[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21506 ) Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. Patch Set 1: Unrelated java test failure: org.apache.kudu.client.TestSecurity. -- To view, visit http://gerrit.cloudera.org:8080/21506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efc2fe6ee7f2dfe94b52b14f1316ffbafd39d52 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 12 Jun 2024 11:25:30 + Gerrit-HasComments: No
[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21506 ) Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efc2fe6ee7f2dfe94b52b14f1316ffbafd39d52 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 12 Jun 2024 11:24:53 + Gerrit-HasComments: No
[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest
Marton Greber has removed a vote on this change. Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I1efc2fe6ee7f2dfe94b52b14f1316ffbafd39d52 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21506 ) Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. Patch Set 1: Code-Review+2 Just to verify, I also ran the problematic test through dist-test: http://dist-test.cloudera.org/job?job_id=root.1718191124.9460 ^ with stress cpu threads, all tests passed. Thanks for fixing this flaky test Alexey! -- To view, visit http://gerrit.cloudera.org:8080/21506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efc2fe6ee7f2dfe94b52b14f1316ffbafd39d52 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 12 Jun 2024 11:24:23 + Gerrit-HasComments: No
[kudu-CR] Include table UUID when using --show table info
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 ) Change subject: Include table UUID when using --show_table_info .. Patch Set 1: (1 comment) Can you also take a look whether this change breaks any of the kudu-tool-tests? http://dist-test.cloudera.org/job?job_id=jenkins-slave.1718036242.523024 In kudu-tool-test.2: "Bad status: Not found: the table does not exist: table_name: "id: name: kudu.table_0"" <- eg is this expected? (i assume in the test we are matching against table name) Thank you! http://gerrit.cloudera.org:8080/#/c/21496/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/21496/1/src/kudu/tools/tool_action_table.cc@123 PS1, Line 123: DEFINE_bool(show_table_info, false, : "Include extra information such as number of tablets, replicas, " : "and live row count for a table in the output"); Can you please extend this description to include the newly added table id? -- To view, visit http://gerrit.cloudera.org:8080/21496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324b920e6feb6139e7d884e3cf08069b0cb922a4 Gerrit-Change-Number: 21496 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 11 Jun 2024 08:33:46 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 ) Change subject: Update build pattern for fetching flaky tests list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21466 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 29 May 2024 08:02:43 + Gerrit-HasComments: No
[kudu-CR] Leader rebalance ignores soft deleted tables
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3 Gerrit-Change-Number: 21411 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Tue, 21 May 2024 09:48:26 + Gerrit-HasComments: No
[kudu-CR] Leader rebalance ignores soft deleted tables
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3 Gerrit-Change-Number: 21411 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 17 May 2024 12:00:07 + Gerrit-HasComments: No
[kudu-CR] Leader rebalance ignores soft deleted tables
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 ) Change subject: Leader rebalance ignores soft deleted tables .. Patch Set 3: Verified+1 Unrelated test failures: asan: alter_table_test.0 tsan: org.apache.kudu.client.TestSecurity -- To view, visit http://gerrit.cloudera.org:8080/21411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3 Gerrit-Change-Number: 21411 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 17 May 2024 11:59:17 + Gerrit-HasComments: No
[kudu-CR] Leader rebalance ignores soft deleted tables
Marton Greber has removed a vote on this change. Change subject: Leader rebalance ignores soft deleted tables .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3 Gerrit-Change-Number: 21411 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai
[kudu-CR] Leader rebalance ignores soft deleted tables
Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/21411 )
Change subject: Leader rebalance ignores soft deleted tables
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc
File src/kudu/master/auto_leader_rebalancer-test.cc:
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer-test.cc@535
PS2, Line 535: TEST_F(LeaderRebalancerTest, TestFilterTrashedTable) {
Could you please add a second test where
FLAGS_leader_rebalancing_ignore_soft_deleted_tables = false?
Just to test both ways.
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/auto_leader_rebalancer.cc@435
PS2, Line 435: catalog_manager_->GetNormalTables(_infos);
Shouldn't the 'leader_rebalancing_ignore_soft_deleted_tables' flag be used here
to decide whether to use GetAllTables() or GetNormalTables() ?
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@875
PS2, Line 875: Retrieve all normal tables, exclud soft deleted tables, not
runnig tables.
nit: (I'm not that familiar in this part of the codebase, and had to lookup
that we dont do any explicit exclusion here, it is a property of
normalized_table_names_map_ that it contains only running and not soft-deleted
tables)
Could you rephrase this, such that it is more clear? Something like:
// Retrieve all tables from the normalized_table_names_map_.
// The normalized_table_names_map_ inherently does not contain
// soft-deleted or not running tables, so no manual exclusion is needed.
http://gerrit.cloudera.org:8080/#/c/21411/2/src/kudu/master/catalog_manager.h@879
PS2, Line 879: GetNormalTables
nit: following up on the above consideration, would it make sense to give a
clearer function name?
Something like: GetActiveTables() ?
--
To view, visit http://gerrit.cloudera.org:8080/21411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3
Gerrit-Change-Number: 21411
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yingchun Lai
Gerrit-Comment-Date: Thu, 16 May 2024 11:38:08 +
Gerrit-HasComments: Yes
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#13). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/13 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 13 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR](gh-pages) gh-pages should not tirgger build
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21404 Change subject: gh-pages should not tirgger build .. gh-pages should not tirgger build Change-Id: I50aaf71ae5bf8a288d8c7347f1fe5ecdb5143654 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21404/1 -- To view, visit http://gerrit.cloudera.org:8080/21404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: I50aaf71ae5bf8a288d8c7347f1fe5ecdb5143654 Gerrit-Change-Number: 21404 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#11). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/11 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 11 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#12). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/12 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 12 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#10). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt A test.txt 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/10 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 10 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#9). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/9 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 9 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR](gh-pages) [blog] Fix typo in blogpost
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21378 ) Change subject: [blog] Fix typo in blogpost .. [blog] Fix typo in blogpost This patch adds a missing space for Backup and Restore heading and uniform some line spacings. Change-Id: Iec743b5151ac9c139d3b3513f99d0369cfe0fc93 Reviewed-on: http://gerrit.cloudera.org:8080/21378 Tested-by: Abhishek Chennaka Reviewed-by: Mahesh Reddy Reviewed-by: Alexey Serbin --- M _posts/2024-03-07-introducing-auto-incrementing-column.md 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Abhishek Chennaka: Verified Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: Iec743b5151ac9c139d3b3513f99d0369cfe0fc93 Gerrit-Change-Number: 21378 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 ) Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Patch Set 1: Code-Review+2 LGTM. nit: http://jenkins.kudu.apache.org/job/build_and_test/523/console -> "All tests passed, yet some left behind their test output." hmm never seen this before, although it is related to webserver-crawl-itest -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Fri, 03 May 2024 08:57:24 + Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has removed a vote on this change. Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 ) Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Fri, 03 May 2024 08:56:34 + Gerrit-HasComments: No
[kudu-CR] [Python] Update dependencies and 3.10 support
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21380 ) Change subject: [Python] Update dependencies and 3.10 support .. [Python] Update dependencies and 3.10 support This patch updates the package dependencies to clearly define the supported Python versions. Previously, supported versions were determined through trial and error (KUDU-2951). With this update, the following versions are now explicitly supported: - Python 2.7 - Python 3.6 to 3.10 (inclusive) This patch adds support for the newer Python versions 3.9 and 3.10. Support for Python versions 3.0 to 3.5 has been discontinued due to dependency complications in this range. However, this decision can be revisited based on community feedback. To re-add support for these versions, use the following marker in `setup.py` and `requirements.txt`: 'python_version >= 3.0, < 3.6'. Testing was conducted manually on: - Ubuntu 20: Python 2.7, Python 3.6 to 3.10 - SLES 15 SP5: Python 3.10 The `setup.py` file has been updated to reflect these changes, ensuring the correct versions are visible on PyPI upon the next release. Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Reviewed-on: http://gerrit.cloudera.org:8080/21380 Tested-by: Marton Greber Reviewed-by: Attila Bukor Reviewed-by: Zoltan Martonka --- M python/requirements.txt M python/setup.py 2 files changed, 29 insertions(+), 34 deletions(-) Approvals: Marton Greber: Verified Attila Bukor: Looks good to me, approved Zoltan Martonka: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21360 ) Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor .. KUDU-3568 Fix budgeting constraint test by enabling preset factor In the failing test TestRowSetCompactionSkipWithBudgetingConstraints the rowset compaction went ahead even with high memory budget requirement (at least as per test expectations). The test bases it memory requirements on number of factor, one of which is rowset_compaction_delta_memory_factor. It is set to a very high value so that node on which test is running is not able to satisfy the memory requirements and hence skipping of compaction becomes necessary. Failure can happen due to a bug in the test where we are using rowset_compaction_delta_memory_factor without setting rowset_compaction_enforce_preset_factor to true. Since rowset_compaction_enforce_preset_factor is set to false by default, which means compaction policy relies on metrics (instead of memory factor) to come up with memory budgeting numbers. The test passes in most runs, because the metrics, (i.e. compact_rs_mem_usage_to_deltas_size_ratio) that compaction policy relies on, happens to be 0. Due to this, memory budgeting logic chooses the rowset_compaction_delta_memory_factor (set to a very high value in this test) as the factor and since the node doesn't have so much memory, it skips compaction as expected. In a nutshell, rowset_compaction_delta_memory_factor is used when when rowset_compaction_enforce_preset_factor is true. If preset is set to false, test will rely on metrics instead of memory factor defined by rowset_compaction_delta_memory_factor. Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6 Reviewed-on: http://gerrit.cloudera.org:8080/21360 Reviewed-by: Attila Bukor Reviewed-by: Zoltan Martonka Tested-by: Marton Greber --- M src/kudu/tablet/compaction-test.cc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Attila Bukor: Looks good to me, approved Zoltan Martonka: Looks good to me, but someone else must approve Marton Greber: Verified -- To view, visit http://gerrit.cloudera.org:8080/21360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6 Gerrit-Change-Number: 21360 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor
Marton Greber has removed a vote on this change. Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6 Gerrit-Change-Number: 21360 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21360 ) Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor .. Patch Set 1: Verified+1 Unrelated test failures, checked manually. -- To view, visit http://gerrit.cloudera.org:8080/21360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6 Gerrit-Change-Number: 21360 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Thu, 02 May 2024 08:07:44 + Gerrit-HasComments: No
[kudu-CR] [Python] Update dependencies and 3.10 support
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21380 ) Change subject: [Python] Update dependencies and 3.10 support .. Patch Set 4: Verified+1 Unrelated test failures(non-python test failures). I've checked that the Python part of the build was green. -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Thu, 02 May 2024 07:21:43 + Gerrit-HasComments: No
[kudu-CR] [Python] Update dependencies and 3.10 support
Marton Greber has removed a vote on this change. Change subject: [Python] Update dependencies and 3.10 support .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] [Python] Update dependencies and 3.10 support
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21380 ) Change subject: [Python] Update dependencies and 3.10 support .. Patch Set 4: (1 comment) Regarding the exact version numbers I've implemented: Python packages are hosted on pypi.org, where each package version contains the supported Python versions. I've just went through all of our packages: -for 2.7 I just searched for the latest version that still supports 2.7, - for 3.x I just looked for a package version that supports 3.6>=, but here I had to make sure that if e.g. Python3.10 is not explicitly shown, our built & test passess, to verfiy everything. I'm planning to update the Kudu Python developer instructions. The above this is pretty standard for Python package management. However I can maybe add info about package management & updates in a future docs patch. http://gerrit.cloudera.org:8080/#/c/21380/4/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/21380/4/python/setup.py@198 PS4, Line 198: ==5.3.2 > Does this need to be: '>=' vs '==': yes your are correct we could use >= in most of the cases, the only place where explicit '==' is the cython package. In the latest patchset pytest-runner is also pinned to an exact version for 2.7. With '==' we have a little bit more stability. However if there is other argument for '>=' I open to changing it, and do more testing. -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Thu, 02 May 2024 07:20:53 + Gerrit-HasComments: Yes
[kudu-CR] [Python] Update dependencies and 3.10 support
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21380 to look at the new patch set (#4). Change subject: [Python] Update dependencies and 3.10 support .. [Python] Update dependencies and 3.10 support This patch updates the package dependencies to clearly define the supported Python versions. Previously, supported versions were determined through trial and error (KUDU-2951). With this update, the following versions are now explicitly supported: - Python 2.7 - Python 3.6 to 3.10 (inclusive) This patch adds support for the newer Python versions 3.9 and 3.10. Support for Python versions 3.0 to 3.5 has been discontinued due to dependency complications in this range. However, this decision can be revisited based on community feedback. To re-add support for these versions, use the following marker in `setup.py` and `requirements.txt`: 'python_version >= 3.0, < 3.6'. Testing was conducted manually on: - Ubuntu 20: Python 2.7, Python 3.6 to 3.10 - SLES 15 SP5: Python 3.10 The `setup.py` file has been updated to reflect these changes, ensuring the correct versions are visible on PyPI upon the next release. Change-Id: I930a15018158563996819fb33d32a3bb5641c396 --- M python/requirements.txt M python/setup.py 2 files changed, 29 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/21380/4 -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Python] Update dependencies and 3.10 support
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21380 to look at the new patch set (#3). Change subject: [Python] Update dependencies and 3.10 support .. [Python] Update dependencies and 3.10 support This patch updates the package dependencies to clearly define the supported Python versions. Previously, supported versions were determined through trial and error (KUDU-2951). With this update, the following versions are now explicitly supported: - Python 2.7 - Python 3.6 to 3.10 (inclusive) This patch adds support for the newer Python versions 3.9 and 3.10. Support for Python versions 3.0 to 3.5 has been discontinued due to dependency complications in this range. However, this decision can be revisited based on community feedback. To re-add support for these versions, use the following marker in `setup.py` and `requirements.txt`: 'python_version >= 3.0, < 3.6'. Testing was conducted manually on: - Ubuntu 20: Python 2.7, Python 3.6 to 3.10 - SLES 15 SP5: Python 3.10 The `setup.py` file has been updated to reflect these changes, ensuring the correct versions are visible on PyPI upon the next release. Change-Id: I930a15018158563996819fb33d32a3bb5641c396 --- M python/requirements.txt M python/setup.py 2 files changed, 29 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/21380/3 -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Python] Update dependencies and 3.10 support
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21380 to look at the new patch set (#2). Change subject: Python] Update dependencies and 3.10 support .. Python] Update dependencies and 3.10 support This patch updates the package dependencies to clearly define the supported Python versions. Previously, supported versions were determined through trial and error (KUDU-2951). With this update, the following versions are now explicitly supported: - Python 2.7 - Python 3.6 to 3.10 (inclusive) This patch adds support for the newer Python versions 3.9 and 3.10. Support for Python versions 3.0 to 3.5 has been discontinued due to dependency complications in this range. However, this decision can be revisited based on community feedback. To re-add support for these versions, use the following marker in `setup.py` and `requirements.txt`: 'python_version >= 3.0, < 3.6'. Testing was conducted manually on: - Ubuntu 20: Python 2.7, Python 3.6 to 3.10 - SLES 15 SP5: Python 3.10 The `setup.py` file has been updated to reflect these changes, ensuring the correct versions are visible on PyPI upon the next release. Change-Id: I930a15018158563996819fb33d32a3bb5641c396 --- M python/requirements.txt M python/setup.py 2 files changed, 29 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/21380/2 -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Python] Update dependencies and 3.10 support
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21380 Change subject: [Python] Update dependencies and 3.10 support .. [Python] Update dependencies and 3.10 support This patch updates the package dependencies to clearly define the supported Python versions. Previously, supported versions were determined through trial and error (KUDU-2951). With this update, the following versions are now explicitly supported: - Python 2.7 - Python 3.6 to 3.10 (inclusive) This patch adds support for the newer Python versions 3.9 and 3.10. Support for Python versions 3.0 to 3.5 has been discontinued due to dependency complications in this range. However, this decision can be revisited based on community feedback. To re-add support for these versions, use the following marker in `setup.py` and `requirements.txt`: 'python_version >= 3.0, < 3.6'. Testing was conducted manually on: - Ubuntu 20: Python 2.7, Python 3.6 to 3.10 - SLES 15 SP5: Python 3.10 The `setup.py` file has been updated to reflect these changes, ensuring the correct versions are visible on PyPI upon the next release. Change-Id: I930a15018158563996819fb33d32a3bb5641c396 --- M python/requirements.txt M python/setup.py 2 files changed, 31 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/21380/1 -- To view, visit http://gerrit.cloudera.org:8080/21380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396 Gerrit-Change-Number: 21380 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] Update build pattern for fetching flaky tests list
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky tests list .. Update build pattern for fetching flaky tests list During the infra changes which happened in the last months, the build_id prefix has been changed [note 1]. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky tests is fetched correctly. [note 1]: The build_id of an isolated test is constructed with Jenkins job's name and build number, prefixed with "jenkins-". To illustrate this let me give some examples, for build_ids prior and after the infra upgrade. Before: jenkins-kudu-gerrit-BUILD_TYPE=ASAN-29232 jenkins-kudu-gerrit-BUILD_TYPE=DEBUG-29227 After: jenkins-build_and_test-64 jenkins-build_and_test-63 >From the above we can see that the new Jenkins job name caused the issue. The new job is parametrised, does not contain the build type in the job's name. Therefore, a change in the naming is justified. In case something like this happens in the future, the build_ids can be observed in the test_results MySQL database on the isolateserver test infra host. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Reviewed-on: http://gerrit.cloudera.org:8080/21327 Reviewed-by: Ashwani Raina Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M build-support/jenkins/build-and-test.sh 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Ashwani Raina: Looks good to me, but someone else must approve Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky tests list
Hello Zoltan Chovan, Alexey Serbin, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#5). Change subject: Update build pattern for fetching flaky tests list .. Update build pattern for fetching flaky tests list During the infra changes which happened in the last months, the build_id prefix has been changed [note 1]. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky tests is fetched correctly. [note 1]: The build_id of an isolated test is constructed with Jenkins job's name and build number, prefixed with "jenkins-". To illustrate this let me give some examples, for build_ids prior and after the infra upgrade. Before: jenkins-kudu-gerrit-BUILD_TYPE=ASAN-29232 jenkins-kudu-gerrit-BUILD_TYPE=DEBUG-29227 After: jenkins-build_and_test-64 jenkins-build_and_test-63 >From the above we can see that the new Jenkins job name caused the issue. The new job is parametrised, does not contain the build type in the job's name. Therefore, a change in the naming is justified. In case something like this happens in the future, the build_ids can be observed in the test_results MySQL database on the isolateserver test infra host. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/5 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky tests list
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky tests list .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh@42 PS4, Line 42: jenkins j > nit: Change here as well? Done http://gerrit.cloudera.org:8080/#/c/21327/4/build-support/jenkins/build-and-test.sh@190 PS4, Line 190: jenkins > For my understanding or maybe posterity, where was build_id prefix changed Added more details to the commit message. -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 19 Apr 2024 13:09:36 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21327 ) Change subject: Update build pattern for fetching flaky test list .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@186 PS2, Line 186: because > nit: because Done http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@187 PS2, Line 187: As > nit: As Done http://gerrit.cloudera.org:8080/#/c/21327/2/build-support/jenkins/build-and-test.sh@188 PS2, Line 188: Any > nit: Any Done -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Thu, 18 Apr 2024 11:18:14 + Gerrit-HasComments: Yes
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#4). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/4 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Ashwani Raina, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#3). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/3 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky test list
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21327 to look at the new patch set (#2). Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/2 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Update build pattern for fetching flaky test list
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21327 Change subject: Update build pattern for fetching flaky test list .. Update build pattern for fetching flaky test list During the infra changes which happened in the last months, the build_id prefix has been changed unintentionally. As a result flaky tests are not retried during testing in the pre-commit runs. This patch updates the build pattern in the build-and-test.sh script, such that the list of flaky test can be fetched correctly. Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f --- M build-support/jenkins/build-and-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21327/1 -- To view, visit http://gerrit.cloudera.org:8080/21327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f Gerrit-Change-Number: 21327 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#8). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/8 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#6). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/6 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#7). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/7 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#5). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/5 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: recheck -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 21:22:31 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: recheck -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 20:07:22 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:57:27 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:54:55 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:32:49 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 4: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:29:06 + Gerrit-HasComments: No
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#4). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/4 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 3: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:16:38 + Gerrit-HasComments: No
[kudu-CR] test
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 3: jenkins-test -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 16 Apr 2024 15:01:56 + Gerrit-HasComments: No
[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try)
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) .. Patch Set 6: Just a clarifying question, so the only thing changed compared to the 1st revision of this patch is that lz4 is switched out for snappy? -> only changes in thirdparty/build-definitions.sh ? Thanks for debugging the issue! -- To view, visit http://gerrit.cloudera.org:8080/21075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b7d2a16802af01a382a1d74cd9869baf364688 Gerrit-Change-Number: 21075 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 19 Mar 2024 13:06:30 + Gerrit-HasComments: No
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#2). Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/2 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] test
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21132 Change subject: test .. test Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/1 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Reviewed-on: http://gerrit.cloudera.org:8080/21027 Reviewed-by: Zoltan Chovan Reviewed-by: Marton Greber Tested-by: Marton Greber --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) Approvals: Zoltan Chovan: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Wed, 14 Feb 2024 12:59:09 + Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has removed a vote on this change. Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Wed, 14 Feb 2024 12:58:50 + Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 7: > Patch Set 7: > > > > Patch Set 6: Code-Review+2 > > > > > > > Patch Set 6: Code-Review+2 > > > > > > > > It seems Yingchun on a 10-day vacation, so awaiting +2 from him > > on this patch soon isn't viable. > > > > > > > > From what I can see, he wasn't against reverting this patch > > temporarily, at least that's what he mentioned in a Slack chat: > > > > > > > > > > > > Alexey Serbin > > > > 9:16 AM > > > > Thanks a lot, Yingchun! If you aren't able to resolve it > > shortly, are you OK with temporarily rollick back the change if > > it's indeed breaks a few things? Just in case, though (I hope we > > can fix the issues quite soon, though). > > > > > > > > Yingchun Lai > > > > 9:34 AM > > > > Sorry about this, I'll revert it tomorrow temporarily. > > > > > > Yes, Alexey and Marton have informed me about this issue, feel > > free to revert it if you found serious issues, I'm on a vacation > > and have not much time to take care about this. > > > > > > It would be nice if you provide more issue details, it's helpful > > for troubleshooting and fixing it, thanks. > > > > Thanks for the info, will do some troubleshooting. > > Just wanted to get a green build on the revert, but failed to do > > so. > > Thats why I havent submitted the revert yet. > > I'm going to dig around today to find out if these are just flakies > > in the above failed runs, or another patch is the culprit. > > Things are little bit slow as the flaky dashboard is also not > > functioning. > > Will keep this thread posted. > > In my case, dist-test failed with SIGILL while trying to run many test > binaries with this patch. Once I reverted this patch, no failures due to > SIGILL, and most times all tests passes. That was when I compiled Kudu tests > in DEBUG configuration on CentOS 7.9 Thanks for the details! Verified the same. Submitting the revert. -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Wed, 14 Feb 2024 12:56:24 + Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: > Patch Set 6: Code-Review+2 > > > Patch Set 6: Code-Review+2 > > > > It seems Yingchun on a 10-day vacation, so awaiting +2 from him on this > > patch soon isn't viable. > > > > From what I can see, he wasn't against reverting this patch temporarily, at > > least that's what he mentioned in a Slack chat: > > > > > > Alexey Serbin > > 9:16 AM > > Thanks a lot, Yingchun! If you aren't able to resolve it shortly, are you > > OK with temporarily rollick back the change if it's indeed breaks a few > > things? Just in case, though (I hope we can fix the issues quite soon, > > though). > > > > Yingchun Lai > > 9:34 AM > > Sorry about this, I'll revert it tomorrow temporarily. > > Yes, Alexey and Marton have informed me about this issue, feel free to revert > it if you found serious issues, I'm on a vacation and have not much time to > take care about this. > > It would be nice if you provide more issue details, it's helpful for > troubleshooting and fixing it, thanks. Thanks for the info, will do some troubleshooting. Just wanted to get a green build on the revert, but failed to do so. Thats why I havent submitted the revert yet. I'm going to dig around today to find out if these are just flakies in the above failed runs, or another patch is the culprit. Things are little bit slow as the flaky dashboard is also not functioning. Will keep this thread posted. -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Tue, 13 Feb 2024 09:00:58 + Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21027 to look at the new patch set (#6). Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/6 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21027 to look at the new patch set (#5). Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/5 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21027 to look at the new patch set (#4). Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/4 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21027 to look at the new patch set (#3). Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/3 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21027 to look at the new patch set (#2). Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/2 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21027 to review the following change. Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" This reverts commit 58d2338de8d586106ea29cfa281ee653392a9145. Reason for revert: constant Jenkins failures for the last week+. Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c --- M src/kudu/benchmarks/CMakeLists.txt M src/kudu/client/CMakeLists.txt M src/kudu/consensus/CMakeLists.txt M src/kudu/fs/CMakeLists.txt M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/data_dirs.cc M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/dir_util.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/fs_report.cc M src/kudu/fs/fs_report.h M src/kudu/fs/log_block_manager-test-util.cc M src/kudu/fs/log_block_manager-test-util.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/server/CMakeLists.txt M src/kudu/tablet/compaction-test.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/CMakeLists.txt M thirdparty/build-definitions.sh 32 files changed, 185 insertions(+), 1,782 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21027/1 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"
Marton Greber has created a revert of this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Uploaded patch set 1. -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: revert Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR](branch-1.17.x) KUDU-3535 Clear log cache while tombstoning a tablet replica.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21017 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I6cf545e604f80d41e7ebd9660acfd2e928cd27a9 Gerrit-Change-Number: 21017 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Song Jiacheng Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Thu, 08 Feb 2024 09:25:51 + Gerrit-HasComments: No
[kudu-CR] [log block manager-test] Improve random selection
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 9: Code-Review+1 LGTM, lets get a green build and I'll +2 it. -- To view, visit http://gerrit.cloudera.org:8080/20899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f73f0572319784b07845b02d15a7d3e6f31abce Gerrit-Change-Number: 20899 Gerrit-PatchSet: 9 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 06 Feb 2024 16:33:46 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Scan Resistant Caching
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 8: (2 comments) +1 on what Alexey was proposing, spliting up the changelist into smaller chunks. http://gerrit.cloudera.org:8080/#/c/20607/8/src/kudu/util/block_cache_metrics.h File src/kudu/util/block_cache_metrics.h: PS8: > Why is it necessary to update the block cache metrics in the same changelis +1 http://gerrit.cloudera.org:8080/#/c/20607/8/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/20607/8/src/kudu/util/cache.h@67 PS8, Line 67: // Recency list cache implementations (FIFO, LRU, etc.) > Is it possible to separate out this and other refactoring (i.e. moving dupl +1 -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 8 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 06 Feb 2024 13:21:02 + Gerrit-HasComments: Yes
[kudu-CR] [rpc] validate security-related parameters earlier
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20961 ) Change subject: [rpc] validate security-related parameters earlier .. Patch Set 1: Would it makes sense to add a basic test, to verify that the verification works as intended? -- To view, visit http://gerrit.cloudera.org:8080/20961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04 Gerrit-Change-Number: 20961 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 06 Feb 2024 13:17:01 + Gerrit-HasComments: No
[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 Did verify that the provided test fails without this fix. Thanks for taking care of this issue! -- To view, visit http://gerrit.cloudera.org:8080/20990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 20990 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 06 Feb 2024 13:07:27 + Gerrit-HasComments: No
[kudu-CR] KUDU-3543 Fix Content-Type headers
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@9 PS2, Line 9: This patch addresses an issue with the webserver's the Content-Headers. : The problem is that in the webserver's path handler functions we only : use a bool called 'is_styled' to decide on the style mode [1]. : This patch basically replaces the 'is_styled > What way commit 1e7d1b3d1 is related to the essence of this refactoring? I I just wanted to elaborate that the implementation worked until we had onlye 'text/plain' and 'text/html' (boolean choice). But with the added 3rd Content-Type header, we need to pipe the StyleMode enum to handle all the cases. (I guess my brain went faster than my hands, anyway removed this part) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@16 PS2, Line 16: ebserver.cc#L671-L672 : > Could you please separate this into its own patch? It would be much easier Makes sense. Did split up the patch. The new rev only contains the refactor part. http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h@36 PS2, Line 36: #define SKIP_IF_SLOW_NOT_ > 'using' in header files in a well known no-no in C++. Done -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Jan 2024 16:56:17 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3543 Fix Content-Type headers
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20868 to look at the new patch set (#3). Change subject: KUDU-3543 Fix Content-Type headers .. KUDU-3543 Fix Content-Type headers This patch addresses an issue with the webserver's the Content-Headers. The problem is that in the webserver's path handler functions we only use a bool called 'is_styled' to decide on the style mode [1]. This patch basically replaces the 'is_styled' bool with the StyleMode enum entirely. I added test cases to check the Content-Type headers of Master and TServer endpoints. [1] https://github.com/apache/kudu/blob/master/src/kudu/server/webserver.cc#L671-L672 Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f --- M src/kudu/master/master-test.cc M src/kudu/master/master_path_handlers.cc M src/kudu/server/default_path_handlers.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/server/rpcz-path-handler.cc M src/kudu/server/startup_path_handler.cc M src/kudu/server/tracing_path_handlers.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/util/jwt-util-test.cc M src/kudu/util/mini_oidc.cc M src/kudu/util/test_util.h M src/kudu/util/thread.cc M src/kudu/util/web_callback_registry.h 16 files changed, 218 insertions(+), 82 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/20868/3 -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3543 Fix Content-Type headers
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20868 to look at the new patch set (#2). Change subject: KUDU-3543 Fix Content-Type headers .. KUDU-3543 Fix Content-Type headers Commit 1e7d1b3d117ca137bdce3d2ec549416d242bdd02 introduced a newly supported Content-Type: application/octet-stream. The problem is that in the webserver's path handler functions we only use a bool called 'is_styled' to decide on the style mode [1]. This patch basically replaced the 'is_styled' bool with the StyleMode enum entirely. Moreover, there were pages which should have been of Content-Type: application/json: /metrics, /rpcz, the /tracing/json/... pages. I took the liberty to add the JSON Content-Type and fix these as well. Finally, I added test cases to check the Content-Type headers of Master and TServer endpoints. [1] https://github.com/apache/kudu/blob/master/src/kudu/server/webserver.cc#L671-L672 Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f --- M src/kudu/master/master-test.cc M src/kudu/master/master_path_handlers.cc M src/kudu/server/default_path_handlers.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/server/rpcz-path-handler.cc M src/kudu/server/startup_path_handler.cc M src/kudu/server/tracing_path_handlers.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/util/jwt-util-test.cc M src/kudu/util/mini_oidc.cc M src/kudu/util/test_util.h M src/kudu/util/thread.cc M src/kudu/util/web_callback_registry.h 16 files changed, 255 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/20868/2 -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] KUDU-3543 Fix Content-Type headers
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20868 Change subject: KUDU-3543 Fix Content-Type headers .. KUDU-3543 Fix Content-Type headers Commit 1e7d1b3d117ca137bdce3d2ec549416d242bdd02 introduced a newly supported Content-Type: application/octet-stream. The problem is that in the webserver's path handler functions we only use a bool called 'is_styled' to decide on the style mode [1]. This patch basically replaced the 'is_styled' bool with the StyleMode enum entirely. Moreover, there were pages which should have been of Content-Type: application/json: /metrics, /rpcz, the /tracing/json/... pages. I took the liberty to add the JSON Content-Type and fix these as well. Finally, I added test cases to check the Content-Type headers of Master and TServer endpoints. [1] https://github.com/apache/kudu/blob/master/src/kudu/server/webserver.cc#L671-L672 Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f --- M src/kudu/master/master-test.cc M src/kudu/master/master_path_handlers.cc M src/kudu/server/default_path_handlers.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/server/rpcz-path-handler.cc M src/kudu/server/startup_path_handler.cc M src/kudu/server/tracing_path_handlers.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/util/jwt-util-test.cc M src/kudu/util/mini_oidc.cc M src/kudu/util/test_util.h M src/kudu/util/thread.cc M src/kudu/util/web_callback_registry.h 16 files changed, 254 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/20868/1 -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 ) Change subject: Add blog post about Prometheus/Grafana .. Patch Set 1: Thanks everyone for the reviews! I also think it makes sense to first implement the SD: KUDU-3538. I will do that, once it is merged I will circle back to update the blog post. -- To view, visit http://gerrit.cloudera.org:8080/20814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f Gerrit-Change-Number: 20814 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Wed, 03 Jan 2024 16:50:50 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20814 Change subject: Add blog post about Prometheus/Grafana .. Add blog post about Prometheus/Grafana While the review is ongoing I'm hosting this patch on my GitHub page: https://martongreber.github.io/2023/12/18/kudu-prometheus-grafana.html Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f --- A _posts/2023-12-18-kudu-prometheus-grafana.md A img/2023-12-18-kudu-prometheus-grafana/master-tserver-memory.png A img/2023-12-18-kudu-prometheus-grafana/metrics-explorer.png A img/2023-12-18-kudu-prometheus-grafana/prometheus-targets.png 4 files changed, 176 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/1 -- To view, visit http://gerrit.cloudera.org:8080/20814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f Gerrit-Change-Number: 20814 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.
Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java
client.
..
Patch Set 11:
(2 comments)
Thanks for adding the requested test!
Just to be picky, I changed back the line which was causing the error:
@@ -1325,7 +1325,8 @@ public class AsyncKuduClient implements AutoCloseable {
// Important to increment the attempts before the next if statement since
// getSleepTimeForRpc() relies on it if the client is null or dead.
nextRequest.attempt++;
-final ServerInfo info = tablet.getTabletServerByUuid(scanner.getTsUUID());
+final ServerInfo info =
tablet.getReplicaSelectedServerInfo(nextRequest.getReplicaSelection(),
+location);
Build and run the test, but I dont get any errors. Did I miss something?
Just wanna make sure that the test fails - repros the issue.
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@636
PS11, Line 636: Restart
nit: Step down
right? ie the command you are building below is kudu tablet leader_step_down
http://gerrit.cloudera.org:8080/#/c/20715/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@657
PS11, Line 657: LOG.debug("Scaned " + kuduScanner.nextRows().numRows);
Rather than just logging it, could you please add assertions, that we dont get
'scanner not found' error?
--
To view, visit http://gerrit.cloudera.org:8080/20715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2
Gerrit-Change-Number: 20715
Gerrit-PatchSet: 11
Gerrit-Owner: Song Jiacheng
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber
Gerrit-Reviewer: Song Jiacheng
Gerrit-Comment-Date: Tue, 12 Dec 2023 13:52:51 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3496 support spnego dedicated keytab
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 6: > Patch Set 6: > > @Marton Greber > > I Finally found that the reason why the webserver-test has failed on MacOS. > > It is because MacOS uses Heimdal kerberos implementation which is kind of > different from MIT kerberos implementation. > > I was able to notice that by checking test log files. In both kerberos > implementations, setting 'KRB5_TRACE' env variable as stderr(/dev/stderr) > provided me the detailed process of GSSAPI. For the case of CentOS which uses > MIT kerberos, the test log left successful negotiation process on each unit > test case. On the other hand, the test log for MacOS did not. All the TGS > Requests were sent to kdc with wrong port number except the first unit test > case. All the unit test cases use same kdc port number that is used in the > first test case so that only first test case can be passed and others can't > not. > > In my opinion, Heimdal kerberos implementation caches a port number > somewhere. I tried to find how to totally purge the cache but i couldn't. > > I think we need a work-around that skips some tests on MacOS like what > negotiation-test've done > (https://github.com/apache/kudu/blob/ae7b08c006167da1ebb0c4302e5d6d7aa739a862/src/kudu/rpc/negotiation-test.cc#L1399-L1402) > > What do you think? Thank you very much for investigating the issue and getting to the bottom of it! In this case I think it is reasonable to use #ifndef __APPLE__ for the test. Since your explanation is longer what I would except in source code comments, I think your could put your findings into a new jira ticket. Then add just the essence of the issue into the source code as comment, with the corresponding jira number, and maybe a TODO. -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 6 Gerrit-Owner: Halim Kim Gerrit-Reviewer: Halim Kim Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 12 Dec 2023 12:51:01 + Gerrit-HasComments: No
[kudu-CR] KUDU-3526 [java] Scanner should bound with a tserver in java client.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bound with a tserver in java client. .. Patch Set 7: (4 comments) I wanted to ask for a test, just to encapsulate the initial problem, when the leader changes. I did a quick search, and found one Java test, which uses leader_step_down: https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java#L241-L263 Using this example, do you think you can add a test which reproduceses the original issue? Thanks! http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@9 PS7, Line 9: by java nit: by the Java http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@10 PS7, Line 10: does not bound with the : tserver which it first communicates with. nit: is not bound to the tserver with which it first communicates. http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@16 PS7, Line 16: response nit: respond http://gerrit.cloudera.org:8080/#/c/20715/7//COMMIT_MSG@19 PS7, Line 19: We should make the scanner bound with the tserver, like how it does : in c++ client. nit: We should bind the scanner to the tserver, similar to how it is done in the C++ client. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 21 Nov 2023 11:38:52 + Gerrit-HasComments: Yes
[kudu-CR] [duplication] KUDU-3290 Support write ops to kafka with kafka client
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19909 ) Change subject: [duplication] KUDU-3290 Support write ops to kafka with kafka client .. Patch Set 8: > Patch Set 8: > > (1 comment) That makes sense. Let me skin through the duplication doc again, and I will start a conversation on the mailing list. Thanks Alexey for the direction! -- To view, visit http://gerrit.cloudera.org:8080/19909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbd5738a61d2521b363c628f88e3699879920a49 Gerrit-Change-Number: 19909 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Mon, 13 Nov 2023 10:34:20 + Gerrit-HasComments: No
[kudu-CR] KUDU-3496 support spnego dedicated keytab
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 6: Overall looks good to me, thanks for adding tests! There is a macOS test issue on my end: Running the webserver-test fails with: SpnegoWebserverTest.TestAuthenticated However if I run this test individually, it runs successfully. If you have a macOS station, could you please check this issue out?(maybe its just an env issue on my end) If you don't have access to macOS station, let me know, and I can help look into this. -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 6 Gerrit-Owner: Halim Kim Gerrit-Reviewer: Halim Kim Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 Nov 2023 07:06:16 + Gerrit-HasComments: No
[kudu-CR] KUDU-3519: List masters in /dump-entities
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20628 ) Change subject: KUDU-3519: List masters in /dump-entities .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92ab8057c5bdae6e8b41afc8f19c0a72cfa329a2 Gerrit-Change-Number: 20628 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 12:30:48 + Gerrit-HasComments: No
[kudu-CR] KUDU-3519: List masters in /dump-entities
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20628 ) Change subject: KUDU-3519: List masters in /dump-entities .. Patch Set 1: (1 comment) Overall looks good to me, thanks for the patch! Did download and build the patch, checked manually that the endpoint displays the masters. To avoid this manual process, could you please add a test in 'TEST_F(MasterTest, TestRegisterAndHeartbeat)' similar to: https://github.com/apache/kudu/blob/master/src/kudu/master/master-test.cc#L632-L655 Just to have basic sanity checks? Thank you! http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc@780 PS1, Line 780: use_externa-addr nit: use_external_addr -- To view, visit http://gerrit.cloudera.org:8080/20628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92ab8057c5bdae6e8b41afc8f19c0a72cfa329a2 Gerrit-Change-Number: 20628 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Thu, 26 Oct 2023 14:51:56 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3496 support spnego dedicated keytab
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 3: > Patch Set 3: > > (2 comments) I'm thinking that a test similar to: https://github.com/apache/kudu/blob/master/src/kudu/server/webserver-test.cc#L246-L251 with the addition of using the dedicated keytab. Some pointers: We have webserver-test.cc where we have spnego related tests: https://github.com/apache/kudu/blob/master/src/kudu/server/webserver-test.cc#L200C1-L252C1 This uses the MiniKdc: https://github.com/apache/kudu/blob/master/src/kudu/security/test/mini_kdc.h Where you can create keytab: https://github.com/apache/kudu/blob/master/src/kudu/security/test/mini_kdc.cc#L263-L278 For further details on how to deal with kdc, the mini_kdc-test is a good starting point: https://github.com/apache/kudu/blob/master/src/kudu/security/test/mini_kdc-test.cc Hope this helps! -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 3 Gerrit-Owner: Halim Kim Gerrit-Reviewer: Halim Kim Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 17 Oct 2023 11:03:41 + Gerrit-HasComments: No
[kudu-CR] KUDU-3496 support spnego dedicated keytab
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 ) Change subject: KUDU-3496 support spnego dedicated keytab .. Patch Set 3: Thank you for the contribution! Couple things: * could you please consider if its possible add some tests to cover the functionality? * I saw in the Impala change you provided detailed commit message. Could you please do the same for the Kudu change as well? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 3 Gerrit-Owner: Halim Kim Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 11 Oct 2023 14:25:01 + Gerrit-HasComments: No
[kudu-CR] [gutil] fix ASAN warning in CountOnes()
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20558 ) Change subject: [gutil] fix ASAN warning in CountOnes() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa Gerrit-Change-Number: 20558 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 13:05:30 + Gerrit-HasComments: No
[kudu-CR] [Python] KUDU-3351 Add write op metrics
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20526 ) Change subject: [Python] KUDU-3351 Add write op metrics .. Patch Set 4: (1 comment) > Patch Set 3: Code-Review+1 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/20526/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/20526/3/python/kudu/client.pyx@1752 PS3, Line 1752: > Leave 2 empty lines between classes. Done -- To view, visit http://gerrit.cloudera.org:8080/20526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9 Gerrit-Change-Number: 20526 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 13:02:27 + Gerrit-HasComments: Yes
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 ) Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx@3201 PS3, Line 3201: del self.op > Please follow standard python blank line conventions as rest of the file do Done http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py@530 PS3, Line 530: # successful_upsers++, upsert_ignore_errors++ > nit: remove the extra blank line. Done -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 11 Oct 2023 13:02:50 + Gerrit-HasComments: Yes
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Hello Alexey Serbin, Zoltan Martonka, Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20527 to look at the new patch set (#5). Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 139 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/20527/5 -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [Python] KUDU-3351 Add write op metrics
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20526 to look at the new patch set (#4). Change subject: [Python] KUDU-3351 Add write op metrics .. [Python] KUDU-3351 Add write op metrics This is a follow-up patch for commit: 0ddcaaabc97c85a4715ae79ff5604feb9b342779, adding per-session write op metrics to the Python client. In the test function "test_insert_and_mutate_rows" I added verification function calls, to check that the metrics are gathered properly. Only "upsert_ignore_errors" is left out, as UPSERT IGNORE is not yet supported by the Python client. I'm planning to address that in the next patch. Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9 --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/common.py M python/kudu/tests/test_client.py 4 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/20526/4 -- To view, visit http://gerrit.cloudera.org:8080/20526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9 Gerrit-Change-Number: 20526 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [build] bootsreap-dev-env python fix for ubuntu 22.04
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 ) Change subject: [build] bootsreap-dev-env python fix for ubuntu 22.04 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/20559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c Gerrit-Change-Number: 20559 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 11 Oct 2023 10:53:31 + Gerrit-HasComments: No
[kudu-CR] [thirpdarty] upgrade gperftools to 2.13
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20545 ) Change subject: [thirpdarty] upgrade gperftools to 2.13 .. Patch Set 1: Code-Review+1 Tested on M1 mac: * third party build: good * Kudu debug build: good * starting local cluster, running Python example: good LGTM. -- To view, visit http://gerrit.cloudera.org:8080/20545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4916bf64ea90bb148e0abf31779106a57061a15 Gerrit-Change-Number: 20545 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Sat, 07 Oct 2023 15:04:29 + Gerrit-HasComments: No
[kudu-CR] [thirpdarty] upgrade gperftools to 2.13
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20545 ) Change subject: [thirpdarty] upgrade gperftools to 2.13 .. Patch Set 1: (1 comment) I'm running a clean third party build on M1 mac, just to double check. Other than that one comment, if the build goes through, it looks good to me! http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch File thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch: http://gerrit.cloudera.org:8080/#/c/20545/1/thirdparty/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch@1 PS1, Line 1: commit 8f04cffe25ca339841ce0ac67c98bb9a74caa9fc Could you touch upon the changes in this patch file? (is it a rebase, or manual edits?) -- To view, visit http://gerrit.cloudera.org:8080/20545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4916bf64ea90bb148e0abf31779106a57061a15 Gerrit-Change-Number: 20545 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Sat, 07 Oct 2023 14:31:53 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] build gperftools with libunwind support
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20544 ) Change subject: [thirdparty] build gperftools with libunwind support .. Patch Set 4: Code-Review+1 LGTM, thanks for taking care of this! -- To view, visit http://gerrit.cloudera.org:8080/20544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59b307e3ee3ff9464934ef60ca439dcfcd496a2c Gerrit-Change-Number: 20544 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Sat, 07 Oct 2023 09:43:04 + Gerrit-HasComments: No
[kudu-CR] [Python] KUDU-3351 Add write op metrics
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20526 to look at the new patch set (#3). Change subject: [Python] KUDU-3351 Add write op metrics .. [Python] KUDU-3351 Add write op metrics This is a follow-up patch for commit: 0ddcaaabc97c85a4715ae79ff5604feb9b342779, adding per-session write op metrics to the Python client. In the test function "test_insert_and_mutate_rows" I added verification function calls, to check that the metrics are gathered properly. Only "upsert_ignore_errors" is left out, as UPSERT IGNORE is not yet supported by the Python client. I'm planning to address that in the next patch. Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9 --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/common.py M python/kudu/tests/test_client.py 4 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/20526/3 -- To view, visit http://gerrit.cloudera.org:8080/20526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id76f8f0cb11ef5e4b9d06508a39492bc6b0109a9 Gerrit-Change-Number: 20526 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Python] KUDU-3353 add support for UPSERT IGNORE
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20527 to look at the new patch set (#2). Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE .. [Python] KUDU-3353 add support for UPSERT IGNORE This patch is a follow-up to commit: ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0, it adds UPSERT IGNORE support to the Python client. Extended the already existing tests: * added write op metrics verification for immutable column tests, * extended immutable column tests with UPSERT IGNORE test, * addressed an UPSERT IGNORE TODO in the auto-incrementing column tests. Change-Id: I9112b96a5688287352307c05e60030a217154cbd --- M python/kudu/__init__.py M python/kudu/client.pyx M python/kudu/libkudu_client.pxd M python/kudu/tests/test_client.py 4 files changed, 137 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/20527/2 -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120)
