Re: Review Request 36847: Added HTTP Delete Method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95410 --- Ship it! Ship It! - Bernd Mathiske On Aug. 13, 2015, 9:19 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 13, 2015, 9:19 a.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3152 https://issues.apache.org/jira/browse/MESOS-3152 Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/include/process/http.hpp b829dad9d1c5d98f09a3a3c7cc04e7659f6616a4 3rdparty/libprocess/src/http.cpp b70e2fa0f500216c15f20907816874b9486826b8 3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 37475: Fixed a wrong comparison.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/#review95412 --- Patch looks great! Reviews applied: [37475] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 10:21 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/ --- (Updated Aug. 14, 2015, 10:21 a.m.) Review request for mesos and Till Toenshoff. Repository: mesos Description --- Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison. Diffs - src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491 Diff: https://reviews.apache.org/r/37475/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:29 a.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Changes --- address review comments from Bernd and Joerg Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs (updated) - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95411 --- Ship it! src/tests/fault_tolerance_tests.cpp (line 1834) https://reviews.apache.org/r/37443/#comment150348 Line length is 81 characters. src/tests/fault_tolerance_tests.cpp (line 1866) https://reviews.apache.org/r/37443/#comment150349 Line length is 81 characters. - Alexander Rojas On Aug. 14, 2015, 1:29 p.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 1:29 p.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review95396 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416, 37442, 37460, 37462, 37466] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 3:39 a.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 14, 2015, 3:39 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2834 https://issues.apache.org/jira/browse/MESOS-2834 Repository: mesos Description --- Update perf tests to including testing the supported perf output formats. Diffs - src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95393 --- Patch looks great! Reviews applied: [37414] All tests passed. - Mesos ReviewBot On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/ --- (Updated Aug. 13, 2015, 4:49 p.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-1013 https://issues.apache.org/jira/browse/MESOS-1013 Repository: mesos Description --- Fix flaky ExamplesTest.JavaLog Diffs - src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56 Diff: https://reviews.apache.org/r/37414/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 37471: Fix EventCallFramework test to not ignore heartbeat events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37471/#review95392 --- Ship it! Ship It! - Vinod Kone On Aug. 14, 2015, 5:54 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37471/ --- (Updated Aug. 14, 2015, 5:54 a.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- See summary and related CR Diffs - src/examples/event_call_framework.cpp 019e5c1f19a9e455b73ea9916b4f4270dad6d3da Diff: https://reviews.apache.org/r/37471/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 14, 2015, 8:17 a.m.) Review request for mesos and Joris Van Remoortere. Changes --- Updated the interface of the `wait()` method, and refined some of the control flow. Summary (updated) - [WIP] Added `wait()` method to process::Subprocess Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description (updated) --- Jira: MESOS-3035 The original API for `process::Subprocess` still left a lot of legwork to do for the caller; we have now added a `wait(Duration timeout)` method that returns a `CommandResult` (also introduced with this patch) which contains useful information about the command invocation; the exit code; stdout and, optionally, stderr too. The `wait()` method will wait for both the process to terminate, and stdout/stderr to be available to read from; it also unpacks them into ready-to-use `string`s. This is still WIP as I'm seeing some unusual behavior and I'd like to discuss with someone more expert on libprocess. Diffs (updated) - 3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/subprocess.cpp d6ea62ed1c914d34e0e189395831c86fff8aac22 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio
Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 14, 2015, 8:20 a.m.) Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description --- Jira: MESOS-3035 The original API for `process::Subprocess` still left a lot of legwork to do for the caller; we have now added a `wait(Duration timeout)` method that returns a `CommandResult` (also introduced with this patch) which contains useful information about the command invocation; the exit code; stdout and, optionally, stderr too. The `wait()` method will wait for both the process to terminate, and stdout/stderr to be available to read from; it also unpacks them into ready-to-use `string`s. This is still WIP as I'm seeing some unusual behavior and I'd like to discuss with someone more expert on libprocess. Diffs (updated) - 3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/subprocess.cpp d6ea62ed1c914d34e0e189395831c86fff8aac22 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio
Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95405 --- Patch looks great! Reviews applied: [37415] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 4:56 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/ --- (Updated Aug. 14, 2015, 4:56 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-830 https://issues.apache.org/jira/browse/MESOS-830 Repository: mesos Description --- Fix flaky ExamplesTest.JavaFramework Diffs - src/examples/java/TestFramework.java 265005b9d1a6a053b812c133a4817c3d9e61179e Diff: https://reviews.apache.org/r/37415/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaFramework bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 37427: Docker registry: adding TokenManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 14, 2015, 2:43 p.m.) Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. Changes --- build fix. Repository: mesos Description --- Changes: - Added Token implementation (RFC 7519). - Added TokenManager implementation. This component keeps a cache of tokens requested for any future requests. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37427/diff/ Testing --- make check. Thanks, Jojy Varghese
Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37488/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Fix cgroup CHECK failure cases test harness to abort. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37488/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for mesos and Jie Yu. Changes --- Split review into two changes. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs (updated) - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37489: Make scheduler tests parameterized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 14, 2015, 8:23 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Added missing makefile include. This should make distcheck happy Repository: mesos Description --- This change makes scheduler tests parameterized. - I had to disable SchedulerTests.KillTask due to the JSON encoding issue till we fix it. I can un-parameterize it for now too ? - Moved the ContentType/output overload operators to include/mesos/http.hpp Diffs (updated) - include/mesos/http.hpp PRE-CREATION include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37488/#review95464 --- Patch looks great! Reviews applied: [37488] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 5:41 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37488/ --- (Updated Aug. 14, 2015, 5:41 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Fix cgroup CHECK failure cases test harness to abort. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37488/diff/ Testing --- sudo make check Thanks, Paul Brett
Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Review Request 37491: Added a trivial test on how the protobuf-json string don't match due to incorrect escaping of bytes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3263 https://issues.apache.org/jira/browse/MESOS-3263 Repository: mesos Description --- Added a test to show how converting a protobuf having a byte field to json fails due to the bytes not being escaped correctly. The test is currently disabled. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37491/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37427: Docker registry: adding TokenManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 14, 2015, 5:28 p.m.) Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. Changes --- fixing build part 2. Repository: mesos Description --- Changes: - Added Token implementation (RFC 7519). - Added TokenManager implementation. This component keeps a cache of tokens requested for any future requests. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37427/diff/ Testing --- make check. Thanks, Jojy Varghese
Review Request 37487: Fixed flaky HTTPTest.NestedGet test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37487/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3262 https://issues.apache.org/jira/browse/MESOS-3262 Repository: mesos Description --- Turns out the test was directly calling methods on HttpProcess instead of dispatching to it. Added routes for /a/b/c and /a handlers in initialize like we did with all the other handlers. Diffs - 3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab Diff: https://reviews.apache.org/r/37487/diff/ Testing --- Ran the test in a loop 10K times. Thanks, Vinod Kone
Review Request 37489: Make scheduler tests parameterized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- This change makes scheduler tests parameterized. - I had to disable SchedulerTests.KillTask due to the JSON encoding issue till we fix it. I can un-parameterize it for now too ? - Moved the ContentType/output overload operators to include/mesos/http.hpp Diffs - include/mesos/http.hpp PRE-CREATION include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37382: Introduced provisioner Backend interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- src/slave/containerizer/provisioners/backend.hpp (line 49) https://reviews.apache.org/r/37382/#comment150400 s/roots/layers/ ? src/slave/containerizer/provisioners/backend.hpp (line 50) https://reviews.apache.org/r/37382/#comment150401 How about s/directory/rootfs/ to make it more clear that 'directory' is the path to the rootfs? src/slave/containerizer/provisioners/backend.hpp (lines 55 - 57) https://reviews.apache.org/r/37382/#comment150402 Hum, what do yo mean here? I think the backend should be container aware. I.e., we should pass in containerid in 'provision' and destroy will take a containerid as well. There could be multiple rootfs for a container (because image in volumes). When the container finishes, the provisioner will try to destroy all rootfs provisioned for that container. Thoughts? - Jie Yu On Aug. 14, 2015, 5:51 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 5:51 p.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
On Aug. 14, 2015, 12:12 p.m., James DeFelice wrote: failing unit test from mesos built bot seems completely unrelated (evil agent!): ``` ../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure Value of: response.get().status Actual: 202 Accepted Expected: http::statuses[200] Which is: 200 OK [ FAILED ] HTTPTest.NestedGet (2 ms) ``` i wrote that test. looking... - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95417 --- On Aug. 14, 2015, 11:58 a.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:58 a.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37382: Introduced provisioner Backend interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Changes --- Comments. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs (updated) - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37382: Introduced provisioner Backend interface.
On Aug. 12, 2015, 1:45 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/backend.hpp, line 48 https://reviews.apache.org/r/37382/diff/1/?file=1038090#file1038090line48 Should we just use Path here? Path is still hard to use in an interface particularly when it comes to joins: Path is implicitly convertable to string but not vice versa, join results are strings; already checked in code in the provisioning / FS isolation components don't use Path in the interface. We can revisit this in the future but for now I think we should still use string. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95069 --- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95459 --- Ship it! Per Greg, the underlying issue will be tracked here: https://issues.apache.org/jira/browse/MESOS-3264 Since this change makes the test less flaky, I say it LGTM. - Joseph Wu On Aug. 13, 2015, 9:49 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/ --- (Updated Aug. 13, 2015, 9:49 a.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-1013 https://issues.apache.org/jira/browse/MESOS-1013 Repository: mesos Description --- Fix flaky ExamplesTest.JavaLog Diffs - src/examples/java/TestLog.java 9dd4630745e4638f5c347c8a69eec30fdad3af56 Diff: https://reviews.apache.org/r/37414/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaLog bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95460 --- Ship it! Per Greg, the underlying issue will be tracked here: https://issues.apache.org/jira/browse/MESOS-3264 Since this change makes the test less flaky, I say it LGTM. - Joseph Wu On Aug. 13, 2015, 9:56 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/ --- (Updated Aug. 13, 2015, 9:56 p.m.) Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Bugs: MESOS-830 https://issues.apache.org/jira/browse/MESOS-830 Repository: mesos Description --- Fix flaky ExamplesTest.JavaFramework Diffs - src/examples/java/TestFramework.java 265005b9d1a6a053b812c133a4817c3d9e61179e Diff: https://reviews.apache.org/r/37415/diff/ Testing --- This test may fail only infrequently, and the bug is made worse by verbose logging, so to verify correctness (or reproduce the bug before patching) try: GLOG_v=2 GTEST_FILTER=ExamplesTest.JavaFramework bin/mesos-tests.sh --verbose --gtest_repeat=100 2/dev/null | grep \[ Thanks, Greg Mann
Re: Review Request 37427: Docker registry: adding TokenManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95457 --- Patch looks great! Reviews applied: [37426, 37427] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 5:28 p.m., Jojy Varghese wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 14, 2015, 5:28 p.m.) Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. Repository: mesos Description --- Changes: - Added Token implementation (RFC 7519). - Added TokenManager implementation. This component keeps a cache of tokens requested for any future requests. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37427/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/#review95435
---
Bad patch!
Reviews applied: [37479]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d mesos-0.24.0; then find mesos-0.24.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.24.0 || { sleep 5 rm -rf
mesos-0.24.0; }; else :; fi
test -d mesos-0.24.0 || mkdir mesos-0.24.0
(cd 3rdparty make top_distdir=../mesos-0.24.0
distdir=../mesos-0.24.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.24.0
distdir=../../mesos-0.24.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.24.0/3rdparty/libprocess || mkdir
../../mesos-0.24.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout make top_distdir=../../../../mesos-0.24.0
distdir=../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout || mkdir
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
(cd include make top_distdir=../../../../../mesos-0.24.0
distdir=../../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n : \
|| find ../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r
../../../../mesos-0.24.0/3rdparty/libprocess/3rdparty/stout
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd include make top_distdir=../../../mesos-0.24.0
distdir=../../../mesos-0.24.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n : \
|| find ../../mesos-0.24.0/3rdparty/libprocess -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r ../../mesos-0.24.0/3rdparty/libprocess
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src make top_distdir=../mesos-0.24.0 distdir=../mesos-0.24.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** No rule to make target `slave/qos_controller.hpp', needed by
`distdir'. Stop.
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
-
Re: Review Request 37457: Add --ip_discovery_command to Agent.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/#review95448
---
Ship it!
I'll fix these up and commit.
src/slave/main.cpp (line 111)
https://reviews.apache.org/r/37457/#comment150390
s/master/slave/
src/slave/main.cpp (line 117)
https://reviews.apache.org/r/37457/#comment150392
s/master/slave/
- Benjamin Hindman
On Aug. 14, 2015, 12:21 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/
---
(Updated Aug. 14, 2015, 12:21 a.m.)
Review request for mesos, Cody Maloney and Timothy Chen.
Repository: mesos
Description
---
Similarly to the Master, we want to enable the Agent too to be initialized
with an IP address that is discovered by an arbitrary script.
This is particularly useful for Mesos deployments on public (or private)
clouds
where DNS resolution is either limited or not feasible.
Jira: MESOS-3154
Diffs
-
src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a
Diff: https://reviews.apache.org/r/37457/diff/
Testing
---
make check
run `./bin/mesos-slave --ip_discovery_command=/.../discover-ip.py ...`
and verified it binds to the expected address:
```
I0813 17:18:24.871472 2046800640 main.cpp:272] Starting Mesos slave
I0813 17:18:24.873610 292802560 slave.cpp:190] Slave started on
1)@192.168.33.1:5051
I0813 17:18:24.873633 292802560 slave.cpp:191] Flags at startup:
--appc_store_dir=/tmp/mesos/store/appc --authenticatee=crammd5
--container_disk_watch_interval=15secs --containerizers=mesos
--default_role=* --disk_watch_interval=1mins --docker=docker
--docker_kill_orphans=true --docker_remove_delay=6hrs
--docker_socket=/var/run/docker.sock --docker_stop_timeout=0ns
--enforce_container_disk_quota=false
--executor_registration_timeout=1mins
--executor_shutdown_grace_period=5secs
--fetcher_cache_dir=/tmp/mesos/fetch --fetcher_cache_size=2GB
--frameworks_home= --gc_delay=1weeks --gc_disk_headroom=0.1
--hadoop_home= --help=false --initialize_driver_logging=true
--ip_discovery_command=~/dev/discovery-ip.py
--isolation=posix/cpu,posix/mem
--launcher_dir=/Users/marco/dev/workspace/mesos/build/src --logbufsecs=0
--logging_level=INFO --master=127.0.0.1:5050 --modules=libraries {
file: /Users/marco/dev/workspace/modules/execute/build/Debug/libexecmod.so
modules {
name: com_mesosphere_mesos_RemoteExecutionAnonymous
}
}
--oversubscribed_resources_interval=15secs --port=5051
--qos_correction_interval_min=0ns --quiet=false --recover=reconnect
--recovery_timeout=15mins --registration_backoff_factor=1secs
--resource_monitoring_interval=1secs
--sandbox_directory=/mnt/mesos/sandbox --strict=true --switch_user=true
--version=false --work_dir=/tmp/slave
I0813 17:18:24.875107 292802560 slave.cpp:354] Slave resources: cpus(*):8;
mem(*):15360; disk(*):470858; ports(*):[31000-32000]
I0813 17:18:24.881863 292802560 slave.cpp:384] Slave hostname: 192.168.33.1
...
```
Thanks,
Marco Massenzio
Re: Review Request 37489: Make scheduler tests parameterized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/#review95490 --- Patch looks great! Reviews applied: [37489] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:23 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 14, 2015, 8:23 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- This change makes scheduler tests parameterized. - I had to disable SchedulerTests.KillTask due to the JSON encoding issue till we fix it. I can un-parameterize it for now too ? - Moved the ContentType/output overload operators to include/mesos/http.hpp Diffs - include/mesos/http.hpp PRE-CREATION include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37382: Introduced provisioner Backend interface.
On Aug. 14, 2015, 6:15 p.m., Jie Yu wrote: src/slave/containerizer/provisioners/backend.hpp, lines 55-57 https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55 Hum, what do yo mean here? I think the backend should be container aware. I.e., we should pass in containerid in 'provision' and destroy will take a containerid as well. There could be multiple rootfs for a container (because image in volumes). When the container finishes, the provisioner will try to destroy all rootfs provisioned for that container. Thoughts? Jiang Yan Xu wrote: This is intended for the image in volumes case but I was trying to not be too explicit because it's not implemented yet (we should track it with a separate ticket). My comment about 'nested' was incorrect, let me clarify here. The 'caller' is the provisioner. What I had in mind was: each Backend call handles one image, if `Backend::provision()`s one image and then it should `destroy()` the rootfs provisioned by one image. Suppose we have such a rootfs dir and each container has multiple rootfses, some from ContainerInfo::volumnes and one from ContainerInfo::mesos::image but they are stored side-by-side under container_id/image_type. ``` --rootfs_dir |--container_id |--appc |--image_id |--image_id |--docker ``` IMO since LinuxFilesystemIsolatorProcess::cleanup() calls each `Provisioner::destory(containerId)` (appc|docker), the provisioner can look at the subdir it manages and scan it and call `Backend::destroy(rootfsPath)` for each image under it. So each `Backend::destroy(rootfsPath)` call destroys one rootfs and there is no `nesting` under it. Passing `containerId` into Backend isn't as clean as it should be the provisioner who converts the id into a path and Backends are this dumb thing which only knows paths. More clear? So the directory layout listed above is managed by the provisioner or backend? It cannot be backend because otherwise that means provisioner needs to know about the layout used by the backend. So if it's managed by provisioner, the layout should probably be: ``` /var/lib/mesos/provisioners/ |-- appc/ |-- container_id |-- image1 |-- image2 |-- docker/ |-- container_id |-- image3 |-- image4 ``` So we only allow one backend, or we allow multiple backends (e.g., what if we want to use bind mount backend for appc but overlayfs backend for docker, or we want to gradually roll out overlayfs backend so that two backends co-exists for a while)? If the later, how can we figure out which backend to use when destroying root filesystems? I just want to get the full picture sorted out. We can chat next week. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- On Aug. 14, 2015, 5:51 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 5:51 p.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37490: Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 10 p.m.) Review request for mesos and Jie Yu. Summary (updated) - Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description (updated) --- Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37491: Added a trivial test on how the protobuf-json string don't match due to incorrect escaping of bytes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/#review95485 --- Patch looks great! Reviews applied: [37491] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:19 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/ --- (Updated Aug. 14, 2015, 8:19 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3263 https://issues.apache.org/jira/browse/MESOS-3263 Repository: mesos Description --- Added a test to show how converting a protobuf having a byte field to json fails due to the bytes not being escaped correctly. The test is currently disabled. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37491/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37382: Introduced provisioner Backend interface.
On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: src/slave/containerizer/provisioners/backend.hpp, lines 55-57 https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55 Hum, what do yo mean here? I think the backend should be container aware. I.e., we should pass in containerid in 'provision' and destroy will take a containerid as well. There could be multiple rootfs for a container (because image in volumes). When the container finishes, the provisioner will try to destroy all rootfs provisioned for that container. Thoughts? This is intended for the image in volumes case but I was trying to not be too explicit because it's not implemented yet (we should track it with a separate ticket). My comment about 'nested' was incorrect, let me clarify here. The 'caller' is the provisioner. What I had in mind was: each Backend call handles one image, if `Backend::provision()`s one image and then it should `destroy()` the rootfs provisioned by one image. Suppose we have such a rootfs dir and each container has multiple rootfses, some from ContainerInfo::volumnes and one from ContainerInfo::mesos::image but they are stored side-by-side under container_id/image_type. ``` --rootfs_dir |--container_id |--appc |--image_id |--image_id |--docker ``` IMO since LinuxFilesystemIsolatorProcess::cleanup() calls each `Provisioner::destory(containerId)` (appc|docker), the provisioner can look at the subdir it manages and scan it and call `Backend::destroy(rootfsPath)` for each image under it. So each `Backend::destroy(rootfsPath)` call destroys one rootfs and there is no `nesting` under it. Passing `containerId` into Backend isn't as clean as it should be the provisioner who converts the id into a path and Backends are this dumb thing which only knows paths. More clear? - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/#review95480 --- Patch looks great! Reviews applied: [37490] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:05 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote: [mmm turns out that it matters WHICH boxes you put your general comments in :) - copied here, as they make sense *before* the nitpicking that follows] Again, sorry it's taken so long to get round to doing this review and s many thanks for doing this! I've only got halfway through, I'll try my best to do more in the next few days, less craziness (here's to hoping, anyway!) I notice the one file runs for 1,000 lines - the Resource class is probably worth having in its own .java file, and probably Flags too - maybe you can refactor further other parts too. In general, I like Java class files to only rarely exceed the 300-400 lines - bigger than that, it usually signals design choices that are sub-optimal in separating concerns. As I mentioned, it's great that you're doing this: as someone who wants to learn more about persistence framework, I'm looking forward to having this committed and being able to also hack around with it :) Maybe, we may also get a blog entry out of it, as we expose persistent volumes to a wider public and show folks how to use them in a Java framework. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95473 --- On June 21, 2015, 9:57 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:57 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2610 https://issues.apache.org/jira/browse/MESOS-2610 Repository: mesos Description --- Add a Java example framework to test persistent volumes. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION src/examples/java/test-persistent-volume-framework.in PRE-CREATION src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca src/tests/java_persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang
Review Request 37494: Fixed JSON wrapper to properly encode bytes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3267 https://issues.apache.org/jira/browse/MESOS-3267 Repository: mesos Description --- See the bug for details. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp dd692094e164e33ba0f13e2b994c14cbfd827cbf 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37494/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37382: Introduced provisioner Backend interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95471 --- Patch looks great! Reviews applied: [37382] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 5:51 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 5:51 p.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu
Re: Review Request 37382: Introduced provisioner Backend interface.
On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: src/slave/containerizer/provisioners/backend.hpp, lines 55-57 https://reviews.apache.org/r/37382/diff/2/?file=1040433#file1040433line55 Hum, what do yo mean here? I think the backend should be container aware. I.e., we should pass in containerid in 'provision' and destroy will take a containerid as well. There could be multiple rootfs for a container (because image in volumes). When the container finishes, the provisioner will try to destroy all rootfs provisioned for that container. Thoughts? Jiang Yan Xu wrote: This is intended for the image in volumes case but I was trying to not be too explicit because it's not implemented yet (we should track it with a separate ticket). My comment about 'nested' was incorrect, let me clarify here. The 'caller' is the provisioner. What I had in mind was: each Backend call handles one image, if `Backend::provision()`s one image and then it should `destroy()` the rootfs provisioned by one image. Suppose we have such a rootfs dir and each container has multiple rootfses, some from ContainerInfo::volumnes and one from ContainerInfo::mesos::image but they are stored side-by-side under container_id/image_type. ``` --rootfs_dir |--container_id |--appc |--image_id |--image_id |--docker ``` IMO since LinuxFilesystemIsolatorProcess::cleanup() calls each `Provisioner::destory(containerId)` (appc|docker), the provisioner can look at the subdir it manages and scan it and call `Backend::destroy(rootfsPath)` for each image under it. So each `Backend::destroy(rootfsPath)` call destroys one rootfs and there is no `nesting` under it. Passing `containerId` into Backend isn't as clean as it should be the provisioner who converts the id into a path and Backends are this dumb thing which only knows paths. More clear? Jie Yu wrote: So the directory layout listed above is managed by the provisioner or backend? It cannot be backend because otherwise that means provisioner needs to know about the layout used by the backend. So if it's managed by provisioner, the layout should probably be: ``` /var/lib/mesos/provisioners/ |-- appc/ |-- container_id |-- image1 |-- image2 |-- docker/ |-- container_id |-- image3 |-- image4 ``` So we only allow one backend, or we allow multiple backends (e.g., what if we want to use bind mount backend for appc but overlayfs backend for docker, or we want to gradually roll out overlayfs backend so that two backends co-exists for a while)? If the later, how can we figure out which backend to use when destroying root filesystems? I just want to get the full picture sorted out. We can chat next week. Note that the above rootfs I mentioned is the result of the Backend either collapsing its layers or overlay them and in the provisioner's view it's just one entity. So the backend know about layout within a rootfs (e.g., its knows that a rootfs is ImageA(a script) - ImageB(essential software) -ImageC(base OS)); the provisioner knows about / manages the direcotry layout of 'rootfs'es but not inside 'rootfs'es (e.g. This container wants three rootfses, two of which from volumes). Yeah I agree the interface design requires a full picture of multi-image-per-contain design. I will jot down my thoughts in a doc and let's chat next week. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2968 https://issues.apache.org/jira/browse/MESOS-2968 Repository: mesos Description --- The Backend interface is made generic so it can be used by different provisioners. See [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) for details. Diffs - src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 src/slave/containerizer/provisioners/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff:
Re: Review Request 33339: Add a Java example framework to test persistent volumes.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review95473
---
src/examples/java/TestPersistentVolumeFramework.java (line 34)
https://reviews.apache.org/r/9/#comment150454
nit: An example...
also: it's persistent *volumes* (plural)
src/examples/java/TestPersistentVolumeFramework.java (line 38)
https://reviews.apache.org/r/9/#comment150456
IMO it should not have the `Test` moniker in its name: it is usually
reserved for junit.TestCase-derived classes that contain unit tests.
As it's an Example Framework something like
SimplePersistentVolumeFramework or Example... would describe better the
intent.
src/examples/java/TestPersistentVolumeFramework.java (line 41)
https://reviews.apache.org/r/9/#comment150450
nit: `provides`
also, you can lose the space before the ending period (also in the line
below)
src/examples/java/TestPersistentVolumeFramework.java (line 43)
https://reviews.apache.org/r/9/#comment150452
add an empty line, please - the generated Javadoc won't wrap and will look
not so pretty.
Maybe you may want to wrap the filename in a `{@code}` so it renders as
monospace.
Finally, I'd suggest you lose the leading ./ and the trailing space before
the period.
src/examples/java/TestPersistentVolumeFramework.java (line 58)
https://reviews.apache.org/r/9/#comment150457
s/use/uses
This is useful information :)
Please put it in the Javadoc and also make sure you mention in the @return
clause
src/examples/java/TestPersistentVolumeFramework.java (line 63)
https://reviews.apache.org/r/9/#comment150467
This would be confusing to someone reading the comment (expecting some kind
of `Error` class) and then seeing the method signature (which returns a
`String`).
I also find a `validate()` method returning an empty string to signal a
valid resource completely unintuitive (and certainly, you should take advantage
of the @return clause to at least mention that to your users).
A much better pattern would be:
(a) return a bool (`true` is valid, `false` otherwise); OR
(b) return void, and `throw new ResourceParseException` with the reason as
the message (and you could even go sophisticated by making
ResourceParseException extend ParseException); OR
(c) if your religion is of the no-exception kind ;-) you may instead
implement an Error class which has a few enums, or a static `OK` instance and
takes a `String` with a static constructor method.
So many possibilities...
src/examples/java/TestPersistentVolumeFramework.java (line 115)
https://reviews.apache.org/r/9/#comment150470
with the caveat of the above comments, this should be anyway changed to:
```
if (!errMsg.isEmpty()) {
...
```
src/examples/java/TestPersistentVolumeFramework.java (line 126)
https://reviews.apache.org/r/9/#comment150479
I really think it would be useful to enumerate the cases in which resources
cannot be added (maybe with a list of li items?)
```
liif their reservation statuses don't match;
liif only one has disk components;
etc.
```
Remember: this is an example frameworks: many many folks who are *not*
experts will come look at it to learn!
src/examples/java/TestPersistentVolumeFramework.java (line 127)
https://reviews.apache.org/r/9/#comment150471
s/addable/composable
or
cannot be added together.
src/examples/java/TestPersistentVolumeFramework.java (line 133)
https://reviews.apache.org/r/9/#comment150490
s/addable/canAdd
IMO all these methods could be non-static and be instead instance method:
```
public boolean canAdd(Resource other)
```
src/examples/java/TestPersistentVolumeFramework.java (line 146)
https://reviews.apache.org/r/9/#comment150480
right - here for example: you could add a comment to explain why their
being equal does not allow them to be added
(I genuinely don't know! in fact, is that right?)
src/examples/java/TestPersistentVolumeFramework.java (line 164)
https://reviews.apache.org/r/9/#comment150482
didn't you just check this on L141?
src/examples/java/TestPersistentVolumeFramework.java (line 173)
https://reviews.apache.org/r/9/#comment150485
nit: s/subtractable/cannot be subtracted
also: please use correct javadoc/HTML:
```
(insert blank line)
pstrongNOTE:/strong Set subtraction...
```
all the examples you enclose in quotes, IMO render better if you use
{@literal} instead.
src/examples/java/TestPersistentVolumeFramework.java (lines 185 - 189)
https://reviews.apache.org/r/9/#comment150488
how about adding an `isCompatible(Resource other)` method to the `Resource`
Re: Review Request 37247: Added Docker image reference store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 15, 2015, 12:46 a.m.) Review request for mesos and Timothy Chen. Changes --- Integrated reference store into local image store and removed restore, since reference store handles saving and restoring state. Bugs: MESOS-3021 https://issues.apache.org/jira/browse/MESOS-3021 Repository: mesos Description --- Added Docker image reference store. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/messages/docker_provisioner.hpp PRE-CREATION src/messages/docker_provisioner.proto PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37247/diff/ Testing --- make check Tests will be added in a later review. Thanks, Lily Chen
Review Request 37495: Docker provisioner local store unit tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- Review request for mesos. Repository: mesos Description --- Docker provisioner local store unit tests. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37495/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/#review95494 --- Ship it! LGTM 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 499) https://reviews.apache.org/r/37494/#comment150530 We can return here itself: return out stuff 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 123) https://reviews.apache.org/r/37494/#comment150529 s/message a little bit to test/message to test - Anand Mazumdar On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/ --- (Updated Aug. 14, 2015, 11:24 p.m.) Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3267 https://issues.apache.org/jira/browse/MESOS-3267 Repository: mesos Description --- See the bug for details. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp dd692094e164e33ba0f13e2b994c14cbfd827cbf 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37494/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 36125: Removing '.json' extension in master endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review95501 --- After @vinodkone (correct) comments, there has been no activity on this and other associated patches. Can you please update or discard, as appropriate? - Marco Massenzio On July 2, 2015, 7:42 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/ --- (Updated July 2, 2015, 7:42 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2719 https://issues.apache.org/jira/browse/MESOS-2719 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in master Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-ps ee14d51 src/cli/mesos-scp 77b8557 src/cli/mesos-tail 256a804 src/master/constants.hpp 7cec18b src/master/http.cpp 2be613b src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/tests/fault_tolerance_tests.cpp 1070ccf src/tests/master_tests.cpp 57721b7 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review95500 --- Is this patch still needed? both this and the associated Jira have not been updated in more than a month. - Marco Massenzio On July 2, 2015, 8:03 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated July 2, 2015, 8:03 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp 3a62ee7 src/master/flags.cpp 60ac64d src/slave/flags.cpp 8632677 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp 5666cd1 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 15, 2015, 2:02 a.m.) Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description --- Jira: MESOS-3035 The original API for `process::Subprocess` still left a lot of legwork to do for the caller; we have now added a `wait(Duration timeout)` method that returns a `CommandResult` (also introduced with this patch) which contains useful information about the command invocation; the exit code; stdout and, optionally, stderr too. The `wait()` method will wait for both the process to terminate, and stdout/stderr to be available to read from; it also unpacks them into ready-to-use `string`s. This is still WIP as I'm seeing some unusual behavior and I'd like to discuss with someone more expert on libprocess. Diffs - 3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 3rdparty/libprocess/src/subprocess.cpp d6ea62ed1c914d34e0e189395831c86fff8aac22 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio
Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- (Updated Aug. 15, 2015, 12:41 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Refactor Docker Image to exclude path and manifest. Diffs (updated) - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37245/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37496: Move docker provisioner local store into dedicated folders.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 15, 2015, 12:54 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Move docker provisioner local store into dedicated folders. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37496/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37495: Docker provisioner local store unit tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 15, 2015, 12:55 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Docker provisioner local store unit tests. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37495/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 15, 2015, 1:27 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added Docker provisioner paths which handles path manipulation. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37497/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 37246: Refactor store to use updated DockerImage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- (Updated Aug. 15, 2015, 12:44 a.m.) Review request for mesos and Timothy Chen. Changes --- Addressed comments and fixed Docker layer storage to be atomic. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactor local store to use updated DockerImage. Diffs (updated) - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37246/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37493: Detect gflags when present and link when building Python module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95504 --- Patch looks great! Reviews applied: [37493] All tests passed. - Mesos ReviewBot On Aug. 15, 2015, 12:28 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- (Updated Aug. 15, 2015, 12:28 a.m.) Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Detect gflags when present and link when building Python module Diffs - configure.ac a478ebd331ff2eed25ced2d86d9e6bda3376e2ab Diff: https://reviews.apache.org/r/37493/diff/ Testing --- Did the following: ../configure make make check For each of these cases: 1. using bundled glog, with gflags not installed 2. using bundled glog, with gflags installed 3. using system glog (built without gflags) via --with-glog=..., with gflags not installed 4. using system glog (built without gflags) via --with-glog=..., with gflags installed 5. using system glog (built with gflags) via --with-glog=..., with gflags installed Test suite passes in all cases. Thanks, Greg Mann
Re: Review Request 37489: Make scheduler tests parameterized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 15, 2015, 2:13 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes --- Enable the KillTask test now that Vinod fixed the JSON encoding issue Repository: mesos Description --- This change makes scheduler tests parameterized. - I had to disable SchedulerTests.KillTask due to the JSON encoding issue till we fix it. I can un-parameterize it for now too ? - Moved the ContentType/output overload operators to include/mesos/http.hpp Diffs (updated) - include/mesos/http.hpp PRE-CREATION include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 37489: Make scheduler tests parameterized
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/#review95505 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2015, 2:13 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 15, 2015, 2:13 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Description --- This change makes scheduler tests parameterized. - I had to disable SchedulerTests.KillTask due to the JSON encoding issue till we fix it. I can un-parameterize it for now too ? - Moved the ContentType/output overload operators to include/mesos/http.hpp Diffs - include/mesos/http.hpp PRE-CREATION include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar
Review Request 37496: Move docker provisioner local store into dedicated folders.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- Review request for mesos. Repository: mesos Description --- Move docker provisioner local store into dedicated folders. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37496/diff/ Testing --- sudo make check ./bin/mesos-tests.sh --gtest_filter=*DockerProvisioner* --gtest_repeat=20 --gtest_shuffle=1 Thanks, Lily Chen
Re: Review Request 36040: Change Server closing connections for every request
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/#review95498 --- This has not been touched in more than a month. Should it be discarded? - Marco Massenzio On July 2, 2015, 10:33 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/ --- (Updated July 2, 2015, 10:33 p.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Repository: mesos-incubating Description --- Adding a TODO so later we have the possibility to 'keep-alive' the connection Diffs - 3rdparty/libprocess/src/http.cpp 0898335 Diff: https://reviews.apache.org/r/36040/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37468: Removed allocation types to mesos::master namespace
On Aug. 14, 2015, 12:21 p.m., Guangya Liu wrote: Code looks good, but pls check what is wrong with the build Solved! There is an issue in the apply-review.sh. The script crashes because my name has é. After I changed my name in the review board the script runs fine - Jose Guilherme --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95418 --- On Aug. 14, 2015, 2:01 a.m., Jose Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated Aug. 14, 2015, 2:01 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, Jose Guilherme Vanz
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review95508 --- Patch looks great! Reviews applied: [37479] All tests passed. - Mesos ReviewBot On Aug. 15, 2015, 1:44 a.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 15, 2015, 1:44 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 37197: Docker image store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 15, 2015, 12:38 a.m.) Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. Changes --- Rebased on master. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Stored images currently kept indefinitely. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c Diff: https://reviews.apache.org/r/37197/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 15, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen. Changes --- Rebased on master. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Added store interface and moved store implementation to LocalStore subclass. Diffs (updated) - src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37199/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37198: Add Docker image provisioner and copy backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 15, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen. Changes --- Rebased on master. Bugs: MESOS-2850 https://issues.apache.org/jira/browse/MESOS-2850 Repository: mesos Description --- Add Docker image provisioner and copy backend. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/slave/containerizer/isolators/filesystem/linux.cpp f36424e94c380870cfde49d55af397fa3dc4a612 src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838 src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c src/tests/containerizer/provisioner.hpp c4ba46794fe5d7875fda11155367f521c34ea339 Diff: https://reviews.apache.org/r/37198/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 15, 2015, 12:40 a.m.) Review request for mesos and Timothy Chen. Changes --- Rebased on master. Bugs: MESOS-2849 https://issues.apache.org/jira/browse/MESOS-2849 Repository: mesos Description --- Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers. Diffs (updated) - src/slave/containerizer/provisioners/docker.hpp PRE-CREATION src/slave/containerizer/provisioners/docker.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 src/slave/flags.cpp e43dd1c13dd4263dc326842233808ddb7a9bb74c Diff: https://reviews.apache.org/r/37200/diff/ Testing --- make check Thanks, Lily Chen
Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/#review95495 --- Patch looks great! Reviews applied: [37494] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/ --- (Updated Aug. 14, 2015, 11:24 p.m.) Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3267 https://issues.apache.org/jira/browse/MESOS-3267 Repository: mesos Description --- See the bug for details. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp dd692094e164e33ba0f13e2b994c14cbfd827cbf 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37494/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated 八月 15, 2015, 1:44 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3261 https://issues.apache.org/jira/browse/MESOS-3261 Repository: mesos Description --- We need to move QoS plug-ins to a specified folder like resource_estimators, this can make sure new plug-ins can be put into the folders for resource estimator and qos controller. Diffs (updated) - src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 src/examples/test_qos_controller_module.cpp 156529d2392572d2968f788e385b0a798ece33b5 src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 36037: Adding /call endpoint to Master
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review95503 --- what's the status of this one? Should it be closed/discarded? - Marco Massenzio On July 2, 2015, 8:16 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 8:16 a.m.) Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2860 https://issues.apache.org/jira/browse/MESOS-2860 Repository: mesos-incubating Description --- Adding a call route with HTTP request header validations Diffs - src/Makefile.am a064d17 src/master/http.cpp 2be613b src/master/http_constants.hpp PRE-CREATION src/master/http_constants.cpp PRE-CREATION src/master/master.hpp af83d3e src/master/master.cpp a7486d8 src/master/validation.hpp 469d6f5 src/master/validation.cpp 9d128aa src/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95408 --- Ship it! These mini issues can easily be fixed while committing. Great job on this project! include/mesos/mesos.proto (line 192) https://reviews.apache.org/r/37443/#comment150343 s/scheduler/framework It will not be the scheduler providing the extra functionality. It just provides the labels describing it. src/master/http.cpp (line 243) https://reviews.apache.org/r/37443/#comment150345 What do you mean by this comment? Confusing. BTW: in general, we do not mark existing code with the tickets it relates to. (We do mark TODOs with issues numbers if available, though.) IMHO this comment can simply be deleted. - Bernd Mathiske On Aug. 13, 2015, 1:20 p.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 13, 2015, 1:20 p.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95409 --- src/master/http.cpp (line 239) https://reviews.apache.org/r/37443/#comment150347 s/framework/framework. - Joerg Schad On Aug. 13, 2015, 8:20 p.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 13, 2015, 8:20 p.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95417 --- failing unit test from mesos built bot seems completely unrelated (evil agent!): ``` ../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure Value of: response.get().status Actual: 202 Accepted Expected: http::statuses[200] Which is: 200 OK [ FAILED ] HTTPTest.NestedGet (2 ms) ``` - James DeFelice On Aug. 14, 2015, 11:58 a.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:58 a.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37468: Removed allocation types to mesos::master namespace
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95418 --- Code looks good, but pls check what is wrong with the build - Guangya Liu On 八月 14, 2015, 2:01 a.m., José Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated 八月 14, 2015, 2:01 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, José Guilherme Vanz
Re: Review Request 37445: Fix typos in style guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37445/#review95419 --- Ship it! Ship It! - Guangya Liu On 八月 13, 2015, 9:58 p.m., Neil Conway wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37445/ --- (Updated 八月 13, 2015, 9:58 p.m.) Review request for mesos. Repository: mesos Description --- Fix typos in style guide. Diffs - docs/mesos-c++-style-guide.md 9c1a00c32043fa10038e38bd7cbc561aafcd6ea0 Diff: https://reviews.apache.org/r/37445/diff/ Testing --- Thanks, Neil Conway
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
On Aug. 14, 2015, 1:49 p.m., Alexander Rojas wrote: src/tests/fault_tolerance_tests.cpp, line 1834 https://reviews.apache.org/r/37443/diff/4/?file=1039554#file1039554line1834 Line length is 81 characters. James DeFelice wrote: assuming that 80 is the limit? is there a common linter that you guys use? yup 80 is the limit. We use clang format, the `.clang-format` is automatically generated when one runs `bootstrap` although it doesn't work perfectly to our rules. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95411 --- On Aug. 14, 2015, 1:29 p.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 1:29 p.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Re: Review Request 37443: Add labels to FrameworkInfo (v2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:58 a.m.) Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. Changes --- fixed line length problems in failover test Bugs: MESOS-2841 https://issues.apache.org/jira/browse/MESOS-2841 Repository: mesos Description --- This is intended to support frameworks that want to offer capabilities to the rest of the cluster (e.g., storage or some arbitrary third-party service). We want processes running in the cluster to be able to discover these capabilities; however, we don't want to commit to a fixed set of capabilities or how those capabilities should be represented. Hence, this commit represents this information using freeform key-value pairs, similar to the labels mechanism already in use elsewhere. Jira: MESOS-2841 supercedes #36867 ; addressed outstanding review comments in that review Diffs (updated) - include/mesos/mesos.proto a4a9c6f src/master/http.cpp 579c009 src/master/master.hpp 4e29470 src/tests/fault_tolerance_tests.cpp c63599a src/tests/master_tests.cpp a4703af Diff: https://reviews.apache.org/r/37443/diff/ Testing --- make check Thanks, James DeFelice
Review Request 37475: Fixed a wrong comparison.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --- Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison. Diffs - src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491 Diff: https://reviews.apache.org/r/37475/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 37475: Fixed a wrong comparison.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/#review95407 --- Ship it! Ship It! - Till Toenshoff On Aug. 14, 2015, 10:21 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/ --- (Updated Aug. 14, 2015, 10:21 a.m.) Review request for mesos and Till Toenshoff. Repository: mesos Description --- Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison. Diffs - src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491 Diff: https://reviews.apache.org/r/37475/diff/ Testing --- make check Thanks, Jan Schlicht
Re: Review Request 18723: Prevent gflags detection from glog configuration phase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18723/ --- (Updated Aug. 14, 2015, 10:34 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description (updated) --- Removes the gflags detection from the glog configuration phase. Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default. NOTE: Do NOT commit - this is an ancient patch meant to illustrate a problem with a trivial fix - a proper fix is in the works by Greg Mann. Diffs - 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f Diff: https://reviews.apache.org/r/18723/diff/ Testing --- make check (while having gflags previously installed). Thanks, Till Toenshoff
