Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 5:24 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Diffs (updated)
-

  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp f56d8a1 
  src/tests/common/http_tests.cpp c2e7704 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/
---

(Updated Oct. 22, 2015, 10:48 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, 
Kapil Arya, Niklas Nielsen, and Timothy Chen.


Changes
---

Remove NetworkInfo.  It is being added in a separate review.


Repository: mesos


Description (updated)
---

Added in reviews:

* https://reviews.apache.org/r/37196/
* https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
* https://reviews.apache.org/r/38253/
* https://reviews.apache.org/r/38367/
** NetworkInfo moved up the review chain.
* 
https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1


Diffs (updated)
-

  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 

Diff: https://reviews.apache.org/r/39502/diff/


Testing (updated)
---

`make`

For now, this review is meant for checking which of these differences are 
intentional.


Thanks,

Joseph Wu

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39383/#review103637
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 37)


Short note here. Because we're using the C standard I/O functions for now 
we're assuming all paths are POSIX-formatted.

We may change this now, but in case you are wondering whether this works on 
Windows, the answer is yes.

Also, you might be leery of committing this without tests. That's ok! We 
need this to pull the FS tests out of `os_tests.cpp` though. The last function 
we will need to port to get those tests functional on Windows is `rmdir`, and 
I'm almost done.


- Alex Clemmer


On Oct. 22, 2015, 5:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39383/
> ---
> 
> (Updated Oct. 22, 2015, 5:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39383/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, 
> > line 31
> > 
> >
> > Just so I catch it before it comes up: this is new code that needs to 
> > be tested, but we wrote it so that we could pull the FS tests out of 
> > `os_test.hpp`.
> > 
> > So my brief answer to "yo, are you stupid, you can't commit this stuff 
> > with tests" is "yes, I agree, but I have to write this before we can open 
> > up the tests!" :)

(And yes, I did test it _ad hoc_ before I pushed it. But that is not 
repeatable, we just need it to be "good enough" to run the actual tests.)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103636
---


On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> ---
> 
> (Updated Oct. 22, 2015, 6:23 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103613
---



src/master/master.hpp (lines 883 - 884)


Should this function be public, or protected is good enough?


- Alexander Rukletsov


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Guangya Liu]

> On 十月 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > 
> >
> > what about "return quotaHandler.create(request)"
> 
> Joerg Schad wrote:
> Wanted to make names consistent.
> @alex: any preference?
> 
> Alexander Rukletsov wrote:
> Yes. Naming is hard, we had a long offline discussion about these names 
> and decided the following:
> - Be consistent. Though there are subtle differences between operations 
> depending on the stage in the process, they are minor and will most probably 
> lead to confusion.
> - `set` instead of `add`, `request`, or `create`. You cannot call `set` 
> multiple times, that's why `add` is not good. `request` is too vague, you can 
> request anything. `create` carries the meaning of a creation act, which is 
> not the focus we would like to have. An important message to deliver is that 
> `set` my change the allocation behaviour for the role significantly.
> - `update` (not in MVP).
> - `remove` instead of `release`, `destroy`, or `delete`. `destroy` and 
> `delete` focus on scrapping an object, which is not the most important action 
> in this case. We would like to put accent on the fact that there is no more 
> quota associated with the role. `release` for me implies possession, 
> moreover, it doesn't play nice with `set`.
> - CRUD naming is a reasonable alternative (because it's a standard), 
> however we decided to opt for more specific naming in a hope it will help 
> understanding quota implications better.
> - This is all about internal naming, the operator API uses standard HTTP 
> verbs for these actions.

Thanks Alex, fair enough.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---


On 十月 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated 十月 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/#review103546
---


Patch looks great!

Reviews applied: [39005, 39006]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 7:47 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39006/
> ---
> 
> (Updated Oct. 22, 2015, 7:47 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> 12ba1ca861114e60f8276c0ee91c543abcfc2519 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> dc7c6522b283916b975a77957909f6cdc02944d3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 1baf142d53fd06149c80d4b2677c2a976c05ef71 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39006/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/
---

(Updated Oct. 22, 2015, 7:47 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Rebased and incorporated review comments.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
12ba1ca861114e60f8276c0ee91c543abcfc2519 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
1baf142d53fd06149c80d4b2677c2a976c05ef71 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
e740d5bc0f0cc5cf8e99b2064c1e39c08282da67 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39006/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/
---

(Updated Oct. 22, 2015, 7:51 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Rebased and incorporated review comments.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa 
  src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/mesos/launch.cpp 
09d4d8f4d6837e93a82deef76ca07e2167d6a405 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
  src/tests/containerizer/memory_test_helper.cpp 
8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
  src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 

Diff: https://reviews.apache.org/r/39008/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 21, 2015, 10:24 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/src/io.cpp, line 27
> > 
> >
> > This should at the very end of stout includes.

Let's keep lexicographical sort with an ASCII code page (which plays nicely 
with everything from sort to clang-format) while the discussion for the coding 
guidelines MESOS-2275 is still in flux.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review103486
---


On Oct. 22, 2015, 7:50 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> ---
> 
> (Updated Oct. 22, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 
> 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp 
> 954d31424bc8f8ecfa78b80513c480f2514ec271 
>   3rdparty/libprocess/src/profiler.cpp 
> 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp 
> 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/
---

(Updated Oct. 22, 2015, 7:50 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Rebased and incorporated review comments.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs (updated)
-

  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/poll_socket.cpp 
85cd864ebddd72316991a8f2782d3c7c9eebcc54 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
  3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
  3rdparty/libprocess/src/subprocess.cpp 
459825c188d56d25f6e2832e5a170d806e257d6b 

Diff: https://reviews.apache.org/r/39007/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

[Alexander Rukletsov]

> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > 
> >
> > what about "return quotaHandler.create(request)"
> 
> Joerg Schad wrote:
> Wanted to make names consistent.
> @alex: any preference?

Yes. Naming is hard, we had a long offline discussion about these names and 
decided the following:
- Be consistent. Though there are subtle differences between operations 
depending on the stage in the process, they are minor and will most probably 
lead to confusion.
- `set` instead of `add`, `request`, or `create`. You cannot call `set` 
multiple times, that's why `add` is not good. `request` is too vague, you can 
request anything. `create` carries the meaning of a creation act, which is not 
the focus we would like to have. An important message to deliver is that `set` 
my change the allocation behaviour for the role significantly.
- `update` (not in MVP).
- `remove` instead of `release`, `destroy`, or `delete`. `destroy` and `delete` 
focus on scrapping an object, which is not the most important action in this 
case. We would like to put accent on the fact that there is no more quota 
associated with the role. `release` for me implies possession, moreover, it 
doesn't play nice with `set`.
- CRUD naming is a reasonable alternative (because it's a standard), however we 
decided to opt for more specific naming in a hope it will help understanding 
quota implications better.
- This is all about internal naming, the operator API uses standard HTTP verbs 
for these actions.


> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 843
> > 
> >
> > What about return quotaHandler.delete(request);
> > 
> > It is better that the operation API can map to CRUD
> 
> Joerg Schad wrote:
> We wanted to make the name consistent across all calls. @alex: Any 
> preference?

Yep, see above.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review103518
---


On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> ---
> 
> (Updated Oct. 22, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 21, 2015, 10:23 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 41
> > 
> >
> > Can we fix the #include order as mentioned in the followup RR?

Let's keep lexicographical sort with an ASCII code page (which plays nicely 
with everything from `sort` to `clang-format`) while the discussion for the 
coding guidelines MESOS-2275 is still in flux.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review103484
---


On Oct. 9, 2015, 2:24 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> ---
> 
> (Updated Oct. 9, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/
---

(Updated Oct. 22, 2015, 7:46 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Rebased and incorporated review comments.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

This adds a thread-safe wrapper around strerror_r which has semantics similar 
to strerror. We plan to use this at call sites currently relying on strerror.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39005/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote:
> > Can you also sync this with the V1 API?  (If so, I'll remove that section 
> > from this: https://reviews.apache.org/r/39502 ).
> 
> Connor Doyle wrote:
> Yes, I will update the v1 proto file as well.  Thanks for the reminder.

Updated.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103497
---


On Oct. 22, 2015, 5:18 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1 
>   include/mesos/v1/mesos.proto eadbc9d 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp 99b843a 
>   src/tests/common/http_tests.cpp 8a01ffc 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 5:18 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Changes
---

Sync v1 API with mesos.proto updates for NetworkInfo.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1 
  include/mesos/v1/mesos.proto eadbc9d 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp 99b843a 
  src/tests/common/http_tests.cpp 8a01ffc 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103611
---


Bad patch!

Reviews applied: [39531]

Failed command: ./support/apply-review.sh -n -r 39531

Error:
 2015-10-22 17:40:22 URL:https://reviews.apache.org/r/39531/diff/raw/ 
[12284/12284] -> "39531.patch" [1]
39531.patch:296: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Successfully applied: [WIP] Clarify NetworkInfo semantics for IP addresses and 
group policies.

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Review: https://reviews.apache.org/r/39531
src/tests/common/http_tests.cpp:236: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On Oct. 22, 2015, 5:24 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 5:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp f56d8a1 
>   src/tests/common/http_tests.cpp c2e7704 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103607
---


Bad patch!

Reviews applied: [39531]

Failed command: ./support/apply-review.sh -n -r 39531

Error:
 2015-10-22 17:20:13 URL:https://reviews.apache.org/r/39531/diff/raw/ 
[12288/12288] -> "39531.patch" [1]
error: patch failed: include/mesos/mesos.proto:1351
error: include/mesos/mesos.proto: patch does not apply
39531.patch:296: new blank line at EOF.
+
Failed to apply patch

- Mesos ReviewBot


On Oct. 22, 2015, 5:18 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1 
>   include/mesos/v1/mesos.proto eadbc9d 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp 99b843a 
>   src/tests/common/http_tests.cpp 8a01ffc 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39560/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Add state.cpp, flags.cpp to Windows agent build.


Diffs
-

  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 

Diff: https://reviews.apache.org/r/39560/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 5:45 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Diffs (updated)
-

  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp f56d8a1 
  src/tests/common/http_tests.cpp c2e7704 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
---

(Updated Oct. 22, 2015, 6:24 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, 
MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

Windows: Added support for `slave/state.cpp`.


Diffs (updated)
-

  src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a 
  src/slave/state.cpp 81c4b96d879f974f0dfba3fb977184122eab 

Diff: https://reviews.apache.org/r/39219/diff/


Testing
---

Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103636
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
31)


Just so I catch it before it comes up: this is new code that needs to be 
tested, but we wrote it so that we could pull the FS tests out of `os_test.hpp`.

So my brief answer to "yo, are you stupid, you can't commit this stuff with 
tests" is "yes, I agree, but I have to write this before we can open up the 
tests!" :)


- Alex Clemmer


On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> ---
> 
> (Updated Oct. 22, 2015, 6:23 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103644
---


Patch looks great!

Reviews applied: [39531, 39502]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 5:48 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> ---
> 
> (Updated Oct. 22, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, 
> Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> ** NetworkInfo moved up the review chain.
> * 
> https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> ---
> 
> `make`
> 
> For now, this review is meant for checking which of these differences are 
> intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39383/
---

(Updated Oct. 22, 2015, 5:40 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39383/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::mkdtemp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
b6afe0e76366d0bc68d37097ced83a1e14828d84 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
3e6f2aafd0f541f512025dfa683ab4178701f7c4 

Diff: https://reviews.apache.org/r/39559/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

[Alex Clemmer]

> On Oct. 22, 2015, 4:59 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp, lines 17-21
> > 
> >
> > Nit: Can you flip the `#ifndef`?  No need to negate the conditional if 
> > there's an `#else`.

Yeah, so as a matter of style, I've tried to keep all the conditionals that 
apply to Unix to appear first, so that regardless of the conditional, you knew 
where to look, but I think you might be right that this actually hurts clarity, 
because it is not obvious.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
---


On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39537/
> ---
> 
> (Updated Oct. 22, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39537/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 39548: SchedulerTest.Suppress is flaky

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3733
https://issues.apache.org/jira/browse/MESOS-3733


Repository: mesos


Description
---

Root Cause: The reason is that the DECLINE call set filter as 1hr,
the Clock::advance set as 100m. A race condition is that both DECLINE
and SUPPRESS started up in different threads and the call Clock::advance
may be called before SUPPRESS finished. The clock advanced for 100m which
is greater than 1hr, this caused the allocator start to allocate resource
again and ASSERT_TRUE(event.isPending()) will be failed.

Solution: Call SUPPRESS first, this can make sure the SUPPRESS can
be finished before DECLINE.


Diffs
-

  src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 

Diff: https://reviews.apache.org/r/39548/diff/


Testing
---

Platform: Ubuntu 14.04
make 
make check
bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
--gtest_repeat=-1 --gtest_break_on_failure


Thanks,

Guangya Liu

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/
---

(Updated Oct. 22, 2015, 2:07 p.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.


Changes
---

Addresses issues in bernd-mesos review.


Bugs: MESOS-3705
https://issues.apache.org/jira/browse/MESOS-3705


Repository: mesos


Description
---

When using the same socket to send multiple HTTP requests to different actors. 
If the actor responsible for handling the first request is stuck handling 
another event while a subsequent request can reply immediatly, the order of the 
responses is altered violating HTTP Pipelining.

This patch fixes that problem enforcing that every response is sent in the 
order the corresponding request arrived. It also adds a test to reproduce the 
issue and verify the fix works.


Diffs (updated)
-

  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 

Diff: https://reviews.apache.org/r/39276/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review103556
---


Patch looks great!

Reviews applied: [39005, 39008]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 7:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> ---
> 
> (Updated Oct. 22, 2015, 7:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
>   src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/linux/routing/link/internal.hpp 
> 015c0ef5be516d7786c96a96437cced1ae8487fa 
>   src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/mesos/launch.cpp 
> 09d4d8f4d6837e93a82deef76ca07e2167d6a405 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
>   src/tests/containerizer/memory_test_helper.cpp 
> 8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/39008/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103650
---



include/mesos/mesos.proto (lines 1395 - 1409)


I should have noticed it earlier, but does it make sense to make IPAddress 
a top level message? Nik?



src/common/http.cpp (lines 165 - 180)


Dumb question -- could we have used `JSON::Protobuf()` instead?


- Kapil Arya


On Oct. 22, 2015, 1:45 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp f56d8a1 
>   src/tests/common/http_tests.cpp c2e7704 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/#review103655
---

Ship it!



src/slave/containerizer/mesos/containerizer.cpp (line 800)


Not yours, but please s/push_back/emplace_back



src/tests/reservation_endpoints_tests.cpp (line 830)


This is longer than 80 chars.


- Jan Schlicht


On Oct. 20, 2015, 7:37 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38335/
> ---
> 
> (Updated Oct. 20, 2015, 7:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/persistent_volume_framework.cpp 176ac3d 
>   src/launcher/executor.cpp 50b3c6e 
>   src/master/contender.cpp c641305 
>   src/master/http.cpp 093f793 
>   src/master/maintenance.cpp 5fe9358 
>   src/master/registrar.cpp 1117232 
>   src/slave/containerizer/fetcher.cpp e0d02d5 
>   src/slave/containerizer/mesos/containerizer.cpp d1fc5a4 
>   src/slave/monitor.cpp aa6e958 
>   src/tests/containerizer/launch_tests.cpp de655ec 
>   src/tests/fault_tolerance_tests.cpp f78a291 
>   src/tests/master_maintenance_tests.cpp e89ce3b 
>   src/tests/master_tests.cpp ee24739 
>   src/tests/mesos.hpp 3e58b45 
>   src/tests/mesos.cpp ab2d85b 
>   src/tests/monitor_tests.cpp 583e711 
>   src/tests/reservation_endpoints_tests.cpp f5f9c48 
>   src/tests/resources_tests.cpp 6584fc6 
>   src/tests/scheduler_http_api_tests.cpp d338a1b 
>   src/tests/script.cpp bcc1fab 
>   src/tests/slave_tests.cpp 10a4fa7 
>   src/usage/main.cpp 86fd796 
> 
> Diff: https://reviews.apache.org/r/38335/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/
---

(Updated Oct. 22, 2015, 8:46 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Updated depends on and moved adding ostream for executor to a separate patch


Bugs: MESOS-3480
https://issues.apache.org/jira/browse/MESOS-3480


Repository: mesos


Description
---

This change refactors the Executor struct on Agent and adds support for 
Executors to connect via the `api/v1/executor` endpoint on Agent. This is 
similar to the change done in Master for the Scheduler HTTP API.


Diffs (updated)
-

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/38874/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39560/#review103653
---


Patch looks great!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 6:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39560/
> ---
> 
> (Updated Oct. 22, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add state.cpp, flags.cpp to Windows agent build.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
> 
> Diff: https://reviews.apache.org/r/39560/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/
---

(Updated Oct. 22, 2015, 8:48 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

This change adds the functionality for executors to `Subscribe` via the 
`api/v1/executor` endpoint. It also stores a marker file as part of the 
`Subscribe` call if framework `checkpointing` is enabled. This can then be used 
by the agent when recovering to wait for reconnecting back with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
`CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
the `Subscribe` call.


Diffs (updated)
-

  src/slave/http.cpp 80bda34e2b344b96d5d2f9c1fecd36046f67ab49 
  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/38877/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39421: Add agent version to /master/slaves endpoint

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review103661
---

Ship it!



src/master/http.cpp (line 298)


if (slave.version.isSome()) {
  object.values["version" = slave.version.get();
}


- Vinod Kone


On Oct. 18, 2015, 1:29 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated Oct. 18, 2015, 1:29 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39569: Added output operator for Executor struct in agent

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/#review103672
---



src/slave/slave.cpp (line 1974)


Can we fix the leading whitespace?



src/slave/slave.cpp (line 2135)


See above.



src/slave/slave.cpp (line 3440)


See above.


- Neil Conway


On Oct. 22, 2015, 8:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39569/
> ---
> 
> (Updated Oct. 22, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Needed for https://reviews.apache.org/r/38874
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
> 
> Diff: https://reviews.apache.org/r/39569/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 39569: Added output operator for Executor struct in agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary. Needed for https://reviews.apache.org/r/38874


Diffs
-

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
---


Thanks,

Anand Mazumdar

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103660
---



src/tests/scheduler_tests.cpp (line 1001)


Hmm. Does this really fix the race? What's the guarantee that SUPPRESS and 
DECLINE are processed by the master/allocator before you advance the clock?

I think what you want do instead here is setup a FUTURE_DISPATCH() on 
HierarchicalAllocatorProcess::suppressOffers() and do a clock::settle() on that 
future before you advance the clock. 

Does that make sense?


- Vinod Kone


On Oct. 22, 2015, 9:12 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 22, 2015, 9:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, this can make sure the SUPPRESS can
> be finished before DECLINE.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review103656
---



support/apply-reviews.py (line 25)


s/extract_//



support/apply-reviews.py (line 32)


s/parent_review/review_chain/ ?



support/apply-reviews.py (lines 41 - 42)


Shouldn't this comment be rephrased/killed since you are disallowing more 
than one immediate parent below?



support/apply-reviews.py (line 56)


why extract summary into a variable here? you didn't do that above in #51.



support/apply-reviews.py (line 57)


what if there is a circular dependency of reviews by mistake?

A --> B --> C --> A



support/apply-reviews.py (line 58)


Why do you need to take 'r_list' as an argument to this method? to catch 
circular dependencies? if not, you could've done something as follows?

```
def review_list(review_id):

  review = review_json(review_id)
  
  if len (review.depends) == 0 :
 return [review_id , review.summary]
  elif len (review.depends) == 1:
 return review_list(review.depends.id) + [review_id, review.summary]
  else:
 error()
```


- Vinod Kone


On Oct. 20, 2015, 7:28 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 20, 2015, 7:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39432: Add /master/frameworks to master endpoint

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/#review103664
---



src/master/http.cpp (line 534)


Can you add a test for this in master_tests similar to what we did for 
/slaves endpoint?


- Vinod Kone


On Oct. 19, 2015, 6:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39432/
> ---
> 
> (Updated Oct. 19, 2015, 6:31 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add /master/frameworks to master endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
> 
> Diff: https://reviews.apache.org/r/39432/diff/
> 
> 
> Testing
> ---
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks; 
> 2>/dev/null| jq .
> {
>   "unregistered_frameworks": [],
>   "frameworks": [
> {
>   "webui_url": "",
>   "user": "root",
>   "used_resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "unregistered_time": 0,
>   "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "hostname": "devstack007.cn.ibm.com",
>   "failover_timeout": 0,
>   "executors": [],
>   "completed_tasks": [],
>   "checkpoint": false,
>   "capabilities": [],
>   "active": true,
>   "name": "",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "offers": [],
>   "pid": 
> "scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
>   "registered_time": 1445236263.95058,
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "role": "*",
>   "tasks": [
> {
>   "statuses": [
> {
>   "timestamp": 1445236266.63443,
>   "state": "TASK_RUNNING",
>   "container_status": {
> "network_infos": [
>   {
> "ip_address": "9.111.242.187"
>   }
> ]
>   }
> }
>   ],
>   "state": "TASK_RUNNING",
>   "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "name": "cluster-test",
>   "id": "cluster-test",
>   "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "executor_id": ""
> }
>   ]
> }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39569: Added output operator for Executor struct in agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
---

(Updated Oct. 22, 2015, 11:07 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Review comments from Neil + Moved the ostream function down


Repository: mesos


Description
---

See summary. Needed for https://reviews.apache.org/r/38874


Diffs (updated)
-

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
---


Thanks,

Anand Mazumdar

Re: Review Request 39421: Add agent version to /master/slaves endpoint

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/
---

(Updated Oct. 23, 2015, 12:17 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Viond's comments


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add agent version to /master/slaves endpoint


Diffs (updated)
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 

Diff: https://reviews.apache.org/r/39421/diff/


Testing
---

root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
"http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
{
  "slaves": [
{
  "version": "0.26.0",  Here
  "used_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "unreserved_resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "resources": {
"ports": "[31000-32000]",
"mem": 2808,
"disk": 1399183,
"cpus": 4
  },
  "reserved_resources": {},
  "active": true,
  "attributes": {},
  "hostname": "devstack007.cn.ibm.com",
  "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
  "offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "pid": "slave(1)@9.111.242.187:5051",
  "registered_time": 1445174743.70792,
  "reregistered_time": 1445174743.7085
}
  ]
}


Thanks,

Guangya Liu

Re: Review Request 39421: Add agent version to /master/slaves endpoint

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39421/#review103703
---


Patch looks great!

Reviews applied: [39421]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 12:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39421/
> ---
> 
> (Updated Oct. 23, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add agent version to /master/slaves endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
> 
> Diff: https://reviews.apache.org/r/39421/diff/
> 
> 
> Testing
> ---
> 
> root@devstack007:~/src/mesos/bug-fix/mesos/build# curl 
> "http://9.111.242.187:5050/master/slaves; 2>/dev/null| jq .
> {
>   "slaves": [
> {
>   "version": "0.26.0",  Here
>   "used_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "unreserved_resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "resources": {
> "ports": "[31000-32000]",
> "mem": 2808,
> "disk": 1399183,
> "cpus": 4
>   },
>   "reserved_resources": {},
>   "active": true,
>   "attributes": {},
>   "hostname": "devstack007.cn.ibm.com",
>   "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "pid": "slave(1)@9.111.242.187:5051",
>   "registered_time": 1445174743.70792,
>   "reregistered_time": 1445174743.7085
> }
>   ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 11:24 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description (updated)
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.


Diffs
-

  docs/networking-for-mesos-managed-containers.md 33568a8 
  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/test_hook_module.cpp 43d6cb9 
  src/slave/slave.cpp e9f2d1b 
  src/tests/common/http_tests.cpp c2e7704 
  src/tests/hook_tests.cpp 5a5d019 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39385: Fixed link conversion regexp in website.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/
---

(Updated Oct. 22, 2015, 11:03 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

More testing.


Repository: mesos


Description
---

The previous regexp was:

/\((.*)(\.md)\)/

Given text like:

Text (comment): [link](foo.md)

This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
seems unlikely to be the desired result.


Diffs (updated)
-

  site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c 

Diff: https://reviews.apache.org/r/39385/diff/


Testing (updated)
---

Tested using support/site-docker -- a few places where the old regexp screwed 
up were corrected, otherwise no changes observed.


Thanks,

Neil Conway

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote:
> > src/common/http.cpp, lines 165-180
> > 
> >
> > Dumb question -- could we have used `JSON::Protobuf()` instead?

Hey Kapil, I'll try it out.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103650
---


On Oct. 22, 2015, 5:45 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 5:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp f56d8a1 
>   src/tests/common/http_tests.cpp c2e7704 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 11:30 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Summary (updated)
-

Clarify NetworkInfo semantics for IP addresses and group policies.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.


Diffs
-

  docs/networking-for-mesos-managed-containers.md 33568a8 
  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/test_hook_module.cpp 43d6cb9 
  src/slave/slave.cpp e9f2d1b 
  src/tests/common/http_tests.cpp c2e7704 
  src/tests/hook_tests.cpp 5a5d019 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39385: Fixed link conversion regexp in website.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review103692
---


Patch looks great!

Reviews applied: [39385]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 11:03 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> ---
> 
> (Updated Oct. 22, 2015, 11:03 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous regexp was:
> 
> /\((.*)(\.md)\)/
> 
> Given text like:
> 
> Text (comment): [link](foo.md)
> 
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
> 
> 
> Diffs
> -
> 
>   site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c 
> 
> Diff: https://reviews.apache.org/r/39385/diff/
> 
> 
> Testing
> ---
> 
> Tested using support/site-docker -- a few places where the old regexp screwed 
> up were corrected, otherwise no changes observed.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39569: Added output operator for Executor struct in agent

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/#review103693
---

Ship it!


Will land this shortly.


src/slave/slave.hpp (line 698)


s/ostream/stream/ to be consistent with the others here


- Ben Mahler


On Oct. 22, 2015, 11:26 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39569/
> ---
> 
> (Updated Oct. 22, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Needed for https://reviews.apache.org/r/38874
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
> 
> Diff: https://reviews.apache.org/r/39569/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/
---

(Updated Oct. 23, 2015, 1:39 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-3515
https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
---

This change adds the functionality for executors to `Subscribe` via the 
`api/v1/executor` endpoint. It also stores a marker file as part of the 
`Subscribe` call if framework `checkpointing` is enabled. This can then be used 
by the agent when recovering to wait for reconnecting back with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
`CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
the `Subscribe` call.


Diffs (updated)
-

  src/slave/http.cpp 80bda34e2b344b96d5d2f9c1fecd36046f67ab49 
  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/38877/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Changes
---

- Fill in NetworkInfo->ip_addresses in Docker executor and slave.
- Updated hook module test for NetworkInfo changes.
- Simplified NetworkInfo JSON serialization.
- Updated documentation.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Diffs (updated)
-

  docs/networking-for-mesos-managed-containers.md 33568a8 
  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/test_hook_module.cpp 43d6cb9 
  src/slave/slave.cpp e9f2d1b 
  src/tests/common/http_tests.cpp c2e7704 
  src/tests/hook_tests.cpp 5a5d019 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote:
> > src/common/http.cpp, lines 165-180
> > 
> >
> > Dumb question -- could we have used `JSON::Protobuf()` instead?
> 
> Connor Doyle wrote:
> Hey Kapil, I'll try it out.

Good catch, updated to use JSON::Protobuf() instead.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103650
---


On Oct. 22, 2015, 11:22 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39569: Added output operator for Executor struct in agent

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39569/
---

(Updated Oct. 22, 2015, 11:26 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Moved ostream function from Executor struct


Repository: mesos


Description
---

See summary. Needed for https://reviews.apache.org/r/38874


Diffs (updated)
-

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/39569/diff/


Testing
---


Thanks,

Anand Mazumdar

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote:
> > include/mesos/mesos.proto, lines 1395-1409
> > 
> >
> > I should have noticed it earlier, but does it make sense to make 
> > IPAddress a top level message? Nik?

Happy to change it, waiting on a second opinion unless you feel strongly about 
it Kapil.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103650
---


On Oct. 22, 2015, 11:30 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 11:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> 
> Diffs
> -
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103690
---


Wow! Awesome documentation work! A few suggestions below.

Mainly: We haven't planned 0.25.1, so let's bump to 0.26.0. The description is 
specific to isolators doing the heavy lifting, whereas we could be doing some 
of the IP assignment in the master (eventually).

Other than that; looks good!


docs/networking-for-mesos-managed-containers.md (line 140)


Let's change this to 0.26.0



include/mesos/mesos.proto (line 1389)


'the actual assigned IP adress' reads a bit odd. How about something like: 
"A user can request an automatically assigned IP (for example, through an IPAM 
service) or a specific IP"

No biggie; if you don't like the suggestion, feel free to drop



include/mesos/mesos.proto (lines 1392 - 1394)


We could, theoretically, have this be done from other places than the 
isolator. Wonder if we can abstract this out a bit



include/mesos/mesos.proto (line 1425)


s/0.25.1/0.26.0/



include/mesos/v1/mesos.proto (line 1343)


As a non-native speaker; what's the consistency around capitalizing 
framework :)



include/mesos/v1/mesos.proto (line 1350)


Agent and Master?



src/common/http.cpp (lines 165 - 166)


Can we inline JSON::Protobuf() instead?



src/examples/test_hook_module.cpp (line 261)


0.27.0?


- Niklas Nielsen


On Oct. 22, 2015, 4:30 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 4:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> 
> Diffs
> -
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39538: Windows: Moved `os::touch` to its own file, `stout/os/touch.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39538/#review103698
---

Ship it!


Confirmed that touch logic did not change.

- Joseph Wu


On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39538/
> ---
> 
> (Updated Oct. 21, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::touch` to its own file, `stout/os/touch.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/touch.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39538/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/
---

(Updated Oct. 23, 2015, 1:34 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-3480
https://issues.apache.org/jira/browse/MESOS-3480


Repository: mesos


Description
---

This change refactors the Executor struct on Agent and adds support for 
Executors to connect via the `api/v1/executor` endpoint on Agent. This is 
similar to the change done in Master for the Scheduler HTTP API.


Diffs (updated)
-

  src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 

Diff: https://reviews.apache.org/r/38874/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

[Till Toenshoff]

> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote:
> > Curious if we want to scope these for the whole files? Might be a bit hard 
> > to scope this correctly over time.

True that - also I noticed that I can totally not include the clang specific 
pragma as clang does pick up the GCC specifics already.


> On Oct. 21, 2015, 10:40 p.m., Ben Mahler wrote:
> > configure.ac, lines 769-774
> > 
> >
> > Could you include the comment here as well?

Aye


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103488
---


On Oct. 19, 2015, 4:27 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> ---
> 
> (Updated Oct. 19, 2015, 4:27 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 66f9b32 
>   src/authentication/cram_md5/authenticatee.cpp b03b44a 
>   src/authentication/cram_md5/authenticator.cpp f238872 
>   src/authentication/cram_md5/auxprop.cpp abf0f8d 
> 
> Diff: https://reviews.apache.org/r/39230/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> OSX, clang3.7 + gcc4.9
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 39474: Make the Command Scheduler use the HTTP Scheduler Library

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/
---

Review request for mesos.


Repository: mesos


Description
---

WIP: Make the Command Scheduler use the HTTP Scheduler Library


Diffs
-

  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 

Diff: https://reviews.apache.org/r/39474/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/
---

(Updated Oct. 22, 2015, 10:02 a.m.)


Review request for mesos and Michael Park.


Changes
---

Removed clang specific pragmas as clang does pick up the GCC specific ones 
already. Updated configure.ac to also contain the specific comment.


Bugs: MESOS-3030
https://issues.apache.org/jira/browse/MESOS-3030


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  configure.ac 66f9b32 
  src/authentication/cram_md5/authenticatee.cpp b03b44a 
  src/authentication/cram_md5/authenticator.cpp f238872 
  src/authentication/cram_md5/auxprop.cpp abf0f8d 

Diff: https://reviews.apache.org/r/39230/diff/


Testing
---

./configure && make check 
OSX, clang3.7 + gcc4.9


Thanks,

Till Toenshoff

Re: Review Request 39285: Added Quota Request Validation.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103539
---



src/master/master.hpp (line 878)


s/Check/Checks
s/Request/request

Do we capitalize "quota"?



src/master/master.hpp (lines 879 - 882)


Let's document more:
- Role is known to the master.
- Irrelevant fields in `Resources` are not set (i.e. reservation, disk).



src/master/master.hpp (lines 1976 - 1985)


Either comment or bookkeeping should go away. As per comment, do you think 
we need `quotaInfo` here now? It does not seem you use this variable in this 
RR. I'd suggest to kill `quotaInfo` here.



src/master/quota_handler.cpp (lines 51 - 52)


This does not apply any more, right?



src/master/quota_handler.cpp (line 60)


I think we should move this check to `Master::QuotaHandler::set()` and even 
convert to `CHECK_` because it's an internal invarian at this moment. It would 
be nice to reuse this function for other quota requests, means we do not need 
any checks here.



src/master/quota_handler.cpp (line 61)


I think we should agree on terminology: "quota request", "Quota Request", 
or "QuotaRequest".

We should be consistent here and everywhere (also in other RRs).



src/master/quota_handler.cpp (lines 67 - 68)


This fits in one line.



src/master/quota_handler.cpp (lines 71 - 72)


How about initializing `role` with QuotaInfo.role? Or we agreed not to send 
role as part of the JSON request?



src/master/quota_handler.cpp (line 88)


Let's be consistent and use present simple everywhere : ).

s/Checking that Resource does not contain non-relevant fields./Check that 
Resources does not contain fields non-relevant for quota.



src/master/quota_handler.cpp (line 89)


I think we can kill this comment.



src/master/quota_handler.cpp (line 93)


And this one.



src/master/quota_handler.cpp (line 97)


And this one.



src/master/quota_handler.cpp (line 102)


The code does something different to what the comment says : ).



src/master/quota_handler.cpp (line 115)


s/all resources are scalar/the resource is scalar



src/master/quota_handler.cpp (line 118)


This sounds incomplete to me. Maybe "includes" is better?



src/master/quota_handler.cpp (line 127)


We are not consistent in BadRequet error messages, but how about 
"Attempting to set quota for an unknown role ''"?



src/master/quota_handler.cpp (line 130)


s/Quota Info/QuotaInfo



src/master/quota_handler.cpp (lines 156 - 160)


This is a bug: not in sync with the way we store quotas:
```
master->quotas[quota.role()] = quota;
```.



src/master/quota_handler.cpp (line 159)


We do not support update currently, so the message is misleading. How about 
"Quota cannot be set for a role that already has quota"?



src/master/quota_handler.cpp (line 183)


Why this newline?


- Alexander Rukletsov


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review103583
---


Patch looks great!

Reviews applied: [39276, 37998, 39472, 37999, 38000, 38094, 38627, 38950, 39043]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 1:01 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Oct. 22, 2015, 1:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103587
---



src/master/quota_handler.cpp (line 162)


We don't need this comment any more, right?


- Alexander Rukletsov


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103710
---



src/tests/scheduler_tests.cpp (lines 999 - 1008)


Wondering, why did you change order here i.e. move this piece of code up ? 

Now, with using `FUTURE_DISPATCH` you can gurrantee that `Suppress` would 
be completed before the `Clock` is advanced. Am I missing something ?



src/tests/scheduler_tests.cpp (line 1007)


This alone won't suffice. AFAIK, the `Future` returned by `FUTURE_DISPATCH` 
is marked ready when the function is invoked not neccessarily when the function 
has completely executed.

You would want to pause/settle the clock too. The modified code would look 
like:

```
 Future suppressOffers =
FUTURE_DISPATCH(_, ::suppressOffers);

  {
Call call;
call.mutable_framework_id()->CopyFrom(id);
call.set_type(Call::SUPPRESS);

mesos.send(call);
  }

  AWAIT_READY(suppressOffers);
  
  // Wait for suppress to be complete.
  Clock::pause();
  Clock::settle();
  
  // No offers should be sent within 100 mins because the framework
  // suppressed offers.
  Clock::advance(Minutes(100));
  Clock::settle();
```

Here is some more info: 
http://mesos.apache.org/documentation/latest/testing-patterns/ . What do you 
think ?


- Anand Mazumdar


On Oct. 23, 2015, 2:32 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
> call DECLINE.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/
---

(Updated Oct. 23, 2015, 4:24 a.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, 
and Jiang Yan Xu.


Bugs: MESOS-3429
https://issues.apache.org/jira/browse/MESOS-3429


Repository: mesos


Description
---

Allow HTTP response codes to be checked with code.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/src/decoder.hpp 53b8079968a0145651bad9d11aa4be2b504de57a 
  3rdparty/libprocess/src/http.cpp ebf76093d654397260fc8da84c4f2b0fd6541483 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
  3rdparty/libprocess/src/tests/benchmarks.cpp 
11e9217343c2c97da7bc392e426f5112f88fe43d 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 
  3rdparty/libprocess/src/tests/process_tests.cpp 
708b8d9a9f4987ddec5406233666ae3f2c93eb07 

Diff: https://reviews.apache.org/r/38416/diff/


Testing
---

make


Thanks,

Timothy Chen

Re: Review Request 38779: Use new HTTP status code check in scheduler.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/
---

(Updated Oct. 23, 2015, 4:25 a.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Repository: mesos


Description
---

Use new HTTP status code check in scheduler.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 33e4d7cd0dfb3c4d4ef928707104034eff634ff1 

Diff: https://reviews.apache.org/r/38779/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 39432: Add /master/frameworks to master endpoint

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/
---

(Updated Oct. 23, 2015, 2:01 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Viond's comments


Bugs: MESOS-3735
https://issues.apache.org/jira/browse/MESOS-3735


Repository: mesos


Description
---

Add /master/frameworks to master endpoint


Diffs (updated)
-

  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
  src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
  src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 

Diff: https://reviews.apache.org/r/39432/diff/


Testing (updated)
---

Unit Test:
[==] Running 2 tests from 1 test case.
[--] Global test environment set-up.
[--] 2 tests from MasterTest
[ RUN  ] MasterTest.FrameworksEndpointWithoutFrameworks
[   OK ] MasterTest.FrameworksEndpointWithoutFrameworks (804 ms)
[ RUN  ] MasterTest.FrameworksEndpointOneFramework
[   OK ] MasterTest.FrameworksEndpointOneFramework (918 ms)
[--] 2 tests from MasterTest (1722 ms total)
 
[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (1742 ms total)
[  PASSED  ] 2 tests.


gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks; 
2>/dev/null| jq .
{
  "unregistered_frameworks": [],
  "frameworks": [
{
  "webui_url": "",
  "user": "root",
  "used_resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "unregistered_time": 0,
  "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
  "hostname": "devstack007.cn.ibm.com",
  "failover_timeout": 0,
  "executors": [],
  "completed_tasks": [],
  "checkpoint": false,
  "capabilities": [],
  "active": true,
  "name": "",
  "offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
  },
  "offers": [],
  "pid": 
"scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
  "registered_time": 1445236263.95058,
  "resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "role": "*",
  "tasks": [
{
  "statuses": [
{
  "timestamp": 1445236266.63443,
  "state": "TASK_RUNNING",
  "container_status": {
"network_infos": [
  {
"ip_address": "9.111.242.187"
  }
]
  }
}
  ],
  "state": "TASK_RUNNING",
  "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
  "resources": {
"mem": 256,
"disk": 0,
"cpus": 1
  },
  "name": "cluster-test",
  "id": "cluster-test",
  "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
  "executor_id": ""
}
  ]
}
  ],
  "completed_frameworks": []
}


Thanks,

Guangya Liu

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/
---

(Updated Oct. 23, 2015, 2:32 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Vinod's comments


Bugs: MESOS-3733
https://issues.apache.org/jira/browse/MESOS-3733


Repository: mesos


Description (updated)
---

Root Cause: The reason is that the DECLINE call set filter as 1hr,
the Clock::advance set as 100m. A race condition is that both DECLINE
and SUPPRESS started up in different threads and the call Clock::advance
may be called before SUPPRESS finished. The clock advanced for 100m which
is greater than 1hr, this caused the allocator start to allocate resource
again and ASSERT_TRUE(event.isPending()) will be failed.

Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
call DECLINE.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 

Diff: https://reviews.apache.org/r/39548/diff/


Testing
---

Platform: Ubuntu 14.04
make 
make check
bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
--gtest_repeat=-1 --gtest_break_on_failure


Thanks,

Guangya Liu

Re: Review Request 39432: Add /master/frameworks to master endpoint

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39432/#review103706
---


Patch looks great!

Reviews applied: [39432]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 2:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39432/
> ---
> 
> (Updated Oct. 23, 2015, 2:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3735
> https://issues.apache.org/jira/browse/MESOS-3735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add /master/frameworks to master endpoint
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39432/diff/
> 
> 
> Testing
> ---
> 
> Unit Test:
> [==] Running 2 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 2 tests from MasterTest
> [ RUN  ] MasterTest.FrameworksEndpointWithoutFrameworks
> [   OK ] MasterTest.FrameworksEndpointWithoutFrameworks (804 ms)
> [ RUN  ] MasterTest.FrameworksEndpointOneFramework
> [   OK ] MasterTest.FrameworksEndpointOneFramework (918 ms)
> [--] 2 tests from MasterTest (1722 ms total)
>  
> [--] Global test environment tear-down
> [==] 2 tests from 1 test case ran. (1742 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> gyliu@devstack007:~$ curl "http://9.111.242.187:5050/master/frameworks; 
> 2>/dev/null| jq .
> {
>   "unregistered_frameworks": [],
>   "frameworks": [
> {
>   "webui_url": "",
>   "user": "root",
>   "used_resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "unregistered_time": 0,
>   "id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "hostname": "devstack007.cn.ibm.com",
>   "failover_timeout": 0,
>   "executors": [],
>   "completed_tasks": [],
>   "checkpoint": false,
>   "capabilities": [],
>   "active": true,
>   "name": "",
>   "offered_resources": {
> "mem": 0,
> "disk": 0,
> "cpus": 0
>   },
>   "offers": [],
>   "pid": 
> "scheduler-43ee3a42-9302-4815-8a07-500e42367f41@9.111.242.187:60454",
>   "registered_time": 1445236263.95058,
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "role": "*",
>   "tasks": [
> {
>   "statuses": [
> {
>   "timestamp": 1445236266.63443,
>   "state": "TASK_RUNNING",
>   "container_status": {
> "network_infos": [
>   {
> "ip_address": "9.111.242.187"
>   }
> ]
>   }
> }
>   ],
>   "state": "TASK_RUNNING",
>   "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
>   "resources": {
> "mem": 256,
> "disk": 0,
> "cpus": 1
>   },
>   "name": "cluster-test",
>   "id": "cluster-test",
>   "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
>   "executor_id": ""
> }
>   ]
> }
>   ],
>   "completed_frameworks": []
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103711
---


Patch looks great!

Reviews applied: [39548]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 2:32 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
> call DECLINE.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Guangya Liu]

> On 十月 23, 2015, 3:53 a.m., Anand Mazumdar wrote:
> > src/tests/scheduler_tests.cpp, lines 999-1008
> > 
> >
> > Wondering, why did you change order here i.e. move this piece of code 
> > up ? 
> > 
> > Now, with using `FUTURE_DISPATCH` you can gurrantee that `Suppress` 
> > would be completed before the `Clock` is advanced. Am I missing something ?

I think that the order of SUPPRESS and DECLINEN is not that important as long 
as we can make sure the offer will be send after decline filter time out. So 
here it is OK to adjust and keep the order.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103710
---


On 十月 23, 2015, 2:32 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated 十月 23, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
> call DECLINE.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39474: Make the Command Scheduler use the HTTP Scheduler Library

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review103565
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Oct. 22, 2015, 9:19 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated Oct. 22, 2015, 9:19 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Make the Command Scheduler use the HTTP Scheduler Library
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Oct. 22, 2015, 2:57 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase to account for changes in previous review.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Oct. 22, 2015, 3:01 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
Toenshoff.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
  src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
  src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103572
---


Patch looks great!

Reviews applied: [39230]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> ---
> 
> (Updated Oct. 22, 2015, 10:02 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 66f9b32 
>   src/authentication/cram_md5/authenticatee.cpp b03b44a 
>   src/authentication/cram_md5/authenticator.cpp f238872 
>   src/authentication/cram_md5/auxprop.cpp abf0f8d 
> 
> Diff: https://reviews.apache.org/r/39230/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> OSX, clang3.7 + gcc4.9
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review103566
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 29)


Mention that the buffer is thread local.



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (lines 49 - 52)


Suggestion:

> Implementations of strerror_r from glibc-2.15 or earlier which do not 
define _GNU_SOURCE and define _POSIX_C_SOURCE=200112L contain a bug where the 
global errno is illegally modify whenever strerr_r run into errors itself.


- Alexander Rojas


On Oct. 22, 2015, 9:46 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> ---
> 
> (Updated Oct. 22, 2015, 9:46 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar 
> to strerror. We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Oct. 22, 2015, 2:57 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase to account for changes in previous review.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
  3rdparty/libprocess/src/tests/http_tests.cpp 
d13d3888abbf3db552df4a9f83e54667e598ded9 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/
---

(Updated 十月 23, 2015, 5:29 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Anand's comments


Bugs: MESOS-3733
https://issues.apache.org/jira/browse/MESOS-3733


Repository: mesos


Description
---

Root Cause: The reason is that the DECLINE call set filter as 1hr,
the Clock::advance set as 100m. A race condition is that both DECLINE
and SUPPRESS started up in different threads and the call Clock::advance
may be called before SUPPRESS finished. The clock advanced for 100m which
is greater than 1hr, this caused the allocator start to allocate resource
again and ASSERT_TRUE(event.isPending()) will be failed.

Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
call DECLINE.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 

Diff: https://reviews.apache.org/r/39548/diff/


Testing
---

Platform: Ubuntu 14.04
make 
make check
bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
--gtest_repeat=-1 --gtest_break_on_failure


Thanks,

Guangya Liu

Re: Review Request 38779: Use new HTTP status code check in scheduler.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review103718
---


Patch looks great!

Reviews applied: [38416, 38779]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 4:25 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38779/
> ---
> 
> (Updated Oct. 23, 2015, 4:25 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use new HTTP status code check in scheduler.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 33e4d7cd0dfb3c4d4ef928707104034eff634ff1 
> 
> Diff: https://reviews.apache.org/r/38779/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

> On Oct. 22, 2015, 10:57 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, lines 64-66
> > 
> >
> > This is an API change which contradicts the API described in the design 
> > doc and differs from, for example, dynamic reservations. Mind elaborating 
> > why you have opted for this change?

No strong preference, will switch back.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103555
---


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

> On Oct. 21, 2015, 10:22 p.m., Kapil Arya wrote:
> > src/launcher/executor.cpp, line 49
> > 
> >
> > This file should go at the end of the stout includes ... don't we put 
> > stout/XX.hpp before stout/DIR/XX.hpp?

Let's keep lexicographical sort with an ASCII code page (which plays nicely 
with everything from sort to clang-format) while the discussion for the coding 
guidelines MESOS-2275 is still in flux.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review103482
---


On Oct. 22, 2015, 7:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> ---
> 
> (Updated Oct. 22, 2015, 7:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
>   src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/linux/routing/link/internal.hpp 
> 015c0ef5be516d7786c96a96437cced1ae8487fa 
>   src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
>   src/slave/containerizer/mesos/launch.cpp 
> 09d4d8f4d6837e93a82deef76ca07e2167d6a405 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
>   src/tests/containerizer/memory_test_helper.cpp 
> 8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/39008/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39008: Used thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/
---

(Updated Oct. 22, 2015, 7:52 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Corrected dependency chain.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

Switch call sites to using safe strerror_r wrapper.


Diffs
-

  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa 
  src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
  src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 
  src/slave/containerizer/isolators/filesystem/posix.cpp 
eec510c4f7655d67b33ad90210eeb57fcc910684 
  src/slave/containerizer/isolators/filesystem/shared.cpp 
73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 
  src/slave/containerizer/mesos/launch.cpp 
09d4d8f4d6837e93a82deef76ca07e2167d6a405 
  src/slave/containerizer/provisioner/backends/bind.cpp 
1fe1746c0bc1c9c12e1378e6438122a91b58316b 
  src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
  src/tests/containerizer/memory_test_helper.cpp 
8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
  src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 

Diff: https://reviews.apache.org/r/39008/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp, line 878
> > 
> >
> > s/Check/Checks
> > s/Request/request
> > 
> > Do we capitalize "quota"?

I did, will adjust to you style


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103539
---


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
---

Ship it!


Confirmed that logic of `utime` did not change.


3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp (lines 17 - 21)


Nit: Can you flip the `#ifndef`?  No need to negate the conditional if 
there's an `#else`.


- Joseph Wu


On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39537/
> ---
> 
> (Updated Oct. 21, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39537/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 22, 2015, 5:08 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Changes
---

Updated JSON formatters, added JSON tests, addressed naming tweak for IPAddress 
message.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.

NOTE: the slave should also be updated in order to set the new IpAddress 
message in ContainerStatus in case network isolation modules are not installed.


Diffs (updated)
-

  include/mesos/mesos.proto 4a16be1 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp 99b843a 
  src/tests/common/http_tests.cpp 8a01ffc 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote:
> > Can you also sync this with the V1 API?  (If so, I'll remove that section 
> > from this: https://reviews.apache.org/r/39502 ).

Yes, I will update the v1 proto file as well.  Thanks for the reminder.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103497
---


On Oct. 22, 2015, 5:08 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 5:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress 
> message in ContainerStatus in case network isolation modules are not 
> installed.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 4a16be1 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp 99b843a 
>   src/tests/common/http_tests.cpp 8a01ffc 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>