Re: Review Request 39886: Added documentation about roles.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105221
---



docs/roles.md (line 60)


s/at/from?



docs/roles.md (line 75)


s/resource. Then/resource, then



docs/roles.md (lines 79 - 80)


s/assigning _weights_ to different roles/assigning different _weights_ to 
roles


- Guangya Liu


On 十一月 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated 十一月 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39944: Add prefix option for os::environment.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/
---

(Updated Nov. 5, 2015, 8:25 a.m.)


Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.


Changes
---

Fix error in gcc 4.8


Bugs: MESOS-3815
https://issues.apache.org/jira/browse/MESOS-3815


Repository: mesos


Description
---

Add prefix option for os::environment.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
91d82a8fae27c002458cad0bbdc45b312d2ec70d 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39944/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 39945: Pass SSL related environment variables to executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/
---

(Updated Nov. 5, 2015, 8:25 a.m.)


Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.


Changes
---

Fix error in gcc 4.8


Repository: mesos


Description
---

Pass SSL related environment variables to executor.


Diffs (updated)
-

  src/slave/containerizer/containerizer.cpp 
06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 

Diff: https://reviews.apache.org/r/39945/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 39968: Enable endpoint include nested paths

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39968/#review105225
---


Patch looks great!

Reviews applied: [39968]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 7:25 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39968/
> ---
> 
> (Updated Nov. 5, 2015, 7:25 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3833
> https://issues.apache.org/jira/browse/MESOS-3833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable endpoint include nested paths
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/help.cpp 3f82c0fb41a0d9388d88dbecc9289d705c2a343a 
> 
> Diff: https://reviews.apache.org/r/39968/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39102: Added documentation for JSON resources.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39102/#review105237
---


Looks great, but we need to fix the consistency issue between the 
configuration.md and flags.cpp, and not recommend ``cat resources.txt``.


docs/attributes-resources.md (lines 45 - 49)


Provide at least one example with a role



docs/attributes-resources.md (line 104)


Inconsistent spacing after ':'s



docs/attributes-resources.md (line 164)


Why ``cat resources.txt`` instead of 
`--resources=file:///path/to/resources.txt`?



docs/attributes-resources.md (line 166)


Note: the "default role" is set by `--default_role`



docs/configuration.md (line 1398)


Did you change src/slave/flags.cpp to match this new description?



docs/configuration.md (line 1406)


Other JSON flags have text like:

"The value could be a JSON formatted string of rules or a\n"
"file path containing the JSON formated rules used in the endpoints\n"
"firewall. Path must be of the form 'file:///path/to/file'\n"
"or '/path/to/file'.\n"


- Adam B


On Nov. 4, 2015, 9:26 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39102/
> ---
> 
> (Updated Nov. 4, 2015, 9:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for JSON resources.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39102/diff/
> 
> 
> Testing
> ---
> 
> Viewed the relevant documentation sections ('Attributes and Resources' & 
> 'Configuration') using the mesos-website-container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39848: Validate revocable resources

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39848/#review105226
---


Patch looks great!

Reviews applied: [39845, 39848]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 7:36 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39848/
> ---
> 
> (Updated Nov. 5, 2015, 7:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2647
> https://issues.apache.org/jira/browse/MESOS-2647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validates if there are enough revocable resources when launching
> the task on slave.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ddeece4334b13cf8b5ab7d87012bbf946640025b 
> 
> Diff: https://reviews.apache.org/r/39848/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39945: Pass SSL related environment variables to executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/#review105230
---


Patch looks great!

Reviews applied: [39944, 39945]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 8:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39945/
> ---
> 
> (Updated Nov. 5, 2015, 8:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass SSL related environment variables to executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 5, 2015, 4:02 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39112: RegistryClient refactor: fixed variable names

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39112/
---

(Updated Nov. 5, 2015, 4:02 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: fixed variable names. This patch will serve as 
catch-all for any variable name related changes in the refactor.


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/39112/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39595: Took mtime into account in the fetcher cache.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105257
---


Patch looks great!

Reviews applied: [39594, 39595]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 3:45 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Nov. 5, 2015, 3:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/
---

(Updated Nov. 5, 2015, 6:05 p.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3705
https://issues.apache.org/jira/browse/MESOS-3705


Repository: mesos


Description
---

When using the same socket to send multiple HTTP requests to different actors. 
If the actor responsible for handling the first request is stuck handling 
another event while a subsequent request can reply immediatly, the order of the 
responses is altered violating HTTP Pipelining.

This patch fixes that problem enforcing that every response is sent in the 
order the corresponding request arrived. It also adds a test to reproduce the 
issue and verify the fix works.


Diffs (updated)
-

  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39276/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39882: Fixed unsafe hashmap.at call

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39882/
---

(Updated Nov. 5, 2015, 4 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

reviews addressed.


Repository: mesos


Description
---

Fixed unsafe hashmap.at call


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39882/diff/


Testing
---


Thanks,

Jojy Varghese

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39053/
---

(Updated Nov. 5, 2015, 4:03 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: priv method const'ness


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39053/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/
---

(Updated Nov. 5, 2015, 4:01 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

rebased.


Repository: mesos


Description
---

Puller refactor: moved untar to a common place


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39250/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 5, 2015, 4 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39839: RegistryClient refactor: Changed getManifest interface

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39839/#review105270
---

Ship it!


Ship It!


src/tests/containerizer/provisioner_docker_tests.cpp (line 690)


style wise, I suggest making this simpler:

 Future manifestResponseFuture =
registryClient.get()->getManifest(
parseImageName("library/busybox"),
None());


- Timothy Chen


On Nov. 5, 2015, 3:50 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39839/
> ---
> 
> (Updated Nov. 5, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced path and tag parameters with Image::Name
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/39839/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38579: Refactored registry client: split large methods.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Nov. 5, 2015, 5:57 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Summary (updated)
-

Refactored registry client: split large methods.


Repository: mesos


Description
---

- Cleanup and broke big methods into smaller chunks.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
---

(Updated Nov. 5, 2015, 6:07 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

rebase


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

`ProcessManager::handle()` is a method used to process HTTP requests, its 
signature returns a boolean which is not used anywhere and it doesn't allow for 
asynchronous operations within handle.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/37998/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38579: Refactored registry client: split large methods.

[Jojy Varghese]

> On Nov. 5, 2015, 5:54 p.m., Timothy Chen wrote:
> > Can you update the title to something more specific of what this patch does?

updated.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105271
---


On Nov. 5, 2015, 5:57 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> ---
> 
> (Updated Nov. 5, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Cleanup and broke big methods into smaller chunks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
---

(Updated Nov. 5, 2015, 4:02 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Added factory method.
 Removed digest.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39017/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 5, 2015, 6:07 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39015/#review105275
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 5, 2015, 4:01 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39015/
> ---
> 
> (Updated Nov. 5, 2015, 4:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: expanded abbreviated names.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39015/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38747: Adding digest utilities

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/
---

(Updated Nov. 5, 2015, 4:04 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Added SHA256, SHA512 implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
99c9754b6a5c7ceb12808a782da9cb9fb3fc731e 
  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38747/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38579: Refactored registry client

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Nov. 5, 2015, 4:03 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

- Cleanup and broke big methods into smaller chunks.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/
---

(Updated Nov. 5, 2015, 4:03 p.m.)


Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.


Changes
---

rebased


Repository: mesos


Description
---

Integrated remote puller with store. Tests will follow.


Diffs (updated)
-

  src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
87d80026939a326bd1169f46906e36d6ef19f546 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
bb02d650e16d45fcf337a7954f7a26143fb2c69f 
  src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
  src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/38580/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39886: Added documentation about roles.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/
---

(Updated Nov. 5, 2015, 5:42 p.m.)


Review request for mesos and Adam B.


Changes
---

Address comments.


Bugs: MESOS-3819
https://issues.apache.org/jira/browse/MESOS-3819


Repository: mesos


Description
---

Also removed a redundant (and arguably slightly wrong) assertion about the
status of static reservations.


Diffs (updated)
-

  docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
  docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
  docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
  docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
  docs/roles.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39886/diff/


Testing
---

Previewed with the support/site Docker container.


Thanks,

Neil Conway

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39015/
---

(Updated Nov. 5, 2015, 4:01 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: expanded abbreviated names.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39015/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Nov. 5, 2015, 4:01 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39873/
---

(Updated Nov. 5, 2015, 4:26 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

updated comments per benm.


Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864


Repository: mesos


Description
---

The master now doesn't change the latest state of a task if it has already 
terminated. But it still updates the status update state and uuid.


Diffs (updated)
-

  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 

Diff: https://reviews.apache.org/r/39873/diff/


Testing
---

make check

Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of the 
time without this fix.


Thanks,

Vinod Kone

Re: Review Request 39944: Add prefix option for os::environment.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105256
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp (line 34)


Where do we need to use this now?
I rather not add regex if we never end up using this.


- Timothy Chen


On Nov. 5, 2015, 8:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39944/
> ---
> 
> (Updated Nov. 5, 2015, 8:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
> https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add prefix option for os::environment.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
> 91d82a8fae27c002458cad0bbdc45b312d2ec70d 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 
> 
> Diff: https://reviews.apache.org/r/39944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/#review105261
---


Bad patch!

Reviews applied: [39838]

Failed command: ./support/apply-review.sh -n -r 39838

Error:
 2015-11-05 17:09:16 URL:https://reviews.apache.org/r/39838/diff/raw/ 
[1452/1452] -> "39838.patch" [1]
error: patch failed: src/tests/containerizer/provisioner_docker_tests.cpp:686
error: src/tests/containerizer/provisioner_docker_tests.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 5, 2015, 4:01 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39250/
> ---
> 
> (Updated Nov. 5, 2015, 4:01 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Puller refactor: moved untar to a common place
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f314f20d989ed0125e15d2a14d0f8e56c56976d5 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 8010b8aa75a2fc2e4b537f915f9dca028e407b63 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
>   src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39250/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39882: Fixed unsafe hashmap.at call

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39882/#review105266
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 5, 2015, 4 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39882/
> ---
> 
> (Updated Nov. 5, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unsafe hashmap.at call
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39882/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39832: RegistryClient refactor: fully qualified name for URL

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39832/#review105265
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 4, 2015, 11:48 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39832/
> ---
> 
> (Updated Nov. 4, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed "using http::URL" to be more explicit and match the rest of http 
> types.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39832/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38579: Refactored registry client

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105271
---


Can you update the title to something more specific of what this patch does?

- Timothy Chen


On Nov. 5, 2015, 4:03 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> ---
> 
> (Updated Nov. 5, 2015, 4:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Cleanup and broke big methods into smaller chunks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Nov. 5, 2015, 6:16 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebase based on the changes on previous patches.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/tests/http_tests.cpp 
7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Nov. 5, 2015, 6:26 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
Toenshoff.


Changes
---

Forcing buildbot to run.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
  src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39873/
---

(Updated Nov. 5, 2015, 6:04 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to kick off another reviewbot run.


Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864


Repository: mesos


Description
---

The master now doesn't change the latest state of a task if it has already 
terminated. But it still updates the status update state and uuid.


Diffs (updated)
-

  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 

Diff: https://reviews.apache.org/r/39873/diff/


Testing
---

make check

Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of the 
time without this fix.


Thanks,

Vinod Kone

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/#review105285
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 478)


You need to check for errors in all the find JSON calls.


- Timothy Chen


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39017/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added factory method.
>  Removed digest.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39017/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105288
---



include/mesos/master/allocator.hpp (lines 355 - 356)


This bit is somewhat unclear: 
"the group of roles with quota set" sounds like it is referring to an 
argument, but it's actually referring to the implementation, right?



include/mesos/master/allocator.hpp (lines 370 - 371)


Suggestion: s/with quota and without/with or without quota/


- Joseph Wu


On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> ---
> 
> (Updated Oct. 23, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp 
> c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/
---

(Updated Nov. 5, 2015, 7:30 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

removed dependency in chain


Repository: mesos


Description
---

Puller refactor: moved untar to a common place


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39250/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 5, 2015, 8:12 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

replaced libevent with libev as default configuration.


Repository: mesos


Description
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Joseph Wu]

> On Oct. 13, 2015, 8:35 a.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 60
> > 
> >
> > Should we follow the pattern of other validation routines where we use 
> > the validation namespace and pull these utility routines into a separate 
> > file?
> > 
> > I think we can separate the validation of the request from the content 
> > of the protobuf. Syntax vs. semantic.
> > 
> > See maintenance as an example.
> 
> Alexander Rukletsov wrote:
> The reason it's conflated into one function is because in order to do 
> proper validation we should convert JSON to protobuf. Some checks are 
> performed with the JSON object and some with the converted protobuf. I though 
> that having three functions `validateJSON`, `convertToQuotaInfo`, and 
> `validateQuotaInfo` is too much.

What specific validation are you doing to the JSON objects (other than 
converting to Protobuf)?  And why can't the validation wait until after the 
JSON->Protobuf conversion sufficient?


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review102247
---


On Nov. 5, 2015, 11:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/#review105284
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 584)


If we don't use this can we skip saving this for now? Let's add it when we 
need to use it just to keep thing simple as possible.


- Timothy Chen


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39017/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added factory method.
>  Removed digest.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39017/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

(Updated Nov. 5, 2015, 7:16 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
---

(Updated Nov. 5, 2015, 7:15 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

review comments addressed


Repository: mesos


Description
---

Added factory method.
 Removed digest.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39017/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
---



src/master/quota_handler.cpp (line 52)


I feel this shouldn't be left for later.



src/master/quota_handler.cpp (lines 70 - 74)


These are TODO's right?

Also, typos:
s/including:/including/
The third "Check" s/Check/check/
s/reservatin/reservation/



src/master/quota_handler.cpp (lines 83 - 88)


Why don't you just parse a QuotaInfo object instead of a form-serialized 
body (with JSON components)?

The maintenance endpoints do this for simplicity.



src/master/quota_handler.cpp (line 118)


Typo: s/reuqest/request/


- Joseph Wu


On Nov. 5, 2015, 11:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 5, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

[Kapil Arya]

> On Nov. 3, 2015, 1:42 p.m., Kapil Arya wrote:
> > Can we merge the Tests from https://reviews.apache.org/r/39769/?
> 
> Timothy Chen wrote:
> I thought you'd like to merge that patch seperately?

Yes, we'll do that.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39866/#review104945
---


On Nov. 4, 2015, 3:58 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39866/
> ---
> 
> (Updated Nov. 4, 2015, 3:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added containerInfo support for tasks in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4aad8a3be43b331efc6b8157b2fae090df16c1b4 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9fd69c1738e2300dbb843d259727010e24523cff 
> 
> Diff: https://reviews.apache.org/r/39866/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39866/#review105280
---

Ship it!


Ship It!

- Kapil Arya


On Nov. 4, 2015, 3:58 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39866/
> ---
> 
> (Updated Nov. 4, 2015, 3:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added containerInfo support for tasks in mesos containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 4aad8a3be43b331efc6b8157b2fae090df16c1b4 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9fd69c1738e2300dbb843d259727010e24523cff 
> 
> Diff: https://reviews.apache.org/r/39866/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 38579: Refactored registry client: split large methods.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Nov. 5, 2015, 7:17 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

- Cleanup and broke big methods into smaller chunks.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39015/
---

(Updated Nov. 5, 2015, 7:17 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: expanded abbreviated names.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39015/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review105286
---


Patch looks great!

Reviews applied: [39276, 37998, 37999, 38000, 38094, 38627, 38950, 39043]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 5:26 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Nov. 5, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
>   src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
>   src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Nov. 5, 2015, 7:18 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39112: RegistryClient refactor: fixed variable names

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39112/
---

(Updated Nov. 5, 2015, 7:18 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: fixed variable names. This patch will serve as 
catch-all for any variable name related changes in the refactor.


Diffs (updated)
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/39112/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 39405: [WIP] Quota: Added authentication of quota requests.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39405/
---

Review request for mesos.


Repository: mesos


Description
---

[WIP] Quota: Added authentication of quota requests.


Diffs
-


Diff: https://reviews.apache.org/r/39405/diff/


Testing
---


Thanks,

Jan Schlicht

Re: Review Request 39886: Added documentation about roles.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105295
---


Patch looks great!

Reviews applied: [39886]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 5:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> ---
> 
> (Updated Nov. 5, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
> https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> ---
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/#review105276
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 629)


How about these?


- Timothy Chen


On Nov. 5, 2015, 4 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39016/
> ---
> 
> (Updated Nov. 5, 2015, 4 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: refactored lambdas as per review comments.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39016/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38747: Adding digest utilities

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/
---

(Updated Nov. 5, 2015, 7:32 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Changes
---

removed dependency


Repository: mesos


Description
---

Added SHA256, SHA512 implementation.


Diffs
-

  3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
99c9754b6a5c7ceb12808a782da9cb9fb3fc731e 
  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38747/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/
---

(Updated Nov. 5, 2015, 7:33 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

fixed dependency chain


Repository: mesos


Description
---

Puller refactor: moved untar to a common place


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39250/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 5, 2015, 7:44 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

setting build env in the script.


Repository: mesos


Description
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/#review105298
---


Bad patch!

Reviews applied: [39832, 39882, 39839, 38579, 39015, 39016, 39017]

Failed command: ./support/apply-review.sh -n -r 39017

Error:
 2015-11-05 20:20:32 URL:https://reviews.apache.org/r/39017/diff/raw/ 
[4007/4007] -> "39017.patch" [1]
Successfully applied: RegistryClient refactor: changed Manifest struct

Added factory method.
 Removed digest.


Review: https://reviews.apache.org/r/39017
Checking 2 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp:584:  
Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Nov. 5, 2015, 7:33 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39250/
> ---
> 
> (Updated Nov. 5, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Puller refactor: moved untar to a common place
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f314f20d989ed0125e15d2a14d0f8e56c56976d5 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 8010b8aa75a2fc2e4b537f915f9dca028e407b63 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
>   src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39250/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39827: Made slave version required in master.cpp.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39827/
---

(Updated Nov. 5, 2015, 6:03 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

minor fix for slave version not being constant anymore.


Repository: mesos


Description
---

Slave version is being set by the slave since 0.21.0. Cleaned up the code in 
master that expected it to be optional.


Diffs (updated)
-

  src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
  src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 

Diff: https://reviews.apache.org/r/39827/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review105290
---



3rdparty/libprocess/include/process/mime.hpp (line 18)


Add `` too.


- Joseph Wu


On Nov. 2, 2015, 2:36 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39850/
> ---
> 
> (Updated Nov. 2, 2015, 2:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Process: Added headers to make `process/mime.hpp` standalone.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/mime.hpp 
> decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
> 
> Diff: https://reviews.apache.org/r/39850/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Jojy Varghese]

> On Nov. 5, 2015, 6:35 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 486
> > 
> >
> > You need to check for errors in all the find JSON calls.

Dropping as this is irrelevant after the protobuf conversion of these 
jsons.(after discussing with Tim)


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/#review105285
---


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39017/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added factory method.
>  Removed digest.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39017/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39832: RegistryClient refactor: fully qualified name for URL

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39832/
---

(Updated Nov. 5, 2015, 7:29 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

Removed "using http::URL" to be more explicit and match the rest of http types.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39832/diff/


Testing
---

make check


Thanks,

Jojy Varghese

Review Request 39991: fetcher should extract from .tar archive

[Bhuvan Arumugam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/
---

Review request for mesos and Bernd Mathiske.


Bugs: mesos-2935
https://issues.apache.org/jira/browse/mesos-2935


Repository: mesos


Description
---

fetcher should extract from .tar archive


Diffs
-

  src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
  src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 

Diff: https://reviews.apache.org/r/39991/diff/


Testing
---

make check


Thanks,

Bhuvan Arumugam

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Ben Whitehead]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105333
---

Ship it!


Ship It!

- Ben Whitehead


On Nov. 5, 2015, 3:50 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 5, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 38580: Added docker registry RemotePuller

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/
---

(Updated Nov. 5, 2015, 11:57 p.m.)


Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.


Changes
---

review comments


Repository: mesos


Description
---

Integrated remote puller with store. Tests will follow.


Diffs (updated)
-

  src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
87d80026939a326bd1169f46906e36d6ef19f546 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
bb02d650e16d45fcf337a7954f7a26143fb2c69f 
  src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
  src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8d90894410cd834edf49a2814d1b616718798fe8 

Diff: https://reviews.apache.org/r/38580/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Nov. 5, 2015, 11:58 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

review


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 35711: Disallow special characters in role name.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review105316
---


Can we add an end-to-end unit test that verifies that attempting to register as 
a framework with an invalid role name results in an error?


include/mesos/roles.hpp (line 46)


Extra whitespace before period.



include/mesos/roles.hpp (line 51)


Should this be a member function? i.e., not static.



include/mesos/roles.hpp (line 53)


Is this necessary?



include/mesos/roles.hpp (line 55)


Capitalization, punctuation.



include/mesos/roles.hpp (line 58)


Same as above.



include/mesos/roles.hpp (line 59)


Is this necessary?



include/mesos/roles.hpp (line 61)


Is this necessary?



include/mesos/roles.hpp (line 63)


Is this necessary?



src/common/roles.cpp (line 19)


If we're including roles.hpp, we can omit including the headers it 
includes, I'd think.



src/common/roles.cpp (line 67)


Error message is inaccurate.



src/common/roles.cpp (line 90)


Why are some trivial member functions/constructors define in the .cpp, 
whereas others are defined in the header file?



src/tests/roles_tests.cpp (line 29)


This can be removed.


- Neil Conway


On Oct. 3, 2015, 4:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated Oct. 3, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 5, 2015, 11:59 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/
---

(Updated Nov. 5, 2015, 11:59 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Puller refactor: moved untar to a common place


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f314f20d989ed0125e15d2a14d0f8e56c56976d5 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
8010b8aa75a2fc2e4b537f915f9dca028e407b63 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
  src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39250/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105323
---

Ship it!



src/tests/authorization_tests.cpp (line 411)


You already did a great job commenting your tests but could you also please 
add 1-2 lines of comment above all test function heads to briefly introduce 
their purpose? We made that a pattern we try to follow for all new tests.


- Till Toenshoff


On Nov. 5, 2015, 9:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> ---
> 
> (Updated Nov. 5, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> ---
> 
> The is the second in a chain of 5 patches. This diff includes new tests for 
> the authorization of reserve and unreserve operations via ACLs. `make check` 
> was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

[Jojy Varghese]

> On Nov. 5, 2015, 8:38 p.m., Timothy Chen wrote:
> > I don't see why we need this commit from the previos one. Can we merge this 
> > with the last one?

The reason being that the changes here are significant. We can merge the two if 
you think.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105303
---


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39985/
---

(Updated Nov. 5, 2015, 9:50 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description (updated)
---

Introduced ACL protobuf definitions for dynamic reservation.
Note: this review is continued from https://reviews.apache.org/r/37002/


Diffs
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/39985/diff/


Testing
---

This is the first in a chain of 5 patches. `make check` was used to test at the 
end of the chain.


Thanks,

Greg Mann

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Nov. 5, 2015, 11:50 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Addressed all comments.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---



src/tests/master_quota_tests.cpp (lines 110 - 112)


The resource string you have is equivalent to the resource string from 
`CreateSlaveFlags`.  Is there some reason you're re-setting it?



src/tests/master_quota_tests.cpp (lines 147 - 148)


Rather than re-defining this, can you populate it via the result of 
`MesosTest::CreateSlaveFlags().resources`?



src/tests/master_quota_tests.cpp (line 201)


Can you change this comment to more closely match your test?

I find `12 > 11` to be a better sanity check than `100 > 11`.


- Joseph Wu


On Nov. 5, 2015, 11:27 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 5, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105328
---


Patch looks great!

Reviews applied: [39953, 39954, 39914]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 8:12 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 5, 2015, 8:12 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> SSL based tests are not currently verified on reviewbot. This change would 
> make reviewbot environment to be same as mesos builds on jenkins.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 12:38 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Nov. 6, 2015, 12:38 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

removed shared_ptr based count


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39774: Fix libprocess protobuf library detection.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39774/#review105320
---

Ship it!


Ship It!

- Till Toenshoff


On Oct. 29, 2015, 9:05 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39774/
> ---
> 
> (Updated Oct. 29, 2015, 9:05 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-3600
> https://issues.apache.org/jira/browse/MESOS-3600
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix libprocess protobuf library detection.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac bdbb454c723756196d0994b621506b838fc71d4f 
> 
> Diff: https://reviews.apache.org/r/39774/diff/
> 
> 
> Testing
> ---
> 
> make check and manual verification with an external protobuf installation.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
---

(Updated Nov. 5, 2015, 8:27 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

removed extraneous line.


Repository: mesos


Description
---

Added factory method.
 Removed digest.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
ad57d8592c5f9df5115b575855ed2e99a0597359 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39017/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/#review105306
---



src/tests/containerizer/provisioner_docker_tests.cpp (line 1001)


Please update the comment as we discussed in our meeting, to be more 
descriptive what you're actually testing.



src/tests/containerizer/provisioner_docker_tests.cpp (line 1004)


Let's move the setup_server and ASSERTS to the Setup method of 
RegistryClientTest class as we're doing it every time.



src/tests/containerizer/provisioner_docker_tests.cpp (line 1191)


io::read should already do os::nonblock, you don't need to do it agian.



src/tests/containerizer/provisioner_docker_tests.cpp (line 1217)


What are these for?


- Timothy Chen


On Nov. 5, 2015, 4:03 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38580/
> ---
> 
> (Updated Nov. 5, 2015, 4:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Integrated remote puller with store. Tests will follow.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 87d80026939a326bd1169f46906e36d6ef19f546 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f314f20d989ed0125e15d2a14d0f8e56c56976d5 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 8010b8aa75a2fc2e4b537f915f9dca028e407b63 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
>   src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> bb02d650e16d45fcf337a7954f7a26143fb2c69f 
>   src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/38580/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105313
---



src/master/quota_handler.cpp (lines 93 - 101)


What do you think about using helpers from `include/mesos/resources.hpp`?  
A bunch of these checks could be done on a `Resources` (plural) object.



src/master/quota_handler.cpp (lines 151 - 152)


Can you comment that this is guaranteed by the master?


- Joseph Wu


On Oct. 24, 2015, 12:42 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 24, 2015, 12:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39053/#review105299
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 5, 2015, 4:03 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39053/
> ---
> 
> (Updated Nov. 5, 2015, 4:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: priv method const'ness
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39053/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39987/
---

(Updated Nov. 5, 2015, 9:52 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description (updated)
---

Added 'Master::authorize' for Reserve/Unreserve.
Note: this review is continued from https://reviews.apache.org/r/37125/


Diffs
-

  src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 

Diff: https://reviews.apache.org/r/39987/diff/


Testing
---

This is the third in a chain of 5 patches. `make check` was used to test after 
all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39989/
---

(Updated Nov. 5, 2015, 9:53 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description (updated)
---

Added framework authorization for dynamic reservation.
Note: this review is continued from https://reviews.apache.org/r/37127/


Diffs
-

  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
  src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 

Diff: https://reviews.apache.org/r/39989/diff/


Testing
---

This is the fifth in a chain of 5 patches. New reservation tests were added to 
`reservation_tests.cpp` to validate the authentication of framework reserve and 
unreserve operations using ACLs. `make check` was run to test after all patches 
were applied.


Thanks,

Greg Mann

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review105304
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 92)


For manifest case i didnt think we needed streaming.


- Jojy Varghese


On Nov. 5, 2015, 7:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> ---
> 
> (Updated Nov. 5, 2015, 7:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient: Added streaming response read
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39340/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39991: fetcher should extract from .tar archive

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/#review105311
---


Patch looks great!

Reviews applied: [39991]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 7:46 p.m., Bhuvan Arumugam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39991/
> ---
> 
> (Updated Nov. 5, 2015, 7:46 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: mesos-2935
> https://issues.apache.org/jira/browse/mesos-2935
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> fetcher should extract from .tar archive
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39991/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39769/#review105283
---


Can you fill in the "testing done" description as well?

Further, I am wondering if we should


src/slave/containerizer/mesos/containerizer.cpp 


Let's rebase it on top of https://reviews.apache.org/r/39866/. That way, 
this change will disappear.



src/tests/slave_tests.cpp (line 576)


Should we update the test name to make it more verbose 
`GetExecutorInfoForTaskWithContainer`?



src/tests/slave_tests.cpp (line 626)


s/0.25.0/0.26.0/



src/tests/slave_tests.cpp (lines 640 - 643)


I don't think doing it in two steps adds any value. Let's just use 
something like:

```
Try containerizer =
641 
MesosContainerizer::create(flags, false, );
642 
  CHECK_SOME(containerizer);
```

We can then replace `containerizer` with `containerizer.get()` below.



src/tests/slave_tests.cpp (lines 693 - 695)


Can we insert the Jira number here for reference?


- Kapil Arya


On Oct. 29, 2015, 6:15 p.m., Spike Curtis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39769/
> ---
> 
> (Updated Oct. 29, 2015, 6:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-3810
> https://issues.apache.org/jira/browse/MESOS-3810
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Always copy ContainerInfo to ExecutorInfo
> 
> Remove MesosContainerizer check for TaskInfo->ContainerInfo
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 91e4ea3a907ad165c359e7422135138737e14085 
>   src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 
>   src/tests/slave_tests.cpp 91dbdba56c7d3a374e56be92d88c0b367c7a2e1c 
> 
> Diff: https://reviews.apache.org/r/39769/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Spike Curtis
> 
>

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

(Updated Nov. 5, 2015, 9:52 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description (updated)
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Note: this review is continued from https://reviews.apache.org/r/37110/


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 39285: Added Quota Request Validation.

[Joseph Wu]

> On Nov. 2, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, lines 148-149
> > 
> >
> > As per @joris' comment in the previous review, should we check for 
> > errors after `.get()` calls?

I agree.  You're effectively double-converting JSON->Protobuf.

Note that you can put `google::protobuf::RepeatedPtrField` in a `foreach`.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review104725
---


On Oct. 24, 2015, 12:42 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 24, 2015, 12:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39112: RegistryClient refactor: fixed variable names

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39112/#review105300
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 5, 2015, 7:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39112/
> ---
> 
> (Updated Nov. 5, 2015, 7:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: fixed variable names. This patch will serve as 
> catch-all for any variable name related changes in the refactor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/39112/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39340: RegistryClient: Added streaming response read

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review105301
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 92)


When does no streaming makes sense? I wonder if we should just use 
streaming as the only option?



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 117)


why _writeBlob? It's not a continuation from writeBlob right?
It should be _saveBlob if it's a continuation



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 629)


Why don't we just copy on each call? Seems unncessary to have a shared_ptr 
int especially only one save in flight at a time.



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 718)


Should we log when we failed to close?



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 728)


onAny doesn't return anything.
We try to propgage the error back to the caller so they log themselves, 
unless you have more information here to log.



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 729)


We usually say it's discarded in the message too.


- Timothy Chen


On Nov. 5, 2015, 7:18 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> ---
> 
> (Updated Nov. 5, 2015, 7:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient: Added streaming response read
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39340/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105303
---


I don't see why we need this commit from the previos one. Can we merge this 
with the last one?

- Timothy Chen


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

[Cody Maloney]

> On Nov. 2, 2015, 5:43 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 433
> > 
> >
> > I think there are two problems here to address:
> > - --net is not always set to host, and if it's not it's causing problem 
> > as LIBPROCESS_IP takes precedence and also causes framework to not be able 
> > to connect
> > - docker code here in src/docker/docker.cpp is meant to be an 
> > abstraction to run docker, which we use to run executors and docker tasks. 
> > It shouldn't really have logic like this embedded especialy when this is 
> > not the desire effect for all docker containers we ever launch from Mesos. 
> > And really this problem and setting has to be two cases 1) We run a 
> > executor in the docker container 2) --net is host. We need to specifically 
> > solve this outside of the docker abstraction.

libprocess processes running with non-host networking (--net=bridge) won't work 
as libprocess processes doesn't like crossing NAT boundaries (which bridge 
networking is).

That we set it to the host IP might actually make it work better than if we 
don't (The libprocess inside the docker container announces the public host IP, 
which makes it so if it is talking to libprocess processes on other remote 
hosts, the remote hosts will get the IP which actually works to connect back, 
rather than the docker internal IP which doesn't. If you're running a bunch of 
things on the same host and connecting the docker networks together then that 
wouldn't work. The way libprocess works I think making both those work at once 
isn't feasible, and the --net=host working at all is generally preferrable (We 
launch mesos frameworks inside of docker containers, they need to talk to the 
Mesos Master using libmesos)


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39388/#review104679
---


On Oct. 17, 2015, 11:18 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39388/
> ---
> 
> (Updated Oct. 17, 2015, 11:18 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3740
> https://issues.apache.org/jira/browse/MESOS-3740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4bb65afd0ee61cafef68e064a697fdce65d60058 
> 
> Diff: https://reviews.apache.org/r/39388/diff/
> 
> 
> Testing
> ---
> 
> Added `DockerContainerizerTest.ROOT_DOCKER_LaunchWithLibprocessIP` test which 
> fails without the changes made to `src/docker/docker.cpp`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39989/
---

Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Added framework authorization for dynamic reservation.


Diffs
-

  src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
  src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 

Diff: https://reviews.apache.org/r/39989/diff/


Testing
---

This is the fifth in a chain of 5 patches. New reservation tests were added to 
`reservation_tests.cpp` to validate the authentication of framework reserve and 
unreserve operations using ACLs. `make check` was run to test after all patches 
were applied.


Thanks,

Greg Mann

Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39985/
---

Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Introduced ACL protobuf definitions for dynamic reservation.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/39985/diff/


Testing
---

This is the first in a chain of 5 patches. `make check` was used to test at the 
end of the chain.


Thanks,

Greg Mann

Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39988/
---

Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Added authorization for dynamic reservation master endpoints.


Diffs
-

  src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
  src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
  src/tests/reservation_endpoints_tests.cpp 
f5f9c4834779a3a84d12d9be77e674e2d6088b5d 

Diff: https://reviews.apache.org/r/39988/diff/


Testing
---

This is the fourth in a chain of 5 patches. Added new reservation endpoints 
tests to validate authorization of reserve and unreserve operations using ACLs. 
`make check` was run to test after all patches were applied.


Thanks,

Greg Mann

Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/
---

Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Bugs: MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
---

Enabled the Authorizer to handle Reserve/Unreserve ACLs.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 

Diff: https://reviews.apache.org/r/39986/diff/


Testing
---

The is the second in a chain of 5 patches. This diff includes new tests for the 
authorization of reserve and unreserve operations via ACLs. `make check` was 
used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 38579: Refactored registry client: split large methods.

[Timothy Chen]

> On Nov. 6, 2015, 2:54 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 529
> > 
> >
> > Can you use the new .status == http::Status::OK and simliar checks here?

Never mind let's worry about this later.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review105352
---


On Nov. 5, 2015, 7:17 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> ---
> 
> (Updated Nov. 5, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Cleanup and broke big methods into smaller chunks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> ad57d8592c5f9df5115b575855ed2e99a0597359 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d90894410cd834edf49a2814d1b616718798fe8 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>