Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review121208
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 22, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43798: Added overview section to upgrades.md.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43798/#review121209
---


Ship it!




Ship It!

- Michael Park


On Feb. 23, 2016, 9:39 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43798/
> ---
> 
> (Updated Feb. 23, 2016, 9:39 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4381
> https://issues.apache.org/jira/browse/MESOS-4381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overview section to upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43798/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and 
> docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review121207
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 5:18 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 22, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
> Docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 42590: Removed reserved() API.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
---

(Updated 二月 29, 2016, 7:54 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Changes
---

Rebase


Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447


Repository: mesos


Description
---

Removed reserved() API.


Diffs
-

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
  src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
  src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/42590/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review121206
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 7:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated Feb. 29, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/
---

(Updated Feb. 29, 2016, 7:20 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Tweaked comment per Klaus.


Bugs: MESOS-4667
https://issues.apache.org/jira/browse/MESOS-4667


Repository: mesos


Description
---

This allows operators to list all the dynamic reservations and persistent
volumes in a cluster. This is important in itself; it also makes it easier to
use the `/unreserve` and `/destroy-volumes` endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
  docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
  src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
  src/tests/persistent_volume_endpoints_tests.cpp 
08b9102318b826bab9d2c1d389fb80b86949218c 

Diff: https://reviews.apache.org/r/44047/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

> On Feb. 28, 2016, 3:06 p.m., Klaus Ma wrote:
> > docs/reservation.md, line 363
> > 
> >
> > s/slave/agent/

The rest of this file uses "slave", so I think this is better as-is for now 
(until we do the rename).


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/#review121145
---


On Feb. 29, 2016, 7:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44047/
> ---
> 
> (Updated Feb. 29, 2016, 7:13 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-4667
> https://issues.apache.org/jira/browse/MESOS-4667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows operators to list all the dynamic reservations and persistent
> volumes in a cluster. This is important in itself; it also makes it easier to
> use the `/unreserve` and `/destroy-volumes` endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
>   docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
>   src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 08b9102318b826bab9d2c1d389fb80b86949218c 
> 
> Diff: https://reviews.apache.org/r/44047/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

> On Feb. 28, 2016, 3:15 a.m., Guangya Liu wrote:
> > docs/persistent-volume.md, lines 372-374
> > 
> >
> > Only the `reserved_resources_full` was mentioned here, what about 
> > `used_resources_full` and `reserved_resources_full`? I think that those new 
> > metrics should also be mentioned here to clarify the meaning of them.

In my opinion, this is okay as-is: we don't document most of the keys in the 
JSON objects we return (which is unfortunate and something we should fix, but 
that's a separate project).


> On Feb. 28, 2016, 3:15 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 1043
> > 
> >
> > s/offered resources/offered resources per agent

I think this is implied by context (the comment occurs inside a for-each-slave 
loop).


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/#review121114
---


On Feb. 29, 2016, 7:13 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44047/
> ---
> 
> (Updated Feb. 29, 2016, 7:13 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-4667
> https://issues.apache.org/jira/browse/MESOS-4667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows operators to list all the dynamic reservations and persistent
> volumes in a cluster. This is important in itself; it also makes it easier to
> use the `/unreserve` and `/destroy-volumes` endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
>   docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
>   src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 08b9102318b826bab9d2c1d389fb80b86949218c 
> 
> Diff: https://reviews.apache.org/r/44047/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/
---

(Updated Feb. 29, 2016, 7:13 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Tweak per mpark.


Bugs: MESOS-4667
https://issues.apache.org/jira/browse/MESOS-4667


Repository: mesos


Description
---

This allows operators to list all the dynamic reservations and persistent
volumes in a cluster. This is important in itself; it also makes it easier to
use the `/unreserve` and `/destroy-volumes` endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
  docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
  src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
  src/tests/persistent_volume_endpoints_tests.cpp 
08b9102318b826bab9d2c1d389fb80b86949218c 

Diff: https://reviews.apache.org/r/44047/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 41772: Added helper function to flatten resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/
---

(Updated 二月 29, 2016, 7:08 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, and Klaus Ma.


Bugs: MESOS-4267
https://issues.apache.org/jira/browse/MESOS-4267


Repository: mesos


Description
---

Added helper function to flatten allocation slack resources.


Diffs
-

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
  src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41772/diff/


Testing
---

make
make check

GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="ResourcesOperationTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 二月 29, 2016, 7:04 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Rebase


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description (updated)
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/
---

(Updated 二月 29, 2016, 7:04 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Remove dependency to make some patches get merged first.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

Enabled oversubscribed resources for reservations in allocator.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
65c7e6b15c5308c0910667e1b12f39b21293a316 
  src/tests/hierarchical_allocator_tests.cpp 
b1cb955b7eb1213c7ba4a9c5181545bb49154f06 

Diff: https://reviews.apache.org/r/40632/diff/


Testing
---

make
make check
GLOG_v=2  ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose --gtest_repeat=100 --gtest_shuffle


Thanks,

Guangya Liu

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43911/
---

(Updated Feb. 29, 2016, 7:01 a.m.)


Review request for mesos and Michael Park.


Changes
---

Revert unintended change.


Repository: mesos


Description
---

Updated `/state` agent endpoint to use jsonify.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 

Diff: https://reviews.apache.org/r/43911/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/
---

(Updated Feb. 29, 2016, 7:01 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Revert unintended change.


Bugs: MESOS-4667
https://issues.apache.org/jira/browse/MESOS-4667


Repository: mesos


Description
---

This allows operators to list all the dynamic reservations and persistent
volumes in a cluster. This is important in itself; it also makes it easier to
use the `/unreserve` and `/destroy-volumes` endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
  docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
  src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
  src/tests/persistent_volume_endpoints_tests.cpp 
08b9102318b826bab9d2c1d389fb80b86949218c 

Diff: https://reviews.apache.org/r/44047/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43910/
---

(Updated Feb. 29, 2016, 6:55 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Enhanced a test case for the `/state` agent endpoint.


Diffs (updated)
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/43910/diff/


Testing
---

make check

Note that we don't currently check the conversion of `TaskInfo` -> JSON, which 
is used for `queuedTasks`. Would be nice to improve the test case so that the 
slave has a queued task, although this will probably require some 
`DROP_MESSAGE` trickery...


Thanks,

Neil Conway

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/
---

(Updated Feb. 29, 2016, 6:55 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-4667
https://issues.apache.org/jira/browse/MESOS-4667


Repository: mesos


Description
---

This allows operators to list all the dynamic reservations and persistent
volumes in a cluster. This is important in itself; it also makes it easier to
use the `/unreserve` and `/destroy-volumes` endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
  docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
  src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e 
  src/tests/persistent_volume_endpoints_tests.cpp 
08b9102318b826bab9d2c1d389fb80b86949218c 

Diff: https://reviews.apache.org/r/44047/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43911/
---

(Updated Feb. 29, 2016, 6:55 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/state` agent endpoint to use jsonify.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 

Diff: https://reviews.apache.org/r/43911/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review121186
---



Patch looks great!

Reviews applied: [43321]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 3:11 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43321/
> ---
> 
> (Updated Feb. 29, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4175
> https://issues.apache.org/jira/browse/MESOS-4175
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up SchedulerTest.Decline by advancing the clock.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/43321/diff/
> 
> 
> Testing
> ---
> 
> sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*
> 
> ```sh
> [ RUN  ] ContentType/SchedulerTest.Decline/0
> [   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
> [ RUN  ] ContentType/SchedulerTest.Decline/1
> [   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/
---

(Updated Feb. 29, 2016, 3:11 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4175
https://issues.apache.org/jira/browse/MESOS-4175


Repository: mesos


Description
---

Speeded up SchedulerTest.Decline by advancing the clock.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 

Diff: https://reviews.apache.org/r/43321/diff/


Testing
---

sudo make check -j2 GTEST_FILTER='ContentType/SchedulerTest.Decline/*

```sh
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (114 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (98 ms)
```


Thanks,

Shuai Lin

Re: Review Request 44154: Fixed build error on Mac OS.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44154/#review121179
---



Patch looks great!

Reviews applied: [44154]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 2:12 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44154/
> ---
> 
> (Updated Feb. 29, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4799
> https://issues.apache.org/jira/browse/MESOS-4799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed build error on Mac OS.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> ae6632404d9609bef15b9e8a7b7224aaf8905ff0 
> 
> Diff: https://reviews.apache.org/r/44154/diff/
> 
> 
> Testing
> ---
> 
> On MAC OS
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43932: Added overlayfs provisioning backend.

[Shuai Lin]

> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines 
> > 124-129
> > 
> >
> > To be safe, can you do the same thing to mark the mount as slave+shared 
> > (like we did in the bind backend).
> > 
> > So the goal of doing that is: we want to make sure when slave fork a 
> > subprocess with a new mount namespace, it does not create an extra 
> > reference to the mount so that rmdir might fail later.
> 
> Shuai Lin wrote:
> Updated. I am interested in how to reprduce the potential problem, but 
> failed to reproduce with these shell commands:
> 
> 
> ```sh
> mkdir -p /tmp/rootfs/folder1 /tmp/layer1
> mount --bind /tmp/layer1 /tmp/rootfs/folder1
> 
> # create a subprocess with a new mount namespace
> unshare -m sleep 1000 &
> 
> # Try to remove the mount dir, Expected: rm would failed, Result: rm 
> succeeded.
> umount /tmp/rootfs/folder1
> rm -rf /tmp/rootfs
> ```
> 
> I've also read about https://issues.apache.org/jira/browse/MESOS-3483 and 
> https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt, but 
> still don't understand this problem, can you provide some links on this?
> 
> Jie Yu wrote:
> I think you're using a newer kernel. See this thread:
> https://lwn.net/Articles/570338/
> 
> You should be able to repo this problem using an older kernel (e.g., 
> 3.10).

Right, I was using kernel 4.2.0 (for better overlayfs support). With another 
ubuntu 12.04 vm with kernel 3.2.0 I can reproduce the bug with the above 
commands. Thanks!


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120750
---


On Feb. 28, 2016, 5:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 28, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review121177
---



Thanks for working on this Qian!

It's really hard to tell what changes were made to the http command executor 
that are different from the command executor. I would suggest you to split this 
into multiple reviews to make reviewers' life easy.

1) Add http command executor to make files. Just copy executor.cpp to 
http_command_executor.cpp without any changes.
2) Update http_command_executor.cpp to use v1 API.
3) Make changes to flags.cpp and slave.cpp.
4) Update/parameterize tests (slave recovery tests?) to use http command 
executor.

- Vinod Kone


On Feb. 20, 2016, 1:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 20, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada 
>   src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 44154: Fixed build error on Mac OS.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44154/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4799
https://issues.apache.org/jira/browse/MESOS-4799


Repository: mesos


Description
---

Fixed build error on Mac OS.


Diffs
-

  src/slave/containerizer/mesos/provisioner/backend.cpp 
ae6632404d9609bef15b9e8a7b7224aaf8905ff0 

Diff: https://reviews.apache.org/r/44154/diff/


Testing
---

On MAC OS

make
make check


Thanks,

Guangya Liu

Re: Review Request 44153: Obtained uid/gids before changing filesystem root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44153/#review121176
---



Patch looks great!

Reviews applied: [44149, 44150, 44151, 44152, 44153]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 12:09 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44153/
> ---
> 
> (Updated Feb. 29, 2016, 12:09 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, we call os::su(user) after pivot_root. This is problematic
> because /etc/passwd and /etc/group might be missing in container's root
> filesystem. We should instead, get the uid/gids before pivot_root, and
> call setuid/setgroups after pivot_root.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/44153/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44149: Renamed a method in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44149/#review121175
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 28, 2016, 4:07 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44149/
> ---
> 
> (Updated Feb. 28, 2016, 4:07 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The original name is not accurate. We're trying to get the docker
> container launch command, not the executor launch command.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
> 507505aa247d4c587ce10ca60536df4b7f0d1674 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> 4241f4c127e89ac02d1b7838041836edbeb75672 
> 
> Diff: https://reviews.apache.org/r/44149/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121174
---




3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 314)


On mosys systems, you should get the max groups from ``sysconf``.


- James Peach


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> ---
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

[Jie Yu]

> On Feb. 29, 2016, 12:39 a.m., James Peach wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 310
> > 
> >
> > Darwin does have a ``gid_t`` type, why is this ifdef needed?

::getgrouplist on Darwin expect `int*` for gids. My clang complains about it if 
I use `gid_t gids[NGROUPS_MAX]`.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121172
---


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> ---
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121172
---




3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 310)


Darwin does have a ``gid_t`` type, why is this ifdef needed?


- James Peach


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> ---
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/#review121170
---




3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 338)


It would be cleaner just to pass the vector data directly:

```C
::setgroups(gids.size(), [0])
```


- James Peach


On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44151/
> ---
> 
> (Updated Feb. 29, 2016, 12:08 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-4757
> https://issues.apache.org/jira/browse/MESOS-4757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/44151/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 44153: Obtained uid/gids before changing filesystem root.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44153/
---

Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

Currently, we call os::su(user) after pivot_root. This is problematic
because /etc/passwd and /etc/group might be missing in container's root
filesystem. We should instead, get the uid/gids before pivot_root, and
call setuid/setgroups after pivot_root.


Diffs
-

  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
  src/slave/containerizer/mesos/launch.cpp 
6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 

Diff: https://reviews.apache.org/r/44153/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Review Request 44152: Added a TODO in os::su.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44152/
---

Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

We should not ignore EPERM in that way. Instead, check should be
performed before calling os::su.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 

Diff: https://reviews.apache.org/r/44152/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 44151: Added stout functions to get and set supplementary groud ids.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44151/
---

Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

Added stout functions to get and set supplementary groud ids.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 

Diff: https://reviews.apache.org/r/44151/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 44150: Added stout functions to set uid and gid.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44150/
---

Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-4757
https://issues.apache.org/jira/browse/MESOS-4757


Repository: mesos


Description
---

Added stout functions to set uid and gid.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 

Diff: https://reviews.apache.org/r/44150/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 44149: Renamed a method in docker runtime isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44149/
---

Review request for mesos, Gilbert Song and Timothy Chen.


Repository: mesos


Description
---

The original name is not accurate. We're trying to get the docker
container launch command, not the executor launch command.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
507505aa247d4c587ce10ca60536df4b7f0d1674 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
4241f4c127e89ac02d1b7838041836edbeb75672 

Diff: https://reviews.apache.org/r/44149/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44147/#review121168
---


Ship it!




Ship It!

- Neil Conway


On Feb. 28, 2016, 7:36 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44147/
> ---
> 
> (Updated Feb. 28, 2016, 7:36 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4792
> https://issues.apache.org/jira/browse/MESOS-4792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused src/common/date_utils.{c,h}pp (MESOS-4792).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/common/date_utils.hpp 794510c0f31eab6dafe8b86d835710096aac3392 
>   src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
> 
> Diff: https://reviews.apache.org/r/44147/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 43884: Added allocator metrics for used quotas.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review121166
---



Bad review!

Reviews applied: [43884, 43883, 43882, 43881, 43880, 43879]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 28, 2016, 9:31 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> ---
> 
> (Updated Feb. 28, 2016, 9:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
> https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44071/#review121165
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 28, 2016, 9:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44071/
> ---
> 
> (Updated Feb. 28, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4776
> https://issues.apache.org/jira/browse/MESOS-4776
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed disabling metrics endpoint rate limiting via the environment.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
> 
> Diff: https://reviews.apache.org/r/44071/diff/
> 
> 
> Testing
> ---
> 
> Site rendered with packaged docker container.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43884: Added allocator metrics for used quotas.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/
---

(Updated Feb. 28, 2016, 10:31 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Rebased.


Bugs: MESOS-4723
https://issues.apache.org/jira/browse/MESOS-4723


Repository: mesos


Description
---

Added allocator metrics for used quotas.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43884/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Benjamin Bannier]

> On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2432-2436
> > 
> >
> > This looks rather hard to read. I think a better solution would look 
> > like this:
> > 
> > ```c++
> > std::string metricKey = strings::join("/", 
> > "allocator/framework_allocations", framework.id());
> > 
> > EXPECT_EQ(1, metrics.values[metricKey]);
> > ```

Done.


> On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2471-2480
> > 
> >
> > Same as above.

Done.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review121001
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

[Benjamin Bannier]

> On Feb. 26, 2016, 6 p.m., Benjamin Bannier wrote:
> > docs/configuration.md, line 1690
> > 
> >
> > Rename to `LIBPROCESS_METRICS_RATE_LIMIT` and document changed 
> > semantics (comment in previous patch).
> 
> Alexander Rojas wrote:
> Does this mean that rate limiting will be opt-in?
> 
> I wonder how that will affect production systems.

As we currently share the same infrastructure for testing and production, this 
will be opt-in, even for production systems. The follow-up commit adds 
documentation.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44071/#review120883
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44071/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4776
> https://issues.apache.org/jira/browse/MESOS-4776
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed disabling metrics endpoint rate limiting via the environment.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
> 
> Diff: https://reviews.apache.org/r/44071/diff/
> 
> 
> Testing
> ---
> 
> Site rendered with packaged docker container.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43882: Added allocation metrics for allocation time.

[Benjamin Bannier]

> On Feb. 25, 2016, 5:47 p.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1207
> > 
> >
> > It seems a general functional class, can we move it into 
> > `process/metrics`?

I currently can only see a handful of uses of `process::metrics::Timer`, non of 
which would benefit from this helper yet. Let's pull it out once we see a 
general need.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/#review120718
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43882/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
> https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocation metrics for allocation time.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43882/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Did not move definition around, and rebased.


Bugs: MESOS-4720
https://issues.apache.org/jira/browse/MESOS-4720


Repository: mesos


Description
---

Added allocator metrics for total and allocated scalar resources.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43880/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

[Benjamin Bannier]

> On Feb. 26, 2016, 8:32 p.m., Alexander Rojas wrote:
> > src/tests/main.cpp, line 75
> > 
> >
> > I think this is using the posix `setenv(const char*, const char*, 
> > int)`, though the boolean as last parameter makes me doubt.
> > 
> > I'd recommend using our own `os::setenv(std::string, std::string, bool)`

Yes, this was using the POSIX variant, I should probably have qualified it 
fully. Using the matching wrapper `os::setenv` now.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review120938
---


On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> ---
> 
> (Updated Feb. 28, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4783
> https://issues.apache.org/jira/browse/MESOS-4783
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disabled metrics endpoint rate limiting in mesos tests.
> 
> 
> Diffs
> -
> 
>   src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 
> 
> Diff: https://reviews.apache.org/r/44073/diff/
> 
> 
> Testing
> ---
> 
> make distcheck (ubuntu 12 & 14), make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44071/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos.


Changes
---

Allowed to either disable rate limiting or set it.


Bugs: MESOS-4776
https://issues.apache.org/jira/browse/MESOS-4776


Repository: mesos


Description
---

Allowed disabling metrics endpoint rate limiting via the environment.


Diffs (updated)
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 

Diff: https://reviews.apache.org/r/44071/diff/


Testing
---

Site rendered with packaged docker container.


Thanks,

Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Addressed comments from Klaus.


Bugs: MESOS-4722
https://issues.apache.org/jira/browse/MESOS-4722


Repository: mesos


Description
---

Added allocator metrics for number of offer filters per framework.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43883/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43882/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Mesos style.


Bugs: MESOS-4721
https://issues.apache.org/jira/browse/MESOS-4721


Repository: mesos


Description
---

Added allocation metrics for allocation time.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43882/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Addressed comments from Alexander.


Bugs: MESOS-4719
https://issues.apache.org/jira/browse/MESOS-4719


Repository: mesos


Description
---

Added allocator metric for the number of allocations to a framework.


Diffs (updated)
-

  docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
  src/master/allocator/mesos/hierarchical.hpp 
3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43881/diff/


Testing
---

make check (OS X)

I confirmed that this does not lead to general performance regressions in the 
allocator; this is partially expected since the added code only inserts metrics 
in the allocator while the actual work is perform asynchronously. These tests 
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an 
optimized build under OS X using clang(trunk) as compiler.


Thanks,

Benjamin Bannier

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos.


Changes
---

Addressed comments from Alexander, allowed to either disable rate limiting or 
set it.


Bugs: MESOS-4783
https://issues.apache.org/jira/browse/MESOS-4783


Repository: mesos


Description
---

Disabled metrics endpoint rate limiting in mesos tests.


Diffs (updated)
-

  src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 

Diff: https://reviews.apache.org/r/44073/diff/


Testing
---

make distcheck (ubuntu 12 & 14), make check (OS X)


Thanks,

Benjamin Bannier

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44070/
---

(Updated Feb. 28, 2016, 10:28 p.m.)


Review request for mesos.


Changes
---

Addressed comments from Alexander, allowed to either disable rate limiting or 
set it.


Bugs: MESOS-4776
https://issues.apache.org/jira/browse/MESOS-4776


Repository: mesos


Description
---

Allowed disabling metrics endpoint rate limiting via the environment.


Diffs (updated)
-

  3rdparty/libprocess/include/process/limiter.hpp 
25254cdc2cb095b96d58d3f73dafc0ea48824998 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
09b716be56eac38f75d79d917799c001aa0b205c 
  3rdparty/libprocess/src/metrics/metrics.cpp 
a9840083722dd6b7b6aab692ed449407ab125ac7 

Diff: https://reviews.apache.org/r/44070/diff/


Testing
---

make check (OS X, not optimized)


Thanks,

Benjamin Bannier

Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44147/#review121164
---



Patch looks great!

Reviews applied: [44147]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 7:36 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44147/
> ---
> 
> (Updated Feb. 28, 2016, 7:36 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4792
> https://issues.apache.org/jira/browse/MESOS-4792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused src/common/date_utils.{c,h}pp (MESOS-4792).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/common/date_utils.hpp 794510c0f31eab6dafe8b86d835710096aac3392 
>   src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
> 
> Diff: https://reviews.apache.org/r/44147/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44147/
---

Review request for mesos and Neil Conway.


Bugs: MESOS-4792
https://issues.apache.org/jira/browse/MESOS-4792


Repository: mesos


Description
---

Remove unused src/common/date_utils.{c,h}pp (MESOS-4792).


Diffs
-

  src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/common/date_utils.hpp 794510c0f31eab6dafe8b86d835710096aac3392 
  src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 
  src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 

Diff: https://reviews.apache.org/r/44147/diff/


Testing
---

make
make check


Thanks,

Yong Tang

Re: Review Request 43932: Added overlayfs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review121158
---



Patch looks great!

Reviews applied: [43718, 43932]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 5:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 28, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43932: Added overlayfs provisioning backend.

[Jie Yu]

> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines 
> > 124-129
> > 
> >
> > To be safe, can you do the same thing to mark the mount as slave+shared 
> > (like we did in the bind backend).
> > 
> > So the goal of doing that is: we want to make sure when slave fork a 
> > subprocess with a new mount namespace, it does not create an extra 
> > reference to the mount so that rmdir might fail later.
> 
> Shuai Lin wrote:
> Updated. I am interested in how to reprduce the potential problem, but 
> failed to reproduce with these shell commands:
> 
> 
> ```sh
> mkdir -p /tmp/rootfs/folder1 /tmp/layer1
> mount --bind /tmp/layer1 /tmp/rootfs/folder1
> 
> # create a subprocess with a new mount namespace
> unshare -m sleep 1000 &
> 
> # Try to remove the mount dir, Expected: rm would failed, Result: rm 
> succeeded.
> umount /tmp/rootfs/folder1
> rm -rf /tmp/rootfs
> ```
> 
> I've also read about https://issues.apache.org/jira/browse/MESOS-3483 and 
> https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt, but 
> still don't understand this problem, can you provide some links on this?

I think you're using a newer kernel. See this thread:
https://lwn.net/Articles/570338/

You should be able to repo this problem using an older kernel (e.g., 3.10).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120750
---


On Feb. 28, 2016, 5:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 28, 2016, 5:22 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43846: Added support for specifying detector to the callback interface.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121156
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 27, 2016, 4:48 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43846/
> ---
> 
> (Updated Feb. 27, 2016, 4:48 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support for passing in a master detector object to the 
> callback interface. This can be used for testing master failover scenarios 
> similar to how the driver already does it.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
> 
> Diff: https://reviews.apache.org/r/43846/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review121155
---




src/launcher/http_executor.cpp (line 82)


Maybe we should also add some tests that launches tasks with this new http 
cmd executor?


- Shuai Lin


On Feb. 20, 2016, 1:44 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 20, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada 
>   src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43661: Added check to not Subscribe if we are already subscribed.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43661/#review121154
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 17, 2016, 7:22 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43661/
> ---
> 
> (Updated Feb. 17, 2016, 7:22 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a check to ensure that we don't `Subscribe` again in case we 
> already have a `SubscribedResponse` stream set. With pipelining, we won't be 
> able to send more then 1 subscribe calls on the `Subscribe` connection.
> 
> In case, the scheduler sends two subscribe calls simultaneously before the 
> subscribed response stream could be established. We would invoke the 
> `disconnected`/`connected` callback, making the scheduler subscribe again.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
> 
> Diff: https://reviews.apache.org/r/43661/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

> On Feb. 28, 2016, 1:16 p.m., Guangya Liu wrote:
> > src/linux/fs.cpp, line 60
> > 
> >
> > I think that should `continue` here, if one line failed, other lines 
> > should still be tried to see if the fs is supportted.
> > 
> > But it would be good to log some WARNINIG message here before continue.
> > 
> > @Jie Yu, @Shuai Lin, what do you say?
> 
> Klaus Ma wrote:
> According to the comments, only one or two columns is accepted. If the 
> data format did not math our expectation, we should return error.
> 
> >  // Each line of /proc/filesystems is "nodev" + "\t" + "fsname", and the
> >  // field "nodev" is optional. For the details, check the kernel src 
> code:

I agree with @klaus1982, if the code execution reaches here, it indicates the 
kernel (very unlikely) changes the format of `/proc/filesystems`, which we 
should never ignore.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review121141
---


On Feb. 28, 2016, 4:56 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 28, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43932: Added overlayfs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/
---

(Updated Feb. 28, 2016, 5:22 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Added overlayfs provisioning backend.


Diffs (updated)
-

  src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
01d06ebc67e259272ee57ea5c75bf7077ede65c4 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
  src/tests/containerizer/provisioner_backend_tests.cpp 
25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
  src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 

Diff: https://reviews.apache.org/r/43932/diff/


Testing
---

sudo modprobe overlayfs
sudo make check -j4 
GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'

- OS: ubuntu 14.04 64bit vm
- Kernel: 4.2.0-27-generic


Thanks,

Shuai Lin

Re: Review Request 43932: Added overlayfs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/
---

(Updated Feb. 28, 2016, 5:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Address review comments.


Bugs: MESOS-2971
https://issues.apache.org/jira/browse/MESOS-2971


Repository: mesos


Description
---

Added overlayfs provisioning backend.


Diffs (updated)
-

  src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
01d06ebc67e259272ee57ea5c75bf7077ede65c4 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
  src/tests/containerizer/provisioner_backend_tests.cpp 
25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
  src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 

Diff: https://reviews.apache.org/r/43932/diff/


Testing
---

sudo modprobe overlayfs
sudo make check -j4 
GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'

- OS: ubuntu 14.04 64bit vm
- Kernel: 4.2.0-27-generic


Thanks,

Shuai Lin

Re: Review Request 43932: Added overlayfs provisioning backend.

[Shuai Lin]

> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, lines 30-31
> > 
> >
> > can you wrap comments in 70 char width. It's less jagged IMO.

done


> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines 
> > 124-129
> > 
> >
> > To be safe, can you do the same thing to mark the mount as slave+shared 
> > (like we did in the bind backend).
> > 
> > So the goal of doing that is: we want to make sure when slave fork a 
> > subprocess with a new mount namespace, it does not create an extra 
> > reference to the mount so that rmdir might fail later.

Updated. I am interested in how to reprduce the potential problem, but failed 
to reproduce with these shell commands:


```sh
mkdir -p /tmp/rootfs/folder1 /tmp/layer1
mount --bind /tmp/layer1 /tmp/rootfs/folder1

# create a subprocess with a new mount namespace
unshare -m sleep 1000 &

# Try to remove the mount dir, Expected: rm would failed, Result: rm succeeded.
umount /tmp/rootfs/folder1
rm -rf /tmp/rootfs
```

I've also read about https://issues.apache.org/jira/browse/MESOS-3483 and 
https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt, but 
still don't understand this problem, can you provide some links on this?


> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines 
> > 132-133
> > 
> >
> > Can you align the error message:
> > ```
> > return Failure(
> > "Failed to remount rootfs '" + rootfs +
> > "' read-only: " + mount.error());
> > ```

Reformatted this function with clang-format.


> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_backend_tests.cpp, line 51
> > 
> >
> > We should add an TearDown method to unmount anything under sandbox. You 
> > can take a look at fs::unmountAll.

Refactored out the `TearDown` method of BindBackendTest into a common 
`MountBackendTest` class so it could be reused for all mount-based backend like 
bind/overlay/aufs.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43932/#review120750
---


On Feb. 24, 2016, 4:38 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43932/
> ---
> 
> (Updated Feb. 24, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2971
> https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added overlayfs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt b13fb23219ebb23bcfd6db062e1c814ca2114aa4 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 01d06ebc67e259272ee57ea5c75bf7077ede65c4 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/environment.cpp 6cd295f76496770774d090e0485ff87be378f74c 
> 
> Diff: https://reviews.apache.org/r/43932/diff/
> 
> 
> Testing
> ---
> 
> sudo modprobe overlayfs
> sudo make check -j4 
> GTEST_FILTER='OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend'
> 
> - OS: ubuntu 14.04 64bit vm
> - Kernel: 4.2.0-27-generic
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 28, 2016, 4:56 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check on ubuntu 14.04 64bit vm


Thanks,

Shuai Lin

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121151
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 27, 2016, 8:55 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> ---
> 
> (Updated Feb. 27, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
> https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated flag examples to refer to /role instead of stats.json.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> ---
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

[Klaus Ma]

> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 376
> > 
> >
> > We also need to remove counter in `removeFramework`; or we'll see 
> > metrics of removed framework.
> 
> Benjamin Bannier wrote:
> Right now this is intended behavior, any preference @bmahler?

For the cluster running for a long time, there'll be several un-available 
metrics after doing operation.
Just go through the other patches of metrics, similar comments on quota and 
filters.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review120716
---


On Feb. 27, 2016, 1:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> ---
> 
> (Updated Feb. 27, 2016, 1:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
> https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43884: Added allocator metrics for used quotas.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review121149
---




src/master/allocator/mesos/hierarchical.hpp (line 389)


Remove it when removeQuota.



src/master/allocator/mesos/hierarchical.cpp (line 1108)


This's not necessary; all resources in quotaSorter are `nonRevocable()`.


- Klaus Ma


On Feb. 27, 2016, 1 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> ---
> 
> (Updated Feb. 27, 2016, 1 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
> https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/#review121148
---




src/master/allocator/mesos/hierarchical.hpp (line 384)


Should we remove this `Gauge` when remove framework?


- Klaus Ma


On Feb. 27, 2016, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43883/
> ---
> 
> (Updated Feb. 27, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4722
> https://issues.apache.org/jira/browse/MESOS-4722
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator metrics for number of offer filters per framework.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43883/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review121147
---



Patch looks great!

Reviews applied: [42100]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 2:14 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Feb. 28, 2016, 2:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> On ubuntu 14.04 64bit machine: 
> 
> ``` sh
> $ cd /path/to/mesos
> $ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
> ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'
> $ ./support/docker_build.sh
> $ ls -1 *.xml
> libprocess-tests.xml
> lt-mesos-tests.xml
> stout-tests.xml
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/#review121145
---




docs/reservation.md (line 363)


s/slave/agent/



src/master/http.cpp (line 1047)


`` for /unreserve and /destroy-volumes.


- Klaus Ma


On Feb. 28, 2016, 8:17 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44047/
> ---
> 
> (Updated Feb. 28, 2016, 8:17 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-4667
> https://issues.apache.org/jira/browse/MESOS-4667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows operators to list all the dynamic reservations and persistent
> volumes in a cluster. This is important in itself; it also makes it easier to
> use the `/unreserve` and `/destroy-volumes` endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
>   docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 08b9102318b826bab9d2c1d389fb80b86949218c 
> 
> Diff: https://reviews.apache.org/r/44047/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 2:14 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64bit machine: 

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
lt-mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review121144
---



Patch looks great!

Reviews applied: [42100]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 12:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Feb. 28, 2016, 12:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> On ubuntu 14.04 64bit machine: 
> 
> ``` sh
> $ cd /path/to/mesos
> $ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
> ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
> $ ./support/docker_build.sh
> $ ls -1 *.xml
> libprocess-tests.xml
> mesos-tests.xml
> stout-tests.xml
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review121143
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 28, 2016, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 28, 2016, 6:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in \`slave/container_launch_errors\` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via \`Metrics()\` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Klaus Ma]

> On Feb. 28, 2016, 9:16 p.m., Guangya Liu wrote:
> > src/linux/fs.cpp, line 60
> > 
> >
> > I think that should `continue` here, if one line failed, other lines 
> > should still be tried to see if the fs is supportted.
> > 
> > But it would be good to log some WARNINIG message here before continue.
> > 
> > @Jie Yu, @Shuai Lin, what do you say?

According to the comments, only one or two columns is accepted. If the data 
format did not math our expectation, we should return error.

>  // Each line of /proc/filesystems is "nodev" + "\t" + "fsname", and the
>  // field "nodev" is optional. For the details, check the kernel src code:


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review121141
---


On Feb. 28, 2016, 9:08 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 28, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review121141
---




src/linux/fs.cpp (line 60)


I think that should `continue` here, if one line failed, other lines should 
still be tried to see if the fs is supportted.

But it would be good to log some WARNINIG message here before continue.

@Jie Yu, @Shuai Lin, what do you say?


- Guangya Liu


On 二月 28, 2016, 1:08 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated 二月 28, 2016, 1:08 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review121140
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 28, 2016, 9:08 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 28, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/
---

(Updated Feb. 28, 2016, 1:08 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Address review comments.


Bugs: MESOS-4707
https://issues.apache.org/jira/browse/MESOS-4707


Repository: mesos


Description
---

Added fs::supported() function.


Diffs (updated)
-

  src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
  src/linux/fs.cpp 6bf87a19a795cf0a1970f160829b477a35cb789a 
  src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 

Diff: https://reviews.apache.org/r/43718/diff/


Testing
---

make check on ubuntu 14.04 64bit vm


Thanks,

Shuai Lin

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

> On Feb. 21, 2016, 5:59 p.m., Cong Wang wrote:
> > src/tests/containerizer/fs_tests.cpp, line 48
> > 
> >
> > Well, not all kernels compile ext4 module, you can actually test 
> > "procfs" and "sysfs" here, they are required by Mesos.

thanks, updated!


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120076
---


On Feb. 22, 2016, 2:10 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 22, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[Shuai Lin]

> On Feb. 25, 2016, 7:53 p.m., Jie Yu wrote:
> > src/linux/fs.cpp, line 60
> > 
> >
> > Should we return an Error here?

Updated.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120747
---


On Feb. 22, 2016, 2:10 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 22, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:57 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64bit machine: 

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:57 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64:

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:55 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update the script after testing && address comment reviews.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---

On ubuntu 14.04 64:

```
export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
./support/docker_build.sh
```


Thanks,

Shuai Lin

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

[Adam B]

> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2325
> > 
> >
> > Why post-increment? Is it consistent to the codebase?

Looks like post-increment wins in this file (14:6) and across all of /tests 
(76:15), but by a smaller margin in all of /src (535:368).
I know there are times when pre/post matters when incrementing a complex 
object, but for simple ints it doesn't matter.

Besides, the language is named "C++" not "++C" damnit!


> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2338
> > 
> >
> > Backticks instead of single quotes, please! Here and everywhere.
> 
> Yongqiao Wang wrote:
> I find single quote?apostrophe and backticks are all used in our 
> comments, You can check this file and others like `master_quota_tests.cpp` 
> `master_maintenance_tests.cpp`, etc. Cloud you tell me what is the rule for 
> using them in comments, I will follow up later. Thanks.

Looks like single quotes are more popular than backticks in this file (99:71) 
and /tests (1162:293). As far as I know, backticks really only show up 
differently in markdown and doxygen. But our 
http://mesos.apache.org/documentation/latest/c++-style-guide/ says "Use 
backticks when quoting code excerpts or object/variable/function names." 
without stating whether that applies only to doxygenized comments.
Now, 'role1' is a string value and not an actual class/variable/function/test 
name, so it could stay in single quotes (or double quotes), but anything 
referencing a named piece of code should use backticks. Doesn't look like 
there's anything like that in this patch, so I'm dropping the issue.


> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2373
> > 
> >
> > You can put framework id's into a `std::set` instead. Given there are 
> > two allocations, there is a guarantee, that there will be no attempts to 
> > put the same framework into the set twice.
> 
> Yongqiao Wang wrote:
> In the current implementation, we only need to check the allocation size 
> for each framework, it does not care the size of whole contianer (currentt is 
> hashmap), so I think use hashmap can meet the current requirement.

I think he's saying you can use a `std::set allocatedFrameworks;` 
and inside your loop do: 
`allocatedFrameworks.insert(allocation.get().frameworkId);`
and verify the allocations afterwards with: `EXPECT_EQ(expectedFrameworksSet, 
allocatedFrameworks);`


> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2402-2403
> > 
> >
> > If you use `set` as proposed above, you can check  set against set here.
> 
> Yongqiao Wang wrote:
> Sorry to do not understand your suggestion here, current using hashmap 
> and use frameworkid as it's key, here to check value for allocation number 
> for each framework.

I think he's saying rather than counting that allocation number is always 1 for 
each of them, you could just add each frameworkId to a set and then at the end 
you verify that the test `set` matches your expected `set`.


> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2423-2433
> > 
> >
> > Will it be cleaner to put resources from the allocation into a hashmap 
> > by framework id? I think this way you can even get rid of the loop.
> > 
> > Same suggestions for the section below.
> 
> Yongqiao Wang wrote:
> Personallly, the current implementation is cleaner, if we using a loop 
> for this, we also need to check the framework Id in the loop due to there 
> allocation size and resources are different.

Not to mention that you still have to call `allocations.get()` each time. And 
you'd have to have two hashmaps, one for allocation size and another for 
resources, or create a struct to hold both. I don't see how you could do it 
without the loop unless you unroll the loop or hide it behind a lambda. I don't 
think we need to change the implementation here. Dropping the issue.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/#review119839
---


On Jan. 20, 2016, 12:36 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> 

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Feb. 28, 2016, 10:27 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
5ee3c7afadd131802c93febbb6b4dbad069c2d81 
  include/mesos/authorizer/authorizer.proto 
84d2cb3fbff3fbc7c3854d6eec5a3a55ad5760f8 
  src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/authorizer/local/authorizer.hpp c7321c276d566eca6a91f45c546468bea1b0da15 
  src/authorizer/local/authorizer.cpp a1486bd042e1d59e5ac99c2619fb3228c37b9788 
  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
--weights="role1=4.2,role2=3.1" --authenticate_http 
--credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
$ curl http://localhost:5050/roles | python -mjson.tool
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 4.2
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 3.1
}
]
}

Test update:
$ curl --user framework1:secret_string1 --data 
"[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
 -X PUT http://127.0.0.1:5050/weights
$ curl http://localhost:5050/roles | python -mjson.tool
{
"roles": [
{
"frameworks": [],
"name": "*",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role1",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.8
},
{
"frameworks": [],
"name": "role2",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role3",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 3.4
}
]
}

Test recovuery:
$ ps -ef | grep mesos-master
501 56292 1   0  6:18PM ttys0010:00.31 
/Users/yqwyq/Desktop/mesos/build/src/.libs/mesos-master --ip=127.0.0.1 
--work_dir=/tmp/mesos-master --weights=role1=4.2,role2=3.1 --authenticate_http 
--credentials=/opt/credentials.json
$ kill -9 56292

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
--weights="role1=4.2,role2=3.1,role6=9.0" --authenticate_http 
--credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
$ curl http://localhost:5050/roles | python -mjson.tool
{
"roles": [
{
"frameworks": [],
"name": "*",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role1",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.8
},
{
"frameworks": [],
"name": "role2",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/
---

(Updated Feb. 28, 2016, 11:27 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Verified the expected change happened.


Bugs: MESOS-4784
https://issues.apache.org/jira/browse/MESOS-4784


Repository: mesos


Description (updated)
---

To observe a changed metric in \`slave/container_launch_errors\` the
triggering action should have taken place. Currently, the test usually
passes, since hitting the metrics endpoint via \`Metrics()\` could block
for longer times due to the endpoint's implicit rate limiting. Once we
disable that blocking with MESOS-4783 this implicit assumption becomes
invalid and the test would be much more likely to fail.


Diffs (updated)
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44063/diff/


Testing
---

make check with unoptimized build OS X both with rate-limiting enabled and 
disabled

With MESOS-4783 applied the test fails before this patch and passes after 
applying it.


Thanks,

Benjamin Bannier

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some 
> > indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
> 
> Yongqiao Wang wrote:
> Thanks Adam. I will add a couple of registrar tests later in another 
> patches, is it OK?
> 
> Adam B wrote:
> Sure, it can go in a later patch, but let's make sure not to forget it.

I have logged a separated JIRA ticket #MESOS-4797 to trace this task.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
---


On Feb. 27, 2016, 1:55 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Feb. 27, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.NonNumericWeight
> [   OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN  ] DynamicWeightsTest.UnknownRole
> [   OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (36 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [--] 11 tests from DynamicWeightsTest (527 ms total)
> 
> [--] Global test environment tear-down
> [==] 11 tests from 1 test case ran. (536 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Adam B]

> On Feb. 27, 2016, 4:21 a.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some 
> > indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
> 
> Yongqiao Wang wrote:
> Thanks Adam. I will add a couple of registrar tests later in another 
> patches, is it OK?

Sure, it can go in a later patch, but let's make sure not to forget it.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
---


On Feb. 27, 2016, 5:55 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Feb. 27, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.NonNumericWeight
> [   OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN  ] DynamicWeightsTest.UnknownRole
> [   OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (36 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [--] 11 tests from DynamicWeightsTest (527 ms total)
> 
> [--] Global test environment tear-down
> [==] 11 tests from 1 test case ran. (536 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44063/#review121135
---


Fix it, then Ship it!




Simple enough.


src/tests/slave_tests.cpp (line 1161)


Why not verify the failureUpdate is TASK_FAILED?


- Adam B


On Feb. 26, 2016, 10:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44063/
> ---
> 
> (Updated Feb. 26, 2016, 10:59 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4784
> https://issues.apache.org/jira/browse/MESOS-4784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To observe a changed metric in `slave/container_launch_errors` the
> triggering action should have taken place. Currently, the test usually
> passes, since hitting the metrics endpoint via `Metrics()` could block
> for longer times due to the endpoint's implicit rate limiting. Once we
> disable that blocking with MESOS-4783 this implicit assumption becomes
> invalid and the test would be much more likely to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 
> 
> Diff: https://reviews.apache.org/r/44063/diff/
> 
> 
> Testing
> ---
> 
> make check with unoptimized build OS X both with rate-limiting enabled and 
> disabled
> 
> With MESOS-4783 applied the test fails before this patch and passes after 
> applying it.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 43824: Addressed comments of 41672.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121132
---



Thanks for following up with this. AlexR is on vacation now, so I'll review 
these changes. I only had a few suggestions.
After reviewing the issues AlexR opened up on the previous patch, the only 
remaining question is whether to use a `std::set` instead of a 
`hashmap counts;`.


src/tests/hierarchical_allocator_tests.cpp (lines 2647 - 2649)


Please fix the wrapping to 70 or 80 chars instead of 60.



src/tests/hierarchical_allocator_tests.cpp (lines 2653 - 2656)


Can you say 100% and 0% instead of 1 and 0? And how is framework1's "share" 
'6'? Is that the number of agents/offers, rather than the framework's "share"?



src/tests/hierarchical_allocator_tests.cpp (lines 2733 - 2736)


It shouldn't be necessary to advance the clock if updateWeights will notice 
the change and 'rebalance' immediately, right?



src/tests/hierarchical_allocator_tests.cpp (lines 2793 - 2797)


Please comment why we don't manually advance the clock here. I guess 
`updateWeights` won't call `allocate()` since no framework exists in 'role3' 
yet, but `addFramework` will.


- Adam B


On Feb. 21, 2016, 11:23 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> ---
> 
> (Updated Feb. 21, 2016, 11:23 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review121130
---



Just a couple of suggested comment rewordings, as I've been looking at a lot of 
ACLs lately.


include/mesos/authorizer/authorizer.proto (line 141)


"Which principals are authorized to updated weights for the given roles."



include/mesos/authorizer/authorizer.proto (line 146)


The list of roles whose weights can be updated.


- Adam B


On Feb. 14, 2016, 4:02 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated Feb. 14, 2016, 4:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 5ee3c7afadd131802c93febbb6b4dbad069c2d81 
>   include/mesos/authorizer/authorizer.proto 
> 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/authorizer/local/authorizer.hpp 
> c7321c276d566eca6a91f45c546468bea1b0da15 
>   src/authorizer/local/authorizer.cpp 
> 9557bbdf68ff182c4538bbf70cee576d717abc05 
>   src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/tmp/mesos-master  
> --weights="role1=4.2,role2=3.1" --authenticate_http 
> --credentials=/opt/credentials.json  >> /tmp/mesos-master.log 2>&1 &)
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 4.2
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 3.1
> }
> ]
> }
> 
> Test update:
> $ curl --user framework1:secret_string1 --data 
> "[{\"weight\":1.8,\"role\":\"role1\"},{\"weight\":1.0,\"role\":\"role2\"},{\"weight\":3.4,\"role\":\"role3\"}]"
>  -X PUT http://127.0.0.1:5050/weights
> $ curl http://localhost:5050/roles | python -mjson.tool
> {
> "roles": [
> {
> "frameworks": [],
> "name": "*",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.0
> },
> {
> "frameworks": [],
> "name": "role1",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.8
> },
> {
> "frameworks": [],
> "name": "role2",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 1.0
> },
> {
> "frameworks": [],
> "name": "role3",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "weight": 3.4
> }
> ]
> }
> 
> Test recovuery:
> $ ps -ef | grep mesos-master
> 501 56292 1   0  6:18PM ttys0010:00.31 
> /Users/yqwyq/Desktop/mesos/build/src/.libs/mesos-master --ip=127.0.0.1 
> --work_dir=/tmp/mesos-master --weights=role1=4.2,role2=3.1 
> --authenticate_http --credentials=/opt/credentials.json
> $ kill -9 56292
> 

Re: Review Request 42719: Add doc for weights.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
---



Thanks! Couple of tweaks as I review it again.
- How did you test that this renders correctly? Did you try 
`support/site-docker` to see if the markdown translates properly to html? Just 
because it looks good in github doesn't mean our Rakefile will make it look as 
good.


docs/weights.md (line 7)


"... priority among roles." - and link to roles.md.



docs/weights.md (line 9)


s/via/by/



docs/weights.md (line 16)


Are we officially deprecating --weights in this release? If so, we'll need 
to update upgrades.md and the CHANGELOG to mention this.

Could you also document what happens when a master restarts with a 
--weights flag that differs from what's in the registry? (We warn and use the 
registry value, correct?)



docs/weights.md (line 32)


s/example/example,/



docs/weights.md (line 48)


s/the specified/all specified/



docs/weights.md (line 54)


s/negative/non-positive/ (since 0 is also invalid)


- Adam B


On Feb. 18, 2016, 11:56 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> ---
> 
> (Updated Feb. 18, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add doc for weights.
> 
> 
> Diffs
> -
> 
>   docs/home.md 07214b927c112d7a180507ae03245892455fd757 
>   docs/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42719/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>