Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121604
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 4 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43908/
> ---
> 
> (Updated March 2, 2016, 4 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added significant test coverage of `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 756aa29ed134bf10a645af7f6562f86dc8e488f5 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> d0592ef8a774d380e9df66b7e623eb72b29a28b3 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 
> 
> Diff: https://reviews.apache.org/r/43908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/#review121553
---


Fix it, then Ship it!





src/CMakeLists.txt (line 248)


Alphabetize.


- Joris Van Remoortere


On March 1, 2016, 11:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40620/
> ---
> 
> (Updated March 1, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added suppport for `slave/monitor.cpp`.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/40620/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: make
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/#review121552
---


Ship it!




- Joris Van Remoortere


On March 1, 2016, 11:55 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40115/
> ---
> 
> (Updated March 1, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added support for `slave/gc.cpp`.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
>   src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 
> 
> Diff: https://reviews.apache.org/r/40115/diff/
> 
> 
> Testing
> ---
> 
> Windows 10: make.bat
> OSX: make check
> Ubuntu: 15.1 make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121602
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 7:26 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated March 2, 2016, 7:26 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44258/
---

Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-4831
https://issues.apache.org/jira/browse/MESOS-4831


Repository: mesos


Description
---

There is a bug when setting host maintain with http endpoint: 
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L1987-L2021
The logic is as this:
1) Get all host list from maintain window and put it to updated hashmap.
2) If the machine in was in updated was also in master->machines, call master 
updateUnavailability to trigger recoverResources, updateUnavailability etc in 
allocator
3) Otherwise, clear the unavailabity time window for the machine.
4) Update each new machines in updated to call master updateUnavailability

But the logic in step 4) is getting all machines from the schedule windows but 
not the machines that is new to the cluster, this caused master get two 
updateUnavailability calls for a machine in the updated hashmap.

The fix is filter machines in updated hashmap when handling new machines.


Diffs
-

  src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 
  src/tests/master_maintenance_tests.cpp 
3faa8136cf57276295553910319480028f433e4c 

Diff: https://reviews.apache.org/r/44258/diff/


Testing
---

make
make check
 ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose


Thanks,

Guangya Liu

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
---

(Updated March 2, 2016, 7:26 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3644
https://issues.apache.org/jira/browse/MESOS-3644


Repository: mesos


Description
---

Windows: Forked signal handling in `signalhandler.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
---

OSX: make check
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/
---

(Updated March 2, 2016, 7:26 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Changes
---

darroyo's commit breaks this one; let's fix that.


Repository: mesos


Description
---

CMake: Added files to be built as part of libmesos.


Diffs (updated)
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 

Diff: https://reviews.apache.org/r/43906/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121598
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121596
---


Ship it!




I'm voting ship it, but I do want to call out that I know almost nothing about 
the autotools build, so I'm not exactly qualified to vote on that.

- Alex Clemmer


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121595
---


Ship it!




Ship It!

- Klaus Ma


On March 2, 2016, 2:21 p.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle and close fd
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/
---

(Updated 三月 2, 2016, 6:21 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description (updated)
---

When fopen is failed,we should curl_easy_cleanup curl_handle and close fd


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 

Diff: https://reviews.apache.org/r/44254/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44251/
---

(Updated March 2, 2016, 6:21 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Address code review comments.


Bugs: MESOS-4833
https://issues.apache.org/jira/browse/MESOS-4833


Repository: mesos


Description
---

When the cluster contains many resources that have either labeled
reservations or persistent volumes, allocator performance can decrease
substantially because such metadata prevents `Resource` objects from
being merged together inside the allocator. As a result, the allocator
must manipulate `Resources` vectors that consist of many small
individual `Resource` values; since many `Resources` operations take
linear-time in the number of `Resource` values they contain, this can
cause very significant slowdowns.

As a short-term solution, this commit strips dynamic reservation and
persistent volume information from the `Resources` objects used
internally by the allocator, because they are not needed when
aggregating resource quantities together.

A long-term solution for this problem will be addressed as work on
refactoring the allocator more generally.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/master/allocator/sorter/drf/sorter.hpp 
46b2a9caf13b028a3aee6c1590679f885be90fd6 
  src/master/allocator/sorter/drf/sorter.cpp 
9e863dd0ca5e2f2f0d517cb833687b757bed2c52 
  src/master/allocator/sorter/sorter.hpp 
ba91a38e47065718af87c9b3b7c5b74d25a258df 

Diff: https://reviews.apache.org/r/44251/diff/


Testing
---

make check

Perf:

```
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.458462secs to make 200 offers
round 1 allocate took 2.427941secs to make 200 offers
round 2 allocate took 2.460724secs to make 200 offers
round 3 allocate took 2.443408secs to make 200 offers
round 4 allocate took 2.464784secs to make 200 offers
round 5 allocate took 2.501429secs to make 200 offers
round 6 allocate took 2.468777secs to make 200 offers
round 7 allocate took 2.482268secs to make 200 offers
round 8 allocate took 2.479014secs to make 200 offers
round 9 allocate took 2.529951secs to make 200 offers
round 10 allocate took 2.460059secs to make 200 offers
```

Performance of `DeclineOffers` without labels is about ~2.1 seconds.


Thanks,

Neil Conway

Re: Review Request 43684: Cleaned up allocator benchmark code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43684/
---

(Updated March 2, 2016, 6:20 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Address code review comments.


Repository: mesos


Description
---

Cleaned up allocator benchmark code.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43684/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43686: Added allocator benchmark using labeled resources.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43686/
---

(Updated March 2, 2016, 6:20 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Address code review comments.


Bugs: MESOS-4691
https://issues.apache.org/jira/browse/MESOS-4691


Repository: mesos


Description
---

This reveals that when the cluster contains many reservations with
distinct labels, allocator performance slows down dramatically. A
short-term fix for this problem will be introduced shortly.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43686/diff/


Testing
---

make check

FYI, results on my laptop:

_Original benchmark (unlabeled resources)_
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.DeclineOffers
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.028175secs to make 200 offers
round 1 allocate took 2.006791secs to make 200 offers
round 2 allocate took 2.033723secs to make 200 offers
round 3 allocate took 2.017508secs to make 200 offers
round 4 allocate took 2.037235secs to make 200 offers
round 5 allocate took 2.054095secs to make 200 offers
round 6 allocate took 2.048884secs to make 200 offers
round 7 allocate took 2.044252secs to make 200 offers
round 8 allocate took 2.060256secs to make 200 offers
round 9 allocate took 2.07121secs to make 200 offers
round 10 allocate took 2.066261secs to make 200 offers
round 11 allocate took 2.034805secs to make 200 offers
round 12 allocate took 2.053705secs to make 200 offers
round 13 allocate took 2.042106secs to make 200 offers
round 14 allocate took 2.082704secs to make 200 offers


Thanks,

Neil Conway

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated March 2, 2016, 6:15 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Changes
---

More changes to handle rename in automake of leveldb to leveldb-1.4.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
---

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.patch  
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
  LICENSE c3aaa437af10533132698df3348114195d338965 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44196/#review121593
---




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 282)


This should be path::getExecutorRunPath(xx,xx,xx,xx). entry.target is the 
directory/mountpoint, not directory itself.


- Jie Yu


On March 2, 2016, 3:42 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44196/
> ---
> 
> (Updated March 2, 2016, 3:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4824
> https://issues.apache.org/jira/browse/MESOS-4824
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds extra mount-table checking logic specifically for orphaned persistent 
> volumes that can be safely cleaned up.  This includes "known" orphans (i.e. 
> containers detected via the `Launcher`).
> 
> Also adds some extra helpers in `slave::paths`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 7fdf518deeb388218438245623719f41613d031b 
>   src/slave/paths.hpp 5ae3a2b86bf76859e0ffb78be2644af56bc88d49 
>   src/slave/paths.cpp 6d9dad59386fb890267923f35edabbdf54fb39c6 
>   src/tests/paths_tests.cpp 4c15ebc514e5d1714b243432eeff5377bb21b93f 
> 
> Diff: https://reviews.apache.org/r/44196/diff/
> 
> 
> Testing
> ---
> 
> Tests added in previous review now pass.  i.e.
> ```
> GLOG_v=1 sudo -E bin/mesos-tests.sh 
> --gtest_filter="*MesosContainerizerRecoverOrphanedVolumes*" --verbose
> GLOG_v=1 sudo -E bin/mesos-tests.sh 
> --gtest_filter="*ChangeRootFilesystemOrphanedPersistentVolume" --verbose
> ```
> 
> Confirmed that the right log messages show up:
> ```
> I0302 00:51:01.100466  1610 linux.cpp:782] Unmounting volume 
> '/tmp/DiskResource_PersistentVolumeTest_ROOT_MesosContainerizerRecoverOrphanedVolumes_0_smk5ZU/slaves/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-S0/frameworks/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-/executors/cdbae703-603d-4e4c-a026-326dbc8c9ce2/runs/8742378c-9a5d-43d6-af31-0c7fe1f5c4c7/path1'
>  for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
> I0302 00:51:01.100538  1610 linux.cpp:798] Ignoring unmounting sandbox/work 
> directory for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
> ```
> 
> ---
> 
> CI test results:
> 
> ```
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) | $| *|:)|   :) |:) |  
>:)|
> With-SSL |  :) | $|%*|#@|   ^@ |:) |  
>:)|
> 
>  :) = Passed.
>   $ = ProvisionerDockerRegistryPullerTest.ROOT_INTERNET_CURL_ShellCommand
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   % = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_DestroyTracedProcess
>   # = SlaveRecoveryTest/0.Reboot
>   @ = SlaveRecoveryTest/0.RecoverTerminatedExecutor
> 
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44196/#review121585
---


Fix it, then Ship it!




Thanks! I'll fix the issues for you and committing it now.


src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 255)


I would put the following code in else, instead of using a continue here.



src/slave/paths.cpp (line 61)


Let's use const char XXX_YYY[] = ""; here to avoid non-POD global 
variables.



src/slave/paths.cpp (line 75)


you can use `path::join(_rootDir, "");` here


- Jie Yu


On March 2, 2016, 3:42 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44196/
> ---
> 
> (Updated March 2, 2016, 3:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4824
> https://issues.apache.org/jira/browse/MESOS-4824
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds extra mount-table checking logic specifically for orphaned persistent 
> volumes that can be safely cleaned up.  This includes "known" orphans (i.e. 
> containers detected via the `Launcher`).
> 
> Also adds some extra helpers in `slave::paths`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 7fdf518deeb388218438245623719f41613d031b 
>   src/slave/paths.hpp 5ae3a2b86bf76859e0ffb78be2644af56bc88d49 
>   src/slave/paths.cpp 6d9dad59386fb890267923f35edabbdf54fb39c6 
>   src/tests/paths_tests.cpp 4c15ebc514e5d1714b243432eeff5377bb21b93f 
> 
> Diff: https://reviews.apache.org/r/44196/diff/
> 
> 
> Testing
> ---
> 
> Tests added in previous review now pass.  i.e.
> ```
> GLOG_v=1 sudo -E bin/mesos-tests.sh 
> --gtest_filter="*MesosContainerizerRecoverOrphanedVolumes*" --verbose
> GLOG_v=1 sudo -E bin/mesos-tests.sh 
> --gtest_filter="*ChangeRootFilesystemOrphanedPersistentVolume" --verbose
> ```
> 
> Confirmed that the right log messages show up:
> ```
> I0302 00:51:01.100466  1610 linux.cpp:782] Unmounting volume 
> '/tmp/DiskResource_PersistentVolumeTest_ROOT_MesosContainerizerRecoverOrphanedVolumes_0_smk5ZU/slaves/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-S0/frameworks/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-/executors/cdbae703-603d-4e4c-a026-326dbc8c9ce2/runs/8742378c-9a5d-43d6-af31-0c7fe1f5c4c7/path1'
>  for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
> I0302 00:51:01.100538  1610 linux.cpp:798] Ignoring unmounting sandbox/work 
> directory for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
> ```
> 
> ---
> 
> CI test results:
> 
> ```
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) | $| *|:)|   :) |:) |  
>:)|
> With-SSL |  :) | $|%*|#@|   ^@ |:) |  
>:)|
> 
>  :) = Passed.
>   $ = ProvisionerDockerRegistryPullerTest.ROOT_INTERNET_CURL_ShellCommand
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   % = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_DestroyTracedProcess
>   # = SlaveRecoveryTest/0.Reboot
>   @ = SlaveRecoveryTest/0.RecoverTerminatedExecutor
> 
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/#review121584
---


Ship it!




- Joris Van Remoortere


On March 2, 2016, 2:21 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44250/
> ---
> 
> (Updated March 2, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This returns a new `Resources` object that omits dynamic reservation
> and persistent volume information. This is intended primarily for
> situations in which code wants to efficiently compute aggregate
> statistics about many `Resource` values for which reservation and
> persistent volume information is not relevant.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
>   include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
>   src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
>   src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 
> 
> Diff: https://reviews.apache.org/r/44250/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44251/#review121588
---




src/master/allocator/mesos/hierarchical.cpp (line 1226)


should we use __quantity__ as you changed it above as well?



src/master/allocator/mesos/hierarchical.cpp (lines 1349 - 1350)


Can we add a comment explaining that `allocatedStage2` is now a 
__quantity__, and that this invariant is maintained by only adding 
`StrippedScalarQuantity`s to it?



src/master/allocator/sorter/drf/sorter.cpp (lines 374 - 375)


new line?


- Joris Van Remoortere


On March 2, 2016, 2:22 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44251/
> ---
> 
> (Updated March 2, 2016, 2:22 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4833
> https://issues.apache.org/jira/browse/MESOS-4833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the cluster contains many resources that have either labeled
> reservations or persistent volumes, allocator performance can decrease
> substantially because such metadata prevents `Resource` objects from
> being merged together inside the allocator. As a result, the allocator
> must manipulate `Resources` vectors that consist of many small
> individual `Resource` values; since many `Resources` operations take
> linear-time in the number of `Resource` values they contain, this can
> cause very significant slowdowns.
> 
> As a short-term solution, this commit strips dynamic reservation and
> persistent volume information from the `Resources` objects used
> internally by the allocator, because they are not needed when
> aggregating resource quantities together.
> 
> A long-term solution for this problem will be addressed as work on
> refactoring the allocator more generally.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 24fa50f62dec10ed43089297473cc386d6ba2f78 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 46b2a9caf13b028a3aee6c1590679f885be90fd6 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 9e863dd0ca5e2f2f0d517cb833687b757bed2c52 
>   src/master/allocator/sorter/sorter.hpp 
> ba91a38e47065718af87c9b3b7c5b74d25a258df 
> 
> Diff: https://reviews.apache.org/r/44251/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Perf:
> 
> ```
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
> Using 2000 slaves and 200 frameworks
> round 0 allocate took 2.458462secs to make 200 offers
> round 1 allocate took 2.427941secs to make 200 offers
> round 2 allocate took 2.460724secs to make 200 offers
> round 3 allocate took 2.443408secs to make 200 offers
> round 4 allocate took 2.464784secs to make 200 offers
> round 5 allocate took 2.501429secs to make 200 offers
> round 6 allocate took 2.468777secs to make 200 offers
> round 7 allocate took 2.482268secs to make 200 offers
> round 8 allocate took 2.479014secs to make 200 offers
> round 9 allocate took 2.529951secs to make 200 offers
> round 10 allocate took 2.460059secs to make 200 offers
> ```
> 
> Performance of `DeclineOffers` without labels is about ~2.1 seconds.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121587
---




3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 159)


also close fd (`os::close(fd.get())`)


- Klaus Ma


On March 2, 2016, 11:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 11:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44122/#review121583
---


Ship it!




Ship It!

- Jie Yu


On March 2, 2016, 3:39 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44122/
> ---
> 
> (Updated March 2, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4824
> https://issues.apache.org/jira/browse/MESOS-4824
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Based on 
> DockerContainerizerTest.ROOT_DOCKER_RecoverOrphanedPersistentVolumes.  This 
> tests orphaned persistent volumes and the MesosContainerizer, with and 
> without rootfs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 6a60962b4593b3521c182c7320331743ccffd4ba 
>   src/tests/persistent_volume_tests.cpp 
> bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
> 
> Diff: https://reviews.apache.org/r/44122/diff/
> 
> 
> Testing
> ---
> 
> As of this patch, thise tests do not pass:
> 
> 1) The `filesystem/linux` isolator recovers the persistent volume as a 
> "known" orphan.  Known orphans are not cleaned up immediately.
>   - We only detect rootfs mounts currently.  i.e. when the root of the mount 
> is inside the agent's `/slaves`.
>   - Persistent volume mounts have roots under `/volumes`.
> 2) When the containerizer removes this orphan, the `filesystem/linux` 
> isolator has no `ContainerInfo` about it.  The isolator does not look up the 
> mount table again, and the isolator ignores the cleanup.
> 3) Test checks the mount table and sees the mount is still present -> test 
> failed.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121582
---


Ship it!




Could you create a jira ticket for this?

- haosdent huang


On March 2, 2016, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 43686: Added allocator benchmark using labeled resources.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43686/#review121581
---


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp (lines 2610 - 2620)


let's use a loop, and add a comment explaining that we're trying to force 
the N^2 labels comparison algorithm by having so many labels.



src/tests/hierarchical_allocator_tests.cpp (lines 2633 - 2634)


Can we add a TODO to factor this test out by parameterizing the 
DeclineFilter test of which it is a copy?


- Joris Van Remoortere


On March 2, 2016, 2:21 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43686/
> ---
> 
> (Updated March 2, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4691
> https://issues.apache.org/jira/browse/MESOS-4691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reveals that when the cluster contains many reservations with
> distinct labels, allocator performance slows down dramatically. A
> short-term fix for this problem will be introduced shortly.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43686/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> FYI, results on my laptop:
> 
> _Original benchmark (unlabeled resources)_
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.DeclineOffers
> Using 2000 slaves and 200 frameworks
> round 0 allocate took 2.028175secs to make 200 offers
> round 1 allocate took 2.006791secs to make 200 offers
> round 2 allocate took 2.033723secs to make 200 offers
> round 3 allocate took 2.017508secs to make 200 offers
> round 4 allocate took 2.037235secs to make 200 offers
> round 5 allocate took 2.054095secs to make 200 offers
> round 6 allocate took 2.048884secs to make 200 offers
> round 7 allocate took 2.044252secs to make 200 offers
> round 8 allocate took 2.060256secs to make 200 offers
> round 9 allocate took 2.07121secs to make 200 offers
> round 10 allocate took 2.066261secs to make 200 offers
> round 11 allocate took 2.034805secs to make 200 offers
> round 12 allocate took 2.053705secs to make 200 offers
> round 13 allocate took 2.042106secs to make 200 offers
> round 14 allocate took 2.082704secs to make 200 offers
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43685: Refactored test helper code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/#review121579
---


Ship it!




- Joris Van Remoortere


On March 2, 2016, 2:20 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43685/
> ---
> 
> (Updated March 2, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored test helper code.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 5f29085d7a491d8f672728228b824634ed42aeca 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
> 
> Diff: https://reviews.apache.org/r/43685/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43684: Cleaned up allocator benchmark code.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43684/#review121578
---


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp 


Let's sync with James before removing this.


- Joris Van Remoortere


On March 2, 2016, 2:20 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43684/
> ---
> 
> (Updated March 2, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up allocator benchmark code.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/43684/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44255/
---

(Updated 三月 2, 2016, 5:18 a.m.)


Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Jie Yu.


Changes
---

add tiny changelog


Bugs: MESOS-4492
https://issues.apache.org/jira/browse/MESOS-4492


Repository: mesos


Description
---

Signed-off-by: Fan Du 


Diffs
-

  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 

Diff: https://reviews.apache.org/r/44255/diff/


Testing (updated)
---

ChangLog:
v2:
  - Documenting those metrics
  - Add test code for MetricsTest as suggested by Guangya
  - post-review.py does not update original 
RR(https://reviews.apache.org/r/44058/), but only create a new one even if I 
rebased.


Tests:
1. make check GTEST_FILTER="MetricsTest.Master" on Centos-7 
(3.10.0-123.el7.x86_640)

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from MetricsTest
[ RUN  ] MetricsTest.Master
[   OK ] MetricsTest.Master (211 ms)
[--] 1 test from MetricsTest (211 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (244 ms total)
[  PASSED  ] 1 test

2. Verify its functionality with 'reserve' http endpoint as an test case

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 0.0,
"master/messages_unreserve_resource": 0.0,


# curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1  -d resources='[ { 
"name": "cpus", "type": "SCALAR","scalar": { "value": 1 
},"reservation":{"principal": "XiaoHaHa"}}  ]' -X POST  
ipdc02-kvm-guest2:5050/master/reserve
HTTP/1.1 200 OK
Date: Fri, 26 Feb 2016 19:59:01 GMT
Content-Length: 0

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot  | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 1.0,
"master/messages_unreserve_resource": 0.0,


Thanks,

fan du

Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44255/
---

Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Jie Yu.


Bugs: MESOS-4492
https://issues.apache.org/jira/browse/MESOS-4492


Repository: mesos


Description
---

Signed-off-by: Fan Du 


Diffs (updated)
-

  docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
  src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
  src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 

Diff: https://reviews.apache.org/r/44255/diff/


Testing (updated)
---

1. make check GTEST_FILTER="MetricsTest.Master" on Centos-7 
(3.10.0-123.el7.x86_640)

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from MetricsTest
[ RUN  ] MetricsTest.Master
[   OK ] MetricsTest.Master (211 ms)
[--] 1 test from MetricsTest (211 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (244 ms total)
[  PASSED  ] 1 test

2. Verify its functionality with 'reserve' http endpoint as an test case

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 0.0,
"master/messages_unreserve_resource": 0.0,


# curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1  -d resources='[ { 
"name": "cpus", "type": "SCALAR","scalar": { "value": 1 
},"reservation":{"principal": "XiaoHaHa"}}  ]' -X POST  
ipdc02-kvm-guest2:5050/master/reserve
HTTP/1.1 200 OK
Date: Fri, 26 Feb 2016 19:59:01 GMT
Content-Length: 0

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot  | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 1.0,
"master/messages_unreserve_resource": 0.0,


Thanks,

fan du

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44058/
---

(Updated 三月 2, 2016, 4:59 a.m.)


Review request for mesos, Greg Mann, haosdent huang, and Jie Yu.


Summary (updated)
-

Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation


Bugs: MESOS-4492
https://issues.apache.org/jira/browse/MESOS-4492


Repository: mesos


Description (updated)
---

Signed-off-by: Fan Du 


Diffs (updated)
-

  src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 

Diff: https://reviews.apache.org/r/44058/diff/


Testing
---

1. make check on Centos-7 (3.10.0-123.el7.x86_640
2. Verify its functionality with 'reserve' http endpoint as an test case

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 0.0,
"master/messages_unreserve_resource": 0.0,


# curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1  -d resources='[ { 
"name": "cpus", "type": "SCALAR","scalar": { "value": 1 
},"reservation":{"principal": "XiaoHaHa"}}  ]' -X POST  
ipdc02-kvm-guest2:5050/master/reserve
HTTP/1.1 200 OK
Date: Fri, 26 Feb 2016 19:59:01 GMT
Content-Length: 0

# curl http://ipdc02-kvm-guest2:5050/metrics/snapshot  | python -mjson.tool | 
grep reserve
"master/messages_reserve_resource": 1.0,
"master/messages_unreserve_resource": 0.0,


Thanks,

fan du

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/
---

(Updated March 2, 2016, 4 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[2/2] Added significant test coverage of `os::rmdir`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
756aa29ed134bf10a645af7f6562f86dc8e488f5 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
3c65d0422dc6e198180d53d1c9e6cb2839137434 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
d0592ef8a774d380e9df66b7e623eb72b29a28b3 
  3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 

Diff: https://reviews.apache.org/r/43908/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/
---

(Updated March 2, 2016, 3:55 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[1/2] Fix error reporting bug in `os::rmdir`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 

Diff: https://reviews.apache.org/r/43907/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

[Alex Clemmer]

> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 172
> > 
> >
> > What is this?

THe remnants of a merge of two commits, unfortunately.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
---


On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43908/
> ---
> 
> (Updated Feb. 25, 2016, 7:40 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added significant test coverage of `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 756aa29ed134bf10a645af7f6562f86dc8e488f5 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> d0592ef8a774d380e9df66b7e623eb72b29a28b3 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 
> 
> Diff: https://reviews.apache.org/r/43908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/
---

Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description
---

When fopen is failed,we should curl_easy_cleanup curl_handle.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 

Diff: https://reviews.apache.org/r/44254/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 44229: Added upgrade testing script.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review121574
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On March 2, 2016, 12:33 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44229/
> ---
> 
> (Updated March 2, 2016, 12:33 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added upgrade testing script.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44229/diff/
> 
> 
> Testing
> ---
> 
> This script is copied from @nnielsen, original patch can be found here: 
> https://reviews.apache.org/r/31645/
> 
> To test, build two different versions of Mesos in two different directories. 
> Then do:
> `support/test-upgrade.py --prev=/path/to/earlier/version 
> --next=/path/to/later/version`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

[Alex Clemmer]

> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48
> > 
> >
> > style

I'd just like to clarify that I made this line up in `git diff` because it was 
off... I guess git is subtly different in how it presents diffs.


> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 214-297
> > 
> >
> > I don't understand why these got removed.
> > They are not covered by the tests your introduced.

These tests are completely redundant. They exist in both `filesystem_tests.cpp` 
and `os_tests.cpp`. So I've removed them from `os.hpp`.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
---


On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43908/
> ---
> 
> (Updated Feb. 25, 2016, 7:40 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added significant test coverage of `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 756aa29ed134bf10a645af7f6562f86dc8e488f5 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> d0592ef8a774d380e9df66b7e623eb72b29a28b3 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 
> 
> Diff: https://reviews.apache.org/r/43908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44196/
---

(Updated March 1, 2016, 7:42 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
---

Reworked according to offline comments.


Bugs: MESOS-4824
https://issues.apache.org/jira/browse/MESOS-4824


Repository: mesos


Description
---

Adds extra mount-table checking logic specifically for orphaned persistent 
volumes that can be safely cleaned up.  This includes "known" orphans (i.e. 
containers detected via the `Launcher`).

Also adds some extra helpers in `slave::paths`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
7fdf518deeb388218438245623719f41613d031b 
  src/slave/paths.hpp 5ae3a2b86bf76859e0ffb78be2644af56bc88d49 
  src/slave/paths.cpp 6d9dad59386fb890267923f35edabbdf54fb39c6 
  src/tests/paths_tests.cpp 4c15ebc514e5d1714b243432eeff5377bb21b93f 

Diff: https://reviews.apache.org/r/44196/diff/


Testing (updated)
---

Tests added in previous review now pass.  i.e.
```
GLOG_v=1 sudo -E bin/mesos-tests.sh 
--gtest_filter="*MesosContainerizerRecoverOrphanedVolumes*" --verbose
GLOG_v=1 sudo -E bin/mesos-tests.sh 
--gtest_filter="*ChangeRootFilesystemOrphanedPersistentVolume" --verbose
```

Confirmed that the right log messages show up:
```
I0302 00:51:01.100466  1610 linux.cpp:782] Unmounting volume 
'/tmp/DiskResource_PersistentVolumeTest_ROOT_MesosContainerizerRecoverOrphanedVolumes_0_smk5ZU/slaves/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-S0/frameworks/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-/executors/cdbae703-603d-4e4c-a026-326dbc8c9ce2/runs/8742378c-9a5d-43d6-af31-0c7fe1f5c4c7/path1'
 for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
I0302 00:51:01.100538  1610 linux.cpp:798] Ignoring unmounting sandbox/work 
directory for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
```

---

CI test results:

```
 | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
Ubuntu 12 |
 Non-SSL |  :) | $| *|:)|   :) |:) |
 :)|
With-SSL |  :) | $|%*|#@|   ^@ |:) |
 :)|

 :) = Passed.
  $ = ProvisionerDockerRegistryPullerTest.ROOT_INTERNET_CURL_ShellCommand
  * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
  % = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
  ^ = CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_DestroyTracedProcess
  # = SlaveRecoveryTest/0.Reboot
  @ = SlaveRecoveryTest/0.RecoverTerminatedExecutor

```


Thanks,

Joseph Wu

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44122/
---

(Updated March 1, 2016, 7:39 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
---

Looks like that `flags.work_dir` assignment has no effect.


Bugs: MESOS-4824
https://issues.apache.org/jira/browse/MESOS-4824


Repository: mesos


Description
---

Based on DockerContainerizerTest.ROOT_DOCKER_RecoverOrphanedPersistentVolumes.  
This tests orphaned persistent volumes and the MesosContainerizer, with and 
without rootfs.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 

Diff: https://reviews.apache.org/r/44122/diff/


Testing
---

As of this patch, thise tests do not pass:

1) The `filesystem/linux` isolator recovers the persistent volume as a "known" 
orphan.  Known orphans are not cleaned up immediately.
  - We only detect rootfs mounts currently.  i.e. when the root of the mount is 
inside the agent's `/slaves`.
  - Persistent volume mounts have roots under `/volumes`.
2) When the containerizer removes this orphan, the `filesystem/linux` isolator 
has no `ContainerInfo` about it.  The isolator does not look up the mount table 
again, and the isolator ignores the cleanup.
3) Test checks the mount table and sees the mount is still present -> test 
failed.


Thanks,

Joseph Wu

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

[Alex Clemmer]

> On March 1, 2016, 10:56 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, lines 
> > 40-43
> > 
> >
> > How is this different from `fts_open` returning null with errno set to 
> > `ENOENT` below?

Good question. I've added a comment explaining -- `fts_open` won't actually 
return `NULL` on invalid paths, so if you try to `rmdir` an invalid path, you 
don't get an error.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121530
---


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 44199: Add .gitattributes file to Mesos.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44199/
---

Review request for mesos.


Repository: mesos


Description
---

Mesos added some patch files for 3rdparty library, but we can't avoid
tab characters inside these patch files. So when the ReviewBot apply
these patch files, it will show errors and apply failed.

In order to solve this issue, I added a .gitattributes file to mark
these patch files as binary, so git will not check the tab characters
anymore.


Diffs
-

  .gitattributes PRE-CREATION 

Diff: https://reviews.apache.org/r/44199/diff/


Testing
---


Thanks,

Zhiwei Chen

Re: Review Request 44199: Add .gitattributes file to Mesos.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44199/
---

(Updated March 2, 2016, 10:56 a.m.)


Review request for mesos.


Bugs: MESOS-4312
https://issues.apache.org/jira/browse/MESOS-4312


Repository: mesos


Description
---

Mesos added some patch files for 3rdparty library, but we can't avoid
tab characters inside these patch files. So when the ReviewBot apply
these patch files, it will show errors and apply failed.

In order to solve this issue, I added a .gitattributes file to mark
these patch files as binary, so git will not check the tab characters
anymore.


Diffs
-

  .gitattributes PRE-CREATION 

Diff: https://reviews.apache.org/r/44199/diff/


Testing
---


Thanks,

Zhiwei Chen

Re: Review Request 44189: Document docker runtime isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/#review121569
---


Ship it!




Ship It!

- Jie Yu


On March 2, 2016, 1:42 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44189/
> ---
> 
> (Updated March 2, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4683
> https://issues.apache.org/jira/browse/MESOS-4683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document docker runtime isolator.
> 
> 
> Diffs
> -
> 
>   docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 
> 
> Diff: https://reviews.apache.org/r/44189/diff/
> 
> 
> Testing
> ---
> 
> Tested with support/site-docker. Verified that the table works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 44251: Improved allocator perf for labeled reservations and volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44251/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4833
https://issues.apache.org/jira/browse/MESOS-4833


Repository: mesos


Description
---

When the cluster contains many resources that have either labeled
reservations or persistent volumes, allocator performance can decrease
substantially because such metadata prevents `Resource` objects from
being merged together inside the allocator. As a result, the allocator
must manipulate `Resources` vectors that consist of many small
individual `Resource` values; since many `Resources` operations take
linear-time in the number of `Resource` values they contain, this can
cause very significant slowdowns.

As a short-term solution, this commit strips dynamic reservation and
persistent volume information from the `Resources` objects used
internally by the allocator, because they are not needed when
aggregating resource quantities together.

A long-term solution for this problem will be addressed as work on
refactoring the allocator more generally.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/master/allocator/sorter/drf/sorter.hpp 
46b2a9caf13b028a3aee6c1590679f885be90fd6 
  src/master/allocator/sorter/drf/sorter.cpp 
9e863dd0ca5e2f2f0d517cb833687b757bed2c52 
  src/master/allocator/sorter/sorter.hpp 
ba91a38e47065718af87c9b3b7c5b74d25a258df 

Diff: https://reviews.apache.org/r/44251/diff/


Testing
---

make check

Perf:

```
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.458462secs to make 200 offers
round 1 allocate took 2.427941secs to make 200 offers
round 2 allocate took 2.460724secs to make 200 offers
round 3 allocate took 2.443408secs to make 200 offers
round 4 allocate took 2.464784secs to make 200 offers
round 5 allocate took 2.501429secs to make 200 offers
round 6 allocate took 2.468777secs to make 200 offers
round 7 allocate took 2.482268secs to make 200 offers
round 8 allocate took 2.479014secs to make 200 offers
round 9 allocate took 2.529951secs to make 200 offers
round 10 allocate took 2.460059secs to make 200 offers
```

Performance of `DeclineOffers` without labels is about ~2.1 seconds.


Thanks,

Neil Conway

Re: Review Request 43686: Added allocator benchmark using labeled resources.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43686/
---

(Updated March 2, 2016, 2:21 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Changed benchmark to isolate allocator bottleneck


Summary (updated)
-

Added allocator benchmark using labeled resources.


Bugs: MESOS-4691
https://issues.apache.org/jira/browse/MESOS-4691


Repository: mesos


Description (updated)
---

This reveals that when the cluster contains many reservations with
distinct labels, allocator performance slows down dramatically. A
short-term fix for this problem will be introduced shortly.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43686/diff/


Testing (updated)
---

make check

FYI, results on my laptop:

_Original benchmark (unlabeled resources)_
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.DeclineOffers
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.028175secs to make 200 offers
round 1 allocate took 2.006791secs to make 200 offers
round 2 allocate took 2.033723secs to make 200 offers
round 3 allocate took 2.017508secs to make 200 offers
round 4 allocate took 2.037235secs to make 200 offers
round 5 allocate took 2.054095secs to make 200 offers
round 6 allocate took 2.048884secs to make 200 offers
round 7 allocate took 2.044252secs to make 200 offers
round 8 allocate took 2.060256secs to make 200 offers
round 9 allocate took 2.07121secs to make 200 offers
round 10 allocate took 2.066261secs to make 200 offers
round 11 allocate took 2.034805secs to make 200 offers
round 12 allocate took 2.053705secs to make 200 offers
round 13 allocate took 2.042106secs to make 200 offers
round 14 allocate took 2.082704secs to make 200 offers


Thanks,

Neil Conway

Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

This returns a new `Resources` object that omits dynamic reservation
and persistent volume information. This is intended primarily for
situations in which code wants to efficiently compute aggregate
statistics about many `Resource` values for which reservation and
persistent volume information is not relevant.


Diffs
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
  src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 

Diff: https://reviews.apache.org/r/44250/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43685: Refactored test helper code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/
---

(Updated March 2, 2016, 2:20 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Refactored test helper code.


Diffs (updated)
-

  src/tests/mesos.hpp 5f29085d7a491d8f672728228b824634ed42aeca 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 

Diff: https://reviews.apache.org/r/43685/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43684: Cleaned up allocator benchmark code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43684/
---

(Updated March 2, 2016, 2:20 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Cleaned up allocator benchmark code.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/43684/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44236: Update slave's version after re-registering.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44236/#review121566
---



Patch looks great!

Reviews applied: [44236]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 2, 2016, 12:01 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44236/
> ---
> 
> (Updated March 2, 2016, 12:01 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4825
> https://issues.apache.org/jira/browse/MESOS-4825
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update slave's version after re-registering.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 
> 
> Diff: https://reviews.apache.org/r/44236/diff/
> 
> 
> Testing
> ---
> 
> Test it manually.
> 
> Test Steps:
> 1. Start 0.28.0 master
> 2. Start 0.28.0 slave
> 3. Stop 0.28.0 slave
> 4. Start 0.27.0 slave with the same work directory
>  
> Test Results:
> 
> ```
> Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
> json.tool
>   % Total% Received % Xferd  Average Speed   TimeTime Time  
> Current
>  Dload  Upload   Total   SpentLeft  Speed
> 100   588  100   5880 0  79277  0 --:--:-- --:--:-- --:--:-- 84000
> {
> "slaves": [
> {
> "active": true,
> "attributes": {},
> "hostname": "192.168.1.101",
> "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
> "offered_resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "offered_resources_full": [],
> "pid": "slave(1)@192.168.1.101:5051",
> "registered_time": 1456874482.32198,
> "reserved_resources": {},
> "reserved_resources_full": {},
> "resources": {
> "cpus": 8.0,
> "disk": 470832.0,
> "mem": 15360.0,
> "ports": "[31000-32000]"
> },
> "unreserved_resources": {
> "cpus": 8.0,
> "disk": 470832.0,
> "mem": 15360.0,
> "ports": "[31000-32000]"
> },
> "used_resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "used_resources_full": [],
> "version": "0.28.0"
> }
> ]
> }
> Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
> json.tool
>   % Total% Received % Xferd  Average Speed   TimeTime Time  
> Current
>  Dload  Upload   Total   SpentLeft  Speed
> 100   625  100   6250 0  85592  0 --:--:-- --:--:-- --:--:-- 89285
> {
> "slaves": [
> {
> "active": true,
> "attributes": {},
> "hostname": "192.168.1.101",
> "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
> "offered_resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "offered_resources_full": [],
> "pid": "slave(1)@192.168.1.101:5051",
> "registered_time": 1456874482.32198,
> "reregistered_time": 1456874497.25686,
> "reserved_resources": {},
> "reserved_resources_full": {},
> "resources": {
> "cpus": 8.0,
> "disk": 470832.0,
> "mem": 15360.0,
> "ports": "[31000-32000]"
> },
> "unreserved_resources": {
> "cpus": 8.0,
> "disk": 470832.0,
> "mem": 15360.0,
> "ports": "[31000-32000]"
> },
> "used_resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "used_resources_full": [],
> "version": "0.27.0"
> }
> ]
> }
> ```
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44247/#review121564
---


Ship it!




Ship It!

- Timothy Chen


On March 2, 2016, 1:44 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44247/
> ---
> 
> (Updated March 2, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Offers2 is never used nor waited for which can result in it not being called.
> SlaveId is an unused variable.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 6a60962b4593b3521c182c7320331743ccffd4ba 
> 
> Diff: https://reviews.apache.org/r/44247/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44247/
---

Review request for mesos, Adam B, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Offers2 is never used nor waited for which can result in it not being called.
SlaveId is an unused variable.


Diffs
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 

Diff: https://reviews.apache.org/r/44247/diff/


Testing
---

sudo make check


Thanks,

Joerg Schad

Re: Review Request 44189: Document docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/
---

(Updated March 1, 2016, 5:42 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy 
Chen.


Bugs: MESOS-4683
https://issues.apache.org/jira/browse/MESOS-4683


Repository: mesos


Description
---

Document docker runtime isolator.


Diffs (updated)
-

  docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 

Diff: https://reviews.apache.org/r/44189/diff/


Testing
---

Tested with support/site-docker. Verified that the table works correctly.


Thanks,

Gilbert Song

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

> On March 2, 2016, 1:31 a.m., Joseph Wu wrote:
> > src/slave/containerizer/docker.cpp, lines 585-586
> > 
> >
> > It would be a slightly stronger check if you include this as well:
> > ```
> > strings::startsWith(entry.root, volumesRootDir)
> > ```
> > 
> > I added `paths::getVolumeRootDir` here:
> > https://reviews.apache.org/r/44196/

SG. Added a TODO.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121527
---


On March 1, 2016, 11:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44232/
> ---
> 
> (Updated March 1, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Timothy Chen.
> 
> 
> Bugs: MESOS-4832
> https://issues.apache.org/jira/browse/MESOS-4832
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a check when umounting persistent volumes in docker containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
>   src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 
> 
> Diff: https://reviews.apache.org/r/44232/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44220/
---

(Updated March 2, 2016, 1:11 a.m.)


Review request for mesos, Anand Mazumdar and Greg Mann.


Changes
---

anand's comments and rebase.


Bugs: MESOS-4712
https://issues.apache.org/jira/browse/MESOS-4712


Repository: mesos


Description
---

Marked this as an API change in the CHANGELOG and removed references of this
field in the user doc. Also, updated the semantics for schedulers that
resubscribe.


Diffs (updated)
-

  CHANGELOG e6cc39b4f45317f94145f0a4a1b64215b9a0cbff 
  docs/scheduler-http-api.md 53b482a813fa3909e786791d5331ef11c8fcc662 

Diff: https://reviews.apache.org/r/44220/diff/


Testing
---

Rendered the markdown locally.


Thanks,

Vinod Kone

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44196/
---

(Updated March 1, 2016, 5:11 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
---

Rework the fix into what we (Jie & I) discussed offline.


Summary (updated)
-

Fixed MesosContainerizer orphaned persistent volume recovery.


Bugs: MESOS-4824
https://issues.apache.org/jira/browse/MESOS-4824


Repository: mesos


Description (updated)
---

Adds extra mount-table checking logic specifically for orphaned persistent 
volumes that can be safely cleaned up.  This includes "known" orphans (i.e. 
containers detected via the `Launcher`).

Also adds some extra helpers in `slave::paths`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
7fdf518deeb388218438245623719f41613d031b 
  src/slave/paths.hpp 5ae3a2b86bf76859e0ffb78be2644af56bc88d49 
  src/slave/paths.cpp 6d9dad59386fb890267923f35edabbdf54fb39c6 
  src/tests/paths_tests.cpp 4c15ebc514e5d1714b243432eeff5377bb21b93f 

Diff: https://reviews.apache.org/r/44196/diff/


Testing (updated)
---

Tests added in previous review now pass.  i.e.
```
GLOG_v=1 sudo -E bin/mesos-tests.sh 
--gtest_filter="*MesosContainerizerRecoverOrphanedVolumes*0" --verbose
GLOG_v=1 sudo -E bin/mesos-tests.sh 
--gtest_filter="*ChangeRootFilesystemOrphanedPersistentVolume" --verbose
```

Confirmed that the right log messages show up:
```
I0302 00:51:01.100466  1610 linux.cpp:782] Unmounting volume 
'/tmp/DiskResource_PersistentVolumeTest_ROOT_MesosContainerizerRecoverOrphanedVolumes_0_smk5ZU/slaves/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-S0/frameworks/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-/executors/cdbae703-603d-4e4c-a026-326dbc8c9ce2/runs/8742378c-9a5d-43d6-af31-0c7fe1f5c4c7/path1'
 for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
I0302 00:51:01.100538  1610 linux.cpp:798] Ignoring unmounting sandbox/work 
directory for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
```

---

CI test results (running)...


Thanks,

Joseph Wu

Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44243/
---

Review request for mesos, Anand Mazumdar and Greg Mann.


Bugs: MESOS-4712
https://issues.apache.org/jira/browse/MESOS-4712


Repository: mesos


Description
---

Master always closes any old active streaming connection when it gets a
SUBSCRIBE request.


Diffs
-

  src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 

Diff: https://reviews.apache.org/r/44243/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44218/
---

(Updated March 2, 2016, 1:09 a.m.)


Review request for mesos, Anand Mazumdar and Greg Mann.


Changes
---

reverted the devolve changes.


Bugs: MESOS-4712
https://issues.apache.org/jira/browse/MESOS-4712


Repository: mesos


Description
---

See the https://issues.apache.org/jira/browse/MESOS-4712 for details.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
4aa32e6422a458221b7829ec6f5223e6a013feae 
  include/mesos/v1/scheduler/scheduler.proto 
5d0e6c7dfcdbe004a8629361328287a88d53a1b6 
  src/examples/event_call_framework.cpp 
d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
  src/tests/scheduler_http_api_tests.cpp 
428e12646d80b45daec30cfe607b97f36170fdf5 
  src/tests/scheduler_tests.cpp 2b1693eaf1a6106f5e7d269e4e3f6c353dd6f017 

Diff: https://reviews.apache.org/r/44218/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

[Vinod Kone]

> On March 1, 2016, 10:32 p.m., Anand Mazumdar wrote:
> > src/internal/devolve.cpp, line 123
> > 
> >
> > Nit: s/but `Call::Subscribe` has//
> > 
> > Since we are inside `devolve` for conversion to `Call::Subscribe`, the 
> > above words are redundant.

I ended up reverting the devolve change and updating the master code to ignore 
the force field for http scheduler.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44218/#review121516
---


On March 1, 2016, 7:47 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44218/
> ---
> 
> (Updated March 1, 2016, 7:47 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the https://issues.apache.org/jira/browse/MESOS-4712 for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 4aa32e6422a458221b7829ec6f5223e6a013feae 
>   include/mesos/v1/scheduler/scheduler.proto 
> 5d0e6c7dfcdbe004a8629361328287a88d53a1b6 
>   src/examples/event_call_framework.cpp 
> d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/tests/scheduler_http_api_tests.cpp 
> 428e12646d80b45daec30cfe607b97f36170fdf5 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44218/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44122/
---

(Updated March 1, 2016, 5:08 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
---

Un-base on my test refactor branch.


Summary (updated)
-

Add tests for recovering orphaned persistent volumes.


Bugs: MESOS-4824
https://issues.apache.org/jira/browse/MESOS-4824


Repository: mesos


Description (updated)
---

Based on DockerContainerizerTest.ROOT_DOCKER_RecoverOrphanedPersistentVolumes.  
This tests orphaned persistent volumes and the MesosContainerizer, with and 
without rootfs.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
6a60962b4593b3521c182c7320331743ccffd4ba 
  src/tests/persistent_volume_tests.cpp 
bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 

Diff: https://reviews.apache.org/r/44122/diff/


Testing (updated)
---

As of this patch, thise tests do not pass:

1) The `filesystem/linux` isolator recovers the persistent volume as a "known" 
orphan.  Known orphans are not cleaned up immediately.
  - We only detect rootfs mounts currently.  i.e. when the root of the mount is 
inside the agent's `/slaves`.
  - Persistent volume mounts have roots under `/volumes`.
2) When the containerizer removes this orphan, the `filesystem/linux` isolator 
has no `ContainerInfo` about it.  The isolator does not look up the mount table 
again, and the isolator ignores the cleanup.
3) Test checks the mount table and sees the mount is still present -> test 
failed.


Thanks,

Joseph Wu

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121561
---




3rdparty/CMakeLists.txt (line 30)


Oh wait. Sorry, I marked this as ship it, but you forgot to update the 
Makefile.am (my build just failed as a result).

As soon as you update that and test the build, you should push this up, and 
then I think it's ready to go.


- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121560
---


Ship it!




- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated March 2, 2016, 12:52 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Summary (updated)
-

CMake: Add leveldb library to 3rdparty external builds.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description (updated)
---

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44218/#review121535
---


Ship it!




Ship It!

- Greg Mann


On March 1, 2016, 7:47 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44218/
> ---
> 
> (Updated March 1, 2016, 7:47 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the https://issues.apache.org/jira/browse/MESOS-4712 for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 4aa32e6422a458221b7829ec6f5223e6a013feae 
>   include/mesos/v1/scheduler/scheduler.proto 
> 5d0e6c7dfcdbe004a8629361328287a88d53a1b6 
>   src/examples/event_call_framework.cpp 
> d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/tests/scheduler_http_api_tests.cpp 
> 428e12646d80b45daec30cfe607b97f36170fdf5 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44218/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44227/#review121557
---



Patch looks great!

Reviews applied: [44227]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44227/
> ---
> 
> (Updated March 1, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Michael Park.
> 
> 
> Bugs: MESOS-4002
> https://issues.apache.org/jira/browse/MESOS-4002
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added AWAIT_READY() call to reservation_endpoint_tests.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> f3a143812aa10bc445ac5d27c00318e91eb086aa 
> 
> Diff: https://reviews.apache.org/r/44227/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
---

(Updated March 2, 2016, 12:41 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3644
https://issues.apache.org/jira/browse/MESOS-3644


Repository: mesos


Description
---

Windows: Forked signal handling in `signalhandler.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
---

OSX: make check
Windows: make


Thanks,

Daniel Pravat

Review Request 44229: Added upgrade testing script.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/
---

Review request for mesos.


Repository: mesos


Description
---

Added upgrade testing script.


Diffs
-

  support/test-upgrade.py PRE-CREATION 

Diff: https://reviews.apache.org/r/44229/diff/


Testing
---

This script is copied from @nnielsen, original patch can be found here: 
https://reviews.apache.org/r/31645/

To test, build two different versions of Mesos in two different directories. 
Then do:
`support/test-upgrade.py --prev=/path/to/earlier/version 
--next=/path/to/later/version`


Thanks,

Greg Mann

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121554
---


Ship it!




Ship It!

- Timothy Chen


On March 1, 2016, 11:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44232/
> ---
> 
> (Updated March 1, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Timothy Chen.
> 
> 
> Bugs: MESOS-4832
> https://issues.apache.org/jira/browse/MESOS-4832
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a check when umounting persistent volumes in docker containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
>   src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 
> 
> Diff: https://reviews.apache.org/r/44232/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 44239: Introduced copy fetcher plugin for file URIs.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4834
https://issues.apache.org/jira/browse/MESOS-4834


Repository: mesos


Description
---

This change adds support for fetching `file` URIs using the fetcher plugin
framework.


Diffs
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
  src/uri/fetchers/copy.hpp PRE-CREATION 
  src/uri/fetchers/copy.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44239/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 44236: Update slave's version after re-registering.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44236/
---

(Updated March 2, 2016, 8:01 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Add JIRA/bugs #.


Bugs: MESOS-4825
https://issues.apache.org/jira/browse/MESOS-4825


Repository: mesos


Description
---

Update slave's version after re-registering.


Diffs
-

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 

Diff: https://reviews.apache.org/r/44236/diff/


Testing
---

Test it manually.

Test Steps:
1. Start 0.28.0 master
2. Start 0.28.0 slave
3. Stop 0.28.0 slave
4. Start 0.27.0 slave with the same work directory
 
Test Results:

```
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
json.tool
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   588  100   5880 0  79277  0 --:--:-- --:--:-- --:--:-- 84000
{
"slaves": [
{
"active": true,
"attributes": {},
"hostname": "192.168.1.101",
"id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
"offered_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"offered_resources_full": [],
"pid": "slave(1)@192.168.1.101:5051",
"registered_time": 1456874482.32198,
"reserved_resources": {},
"reserved_resources_full": {},
"resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"unreserved_resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"used_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"used_resources_full": [],
"version": "0.28.0"
}
]
}
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
json.tool
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   625  100   6250 0  85592  0 --:--:-- --:--:-- --:--:-- 89285
{
"slaves": [
{
"active": true,
"attributes": {},
"hostname": "192.168.1.101",
"id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
"offered_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"offered_resources_full": [],
"pid": "slave(1)@192.168.1.101:5051",
"registered_time": 1456874482.32198,
"reregistered_time": 1456874497.25686,
"reserved_resources": {},
"reserved_resources_full": {},
"resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"unreserved_resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"used_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"used_resources_full": [],
"version": "0.27.0"
}
]
}
```


Thanks,

Klaus Ma

Review Request 44236: Update slave's version after re-registering.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44236/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Update slave's version after re-registering.


Diffs
-

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 

Diff: https://reviews.apache.org/r/44236/diff/


Testing
---

Test it manually.

Test Steps:
1. Start 0.28.0 master
2. Start 0.28.0 slave
3. Stop 0.28.0 slave
4. Start 0.27.0 slave with the same work directory
 
Test Results:

```
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
json.tool
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   588  100   5880 0  79277  0 --:--:-- --:--:-- --:--:-- 84000
{
"slaves": [
{
"active": true,
"attributes": {},
"hostname": "192.168.1.101",
"id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
"offered_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"offered_resources_full": [],
"pid": "slave(1)@192.168.1.101:5051",
"registered_time": 1456874482.32198,
"reserved_resources": {},
"reserved_resources_full": {},
"resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"unreserved_resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"used_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"used_resources_full": [],
"version": "0.28.0"
}
]
}
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m 
json.tool
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   625  100   6250 0  85592  0 --:--:-- --:--:-- --:--:-- 89285
{
"slaves": [
{
"active": true,
"attributes": {},
"hostname": "192.168.1.101",
"id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
"offered_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"offered_resources_full": [],
"pid": "slave(1)@192.168.1.101:5051",
"registered_time": 1456874482.32198,
"reregistered_time": 1456874497.25686,
"reserved_resources": {},
"reserved_resources_full": {},
"resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"unreserved_resources": {
"cpus": 8.0,
"disk": 470832.0,
"mem": 15360.0,
"ports": "[31000-32000]"
},
"used_resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"used_resources_full": [],
"version": "0.27.0"
}
]
}
```


Thanks,

Klaus Ma

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated March 1, 2016, 11:58 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp`.


Diffs (updated)
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
---

(Updated March 1, 2016, 11:56 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Forked signal handling in `signalhandler.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
---

OSX: make check
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
---

(Updated March 1, 2016, 11:54 p.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.


Repository: mesos


Description (updated)
---

Windows: Added support for `slave/gc.cpp`.


Diffs (updated)
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
  src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
---

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Yi Sun]

> On March 1, 2016, 11:47 p.m., Yi Sun wrote:
> > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152
> > 
> >
> > The second param for strcpy_s is the number of chars to be copied. It 
> > doesn't seem right here.

It's the size of the dest buffer. I got it wrong.


- Yi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121541
---


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121543
---


Ship it!




Ship It!

- Yi Sun


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/
---

(Updated March 1, 2016, 11:50 p.m.)


Review request for mesos, Joseph Wu and Timothy Chen.


Changes
---

Added a TODO about making slave's work_dir a slave+shared mount.


Bugs: MESOS-4832
https://issues.apache.org/jira/browse/MESOS-4832


Repository: mesos


Description (updated)
---

Added a check when umounting persistent volumes in docker containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 

Diff: https://reviews.apache.org/r/44232/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121540
---



Bad patch!

Reviews applied: [44141, 44140]

Failed command: ./support/apply-review.sh -n -r 44140

Error:
2016-03-01 23:23:40 URL:https://reviews.apache.org/r/44140/diff/raw/ 
[3115/3115] -> "44140.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:2195
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11767/console

- Mesos ReviewBot


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
---




3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)


style



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 32)


We have `hashset::EMPTY`.
`const hashset& EMPTY = hashset::EMPTY;`



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (lines 51 - 91)


Can you add a TODO to parameterize this test?
It's the same code copy pasted with 1 difference: relative vs. absolute 
path.



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 172)


What is this?



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (lines 163 - 194)


I don't understand why these got removed.
They are not covered by the tests your introduced.


- Joris Van Remoortere


On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43908/
> ---
> 
> (Updated Feb. 25, 2016, 7:40 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added significant test coverage of `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 756aa29ed134bf10a645af7f6562f86dc8e488f5 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> d0592ef8a774d380e9df66b7e623eb72b29a28b3 
>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422 
> 
> Diff: https://reviews.apache.org/r/43908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44226: Modified tests to remove `Shutdown` event.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44226/#review121531
---



Patch looks great!

Reviews applied: [44222, 44224, 44223, 44225, 44226]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44226/
> ---
> 
> (Updated March 1, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing tests to not rely on the `Shutdown` event
> in the executor protobufs.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44226/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121530
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp (lines 40 - 
43)


How is this different from `fts_open` returning null with errno set to 
`ENOENT` below?


- Joris Van Remoortere


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/#review121518
---


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 118)


style.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp (line 19)


new line.


- Joris Van Remoortere


On March 1, 2016, 10:07 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40938/
> ---
> 
> (Updated March 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Mark `os::chroot` as deleted on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
> 
> Diff: https://reviews.apache.org/r/40938/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: make.bat
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40939/#review121519
---


Fix it, then Ship it!




verified nothing changed in the posix implementation.


3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 117)


style



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp (lines 28 - 29)


why the extra new line?



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp (line 216)


no extra new-line



3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp (lines 20 - 24)


Why does this file need to include these?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp (lines 46 - 
56)


2 new lines between functions in a namespace.


- Joris Van Remoortere


On March 1, 2016, 10:08 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40939/
> ---
> 
> (Updated March 1, 2016, 10:08 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Marked `os::su` as deleted on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
> 
> Diff: https://reviews.apache.org/r/40939/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: make.bat
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44231: Added rmdir error string to Appc store fetch.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44231/#review121525
---


Ship it!




Ship It!

- Jie Yu


On March 1, 2016, 10:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44231/
> ---
> 
> (Updated March 1, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added rmdir error string to Appc store fetch.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 955647d2e4a26783898042ab80e641db7e4d4980 
> 
> Diff: https://reviews.apache.org/r/44231/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44218/#review121516
---


Fix it, then Ship it!




LGTM.


src/internal/devolve.cpp (line 123)


Nit: s/but `Call::Subscribe` has//

Since we are inside `devolve` for conversion to `Call::Subscribe`, the 
above words are redundant.


- Anand Mazumdar


On March 1, 2016, 7:47 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44218/
> ---
> 
> (Updated March 1, 2016, 7:47 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the https://issues.apache.org/jira/browse/MESOS-4712 for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 4aa32e6422a458221b7829ec6f5223e6a013feae 
>   include/mesos/v1/scheduler/scheduler.proto 
> 5d0e6c7dfcdbe004a8629361328287a88d53a1b6 
>   src/examples/event_call_framework.cpp 
> d07d05d4b1eae5d2286d3fc1fdc32247bc19cada 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/tests/scheduler_http_api_tests.cpp 
> 428e12646d80b45daec30cfe607b97f36170fdf5 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44218/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44230/#review121524
---


Ship it!




Ship It!

- Jie Yu


On March 1, 2016, 10:01 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44230/
> ---
> 
> (Updated March 1, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently dont handle special files like device files in rmdir. This change
> adds FS_DEFAULT as one of the cases where we try to unlink a file.
> 
> Reference: http://man7.org/linux/man-pages/man3/fts.3.html
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/44230/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44220/#review121521
---


Fix it, then Ship it!




LGTM.


docs/scheduler-http-api.md (line 95)


Nit: Can we remove the comma at the end?



docs/scheduler-http-api.md (line 117)


s/response/event containing the same FrameworkID.


- Anand Mazumdar


On March 1, 2016, 7:48 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44220/
> ---
> 
> (Updated March 1, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-4712
> https://issues.apache.org/jira/browse/MESOS-4712
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Marked this as an API change in the CHANGELOG and removed references of this
> field in the user doc. Also, updated the semantics for schedulers that
> resubscribe.
> 
> 
> Diffs
> -
> 
>   CHANGELOG e6cc39b4f45317f94145f0a4a1b64215b9a0cbff 
>   docs/scheduler-http-api.md 53b482a813fa3909e786791d5331ef11c8fcc662 
> 
> Diff: https://reviews.apache.org/r/44220/diff/
> 
> 
> Testing
> ---
> 
> Rendered the markdown locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/
---

Review request for mesos, Joseph Wu and Timothy Chen.


Bugs: MESOS-4832
https://issues.apache.org/jira/browse/MESOS-4832


Repository: mesos


Description
---

Added a check when umounting persistent volumes in docker containerizer.

See ticket for details.


Diffs
-

  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 

Diff: https://reviews.apache.org/r/44232/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43915/
---

(Updated March 1, 2016, 10:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
f05cd55a9e080f44566ec7dcef22f11950496d6f 
  src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48 
  src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701 

Diff: https://reviews.apache.org/r/43915/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Re: Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44182/
---

(Updated March 1, 2016, 10:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Added the flag --cgroups_net_cls_secondary_handles to documentation.


Diffs (updated)
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 

Diff: https://reviews.apache.org/r/44182/diff/


Testing
---

Ran the website in docker and verified the changes.


Thanks,

Avinash sridharan

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
---

(Updated March 1, 2016, 10:17 p.m.)


Review request for mesos and Jie Yu.


Changes
---

addressed comments.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles instead of
assuming that the entire 64K space of secondary handles is available
for use.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
acd61e615951e18dd51a2ce1e746ba733e9159ae 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
f05cd55a9e080f44566ec7dcef22f11950496d6f 

Diff: https://reviews.apache.org/r/43914/diff/


Testing
---

make and make check.

Also ran sudo make check for the "NetClsIsolatoTest"


Thanks,

Avinash sridharan

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/
---

(Updated March 1, 2016, 10:17 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700


Repository: mesos


Description
---

Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
7b257de2afbc66f63c47a80c1f828e3e95bd602d 

Diff: https://reviews.apache.org/r/43916/diff/


Testing
---

make check and sudo make check (for NetClsIsolator)


Thanks,

Avinash sridharan

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

[Daniel Pravat]

> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, 
> > line 30
> > 
> >
> > remove newline

I don't see it. Maybe in the old version of os.hpp


> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, 
> > line 23
> > 
> >
> > remove new line

I don't see it. Maybe in the old version of os.hpp


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/#review121509
---


On March 1, 2016, 10:07 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40938/
> ---
> 
> (Updated March 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Mark `os::chroot` as deleted on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
> 
> Diff: https://reviews.apache.org/r/40938/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: make.bat
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40939/
---

(Updated March 1, 2016, 10:08 p.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.


Summary (updated)
-

Stout: Marked `os::su` as deleted on Windows.


Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780


Repository: mesos


Description (updated)
---

Stout: Marked `os::su` as deleted on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
f1d38029eef7e89dfdb8915158fba17865e6855b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 

Diff: https://reviews.apache.org/r/40939/diff/


Testing
---

OSX: make check
Windows: make.bat


Thanks,

Daniel Pravat

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40938/
---

(Updated March 1, 2016, 10:07 p.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.


Summary (updated)
-

Stout: Mark `os::chroot` as deleted on Windows.


Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780


Repository: mesos


Description (updated)
---

Stout: Mark `os::chroot` as deleted on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
03eff5a831283f6d298e9a1feecfdc7369cacfe7 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
f1d38029eef7e89dfdb8915158fba17865e6855b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
d917a99a46841156dc1e359c44010938cc45e943 

Diff: https://reviews.apache.org/r/40938/diff/


Testing
---

OSX: make check
Windows: make.bat


Thanks,

Daniel Pravat

Review Request 44231: Added rmdir error string to Appc store fetch.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44231/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added rmdir error string to Appc store fetch.


Diffs
-

  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
955647d2e4a26783898042ab80e641db7e4d4980 

Diff: https://reviews.apache.org/r/44231/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 44230: Added FS_DEFAULT case in rmdir.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44230/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

We currently dont handle special files like device files in rmdir. This change
adds FS_DEFAULT as one of the cases where we try to unlink a file.

Reference: http://man7.org/linux/man-pages/man3/fts.3.html


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 

Diff: https://reviews.apache.org/r/44230/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43916/#review121508
---



Patch looks great!

Reviews applied: [43914, 43915, 44182, 43916]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 7:59 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43916/
> ---
> 
> (Updated March 1, 2016, 7:59 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 7b257de2afbc66f63c47a80c1f828e3e95bd602d 
> 
> Diff: https://reviews.apache.org/r/43916/diff/
> 
> 
> Testing
> ---
> 
> make check and sudo make check (for NetClsIsolator)
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40939/
---

(Updated March 1, 2016, 9:42 p.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi.


Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780


Repository: mesos


Description
---

Windows: Unified POSIX and Windows implementation of `su`


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a25e2c1e5584e744c666bbc654eafbfc5f7b10e6 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
581ec5baac05bd8b702bfe000893e67fb04bde3b 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
42733d429814bf0512540188264830aeaabcabbe 

Diff: https://reviews.apache.org/r/40939/diff/


Testing
---

OSX: make check
Windows: make.bat


Thanks,

Daniel Pravat

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
---

(Updated March 1, 2016, 9:39 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4817
https://issues.apache.org/jira/browse/MESOS-4817


Repository: mesos


Description
---

Updated flag examples to refer to /snapshot instead of deprecated stats.json.


Diffs
-

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
---

make test + manually checked the flags example.


Thanks,

Joerg Schad

Re: Review Request 44112: Updated tests to use /state endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/
---

(Updated March 1, 2016, 9:39 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4817
https://issues.apache.org/jira/browse/MESOS-4817


Repository: mesos


Description
---

Updated tests to use /state endpoint instead of deprecated state.json endpoint.


Diffs
-

  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/44112/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44111/
---

(Updated March 1, 2016, 9:39 p.m.)


Review request for mesos, Alexander Rojas, Philip Norman, and Vinod Kone.


Bugs: MESOS-4817
https://issues.apache.org/jira/browse/MESOS-4817


Repository: mesos


Description
---

Updated UI controller to use master/state endpoint instead of deprecated 
state.json endpoint.


Diffs
-

  src/webui/master/static/js/controllers.js 
56a44fccdc2a004463576c710f9eb117646514a2 

Diff: https://reviews.apache.org/r/44111/diff/


Testing
---

make check + manually checked the UI


Thanks,

Joerg Schad

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43905/
---

(Updated March 1, 2016, 9:38 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780


Repository: mesos


Description
---

`su` does not exist on Windows. Unfortunately, the launcher also depends
on it. In this commit, we remove Windows support for the launcher flag
`user`, which controls whether we use `su` in the launcher. This
allows us to divest ourselves of `su` altogether on Windows.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
d917a99a46841156dc1e359c44010938cc45e943 
  src/slave/containerizer/mesos/containerizer.cpp 
129406abdff715e321f683911e404c46676b6daf 
  src/slave/containerizer/mesos/launch.hpp 
7e29ca2b8bec1c20aef122472cff60f6003603ad 
  src/slave/containerizer/mesos/launch.cpp 
6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 

Diff: https://reviews.apache.org/r/43905/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43905/#review121505
---


Fix it, then Ship it!




Split the commit.


3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 


Not sure how you were able to commit a stout change together with a mesos 
change.


- Joris Van Remoortere


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43905/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `su` does not exist on Windows. Unfortunately, the launcher also depends
> on it. In this commit, we remove Windows support for the launcher flag
> `user`, which controls whether we use `su` in the launcher. This
> allows us to divest ourselves of `su` altogether on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 129406abdff715e321f683911e404c46676b6daf 
>   src/slave/containerizer/mesos/launch.hpp 
> 7e29ca2b8bec1c20aef122472cff60f6003603ad 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/43905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>