Review Request 35622: Adding a link to example framework implementations (RENDLR)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLR)


Diffs
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLR)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 18, 2015, 9:15 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description (updated)
---

Adding a link to example framework implementations (RENDLER)


Diffs
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLER)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 18, 2015, 9:18 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Adding a link to example framework implementations (RENDLER)


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLER)


Diffs
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLR)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 18, 2015, 9:18 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLER)


Diffs (updated)
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLER)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 18, 2015, 9:24 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLER)


Diffs (updated)
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLER)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 18, 2015, 9:29 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLER)


Diffs
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Review Request 35625: Fixing a typo

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35625/
---

Review request for mesos.


Repository: mesos


Description
---

Fixing a typo


Diffs
-


Diff: https://reviews.apache.org/r/35625/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 35622: Adding a link to example framework implementations (RENDLER)

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/
---

(Updated June 23, 2015, 3:57 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Adding a link to example framework implementations (RENDLER)


Diffs
-

  docs/app-framework-development-guide.md 
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f 

Diff: https://reviews.apache.org/r/35622/diff/


Testing
---

This is a documentation change.


Thanks,

Artem Harutyunyan

Review Request 35843: Making markup doxygen-friendly

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Making markup doxygen-friendly


Diffs
-

  docs/allocation-module.md 5db4aa22ee66d5c320378cbdcbc082782d31ed73 
  docs/app-framework-development-guide.md 
d651ec8b20977ddbe5578558f164ba7805b2ad25 
  docs/clang-format.md 909a253b699fca37ae4ea0f8c9d680c9a5f012ed 
  docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
  docs/mesos-doxygen-style-guide.md 93a5e70a4a78bc3a6e83206b06f45dd28e9daa99 
  docs/mesos-markdown-style-guide.md 7ea0b1d7e00ac05ecf438fc22f2f62483f2db37b 
  docs/mesos-testing-patterns.md 6383786419fec23ad49289b594979f0657e1fe83 
  docs/modules.md d323f2adfa3c5e431f7dbfe79402fe8de081cf80 
  docs/network-monitoring.md 680f771806772c84973613eaee48ddf3b57fd858 
  docs/reconciliation.md ae4a99c334093a9d085df06d7f49af16f045 
  docs/release-guide.md 38ecbec75db59b457c3b55003665a51ba10fc254 
  docs/upgrades.md 355307a5f301d73a0c7d0541f509a45c1fc9a72b 

Diff: https://reviews.apache.org/r/35843/diff/


Testing
---

This is a documentation only change:
  - Replacing triple backtics with tildes  
  - Adding .cpp for code blocks  
  - Using indentation where tildes produces line numbers

Rendered all the pages from scratch using doxygen as well as rake/middleman. 
Reviewd all affected pages.


Thanks,

Artem Harutyunyan

Re: Review Request 35843: Making markup doxygen-friendly

[Artem Harutyunyan]

> On June 25, 2015, 2:54 p.m., Benjamin Hindman wrote:
> > docs/mesos-doxygen-style-guide.md, line 20
> > <https://reviews.apache.org/r/35843/diff/1/?file=991532#file991532line20>
> >
> > Seems like most of the examples in this file should still be ~~~{.cpp}? 
> > I'll fix before commit.

Actually not. If you wrap it with ~~~{.cpp} doxygen will strip most of the 
comments out (we have STRIP_CODE_COMMENTS = YES in Doxyfile, probably for a 
good reason). That is why in places where I wanted to preserve comments I 
intentionally used indentation.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
-------


On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35843/
> ---
> 
> (Updated June 24, 2015, 7:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Making markup doxygen-friendly
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 5db4aa22ee66d5c320378cbdcbc082782d31ed73 
>   docs/app-framework-development-guide.md 
> d651ec8b20977ddbe5578558f164ba7805b2ad25 
>   docs/clang-format.md 909a253b699fca37ae4ea0f8c9d680c9a5f012ed 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
>   docs/mesos-doxygen-style-guide.md 93a5e70a4a78bc3a6e83206b06f45dd28e9daa99 
>   docs/mesos-markdown-style-guide.md 7ea0b1d7e00ac05ecf438fc22f2f62483f2db37b 
>   docs/mesos-testing-patterns.md 6383786419fec23ad49289b594979f0657e1fe83 
>   docs/modules.md d323f2adfa3c5e431f7dbfe79402fe8de081cf80 
>   docs/network-monitoring.md 680f771806772c84973613eaee48ddf3b57fd858 
>   docs/reconciliation.md ae4a99c334093a9d085df06d7f49af16f045 
>   docs/release-guide.md 38ecbec75db59b457c3b55003665a51ba10fc254 
>   docs/upgrades.md 355307a5f301d73a0c7d0541f509a45c1fc9a72b 
> 
> Diff: https://reviews.apache.org/r/35843/diff/
> 
> 
> Testing
> ---
> 
> This is a documentation only change:
>   - Replacing triple backtics with tildes  
>   - Adding .cpp for code blocks  
>   - Using indentation where tildes produces line numbers
> 
> Rendered all the pages from scratch using doxygen as well as rake/middleman. 
> Reviewd all affected pages.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 35843: Making markup doxygen-friendly

[Artem Harutyunyan]

> On June 25, 2015, 2:54 p.m., Benjamin Hindman wrote:
> > docs/allocation-module.md, line 37
> > <https://reviews.apache.org/r/35843/diff/1/?file=991528#file991528line37>
> >
> > These ones don't need to be indented, but I'll take care of this for 
> > you when I commit.

oops, I missed this one. Thanks!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
-------


On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35843/
> ---
> 
> (Updated June 24, 2015, 7:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Making markup doxygen-friendly
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 5db4aa22ee66d5c320378cbdcbc082782d31ed73 
>   docs/app-framework-development-guide.md 
> d651ec8b20977ddbe5578558f164ba7805b2ad25 
>   docs/clang-format.md 909a253b699fca37ae4ea0f8c9d680c9a5f012ed 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
>   docs/mesos-doxygen-style-guide.md 93a5e70a4a78bc3a6e83206b06f45dd28e9daa99 
>   docs/mesos-markdown-style-guide.md 7ea0b1d7e00ac05ecf438fc22f2f62483f2db37b 
>   docs/mesos-testing-patterns.md 6383786419fec23ad49289b594979f0657e1fe83 
>   docs/modules.md d323f2adfa3c5e431f7dbfe79402fe8de081cf80 
>   docs/network-monitoring.md 680f771806772c84973613eaee48ddf3b57fd858 
>   docs/reconciliation.md ae4a99c334093a9d085df06d7f49af16f045 
>   docs/release-guide.md 38ecbec75db59b457c3b55003665a51ba10fc254 
>   docs/upgrades.md 355307a5f301d73a0c7d0541f509a45c1fc9a72b 
> 
> Diff: https://reviews.apache.org/r/35843/diff/
> 
> 
> Testing
> ---
> 
> This is a documentation only change:
>   - Replacing triple backtics with tildes  
>   - Adding .cpp for code blocks  
>   - Using indentation where tildes produces line numbers
> 
> Rendered all the pages from scratch using doxygen as well as rake/middleman. 
> Reviewd all affected pages.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 35757: Refactored OSNetUri tests for Fetcher

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35757/
---

(Updated June 26, 2015, 5:38 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/35757/diff/


Testing
---

This is a test case refactoring.


Thanks,

Artem Harutyunyan

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/
---

(Updated June 30, 2015, 4:24 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Fixes MESOS-2862


Diffs (updated)
-

  src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/35755/diff/


Testing
---

- make check 
- added a test case for fetcher


Thanks,

Artem Harutyunyan

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated June 30, 2015, 4:25 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/
---

(Updated July 6, 2015, 9:03 a.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Fixes MESOS-2862


Diffs
-

  src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/35755/diff/


Testing
---

- make check 
- added a test case for fetcher


Thanks,

Artem Harutyunyan

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated July 6, 2015, 1:51 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Fixed compile error. Merged changes from parent review.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 36189: Add strings::Mode to strings::trim.

[Artem Harutyunyan]

> On July 6, 2015, 1:53 p.m., Artem Harutyunyan wrote:
> > Ship It!

Thanks for taking care of this!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36189/#review90558
---


On July 6, 2015, 8:29 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36189/
> ---
> 
> (Updated July 6, 2015, 8:29 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Vinod Kone.
> 
> 
> Bugs: MESOS-2862
> https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> 963029bea989a68a484f7b8b47d29ea5fffeb955 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 
> 9733b2ec5d68605b694210c66144b8d9f8c36467 
> 
> Diff: https://reviews.apache.org/r/36189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 36189: Add strings::Mode to strings::trim.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36189/#review90558
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 6, 2015, 8:29 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36189/
> ---
> 
> (Updated July 6, 2015, 8:29 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Vinod Kone.
> 
> 
> Bugs: MESOS-2862
> https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> 963029bea989a68a484f7b8b47d29ea5fffeb955 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 
> 9733b2ec5d68605b694210c66144b8d9f8c36467 
> 
> Diff: https://reviews.apache.org/r/36189/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated July 6, 2015, 1:59 p.m.)


Review request for Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

[Artem Harutyunyan]

> On July 5, 2015, 8:02 p.m., Benjamin Hindman wrote:
> >
> 
> Joris Van Remoortere wrote:
> Hey Ben,
> Great questions in the latter half of your review.
> It turns out that the original test was malformed. It happened to pass 
> because there is also a help process that responds to the `/help` endpoint.
> The original intent of the test, however, was to ensure that the newly 
> added `/help` endpoint would work. That newly added enpoint was actually 
> never being hit.
> 
> The name is being passed through to the HTTPProcess constructor 
> explicitly to make the url at which the test endpoint is being hit stable. If 
> the default `Process` constructor is used, then we end up using the 
> auto-incrementing ids which can be hard to deterministically hit.
> 
> I agree that we should stick with a single endpoint as you suggested; 
> however, we need to change the name to something unique to avoid this test 
> from passing accidentally when the intended path is broken.
> 
> We definitely need a comment as to why we're explicitly specifying the 
> name of the process (as described above). I have seen a couple of people bang 
> their heads against this, so let's add cleared documentation to the headers / 
> doxygen as well!

Ben suggested to use MOCK_METHOD/EXPECT_CALL to make sure that the right 
callback is being invoked. As for the named processes, Ben suggested to use 
process.self().id instead of having named processes.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/#review90423
-------


On July 6, 2015, 9:03 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35755/
> ---
> 
> (Updated July 6, 2015, 9:03 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2862
> https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixes MESOS-2862
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
>   src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 
> 
> Diff: https://reviews.apache.org/r/35755/diff/
> 
> 
> Testing
> ---
> 
> - make check 
> - added a test case for fetcher
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36245/#review90650
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 6, 2015, 10:16 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36245/
> ---
> 
> (Updated July 6, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-2943
> https://issues.apache.org/jira/browse/MESOS-2943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While we figure out how to avoid this bug in clang-3.5, we can allow people 
> to compile by explicitly specifying the return type of the lambda.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e 
> 
> Diff: https://reviews.apache.org/r/36245/diff/
> 
> 
> Testing
> ---
> 
> make check 3rdparty using clang-3.5
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36267: MESOS-2943: Add comment for explicit return type.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90761
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 7, 2015, 10:21 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36267/
> ---
> 
> (Updated July 7, 2015, 10:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2943
> https://issues.apache.org/jira/browse/MESOS-2943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e 
> 
> Diff: https://reviews.apache.org/r/36267/diff/
> 
> 
> Testing
> ---
> 
> Only adding a comment.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 36337: Adding a missing newline to Framework Development Guide.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36337/
---

Review request for mesos, Adam B and Benjamin Hindman.


Repository: mesos


Description
---

Adding a missing newline to Framework Development Guide.


Diffs
-

  docs/app-framework-development-guide.md 
0f7c7c74988e3bde98a11b7e23fc0b1ebec10c6a 

Diff: https://reviews.apache.org/r/36337/diff/


Testing
---

Generated the website with rake and verified that Framework Development Guide 
is rendered correctly.


Thanks,

Artem Harutyunyan

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated July 8, 2015, 9:48 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed some of Joris' comments


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

> On July 8, 2015, 7:54 p.m., Joris Van Remoortere wrote:
> > src/tests/fetcher_tests.cpp, line 281
> > <https://reviews.apache.org/r/36024/diff/4/?file=1000470#file1000470line281>
> >
> > I think you mean `const vector& testEndpoints` ?

Indeed!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/#review91046
---


On July 8, 2015, 9:48 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36024/
> ---
> 
> (Updated July 8, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2862
> https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored OSNetUri tests for fetcher to avoid code copy/pasting.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 
> 
> Diff: https://reviews.apache.org/r/36024/diff/
> 
> 
> Testing
> ---
> 
> # This is a test case refactoring.
> 
> $ make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated July 8, 2015, 10:44 p.m.)


Review request for Joris Van Remoortere.


Changes
---

Addressing Joris' comments.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/
---

(Updated July 9, 2015, 10:19 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Fixes MESOS-2862


Diffs
-

  src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/35755/diff/


Testing
---

- make check 
- added a test case for fetcher


Thanks,

Artem Harutyunyan

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/
---

(Updated July 9, 2015, 10:20 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2862
https://issues.apache.org/jira/browse/MESOS-2862


Repository: mesos


Description
---

Refactored OSNetUri tests for fetcher to avoid code copy/pasting.


Diffs
-

  src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 

Diff: https://reviews.apache.org/r/36024/diff/


Testing
---

# This is a test case refactoring.

$ make check


Thanks,

Artem Harutyunyan

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated July 10, 2015, 3:20 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
245716353ad5ffa8d705fc5e826addfa6a3594dc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 36389: Enable remote execution of arbitrary command.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91723
---



src/slave/flags.hpp (line 117)
<https://reviews.apache.org/r/36389/#comment145304>

Just for my own education purpose :-), Is there a reason for a newline here?



src/slave/slave.cpp (line 151)
<https://reviews.apache.org/r/36389/#comment145297>

Do you think it makes sense to capture the default value in a single 
location? Otherwise it's hardcoded in two places (here and in flags.cpp)



src/slave/slave.cpp (lines 4691 - 4694)
<https://reviews.apache.org/r/36389/#comment145310>

wouldn't const std::vector args(command.arguments()); work here?



src/slave/slave.cpp (line 4698)
<https://reviews.apache.org/r/36389/#comment145298>

If you make this review dependent on /r/36424 then RB should be smart 
enough to apply the patch from there before apllying and building this one. 
That should eliminate the need of having a temporary code in the review.



src/slave/slave.cpp (line 4702)
<https://reviews.apache.org/r/36389/#comment145311>

if we are using command.value() here we might as well use command.args() 
and ditch the args variable altogether.



src/slave/slave.cpp (line 4743)
<https://reviews.apache.org/r/36389/#comment145302>

Is it OK to return HTTP 200 if the command returned a non-zero error code?

In the statements above, for exaple, the error code is returned if the 
command execution failed (albeit, the reasons for a failure are different).

This approach makes the HTTP 200 insufficient for verifying successful 
execution of the command.



src/slave/slave.cpp (line 4755)
<https://reviews.apache.org/r/36389/#comment145299>

Shouldn't there be an equivalent of an assert here if we never expect this 
to happen? Something like this: 

if (response.isReady()) {
 ASSERT
}

return http::BadRequest ...

Unless, there is possibility of a race where the result becomes ready right 
at the 15th second (in a separate thread) and by the time this lambda is 
executed the response becomes actually (and legitimately) ready.


- Artem Harutyunyan


On July 14, 2015, 4:20 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36389/
> ---
> 
> (Updated July 14, 2015, 4:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2830
> https://issues.apache.org/jira/browse/MESOS-2830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-2830
> 
> Under certain (maintenance) circumnstance, it may be necessary
> (or desirable) to execute arbitrary operator's commands on the
> slave (the entire fleet or a subset thereof) bypassing the Mesos
> Task execution mechanism; this may typically be necessary for
> maintenance and/or emergency actions.
> 
> This patch adds an HTTP endpoint (/execute) which accepts a
> JSON-encoded CommandInfo structure and executes the given
> command (with optional arguments).
> 
> The output of the command (along with potentially any stderr
> messages) is returned JSON-encoded in the Response.
> 
> For more details, see the design doc at:
> https://goo.gl/4npTMU
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
>   src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
>   src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 
> 
> Diff: https://reviews.apache.org/r/36389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> lots of manual testing (using Postman, REST client)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36424: Created a command executor helper method.

[Artem Harutyunyan]

> On July 13, 2015, 5:20 p.m., Paul Brett wrote:
> >

 is inline really necessary here?


> On July 13, 2015, 5:20 p.m., Paul Brett wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 307
> > 
> >
> > How about returning a tuple/struct of stdout, stderr and return code 
> > and let the caller decide what they want?
> 
> Marco Massenzio wrote:
> sure, that would be a possibility too, but it seems to me that the 
> "approved way" in Mesos is to return a `Try` for when something *may* go 
> wrong.
> This is consistent across the entire code base.

Maybe I am missing something, I did a grep for `Future` and you could use 
`Failure()` to indicate the error. In that case you'll need to change the 
return type of `.then` lamda to `Future` and also to replace a 
`return Error(...` on line 346 with `return Failure(...` (which you might want 
to do anyway for the sake of consistency).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36424/#review91566
---


On July 13, 2015, 9:21 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36424/
> ---
> 
> (Updated July 13, 2015, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-3035
> https://issues.apache.org/jira/browse/MESOS-3035
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-2902
> 
> While researching how to execute an arbitrary script
> to detect the Master IP address, it emerged clearly that
> a helper method to execute an arbitrary command/script on
> a node and obtain either stdout or stderr would have been
> useful and avoided a lot of code repetition.
> 
> This could not be ultimately used for the purpose at hand,
> but I believe it to be useful enough (particularly, to avoid
> people doing "coding by copy&paste" and/or waste time
> researching the same functionality).
> 
> This would also be beneficial in MESOS-2830, factoring out the remote command 
> execution logic.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> f6acb204582a9e696c3b09d4e4c543bb052e97d4 
> 
> Diff: https://reviews.apache.org/r/36424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36389: Enable remote execution of arbitrary command.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91784
---


To make sure that this is fool proof(ish), I would suggest that this should 
only ship only when the Authorizer framework (mentioned in the TODO comment) 
becomes available. Also, I would add a screaming comment to --usage, something 
along the lines of 'this is insecure, and this enables arbitrary command 
executrion with root privileges'. 

In general, I am of the firm opinion that this feature should come with a 
whitelisting mechanism that will allow operators to whitelist (benign) commands 
that they want to execute, and forbid anything else.

- Artem Harutyunyan


On July 14, 2015, 4:20 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36389/
> ---
> 
> (Updated July 14, 2015, 4:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2830
> https://issues.apache.org/jira/browse/MESOS-2830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-2830
> 
> Under certain (maintenance) circumnstance, it may be necessary
> (or desirable) to execute arbitrary operator's commands on the
> slave (the entire fleet or a subset thereof) bypassing the Mesos
> Task execution mechanism; this may typically be necessary for
> maintenance and/or emergency actions.
> 
> This patch adds an HTTP endpoint (/execute) which accepts a
> JSON-encoded CommandInfo structure and executes the given
> command (with optional arguments).
> 
> The output of the command (along with potentially any stderr
> messages) is returned JSON-encoded in the Response.
> 
> For more details, see the design doc at:
> https://goo.gl/4npTMU
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
>   src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
>   src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 
> 
> Diff: https://reviews.apache.org/r/36389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> lots of manual testing (using Postman, REST client)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36389: Enable remote execution of arbitrary command.

[Artem Harutyunyan]

> On July 15, 2015, 12:36 a.m., Artem Harutyunyan wrote:
> > src/slave/slave.cpp, line 4755
> > <https://reviews.apache.org/r/36389/diff/4/?file=1011886#file1011886line4755>
> >
> > Shouldn't there be an equivalent of an assert here if we never expect 
> > this to happen? Something like this: 
> > 
> > if (response.isReady()) {
> >  ASSERT
> > }
> > 
> > return http::BadRequest ...
> > 
> > Unless, there is possibility of a race where the result becomes ready 
> > right at the 15th second (in a separate thread) and by the time this lambda 
> > is executed the response becomes actually (and legitimately) ready.

I sat down with Joris to verify whether or not there was a possible race 
condition resulting in a ready Future inside the `.after` lambda, and turned 
out that there is not. It's a great idea to have an explicit check for 
isReady() to be false, but the assert (i.e. CHECK) still does looks like a 
better option.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36389/#review91723
---


On July 14, 2015, 4:20 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36389/
> ---
> 
> (Updated July 14, 2015, 4:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2830
> https://issues.apache.org/jira/browse/MESOS-2830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-2830
> 
> Under certain (maintenance) circumnstance, it may be necessary
> (or desirable) to execute arbitrary operator's commands on the
> slave (the entire fleet or a subset thereof) bypassing the Mesos
> Task execution mechanism; this may typically be necessary for
> maintenance and/or emergency actions.
> 
> This patch adds an HTTP endpoint (/execute) which accepts a
> JSON-encoded CommandInfo structure and executes the given
> command (with optional arguments).
> 
> The output of the command (along with potentially any stderr
> messages) is returned JSON-encoded in the Response.
> 
> For more details, see the design doc at:
> https://goo.gl/4npTMU
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
>   src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
>   src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a 
>   src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
>   src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 
> 
> Diff: https://reviews.apache.org/r/36389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> lots of manual testing (using Postman, REST client)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/
---

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-3079
https://issues.apache.org/jira/browse/MESOS-3079


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 

Diff: https://reviews.apache.org/r/36618/diff/


Testing
---

sudo make check


Thanks,

Artem Harutyunyan

Re: Review Request 36658: Updated SSL documentation. Added to home page.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36658/#review92490
---

Ship it!


Rendered affected files, everything looks good.

- Artem Harutyunyan


On July 21, 2015, 2:39 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36658/
> ---
> 
> (Updated July 21, 2015, 2:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3121
> https://issues.apache.org/jira/browse/MESOS-3121
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated SSL documentation. Added to home page.
> 
> 
> Diffs
> -
> 
>   docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 
>   docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 
> 
> Diff: https://reviews.apache.org/r/36658/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36656/#review92492
---

Ship it!



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 673)
<https://reviews.apache.org/r/36656/#comment146704>

Since it's used in several places, will it make sense to have a helper 
function that returns a vector with protocols?



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 675)
<https://reviews.apache.org/r/36656/#comment146699>

s/protocol/protocols/



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 807)
<https://reviews.apache.org/r/36656/#comment146700>

ditto.



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 865)
<https://reviews.apache.org/r/36656/#comment146701>

    ditto.


- Artem Harutyunyan


On July 21, 2015, 3:51 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36656/
> ---
> 
> (Updated July 21, 2015, 3:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3121
> https://issues.apache.org/jira/browse/MESOS-3121
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.hpp 
> 3f8d351589f8bb26c886da12c53b5e02a242376a 
>   3rdparty/libprocess/src/openssl.cpp 
> 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 2fe50601615b0bee57bd3e05dc9c932f93ca7477 
> 
> Diff: https://reviews.apache.org/r/36656/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36673: Removed pthread from Once and Gate.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92538
---



3rdparty/libprocess/src/gate.hpp (line 18)
<https://reviews.apache.org/r/36673/#comment146747>

Is this todo still valid?


- Artem Harutyunyan


On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> ---
> 
> (Updated July 21, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/once.hpp 
> 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 
>   3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b 
> 
> Diff: https://reviews.apache.org/r/36673/diff/
> 
> 
> Testing
> ---
> 
> make check in libprocess.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36674/#review92541
---



include/mesos/executor.hpp (line 243)
<https://reviews.apache.org/r/36674/#comment146750>

s/execute/executed/

I would rewrite this:

Mutex for enforcing serial execution of all non-callbacks.



include/mesos/scheduler.hpp (line 452)
<https://reviews.apache.org/r/36674/#comment146752>

    ditto.


- Artem Harutyunyan


On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36674/
> ---
> 
> (Updated July 21, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 
>   include/mesos/scheduler.hpp 9dae0a8f5af168f25eb462e30473f8fd7da50913 
>   src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 
>   src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 
> 
> Diff: https://reviews.apache.org/r/36674/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated July 21, 2015, 10:29 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Changes
---

Rebased and changed comments to Doxygen format.


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 36673: Removed pthread from Once and Gate.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92553
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 21, 2015, 10:55 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> ---
> 
> (Updated July 21, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/once.hpp 
> 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 
>   3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b 
> 
> Diff: https://reviews.apache.org/r/36673/diff/
> 
> 
> Testing
> ---
> 
> make check in libprocess.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36627: Fixed cgroups oom killer test on Ubuntu 14.04

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---

(Updated July 22, 2015, 3:04 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Changes
---

used mlockall(MCL_FUTURE) for locking pages into memory.


Summary (updated)
-

Fixed cgroups oom killer test on Ubuntu 14.04


Bugs: MESOS-2660
https://issues.apache.org/jira/browse/MESOS-2660


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 

Diff: https://reviews.apache.org/r/36627/diff/


Testing (updated)
---

sudo make check

Verified that the process actually gets killed by oom-killer:

```
# tail -f /var/log/syslog

Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
lt-memory-test- cpuset=/ mems_allowed=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 PID: 
76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
#57~14.04.1-Ubuntu
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
BIOS 6.00 05/20/2014
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
88022efc1000 8801fd2efc30 81765721 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
8801fd2efc80 81165067 880231f10ee8 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
[] dump_stack+0x45/0x56
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
[] dump_header+0x7f/0x1f1
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
[] ? find_lock_task_mm+0x47/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
[] oom_kill_process+0x205/0x360
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
[] ? security_capable_noaudit+0x15/0x20
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
[] mem_cgroup_oom_synchronize+0x581/0x5e0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
[] ? mem_cgroup_try_charge_mm+0xa0/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
[] pagefault_out_of_memory+0x14/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
[] mm_fault_error+0x67/0x140
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
[] __do_page_fault+0x4ec/0x560
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
[] ? __enqueue_entity+0x78/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
[] ? set_next_entity+0x95/0xb0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
[] ? __switch_to+0x167/0x580
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
[] do_page_fault+0x31/0x70
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
[] page_fault+0x28/0x30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
/mesos_test killed as a result of limit of /mesos_test
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
usage 65536kB, limit 65536kB, failcnt 24
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] memory+swap: 
usage 0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: usage 
0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memory 
cgroup stats for /mesos_test: cache:0KB rss:65536KB rss_huge:63488KB 
mapped_file:0KB writeback:0KB inactive_anon:0KB active_anon:0KB 
inactive_file:0KB active_file:0KB unevictable:65536KB
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052467] [ pid ]   
uid  tgid total_vm  rss nr_ptes swapents oom_score_adj name
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052574] [76599] 
0 765998245231766 1221 0 lt-memory-test-
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052575] Memory 
cgroup out of memory: Kill process 76599 (lt-memory-test-) score 14 or 
sacrifice child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed 
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB, 
file-rss:59076kB


```


Thanks,

Artem Harutyunyan

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/
---

(Updated July 23, 2015, 10:38 a.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Summary (updated)
-

WIP: Fixed cgroups oom killer test on Ubuntu 14.04


Bugs: MESOS-2660
https://issues.apache.org/jira/browse/MESOS-2660


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 

Diff: https://reviews.apache.org/r/36627/diff/


Testing (updated)
---

It seems there is still one more cgroups memory test failing on more test 
failing on my box. I'd like to fix that too and commit it together with this 
one. 

sudo make check

Verified that the process actually gets killed by oom-killer:

```
# tail -f /var/log/syslog

Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
lt-memory-test- cpuset=/ mems_allowed=0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 PID: 
76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
#57~14.04.1-Ubuntu
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
BIOS 6.00 05/20/2014
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
88022efc1000 8801fd2efc30 81765721 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
8801fd2efc80 81165067 880231f10ee8 880231f10a30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
[] dump_stack+0x45/0x56
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
[] dump_header+0x7f/0x1f1
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
[] ? find_lock_task_mm+0x47/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
[] oom_kill_process+0x205/0x360
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
[] ? security_capable_noaudit+0x15/0x20
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
[] mem_cgroup_oom_synchronize+0x581/0x5e0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
[] ? mem_cgroup_try_charge_mm+0xa0/0xa0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
[] pagefault_out_of_memory+0x14/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
[] mm_fault_error+0x67/0x140
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
[] __do_page_fault+0x4ec/0x560
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
[] ? __enqueue_entity+0x78/0x80
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
[] ? set_next_entity+0x95/0xb0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
[] ? __switch_to+0x167/0x580
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
[] do_page_fault+0x31/0x70
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
[] page_fault+0x28/0x30
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
/mesos_test killed as a result of limit of /mesos_test
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
usage 65536kB, limit 65536kB, failcnt 24
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] memory+swap: 
usage 0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] kmem: usage 
0kB, limit 18014398509481983kB, failcnt 0
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052461] Memory 
cgroup stats for /mesos_test: cache:0KB rss:65536KB rss_huge:63488KB 
mapped_file:0KB writeback:0KB inactive_anon:0KB active_anon:0KB 
inactive_file:0KB active_file:0KB unevictable:65536KB
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052467] [ pid ]   
uid  tgid total_vm  rss nr_ptes swapents oom_score_adj name
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052574] [76599] 
0 765998245231766 1221 0 lt-memory-test-
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052575] Memory 
cgroup out of memory: Kill process 76599 (lt-memory-test-) score 14 or 
sacrifice child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed 
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB, 
file-rss:59076kB


```


Thanks,

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36674/#review92815
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 21, 2015, 10:56 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36674/
> ---
> 
> (Updated July 21, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 
>   include/mesos/scheduler.hpp 9dae0a8f5af168f25eb462e30473f8fd7da50913 
>   src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 
>   src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 
> 
> Diff: https://reviews.apache.org/r/36674/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92816
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 22, 2015, 12:07 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> ---
> 
> (Updated July 22, 2015, 12:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp 
> e40ec55f7818fad8703787ecb67869c9e1922e85 
> 
> Diff: https://reviews.apache.org/r/36629/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36672: Removed pthread specialization from Synchronized.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36672/#review92817
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36672/
> ---
> 
> (Updated July 21, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3118
> https://issues.apache.org/jira/browse/MESOS-3118
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp 
> e40ec55f7818fad8703787ecb67869c9e1922e85 
> 
> Diff: https://reviews.apache.org/r/36672/diff/
> 
> 
> Testing
> ---
> 
> Breaking patch, requires dependent patches.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36715/#review92864
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 23, 2015, 12:49 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36715/
> ---
> 
> (Updated July 23, 2015, 12:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/event_loop.hpp 
> 45aa2a6019dc08da287b7c8a9d799619deb69747 
>   3rdparty/libprocess/src/libev.cpp 8960c75010e3ceca3486a1fbb0fdeeffd62f4ec8 
>   3rdparty/libprocess/src/libevent.cpp 
> 02f9e61c1357e7b450e53b252b49d1979e782ae8 
>   3rdparty/libprocess/src/process.cpp 
> d6b0d5517964bf7c7276689e801a38b34a3f9db2 
> 
> Diff: https://reviews.apache.org/r/36715/diff/
> 
> 
> Testing
> ---
> 
> make check with libev, libevent
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36705/#review92865
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 22, 2015, 1:23 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36705/
> ---
> 
> (Updated July 22, 2015, 1:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Replaced ThreadLocal use with thread_local.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/executor.hpp 
> 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
>   3rdparty/libprocess/include/process/process.hpp 
> 8620547148f8a69d5b661eaf08063ca72347b6a4 
>   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
>   3rdparty/libprocess/src/libev.cpp 8960c75010e3ceca3486a1fbb0fdeeffd62f4ec8 
>   3rdparty/libprocess/src/libevent.hpp 
> 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
>   3rdparty/libprocess/src/libevent.cpp 
> 02f9e61c1357e7b450e53b252b49d1979e782ae8 
>   3rdparty/libprocess/src/process.cpp 
> d6b0d5517964bf7c7276689e801a38b34a3f9db2 
> 
> Diff: https://reviews.apache.org/r/36705/diff/
> 
> 
> Testing
> ---
> 
> make check with gcc-4.8, gcc-4.9, clang-3.5, clang-3.6
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36741/#review92930
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 23, 2015, 4:40 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36741/
> ---
> 
> (Updated July 23, 2015, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are two things that have to change in the current CMake build
> solution in order to work on OS X 10.10:
>   * librt (which holds the POSIX.1b Realtime Extensions interfaces in
> Linux, including things like async I/O and memory-mapped files, etc.)
> does not exist on OS X, and does not need to be linked
>   * The version of GTest attempts to find std::tr1::tuple, which is not
> available on OS X 10.10. Like we have done in autotools (see[1] and
> also configure.ac) we simply define `GTEST_USE_OWN_TR1_TUPLE` when
> we're compiling on OS X.
> 
> [1] 
> https://mail-archives.apache.org/mod_mbox/mesos-dev/201403.mbox/%3c20140306223933.2625.25...@reviews.apache.org%3E
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 851ab94e4c0f901520c9a4d209f5b9c928116d3c 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> d6cdd05e281f23f0a57809d3798b5766fb2e9aa6 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 082489ca4a31843886f764105e70e6af9779ca11 
> 
> Diff: https://reviews.apache.org/r/36741/diff/
> 
> 
> Testing
> ---
> 
> Tested fixes on OS X 10.10 and Ubuntu 14 boxes.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

[Artem Harutyunyan]

988kB, 
file-rss:59076kB


```


Thanks,

Artem Harutyunyan

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

al-vm:329808kB, anon-rss:67988kB, 
file-rss:59076kB


```


Thanks,

Artem Harutyunyan

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

> On July 23, 2015, 8:02 p.m., Marco Massenzio wrote:
> > src/tests/memory_test_helper.cpp, line 87
> > <https://reviews.apache.org/r/36627/diff/2/?file=1019121#file1019121line87>
> >
> > micro-nit: missing an `a` in `posix_memlign`

Fixed in the latest commit. Thanks!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review92862
---


On July 24, 2015, 5:32 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36627/
> ---
> 
> (Updated July 24, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2660
> https://issues.apache.org/jira/browse/MESOS-2660
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/36627/diff/
> 
> 
> Testing
> ---
> 
> It seems there is still one more cgroups memory test failing on more test 
> failing on my box. I'd like to fix that too and commit it together with this 
> one. 
> 
> sudo make check
> 
> Verified that the process actually gets killed by oom-killer:
> 
> ```
> # tail -f /var/log/syslog
> 
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
> lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
> lt-memory-test- cpuset=/ mems_allowed=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 
> PID: 76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
> #57~14.04.1-Ubuntu
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
> name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
> BIOS 6.00 05/20/2014
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
> 88022efc1000 8801fd2efc30 81765721 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
> 8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
> 8801fd2efc80 81165067 880231f10ee8 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
> [] dump_stack+0x45/0x56
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
> [] dump_header+0x7f/0x1f1
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
> [] ? find_lock_task_mm+0x47/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
> [] oom_kill_process+0x205/0x360
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
> [] ? security_capable_noaudit+0x15/0x20
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
> [] mem_cgroup_oom_synchronize+0x581/0x5e0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052439]  
> [] ? mem_cgroup_try_charge_mm+0xa0/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052440]  
> [] pagefault_out_of_memory+0x14/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052442]  
> [] mm_fault_error+0x67/0x140
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052445]  
> [] __do_page_fault+0x4ec/0x560
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052449]  
> [] ? __enqueue_entity+0x78/0x80
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052450]  
> [] ? set_next_entity+0x95/0xb0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052452]  
> [] ? __switch_to+0x167/0x580
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052454]  
> [] do_page_fault+0x31/0x70
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052456]  
> [] page_fault+0x28/0x30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052457] Task in 
> /mesos_test killed as a result of limit of /mesos_test
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052459] memory: 
> usage 65536kB, limit 65536kB, failcnt 24
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052460] 
> memory+swap:

Re: Review Request 36827: Removed and guarded pthread specifics for libevent-openssl.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36827/#review93062
---

Ship it!


Built on OSX, ran sudo make check.


3rdparty/libprocess/src/libevent.cpp (line 198)
<https://reviews.apache.org/r/36827/#comment147324>

Do you think it would make sense to make the error message more 
descriptive? Maybe something like 'Libevent must be compiled with either 
pthread or Windows thread support'? Thanks!


- Artem Harutyunyan


On July 26, 2015, 12:53 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36827/
> ---
> 
> (Updated July 26, 2015, 12:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent.cpp 
> 1f175a4ae83391152d064779c6ab69d31cbaf867 
>   3rdparty/libprocess/src/openssl.cpp 
> 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 
> 
> Diff: https://reviews.apache.org/r/36827/diff/
> 
> 
> Testing
> ---
> 
> make check.
> Waiting on validation from someone with an OSX build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93077
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 29)
<https://reviews.apache.org/r/36829/#comment147336>

const?



3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 30)
<https://reviews.apache.org/r/36829/#comment147337>

Perhaps I am missing something, but is it reasonable to assume that 
 will always be included before this header?



3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 32)
<https://reviews.apache.org/r/36829/#comment147338>

Ditto about .


- Artem Harutyunyan


On July 26, 2015, 2 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36829/
> ---
> 
> (Updated July 26, 2015, 2 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36829/diff/
> 
> 
> Testing
> ---
> 
> requires follow-up patch.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36830: Libprocess: Introduce configurable `UNIMPLEMENTED` macro.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93078
---

Ship it!



3rdparty/libprocess/configure.ac (lines 97 - 101)
<https://reviews.apache.org/r/36830/#comment147339>

Are you planning a follow-up patch to introduce this to the configure.ac of 
Mesos as well?


- Artem Harutyunyan


On July 26, 2015, 2:01 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36830/
> ---
> 
> (Updated July 26, 2015, 2:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb 
> 
> Diff: https://reviews.apache.org/r/36830/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36828/#review93080
---

Ship it!



3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp (line 97)
<https://reviews.apache.org/r/36828/#comment147342>

const?


- Artem Harutyunyan


On July 26, 2015, 1:04 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36828/
> ---
> 
> (Updated July 26, 2015, 1:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3118
> https://issues.apache.org/jira/browse/MESOS-3118
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 
> 5d24f21f63433b8525370736dd630880d324ebeb 
> 
> Diff: https://reviews.apache.org/r/36828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36826: Removed common/factory as it is not used.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93081
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 26, 2015, 12:19 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36826/
> ---
> 
> (Updated July 26, 2015, 12:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 
>   src/common/factory.hpp bdddcf872eae1a4ed78ca8b35864ee59bbaecb65 
> 
> Diff: https://reviews.apache.org/r/36826/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36825: Removed common/thread as it is not used.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36825/#review93082
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 26, 2015, 12:12 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36825/
> ---
> 
> (Updated July 26, 2015, 12:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 
>   src/common/thread.hpp 9685898136b7a270f5ff53bdd3720ad717c4943d 
>   src/common/thread.cpp 751e9e83e0ed3b9e4a5e0a8396424f2ef4e8fe4b 
> 
> Diff: https://reviews.apache.org/r/36825/diff/
> 
> 
> Testing
> ---
> 
> make check.
> grepped for common/thread
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36824: Used std::thread instead of pthread for ns tests.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/#review93083
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 26, 2015, 12:02 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36824/
> ---
> 
> (Updated July 26, 2015, 12:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/ns_tests.cpp 
> c71c33fa1247d1658be91ce81c93bfffd5b282b7 
> 
> Diff: https://reviews.apache.org/r/36824/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="NsTest.*"
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36823: Used std::thread instead of pthread for cgroups tests.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823/#review93084
---

Ship it!



src/tests/containerizer/cgroups_tests.cpp (line 807)
<https://reviews.apache.org/r/36823/#comment147343>

const?


- Artem Harutyunyan


On July 26, 2015, 12:02 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36823/
> ---
> 
> (Updated July 26, 2015, 12:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3120
> https://issues.apache.org/jira/browse/MESOS-3120
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> caecd5dfa3fef33dba35cfc1b5934a11e2cc961a 
> 
> Diff: https://reviews.apache.org/r/36823/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="CgroupsAnyHierarchyWithFreezerTest.*"
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36820: Fixed clang warning [-Wunevaluated-expression] in process tests.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36820/#review93085
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 26, 2015, 9:51 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36820/
> ---
> 
> (Updated July 26, 2015, 9:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removes `warning: expression with side effects has no effect in an 
> unevaluated context`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> bc54d29235e7cf015d796f83000a136788c7df65 
> 
> Diff: https://reviews.apache.org/r/36820/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36024/#review93089
---


After discussing this with the shepherd it was decided to drop this patch. The 
benefits of refactoring the copy-pasted boilerplate code are overshadowed by 
reduced readability and added complexity.

- Artem Harutyunyan


On July 9, 2015, 10:20 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36024/
> ---
> 
> (Updated July 9, 2015, 10:20 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2862
> https://issues.apache.org/jira/browse/MESOS-2862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored OSNetUri tests for fetcher to avoid code copy/pasting.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 
> 
> Diff: https://reviews.apache.org/r/36024/diff/
> 
> 
> Testing
> ---
> 
> # This is a test case refactoring.
> 
> $ make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED` macro.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93124
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 27, 2015, 12:19 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> ---
> 
> (Updated July 27, 2015, 12:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36842/diff/
> 
> 
> Testing
> ---
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime 
> error occured when configured by default, and a compile-time error ocurred 
> when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36845: Stout: Introduced THREAD_LOCAL wrapper for thread local storage.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93230
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp (line 20)
<https://reviews.apache.org/r/36845/#comment147553>

micro-nit #1: Is there a link explaining this that is not behind the 
registration wall?



3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp (line 22)
<https://reviews.apache.org/r/36845/#comment147554>

micro nit #2: either s/required/require/, or  point to where the 
requirement was made.


- Artem Harutyunyan


On July 27, 2015, 2:05 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36845/
> ---
> 
> (Updated July 27, 2015, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This replaced the ThreadLocal primitive with the new c++11 standard.
> The exception is on OSX where we use `__thread` as thread_local is not
> supported.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 89e7b1854bd7f449f4f0027d76c6430d259a24de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
> 552d6e97c882a36d6a889af205c422e51f544b34 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 
> 319fcdf517b24f5bb9c85dad4093b09ec87e915e 
> 
> Diff: https://reviews.apache.org/r/36845/diff/
> 
> 
> Testing
> ---
> 
> dependens on follow-up patch.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36845: Stout: Introduced THREAD_LOCAL wrapper for thread local storage.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93298
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp (line 25)
<https://reviews.apache.org/r/36845/#comment147675>

Also, by default TLS for a lot of people is Transport Layer Security. So 
this name will likely cause some brain cycle waste every now and then.


- Artem Harutyunyan


On July 27, 2015, 2:05 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36845/
> ---
> 
> (Updated July 27, 2015, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This replaced the ThreadLocal primitive with the new c++11 standard.
> The exception is on OSX where we use `__thread` as thread_local is not
> supported.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 89e7b1854bd7f449f4f0027d76c6430d259a24de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
> 552d6e97c882a36d6a889af205c422e51f544b34 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 
> 319fcdf517b24f5bb9c85dad4093b09ec87e915e 
> 
> Diff: https://reviews.apache.org/r/36845/diff/
> 
> 
> Testing
> ---
> 
> dependens on follow-up patch.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93339
---

Ship it!


make check with libev and libevent on OSX

- Artem Harutyunyan


On July 27, 2015, 2:15 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36844/
> ---
> 
> (Updated July 27, 2015, 2:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> bd95fe197532131255072a86aba83cd5e822419a 
>   3rdparty/libprocess/include/process/executor.hpp 
> 434d23ac8119e24454f8bc8324d7b26ec62a85c7 
>   3rdparty/libprocess/include/process/process.hpp 
> 8620547148f8a69d5b661eaf08063ca72347b6a4 
>   3rdparty/libprocess/src/libev.hpp fd26728fe9c0688b82fd75f0bfc83b8d0a3b8581 
>   3rdparty/libprocess/src/libev.cpp 55ed6efd47ac1864af828e68320c1929843cde57 
>   3rdparty/libprocess/src/libevent.hpp 
> 3a0a46ba95db95f4a007ec755012ac969d1c6cd9 
>   3rdparty/libprocess/src/libevent.cpp 
> 1f175a4ae83391152d064779c6ab69d31cbaf867 
>   3rdparty/libprocess/src/process.cpp 
> 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
> 
> Diff: https://reviews.apache.org/r/36844/diff/
> 
> 
> Testing
> ---
> 
> make check with libev and libevent.
> Requires validation on OSX.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

e-rss:59076kB


```


Thanks,

Artem Harutyunyan

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

n-rss:67988kB, 
file-rss:59076kB


```


Thanks,

Artem Harutyunyan

Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/
---

Review request for mesos, Bernd Mathiske and Klaus Ma.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Factored out the pattern for URL generation in (another)fetcher test.


Diffs
-

  src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 

Diff: https://reviews.apache.org/r/36946/diff/


Testing
---

GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check


Thanks,

Artem Harutyunyan

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

[Artem Harutyunyan]

> On July 31, 2015, 12:39 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 343
> > <https://reviews.apache.org/r/36946/diff/1/?file=1025117#file1025117line343>
> >
> > This change seems to eliminate the essence of the test, namely the 
> > leading white space.
> 
> Klaus Ma wrote:
> There are two UT cases here:
> 
> - FetcherTest-OSNetUriTest
> - FetcherTest-OSNetUriSpaceTest
> 
> This fix only handle #1, which did not handle leading white space :)

You're right :facepalm:. Should be fixed now.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
-----------


On July 31, 2015, 8:23 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 8:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/
---

(Updated July 31, 2015, 8:23 a.m.)


Review request for mesos, Bernd Mathiske and Klaus Ma.


Changes
---

Actually add whitespace to URL.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Factored out the pattern for URL generation in (another)fetcher test.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 

Diff: https://reviews.apache.org/r/36946/diff/


Testing
---

GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check


Thanks,

Artem Harutyunyan

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/#review93832
---

Ship it!


Ship It!

- Artem Harutyunyan


On July 31, 2015, 7:10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37011/
> ---
> 
> (Updated July 31, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/fatal.hpp 87a55dca4fe53c1f3fc7fb03914f3ec4270aa5b4 
>   3rdparty/libprocess/src/fatal.cpp 76d5ee42be50651863f88189341d59cfd406bae4 
> 
> Diff: https://reviews.apache.org/r/37011/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

> On Aug. 1, 2015, 3:30 p.m., Benjamin Hindman wrote:
> > src/tests/containerizer/cgroups_tests.cpp, lines 1143-1146
> > <https://reviews.apache.org/r/36627/diff/5/?file=1024882#file1024882line1143>
> >
> > But doesn't this mean we might stay in an infinite loop forever? I'm 
> > assuming that somehow you figured out that things are just delayed but it 
> > eventually converges correctly, is that the case? Can you leave a comment 
> > on why not incrementing 'i' won't just make this an infinite loop?

The reasoning here is that counters will eventually become stable (that should 
happen on the second read) at which point the normal course of action 
(including incrementing the loop counter) should resume. 

There is a comment about that a couple of lines above (lines 1120-1123):
```
// We need to know the readings are the same as last time to be
// sure they are stable, because the reading is not atomic. For
// example, the medium could turn positive after we read low to be
// 0, but this should be fixed by the next read immediately.
```
I will ammend this comment too.


> On Aug. 1, 2015, 3:30 p.m., Benjamin Hindman wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 93
> > <https://reviews.apache.org/r/36627/diff/5/?file=1024883#file1024883line93>
> >
> > Any specific reason to memset it to 0 instead of 1?

We thought that compiler might treat '0' as a special value that could affect 
optimization behaviour. It does not really seem to matter, I'll revert the 
change.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review93849
---


On July 29, 2015, 4:14 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36627/
> ---
> 
> (Updated July 29, 2015, 4:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2660
> https://issues.apache.org/jira/browse/MESOS-2660
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> caecd5dfa3fef33dba35cfc1b5934a11e2cc961a 
>   src/tests/containerizer/memory_test_helper.cpp 
> 48a35632786963f484f66642b5c67afd4f7a89cc 
> 
> Diff: https://reviews.apache.org/r/36627/diff/
> 
> 
> Testing
> ---
> 
> It seems there is still one more cgroups memory test failing on more test 
> failing on my box. I'd like to fix that too and commit it together with this 
> one. 
> 
> sudo make check
> 
> Verified that the process actually gets killed by oom-killer:
> 
> ```
> # tail -f /var/log/syslog
> 
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052405] 
> lt-memory-test- invoked oom-killer: gfp_mask=0xd0, order=0, oom_score_adj=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052408] 
> lt-memory-test- cpuset=/ mems_allowed=0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052411] CPU: 7 
> PID: 76599 Comm: lt-memory-test- Tainted: G   OE 3.16.0-41-generic 
> #57~14.04.1-Ubuntu
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413] Hardware 
> name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, 
> BIOS 6.00 05/20/2014
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052413]  
> 88022efc1000 8801fd2efc30 81765721 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052415]  
> 8801fd2efcb8 8175f2d5 8802366f30c0 8801e9405b00
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052416]  
> 8801fd2efc80 81165067 880231f10ee8 880231f10a30
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052418] Call Trace:
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052424]  
> [] dump_stack+0x45/0x56
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052426]  
> [] dump_header+0x7f/0x1f1
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052430]  
> [] ? find_lock_task_mm+0x47/0xa0
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052432]  
> [] oom_kill_process+0x205/0x360
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052434]  
> [] ? security_capable_noaudit+0x15/0x20
> Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052437]  
> 

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

[Artem Harutyunyan]

988kB, 
file-rss:59076kB


```


Thanks,

Artem Harutyunyan

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated Aug. 3, 2015, 10:44 a.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated Aug. 3, 2015, 11:30 a.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Changes
---

Missing commas.


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs (updated)
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---

Review request for mesos, Benjamin Hindman and switched to 'mcypark'.


Bugs: MESOS-3197
https://issues.apache.org/jira/browse/MESOS-3197


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/containerizer/memory_test_helper.cpp 
5e40b747f4266e7532baf8fd02ea5db0955124d2 

Diff: https://reviews.apache.org/r/37065/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

> On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 81
> > <https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81>
> >
> > What's the significance in the order in which these are called? I 
> > would've expected something like:
> > 
> > ```
> >   // Make sure that all pages that are going to be mapped into the
> >   // address space of this process become unevictable. This is needed
> >   // for testing cgroup oom killer.
> > #ifdef __APPLE__
> >   if (mlock(rss, size.bytes()) != 0)
> > #else
> >   if (mlockall(MCL_FUTURE) != 0)
> > #endif
> >   {
> > return ErrnoError("Failed to make pages to be mapped unevictable");
> >   }
> > ```

The mlockall(MCL_FUTURE) has to be called before the memory allocation is made 
(because it affects future allocations), whereas mlock() is called for already 
allocated pages. I could probably change mlockall(MCL_FUTURE) to 
mlockall(MCL_CURRENT) in your snippet and make it work that way. I'll test to 
verify and will update the patch accordingly. Thanks!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---


On Aug. 3, 2015, 11:32 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> ---
> 
> (Updated Aug. 3, 2015, 11:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
> https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/#review94162
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (line 40)
<https://reviews.apache.org/r/36978/#comment148715>

Was not it discussed at some point that it would be good to have a funtion 
that returns a {status, stderr, stdout} tuple?



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (line 50)
<https://reviews.apache.org/r/36978/#comment148697>

should the variable be called `_cmd`?



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (line 57)
<https://reviews.apache.org/r/36978/#comment148703>

Why not do `std::string cmd = _cmd + " " + strings::join(" ", args)?` and 
get rid of cmdLine?



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (lines 86 - 
88)
<https://reviews.apache.org/r/36978/#comment148705>

alignment seems to be off here.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp (line 87)
<https://reviews.apache.org/r/36978/#comment148708>

Is there are reason for specifically calling out error 127? I would suggest 
a generic error message + stringify(WEXITSTATUS(status)).



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 881)
<https://reviews.apache.org/r/36978/#comment148714>

Maybe it makes sense to factor out os::shell tests into a separate function.



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 882)
<https://reviews.apache.org/r/36978/#comment148713>

Could you please add a test that makes sure that redirecting stderr to 
stdout with 2>&1 works?



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 885)
<https://reviews.apache.org/r/36978/#comment148711>

From what I've seen the variables with _ are used when some transformation 
needs to be applied on the original value:
    
    ```
_var = transform1(__var);
var = transform2(_var);
```


- Artem Harutyunyan


On Aug. 4, 2015, 5:54 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36978/
> ---
> 
> (Updated Aug. 4, 2015, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-3142
> https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactoring os::shell.
> See MESOS-3142 for more details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> ab767ccc4553cc5f61e4fe1b67110a9b5b32f2bc 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 
> 53f14e1869ed7a6e1ac7cc8a82c558ed77907dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 2556bd428cc8990659e30e804b9c96c1659ef4a1 
> 
> Diff: https://reviews.apache.org/r/36978/diff/
> 
> 
> Testing
> ---
> 
> make check
> *Note*: this patch by itself breaks mesos - this only fixes the `stout` part: 
> see also https://reviews.apache.org/r/36979/
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36979: Updating all references to os::shell

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94177
---



src/slave/containerizer/isolators/network/port_mapping.cpp (line 1579)
<https://reviews.apache.org/r/36979/#comment148718>

nit: this seems to fit on a single line.



src/tests/containerizer/isolator_tests.cpp (line 1269)
<https://reviews.apache.org/r/36979/#comment148719>

You are right that the awk did not actually seem to accomplish anything 
meaningful here.



src/tests/containerizer/port_mapping_tests.cpp (lines 971 - 974)
<https://reviews.apache.org/r/36979/#comment148720>

Another illustration of why a tuple return type might be a better option 
for os::shell() :-)

But regardless, I'd change this code to something more suggestive (it's a 
test case after all), or at least would add a comment that clarifies the 
intention.



src/tests/containerizer/port_mapping_tests.cpp (line 986)
<https://reviews.apache.org/r/36979/#comment148721>

    ditto. 
+ extra newline.


- Artem Harutyunyan


On Aug. 4, 2015, 5:55 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36979/
> ---
> 
> (Updated Aug. 4, 2015, 5:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-3142
> https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updating all references to os::shell
> For more details see MESOS-3142.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a 
>   src/tests/containerizer/isolator_tests.cpp 
> ff6e2b7e190a58a4809d6e71addb15dabe418e17 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 4bee74acba2b1472c80cabbc9d0384bd04c543aa 
> 
> Diff: https://reviews.apache.org/r/36979/diff/
> 
> 
> Testing
> ---
> 
> make check
> *Note*: this patch fixes breakages introduce by the refactoring in: 
> https://reviews.apache.org/r/36978
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---

(Updated Aug. 5, 2015, 8:26 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Changes
---

Added missing JIRA ticket.


Bugs: MESOS-2964
https://issues.apache.org/jira/browse/MESOS-2964


Repository: mesos


Description
---

JIRA: https://issues.apache.org/jira/browse/MESOS-2964


Diffs
-

  3rdparty/libprocess/include/process/io.hpp 
975923f40f82357f31b89428f24d01df6a8ac9fc 
  3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
  3rdparty/libprocess/src/tests/io_tests.cpp 
c642bab9e2845668767ad237985cb9ce1109 

Diff: https://reviews.apache.org/r/36404/diff/


Testing
---

- Added a test case for process::io::peek
- make check


Thanks,

Artem Harutyunyan

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

> On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 81
> > <https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81>
> >
> > What's the significance in the order in which these are called? I 
> > would've expected something like:
> > 
> > ```
> >   // Make sure that all pages that are going to be mapped into the
> >   // address space of this process become unevictable. This is needed
> >   // for testing cgroup oom killer.
> > #ifdef __APPLE__
> >   if (mlock(rss, size.bytes()) != 0)
> > #else
> >   if (mlockall(MCL_FUTURE) != 0)
> > #endif
> >   {
> >     return ErrnoError("Failed to make pages to be mapped unevictable");
> >   }
> > ```
> 
> Artem Harutyunyan wrote:
> The mlockall(MCL_FUTURE) has to be called before the memory allocation is 
> made (because it affects future allocations), whereas mlock() is called for 
> already allocated pages. I could probably change mlockall(MCL_FUTURE) to 
> mlockall(MCL_CURRENT) in your snippet and make it work that way. I'll test to 
> verify and will update the patch accordingly. Thanks!
> 
> James Peach wrote:
> IMHO it would be better to add an autoconf check for ```mlockall``` 
> availability that to check ```__APPLE__```.
> 
> Michael Park wrote:
> @jpeach: Do you mean we should fail to configure if `mlockall` is not 
> available? If we did that, we wouldn't be able to compile on OS X though.
> 
> James Peach wrote:
> In autoconf, do ```AC_CHECK_FUNC(mlockall)```, then make this code 
> conditional on ```#if HAVE_MLOCKALL```.
> 
> Michael Park wrote:
> Ah I see, great! I agree that's better since there may be other platforms 
> aside from OS X that don't support `mlockall`. @hartem: what do you think?

I refactored following MPark's suggestion, however using 
AC_CHECK_FUNC(mlockall) did not work, because the function is present on OSX, 
it just prints the error message instead of actually locking memory pages.


- Artem


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---


On Aug. 5, 2015, 10:14 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> ---
> 
> (Updated Aug. 5, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
> https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---

(Updated Aug. 5, 2015, 10:14 p.m.)


Review request for mesos, Benjamin Hindman and Michael Park.


Changes
---

Addressed comments.


Bugs: MESOS-3197
https://issues.apache.org/jira/browse/MESOS-3197


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/memory_test_helper.cpp 
5e40b747f4266e7532baf8fd02ea5db0955124d2 

Diff: https://reviews.apache.org/r/37065/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---

(Updated Aug. 5, 2015, 10:54 p.m.)


Review request for mesos, Benjamin Hindman and Michael Park.


Changes
---

Reverting refactor (see comments).


Bugs: MESOS-3197
https://issues.apache.org/jira/browse/MESOS-3197


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/memory_test_helper.cpp 
5e40b747f4266e7532baf8fd02ea5db0955124d2 

Diff: https://reviews.apache.org/r/37065/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

> On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 81
> > <https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81>
> >
> > What's the significance in the order in which these are called? I 
> > would've expected something like:
> > 
> > ```
> >   // Make sure that all pages that are going to be mapped into the
> >   // address space of this process become unevictable. This is needed
> >   // for testing cgroup oom killer.
> > #ifdef __APPLE__
> >   if (mlock(rss, size.bytes()) != 0)
> > #else
> >   if (mlockall(MCL_FUTURE) != 0)
> > #endif
> >   {
> >     return ErrnoError("Failed to make pages to be mapped unevictable");
> >   }
> > ```
> 
> Artem Harutyunyan wrote:
> The mlockall(MCL_FUTURE) has to be called before the memory allocation is 
> made (because it affects future allocations), whereas mlock() is called for 
> already allocated pages. I could probably change mlockall(MCL_FUTURE) to 
> mlockall(MCL_CURRENT) in your snippet and make it work that way. I'll test to 
> verify and will update the patch accordingly. Thanks!
> 
> James Peach wrote:
> IMHO it would be better to add an autoconf check for ```mlockall``` 
> availability that to check ```__APPLE__```.
> 
> Michael Park wrote:
> @jpeach: Do you mean we should fail to configure if `mlockall` is not 
> available? If we did that, we wouldn't be able to compile on OS X though.
> 
> James Peach wrote:
> In autoconf, do ```AC_CHECK_FUNC(mlockall)```, then make this code 
> conditional on ```#if HAVE_MLOCKALL```.
> 
> Michael Park wrote:
> Ah I see, great! I agree that's better since there may be other platforms 
> aside from OS X that don't support `mlockall`. @hartem: what do you think?
> 
> Artem Harutyunyan wrote:
> I refactored following MPark's suggestion, however using 
> AC_CHECK_FUNC(mlockall) did not work, because the function is present on OSX, 
> it just prints the error message instead of actually locking memory pages.

Actually, I was too hopeful too quickly :-). I had to revert the 
mlockall(MCL_CURRENT) change becasue it broke the OOM killer test on Ubuntu.


- Artem


-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---


On Aug. 5, 2015, 10:14 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> ---
> 
> (Updated Aug. 5, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
> https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36979: Updating all references to os::shell

[Artem Harutyunyan]

> On Aug. 4, 2015, 9:16 p.m., Artem Harutyunyan wrote:
> > src/tests/containerizer/port_mapping_tests.cpp, line 986
> > <https://reviews.apache.org/r/36979/diff/1/?file=1026038#file1026038line986>
> >
> > ditto. 
> > + extra newline.
> 
> Marco Massenzio wrote:
> Having looked at both tests, I was being unnecessarily pedantic IMO: 
> checking for the error code (256) to be present in the error string seems to 
> me to be more than sufficient (and self-explanatory too - but added a comment 
> all the same).
> 
> What thinks you?

After think a bit more about it, I find it a bit unusual that the user has to 
perform a string search in order to get out the integer error code. In cases 
when you expect a certain kind of failure from a certain command it's easy 
(like in your test case), but what if the cause of failure is unknown, or if 
there are several possible error codes expected. It looks to me that one will 
need to involve a regex parser to be able to reliably(?) get the signal and the 
error code out. This might drive delopers away from this function, and cause 
proliferation of similar code in the codebase (something that this was meant to 
facilitate avoiding). Returning a primtive struct(or a union) with a couple of 
fields could easily help to avoid that.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94177
---


On Aug. 5, 2015, 10:10 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36979/
> ---
> 
> (Updated Aug. 5, 2015, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-3142
> https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updating all references to os::shell
> For more details see MESOS-3142.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 8244c345b84108af7fa18d20e71401d6e1a0aeb0 
>   src/tests/containerizer/isolator_tests.cpp 
> ff6e2b7e190a58a4809d6e71addb15dabe418e17 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 4bee74acba2b1472c80cabbc9d0384bd04c543aa 
> 
> Diff: https://reviews.apache.org/r/36979/diff/
> 
> 
> Testing
> ---
> 
> make check
> *Note*: this patch fixes breakages introduce by the refactoring in: 
> https://reviews.apache.org/r/36978
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

> On Aug. 6, 2015, 4:47 a.m., Alexander Rojas wrote:
> > src/tests/containerizer/memory_test_helper.cpp, lines 79-87
> > <https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line79>
> >
> > After reading the man pages, `mlock()` exists in Linux too and frankly 
> > it looks safer to use than `mlockall()`. 
> > 
> > `mlock()` will only lock the memory passed to the call in the physical 
> > memory while `mlockall()` will lock every new allocation after we made this 
> > call (and that includes stack, heap and code sections) until we make a 
> > `munlockall()` call, which we don't.

It does exist on Linux, it just doesn't realiably work for our use case on 
Ubuntu. I am aware of the difference of mlock() and mlockall(), in the context 
of the OOM test it does not really mattter because these are short lived test 
processes that are either getting killed or are going away.


> On Aug. 6, 2015, 4:47 a.m., Alexander Rojas wrote:
> > src/tests/containerizer/memory_test_helper.cpp, lines 75-76
> > <https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line75>
> >
> > Not a big fan of explain how something will be used in the method 
> > description. What if we remove references to `mlockall()` and `mlock()` 
> > here. Something a long the lines of:
> > 
> > > This helper allocates memory and locks it to the physical memory so 
> > it won't get swapped by the OS.

I've removed references to `mlockall()` and `mlock()`.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94394
---


On Aug. 6, 2015, 10:34 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> ---
> 
> (Updated Aug. 6, 2015, 10:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
> https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---

(Updated Aug. 6, 2015, 10:34 a.m.)


Review request for mesos, Benjamin Hindman and Michael Park.


Changes
---

Addressed comments.


Bugs: MESOS-3197
https://issues.apache.org/jira/browse/MESOS-3197


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/containerizer/memory_test_helper.cpp 
5e40b747f4266e7532baf8fd02ea5db0955124d2 

Diff: https://reviews.apache.org/r/37065/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

[Artem Harutyunyan]

> On Aug. 6, 2015, 1:21 a.m., Michael Park wrote:
> > src/tests/containerizer/memory_test_helper.cpp, lines 81-83
> > <https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line81>
> >
> > `mlockall` is not what we want ideally right?
> > 
> > Can we mention that it's not ideal but that it exists temporarily to 
> > address `MESOS-3197`?

I am not sure. For the purpose of this test (which is to artifficiialy drive 
memory utilization) mlockall() seems to be a safer choice.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94376
-----------


On Aug. 6, 2015, 10:34 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> ---
> 
> (Updated Aug. 6, 2015, 10:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
> https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_test_helper.cpp 
> 5e40b747f4266e7532baf8fd02ea5db0955124d2 
> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---

(Updated Aug. 6, 2015, 11:27 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.


Changes
---

Addressed some of the comments.


Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 30a2550c606ca528ec5b69fc9efedd698d67c5f2 
  src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 

Diff: https://reviews.apache.org/r/37190/diff/


Testing
---

Manual testing of the endpoint.


Thanks,

Artem Harutyunyan

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

[Artem Harutyunyan]

> On Aug. 4, 2015, 7:54 p.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp, line 50
> > <https://reviews.apache.org/r/36978/diff/1/?file=1026032#file1026032line50>
> >
> > should the variable be called `_cmd`?
> 
> Marco Massenzio wrote:
> note this is neither a private member, not a constructor arg - it's a 
> temp var: AFAIK there are no guidelines (apart from the obvious naming it 
> sensibly).
> Renamed `command`

It does not really matter since you renamed, but there is a guideline for 
function arguments:

```
We prepend constructor and function arguments with a leading underscore to 
avoid ambiguity and / or shadowing:
```


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/#review94162
---


On Aug. 6, 2015, 11:20 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36978/
> ---
> 
> (Updated Aug. 6, 2015, 11:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-3142
> https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactoring os::shell.
> See MESOS-3142 for more details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> ab767ccc4553cc5f61e4fe1b67110a9b5b32f2bc 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 
> 53f14e1869ed7a6e1ac7cc8a82c558ed77907dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
> 4b7a7bafe1c64183d021b39cf12523250491f0ee 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 2556bd428cc8990659e30e804b9c96c1659ef4a1 
> 
> Diff: https://reviews.apache.org/r/36978/diff/
> 
> 
> Testing
> ---
> 
> make check
> *Note*: this patch by itself breaks mesos - this only fixes the `stout` part: 
> see also https://reviews.apache.org/r/36979/
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---

(Updated Aug. 6, 2015, 6:34 p.m.)


Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.


Changes
---

Uploading WIP.


Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
  src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 

Diff: https://reviews.apache.org/r/37190/diff/


Testing
---

Manual testing of the endpoint.


Thanks,

Artem Harutyunyan

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---

(Updated Aug. 7, 2015, 10:05 a.m.)


Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.


Changes
---

Added maintenance state endpoint. Addressed remaining comment.


Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
  src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 

Diff: https://reviews.apache.org/r/37190/diff/


Testing
---

Manual testing of the endpoint.


Thanks,

Artem Harutyunyan

Re: Review Request 37190: WIP: Added /maintenance.schedule, /maintenance.start, /maintenance.stop and /maintenance.status endpoints.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---

(Updated Aug. 7, 2015, 1:40 p.m.)


Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.


Changes
---

Addressed comments; added more endpoints.


Summary (updated)
-

WIP: Added /maintenance.schedule, /maintenance.start, /maintenance.stop and 
/maintenance.status endpoints.


Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.proto PRE-CREATION 
  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
  src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 

Diff: https://reviews.apache.org/r/37190/diff/


Testing
---

Manual testing of the endpoint.


Thanks,

Artem Harutyunyan

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/
---

(Updated Aug. 8, 2015, 2:54 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched 
to 'mcypark'.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/README.md 
39a6a3f26f59915f7a338796558eb19c93788ced 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
451a53d152011db0ca89a8b2e9bf47ba277cf132 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
967201888114e01f1a2d3c9cfaae847f1ce42d13 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
35fb034f303ffda8e786a8cb564b92d02cddbfe9 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
ae54566b9d0160def6146aa0ce634bdbf0967142 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
30baa65837621a277cf9d1042a751bfe18004b05 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
549fc46cedb643ef1ebdf8441c332a02ac45016d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
24c26e90d2386bf5319f07c69c20efacb95f12eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
5d7404bed73774644451f74a15c63da32441f529 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
420d5bbb4c275eed3e663d40501b127d8fc7749f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
0e94e22817e21fc7944a995092e54bf302ab0e2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
bbb796d647e9dd591802722f498cdc2fd39bca3e 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
5af9be8fe419fe7f798a31dfa399516cd3514f67 
  3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
0004fa5cd249269504155e51e52cd802c0916851 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
a7de91f73b08494157873dd8a0df8538c22d2e24 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
f0b0a488059e6cbc041697280356d45f3ff95f17 
  3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
ea8a13f25d72bb645842d32a91b168b67d33c3eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
5ad611497a47be64c539e832b9a1c23e6cf9586d 
  3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
22d30eb80b4eca8be9cd4d48288f63fd52040ddd 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
984c02c982dc4dd8eb528d79e715847ef7a693b8 
  3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
d03678552ae222cb8748ac7e57c600f8688761c4 

Diff: https://reviews.apache.org/r/37018/diff/


Testing
---

`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check


Thanks,

Artem Harutyunyan

Re: Review Request 37013: [1/3] Removed whitespace padding in overloaded operators (mesos).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37013/
---

(Updated Aug. 8, 2015, 2:54 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched 
to 'mcypark'.


Repository: mesos


Description
---

See summary.


Diffs
-

  docs/clang-format.md 3824ec0b11cc2d3e4a2a8409171107839d706a28 
  docs/mesos-c++-style-guide.md d8ad0acbb5f1484699f06e6748328a1ec0e7957f 
  include/mesos/resources.hpp d4d5cafd937cccf6c4eff905e3024d53b4594bf7 
  include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 
  include/mesos/values.hpp c61f9e87f1e240c71571793d24751fbe53ed45d2 
  src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
  src/common/attributes.cpp a8a621e52f0399dbd480437279bdbadf0916f745 
  src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 
  src/common/type_utils.cpp 36a2469274abb356376279cf7c2f88cf29c2796e 
  src/common/values.cpp 2431d9e276072c40061f8626d56a0727b16a088f 
  src/jvm/jvm.hpp 90febda728e7068f7ace678c55a7061741c748bb 
  src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf 
  src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
  src/linux/routing/filter/basic.hpp fea8976b8d4e53be23b2ba838a2091b7187b8e55 
  src/linux/routing/filter/icmp.hpp b732193aafcbb72a79036cd69418dbfb21428fff 
  src/linux/routing/filter/ip.hpp ec6f643639879639d56b81e97b4ea7b4b487e1e5 
  src/linux/routing/handle.hpp 052c7cc1a967797d245a275d08cc774f627398a5 
  src/log/log.hpp 7c905c7e431b6663af8cdbce94d98c905da878ae 
  src/log/network.hpp ff3496b2f648944087eaed8b314d64f3671c3f50 
  src/master/allocator/sorter/drf/sorter.hpp 
6aec14f2dbe4476f9c2a857f2d54f30c12c3133d 
  src/master/allocator/sorter/drf/sorter.cpp 
85eef6bbb4c8b3436f0cd345cd9f1c4e8289e110 
  src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
  src/master/registrar.hpp c1463c52b835e3dd653e64dcceacdb31b00fca54 
  src/messages/flags.hpp 17f8bf3aaa2f10d20abac14c4ace845cde251760 
  src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d 
  src/messages/messages.hpp f7afcf757696cd210b26ce8dd3a173f036c23da1 
  src/slave/gc.hpp 780f9c988b72ad3b22db191a62bff62621b15733 
  src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
  src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 
  src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
  src/zookeeper/authentication.hpp 1c503077cd577cd0440e62d7b9c7ddf128bbceab 
  src/zookeeper/group.hpp 9e0ed327aec6f26982984d8fd379dbd6140589b3 
  src/zookeeper/url.hpp b4253e86c0e597a737e83a9660d29ea9748bf285 
  src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 

Diff: https://reviews.apache.org/r/37013/diff/


Testing
---

`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check


Thanks,

Artem Harutyunyan

Re: Review Request 37017: [2/3] Removed whitespace padding in overloaded operators (libprocess).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37017/
---

(Updated Aug. 8, 2015, 2:54 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched 
to 'mcypark'.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/address.hpp 
be216db823160f5db1dfb4502bf832246fb3df6d 
  3rdparty/libprocess/include/process/async.hpp 
d0c560aa48ef1c88407a6b1c42223fce3170245c 
  3rdparty/libprocess/include/process/deferred.hpp 
b11acc4bed390fd33d782143afb6231fc7606bea 
  3rdparty/libprocess/include/process/event.hpp 
522771a62bcdea458e33e4b15d590bd8c1dc5e22 
  3rdparty/libprocess/include/process/executor.hpp 
23384c2ca206fdbb1fcc4c06a6ca99b0ee0b3498 
  3rdparty/libprocess/include/process/future.hpp 
db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/gmock.hpp 
d4499526af3652a6c6600e871b843af49388b4ee 
  3rdparty/libprocess/include/process/http.hpp 
f24ca24f4b2926d6d9651b90bdf4dd8156f71c9f 
  3rdparty/libprocess/include/process/latch.hpp 
460971e67a64c5b62bac5370a6a616c7f13bac51 
  3rdparty/libprocess/include/process/limiter.hpp 
ce692883c74bc9a5cb4822567e5d7edee81ae0a3 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
6ea32200d1b26a192731d9c14bcda48cf7855917 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
5a328d3786e047459d9b245c8dd38a00d3b41b3b 
  3rdparty/libprocess/include/process/once.hpp 
4b0cbe073dd0cd89b9ae788e66ccdf707afd0fc6 
  3rdparty/libprocess/include/process/owned.hpp 
428e922327fd05e2e2f943bbb498cd58543cdc70 
  3rdparty/libprocess/include/process/pid.hpp 
3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 
  3rdparty/libprocess/include/process/protobuf.hpp 
3ec3775165d1cef1d081e465d809d46e09d49b5c 
  3rdparty/libprocess/include/process/sequence.hpp 
2dec013012c01813d43f80899f1292eecc7e414d 
  3rdparty/libprocess/include/process/shared.hpp 
b4d90ca0309be1116ae8421716894652b5bd0890 
  3rdparty/libprocess/include/process/socket.hpp 
a882330b45be10bab1e3e8fd8983e172eb0e4efc 
  3rdparty/libprocess/include/process/time.hpp 
095409ac151c8ae3320c47cb50247718044dde83 
  3rdparty/libprocess/include/process/timeout.hpp 
868da4935ca3c9959749b5c51b446179834086e4 
  3rdparty/libprocess/include/process/timer.hpp 
02ebd32569cf0c25a1434107cd0cca76cf8a2659 
  3rdparty/libprocess/src/http.cpp b44c1f457279a67fc5d60fab639b8baec71bef41 
  3rdparty/libprocess/src/pid.cpp a5c527443cebb0c150f59fb4abe80216794a209b 
  3rdparty/libprocess/src/process_reference.hpp 
c070158defe234bfcdff06a829c7a001dc66ba1f 
  3rdparty/libprocess/src/test-master.cpp 
2a2ed0e9ac58d7973b1254c708cbd97a7a33b762 
  3rdparty/libprocess/src/test-slave.cpp 
5a924a0bca21397f059cf558d67853cc4103e5da 
  3rdparty/libprocess/src/tests/process_tests.cpp 
95e3257b030128e9d03dde9aa048602c68c6a446 
  3rdparty/libprocess/src/time.cpp 87f1f367f422df0efe3bd57f983404e572dc5314 

Diff: https://reviews.apache.org/r/37017/diff/


Testing
---

`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check


Thanks,

Artem Harutyunyan

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Artem Harutyunyan]

> On Aug. 8, 2015, 3:07 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37013, 37017, 37018]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37018
> > 
> > Error:
> >  2015-08-08 22:07:03 URL:https://reviews.apache.org/r/37018/diff/raw/ 
> > [49035/49035] -> "37018.patch" [1]
> > error: patch failed: 
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp:76
> > error: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp: patch 
> > does not apply
> > Failed to apply patch
> 
> Michael Park wrote:
> Looks like this needs to be rebased since @bmahler took care of the style 
> issues in `stout/version.hpp` for us already in 
> https://github.com/apache/mesos/commit/e870bb3ed5cc6aa6dca088f7e4c58d6220e02595.

Done.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/#review94653
---


On Aug. 9, 2015, 3:16 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37018/
> ---
> 
> (Updated Aug. 9, 2015, 3:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> 39a6a3f26f59915f7a338796558eb19c93788ced 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 451a53d152011db0ca89a8b2e9bf47ba277cf132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 967201888114e01f1a2d3c9cfaae847f1ce42d13 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> 35fb034f303ffda8e786a8cb564b92d02cddbfe9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ae54566b9d0160def6146aa0ce634bdbf0967142 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> 89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 24c26e90d2386bf5319f07c69c20efacb95f12eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 5d7404bed73774644451f74a15c63da32441f529 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> 420d5bbb4c275eed3e663d40501b127d8fc7749f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 0e94e22817e21fc7944a995092e54bf302ab0e2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> bbb796d647e9dd591802722f498cdc2fd39bca3e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
> 70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 5af9be8fe419fe7f798a31dfa399516cd3514f67 
>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
> 0004fa5cd249269504155e51e52cd802c0916851 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> a7de91f73b08494157873dd8a0df8538c22d2e24 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> f0b0a488059e6cbc041697280356d45f3ff95f17 
>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
> ea8a13f25d72bb645842d32a91b168b67d33c3eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 450b3a7e67cf5f49888691d03997b8409004519e 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 984c02c982dc4dd8eb528d79e715847ef7a693b8 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
> d03678552ae222cb8748ac7e57c600f8688761c4 
> 
> Diff: https://reviews.apache.org/r/37018/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/
---

(Updated Aug. 9, 2015, 3:16 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
Park.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
39a6a3f26f59915f7a338796558eb19c93788ced 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
451a53d152011db0ca89a8b2e9bf47ba277cf132 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
967201888114e01f1a2d3c9cfaae847f1ce42d13 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
35fb034f303ffda8e786a8cb564b92d02cddbfe9 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
ae54566b9d0160def6146aa0ce634bdbf0967142 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
30baa65837621a277cf9d1042a751bfe18004b05 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
549fc46cedb643ef1ebdf8441c332a02ac45016d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
24c26e90d2386bf5319f07c69c20efacb95f12eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
5d7404bed73774644451f74a15c63da32441f529 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
420d5bbb4c275eed3e663d40501b127d8fc7749f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
0e94e22817e21fc7944a995092e54bf302ab0e2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
bbb796d647e9dd591802722f498cdc2fd39bca3e 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
5af9be8fe419fe7f798a31dfa399516cd3514f67 
  3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
0004fa5cd249269504155e51e52cd802c0916851 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
a7de91f73b08494157873dd8a0df8538c22d2e24 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
f0b0a488059e6cbc041697280356d45f3ff95f17 
  3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
ea8a13f25d72bb645842d32a91b168b67d33c3eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
5ad611497a47be64c539e832b9a1c23e6cf9586d 
  3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
450b3a7e67cf5f49888691d03997b8409004519e 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
984c02c982dc4dd8eb528d79e715847ef7a693b8 
  3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
d03678552ae222cb8748ac7e57c600f8688761c4 

Diff: https://reviews.apache.org/r/37018/diff/


Testing
---

`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check


Thanks,

Artem Harutyunyan

Review Request 37340: Added CERN to Mesos users list.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37340/
---

Review request for mesos, Benjamin Hindman and Michael Park.


Repository: mesos


Description
---

Here is the paper that describes how Mesos is used 
http://arxiv.org/pdf/1507.07429.pdf .


Diffs
-

  docs/powered-by-mesos.md 574d1c036f26a856671564673dd04532413dacc3 

Diff: https://reviews.apache.org/r/37340/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 36404: Added support for peek() to process::io

[Artem Harutyunyan]

> On July 26, 2015, 6:18 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/io_tests.cpp, line 377
> > <https://reviews.apache.org/r/36404/diff/4/?file=1018378#file1018378line377>
> >
> > we can get rid of some of these literals by:
> > s/3/sizeof(data)/
> > What do you think?

I followed what was done in the read test here.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/#review93040
---


On Aug. 5, 2015, 8:26 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36404/
> ---
> 
> (Updated Aug. 5, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-2964
> https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/io.hpp 
> 975923f40f82357f31b89428f24d01df6a8ac9fc 
>   3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> c642bab9e2845668767ad237985cb9ce1109 
> 
> Diff: https://reviews.apache.org/r/36404/diff/
> 
> 
> Testing
> ---
> 
> - Added a test case for process::io::peek
> - make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>