Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[msivak]

Martin Sivák has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> Why is it not enough? We are talking about developers not users.
Because nobody rereads a docstring for a library that has already been used for 
years. So deprecation warnings need to be a bit more obvious. But only to 
developers (so warnings should be enabled in automation), users will just get 
confused.


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Document the secret TRACE log level

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: logging: Document the secret TRACE log level
..

logging: Document the secret TRACE log level

This may be useful to for developers to understand complicated flows.

Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Signed-off-by: Nir Soffer 
---
M README.logging
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/64218/1

diff --git a/README.logging b/README.logging
index ca04578..8dcf199 100644
--- a/README.logging
+++ b/README.logging
@@ -26,7 +26,7 @@
 
 # vdsClient [-s] SERVER setLogLevel LEVEL [LOGGER]
 
-`LEVEL` is one of DEBUG, INFO, WARN
+`LEVEL` is one of TRACE DEBUG, INFO, WARN
 `LOGGER` is any logger Vdsm uses. Please check the configuration file
 to learn about some predefined loggers.
 


-- 
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve log level alignment

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: logging: Improve log level alignment
..

logging: Improve log level alignment

Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
nicer.

Here is an example log:
https://paste.fedoraproject.org/431570/raw/

Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938
Signed-off-by: Nir Soffer 
---
M README.logging
M static/etc/vdsm/logger.conf.in
M tests/run_tests_local.sh.in
M vdsm/vdsm
4 files changed, 13 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/64217/1

diff --git a/README.logging b/README.logging
index ed91532..ca04578 100644
--- a/README.logging
+++ b/README.logging
@@ -26,7 +26,7 @@
 
 # vdsClient [-s] SERVER setLogLevel LEVEL [LOGGER]
 
-`LEVEL` is one of DEBUG, INFO, WARNING
+`LEVEL` is one of DEBUG, INFO, WARN
 `LOGGER` is any logger Vdsm uses. Please check the configuration file
 to learn about some predefined loggers.
 
@@ -43,16 +43,16 @@
 vdsClient -s 0 setLogLevel DEBUG
 
 2. silence virt logs, show only warnings, errors or worse:
-vdsClient -s 0 setLogLevel WARNING virt
+vdsClient -s 0 setLogLevel WARN virt
 
 3. same as #2, for storage
-vdsClient -s 0 setLogLevel WARNING storage
+vdsClient -s 0 setLogLevel WARN storage
 
 4. silence JSONRPC logs:
-vdsClient -s 0 setLogLevel WARNING jsonrpc
+vdsClient -s 0 setLogLevel WARN jsonrpc
 
 5. enable the 'devel' logs, which could be useful for developers
-vdsClient -s 0 setLogLevel devel WARNING
+vdsClient -s 0 setLogLevel devel WARN
 
 
 Notes
diff --git a/static/etc/vdsm/logger.conf.in b/static/etc/vdsm/logger.conf.in
index 02988ff..5e92b78 100644
--- a/static/etc/vdsm/logger.conf.in
+++ b/static/etc/vdsm/logger.conf.in
@@ -61,7 +61,7 @@
 propagate=0
 
 [handler_syslog]
-level=WARNING
+level=WARN
 class=handlers.SysLogHandler
 formatter=sysform
 args=('/dev/log', handlers.SysLogHandler.LOG_USER)
@@ -92,7 +92,7 @@
 format: %(message)s
 
 [formatter_long]
-format: %(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) %(message)s 
(%(module)s:%(lineno)d)
+format: %(asctime)s %(levelname)-5s [%(name)s] (%(threadName)s) %(message)s 
(%(module)s:%(lineno)d)
 
 [formatter_sysform]
 format= vdsm %(name)s %(levelname)s %(message)s
diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in
index 121eb7c..5a8d8b6 100644
--- a/tests/run_tests_local.sh.in
+++ b/tests/run_tests_local.sh.in
@@ -5,7 +5,7 @@
 
 export \
 LC_ALL=C \
-NOSE_LOGFORMAT='%(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) 
%(message)s (%(module)s:%(lineno)d)' \
+NOSE_LOGFORMAT='%(asctime)s %(levelname)-5s [%(name)s] (%(threadName)s) 
%(message)s (%(module)s:%(lineno)d)' \
 NOSE_VERBOSE=${NOSE_VERBOSE:-3} \
 PYTHONDONTWRITEBYTECODE=1 \
 
PYTHONPATH="@top_srcdir@/lib:@top_srcdir@/vdsm:@top_srcdir@/client:@top_srcdir@/vdsm_api:$PYTHONPATH"
 \
diff --git a/vdsm/vdsm b/vdsm/vdsm
index 34a400c..b87fa61 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -133,6 +133,11 @@
 raise FatalError("Cannot configure logging: %s" % e)
 
 logging.addLevelName(5, 'TRACE')
+
+# Shorten WARNING and CRITICAL to make the log align nicer.
+logging.addLevelName(logging.WARNING, 'WARN')
+logging.addLevelName(logging.CRITICAL, 'CRIT')
+
 logging.TRACE = 5  # impolite but helpful
 log = logging.getLogger('vds')
 try:


-- 
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use same log format as vdsm

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: tests: Use same log format as vdsm
..

tests: Use same log format as vdsm

Using the same format as in vdsm logs may make it easier to debug
failing tests. In particular, the old format was missing the module and
line number.

Change-Id: Ia8a6c07442d3fb2dd86d08f5c71c3b640bbda43d
Signed-off-by: Nir Soffer 
---
M tests/run_tests_local.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/64216/1

diff --git a/tests/run_tests_local.sh.in b/tests/run_tests_local.sh.in
index a2c38c5..121eb7c 100644
--- a/tests/run_tests_local.sh.in
+++ b/tests/run_tests_local.sh.in
@@ -5,7 +5,7 @@
 
 export \
 LC_ALL=C \
-NOSE_LOGFORMAT='%(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) 
%(message)s' \
+NOSE_LOGFORMAT='%(asctime)s %(levelname)-7s [%(name)s] (%(threadName)s) 
%(message)s (%(module)s:%(lineno)d)' \
 NOSE_VERBOSE=${NOSE_VERBOSE:-3} \
 PYTHONDONTWRITEBYTECODE=1 \
 
PYTHONPATH="@top_srcdir@/lib:@top_srcdir@/vdsm:@top_srcdir@/client:@top_srcdir@/vdsm_api:$PYTHONPATH"
 \


-- 
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8a6c07442d3fb2dd86d08f5c71c3b640bbda43d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdm: Introduce new SDM.merge verb

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 9915: type: *UUID
Line 9916: 
Line 9917: -   description: The base volume
Line 9918: name: base
Line 9919: type: *CopyDataDivEndpoint
> Great for code reuse but this means we're supplying the sd and image twice 
I don't care about engine sending same value twice.

The fact that I can take the same object using the same locks and prepare 
infrastructure is so much more important.

I think we need the same locks here:

- the top volumes are read only. We must use -d so qemu does not touch the top 
volumes, since we may want to wipe them, and we need the data to get the size 
of the wipe.
- the base volume is writable

This is exactly the same as copy data.

If we find later that we want different locks, we will subclass this to 
override the locks.

We will verify that both endpoints belong to the same chain (same domain and 
image).
Line 9920: 
Line 9921: -   description: The top volume
Line 9922: name: top


-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve log level alignment

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: Improve log level alignment
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: Document the secret TRACE log level

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: Document the secret TRACE log level
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eaec7b6f1d65c2801bc3dcc0dd3d2a02ee61e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3:

* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Product::#133::OK, Correct classification oVirt
* Check TM::#133::ERROR, wrong target milestone for stable branch, --- 
should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdm: Introduce new SDM.merge verb

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
..


Patch Set 2: Code-Review+1

Waiting for more reviews.

-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3: -Verified

* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Product::#133::OK, Correct classification oVirt
* Check TM::#133::ERROR, wrong target milestone for stable branch, --- 
should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 3:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Migration plugins to enable skipping of special OVS pr...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Migration plugins to enable skipping of special OVS 
processing for nics
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename qemuimgTests.py to new Vdsm convention

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64203/2/tests/Makefile.am
File tests/Makefile.am:

Line 97:persistentDictTests.py \
Line 98:properties_test.py \
Line 99:protocoldetectorTests.py \
Line 100:   pthreadTests.py \
Line 101:   qemuimg_test.py.py \
py.py is little repetitive, and makes make check grumpy.
Line 102:   resourceManagerTests.py \
Line 103:   responseTests.py \
Line 104:   rngsources_test.py \
Line 105:   samplingTests.py \


-- 
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Migration plugins to enable skipping of special OVS pr...

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: virt: Migration plugins to enable skipping of special OVS 
processing for nics
..


Patch Set 2:

(8 comments)

This was just a quick and dirty draft to show the concept :(
This version should be better.

https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 27: from vdsm import jsonrpcvdscli
Line 28: from vdsm.config import config
Line 29: from vdsm.network import api as net_api
Line 30: 
Line 31: import vm_migrate_plugins
> I like this simplistic approach.
Done
Line 32: 
Line 33: 
Line 34: _DEBUG_MODE = False
Line 35: LOG_FILE = '/tmp/libvirthook_ovs_migrate.log'


PS1, Line 87: target_vm_conf_by_vni
> Can you add the 'vnic' part? ..by_vnic_mac
Done


PS1, Line 100: target_vm_ifac
> How about: 'target_vm_iface_conf' ?
Done


Line 98: vnic_mac_addr = elem_macaddr.get('address')
Line 99: 
Line 100: target_vm_iface_conf = target_vm_conf_by_vnic_mac[vnic_mac_addr]
Line 101: target_vm_net = target_vm_iface_conf['network']
Line 102: 
> It's a bit nicer to go with the positive one and just bail out earlier with
Done
Line 103: if vm_migrate_plugins.skip_processing(interface, 
target_vm_iface_conf):
Line 104: return
Line 105: 
Line 106: target_ovs_bridge = net_api.ovs_bridge(target_vm_net)


https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_plugins/__init__.py
File vdsm/virt/vm_migrate_plugins/__init__.py:

Line 18
Line 19
Line 20
Line 21
Line 22
> please place new code under lib/vdsm
Done


PS1, Line 27: 
> _PLUGINS
Done


Line 26
Line 27
Line 28
Line 29
Line 30
> domxml_iface or something similar.
Done


Line 31
Line 32
Line 33
Line 34
Line 35
> You will need a decorator:
I'm dropping the class completely and invoking 'skip_processing' on the plugin 
itself.


-- 
To view, visit https://gerrit.ovirt.org/64186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 2: Code-Review-1

(5 comments)

-1 for visibility

https://gerrit.ovirt.org/#/c/63748/2/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 443: 
Line 444: def getAllVmIoTunePolicies(self):
Line 445: vm_io_tune_policies = {}
Line 446: for v in self.vmContainer.values():
Line 447: vm_io_tune_policies[v.id] = 
{'policy':v.getIoTunePolicy(), 'current_values': v.getIoTune()}
this saves us the roundtrips. It is one improvement, but not sure how 
significant it is.
First, we need a benchmark to compare and to assess our progress.
Then, we could compare the gains.
If this change is not enough, we can evolve from there, still guided by the 
benchmark.
Line 448: return vm_io_tune_policies
Line 449: 
Line 450: def createStompClient(self, client_socket):
Line 451: if 'jsonrpc' in self.bindings:


https://gerrit.ovirt.org/#/c/63748/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 2579: getIoTunePolicyResponse
what's the need for this?


PS2, Line 2601: getIoTuneResponse
ditto


Line 2624: 
Line 2625: except libvirt.libvirtError as e:
Line 2626: self.log.exception("getVmIoTune failed")
Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2628: self.logger.error('noVM')
not sure you wanna keep this.
Line 2629: return response.error('noVM')
Line 2630: else:
Line 2631: self.logger.error('updateIoTuneErr', e.message)
Line 2632: return response.error('updateIoTuneErr', 
e.message)


Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2628: self.logger.error('noVM')
Line 2629: return response.error('noVM')
Line 2630: else:
Line 2631: self.logger.error('updateIoTuneErr', e.message)
ditto
Line 2632: return response.error('updateIoTuneErr', 
e.message)
Line 2633: 
Line 2634: return response.success(ioTuneList=resultList)
Line 2635: 


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[jtokar]

Jenny Tokar has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 7626: object
> This is too generic. We need to specify type we return.
working on that :-)


https://gerrit.ovirt.org/#/c/63748/2/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 355: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 356: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
Line 357: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 
'vmList'},
Line 358: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 359: 'Host_getAllVmIoTunePolicies': {'ret': 
Host_getAllVmIoTunePolicies_Ret},
> Same here.
If I'm removing this the only response I'm getting is: {'status': {'message': 
'Done', 'code': 0}} without the 'io_tune_policies_dict'.
And if I'm using 'Host_getAllVmIoTunePolicies': {'ret': 
'io_tune_policies_dict'} I'm getting the status and the dictionary but without 
the dictionary name and I have no way of accessing it later on.
Line 360: 'Host_setupNetworks': {'ret': 'status'},
Line 361: 'Host_setKsmTune': {'ret': 'status'},
Line 362: 'Image_cloneStructure': {'ret': 'uuid'},
Line 363: 'Image_delete': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: More standard logging format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: log: More standard logging format
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sdm: Introduce new SDM.merge verb

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Introduce new SDM.merge verb
..


Patch Set 2:

(1 comment)

Let's discuss the API we want before proceeding.

https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 9919: CopyDataDivEndpoint
Great for code reuse but this means we're supplying the sd and image twice when 
all we truly need is:

 job_id, sd_id, img_id, base_vol_id, top_vol_id

Another concern is the .locks property of CopyDataDivEndpoint.  Are you sure 
you want the same set of locks (including the volume lease?  Maybe so but I 
expect there could be some issues with deciding whether locks are shared or 
exclusive.  I think it's better to use bare uuids in this verb and build your 
own lock list to pass to guarded.context directly in the verb itself.


-- 
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96d57a5b9f21153ce1de2cd5619c7f9f78bbe75b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Setup validation for OVS - Check nics usage
..

net: Setup validation for OVS - Check nics usage

OVS is not properly failing when adding a port that is already slaved
to a different device (bond as an example).
Therefore, there is a need to extend the validation checks to
include a check that looks for nics that may have multiple usages.

Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/network/ovs/validator.py
2 files changed, 31 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/64212/1

diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py
index 7f84168..599dfc6 100644
--- a/lib/vdsm/network/ovs/switch.py
+++ b/lib/vdsm/network/ovs/switch.py
@@ -38,7 +38,13 @@
 def validate_network_setup(nets, bonds):
 ovs_networks = info.create_netinfo(info.OvsInfo())['networks']
 kernel_nics = nics()
+
 kernel_bonds = Bond.bonds()
+kernel_bonds_slaves = set()
+for bond_name in kernel_bonds:
+kernel_bonds_slaves |= Bond(bond_name).slaves
+validator.validate_nic_usage(nets, bonds, kernel_bonds_slaves)
+
 for net, attrs in six.iteritems(nets):
 validator.validate_net_configuration(
 net, attrs, bonds, kernel_bonds, kernel_nics)
diff --git a/lib/vdsm/network/ovs/validator.py 
b/lib/vdsm/network/ovs/validator.py
index 4911a71..3df65f2 100644
--- a/lib/vdsm/network/ovs/validator.py
+++ b/lib/vdsm/network/ovs/validator.py
@@ -23,8 +23,7 @@
 from vdsm.network import errors as ne
 
 
-def validate_net_configuration(net, attrs, to_be_configured_bonds,
-   running_bonds, kernel_nics):
+def validate_net_configuration(net, attrs, bonds, running_bonds, kernel_nics):
 """Test if network meets logical Vdsm requiremets.
 
 Bridgeless networks are allowed in order to support Engine requirements.
@@ -40,8 +39,9 @@
 if nic and nic not in kernel_nics:
 raise ne.ConfigNetworkError(
 ne.ERR_BAD_NIC, 'Nic %s does not exist' % nic)
-if bond and (bond not in running_bonds and
- bond not in to_be_configured_bonds):
+running_bond = bond in running_bonds
+new_bond = bond in bonds and 'remove' not in bonds[bond]
+if bond and not running_bond and not new_bond:
 raise ne.ConfigNetworkError(
 ne.ERR_BAD_BONDING, 'Bond %s does not exist' % bond)
 else:
@@ -65,6 +65,27 @@
 raise ne.ConfigNetworkError(ne.ERR_BAD_NIC, 'Missing nics attribute')
 
 
+def validate_nic_usage(nets, bonds, kernel_bonds_slaves):
+request_bonds_slaves = set()
+for bond_attr in six.itervalues(bonds):
+if 'remove' in bond_attr:
+continue
+request_bonds_slaves |= set(bond_attr['nics'])
+
+request_nets_nics = set()
+for net_attr in six.itervalues(nets):
+if 'remove' in net_attr:
+continue
+request_nets_nics |= set(net_attr.get('nic', ()))
+
+shared_nics = ((request_bonds_slaves | kernel_bonds_slaves) &
+   request_nets_nics)
+if shared_nics:
+raise ne.ConfigNetworkError(ne.ERR_USED_NIC,
+'Nic/s with multiple usages: ' +
+shared_nics)
+
+
 def _validate_bond_addition(nics, kernel_nics):
 for nic in nics:
 if nic not in kernel_nics:


-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[jtokar]

Jenny Tokar has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/63748/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 2579: getIoTunePolicyResponse
> what's the need for this?
I didn't want to remove the current api for getting the io tune policy for a 
single vm. 
The api relies on this method. 
I could remove it and move the handling of the response to API.py.


PS2, Line 2601: getIoTuneResponse
> ditto
I didn't want to remove the current api for getting the io tune info for a 
single vm. 
The api relies on this method. 
I could remove it and move the handling of the response to API.py.


Line 2624: 
Line 2625: except libvirt.libvirtError as e:
Line 2626: self.log.exception("getVmIoTune failed")
Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2628: self.logger.error('noVM')
> not sure you wanna keep this.
why not? in case the method is called from the bulk api the error response is 
not returned (see getIoTune method that cleans it). if I'm logging the error at 
least there will be something that tells the user something failed.
Line 2629: return response.error('noVM')
Line 2630: else:
Line 2631: self.logger.error('updateIoTuneErr', e.message)
Line 2632: return response.error('updateIoTuneErr', 
e.message)


Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 2628: self.logger.error('noVM')
Line 2629: return response.error('noVM')
Line 2630: else:
Line 2631: self.logger.error('updateIoTuneErr', e.message)
> ditto
same
Line 2632: return response.error('updateIoTuneErr', 
e.message)
Line 2633: 
Line 2634: return response.success(ioTuneList=resultList)
Line 2635: 


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 7626: object
This is too generic. We need to specify type we return.


https://gerrit.ovirt.org/#/c/63748/2/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 257: """
Line 258: del ret['status']
Line 259: return ret
Line 260: 
Line 261: def Host_getAllVmIoTunePolicies_Ret(ret):
This should be not needed.
Line 262: return ret
Line 263: 
Line 264: def Host_getVMList_Call(api, args):
Line 265: """


Line 355: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 356: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
Line 357: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 
'vmList'},
Line 358: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 359: 'Host_getAllVmIoTunePolicies': {'ret': 
Host_getAllVmIoTunePolicies_Ret},
Same here.
Line 360: 'Host_setupNetworks': {'ret': 'status'},
Line 361: 'Host_setKsmTune': {'ret': 'status'},
Line 362: 'Image_cloneStructure': {'ret': 'uuid'},
Line 363: 'Image_delete': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> What about docstring For developers?
Sure, documentation is a must, but it is not enough.


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: WIP benchmark decorator module speed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP benchmark decorator module speed
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id619702a42a37150fb6772790430f70a259ab2b6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "configurator: libvirt: do not jump on virtlogd"

[fromani]

Francesco Romani has abandoned this change.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: vm_migration_libvirt_hook_plugins
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: shorten py3 blacklist
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: shorten py3 blacklist
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: log: Nicer logging format

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: log: Nicer logging format
..


Patch Set 1:

Do we know whether anyone already parses our log to collect information about 
what is going on?

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: [wip] build: assumptions about the path do not work for 
distcheck
..


Patch Set 1:

sure

-- 
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: WIP: API: more cleanups

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: API: more cleanups
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61591
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07cca8d3e6ee56c0e190e884410074431221371d
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[automation]

gerrit-hooks has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: response: helper to detect valid responses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: response: helper to detect valid responses
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifab6a25bea1b4a187d8425275e86bdb2fecf4c7d
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: WIP: add helper to enforce the `common` rules

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: add helper to enforce the `common` rules
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f7f374240c8ed379a874cf2324fa4b3b15feaa
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 9: Verified+1

(3 comments)

func_bond_basic_test passed

https://gerrit.ovirt.org/#/c/63723/8/tests/network/func_bond_basic_test.py
File tests/network/func_bond_basic_test.py:

PS8, Line 112: ifdown(BOND_
> Why is this needed? This info exists in the source control history.
Done


PS8, Line 115: self.update_netinfo()
> Can you add a comment on why it is needed?
Done


PS8, Line 124: with self._test_detach_used_bond_from_bri
> Calling this without a 'with'? What happens when it reaches the 'yield'?
Aha, it does not, it just returns 


-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: vm_migration_libvirt_hook_plugins
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 9:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 8: Verified+1

tests still pass :)

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:

PS2, Line 2: 2012
please update


-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move the response.py under common

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: lib: move the response.py under common
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-09-20 01:41:01 +0300
Line 4: Commit: Maor Lipchuk 
Line 5: CommitDate: 2016-09-20 03:56:54 +0300
Line 6: 
Line 7: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
We don't use such titles ([FOO]).

You can name this after the module or subsystem modified, or the feature, which 
is actually "qcow3".

- qcow2 == qcow_compat 0.10
- qcow3 == qcow_compat 1.1

I don't know why qemu are not calling this "version", this is how it is stored 
in qcow header.
Line 8: 
Line 9: Add kwargs of storage domain metadata to indicate the
Line 10: appropriate qcow level to use for create and convert operations.
Line 11: 


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> The whole point is to allow interested developers or users (or automation) 
What about docstring For developers?


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move define.py under common

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: lib: move define.py under common
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connect

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.connect
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19b6f25c17e697702ec61eba6b11f256c1df4d83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: alignmentScan: Use proper environment

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: alignmentScan: Use proper environment
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:

Line 1: #
Line 2: # Copyright (c) 2012, Sasha Tomic 
> please update
Thanks, will update in the next version.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ea5454a77b06e833723e0995ccbdeab9e5e5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 8:

* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Check Product::#1369822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: early IP+link setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 2: Verified+1

Passed testing by QE. No regression with legacy network. OVS networks' IP 
config was restored.

-- 
To view, visit https://gerrit.ovirt.org/63988
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: vm_migration_libvirt_hook_plugins

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: vm_migration_libvirt_hook_plugins
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.spmStart
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49072827b8ac04f720d50aca8e5a24b4be7582b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for StoragePool.getSpmStatus

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for StoragePool.getSpmStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb9fbae250507d4cf02ef9b73eee6403a06cd9d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for StoragePool.getInfo

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for StoragePool.getInfo
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeadf2323d2a3535a5777d0cc16027cfb9e42f0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for Task.getStatus

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for Task.getStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce3e3ab2e21e5d1f6da6bdf5dc89a3db40e2160
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: return type fixes for LVMVolumeGroup.getInfo

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59708
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc2b2a3d1e8b4563b24c60601c44e851f2603e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: [wip] build: assumptions about the path do not work for 
distcheck
..


Patch Set 1:

After rebase this patch is not needed anymore. There are new issues that I 
noticed in vdsm/static dir.

Deleting this change.

-- 
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 4: Code-Review-1

(4 comments)

qemuimg module cannot have storage logic, move the logic to sd.py.

We should have a new qcow_compat parameter and update the tests.

https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 45: RAW = "raw"
Line 46: VMDK = "vmdk"
Line 47: 
Line 48: _QCOW2_COMPAT_SUPPORTED = ("0.10", "1.1")
Line 49: _QCOW2_1_1 = "1.1"
We need a better name for this, and we need another constant for 0.10, and use 
both in the list above.
Line 50: 
Line 51: 
Line 52: def supports_compat(compat):
Line 53: return compat in _QCOW2_COMPAT_SUPPORTED


Line 102: return info
Line 103: 
Line 104: 
Line 105: def create(image, size=None, format=None, backing=None,
Line 106:backingFormat=None, **kwargs):
Please replace this change with qcow2_compat=None.

Injecting here a domain version is a layering violation. This is a wrapper 
around qemu-img command, and is not part of the storage layer. This layer does 
not know anything about version.

The caller of this api should choose the correct qcow_compat value, based on 
the storage domain version.

I think the best place for this in StorageDomain.qcow_compat() - it will check 
the domain version and return correct value.
Line 107: cmd = [_qemuimg.cmd, "create"]
Line 108: cwdPath = None
Line 109: 
Line 110: if format:


Line 154: raise QImgError(rc, out, err, "unable to parse qemu-img check 
output")
Line 155: 
Line 156: 
Line 157: def convert(srcImage, dstImage, srcFormat=None, dstFormat=None,
Line 158: backing=None, backingFormat=None, **kwargs):
Same, replace with qcow_compat=None
Line 159: cmd = [_qemuimg.cmd, "convert", "-p", "-t", "none", "-T", "none"]
Line 160: options = []
Line 161: cwdPath = None
Line 162: 


Line 307: if rc != 0:
Line 308: raise QImgError(rc, out, err)
Line 309: 
Line 310: 
Line 311: def _qcow2_compat(**kwargs):
Please rename to _default_qcow2_compat()

This will be used if the user did not specify the compat version.
Line 312: sd_version = kwargs.get('version')
Line 313: if sd_version == '4':
Line 314: return _QCOW2_1_1
Line 315: value = config.get('irs', 'qcow2_compat')


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move exception.py under common

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: lib: move exception.py under common
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 4:

This change broke many tests - please make sure all tests pass before you 
upload the next version.

3:46:15 ==
23:46:15 ERROR: test_volume_chain_copy('block', 'raw', 'raw', (0, 1)) 
(storage_sdm_copy_data_test.TestCopyDataDIV)
23:46:15 --
23:46:15 Traceback (most recent call last):
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/testlib.py",
 line 85, in wrapper
23:46:15 return f(self, *args)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storage_sdm_copy_data_test.py",
 line 164, in test_volume_chain_copy
23:46:15 chain_length=nr_vols) as (src_chain,
23:46:15   File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
23:46:15 return self.gen.next()
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storage_sdm_copy_data_test.py",
 line 74, in get_vols
23:46:15 chain_length)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/storagetestlib.py",
 line 356, in make_qemu_chain
23:46:15 format=qemuimg.FORMAT.QCOW2, backing=backing)
23:46:15   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/vdsm/qemuimg.py",
 line 113, in create
23:46:15 cmd.extend(('-o', 'compat=' + _qcow2_compat(kwargs)))
23:46:15 TypeError: _qcow2_compat() takes exactly 0 arguments (1 given)
23:46:15  >> begin captured logging << 
23:46:15 2016-09-19 23:45:16,559 DEBUG   [storage.PersistentDict] (MainThread) 
Created a persistent dict with VGTagMetadataRW backend
23:46:15 2016-09-19 23:45:16,560 DEBUG   [storage.PersistentDict] (MainThread) 
read lines (VGTagMetadataRW)=[]
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Empty metadata
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Starting transaction
23:46:15 2016-09-19 23:45:16,561 DEBUG   [storage.PersistentDict] (MainThread) 
Flushing changes
23:46:15 2016-09-19 23:45:16,562 DEBUG   [storage.PersistentDict] (MainThread) 
about to write lines (VGTagMetadataRW)=['CLASS=Data', 
'POOL_UUID=a65f91b4-d51c-49c7-92ec-d3767bd94e14', 
'SDUUID=3c02be87-d1da-4fa1-8fca-adfb7f4f63e5', 'VERSION=3', 
'_SHA_CKSUM=0c7bd0762a865207d4d00f5ae16b69a607125565']
23:46:15 2016-09-19 23:45:16,563 DEBUG   [storage.Metadata.VGTagMetadataRW] 
(MainThread) Updating metadata 
adding=MDT_POOL_UUID=a65f91b4-d51c-49c7-92ec-d3767bd94e14, MDT_VERSION=3, 
MDT_SDUUID=3c02be87-d1da-4fa1-8fca-adfb7f4f63e5, 
MDT__SHA_CKSUM=0c7bd0762a865207d4d00f5ae16b69a607125565, MDT_CLASS=Data 
removing=
23:46:15 2016-09-19 23:45:16,563 DEBUG   [storage.PersistentDict] (MainThread) 
Finished transaction
23:46:15 2016-09-19 23:45:16,568 WARNING [storage.StorageDomainManifest] 
(MainThread) Could not find mapping for lv 
3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/b8f76961-14df-4679-86c6-c21fe522cb8b
23:46:15 2016-09-19 23:45:16,569 DEBUG   [storage.StorageDomainManifest] 
(MainThread) Found freeSlot 4 in VG 3c02be87-d1da-4fa1-8fca-adfb7f4f63e5
23:46:15 2016-09-19 23:45:16,571 DEBUG   [storage.VolumeManifest] (MainThread) 
Creating symlink from 
/var/tmp/tmpBX_Rfb/dev/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/b8f76961-14df-4679-86c6-c21fe522cb8b
 to 
/var/tmp/tmpBX_Rfb/mnt/blockSD/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/images/d6ae6eb6-fb86-40e5-929b-8e554df0d1a2/b8f76961-14df-4679-86c6-c21fe522cb8b
23:46:15 2016-09-19 23:45:16,575 WARNING [storage.StorageDomainManifest] 
(MainThread) Could not find mapping for lv 
3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/8c4ecba5-0767-41a2-abb5-87afcc9b0949
23:46:15 2016-09-19 23:45:16,576 DEBUG   [storage.StorageDomainManifest] 
(MainThread) Found freeSlot 5 in VG 3c02be87-d1da-4fa1-8fca-adfb7f4f63e5
23:46:15 2016-09-19 23:45:16,583 DEBUG   [storage.VolumeManifest] (MainThread) 
Creating symlink from 
/var/tmp/tmpBX_Rfb/dev/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/8c4ecba5-0767-41a2-abb5-87afcc9b0949
 to 
/var/tmp/tmpBX_Rfb/mnt/blockSD/3c02be87-d1da-4fa1-8fca-adfb7f4f63e5/images/d6ae6eb6-fb86-40e5-929b-8e554df0d1a2/8c4ecba5-0767-41a2-abb5-87afcc9b0949
23:46:15 - >> end captured logging << -

-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: 

Change in vdsm[master]: lib: api: allow to return prebuilt responses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 29: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooks: Destroy fcoe interface once config removed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Destroy fcoe interface once config removed
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/57867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2417d9d16dd76ca063100124a059deeeb328f305
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: add and use new devel logger

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: logging: add and use new devel logger
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 31: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Remove python-argparse requirement

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove python-argparse requirement
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Revert "configurator: libvirt: do not jump on virtlogd"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..


Patch Set 1:

* #1370103::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 309: 
Line 310: 
Line 311: def _qcow2_compat(**kwargs):
Line 312: sd_version = kwargs.get('version')
Line 313: if sd_version == '4':
>= 4 perhaps?
Line 314: return _QCOW2_1_1
Line 315: value = config.get('irs', 'qcow2_compat')
Line 316: if value not in _QCOW2_COMPAT_SUPPORTED:
Line 317: raise exception.InvalidConfiguration(


-- 
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[fromani]

Francesco Romani has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py
File vdsm/API.py:

Line 37: from vdsm import supervdsm
Line 38: from vdsm import throttledlog
Line 39: from vdsm import jobs
Line 40: from vdsm import v2v
Line 41: from vdsm.common import api as wrapapi
> Can we use the original name?
I had a name clash. Not sure if it applies nowadays. Will try, and if still 
relevant I'll add a comment to explain.
Line 42: from vdsm.host import api as hostapi
Line 43: from vdsm.logUtils import AllVmStatsValue, Suppressed
Line 44: from vdsm.storage import clusterlock
Line 45: from vdsm.storage import misc


Line 127: @contextmanager
Line 128: def _vm_instance(self):
Line 129: v = self._cif.vmContainer.get(self._UUID)
Line 130: if not v:
Line 131: raise exception.NoSuchVM()
> Nice cleanup!
Good idea, will implement.
Line 132: yield v
Line 133: 
Line 134: @wrapapi.method
Line 135: def changeCD(self, driveSpec):


-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: Do not modify warnings filter in a library

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 138
Line 139
Line 140
Line 141
Line 142
> Sure, documentation is a must, but it is not enough.
Why is it not enough? We are talking about developers not users.


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Split OVS setup transaction to adjust for bond setup
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 202: 
Line 203: def _add_networks(nets2add, ovs_info, config, acq):
Line 204: net_add_setup = ovs_switch.create_network_addition_setup(ovs_info)
Line 205: net_add_setup.add(nets2add)
Line 206: acq.acquire(net_add_setup.acquired_ifaces)
but we should acquire before we commit add(), right?
Line 207: for net, attrs in six.iteritems(nets2add):
Line 208: config.setNetwork(net, attrs)
Line 209: 
Line 210: 


https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:

Line 122: # FIXME: What about an existing bond?
Line 123: if nic is not None and vlan is None:
Line 124: self._copy_nic_hwaddr_to_nb(net, nic)
Line 125: 
Line 126: self._ovs_info.northbounds_by_sb.setdefault(sb, set())
.add(net) won't  fit here?
Line 127: self._ovs_info.northbounds_by_sb[sb].add(net)
Line 128: 
Line 129: @property
Line 130: def acquired_ifaces(self):


Line 197: """
Line 198: return [ovsdb.del_br(bridge) for bridge in _unused_bridges()]
Line 199: 
Line 200: 
Line 201: # TODO: we can just check for bridges with no NB port
can we address this? we detach both NICs and bonds from bridge when not used 
anymore.
Line 202: def _unused_bridges():
Line 203: unused_bridges = set()
Line 204: ovs_info = info.OvsInfo()
Line 205: for bridge, attrs in six.iteritems(ovs_info.bridges):


-- 
To view, visit https://gerrit.ovirt.org/64118
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 16:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: properly set is_hostdevice

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: properly set is_hostdevice
..


Patch Set 8:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move define.py under common

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: move define.py under common
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move the response.py under common

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: move the response.py under common
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: migration plugin proposal - draft 102

[automation]

gerrit-hooks has posted comments on this change.

Change subject: draft: migration plugin proposal - draft 102
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: v2v: add test for Xen block device
..


v2v: add test for Xen block device

Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/63022
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Tomas Golembiovsky 
---
M tests/v2vTests.py
1 file changed, 27 insertions(+), 2 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Tomas Golembiovsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 264: 
Line 265: ('host_numa_scheduling', 'true',
Line 266: 'Enable implicit scheduling of VMs to properly match numa 
'
Line 267: 'topology. Explicit settings sent from engine disables 
the '
Line 268: 'scheduling.'),
> implicit scheduling ?
Way better.
Line 269: ]),
Line 270: 
Line 271: # Section: [rpc]
Line 272: ('rpc', [


https://gerrit.ovirt.org/#/c/60640/15/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS15, Line 519: [dev_object.numa_node for dev_object in devices if
  : dev_object.is_hostdevice and 
dev_object.numa_node]
> Obfuscation contest?
How is this obfuscation? It literally reads "list of numa nodes for host 
devices with numa node available".


-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: devices: add is_hostdevice attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: devices: add is_hostdevice attribute
..


Patch Set 8:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 30:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 29: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cmdutils: enhance systemd_run

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: cmdutils: enhance systemd_run
..


cmdutils: enhance systemd_run

Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/56474
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/cmdutils.py
M tests/cmdutilsTests.py
2 files changed, 27 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move define.py under common

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: move define.py under common
..


lib: move define.py under common

The commit fc732ae broke the rule that code under lib/vdsm/common
should depend only on code under the same subtree.

Another module which should be moved to fix the breakage is
define.py. Again this makes sense to move anyway.
It should go away soon, but for the meantime let's have this here.

Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63953
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/Makefile.am
R lib/vdsm/common/define.py
M lib/vdsm/host/api.py
M lib/vdsm/momIF.py
M lib/vdsm/response.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/v2v.py
M lib/vdsm/virt/vmpowerdown.py
M tests/functional/momTests.py
M tests/momTests.py
M tests/responseTests.py
M tests/vmApiTests.py
M tests/vmOperationsTests.py
M tests/vmTests.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/gluster/api.py
M vdsm/virt/migration.py
M vdsm/virt/vm.py
20 files changed, 19 insertions(+), 21 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I634d3bac718fe0615a2aca951ec47b976967ada1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move the response.py under common

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: move the response.py under common
..


lib: move the response.py under common

The commit fc732ae broke the rule that code under lib/vdsm/common
should depend only on code under the same subtree.

The last module we need to move to fix the breakage is 'response'.
Once again, this makes sense to be moved in the common layer anyway.

Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63954
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/Makefile.am
M lib/vdsm/common/api.py
R lib/vdsm/common/response.py
M lib/vdsm/jobs.py
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/v2v.py
M lib/vdsm/virt/secret.py
M lib/vdsm/virt/vmpowerdown.py
M tests/api_test.py
M tests/jobsTests.py
M tests/responseTests.py
M tests/vmMigrationTests.py
M tests/vmOperationsTests.py
M tests/vmRecoveryTests.py
M tests/vmSecretTests.py
M tests/vmTests.py
M tests/vmfakelib.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/virt/migration.py
M vdsm/virt/recovery.py
M vdsm/virt/vm.py
23 files changed, 22 insertions(+), 25 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6263fb8991a226516ba5d14e909a4a70ea0078d2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api.py: preserve signature in decorator

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: api.py: preserve signature in decorator
..


lib: api.py: preserve signature in decorator

The api.method decorator needs to preserve the function
or method signature, to let the schema validation keep working.
Moreover, preserving the signature of decorated callables
is a good idea anyway.

In python 3.4+ this is done by default, but on python 2.7
we need to take steps to implement this.
We leverage the existing 'decorator' module which solves
this problem. This module is available in EL/Centos7.

For further reference:
http://pythonhosted.org/decorator/documentation.html

Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63759
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M automation/build-artifacts.packages.el7
M automation/build-artifacts.packages.fc24
M automation/check-merged.packages.el7
M automation/check-merged.packages.fc24
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc24
M lib/vdsm/common/api.py
M tests/api_test.py
M vdsm.spec.in
9 files changed, 55 insertions(+), 20 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api.py: preserve signature in decorator

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: lib: api.py: preserve signature in decorator
..


Patch Set 13: Code-Review+2

never mind the minor slowdown of each API call, let's take this in.

-- 
To view, visit https://gerrit.ovirt.org/63759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: api.py: preserve signature in decorator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: api.py: preserve signature in decorator
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: expose numa_node in host device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose numa_node in host device
..


Patch Set 14:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: report device MMIO numa node

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: report device MMIO numa node
..


Patch Set 14:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move condition from appendNumaTune to buildDomainXML

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: shorten py3 blacklist
..


tests: shorten py3 blacklist

A few more test modules are passing under Python 3. Let's keeep testing
them.

Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/64060
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Piotr Kliczewski 
---
M tests/Makefile.am
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: shorten py3 blacklist
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: add test for Xen block device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add test for Xen block device
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: migration plugin proposal - draft 102

[mmirecki]

Marcin Mirecki has uploaded a new change for review.

Change subject: draft: migration plugin proposal - draft 102
..

draft: migration plugin proposal - draft 102

Just a draft to show the idea, not verified

Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Signed-off-by: mirecki 
---
M vdsm/virt/vm_migrate_hook.py
A vdsm/virt/vm_migrate_plugins/__init__.py
A vdsm/virt/vm_migrate_plugins/external_network_plugin.py
A vdsm/virt/vm_migrate_plugins/openstack_network_plugin.py
A vdsm/virt/vm_migrate_plugins/vm_fex_plugin.py
5 files changed, 161 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/64186/1

diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 633e4f0..dd276f5 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -28,6 +28,8 @@
 from vdsm.config import config
 from vdsm.network import api as net_api
 
+import vm_migrate_plugins
+
 
 _DEBUG_MODE = False
 LOG_FILE = '/tmp/libvirthook_ovs_migrate.log'
@@ -82,24 +84,28 @@
 
 
 def _set_bridge_interfaces(devices, target_vm_conf):
-target_vm_nets_by_vnic_mac = {dev['macAddr']: dev['network']
-  for dev in target_vm_conf['devices']
-  if dev.get('type') == 'interface'}
+target_vm_conf_by_mac = {dev['macAddr']: dev
+ for dev in target_vm_conf['devices']
+ if dev.get('type') == 'interface'}
+
 for interface in devices.findall('interface'):
 if interface.get('type') == 'bridge':
-_bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac)
+_bind_iface_to_bridge(interface, target_vm_conf_by_mac)
 
 
-def _bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac):
+def _bind_iface_to_bridge(interface, target_vm_conf_by_mac):
 elem_macaddr = interface.find('mac')
 mac_addr = elem_macaddr.get('address')
 
-target_vm_net = target_vm_nets_by_vnic_mac[mac_addr]
-target_ovs_bridge = net_api.ovs_bridge(target_vm_net)
-if target_ovs_bridge:
-_bind_iface_to_ovs_bridge(interface, target_ovs_bridge, target_vm_net)
-else:
-_bind_iface_to_linux_bridge(interface, target_vm_net)
+interface_conf = target_vm_conf_by_mac[mac_addr]
+target_vm_net = interface_conf['network']
+if not vm_migrate_plugins.skip_processing(interface, interface_conf):
+target_ovs_bridge = net_api.ovs_bridge(target_vm_net)
+if target_ovs_bridge:
+_bind_iface_to_ovs_bridge(interface, target_ovs_bridge,
+  target_vm_net)
+else:
+_bind_iface_to_linux_bridge(interface, target_vm_net)
 
 
 def _bind_iface_to_ovs_bridge(interface, target_ovs_bridge, target_vm_net):
diff --git a/vdsm/virt/vm_migrate_plugins/__init__.py 
b/vdsm/virt/vm_migrate_plugins/__init__.py
new file mode 100644
index 000..6c81eee
--- /dev/null
+++ b/vdsm/virt/vm_migrate_plugins/__init__.py
@@ -0,0 +1,43 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+import abc
+from importlib import import_module
+from pkgutil import iter_modules
+
+import six
+
+
+_DRIVERS = []
+
+
+def skip_processing(domxml, device_conf):
+for driver in _DRIVERS:
+driver.create().skip_processing(domxml, device_conf)
+
+
+class VmMigratePlugin():
+
+@abc.abstractmethod
+def skip_processing(self, domxml, device_conf):
+return False
+
+
+for _, module, _ in iter_modules([__path__[0]]):
+_DRIVERS.append(import_module('{}.{}'.format(__name__, module)))
diff --git a/vdsm/virt/vm_migrate_plugins/external_network_plugin.py 
b/vdsm/virt/vm_migrate_plugins/external_network_plugin.py
new file mode 100644
index 000..6beb0b2
--- /dev/null
+++ b/vdsm/virt/vm_migrate_plugins/external_network_plugin.py
@@ -0,0 +1,35 @@
+#!/usr/bin/env python
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# 

Change in vdsm[master]: draft: migration plugin proposal - draft 102

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: draft: migration plugin proposal - draft 102
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 27: from vdsm import jsonrpcvdscli
Line 28: from vdsm.config import config
Line 29: from vdsm.network import api as net_api
Line 30: 
Line 31: import vm_migrate_plugins
I like this simplistic approach.

but now the name vnic_migrate_plugins may better fit.

Also, each plugin should be shipped as part of its relevant hook.
Line 32: 
Line 33: 
Line 34: _DEBUG_MODE = False
Line 35: LOG_FILE = '/tmp/libvirthook_ovs_migrate.log'


https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_plugins/__init__.py
File vdsm/virt/vm_migrate_plugins/__init__.py:

Line 18: #
Line 19: 
Line 20: import abc
Line 21: from importlib import import_module
Line 22: from pkgutil import iter_modules
please place new code under lib/vdsm
Line 23: 
Line 24: import six
Line 25: 
Line 26: 


https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_plugins/external_network_plugin.py
File vdsm/virt/vm_migrate_plugins/external_network_plugin.py:

Line 25: 
Line 26: EXTERNAL_NETWORK = 'EXTERNAL_NETWORK'
Line 27: 
Line 28: def skip_processing(self, domxml, conf):
Line 29: custom = conf.get('custom')
custom = conf.get('custom', {})

is much safer
Line 30: return custom.get('provider_type') == self.EXTERNAL_NETWORK \
Line 31: if custom else False
Line 32: 
Line 33: 


-- 
To view, visit https://gerrit.ovirt.org/64186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move exception.py under common

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: move exception.py under common
..


lib: move exception.py under common

The commit fc732ae broke the rule that code under lib/vdsm/common
should depend only on code under the same subtree.

The good news is that the code moved in fc732ae depends only on
a few modules; one of them is exception.py, which makes sense
to move under common/ anyway.

This patch does that.

Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63952
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/Makefile.am
M lib/vdsm/commands.py
M lib/vdsm/common/api.py
R lib/vdsm/common/exception.py
M lib/vdsm/define.py
M lib/vdsm/gluster/exception.py
M lib/vdsm/hooks.py
M lib/vdsm/jobs.py
M lib/vdsm/qemuimg.py
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/storage/exception.py
M lib/yajsonrpc/__init__.py
M tests/api_test.py
M tests/bridgeTests.py
M tests/exception_test.py
M tests/jobsTests.py
M tests/miscTests.py
M tests/qemuimgTests.py
M tests/storage_exception_test.py
M tests/storage_sdm_create_volume_test.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/image.py
M vdsm/storage/sdm/api/create_volume.py
28 files changed, 28 insertions(+), 27 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: move exception.py under common

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: move exception.py under common
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7742aa7dafe0e0e29044536ad19fbddbcab0f420
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: gluster: set selinux labels while creating bricks

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 329: try:
Line 330: selinux.restorecon(mountPoint, recursive=True)
Line 331: except OSError as e:
Line 332: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, 
e.filename)
Line 333: raise ge.GlusterHostFailedToRunRestorecon(mountPoint, 
err=errMsg)
this works, no doubt about that, but why has not the parent directory (/rhgs) 
the right labelling in the first place?
Let me share on example of what I mean

On a pristine CentOS 7.2 box (which I have handy for experimenting):

KENji> 13:21:56 root [~]$ mkdir /rhgs
KENji> 13:22:00 root [~]$ ls -lhZd /rhgs
drwxr-xr-x. root root unconfined_u:object_r:default_t:s0 /rhgs

So /rhgs has wrong context. And it is empty:
KENji> 13:22:05 root [~]$ ls -lh /rhgs
total 0

Let's fix the context of this root directory:
KENji> 13:22:46 root [~]$ semanage fcontext -a -t glusterd_brick_t /rhgs
KENji> 13:23:22 root [~]$ restorecon -Rv /rhgs/
restorecon reset /rhgs context 
unconfined_u:object_r:default_t:s0->unconfined_u:object_r:glusterd_brick_t:s0

Now, if we create any subfolder:
KENji> 13:23:31 root [~]$ mkdir /rhgs/brick1
KENji> 13:23:54 root [~]$ mkdir /rhgs/brick2
KENji> 13:23:54 root [~]$ ls -lh /rhgs
total 8.0K
drwxr-xr-x. 2 root root 4.0K Sep 20 13:23 brick1
drwxr-xr-x. 2 root root 4.0K Sep 20 13:23 brick2
KENji> 13:23:58 root [~]$ ls -lhZd /rhgs
drwxr-xr-x. root root unconfined_u:object_r:glusterd_brick_t:s0 /rhgs
KENji> 13:24:04 root [~]$ ls -lhZd /rhgs/*
drwxr-xr-x. root root unconfined_u:object_r:glusterd_brick_t:s0 /rhgs/brick1
drwxr-xr-x. root root unconfined_u:object_r:glusterd_brick_t:s0 /rhgs/brick2


Looks better, and it has the correct context since the beginning, no room for 
races.

Is that what you want? Please confirm. If so, fixing the context of the parent 
seems better; I'm pretty sure we can make one step even further and patch the 
selinux-policy package to make sure the /rhgs directory gets the right context 
when it is created, but I don't have the instructions handy now. Could be worth 
to just file a bug and depend on that.


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 16:

(2 comments)

https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS16, Line 1527: [device for devices in self._devices.values() for
   :  device in devices]
This is the actual complicated construct.


https://gerrit.ovirt.org/#/c/60640/15/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS15, Line 519: [dev_object.numa_node for dev_object in devices if
  : dev_object.is_hostdevice and 
dev_object.numa_node]
> How is this obfuscation? It literally reads "list of numa nodes for host de
I'm sorry, a misplaced comment, it belonged to vm.py.


-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org