date:20140213

[webkit-changes] [164094] trunk/Source/WebKit2

2014-02-13 Thread mitz

Title: [164094] trunk/Source/WebKit2








Revision 164094
Author m...@apple.com
Date 2014-02-13 22:04:27 -0800 (Thu, 13 Feb 2014)


Log Message
[Cocoa] Expose the bundle form client
https://bugs.webkit.org/show_bug.cgi?id=128792

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj: Added new file.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didFocusTextField): Implemented this WKBundlePageFormClient callback by calling the form
delegate.
(setUpFormClient): Added. Initializes the form client with the above function.
(-[WKWebProcessPlugInBrowserContextController _formDelegate]): Added this getter.
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added. Initializes or
clears the form client.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
Declared _formDelegate property.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h


Added Paths

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164093 => 164094)

--- trunk/Source/WebKit2/ChangeLog	2014-02-14 06:03:34 UTC (rev 164093)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-14 06:04:27 UTC (rev 164094)
@@ -1,5 +1,24 @@
 2014-02-13  Dan Bernstein  
 
+[Cocoa] Expose the bundle form client
+https://bugs.webkit.org/show_bug.cgi?id=128792
+
+Reviewed by Anders Carlsson.
+
+* WebKit2.xcodeproj/project.pbxproj: Added new file.
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added.
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+(didFocusTextField): Implemented this WKBundlePageFormClient callback by calling the form
+delegate.
+(setUpFormClient): Added. Initializes the form client with the above function.
+(-[WKWebProcessPlugInBrowserContextController _formDelegate]): Added this getter.
+(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added. Initializes or
+clears the form client.
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
+Declared _formDelegate property.
+
+2014-02-13  Dan Bernstein  
+
 [Cocoa] Add a way to get the page from a frame in the injected bundle
 https://bugs.webkit.org/show_bug.cgi?id=128791
 


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (164093 => 164094)

--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-02-14 06:03:34 UTC (rev 164093)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2014-02-14 06:04:27 UTC (rev 164094)
@@ -598,6 +598,7 @@
 		37948404150C350600E52CE9 /* WebRenderLayer.h in Headers */ = {isa = PBXBuildFile; fileRef = 37948402150C350600E52CE9 /* WebRenderLayer.h */; };
 		37948408150C4B9700E52CE9 /* WKRenderLayer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 37948406150C4B9600E52CE9 /* WKRenderLayer.cpp */; };
 		37948409150C4B9700E52CE9 /* WKRenderLayer.h in Headers */ = {isa = PBXBuildFile; fileRef = 37948407150C4B9600E52CE9 /* WKRenderLayer.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		3795789C18AD4F1900B9ED2E /* WKWebProcessPlugInFormDelegatePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 3795789B18AD4F1100B9ED2E /* WKWebProcessPlugInFormDelegatePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		37C4C08618149C5B003688B9 /* WKBackForwardListItem.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37C4C08418149C5B003688B9 /* WKBackForwardListItem.mm */; };
 		37C4C08718149C5B003688B9 /* WKBackForwardListItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08518149C5B003688B9 /* WKBackForwardListItem.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		37C4C08918149F23003688B9 /* WKBackForwardListItemInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08818149F23003688B9 /* WKBackForwardListItemInternal.h */; };
@@ -2308,6 +2309,7 @@
 		37948402150C350600E52CE9 /* WebRenderLayer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebRenderLayer.h; sourceTree = ""; };
 		37948406150C4B9600E52CE9 /* WKRenderLayer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKRenderLayer.cpp; sourceTree = ""; };
 		37948407150C4B9600E52CE9 /* WKRenderLayer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKRenderLayer.h; sourceTree = ""; };
+		3795789B18AD4F1100B9ED2E /* WKWebProcessPlugInFormDelegatePrivate.h */ = {isa = PBXF

[webkit-changes] [164093] trunk/Source/WebKit2

2014-02-13 Thread mitz

Title: [164093] trunk/Source/WebKit2








Revision 164093
Author m...@apple.com
Date 2014-02-13 22:03:34 -0800 (Thu, 13 Feb 2014)


Log Message
[Cocoa] Add a way to get the page from a frame in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=128791

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _browserContextController]): Added.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Declared
_browserContextController property.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164092 => 164093)

--- trunk/Source/WebKit2/ChangeLog	2014-02-14 05:37:38 UTC (rev 164092)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-14 06:03:34 UTC (rev 164093)
@@ -1,3 +1,15 @@
+2014-02-13  Dan Bernstein  
+
+[Cocoa] Add a way to get the page from a frame in the injected bundle
+https://bugs.webkit.org/show_bug.cgi?id=128791
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+(-[WKWebProcessPlugInFrame _browserContextController]): Added.
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Declared
+_browserContextController property.
+
 2014-02-13  Anders Carlsson  
 
 Add -[WKWebView stopLoading:]


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (164092 => 164093)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm	2014-02-14 05:37:38 UTC (rev 164092)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm	2014-02-14 06:03:34 UTC (rev 164093)
@@ -31,6 +31,7 @@
 #import "WKFrameHandleInternal.h"
 #import "WKNSArray.h"
 #import "WKNSURLExtras.h"
+#import "WKWebProcessPlugInBrowserContextControllerInternal.h"
 #import "WKWebProcessPlugInHitTestResultInternal.h"
 #import "WKWebProcessPlugInNodeHandleInternal.h"
 #import "WKWebProcessPlugInScriptWorldInternal.h"
@@ -76,6 +77,11 @@
 return [JSValue valueWithJSValueRef:valueRef inContext:[self jsContextForWorld:world]];
 }
 
+- (WKWebProcessPlugInBrowserContextController *)_browserContextController
+{
+return wrapper(*_frame->page());
+}
+
 - (NSURL *)URL
 {
 return [NSURL _web_URLWithWTFString:_frame->url()];


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h (164092 => 164093)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h	2014-02-14 05:37:38 UTC (rev 164092)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h	2014-02-14 06:03:34 UTC (rev 164093)
@@ -27,10 +27,14 @@
 
 #if WK_API_ENABLED
 
+@class WKWebProcessPlugInBrowserContextController;
+
 @interface WKWebProcessPlugInFrame (WKPrivate)
 
 + (instancetype)lookUpFrameFromHandle:(WKFrameHandle *)handle;
 
+@property (nonatomic, readonly) WKWebProcessPlugInBrowserContextController *_browserContextController;
+
 @end
 
 #endif // WK_API_ENABLED






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164092] trunk/Source/JavaScriptCore

2014-02-13 Thread fpizlo

Title: [164092] trunk/Source/_javascript_Core








Revision 164092
Author fpi...@apple.com
Date 2014-02-13 21:37:38 -0800 (Thu, 13 Feb 2014)


Log Message
Kill some of the last vestiges of the C++ interpreter's PICs
https://bugs.webkit.org/show_bug.cgi?id=128796

Reviewed by Michael Saboff.

* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecode/PolymorphicAccessStructureList.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/Repatch.cpp:
(JSC::getPolymorphicStructureList):
(JSC::tryBuildGetByIDList):
* llint/LowLevelInterpreter.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/bytecode/PolymorphicAccessStructureList.h
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp
trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164091 => 164092)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-14 04:03:59 UTC (rev 164091)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-14 05:37:38 UTC (rev 164092)
@@ -1,3 +1,39 @@
+2014-02-13  Filip Pizlo  
+
+Kill some of the last vestiges of the C++ interpreter's PICs
+https://bugs.webkit.org/show_bug.cgi?id=128796
+
+Reviewed by Michael Saboff.
+
+* bytecode/BytecodeUseDef.h:
+(JSC::computeUsesForBytecodeOffset):
+(JSC::computeDefsForBytecodeOffset):
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::printGetByIdOp):
+(JSC::CodeBlock::printGetByIdCacheStatus):
+(JSC::CodeBlock::dumpBytecode):
+(JSC::CodeBlock::CodeBlock):
+* bytecode/GetByIdStatus.cpp:
+(JSC::GetByIdStatus::computeForStubInfo):
+* bytecode/Opcode.h:
+(JSC::padOpcodeName):
+* bytecode/PolymorphicAccessStructureList.h:
+(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
+(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
+(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
+(JSC::PolymorphicAccessStructureList::visitWeak):
+* bytecode/StructureStubInfo.cpp:
+(JSC::StructureStubInfo::deref):
+(JSC::StructureStubInfo::visitWeakReferences):
+* bytecode/StructureStubInfo.h:
+(JSC::isGetByIdAccess):
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+* jit/Repatch.cpp:
+(JSC::getPolymorphicStructureList):
+(JSC::tryBuildGetByIDList):
+* llint/LowLevelInterpreter.asm:
+
 2014-02-13  Mark Lam  
 
 The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs. Part 2.


Modified: trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h (164091 => 164092)

--- trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2014-02-14 04:03:59 UTC (rev 164091)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2014-02-14 05:37:38 UTC (rev 164092)
@@ -99,13 +99,10 @@
 return;
 }
 case op_put_by_index:
-case op_put_by_id_replace:
-case op_put_by_id_transition:
 case op_put_by_id_transition_direct:
 case op_put_by_id_transition_direct_out_of_line:
 case op_put_by_id_transition_normal:
 case op_put_by_id_transition_normal_out_of_line:
-case op_put_by_id_generic:
 case op_put_by_id_out_of_line:
 case op_put_by_id:
 case op_put_to_scope: {
@@ -126,18 +123,7 @@
 case op_to_primitive:
 case op_get_by_id:
 case op_get_by_id_out_of_line:
-case op_get_by_id_self:
-case op_get_by_id_proto:
-case op_get_by_id_chain:
-case op_get_by_id_getter_self:
-case op_get_by_id_getter_proto:
-case op_get_by_id_getter_chain:
-case op_get_by_id_custom_self:
-case op_get_by_id_custom_proto:
-case op_get_by_id_custom_chain:
-case op_get_by_id_generic:
 case op_ge

[webkit-changes] [164091] trunk/Source/WebCore

2014-02-13 Thread commit-queue

Title: [164091] trunk/Source/WebCore








Revision 164091
Author commit-qu...@webkit.org
Date 2014-02-13 20:03:59 -0800 (Thu, 13 Feb 2014)


Log Message
[MSE] Move PublicURLManager shutdown logic so ActiveDOMObjects associated with public URLs won't leak.
https://bugs.webkit.org/show_bug.cgi?id=128532

Patch by Byungseon Shin  on 2014-02-13
Reviewed by Jer Noble.

This fixes a leak of DOM objects by breaking the circular reference
between Document, PublicURLManager, and MediaSource.
Instead of clearing PublicURLManager at destruction-time,
which is delayed indefinitely because of the circular reference,
clear the PublicURLManager during ActiveDOMObject::stop().

Frome Blink r151890 by 


* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::publicURLManager):
* html/DOMURL.h:
* html/PublicURLManager.cpp:
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::PublicURLManager):
(WebCore::PublicURLManager::registerURL):
(WebCore::PublicURLManager::stop):
* html/PublicURLManager.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/html/DOMURL.h
trunk/Source/WebCore/html/PublicURLManager.cpp
trunk/Source/WebCore/html/PublicURLManager.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164090 => 164091)

--- trunk/Source/WebCore/ChangeLog	2014-02-14 03:35:13 UTC (rev 164090)
+++ trunk/Source/WebCore/ChangeLog	2014-02-14 04:03:59 UTC (rev 164091)
@@ -1,3 +1,30 @@
+2014-02-13  Byungseon Shin  
+
+[MSE] Move PublicURLManager shutdown logic so ActiveDOMObjects associated with public URLs won't leak.
+https://bugs.webkit.org/show_bug.cgi?id=128532
+
+Reviewed by Jer Noble.
+
+This fixes a leak of DOM objects by breaking the circular reference 
+between Document, PublicURLManager, and MediaSource. 
+Instead of clearing PublicURLManager at destruction-time, 
+which is delayed indefinitely because of the circular reference, 
+clear the PublicURLManager during ActiveDOMObject::stop().
+
+Frome Blink r151890 by 
+
+
+* dom/ScriptExecutionContext.cpp:
+(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
+(WebCore::ScriptExecutionContext::publicURLManager):
+* html/DOMURL.h:
+* html/PublicURLManager.cpp:
+(WebCore::PublicURLManager::create):
+(WebCore::PublicURLManager::PublicURLManager):
+(WebCore::PublicURLManager::registerURL):
+(WebCore::PublicURLManager::stop):
+* html/PublicURLManager.h:
+
 2014-02-13  Myles C. Maxfield  
 
 Remove position:sticky runtime flag


Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (164090 => 164091)

--- trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-14 03:35:13 UTC (rev 164090)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2014-02-14 04:03:59 UTC (rev 164091)
@@ -117,10 +117,6 @@
 ASSERT((*iter)->scriptExecutionContext() == this);
 (*iter)->contextDestroyed();
 }
-#if ENABLE(BLOB)
-if (m_publicURLManager)
-m_publicURLManager->contextDestroyed();
-#endif
 }
 
 void ScriptExecutionContext::processMessagePortMessagesSoon()
@@ -367,7 +363,7 @@
 PublicURLManager& ScriptExecutionContext::publicURLManager()
 {
 if (!m_publicURLManager)
-m_publicURLManager = PublicURLManager::create();
+m_publicURLManager = PublicURLManager::create(this);
 return *m_publicURLManager;
 }
 #endif


Modified: trunk/Source/WebCore/html/DOMURL.h (164090 => 164091)

--- trunk/Source/WebCore/html/DOMURL.h	2014-02-14 03:35:13 UTC (rev 164090)
+++ trunk/Source/WebCore/html/DOMURL.h	2014-02-14 04:03:59 UTC (rev 164091)
@@ -53,8 +53,6 @@
 void setHref(const String&, ExceptionCode&);
 
 #if ENABLE(BLOB)
-static void contextDestroyed(ScriptExecutionContext*);
-
 static String createObjectURL(ScriptExecutionContext*, Blob*);
 static void revokeObjectURL(ScriptExecutionContext*, const String&);
 


Modified: trunk/Source/WebCore/html/PublicURLManager.cpp (164090 => 164091)

--- trunk/Source/WebCore/html/PublicURLManager.cpp	2014-02-14 03:35:13 UTC (rev 164090)
+++ trunk/Source/WebCore/html/PublicURLManager.cpp	2014-02-14 04:03:59 UTC (rev 164091)
@@ -35,8 +35,24 @@
 
 namespace WebCore {
 
+PassOwnPtr PublicURLManager::create(ScriptExecutionContext* context)
+{
+OwnPtr publicURLManager(adoptPtr(new PublicURLManager(context)));
+publicURLManager->suspendIfNeeded();
+return publicURLManager.release();
+}
+
+PublicURLManager::PublicURLManager(ScriptExecutionContext* context)
+: ActiveDOMObject(context)
+, m_isStopped(false)
+{
+}
+
 void PublicURLManager::registerURL(SecurityOrigin* origin, const URL& url, URLRegistrable* registrable)
 {
+if (m_isStopped)
+return;
+
 RegistryURLMap::iterator found = m_registryToURL.add(®istrable->registry(), URLSet()).iterat

[webkit-changes] [164090] trunk

2014-02-13 Thread mrobinson

Title: [164090] trunk








Revision 164090
Author mrobin...@webkit.org
Date 2014-02-13 19:35:13 -0800 (Thu, 13 Feb 2014)


Log Message
[GTK] [CMake] _javascript_Core crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434

Extend a fix for EFL to all ports that use GCC. Also include further fixes
that were applied only to the autotools build.

Reviewed by Gyuyoung Kim.

* Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
as -fno-tree-dce, which is necessary for GTK+.
* Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake
trunk/Source/cmake/OptionsEfl.cmake




Diff

Modified: trunk/ChangeLog (164089 => 164090)

--- trunk/ChangeLog	2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/ChangeLog	2014-02-14 03:35:13 UTC (rev 164090)
@@ -1,3 +1,17 @@
+2014-02-09  Martin Robinson  
+
+[GTK] [CMake] _javascript_Core crashes in JSC::eval
+https://bugs.webkit.org/show_bug.cgi?id=128434
+
+Extend a fix for EFL to all ports that use GCC. Also include further fixes
+that were applied only to the autotools build.
+
+Reviewed by Gyuyoung Kim.
+
+* Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
+as -fno-tree-dce, which is necessary for GTK+.
+* Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.
+
 2014-02-04  Gustavo Noronha Silva  
 
 [GTK][CMake] Generate GObject DOM bindings .symbols files


Modified: trunk/Source/cmake/OptionsCommon.cmake (164089 => 164090)

--- trunk/Source/cmake/OptionsCommon.cmake	2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/Source/cmake/OptionsCommon.cmake	2014-02-14 03:35:13 UTC (rev 164090)
@@ -19,6 +19,12 @@
 set(CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS "${CMAKE_CXX_COMPILER} -E -x c++")
 endif ()
 
+# Push of rbp is needed after JSC JIT uses CStack. See http://wkbug.com/12.
+if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
+set(CMAKE_C_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_C_FLAGS_RELEASE}")
+set(CMAKE_CXX_FLAGS_RELEASE "-fno-omit-frame-pointer -fno-tree-dce ${CMAKE_CXX_FLAGS_RELEASE}")
+endif ()
+
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 
 if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")


Modified: trunk/Source/cmake/OptionsEfl.cmake (164089 => 164090)

--- trunk/Source/cmake/OptionsEfl.cmake	2014-02-14 02:42:10 UTC (rev 164089)
+++ trunk/Source/cmake/OptionsEfl.cmake	2014-02-14 03:35:13 UTC (rev 164090)
@@ -262,13 +262,6 @@
 set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "-Wl,--gc-sections ${CMAKE_SHARED_LINKER_FLAGS_RELEASE}")
 endif ()
 
-# push of rbp is needed after JSC JIT uses CStack
-if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
-set(CMAKE_C_FLAGS_RELEASE "-fno-omit-frame-pointer ${CMAKE_C_FLAGS_RELEASE}")
-set(CMAKE_CXX_FLAGS_RELEASE "-fno-omit-frame-pointer ${CMAKE_CXX_FLAGS_RELEASE}")
-endif ()
-
-
 if (ENABLE_SPELLCHECK)
 find_package(Enchant REQUIRED)
 endif ()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164089] trunk/Source/JavaScriptCore

2014-02-13 Thread mark . lam

Title: [164089] trunk/Source/_javascript_Core








Revision 164089
Author mark@apple.com
Date 2014-02-13 18:42:10 -0800 (Thu, 13 Feb 2014)


Log Message
The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs. Part 2.


Reviewed by Mark Hahnenberg.

toJS() is the wrong cast function to use. We need to use toJSForGC() instead.
Also we need to acquire the JSLock to prevent concurrent accesses to the
Strong handle list.

* API/JSValue.mm:
(JSContainerConvertor::add):
(containerValueToObject):
(ObjcContainerConvertor::add):
(objectToValue):

Modified Paths

trunk/Source/_javascript_Core/API/JSValue.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSValue.mm (164088 => 164089)

--- trunk/Source/_javascript_Core/API/JSValue.mm	2014-02-14 02:36:44 UTC (rev 164088)
+++ trunk/Source/_javascript_Core/API/JSValue.mm	2014-02-14 02:42:10 UTC (rev 164089)
@@ -615,7 +615,7 @@
 void JSContainerConvertor::add(Task task)
 {
 JSC::ExecState* exec = toJS(m_context);
-m_jsValues.append(JSC::Strong(exec->vm(), toJS(exec, task.js)));
+m_jsValues.append(JSC::Strong(exec->vm(), toJSForGC(exec, task.js)));
 m_objectMap.add(task.js, task.objc);
 if (task.type != ContainerNone)
 m_worklist.append(task);
@@ -672,6 +672,7 @@
 static id containerValueToObject(JSGlobalContextRef context, JSContainerConvertor::Task task)
 {
 ASSERT(task.type != ContainerNone);
+JSC::APIEntryShim entryShim(toJS(context));
 JSContainerConvertor convertor(context);
 convertor.add(task);
 ASSERT(!convertor.isWorkListEmpty());
@@ -841,7 +842,7 @@
 void ObjcContainerConvertor::add(ObjcContainerConvertor::Task task)
 {
 JSC::ExecState* exec = toJS(m_context.JSGlobalContextRef);
-m_jsValues.append(JSC::Strong(exec->vm(), toJS(exec, task.js)));
+m_jsValues.append(JSC::Strong(exec->vm(), toJSForGC(exec, task.js)));
 m_objectMap.add(task.objc, task.js);
 if (task.type != ContainerNone)
 m_worklist.append(task);
@@ -921,6 +922,7 @@
 if (task.type == ContainerNone)
 return task.js;
 
+JSC::APIEntryShim entryShim(toJS(contextRef));
 ObjcContainerConvertor convertor(context);
 convertor.add(task);
 ASSERT(!convertor.isWorkListEmpty());


Modified: trunk/Source/_javascript_Core/ChangeLog (164088 => 164089)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:36:44 UTC (rev 164088)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:42:10 UTC (rev 164089)
@@ -1,3 +1,20 @@
+2014-02-13  Mark Lam  
+
+The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs. Part 2.
+
+
+Reviewed by Mark Hahnenberg.
+
+toJS() is the wrong cast function to use. We need to use toJSForGC() instead.
+Also we need to acquire the JSLock to prevent concurrent accesses to the
+Strong handle list.
+
+* API/JSValue.mm:
+(JSContainerConvertor::add):
+(containerValueToObject):
+(ObjcContainerConvertor::add):
+(objectToValue):
+
 2014-02-13  Mark Hahnenberg  
 
 JSManagedValue::dealloc modifies NSMapTable while iterating it






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164088] trunk/Source/JavaScriptCore

2014-02-13 Thread mhahnenberg

Title: [164088] trunk/Source/_javascript_Core








Revision 164088
Author mhahnenb...@apple.com
Date 2014-02-13 18:36:44 -0800 (Thu, 13 Feb 2014)


Log Message
JSManagedValue::dealloc modifies NSMapTable while iterating it
https://bugs.webkit.org/show_bug.cgi?id=128713

Reviewed by Geoffrey Garen.

Having to write a test for this revealed a bug in how addManagedReference:withOwner:
actually notifies JSManagedValues of new owners.

* API/JSManagedValue.mm:
(-[JSManagedValue dealloc]):
* API/JSVirtualMachine.mm:
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
* API/tests/testapi.mm:
(testObjectiveCAPI):

Modified Paths

trunk/Source/_javascript_Core/API/JSManagedValue.mm
trunk/Source/_javascript_Core/API/JSVirtualMachine.mm
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSManagedValue.mm (164087 => 164088)

--- trunk/Source/_javascript_Core/API/JSManagedValue.mm	2014-02-14 02:32:02 UTC (rev 164087)
+++ trunk/Source/_javascript_Core/API/JSManagedValue.mm	2014-02-14 02:36:44 UTC (rev 164088)
@@ -221,11 +221,13 @@
 {
 JSVirtualMachine *virtualMachine = [[[self value] context] virtualMachine];
 if (virtualMachine) {
-for (id owner in [m_owners keyEnumerator]) {
+NSMapTable *copy = [m_owners copy];
+for (id owner in [copy keyEnumerator]) {
 size_t count = reinterpret_cast(NSMapGet(m_owners, owner));
 while (count--)
 [virtualMachine removeManagedReference:self withOwner:owner];
 }
+[copy release];
 }
 
 [self disconnectValue];


Modified: trunk/Source/_javascript_Core/API/JSVirtualMachine.mm (164087 => 164088)

--- trunk/Source/_javascript_Core/API/JSVirtualMachine.mm	2014-02-14 02:32:02 UTC (rev 164087)
+++ trunk/Source/_javascript_Core/API/JSVirtualMachine.mm	2014-02-14 02:36:44 UTC (rev 164088)
@@ -148,6 +148,9 @@
 
 - (void)addManagedReference:(id)object withOwner:(id)owner
 {
+if ([object isKindOfClass:[JSManagedValue class]])
+[object didAddOwner:owner];
+
 object = getInternalObjcObject(object);
 owner = getInternalObjcObject(owner);
 
@@ -166,15 +169,15 @@
 [ownedObjects release];
 }
 
-if ([object isKindOfClass:[JSManagedValue class]])
-[object didAddOwner:owner];
-
 size_t count = reinterpret_cast(NSMapGet(ownedObjects, object));
 NSMapInsert(ownedObjects, object, reinterpret_cast(count + 1));
 }
 
 - (void)removeManagedReference:(id)object withOwner:(id)owner
 {
+if ([object isKindOfClass:[JSManagedValue class]])
+[object didRemoveOwner:owner];
+
 object = getInternalObjcObject(object);
 owner = getInternalObjcObject(owner);
 
@@ -196,9 +199,6 @@
 if (count == 1)
 NSMapRemove(ownedObjects, object);
 
-if ([object isKindOfClass:[JSManagedValue class]])
-[object didRemoveOwner:owner];
-
 if (![ownedObjects count])
 [m_externalObjectGraph removeObjectForKey:owner];
 }


Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (164087 => 164088)

--- trunk/Source/_javascript_Core/API/tests/testapi.mm	2014-02-14 02:32:02 UTC (rev 164087)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm	2014-02-14 02:36:44 UTC (rev 164088)
@@ -539,6 +539,20 @@
 
 @autoreleasepool {
 JSContext *context = [[JSContext alloc] init];
+JSValue *message = [JSValue valueWithObject:@"hello" inContext:context];
+TestObject *rootObject = [TestObject testObject];
+JSCollection *collection = [[JSCollection alloc] init];
+context[@"root"] = rootObject;
+@autoreleasepool {
+JSValue *jsCollection = [JSValue valueWithObject:collection inContext:context];
+JSManagedValue *weakCollection = [JSManagedValue managedValueWithValue:jsCollection andOwner:rootObject];
+[context.virtualMachine addManagedReference:weakCollection withOwner:message];
+JSSynchronousGarbageCollectForDebugging([context JSGlobalContextRef]);
+}
+}
+
+@autoreleasepool {
+JSContext *context = [[JSContext alloc] init];
 __block int result;
 context[@"blockCallback"] = ^(int value){
 result = value;


Modified: trunk/Source/_javascript_Core/ChangeLog (164087 => 164088)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:32:02 UTC (rev 164087)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:36:44 UTC (rev 164088)
@@ -1,3 +1,21 @@
+2014-02-13  Mark Hahnenberg  
+
+JSManagedValue::dealloc modifies NSMapTable while iterating it
+https://bugs.webkit.org/show_bug.cgi?id=128713
+
+Reviewed by Geoffrey Garen.
+
+Having to write a test for this revealed a bug in how addManagedReference:withOwner:
+actually notifies JSManagedValues of new owners.
+
+* API/JSManagedValue.mm:
+

[webkit-changes] [164087] trunk/Source/JavaScriptCore

2014-02-13 Thread fpizlo

Title: [164087] trunk/Source/_javascript_Core








Revision 164087
Author fpi...@apple.com
Date 2014-02-13 18:32:02 -0800 (Thu, 13 Feb 2014)


Log Message
Unreviewed, fix build.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164086 => 164087)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:25:28 UTC (rev 164086)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:32:02 UTC (rev 164087)
@@ -1,3 +1,10 @@
+2014-02-13  Filip Pizlo  
+
+Unreviewed, fix build.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
+
 2014-02-13  Ryosuke Niwa  
 
 Speculative Release build fix after r164077.


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (164086 => 164087)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-14 02:25:28 UTC (rev 164086)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-02-14 02:32:02 UTC (rev 164087)
@@ -1803,7 +1803,7 @@
 
 void compileGetMyArgumentsLength() 
 {
-TypedPointer reg = addressFor(m_node->codeOrigin.stackOffset() + JSStack::ArgumentCount);
+TypedPointer reg = addressFor(m_node->origin.semantic.stackOffset() + JSStack::ArgumentCount);
 setInt32(m_out.add(m_out.load32NonNegative(reg), m_out.constInt32(-1)));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164086] trunk/LayoutTests

2014-02-13 Thread roger_fong

Title: [164086] trunk/LayoutTests








Revision 164086
Author roger_f...@apple.com
Date 2014-02-13 18:25:28 -0800 (Thu, 13 Feb 2014)


Log Message
[Windows] Unreviewed gardening of some timing out tests.
https://bugs.webkit.org/show_bug.cgi?id=128789.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (164085 => 164086)

--- trunk/LayoutTests/ChangeLog	2014-02-14 02:04:51 UTC (rev 164085)
+++ trunk/LayoutTests/ChangeLog	2014-02-14 02:25:28 UTC (rev 164086)
@@ -1,3 +1,10 @@
+2014-02-13  Roger Fong  
+
+[Windows] Unreviewed gardening of some timing out tests.
+https://bugs.webkit.org/show_bug.cgi?id=128789.
+
+* platform/win/TestExpectations:
+
 2014-02-13  Commit Queue  
 
 Unreviewed, rolling out r164073 and r164080.


Modified: trunk/LayoutTests/platform/win/TestExpectations (164085 => 164086)

--- trunk/LayoutTests/platform/win/TestExpectations	2014-02-14 02:04:51 UTC (rev 164085)
+++ trunk/LayoutTests/platform/win/TestExpectations	2014-02-14 02:25:28 UTC (rev 164086)
@@ -2917,3 +2917,15 @@
 webkit.org/b/92749 fast/dom/is-protocol-handler-registered.html [ Skip ] 
 
 webkit.org/b/128726 [ Release ] js/regress/emscripten-memops.html [ Failure ]
+
+# https://bugs.webkit.org/show_bug.cgi?id=128789
+js/regress/Int16Array-bubble-sort-with-byteLength.html
+js/regress/Int16Array-bubble-sort.html
+js/regress/chain-custom-getter.html
+js/regress/chain-getter-access.html
+js/regress/marsaglia.html
+js/regress/proto-custom-getter.html
+js/regress/proto-getter-access.html
+js/regress/simple-custom-getter.html
+js/regress/simple-getter-access.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164085] trunk/Source/JavaScriptCore

2014-02-13 Thread rniwa

Title: [164085] trunk/Source/_javascript_Core








Revision 164085
Author rn...@webkit.org
Date 2014-02-13 18:04:51 -0800 (Thu, 13 Feb 2014)


Log Message
Speculative Release build fix after r164077.

* API/JSValue.mm:

Modified Paths

trunk/Source/_javascript_Core/API/JSValue.mm
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSValue.mm (164084 => 164085)

--- trunk/Source/_javascript_Core/API/JSValue.mm	2014-02-14 01:59:29 UTC (rev 164084)
+++ trunk/Source/_javascript_Core/API/JSValue.mm	2014-02-14 02:04:51 UTC (rev 164085)
@@ -38,6 +38,7 @@
 #import "JSCInlines.h"
 #import "JSCJSValue.h"
 #import "Strong.h"
+#import "StrongInlines.h"
 #import 
 #import 
 #import 


Modified: trunk/Source/_javascript_Core/ChangeLog (164084 => 164085)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-14 01:59:29 UTC (rev 164084)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-14 02:04:51 UTC (rev 164085)
@@ -1,3 +1,9 @@
+2014-02-13  Ryosuke Niwa  
+
+Speculative Release build fix after r164077.
+
+* API/JSValue.mm:
+
 2014-02-13  Mark Lam  
 
 The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164084] trunk/Source/WebCore

2014-02-13 Thread mmaxfield

Title: [164084] trunk/Source/WebCore








Revision 164084
Author mmaxfi...@apple.com
Date 2014-02-13 17:59:29 -0800 (Thu, 13 Feb 2014)


Log Message
Remove position:sticky runtime flag
https://bugs.webkit.org/show_bug.cgi?id=128774

Reviewed by Simon Fraser.

Rollout of r128663

No new tests are necessary because there is no behavior change.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSParserMode.h:
* dom/Document.cpp:
* dom/Document.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParserMode.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164083 => 164084)

--- trunk/Source/WebCore/ChangeLog	2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/ChangeLog	2014-02-14 01:59:29 UTC (rev 164084)
@@ -1,3 +1,25 @@
+2014-02-13  Myles C. Maxfield  
+
+Remove position:sticky runtime flag
+https://bugs.webkit.org/show_bug.cgi?id=128774
+
+Reviewed by Simon Fraser.
+
+Rollout of r128663
+
+No new tests are necessary because there is no behavior change.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+(WebCore::operator==):
+(WebCore::isValidKeywordPropertyAndValue):
+* css/CSSParserMode.h:
+* dom/Document.cpp:
+* dom/Document.h:
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+
 2014-02-04  Gustavo Noronha Silva  
 
 [GTK][CMake] Generate GObject DOM bindings .symbols files


Modified: trunk/Source/WebCore/css/CSSParser.cpp (164083 => 164084)

--- trunk/Source/WebCore/css/CSSParser.cpp	2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2014-02-14 01:59:29 UTC (rev 164084)
@@ -245,7 +245,6 @@
 : baseURL(baseURL)
 , mode(mode)
 , isHTMLDocument(false)
-, isCSSStickyPositionEnabled(false)
 , isCSSRegionsEnabled(false)
 , isCSSCompositingEnabled(false)
 , isCSSGridLayoutEnabled(false)
@@ -266,7 +265,6 @@
 , charset(charset)
 , mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
 , isHTMLDocument(document.isHTMLDocument())
-, isCSSStickyPositionEnabled(document.cssStickyPositionEnabled())
 , isCSSRegionsEnabled(document.cssRegionsEnabled())
 , isCSSCompositingEnabled(document.cssCompositingEnabled())
 , isCSSGridLayoutEnabled(document.cssGridLayoutEnabled())
@@ -288,7 +286,6 @@
 && a.charset == b.charset
 && a.mode == b.mode
 && a.isHTMLDocument == b.isHTMLDocument
-&& a.isCSSStickyPositionEnabled == b.isCSSStickyPositionEnabled
 && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
 && a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
 && a.isCSSGridLayoutEnabled == b.isCSSGridLayoutEnabled
@@ -751,7 +748,7 @@
 case CSSPropertyPosition: // static | relative | absolute | fixed | sticky | inherit
 if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed
 #if ENABLE(CSS_STICKY_POSITION)
-|| (parserContext.isCSSStickyPositionEnabled && valueID == CSSValueWebkitSticky)
+|| valueID == CSSValueWebkitSticky
 #endif
 )
 return true;


Modified: trunk/Source/WebCore/css/CSSParserMode.h (164083 => 164084)

--- trunk/Source/WebCore/css/CSSParserMode.h	2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/css/CSSParserMode.h	2014-02-14 01:59:29 UTC (rev 164084)
@@ -64,7 +64,6 @@
 String charset;
 CSSParserMode mode;
 bool isHTMLDocument;
-bool isCSSStickyPositionEnabled;
 bool isCSSRegionsEnabled;
 bool isCSSCompositingEnabled;
 bool isCSSGridLayoutEnabled;


Modified: trunk/Source/WebCore/dom/Document.cpp (164083 => 164084)

--- trunk/Source/WebCore/dom/Document.cpp	2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.cpp	2014-02-14 01:59:29 UTC (rev 164084)
@@ -1082,11 +1082,6 @@
 return settings() && settings()->regionBasedColumnsEnabled(); 
 }
 
-bool Document::cssStickyPositionEnabled() const
-{
-return settings() && settings()->cssStickyPositionEnabled(); 
-}
-
 bool Document::cssRegionsEnabled() const
 {
 return RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled(); 


Modified: trunk/Source/WebCore/dom/Document.h (164083 => 164084)

--- trunk/Source/WebCore/dom/Document.h	2014-02-14 01:53:43 UTC (rev 164083)
+++ trunk/Source/WebCore/dom/Document.h	2014-02-14 01:59:29 UTC (rev 164084)
@@ -394,7 +394,6 @@
 PassRefPtr createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);

[webkit-changes] [164083] trunk/Source/WebKit2

2014-02-13 Thread andersca

Title: [164083] trunk/Source/WebKit2








Revision 164083
Author ander...@apple.com
Date 2014-02-13 17:53:43 -0800 (Thu, 13 Feb 2014)


Log Message
Add -[WKWebView stopLoading:]
https://bugs.webkit.org/show_bug.cgi?id=128784

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164082 => 164083)

--- trunk/Source/WebKit2/ChangeLog	2014-02-14 01:49:24 UTC (rev 164082)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-14 01:53:43 UTC (rev 164083)
@@ -1,5 +1,16 @@
 2014-02-13  Anders Carlsson  
 
+Add -[WKWebView stopLoading:]
+https://bugs.webkit.org/show_bug.cgi?id=128784
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView stopLoading:]):
+
+2014-02-13  Anders Carlsson  
+
 Add -[WKWebView activeURL]
 https://bugs.webkit.org/show_bug.cgi?id=128777
 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (164082 => 164083)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-14 01:49:24 UTC (rev 164082)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-14 01:53:43 UTC (rev 164083)
@@ -86,6 +86,8 @@
  */
 - (WKNavigation *)goToBackForwardListItem:(WKBackForwardListItem *)item;
 
+- (IBAction)stopLoading:(id)sender;
+
 @property (nonatomic, readonly) NSString *title;
 
 /*! @abstract The active URL. @link WKWebView @/link is KVO-compliant for this property.


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164082 => 164083)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-14 01:49:24 UTC (rev 164082)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-14 01:53:43 UTC (rev 164083)
@@ -187,6 +187,11 @@
 return nil;
 }
 
+- (IBAction)stopLoading:(id)sender
+{
+_page->stopLoading();
+}
+
 - (NSString *)title
 {
 return _page->pageLoadState().title();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164082] trunk/Tools

2014-02-13 Thread dfarler

Title: [164082] trunk/Tools








Revision 164082
Author dfar...@apple.com
Date 2014-02-13 17:49:24 -0800 (Thu, 13 Feb 2014)


Log Message
DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator
https://bugs.webkit.org/show_bug.cgi?id=128780

Reviewed by Simon Fraser.

* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
Use `xcrun -find clang` instead of `xcrun --sdk $ENV{SDKROOT} -find clang,
which will pick up SDKROOT=iphonesimulator from building the Xcode aggregate target.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL




Diff

Modified: trunk/Tools/ChangeLog (164081 => 164082)

--- trunk/Tools/ChangeLog	2014-02-14 01:44:07 UTC (rev 164081)
+++ trunk/Tools/ChangeLog	2014-02-14 01:49:24 UTC (rev 164082)
@@ -1,3 +1,14 @@
+2014-02-13  David Farler  
+
+DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator
+https://bugs.webkit.org/show_bug.cgi?id=128780
+
+Reviewed by Simon Fraser.
+
+* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
+Use `xcrun -find clang` instead of `xcrun --sdk $ENV{SDKROOT} -find clang,
+which will pick up SDKROOT=iphonesimulator from building the Xcode aggregate target.
+
 2014-02-13  Commit Queue  
 
 Unreviewed, rolling out r164073 and r164080.


Modified: trunk/Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL (164081 => 164082)

--- trunk/Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL	2014-02-14 01:44:07 UTC (rev 164081)
+++ trunk/Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL	2014-02-14 01:49:24 UTC (rev 164082)
@@ -28,7 +28,7 @@
 use Config;
 use ExtUtils::MakeMaker;
 
-chomp(my $cc = my $ld = `xcrun -sdk $ENV{SDKROOT} -find clang`);
+chomp(my $cc = my $ld = `xcrun -find clang`);
 
 # Remove -arch flags (especially "-arch ppc") from linker flags.
 my $archflags = join(" ", map { ("-arch", $_) } split(" ", $ENV{ARCHS})) . " ";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164080] trunk/Tools

2014-02-13 Thread bfulgham

Title: [164080] trunk/Tools








Revision 164080
Author bfulg...@apple.com
Date 2014-02-13 17:30:10 -0800 (Thu, 13 Feb 2014)


Log Message
Unreviewed build fix for Mountain Lion.

* DumpRenderTree/mac/EventSendingController.mm: Provide definition
for kCGScrollWheelEventScrollPhase if it isn't found in the
system headers.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/EventSendingController.mm




Diff

Modified: trunk/Tools/ChangeLog (164079 => 164080)

--- trunk/Tools/ChangeLog	2014-02-14 01:24:09 UTC (rev 164079)
+++ trunk/Tools/ChangeLog	2014-02-14 01:30:10 UTC (rev 164080)
@@ -1,3 +1,11 @@
+2014-02-13  Brent Fulgham  
+
+Unreviewed build fix for Mountain Lion.
+
+* DumpRenderTree/mac/EventSendingController.mm: Provide definition
+for kCGScrollWheelEventScrollPhase if it isn't found in the
+system headers.
+
 2014-02-04  Gustavo Noronha Silva  
 
 [GTK][CMake] Generate GObject DOM bindings .symbols files


Modified: trunk/Tools/DumpRenderTree/mac/EventSendingController.mm (164079 => 164080)

--- trunk/Tools/DumpRenderTree/mac/EventSendingController.mm	2014-02-14 01:24:09 UTC (rev 164079)
+++ trunk/Tools/DumpRenderTree/mac/EventSendingController.mm	2014-02-14 01:30:10 UTC (rev 164080)
@@ -703,6 +703,10 @@
 [self mouseScrollByX:x andY:y continuously:NO];
 }
 
+#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 1090
+const uint32_t kCGScrollWheelEventMomentumPhase = 123;
+#endif
+
 - (void)mouseScrollByX:(int)x andY:(int)y withWheel:(NSString*)phaseName andMomentumPhases:(NSString*)momentumName
 {
 #if !PLATFORM(IOS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164079] trunk/Source/WebKit2

2014-02-13 Thread andersca

Title: [164079] trunk/Source/WebKit2








Revision 164079
Author ander...@apple.com
Date 2014-02-13 17:24:09 -0800 (Thu, 13 Feb 2014)


Log Message
Add -[WKWebView activeURL]
https://bugs.webkit.org/show_bug.cgi?id=128777

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView activeURL]):
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeActiveURL):
(WebKit::NavigationState::didChangeActiveURL):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164078 => 164079)

--- trunk/Source/WebKit2/ChangeLog	2014-02-14 01:17:14 UTC (rev 164078)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-14 01:24:09 UTC (rev 164079)
@@ -1,5 +1,19 @@
 2014-02-13  Anders Carlsson  
 
+Add -[WKWebView activeURL]
+https://bugs.webkit.org/show_bug.cgi?id=128777
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView activeURL]):
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::willChangeActiveURL):
+(WebKit::NavigationState::didChangeActiveURL):
+
+2014-02-13  Anders Carlsson  
+
 Add -[WKWebView goToBackForwardListItem:]
 https://bugs.webkit.org/show_bug.cgi?id=128773
 


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (164078 => 164079)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-14 01:17:14 UTC (rev 164078)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-02-14 01:24:09 UTC (rev 164079)
@@ -88,6 +88,11 @@
 
 @property (nonatomic, readonly) NSString *title;
 
+/*! @abstract The active URL. @link WKWebView @/link is KVO-compliant for this property.
+ @discussion This is the URL that should be reflected in the user interface.
+ */
+@property (nonatomic, readonly) NSURL *activeURL;
+
 /*! @abstract Whether the view is loading content. @link WKWebView @/link is KVO-compliant for this
  property. */
 @property (nonatomic, readonly, getter=isLoading) BOOL loading;


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (164078 => 164079)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-14 01:17:14 UTC (rev 164078)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-02-14 01:24:09 UTC (rev 164079)
@@ -29,6 +29,7 @@
 #if WK_API_ENABLED
 
 #import "NavigationState.h"
+#import "RemoteLayerTreeTransaction.h"
 #import "RemoteObjectRegistry.h"
 #import "RemoteObjectRegistryMessages.h"
 #import "WKBackForwardListInternal.h"
@@ -43,7 +44,7 @@
 #import "WebBackForwardList.h"
 #import "WebPageProxy.h"
 #import "WebProcessProxy.h"
-#import 
+#import "WKNSURLExtras.h"
 #import 
 
 #if PLATFORM(IOS)
@@ -191,6 +192,11 @@
 return _page->pageLoadState().title();
 }
 
+- (NSURL *)activeURL
+{
+return [NSURL _web_URLWithWTFString:_page->pageLoadState().activeURL()];
+}
+
 - (BOOL)isLoading
 {
 return _page->pageLoadState().isLoading();


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (164078 => 164079)

--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-02-14 01:17:14 UTC (rev 164078)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-02-14 01:24:09 UTC (rev 164079)
@@ -394,10 +394,12 @@
 
 void NavigationState::willChangeActiveURL()
 {
+[m_webView willChangeValueForKey:@"activeURL"];
 }
 
 void NavigationState::didChangeActiveURL()
 {
+[m_webView didChangeValueForKey:@"activeURL"];
 }
 
 void NavigationState::willChangeHasOnlySecureContent()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164078] trunk/PerformanceTests

2014-02-13 Thread zoltan

Title: [164078] trunk/PerformanceTests








Revision 164078
Author zol...@webkit.org
Date 2014-02-13 17:17:14 -0800 (Thu, 13 Feb 2014)


Log Message
[CSS Shapes] Add performance test for complex polygon with shape-margin
https://bugs.webkit.org/show_bug.cgi?id=128769

Reviewed by Ryosuke Niwa.

This patch modifies the logic of createShapeOutsideTest to accept multiple
CSS properties from the test. The patch adds performance test for complex
polygon shape (self intersecting at multiple places) case, moreover we
apply shape-margin on the polygon also.

* Layout/Shapes/ShapeOutsideContentBox.html:
* Layout/Shapes/ShapeOutsideInset.html:
* Layout/Shapes/ShapeOutsidePolygonWithMargin.html: Added.
* Layout/Shapes/ShapeOutsideRaster.html:
* Layout/Shapes/ShapeOutsideSimplePolygon.html:
* Layout/Shapes/resources/shapes.js:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html
trunk/PerformanceTests/Layout/Shapes/ShapeOutsideInset.html
trunk/PerformanceTests/Layout/Shapes/ShapeOutsideRaster.html
trunk/PerformanceTests/Layout/Shapes/ShapeOutsideSimplePolygon.html
trunk/PerformanceTests/Layout/Shapes/resources/shapes.js


Added Paths

trunk/PerformanceTests/Layout/Shapes/ShapeOutsidePolygonWithMargin.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (164077 => 164078)

--- trunk/PerformanceTests/ChangeLog	2014-02-14 01:06:53 UTC (rev 164077)
+++ trunk/PerformanceTests/ChangeLog	2014-02-14 01:17:14 UTC (rev 164078)
@@ -1,5 +1,24 @@
 2014-02-13  Zoltan Horvath  
 
+[CSS Shapes] Add performance test for complex polygon with shape-margin
+https://bugs.webkit.org/show_bug.cgi?id=128769
+
+Reviewed by Ryosuke Niwa.
+
+This patch modifies the logic of createShapeOutsideTest to accept multiple
+CSS properties from the test. The patch adds performance test for complex
+polygon shape (self intersecting at multiple places) case, moreover we
+apply shape-margin on the polygon also.
+
+* Layout/Shapes/ShapeOutsideContentBox.html:
+* Layout/Shapes/ShapeOutsideInset.html:
+* Layout/Shapes/ShapeOutsidePolygonWithMargin.html: Added.
+* Layout/Shapes/ShapeOutsideRaster.html:
+* Layout/Shapes/ShapeOutsideSimplePolygon.html:
+* Layout/Shapes/resources/shapes.js:
+
+2014-02-13  Zoltan Horvath  
+
 [CSS Shapes] Add performance test for raster shape
 https://bugs.webkit.org/show_bug.cgi?id=128746
 


Modified: trunk/PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html (164077 => 164078)

--- trunk/PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html	2014-02-14 01:06:53 UTC (rev 164077)
+++ trunk/PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html	2014-02-14 01:17:14 UTC (rev 164078)
@@ -8,8 +8,12 @@
 
 
 
-var shape = "content-box";
-PerfTestRunner.measureTime(createShapeOutsideTest("200px", "200px", shape, 1000));
+var properties = {
+width: "200px",
+height: "200px",
+webkitShapeOutside: "content-box"
+};
+PerfTestRunner.measureTime(createShapeOutsideTest(properties, 1000));
 
 
 


Modified: trunk/PerformanceTests/Layout/Shapes/ShapeOutsideInset.html (164077 => 164078)

--- trunk/PerformanceTests/Layout/Shapes/ShapeOutsideInset.html	2014-02-14 01:06:53 UTC (rev 164077)
+++ trunk/PerformanceTests/Layout/Shapes/ShapeOutsideInset.html	2014-02-14 01:17:14 UTC (rev 164078)
@@ -8,8 +8,12 @@
 
 
 
-var shape = "inset(10px)";
-PerfTestRunner.measureTime(createShapeOutsideTest("200px", "200px", shape, 1000));
+var properties = {
+width: "200px",
+height: "200px",
+webkitShapeOutside: "inset(10px)"
+};
+PerfTestRunner.measureTime(createShapeOutsideTest(properties, 1000));
 
 
 


Added: trunk/PerformanceTests/Layout/Shapes/ShapeOutsidePolygonWithMargin.html (0 => 164078)

--- trunk/PerformanceTests/Layout/Shapes/ShapeOutsidePolygonWithMargin.html	(rev 0)
+++ trunk/PerformanceTests/Layout/Shapes/ShapeOutsidePolygonWithMargin.html	2014-02-14 01:17:14 UTC (rev 164078)
@@ -0,0 +1,20 @@
+
+
+
+
+
+
+
+