[webkit-changes] [259847] trunk/Source/WebKit
Title: [259847] trunk/Source/WebKit
Revision 259847
Author ddkil...@apple.com
Date 2020-04-09 22:48:35 -0700 (Thu, 09 Apr 2020)
Log Message
Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC
Reviewed by Alex Christensen.
* Platform/IPC/ArgumentCoder.h:
* Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
(IPC::ArgumentCoder::decode):
* Platform/IPC/ArgumentCoders.h:
(IPC::SimpleArgumentCoder::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::TupleDecoderImpl::decode):
(IPC::TupleDecoderImpl::decode):
(IPC::TupleDecoder::decode):
(IPC::TupleDecoder<0>::decode):
(IPC::VariantCoder::decode):
* Platform/IPC/Attachment.h:
* Platform/IPC/DataReference.h:
* Platform/IPC/Decoder.h:
(IPC::Decoder::decodeEnum):
* Platform/IPC/FormDataReference.h:
(IPC::FormDataReference::decode):
* Platform/IPC/ImageDataReference.h:
(IPC::ImageDataReference::decode):
* Platform/IPC/SharedBufferDataReference.h:
(IPC::SharedBufferDataReference::decode):
* Platform/IPC/StringReference.h:
* Platform/IPC/cocoa/MachPort.h:
(IPC::MachPort::decode):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h
trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp
trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h
trunk/Source/WebKit/Platform/IPC/Attachment.h
trunk/Source/WebKit/Platform/IPC/DataReference.h
trunk/Source/WebKit/Platform/IPC/Decoder.h
trunk/Source/WebKit/Platform/IPC/FormDataReference.h
trunk/Source/WebKit/Platform/IPC/ImageDataReference.h
trunk/Source/WebKit/Platform/IPC/SharedBufferDataReference.h
trunk/Source/WebKit/Platform/IPC/StringReference.h
trunk/Source/WebKit/Platform/IPC/cocoa/MachPort.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259846 => 259847)
--- trunk/Source/WebKit/ChangeLog 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/ChangeLog 2020-04-10 05:48:35 UTC (rev 259847)
@@ -1,3 +1,43 @@
+2020-04-09 David Kilzer
+
+Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC
+
+
+Reviewed by Alex Christensen.
+
+* Platform/IPC/ArgumentCoder.h:
+* Platform/IPC/ArgumentCoders.cpp:
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+(IPC::ArgumentCoder::decode):
+* Platform/IPC/ArgumentCoders.h:
+(IPC::SimpleArgumentCoder::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::TupleDecoderImpl::decode):
+(IPC::TupleDecoderImpl::decode):
+(IPC::TupleDecoder::decode):
+(IPC::TupleDecoder<0>::decode):
+(IPC::VariantCoder::decode):
+* Platform/IPC/Attachment.h:
+* Platform/IPC/DataReference.h:
+* Platform/IPC/Decoder.h:
+(IPC::Decoder::decodeEnum):
+* Platform/IPC/FormDataReference.h:
+(IPC::FormDataReference::decode):
+* Platform/IPC/ImageDataReference.h:
+(IPC::ImageDataReference::decode):
+* Platform/IPC/SharedBufferDataReference.h:
+(IPC::SharedBufferDataReference::decode):
+* Platform/IPC/StringReference.h:
+* Platform/IPC/cocoa/MachPort.h:
+(IPC::MachPort::decode):
+
2020-04-09 Alex Christensen
IPC serialization of enums should serialize std::underlying_type instead of uint64_t
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoder.h 2020-04-10 05:48:35 UTC (rev 259847)
@@ -99,13 +99,13 @@
t.encode(encoder);
}
-template::argumentCoderValue>* = nullptr>
+template::argumentCoderValue>* = nullptr> WARN_UNUSED_RETURN
static bool decode(Decoder& decoder, U& u)
{
return U::decode(decoder, u);
}
-template::argumentCoderValue>* = nullptr>
+template::argumentCoderValue>* = nullptr> WARN_UNUSED_RETURN
static Optional decode(Decoder& decoder)
{
return U::decode(decoder);
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp (259846 => 259847)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp 2020-04-10 05:22:16 UTC (rev 259846)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoders.cpp 2020-04-10 05:48:35 UTC (rev 259847)
@@ -37,7 +37,7 @@
encoder << time.secondsSinceEpoch().value();
}
-bool ArgumentCoder::decode(Decoder& decoder, WallTime& time)
+WARN_UNUSED_RETURN bool ArgumentCoder::decode(Decoder& decoder, WallTime& time)
{
double value;
if
[webkit-changes] [259846] trunk/Source/WebCore
Title: [259846] trunk/Source/WebCore Revision 259846 Author cathiec...@igalia.com Date 2020-04-09 22:22:16 -0700 (Thu, 09 Apr 2020) Log Message Fix up code style for scroll animation https://bugs.webkit.org/show_bug.cgi?id=210171 Reviewed by Simon Fraser. 1. Use AnimatedScroll instead of bool to indicate animated or not. 2. Remove parameter ScrollRectToVisibleOptions, the autoscroll status is available from EventHandler. 3. In order to keep consistent, use RenderLayer::setScrollPosition instead of RenderLayer::scrollToPosition. 4. Add AnimatedScroll parameter to ScrollView::setContentsScrollPosition, then the scroll animation can be dealt in FrameView::setScrollPosition. 5. In ScrollView::setScrollPosition, the scroll animation should be cancled before return. * dom/Element.cpp: Use AnimatedScroll instead of bool. (WebCore::Element::scrollTo): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): * page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo const): No need to call scrollToOffsetWithAnimation here. * page/FrameView.cpp: (WebCore::FrameView::setScrollPosition): * page/FrameView.h: * platform/ScrollTypes.h: Add AnimatedScroll. * platform/ScrollView.cpp: (WebCore::ScrollView::setContentsScrollPosition): Add parameter AnimatedScroll. (WebCore::ScrollView::setScrollPosition): Cancel the scroll animation before return. * platform/ScrollView.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::setScrollPosition): * rendering/RenderBox.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToXPosition): (WebCore::RenderLayer::scrollToYPosition): (WebCore::RenderLayer::setScrollPosition): (WebCore::RenderLayer::scrollRectToVisible): Remove AutoscrollStatus. (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::scrollToPosition): Deleted. Use setScrollPosition instead. * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::setScrollTop): * rendering/RenderListBox.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): * rendering/RenderTextControlSingleLine.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/ScrollTypes.h trunk/Source/WebCore/platform/ScrollView.cpp trunk/Source/WebCore/platform/ScrollView.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderListBox.cpp trunk/Source/WebCore/rendering/RenderListBox.h trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h Diff Modified: trunk/Source/WebCore/ChangeLog (259845 => 259846) --- trunk/Source/WebCore/ChangeLog 2020-04-10 04:53:55 UTC (rev 259845) +++ trunk/Source/WebCore/ChangeLog 2020-04-10 05:22:16 UTC (rev 259846) @@ -1,3 +1,53 @@ +2020-04-09 Cathie Chen + +Fix up code style for scroll animation +https://bugs.webkit.org/show_bug.cgi?id=210171 + +Reviewed by Simon Fraser. + +1. Use AnimatedScroll instead of bool to indicate animated or not. +2. Remove parameter ScrollRectToVisibleOptions, the autoscroll status is available from EventHandler. +3. In order to keep consistent, use RenderLayer::setScrollPosition instead of RenderLayer::scrollToPosition. +4. Add AnimatedScroll parameter to ScrollView::setContentsScrollPosition, then the scroll animation +can be dealt in FrameView::setScrollPosition. +5. In ScrollView::setScrollPosition, the scroll animation should be cancled before return. + +* dom/Element.cpp: Use AnimatedScroll instead of bool. +(WebCore::Element::scrollTo): +(WebCore::Element::setScrollLeft): +(WebCore::Element::setScrollTop): +* page/DOMWindow.cpp: +(WebCore::DOMWindow::scrollTo const): No need to call scrollToOffsetWithAnimation here. +* page/FrameView.cpp: +(WebCore::FrameView::setScrollPosition): +* page/FrameView.h: +* platform/ScrollTypes.h: Add AnimatedScroll. +* platform/ScrollView.cpp: +(WebCore::ScrollView::setContentsScrollPosition): Add parameter AnimatedScroll. +(WebCore::ScrollView::setScrollPosition): Cancel the scroll animation before return. +* platform/ScrollView.h: +* rendering/RenderBox.cpp: +(WebCore::RenderBox::setScrollLeft): +(WebCore::RenderBox::setScrollTop): +(WebCore::RenderBox::setScrollPosition): +* rendering/RenderBox.h: +* rendering/RenderLayer.cpp: +
[webkit-changes] [259845] trunk/Source
Title: [259845] trunk/Source Revision 259845 Author commit-qu...@webkit.org Date 2020-04-09 21:53:55 -0700 (Thu, 09 Apr 2020) Log Message IPC serialization of enums should serialize std::underlying_type instead of uint64_t https://bugs.webkit.org/show_bug.cgi?id=210228 Patch by Alex Christensen on 2020-04-09 Reviewed by Chris Dumez and Darin Adler. Source/WebCore: No change in behavior, other than less memory and time spent in IPC code. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextStateChange::dump const): * platform/graphics/GraphicsContext.h: * platform/graphics/ca/PlatformCALayer.cpp: (WebCore::PlatformCALayer::drawRepaintIndicator): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformTextDrawingMode): * platform/graphics/cocoa/FontCascadeCocoa.mm: (WebCore::shouldUseLetterpressEffect): (WebCore::FontCascade::drawGlyphs): * platform/mock/MockRealtimeVideoSource.cpp: (WebCore::MockRealtimeVideoSource::drawText): * rendering/TextPaintStyle.cpp: (WebCore::updateGraphicsContext): * rendering/TextPainter.cpp: (WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded): * rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource): * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): * rendering/svg/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource): Source/WebKit: * Platform/IPC/Decoder.h: (IPC::Decoder::decode): (IPC::Decoder::operator>>): (IPC::Decoder::decodeEnum): * Platform/IPC/Encoder.h: * Shared/cf/ArgumentCodersCF.cpp: (IPC::encode): (IPC::decode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h trunk/Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp trunk/Source/WebCore/platform/graphics/win/Direct2DOperations.cpp trunk/Source/WebCore/platform/graphics/win/FontCGWin.cpp trunk/Source/WebCore/platform/graphics/win/FontCascadeDirect2D.cpp trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp trunk/Source/WebCore/rendering/TextPaintStyle.cpp trunk/Source/WebCore/rendering/TextPainter.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/IPC/Decoder.h trunk/Source/WebKit/Platform/IPC/Encoder.h trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (259844 => 259845) --- trunk/Source/WebCore/ChangeLog 2020-04-10 03:39:58 UTC (rev 259844) +++ trunk/Source/WebCore/ChangeLog 2020-04-10 04:53:55 UTC (rev 259845) @@ -1,3 +1,37 @@ +2020-04-09 Alex Christensen + +IPC serialization of enums should serialize std::underlying_type instead of uint64_t +https://bugs.webkit.org/show_bug.cgi?id=210228 + +Reviewed by Chris Dumez and Darin Adler. + +No change in behavior, other than less memory and time spent in IPC code. + +* html/canvas/CanvasRenderingContext2D.cpp: +(WebCore::CanvasRenderingContext2D::drawTextInternal): +* platform/graphics/GraphicsContext.cpp: +(WebCore::GraphicsContextStateChange::dump const): +* platform/graphics/GraphicsContext.h: +* platform/graphics/ca/PlatformCALayer.cpp: +(WebCore::PlatformCALayer::drawRepaintIndicator): +* platform/graphics/cg/GraphicsContextCG.cpp: +(WebCore::GraphicsContext::setPlatformTextDrawingMode): +* platform/graphics/cocoa/FontCascadeCocoa.mm: +(WebCore::shouldUseLetterpressEffect): +(WebCore::FontCascade::drawGlyphs): +* platform/mock/MockRealtimeVideoSource.cpp: +(WebCore::MockRealtimeVideoSource::drawText): +* rendering/TextPaintStyle.cpp: +(WebCore::updateGraphicsContext): +* rendering/TextPainter.cpp: +(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded): +* rendering/svg/RenderSVGResourceGradient.cpp: +(WebCore::RenderSVGResourceGradient::applyResource): +* rendering/svg/RenderSVGResourcePattern.cpp: +(WebCore::RenderSVGResourcePattern::applyResource): +* rendering/svg/RenderSVGResourceSolidColor.cpp: +(WebCore::RenderSVGResourceSolidColor::applyResource): + 2020-04-08 Darin Adler
[webkit-changes] [259844] trunk/LayoutTests
Title: [259844] trunk/LayoutTests
Revision 259844
Author cathiec...@igalia.com
Date 2020-04-09 20:39:58 -0700 (Thu, 09 Apr 2020)
Log Message
Import test for programmatic scrolling scrollend event
https://bugs.webkit.org/show_bug.cgi?id=210281
Reviewed by Frédéric Wang.
LayoutTests/imported/w3c:
Import test cases.
* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt: Added.
* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html: Added.
* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView-expected.txt: Added.
* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView.html: Added.
* web-platform-tests/dom/events/scrolling/w3c-import.log:
LayoutTests:
* tests-options.json:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/w3c-import.log
trunk/LayoutTests/tests-options.json
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259843 => 259844)
--- trunk/LayoutTests/ChangeLog 2020-04-10 02:11:30 UTC (rev 259843)
+++ trunk/LayoutTests/ChangeLog 2020-04-10 03:39:58 UTC (rev 259844)
@@ -1,3 +1,12 @@
+2020-04-09 Cathie Chen
+
+Import test for programmatic scrolling scrollend event
+https://bugs.webkit.org/show_bug.cgi?id=210281
+
+Reviewed by Frédéric Wang.
+
+* tests-options.json:
+
2020-04-09 Daniel Bates
[iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (259843 => 259844)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-04-10 02:11:30 UTC (rev 259843)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-04-10 03:39:58 UTC (rev 259844)
@@ -1,3 +1,18 @@
+2020-04-09 Cathie Chen
+
+Import test for programmatic scrolling scrollend event
+https://bugs.webkit.org/show_bug.cgi?id=210281
+
+Reviewed by Frédéric Wang.
+
+Import test cases.
+
+* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt: Added.
+* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html: Added.
+* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView-expected.txt: Added.
+* web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView.html: Added.
+* web-platform-tests/dom/events/scrolling/w3c-import.log:
+
2020-04-09 Yusuke Suzuki
[JSC] ModuleEnvironment do not have JSGlobalLexicalEnvironment as its upper scope
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt (0 => 259844)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt 2020-04-10 03:39:58 UTC (rev 259844)
@@ -0,0 +1,4 @@
+
+FAIL Tests scrollend event for calling scroll functions. promise_test: Unhandled rejection with value: "DIV.scrollTo did not receive scrollend event."
+FAIL Tests scrollend event for changing scroll attributes. promise_test: Unhandled rejection with value: "DIV.scrollTop did not receive scrollend event."
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html (0 => 259844)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html 2020-04-10 03:39:58 UTC (rev 259844)
@@ -0,0 +1,134 @@
+
+
+
+html {
+ height: 3000px;
+ width: 3000px;
+}
+#targetDiv {
+ width: 200px;
+ height: 200px;
+ overflow: scroll;
+}
+
+#innerDiv {
+ width: 400px;
+ height: 400px;
+}
+
+
+
+
+
+
+
+
+