[webkit-changes] [WebKit/WebKit] 8e655f: [PlayStation] Add libpas implementation which don'...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e655f85359dd1ef174c38b09e5b5cab458c74b3 https://github.com/WebKit/WebKit/commit/8e655f85359dd1ef174c38b09e5b5cab458c74b3 Author: Basuke Suzuki Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M Source/bmalloc/PlatformPlayStation.cmake M Source/bmalloc/libpas/src/libpas/pas_compact_heap_reservation.c Log Message: --- [PlayStation] Add libpas implementation which don't map huge vss region. https://bugs.webkit.org/show_bug.cgi?id=274234 Reviewed by Yusuke Suzuki. libpas allocate memory region called `compact heap reservation` in its very early stage of its life cycle. The area is used by libpas's management object to achieve several heaps managed by libpas system. The point is that they never been deallocated and even more, they never been decommitted. So only action to the memory region is allocation. This means that we don't need to patch every mmap usage with vss library but only this usage. Much simpler. This reservation heap is designed for mmpa's behavior called *demand paging*, that the kernel never assign physical memory to the page until actual write is happened. So the heap is as is from the beginning to the end without any further memory calls such as madvise or munmap. But when some are is allowed to be used for some object, the first write to that page will be used to assign physical memory to that region. This is smart but not good for our platform. We need precise reserve / commit management. So in this PR, we add some code in `pas_compact_heap_reservation_try_allocate()` to switch current implementation and ours and manage commit when region is actually allocated. Compact heap reservation is used from lower address to higher address by order or request. They don't care page boundary when the region is used. Just the requested alignment is cared. For instance, say the request is coming like following order: - 84 bytes with 1 byte alignment - 64 bytes with 16 bytes alignment - 1M bytes with 1M bytes alignment then allocation and unused padding is like this: | request 1 | padding | request 2 | padding | request 3 | ... | 84 bytes| 12 | 64 bytes | 1,048,416 | 1M bytes | | 1 byte alin | bytes | 16 bytes align | bytes | 1M bytes align | See the second padding is pretty huge and sounds very inefficient. But it is okay because actual region is never touched and no page is consumed for the padding region. And 128MB of addresses are enough big for the libpas usage. FYI: The purpose of this reservation is to represent 64 bit address with compact size (3 bytes in actual configuration). The client of compact heap reservation uses the fact that the assigned address fits in the range of reservation start and end so it can be represented as the index from the start. Testing is done on Speedometer 3.0 using MiniBrowser * Source/bmalloc/PlatformPlayStation.cmake: * Source/bmalloc/libpas/src/libpas/pas_compact_heap_reservation.c: (pas_compact_heap_reservation_try_allocate): Canonical link: https://commits.webkit.org/278937@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3042eb: Replace OSAllocator implementation with memory-ext...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3042eb64bb0398dcc68f3fd6000f8c7d099caf73 https://github.com/WebKit/WebKit/commit/3042eb64bb0398dcc68f3fd6000f8c7d099caf73 Author: Basuke Suzuki Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M Source/JavaScriptCore/PlatformPlayStation.cmake M Source/JavaScriptCore/shell/PlatformPlayStation.cmake M Source/JavaScriptCore/testmem/PlatformPlayStation.cmake M Source/JavaScriptCore/testmem/testmem.cpp M Source/WTF/wtf/PlatformPlayStation.cmake A Source/WTF/wtf/playstation/OSAllocatorPlayStation.cpp M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/page/playstation/ResourceUsageThreadPlayStation.cpp M Source/cmake/OptionsPlayStation.cmake M Tools/TestWebKitAPI/PlatformPlayStation.cmake Log Message: --- Replace OSAllocator implementation with memory-extra private library https://bugs.webkit.org/show_bug.cgi?id=274221 Reviewed by Don Olmstead. To reserve large address space, our platform requires precise control of virtual address space and commiti/decommit management is not enough for this purpose. In this patch, I've introduced new memory-extra private library for that purpose and add platform specific OSAllocator implementation. Also replace showmap library with embedded one inside memory-extra and use clever way to collect memory information. * Source/JavaScriptCore/PlatformPlayStation.cmake: * Source/JavaScriptCore/shell/PlatformPlayStation.cmake: * Source/JavaScriptCore/testmem/PlatformPlayStation.cmake: * Source/JavaScriptCore/testmem/testmem.cpp: (Footprint::now): * Source/WTF/wtf/PlatformPlayStation.cmake: * Source/WTF/wtf/playstation/OSAllocatorPlayStation.cpp: Added. (WTF::OSAllocator::tryReserveAndCommit): (WTF::OSAllocator::tryReserveUncommitted): (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::tryReserveUncommittedAligned): (WTF::OSAllocator::reserveAndCommit): (WTF::OSAllocator::commit): (WTF::OSAllocator::decommit): (WTF::OSAllocator::hintMemoryNotNeededSoon): (WTF::OSAllocator::releaseDecommitted): (WTF::OSAllocator::protect): * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/page/playstation/ResourceUsageThreadPlayStation.cpp: (WebCore::ResourceUsageThread::platformCollectMemoryData): * Source/cmake/OptionsPlayStation.cmake: * Tools/TestWebKitAPI/PlatformPlayStation.cmake: Canonical link: https://commits.webkit.org/278920@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91adc5: Postpone initialization of StructureAlignedMemoryA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91adc5e2412ce1d92a3271e5bc983618cb2aabba https://github.com/WebKit/WebKit/commit/91adc5e2412ce1d92a3271e5bc983618cb2aabba Author: Basuke Suzuki Date: 2023-10-21 (Sat, 21 Oct 2023) Changed paths: M Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp Log Message: --- Postpone initialization of StructureAlignedMemoryAllocator. https://bugs.webkit.org/show_bug.cgi?id=263380 Reviewed by Keith Miller. StructureAlignedMemoryAllocator reserves a large amount of pages at startup even on UIProcess and NetworkProcess because the initialization is called from JSC::initialize(). In this patch, we postpone the initialization of StructureAlignedMemoryAllocator until the first time it is used. Because permanentlyFreeze() will be called at the end of construction of VM, it is safe to postpone the initialization. * Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp: (JSC::StructureAlignedMemoryAllocator::tryMallocBlock): * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): Canonical link: https://commits.webkit.org/269633@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e0341: [PlayStation] Build fix after 268570@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e034196ac52df1b62b17c9635749091985e34b9 https://github.com/WebKit/WebKit/commit/5e034196ac52df1b62b17c9635749091985e34b9 Author: Basuke Suzuki Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M Source/WebCore/page/FocusController.h Log Message: --- [PlayStation] Build fix after 268570@main https://bugs.webkit.org/show_bug.cgi?id=262324 Unreviewed, build fix. LocalFrame should be included instead of forward declared. * Source/WebCore/page/FocusController.h: Canonical link: https://commits.webkit.org/268608@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ebec3b: Add WKUserScriptCreate with all parameters available.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ebec3b5a284a8f8b2e8358c47f8a810121672045 https://github.com/WebKit/WebKit/commit/ebec3b5a284a8f8b2e8358c47f8a810121672045 Author: Basuke Suzuki Date: 2023-08-18 (Fri, 18 Aug 2023) Changed paths: M Source/WebKit/PlatformPlayStation.cmake M Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp M Source/WebKit/UIProcess/API/C/WKUserScriptRef.h Log Message: --- Add WKUserScriptCreate with all parameters available. https://bugs.webkit.org/show_bug.cgi?id=260363 Reviewed by Alex Christensen. WKUserScriptCreateFromSource() cannot specify parameters for full WebCore::UserScript and the feature is limited. Because WKPageGroup is deprecated on 266167@main, we cannot achieve same thing we could do with WKPageGroupAddUserScript because of the lack of above creation API. This patch adds WKUserScriptCreate() with all parameters available. * Source/WebKit/PlatformPlayStation.cmake: * Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp: (WKUserScriptCreate): * Source/WebKit/UIProcess/API/C/WKUserScriptRef.h: Canonical link: https://commits.webkit.org/267052@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7e13f: [PlayStaion] Fix build after 263979@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7e13f01c2ebd0979c950e7e4b10b094bcae5116 https://github.com/WebKit/WebKit/commit/b7e13f01c2ebd0979c950e7e4b10b094bcae5116 Author: Basuke Suzuki Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStaion] Fix build after 263979@main https://bugs.webkit.org/show_bug.cgi?id=25 Unreviewed build fix. Fix mis configuration of availability of std::span. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/263985@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8441e: [PlayStation] Build fix after 263719@main when FIL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8441ed60b1313feadd12efe7faec0de27c75ab7 https://github.com/WebKit/WebKit/commit/e8441ed60b1313feadd12efe7faec0de27c75ab7 Author: Basuke Suzuki Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- [PlayStation] Build fix after 263719@main when FILTERS_LEVEL_2 is off (part 2). https://bugs.webkit.org/show_bug.cgi?id=256491 Unreviewed build fix. Added missing implementation for case when the flag is off. * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/263838@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad1c1a: [PlayStation] Build fix after 263719@main when FIL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad1c1aef7ec739d1bce9667f69087e6aa386b35e https://github.com/WebKit/WebKit/commit/ad1c1aef7ec739d1bce9667f69087e6aa386b35e Author: Basuke Suzuki Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- [PlayStation] Build fix after 263719@main when FILTERS_LEVEL_2 is off. https://bugs.webkit.org/show_bug.cgi?id=256491 Unreviewed build fix. * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/263833@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08bc10: [PlayStation] Build fix after 263719@main when CSS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08bc10f13a56d2db82d3a878737c3f0c9263e21f https://github.com/WebKit/WebKit/commit/08bc10f13a56d2db82d3a878737c3f0c9263e21f Author: Basuke Suzuki Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h Log Message: --- [PlayStation] Build fix after 263719@main when CSS_COMPOSITING is off. https://bugs.webkit.org/show_bug.cgi?id=256486 Unreviewed build fix. * Source/WebCore/rendering/RenderLayer.h: * Source/WebCore/rendering/RenderLayerInlines.h: (WebCore::RenderLayer::hasBackdropFilter const): (WebCore::RenderLayer::hasBlendMode const): * Source/WebCore/rendering/style/KeyframeList.h: * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setInputSecurity): (WebCore::RenderStyle::setIsolation): Canonical link: https://commits.webkit.org/263825@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d27a9b: [Windows] Drop support of older version of Windows.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d27a9b023902534f01844dd91c56de14ee95f493 https://github.com/WebKit/WebKit/commit/d27a9b023902534f01844dd91c56de14ee95f493 Author: Basuke Suzuki Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M Source/cmake/OptionsWin.cmake Log Message: --- [Windows] Drop support of older version of Windows. https://bugs.webkit.org/show_bug.cgi?id=256314 Reviewed by Don Olmstead and Yusuke Suzuki. Change the supported Windows version from Windows 7 to Windows 10 1809 "Redstone 5". Version 1809 is the oldest version which is still supported in Enterprise LTSB/LTSC editions. https://learn.microsoft.com/en-us/windows/release-health/supported-versions-windows-client * Source/cmake/OptionsWin.cmake: Canonical link: https://commits.webkit.org/263812@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c0f1c: [PlayStation] Fix build after 263601@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c0f1ca12c201bfe7e09bf06258f1cb6620c0eba https://github.com/WebKit/WebKit/commit/6c0f1ca12c201bfe7e09bf06258f1cb6620c0eba Author: Basuke Suzuki Date: 2023-05-05 (Fri, 05 May 2023) Changed paths: M Source/bmalloc/libpas/src/libpas/pas_segregated_page.h Log Message: --- [PlayStation] Fix build after 263601@main https://bugs.webkit.org/show_bug.cgi?id=256393 Reviewed by Yusuke Suzuki. While libpas header file is used outside bmalloc, casting from 'pas_page_base *' to 'pas_segregated_page *' generates warning (-Wcast-align). * Source/bmalloc/libpas/src/libpas/pas_segregated_page.h: Canonical link: https://commits.webkit.org/263739@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fca1b: [bmalloc] Replace ssize_t with ptrdiff_t for porta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fca1b37291f10c1bc0b672f96542994873c8f4c https://github.com/WebKit/WebKit/commit/3fca1b37291f10c1bc0b672f96542994873c8f4c Author: Basuke Suzuki Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Source/bmalloc/bmalloc/Heap.cpp M Source/bmalloc/bmalloc/Heap.h Log Message: --- [bmalloc] Replace ssize_t with ptrdiff_t for portability. https://bugs.webkit.org/show_bug.cgi?id=256010 Reviewed by Yusuke Suzuki. This is the patch for Windows bmalloc implementation part 4 of N. In Heap, ssize_t is used to pass +/- delta. Actually ssize_t is from posix and not portable. Let's use ptrdiff_t instead for better portability. * Source/bmalloc/bmalloc/Heap.cpp: (bmalloc::Heap::adjustStat): (bmalloc::Heap::logStat): (bmalloc::Heap::adjustFreeableMemory): (bmalloc::Heap::adjustFootprint): * Source/bmalloc/bmalloc/Heap.h: Canonical link: https://commits.webkit.org/263472@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 076ada: [bmalloc] Prevent warning when building bmalloc us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 076ada7d6d7a6e957a6fd99687819def19cd46be https://github.com/WebKit/WebKit/commit/076ada7d6d7a6e957a6fd99687819def19cd46be Author: Basuke Suzuki Date: 2023-04-26 (Wed, 26 Apr 2023) Changed paths: M Source/bmalloc/CMakeLists.txt Log Message: --- [bmalloc] Prevent warning when building bmalloc using MSVC without libpas. https://bugs.webkit.org/show_bug.cgi?id=255996 Reviewed by Yusuke Suzuki. This is the patch for Windows bmalloc implementation part 3 of N. When build bmalloc without libpas enabled by MSVC, following warning is reported while compiling libpas code: > C:\webkit\Source\bmalloc\libpas\src\libpas\iso_heap.c(304): warning C4206: > nonstandard extension used: translation unit is empty This is because `LIBPAS_ENABLED` is false and entire C file is empty after preprocessing. https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4206?view=msvc-170 Ignore this error on bmalloc MSVC build. * Source/bmalloc/CMakeLists.txt: Canonical link: https://commits.webkit.org/263436@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f46202: [bmalloc] Add missing macros for Windows platform.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f462028e09b021b5d2768fee9ea0ffc056565b94 https://github.com/WebKit/WebKit/commit/f462028e09b021b5d2768fee9ea0ffc056565b94 Author: Basuke Suzuki Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/bmalloc/bmalloc/BCompiler.h M Source/bmalloc/bmalloc/BInline.h M Source/bmalloc/bmalloc/BPlatform.h M Source/bmalloc/bmalloc/PerProcess.h M Source/bmalloc/libpas/src/libpas/pas_platform.h Log Message: --- [bmalloc] Add missing macros for Windows platform. https://bugs.webkit.org/show_bug.cgi?id=255944 Reviewed by Yusuke Suzuki. This is the patch for Windows bmalloc implementation part 2 of N. Bmalloc defines many compiler macros. Most of them are not Windows and MSVC ready. This patch defines those for Windows API. * Source/bmalloc/bmalloc/BCompiler.h: * Source/bmalloc/bmalloc/BInline.h: * Source/bmalloc/bmalloc/BPlatform.h: * Source/bmalloc/bmalloc/OerOricess.h: * Source/bmalloc/libpas/src/libpas/pas_platform.h: Canonical link: https://commits.webkit.org/263404@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f2402: [Windows] Allow bmalloc build for Windows platform.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f2402e915287f01288f7061e71be2de40cc98a8 https://github.com/WebKit/WebKit/commit/7f2402e915287f01288f7061e71be2de40cc98a8 Author: Basuke Suzuki Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/bmalloc/CMakeLists.txt M Source/cmake/OptionsWin.cmake Log Message: --- [Windows] Allow bmalloc build for Windows platform. https://bugs.webkit.org/show_bug.cgi?id=255943 Reviewed by Yusuke Suzuki. This is the patch for Windows bmalloc implementation part 1 of N. On Windows port, USE_SYSTEM_MALLOC is hard coded and cannot enable by cmake option USE_SYSTEM_MALLOC=Off. This patch removes the restriction by removing that code. Note the default value of USE_SYSTEM_MALLOC on Windows port is still on. There's no actual effect unless passing the cmake arg explicitly. * Source/WTF/wtf/PlatformUse.h: * Source/bmalloc/CMakeLists.txt: * Source/cmake/OptionsWin.cmake: Canonical link: https://commits.webkit.org/263399@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59318c: [PlayStation] Fix build after 262631@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59318ce6feee9ffa135d2c2979b291f526bf9c09 https://github.com/WebKit/WebKit/commit/59318ce6feee9ffa135d2c2979b291f526bf9c09 Author: Basuke Suzuki Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkProcess.cpp Log Message: --- [PlayStation] Fix build after 262631@main https://bugs.webkit.org/show_bug.cgi?id=255053 Unreviewed build fix. Service worker code was used without enable guard. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::storeServiceWorkerRegistrations): Canonical link: https://commits.webkit.org/262638@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b387b3: [PlayStation] Fix assertion crash of libpas pthrea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b387b3c61ceaf97fc854b64bbee510eeefb208e6 https://github.com/WebKit/WebKit/commit/b387b3c61ceaf97fc854b64bbee510eeefb208e6 Author: Basuke Suzuki Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M Source/bmalloc/libpas/src/libpas/pas_lock.h Log Message: --- [PlayStation] Fix assertion crash of libpas pthread implementation. https://bugs.webkit.org/show_bug.cgi?id=254452 Reviewed by Don Olmstead. Fix trivial mistake which uses errno instead of returned error value. * Source/bmalloc/libpas/src/libpas/pas_lock.h: (pas_lock_try_lock): Canonical link: https://commits.webkit.org/262107@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f24f30: [PlayStation] Port pthread mutex implementation to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f24f304431b72fcb29dabdc0e8501e100e7892e3 https://github.com/WebKit/WebKit/commit/f24f304431b72fcb29dabdc0e8501e100e7892e3 Author: Basuke Suzuki Date: 2023-03-21 (Tue, 21 Mar 2023) Changed paths: M Source/bmalloc/libpas/src/libpas/pas_config.h M Source/bmalloc/libpas/src/libpas/pas_lock.h Log Message: --- [PlayStation] Port pthread mutex implementation to libpas. https://bugs.webkit.org/show_bug.cgi?id=254182 Reviewed by Yusuke Suzuki. Added pthread mutex implementation for PlayStation port. * Source/bmalloc/libpas/src/libpas/pas_config.h: * Source/bmalloc/libpas/src/libpas/pas_lock.h: (pas_lock_construct): (pas_lock_construct_disabled): (pas_lock_mutex_setname): (pas_lock_lock): (pas_lock_try_lock): (pas_lock_unlock): (pas_lock_test_held): (pas_lock_assert_held): (pas_lock_testing_assert_held): Canonical link: https://commits.webkit.org/261931@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 806d83: [PlayStation] Fix cmake settings of VisualStudio d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 806d83f4413652ce474641c5ea66f889cd186741 https://github.com/WebKit/WebKit/commit/806d83f4413652ce474641c5ea66f889cd186741 Author: Basuke Suzuki Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M Tools/TestWebKitAPI/PlatformPlayStation.cmake Log Message: --- [PlayStation] Fix cmake settings of VisualStudio debugging environment. https://bugs.webkit.org/show_bug.cgi?id=254171 Reviewed by Don Olmstead. Fix the working directory of TestJavaScriptCore and TestWebKit correctly. * Tools/TestWebKitAPI/PlatformPlayStation.cmake: Canonical link: https://commits.webkit.org/261898@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 612be3: Build fix for debug build after 261509@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 612be37dd057e950b2138411bb9e80d9fcec5c96 https://github.com/WebKit/WebKit/commit/612be37dd057e950b2138411bb9e80d9fcec5c96 Author: Basuke Suzuki Date: 2023-03-11 (Sat, 11 Mar 2023) Changed paths: M Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementEphemeralStore.cpp Log Message: --- Build fix for debug build after 261509@main https://bugs.webkit.org/show_bug.cgi?id=253746 Unreviewed build fix. PrivateClickMeasurementAttributionType didn't have definition. * Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementEphemeralStore.cpp: Canonical link: https://commits.webkit.org/261541@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79fa85: Fix build break after 261484@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79fa85a5f8525adbf282f03eef0fab37a7b9fdc4 https://github.com/WebKit/WebKit/commit/79fa85a5f8525adbf282f03eef0fab37a7b9fdc4 Author: Basuke Suzuki Date: 2023-03-10 (Fri, 10 Mar 2023) Changed paths: M Source/WebCore/rendering/RenderHTMLCanvas.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- Fix build break after 261484@main https://bugs.webkit.org/show_bug.cgi?id=253710 Unreviewed build fix. Added ENABLE flag protection. * Source/WebCore/rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): Canonical link: https://commits.webkit.org/261514@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ba5c5: [PlayStation] Fix build after 261363@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ba5c54bcf367e03a4b45f77c6958ae295351374 https://github.com/WebKit/WebKit/commit/3ba5c54bcf367e03a4b45f77c6958ae295351374 Author: Basuke Suzuki Date: 2023-03-08 (Wed, 08 Mar 2023) Changed paths: M Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp Log Message: --- [PlayStation] Fix build after 261363@main https://bugs.webkit.org/show_bug.cgi?id=253585 Unreviewed build fix. Following constructor signature change of NativeWebKeyboardEvent. * Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp: (WKPageHandleKeyboardEvent): Canonical link: https://commits.webkit.org/261379@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d55742: [PlayStation] Build fix for non SERVICE_WORKER bui...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5574254187011ee8d6978fb6cd26e61b75cd448 https://github.com/WebKit/WebKit/commit/d5574254187011ee8d6978fb6cd26e61b75cd448 Author: Basuke Suzuki Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: M Source/WebKit/Shared/BackgroundFetchState.h Log Message: --- [PlayStation] Build fix for non SERVICE_WORKER build after 261261@main https://bugs.webkit.org/show_bug.cgi?id=253473 Unreviewed build fix. Added ENABLE(SERVICE_WORKER). * Source/WebKit/Shared/BackgroundFetchState.h: Canonical link: https://commits.webkit.org/261301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 954abe: [Visual Studio] Debug information was gone since 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 954abe6a1af976007d7c62d14b9a1b3e61cdf267 https://github.com/WebKit/WebKit/commit/954abe6a1af976007d7c62d14b9a1b3e61cdf267 Author: Basuke Suzuki Date: 2023-02-17 (Fri, 17 Feb 2023) Changed paths: M Source/cmake/OptionsCommon.cmake Log Message: --- [Visual Studio] Debug information was gone since 259957@main https://bugs.webkit.org/show_bug.cgi?id=252429 Reviewed by Adrian Perez de Castro and Michael Catanzaro. Disable fission settings when generator is Visual Studio because VS doesn't handle debug information well if this settings is on for llvm. * Source/cmake/OptionsCommon.cmake: Canonical link: https://commits.webkit.org/260488@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acef9a: [PlayStation] Port testmem binary
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acef9ad8c7ef07b019e19405a8b2ea5395f65b0c https://github.com/WebKit/WebKit/commit/acef9ad8c7ef07b019e19405a8b2ea5395f65b0c Author: Basuke Suzuki Date: 2023-02-16 (Thu, 16 Feb 2023) Changed paths: M Source/JavaScriptCore/PlatformPlayStation.cmake A Source/JavaScriptCore/testmem/CMakeLists.txt A Source/JavaScriptCore/testmem/PlatformPlayStation.cmake A Source/JavaScriptCore/testmem/testmem.cpp Log Message: --- [PlayStation] Port testmem binary https://bugs.webkit.org/show_bug.cgi?id=252411 Reviewed by Yusuke Suzuki. Ported testmem binary from Darwin port. Original code was Objective-C++ so new cpp file was added. * Source/JavaScriptCore/PlatformPlayStation.cmake: * Source/JavaScriptCore/testmem/CMakeLists.txt: Added. * Source/JavaScriptCore/testmem/PlatformPlayStation.cmake: Added. * Source/JavaScriptCore/testmem/testmem.cpp: Added. (description): (Footprint::now): (readScript): (main): Canonical link: https://commits.webkit.org/260423@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f0677: [PlayStation] Fix build break on API tests.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f06777840929f9d83de818ba4837ac2b63eff8d https://github.com/WebKit/WebKit/commit/6f06777840929f9d83de818ba4837ac2b63eff8d Author: Basuke Suzuki Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M Source/WebKit/PlatformPlayStation.cmake M Tools/TestWebKitAPI/PlatformPlayStation.cmake Log Message: --- [PlayStation] Fix build break on API tests. https://bugs.webkit.org/show_bug.cgi?id=251931 Unreviewed build fix. * Source/WebKit/PlatformPlayStation.cmake: * Tools/TestWebKitAPI/PlatformPlayStation.cmake: Canonical link: https://commits.webkit.org/260022@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/test-backendcommand Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3260f1: [PlayStation] Fix JSC build.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3260f1c679400d828e0585704f95023b7e726e54 https://github.com/WebKit/WebKit/commit/3260f1c679400d828e0585704f95023b7e726e54 Author: Basuke Suzuki Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Fix JSC build. https://bugs.webkit.org/show_bug.cgi?id=246659 Reviewed by Yusuke Suzuki. The location of find_package for Threads should run even when WEBCORE is disabled. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/255700@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295624] trunk/Source/JavaScriptCore
Title: [295624] trunk/Source/_javascript_Core
Revision 295624
Author basuke.suz...@sony.com
Date 2022-06-16 19:20:29 -0700 (Thu, 16 Jun 2022)
Log Message
The extraMemorySize() get wrong when transferring ArrayBuffer from Worker VM
https://bugs.webkit.org/show_bug.cgi?id=241559
Reviewed by Yusuke Suzuki.
When ArrayBuffer is passed in the transfer option of postMessage(), the size cached in
heap.m_arrayBuffers get incorrect and that makes extraMemorySize() bigger than actual
managed size.
This patch added the code to reduce size from GCIncomingRefCountedSet.m_bytes when
ArrayBuffer is actually transferring from VM.
Also for verification, added a simple check code in GCIncomingRefCountedSet.addReference
with constexpr flag.
* Source/_javascript_Core/heap/GCIncomingRefCountedSet.h:
* Source/_javascript_Core/heap/GCIncomingRefCountedSetInlines.h:
(JSC::GCIncomingRefCountedSet::sweep):
(JSC::GCIncomingRefCountedSet::reduceSize):
* Source/_javascript_Core/heap/Heap.cpp:
(JSC::Heap::reduceArrayBufferSize):
* Source/_javascript_Core/heap/Heap.h:
* Source/_javascript_Core/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::transferTo):
Canonical link: https://commits.webkit.org/251629@main
Modified Paths
trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSet.h
trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSetInlines.h
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp
Diff
Modified: trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSet.h (295623 => 295624)
--- trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSet.h 2022-06-17 02:17:50 UTC (rev 295623)
+++ trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSet.h 2022-06-17 02:20:29 UTC (rev 295624)
@@ -44,6 +44,7 @@
void sweep(VM&);
size_t size() const { return m_bytes; };
+void reduceSize(size_t);
private:
Vector m_vector;
Modified: trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSetInlines.h (295623 => 295624)
--- trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSetInlines.h 2022-06-17 02:17:50 UTC (rev 295623)
+++ trunk/Source/_javascript_Core/heap/GCIncomingRefCountedSetInlines.h 2022-06-17 02:20:29 UTC (rev 295624)
@@ -72,6 +72,23 @@
m_vector[i--] = m_vector.last();
m_vector.removeLast();
}
+
+constexpr bool verify = false;
+if constexpr (verify) {
+CheckedSize size;
+for (size_t i = m_vector.size(); i--;) {
+T* object = m_vector[i];
+size += object->gcSizeEstimateInBytes();
+}
+ASSERT(m_bytes == size);
+}
}
+template
+void GCIncomingRefCountedSet::reduceSize(size_t bytes)
+{
+ASSERT(m_bytes >= bytes);
+m_bytes -= bytes;
+}
+
} // namespace JSC
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (295623 => 295624)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2022-06-17 02:17:50 UTC (rev 295623)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2022-06-17 02:20:29 UTC (rev 295624)
@@ -659,6 +659,11 @@
}
}
+void Heap::reduceArrayBufferSize(size_t bytes)
+{
+m_arrayBuffers.reduceSize(bytes);
+}
+
template
void Heap::finalizeMarkedUnconditionalFinalizers(CellSet& cellSet)
{
Modified: trunk/Source/_javascript_Core/heap/Heap.h (295623 => 295624)
--- trunk/Source/_javascript_Core/heap/Heap.h 2022-06-17 02:17:50 UTC (rev 295623)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2022-06-17 02:20:29 UTC (rev 295624)
@@ -439,6 +439,7 @@
const JITStubRoutineSet& jitStubRoutines() { return *m_jitStubRoutines; }
void addReference(JSCell*, ArrayBuffer*);
+void reduceArrayBufferSize(size_t bytes);
bool isDeferred() const { return !!m_deferralDepth; }
Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp (295623 => 295624)
--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp 2022-06-17 02:17:50 UTC (rev 295623)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp 2022-06-17 02:20:29 UTC (rev 295624)
@@ -303,8 +303,11 @@
return true;
}
+CheckedSize sizeReduced { gcSizeEstimateInBytes() };
result = WTFMove(m_contents);
notifyDetaching(vm);
+sizeReduced -= gcSizeEstimateInBytes();
+vm.heap.reduceArrayBufferSize(sizeReduced);
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294517] trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp
Title: [294517] trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp Revision 294517 Author basuke.suz...@sony.com Date 2022-05-19 17:59:11 -0700 (Thu, 19 May 2022) Log Message Fix boolean operation in WTF/BitMap test. https://bugs.webkit.org/show_bug.cgi?id=240668 Reviewed by Adrian Perez de Castro. Clang 14 starts complaining about using logical operators to boolean: ``` webkit/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:1172:32: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical] EXPECT_EQ(temp.get(i), bitmap1.get(i) | bitmap2.get(i)); ^~~ || ``` Canonical link: https://commits.webkit.org/250773@main Modified Paths trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp Diff Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp (294516 => 294517) --- trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp 2022-05-20 00:04:46 UTC (rev 294516) +++ trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp 2022-05-20 00:59:11 UTC (rev 294517) @@ -1169,7 +1169,7 @@ temp |= bitmap2; for (size_t i = 0; i < size; ++i) -EXPECT_EQ(temp.get(i), bitmap1.get(i) | bitmap2.get(i)); +EXPECT_EQ(temp.get(i), bitmap1.get(i) || bitmap2.get(i)); temp1 = temp; EXPECT_TRUE(temp1 == temp); @@ -1237,7 +1237,7 @@ temp &= bitmap2; for (size_t i = 0; i < size; ++i) -EXPECT_EQ(temp.get(i), bitmap1.get(i) & bitmap2.get(i)); +EXPECT_EQ(temp.get(i), bitmap1.get(i) && bitmap2.get(i)); EXPECT_TRUE(!temp.isEmpty()); temp1 = temp; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294509] trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
Title: [294509] trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp Revision 294509 Author basuke.suz...@sony.com Date 2022-05-19 15:43:55 -0700 (Thu, 19 May 2022) Log Message [Curl] Suppress warning of unused enum value in switch statement. https://bugs.webkit.org/show_bug.cgi?id=240672 Reviewed by Fujii Hironori. Just after the request object creation, the state is WaitingForStart. It is better the code explicitly takes care of this fact. Also moving the assignment to the state inside the switch statement denotes the state is changing to the response of previous state. No new tests. Covered by existing tests. * platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::start): Canonical link: https://commits.webkit.org/250766@main Modified Paths trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp Diff Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (294508 => 294509) --- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2022-05-19 22:37:38 UTC (rev 294508) +++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2022-05-19 22:43:55 UTC (rev 294509) @@ -116,10 +116,11 @@ [[fallthrough]]; case StartState::StartSuspended: return; +case StartState::WaitingForStart: +m_startState = StartState::DidStart; +break; } -m_startState = StartState::DidStart; - if (m_request.url().isLocalFile()) invokeDidReceiveResponseForFile(m_request.url()); else ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294437] trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp
Title: [294437] trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp Revision 294437 Author basuke.suz...@sony.com Date 2022-05-18 14:57:51 -0700 (Wed, 18 May 2022) Log Message [LibWPE] Fix build failure when enabling LAYOUT_FORMATTING_CONTEXT https://bugs.webkit.org/show_bug.cgi?id=240602 Unreviewed, fix libwpe build with the flag after r294399 * editing/libwpe/EditorLibWPE.cpp: Canonical link: https://commits.webkit.org/250715@main Modified Paths trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp Diff Modified: trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp (294436 => 294437) --- trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp 2022-05-18 21:57:27 UTC (rev 294436) +++ trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp 2022-05-18 21:57:51 UTC (rev 294437) @@ -30,6 +30,7 @@ #include "DocumentFragment.h" #include "Frame.h" +#include "FrameDestructionObserverInlines.h" #include "NotImplemented.h" #include "Pasteboard.h" #include "Settings.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294377] trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp
Title: [294377] trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp
Revision 294377
Author basuke.suz...@sony.com
Date 2022-05-17 18:42:26 -0700 (Tue, 17 May 2022)
Log Message
[WinCairo] Add memory usage of LibcMalloc category
https://bugs.webkit.org/show_bug.cgi?id=239660
Reviewed by Ross Kirsling.
WinCairo's memory timeline just displays _javascript_ memory usage. Adding
this info shows also Page
memory usage.
* page/win/ResourceUsageThreadWin.cpp:
(WebCore::ResourceUsageThread::platformCollectMemoryData):
Canonical link: https://commits.webkit.org/250668@main
Modified Paths
trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp
Diff
Modified: trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp (294376 => 294377)
--- trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp 2022-05-18 01:37:03 UTC (rev 294376)
+++ trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp 2022-05-18 01:42:26 UTC (rev 294377)
@@ -118,7 +118,7 @@
void ResourceUsageThread::platformCollectMemoryData(JSC::VM* vm, ResourceUsageData& data)
{
-data.totalDirtySize = memoryUsage();
+auto usage = data.totalDirtySize = memoryUsage();
size_t currentGCHeapCapacity = vm->heap.blockBytesAllocated();
size_t currentGCOwnedExtra = vm->heap.extraMemorySize();
@@ -129,6 +129,14 @@
data.categories[MemoryCategory::GCOwned].dirtySize = currentGCOwnedExtra - currentGCOwnedExternal;
data.categories[MemoryCategory::GCOwned].externalSize = currentGCOwnedExternal;
+usage -= currentGCHeapCapacity;
+// Following ResourceUsageThreadCocoa implementation
+auto currentGCOwnedGenerallyInMalloc = currentGCOwnedExtra - currentGCOwnedExternal;
+if (currentGCOwnedGenerallyInMalloc < usage)
+usage -= currentGCOwnedGenerallyInMalloc;
+
+data.categories[MemoryCategory::LibcMalloc].dirtySize = usage;
+
data.totalExternalSize = currentGCOwnedExternal;
data.timeOfNextEdenCollection = data.timestamp + vm->heap.edenActivityCallback()->timeUntilFire().value_or(Seconds(std::numeric_limits::infinity()));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294364] trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c
Title: [294364] trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c
Revision 294364
Author basuke.suz...@sony.com
Date 2022-05-17 16:54:32 -0700 (Tue, 17 May 2022)
Log Message
[libpas] Suppress warnings for %llu format specifier for uint64_t.
https://bugs.webkit.org/show_bug.cgi?id=240541
Reviewed by Yusuke Suzuki.
Use PRIu64 instead.
* libpas/src/libpas/pas_utils.c:
(pas_assertion_failed_no_inline_with_extra_detail):
Canonical link: https://commits.webkit.org/250667@main
Modified Paths
trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c
Diff
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c (294363 => 294364)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c 2022-05-17 23:50:32 UTC (rev 294363)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c 2022-05-17 23:54:32 UTC (rev 294364)
@@ -32,6 +32,7 @@
#include "pas_lock.h"
#include "pas_log.h"
#include "pas_string_stream.h"
+#include
#include
#include
#include
@@ -113,7 +114,7 @@
void pas_assertion_failed_no_inline_with_extra_detail(const char* filename, int line, const char* function, const char* _expression_, uint64_t extra)
{
pas_log("[%d] pas assertion failed (with extra detail): ", getpid());
-pas_log("%s:%d: %s: assertion %s failed. Extra data: %llu.\n", filename, line, function, _expression_, extra);
+pas_log("%s:%d: %s: assertion %s failed. Extra data: %" PRIu64 ".\n", filename, line, function, _expression_, extra);
pas_crash_with_info_impl((uint64_t)filename, line, (uint64_t) function, (uint64_t) _expression_, extra, 1337, 0xbeef0bff);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292407] trunk/Source/bmalloc
Title: [292407] trunk/Source/bmalloc
Revision 292407
Author basuke.suz...@sony.com
Date 2022-04-05 11:45:09 -0700 (Tue, 05 Apr 2022)
Log Message
[PlayStation] Enable libpas.
https://bugs.webkit.org/show_bug.cgi?id=238753
Reviewed by Yusuke Suzuki.
PlayStation platform is ready to enable it finally.
* PlatformPlayStation.cmake:
* bmalloc/BPlatform.h:
* libpas/src/libpas/pas_config.h:
* libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_try_allocate_without_deallocating_padding):
(commit_impl):
* libpas/src/libpas/pas_platform.h:
* libpas/src/libpas/pas_thread_local_cache.c:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/PlatformPlayStation.cmake
trunk/Source/bmalloc/bmalloc/BPlatform.h
trunk/Source/bmalloc/libpas/src/libpas/pas_config.h
trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segmented_vector.h
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.h
trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c
trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (292406 => 292407)
--- trunk/Source/bmalloc/ChangeLog 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/ChangeLog 2022-04-05 18:45:09 UTC (rev 292407)
@@ -1,3 +1,21 @@
+2022-04-05 Basuke Suzuki
+
+[PlayStation] Enable libpas.
+https://bugs.webkit.org/show_bug.cgi?id=238753
+
+Reviewed by Yusuke Suzuki.
+
+PlayStation platform is ready to enable it finally.
+
+* PlatformPlayStation.cmake:
+* bmalloc/BPlatform.h:
+* libpas/src/libpas/pas_config.h:
+* libpas/src/libpas/pas_page_malloc.c:
+(pas_page_malloc_try_allocate_without_deallocating_padding):
+(commit_impl):
+* libpas/src/libpas/pas_platform.h:
+* libpas/src/libpas/pas_thread_local_cache.c:
+
2022-04-04 Yusuke Suzuki
[libpas] Do not need to call pthread_set_qos_class_self_np repeatedly
Modified: trunk/Source/bmalloc/PlatformPlayStation.cmake (292406 => 292407)
--- trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-04-05 18:45:09 UTC (rev 292407)
@@ -1,8 +1,15 @@
+WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(
+-Wno-typedef-redefinition)
+
if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
+set(bmalloc_C_SOURCES ${bmalloc_SOURCES})
+list(FILTER bmalloc_C_SOURCES INCLUDE REGEX "\\.c$")
+
# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
set_source_files_properties(
-${bmalloc_SOURCES}
-PROPERTIES LANGUAGE CXX
+${bmalloc_C_SOURCES}
+PROPERTIES LANGUAGE C
+COMPILE_OPTIONS --std=gnu17
)
endif ()
Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (292406 => 292407)
--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2022-04-05 18:45:09 UTC (rev 292407)
@@ -324,7 +324,7 @@
/* BENABLE(LIBPAS) is enabling libpas build. But this does not mean we use libpas for bmalloc replacement. */
#if !defined(BENABLE_LIBPAS)
-#if BCPU(ADDRESS64) && (BOS(DARWIN) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE)))
+#if BCPU(ADDRESS64) && (BOS(DARWIN) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE))) || BPLATFORM(PLAYSTATION)
#define BENABLE_LIBPAS 1
#ifndef PAS_BMALLOC
#define PAS_BMALLOC 1
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config.h (292406 => 292407)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_config.h 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config.h 2022-04-05 18:45:09 UTC (rev 292407)
@@ -38,7 +38,7 @@
#endif
#endif
-#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E && defined(NDEBUG)
+#if ((PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E) || PAS_PLATFORM(PLAYSTATION)) && defined(NDEBUG)
#define PAS_ENABLE_ASSERT 0
#else
#define PAS_ENABLE_ASSERT 1
@@ -54,7 +54,7 @@
#define PAS_ADDRESS_BITS 48
-#if PAS_ARM
+#if PAS_ARM || PAS_PLATFORM(PLAYSTATION)
#define PAS_MAX_GRANULES 256
#else
#define PAS_MAX_GRANULES 1024
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c (292406 => 292407)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c 2022-04-05 18:45:09 UTC (rev 292407)
@@ -120,8 +120,13 @@
return result;
}
+#if PAS_PLATFORM(PLAYSTATION)
+mmap_result = mmap_np(NULL, mapped_size, PROT_READ | PROT_WRITE,
+
[webkit-changes] [291368] trunk/Source/WebCore
Title: [291368] trunk/Source/WebCore
Revision 291368
Author basuke.suz...@sony.com
Date 2022-03-16 14:35:36 -0700 (Wed, 16 Mar 2022)
Log Message
[PlayStation] Fix build break after r291341
https://bugs.webkit.org/show_bug.cgi?id=237971
Unreviewed build fix.
* platform/playstation/MIMETypeRegistryPlayStation.cpp:
(WebCore::MIMETypeRegistry::mimeTypeForExtension):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291367 => 291368)
--- trunk/Source/WebCore/ChangeLog 2022-03-16 21:32:49 UTC (rev 291367)
+++ trunk/Source/WebCore/ChangeLog 2022-03-16 21:35:36 UTC (rev 291368)
@@ -1,3 +1,13 @@
+2022-03-16 Basuke Suzuki
+
+[PlayStation] Fix build break after r291341
+https://bugs.webkit.org/show_bug.cgi?id=237971
+
+Unreviewed build fix.
+
+* platform/playstation/MIMETypeRegistryPlayStation.cpp:
+(WebCore::MIMETypeRegistry::mimeTypeForExtension):
+
2022-03-16 Said Abou-Hallawa
[GPU Process] Move other classes out of GraphicsContext.h
Modified: trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp (291367 => 291368)
--- trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp 2022-03-16 21:32:49 UTC (rev 291367)
+++ trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp 2022-03-16 21:35:36 UTC (rev 291368)
@@ -57,7 +57,7 @@
return platformMediaTypes;
}
-String MIMETypeRegistry::mimeTypeForExtension(const String& extension)
+String MIMETypeRegistry::mimeTypeForExtension(StringView extension)
{
for (auto& entry : platformMediaTypes()) {
if (equalIgnoringASCIICase(extension, entry.extension.characters()))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291363] trunk/Tools
Title: [291363] trunk/Tools Revision 291363 Author basuke.suz...@sony.com Date 2022-03-16 13:50:30 -0700 (Wed, 16 Mar 2022) Log Message Suppress warnings for implicit conversion from unsigned long to double https://bugs.webkit.org/show_bug.cgi?id=237899 Reviewed by Darin Adler. Add static_cast for approx casting to double. * TestWebKitAPI/Tests/WTF/Int128.cpp: (TestWebKitAPI::TEST): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp Diff Modified: trunk/Tools/ChangeLog (291362 => 291363) --- trunk/Tools/ChangeLog 2022-03-16 20:45:42 UTC (rev 291362) +++ trunk/Tools/ChangeLog 2022-03-16 20:50:30 UTC (rev 291363) @@ -1,3 +1,16 @@ +2022-03-16 Basuke Suzuki + +Suppress warnings for implicit conversion from unsigned long to double +https://bugs.webkit.org/show_bug.cgi?id=237899 + + +Reviewed by Darin Adler. + +Add static_cast for approx casting to double. + +* TestWebKitAPI/Tests/WTF/Int128.cpp: +(TestWebKitAPI::TEST): + 2022-03-15 Jonathan Bedard [Merge-Queue] Rename patch_reviewer Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp (291362 => 291363) --- trunk/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp 2022-03-16 20:45:42 UTC (rev 291362) +++ trunk/Tools/TestWebKitAPI/Tests/WTF/Int128.cpp 2022-03-16 20:50:30 UTC (rev 291363) @@ -251,7 +251,7 @@ EXPECT_EQ(from_precise_double, from_precise_ints); EXPECT_DOUBLE_EQ(static_cast(from_precise_ints), precise_double); -double approx_double = 0x * std::pow(2.0, 64.0) + 0x; +double approx_double = static_cast(0x) * std::pow(2.0, 64.0) + static_cast(0x); WTF::UInt128Impl from_approx_double(approx_double); EXPECT_DOUBLE_EQ(static_cast(from_approx_double), approx_double); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290904] trunk
Title: [290904] trunk
Revision 290904
Author basuke.suz...@sony.com
Date 2022-03-07 13:11:28 -0800 (Mon, 07 Mar 2022)
Log Message
Update Basuke Suzuki's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=237545
Unreviewed.
* metadata/contributors.json:
Modified Paths
trunk/ChangeLog
trunk/metadata/contributors.json
Diff
Modified: trunk/ChangeLog (290903 => 290904)
--- trunk/ChangeLog 2022-03-07 20:59:05 UTC (rev 290903)
+++ trunk/ChangeLog 2022-03-07 21:11:28 UTC (rev 290904)
@@ -1,3 +1,12 @@
+2022-03-07 Basuke Suzuki
+
+Update Basuke Suzuki's status to reviewer
+https://bugs.webkit.org/show_bug.cgi?id=237545
+
+Unreviewed.
+
+* metadata/contributors.json:
+
2022-03-07 Jonathan Bedard
[webkitbugspy] Allow creation of new issues
Modified: trunk/metadata/contributors.json (290903 => 290904)
--- trunk/metadata/contributors.json 2022-03-07 20:59:05 UTC (rev 290903)
+++ trunk/metadata/contributors.json 2022-03-07 21:11:28 UTC (rev 290904)
@@ -1003,7 +1003,7 @@
"nicks" : [
"basuke"
],
- "status" : "committer"
+ "status" : "reviewer"
},
{
"emails" : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290719] trunk/Source/bmalloc
Title: [290719] trunk/Source/bmalloc
Revision 290719
Author basuke.suz...@sony.com
Date 2022-03-01 22:05:31 -0800 (Tue, 01 Mar 2022)
Log Message
[libpas] Add missing PlayStation implementation.
https://bugs.webkit.org/show_bug.cgi?id=237341
Reviewed by Yusuke Suzuki.
* libpas/src/libpas/pas_monotonic_time.c:
(pas_get_current_monotonic_time_nanoseconds):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c
Diff
Modified: trunk/Source/bmalloc/ChangeLog (290718 => 290719)
--- trunk/Source/bmalloc/ChangeLog 2022-03-02 06:03:13 UTC (rev 290718)
+++ trunk/Source/bmalloc/ChangeLog 2022-03-02 06:05:31 UTC (rev 290719)
@@ -1,3 +1,13 @@
+2022-03-01 Basuke Suzuki
+
+[libpas] Add missing PlayStation implementation.
+https://bugs.webkit.org/show_bug.cgi?id=237341
+
+Reviewed by Yusuke Suzuki.
+
+* libpas/src/libpas/pas_monotonic_time.c:
+(pas_get_current_monotonic_time_nanoseconds):
+
2022-02-25 Basuke Suzuki
[libpas] Suppress cast-align warnings
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c (290718 => 290719)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c 2022-03-02 06:03:13 UTC (rev 290718)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c 2022-03-02 06:05:31 UTC (rev 290719)
@@ -80,6 +80,15 @@
return ts.tv_sec * 1.0e9 + ts.tv_nsec;
}
+#elif PAS_PLATFORM(PLAYSTATION)
+
+uint64_t pas_get_current_monotonic_time_nanoseconds(void)
+{
+struct timespec ts;
+clock_gettime_np(CLOCK_MONOTONIC_FAST, );
+return ts.tv_sec * 1000u * 1000u * 1000u + ts.tv_nsec;
+}
+
#endif
#endif /* LIBPAS_ENABLED */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290636] trunk
Title: [290636] trunk
Revision 290636
Author basuke.suz...@sony.com
Date 2022-03-01 01:36:58 -0800 (Tue, 01 Mar 2022)
Log Message
[CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.
https://bugs.webkit.org/show_bug.cgi?id=237170
Reviewed by Fujii Hironori.
CMake variables which has chance to set from outside should be cached in CMake configuration cache.
Unless cacheing, the result of building the generated project is not consisitent because the other
configuration may run while building.
To make it complete, I've changed ENABLE_JAVASCRIPTCORE, ENABLE_WEBCORE and ENABLE_WEBKIT to `option()`
which is stored in cached and reused while building even if the confuguration runs again.
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/WebKitCommon.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Source/cmake/WebKitCommon.cmake
Diff
Modified: trunk/ChangeLog (290635 => 290636)
--- trunk/ChangeLog 2022-03-01 09:01:13 UTC (rev 290635)
+++ trunk/ChangeLog 2022-03-01 09:36:58 UTC (rev 290636)
@@ -1,3 +1,20 @@
+2022-03-01 Basuke Suzuki
+
+[CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.
+https://bugs.webkit.org/show_bug.cgi?id=237170
+
+Reviewed by Fujii Hironori.
+
+CMake variables which has chance to set from outside should be cached in CMake configuration cache.
+Unless cacheing, the result of building the generated project is not consisitent because the other
+configuration may run while building.
+
+To make it complete, I've changed ENABLE_JAVASCRIPTCORE, ENABLE_WEBCORE and ENABLE_WEBKIT to `option()`
+which is stored in cached and reused while building even if the confuguration runs again.
+
+* Source/cmake/OptionsPlayStation.cmake:
+* Source/cmake/WebKitCommon.cmake:
+
2022-02-28 Brandon Stewart
Add Brandon Stewart's name to contributors.json
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (290635 => 290636)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2022-03-01 09:01:13 UTC (rev 290635)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2022-03-01 09:36:58 UTC (rev 290636)
@@ -17,15 +17,9 @@
WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-dll-attribute-on-redeclaration)
set(ENABLE_API_TESTS ON CACHE BOOL "Build API Tests")
-set(ENABLE_WEBCORE ON CACHE BOOL "Build WebCore")
-set(ENABLE_WEBKIT ON CACHE BOOL "Build WebKit")
set(ENABLE_WEBKIT_LEGACY OFF)
set(ENABLE_WEBINSPECTORUI OFF)
-if (NOT ENABLE_WEBCORE)
-set(ENABLE_WEBKIT OFF)
-endif ()
-
WEBKIT_OPTION_BEGIN()
# PlayStation Specific Options
Modified: trunk/Source/cmake/WebKitCommon.cmake (290635 => 290636)
--- trunk/Source/cmake/WebKitCommon.cmake 2022-03-01 09:01:13 UTC (rev 290635)
+++ trunk/Source/cmake/WebKitCommon.cmake 2022-03-01 09:36:58 UTC (rev 290636)
@@ -13,13 +13,18 @@
message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
endif ()
-set(ENABLE_JAVASCRIPTCORE ON)
-set(ENABLE_WEBCORE ON)
+option(ENABLE_JAVASCRIPTCORE "Enable building _javascript_Core" ON)
+option(ENABLE_WEBCORE "Enable building _javascript_Core" ON)
+option(ENABLE_WEBKIT "Enable building WebKit" ON)
-if (NOT DEFINED ENABLE_WEBKIT)
-set(ENABLE_WEBKIT ON)
+if (NOT ENABLE_JAVASCRIPTCORE)
+set(ENABLE_WEBCORE OFF)
endif ()
+if (NOT ENABLE_WEBCORE)
+set(ENABLE_WEBKIT OFF)
+endif ()
+
if (NOT DEFINED ENABLE_TOOLS AND EXISTS "${CMAKE_SOURCE_DIR}/Tools")
set(ENABLE_TOOLS ON)
endif ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290551] trunk/Source/JavaScriptCore
Title: [290551] trunk/Source/_javascript_Core
Revision 290551
Author basuke.suz...@sony.com
Date 2022-02-26 14:12:25 -0800 (Sat, 26 Feb 2022)
Log Message
Remove UNUSED warnings for non-Cocoa platform after r290449
https://bugs.webkit.org/show_bug.cgi?id=237233
Reviewed by Darin Adler.
* runtime/JSDateMath.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSDateMath.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (290550 => 290551)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-26 21:04:49 UTC (rev 290550)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-26 22:12:25 UTC (rev 290551)
@@ -1,3 +1,12 @@
+2022-02-26 Basuke Suzuki
+
+Remove UNUSED warnings for non-Cocoa platform after r290449
+https://bugs.webkit.org/show_bug.cgi?id=237233
+
+Reviewed by Darin Adler.
+
+* runtime/JSDateMath.cpp:
+
2022-02-24 Mark Lam
Remove incorrect ASSERT.
Modified: trunk/Source/_javascript_Core/runtime/JSDateMath.cpp (290550 => 290551)
--- trunk/Source/_javascript_Core/runtime/JSDateMath.cpp 2022-02-26 21:04:49 UTC (rev 290550)
+++ trunk/Source/_javascript_Core/runtime/JSDateMath.cpp 2022-02-26 22:12:25 UTC (rev 290551)
@@ -97,7 +97,9 @@
namespace JSC {
+#if PLATFORM(COCOA)
static std::atomic lastTimeZoneID { 1 };
+#endif
#if HAVE(ICU_C_TIMEZONE_API)
class OpaqueICUTimeZone {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290541] trunk/Source/bmalloc
Title: [290541] trunk/Source/bmalloc
Revision 290541
Author basuke.suz...@sony.com
Date 2022-02-25 19:59:24 -0800 (Fri, 25 Feb 2022)
Log Message
[libpas] Suppress cast-align warnings
https://bugs.webkit.org/show_bug.cgi?id=237179
Reviewed by Yusuke Suzuki.
Ignore cast-align warnings for libpas target.
* CMakeLists.txt:
* libpas/src/libpas/bmalloc_heap_inlines.h:
Modified Paths
trunk/Source/bmalloc/CMakeLists.txt
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h
Diff
Modified: trunk/Source/bmalloc/CMakeLists.txt (290540 => 290541)
--- trunk/Source/bmalloc/CMakeLists.txt 2022-02-26 02:03:23 UTC (rev 290540)
+++ trunk/Source/bmalloc/CMakeLists.txt 2022-02-26 03:59:24 UTC (rev 290541)
@@ -695,7 +695,9 @@
libpas/src/libpas/pas_fast_megapage_cache.c
PROPERTIES LANGUAGE CXX)
-WEBKIT_ADD_TARGET_CXX_FLAGS(bmalloc -Wno-missing-field-initializers)
+WEBKIT_ADD_TARGET_CXX_FLAGS(bmalloc
+-Wno-missing-field-initializers
+-Wno-cast-align)
# Only build mbmalloc on platforms that MallocBench supports
if (DEVELOPER_MODE AND (APPLE OR HAVE_MALLOC_TRIM))
Modified: trunk/Source/bmalloc/ChangeLog (290540 => 290541)
--- trunk/Source/bmalloc/ChangeLog 2022-02-26 02:03:23 UTC (rev 290540)
+++ trunk/Source/bmalloc/ChangeLog 2022-02-26 03:59:24 UTC (rev 290541)
@@ -1,3 +1,16 @@
+2022-02-25 Basuke Suzuki
+
+[libpas] Suppress cast-align warnings
+https://bugs.webkit.org/show_bug.cgi?id=237179
+
+
+Reviewed by Yusuke Suzuki.
+
+Ignore cast-align warnings for libpas target.
+
+* CMakeLists.txt:
+* libpas/src/libpas/bmalloc_heap_inlines.h:
+
2022-02-23 Basuke Suzuki
[libpas] PlayStation uses 16k page size.
Modified: trunk/Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h (290540 => 290541)
--- trunk/Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h 2022-02-26 02:03:23 UTC (rev 290540)
+++ trunk/Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h 2022-02-26 03:59:24 UTC (rev 290541)
@@ -29,6 +29,7 @@
#include "pas_platform.h"
PAS_IGNORE_WARNINGS_BEGIN("missing-field-initializers")
+PAS_IGNORE_WARNINGS_BEGIN("cast-align")
#include "bmalloc_heap.h"
#include "bmalloc_heap_config.h"
@@ -577,6 +578,7 @@
#endif /* PAS_ENABLE_BMALLOC */
PAS_IGNORE_WARNINGS_END
+PAS_IGNORE_WARNINGS_END
#endif /* BMALLOC_HEAP_INLINES_H */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290390] trunk/Source/bmalloc
Title: [290390] trunk/Source/bmalloc Revision 290390 Author basuke.suz...@sony.com Date 2022-02-23 12:59:41 -0800 (Wed, 23 Feb 2022) Log Message [libpas] PlayStation uses 16k page size. https://bugs.webkit.org/show_bug.cgi?id=237096 Reviewed by Yusuke Suzuki. Match the granule default size to system page size for our platform. * libpas/src/libpas/pas_internal_config.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h Diff Modified: trunk/Source/bmalloc/ChangeLog (290389 => 290390) --- trunk/Source/bmalloc/ChangeLog 2022-02-23 20:57:36 UTC (rev 290389) +++ trunk/Source/bmalloc/ChangeLog 2022-02-23 20:59:41 UTC (rev 290390) @@ -1 +1,12 @@ +2022-02-23 Basuke Suzuki + +[libpas] PlayStation uses 16k page size. +https://bugs.webkit.org/show_bug.cgi?id=237096 + +Reviewed by Yusuke Suzuki. + +Match the granule default size to system page size for our platform. + +* libpas/src/libpas/pas_internal_config.h: + == Rolled over to ChangeLog-2022-02-22 == Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h (290389 => 290390) --- trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h 2022-02-23 20:57:36 UTC (rev 290389) +++ trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h 2022-02-23 20:59:41 UTC (rev 290390) @@ -49,7 +49,7 @@ #define PAS_MARGE_PAGE_DEFAULT_SHIFT 22 #define PAS_MARGE_PAGE_DEFAULT_SIZE ((size_t)1 << PAS_MARGE_PAGE_DEFAULT_SHIFT) -#if PAS_ARM64 +#if PAS_ARM64 || PAS_PLATFORM(PLAYSTATION) #define PAS_GRANULE_DEFAULT_SHIFT14 #else #define PAS_GRANULE_DEFAULT_SHIFT12 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287051] trunk/Source/WebCore
Title: [287051] trunk/Source/WebCore
Revision 287051
Author basuke.suz...@sony.com
Date 2021-12-14 14:38:09 -0800 (Tue, 14 Dec 2021)
Log Message
[Playstation] Fix build break after r286908
https://bugs.webkit.org/show_bug.cgi?id=234311
Unreviewed, build fix for PlayStation platform after r286908.
https://trac.webkit.org/changeset/286908/webkit
* platform/graphics/PlatformVideoColorSpace.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformVideoColorSpace.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (287050 => 287051)
--- trunk/Source/WebCore/ChangeLog 2021-12-14 22:36:14 UTC (rev 287050)
+++ trunk/Source/WebCore/ChangeLog 2021-12-14 22:38:09 UTC (rev 287051)
@@ -1,3 +1,13 @@
+2021-12-14 Basuke Suzuki
+
+[Playstation] Fix build break after r286908
+https://bugs.webkit.org/show_bug.cgi?id=234311
+
+Unreviewed, build fix for PlayStation platform after r286908.
+https://trac.webkit.org/changeset/286908/webkit
+
+* platform/graphics/PlatformVideoColorSpace.h:
+
2021-12-14 Alex Christensen
Revert r284816
Modified: trunk/Source/WebCore/platform/graphics/PlatformVideoColorSpace.h (287050 => 287051)
--- trunk/Source/WebCore/platform/graphics/PlatformVideoColorSpace.h 2021-12-14 22:36:14 UTC (rev 287050)
+++ trunk/Source/WebCore/platform/graphics/PlatformVideoColorSpace.h 2021-12-14 22:38:09 UTC (rev 287051)
@@ -28,6 +28,7 @@
#include "PlatformVideoColorPrimaries.h"
#include "PlatformVideoMatrixCoefficients.h"
#include "PlatformVideoTransferCharacteristics.h"
+#include
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286029] trunk/Source/bmalloc
Title: [286029] trunk/Source/bmalloc Revision 286029 Author basuke.suz...@sony.com Date 2021-11-18 14:21:54 -0800 (Thu, 18 Nov 2021) Log Message [bmalloc] freeableMemory and footprint of Heap are completely broken https://bugs.webkit.org/show_bug.cgi?id=230245 Reviewed by Geoffrey Garen. This introduced in r279922. The physical size of the newly allocated range was changed from zero to the size of the range on that commit and that causes the numbers wrong. That change itself is correct fix because the range has physical pages attached. That simply activated the bug which was there for a long time. I've added the correction to adjust both numbers with newly allocated region. Also added an optional assertion to check the overflow of those values and the option to log those value change to the console. Fortunately those numbers are used for debugging purpose. Scavenger will dump out those to stderr with its verbose mode. There's no practical cases affected by this bug. Here is the example of footprint logging before fixing the bug: >>> footprint: 18446744073709535232 (-16384) scavenge footprint: 18446744073709518848 (-16384) scavenge footprint: 18446744073709502464 (-16384) scavenge footprint: 18446744073709486080 (-16384) scavenge footprint: 18446744073709469696 (-16384) scavenge footprint: 18446744073709453312 (-16384) scavenge ... It just began with negative number which overflows on unsigned. And following is the one with fix: footprint: 1048576 (1048576) allocateLarge footprint: 2097152 (1048576) allocateLarge footprint: 3145728 (1048576) allocateLarge footprint: 4194304 (1048576) allocateLarge footprint: 5242880 (1048576) allocateLarge footprint: 6291456 (1048576) allocateLarge >>> footprint: 6275072 (-16384) scavenge footprint: 6258688 (-16384) scavenge footprint: 6242304 (-16384) scavenge footprint: 6225920 (-16384) scavenge footprint: 6209536 (-16384) scavenge footprint: 6193152 (-16384) scavenge ... * bmalloc/Heap.cpp: (bmalloc::Heap::adjustStat): (bmalloc::Heap::logStat): (bmalloc::Heap::adjustFreeableMemory): (bmalloc::Heap::adjustFootprint): (bmalloc::Heap::decommitLargeRange): (bmalloc::Heap::scavenge): (bmalloc::Heap::allocateSmallChunk): (bmalloc::Heap::allocateSmallPage): (bmalloc::Heap::deallocateSmallLine): (bmalloc::Heap::splitAndAllocate): (bmalloc::Heap::allocateLarge): (bmalloc::Heap::deallocateLarge): (bmalloc::Heap::externalCommit): (bmalloc::Heap::externalDecommit): * bmalloc/Heap.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Heap.cpp trunk/Source/bmalloc/bmalloc/Heap.h Diff Modified: trunk/Source/bmalloc/ChangeLog (286028 => 286029) --- trunk/Source/bmalloc/ChangeLog 2021-11-18 22:10:11 UTC (rev 286028) +++ trunk/Source/bmalloc/ChangeLog 2021-11-18 22:21:54 UTC (rev 286029) @@ -1,3 +1,65 @@ +2021-11-18 Basuke Suzuki + +[bmalloc] freeableMemory and footprint of Heap are completely broken +https://bugs.webkit.org/show_bug.cgi?id=230245 + + +Reviewed by Geoffrey Garen. + +This introduced in r279922. The physical size of the newly allocated range was changed from zero +to the size of the range on that commit and that causes the numbers wrong. That change itself is +correct fix because the range has physical pages attached. That simply activated the bug which was +there for a long time. + +I've added the correction to adjust both numbers with newly allocated region. Also added an optional +assertion to check the overflow of those values and the option to log those value change to the console. + +Fortunately those numbers are used for debugging purpose. Scavenger will dump out those to stderr +with its verbose mode. There's no practical cases affected by this bug. + +Here is the example of footprint logging before fixing the bug: + +>>> footprint: 18446744073709535232 (-16384) scavenge +footprint: 18446744073709518848 (-16384) scavenge +footprint: 18446744073709502464 (-16384) scavenge +footprint: 18446744073709486080 (-16384) scavenge +footprint: 18446744073709469696 (-16384) scavenge +footprint: 18446744073709453312 (-16384) scavenge +... + +It just began with negative number which overflows on unsigned. And following is the one with fix: + +footprint: 1048576 (1048576) allocateLarge +footprint: 2097152 (1048576) allocateLarge +footprint: 3145728 (1048576) allocateLarge +footprint: 4194304 (1048576) allocateLarge +footprint: 5242880 (1048576) allocateLarge +footprint: 6291456 (1048576) allocateLarge +
[webkit-changes] [284306] trunk
Title: [284306] trunk
Revision 284306
Author basuke.suz...@sony.com
Date 2021-10-15 22:31:25 -0700 (Fri, 15 Oct 2021)
Log Message
Add flag to turn off Iso heap
https://bugs.webkit.org/show_bug.cgi?id=231823
Reviewed by Yusuke Suzuki.
.:
Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/WebKitFeatures.cmake:
Source/WTF:
If this flag is off, then all allocations are replaced with FastMalloc.
* wtf/IsoMalloc.h:
* wtf/IsoMallocInlines.h:
* wtf/PlatformUse.h:
Tools:
Added --(no-)iso-malloc feature flag for cmake build.
* Scripts/webkitperl/FeatureList.pm:
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/IsoMalloc.h
trunk/Source/WTF/wtf/IsoMallocInlines.h
trunk/Source/WTF/wtf/PlatformUse.h
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Diff
Modified: trunk/ChangeLog (284305 => 284306)
--- trunk/ChangeLog 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/ChangeLog 2021-10-16 05:31:25 UTC (rev 284306)
@@ -1,3 +1,15 @@
+2021-10-15 Basuke Suzuki
+
+Add flag to turn off Iso heap
+https://bugs.webkit.org/show_bug.cgi?id=231823
+
+Reviewed by Yusuke Suzuki.
+
+Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
+
+* Source/cmake/OptionsPlayStation.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+
2021-10-15 Ross Kirsling
Realize Mac CMake build of WebCore and WebKit
Modified: trunk/Source/WTF/ChangeLog (284305 => 284306)
--- trunk/Source/WTF/ChangeLog 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/ChangeLog 2021-10-16 05:31:25 UTC (rev 284306)
@@ -1,3 +1,16 @@
+2021-10-15 Basuke Suzuki
+
+Add flag to turn off Iso heap
+https://bugs.webkit.org/show_bug.cgi?id=231823
+
+Reviewed by Yusuke Suzuki.
+
+If this flag is off, then all allocations are replaced with FastMalloc.
+
+* wtf/IsoMalloc.h:
+* wtf/IsoMallocInlines.h:
+* wtf/PlatformUse.h:
+
2021-10-15 Ross Kirsling
Realize Mac CMake build of WebCore and WebKit
Modified: trunk/Source/WTF/wtf/IsoMalloc.h (284305 => 284306)
--- trunk/Source/WTF/wtf/IsoMalloc.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/IsoMalloc.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -26,8 +26,9 @@
#pragma once
#include
+#include
-#if (USE(SYSTEM_MALLOC))
+#if USE(SYSTEM_MALLOC) || !USE(ISO_MALLOC)
#include
Modified: trunk/Source/WTF/wtf/IsoMallocInlines.h (284305 => 284306)
--- trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -25,8 +25,10 @@
#pragma once
-#if (USE(SYSTEM_MALLOC))
+#include
+#if USE(SYSTEM_MALLOC) || !USE(ISO_MALLOC)
+
#include
#define WTF_MAKE_ISO_ALLOCATED_INLINE(name) WTF_MAKE_FAST_ALLOCATED
Modified: trunk/Source/WTF/wtf/PlatformUse.h (284305 => 284306)
--- trunk/Source/WTF/wtf/PlatformUse.h 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/WTF/wtf/PlatformUse.h 2021-10-16 05:31:25 UTC (rev 284306)
@@ -355,3 +355,7 @@
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12
#define USE_VORBIS_AUDIOCOMPONENT_WORKAROUND 1
#endif
+
+#if !defined(USE_ISO_MALLOC)
+#define USE_ISO_MALLOC 1
+#endif
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (284305 => 284306)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-16 05:31:25 UTC (rev 284306)
@@ -36,6 +36,9 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DFG_JIT PRIVATE OFF)
+# Don't use IsoMalloc
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_ISO_MALLOC PRIVATE OFF)
+
# Enabled features
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (284305 => 284306)
--- trunk/Source/cmake/WebKitFeatures.cmake 2021-10-16 04:38:16 UTC (rev 284305)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2021-10-16 05:31:25 UTC (rev 284306)
@@ -235,6 +235,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_WEBXR "Toggle WebXR support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_WIRELESS_PLAYBACK_TARGET "Toggle wireless playback target support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_XSLT "Toggle XSLT support" PRIVATE ON)
+WEBKIT_OPTION_DEFINE(USE_ISO_MALLOC "Toggle IsoMalloc support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC "Toggle system allocator instead of WebKit's custom allocator" PRIVATE ${USE_SYSTEM_MALLOC_DEFAULT})
WEBKIT_OPTION_CONFLICT(ENABLE_JIT ENABLE_C_LOOP)
Modified: trunk
[webkit-changes] [284065] trunk
Title: [284065] trunk
Revision 284065
Author basuke.suz...@sony.com
Date 2021-10-12 17:18:56 -0700 (Tue, 12 Oct 2021)
Log Message
[PlayStation] Enable RemoteInspector by default
https://bugs.webkit.org/show_bug.cgi?id=231599
Reviewed by Fujii Hironori.
It was treated as experimental feature but we've depended on this feature in various situation.
* Source/cmake/OptionsPlayStation.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/ChangeLog (284064 => 284065)
--- trunk/ChangeLog 2021-10-13 00:14:33 UTC (rev 284064)
+++ trunk/ChangeLog 2021-10-13 00:18:56 UTC (rev 284065)
@@ -1,3 +1,14 @@
+2021-10-12 Basuke Suzuki
+
+[PlayStation] Enable RemoteInspector by default
+https://bugs.webkit.org/show_bug.cgi?id=231599
+
+Reviewed by Fujii Hironori.
+
+It was treated as experimental feature but we've depended on this feature in various situation.
+
+* Source/cmake/OptionsPlayStation.cmake:
+
2021-10-12 Philippe Normand
Add my github username to contributors.json
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (284064 => 284065)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-13 00:14:33 UTC (rev 284064)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-10-13 00:18:56 UTC (rev 284065)
@@ -43,6 +43,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
# Experimental features
@@ -52,7 +53,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GPU_PROCESS PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LAYOUT_FORMATTING_CONTEXT PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283834] trunk/Source/WebKit
Title: [283834] trunk/Source/WebKit
Revision 283834
Author basuke.suz...@sony.com
Date 2021-10-08 13:01:18 -0700 (Fri, 08 Oct 2021)
Log Message
Fix build break after r283796 when ENABLE_SERVICE_WORKER is off
https://bugs.webkit.org/show_bug.cgi?id=231440
Unreviewed build fix.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::hasServiceWorkerBackgroundActivityForTesting const):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (283833 => 283834)
--- trunk/Source/WebKit/ChangeLog 2021-10-08 19:53:57 UTC (rev 283833)
+++ trunk/Source/WebKit/ChangeLog 2021-10-08 20:01:18 UTC (rev 283834)
@@ -1,3 +1,13 @@
+2021-10-08 Basuke Suzuki
+
+Fix build break after r283796 when ENABLE_SERVICE_WORKER is off
+https://bugs.webkit.org/show_bug.cgi?id=231440
+
+Unreviewed build fix.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::hasServiceWorkerBackgroundActivityForTesting const):
+
2021-10-08 Myles C. Maxfield
[GPU Process] Unique RenderingResourceIdentifiers Part 4: Migrate PendingWakeupInformation to QualifiedRenderingResourceIdentifier
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (283833 => 283834)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2021-10-08 19:53:57 UTC (rev 283833)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2021-10-08 20:01:18 UTC (rev 283834)
@@ -1009,7 +1009,11 @@
bool WebsiteDataStore::hasServiceWorkerBackgroundActivityForTesting() const
{
+#if ENABLE(SERVICE_WORKER)
return WTF::anyOf(WebProcessPool::allProcessPools(), [](auto& pool) { return pool->hasServiceWorkerBackgroundActivityForTesting(); });
+#else
+return false;
+#endif
}
#if ENABLE(INTELLIGENT_TRACKING_PREVENTION)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283702] trunk/Source/WebKit
Title: [283702] trunk/Source/WebKit
Revision 283702
Author basuke.suz...@sony.com
Date 2021-10-07 00:56:31 -0700 (Thu, 07 Oct 2021)
Log Message
Change the confusing feature name for testing purpose
https://bugs.webkit.org/show_bug.cgi?id=231259
Reviewed by Tim Horton.
ENABLE(EXPERIMENTAL_FEATURE) was used in the test, but that is very confusing with
ENABLE_EXPERIMENTAL_FEATURES. Change them to more obvious ENABLE(FEATURE_FOR_TESTING).
* Scripts/webkit/parser_unittest.py:
* Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::jsValueForArguments):
(IPC::messageArgumentDescriptions):
* Scripts/webkit/tests/MessageNames.cpp:
(IPC::isValidMessageName):
* Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
* Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
* Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
* Scripts/webkit/tests/TestWithoutAttributes.messages.in:
* Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
(WebKit::TestWithoutAttributes::didReceiveMessage):
* Scripts/webkit/tests/TestWithoutAttributesMessages.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/parser_unittest.py
trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
trunk/Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in
trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h
trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in
trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp
trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (283701 => 283702)
--- trunk/Source/WebKit/ChangeLog 2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/ChangeLog 2021-10-07 07:56:31 UTC (rev 283702)
@@ -1,3 +1,28 @@
+2021-10-07 Basuke Suzuki
+
+Change the confusing feature name for testing purpose
+https://bugs.webkit.org/show_bug.cgi?id=231259
+
+Reviewed by Tim Horton.
+
+ENABLE(EXPERIMENTAL_FEATURE) was used in the test, but that is very confusing with
+ENABLE_EXPERIMENTAL_FEATURES. Change them to more obvious ENABLE(FEATURE_FOR_TESTING).
+
+* Scripts/webkit/parser_unittest.py:
+* Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
+(IPC::jsValueForArguments):
+(IPC::messageArgumentDescriptions):
+* Scripts/webkit/tests/MessageNames.cpp:
+(IPC::isValidMessageName):
+* Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
+* Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
+(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
+* Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
+* Scripts/webkit/tests/TestWithoutAttributes.messages.in:
+* Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
+(WebKit::TestWithoutAttributes::didReceiveMessage):
+* Scripts/webkit/tests/TestWithoutAttributesMessages.h:
+
2021-10-06 Timothy Hatcher
_WKRemoteObjectRegistry's ReplyBlockCallChecker should always dealloc on the main thread
Modified: trunk/Source/WebKit/Scripts/webkit/parser_unittest.py (283701 => 283702)
--- trunk/Source/WebKit/Scripts/webkit/parser_unittest.py 2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/parser_unittest.py 2021-10-07 07:56:31 UTC (rev 283702)
@@ -218,7 +218,7 @@
'parameters': (
('IPC::DummyType', 'dummy'),
),
-'conditions': ('ENABLE(EXPERIMENTAL_FEATURE)'),
+'conditions': ('ENABLE(FEATURE_FOR_TESTING)'),
}
),
}
Modified: trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp (283701 => 283702)
--- trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp 2021-10-07 05:33:35 UTC (rev 283701)
+++ trunk/Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp 2021-10-07 07:56:31 UTC (rev 283702)
@@ -39,7 +39,7 @@
#if (ENABLE(WEBKIT2) && (NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND))
#include "ArgumentCoders.h"
#include "Connection.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FOR_TESTING)
#include "DummyType.h"
#endif
#if PLATFORM(MAC)
@@ -71,7 +71,7 @@
#if (ENABLE(WEBKIT2) && (NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND))
#include "ArgumentCoders.h"
#include "Connection.h"
-#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE)
+#if ENABLE(DEPRECATED_FEATURE) || ENABLE(FEATURE_FO
[webkit-changes] [283602] trunk/Source/WebCore
Title: [283602] trunk/Source/WebCore
Revision 283602
Author basuke.suz...@sony.com
Date 2021-10-05 23:14:37 -0700 (Tue, 05 Oct 2021)
Log Message
[PlayStation] Fix build break after r283441
https://bugs.webkit.org/show_bug.cgi?id=231277
Unreviewed.
No new tests because there is no behavior change.
* platform/graphics/Path.h:
(WebCore::Path::strokeBoundingRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (283601 => 283602)
--- trunk/Source/WebCore/ChangeLog 2021-10-06 05:40:07 UTC (rev 283601)
+++ trunk/Source/WebCore/ChangeLog 2021-10-06 06:14:37 UTC (rev 283602)
@@ -1,3 +1,15 @@
+2021-10-05 Basuke Suzuki
+
+[PlayStation] Fix build break after r283441
+https://bugs.webkit.org/show_bug.cgi?id=231277
+
+Unreviewed.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/Path.h:
+(WebCore::Path::strokeBoundingRect):
+
2021-10-05 Tyler Wilcock
AX: Move handling of AXContents from platform wrapper to AX core
Modified: trunk/Source/WebCore/platform/graphics/Path.h (283601 => 283602)
--- trunk/Source/WebCore/platform/graphics/Path.h 2021-10-06 05:40:07 UTC (rev 283601)
+++ trunk/Source/WebCore/platform/graphics/Path.h 2021-10-06 06:14:37 UTC (rev 283602)
@@ -137,13 +137,13 @@
static Path polygonPathFromPoints(const Vector&);
bool contains(const FloatPoint&, WindRule = WindRule::NonZero) const;
-bool strokeContains(const FloatPoint&, const Function& strokeStyleApplier) const;
+bool strokeContains(const FloatPoint&, const WTF::Function& strokeStyleApplier) const;
// fastBoundingRect() should equal or contain boundingRect(); boundingRect()
// should perfectly bound the points within the path.
FloatRect boundingRect() const;
WEBCORE_EXPORT FloatRect fastBoundingRect() const;
-FloatRect strokeBoundingRect(const Function& strokeStyleApplier = { }) const;
+FloatRect strokeBoundingRect(const WTF::Function& strokeStyleApplier = { }) const;
WEBCORE_EXPORT size_t elementCount() const;
float length() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283478] trunk/Source/WebKit
Title: [283478] trunk/Source/WebKit
Revision 283478
Author basuke.suz...@sony.com
Date 2021-10-03 14:02:20 -0700 (Sun, 03 Oct 2021)
Log Message
[PlayStation] Pass logging channel parameter to WebProcess from environment variable
https://bugs.webkit.org/show_bug.cgi?id=230726
Reviewed by Fujii Hironori.
Added release log configuration environment variables to PlayStation port.
* UIProcess/playstation/WebProcessPoolPlayStation.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/playstation/WebProcessPlayStation.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp
trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (283477 => 283478)
--- trunk/Source/WebKit/ChangeLog 2021-10-03 19:32:52 UTC (rev 283477)
+++ trunk/Source/WebKit/ChangeLog 2021-10-03 21:02:20 UTC (rev 283478)
@@ -1,3 +1,18 @@
+2021-10-03 Basuke Suzuki
+
+[PlayStation] Pass logging channel parameter to WebProcess from environment variable
+https://bugs.webkit.org/show_bug.cgi?id=230726
+
+
+Reviewed by Fujii Hironori.
+
+Added release log configuration environment variables to PlayStation port.
+
+* UIProcess/playstation/WebProcessPoolPlayStation.cpp:
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+* WebProcess/playstation/WebProcessPlayStation.cpp:
+(WebKit::WebProcess::platformInitializeWebProcess):
+
2021-10-03 David Kilzer
WTF::RetainPtr<> allows assignment of two pointer types that are not assignable
Modified: trunk/Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp (283477 => 283478)
--- trunk/Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp 2021-10-03 19:32:52 UTC (rev 283477)
+++ trunk/Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp 2021-10-03 21:02:20 UTC (rev 283478)
@@ -26,6 +26,8 @@
#include "config.h"
#include "WebProcessPool.h"
+#include "WebProcessCreationParameters.h"
+
namespace WebKit {
void WebProcessPool::platformInitialize()
@@ -38,9 +40,19 @@
notImplemented();
}
-void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters&)
+void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& parameters)
{
-notImplemented();
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
+char buf[2048];
+if (getenv_np("WTFLogging", buf, sizeof(buf)))
+parameters.wtfLoggingChannels = buf;
+if (getenv_np("WebCoreLogging", buf, sizeof(buf)))
+parameters.webCoreLoggingChannels = buf;
+if (getenv_np("WebKitLogging", buf, sizeof(buf)))
+parameters.webKitLoggingChannels = buf;
+#else
+UNUSED_PARAM(parameters);
+#endif
}
void WebProcessPool::platformInvalidateContext()
Modified: trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp (283477 => 283478)
--- trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp 2021-10-03 19:32:52 UTC (rev 283477)
+++ trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp 2021-10-03 21:02:20 UTC (rev 283478)
@@ -26,10 +26,21 @@
#include "config.h"
#include "WebProcess.h"
+#include "LogInitialization.h"
+#include
+#include
+
namespace WebKit {
-void WebProcess::platformInitializeWebProcess(WebProcessCreationParameters&)
+void WebProcess::platformInitializeWebProcess(WebProcessCreationParameters& parameters)
{
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
+WTF::logChannels().initializeLogChannelsIfNecessary(parameters.wtfLoggingChannels);
+WebCore::logChannels().initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels);
+WebKit::logChannels().initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels);
+#else
+UNUSED_PARAM(parameters);
+#endif
}
void WebProcess::platformSetWebsiteDataStoreParameters(WebProcessDataStoreParameters&&)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283469] trunk
Title: [283469] trunk
Revision 283469
Author basuke.suz...@sony.com
Date 2021-10-03 10:19:59 -0700 (Sun, 03 Oct 2021)
Log Message
Enable release log to stderr
https://bugs.webkit.org/show_bug.cgi?id=230725
Reviewed by Michael Catanzaro.
.:
Introduced new flags, USE_LOG_STDERR for release logging to stderr.
* Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
SQLiteDatabase uses hard-coded %{public} format specifiers. Replace them with defined
macro.
No new tests because there is no behavior change.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::prepareStatementSlow):
(WebCore::SQLiteDatabase::prepareStatement):
(WebCore::SQLiteDatabase::prepareHeapStatementSlow):
(WebCore::SQLiteDatabase::prepareHeapStatement):
Source/WTF:
Define new compiler definitions, USE_LOG_STDERR for release logging. We don't have
modern logging backend so that dumping out to stdout/stderr is still very valuable.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/Logger.h:
(WTF::Logger::log):
(WTF::Logger::logVerbose):
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.cpp
trunk/Source/WTF/wtf/Assertions.h
trunk/Source/WTF/wtf/Logger.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp
trunk/Source/cmake/WebKitFeatures.cmake
Diff
Modified: trunk/ChangeLog (283468 => 283469)
--- trunk/ChangeLog 2021-10-03 17:10:45 UTC (rev 283468)
+++ trunk/ChangeLog 2021-10-03 17:19:59 UTC (rev 283469)
@@ -1,3 +1,15 @@
+2021-10-03 Basuke Suzuki
+
+Enable release log to stderr
+https://bugs.webkit.org/show_bug.cgi?id=230725
+
+
+Reviewed by Michael Catanzaro.
+
+Introduced new flags, USE_LOG_STDERR for release logging to stderr.
+
+* Source/cmake/WebKitFeatures.cmake:
+
2021-10-02 Philippe Normand
[GTK][WPE] Enable bwrap launcher build on bots
Modified: trunk/Source/WTF/ChangeLog (283468 => 283469)
--- trunk/Source/WTF/ChangeLog 2021-10-03 17:10:45 UTC (rev 283468)
+++ trunk/Source/WTF/ChangeLog 2021-10-03 17:19:59 UTC (rev 283469)
@@ -1,3 +1,20 @@
+2021-10-03 Basuke Suzuki
+
+Enable release log to stderr
+https://bugs.webkit.org/show_bug.cgi?id=230725
+
+
+Reviewed by Michael Catanzaro.
+
+Define new compiler definitions, USE_LOG_STDERR for release logging. We don't have
+modern logging backend so that dumping out to stdout/stderr is still very valuable.
+
+* wtf/Assertions.cpp:
+* wtf/Assertions.h:
+* wtf/Logger.h:
+(WTF::Logger::log):
+(WTF::Logger::logVerbose):
+
2021-10-02 Philippe Normand
[GLib] Media session manager unable to handle more than one session
Modified: trunk/Source/WTF/wtf/Assertions.cpp (283468 => 283469)
--- trunk/Source/WTF/wtf/Assertions.cpp 2021-10-03 17:10:45 UTC (rev 283468)
+++ trunk/Source/WTF/wtf/Assertions.cpp 2021-10-03 17:19:59 UTC (rev 283469)
@@ -59,7 +59,7 @@
#include
#endif
-#if USE(JOURNALD)
+#if !RELEASE_LOG_DISABLED && !USE(OS_LOG)
#include
#endif
@@ -601,7 +601,7 @@
os_log(channel->osLogChannel, "%-3d %p %{public}s", frameNumber, stackFrame, demangled->mangledName());
else
os_log(channel->osLogChannel, "%-3d %p", frameNumber, stackFrame);
-#elif USE(JOURNALD)
+#else
StringPrintStream out;
if (demangled && demangled->demangledName())
out.printf("%-3d %p %s", frameNumber, stackFrame, demangled->demangledName());
@@ -609,8 +609,12 @@
out.printf("%-3d %p %s", frameNumber, stackFrame, demangled->mangledName());
else
out.printf("%-3d %p", frameNumber, stackFrame);
+#if USE(JOURNALD)
sd_journal_send("WEBKIT_SUBSYSTEM=%s", channel->subsystem, "WEBKIT_CHANNEL=%s", channel->name, "MESSAGE=%s", out.toCString().data(), nullptr);
+#else
+fprintf(stderr, "[%s:%s:-] %s\n", channel->subsystem, channel->name, out.toCString().data());
#endif
+#endif
}
}
}
Modified: trunk/Source/WTF/wtf/Assertions.h (283468 => 283469)
--- trunk/Source/WTF/wtf/Assertions.h 2021-10-03 17:10:45 UTC (rev 283468)
+++ trunk/Source/WTF/wtf/Assertions.h 2021-10-03 17:19:59 UTC (rev 283469)
@@ -95,7 +95,9 @@
#define LOG_DISABLED !ASSERT_ENABLED
#endif
-#ifndef RELEASE_LOG_DISABLED
+#if ENABLE(RELEASE_LOG)
+#define RELEASE_LOG_DISABLED 0
+#else
#define RELEASE_LOG_DISABLED !(USE(OS_LOG) || USE(JOURNALD))
#endif
@@ -163,10 +165,10 @@
WTFLogLevel level;
#if !RELEASE_LOG_DISABLED
const char* subsystem;
-#endif
-#if USE(OS_LOG) && !RELEASE_LOG_DISABLED
+#if USE(OS_LOG)
__unsafe_unretained os_log_t osLogChannel;
#endif
+#endif
} WTFLogChannel;
#define LOG_CHANNEL(name
[webkit-changes] [283287] trunk/Source
Title: [283287] trunk/Source
Revision 283287
Author basuke.suz...@sony.com
Date 2021-09-29 17:21:20 -0700 (Wed, 29 Sep 2021)
Log Message
Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
https://bugs.webkit.org/show_bug.cgi?id=230963
Reviewed by Mark Lam.
Source/_javascript_Core:
Added default copy constructor to suppress warning.
* bytecode/Operands.h:
Source/WebCore:
No new tests because there is no behavior change.
Added default copy constructor / copy assignment operator to suppress warning.
* platform/LayoutUnit.h:
* platform/LengthBox.h:
* platform/RectEdges.h:
* platform/graphics/FontSelectionAlgorithm.h:
* platform/graphics/ImagePaintingOptions.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Operands.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LayoutUnit.h
trunk/Source/WebCore/platform/LengthBox.h
trunk/Source/WebCore/platform/RectEdges.h
trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h
trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (283286 => 283287)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,5 +1,16 @@
2021-09-29 Basuke Suzuki
+Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+https://bugs.webkit.org/show_bug.cgi?id=230963
+
+Reviewed by Mark Lam.
+
+Added default copy constructor to suppress warning.
+
+* bytecode/Operands.h:
+
+2021-09-29 Basuke Suzuki
+
[JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics
https://bugs.webkit.org/show_bug.cgi?id=230957
Modified: trunk/Source/_javascript_Core/bytecode/Operands.h (283286 => 283287)
--- trunk/Source/_javascript_Core/bytecode/Operands.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/bytecode/Operands.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -68,6 +68,8 @@
}
static Operand tmp(uint32_t index) { return Operand(OperandKind::Tmp, index); }
+Operand& operator=(const Operand&) = default;
+
OperandKind kind() const { return m_kind; }
int value() const { return m_operand; }
VirtualRegister virtualRegister() const
Modified: trunk/Source/WebCore/ChangeLog (283286 => 283287)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,3 +1,20 @@
+2021-09-29 Basuke Suzuki
+
+Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+https://bugs.webkit.org/show_bug.cgi?id=230963
+
+Reviewed by Mark Lam.
+
+No new tests because there is no behavior change.
+
+Added default copy constructor / copy assignment operator to suppress warning.
+
+* platform/LayoutUnit.h:
+* platform/LengthBox.h:
+* platform/RectEdges.h:
+* platform/graphics/FontSelectionAlgorithm.h:
+* platform/graphics/ImagePaintingOptions.h:
+
2021-09-29 Kiet Ho
Implement the 'ic' unit from CSS Values 4
Modified: trunk/Source/WebCore/platform/LayoutUnit.h (283286 => 283287)
--- trunk/Source/WebCore/platform/LayoutUnit.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LayoutUnit.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -65,6 +65,7 @@
class LayoutUnit {
public:
LayoutUnit() : m_value(0) { }
+LayoutUnit(const LayoutUnit&) = default;
LayoutUnit(int value) { setValue(value); }
LayoutUnit(unsigned short value) { setValue(value); }
LayoutUnit(unsigned value) { setValue(value); }
@@ -85,7 +86,7 @@
m_value = clampToInteger(value * kFixedPointDenominator);
}
-LayoutUnit& operator=(const LayoutUnit& other) = default;
+LayoutUnit& operator=(const LayoutUnit&) = default;
LayoutUnit& operator=(const float& other) { return *this = LayoutUnit(other); }
static LayoutUnit fromFloatCeil(float value)
Modified: trunk/Source/WebCore/platform/LengthBox.h (283286 => 283287)
--- trunk/Source/WebCore/platform/LengthBox.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LengthBox.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -55,6 +55,7 @@
}
LengthBox(const LengthBox&) = default;
+LengthBox& operator=(const LengthBox&) = default;
bool isZero() const
{
Modified: trunk/Source/WebCore/platform/RectEdges.h (283286 => 283287)
--- trunk/Source/WebCore/platform/RectEdges.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/RectEdges.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -46,6 +46,7 @@
RectEdges() = default;
RectEdges(const RectEdges&) = default;
+RectEdges& operat
[webkit-changes] [283286] trunk/Source/JavaScriptCore
Title: [283286] trunk/Source/_javascript_Core Revision 283286 Author basuke.suz...@sony.com Date 2021-09-29 17:19:07 -0700 (Wed, 29 Sep 2021) Log Message [JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics https://bugs.webkit.org/show_bug.cgi?id=230957 Reviewed by Yusuke Suzuki. * API/JSBase.cpp: Added objectTypeCounts property (JSGetMemoryUsageStatistics): * API/JSBasePrivate.h: Added description of objectTypeCounts property * jsc.cpp: Added memoryUsageStatistics() function Modified Paths trunk/Source/_javascript_Core/API/JSBase.cpp trunk/Source/_javascript_Core/API/JSBasePrivate.h trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jsc.cpp Diff Modified: trunk/Source/_javascript_Core/API/JSBase.cpp (283285 => 283286) --- trunk/Source/_javascript_Core/API/JSBase.cpp 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/API/JSBase.cpp 2021-09-30 00:19:07 UTC (rev 283286) @@ -204,6 +204,11 @@ VM& vm = globalObject->vm(); JSLockHolder locker(vm); +auto typeCounts = vm.heap.objectTypeCounts(); +JSObject* objectTypeCounts = constructEmptyObject(globalObject); +for (auto& it : *typeCounts) +objectTypeCounts->putDirect(vm, Identifier::fromString(vm, it.key), jsNumber(it.value)); + JSObject* object = constructEmptyObject(globalObject); object->putDirect(vm, Identifier::fromString(vm, "heapSize"), jsNumber(vm.heap.size())); object->putDirect(vm, Identifier::fromString(vm, "heapCapacity"), jsNumber(vm.heap.capacity())); @@ -212,6 +217,7 @@ object->putDirect(vm, Identifier::fromString(vm, "protectedObjectCount"), jsNumber(vm.heap.protectedObjectCount())); object->putDirect(vm, Identifier::fromString(vm, "globalObjectCount"), jsNumber(vm.heap.globalObjectCount())); object->putDirect(vm, Identifier::fromString(vm, "protectedGlobalObjectCount"), jsNumber(vm.heap.protectedGlobalObjectCount())); +object->putDirect(vm, Identifier::fromString(vm, "objectTypeCounts"), objectTypeCounts); return toRef(object); } Modified: trunk/Source/_javascript_Core/API/JSBasePrivate.h (283285 => 283286) --- trunk/Source/_javascript_Core/API/JSBasePrivate.h 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/API/JSBasePrivate.h 2021-09-30 00:19:07 UTC (rev 283286) @@ -71,6 +71,7 @@ protectedObjectCount: current count of protected GC objects globalObjectCount: current count of global GC objects protectedGlobalObjectCount: current count of protected global GC objects + objectTypeCounts: object with GC object types as keys and their current counts as values */ JS_EXPORT JSObjectRef JSGetMemoryUsageStatistics(JSContextRef ctx); Modified: trunk/Source/_javascript_Core/ChangeLog (283285 => 283286) --- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286) @@ -1,3 +1,15 @@ +2021-09-29 Basuke Suzuki + +[JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics +https://bugs.webkit.org/show_bug.cgi?id=230957 + +Reviewed by Yusuke Suzuki. + +* API/JSBase.cpp: Added objectTypeCounts property +(JSGetMemoryUsageStatistics): +* API/JSBasePrivate.h: Added description of objectTypeCounts property +* jsc.cpp: Added memoryUsageStatistics() function + 2021-09-29 Yusuke Suzuki [JSC] Remove CodeBlock::m_llintExecuteCounter Modified: trunk/Source/_javascript_Core/jsc.cpp (283285 => 283286) --- trunk/Source/_javascript_Core/jsc.cpp 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/jsc.cpp 2021-09-30 00:19:07 UTC (rev 283286) @@ -22,6 +22,7 @@ #include "config.h" +#include "APICast.h" #include "ArrayBuffer.h" #include "BigIntConstructor.h" #include "BytecodeCacheError.h" @@ -44,6 +45,7 @@ #include "JITSizeStatistics.h" #include "JSArray.h" #include "JSArrayBuffer.h" +#include "JSBasePrivate.h" #include "JSBigInt.h" #include "JSFinalizationRegistry.h" #include "JSFunction.h" @@ -285,6 +287,7 @@ static JSC_DECLARE_HOST_FUNCTION(functionFullGC); static JSC_DECLARE_HOST_FUNCTION(functionEdenGC); static JSC_DECLARE_HOST_FUNCTION(functionHeapSize); +static JSC_DECLARE_HOST_FUNCTION(functionMemoryUsageStatistics); static JSC_DECLARE_HOST_FUNCTION(functionCreateMemoryFootprint); static JSC_DECLARE_HOST_FUNCTION(functionResetMemoryPeak); static JSC_DECLARE_HOST_FUNCTION(functionAddressOf); @@ -529,6 +532,7 @@ addFunction(vm, "fullGC", functionFullGC, 0); addFunction(vm, "edenGC", functionEdenGC, 0); addFunction(vm, "gcHeapSize", functionHeapSize, 0); +addFunction(vm, "memoryUsageStatistics", fun
[webkit-changes] [283285] trunk/Source/bmalloc
Title: [283285] trunk/Source/bmalloc
Revision 283285
Author basuke.suz...@sony.com
Date 2021-09-29 17:07:14 -0700 (Wed, 29 Sep 2021)
Log Message
[bmalloc] ChunkHash is not used since r261667
https://bugs.webkit.org/show_bug.cgi?id=230762
Reviewed by Alex Christensen.
The structure is the leftover when ObjectTypeTable was introduced at r261667.
* bmalloc/Chunk.h:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Chunk.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (283284 => 283285)
--- trunk/Source/bmalloc/ChangeLog 2021-09-30 00:00:16 UTC (rev 283284)
+++ trunk/Source/bmalloc/ChangeLog 2021-09-30 00:07:14 UTC (rev 283285)
@@ -1,3 +1,14 @@
+2021-09-29 Basuke Suzuki
+
+[bmalloc] ChunkHash is not used since r261667
+https://bugs.webkit.org/show_bug.cgi?id=230762
+
+Reviewed by Alex Christensen.
+
+The structure is the leftover when ObjectTypeTable was introduced at r261667.
+
+* bmalloc/Chunk.h:
+
2021-09-29 Eric Hutchison
Unreviewed, reverting r282850.
Modified: trunk/Source/bmalloc/bmalloc/Chunk.h (283284 => 283285)
--- trunk/Source/bmalloc/bmalloc/Chunk.h 2021-09-30 00:00:16 UTC (rev 283284)
+++ trunk/Source/bmalloc/bmalloc/Chunk.h 2021-09-30 00:07:14 UTC (rev 283285)
@@ -66,14 +66,6 @@
std::array m_pages { };
};
-struct ChunkHash {
-static unsigned hash(Chunk* key)
-{
-return static_cast(
-reinterpret_cast(key) / chunkSize);
-}
-};
-
inline size_t Chunk::metadataSize(size_t pageSize)
{
// We align to at least the page size so we can service aligned allocations
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283282] trunk/Tools
Title: [283282] trunk/Tools
Revision 283282
Author basuke.suz...@sony.com
Date 2021-09-29 16:53:31 -0700 (Wed, 29 Sep 2021)
Log Message
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
https://bugs.webkit.org/show_bug.cgi?id=230995
Reviewed by Jonathan Bedard.
LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
in the framework.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
Diff
Modified: trunk/Tools/ChangeLog (283281 => 283282)
--- trunk/Tools/ChangeLog 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/ChangeLog 2021-09-29 23:53:31 UTC (rev 283282)
@@ -1,3 +1,16 @@
+2021-09-29 Basuke Suzuki
+
+[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
+https://bugs.webkit.org/show_bug.cgi?id=230995
+
+Reviewed by Jonathan Bedard.
+
+LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
+in the framework.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_identifier_name_in_declaration):
+
2021-09-29 Alex Christensen
Update PCM Daemon name
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (283281 => 283282)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:53:31 UTC (rev 283282)
@@ -4104,6 +4104,7 @@
and not modified_identifier == "const_iterator"
and not modified_identifier == "vm_throw"
and not modified_identifier == "DFG_OPERATION"
+and not modified_identifier == "LOG_CHANNEL"
and not modified_identifier.find('chrono_literals') >= 0):
error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283266] trunk/Tools
Title: [283266] trunk/Tools
Revision 283266
Author basuke.suz...@sony.com
Date 2021-09-29 14:58:18 -0700 (Wed, 29 Sep 2021)
Log Message
[PlayStation] Make build-webkit configurable using environment variable
https://bugs.webkit.org/show_bug.cgi?id=230958
Reviewed by Fujii Hironori.
The cmake toolchain file is hard coded in the script. Make it configurable using
environment variable.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (283265 => 283266)
--- trunk/Tools/ChangeLog 2021-09-29 21:52:58 UTC (rev 283265)
+++ trunk/Tools/ChangeLog 2021-09-29 21:58:18 UTC (rev 283266)
@@ -1,3 +1,16 @@
+2021-09-29 Basuke Suzuki
+
+[PlayStation] Make build-webkit configurable using environment variable
+https://bugs.webkit.org/show_bug.cgi?id=230958
+
+Reviewed by Fujii Hironori.
+
+The cmake toolchain file is hard coded in the script. Make it configurable using
+environment variable.
+
+* Scripts/webkitdirs.pm:
+(generateBuildSystemFromCMakeProject):
+
2021-09-29 Youenn Fablet
WPT importer should create serviceworker template for templated test that have worker as global
Modified: trunk/Tools/Scripts/webkitdirs.pm (283265 => 283266)
--- trunk/Tools/Scripts/webkitdirs.pm 2021-09-29 21:52:58 UTC (rev 283265)
+++ trunk/Tools/Scripts/webkitdirs.pm 2021-09-29 21:58:18 UTC (rev 283266)
@@ -2511,7 +2511,10 @@
push @args, "-DLTO_MODE=$ltoMode" if ltoMode();
-push @args, '-DCMAKE_TOOLCHAIN_FILE=Platform/PlayStation' if isPlayStation();
+if (isPlayStation()) {
+my $toolChainFile = $ENV{'CMAKE_TOOLCHAIN_FILE'} || "Platform/PlayStation";
+push @args, '-DCMAKE_TOOLCHAIN_FILE=' . $toolChainFile;
+}
if ($willUseNinja) {
push @args, "-G";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282850] trunk/Source/bmalloc
Title: [282850] trunk/Source/bmalloc Revision 282850 Author basuke.suz...@sony.com Date 2021-09-21 17:00:07 -0700 (Tue, 21 Sep 2021) Log Message [bmalloc] freeableMemory and footprint of Heap are completely broken https://bugs.webkit.org/show_bug.cgi?id=230245 Reviewed by Geoffrey Garen. This introduced in r279922. The physical size of the newly allocated range was changed from zero to the size of the range on that commit and that causes the numbers wrong. That change itself is correct fix because the range has physical pages attached. That simply activated the bug which was there for a long time. I've added the correction to adjust both numbers with newly allocated region. Also added assertion to check the overflow of those values and the option to log those value change to the console. Fortunately those numbers are used for debugging purpose. Scavenger will dump out those to stderr with its verbose mode. There's no practical cases affected by this bug. Here is the example of footprint logging before fixing the bug: >>> footprint: 18446744073709535232 (-16384) scavenge footprint: 18446744073709518848 (-16384) scavenge footprint: 18446744073709502464 (-16384) scavenge footprint: 18446744073709486080 (-16384) scavenge footprint: 18446744073709469696 (-16384) scavenge footprint: 18446744073709453312 (-16384) scavenge ... It just began with negative number which overflows on unsigned. And following is the one with fix: footprint: 1048576 (1048576) allocateLarge footprint: 2097152 (1048576) allocateLarge footprint: 3145728 (1048576) allocateLarge footprint: 4194304 (1048576) allocateLarge footprint: 5242880 (1048576) allocateLarge footprint: 6291456 (1048576) allocateLarge >>> footprint: 6275072 (-16384) scavenge footprint: 6258688 (-16384) scavenge footprint: 6242304 (-16384) scavenge footprint: 6225920 (-16384) scavenge footprint: 6209536 (-16384) scavenge footprint: 6193152 (-16384) scavenge ... * bmalloc/Heap.cpp: (bmalloc::Heap::adjustStat): (bmalloc::Heap::logStat): (bmalloc::Heap::adjustFreeableMemory): (bmalloc::Heap::adjustFootprint): (bmalloc::Heap::decommitLargeRange): (bmalloc::Heap::scavenge): (bmalloc::Heap::allocateSmallChunk): (bmalloc::Heap::allocateSmallPage): (bmalloc::Heap::deallocateSmallLine): (bmalloc::Heap::splitAndAllocate): (bmalloc::Heap::allocateLarge): (bmalloc::Heap::deallocateLarge): (bmalloc::Heap::externalCommit): (bmalloc::Heap::externalDecommit): * bmalloc/Heap.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Heap.cpp trunk/Source/bmalloc/bmalloc/Heap.h Diff Modified: trunk/Source/bmalloc/ChangeLog (282849 => 282850) --- trunk/Source/bmalloc/ChangeLog 2021-09-21 23:35:41 UTC (rev 282849) +++ trunk/Source/bmalloc/ChangeLog 2021-09-22 00:00:07 UTC (rev 282850) @@ -1,3 +1,64 @@ +2021-09-21 Basuke Suzuki + +[bmalloc] freeableMemory and footprint of Heap are completely broken +https://bugs.webkit.org/show_bug.cgi?id=230245 + +Reviewed by Geoffrey Garen. + +This introduced in r279922. The physical size of the newly allocated range was changed from zero +to the size of the range on that commit and that causes the numbers wrong. That change itself is +correct fix because the range has physical pages attached. That simply activated the bug which was +there for a long time. + +I've added the correction to adjust both numbers with newly allocated region. Also added assertion +to check the overflow of those values and the option to log those value change to the console. + +Fortunately those numbers are used for debugging purpose. Scavenger will dump out those to stderr +with its verbose mode. There's no practical cases affected by this bug. + +Here is the example of footprint logging before fixing the bug: + +>>> footprint: 18446744073709535232 (-16384) scavenge +footprint: 18446744073709518848 (-16384) scavenge +footprint: 18446744073709502464 (-16384) scavenge +footprint: 18446744073709486080 (-16384) scavenge +footprint: 18446744073709469696 (-16384) scavenge +footprint: 18446744073709453312 (-16384) scavenge +... + +It just began with negative number which overflows on unsigned. And following is the one with fix: + +footprint: 1048576 (1048576) allocateLarge +footprint: 2097152 (1048576) allocateLarge +footprint: 3145728 (1048576) allocateLarge +footprint: 4194304 (1048576) allocateLarge +footprint: 5242880 (1048576) allocateLarge +footprint: 6291456 (1048576) allocateLarge +>>> footprint: 6275072 (-163
[webkit-changes] [282043] trunk/Source/WTF
Title: [282043] trunk/Source/WTF
Revision 282043
Author basuke.suz...@sony.com
Date 2021-09-03 21:21:17 -0700 (Fri, 03 Sep 2021)
Log Message
Use USE(SYSTEM_MALLOC) macro in all cases
https://bugs.webkit.org/show_bug.cgi?id=229902
Reviewed by Yusuke Suzuki.
Convert old style macro check to USE() macro for USE_SYSTEM_MALLOC.
* wtf/FastMalloc.cpp:
* wtf/Gigacage.cpp:
* wtf/Gigacage.h:
* wtf/IsoMalloc.h:
* wtf/IsoMallocInlines.h:
* wtf/JSValueMalloc.cpp:
* wtf/PlatformUse.h:
* wtf/RAMSize.cpp:
* wtf/VMTags.h:
* wtf/WTFConfig.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp
trunk/Source/WTF/wtf/Gigacage.cpp
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/WTF/wtf/IsoMalloc.h
trunk/Source/WTF/wtf/IsoMallocInlines.h
trunk/Source/WTF/wtf/JSValueMalloc.cpp
trunk/Source/WTF/wtf/PlatformUse.h
trunk/Source/WTF/wtf/RAMSize.cpp
trunk/Source/WTF/wtf/VMTags.h
trunk/Source/WTF/wtf/WTFConfig.h
Diff
Modified: trunk/Source/WTF/ChangeLog (282042 => 282043)
--- trunk/Source/WTF/ChangeLog 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/ChangeLog 2021-09-04 04:21:17 UTC (rev 282043)
@@ -1,3 +1,23 @@
+2021-09-03 Basuke Suzuki
+
+Use USE(SYSTEM_MALLOC) macro in all cases
+https://bugs.webkit.org/show_bug.cgi?id=229902
+
+Reviewed by Yusuke Suzuki.
+
+Convert old style macro check to USE() macro for USE_SYSTEM_MALLOC.
+
+* wtf/FastMalloc.cpp:
+* wtf/Gigacage.cpp:
+* wtf/Gigacage.h:
+* wtf/IsoMalloc.h:
+* wtf/IsoMallocInlines.h:
+* wtf/JSValueMalloc.cpp:
+* wtf/PlatformUse.h:
+* wtf/RAMSize.cpp:
+* wtf/VMTags.h:
+* wtf/WTFConfig.h:
+
2021-09-03 Yusuke Suzuki
[JSC] Implement Temporal.TimeZone
Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (282042 => 282043)
--- trunk/Source/WTF/wtf/FastMalloc.cpp 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/FastMalloc.cpp 2021-09-04 04:21:17 UTC (rev 282043)
@@ -145,7 +145,7 @@
} // namespace WTF
-#if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#if USE(SYSTEM_MALLOC)
#include
@@ -315,7 +315,7 @@
} // namespace WTF
-#else // defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#else // USE(SYSTEM_MALLOC)
#include
@@ -686,4 +686,4 @@
} // namespace WTF
-#endif // defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#endif // USE(SYSTEM_MALLOC)
Modified: trunk/Source/WTF/wtf/Gigacage.cpp (282042 => 282043)
--- trunk/Source/WTF/wtf/Gigacage.cpp 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/Gigacage.cpp 2021-09-04 04:21:17 UTC (rev 282043)
@@ -29,7 +29,7 @@
#include
#include
-#if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#if USE(SYSTEM_MALLOC)
#include
namespace Gigacage {
@@ -64,7 +64,7 @@
}
} // namespace Gigacage
-#else // defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#else // USE(SYSTEM_MALLOC)
#include
namespace Gigacage {
Modified: trunk/Source/WTF/wtf/Gigacage.h (282042 => 282043)
--- trunk/Source/WTF/wtf/Gigacage.h 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/Gigacage.h 2021-09-04 04:21:17 UTC (rev 282043)
@@ -28,7 +28,7 @@
#include
#include
-#if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#if USE(SYSTEM_MALLOC)
#define GIGACAGE_ENABLED 0
namespace Gigacage {
Modified: trunk/Source/WTF/wtf/IsoMalloc.h (282042 => 282043)
--- trunk/Source/WTF/wtf/IsoMalloc.h 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/IsoMalloc.h 2021-09-04 04:21:17 UTC (rev 282043)
@@ -27,7 +27,7 @@
#include
-#if (defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC)
+#if (USE(SYSTEM_MALLOC))
#include
Modified: trunk/Source/WTF/wtf/IsoMallocInlines.h (282042 => 282043)
--- trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/IsoMallocInlines.h 2021-09-04 04:21:17 UTC (rev 282043)
@@ -25,7 +25,7 @@
#pragma once
-#if (defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC)
+#if (USE(SYSTEM_MALLOC))
#include
Modified: trunk/Source/WTF/wtf/JSValueMalloc.cpp (282042 => 282043)
--- trunk/Source/WTF/wtf/JSValueMalloc.cpp 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/JSValueMalloc.cpp 2021-09-04 04:21:17 UTC (rev 282043)
@@ -29,13 +29,13 @@
#include
#include
-#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC)
+#if !(USE(SYSTEM_MALLOC))
#include
#endif
namespace WTF {
-#if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
+#if USE(SYSTEM_MALLOC)
void* tryJSValueMalloc(size_t size)
{
return FastMalloc::tryMalloc(size);
Modified: trunk/Source/WTF/wtf/PlatformUse.h (282042 => 282043)
--- trunk/Source/WTF/wtf/PlatformUse.h 2021-09-04 03:24:14 UTC (rev 282042)
+++ trunk/Source/WTF/wtf/PlatformUse.h 2021-09-04 04:21:17 UTC (rev 282043)
@@ -281,7 +281,7 @@
#define USE_UICONTEXTMENU 1
#endif
-#if PL
[webkit-changes] [277241] trunk/Source/ThirdParty/ANGLE
Title: [277241] trunk/Source/ThirdParty/ANGLE
Revision 277241
Author basuke.suz...@sony.com
Date 2021-05-08 21:31:43 -0700 (Sat, 08 May 2021)
Log Message
[WinCairo] Remove linker warning on ANGLE
https://bugs.webkit.org/show_bug.cgi?id=225501
Reviewed by Darin Adler.
libANGLE is statically linked to libGLESv2.dll so that __declspec(dllimport) is not required here.
* include/platform/PlatformMethods.h:
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/include/platform/PlatformMethods.h
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (277240 => 277241)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-05-09 04:15:21 UTC (rev 277240)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-05-09 04:31:43 UTC (rev 277241)
@@ -1,3 +1,14 @@
+2021-05-08 Basuke Suzuki
+
+[WinCairo] Remove linker warning on ANGLE
+https://bugs.webkit.org/show_bug.cgi?id=225501
+
+Reviewed by Darin Adler.
+
+libANGLE is statically linked to libGLESv2.dll so that __declspec(dllimport) is not required here.
+
+* include/platform/PlatformMethods.h:
+
2021-05-06 Kyle Piddington
[Metal ANGLE] Only clear dirty state bits after all state has been successfully set
Modified: trunk/Source/ThirdParty/ANGLE/include/platform/PlatformMethods.h (277240 => 277241)
--- trunk/Source/ThirdParty/ANGLE/include/platform/PlatformMethods.h 2021-05-09 04:15:21 UTC (rev 277240)
+++ trunk/Source/ThirdParty/ANGLE/include/platform/PlatformMethods.h 2021-05-09 04:31:43 UTC (rev 277241)
@@ -16,13 +16,7 @@
#define EGL_PLATFORM_ANGLE_PLATFORM_METHODS_ANGLEX 0x3482
#if !defined(ANGLE_PLATFORM_EXPORT)
-#if defined(_WIN32)
-#if !defined(LIBANGLE_IMPLEMENTATION)
-#define ANGLE_PLATFORM_EXPORT __declspec(dllimport)
-#else
-#define ANGLE_PLATFORM_EXPORT __declspec(dllexport)
-#endif
-#elif defined(__GNUC__) || defined(__clang__)
+#if defined(__GNUC__) || defined(__clang__)
#define ANGLE_PLATFORM_EXPORT __attribute__((visibility("default")))
#endif
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276740] trunk/Source
::markAttributedPrivateClickMeasurementsAsExpiredForTesting):
Source/WTF:
* wtf/Assertions.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (276739 => 276740)
--- trunk/Source/WTF/ChangeLog 2021-04-28 23:00:57 UTC (rev 276739)
+++ trunk/Source/WTF/ChangeLog 2021-04-28 23:22:18 UTC (rev 276740)
@@ -1,3 +1,16 @@
+2021-04-28 Basuke Suzuki
+
+Suppress warnings for %{private}s format specifier
+https://bugs.webkit.org/show_bug.cgi?id=225137
+
+Reviewed by Alex Christensen.
+
+Add PRIVATE_LOG_STRING macro which is defined depending on if
+os_log() is used or rather old printf().
+See also: https://bugs.webkit.org/show_bug.cgi?id=207478
+
+* wtf/Assertions.h:
+
2021-04-28 Alex Christensen
Remove support for NPAPI plugins in WebView
Modified: trunk/Source/WTF/wtf/Assertions.h (276739 => 276740)
--- trunk/Source/WTF/wtf/Assertions.h 2021-04-28 23:00:57 UTC (rev 276739)
+++ trunk/Source/WTF/wtf/Assertions.h 2021-04-28 23:22:18 UTC (rev 276740)
@@ -521,6 +521,7 @@
#if RELEASE_LOG_DISABLED
#define PUBLIC_LOG_STRING "s"
+#define PRIVATE_LOG_STRING "s"
#define RELEASE_LOG(channel, ...) ((void)0)
#define RELEASE_LOG_ERROR(channel, ...) LOG_ERROR(__VA_ARGS__)
#define RELEASE_LOG_FAULT(channel, ...) LOG_ERROR(__VA_ARGS__)
@@ -538,6 +539,7 @@
#if USE(OS_LOG) && !RELEASE_LOG_DISABLED
#define PUBLIC_LOG_STRING "{public}s"
+#define PRIVATE_LOG_STRING "{private}s"
#define RELEASE_LOG(channel, ...) os_log(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
#define RELEASE_LOG_ERROR(channel, ...) os_log_error(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
#define RELEASE_LOG_FAULT(channel, ...) os_log_fault(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
@@ -555,6 +557,7 @@
#if USE(JOURNALD) && !RELEASE_LOG_DISABLED
#define PUBLIC_LOG_STRING "s"
+#define PRIVATE_LOG_STRING "s"
#define SD_JOURNAL_SEND(channel, priority, file, line, function, ...) do { \
if (LOG_CHANNEL(channel).state != WTFLogChannelState::Off) \
sd_journal_send_with_location("CODE_FILE=" file, "CODE_LINE=" line, function, "WEBKIT_SUBSYSTEM=%s", LOG_CHANNEL(channel).subsystem, "WEBKIT_CHANNEL=%s", LOG_CHANNEL(channel).name, "PRIORITY=%i", priority, "MESSAGE=" __VA_ARGS__, nullptr); \
Modified: trunk/Source/WebKit/ChangeLog (276739 => 276740)
--- trunk/Source/WebKit/ChangeLog 2021-04-28 23:00:57 UTC (rev 276739)
+++ trunk/Source/WebKit/ChangeLog 2021-04-28 23:22:18 UTC (rev 276740)
@@ -1,3 +1,75 @@
+2021-04-28 Basuke Suzuki
+
+Suppress warnings for %{private}s format specifier
+https://bugs.webkit.org/show_bug.cgi?id=225137
+
+Reviewed by Alex Christensen.
+
+Add PRIVATE_LOG_STRING macro which is defined depending on if
+os_log() is used or rather old printf().
+See also: https://bugs.webkit.org/show_bug.cgi?id=207478
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+(WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):
+(WebKit::ResourceLoadStatisticsDatabaseStore::enableForeignKeys):
+(WebKit::ResourceLoadStatisticsDatabaseStore::currentTableAndIndexQueries):
+(WebKit::ResourceLoadStatisticsDatabaseStore::columnsForTable):
+(WebKit::ResourceLoadStatisticsDatabaseStore::addMissingColumnsToTable):
+(WebKit::ResourceLoadStatisticsDatabaseStore::renameColumnInTable):
+(WebKit::ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary):
+(WebKit::ResourceLoadStatisticsDatabaseStore::isEmpty const):
+(WebKit::ResourceLoadStatisticsDatabaseStore::insertObservedDomain):
+(WebKit::ResourceLoadStatisticsDatabaseStore::relationshipExists const):
+(WebKit::ResourceLoadStatisticsDatabaseStore::domainID const):
+(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
+(WebKit::ResourceLoadStatisticsDatabaseStore::populateFromMemoryStore):
+(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistic):
+(WebKit::ResourceLoadStatisticsDatabaseStore::mergeStatistics):
+(WebKit::ResourceLoadStatisticsDatabaseStore::incrementRecordsDeletedCountForDomains):
+(WebKit::ResourceLoadStatisticsDatabaseStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain):
+(WebKit::ResourceLoadStatisticsDatabaseStore::markAsPrevalentIfHasRedirectedToPrevalent):
+(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess):
+(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener):
+(WebKit::ResourceLoadStatisticsDatabaseStore::grandfatherDataForDomains):
+
[webkit-changes] [276726] trunk/Source/WebCore
Title: [276726] trunk/Source/WebCore
Revision 276726
Author basuke.suz...@sony.com
Date 2021-04-28 11:53:12 -0700 (Wed, 28 Apr 2021)
Log Message
[clang] Remove implicit cast related warnings
https://bugs.webkit.org/show_bug.cgi?id=225139
Reviewed by Darin Adler.
Added explicit cast to suppress warning.
Behavior is not changed from implicit cast.
No new tests because there's no behavior change.
* layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::removeTrailingLetterSpacing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276725 => 276726)
--- trunk/Source/WebCore/ChangeLog 2021-04-28 18:15:01 UTC (rev 276725)
+++ trunk/Source/WebCore/ChangeLog 2021-04-28 18:53:12 UTC (rev 276726)
@@ -1,3 +1,18 @@
+2021-04-28 Basuke Suzuki
+
+[clang] Remove implicit cast related warnings
+https://bugs.webkit.org/show_bug.cgi?id=225139
+
+Reviewed by Darin Adler.
+
+Added explicit cast to suppress warning.
+Behavior is not changed from implicit cast.
+
+No new tests because there's no behavior change.
+
+* layout/inlineformatting/InlineLine.cpp:
+(WebCore::Layout::Line::Run::removeTrailingLetterSpacing):
+
2021-04-28 Mark Lam
Fix exception assertions in light of the TerminationException.
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (276725 => 276726)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2021-04-28 18:15:01 UTC (rev 276725)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2021-04-28 18:53:12 UTC (rev 276726)
@@ -487,7 +487,7 @@
{
ASSERT(hasTrailingLetterSpacing());
shrinkHorizontally(trailingLetterSpacing());
-ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= intMaxForLayoutUnit));
+ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast(intMaxForLayoutUnit)));
}
void Line::Run::removeTrailingWhitespace()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276692] trunk/Source
Title: [276692] trunk/Source
Revision 276692
Author basuke.suz...@sony.com
Date 2021-04-27 23:39:41 -0700 (Tue, 27 Apr 2021)
Log Message
[PlayStation] Suppress warnings for %llu format specifier for uint64_t.
https://bugs.webkit.org/show_bug.cgi?id=225138
Reviewed by Darin Adler.
PRIu64 from should be use to format uint64_t value in printf.
Source/WebCore:
No new tests because there's no behavior change.
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::startTermination):
Source/WebKit:
* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::createFetchTask):
(WebKit::WebSWServerConnection::startFetch):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276691 => 276692)
--- trunk/Source/WebCore/ChangeLog 2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebCore/ChangeLog 2021-04-28 06:39:41 UTC (rev 276692)
@@ -1,3 +1,17 @@
+2021-04-27 Basuke Suzuki
+
+[PlayStation] Suppress warnings for %llu format specifier for uint64_t.
+https://bugs.webkit.org/show_bug.cgi?id=225138
+
+Reviewed by Darin Adler.
+
+PRIu64 from should be use to format uint64_t value in printf.
+
+No new tests because there's no behavior change.
+
+* workers/service/server/SWServerWorker.cpp:
+(WebCore::SWServerWorker::startTermination):
+
2021-04-27 Chris Dumez
Improve local storage size estimation for quota limitation
Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp (276691 => 276692)
--- trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp 2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp 2021-04-28 06:39:41 UTC (rev 276692)
@@ -32,6 +32,7 @@
#include "SWServer.h"
#include "SWServerRegistration.h"
#include "SWServerToContextConnection.h"
+#include
#include
#include
@@ -116,7 +117,7 @@
auto* contextConnection = this->contextConnection();
ASSERT(contextConnection);
if (!contextConnection) {
-RELEASE_LOG_ERROR(ServiceWorker, "Request to terminate a worker %llu whose context connection does not exist", identifier().toUInt64());
+RELEASE_LOG_ERROR(ServiceWorker, "Request to terminate a worker %" PRIu64 " whose context connection does not exist", identifier().toUInt64());
setState(State::NotRunning);
callback();
m_server->workerContextTerminated(*this);
Modified: trunk/Source/WebKit/ChangeLog (276691 => 276692)
--- trunk/Source/WebKit/ChangeLog 2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebKit/ChangeLog 2021-04-28 06:39:41 UTC (rev 276692)
@@ -1,3 +1,16 @@
+2021-04-27 Basuke Suzuki
+
+[PlayStation] Suppress warnings for %llu format specifier for uint64_t.
+https://bugs.webkit.org/show_bug.cgi?id=225138
+
+Reviewed by Darin Adler.
+
+PRIu64 from should be use to format uint64_t value in printf.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::createFetchTask):
+(WebKit::WebSWServerConnection::startFetch):
+
2021-04-27 Kimmo Kinnunen
Add a Condition type that supports thread safety analysis
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (276691 => 276692)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp 2021-04-28 06:39:41 UTC (rev 276692)
@@ -54,6 +54,7 @@
#include
#include
#include
+#include
#include
#include
@@ -179,7 +180,7 @@
auto* worker = server().activeWorkerFromRegistrationID(*serviceWorkerRegistrationIdentifier);
if (!worker) {
-SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because no active worker for registration %llu", serviceWorkerRegistrationIdentifier->toUInt64());
+SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because no active worker for registration %" PRIu64, serviceWorkerRegistrationIdentifier->toUInt64());
return nullptr;
}
@@ -193,7 +194,7 @@
}
if (worker->hasTimedOutAnyFetchTasks()) {
-SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because worker %llu has some timeouts", worker->identifier().toUInt64());
+SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because worker %" PRIu64 " has some timeouts", worker->identifier().toUInt64());
return nullp
[webkit-changes] [276342] trunk/Source/WebCore
Title: [276342] trunk/Source/WebCore
Revision 276342
Author basuke.suz...@sony.com
Date 2021-04-20 18:42:52 -0700 (Tue, 20 Apr 2021)
Log Message
[clang] Remove implicit cast related warnings.
https://bugs.webkit.org/show_bug.cgi?id=224797
Reviewed by Darin Adler.
Added explicit cast to suppress warning.
Behavior is not changed from implicit cast.
No new tests because there's no behavior change.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276341 => 276342)
--- trunk/Source/WebCore/ChangeLog 2021-04-21 01:20:17 UTC (rev 276341)
+++ trunk/Source/WebCore/ChangeLog 2021-04-21 01:42:52 UTC (rev 276342)
@@ -1,3 +1,18 @@
+2021-04-20 Basuke Suzuki
+
+[clang] Remove implicit cast related warnings.
+https://bugs.webkit.org/show_bug.cgi?id=224797
+
+Reviewed by Darin Adler.
+
+Added explicit cast to suppress warning.
+Behavior is not changed from implicit cast.
+
+No new tests because there's no behavior change.
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
+
2021-04-20 Brent Fulgham
[Cocoa] Prevent GPU and WebContent processes from attempting to connect to the AppSSO service
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (276341 => 276342)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2021-04-21 01:20:17 UTC (rev 276341)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2021-04-21 01:42:52 UTC (rev 276342)
@@ -1782,8 +1782,8 @@
// top of the page.
// FIXME: We are still honoring gigantic margins, which does leave open the possibility of blank pages caused by this heuristic. It remains to be seen whether or not
// this will be a real-world issue. For now we don't try to deal with this problem.
-logicalOffset = intMaxForLayoutUnit;
-logicalBottom = intMinForLayoutUnit;
+logicalOffset = static_cast(intMaxForLayoutUnit);
+logicalBottom = static_cast(intMinForLayoutUnit);
lineBox->computeReplacedAndTextLineTopAndBottom(logicalOffset, logicalBottom);
lineHeight = logicalBottom - logicalOffset;
if (logicalOffset == intMaxForLayoutUnit || lineHeight > pageLogicalHeight) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276323] trunk/Tools
Title: [276323] trunk/Tools
Revision 276323
Author basuke.suz...@sony.com
Date 2021-04-20 15:37:05 -0700 (Tue, 20 Apr 2021)
Log Message
[PlayStation] Remove warnings for unused parameter.
https://bugs.webkit.org/show_bug.cgi?id=224830
Reviewed by Darin Adler.
* MiniBrowser/playstation/main.cpp:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/playstation/main.cpp
Diff
Modified: trunk/Tools/ChangeLog (276322 => 276323)
--- trunk/Tools/ChangeLog 2021-04-20 22:33:49 UTC (rev 276322)
+++ trunk/Tools/ChangeLog 2021-04-20 22:37:05 UTC (rev 276323)
@@ -1,3 +1,13 @@
+2021-04-20 Basuke Suzuki
+
+[PlayStation] Remove warnings for unused parameter.
+https://bugs.webkit.org/show_bug.cgi?id=224830
+
+Reviewed by Darin Adler.
+
+* MiniBrowser/playstation/main.cpp:
+(main):
+
2021-04-20 Kimmo Kinnunen
gtest.a exports symbols, causing link-time warning: direct access in function ... means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
Modified: trunk/Tools/MiniBrowser/playstation/main.cpp (276322 => 276323)
--- trunk/Tools/MiniBrowser/playstation/main.cpp 2021-04-20 22:33:49 UTC (rev 276322)
+++ trunk/Tools/MiniBrowser/playstation/main.cpp 2021-04-20 22:37:05 UTC (rev 276323)
@@ -71,7 +71,7 @@
}
};
-int main(int argc, char *argv[])
+int main(int, char *[])
{
WKRunLoopInitializeMain();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276306] trunk/Source
Title: [276306] trunk/Source
Revision 276306
Author basuke.suz...@sony.com
Date 2021-04-20 08:47:23 -0700 (Tue, 20 Apr 2021)
Log Message
Remove UNUSED warnings based on the configuration.
https://bugs.webkit.org/show_bug.cgi?id=224787
Reviewed by Darin Adler.
Added UNUSED_VARIABLE or its variant to suppress warnings based on the configuration.
Source/WebCore:
No new tests because it just for suppression of the warnings.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
* page/PageConsoleClient.cpp:
(WebCore::snapshotCanvas):
* page/PerformanceLogging.cpp:
(WebCore::PerformanceLogging::didReachPointOfInterest):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
Source/WebKit:
* NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::debugLogDomainsInBatches):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prepareToSuspend):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestStorageSpace):
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
* WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:
(WebKit::pageIDFromWebFrame):
(WebKit::frameIDFromWebFrame):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::prepareToSuspend):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/page/PageConsoleClient.cpp
trunk/Source/WebCore/page/PerformanceLogging.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276305 => 276306)
--- trunk/Source/WebCore/ChangeLog 2021-04-20 15:45:09 UTC (rev 276305)
+++ trunk/Source/WebCore/ChangeLog 2021-04-20 15:47:23 UTC (rev 276306)
@@ -1,3 +1,24 @@
+2021-04-20 Basuke Suzuki
+
+Remove UNUSED warnings based on the configuration.
+https://bugs.webkit.org/show_bug.cgi?id=224787
+
+Reviewed by Darin Adler.
+
+Added UNUSED_VARIABLE or its variant to suppress warnings based on the configuration.
+
+No new tests because it just for suppression of the warnings.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::willSendRequestInternal):
+* page/PageConsoleClient.cpp:
+(WebCore::snapshotCanvas):
+* page/PerformanceLogging.cpp:
+(WebCore::PerformanceLogging::didReachPointOfInterest):
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::FontCache::systemFallbackForCharacters):
+* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+
2021-04-19 Darin Adler
Refactor sorted array mapping machinery in LocaleToScriptMapping.cpp for reuse elsewhere
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (276305 => 276306)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2021-04-20 15:45:09 UTC (rev 276305)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2021-04-20 15:47:23 UTC (rev 276306)
@@ -71,8 +71,13 @@
#undef RELEASE_LOG_ERROR_IF_ALLOWED
#define PAGE_ID ((frame() ? frame()->pageID().valueOr(PageIdentifier()) : PageIdentifier()).toUInt64())
#define FRAME_ID ((frame() ? frame()->frameID().valueOr(FrameIdentifier()) : FrameIdentifier()).toUInt64())
+#if RELEASE_LOG_DISABLED
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) UNUSED_VARIABLE(this)
+#define RELEASE_LOG_ERROR_IF_ALLOWED(fmt, ...) UNUSED_VARIABLE(this)
+#else
#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), ResourceLoading, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", frameLoader=%p, resourceID=%lu] SubresourceLoader::" fmt, this, PAGE_ID, FRAME_ID, frameLoader(), identifier(), ##__VA_ARGS__)
#define RELEASE_LOG_ERROR_IF_ALLOWED(fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), ResourceLoading, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", frameLoader=%p, resourceID=%lu] SubresourceLoader::" fmt, this, PAGE_ID, FRAME_ID, frameLoader(), identifier(), ##__VA_ARGS__)
+#endif
namespace WebCore {
Modified: trunk/Source/WebCore/page/PageConsoleClient.cpp (276305 => 276306)
--- trunk/Source/WebCore/page/PageCons
[webkit-changes] [276211] trunk/Source/WebCore
Title: [276211] trunk/Source/WebCore
Revision 276211
Author basuke.suz...@sony.com
Date 2021-04-17 15:55:14 -0700 (Sat, 17 Apr 2021)
Log Message
[Curl] Remove warnings on curl layer.
https://bugs.webkit.org/show_bug.cgi?id=224721
Reviewed by Darin Adler.
Remove unused parameters to prevent warnings. For CurlRequest, it passes
member variable to private method which is meaningless so that it was
removed.
Covered by existing test files.
* platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::createPrepareStatement):
* platform/network/curl/CurlFormDataStream.cpp:
(WebCore::CurlFormDataStream::read):
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::setupPUT):
(WebCore::CurlRequest::setupPOST):
* platform/network/curl/CurlRequest.h:
* platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::setCookiesFromDOM const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp
trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.h
trunk/Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276210 => 276211)
--- trunk/Source/WebCore/ChangeLog 2021-04-17 22:40:08 UTC (rev 276210)
+++ trunk/Source/WebCore/ChangeLog 2021-04-17 22:55:14 UTC (rev 276211)
@@ -1,3 +1,28 @@
+2021-04-17 Basuke Suzuki
+
+[Curl] Remove warnings on curl layer.
+https://bugs.webkit.org/show_bug.cgi?id=224721
+
+Reviewed by Darin Adler.
+
+Remove unused parameters to prevent warnings. For CurlRequest, it passes
+member variable to private method which is meaningless so that it was
+removed.
+
+Covered by existing test files.
+
+* platform/network/curl/CookieJarDB.cpp:
+(WebCore::CookieJarDB::createPrepareStatement):
+* platform/network/curl/CurlFormDataStream.cpp:
+(WebCore::CurlFormDataStream::read):
+* platform/network/curl/CurlRequest.cpp:
+(WebCore::CurlRequest::setupTransfer):
+(WebCore::CurlRequest::setupPUT):
+(WebCore::CurlRequest::setupPOST):
+* platform/network/curl/CurlRequest.h:
+* platform/network/curl/NetworkStorageSessionCurl.cpp:
+(WebCore::NetworkStorageSession::setCookiesFromDOM const):
+
2021-04-17 Chris Lord
Create local copy of CSSParserContext in CSSPropertyParserWorkerSafe
Modified: trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp (276210 => 276211)
--- trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp 2021-04-17 22:40:08 UTC (rev 276210)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarDB.cpp 2021-04-17 22:55:14 UTC (rev 276211)
@@ -639,7 +639,7 @@
{
auto statement = makeUnique(m_database, sql);
int ret = statement->prepare();
-ASSERT(ret == SQLITE_OK);
+ASSERT_UNUSED(ret, ret == SQLITE_OK);
m_statements.add(sql, WTFMove(statement));
}
Modified: trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.cpp (276210 => 276211)
--- trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.cpp 2021-04-17 22:40:08 UTC (rev 276210)
+++ trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.cpp 2021-04-17 22:55:14 UTC (rev 276211)
@@ -128,7 +128,7 @@
return readFromData(bytes, bufferPosition, bufferSize);
}, [&] (const FormDataElement::EncodedFileData& fileData) {
return readFromFile(fileData, bufferPosition, bufferSize);
-}, [] (const FormDataElement::EncodedBlobData& blobData) {
+}, [] (const FormDataElement::EncodedBlobData&) {
ASSERT_NOT_REACHED();
return WTF::nullopt;
}
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (276210 => 276211)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2021-04-17 22:40:08 UTC (rev 276210)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2021-04-17 22:55:14 UTC (rev 276211)
@@ -216,14 +216,14 @@
if (method == "GET")
m_curlHandle->enableHttpGetRequest();
else if (method == "POST")
-setupPOST(m_request);
+setupPOST();
else if (method == "PUT")
-setupPUT(m_request);
+setupPUT();
else if (method == "HEAD")
m_curlHandle->enableHttpHeadRequest();
else {
m_curlHandle->setHttpCustomRequest(method);
-setupPUT(m_request);
+setupPUT();
}
if (!m_user.isEmpty() || !m_password.isEmpty()) {
@@ -529,7 +529,7 @@
header.add(HTTPHeaderName::AcceptLanguage, language);
}
-void CurlRequest::setupPUT(ResourceRequest& request)
+void CurlRequest::setupPUT()
{
[webkit-changes] [276205] trunk/Source/WebCore
Title: [276205] trunk/Source/WebCore
Revision 276205
Author basuke.suz...@sony.com
Date 2021-04-17 13:16:22 -0700 (Sat, 17 Apr 2021)
Log Message
[clang 11] Remove warning when converting WebCore::maxValueForCssLength from int to float
https://bugs.webkit.org/show_bug.cgi?id=224714
Reviewed by Chris Dumez.
On clang 11, the conversion from const int WebCore::maxValueForCssLength (= 33554429) to
float generates conversion warning:
> warning: implicit conversion from 'const int' to 'float' changes value from 33554429 to 33554428
Changing the target type from float to double works for this. Length constructor accept double
so that there's no drawback with this change.
No test because it's compiler behavior.
* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertWordSpacing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/style/StyleBuilderConverter.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (276204 => 276205)
--- trunk/Source/WebCore/ChangeLog 2021-04-17 20:07:30 UTC (rev 276204)
+++ trunk/Source/WebCore/ChangeLog 2021-04-17 20:16:22 UTC (rev 276205)
@@ -1,3 +1,22 @@
+2021-04-17 Basuke Suzuki
+
+[clang 11] Remove warning when converting WebCore::maxValueForCssLength from int to float
+https://bugs.webkit.org/show_bug.cgi?id=224714
+
+Reviewed by Chris Dumez.
+
+On clang 11, the conversion from const int WebCore::maxValueForCssLength (= 33554429) to
+float generates conversion warning:
+> warning: implicit conversion from 'const int' to 'float' changes value from 33554429 to 33554428
+
+Changing the target type from float to double works for this. Length constructor accept double
+so that there's no drawback with this change.
+
+No test because it's compiler behavior.
+
+* style/StyleBuilderConverter.h:
+(WebCore::Style::BuilderConverter::convertWordSpacing):
+
2021-04-17 Sam Weinig
Move RuntimeEnabledFeatures to Settings (Part 1)
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (276204 => 276205)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2021-04-17 20:07:30 UTC (rev 276204)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2021-04-17 20:16:22 UTC (rev 276205)
@@ -542,7 +542,7 @@
template<> Length CSSPrimitiveValue::computeLength(const CSSToLengthConversionData& conversionData) const
{
-return Length(clampTo(computeLengthDouble(conversionData), minValueForCssLength, maxValueForCssLength), LengthType::Fixed);
+return Length(clampTo(computeLengthDouble(conversionData), minValueForCssLength, maxValueForCssLength), LengthType::Fixed);
}
template<> short CSSPrimitiveValue::computeLength(const CSSToLengthConversionData& conversionData) const
Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (276204 => 276205)
--- trunk/Source/WebCore/style/StyleBuilderConverter.h 2021-04-17 20:07:30 UTC (rev 276204)
+++ trunk/Source/WebCore/style/StyleBuilderConverter.h 2021-04-17 20:16:22 UTC (rev 276205)
@@ -1212,7 +1212,7 @@
else if (primitiveValue.isLength())
wordSpacing = primitiveValue.computeLength(csstoLengthConversionDataWithTextZoomFactor(builderState));
else if (primitiveValue.isPercentage())
-wordSpacing = Length(clampTo(primitiveValue.doubleValue(), minValueForCssLength, maxValueForCssLength), LengthType::Percent);
+wordSpacing = Length(clampTo(primitiveValue.doubleValue(), minValueForCssLength, maxValueForCssLength), LengthType::Percent);
else if (primitiveValue.isNumber())
wordSpacing = Length(primitiveValue.doubleValue(), LengthType::Fixed);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276192] trunk/Source/WebCore
Title: [276192] trunk/Source/WebCore Revision 276192 Author basuke.suz...@sony.com Date 2021-04-16 20:12:46 -0700 (Fri, 16 Apr 2021) Log Message Use WebKit macro to detect 64bit in RenderLayerBacking.h https://bugs.webkit.org/show_bug.cgi?id=224707 Reviewed by Yusuke Suzuki. There's no definition of __WORDSIZE in some environment. Also there's WebKit macro for that. > warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef] > #if __WORDSIZE == 64 && PLATFORM(COCOA) > ^ No test because it's compiler behavior. * rendering/RenderLayerBacking.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayerBacking.h Diff Modified: trunk/Source/WebCore/ChangeLog (276191 => 276192) --- trunk/Source/WebCore/ChangeLog 2021-04-17 02:32:54 UTC (rev 276191) +++ trunk/Source/WebCore/ChangeLog 2021-04-17 03:12:46 UTC (rev 276192) @@ -1,3 +1,20 @@ +2021-04-16 Basuke Suzuki + +Use WebKit macro to detect 64bit in RenderLayerBacking.h +https://bugs.webkit.org/show_bug.cgi?id=224707 + +Reviewed by Yusuke Suzuki. + +There's no definition of __WORDSIZE in some environment. Also there's WebKit macro for that. + +> warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef] +> #if __WORDSIZE == 64 && PLATFORM(COCOA) +> ^ + +No test because it's compiler behavior. + +* rendering/RenderLayerBacking.h: + 2021-04-16 Ryosuke Niwa Deploy Ref/RefPtr in Editor Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (276191 => 276192) --- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2021-04-17 02:32:54 UTC (rev 276191) +++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2021-04-17 03:12:46 UTC (rev 276192) @@ -43,7 +43,7 @@ class TransformationMatrix; -#if __WORDSIZE == 64 && PLATFORM(COCOA) +#if CPU(ADDRESS64) && PLATFORM(COCOA) #define USE_OWNING_LAYER_BEAR_TRAP 1 #define BEAR_TRAP_VALUE 0x #else ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276167] trunk/Source/WebCore
Title: [276167] trunk/Source/WebCore
Revision 276167
Author basuke.suz...@sony.com
Date 2021-04-16 14:07:29 -0700 (Fri, 16 Apr 2021)
Log Message
[PlayStation][OpenSSL] Remove warnings.
https://bugs.webkit.org/show_bug.cgi?id=224630
Reviewed by Don Olmstead.
There're two kinds of warnings in curl and openssl layer in our platform.
a) Unused param
b) '__WORDSIZE' is not defined.
warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef]
#if __WORDSIZE >= 64
^
No new tests because it's only for compilation issue.
* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
* crypto/openssl/CryptoKeyECOpenSSL.cpp:
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
* crypto/openssl/CryptoKeyRSAOpenSSL.cpp:
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::generatePair):
(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp
trunk/Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp
trunk/Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276166 => 276167)
--- trunk/Source/WebCore/ChangeLog 2021-04-16 20:55:48 UTC (rev 276166)
+++ trunk/Source/WebCore/ChangeLog 2021-04-16 21:07:29 UTC (rev 276167)
@@ -1,3 +1,37 @@
+2021-04-16 Basuke Suzuki
+
+[PlayStation][OpenSSL] Remove warnings.
+https://bugs.webkit.org/show_bug.cgi?id=224630
+
+Reviewed by Don Olmstead.
+
+There're two kinds of warnings in curl and openssl layer in our platform.
+
+a) Unused param
+
+b) '__WORDSIZE' is not defined.
+warning: '__WORDSIZE' is not defined, evaluates to 0 [-Wundef]
+#if __WORDSIZE >= 64
+^
+
+No new tests because it's only for compilation issue.
+
+* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
+(WebCore::CryptoAlgorithmAES_GCM::encrypt):
+(WebCore::CryptoAlgorithmAES_GCM::decrypt):
+* crypto/openssl/CryptoKeyECOpenSSL.cpp:
+(WebCore::CryptoKeyEC::platformGeneratePair):
+(WebCore::CryptoKeyEC::platformImportRaw):
+(WebCore::CryptoKeyEC::platformImportJWKPublic):
+(WebCore::CryptoKeyEC::platformImportJWKPrivate):
+(WebCore::CryptoKeyEC::platformImportSpki):
+(WebCore::CryptoKeyEC::platformImportPkcs8):
+* crypto/openssl/CryptoKeyRSAOpenSSL.cpp:
+(WebCore::CryptoKeyRSA::create):
+(WebCore::CryptoKeyRSA::generatePair):
+(WebCore::CryptoKeyRSA::importSpki):
+(WebCore::CryptoKeyRSA::importPkcs8):
+
2021-04-16 Alex Christensen
Disable ApplicationCache with linkedOnOrAfter check
Modified: trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp (276166 => 276167)
--- trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp 2021-04-16 20:55:48 UTC (rev 276166)
+++ trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp 2021-04-16 21:07:29 UTC (rev 276167)
@@ -39,7 +39,7 @@
static const char* const ALG128 = "A128GCM";
static const char* const ALG192 = "A192GCM";
static const char* const ALG256 = "A256GCM";
-#if __WORDSIZE >= 64
+#if CPU(ADDRESS64)
static const uint64_t PlainTextMaxLength = 549755813632ULL; // 2^39 - 256
#endif
static const uint8_t DefaultTagLength = 128;
@@ -77,7 +77,7 @@
auto& aesParameters = downcast(parameters);
-#if __WORDSIZE >= 64
+#if CPU(ADDRESS64)
if (plainText.size() > PlainTextMaxLength) {
exceptionCallback(OperationError);
return;
@@ -120,7 +120,7 @@
return;
}
-#if __WORDSIZE >= 64
+#if CPU(ADDRESS64)
if (aesParameters.ivVector().size() > UINT64_MAX) {
exceptionCallback(OperationError);
return;
Modified: trunk/Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp (276166 => 276167)
--- trunk/Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp 2021-04-16 20:55:48 UTC (rev 276166)
+++ trunk/Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp 2021-04-16 21:07:29 UTC (rev 276167)
@@ -46,6 +46,7 @@
Optional CryptoKeyEC::platformGeneratePair(CryptoAlgorithmIdentifier, NamedCurve, bool extractable, CryptoKeyUsageBitmap)
{
+UNUSED_PARAM(extractable);
notImplemented();
return { };
}
@@ -52,6 +53,8 @@
RefPtr CryptoKeyEC::platformImportRaw(CryptoAlgorithmIdentifier, NamedCurve, Vector&& keyData, bool extractable, CryptoKeyUsageBitmap)
{
+UNUSED_PARAM(keyData);
+UNUSED_PARAM(extractable);
notImplemented();
return nullptr;
}
@@ -58,6 +61,9 @@
RefPtr CryptoKeyEC::platformI
[webkit-changes] [276022] trunk
Title: [276022] trunk Revision 276022 Author basuke.suz...@sony.com Date 2021-04-15 08:48:10 -0700 (Thu, 15 Apr 2021) Log Message Remove warnings caused by export g_config extern definition in WTFConfig.h https://bugs.webkit.org/show_bug.cgi?id=224462 Reviewed by Don Olmstead. While building PlayStation port, lots of warnings are displayed: > WTF/Headers\wtf/WTFConfig.h:49:36: warning: redeclaration of 'WebConfig::g_config' > should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration] > extern "C" WTF_EXPORT_PRIVATE Slot g_config[]; >^ > bmalloc/Headers\bmalloc/GigacageConfig.h:38:17: note: previous declaration is here > extern "C" Slot g_config[]; This is because the two definitions are not same. Becasue we can't solve the situation completely, we just ignore these warnings at this morment. * Source/cmake/OptionsPlayStation.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsPlayStation.cmake Diff Modified: trunk/ChangeLog (276021 => 276022) --- trunk/ChangeLog 2021-04-15 15:35:01 UTC (rev 276021) +++ trunk/ChangeLog 2021-04-15 15:48:10 UTC (rev 276022) @@ -1,3 +1,25 @@ +2021-04-15 Basuke Suzuki + +Remove warnings caused by export g_config extern definition in WTFConfig.h +https://bugs.webkit.org/show_bug.cgi?id=224462 + +Reviewed by Don Olmstead. + +While building PlayStation port, lots of warnings are displayed: + +> WTF/Headers\wtf/WTFConfig.h:49:36: warning: redeclaration of 'WebConfig::g_config' +> should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration] +> extern "C" WTF_EXPORT_PRIVATE Slot g_config[]; +>^ +> bmalloc/Headers\bmalloc/GigacageConfig.h:38:17: note: previous declaration is here +> extern "C" Slot g_config[]; + +This is because the two definitions are not same. +Becasue we can't solve the situation completely, we just ignore these warnings at +this morment. + +* Source/cmake/OptionsPlayStation.cmake: + 2021-04-15 Philippe Normand [WebRTC][GStreamer] Build and use the openh264 based encoder if present on the system Modified: trunk/Source/cmake/OptionsPlayStation.cmake (276021 => 276022) --- trunk/Source/cmake/OptionsPlayStation.cmake 2021-04-15 15:35:01 UTC (rev 276021) +++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-04-15 15:48:10 UTC (rev 276022) @@ -13,6 +13,9 @@ add_definitions(-DSCE_LIBC_DISABLE_CPP14_HEADER_WARNING= -DSCE_LIBC_DISABLE_CPP17_HEADER_WARNING=) +# bug-224462 +WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-dll-attribute-on-redeclaration) + set(ENABLE_API_TESTS ON CACHE BOOL "Build API Tests") set(ENABLE_WEBCORE ON CACHE BOOL "Build WebCore") set(ENABLE_WEBKIT ON CACHE BOOL "Build WebKit") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275992] trunk/Source/WebKit
Title: [275992] trunk/Source/WebKit
Revision 275992
Author basuke.suz...@sony.com
Date 2021-04-14 19:42:09 -0700 (Wed, 14 Apr 2021)
Log Message
Fix WK_EXPORT macro for declspec compilers
https://bugs.webkit.org/show_bug.cgi?id=224583
Reviewed by Don Olmstead.
It displays warnings when macro is not defined. Actually it is defined only when
it builds WebKit. It should be defined(BUILDING_WebKit).
* Shared/API/c/WKDeclarationSpecifiers.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/c/WKDeclarationSpecifiers.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (275991 => 275992)
--- trunk/Source/WebKit/ChangeLog 2021-04-15 02:23:38 UTC (rev 275991)
+++ trunk/Source/WebKit/ChangeLog 2021-04-15 02:42:09 UTC (rev 275992)
@@ -1,3 +1,15 @@
+2021-04-14 Basuke Suzuki
+
+Fix WK_EXPORT macro for declspec compilers
+https://bugs.webkit.org/show_bug.cgi?id=224583
+
+Reviewed by Don Olmstead.
+
+It displays warnings when macro is not defined. Actually it is defined only when
+it builds WebKit. It should be defined(BUILDING_WebKit).
+
+* Shared/API/c/WKDeclarationSpecifiers.h:
+
2021-04-14 Jiewen Tan
6 http/wpt/webauthn layout-tests are constantly timing out
Modified: trunk/Source/WebKit/Shared/API/c/WKDeclarationSpecifiers.h (275991 => 275992)
--- trunk/Source/WebKit/Shared/API/c/WKDeclarationSpecifiers.h 2021-04-15 02:23:38 UTC (rev 275991)
+++ trunk/Source/WebKit/Shared/API/c/WKDeclarationSpecifiers.h 2021-04-15 02:42:09 UTC (rev 275992)
@@ -35,11 +35,11 @@
#if defined(WK_NO_EXPORT)
#define WK_EXPORT
#elif defined(WIN32) || defined(_WIN32) || defined(__CC_ARM) || defined(__ARMCC__) || (__has_declspec_attribute(dllimport) && __has_declspec_attribute(dllexport))
-#if BUILDING_WebKit
+#if defined(BUILDING_WebKit)
#define WK_EXPORT __declspec(dllexport)
#else
#define WK_EXPORT __declspec(dllimport)
-#endif /* BUILDING_WebKit */
+#endif /* defined(BUILDING_WebKit) */
#elif defined(__GNUC__)
#define WK_EXPORT __attribute__((visibility("default")))
#else /* !defined(WK_NO_EXPORT) */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275854] trunk/Source/WTF
Title: [275854] trunk/Source/WTF
Revision 275854
Author basuke.suz...@sony.com
Date 2021-04-12 18:06:07 -0700 (Mon, 12 Apr 2021)
Log Message
[PlayStation] Enable WTFCrashWithInfo implementation
https://bugs.webkit.org/show_bug.cgi?id=224458
Reviewed by Don Olmstead.
Enable WTFCrashWithInfo implementation for PlayStation platform. It is x86_64 and uses clang
so that it can share Darwin's implemetation with us.
* wtf/Assertions.cpp:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (275853 => 275854)
--- trunk/Source/WTF/ChangeLog 2021-04-13 00:48:17 UTC (rev 275853)
+++ trunk/Source/WTF/ChangeLog 2021-04-13 01:06:07 UTC (rev 275854)
@@ -1,3 +1,15 @@
+2021-04-12 Basuke Suzuki
+
+[PlayStation] Enable WTFCrashWithInfo implementation
+https://bugs.webkit.org/show_bug.cgi?id=224458
+
+Reviewed by Don Olmstead.
+
+Enable WTFCrashWithInfo implementation for PlayStation platform. It is x86_64 and uses clang
+so that it can share Darwin's implemetation with us.
+
+* wtf/Assertions.cpp:
+
2021-04-12 Youenn Fablet
Block loading for port 10080
Modified: trunk/Source/WTF/wtf/Assertions.cpp (275853 => 275854)
--- trunk/Source/WTF/wtf/Assertions.cpp 2021-04-13 00:48:17 UTC (rev 275853)
+++ trunk/Source/WTF/wtf/Assertions.cpp 2021-04-13 01:06:07 UTC (rev 275854)
@@ -602,7 +602,7 @@
} // extern "C"
-#if OS(DARWIN) && (CPU(X86_64) || CPU(ARM64))
+#if (OS(DARWIN) || PLATFORM(PLAYSTATION)) && (CPU(X86_64) || CPU(ARM64))
#if CPU(X86_64)
#define CRASH_INST "int3"
@@ -713,7 +713,7 @@
void WTFCrashWithInfoImpl(int, const char*, const char*, int, uint64_t, uint64_t) { CRASH(); }
void WTFCrashWithInfoImpl(int, const char*, const char*, int, uint64_t) { CRASH(); }
-#endif // OS(DARWIN) && (CPU(X64_64) || CPU(ARM64))
+#endif // (OS(DARWIN) || PLATFORM(PLAYSTATION)) && (CPU(X64_64) || CPU(ARM64))
namespace WTF {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269128] trunk/Source
Title: [269128] trunk/Source
Revision 269128
Author basuke.suz...@sony.com
Date 2020-10-28 16:51:45 -0700 (Wed, 28 Oct 2020)
Log Message
[WinCairo][PlayStation] Add handling for accept failure case
https://bugs.webkit.org/show_bug.cgi?id=217353
Reviewed by Alex Christensen.
Source/_javascript_Core:
It is rare to happen, but listening socket can be invalid state (i.e. cable disconnection, interface error),
and accept() will be called because of the poll's false report. In that situation, it is required to rebuild
the listening socket from the scratch. The failure of accept is the good place to capture this situation.
This patch moves listening duty into Listener internal calss and it is possible to make the invalid state
while maintained by SocketEndpoint. Also in case of failure continues, the retry will be gradually increasing
the intervals.
* inspector/remote/socket/RemoteInspectorServer.h:
* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::pollingTimeout):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::disconnect):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
* inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
Source/WebDriver:
Following the interface change.
* HTTPServer.h:
* socket/HTTPServerSocket.cpp:
(WebDriver::HTTPServer::didStatusChanged):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.h
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/HTTPServer.h
trunk/Source/WebDriver/socket/HTTPServerSocket.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (269127 => 269128)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-28 21:34:04 UTC (rev 269127)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-28 23:51:45 UTC (rev 269128)
@@ -1,3 +1,28 @@
+2020-10-28 Basuke Suzuki
+
+[WinCairo][PlayStation] Add handling for accept failure case
+https://bugs.webkit.org/show_bug.cgi?id=217353
+
+Reviewed by Alex Christensen.
+
+It is rare to happen, but listening socket can be invalid state (i.e. cable disconnection, interface error),
+and accept() will be called because of the poll's false report. In that situation, it is required to rebuild
+the listening socket from the scratch. The failure of accept is the good place to capture this situation.
+
+This patch moves listening duty into Listener internal calss and it is possible to make the invalid state
+while maintained by SocketEndpoint. Also in case of failure continues, the retry will be gradually increasing
+the intervals.
+
+* inspector/remote/socket/RemoteInspectorServer.h:
+* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
+(Inspector::RemoteInspectorSocketEndpoint::listenInet):
+(Inspector::RemoteInspectorSocketEndpoint::pollingTimeout):
+(Inspector::RemoteInspectorSocketEndpoint::workerThread):
+(Inspector::RemoteInspectorSocketEndpoint::createClient):
+(Inspector::RemoteInspectorSocketEndpoint::disconnect):
+(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
+* inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
+
2020-10-28 Saam Barati
Better cache our serialization of the outer TDZ environment when creating FunctionExecutables during bytecode generation
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h (269127 => 269128)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-10-28 21:34:04 UTC (rev 269127)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-10-28 23:51:45 UTC (rev 269128)
@@ -47,7 +47,7 @@
RemoteInspectorServer() { Socket::init(); }
Optional doAccept(RemoteInspectorSocketEndpoint&, PlatformSocketType) final;
-void didClose(RemoteInspectorSocketEndpoint&, ConnectionID) final { };
+void didChangeStatus(RemoteInspectorSocketEndpoint&, ConnectionID, RemoteInspectorSocketEndpoint::Listener::Status) final { };
Optional m_server;
};
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp (269127 => 269128)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp 2020-10-28 21:34:04 UTC (rev 269127)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp 2020-10-28 23:51:45 UTC (rev 269128)
@@ -31,7 +31,6 @@
#include
#include
[webkit-changes] [268134] trunk/Tools
Title: [268134] trunk/Tools
Revision 268134
Author basuke.suz...@sony.com
Date 2020-10-07 11:04:46 -0700 (Wed, 07 Oct 2020)
Log Message
[build-webkit] Compare with cmakeargs and unhandled to detect configuration change
https://bugs.webkit.org/show_bug.cgi?id=207012
Reviewed by Carlos Alberto Lopez Perez.
Added command line arguments on top of @featureArgs for comparison with previous build
options. This forces regeneration of CMakeCache.txt when any configuration is changed.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (268133 => 268134)
--- trunk/Tools/ChangeLog 2020-10-07 18:02:52 UTC (rev 268133)
+++ trunk/Tools/ChangeLog 2020-10-07 18:04:46 UTC (rev 268134)
@@ -1,3 +1,16 @@
+2020-10-07 Basuke Suzuki
+
+[build-webkit] Compare with cmakeargs and unhandled to detect configuration change
+https://bugs.webkit.org/show_bug.cgi?id=207012
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Added command line arguments on top of @featureArgs for comparison with previous build
+options. This forces regeneration of CMakeCache.txt when any configuration is changed.
+
+* Scripts/webkitdirs.pm:
+(shouldRemoveCMakeCache):
+
2020-10-07 Aakash Jain
[build.webkit.org] Ensure that invalid step names are not allowed
Modified: trunk/Tools/Scripts/webkitdirs.pm (268133 => 268134)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-10-07 18:02:52 UTC (rev 268133)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-10-07 18:04:46 UTC (rev 268134)
@@ -161,6 +161,7 @@
my $xcodeVersion;
my $unknownPortProhibited = 0;
+my @originalArgv = @ARGV;
# Variables for Win32 support
my $programFilesPath;
@@ -2327,7 +2328,7 @@
sub shouldRemoveCMakeCache(@)
{
-my (@buildArgs) = @_;
+my (@buildArgs) = sort (@_, @originalArgv);
# We check this first, because we always want to create this file for a fresh build.
my $productDir = File::Spec->catdir(baseProductDir(), configuration());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [267807] trunk/Source
/CapabilitiesSocket.cpp
trunk/Source/WebDriver/socket/CapabilitiesSocket.h
trunk/Source/WebDriver/socket/HTTPParser.cpp
trunk/Source/WebDriver/socket/HTTPParser.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (267806 => 267807)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-30 20:54:44 UTC (rev 267806)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-30 21:22:57 UTC (rev 267807)
@@ -1,3 +1,21 @@
+2020-09-30 Basuke Suzuki
+
+[PlayStation][WinCairo] Enable WebDriver target on PlayStation and client for WinCairo
+https://bugs.webkit.org/show_bug.cgi?id=216908
+
+Reviewed by Don Olmstead.
+
+Implement automation session correctly for PlayStation and WinCairo.
+
+* inspector/remote/RemoteInspector.h:
+* inspector/remote/socket/RemoteInspectorConnectionClient.cpp:
+(Inspector::RemoteInspectorConnectionClient::parseTargetListJSON):
+* inspector/remote/socket/RemoteInspectorConnectionClient.h:
+* inspector/remote/socket/RemoteInspectorSocket.cpp:
+(Inspector::RemoteInspector::stopInternal):
+(Inspector::RemoteInspector::requestAutomationSession):
+(Inspector::RemoteInspector::startAutomationSession):
+
2020-09-30 Commit Queue
Unreviewed, reverting r267795.
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (267806 => 267807)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h 2020-09-30 20:54:44 UTC (rev 267806)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h 2020-09-30 21:22:57 UTC (rev 267807)
@@ -89,7 +89,7 @@
struct SessionCapabilities {
bool acceptInsecureCertificates { false };
-#if USE(GLIB)
+#if USE(GLIB) || USE(INSPECTOR_SOCKET_SERVER)
Vector> certificates;
struct Proxy {
String type;
@@ -112,6 +112,9 @@
virtual String browserName() const { return { }; }
virtual String browserVersion() const { return { }; }
virtual void requestAutomationSession(const String& sessionIdentifier, const SessionCapabilities&) = 0;
+#if USE(INSPECTOR_SOCKET_SERVER)
+virtual void closeAutomationSession() = 0;
+#endif
};
#if PLATFORM(COCOA)
@@ -160,7 +163,7 @@
void sendMessageToTarget(TargetID, const char* message);
#endif
#if USE(INSPECTOR_SOCKET_SERVER)
-void requestAutomationSession(const String& sessionID, const Client::SessionCapabilities&);
+void requestAutomationSession(String&& sessionID, const Client::SessionCapabilities&);
bool isConnected() const { return !!m_clientConnection; }
void connect(ConnectionID);
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.cpp (267806 => 267807)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.cpp 2020-09-30 20:54:44 UTC (rev 267806)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.cpp 2020-09-30 21:22:57 UTC (rev 267807)
@@ -119,6 +119,26 @@
return event;
}
+Optional>> RemoteInspectorConnectionClient::parseTargetListJSON(const String& message)
+{
+auto messageValue = JSON::Value::parseJSON(message);
+if (!messageValue)
+return WTF::nullopt;
+
+auto messageArray = messageValue->asArray();
+if (!messageArray)
+return WTF::nullopt;
+
+Vector> targetList;
+for (auto& itemValue : *messageArray) {
+if (auto itemObject = itemValue->asObject())
+targetList.append(itemObject.releaseNonNull());
+else
+LOG_ERROR("Invalid type of value in targetList. It must be object.");
+}
+return targetList;
+}
+
} // namespace Inspector
#endif // ENABLE(REMOTE_INSPECTOR)
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h (267806 => 267807)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2020-09-30 20:54:44 UTC (rev 267806)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2020-09-30 21:22:57 UTC (rev 267807)
@@ -31,6 +31,7 @@
#include "RemoteInspectorMessageParser.h"
#include "RemoteInspectorSocketEndpoint.h"
#include
+#include
#include
#include
@@ -46,7 +47,7 @@
Optional createClient(PlatformSocketType);
void send(ConnectionID, const uint8_t* data, size_t);
-void didReceive(RemoteInspectorSocketEndpoint&, ConnectionID, Vector&&) override;
+void didReceive(RemoteInspectorSocketEndpoint&, ConnectionID, Vector&&) final;
struct Event {
String methodName;
@@ -60,6 +61,8 @@
virtual HashMap& dispatchMap() = 0;
protected:
+Optional>> parseTargetListJSON(const String&);
+
static Optional extractEvent(ConnectionID, Vector&&);
HashM
[webkit-changes] [267538] trunk/Source/JavaScriptCore
Title: [267538] trunk/Source/_javascript_Core
Revision 267538
Author basuke.suz...@sony.com
Date 2020-09-24 11:23:57 -0700 (Thu, 24 Sep 2020)
Log Message
[PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
https://bugs.webkit.org/show_bug.cgi?id=216805
Reviewed by Don Olmstead.
When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.
On Windows, there's no such fancy feature from the beginning.
* inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
(Inspector::Socket::read):
(Inspector::Socket::write):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (267537 => 267538)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-24 17:47:53 UTC (rev 267537)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-24 18:23:57 UTC (rev 267538)
@@ -1,3 +1,19 @@
+2020-09-24 Basuke Suzuki
+
+[PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
+https://bugs.webkit.org/show_bug.cgi?id=216805
+
+Reviewed by Don Olmstead.
+
+When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
+raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.
+
+On Windows, there's no such fancy feature from the beginning.
+
+* inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
+(Inspector::Socket::read):
+(Inspector::Socket::write):
+
2020-09-24 Angelos Oikonomopoulos
[MIPS] Broken build after r267371
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp (267537 => 267538)
--- trunk/Source/_javascript_Core/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp 2020-09-24 17:47:53 UTC (rev 267537)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp 2020-09-24 18:23:57 UTC (rev 267538)
@@ -206,7 +206,7 @@
{
ASSERT(isValid(socket));
-ssize_t readSize = ::read(socket, buffer, bufferSize);
+ssize_t readSize = ::recv(socket, buffer, bufferSize, MSG_NOSIGNAL);
if (readSize >= 0)
return static_cast(readSize);
@@ -218,7 +218,7 @@
{
ASSERT(isValid(socket));
-ssize_t writeSize = ::write(socket, data, size);
+ssize_t writeSize = ::send(socket, data, size, MSG_NOSIGNAL);
if (writeSize >= 0)
return static_cast(writeSize);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [267370] trunk/Source
Title: [267370] trunk/Source Revision 267370 Author basuke.suz...@sony.com Date 2020-09-21 14:45:23 -0700 (Mon, 21 Sep 2020) Log Message [WinCairo][PlayStation] Support different instances of listener client. https://bugs.webkit.org/show_bug.cgi?id=216733 Reviewed by Don Olmstead. Source/_javascript_Core: Currently RemoteInspectorSocketEndpoint support one client instance for all listeners. This patch allows listeners to create its own listener client on accept timing. * inspector/remote/RemoteControllableTarget.h: * inspector/remote/RemoteInspector.h: * inspector/remote/socket/RemoteInspectorConnectionClient.cpp: (Inspector::RemoteInspectorConnectionClient::didReceive): * inspector/remote/socket/RemoteInspectorConnectionClient.h: * inspector/remote/socket/RemoteInspectorServer.cpp: (Inspector::RemoteInspectorServer::start): (Inspector::RemoteInspectorServer::doAccept): * inspector/remote/socket/RemoteInspectorServer.h: * inspector/remote/socket/RemoteInspectorSocket.cpp: (Inspector::RemoteInspector::didClose): * inspector/remote/socket/RemoteInspectorSocket.h: * inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp: (Inspector::RemoteInspectorSocketEndpoint::RemoteInspectorSocketEndpoint): (Inspector::RemoteInspectorSocketEndpoint::~RemoteInspectorSocketEndpoint): (Inspector::RemoteInspectorSocketEndpoint::listenInet): (Inspector::RemoteInspectorSocketEndpoint::workerThread): (Inspector::RemoteInspectorSocketEndpoint::generateConnectionID): (Inspector::RemoteInspectorSocketEndpoint::createClient): (Inspector::RemoteInspectorSocketEndpoint::disconnect): (Inspector::RemoteInspectorSocketEndpoint::createListener): (Inspector::RemoteInspectorSocketEndpoint::invalidateClient): (Inspector::RemoteInspectorSocketEndpoint::invalidateListener): (Inspector::RemoteInspectorSocketEndpoint::getPort const): (Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled): (Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled): (Inspector::RemoteInspectorSocketEndpoint::send): (Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled): * inspector/remote/socket/RemoteInspectorSocketEndpoint.h: Source/WebKit: Follows the change of RemoteInspectorSocketEndpoint::Client interface change. No new tests because there's no behaivior change. * UIProcess/Inspector/socket/RemoteInspectorClient.cpp: (WebKit::RemoteInspectorClient::didClose): * UIProcess/Inspector/socket/RemoteInspectorClient.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/remote/RemoteControllableTarget.h trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.cpp trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocket.cpp trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocket.h trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp trunk/Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (267369 => 267370) --- trunk/Source/_javascript_Core/ChangeLog 2020-09-21 21:32:21 UTC (rev 267369) +++ trunk/Source/_javascript_Core/ChangeLog 2020-09-21 21:45:23 UTC (rev 267370) @@ -1,3 +1,44 @@ +2020-09-21 Basuke Suzuki + +[WinCairo][PlayStation] Support different instances of listener client. +https://bugs.webkit.org/show_bug.cgi?id=216733 + +Reviewed by Don Olmstead. + +Currently RemoteInspectorSocketEndpoint support one client instance for all +listeners. This patch allows listeners to create its own listener client on +accept timing. + +* inspector/remote/RemoteControllableTarget.h: +* inspector/remote/RemoteInspector.h: +* inspector/remote/socket/RemoteInspectorConnectionClient.cpp: +(Inspector::RemoteInspectorConnectionClient::didReceive): +* inspector/remote/socket/RemoteInspectorConnectionClient.h: +* inspector/remote/socket/RemoteInspectorServer.cpp: +(Inspector::RemoteInspectorServer::start): +(Inspector::RemoteInspectorServer::doAccept): +* inspector/remote/socket/RemoteInspectorServer.h: +* inspector/remote/socket/RemoteInspectorSocket.cpp: +(Inspector::RemoteInspector::didClose): +* inspector/remote/socket/RemoteInspectorSocket.h: +* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp: +(Inspector::RemoteInspectorSocketEndpo
[webkit-changes] [261543] trunk/Source
Title: [261543] trunk/Source Revision 261543 Author basuke.suz...@sony.com Date 2020-05-11 20:06:23 -0700 (Mon, 11 May 2020) Log Message [bmalloc][WTF] Add computing memory size implementation for FreeBSD https://bugs.webkit.org/show_bug.cgi?id=211749 Reviewed by David Kilzer. Source/bmalloc: * bmalloc/AvailableMemory.cpp: (bmalloc::computeAvailableMemory): Source/WTF: Share sysinfo(3) implementation with Linux and FreeBSD. * wtf/RAMSize.cpp: (WTF::computeRAMSize): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/RAMSize.cpp trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp Diff Modified: trunk/Source/WTF/ChangeLog (261542 => 261543) --- trunk/Source/WTF/ChangeLog 2020-05-12 03:04:10 UTC (rev 261542) +++ trunk/Source/WTF/ChangeLog 2020-05-12 03:06:23 UTC (rev 261543) @@ -1,3 +1,15 @@ +2020-05-11 Basuke Suzuki + +[bmalloc][WTF] Add computing memory size implementation for FreeBSD +https://bugs.webkit.org/show_bug.cgi?id=211749 + +Reviewed by David Kilzer. + +Share sysinfo(3) implementation with Linux and FreeBSD. + +* wtf/RAMSize.cpp: +(WTF::computeRAMSize): + 2020-05-11 Mark Lam Introduce WTF::Config and put Signal.cpp's init-once globals in it. Modified: trunk/Source/WTF/wtf/RAMSize.cpp (261542 => 261543) --- trunk/Source/WTF/wtf/RAMSize.cpp 2020-05-12 03:04:10 UTC (rev 261542) +++ trunk/Source/WTF/wtf/RAMSize.cpp 2020-05-12 03:06:23 UTC (rev 261543) @@ -54,14 +54,14 @@ if (!result) return ramSizeGuess; return status.ullTotalPhys; -#elif defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC -#if OS(LINUX) +#elif USE(SYSTEM_MALLOC) +#if OS(LINUX) || OS(FREEBSD) struct sysinfo si; sysinfo(); return si.totalram * si.mem_unit; #else #error "Missing a platform specific way of determining the available RAM" -#endif // OS(LINUX) +#endif // OS(LINUX) || OS(FREEBSD) #else return bmalloc::api::availableMemory(); #endif Modified: trunk/Source/bmalloc/ChangeLog (261542 => 261543) --- trunk/Source/bmalloc/ChangeLog 2020-05-12 03:04:10 UTC (rev 261542) +++ trunk/Source/bmalloc/ChangeLog 2020-05-12 03:06:23 UTC (rev 261543) @@ -1,3 +1,13 @@ +2020-05-11 Basuke Suzuki + +[bmalloc][WTF] Add computing memory size implementation for FreeBSD +https://bugs.webkit.org/show_bug.cgi?id=211749 + +Reviewed by David Kilzer. + +* bmalloc/AvailableMemory.cpp: +(bmalloc::computeAvailableMemory): + 2020-05-09 Don Olmstead [CMake] Use WEBKIT_EXECUTABLE in MallocBench Modified: trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp (261542 => 261543) --- trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp 2020-05-12 03:04:10 UTC (rev 261542) +++ trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp 2020-05-12 03:06:23 UTC (rev 261543) @@ -50,6 +50,7 @@ #elif BOS(FREEBSD) #include "VMAllocate.h" #include +#include #include #include #endif @@ -168,6 +169,11 @@ return ((sizeAccordingToKernel + multiple - 1) / multiple) * multiple; #elif BOS(LINUX) return LinuxMemory::singleton().availableMemory; +#elif BOS(FREEBSD) +struct sysinfo info; +if (!sysinfo()) +return info.totalram * info.mem_unit; +return availableMemoryGuess; #elif BOS(UNIX) long pages = sysconf(_SC_PHYS_PAGES); long pageSize = sysconf(_SC_PAGE_SIZE); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261462] trunk
Title: [261462] trunk Revision 261462 Author basuke.suz...@sony.com Date 2020-05-10 16:56:21 -0700 (Sun, 10 May 2020) Log Message Add ENABLE_PERIODIC_MEMORY_MONITOR flag. https://bugs.webkit.org/show_bug.cgi?id=211704 Reviewed by Yusuke Suzuki. .: Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform's options. Enable it for PlayStation port. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsMac.cmake: * Source/cmake/OptionsPlayStation.cmake: * Source/cmake/OptionsWPE.cmake: * Source/cmake/WebKitFeatures.cmake: Source/WebKit: No new tests because there's no behavior change. Replace PLATFORM() macros with ENABLE() macro. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Source/WTF: Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform file. * wtf/PlatformEnable.h: * wtf/PlatformEnableCocoa.h: Modified Paths trunk/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnable.h trunk/Source/WTF/wtf/PlatformEnableCocoa.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebProcess.cpp trunk/Source/cmake/OptionsGTK.cmake trunk/Source/cmake/OptionsMac.cmake trunk/Source/cmake/OptionsPlayStation.cmake trunk/Source/cmake/OptionsWPE.cmake trunk/Source/cmake/WebKitFeatures.cmake Diff Modified: trunk/ChangeLog (261461 => 261462) --- trunk/ChangeLog 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/ChangeLog 2020-05-10 23:56:21 UTC (rev 261462) @@ -1,3 +1,19 @@ +2020-05-10 Basuke Suzuki + +Add ENABLE_PERIODIC_MEMORY_MONITOR flag. +https://bugs.webkit.org/show_bug.cgi?id=211704 + +Reviewed by Yusuke Suzuki. + +Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform's options. +Enable it for PlayStation port. + +* Source/cmake/OptionsGTK.cmake: +* Source/cmake/OptionsMac.cmake: +* Source/cmake/OptionsPlayStation.cmake: +* Source/cmake/OptionsWPE.cmake: +* Source/cmake/WebKitFeatures.cmake: + 2020-05-09 Don Olmstead [CMake] Use WEBKIT_EXECUTABLE in MallocBench Modified: trunk/Source/WTF/ChangeLog (261461 => 261462) --- trunk/Source/WTF/ChangeLog 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/Source/WTF/ChangeLog 2020-05-10 23:56:21 UTC (rev 261462) @@ -1,3 +1,15 @@ +2020-05-10 Basuke Suzuki + +Add ENABLE_PERIODIC_MEMORY_MONITOR flag. +https://bugs.webkit.org/show_bug.cgi?id=211704 + +Reviewed by Yusuke Suzuki. + +Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform file. + +* wtf/PlatformEnable.h: +* wtf/PlatformEnableCocoa.h: + 2020-05-10 Darin Adler Remove now-unneeded HAVE(CORE_VIDEO) Modified: trunk/Source/WTF/wtf/PlatformEnable.h (261461 => 261462) --- trunk/Source/WTF/wtf/PlatformEnable.h 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/Source/WTF/wtf/PlatformEnable.h 2020-05-10 23:56:21 UTC (rev 261462) @@ -416,6 +416,10 @@ #define ENABLE_PAYMENT_REQUEST 0 #endif +#if !defined(ENABLE_PERIODIC_MEMORY_MONITOR) +#define ENABLE_PERIODIC_MEMORY_MONITOR 0 +#endif + #if !defined(ENABLE_POINTER_LOCK) #define ENABLE_POINTER_LOCK 1 #endif Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (261461 => 261462) --- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-05-10 23:56:21 UTC (rev 261462) @@ -207,6 +207,10 @@ #define ENABLE_PAYMENT_REQUEST 1 #endif +#if !defined(ENABLE_PERIODIC_MEMORY_MONITOR) && PLATFORM(MAC) +#define ENABLE_PERIODIC_MEMORY_MONITOR 1 +#endif + #if !defined(ENABLE_ASYNC_SCROLLING) #define ENABLE_ASYNC_SCROLLING 1 #endif Modified: trunk/Source/WebKit/ChangeLog (261461 => 261462) --- trunk/Source/WebKit/ChangeLog 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/Source/WebKit/ChangeLog 2020-05-10 23:56:21 UTC (rev 261462) @@ -1,3 +1,17 @@ +2020-05-10 Basuke Suzuki + +Add ENABLE_PERIODIC_MEMORY_MONITOR flag. +https://bugs.webkit.org/show_bug.cgi?id=211704 + +Reviewed by Yusuke Suzuki. + +No new tests because there's no behavior change. + +Replace PLATFORM() macros with ENABLE() macro. + +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::initializeWebProcess): + 2020-05-10 Michael Catanzaro REGRESSION(r261270): Broke build with python3 Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (261461 => 261462) --- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2020-05-10 22:37:39 UTC (rev 261461) +++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2020-05-10 23:56:21 UTC (rev 261462) @@ -353,7 +353,7 @@ auto maintainMemoryCache = m_isSuspending && m_hasSuspendedPageProxy ? WebCore::MaintainMemoryCache::Yes : WebCore::MaintainMemoryCache::No; WebCore::releaseMemory(critical, synchronous, maintainBackForwardCache, maintainMemoryCache); }); -#if PLATFORM(MAC) || PLATFORM
[webkit-changes] [261431] trunk/Source/WebCore
Title: [261431] trunk/Source/WebCore
Revision 261431
Author basuke.suz...@sony.com
Date 2020-05-08 21:17:33 -0700 (Fri, 08 May 2020)
Log Message
Fix build error on PlatStation port after r261132
https://bugs.webkit.org/show_bug.cgi?id=211659
Unreviewed build fix after r261132.
* page/scrolling/ScrollingTreeGestureState.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingTreeGestureState.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (261430 => 261431)
--- trunk/Source/WebCore/ChangeLog 2020-05-09 01:43:42 UTC (rev 261430)
+++ trunk/Source/WebCore/ChangeLog 2020-05-09 04:17:33 UTC (rev 261431)
@@ -1,3 +1,12 @@
+2020-05-08 Basuke Suzuki
+
+Fix build error on PlatStation port after r261132
+https://bugs.webkit.org/show_bug.cgi?id=211659
+
+Unreviewed build fix after r261132.
+
+* page/scrolling/ScrollingTreeGestureState.cpp:
+
2020-05-08 David Kilzer
Remove empty directories from from svn.webkit.org repository
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTreeGestureState.cpp (261430 => 261431)
--- trunk/Source/WebCore/page/scrolling/ScrollingTreeGestureState.cpp 2020-05-09 01:43:42 UTC (rev 261430)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTreeGestureState.cpp 2020-05-09 04:17:33 UTC (rev 261431)
@@ -29,6 +29,7 @@
#if ENABLE(ASYNC_SCROLLING)
#include "PlatformWheelEvent.h"
+#include "ScrollingTree.h"
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261428] trunk
Title: [261428] trunk Revision 261428 Author basuke.suz...@sony.com Date 2020-05-08 18:13:46 -0700 (Fri, 08 May 2020) Log Message [WTF] Share Linux's MemoryPressureHandler among other Unix ports https://bugs.webkit.org/show_bug.cgi?id=208955 Reviewed by Yusuke Suzuki. Source/bmalloc: Added FreeBSD implementation of memoryFootprint(). * bmalloc/AvailableMemory.cpp: (bmalloc::memoryStatus): * bmalloc/AvailableMemory.h: (bmalloc::isUnderMemoryPressure): * bmalloc/bmalloc.h: Source/WTF: Renamed MemoryPressureHandlerLinux to MemoryPressureHandlerUnix and added FreeBSD implementation of memory status functions. Change PlayStation port to use it from generic implementation. * wtf/MemoryPressureHandler.cpp: (WTF::MemoryPressureHandler::MemoryPressureHandler): * wtf/MemoryPressureHandler.h: * wtf/PlatformGTK.cmake: * wtf/PlatformJSCOnly.cmake: * wtf/PlatformPlayStation.cmake: * wtf/PlatformWPE.cmake: * wtf/generic/MemoryFootprintGeneric.cpp: (WTF::memoryFootprint): * wtf/unix/MemoryPressureHandlerUnix.cpp: Renamed from Source\WTF\wtf\linux\MemoryPressureHandlerLinux.cpp. (WTF::processMemoryUsage): Tools: Fix unneeded library dependency. * TestWebKitAPI/CMakeLists.txt: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/MemoryPressureHandler.cpp trunk/Source/WTF/wtf/MemoryPressureHandler.h trunk/Source/WTF/wtf/PlatformGTK.cmake trunk/Source/WTF/wtf/PlatformJSCOnly.cmake trunk/Source/WTF/wtf/PlatformPlayStation.cmake trunk/Source/WTF/wtf/PlatformWPE.cmake trunk/Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp trunk/Source/bmalloc/bmalloc/AvailableMemory.h trunk/Source/bmalloc/bmalloc/bmalloc.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/CMakeLists.txt Added Paths trunk/Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp Removed Paths trunk/Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp Diff Modified: trunk/Source/WTF/ChangeLog (261427 => 261428) --- trunk/Source/WTF/ChangeLog 2020-05-09 00:02:45 UTC (rev 261427) +++ trunk/Source/WTF/ChangeLog 2020-05-09 01:13:46 UTC (rev 261428) @@ -1,3 +1,25 @@ +2020-05-08 Basuke Suzuki + +[WTF] Share Linux's MemoryPressureHandler among other Unix ports +https://bugs.webkit.org/show_bug.cgi?id=208955 + +Reviewed by Yusuke Suzuki. + +Renamed MemoryPressureHandlerLinux to MemoryPressureHandlerUnix and added FreeBSD implementation +of memory status functions. Change PlayStation port to use it from generic implementation. + +* wtf/MemoryPressureHandler.cpp: +(WTF::MemoryPressureHandler::MemoryPressureHandler): +* wtf/MemoryPressureHandler.h: +* wtf/PlatformGTK.cmake: +* wtf/PlatformJSCOnly.cmake: +* wtf/PlatformPlayStation.cmake: +* wtf/PlatformWPE.cmake: +* wtf/generic/MemoryFootprintGeneric.cpp: +(WTF::memoryFootprint): +* wtf/unix/MemoryPressureHandlerUnix.cpp: Renamed from Source\WTF\wtf\linux\MemoryPressureHandlerLinux.cpp. +(WTF::processMemoryUsage): + 2020-05-08 Darin Adler Remove now-unneeded HAVE(AVFOUNDATION_LOADER_DELEGATE) Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.cpp (261427 => 261428) --- trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2020-05-09 00:02:45 UTC (rev 261427) +++ trunk/Source/WTF/wtf/MemoryPressureHandler.cpp 2020-05-09 01:13:46 UTC (rev 261428) @@ -53,7 +53,7 @@ } MemoryPressureHandler::MemoryPressureHandler() -#if OS(LINUX) +#if OS(LINUX) || OS(FREEBSD) : m_holdOffTimer(RunLoop::main(), this, ::holdOffTimerFired) #elif OS(WINDOWS) : m_windowsMeasurementTimer(RunLoop::main(), this, ::windowsMeasurementTimerFired) Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.h (261427 => 261428) --- trunk/Source/WTF/wtf/MemoryPressureHandler.h 2020-05-09 00:02:45 UTC (rev 261427) +++ trunk/Source/WTF/wtf/MemoryPressureHandler.h 2020-05-09 01:13:46 UTC (rev 261428) @@ -66,7 +66,7 @@ WTF_EXPORT_PRIVATE void setShouldUsePeriodicMemoryMonitor(bool); -#if OS(LINUX) +#if OS(LINUX) || OS(FREEBSD) WTF_EXPORT_PRIVATE void triggerMemoryPressureEvent(bool isCritical); #endif @@ -200,7 +200,7 @@ Win32Handle m_lowMemoryHandle; #endif -#if OS(LINUX) +#if OS(LINUX) || OS(FREEBSD) RunLoop::Timer m_holdOffTimer; void holdOffTimerFired(); #endif Modified: trunk/Source/WTF/wtf/PlatformGTK.cmake (261427 => 261428) --- trunk/Source/WTF/wtf/PlatformGTK.cmake 2020-05-09 00:02:45 UTC (rev 261427) +++ trunk/Source/WTF/wtf/PlatformGTK.cmake 2020-05-09 01:13:46 UTC (rev 261428) @@ -45,8 +45,15 @@ list(APPEND WTF_SOURCES linux/CurrentProcessMemoryStatus.cpp linux/MemoryFootprintLinux.cpp -linux/MemoryPressureHandlerLinux.cpp + +unix/MemoryPressureHandlerUnix.cpp ) +elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD") +list(APPEND WTF_SOURCES +generic/MemoryFootprintGener
[webkit-changes] [258045] trunk/Tools
Title: [258045] trunk/Tools
Revision 258045
Author basuke.suz...@sony.com
Date 2020-03-06 17:53:51 -0800 (Fri, 06 Mar 2020)
Log Message
[webkitpy] Fix executive on Windows to run wpt server correctly
https://bugs.webkit.org/show_bug.cgi?id=208693
Reviewed by Jonathan Bedard.
Bug fix for Windows environment a) fixing a typo. b) fixing path
c) fix how to kill subprocesses.
* Scripts/webkitpy/common/system/executive.py:
(Executive._windows_kill_command):
(Executive.interrupt):
(Executive.kill_all):
* Scripts/webkitpy/port/base.py:
(Port.web_platform_test_server_doc_root):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive.py
trunk/Tools/Scripts/webkitpy/port/base.py
Diff
Modified: trunk/Tools/ChangeLog (258044 => 258045)
--- trunk/Tools/ChangeLog 2020-03-07 01:45:55 UTC (rev 258044)
+++ trunk/Tools/ChangeLog 2020-03-07 01:53:51 UTC (rev 258045)
@@ -1,3 +1,20 @@
+2020-03-06 Basuke Suzuki
+
+[webkitpy] Fix executive on Windows to run wpt server correctly
+https://bugs.webkit.org/show_bug.cgi?id=208693
+
+Reviewed by Jonathan Bedard.
+
+Bug fix for Windows environment a) fixing a typo. b) fixing path
+c) fix how to kill subprocesses.
+
+* Scripts/webkitpy/common/system/executive.py:
+(Executive._windows_kill_command):
+(Executive.interrupt):
+(Executive.kill_all):
+* Scripts/webkitpy/port/base.py:
+(Port.web_platform_test_server_doc_root):
+
2020-03-06 Alex Christensen
Evaluating _javascript_ in main frame before loading should succeed
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (258044 => 258045)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2020-03-07 01:45:55 UTC (rev 258044)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2020-03-07 01:53:51 UTC (rev 258045)
@@ -321,14 +321,23 @@
process_name = "%s.exe" % name
return process_name
+def _windows_kill_command(self):
+if self._is_native_win:
+return os.path.join("C:", os.sep, "WINDOWS", "system32", "taskkill.exe")
+else:
+return 'taskkill.exe'
+
def interrupt(self, pid):
-interrupt_signal = signal.CTRL_C_EVENT if self._is_native_win else signal.SIGINT
-try:
-os.kill(pid, interrupt_signal)
-except OSError:
-# Silently ignore when the pid doesn't exist.
-# It's impossible for callers to avoid race conditions with process shutdown.
-pass
+if self._is_native_win:
+command = [self._windows_kill_command(), "/f", "/t", "/pid", str(pid)]
+self.run_command(command, ignore_errors=True)
+else:
+try:
+os.kill(pid, signal.SIGINT)
+except OSError:
+# Silently ignore when the pid doesn't exist.
+# It's impossible for callers to avoid race conditions with process shutdown.
+pass
def kill_all(self, process_name):
"""Attempts to kill processes matching process_name.
@@ -335,10 +344,7 @@
Will fail silently if no process are found."""
if self._is_cygwin or self._is_native_win:
image_name = self._windows_image_name(process_name)
-killCommmand = 'taskkill.exe'
-if self._is_native_win:
-killCommand = os.path.join('C:', os.sep, 'WINDOWS', 'system32', 'taskkill.exe')
-command = [killCommmand, "/f", "/im", image_name]
+command = [self._windows_kill_command(), "/f", "/im", image_name]
# taskkill will exit 128 if the process is not found. We should log.
self.run_command(command, ignore_errors=True)
return
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (258044 => 258045)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-03-07 01:45:55 UTC (rev 258044)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-03-07 01:53:51 UTC (rev 258045)
@@ -1036,7 +1036,7 @@
self._web_platform_test_server.start()
def web_platform_test_server_doc_root(self):
-return web_platform_test_server.doc_root(self) + self.TEST_PATH_SEPARATOR
+return web_platform_test_server.doc_root(self).replace('\\', self.TEST_PATH_SEPARATOR) + self.TEST_PATH_SEPARATOR
def web_platform_test_server_base_http_url(self):
return web_platform_test_server.base_http_url(self)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257906] trunk/Tools
Title: [257906] trunk/Tools
Revision 257906
Author basuke.suz...@sony.com
Date 2020-03-04 23:50:47 -0800 (Wed, 04 Mar 2020)
Log Message
[MSVC] Add .natvis support of WebKit types
https://bugs.webkit.org/show_bug.cgi?id=193119
Reviewed by Don Olmstead.
To help the WebKit developer while debugging, this file defines how
WebKit types are displayed in debugger of Visual Studio.
Very limited set of WebKit types, but it changes the world.
* VisualStudio/WebKit.natvis: Added.
Modified Paths
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/VisualStudio/
trunk/Tools/VisualStudio/WebKit.natvis
Diff
Modified: trunk/Tools/ChangeLog (257905 => 257906)
--- trunk/Tools/ChangeLog 2020-03-05 07:18:17 UTC (rev 257905)
+++ trunk/Tools/ChangeLog 2020-03-05 07:50:47 UTC (rev 257906)
@@ -1,3 +1,16 @@
+2020-03-04 Basuke Suzuki
+
+[MSVC] Add .natvis support of WebKit types
+https://bugs.webkit.org/show_bug.cgi?id=193119
+
+Reviewed by Don Olmstead.
+
+To help the WebKit developer while debugging, this file defines how
+WebKit types are displayed in debugger of Visual Studio.
+Very limited set of WebKit types, but it changes the world.
+
+* VisualStudio/WebKit.natvis: Added.
+
2020-03-04 Wenson Hsieh
Add system trace points around display list replay
Added: trunk/Tools/VisualStudio/WebKit.natvis (0 => 257906)
--- trunk/Tools/VisualStudio/WebKit.natvis (rev 0)
+++ trunk/Tools/VisualStudio/WebKit.natvis 2020-03-05 07:50:47 UTC (rev 257906)
@@ -0,0 +1,84 @@
+
+
+
+
+empty
+{*m_ptr}
+
+
+{m_ref}
+
+
+
+
+
+ Atom:{m_data8,[m_length]s}
+
+
+ Atom:{m_data16,[m_length]su}
+
+
+
+
+ {m_data8,[m_length]s}
+
+
+ {m_data16,[m_length]su}
+
+
+
+ {m_data8,[m_length]s}
+
+
+ {m_data16,[m_length]su}
+
+
+not supported ({m_hashAndFlags})
+
+
+
+{m_impl}
+
+
+
+empty
+{m_data,[m_size]s8}
+
+
+
+{m_messageReceiverName}::{m_messageName}(ID={m_destination})
+
+
+
+{m_string}
+
+
+{m_string} (Atom)
+
+
+
+{m_identifier}
+
+
+
+{m_identifier}
+
+
+
+{m_storage,x}
+
+
+
+({m_width} x {m_height})
+
+
+
+
+
+{m_httpMethod} {m_url} {m_httpBody}
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257795] trunk/Source/JavaScriptCore
Title: [257795] trunk/Source/_javascript_Core
Revision 257795
Author basuke.suz...@sony.com
Date 2020-03-03 12:24:10 -0800 (Tue, 03 Mar 2020)
Log Message
[WinCairo][PlayStation] Add interface to get listening port of RemoteInspectorServer
https://bugs.webkit.org/show_bug.cgi?id=208391
Reviewed by Don Olmstead.
When passing zero as a port argument, system will pick an available port for it.
Without this method, client cannot get which port is listening.
* inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::start):
(Inspector::RemoteInspectorServer::getPort):
* inspector/remote/socket/RemoteInspectorServer.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (257794 => 257795)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-03 20:08:10 UTC (rev 257794)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-03 20:24:10 UTC (rev 257795)
@@ -1,3 +1,18 @@
+2020-03-03 Basuke Suzuki
+
+[WinCairo][PlayStation] Add interface to get listening port of RemoteInspectorServer
+https://bugs.webkit.org/show_bug.cgi?id=208391
+
+Reviewed by Don Olmstead.
+
+When passing zero as a port argument, system will pick an available port for it.
+Without this method, client cannot get which port is listening.
+
+* inspector/remote/socket/RemoteInspectorServer.cpp:
+(Inspector::RemoteInspectorServer::start):
+(Inspector::RemoteInspectorServer::getPort):
+* inspector/remote/socket/RemoteInspectorServer.h:
+
2020-03-03 Yusuke Suzuki
[JSC] @hasOwnLengthProperty returns wrong value if "length" is attempted to be modified
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp (257794 => 257795)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp 2020-03-03 20:08:10 UTC (rev 257794)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp 2020-03-03 20:24:10 UTC (rev 257795)
@@ -47,11 +47,23 @@
bool RemoteInspectorServer::start(const char* address, uint16_t port)
{
+if (isRunning())
+return false;
+
auto& endpoint = Inspector::RemoteInspectorSocketEndpoint::singleton();
m_server = endpoint.listenInet(address, port, *this, RemoteInspector::singleton());
return isRunning();
}
+Optional RemoteInspectorServer::getPort() const
+{
+if (!isRunning())
+return WTF::nullopt;
+
+const auto& endpoint = Inspector::RemoteInspectorSocketEndpoint::singleton();
+return endpoint.getPort(m_server.value());
+}
+
bool RemoteInspectorServer::didAccept(ConnectionID acceptedID, ConnectionID, Socket::Domain)
{
ASSERT(!isMainThread());
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h (257794 => 257795)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-03-03 20:08:10 UTC (rev 257794)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-03-03 20:24:10 UTC (rev 257795)
@@ -39,6 +39,7 @@
JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton();
JS_EXPORT_PRIVATE bool start(const char* address, uint16_t port);
+JS_EXPORT_PRIVATE Optional getPort() const;
bool isRunning() const { return !!m_server; }
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [257598] trunk/Source
Title: [257598] trunk/Source
Revision 257598
Author basuke.suz...@sony.com
Date 2020-02-27 16:06:12 -0800 (Thu, 27 Feb 2020)
Log Message
[WinCairo] Fix RemoteInspector reconnect issue
https://bugs.webkit.org/show_bug.cgi?id=208256
Reviewed by Devin Rousso.
Source/_javascript_Core:
Call target's disconnection sequence asynchronously to avoid deadlock.
* inspector/remote/RemoteConnectionToTarget.cpp:
(Inspector::RemoteConnectionToTarget::close):
* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
Source/WTF:
Added wakeupCallback to RunLoop. In case of RunLook::iterate, we need to wake up worker thread
when RunLoop is waking up.
* wtf/RunLoop.h:
* wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::setWakeUpCallback):
(WTF::RunLoop::wakeUp):
* wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::setWakeUpCallback):
(WTF::RunLoop::wakeUp):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.cpp
trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/RunLoop.h
trunk/Source/WTF/wtf/generic/RunLoopGeneric.cpp
trunk/Source/WTF/wtf/win/RunLoopWin.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (257597 => 257598)
--- trunk/Source/_javascript_Core/ChangeLog 2020-02-28 00:05:19 UTC (rev 257597)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-02-28 00:06:12 UTC (rev 257598)
@@ -1,3 +1,17 @@
+2020-02-27 Basuke Suzuki
+
+[WinCairo] Fix RemoteInspector reconnect issue
+https://bugs.webkit.org/show_bug.cgi?id=208256
+
+Reviewed by Devin Rousso.
+
+Call target's disconnection sequence asynchronously to avoid deadlock.
+
+* inspector/remote/RemoteConnectionToTarget.cpp:
+(Inspector::RemoteConnectionToTarget::close):
+* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
+(Inspector::RemoteInspectorSocketEndpoint::workerThread):
+
2020-02-26 Mark Lam
Enhance JSObjectGetProperty() to mitigate against null object pointers.
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.cpp (257597 => 257598)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.cpp 2020-02-28 00:05:19 UTC (rev 257597)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteConnectionToTarget.cpp 2020-02-28 00:06:12 UTC (rev 257598)
@@ -31,6 +31,7 @@
#include "RemoteAutomationTarget.h"
#include "RemoteInspectionTarget.h"
#include "RemoteInspector.h"
+#include
namespace Inspector {
@@ -86,18 +87,20 @@
void RemoteConnectionToTarget::close()
{
-LockHolder lock(m_targetMutex);
-if (!m_target)
-return;
+RunLoop::current().dispatch([this, protectThis = makeRef(*this)] {
+LockHolder lock(m_targetMutex);
+if (!m_target)
+return;
-auto targetIdentifier = m_target->targetIdentifier();
+auto targetIdentifier = m_target->targetIdentifier();
-if (m_connected)
-m_target->disconnect(*this);
+if (m_connected)
+m_target->disconnect(*this);
-m_target = nullptr;
+m_target = nullptr;
-RemoteInspector::singleton().updateTargetListing(targetIdentifier);
+RemoteInspector::singleton().updateTargetListing(targetIdentifier);
+});
}
void RemoteConnectionToTarget::targetClosed()
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp (257597 => 257598)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp 2020-02-28 00:05:19 UTC (rev 257597)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp 2020-02-28 00:06:12 UTC (rev 257598)
@@ -102,6 +102,12 @@
{
PollingDescriptor wakeup = Socket::preparePolling(m_wakeupReceiveSocket);
+#if USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP)
+RunLoop::setWakeUpCallback([this] {
+wakeupWorkerThread();
+});
+#endif
+
while (!m_shouldAbortWorkerThread) {
#if USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP)
RunLoop::iterate();
@@ -143,6 +149,10 @@
sendIfEnabled(id);
}
}
+
+#if USE(GENERIC_EVENT_LOOP) || USE(WINDOWS_EVENT_LOOP)
+RunLoop::setWakeUpCallback(WTF::Function());
+#endif
}
ConnectionID RemoteInspectorSocketEndpoint::generateConnectionID()
Modified: trunk/Source/WTF/ChangeLog (257597 => 257598)
--- trunk/Source/WTF/ChangeLog 2020-02-28 00:05:19 UTC (rev 257597)
+++ trunk/Source/WTF/ChangeLog 2020-02-28 00:06:12 UTC (rev 257598)
@@ -1,3 +1,21 @@
+2020-02-27 Basuke Suzuki
+
+[WinCairo] Fix RemoteInspector reconnect issue
+https://bugs.webkit.org/show_bug.cgi?id=208256
+
+Reviewed by Devin Rousso.
+
+Added wakeupCallback to RunLoop.
[webkit-changes] [257554] trunk/Source/bmalloc
Title: [257554] trunk/Source/bmalloc
Revision 257554
Author basuke.suz...@sony.com
Date 2020-02-26 20:56:58 -0800 (Wed, 26 Feb 2020)
Log Message
[bmalloc][PlayStation] Set Scavenger's thread name.
https://bugs.webkit.org/show_bug.cgi?id=208268
Reviewed by Alex Christensen.
We also need to have our thread with proper name.
* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::setThreadName):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Scavenger.cpp
Diff
Modified: trunk/Source/bmalloc/ChangeLog (257553 => 257554)
--- trunk/Source/bmalloc/ChangeLog 2020-02-27 04:43:32 UTC (rev 257553)
+++ trunk/Source/bmalloc/ChangeLog 2020-02-27 04:56:58 UTC (rev 257554)
@@ -1,3 +1,15 @@
+2020-02-26 Basuke Suzuki
+
+[bmalloc][PlayStation] Set Scavenger's thread name.
+https://bugs.webkit.org/show_bug.cgi?id=208268
+
+Reviewed by Alex Christensen.
+
+We also need to have our thread with proper name.
+
+* bmalloc/Scavenger.cpp:
+(bmalloc::Scavenger::setThreadName):
+
2020-02-25 Saam Barati
Update stale comment about PackedAlignedPtr
Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (257553 => 257554)
--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2020-02-27 04:43:32 UTC (rev 257553)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2020-02-27 04:56:58 UTC (rev 257554)
@@ -40,6 +40,10 @@
#include
#include
+#if BPLATFORM(PLAYSTATION)
+#include
+#endif
+
namespace bmalloc {
static constexpr bool verbose = false;
@@ -513,7 +517,7 @@
void Scavenger::setThreadName(const char* name)
{
BUNUSED(name);
-#if BOS(DARWIN)
+#if BOS(DARWIN) || BPLATFORM(PLAYSTATION)
pthread_setname_np(name);
#elif BOS(LINUX)
// Truncate the given name since Linux limits the size of the thread name 16 including null terminator.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256487] trunk/Source/WebCore
Title: [256487] trunk/Source/WebCore
Revision 256487
Author basuke.suz...@sony.com
Date 2020-02-12 15:46:57 -0800 (Wed, 12 Feb 2020)
Log Message
[Curl] Force HTTP/1.1 for WebSocket connection
https://bugs.webkit.org/show_bug.cgi?id=207656
Reviewed by Fujii Hironori.
No tests for H2 in LayoutTests. Checked in real site.
See: https://bugs.webkit.org/show_bug.cgi?id=176483
* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::enableConnectionOnly):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (256486 => 256487)
--- trunk/Source/WebCore/ChangeLog 2020-02-12 23:25:27 UTC (rev 256486)
+++ trunk/Source/WebCore/ChangeLog 2020-02-12 23:46:57 UTC (rev 256487)
@@ -1,3 +1,16 @@
+2020-02-12 Basuke Suzuki
+
+[Curl] Force HTTP/1.1 for WebSocket connection
+https://bugs.webkit.org/show_bug.cgi?id=207656
+
+Reviewed by Fujii Hironori.
+
+No tests for H2 in LayoutTests. Checked in real site.
+See: https://bugs.webkit.org/show_bug.cgi?id=176483
+
+* platform/network/curl/CurlContext.cpp:
+(WebCore::CurlHandle::enableConnectionOnly):
+
2020-02-12 Wenson Hsieh
Composition highlight rects should be rounded and inset
Modified: trunk/Source/WebCore/platform/network/curl/CurlContext.cpp (256486 => 256487)
--- trunk/Source/WebCore/platform/network/curl/CurlContext.cpp 2020-02-12 23:25:27 UTC (rev 256486)
+++ trunk/Source/WebCore/platform/network/curl/CurlContext.cpp 2020-02-12 23:46:57 UTC (rev 256487)
@@ -648,6 +648,7 @@
void CurlHandle::enableConnectionOnly()
{
curl_easy_setopt(m_handle, CURLOPT_CONNECT_ONLY, 1L);
+curl_easy_setopt(m_handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
}
Optional CurlHandle::getProxyUrl()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256223] trunk/Source/WebCore
Title: [256223] trunk/Source/WebCore
Revision 256223
Author basuke.suz...@sony.com
Date 2020-02-10 15:17:18 -0800 (Mon, 10 Feb 2020)
Log Message
[WebCore] Shrink Vectors passed to SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=207503
Reviewed by Yusuke Suzuki.
Once SharedBuffer::DataSegment is created, the content won't change in its life cycle. Shrink the passed vector
before assigning to member variable to save space.
With the quick research, when displaying Apple's website, 1~3% RSS usage reduction on PlayStation port.
No new tests because there's no behavior change.
* platform/SharedBuffer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (256222 => 256223)
--- trunk/Source/WebCore/ChangeLog 2020-02-10 23:14:39 UTC (rev 256222)
+++ trunk/Source/WebCore/ChangeLog 2020-02-10 23:17:18 UTC (rev 256223)
@@ -1,3 +1,19 @@
+2020-02-10 Basuke Suzuki
+
+[WebCore] Shrink Vectors passed to SharedBuffer
+https://bugs.webkit.org/show_bug.cgi?id=207503
+
+Reviewed by Yusuke Suzuki.
+
+Once SharedBuffer::DataSegment is created, the content won't change in its life cycle. Shrink the passed vector
+before assigning to member variable to save space.
+
+With the quick research, when displaying Apple's website, 1~3% RSS usage reduction on PlayStation port.
+
+No new tests because there's no behavior change.
+
+* platform/SharedBuffer.h:
+
2020-02-10 Timothy Hatcher
REGRESSION (r246055): Data detected URLs are no longer blue
Modified: trunk/Source/WebCore/platform/SharedBuffer.h (256222 => 256223)
--- trunk/Source/WebCore/platform/SharedBuffer.h 2020-02-10 23:14:39 UTC (rev 256222)
+++ trunk/Source/WebCore/platform/SharedBuffer.h 2020-02-10 23:17:18 UTC (rev 256223)
@@ -129,7 +129,12 @@
WEBCORE_EXPORT const char* data() const;
WEBCORE_EXPORT size_t size() const;
-static Ref create(Vector&& data) { return adoptRef(*new DataSegment(WTFMove(data))); }
+static Ref create(Vector&& data)
+{
+data.shrinkToFit();
+return adoptRef(*new DataSegment(WTFMove(data)));
+}
+
#if USE(CF)
static Ref create(RetainPtr&& data) { return adoptRef(*new DataSegment(WTFMove(data))); }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256110] trunk/Source/WebCore
Title: [256110] trunk/Source/WebCore
Revision 256110
Author basuke.suz...@sony.com
Date 2020-02-09 21:49:46 -0800 (Sun, 09 Feb 2020)
Log Message
Replace redundant functions with variadic template function.
https://bugs.webkit.org/show_bug.cgi?id=207413
Reviewed by Darin Adler.
No new tests. Covered by existing tests.
* loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/TextResourceDecoder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (256109 => 256110)
--- trunk/Source/WebCore/ChangeLog 2020-02-10 04:47:15 UTC (rev 256109)
+++ trunk/Source/WebCore/ChangeLog 2020-02-10 05:49:46 UTC (rev 256110)
@@ -1,3 +1,15 @@
+2020-02-09 Basuke Suzuki
+
+Replace redundant functions with variadic template function.
+https://bugs.webkit.org/show_bug.cgi?id=207413
+
+Reviewed by Darin Adler.
+
+No new tests. Covered by existing tests.
+
+* loader/TextResourceDecoder.cpp:
+(WebCore::bytesEqual):
+
2020-02-09 Keith Rollin
Re-enable LTO for ARM builds
Modified: trunk/Source/WebCore/loader/TextResourceDecoder.cpp (256109 => 256110)
--- trunk/Source/WebCore/loader/TextResourceDecoder.cpp 2020-02-10 04:47:15 UTC (rev 256109)
+++ trunk/Source/WebCore/loader/TextResourceDecoder.cpp 2020-02-10 05:49:46 UTC (rev 256110)
@@ -37,31 +37,17 @@
using namespace HTMLNames;
-static inline bool bytesEqual(const char* p, char b0, char b1)
+static constexpr bool bytesEqual(const char* p, char b)
{
-return p[0] == b0 && p[1] == b1;
+return *p == b;
}
-static inline bool bytesEqual(const char* p, char b0, char b1, char b2, char b3, char b4)
+template
+static constexpr bool bytesEqual(const char* p, char b, T... bs)
{
-return p[0] == b0 && p[1] == b1 && p[2] == b2 && p[3] == b3 && p[4] == b4;
+return *p == b && bytesEqual(p + 1, bs...);
}
-static inline bool bytesEqual(const char* p, char b0, char b1, char b2, char b3, char b4, char b5)
-{
-return p[0] == b0 && p[1] == b1 && p[2] == b2 && p[3] == b3 && p[4] == b4 && p[5] == b5;
-}
-
-static inline bool bytesEqual(const char* p, char b0, char b1, char b2, char b3, char b4, char b5, char b6, char b7)
-{
-return p[0] == b0 && p[1] == b1 && p[2] == b2 && p[3] == b3 && p[4] == b4 && p[5] == b5 && p[6] == b6 && p[7] == b7;
-}
-
-static inline bool bytesEqual(const char* p, char b0, char b1, char b2, char b3, char b4, char b5, char b6, char b7, char b8, char b9)
-{
-return p[0] == b0 && p[1] == b1 && p[2] == b2 && p[3] == b3 && p[4] == b4 && p[5] == b5 && p[6] == b6 && p[7] == b7 && p[8] == b8 && p[9] == b9;
-}
-
// You might think we should put these find functions elsewhere, perhaps with the
// similar functions that operate on UChar, but arguably only the decoder has
// a reason to process strings of char rather than UChar.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [256088] trunk/Source/bmalloc
Title: [256088] trunk/Source/bmalloc
Revision 256088
Author basuke.suz...@sony.com
Date 2020-02-08 02:35:40 -0800 (Sat, 08 Feb 2020)
Log Message
[bmalloc] VMHeap can be merge into Heap
https://bugs.webkit.org/show_bug.cgi?id=207410
Reviewed by Yusuke Suzuki.
VMHeap has only one member function in it and Heap is the only client of that.
No member variable is defined. It does nothing special with its context as a class.
It is safe to merge the function into Heap.
* CMakeLists.txt:
* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::tryAllocateLargeChunk): Moved from VMHeap.
* bmalloc/Heap.h:
* bmalloc/VMHeap.cpp: Removed.
* bmalloc/VMHeap.h: Removed.
Modified Paths
trunk/Source/bmalloc/CMakeLists.txt
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Heap.h
trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
Removed Paths
trunk/Source/bmalloc/bmalloc/VMHeap.cpp
trunk/Source/bmalloc/bmalloc/VMHeap.h
Diff
Modified: trunk/Source/bmalloc/CMakeLists.txt (256087 => 256088)
--- trunk/Source/bmalloc/CMakeLists.txt 2020-02-08 06:08:33 UTC (rev 256087)
+++ trunk/Source/bmalloc/CMakeLists.txt 2020-02-08 10:35:40 UTC (rev 256088)
@@ -31,7 +31,6 @@
bmalloc/ObjectType.cpp
bmalloc/PerProcess.cpp
bmalloc/Scavenger.cpp
-bmalloc/VMHeap.cpp
bmalloc/bmalloc.cpp
)
@@ -127,7 +126,6 @@
bmalloc/StdLibExtras.h
bmalloc/Syscall.h
bmalloc/VMAllocate.h
-bmalloc/VMHeap.h
bmalloc/Vector.h
bmalloc/Zone.h
bmalloc/bmalloc.h
Modified: trunk/Source/bmalloc/ChangeLog (256087 => 256088)
--- trunk/Source/bmalloc/ChangeLog 2020-02-08 06:08:33 UTC (rev 256087)
+++ trunk/Source/bmalloc/ChangeLog 2020-02-08 10:35:40 UTC (rev 256088)
@@ -1,3 +1,23 @@
+2020-02-08 Basuke Suzuki
+
+[bmalloc] VMHeap can be merge into Heap
+https://bugs.webkit.org/show_bug.cgi?id=207410
+
+Reviewed by Yusuke Suzuki.
+
+VMHeap has only one member function in it and Heap is the only client of that.
+No member variable is defined. It does nothing special with its context as a class.
+It is safe to merge the function into Heap.
+
+* CMakeLists.txt:
+* bmalloc.xcodeproj/project.pbxproj:
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::allocateLarge):
+(bmalloc::Heap::tryAllocateLargeChunk): Moved from VMHeap.
+* bmalloc/Heap.h:
+* bmalloc/VMHeap.cpp: Removed.
+* bmalloc/VMHeap.h: Removed.
+
2020-02-05 Don Olmstead
[bmalloc] Add declspec support for export macros
Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (256087 => 256088)
--- trunk/Source/bmalloc/bmalloc/Heap.cpp 2020-02-08 06:08:33 UTC (rev 256087)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2020-02-08 10:35:40 UTC (rev 256088)
@@ -38,11 +38,14 @@
#include "Scavenger.h"
#include "SmallLine.h"
#include "SmallPage.h"
-#include "VMHeap.h"
#include "bmalloc.h"
#include
#include
+#if BOS(DARWIN)
+#include "Zone.h"
+#endif
+
namespace bmalloc {
Heap::Heap(HeapKind kind, LockHolder&)
@@ -574,7 +577,7 @@
ASSERT_OR_RETURN_ON_FAILURE(!usingGigacage());
-range = VMHeap::get()->tryAllocateLargeChunk(alignment, size);
+range = tryAllocateLargeChunk(alignment, size);
ASSERT_OR_RETURN_ON_FAILURE(range);
m_largeFree.add(range);
@@ -593,6 +596,31 @@
#undef ASSERT_OR_RETURN_ON_FAILURE
}
+LargeRange Heap::tryAllocateLargeChunk(size_t alignment, size_t size)
+{
+// We allocate VM in aligned multiples to increase the chances that
+// the OS will provide contiguous ranges that we can merge.
+size_t roundedAlignment = roundUpToMultipleOf(alignment);
+if (roundedAlignment < alignment) // Check for overflow
+return LargeRange();
+alignment = roundedAlignment;
+
+size_t roundedSize = roundUpToMultipleOf(size);
+if (roundedSize < size) // Check for overflow
+return LargeRange();
+size = roundedSize;
+
+void* memory = tryVMAllocate(alignment, size);
+if (!memory)
+return LargeRange();
+
+#if BOS(DARWIN)
+PerProcess::get()->addRange(Range(memory, size));
+#endif
+
+return LargeRange(memory, size, 0, 0);
+}
+
bool Heap::isLarge(UniqueLockHolder&, void* object)
{
return m_objectTypes.get(Object(object).chunk()) == ObjectType::Large;
Modified: trunk/Source/bmalloc/bmalloc/Heap.h (256087 => 256088)
--- trunk/Source/bmalloc/bmalloc/Heap.h 2020-02-08 06:08:33 UTC (rev 256087)
+++ trunk/Source/bmalloc/bmalloc/Heap.h 2020-02-08 10:35:40 UTC (rev 256088)
@@ -47,11 +47,9 @@
namespace bmalloc {
-class BeginTag;
class BulkDecommit;
class BumpAllocator;
class DebugHeap;
-class EndTag;
class HeapConstants;
class Scavenger;
@@ -121,10 +119,7 @@
void allocateSmallChunk(UniqueLockHolder
[webkit-changes] [254942] trunk/Tools
Title: [254942] trunk/Tools
Revision 254942
Author basuke.suz...@sony.com
Date 2020-01-22 13:33:19 -0800 (Wed, 22 Jan 2020)
Log Message
[build-webkit] Add option for toggling unified build
https://bugs.webkit.org/show_bug.cgi?id=206597
Reviewed by Adrian Perez de Castro.
Added command line option for build-webkit script to toggle unified build.
* Scripts/webkitperl/FeatureList.pm:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Diff
Modified: trunk/Tools/ChangeLog (254941 => 254942)
--- trunk/Tools/ChangeLog 2020-01-22 21:32:11 UTC (rev 254941)
+++ trunk/Tools/ChangeLog 2020-01-22 21:33:19 UTC (rev 254942)
@@ -1,3 +1,14 @@
+2020-01-22 Basuke Suzuki
+
+[build-webkit] Add option for toggling unified build
+https://bugs.webkit.org/show_bug.cgi?id=206597
+
+Reviewed by Adrian Perez de Castro.
+
+Added command line option for build-webkit script to toggle unified build.
+
+* Scripts/webkitperl/FeatureList.pm:
+
2020-01-22 Don Olmstead
Share InjectedBundleController::platformInitialize
Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (254941 => 254942)
--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2020-01-22 21:32:11 UTC (rev 254941)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2020-01-22 21:33:19 UTC (rev 254942)
@@ -163,6 +163,7 @@
$threeDTransformsSupport,
$touchEventsSupport,
$touchSliderSupport,
+$unifiedBuildSupport,
$userMessageHandlersSupport,
$userselectAllSupport,
$variationFontsSupport,
@@ -570,6 +571,9 @@
{ option => "system-malloc", desc => "Toggle system allocator instead of bmalloc",
define => "USE_SYSTEM_MALLOC", value => \$systemMallocSupport },
+
+{ option => "unified-builds", desc => "Toggle unified builds",
+ define => "ENABLE_UNIFIED_BUILDS", value => \$unifiedBuildSupport },
);
sub getFeatureOptionList()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254871] trunk/Source/bmalloc
Title: [254871] trunk/Source/bmalloc
Revision 254871
Author basuke.suz...@sony.com
Date 2020-01-21 12:33:40 -0800 (Tue, 21 Jan 2020)
Log Message
[bmalloc] Make use of LockHolder strict in some methods of Scavenger
https://bugs.webkit.org/show_bug.cgi?id=206460
Reviewed by Darin Adler.
For instance, Scavenger::runHoldingLock() assume the caller has lock and express that by its function name. This rule can be
strict by passing LockHolder and that's the way as other code do.
Same change to runSoonHoldingLock and scheduleIfUnderMemoryPressureHoldingLock.
* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::run):
(bmalloc::Scavenger::runSoon):
(bmalloc::Scavenger::scheduleIfUnderMemoryPressure):
(bmalloc::Scavenger::schedule):
(bmalloc::Scavenger::runHoldingLock): Renamed.
(bmalloc::Scavenger::runSoonHoldingLock): Renamed.
(bmalloc::Scavenger::scheduleIfUnderMemoryPressureHoldingLock): Renamed.
* bmalloc/Scavenger.h:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Scavenger.cpp
trunk/Source/bmalloc/bmalloc/Scavenger.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (254870 => 254871)
--- trunk/Source/bmalloc/ChangeLog 2020-01-21 20:05:49 UTC (rev 254870)
+++ trunk/Source/bmalloc/ChangeLog 2020-01-21 20:33:40 UTC (rev 254871)
@@ -1,3 +1,25 @@
+2020-01-21 Basuke Suzuki
+
+[bmalloc] Make use of LockHolder strict in some methods of Scavenger
+https://bugs.webkit.org/show_bug.cgi?id=206460
+
+Reviewed by Darin Adler.
+
+For instance, Scavenger::runHoldingLock() assume the caller has lock and express that by its function name. This rule can be
+strict by passing LockHolder and that's the way as other code do.
+
+Same change to runSoonHoldingLock and scheduleIfUnderMemoryPressureHoldingLock.
+
+* bmalloc/Scavenger.cpp:
+(bmalloc::Scavenger::run):
+(bmalloc::Scavenger::runSoon):
+(bmalloc::Scavenger::scheduleIfUnderMemoryPressure):
+(bmalloc::Scavenger::schedule):
+(bmalloc::Scavenger::runHoldingLock): Renamed.
+(bmalloc::Scavenger::runSoonHoldingLock): Renamed.
+(bmalloc::Scavenger::scheduleIfUnderMemoryPressureHoldingLock): Renamed.
+* bmalloc/Scavenger.h:
+
2020-01-17 Sam Weinig
Platform.h is out of control Part 8: Macros are used inconsistently
Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (254870 => 254871)
--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2020-01-21 20:05:49 UTC (rev 254870)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2020-01-21 20:33:40 UTC (rev 254871)
@@ -93,10 +93,10 @@
void Scavenger::run()
{
LockHolder lock(mutex());
-runHoldingLock();
+run(lock);
}
-void Scavenger::runHoldingLock()
+void Scavenger::run(const LockHolder&)
{
m_state = State::Run;
m_condition.notify_all();
@@ -105,10 +105,10 @@
void Scavenger::runSoon()
{
LockHolder lock(mutex());
-runSoonHoldingLock();
+runSoon(lock);
}
-void Scavenger::runSoonHoldingLock()
+void Scavenger::runSoon(const LockHolder&)
{
if (willRunSoon())
return;
@@ -125,10 +125,10 @@
void Scavenger::scheduleIfUnderMemoryPressure(size_t bytes)
{
LockHolder lock(mutex());
-scheduleIfUnderMemoryPressureHoldingLock(bytes);
+scheduleIfUnderMemoryPressure(lock, bytes);
}
-void Scavenger::scheduleIfUnderMemoryPressureHoldingLock(size_t bytes)
+void Scavenger::scheduleIfUnderMemoryPressure(const LockHolder& lock, size_t bytes)
{
m_scavengerBytes += bytes;
if (m_scavengerBytes < scavengerBytesPerMemoryPressureCheck)
@@ -143,19 +143,19 @@
return;
m_isProbablyGrowing = false;
-runHoldingLock();
+run(lock);
}
void Scavenger::schedule(size_t bytes)
{
LockHolder lock(mutex());
-scheduleIfUnderMemoryPressureHoldingLock(bytes);
+scheduleIfUnderMemoryPressure(lock, bytes);
if (willRunSoon())
return;
m_isProbablyGrowing = false;
-runSoonHoldingLock();
+runSoon(lock);
}
inline void dumpStats()
Modified: trunk/Source/bmalloc/bmalloc/Scavenger.h (254870 => 254871)
--- trunk/Source/bmalloc/bmalloc/Scavenger.h 2020-01-21 20:05:49 UTC (rev 254870)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.h 2020-01-21 20:33:40 UTC (rev 254871)
@@ -77,10 +77,10 @@
private:
enum class State { Sleep, Run, RunSoon };
-void runHoldingLock();
-void runSoonHoldingLock();
+void run(const LockHolder&);
+void runSoon(const LockHolder&);
-void scheduleIfUnderMemoryPressureHoldingLock(size_t bytes);
+void scheduleIfUnderMemoryPressure(const LockHolder&, size_t bytes);
BNO_RETURN static void threadEntryPoint(Scavenger*);
BNO_RETURN void threadRunLoop();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [254781] trunk/Source/bmalloc
: (bmalloc::Scavenger::runSoon): (bmalloc::Scavenger::scheduleIfUnderMemoryPressure): (bmalloc::Scavenger::schedule): (bmalloc::Scavenger::timeSinceLastFullScavenge): (bmalloc::Scavenger::timeSinceLastPartialScavenge): (bmalloc::Scavenger::scavenge): (bmalloc::Scavenger::partialScavenge): (bmalloc::Scavenger::freeableMemory): (bmalloc::Scavenger::threadRunLoop): * bmalloc/Scavenger.h: * bmalloc/SmallLine.h: (bmalloc::SmallLine::refCount): (bmalloc::SmallLine::ref): (bmalloc::SmallLine::deref): * bmalloc/SmallPage.h: (bmalloc::SmallPage::refCount): (bmalloc::SmallPage::hasFreeLines const): (bmalloc::SmallPage::setHasFreeLines): (bmalloc::SmallPage::ref): (bmalloc::SmallPage::deref): * bmalloc/StaticPerProcess.h: * bmalloc/VMHeap.cpp: (bmalloc::VMHeap::VMHeap): * bmalloc/VMHeap.h: * bmalloc/Zone.cpp: (bmalloc::Zone::Zone): * bmalloc/Zone.h: * bmalloc/bmalloc.cpp: (bmalloc::api::tryLargeZeroedMemalignVirtual): (bmalloc::api::freeLargeVirtual): (bmalloc::api::setScavengerThreadQOSClass): Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/AllIsoHeaps.cpp trunk/Source/bmalloc/bmalloc/AllIsoHeaps.h trunk/Source/bmalloc/bmalloc/Allocator.cpp trunk/Source/bmalloc/bmalloc/CryptoRandom.cpp trunk/Source/bmalloc/bmalloc/Deallocator.cpp trunk/Source/bmalloc/bmalloc/Deallocator.h trunk/Source/bmalloc/bmalloc/DebugHeap.cpp trunk/Source/bmalloc/bmalloc/DebugHeap.h trunk/Source/bmalloc/bmalloc/DeferredTrigger.h trunk/Source/bmalloc/bmalloc/DeferredTriggerInlines.h trunk/Source/bmalloc/bmalloc/Environment.cpp trunk/Source/bmalloc/bmalloc/Environment.h trunk/Source/bmalloc/bmalloc/Gigacage.cpp trunk/Source/bmalloc/bmalloc/Heap.cpp trunk/Source/bmalloc/bmalloc/Heap.h trunk/Source/bmalloc/bmalloc/HeapConstants.cpp trunk/Source/bmalloc/bmalloc/HeapConstants.h trunk/Source/bmalloc/bmalloc/IsoAllocatorInlines.h trunk/Source/bmalloc/bmalloc/IsoDeallocatorInlines.h trunk/Source/bmalloc/bmalloc/IsoDirectory.h trunk/Source/bmalloc/bmalloc/IsoDirectoryInlines.h trunk/Source/bmalloc/bmalloc/IsoHeapImpl.h trunk/Source/bmalloc/bmalloc/IsoHeapImplInlines.h trunk/Source/bmalloc/bmalloc/IsoPage.h trunk/Source/bmalloc/bmalloc/IsoPageInlines.h trunk/Source/bmalloc/bmalloc/IsoSharedHeap.h trunk/Source/bmalloc/bmalloc/IsoSharedHeapInlines.h trunk/Source/bmalloc/bmalloc/IsoSharedPage.h trunk/Source/bmalloc/bmalloc/IsoSharedPageInlines.h trunk/Source/bmalloc/bmalloc/IsoTLSDeallocatorEntry.h trunk/Source/bmalloc/bmalloc/IsoTLSDeallocatorEntryInlines.h trunk/Source/bmalloc/bmalloc/IsoTLSInlines.h trunk/Source/bmalloc/bmalloc/IsoTLSLayout.cpp trunk/Source/bmalloc/bmalloc/IsoTLSLayout.h trunk/Source/bmalloc/bmalloc/Mutex.h trunk/Source/bmalloc/bmalloc/ObjectType.cpp trunk/Source/bmalloc/bmalloc/PerProcess.cpp trunk/Source/bmalloc/bmalloc/PerProcess.h trunk/Source/bmalloc/bmalloc/Scavenger.cpp trunk/Source/bmalloc/bmalloc/Scavenger.h trunk/Source/bmalloc/bmalloc/SmallLine.h trunk/Source/bmalloc/bmalloc/SmallPage.h trunk/Source/bmalloc/bmalloc/StaticPerProcess.h trunk/Source/bmalloc/bmalloc/VMHeap.cpp trunk/Source/bmalloc/bmalloc/VMHeap.h trunk/Source/bmalloc/bmalloc/Zone.cpp trunk/Source/bmalloc/bmalloc/Zone.h trunk/Source/bmalloc/bmalloc/bmalloc.cpp Diff Modified: trunk/Source/bmalloc/ChangeLog (254780 => 254781) --- trunk/Source/bmalloc/ChangeLog 2020-01-18 00:42:32 UTC (rev 254780) +++ trunk/Source/bmalloc/ChangeLog 2020-01-18 00:43:00 UTC (rev 254781) @@ -1,3 +1,171 @@ +2020-01-17 Basuke Suzuki + +[bmalloc] Define alias for std::lock_guard and std::unique_lock for better readability +https://bugs.webkit.org/show_bug.cgi?id=206443 + +Reviewed by Yusuke Suzuki. + +There are two types of lock holder in bmalloc: std::lock_guard and std::unique_lock. Their names are relatively long +and a bit harder to distinguish them each other. Define simple type name for them, LockHolder and UniqueLockHolder. + +* bmalloc/AllIsoHeaps.cpp: +(bmalloc::AllIsoHeaps::AllIsoHeaps): +(bmalloc::AllIsoHeaps::add): +(bmalloc::AllIsoHeaps::head): +* bmalloc/AllIsoHeaps.h: +* bmalloc/Allocator.cpp: +(bmalloc::Allocator::reallocateImpl): +(bmalloc::Allocator::refillAllocatorSlowCase): +(bmalloc::Allocator::allocateLarge): +* bmalloc/CryptoRandom.cpp: +(bmalloc::ARC4RandomNumberGenerator::ARC4RandomNumberGenerator): +(bmalloc::ARC4RandomNumberGenerator::randomValues): +* bmalloc/Deallocator.cpp: +(bmalloc::Deallocator::scavenge): +(bmalloc::Deallocator::processObjectLog): +(bmalloc::Deallocator::deallocateSlowCase): +* bmalloc/Deallocator.h: +(bmalloc::Deallocator::lineCache): +* bmalloc/DebugHeap.cpp: +(bmalloc::DebugHeap::DebugHeap): +(bmalloc::DebugHeap::memalignLarge): +(bmalloc::DebugHeap::freeLarge): +* bmalloc/DebugHeap.h: +* bmalloc/DeferredTrigger.h: +* bmalloc/DeferredTriggerInlines.h: +(
[webkit-changes] [254527] trunk/Source/bmalloc
Title: [254527] trunk/Source/bmalloc
Revision 254527
Author basuke.suz...@sony.com
Date 2020-01-14 12:51:31 -0800 (Tue, 14 Jan 2020)
Log Message
[bmalloc] Calculate LineMetadata for specific VM page size in compile time
https://bugs.webkit.org/show_bug.cgi?id=206044
Reviewed by Yusuke Suzuki.
LineMetadata is dependent only on VM page size. This patch enables the pre-calculation for
specific VM page sizes by compiler flags. The benefit is both runtime initialization speed
up and avoiding extra VM allocation on runtime.
First targets are 4k (Mac) and 16k (some iOS, PlayStation) VM page sizes.
* bmalloc/Algorithm.h:
(bmalloc::divideRoundingUp):
* bmalloc/BPlatform.h:
* bmalloc/HeapConstants.cpp:
(bmalloc::fillLineMetadata):
(bmalloc::computeLineMetadata):
(bmalloc::HeapConstants::initializeLineMetadata):
* bmalloc/HeapConstants.h:
(bmalloc::HeapConstants::smallLineCount const):
(bmalloc::HeapConstants::startOffset const):
(bmalloc::HeapConstants::objectCount const):
(bmalloc::HeapConstants::lineMetadata const):
(bmalloc::HeapConstants::startOffset): Deleted.
(bmalloc::HeapConstants::objectCount): Deleted.
(bmalloc::HeapConstants::lineMetadata): Deleted.
* bmalloc/LineMetadata.h:
* bmalloc/Sizes.h:
(bmalloc::Sizes::maskObjectSize):
(bmalloc::Sizes::logSizeClass):
(bmalloc::Sizes::logObjectSize):
(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize):
(bmalloc::Sizes::pageSize):
(bmalloc::Sizes::smallLineCount):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Algorithm.h
trunk/Source/bmalloc/bmalloc/BPlatform.h
trunk/Source/bmalloc/bmalloc/HeapConstants.cpp
trunk/Source/bmalloc/bmalloc/HeapConstants.h
trunk/Source/bmalloc/bmalloc/LineMetadata.h
trunk/Source/bmalloc/bmalloc/Sizes.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (254526 => 254527)
--- trunk/Source/bmalloc/ChangeLog 2020-01-14 20:46:52 UTC (rev 254526)
+++ trunk/Source/bmalloc/ChangeLog 2020-01-14 20:51:31 UTC (rev 254527)
@@ -1,3 +1,41 @@
+2020-01-14 Basuke Suzuki
+
+[bmalloc] Calculate LineMetadata for specific VM page size in compile time
+https://bugs.webkit.org/show_bug.cgi?id=206044
+
+Reviewed by Yusuke Suzuki.
+
+LineMetadata is dependent only on VM page size. This patch enables the pre-calculation for
+specific VM page sizes by compiler flags. The benefit is both runtime initialization speed
+up and avoiding extra VM allocation on runtime.
+
+First targets are 4k (Mac) and 16k (some iOS, PlayStation) VM page sizes.
+
+* bmalloc/Algorithm.h:
+(bmalloc::divideRoundingUp):
+* bmalloc/BPlatform.h:
+* bmalloc/HeapConstants.cpp:
+(bmalloc::fillLineMetadata):
+(bmalloc::computeLineMetadata):
+(bmalloc::HeapConstants::initializeLineMetadata):
+* bmalloc/HeapConstants.h:
+(bmalloc::HeapConstants::smallLineCount const):
+(bmalloc::HeapConstants::startOffset const):
+(bmalloc::HeapConstants::objectCount const):
+(bmalloc::HeapConstants::lineMetadata const):
+(bmalloc::HeapConstants::startOffset): Deleted.
+(bmalloc::HeapConstants::objectCount): Deleted.
+(bmalloc::HeapConstants::lineMetadata): Deleted.
+* bmalloc/LineMetadata.h:
+* bmalloc/Sizes.h:
+(bmalloc::Sizes::maskObjectSize):
+(bmalloc::Sizes::logSizeClass):
+(bmalloc::Sizes::logObjectSize):
+(bmalloc::Sizes::sizeClass):
+(bmalloc::Sizes::objectSize):
+(bmalloc::Sizes::pageSize):
+(bmalloc::Sizes::smallLineCount):
+
2020-01-14 David Kilzer
Enable -Wconditional-uninitialized in bmalloc, WTF, _javascript_Core
Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (254526 => 254527)
--- trunk/Source/bmalloc/bmalloc/Algorithm.h 2020-01-14 20:46:52 UTC (rev 254526)
+++ trunk/Source/bmalloc/bmalloc/Algorithm.h 2020-01-14 20:51:31 UTC (rev 254527)
@@ -129,7 +129,7 @@
quotient += 1;
}
-template inline T divideRoundingUp(T numerator, T denominator)
+template constexpr T divideRoundingUp(T numerator, T denominator)
{
return (numerator + denominator - 1) / denominator;
}
Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (254526 => 254527)
--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2020-01-14 20:46:52 UTC (rev 254526)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2020-01-14 20:51:31 UTC (rev 254527)
@@ -262,3 +262,11 @@
#else
#define BUSE_PARTIAL_SCAVENGE 0
#endif
+
+#if !defined(BUSE_PRECOMPUTED_CONSTANTS_VMPAGE4K)
+#define BUSE_PRECOMPUTED_CONSTANTS_VMPAGE4K 1
+#endif
+
+#if !defined(BUSE_PRECOMPUTED_CONSTANTS_VMPAGE16K)
+#define BUSE_PRECOMPUTED_CONSTANTS_VMPAGE16K 1
+#endif
Modified: trunk/Source/bmalloc/bmalloc/HeapConstants.cpp (254526 => 254527)
--- trunk/Source/bmalloc/bmalloc/HeapConstants.cpp 2020-01-14 20:46:52 UTC (rev 254526)
+++ trunk/Source/bmalloc/bmalloc/HeapConstants.cpp 2020-01-14 20:51:31 UTC (rev 254527)
@@ -24,6 +24,7 @@
*/
[webkit-changes] [254303] trunk/Source/bmalloc
Title: [254303] trunk/Source/bmalloc Revision 254303 Author basuke.suz...@sony.com Date 2020-01-09 14:57:39 -0800 (Thu, 09 Jan 2020) Log Message [bmalloc] Extract constants from Heap and share it among Heaps. https://bugs.webkit.org/show_bug.cgi?id=205834 Reviewed by Geoffrey Garen. A Heap has many constants (m_vmPageSizePhysical, m_smallLineMetadata and m_pageClasses) and they are dependent only to vmPageSizePhysical and identical for all Heaps. Extracting them into a class and make it sharable among heaps. Also this is the first step for making Heap constants to actual `constexpr`. * CMakeLists.txt: Added HeapConstants.cpp. * bmalloc.xcodeproj/project.pbxproj: Ditto. * bmalloc/Heap.cpp: Referencing HeapConstants object to get information. (bmalloc::Heap::Heap): (bmalloc::Heap::allocateSmallPage): (bmalloc::Heap::deallocateSmallLine): (bmalloc::Heap::allocateSmallBumpRangesByMetadata): (bmalloc::Heap::allocateSmallBumpRangesByObject): (bmalloc::Heap::initializeLineMetadata): Moved to HeapConstants.cpp. (bmalloc::Heap::initializePageMetadata): Moved to HeapConstants.cpp. * bmalloc/Heap.h: Extract metadata initialization and member variables. * bmalloc/HeapConstants.cpp: Added. (bmalloc::HeapConstants::HeapConstants): (bmalloc::HeapConstants::initializeLineMetadata): (bmalloc::HeapConstants::initializePageMetadata): * bmalloc/HeapConstants.h: (bmalloc::HeapConstants::pageClass const): (bmalloc::HeapConstants::smallLineCount const): (bmalloc::HeapConstants::startOffset): (bmalloc::HeapConstants::objectCount): (bmalloc::HeapConstants::lineMetadata): Modified Paths trunk/Source/bmalloc/CMakeLists.txt trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Heap.cpp trunk/Source/bmalloc/bmalloc/Heap.h trunk/Source/bmalloc/bmalloc/LineMetadata.h trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj Added Paths trunk/Source/bmalloc/bmalloc/HeapConstants.cpp trunk/Source/bmalloc/bmalloc/HeapConstants.h Diff Modified: trunk/Source/bmalloc/CMakeLists.txt (254302 => 254303) --- trunk/Source/bmalloc/CMakeLists.txt 2020-01-09 22:57:24 UTC (rev 254302) +++ trunk/Source/bmalloc/CMakeLists.txt 2020-01-09 22:57:39 UTC (rev 254303) @@ -16,6 +16,7 @@ bmalloc/FreeList.cpp bmalloc/Gigacage.cpp bmalloc/Heap.cpp +bmalloc/HeapConstants.cpp bmalloc/HeapKind.cpp bmalloc/IsoHeapImpl.cpp bmalloc/IsoPage.cpp @@ -70,6 +71,7 @@ bmalloc/FreeListInlines.h bmalloc/Gigacage.h bmalloc/Heap.h +bmalloc/HeapConstants.h bmalloc/HeapKind.h bmalloc/IsoAllocator.h bmalloc/IsoAllocatorInlines.h Modified: trunk/Source/bmalloc/ChangeLog (254302 => 254303) --- trunk/Source/bmalloc/ChangeLog 2020-01-09 22:57:24 UTC (rev 254302) +++ trunk/Source/bmalloc/ChangeLog 2020-01-09 22:57:39 UTC (rev 254303) @@ -1,3 +1,38 @@ +2020-01-09 Basuke Suzuki + +[bmalloc] Extract constants from Heap and share it among Heaps. +https://bugs.webkit.org/show_bug.cgi?id=205834 + +Reviewed by Geoffrey Garen. + +A Heap has many constants (m_vmPageSizePhysical, m_smallLineMetadata and m_pageClasses) and they +are dependent only to vmPageSizePhysical and identical for all Heaps. + +Extracting them into a class and make it sharable among heaps. Also this is the first step for +making Heap constants to actual `constexpr`. + +* CMakeLists.txt: Added HeapConstants.cpp. +* bmalloc.xcodeproj/project.pbxproj: Ditto. +* bmalloc/Heap.cpp: Referencing HeapConstants object to get information. +(bmalloc::Heap::Heap): +(bmalloc::Heap::allocateSmallPage): +(bmalloc::Heap::deallocateSmallLine): +(bmalloc::Heap::allocateSmallBumpRangesByMetadata): +(bmalloc::Heap::allocateSmallBumpRangesByObject): +(bmalloc::Heap::initializeLineMetadata): Moved to HeapConstants.cpp. +(bmalloc::Heap::initializePageMetadata): Moved to HeapConstants.cpp. +* bmalloc/Heap.h: Extract metadata initialization and member variables. +* bmalloc/HeapConstants.cpp: Added. +(bmalloc::HeapConstants::HeapConstants): +(bmalloc::HeapConstants::initializeLineMetadata): +(bmalloc::HeapConstants::initializePageMetadata): +* bmalloc/HeapConstants.h: +(bmalloc::HeapConstants::pageClass const): +(bmalloc::HeapConstants::smallLineCount const): +(bmalloc::HeapConstants::startOffset): +(bmalloc::HeapConstants::objectCount): +(bmalloc::HeapConstants::lineMetadata): + 2020-01-02 Yusuke Suzuki and Simon Fraser Experiment: create lots of different malloc zones for easier accounting of memory use Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (254302 => 254303) --- trunk/Source/bmalloc/bmalloc/Heap.cpp 2020-01-09 22:57:24 UTC (rev 254302) +++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2020-01-09 22:57:39 UTC (rev 254303) @@ -30,9 +30,10 @@ #include "BumpAllocator.h" #include
[webkit-changes] [254140] trunk/Tools
Title: [254140] trunk/Tools
Revision 254140
Author basuke.suz...@sony.com
Date 2020-01-07 11:04:01 -0800 (Tue, 07 Jan 2020)
Log Message
check-webkit-style: bmalloc doesn't use config.h
https://bugs.webkit.org/show_bug.cgi?id=205840
Reviewed by Jonathan Bedard.
* Scripts/webkitpy/style/checkers/cpp.py:
(_IncludeState.check_next_include_order):
(check_include_line):
(check_has_config_header):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (254139 => 254140)
--- trunk/Tools/ChangeLog 2020-01-07 18:55:55 UTC (rev 254139)
+++ trunk/Tools/ChangeLog 2020-01-07 19:04:01 UTC (rev 254140)
@@ -1,3 +1,15 @@
+2020-01-07 Basuke Suzuki
+
+check-webkit-style: bmalloc doesn't use config.h
+https://bugs.webkit.org/show_bug.cgi?id=205840
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(_IncludeState.check_next_include_order):
+(check_include_line):
+(check_has_config_header):
+
2020-01-07 youenn fablet
Add an option to make video capture in GPUProcess
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (254139 => 254140)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-01-07 18:55:55 UTC (rev 254139)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-01-07 19:04:01 UTC (rev 254140)
@@ -137,6 +137,10 @@
_unit_test_config = {}
+_NO_CONFIG_H_PATH_PATTERNS = [
+'^Source/bmalloc/',
+]
+
def iteratively_replace_matches_with_char(pattern, char_replacement, s):
"""Returns the string with replacement done.
@@ -294,7 +298,7 @@
def visited_soft_link_section(self):
return self._visited_soft_link_section
-def check_next_include_order(self, header_type, filename, file_is_header, primary_header_exists):
+def check_next_include_order(self, header_type, filename, file_is_header, primary_header_exists, has_config_header):
"""Returns a non-empty error message if the next header is out of order.
This function also updates the internal state to be ready to check
@@ -305,6 +309,7 @@
filename: The name of the current file.
file_is_header: Whether the file that owns this _IncludeState is itself a header
primary_header_exists: Whether the primary header file actually exists on disk
+ has_config_header: Whether project uses config.h or not.
Returns:
The empty string if the header is in the right order, or an
@@ -334,7 +339,7 @@
elif header_type == _PRIMARY_HEADER:
if self._section >= self._PRIMARY_SECTION:
error_message = after_error_message
-elif self._section < self._CONFIG_SECTION:
+elif has_config_header and self._section < self._CONFIG_SECTION:
error_message = before_error_message
self._section = self._PRIMARY_SECTION
self._visited_primary_section = True
@@ -3181,6 +3186,8 @@
header_type = _classify_include(filename, include, is_system, include_state)
primary_header_exists = _does_primary_header_exist(filename)
+has_config_header = check_has_config_header(filename)
+
include_state.header_types[line_number] = header_type
# Only proceed if this isn't a duplicate header.
@@ -3195,7 +3202,8 @@
error_message = include_state.check_next_include_order(header_type,
filename,
file_extension == "h",
- primary_header_exists)
+ primary_header_exists,
+ has_config_header)
# Check to make sure *SoftLink.h headers always appear last and never in a header.
if error_message and include_state.visited_soft_link_section():
@@ -3209,7 +3217,7 @@
if not is_blank_line(next_line):
error(line_number, 'build/include_order', 4,
'You should add a blank line after implementation file\'s own header.')
-if is_blank_line(previous_line):
+if has_config_header and is_blank_line(previous_line):
error(line_number, 'build/include_order', 4,
'You should not add a blank line before implementation file\'s own header.')
@@ -3800,6 +3808,15 @@
return file_path in _AUTO_GENERATED_FILES
+def check_has_config_header(file_path):
+"""Check if the module uses config.h"""
+file_path = file_path.replace(os.path.sep, '/')
+for pattern in _NO_CONFIG_H_PATH_PATTERNS:
+if re.match(pattern, file_path):
+return False
+return True
+
+
[webkit-changes] [253245] trunk/Source/bmalloc
Title: [253245] trunk/Source/bmalloc Revision 253245 Author basuke.suz...@sony.com Date 2019-12-07 00:42:49 -0800 (Sat, 07 Dec 2019) Log Message [bmalloc] Decommit unused region in chunk metadata. https://bugs.webkit.org/show_bug.cgi?id=204810 Reviewed by Yusuke Suzuki. There is an unused memory region from just after Chunk object to next page border. We can decommit those memory to kernel at the initialization of Chunk. * bmalloc/Heap.cpp: (bmalloc::Heap::allocateSmallChunk): Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Heap.cpp Diff Modified: trunk/Source/bmalloc/ChangeLog (253244 => 253245) --- trunk/Source/bmalloc/ChangeLog 2019-12-07 07:50:19 UTC (rev 253244) +++ trunk/Source/bmalloc/ChangeLog 2019-12-07 08:42:49 UTC (rev 253245) @@ -1,3 +1,16 @@ +2019-12-07 Basuke Suzuki + +[bmalloc] Decommit unused region in chunk metadata. +https://bugs.webkit.org/show_bug.cgi?id=204810 + +Reviewed by Yusuke Suzuki. + +There is an unused memory region from just after Chunk object to next page border. +We can decommit those memory to kernel at the initialization of Chunk. + +* bmalloc/Heap.cpp: +(bmalloc::Heap::allocateSmallChunk): + 2019-11-25 Fujii Hironori Ran sort-Xcode-project-file. Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (253244 => 253245) --- trunk/Source/bmalloc/bmalloc/Heap.cpp 2019-12-07 07:50:19 UTC (rev 253244) +++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2019-12-07 08:42:49 UTC (rev 253245) @@ -287,9 +287,12 @@ m_freeableMemory += accountedInFreeable; -auto decommitSize = chunkSize - Chunk::metadataSize(pageSize) - accountedInFreeable; +auto metadataSize = Chunk::metadataSize(pageSize); +vmDeallocatePhysicalPagesSloppy(chunk->address(sizeof(Chunk)), metadataSize - sizeof(Chunk)); + +auto decommitSize = chunkSize - metadataSize - accountedInFreeable; if (decommitSize > 0) -vmDeallocatePhysicalPagesSloppy(Chunk::get(chunk)->address(chunkSize - decommitSize), decommitSize); +vmDeallocatePhysicalPagesSloppy(chunk->address(chunkSize - decommitSize), decommitSize); m_scavenger->schedule(0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252621] trunk/Source/bmalloc
Title: [252621] trunk/Source/bmalloc
Revision 252621
Author basuke.suz...@sony.com
Date 2019-11-18 19:29:12 -0800 (Mon, 18 Nov 2019)
Log Message
[bmalloc] Some chunks have unused region in the tail of its memory block.
https://bugs.webkit.org/show_bug.cgi?id=204286
Reviewed by Yusuke Suzuki.
When chunk is initialized, some amount of memory are not used and be kept untouched until its end.
This patch tries to decommit those region at the end of initialization.
For instance, think about the case that the pageClass is 5. Then pageSize is 24k. With this pageSize,
a chunk can hold 42 pages and its size is 24k * 42 = 1008k which is smaller than chunkSize = 1024k.
Here is the complete result:
pagepagepage
class sizecount remainings
--
0 4kB 256 0
1 8kB 128 0
2 12kB85 4kB
3 16kB64 0
4 20kB51 4kB
5 24kB42 16kB
6 28kB36 16kB
7 32kB32 0
8 36kB28 16kB
9 40kB25 24kB
10 44kB23 12kB
11 48kB21 16kB
12 52kB19 36kB
13 56kB18 16kB
14 60kB17 4kB
15 64kB16 0
Tested on Mac testmem and result is almost same or in error margin.
Before: After:
end score: 8.5425 MB end score: 8.5127 MB
peak score: 8.7997 MB peak score: 8.7884 MB
total memory score: 8.6702 MB total memory score: 8.6495 MB
time score: 668.19 ms time score: 666.27 ms
* bmalloc/Chunk.h:
(bmalloc::Chunk::metadataSize):
(bmalloc::forEachPage):
* bmalloc/Heap.cpp:
(bmalloc::Heap::allocateSmallChunk):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Chunk.h
trunk/Source/bmalloc/bmalloc/Heap.cpp
Diff
Modified: trunk/Source/bmalloc/ChangeLog (252620 => 252621)
--- trunk/Source/bmalloc/ChangeLog 2019-11-19 03:16:44 UTC (rev 252620)
+++ trunk/Source/bmalloc/ChangeLog 2019-11-19 03:29:12 UTC (rev 252621)
@@ -1,3 +1,51 @@
+2019-11-18 Basuke Suzuki
+
+[bmalloc] Some chunks have unused region in the tail of its memory block.
+https://bugs.webkit.org/show_bug.cgi?id=204286
+
+Reviewed by Yusuke Suzuki.
+
+When chunk is initialized, some amount of memory are not used and be kept untouched until its end.
+This patch tries to decommit those region at the end of initialization.
+
+For instance, think about the case that the pageClass is 5. Then pageSize is 24k. With this pageSize,
+a chunk can hold 42 pages and its size is 24k * 42 = 1008k which is smaller than chunkSize = 1024k.
+Here is the complete result:
+
+pagepagepage
+class sizecount remainings
+--
+0 4kB 256 0
+1 8kB 128 0
+2 12kB85 4kB
+3 16kB64 0
+4 20kB51 4kB
+5 24kB42 16kB
+6 28kB36 16kB
+7 32kB32 0
+8 36kB28 16kB
+9 40kB25 24kB
+10 44kB23 12kB
+11 48kB21 16kB
+12 52kB19 36kB
+13 56kB18 16kB
+14 60kB17 4kB
+15 64kB16 0
+
+Tested on Mac testmem and result is almost same or in error margin.
+
+Before: After:
+end score: 8.5425 MB end score: 8.5127 MB
+peak score: 8.7997 MB peak score: 8.7884 MB
+total memory score: 8.6702 MB total memory score: 8.6495 MB
+time score: 668.19 ms time score: 666.27 ms
+
+* bmalloc/Chunk.h:
+(bmalloc::Chunk::metadataSize):
+(bmalloc::forEachPage):
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::allocateSmallChunk):
+
2019-11-15 Basuke Suzuki
[bmalloc] The tracking of freeableMemory of Heap doesn't count Chunk's metadata size.
Modified: trunk/Source/bmalloc/bmalloc/Chunk.h (252620 => 252621)
--- trunk/Source/bmalloc/bmalloc/Chunk.h 2019-11-19 03:16:44 UTC (rev 252620)
+++ trunk/Source/bmalloc/bmalloc/Chunk.h 2019-11-19 03:29:12 UTC (rev 252621)
@@ -38,6 +38,7 @@
class Chunk : public ListNode {
public:
static Chunk* get(void*);
+static
[webkit-changes] [252519] trunk/Source/bmalloc
Title: [252519] trunk/Source/bmalloc
Revision 252519
Author basuke.suz...@sony.com
Date 2019-11-15 18:34:32 -0800 (Fri, 15 Nov 2019)
Log Message
[bmalloc] The tracking of freeableMemory of Heap doesn't count Chunk's metadata size.
https://bugs.webkit.org/show_bug.cgi?id=204135
Reviewed by Yusuke Suzuki.
When chunk is allocated in allocateSmallChunk(), all chunk size is added to freeableMemory.
This is wrong. Only free pages should be added to it.
* bmalloc/Heap.cpp:
(bmalloc::Heap::allocateSmallChunk):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
Diff
Modified: trunk/Source/bmalloc/ChangeLog (252518 => 252519)
--- trunk/Source/bmalloc/ChangeLog 2019-11-16 02:32:40 UTC (rev 252518)
+++ trunk/Source/bmalloc/ChangeLog 2019-11-16 02:34:32 UTC (rev 252519)
@@ -1,5 +1,18 @@
2019-11-15 Basuke Suzuki
+[bmalloc] The tracking of freeableMemory of Heap doesn't count Chunk's metadata size.
+https://bugs.webkit.org/show_bug.cgi?id=204135
+
+Reviewed by Yusuke Suzuki.
+
+When chunk is allocated in allocateSmallChunk(), all chunk size is added to freeableMemory.
+This is wrong. Only free pages should be added to it.
+
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::allocateSmallChunk):
+
+2019-11-15 Basuke Suzuki
+
[Mac] Use better describing name for Mac's scavenger compiler flag.
https://bugs.webkit.org/show_bug.cgi?id=203922
Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (252518 => 252519)
--- trunk/Source/bmalloc/bmalloc/Heap.cpp 2019-11-16 02:32:40 UTC (rev 252518)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2019-11-16 02:34:32 UTC (rev 252519)
@@ -274,6 +274,7 @@
m_objectTypes.set(chunk, ObjectType::Small);
+size_t accountedInFreeable = 0;
forEachPage(chunk, pageSize, [&](SmallPage* page) {
page->setHasPhysicalPages(true);
#if !BUSE(PARTIAL_SCAVENGE)
@@ -281,9 +282,10 @@
#endif
page->setHasFreeLines(lock, true);
chunk->freePages().push(page);
+accountedInFreeable += pageSize;
});
-m_freeableMemory += chunkSize;
+m_freeableMemory += accountedInFreeable;
m_scavenger->schedule(0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
