from:"lmoura"

[webkit-changes] [294942] trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

2022-05-27 Thread lmoura

Title: [294942] trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp








Revision 294942
Author lmo...@igalia.com
Date 2022-05-27 10:58:08 -0700 (Fri, 27 May 2022)


Log Message
[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538

Reviewed by Adrian Perez de Castro.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings): Move test of deprecated function to section
disabling deprecation warnings.

Canonical link: https://commits.webkit.org/251052@main

Modified Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp




Diff

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (294941 => 294942)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2022-05-27 17:22:25 UTC (rev 294941)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2022-05-27 17:58:08 UTC (rev 294942)
@@ -77,14 +77,6 @@
 webkit_settings_set_enable_frame_flattening(settings, TRUE);
 g_assert_true(webkit_settings_get_enable_frame_flattening(settings));
 
-// Java is not supported, and always disabled.
-// Make warnings non-fatal for this test to make it pass.
-Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
-g_assert_false(webkit_settings_get_enable_java(settings));
-webkit_settings_set_enable_java(settings, FALSE);
-g_assert_false(webkit_settings_get_enable_java(settings));
-Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
-
 // By default, _javascript_ can open windows automatically is disabled.
 g_assert_false(webkit_settings_get_javascript_can_open_windows_automatically(settings));
 webkit_settings_set_javascript_can_open_windows_automatically(settings, TRUE);
@@ -369,6 +361,14 @@
 g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
 webkit_settings_set_enable_xss_auditor(settings, TRUE);
 g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
+
+// Java is not supported, and always disabled.
+// Make warnings non-fatal for this test to make it pass.
+Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
+g_assert_false(webkit_settings_get_enable_java(settings));
+webkit_settings_set_enable_java(settings, FALSE);
+g_assert_false(webkit_settings_get_enable_java(settings));
+Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
 ALLOW_DEPRECATED_DECLARATIONS_END
 
 g_object_unref(G_OBJECT(settings));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294920] trunk

2022-05-26 Thread lmoura

Title: [294920] trunk








Revision 294920
Author lmo...@igalia.com
Date 2022-05-26 18:40:53 -0700 (Thu, 26 May 2022)


Log Message
[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538

Reviewed by Adrian Perez de Castro and Michael Catanzaro.

250264@main removed the WKPreference entry regarding Java support, which in turn
was dropped long time ago.

* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsSetProperty): Do not call deprecated function.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkit_settings_get_enable_java): Add deprecation warnings.
(webkit_settings_set_enable_java): Add deprecation warnings.
* Source/WebKit/UIProcess/API/gtk/WebKitSettings.h: Mark functions as
deprecated.
* Source/WebKit/UIProcess/API/wpe/WebKitSettings.h: Ditto.
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings): Update for new behavior and remove fatal warning
flag for enable-java block as the warnings are expected.

Canonical link: https://commits.webkit.org/251036@main

Modified Paths

trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp




Diff

Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (294919 => 294920)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2022-05-27 00:58:34 UTC (rev 294919)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2022-05-27 01:40:53 UTC (rev 294920)
@@ -236,7 +236,6 @@
 case PROP_ENABLE_PLUGINS:
 break;
 case PROP_ENABLE_JAVA:
-webkit_settings_set_enable_java(settings, g_value_get_boolean(value));
 break;
 case PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY:
 webkit_settings_set_javascript_can_open_windows_automatically(settings, g_value_get_boolean(value));
@@ -439,7 +438,7 @@
 g_value_set_boolean(value, FALSE);
 break;
 case PROP_ENABLE_JAVA:
-g_value_set_boolean(value, webkit_settings_get_enable_java(settings));
+g_value_set_boolean(value, FALSE);
 break;
 case PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY:
 g_value_set_boolean(value, webkit_settings_get_javascript_can_open_windows_automatically(settings));
@@ -752,6 +751,8 @@
  * WebKitSettings:enable-java:
  *
  * Determines whether or not Java is enabled on the page.
+ *
+ * Deprecated: 2.38
  */
 sObjProperties[PROP_ENABLE_JAVA] =
 g_param_spec_boolean(
@@ -758,7 +759,7 @@
 "enable-java",
 _("Enable Java"),
 _("Whether Java support should be enabled."),
-TRUE,
+FALSE,
 readWriteConstructParamFlags);
 
 /**
@@ -1917,11 +1918,15 @@
  * Get the #WebKitSettings:enable-java property.
  *
  * Returns: %FALSE always.
+ *
+ * Deprecated: 2.38. This function always returns %FALSE.
  */
 gboolean webkit_settings_get_enable_java(WebKitSettings* settings)
 {
 g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
 
+g_warning("webkit_settings_get_enable_java is deprecated and always returns FALSE. Java is no longer supported.");
+
 return FALSE;
 }
 
@@ -1931,10 +1936,15 @@
  * @enabled: Value to be set
  *
  * Set the #WebKitSettings:enable-java property. Deprecated function that does nothing.
+ *
+ * Deprecated: 2.38. This function does nothing.
  */
-void webkit_settings_set_enable_java(WebKitSettings* settings, gboolean)
+void webkit_settings_set_enable_java(WebKitSettings* settings, gboolean enabled)
 {
 g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
+
+if (enabled)
+g_warning("webkit_settings_set_enable_java is deprecated and does nothing. Java is no longer supported.");
 }
 
 /**


Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h (294919 => 294920)

--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h	2022-05-27 00:58:34 UTC (rev 294919)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h	2022-05-27 01:40:53 UTC (rev 294920)
@@ -156,10 +156,10 @@
 webkit_settings_set_enable_plugins (WebKitSettings *settings,
 gbooleanenabled);
 
-WEBKIT_API gboolean
+WEBKIT_DEPRECATED gboolean
 webkit_settings_get_enable_java(WebKitSettings *settings);
 
-WEBKIT_API void
+WEBKIT_DEPRECATED void
 webkit_settings_set_enable_java(WebKitSettings *settings,
 gbooleanenabled);
 


Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h (294919 => 294920)

--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h	2022-05-27 00:58:34 UTC (rev 294919)
+++

[webkit-changes] [294626] trunk/Source/WebKit/Shared

2022-05-23 Thread lmoura

Title: [294626] trunk/Source/WebKit/Shared








Revision 294626
Author lmo...@igalia.com
Date 2022-05-22 23:31:12 -0700 (Sun, 22 May 2022)


Log Message
Ignore SIGPIPE in subprocesses
https://bugs.webkit.org/show_bug.cgi?id=240444

Reviewed by Adrian Perez de Castro.

One common case where ignoring SIGPIPE is desired is to avoid issues
when logging to journald and it crashes. As stated in
https://www.freedesktop.org/software/systemd/man/systemd-journald.service

"In order to react gracefully in this (journald stopped) case it is
recommended that programs logging to standard output/error ignore such
errors."

* Shared/AuxiliaryProcess.cpp: Avoid default platformInitialize on
Unix.
* Shared/unix/AuxiliaryProcessMain.cpp:
(WebKit::AuxiliaryProcess::platformInitialize): Added, ignore SIGPIPE.

Canonical link: https://commits.webkit.org/250852@main

Modified Paths

trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp
trunk/Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp




Diff

Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (294625 => 294626)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-05-23 04:43:10 UTC (rev 294625)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-05-23 06:31:12 UTC (rev 294626)
@@ -219,9 +219,12 @@
 }
 
 #if !PLATFORM(COCOA)
+
+#if !OS(UNIX)
 void AuxiliaryProcess::platformInitialize(const AuxiliaryProcessInitializationParameters&)
 {
 }
+#endif
 
 void AuxiliaryProcess::initializeSandbox(const AuxiliaryProcessInitializationParameters&, SandboxInitializationParameters&)
 {


Modified: trunk/Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp (294625 => 294626)

--- trunk/Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp	2022-05-23 04:43:10 UTC (rev 294625)
+++ trunk/Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp	2022-05-23 06:31:12 UTC (rev 294626)
@@ -28,6 +28,7 @@
 
 #include <_javascript_Core/Options.h>
 #include 
+#include 
 #include 
 #include 
 
@@ -48,4 +49,13 @@
 return true;
 }
 
+void AuxiliaryProcess::platformInitialize(const AuxiliaryProcessInitializationParameters&)
+{
+struct sigaction signalAction;
+memset(, 0, sizeof(signalAction));
+RELEASE_ASSERT(!sigemptyset(_mask));
+signalAction.sa_handler = SIG_IGN;
+RELEASE_ASSERT(!sigaction(SIGPIPE, , nullptr));
+}
+
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294466] trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/ WebEditorClientWPE.cpp

2022-05-18 Thread lmoura

Title: [294466] trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp








Revision 294466
Author lmo...@igalia.com
Date 2022-05-18 21:08:35 -0700 (Wed, 18 May 2022)


Log Message
Unreviewed, fix WPE build 250693@main

* WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp: Add missing inlines.h include.

Canonical link: https://commits.webkit.org/250728@main

Modified Paths

trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp




Diff

Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp (294465 => 294466)

--- trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp	2022-05-19 04:03:09 UTC (rev 294465)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp	2022-05-19 04:08:35 UTC (rev 294466)
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294178] trunk/Tools/buildstream

2022-05-13 Thread lmoura

Title: [294178] trunk/Tools/buildstream








Revision 294178
Author lmo...@igalia.com
Date 2022-05-13 15:11:26 -0700 (Fri, 13 May 2022)


Log Message
[Flatpak SDK] Add Breakpad to SDK
https://bugs.webkit.org/show_bug.cgi?id=240367

Reviewed by Philippe Normand.

To be used to generate minidumps of crashes.

Based on original bst file by Adrian Perez de Castro.

* elements/sdk-platform.bst:
* elements/sdk/breakpad.bst: Added.

Modified Paths

trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/elements/sdk-platform.bst


Added Paths

trunk/Tools/buildstream/elements/sdk/breakpad.bst




Diff

Modified: trunk/Tools/buildstream/ChangeLog (294177 => 294178)

--- trunk/Tools/buildstream/ChangeLog	2022-05-13 22:02:46 UTC (rev 294177)
+++ trunk/Tools/buildstream/ChangeLog	2022-05-13 22:11:26 UTC (rev 294178)
@@ -1,3 +1,17 @@
+2022-05-13  Lauro Moura  
+
+[Flatpak SDK] Add Breakpad to SDK
+https://bugs.webkit.org/show_bug.cgi?id=240367
+
+Reviewed by Philippe Normand.
+
+To be used to generate minidumps of crashes.
+
+Based on original bst file by Adrian Perez de Castro.
+
+* elements/sdk-platform.bst:
+* elements/sdk/breakpad.bst: Added.
+
 2022-05-06  Adrian Perez de Castro  
 
 [Flatpak SDK] Update mold to version 1.2.1


Added: trunk/Tools/buildstream/elements/sdk/breakpad.bst (0 => 294178)

--- trunk/Tools/buildstream/elements/sdk/breakpad.bst	(rev 0)
+++ trunk/Tools/buildstream/elements/sdk/breakpad.bst	2022-05-13 22:11:26 UTC (rev 294178)
@@ -0,0 +1,21 @@
+kind: autotools
+
+build-depends:
+- freedesktop-sdk.bst:public-stacks/buildsystem-autotools.bst
+
+sources:
+- kind: git
+  url: https://chromium.googlesource.com/breakpad/breakpad
+  ref: d8a7c0548c7b30689df9a65e52b7ab9db37ab9e8
+  track: chrome_99
+- kind: git
+  url: https://chromium.googlesource.com/linux-syscall-support
+  ref: e1e7b0ad8ee99a875b272c8e33e308472e897660
+  track: main
+  directory: src/third_party/lss
+
+public:
+  bst:
+integration-commands:
+- |
+  minidump-2-core -h


Modified: trunk/Tools/buildstream/elements/sdk-platform.bst (294177 => 294178)

--- trunk/Tools/buildstream/elements/sdk-platform.bst	2022-05-13 22:02:46 UTC (rev 294177)
+++ trunk/Tools/buildstream/elements/sdk-platform.bst	2022-05-13 22:11:26 UTC (rev 294178)
@@ -10,6 +10,7 @@
 # replaced (patched) elements:
 - sdk/adwaita-icon-theme.bst
 - sdk/apitrace.bst
+- sdk/breakpad.bst
 - sdk/capnp.bst
 - sdk/cargo-c.bst
 - sdk/ccls.bst






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294154] trunk/Source

2022-05-13 Thread lmoura

Title: [294154] trunk/Source








Revision 294154
Author lmo...@igalia.com
Date 2022-05-13 04:30:39 -0700 (Fri, 13 May 2022)


Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=240369


Source/_javascript_Core:

* runtime/DateConversion.cpp:

Source/WebCore:

* Modules/highlight/HighlightRegister.h:
* rendering/TextPainter.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DateConversion.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/highlight/HighlightRegister.h
trunk/Source/WebCore/rendering/TextPainter.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (294153 => 294154)

--- trunk/Source/_javascript_Core/ChangeLog	2022-05-13 09:25:49 UTC (rev 294153)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-05-13 11:30:39 UTC (rev 294154)
@@ -1,3 +1,10 @@
+2022-05-13  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=240369
+
+* runtime/DateConversion.cpp:
+
 2022-05-08  Saam Barati  
 
 Better handle clobbered registers in O0 register allocation


Modified: trunk/Source/_javascript_Core/runtime/DateConversion.cpp (294153 => 294154)

--- trunk/Source/_javascript_Core/runtime/DateConversion.cpp	2022-05-13 09:25:49 UTC (rev 294153)
+++ trunk/Source/_javascript_Core/runtime/DateConversion.cpp	2022-05-13 11:30:39 UTC (rev 294154)
@@ -25,6 +25,7 @@
 #include "config.h"
 #include "DateConversion.h"
 
+#include "JSDateMath.h"
 #include 
 #include 
 #include 


Modified: trunk/Source/WebCore/ChangeLog (294153 => 294154)

--- trunk/Source/WebCore/ChangeLog	2022-05-13 09:25:49 UTC (rev 294153)
+++ trunk/Source/WebCore/ChangeLog	2022-05-13 11:30:39 UTC (rev 294154)
@@ -1,3 +1,11 @@
+2022-05-13  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=240369
+
+* Modules/highlight/HighlightRegister.h:
+* rendering/TextPainter.h:
+
 2022-05-13  Zan Dobersek  
 
 [GStreamer] Properly handle DMABuf-containing GstBuffers with missing DMABuf GstCaps feature


Modified: trunk/Source/WebCore/Modules/highlight/HighlightRegister.h (294153 => 294154)

--- trunk/Source/WebCore/Modules/highlight/HighlightRegister.h	2022-05-13 09:25:49 UTC (rev 294153)
+++ trunk/Source/WebCore/Modules/highlight/HighlightRegister.h	2022-05-13 11:30:39 UTC (rev 294154)
@@ -29,6 +29,7 @@
 #include "HighlightVisibility.h"
 #include 
 #include 
+#include 
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/rendering/TextPainter.h (294153 => 294154)

--- trunk/Source/WebCore/rendering/TextPainter.h	2022-05-13 09:25:49 UTC (rev 294153)
+++ trunk/Source/WebCore/rendering/TextPainter.h	2022-05-13 11:30:39 UTC (rev 294154)
@@ -36,6 +36,7 @@
 class RenderCombineText;
 class ShadowData;
 class TextRun;
+class Text;
 
 struct TextPaintStyle;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292949] trunk/Source/WebCore

2022-04-17 Thread lmoura

Title: [292949] trunk/Source/WebCore








Revision 292949
Author lmo...@igalia.com
Date 2022-04-17 14:01:10 -0700 (Sun, 17 Apr 2022)


Log Message
Unreviewed, non-unified build fixes after 249632@main
https://bugs.webkit.org/show_bug.cgi?id=239436


* workers/DedicatedWorkerThread.cpp:
* workers/WorkerGlobalScope.cpp:
* workers/WorkerScriptLoader.cpp:
* workers/service/ServiceWorkerClientData.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerClientData.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (292948 => 292949)

--- trunk/Source/WebCore/ChangeLog	2022-04-17 13:32:42 UTC (rev 292948)
+++ trunk/Source/WebCore/ChangeLog	2022-04-17 21:01:10 UTC (rev 292949)
@@ -1,3 +1,13 @@
+2022-04-17  Lauro Moura  
+
+Unreviewed, non-unified build fixes after 249632@main
+https://bugs.webkit.org/show_bug.cgi?id=239436
+
+* workers/DedicatedWorkerThread.cpp:
+* workers/WorkerGlobalScope.cpp:
+* workers/WorkerScriptLoader.cpp:
+* workers/service/ServiceWorkerClientData.cpp:
+
 2022-04-17  Alan Bujtas  
 
 RenderDeprecatedFlexibleBox::applyLineClamp should use size_t


Modified: trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp (292948 => 292949)

--- trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp	2022-04-17 13:32:42 UTC (rev 292948)
+++ trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp	2022-04-17 21:01:10 UTC (rev 292949)
@@ -34,6 +34,7 @@
 
 #include "DedicatedWorkerGlobalScope.h"
 #include "SecurityOrigin.h"
+#include "ServiceWorker.h"
 #include "WorkerObjectProxy.h"
 
 namespace WebCore {


Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.cpp (292948 => 292949)

--- trunk/Source/WebCore/workers/WorkerGlobalScope.cpp	2022-04-17 13:32:42 UTC (rev 292948)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.cpp	2022-04-17 21:01:10 UTC (rev 292949)
@@ -48,6 +48,7 @@
 #include "ScriptSourceCode.h"
 #include "SecurityOrigin.h"
 #include "SecurityOriginPolicy.h"
+#include "ServiceWorker.h"
 #include "ServiceWorkerClientData.h"
 #include "ServiceWorkerGlobalScope.h"
 #include "SocketProvider.h"


Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (292948 => 292949)

--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp	2022-04-17 13:32:42 UTC (rev 292948)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp	2022-04-17 21:01:10 UTC (rev 292949)
@@ -28,6 +28,7 @@
 #include "WorkerScriptLoader.h"
 
 #include "ContentSecurityPolicy.h"
+#include "Document.h"
 #include "Exception.h"
 #include "FetchIdioms.h"
 #include "MIMETypeRegistry.h"


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerClientData.cpp (292948 => 292949)

--- trunk/Source/WebCore/workers/service/ServiceWorkerClientData.cpp	2022-04-17 13:32:42 UTC (rev 292948)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerClientData.cpp	2022-04-17 21:01:10 UTC (rev 292949)
@@ -33,6 +33,7 @@
 #include "DocumentLoader.h"
 #include "Frame.h"
 #include "SWClientConnection.h"
+#include "WorkerGlobalScope.h"
 #include 
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292542] trunk/Source/WebCore

2022-04-07 Thread lmoura

Title: [292542] trunk/Source/WebCore








Revision 292542
Author lmo...@igalia.com
Date 2022-04-07 10:13:34 -0700 (Thu, 07 Apr 2022)


Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=238933


* css/CSSToStyleMap.h: Forward declare Quad
* platform/graphics/filters/FilterEffectVector.h: Replace forward with
actual include for Ref.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSToStyleMap.h
trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (292541 => 292542)

--- trunk/Source/WebCore/ChangeLog	2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/ChangeLog	2022-04-07 17:13:34 UTC (rev 292542)
@@ -1,3 +1,12 @@
+2022-04-07  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=238933
+
+* css/CSSToStyleMap.h: Forward declare Quad
+* platform/graphics/filters/FilterEffectVector.h: Replace forward with
+actual include for Ref.
+
 2022-04-07  Tim Nguyen  
 
 Remove redundant invalidateStyleForSubtree() calls


Modified: trunk/Source/WebCore/css/CSSToStyleMap.h (292541 => 292542)

--- trunk/Source/WebCore/css/CSSToStyleMap.h	2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/css/CSSToStyleMap.h	2022-04-07 17:13:34 UTC (rev 292542)
@@ -32,6 +32,7 @@
 class FillLayer;
 class LengthBox;
 class NinePieceImage;
+class Quad;
 class RenderStyle;
 class StyleImage;
 


Modified: trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h (292541 => 292542)

--- trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h	2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h	2022-04-07 17:13:34 UTC (rev 292542)
@@ -25,12 +25,11 @@
 
 #pragma once
 
+#include "FilterEffect.h"
 #include 
 
 namespace WebCore {
 
-class FilterEffect;
-
 using FilterEffectVector = Vector>;
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292494] trunk/Tools

2022-04-06 Thread lmoura

Title: [292494] trunk/Tools








Revision 292494
Author lmo...@igalia.com
Date 2022-04-06 12:40:27 -0700 (Wed, 06 Apr 2022)


Log Message
[Flatpak SDK] Avoid termination if gdbus is not installed after 249303@main
https://bugs.webkit.org/show_bug.cgi?id=238878

Reviewed by Philippe Normand.

Instead of bailing out, just disable a11y bus forwarding. Also hide
some debug messages.

* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_a11y_proxy):
* glib/dependencies/apt: Add libglib2.0-bin

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
trunk/Tools/glib/dependencies/apt




Diff

Modified: trunk/Tools/ChangeLog (292493 => 292494)

--- trunk/Tools/ChangeLog	2022-04-06 19:35:37 UTC (rev 292493)
+++ trunk/Tools/ChangeLog	2022-04-06 19:40:27 UTC (rev 292494)
@@ -1,3 +1,17 @@
+2022-04-06  Lauro Moura  
+
+[Flatpak SDK] Avoid termination if gdbus is not installed after 249303@main
+https://bugs.webkit.org/show_bug.cgi?id=238878
+
+Reviewed by Philippe Normand.
+
+Instead of bailing out, just disable a11y bus forwarding. Also hide
+some debug messages.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.setup_a11y_proxy):
+* glib/dependencies/apt: Add libglib2.0-bin
+
 2022-04-06  Jonathan Bedard  
 
 [git-webkit] Provide https credentialing program


Modified: trunk/Tools/flatpak/flatpakutils.py (292493 => 292494)

--- trunk/Tools/flatpak/flatpakutils.py	2022-04-06 19:35:37 UTC (rev 292493)
+++ trunk/Tools/flatpak/flatpakutils.py	2022-04-06 19:40:27 UTC (rev 292494)
@@ -741,14 +741,14 @@
 try:
 output = subprocess.check_output(("gdbus", "call", "-e", "-d", "org.a11y.Bus", "-o", "/org/a11y/bus", "-m", "org.a11y.Bus.GetAddress"))
 a11y_bus_address = re.findall(br"'([^']+)", output)[0]  # Extract string from output from: ('unix:abstract=f',)
-Console.message("Found a11y address {}".format(a11y_bus_address))
-except (subprocess.CalledProcessError, IndexError) as e:
-Console.message("Failed to get a11y address {}".format(e))
+_log.debug("Found a11y address {}".format(a11y_bus_address))
+except (subprocess.CalledProcessError, IndexError, FileNotFoundError) as e:
+_log.warning("Failed to get a11y address {}".format(e))
 return []
 
 dbus_proxy_path = shutil.which("xdg-dbus-proxy")
 if not dbus_proxy_path:
-Console.message("Failed to find xdg-dbus-proxy")
+_log.warning("Failed to find xdg-dbus-proxy. Can't forward a11y bus.")
 return []
 
 self.socket_dir = tempfile.TemporaryDirectory(prefix="webkit-flatpak-a11y-sockets-")
@@ -759,7 +759,7 @@
 
 atexit.register(lambda: proxy_proc.terminate())
 except (subprocess.CalledProcessError) as e:
-Console.message("Failed to get run xdg-dbus-proxy {}".format(e))
+_log.warning("Failed to run xdg-dbus-proxy {}. Can't forward a11y bus.".format(e))
 return []
 
 return [


Modified: trunk/Tools/glib/dependencies/apt (292493 => 292494)

--- trunk/Tools/glib/dependencies/apt	2022-04-06 19:35:37 UTC (rev 292493)
+++ trunk/Tools/glib/dependencies/apt	2022-04-06 19:40:27 UTC (rev 292494)
@@ -64,6 +64,7 @@
 
 # These are dependencies necessary for building with the Flatpak SDK.
 flatpak
+libglib2.0-bin
 
 # These are dependencies necessary for building the jhbuild.
 git






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292452] trunk/Tools

2022-04-06 Thread lmoura

Title: [292452] trunk/Tools








Revision 292452
Author lmo...@igalia.com
Date 2022-04-06 00:48:33 -0700 (Wed, 06 Apr 2022)


Log Message
[Flatpak SDK][AT-SPI] Use xdg-dbus-proxy to expose the a11y bus
https://bugs.webkit.org/show_bug.cgi?id=238856

Reviewed by Carlos Garcia Campos.

Expose the host at-spi socket with xdg-dbus-proxy to avoid at-spi
bailing out by not being able to connect to the a11y bus.

Also add the exported address to the environement of the tests.

Based on the original patch by Patrick Griffis with minor updates.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_a11y_proxy):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.get_user_runtime_dir): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/gtk.py
trunk/Tools/Scripts/webkitpy/port/wpe.py
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Tools/ChangeLog (292451 => 292452)

--- trunk/Tools/ChangeLog	2022-04-06 07:05:25 UTC (rev 292451)
+++ trunk/Tools/ChangeLog	2022-04-06 07:48:33 UTC (rev 292452)
@@ -1,3 +1,26 @@
+2022-04-06  Lauro Moura  
+
+[Flatpak SDK][AT-SPI] Use xdg-dbus-proxy to expose the a11y bus
+https://bugs.webkit.org/show_bug.cgi?id=238856
+
+Reviewed by Carlos Garcia Campos.
+
+Expose the host at-spi socket with xdg-dbus-proxy to avoid at-spi
+bailing out by not being able to connect to the a11y bus.
+
+Also add the exported address to the environement of the tests.
+
+Based on the original patch by Patrick Griffis with minor updates.
+
+* Scripts/webkitpy/port/gtk.py:
+(GtkPort.setup_environ_for_server):
+* Scripts/webkitpy/port/wpe.py:
+(WPEPort.setup_environ_for_server):
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.setup_a11y_proxy):
+(WebkitFlatpak.run_in_sandbox):
+(WebkitFlatpak.get_user_runtime_dir): Deleted.
+
 2022-04-05  Chris Dumez  
 
 Mark String(const char*) constructor as explicit


Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (292451 => 292452)

--- trunk/Tools/Scripts/webkitpy/port/gtk.py	2022-04-06 07:05:25 UTC (rev 292451)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py	2022-04-06 07:48:33 UTC (rev 292452)
@@ -122,6 +122,7 @@
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
+self._copy_value_from_environ_if_set(environment, 'AT_SPI_BUS_ADDRESS')
 for gst_variable in ('DEBUG', 'DEBUG_DUMP_DOT_DIR', 'DEBUG_FILE', 'DEBUG_NO_COLOR',
  'PLUGIN_SCANNER', 'PLUGIN_PATH', 'PLUGIN_SYSTEM_PATH', 'REGISTRY',
  'PLUGIN_PATH_1_0'):


Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (292451 => 292452)

--- trunk/Tools/Scripts/webkitpy/port/wpe.py	2022-04-06 07:05:25 UTC (rev 292451)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py	2022-04-06 07:48:33 UTC (rev 292452)
@@ -88,6 +88,7 @@
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_JHBUILD')
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
 self._copy_value_from_environ_if_set(environment, 'WEBKIT_DEBUG')
+self._copy_value_from_environ_if_set(environment, 'AT_SPI_BUS_ADDRESS')
 self._copy_value_from_environ_if_set(environment, 'LIBGL_ALWAYS_SOFTWARE')
 self._copy_value_from_environ_if_set(environment, 'PULSE_SERVER')
 self._copy_value_from_environ_if_set(environment, 'PULSE_CLIENTCONFIG')


Modified: trunk/Tools/flatpak/flatpakutils.py (292451 => 292452)

--- trunk/Tools/flatpak/flatpakutils.py	2022-04-06 07:05:25 UTC (rev 292451)
+++ trunk/Tools/flatpak/flatpakutils.py	2022-04-06 07:48:33 UTC (rev 292452)
@@ -16,6 +16,7 @@
 # Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 import argparse
+import atexit
 import logging
 try:
 import configparser
@@ -736,10 +737,39 @@
 def is_build_jsc(self, command):
 return command and "build-jsc" in os.path.basename(command)
 
-@staticmethod
-def get_user_runtime_dir():
-return os.environ.get('XDG_RUNTIME_DIR', os.path.join('/run/user', str(os.getuid(
+def setup_a11y_proxy(self):
+try:
+output = subprocess.check_output(("gdbus", "call", "-e", "-d", "org.a11y.Bus", "-o", "/org/a11y/bus", "-m", "org.a11y.Bus.GetAddress"))
+a11y_bus_address = re.findall(br"'([^']+)", output)[0]  # Extract string from output from: ('unix:abstract=f',)
+Console.message("Found a11y address {}".format(a11y_bus_address))
+except (subprocess.CalledProcessError, IndexError) as e:
+Console.message("Failed to get a11y address {}".format(e))
+

[webkit-changes] [292100] trunk/Source/WebCore

2022-03-30 Thread lmoura

Title: [292100] trunk/Source/WebCore








Revision 292100
Author lmo...@igalia.com
Date 2022-03-30 01:19:53 -0700 (Wed, 30 Mar 2022)


Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=238536


* contentextensions/ContentExtensionError.cpp:
* contentextensions/ContentExtensionError.h:
* css/ContainerQuery.cpp:
* html/HTMLTextFormControlElement.cpp:
* inspector/InspectorFrontendHost.cpp:
* page/Page.cpp:
* page/csp/ContentSecurityPolicyDirectiveNames.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionError.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionError.h
trunk/Source/WebCore/css/ContainerQuery.cpp
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (292099 => 292100)

--- trunk/Source/WebCore/ChangeLog	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/ChangeLog	2022-03-30 08:19:53 UTC (rev 292100)
@@ -1,3 +1,16 @@
+2022-03-30  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=238536
+
+* contentextensions/ContentExtensionError.cpp:
+* contentextensions/ContentExtensionError.h:
+* css/ContainerQuery.cpp:
+* html/HTMLTextFormControlElement.cpp:
+* inspector/InspectorFrontendHost.cpp:
+* page/Page.cpp:
+* page/csp/ContentSecurityPolicyDirectiveNames.cpp:
+
 2022-03-29  Brandon Stewart  
 
 Ensure m_layerRulesBeforeImportRules is properly copied during StyleSheetContents instantiation


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionError.cpp (292099 => 292100)

--- trunk/Source/WebCore/contentextensions/ContentExtensionError.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionError.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -30,6 +30,7 @@
 
 #include 
 #include 
+#include 
 
 namespace WebCore {
 namespace ContentExtensions {


Modified: trunk/Source/WebCore/contentextensions/ContentExtensionError.h (292099 => 292100)

--- trunk/Source/WebCore/contentextensions/ContentExtensionError.h	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionError.h	2022-03-30 08:19:53 UTC (rev 292100)
@@ -29,6 +29,8 @@
 
 #include 
 
+#include 
+
 namespace WebCore {
 namespace ContentExtensions {
 


Modified: trunk/Source/WebCore/css/ContainerQuery.cpp (292099 => 292100)

--- trunk/Source/WebCore/css/ContainerQuery.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/css/ContainerQuery.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -26,6 +26,7 @@
 #include "ContainerQuery.h"
 
 #include "CSSMarkup.h"
+#include "CSSValue.h"
 #include 
 #include 
 


Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (292099 => 292100)

--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -37,6 +37,7 @@
 #include "EventNames.h"
 #include "Frame.h"
 #include "FrameSelection.h"
+#include "GCReachableRef.h"
 #include "HTMLBRElement.h"
 #include "HTMLFormElement.h"
 #include "HTMLInputElement.h"


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (292099 => 292100)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -64,6 +64,7 @@
 #include "UserGestureIndicator.h"
 #include <_javascript_Core/ScriptFunctionCall.h>
 #include 
+#include 
 #include 
 #include 
 #include 


Modified: trunk/Source/WebCore/page/Page.cpp (292099 => 292100)

--- trunk/Source/WebCore/page/Page.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/page/Page.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -64,6 +64,7 @@
 #include "EventNames.h"
 #include "ExtensionStyleSheets.h"
 #include "FocusController.h"
+#include "FontCache.h"
 #include "FrameLoader.h"
 #include "FrameLoaderClient.h"
 #include "FrameSelection.h"


Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.cpp (292099 => 292100)

--- trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.cpp	2022-03-30 07:41:37 UTC (rev 292099)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.cpp	2022-03-30 08:19:53 UTC (rev 292100)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "ContentSecurityPolicyDirectiveNames.h"
 
+#include 
+
 namespace WebCore {
 
 namespace ContentSecurityPolicyDirectiveNames {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [292020] trunk/Source/WebCore

2022-03-28 Thread lmoura

Title: [292020] trunk/Source/WebCore








Revision 292020
Author lmo...@igalia.com
Date 2022-03-28 19:04:25 -0700 (Mon, 28 Mar 2022)


Log Message
Unreviewed, non-unified buildfix after 248938@main
https://bugs.webkit.org/show_bug.cgi?id=238478


* workers/service/server/SWServerToContextConnection.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (292019 => 292020)

--- trunk/Source/WebCore/ChangeLog	2022-03-29 01:20:34 UTC (rev 292019)
+++ trunk/Source/WebCore/ChangeLog	2022-03-29 02:04:25 UTC (rev 292020)
@@ -1,3 +1,10 @@
+2022-03-28  Lauro Moura  
+
+Unreviewed, non-unified buildfix after 248938@main
+https://bugs.webkit.org/show_bug.cgi?id=238478
+
+* workers/service/server/SWServerToContextConnection.h:
+
 2022-03-28  Nikolaos Mouchtaris  
 
 Clamp degenerate calc() values for 


Modified: trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h (292019 => 292020)

--- trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h	2022-03-29 01:20:34 UTC (rev 292019)
+++ trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h	2022-03-29 02:04:25 UTC (rev 292020)
@@ -28,6 +28,7 @@
 #if ENABLE(SERVICE_WORKER)
 
 #include "ExceptionData.h"
+#include "PageIdentifier.h"
 #include "RegistrableDomain.h"
 #include "ScriptExecutionContextIdentifier.h"
 #include "ServiceWorkerClientQueryOptions.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292019] trunk

2022-03-28 Thread lmoura

Title: [292019] trunk








Revision 292019
Author lmo...@igalia.com
Date 2022-03-28 18:20:34 -0700 (Mon, 28 Mar 2022)


Log Message
[AT-SPI] accessibility/native-text-control-attributed-string.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237821

Reviewed by Carlos Garcia Campos.

Tools:

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::attributedStringForRange): Check the
validity of the passed range.

LayoutTests:

* platform/gtk/TestExpectations:
* platform/gtk/accessibility/native-text-control-attributed-string-expected.txt: Added.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp


Added Paths

trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (292018 => 292019)

--- trunk/LayoutTests/ChangeLog	2022-03-29 01:16:31 UTC (rev 292018)
+++ trunk/LayoutTests/ChangeLog	2022-03-29 01:20:34 UTC (rev 292019)
@@ -1,3 +1,14 @@
+2022-03-28  Lauro Moura  
+
+[AT-SPI] accessibility/native-text-control-attributed-string.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=237821
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/accessibility/native-text-control-attributed-string-expected.txt: Added.
+* platform/wpe/TestExpectations:
+
 2022-03-28  Matteo Flores  
 
 [ iPadOS ] 3 svg/filters/* tests are constant image failures


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (292018 => 292019)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-29 01:16:31 UTC (rev 292018)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-29 01:20:34 UTC (rev 292019)
@@ -1864,7 +1864,6 @@
 #
 
 accessibility/dialog-properties.html [ Skip ]
-accessibility/native-text-control-attributed-string.html [ Skip ]
 
 # These tests require platform support.
 media/media-allowed-codecs.html


Added: trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt (0 => 292019)

--- trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt	2022-03-29 01:20:34 UTC (rev 292019)
@@ -0,0 +1,135 @@
+Tests that attributedStringForRange works properly for native text and password fields, including for ranges out of bound.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Attributed string for range (0, 9):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for 'some word':
+Attributed string for range (0, 3):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for 'som':
+Attributed string for range (5, 4):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for 'word':
+Attributed string for range (5, 10):
+Attributed string for range (10, 1):
+Attributed string for range (-1, 1):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for 's':
+
+Attributed string for range (0, 3):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for '•••':
+Attributed string for range (0, 2):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+		bg-color:255,255,255
+		editable:true
+		strikethrough:false
+		style:normal
+		fg-color:0,0,0
+		size:12pt
+		weight:400
+		invisible:false
+		underline:none
+		direction:ltr
+	Range attributes for '••':
+Attributed string for range (1, 2):
+	Default text attributes:
+		indent:0
+		family-name:Liberation Sans
+

[webkit-changes] [291960] trunk/Source

2022-03-28 Thread lmoura

Title: [291960] trunk/Source








Revision 291960
Author lmo...@igalia.com
Date 2022-03-27 23:15:24 -0700 (Sun, 27 Mar 2022)


Log Message
Unreviewed, non-unified buildfix
https://bugs.webkit.org/show_bug.cgi?id=238436


Source/_javascript_Core:

* dfg/DFGStrengthReductionPhase.cpp:

Source/WebCore:

* workers/service/ServiceWorkerWindowClient.cpp:

Source/WebKit:

* WebProcess/Storage/WebSWClientConnection.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (291959 => 291960)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27  Lauro Moura  
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* dfg/DFGStrengthReductionPhase.cpp:
+
 2022-03-26  Yusuke Suzuki  
 
 Use static_assert instead of COMPILE_ASSERT


Modified: trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp (291959 => 291960)

--- trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp	2022-03-28 06:15:24 UTC (rev 291960)
@@ -33,6 +33,7 @@
 #include "DFGClobberize.h"
 #include "DFGGraph.h"
 #include "DFGInsertionSet.h"
+#include "DFGJITCode.h"
 #include "DFGPhase.h"
 #include "MathCommon.h"
 #include "RegExpObject.h"


Modified: trunk/Source/WebCore/ChangeLog (291959 => 291960)

--- trunk/Source/WebCore/ChangeLog	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebCore/ChangeLog	2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27  Lauro Moura  
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* workers/service/ServiceWorkerWindowClient.cpp:
+
 2022-03-27  Matt Woodrow  
 
 Preserve repeat() notation for grid-templates


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp (291959 => 291960)

--- trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp	2022-03-28 06:15:24 UTC (rev 291960)
@@ -32,6 +32,7 @@
 #include "JSServiceWorkerWindowClient.h"
 #include "SWContextManager.h"
 #include "ServiceWorkerClients.h"
+#include "ServiceWorkerGlobalScope.h"
 #include "ServiceWorkerThread.h"
 
 namespace WebCore {


Modified: trunk/Source/WebKit/ChangeLog (291959 => 291960)

--- trunk/Source/WebKit/ChangeLog	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebKit/ChangeLog	2022-03-28 06:15:24 UTC (rev 291960)
@@ -1,3 +1,10 @@
+2022-03-27  Lauro Moura  
+
+Unreviewed, non-unified buildfix
+https://bugs.webkit.org/show_bug.cgi?id=238436
+
+* WebProcess/Storage/WebSWClientConnection.cpp:
+
 2022-03-26  Yusuke Suzuki  
 
 Use static_assert instead of COMPILE_ASSERT


Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp (291959 => 291960)

--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp	2022-03-28 04:37:46 UTC (rev 291959)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp	2022-03-28 06:15:24 UTC (rev 291960)
@@ -35,6 +35,8 @@
 #include "NetworkProcessConnection.h"
 #include "NetworkProcessMessages.h"
 #include "WebCoreArgumentCoders.h"
+#include "WebPage.h"
+#include "WebPageProxyMessages.h"
 #include "WebProcess.h"
 #include "WebProcessPoolMessages.h"
 #include "WebSWOriginTable.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291298] trunk/LayoutTests

2022-03-15 Thread lmoura

Title: [291298] trunk/LayoutTests








Revision 291298
Author lmo...@igalia.com
Date 2022-03-15 09:56:07 -0700 (Tue, 15 Mar 2022)


Log Message
[GLIB] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=237902


* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291297 => 291298)

--- trunk/LayoutTests/ChangeLog	2022-03-15 16:52:02 UTC (rev 291297)
+++ trunk/LayoutTests/ChangeLog	2022-03-15 16:56:07 UTC (rev 291298)
@@ -1,3 +1,12 @@
+2022-03-15  Lauro Moura  
+
+[GLIB] Unreviewed gardening
+https://bugs.webkit.org/show_bug.cgi?id=237902
+
+* platform/glib/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2022-03-15  Matteo Flores  
 
 A combination of scrolling and a content change can leave a fixed layer in the wrong place


Modified: trunk/LayoutTests/platform/glib/TestExpectations (291297 => 291298)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-03-15 16:52:02 UTC (rev 291297)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-03-15 16:56:07 UTC (rev 291298)
@@ -911,6 +911,8 @@
 
 webkit.org/b/237872 webrtc/vp8-then-h264.html [ Crash ]
 
+webkit.org/b/237901 media/media-source/media-source-interruption-with-resume-allowing-play.html [ Slow ]
+
 #
 # End of GStreamer-related bugs
 #
@@ -1096,6 +1098,12 @@
 # Previous expectation: webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Failure Pass ]
 webkit.org/b/212202 fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
 
+# Previous: webkit.org/b/223729 [ Release ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass Failure ]
+# Previous: webkit.org/b/223729 [ Debug ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass ]
+webkit.org/b/212202 css3/scroll-snap/scroll-snap-wheel-event.html [ Skip ]
+
+
+
 # Warning: this test is expected to fail in the global expectations file, but
 # we expect it to Pass because we support RTL scrollbars. When fixed, it should
 # not be removed, but moved to the expected passes section of this file.
@@ -1784,6 +1792,9 @@
 # UNSUPPORTED tests. Things we must skip.
 #
 
+# Tests behavior specific to MediaSessionManagerCocoa
+media/audio-session-category.html [ Skip ]
+
 # This test assumes we cannot play RTSP, but we can.
 media/unsupported-rtsp.html [ WontFix Skip ]
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (291297 => 291298)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-15 16:52:02 UTC (rev 291297)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-15 16:56:07 UTC (rev 291298)
@@ -614,9 +614,6 @@
 webkit.org/b/152620 css3/font-variant-petite-caps-synthesis.html [ ImageOnlyFailure ]
 webkit.org/b/152620 css3/font-variant-small-caps-synthesis.html [ ImageOnlyFailure ]
 
-# monitorWheelEvents doesn't work in this test.
-css3/scroll-snap/scroll-snap-wheel-event.html [ Skip ]
-
 # Requires ENABLE(SAMPLING_PROFILER)
 webkit.org/b/153466 inspector/sampling-profiler [ Skip ]
 
@@ -937,9 +934,6 @@
 # End of Crashing tests
 #
 
-# Tests behavior specific to MediaSessionManagerCocoa
-media/audio-session-category.html [ Skip ]
-
 #
 # 4. FLAKY TESTS
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (291297 => 291298)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2022-03-15 16:52:02 UTC (rev 291297)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2022-03-15 16:56:07 UTC (rev 291298)
@@ -230,10 +230,6 @@
 # We don't yet support EXIF-based resolution
 webkit.org/b/217821 imported/w3c/web-platform-tests/density-size-correction/ [ Skip ]
 
-# Scrolling
-webkit.org/b/223729 [ Release ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass Failure ]
-webkit.org/b/223729 [ Debug ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass ]
-
 # Scrolling coordinator
 webkit.org/b/215508 [ Release ] scrollingcoordinator/overflow-proxy-reattach.html [ Pass Timeout ]
 webkit.org/b/215508 [ Release ] scrollingcoordinator/fixed-node-reattach.html [ Pass Timeout ]
@@ -1265,6 +1261,7 @@
 webkit.org/b/208188 webgl/2.0.0 [ Skip ]
 webkit.org/b/208188 webgl/2.0.y [ Skip ]
 webkit.org/b/208188 webgl/pending/conformance2 [ Skip ]

[webkit-changes] [291294] trunk/Source/WebCore

2022-03-15 Thread lmoura

Title: [291294] trunk/Source/WebCore








Revision 291294
Author lmo...@igalia.com
Date 2022-03-15 09:18:28 -0700 (Tue, 15 Mar 2022)


Log Message
[GStreamer] Unreviewed, tentative clang build fix after 248419@main
https://bugs.webkit.org/show_bug.cgi?id=237897

Adds static_cast to avoid "non-const-_expression_ cannot be narrowed"
error.


* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (291293 => 291294)

--- trunk/Source/WebCore/ChangeLog	2022-03-15 16:13:55 UTC (rev 291293)
+++ trunk/Source/WebCore/ChangeLog	2022-03-15 16:18:28 UTC (rev 291294)
@@ -1,3 +1,14 @@
+2022-03-15  Lauro Moura  
+
+[GStreamer] Unreviewed, tentative clang build fix after 248419@main
+https://bugs.webkit.org/show_bug.cgi?id=237897
+
+Adds static_cast to avoid "non-const-_expression_ cannot be narrowed"
+error.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
+
 2022-03-15  Enrique Ocaña González  
 
 [GStreamer] clarify playback errors with MediaError.message


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (291293 => 291294)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2022-03-15 16:13:55 UTC (rev 291293)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2022-03-15 16:18:28 UTC (rev 291294)
@@ -3117,7 +3117,7 @@
 // and copy over the data for each plane.
 GBMBufferSwapchain::BufferDescription bufferDescription {
 DMABufFormat::create(fourccValue(GST_VIDEO_INFO_FORMAT())),
-GST_VIDEO_INFO_WIDTH(), GST_VIDEO_INFO_HEIGHT(),
+static_castGST_VIDEO_INFO_WIDTH(), static_castGST_VIDEO_INFO_HEIGHT(),
 };
 if (bufferDescription.format.fourcc == DMABufFormat::FourCC::Invalid)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291266] trunk/LayoutTests

2022-03-14 Thread lmoura

Title: [291266] trunk/LayoutTests








Revision 291266
Author lmo...@igalia.com
Date 2022-03-14 21:16:28 -0700 (Mon, 14 Mar 2022)


Log Message
[GLIB] Unreviewed, gardening crash and timeout
https://bugs.webkit.org/show_bug.cgi?id=237873


* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291265 => 291266)

--- trunk/LayoutTests/ChangeLog	2022-03-15 02:28:55 UTC (rev 291265)
+++ trunk/LayoutTests/ChangeLog	2022-03-15 04:16:28 UTC (rev 291266)
@@ -1,3 +1,10 @@
+2022-03-14  Lauro Moura  
+
+[GLIB] Unreviewed, gardening crash and timeout
+https://bugs.webkit.org/show_bug.cgi?id=237873
+
+* platform/glib/TestExpectations:
+
 2022-03-14  Robert Jenner  
 
 [ Mac wk1 ] 8X imported/w3c/web-platform-tests/pointerevents/pointere vent (layout-tests) are flaky text failures (236128)


Modified: trunk/LayoutTests/platform/glib/TestExpectations (291265 => 291266)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-03-15 02:28:55 UTC (rev 291265)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-03-15 04:16:28 UTC (rev 291266)
@@ -909,6 +909,8 @@
 
 webkit.org/b/237256 media/video-src-blob-perf.html [ Timeout Failure ]
 
+webkit.org/b/237872 webrtc/vp8-then-h264.html [ Crash ]
+
 #
 # End of GStreamer-related bugs
 #
@@ -1091,7 +1093,8 @@
 # Scrolling-related bugs
 #
 
-webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Failure Pass ]
+# Previous expectation: webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Failure Pass ]
+webkit.org/b/212202 fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
 
 # Warning: this test is expected to fail in the global expectations file, but
 # we expect it to Pass because we support RTL scrollbars. When fixed, it should






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291143] trunk/Source/WebCore

2022-03-10 Thread lmoura

Title: [291143] trunk/Source/WebCore








Revision 291143
Author lmo...@igalia.com
Date 2022-03-10 19:22:03 -0800 (Thu, 10 Mar 2022)


Log Message
Unreviewed, non-unified build fix after 248294@main
https://bugs.webkit.org/show_bug.cgi?id=237751


* layout/integration/LayoutIntegrationLineLayout.cpp: Add missing
include.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (291142 => 291143)

--- trunk/Source/WebCore/ChangeLog	2022-03-11 02:35:06 UTC (rev 291142)
+++ trunk/Source/WebCore/ChangeLog	2022-03-11 03:22:03 UTC (rev 291143)
@@ -1,3 +1,11 @@
+2022-03-10  Lauro Moura  
+
+Unreviewed, non-unified build fix after 248294@main
+https://bugs.webkit.org/show_bug.cgi?id=237751
+
+* layout/integration/LayoutIntegrationLineLayout.cpp: Add missing
+include.
+
 2022-03-10  Chris Dumez  
 
 Main document is leaking on haaretz.co.il due to lazy image loading


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (291142 => 291143)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-03-11 02:35:06 UTC (rev 291142)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-03-11 03:22:03 UTC (rev 291143)
@@ -54,6 +54,7 @@
 #include "RenderInline.h"
 #include "RenderLineBreak.h"
 #include "RenderListBox.h"
+#include "RenderListItem.h"
 #include "RenderListMarker.h"
 #include "RenderSlider.h"
 #include "RenderTextControlMultiLine.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291113] trunk/Source/WebCore

2022-03-10 Thread lmoura

Title: [291113] trunk/Source/WebCore








Revision 291113
Author lmo...@igalia.com
Date 2022-03-10 08:34:19 -0800 (Thu, 10 Mar 2022)


Log Message
Unreviewed, non-unified build fix after 248260@main
https://bugs.webkit.org/show_bug.cgi?id=237715


* css/ContainerQuery.h: Add missing include.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ContainerQuery.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (291112 => 291113)

--- trunk/Source/WebCore/ChangeLog	2022-03-10 16:31:57 UTC (rev 291112)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 16:34:19 UTC (rev 291113)
@@ -1,3 +1,10 @@
+2022-03-10  Lauro Moura  
+
+Unreviewed, non-unified build fix after 248260@main
+https://bugs.webkit.org/show_bug.cgi?id=237715
+
+* css/ContainerQuery.h: Add missing include.
+
 2022-03-10  Philippe Normand  
 
 REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com


Modified: trunk/Source/WebCore/css/ContainerQuery.h (291112 => 291113)

--- trunk/Source/WebCore/css/ContainerQuery.h	2022-03-10 16:31:57 UTC (rev 291112)
+++ trunk/Source/WebCore/css/ContainerQuery.h	2022-03-10 16:34:19 UTC (rev 291113)
@@ -24,6 +24,7 @@
 
 #pragma once
 
+#include 
 #include 
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291067] trunk/Tools

2022-03-09 Thread lmoura

Title: [291067] trunk/Tools








Revision 291067
Author lmo...@igalia.com
Date 2022-03-09 14:07:51 -0800 (Wed, 09 Mar 2022)


Log Message
[Tools] Add script to query results database
https://bugs.webkit.org/show_bug.cgi?id=233800

Reviewed by Jonathan Bedard.

This commit adds a script to query https://results.webkit.org for the
history of a testcase for a given bot/config. It includes a
`--only-changes` switch to show only revisions when the actual changed
from the previous one (useful to check when a test started failing).

For now it supports only layout-tests and has GTK/WPE bots predefined,
although full configurations (the query string for results.webkit.org)
can be used to access other bots.

* Scripts/webkit-test-results: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/Scripts/webkit-test-results




Diff

Modified: trunk/Tools/ChangeLog (291066 => 291067)

--- trunk/Tools/ChangeLog	2022-03-09 22:05:34 UTC (rev 291066)
+++ trunk/Tools/ChangeLog	2022-03-09 22:07:51 UTC (rev 291067)
@@ -1,5 +1,23 @@
 2022-03-09  Lauro Moura  
 
+[Tools] Add script to query results database
+https://bugs.webkit.org/show_bug.cgi?id=233800
+
+Reviewed by Jonathan Bedard.
+
+This commit adds a script to query https://results.webkit.org for the
+history of a testcase for a given bot/config. It includes a
+`--only-changes` switch to show only revisions when the actual changed
+from the previous one (useful to check when a test started failing).
+
+For now it supports only layout-tests and has GTK/WPE bots predefined,
+although full configurations (the query string for results.webkit.org)
+can be used to access other bots.
+
+* Scripts/webkit-test-results: Added.
+
+2022-03-09  Lauro Moura  
+
 [webkitcorepy] Prefer xdg-open to open in linux
 https://bugs.webkit.org/show_bug.cgi?id=237655
 


Added: trunk/Tools/Scripts/webkit-test-results (0 => 291067)

--- trunk/Tools/Scripts/webkit-test-results	(rev 0)
+++ trunk/Tools/Scripts/webkit-test-results	2022-03-09 22:07:51 UTC (rev 291067)
@@ -0,0 +1,390 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2021 Igalia S.L.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this program; if not, write to the
+# Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+# Boston, MA 02110-1301, USA.
+# pylint: disable=missing-docstring,invalid-name
+
+"""Command-line interface to the Webkit Results Database"""
+
+import argparse
+from datetime import datetime
+import json
+import logging
+import os
+import pathlib
+import sys
+import textwrap
+from urllib.parse import urljoin, urlencode, parse_qs
+from urllib.request import urlopen
+from urllib.error import HTTPError
+
+BASE_URL = "https://results.webkit.org/"
+
+
+def red(msg):
+"""Returns a shell-aware red string"""
+return "\033[91m" + msg + "\033[0m"
+
+
+def green(msg):
+"""Returns a shell-aware green string"""
+return "\033[92m" + msg + "\033[0m"
+
+
+# Roughly ordered from the most desired to the most unwanted.
+OUTCOMES = [
+"PASS",
+"TEXT",
+"IMAGE",
+"SKIP",
+"FAIL",
+"ERROR",
+"TIMEOUT",  # Put timeout as more severe than ERROR as they often are harder to debug
+"CRASH",
+]
+
+
+def is_improvement(baseline, current):
+"""Returns true if the current outcome is more favourable."""
+best_baseline = min(OUTCOMES.index(baseline_token) for baseline_token in baseline.split())
+return best_baseline > OUTCOMES.index(current)
+
+
+def is_regression(baseline, current):
+"""Returns true if the current outcome downgraded the result."""
+worst_baseline = max(OUTCOMES.index(baseline_token) for baseline_token in baseline.split())
+return worst_baseline < OUTCOMES.index(current)
+
+
+def decorate(msg, baseline, current):
+"""Colors the message if the status change represents an improvement or regression."""
+if is_improvement(baseline, current):
+msg = green(msg)
+elif is_regression(baseline, current):
+msg = red(msg)
+return msg
+
+
+class Query:
+"""Wrapper around the most common query parameters for a given request"""
+
+def __init__(self, **kwargs):
+"""Just stores the passed kwargs as parameters to be forwarded to the actual query"""
+self._params = kwargs.copy()
+
+@classmethod
+def

[webkit-changes] [291065] trunk/Tools

2022-03-09 Thread lmoura

Title: [291065] trunk/Tools








Revision 291065
Author lmo...@igalia.com
Date 2022-03-09 13:46:49 -0800 (Wed, 09 Mar 2022)


Log Message
[webkitcorepy] Prefer xdg-open to open in linux
https://bugs.webkit.org/show_bug.cgi?id=237655

Reviewed by Jonathan Bedard.

* Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.open_url):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py




Diff

Modified: trunk/Tools/ChangeLog (291064 => 291065)

--- trunk/Tools/ChangeLog	2022-03-09 21:06:23 UTC (rev 291064)
+++ trunk/Tools/ChangeLog	2022-03-09 21:46:49 UTC (rev 291065)
@@ -1,3 +1,13 @@
+2022-03-09  Lauro Moura  
+
+[webkitcorepy] Prefer xdg-open to open in linux
+https://bugs.webkit.org/show_bug.cgi?id=237655
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
+(Terminal.open_url):
+
 2021-12-07  Zhifei Fang  
 
 [results.webkit.org]Add selection box for results database.


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py (291064 => 291065)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py	2022-03-09 21:06:23 UTC (rev 291064)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py	2022-03-09 21:46:49 UTC (rev 291065)
@@ -131,7 +131,12 @@
 if sys.platform.startswith('win'):
 process = run(['explorer', url])
 else:
-process = run(['open', url])
+# TODO: Use shutil directly when Python 2.7 is removed
+from whichcraft import which
+if sys.platform.startswith('linux') and which('xdg-open'):
+process = run(['xdg-open', url])
+else:
+process = run(['open', url])
 return True if process.returncode == 0 else False
 
 class Text(object):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290876] trunk/Tools

2022-03-06 Thread lmoura

Title: [290876] trunk/Tools








Revision 290876
Author lmo...@igalia.com
Date 2022-03-06 19:52:57 -0800 (Sun, 06 Mar 2022)


Log Message
[Flatpak SDK] Fix key expired treatment with Python3
https://bugs.webkit.org/show_bug.cgi?id=237509

Reviewed by Fujii Hironori.

* flatpak/flatpakutils.py:
(FlatpakObject.flatpak_update):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Tools/ChangeLog (290875 => 290876)

--- trunk/Tools/ChangeLog	2022-03-06 17:39:33 UTC (rev 290875)
+++ trunk/Tools/ChangeLog	2022-03-07 03:52:57 UTC (rev 290876)
@@ -1,3 +1,13 @@
+2022-03-06  Lauro Moura  
+
+[Flatpak SDK] Fix key expired treatment with Python3
+https://bugs.webkit.org/show_bug.cgi?id=237509
+
+Reviewed by Fujii Hironori.
+
+* flatpak/flatpakutils.py:
+(FlatpakObject.flatpak_update):
+
 2022-03-06  Wenson Hsieh  
 
 [iOS] Layer tree can get indefinitely frozen if WKWebView is unparented underneath -[UIWindow dealloc]


Modified: trunk/Tools/flatpak/flatpakutils.py (290875 => 290876)

--- trunk/Tools/flatpak/flatpakutils.py	2022-03-06 17:39:33 UTC (rev 290875)
+++ trunk/Tools/flatpak/flatpakutils.py	2022-03-07 03:52:57 UTC (rev 290876)
@@ -267,7 +267,7 @@
 try:
 self.flatpak("remote-ls", remote, gather_output=True)
 except subprocess.CalledProcessError as error:
-if error.output.lower().find("key expired"):
+if error.output.lower().find(b"key expired"):
 Console.message("WebKit SDK GPG key expired, synchronizing with remote")
 with tempfile.NamedTemporaryFile() as tmpfile:
 fd = urlopen(WEBKIT_SDK_GPG_PUBKEY_URL)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290799] trunk/Tools

2022-03-03 Thread lmoura

Title: [290799] trunk/Tools








Revision 290799
Author lmo...@igalia.com
Date 2022-03-03 16:53:08 -0800 (Thu, 03 Mar 2022)


Log Message
[Python3] Switch a few more glib scripts to Python3
https://bugs.webkit.org/show_bug.cgi?id=237442

Reviewed by Adrian Perez de Castro.

* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
shebang.
(bss_symbols): Decode Popen bytes output.
* gtk/jhbuildrc: Update shebang.
* gtk/ycm_extra_conf.py: Ditto.
* jhbuild/jhbuild-wrapper: Ditto.
(jhbuild_at_expected_revision): Decode Popen bytes output.
* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
* wpe/jhbuildrc: Update shebang.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs
trunk/Tools/gtk/jhbuildrc
trunk/Tools/gtk/ycm_extra_conf.py
trunk/Tools/jhbuild/jhbuild-wrapper
trunk/Tools/jhbuild/jhbuildrc_common.py
trunk/Tools/wpe/jhbuildrc




Diff

Modified: trunk/Tools/ChangeLog (290798 => 290799)

--- trunk/Tools/ChangeLog	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/ChangeLog	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,3 +1,20 @@
+2022-03-03  Lauro Moura  
+
+[Python3] Switch a few more glib scripts to Python3
+https://bugs.webkit.org/show_bug.cgi?id=237442
+
+Reviewed by Adrian Perez de Castro.
+
+* Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
+shebang.
+(bss_symbols): Decode Popen bytes output.
+* gtk/jhbuildrc: Update shebang.
+* gtk/ycm_extra_conf.py: Ditto.
+* jhbuild/jhbuild-wrapper: Ditto.
+(jhbuild_at_expected_revision): Decode Popen bytes output.
+* jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
+* wpe/jhbuildrc: Update shebang.
+
 2022-03-03  Jonathan Bedard  
 
 [webkitcorepy] Disable prompt when saving credentials


Modified: trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs (290798 => 290799)

--- trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/Scripts/check-for-global-bss-symbols-in-webkitgtk-libs	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import re
 import subprocess
@@ -10,7 +10,7 @@
 data = ""
 pattern = re.compile('^[0-9a-f]+ ([a-zA-Z ])[a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ][a-zA-Z ] \.bss\t[0-9a-f]+ +(.*)$')
 for line in data.splitlines():
-m = pattern.match(line)
+m = pattern.match(line.decode('utf-8', 'ignore'))
 if not m:
 continue
 if sfilter is None or sfilter(m.group(1)):


Modified: trunk/Tools/gtk/jhbuildrc (290798 => 290799)

--- trunk/Tools/gtk/jhbuildrc	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/gtk/jhbuildrc	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011-2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or


Modified: trunk/Tools/gtk/ycm_extra_conf.py (290798 => 290799)

--- trunk/Tools/gtk/ycm_extra_conf.py	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/gtk/ycm_extra_conf.py	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2013 Danilo Cesar Lemes de Paula 
 # Copyright (C) 2014 ChangSeok Oh 
 #


Modified: trunk/Tools/jhbuild/jhbuild-wrapper (290798 => 290799)

--- trunk/Tools/jhbuild/jhbuild-wrapper	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/jhbuild/jhbuild-wrapper	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2011 Igalia S.L.
 # Copyright (C) 2012 Gustavo Noronha Silva 
 # Copyright (C) 2012 Intel Corporation
@@ -59,7 +59,7 @@
 if process.returncode != 0:
 raise Exception('failed to find jhbuild revision: %s' % err)
 
-return output.strip() == jhbuild_revision
+return output.strip().decode('utf-8', 'ignore') == jhbuild_revision
 
 
 def update_jhbuild():


Modified: trunk/Tools/jhbuild/jhbuildrc_common.py (290798 => 290799)

--- trunk/Tools/jhbuild/jhbuildrc_common.py	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/jhbuild/jhbuildrc_common.py	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # Copyright (C) 2011 Igalia S.L.
 # Copyright (C) 2012 Intel Corporation
 #


Modified: trunk/Tools/wpe/jhbuildrc (290798 => 290799)

--- trunk/Tools/wpe/jhbuildrc	2022-03-03 23:46:29 UTC (rev 290798)
+++ trunk/Tools/wpe/jhbuildrc	2022-03-04 00:53:08 UTC (rev 290799)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290792] trunk/Tools

2022-03-03 Thread lmoura

Title: [290792] trunk/Tools








Revision 290792
Author lmo...@igalia.com
Date 2022-03-03 13:19:46 -0800 (Thu, 03 Mar 2022)


Log Message
[build.webkit.org] Add GTK queue using clang
https://bugs.webkit.org/show_bug.cgi?id=229637

Reviewed by Michael Catanzaro.

This commit adds a specific queue to build with clang in place of GCC.
It will help cover both toolchains and catch bugs and warnings
that happen to be raised by/to affect only clang.

Initially, it'll be a build-only queue, moving to a complete build and
tester in the future. It'll use clang-12, the version available in the
current SDK used by GTK and WPE.

* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):

Modified Paths

trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/build-webkit-org/config.json (290791 => 290792)

--- trunk/Tools/CISupport/build-webkit-org/config.json	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/CISupport/build-webkit-org/config.json	2022-03-03 21:19:46 UTC (rev 290792)
@@ -113,6 +113,7 @@
 { "name": "gtk-linux-bot-17", "platform": "gtk" },
 { "name": "gtk-linux-bot-18", "platform": "gtk" },
 { "name": "gtk-linux-bot-19", "platform": "gtk" },
+{ "name": "gtk-linux-bot-20", "platform": "gtk" },
 
 { "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
 { "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -484,6 +485,11 @@
   "workernames": ["gtk-linux-bot-19"]
 },
 {
+  "name": "GTK-Linux-64-bit-Release-Clang", "factory": "BuildFactory", "builddir": "gtk-linux-64-release-clang",
+  "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "workernames": ["gtk-linux-bot-20"]
+},
+{
   "name": "WinCairo-64-bit-WKL-Release-Build", "factory": "BuildFactory", "builddir": "wincairo-wkl-release",
   "platform": "wincairo", "configuration": "release", "architectures": ["x86_64"],
   "triggers": ["wincairo-wkl-release-tests", "wincairo-jsc-release-tests"],
@@ -605,6 +611,7 @@
 
 "schedulers": [ { "type": "AnyBranchScheduler", "name": "trunk", "change_filter": "trunk_filter", "treeStableTimer": 45.0,
   "builderNames": ["GTK-Linux-64-bit-Release-Build", "GTK-Linux-64-bit-Debug-Build",
+   "GTK-Linux-64-bit-Release-Clang",
"GTK-Linux-64-bit-Release-Debian-Stable-Build",
"GTK-Linux-64-bit-Release-Ubuntu-LTS-Build",
"WPE-Linux-64-bit-Release-Ubuntu-LTS-Build",


Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (290791 => 290792)

--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py	2022-03-03 21:19:46 UTC (rev 290792)
@@ -978,6 +978,17 @@
 'transfer-to-s3',
 'trigger'
 ],
+'GTK-Linux-64-bit-Release-Clang': [
+'configure-build',
+'configuration',
+'clean-and-update-working-directory',
+'show-identifier',
+'kill-old-processes',
+'delete-WebKitBuild-directory',
+'delete-stale-build-files',
+'jhbuild',
+'compile-webkit'
+],
 'GTK-Linux-64-bit-Release-Tests': [
 'configure-build',
 'configuration',


Modified: trunk/Tools/ChangeLog (290791 => 290792)

--- trunk/Tools/ChangeLog	2022-03-03 21:02:09 UTC (rev 290791)
+++ trunk/Tools/ChangeLog	2022-03-03 21:19:46 UTC (rev 290792)
@@ -1,3 +1,22 @@
+2022-03-03  Lauro Moura  
+
+[build.webkit.org] Add GTK queue using clang
+https://bugs.webkit.org/show_bug.cgi?id=229637
+
+Reviewed by Michael Catanzaro.
+
+This commit adds a specific queue to build with clang in place of GCC.
+It will help cover both toolchains and catch bugs and warnings
+that happen to be raised by/to affect only clang.
+
+Initially, it'll be a build-only queue, moving to a complete build and
+tester in the future. It'll use clang-12, the version available in the
+current SDK used by GTK and WPE.
+
+* CISupport/build-webkit-org/config.json:
+* CISupport/build-webkit-org/factories_unittest.py:
+(TestExpectedBuildSteps):
+
 2022-03-03  Myles C. Maxfield  
 
 [Style] Forbid spaces between type names and protocol names in Objective-C

[webkit-changes] [290767] trunk/Tools

2022-03-02 Thread lmoura

Title: [290767] trunk/Tools








Revision 290767
Author lmo...@igalia.com
Date 2022-03-02 22:23:24 -0800 (Wed, 02 Mar 2022)


Log Message
[Tools] Fix linux_get_crash_log.py error logging with python3
https://bugs.webkit.org/show_bug.cgi?id=237404

Reviewed by Fujii Hironori.

Avoid issues generating error logs after 247736@main defaulted to
python3.

* Scripts/webkitpy/port/linux_get_crash_log.py:
(GDBCrashLogGenerator._get_gdb_output): Encode returncode before
appending to bytes.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py




Diff

Modified: trunk/Tools/ChangeLog (290766 => 290767)

--- trunk/Tools/ChangeLog	2022-03-03 05:08:03 UTC (rev 290766)
+++ trunk/Tools/ChangeLog	2022-03-03 06:23:24 UTC (rev 290767)
@@ -1,3 +1,17 @@
+2022-03-02  Lauro Moura  
+
+[Tools] Fix linux_get_crash_log.py error logging with python3
+https://bugs.webkit.org/show_bug.cgi?id=237404
+
+Reviewed by Fujii Hironori.
+
+Avoid issues generating error logs after 247736@main defaulted to
+python3.
+
+* Scripts/webkitpy/port/linux_get_crash_log.py:
+(GDBCrashLogGenerator._get_gdb_output): Encode returncode before
+appending to bytes.
+
 2022-03-02  Jonathan Bedard  
 
 [webkitcorepy] Add Terminal.open_url


Modified: trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py (290766 => 290767)

--- trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py	2022-03-03 05:08:03 UTC (rev 290766)
+++ trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py	2022-03-03 06:23:24 UTC (rev 290767)
@@ -60,7 +60,7 @@
 stdout, stderr = proc.communicate()
 errors = [stderr_line.strip().decode('utf8', 'ignore') for stderr_line in stderr.splitlines()]
 if proc.returncode != 0:
-stdout = (b'ERROR: The gdb process exited with non-zero return code %s\n\n' % str(proc.returncode)) + stdout
+stdout = (b'ERROR: The gdb process exited with non-zero return code %s\n\n' % str(proc.returncode).encode('utf8', 'ignore')) + stdout
 return (stdout.decode('utf8', 'ignore'), errors)
 
 def _get_tmp_file_name(self, coredumpctl, filename):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290353] trunk/Source/WebCore

2022-02-23 Thread lmoura

Title: [290353] trunk/Source/WebCore








Revision 290353
Author lmo...@igalia.com
Date 2022-02-23 00:04:17 -0800 (Wed, 23 Feb 2022)


Log Message
Unreviewed, non-unified build fix after 247623@main
https://bugs.webkit.org/show_bug.cgi?id=237074


* bindings/js/WebAssemblyCachedScriptSourceProvider.h: Namespace.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290352 => 290353)

--- trunk/Source/WebCore/ChangeLog	2022-02-23 07:35:12 UTC (rev 290352)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 08:04:17 UTC (rev 290353)
@@ -1,3 +1,10 @@
+2022-02-23  Lauro Moura  
+
+Unreviewed, non-unified build fix after 247623@main
+https://bugs.webkit.org/show_bug.cgi?id=237074
+
+* bindings/js/WebAssemblyCachedScriptSourceProvider.h: Namespace.
+
 2022-02-22  Chris Dumez  
 
 http/wpt/push-api/onpush-disabled.html fails


Modified: trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h (290352 => 290353)

--- trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h	2022-02-23 07:35:12 UTC (rev 290352)
+++ trunk/Source/WebCore/bindings/js/WebAssemblyCachedScriptSourceProvider.h	2022-02-23 08:04:17 UTC (rev 290353)
@@ -78,7 +78,7 @@
 }
 
 private:
-WebAssemblyCachedScriptSourceProvider(CachedScript* cachedScript, const SourceOrigin& sourceOrigin, String sourceURL)
+WebAssemblyCachedScriptSourceProvider(CachedScript* cachedScript, const JSC::SourceOrigin& sourceOrigin, String sourceURL)
 : BaseWebAssemblySourceProvider(sourceOrigin, WTFMove(sourceURL))
 , m_cachedScript(cachedScript)
 , m_buffer(nullptr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290238] trunk/Source/WebCore

2022-02-20 Thread lmoura

Title: [290238] trunk/Source/WebCore








Revision 290238
Author lmo...@igalia.com
Date 2022-02-20 19:55:04 -0800 (Sun, 20 Feb 2022)


Log Message
Unreviewed, non-unified build fixes after 247508@main
https://bugs.webkit.org/show_bug.cgi?id=236945


* dom/ImageOverlay.h: Forward declare document.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ImageOverlay.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290237 => 290238)

--- trunk/Source/WebCore/ChangeLog	2022-02-21 00:02:38 UTC (rev 290237)
+++ trunk/Source/WebCore/ChangeLog	2022-02-21 03:55:04 UTC (rev 290238)
@@ -1,3 +1,10 @@
+2022-02-20  Lauro Moura  
+
+Unreviewed, non-unified build fixes after 247508@main
+https://bugs.webkit.org/show_bug.cgi?id=236945
+
+* dom/ImageOverlay.h: Forward declare document.
+
 2022-02-20  Alan Bujtas  
 
 [LFC][IFC] Flip inline block coords for vertical-rl before painting


Modified: trunk/Source/WebCore/dom/ImageOverlay.h (290237 => 290238)

--- trunk/Source/WebCore/dom/ImageOverlay.h	2022-02-21 00:02:38 UTC (rev 290237)
+++ trunk/Source/WebCore/dom/ImageOverlay.h	2022-02-21 03:55:04 UTC (rev 290238)
@@ -31,6 +31,7 @@
 
 namespace WebCore {
 
+class Document;
 class FloatRect;
 class HTMLElement;
 class Node;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290013] trunk/Source/WebCore

2022-02-17 Thread lmoura

Title: [290013] trunk/Source/WebCore








Revision 290013
Author lmo...@igalia.com
Date 2022-02-17 05:36:13 -0800 (Thu, 17 Feb 2022)


Log Message
Unreviewed, non-unified build fix after r290003
https://bugs.webkit.org/show_bug.cgi?id=236774


* animation/FrameRateAligner.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/FrameRateAligner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (290012 => 290013)

--- trunk/Source/WebCore/ChangeLog	2022-02-17 13:32:50 UTC (rev 290012)
+++ trunk/Source/WebCore/ChangeLog	2022-02-17 13:36:13 UTC (rev 290013)
@@ -1,3 +1,10 @@
+2022-02-17  Lauro Moura  
+
+Unreviewed, non-unified build fix after r290003
+https://bugs.webkit.org/show_bug.cgi?id=236774
+
+* animation/FrameRateAligner.h:
+
 2022-02-17  Nikolas Zimmermann  
 
 [LBSE] Apply SVG specific changes to RenderLayer painting


Modified: trunk/Source/WebCore/animation/FrameRateAligner.h (290012 => 290013)

--- trunk/Source/WebCore/animation/FrameRateAligner.h	2022-02-17 13:32:50 UTC (rev 290012)
+++ trunk/Source/WebCore/animation/FrameRateAligner.h	2022-02-17 13:36:13 UTC (rev 290013)
@@ -27,6 +27,7 @@
 
 #include "AnimationFrameRate.h"
 #include "ReducedResolutionSeconds.h"
+#include 
 #include 
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289971] trunk/Source/WebCore

2022-02-16 Thread lmoura

Title: [289971] trunk/Source/WebCore








Revision 289971
Author lmo...@igalia.com
Date 2022-02-16 15:12:45 -0800 (Wed, 16 Feb 2022)


Log Message
Unreviewed, non-unified build fix after r289742
https://bugs.webkit.org/show_bug.cgi?id=236687


* css/ContainerQueryParser.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ContainerQueryParser.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289970 => 289971)

--- trunk/Source/WebCore/ChangeLog	2022-02-16 23:10:54 UTC (rev 289970)
+++ trunk/Source/WebCore/ChangeLog	2022-02-16 23:12:45 UTC (rev 289971)
@@ -1,3 +1,10 @@
+2022-02-16  Lauro Moura  
+
+Unreviewed, non-unified build fix after r289742
+https://bugs.webkit.org/show_bug.cgi?id=236687
+
+* css/ContainerQueryParser.h:
+
 2022-02-16  Adrian Perez de Castro  
 
 [CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc


Modified: trunk/Source/WebCore/css/ContainerQueryParser.h (289970 => 289971)

--- trunk/Source/WebCore/css/ContainerQueryParser.h	2022-02-16 23:10:54 UTC (rev 289970)
+++ trunk/Source/WebCore/css/ContainerQueryParser.h	2022-02-16 23:12:45 UTC (rev 289971)
@@ -24,11 +24,14 @@
 
 #pragma once
 
+#include "CSSParserContext.h"
 #include "CSSParserToken.h"
 #include "ContainerQuery.h"
 
 namespace WebCore {
 
+class CSSParserTokenRange;
+
 class ContainerQueryParser {
 public:
 static std::optional consumeContainerQuery(CSSParserTokenRange&, const CSSParserContext&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289726] trunk/Source

2022-02-13 Thread lmoura

Title: [289726] trunk/Source








Revision 289726
Author lmo...@igalia.com
Date 2022-02-13 22:22:21 -0800 (Sun, 13 Feb 2022)


Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=236577


Source/_javascript_Core:

* heap/StructureAlignedMemoryAllocator.cpp: Add missing include.

Source/WebCore:

* Modules/notifications/NotificationEvent.cpp: Missing include.
* platform/graphics/ContentTypeUtilities.cpp: Namespace function.
(WebCore::contentTypeMeetsContainerAndCodecTypeRequirements):
* workers/service/ServiceWorkerGlobalScope.cpp: Missing include.

Source/WebKit:

* UIProcess/Notifications/ServiceWorkerNotificationHandler.h: Forward
declare.
* UIProcess/WebProcessProxy.cpp: Missing include.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/notifications/NotificationEvent.cpp
trunk/Source/WebCore/platform/graphics/ContentTypeUtilities.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289725 => 289726)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-14 06:22:21 UTC (rev 289726)
@@ -1,3 +1,10 @@
+2022-02-13  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=236577
+
+* heap/StructureAlignedMemoryAllocator.cpp: Add missing include.
+
 2022-02-13  Keith Miller  
 
 Add comment on how StructureMemoryManager grows the free list when there are no free blocks.


Modified: trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp (289725 => 289726)

--- trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp	2022-02-14 06:22:21 UTC (rev 289726)
@@ -28,6 +28,7 @@
 
 #include "JSCConfig.h"
 #include "MarkedBlock.h"
+#include "StructureID.h"
 
 #include 
 


Modified: trunk/Source/WebCore/ChangeLog (289725 => 289726)

--- trunk/Source/WebCore/ChangeLog	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/WebCore/ChangeLog	2022-02-14 06:22:21 UTC (rev 289726)
@@ -1,3 +1,13 @@
+2022-02-13  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=236577
+
+* Modules/notifications/NotificationEvent.cpp: Missing include.
+* platform/graphics/ContentTypeUtilities.cpp: Namespace function.
+(WebCore::contentTypeMeetsContainerAndCodecTypeRequirements):
+* workers/service/ServiceWorkerGlobalScope.cpp: Missing include.
+
 2022-02-13  Andres Gonzalez  
 
 Decouple AXObjectCache handleChildrenChanged and postNotification.


Modified: trunk/Source/WebCore/Modules/notifications/NotificationEvent.cpp (289725 => 289726)

--- trunk/Source/WebCore/Modules/notifications/NotificationEvent.cpp	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/WebCore/Modules/notifications/NotificationEvent.cpp	2022-02-14 06:22:21 UTC (rev 289726)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "NotificationEvent.h"
 
+#include 
+
 #if ENABLE(NOTIFICATION_EVENT)
 
 namespace WebCore {


Modified: trunk/Source/WebCore/platform/graphics/ContentTypeUtilities.cpp (289725 => 289726)

--- trunk/Source/WebCore/platform/graphics/ContentTypeUtilities.cpp	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/WebCore/platform/graphics/ContentTypeUtilities.cpp	2022-02-14 06:22:21 UTC (rev 289726)
@@ -39,8 +39,8 @@
 if (!allowedMediaCodecTypes)
 return true;
 
-return allOf(type.codecs(), [&] (auto& codec) {
-return anyOf(*allowedMediaCodecTypes, [&] (auto& allowedCodec) {
+return WTF::allOf(type.codecs(), [&] (auto& codec) {
+return WTF::anyOf(*allowedMediaCodecTypes, [&] (auto& allowedCodec) {
 return codec.startsWith(allowedCodec);
 });
 });


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp (289725 => 289726)

--- trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2022-02-14 06:22:21 UTC (rev 289726)
@@ -30,6 +30,7 @@
 
 #include "Document.h"
 #include "EventLoop.h"
+#include "EventNames.h"
 #include "ExtendableEvent.h"
 #include "Frame.h"
 #include "FrameLoader.h"


Modified: trunk/Source/WebKit/ChangeLog (289725 => 289726)

--- trunk/Source/WebKit/ChangeLog	2022-02-14 05:22:55 UTC (rev 289725)
+++ trunk/Source/WebKit/ChangeLog	2022-02-14 06:22:21 UTC (rev 289726)
@@ -1,3 +1,12 @@
+2022-02-13  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+

[webkit-changes] [289715] trunk/Source/WebCore

2022-02-13 Thread lmoura

Title: [289715] trunk/Source/WebCore








Revision 289715
Author lmo...@igalia.com
Date 2022-02-13 09:53:35 -0800 (Sun, 13 Feb 2022)


Log Message
Unreviewed, gtk buildfix after r289706
https://bugs.webkit.org/show_bug.cgi?id=236563


* Headers.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (289714 => 289715)

--- trunk/Source/WebCore/ChangeLog	2022-02-13 17:41:35 UTC (rev 289714)
+++ trunk/Source/WebCore/ChangeLog	2022-02-13 17:53:35 UTC (rev 289715)
@@ -1,3 +1,10 @@
+2022-02-13  Lauro Moura  
+
+Unreviewed, gtk buildfix after r289706
+https://bugs.webkit.org/show_bug.cgi?id=236563
+
+* Headers.cmake:
+
 2022-02-13  Alan Bujtas  
 
 [LFC][IFC] Take writing direction into account when setting up the root geometry


Modified: trunk/Source/WebCore/Headers.cmake (289714 => 289715)

--- trunk/Source/WebCore/Headers.cmake	2022-02-13 17:41:35 UTC (rev 289714)
+++ trunk/Source/WebCore/Headers.cmake	2022-02-13 17:53:35 UTC (rev 289715)
@@ -553,6 +553,7 @@
 css/CSSValueList.h
 css/CSSVariableData.h
 css/CSSVariableReferenceValue.h
+css/ContainerQuery.h
 css/Counter.h
 css/DeprecatedCSSOMCounter.h
 css/DeprecatedCSSOMPrimitiveValue.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289517] trunk/Source/WebCore

2022-02-09 Thread lmoura

Title: [289517] trunk/Source/WebCore








Revision 289517
Author lmo...@igalia.com
Date 2022-02-09 20:11:48 -0800 (Wed, 09 Feb 2022)


Log Message
Unreviewed, non-unified build fix after r289474
https://bugs.webkit.org/show_bug.cgi?id=236425


* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289516 => 289517)

--- trunk/Source/WebCore/ChangeLog	2022-02-10 01:50:38 UTC (rev 289516)
+++ trunk/Source/WebCore/ChangeLog	2022-02-10 04:11:48 UTC (rev 289517)
@@ -1,3 +1,10 @@
+2022-02-09  Lauro Moura  
+
+Unreviewed, non-unified build fix after r289474
+https://bugs.webkit.org/show_bug.cgi?id=236425
+
+* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
+
 2022-02-09  Eric Carlson  
 
 WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp (289516 => 289517)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp	2022-02-10 01:50:38 UTC (rev 289516)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp	2022-02-10 04:11:48 UTC (rev 289517)
@@ -30,6 +30,8 @@
 #include "IDBResultData.h"
 #include "Logging.h"
 #include "UniqueIDBDatabase.h"
+#include "UniqueIDBDatabaseConnection.h"
+#include "UniqueIDBDatabaseManager.h"
 
 namespace WebCore {
 namespace IDBServer {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289469] trunk/Source

2022-02-09 Thread lmoura

Title: [289469] trunk/Source








Revision 289469
Author lmo...@igalia.com
Date 2022-02-09 07:13:24 -0800 (Wed, 09 Feb 2022)


Log Message
Non-unified build fixes after r289247
https://bugs.webkit.org/show_bug.cgi?id=236343

Reviewed by Fujii Hironori.

Source/_javascript_Core:

* runtime/JSRemoteFunction.h: Drive-by fix, add missing include.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp: Drive-by fix. Missing
include.
* layout/formattingContexts/inline/display/InlineDisplayLine.h:
Drive-by fix. Missing include.
* workers/shared/SharedWorkerObjectConnection.cpp:
SharedWorkerScriptLoader only forward-declares WorkerScriptLoader.
* workers/shared/SharedWorkerScriptLoader.h: Missing CompletionHandler
include.
* workers/shared/context/SharedWorkerContextManager.cpp:
SharedWorkerThreadProxy only forward-declares SharedWorkerThread

Source/WebKit:

* NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp: Moved
SharedWorkerKey include to .h file, as it declares a HashMap of it and
it has custom HashTraits that must be visible.
* NetworkProcess/SharedWorker/WebSharedWorkerServer.h: Ditto.
* NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp: Add
missing includes.
* NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h: Add
missing includes and forward declarations.
* NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
Add missing include with proper coder/decoder support.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h
trunk/Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp
trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h
trunk/Source/WebCore/workers/shared/context/SharedWorkerContextManager.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h
trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289468 => 289469)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-09 14:56:58 UTC (rev 289468)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-09 15:13:24 UTC (rev 289469)
@@ -1,3 +1,12 @@
+2022-02-09  Lauro Moura  
+
+Non-unified build fixes after r289247
+https://bugs.webkit.org/show_bug.cgi?id=236343
+
+Reviewed by Fujii Hironori.
+
+* runtime/JSRemoteFunction.h: Drive-by fix, add missing include.
+
 2022-02-08  Yusuke Suzuki  
 
 [JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure


Modified: trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h (289468 => 289469)

--- trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h	2022-02-09 14:56:58 UTC (rev 289468)
+++ trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h	2022-02-09 15:13:24 UTC (rev 289469)
@@ -27,6 +27,7 @@
 #pragma once
 
 #include "AuxiliaryBarrier.h"
+#include "JSFunction.h"
 #include "JSObject.h"
 #include 
 


Modified: trunk/Source/WebCore/ChangeLog (289468 => 289469)

--- trunk/Source/WebCore/ChangeLog	2022-02-09 14:56:58 UTC (rev 289468)
+++ trunk/Source/WebCore/ChangeLog	2022-02-09 15:13:24 UTC (rev 289469)
@@ -1,3 +1,21 @@
+2022-02-09  Lauro Moura  
+
+Non-unified build fixes after r289247
+https://bugs.webkit.org/show_bug.cgi?id=236343
+
+Reviewed by Fujii Hironori.
+
+* accessibility/AccessibilityNodeObject.cpp: Drive-by fix. Missing
+include.
+* layout/formattingContexts/inline/display/InlineDisplayLine.h:
+Drive-by fix. Missing include.
+* workers/shared/SharedWorkerObjectConnection.cpp:
+SharedWorkerScriptLoader only forward-declares WorkerScriptLoader.
+* workers/shared/SharedWorkerScriptLoader.h: Missing CompletionHandler
+include.
+* workers/shared/context/SharedWorkerContextManager.cpp:
+SharedWorkerThreadProxy only forward-declares SharedWorkerThread
+
 2022-02-09  Antti Koivisto  
 
 [CSS Container Queries] Implement inline-size containment


Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (289468 => 289469)

--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2022-02-09 14:56:58 UTC (rev 289468)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2022-02-09 15:13:24 UTC (rev 289469)
@@ -59,6 +59,7 @@
 #include "HTMLOptionElement.h"
 #include "HTMLParserIdioms.h"
 #include "HTMLSelectElement.h"
+#include "HTMLSummaryElement.h"
 #include "HTMLTextAreaElement.h"
 #include

[webkit-changes] [289252] trunk/Source/WebCore

2022-02-07 Thread lmoura

Title: [289252] trunk/Source/WebCore








Revision 289252
Author lmo...@igalia.com
Date 2022-02-07 17:13:41 -0800 (Mon, 07 Feb 2022)


Log Message
Unreviewed, non-unified build fixes after 246907@main
https://bugs.webkit.org/show_bug.cgi?id=236256


* style/ContainerQueryEvaluator.cpp:
* style/ContainerQueryEvaluator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp
trunk/Source/WebCore/style/ContainerQueryEvaluator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289251 => 289252)

--- trunk/Source/WebCore/ChangeLog	2022-02-08 01:13:36 UTC (rev 289251)
+++ trunk/Source/WebCore/ChangeLog	2022-02-08 01:13:41 UTC (rev 289252)
@@ -1,3 +1,11 @@
+2022-02-07  Lauro Moura  
+
+Unreviewed, non-unified build fixes after 246907@main
+https://bugs.webkit.org/show_bug.cgi?id=236256
+
+* style/ContainerQueryEvaluator.cpp:
+* style/ContainerQueryEvaluator.h:
+
 2022-02-07  Tyler Wilcock  
 
 AX: Move node-dependent role computation to AccessibilityNodeObject from AccessibilityRenderObject


Modified: trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp (289251 => 289252)

--- trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp	2022-02-08 01:13:36 UTC (rev 289251)
+++ trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp	2022-02-08 01:13:41 UTC (rev 289252)
@@ -28,8 +28,10 @@
 #include "CSSToLengthConversionData.h"
 #include "Document.h"
 #include "MediaFeatureNames.h"
+#include "MediaList.h"
 #include "MediaQuery.h"
 #include "RenderView.h"
+#include "StyleRule.h"
 
 namespace WebCore::Style {
 


Modified: trunk/Source/WebCore/style/ContainerQueryEvaluator.h (289251 => 289252)

--- trunk/Source/WebCore/style/ContainerQueryEvaluator.h	2022-02-08 01:13:36 UTC (rev 289251)
+++ trunk/Source/WebCore/style/ContainerQueryEvaluator.h	2022-02-08 01:13:41 UTC (rev 289252)
@@ -24,8 +24,11 @@
 
 #pragma once
 
+#include 
+
 namespace WebCore {
 
+struct ContainerQuery;
 class Element;
 
 namespace Style {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289199] trunk/Source

2022-02-06 Thread lmoura

Title: [289199] trunk/Source








Revision 289199
Author lmo...@igalia.com
Date 2022-02-06 21:29:35 -0800 (Sun, 06 Feb 2022)


Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=236216

Source/_javascript_Core:

This missing include was causing non-unified builds to fail linking
libWPEWebkit with undefined JSC::Structure::get(...) after dropping
gold as the default linker in 246713@main.


* wasm/js/JSWebAssemblyException.cpp:

Source/WebCore:


* layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:
* workers/shared/context/SharedWorkerThread.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyException.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h
trunk/Source/WebCore/workers/shared/context/SharedWorkerThread.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289198 => 289199)

--- trunk/Source/_javascript_Core/ChangeLog	2022-02-07 05:02:39 UTC (rev 289198)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-07 05:29:35 UTC (rev 289199)
@@ -1,3 +1,14 @@
+2022-02-06  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=236216
+
+This missing include was causing non-unified builds to fail linking
+libWPEWebkit with undefined JSC::Structure::get(...) after dropping
+gold as the default linker in 246713@main.
+
+* wasm/js/JSWebAssemblyException.cpp:
+
 2022-02-06  Yusuke Suzuki  
 
 [Wasm] ref.null check should be done first in B3 call_ref


Modified: trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyException.cpp (289198 => 289199)

--- trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyException.cpp	2022-02-07 05:02:39 UTC (rev 289198)
+++ trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyException.cpp	2022-02-07 05:29:35 UTC (rev 289199)
@@ -33,6 +33,7 @@
 #include "JSCJSValueInlines.h"
 #include "JSCellInlines.h"
 #include "JSWebAssemblyHelpers.h"
+#include "StructureInlines.h"
 
 namespace JSC {
 


Modified: trunk/Source/WebCore/ChangeLog (289198 => 289199)

--- trunk/Source/WebCore/ChangeLog	2022-02-07 05:02:39 UTC (rev 289198)
+++ trunk/Source/WebCore/ChangeLog	2022-02-07 05:29:35 UTC (rev 289199)
@@ -1,3 +1,11 @@
+2022-02-06  Lauro Moura  
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=236216
+
+* layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:
+* workers/shared/context/SharedWorkerThread.cpp:
+
 2022-02-06  Alan Bujtas  
 
 Address a post-commit review comment after r289171.


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h (289198 => 289199)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h	2022-02-07 05:02:39 UTC (rev 289198)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h	2022-02-07 05:29:35 UTC (rev 289199)
@@ -27,6 +27,7 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 
+#include "InlineFormattingContext.h"
 #include "InlineFormattingGeometry.h"
 
 namespace WebCore {


Modified: trunk/Source/WebCore/workers/shared/context/SharedWorkerThread.cpp (289198 => 289199)

--- trunk/Source/WebCore/workers/shared/context/SharedWorkerThread.cpp	2022-02-07 05:02:39 UTC (rev 289198)
+++ trunk/Source/WebCore/workers/shared/context/SharedWorkerThread.cpp	2022-02-07 05:29:35 UTC (rev 289199)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "SharedWorkerThread.h"
 
+#include "Logging.h"
 #include "SharedWorkerGlobalScope.h"
 #include "WorkerObjectProxy.h"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289016] trunk/Source/WebCore

2022-02-02 Thread lmoura

Title: [289016] trunk/Source/WebCore








Revision 289016
Author lmo...@igalia.com
Date 2022-02-02 16:48:32 -0800 (Wed, 02 Feb 2022)


Log Message
[GLIB] Unreviewed debug buildfix after r288872
https://bugs.webkit.org/show_bug.cgi?id=236036

The actual issue was the roleNames array provided to SortedArrayMap
constructor wasn't fully ordered, making isSortedConstExpr to fail,
generating the call to WTFReport..., which is non-constexpr and thus
the compile failure.

This commit revert the previous fix from r288990 and fix the ordering of
roleNames.


* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::localizedRoleName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289015 => 289016)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 00:34:50 UTC (rev 289015)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 00:48:32 UTC (rev 289016)
@@ -1,3 +1,19 @@
+2022-02-02  Lauro Moura  
+
+[GLIB] Unreviewed debug buildfix after r288872
+https://bugs.webkit.org/show_bug.cgi?id=236036
+
+The actual issue was the roleNames array provided to SortedArrayMap
+constructor wasn't fully ordered, making isSortedConstExpr to fail,
+generating the call to WTFReport..., which is non-constexpr and thus
+the compile failure.
+
+This commit revert the previous fix from r288990 and fix the ordering of
+roleNames.
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::localizedRoleName):
+
 2022-02-02  Antoine Quint  
 
 Keyframe resolution methods should use reference instead of pointer parameters


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (289015 => 289016)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-03 00:34:50 UTC (rev 289015)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-03 00:48:32 UTC (rev 289016)
@@ -602,8 +602,8 @@
 { AccessibilityRole::Definition, { "definition", N_("definition") } },
 { AccessibilityRole::Deletion, { "content deletion", N_("content deletion") } },
 { AccessibilityRole::DescriptionList, { "description list", N_("description list") } },
+{ AccessibilityRole::DescriptionListDetail, { "description value", N_("description value") } },
 { AccessibilityRole::DescriptionListTerm, { "description term", N_("description term") } },
-{ AccessibilityRole::DescriptionListDetail, { "description value", N_("description value") } },
 { AccessibilityRole::Directory, { "directory pane", N_("directory pane") } },
 { AccessibilityRole::Div, { "section", N_("section") } },
 { AccessibilityRole::Document, { "document frame", N_("document frame") } },
@@ -704,7 +704,7 @@
 
 const char* AccessibilityAtspi::localizedRoleName(AccessibilityRole role)
 {
-static const SortedArrayMap roleNamesMap { roleNames };
+static constexpr SortedArrayMap roleNamesMap { roleNames };
 if (auto entry = roleNamesMap.tryGet(role))
 return entry->localizedName;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288990] trunk/Source/WebCore

2022-02-02 Thread lmoura

Title: [288990] trunk/Source/WebCore








Revision 288990
Author lmo...@igalia.com
Date 2022-02-02 12:54:14 -0800 (Wed, 02 Feb 2022)


Log Message
[GLIB] Unreviewed debug buildfix after r288872
https://bugs.webkit.org/show_bug.cgi?id=236036


* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::localizedRoleName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (288989 => 288990)

--- trunk/Source/WebCore/ChangeLog	2022-02-02 20:51:51 UTC (rev 288989)
+++ trunk/Source/WebCore/ChangeLog	2022-02-02 20:54:14 UTC (rev 288990)
@@ -1,3 +1,11 @@
+2022-02-02  Lauro Moura  
+
+[GLIB] Unreviewed debug buildfix after r288872
+https://bugs.webkit.org/show_bug.cgi?id=236036
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::localizedRoleName):
+
 2022-02-02  Asumu Takikawa  
 
 Unmute link errors for ES module scripts


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (288989 => 288990)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-02 20:51:51 UTC (rev 288989)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-02 20:54:14 UTC (rev 288990)
@@ -704,7 +704,7 @@
 
 const char* AccessibilityAtspi::localizedRoleName(AccessibilityRole role)
 {
-static constexpr SortedArrayMap roleNamesMap { roleNames };
+static const SortedArrayMap roleNamesMap { roleNames };
 if (auto entry = roleNamesMap.tryGet(role))
 return entry->localizedName;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288941] trunk/Source/WebCore

2022-02-01 Thread lmoura

Title: [288941] trunk/Source/WebCore








Revision 288941
Author lmo...@igalia.com
Date 2022-02-01 21:08:27 -0800 (Tue, 01 Feb 2022)


Log Message
Unreviewed, non-unified buildfix after latest accessibility commits
https://bugs.webkit.org/show_bug.cgi?id=235999


* accessibility/atspi/AccessibilityAtspi.cpp:
* accessibility/atspi/AccessibilityObjectAtspi.cpp:
* accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp:
* accessibility/atspi/AccessibilityObjectTableAtspi.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTableAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (288940 => 288941)

--- trunk/Source/WebCore/ChangeLog	2022-02-02 05:00:13 UTC (rev 288940)
+++ trunk/Source/WebCore/ChangeLog	2022-02-02 05:08:27 UTC (rev 288941)
@@ -1,3 +1,13 @@
+2022-02-01  Lauro Moura  
+
+Unreviewed, non-unified buildfix after latest accessibility commits
+https://bugs.webkit.org/show_bug.cgi?id=235999
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+* accessibility/atspi/AccessibilityObjectAtspi.cpp:
+* accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp:
+* accessibility/atspi/AccessibilityObjectTableAtspi.cpp:
+
 2022-02-01  Commit Queue  
 
 Unreviewed, reverting r288914.


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (288940 => 288941)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-02 05:00:13 UTC (rev 288940)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-02 05:08:27 UTC (rev 288941)
@@ -22,8 +22,10 @@
 #include "AccessibilityAtspi.h"
 
 #if ENABLE(ACCESSIBILITY) && USE(ATSPI)
+#include "AXObjectCache.h"
 #include "AccessibilityAtspiEnums.h"
 #include "AccessibilityAtspiInterfaces.h"
+#include "AccessibilityObjectAtspi.h"
 #include "AccessibilityRootAtspi.h"
 #include 
 #include 


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp (288940 => 288941)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp	2022-02-02 05:00:13 UTC (rev 288940)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp	2022-02-02 05:08:27 UTC (rev 288941)
@@ -21,7 +21,9 @@
 #include "AccessibilityObjectAtspi.h"
 
 #if ENABLE(ACCESSIBILITY) && USE(ATSPI)
+#include "AXObjectCache.h"
 #include "AccessibilityAtspiEnums.h"
+#include "AccessibilityAtspiInterfaces.h"
 #include "AccessibilityObjectInterface.h"
 #include "AccessibilityRootAtspi.h"
 #include "AccessibilityTableCell.h"


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp (288940 => 288941)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp	2022-02-02 05:00:13 UTC (rev 288940)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp	2022-02-02 05:08:27 UTC (rev 288941)
@@ -23,6 +23,7 @@
 #if ENABLE(ACCESSIBILITY) && USE(ATSPI)
 
 #include "AccessibilityAtspi.h"
+#include "AccessibilityObject.h" // NOLINT: check-webkit-style has problems with files that do not have primary header
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTableAtspi.cpp (288940 => 288941)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTableAtspi.cpp	2022-02-02 05:00:13 UTC (rev 288940)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTableAtspi.cpp	2022-02-02 05:08:27 UTC (rev 288941)
@@ -23,6 +23,7 @@
 #if ENABLE(ACCESSIBILITY) && USE(ATSPI)
 
 #include "AccessibilityAtspi.h"
+#include "AccessibilityObject.h" // NOLINT: check-webkit-style has problems with files that do not have primary header
 #include "HTMLTableCaptionElement.h"
 #include "HTMLTableElement.h"
 #include "RenderElement.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288550] trunk/Source/WebCore

2022-01-25 Thread lmoura

Title: [288550] trunk/Source/WebCore








Revision 288550
Author lmo...@igalia.com
Date 2022-01-25 08:20:28 -0800 (Tue, 25 Jan 2022)


Log Message
Non-unified buildfix after r288546/246378@main
https://bugs.webkit.org/show_bug.cgi?id=235590

Unreviewed build fix.


* page/Navigator.cpp: Add missing include.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Navigator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (288549 => 288550)

--- trunk/Source/WebCore/ChangeLog	2022-01-25 15:59:17 UTC (rev 288549)
+++ trunk/Source/WebCore/ChangeLog	2022-01-25 16:20:28 UTC (rev 288550)
@@ -1,3 +1,12 @@
+2022-01-25  Lauro Moura  
+
+Non-unified buildfix after r288546/246378@main
+https://bugs.webkit.org/show_bug.cgi?id=235590
+
+Unreviewed build fix.
+
+* page/Navigator.cpp: Add missing include.
+
 2022-01-25  Commit Queue  
 
 Unreviewed, reverting r282374.


Modified: trunk/Source/WebCore/page/Navigator.cpp (288549 => 288550)

--- trunk/Source/WebCore/page/Navigator.cpp	2022-01-25 15:59:17 UTC (rev 288549)
+++ trunk/Source/WebCore/page/Navigator.cpp	2022-01-25 16:20:28 UTC (rev 288550)
@@ -41,6 +41,7 @@
 #include "Page.h"
 #include "PlatformStrategies.h"
 #include "PluginData.h"
+#include "Quirks.h"
 #include "ResourceLoadObserver.h"
 #include "RuntimeEnabledFeatures.h"
 #include "ScriptController.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288361] trunk

2022-01-21 Thread lmoura

Title: [288361] trunk








Revision 288361
Author lmo...@igalia.com
Date 2022-01-21 05:11:33 -0800 (Fri, 21 Jan 2022)


Log Message
[CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build
https://bugs.webkit.org/show_bug.cgi?id=226088

Reviewed by Adrian Perez de Castro.

Source/_javascript_Core:

* wasm/js/JSWebAssemblyModule.h: Add missing header

Source/WebCore:

Covered by existing tests.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::isUnderTest const): Defining  it.
* inspector/InspectorController.h: Export isUnderTest().
* loader/SubresourceIntegrity.h: Add missing header.
* platform/gtk/ValidationBubbleGtk.cpp: Ditto.
* svg/graphics/filters/SVGFEImage.h: Ditto.
* testing/Internals.cpp:
(WebCore::Internals::mediaSessionState): Cast new enum to the WebCore
one.
* testing/Internals.h: Redefine MediaSessionState as a new enum
instead of aliasing to avoid redefinitions of
convertEnumerationToString in non-unified builds.
* workers/WorkerConsoleClient.h:

Tools:

* WebKitTestRunner/CMakeLists.txt: Pull WebCore as dependency for
WTR/WTRInjectedBundle

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/loader/SubresourceIntegrity.h
trunk/Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/workers/WorkerConsoleClient.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/CMakeLists.txt




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (288360 => 288361)

--- trunk/Source/_javascript_Core/ChangeLog	2022-01-21 11:05:10 UTC (rev 288360)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-01-21 13:11:33 UTC (rev 288361)
@@ -1,3 +1,12 @@
+2022-01-21  Lauro Moura  
+
+[CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build
+https://bugs.webkit.org/show_bug.cgi?id=226088
+
+Reviewed by Adrian Perez de Castro.
+
+* wasm/js/JSWebAssemblyModule.h: Add missing header
+
 2022-01-20  Pablo Saavedra  
 
 Non-unified build fails due to forward declaration in _javascript_Core/jit/JITStubRoutine.h


Modified: trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.h (288360 => 288361)

--- trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.h	2022-01-21 11:05:10 UTC (rev 288360)
+++ trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.h	2022-01-21 13:11:33 UTC (rev 288361)
@@ -27,6 +27,7 @@
 
 #if ENABLE(WEBASSEMBLY)
 
+#include "CallLinkInfo.h"
 #include "JSDestructibleObject.h"
 #include "JSObject.h"
 #include "WasmMemoryMode.h"


Modified: trunk/Source/WebCore/ChangeLog (288360 => 288361)

--- trunk/Source/WebCore/ChangeLog	2022-01-21 11:05:10 UTC (rev 288360)
+++ trunk/Source/WebCore/ChangeLog	2022-01-21 13:11:33 UTC (rev 288361)
@@ -1,3 +1,26 @@
+2022-01-21  Lauro Moura  
+
+[CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build
+https://bugs.webkit.org/show_bug.cgi?id=226088
+
+Reviewed by Adrian Perez de Castro.
+
+Covered by existing tests.
+
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::isUnderTest const): Defining  it.
+* inspector/InspectorController.h: Export isUnderTest().
+* loader/SubresourceIntegrity.h: Add missing header.
+* platform/gtk/ValidationBubbleGtk.cpp: Ditto.
+* svg/graphics/filters/SVGFEImage.h: Ditto.
+* testing/Internals.cpp:
+(WebCore::Internals::mediaSessionState): Cast new enum to the WebCore
+one.
+* testing/Internals.h: Redefine MediaSessionState as a new enum
+instead of aliasing to avoid redefinitions of
+convertEnumerationToString in non-unified builds.
+* workers/WorkerConsoleClient.h:
+
 2022-01-21  Martin Robinson  
 
 element.scrollIntoView() sometimes doesn't scroll


Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (288360 => 288361)

--- trunk/Source/WebCore/inspector/InspectorController.cpp	2022-01-21 11:05:10 UTC (rev 288360)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp	2022-01-21 13:11:33 UTC (rev 288361)
@@ -359,6 +359,11 @@
 m_overlay->getHighlight(highlight, coordinateSystem);
 }
 
+bool InspectorController::isUnderTest() const
+{
+return m_isUnderTest;
+}
+
 unsigned InspectorController::gridOverlayCount() const
 {
 return m_overlay->gridOverlayCount();


Modified: trunk/Source/WebCore/inspector/InspectorController.h (288360 => 288361)

--- trunk/Source/WebCore/inspector/InspectorController.h	2022-01-21 11:05:10 UTC (rev 288360)
+++ trunk/Source/WebCore/inspector/InspectorController.h	2022-01-21 13:11:33 UTC (rev 288361)
@@ -102,7 +102,7 @@

[webkit-changes] [288349] trunk/Tools

2022-01-20 Thread lmoura

Title: [288349] trunk/Tools








Revision 288349
Author lmo...@igalia.com
Date 2022-01-20 19:58:21 -0800 (Thu, 20 Jan 2022)


Log Message
[GTK] API test /webkit/WebKitWebsiteData/cache is flaky
https://bugs.webkit.org/show_bug.cgi?id=188113

Unreviewed test gardening.

It has been passing consistently for a long time. Sometimes failing
consistently too, but when there are regressions.


* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (288348 => 288349)

--- trunk/Tools/ChangeLog	2022-01-21 03:51:53 UTC (rev 288348)
+++ trunk/Tools/ChangeLog	2022-01-21 03:58:21 UTC (rev 288349)
@@ -1,3 +1,15 @@
+2022-01-20  Lauro Moura  
+
+[GTK] API test /webkit/WebKitWebsiteData/cache is flaky
+https://bugs.webkit.org/show_bug.cgi?id=188113
+
+Unreviewed test gardening.
+
+It has been passing consistently for a long time. Sometimes failing
+consistently too, but when there are regressions.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2022-01-20  Devin Rousso  
 
 Add SPI for passing around and getting details about `WebCore::CSSStyleDeclaration` in injected bundle code


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (288348 => 288349)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2022-01-21 03:51:53 UTC (rev 288348)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2022-01-21 03:58:21 UTC (rev 288349)
@@ -101,9 +101,6 @@
 },
 "TestWebsiteData": {
 "subtests": {
-"/webkit/WebKitWebsiteData/cache": {
-"expected": {"all": {"status": ["PASS", "FAIL"], "bug": "webkit.org/b/188113"}}
-},
 "/webkit/WebKitWebsiteData/appcache": {
 "expected": {"all": {"status": ["PASS", "FAIL"], "bug": "webkit.org/b/188117"}}
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288085] trunk/Source

2022-01-16 Thread lmoura

Title: [288085] trunk/Source








Revision 288085
Author lmo...@igalia.com
Date 2022-01-16 21:18:06 -0800 (Sun, 16 Jan 2022)


Log Message
Fix C++20 build warnings with GCC
https://bugs.webkit.org/show_bug.cgi?id=235023

Reviewed by Alex Christensen.

Mostly related to deprecating operations between enums of different
types and not capturing this by default in lambdas.

Source/_javascript_Core:

* assembler/X86Assembler.h: Casting enums to same type.
(JSC::X86Assembler::cmovcc):
(JSC::X86Assembler::jccRel32):
(JSC::X86Assembler::setccOpcode):
* b3/B3CheckSpecial.cpp: Capture this in lambda.
(JSC::B3::CheckSpecial::generate):
* b3/B3Type.cpp: Replace is_pod_v is is_standard_layout_v and
is_trivial_v
* bytecode/AccessCase.cpp: Capture this in lambda.
(JSC::AccessCase::generateImpl):
* bytecode/CallLinkInfo.cpp: Ditto.
(JSC::OptimizingCallLinkInfo::emitDirectFastPath):
(JSC::OptimizingCallLinkInfo::emitDirectTailCallFastPath):
(JSC::OptimizingCallLinkInfo::initializeDirectCall):
* dfg/DFGSpeculativeJIT.cpp: Ditto.
* dfg/DFGSpeculativeJIT64.cpp: Ditto.
(JSC::DFG::SpeculativeJIT::compile):
* jit/ICStats.h: Cast enums to same type.
(JSC::ICEvent::hash const):
* jit/JITArithmetic.cpp: Capture this in lambda.
(JSC::JIT::emitMathICSlow):
* jit/JITSizeStatistics.cpp: Ditto.
(JSC::JITSizeStatistics::markEnd):
* runtime/VM.cpp: Ditto.
(JSC::VM::deleteAllLinkedCode):
(JSC::VM::deleteAllCode):
(JSC::VM::shrinkFootprintWhenIdle):
* wasm/WasmAirIRGenerator.cpp: Ditto.
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addTableGet):
(JSC::Wasm::AirIRGenerator::addTableSet):
(JSC::Wasm::AirIRGenerator::addTableInit):
(JSC::Wasm::AirIRGenerator::addTableFill):
(JSC::Wasm::AirIRGenerator::addTableCopy):
(JSC::Wasm::AirIRGenerator::addMemoryFill):
(JSC::Wasm::AirIRGenerator::addMemoryCopy):
(JSC::Wasm::AirIRGenerator::addMemoryInit):
(JSC::Wasm::AirIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::AirIRGenerator::emitAtomicLoadOp):
(JSC::Wasm::AirIRGenerator::emitAtomicStoreOp):
(JSC::Wasm::AirIRGenerator::emitAtomicBinaryRMWOp):
(JSC::Wasm::AirIRGenerator::emitAtomicCompareExchange):
(JSC::Wasm::AirIRGenerator::atomicWait):
(JSC::Wasm::AirIRGenerator::atomicNotify):
(JSC::Wasm::AirIRGenerator::emitEntryTierUpCheck):
(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::AirIRGenerator::addCallIndirect):
(JSC::Wasm::AirIRGenerator::addCallRef):
(JSC::Wasm::AirIRGenerator::emitChecksForModOrDiv):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
* wasm/WasmB3IRGenerator.cpp: Ditto.
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addTableGet):
(JSC::Wasm::B3IRGenerator::addTableSet):
(JSC::Wasm::B3IRGenerator::addTableInit):
(JSC::Wasm::B3IRGenerator::addTableFill):
(JSC::Wasm::B3IRGenerator::addTableCopy):
(JSC::Wasm::B3IRGenerator::emitIndirectCall):
(JSC::Wasm::B3IRGenerator::addMemoryFill):
(JSC::Wasm::B3IRGenerator::addMemoryInit):
(JSC::Wasm::B3IRGenerator::addMemoryCopy):
(JSC::Wasm::B3IRGenerator::fixupPointerPlusOffsetForAtomicOps):
(JSC::Wasm::B3IRGenerator::atomicWait):
(JSC::Wasm::B3IRGenerator::atomicNotify):
(JSC::Wasm::B3IRGenerator::emitEntryTierUpCheck):
(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
(JSC::Wasm::B3IRGenerator::addCallRef):
(JSC::Wasm::B3IRGenerator::emitChecksForModOrDiv):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
(JSC::Wasm::B3IRGenerator::addOp):
* yarr/YarrJIT.cpp: Ditto.

Source/WebCore:

* dom/ViewportArguments.h: Replace enum with constexpr ints as they're
compared to doubles in various places through ViewportArguments.cpp.
* dom/WheelEvent.h: Replace single-valued enum with constexpr
variable.
* platform/animation/Animation.h: Ditto.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
Ditto.
(WebCore::CoordinatedGraphicsLayer::shouldDirectlyCompositeImage const):
* rendering/style/RenderStyleConstants.h: Merge two enums that are
used only in the context of being combined to form a third enum.

Source/WebKit:

* WebProcess/Inspector/WebInspector.cpp: Capture this in lambdas.
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::startElementSelection):
(WebKit::WebInspector::stopElementSelection):

Source/WTF:

* wtf/AutomaticThread.cpp: Capture this in lambda.
(WTF::AutomaticThread::start):

Modified Paths

[webkit-changes] [287723] trunk/Tools

2022-01-06 Thread lmoura

Title: [287723] trunk/Tools








Revision 287723
Author lmo...@igalia.com
Date 2022-01-06 15:42:36 -0800 (Thu, 06 Jan 2022)


Log Message
[GLIB] Make API test initialize localstorage to ensure the database file is created
https://bugs.webkit.org/show_bug.cgi?id=234891

Reviewed by Michael Catanzaro.

Changes needed after 245553@main/r287418 changed the localstorage
behavior to avoid creating an empty database file when reading empty
databases.

* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp




Diff

Modified: trunk/Tools/ChangeLog (287722 => 287723)

--- trunk/Tools/ChangeLog	2022-01-06 23:42:24 UTC (rev 287722)
+++ trunk/Tools/ChangeLog	2022-01-06 23:42:36 UTC (rev 287723)
@@ -1,3 +1,17 @@
+2022-01-06  Lauro Moura  
+
+[GLIB] Make API test initialize localstorage to ensure the database file is created
+https://bugs.webkit.org/show_bug.cgi?id=234891
+
+Reviewed by Michael Catanzaro.
+
+Changes needed after 245553@main/r287418 changed the localstorage
+behavior to avoid creating an empty database file when reading empty
+databases.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+(testWebsiteDataConfiguration):
+
 2022-01-04  Jonathan Bedard  
 
 [EWS] Support pull-requests in ConfigureBuild


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (287722 => 287723)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2022-01-06 23:42:24 UTC (rev 287722)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2022-01-06 23:42:36 UTC (rev 287723)
@@ -168,11 +168,12 @@
 
 test->loadURI(kServer->getURIForPath("/empty").data());
 test->waitUntilLoadFinished();
-test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
+test->runJavaScriptAndWaitUntilFinished("window.localStorage.myproperty = 42;", nullptr);
 GUniquePtr localStorageDirectory(g_build_filename(Test::dataDirectory(), "local-storage", nullptr));
 g_assert_cmpstr(localStorageDirectory.get(), ==, webkit_website_data_manager_get_local_storage_directory(test->m_manager));
 test->assertFileIsCreated(localStorageDirectory.get());
 g_assert_true(g_file_test(localStorageDirectory.get(), G_FILE_TEST_IS_DIR));
+test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
 
 test->loadURI(kServer->getURIForPath("/empty").data());
 test->waitUntilLoadFinished();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287264] trunk/Tools

2021-12-20 Thread lmoura

Title: [287264] trunk/Tools








Revision 287264
Author lmo...@igalia.com
Date 2021-12-20 09:45:19 -0800 (Mon, 20 Dec 2021)


Log Message
[webkitcorepy] Require cryptography while on Linux with Py3
https://bugs.webkit.org/show_bug.cgi?id=234499

Reviewed by Philippe Normand.

cryptography is required by secretstorage.util. When not installed,
the import fails and the keyring backend initialization fails silently,
just removing the SecretService keyring backend from the list of
viable backends. This can happen when running the scripts from a fresh
virtualenv, for example.

* Scripts/libraries/webkitcorepy/setup.py:
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py




Diff

Modified: trunk/Tools/ChangeLog (287263 => 287264)

--- trunk/Tools/ChangeLog	2021-12-20 16:56:35 UTC (rev 287263)
+++ trunk/Tools/ChangeLog	2021-12-20 17:45:19 UTC (rev 287264)
@@ -1,3 +1,19 @@
+2021-12-20  Lauro Moura  
+
+[webkitcorepy] Require cryptography while on Linux with Py3
+https://bugs.webkit.org/show_bug.cgi?id=234499
+
+Reviewed by Philippe Normand.
+
+cryptography is required by secretstorage.util. When not installed,
+the import fails and the keyring backend initialization fails silently,
+just removing the SecretService keyring backend from the list of
+viable backends. This can happen when running the scripts from a fresh
+virtualenv, for example.
+
+* Scripts/libraries/webkitcorepy/setup.py:
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
+
 2021-12-20  Tim Nguyen  
 
 Fix Tools/Scripts/webkitpy/w3c/test_importer.py


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/setup.py (287263 => 287264)

--- trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-12-20 16:56:35 UTC (rev 287263)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-12-20 17:45:19 UTC (rev 287264)
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitcorepy',
-version='0.12.3',
+version='0.12.4',
 description='Library containing various Python support classes and functions.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (287263 => 287264)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-12-20 16:56:35 UTC (rev 287263)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-12-20 17:45:19 UTC (rev 287264)
@@ -44,7 +44,7 @@
 from webkitcorepy.editor import Editor
 from webkitcorepy.file_lock import FileLock
 
-version = Version(0, 12, 3)
+version = Version(0, 12, 4)
 
 from webkitcorepy.autoinstall import Package, AutoInstall
 if sys.version_info > (3, 0):
@@ -76,6 +76,8 @@
 if sys.version_info >= (3, 6):
 if sys.platform == 'linux':
 AutoInstall.register(Package('jeepney', Version(0, 7, 1)))
+AutoInstall.register(Package('cffi', Version(1, 15, 0)))
+AutoInstall.register(Package('cryptography', Version(36, 0, 1), wheel=True, implicit_deps=['cffi']))
 AutoInstall.register(Package('secretstorage', Version(3, 3, 1)))
 AutoInstall.register(Package('keyring', Version(23, 2, 1)))
 else:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [287254] trunk/Tools

2021-12-20 Thread lmoura

Title: [287254] trunk/Tools








Revision 287254
Author lmo...@igalia.com
Date 2021-12-20 01:20:53 -0800 (Mon, 20 Dec 2021)


Log Message
REGRESSION(r286936) [GLIB] WebsiteData configuration API test is failing with non-created localstorage dir
https://bugs.webkit.org/show_bug.cgi?id=234497

Reviewed by Adrian Perez de Castro.

* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration): Ensure localStorage is created before
trying to query it.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp




Diff

Modified: trunk/Tools/ChangeLog (287253 => 287254)

--- trunk/Tools/ChangeLog	2021-12-20 05:03:26 UTC (rev 287253)
+++ trunk/Tools/ChangeLog	2021-12-20 09:20:53 UTC (rev 287254)
@@ -1,3 +1,14 @@
+2021-12-20  Lauro Moura  
+
+REGRESSION(r286936) [GLIB] WebsiteData configuration API test is failing with non-created localstorage dir
+https://bugs.webkit.org/show_bug.cgi?id=234497
+
+Reviewed by Adrian Perez de Castro.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+(testWebsiteDataConfiguration): Ensure localStorage is created before
+trying to query it.
+
 2021-12-18  Alex Christensen  
 
 [Monterey] TestWebKitAPI.PrivateClickMeasurement.Daemon* tests timing out: Failed to connect to mach service org.webkit.pcmtestdaemon.service


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (287253 => 287254)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2021-12-20 05:03:26 UTC (rev 287253)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2021-12-20 09:20:53 UTC (rev 287254)
@@ -166,8 +166,12 @@
 g_assert_null(webkit_website_data_manager_get_base_data_directory(test->m_manager));
 g_assert_null(webkit_website_data_manager_get_base_cache_directory(test->m_manager));
 
+test->loadURI(kServer->getURIForPath("/empty").data());
+test->waitUntilLoadFinished();
+test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
 GUniquePtr localStorageDirectory(g_build_filename(Test::dataDirectory(), "local-storage", nullptr));
 g_assert_cmpstr(localStorageDirectory.get(), ==, webkit_website_data_manager_get_local_storage_directory(test->m_manager));
+test->assertFileIsCreated(localStorageDirectory.get());
 g_assert_true(g_file_test(localStorageDirectory.get(), G_FILE_TEST_IS_DIR));
 
 test->loadURI(kServer->getURIForPath("/empty").data());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286914] trunk/Source

2021-12-11 Thread lmoura

Title: [286914] trunk/Source








Revision 286914
Author lmo...@igalia.com
Date 2021-12-11 10:17:29 -0800 (Sat, 11 Dec 2021)


Log Message
Non-unified build fixes, mid mid December 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=234191

Unreviewed build fix.

A few more fixes already a couple of days after the last fix.

Full build still failing due to the issue discussed on bug226088.

All changes are inclusion of missing headers.


Source/WebCore:

* html/shadow/DateTimeEditElement.cpp:
* platform/graphics/displaylists/DisplayListRecorder.cpp:
* workers/WorkerDebuggerProxy.h:
* workers/shared/SharedWorkerManager.cpp:
* workers/shared/SharedWorkerProxy.cpp:
* workers/shared/SharedWorkerScriptLoader.cpp:
* workers/shared/SharedWorkerScriptLoader.h:
* workers/shared/SharedWorkerThread.cpp:

Source/WebKit:

* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDListElement.cpp:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDirectoryElement.cpp:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMenuElement.cpp:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPreElement.cpp:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
trunk/Source/WebCore/workers/WorkerDebuggerProxy.h
trunk/Source/WebCore/workers/shared/SharedWorkerManager.cpp
trunk/Source/WebCore/workers/shared/SharedWorkerProxy.cpp
trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp
trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h
trunk/Source/WebCore/workers/shared/SharedWorkerThread.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDListElement.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDirectoryElement.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMenuElement.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPreElement.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (286913 => 286914)

--- trunk/Source/WebCore/ChangeLog	2021-12-11 16:59:05 UTC (rev 286913)
+++ trunk/Source/WebCore/ChangeLog	2021-12-11 18:17:29 UTC (rev 286914)
@@ -1,3 +1,25 @@
+2021-12-11  Lauro Moura  
+
+Non-unified build fixes, mid mid December 2021 edition
+https://bugs.webkit.org/show_bug.cgi?id=234191
+
+Unreviewed build fix.
+
+A few more fixes already a couple of days after the last fix.
+
+Full build still failing due to the issue discussed on bug226088.
+
+All changes are inclusion of missing headers.
+
+* html/shadow/DateTimeEditElement.cpp:
+* platform/graphics/displaylists/DisplayListRecorder.cpp:
+* workers/WorkerDebuggerProxy.h:
+* workers/shared/SharedWorkerManager.cpp:
+* workers/shared/SharedWorkerProxy.cpp:
+* workers/shared/SharedWorkerScriptLoader.cpp:
+* workers/shared/SharedWorkerScriptLoader.h:
+* workers/shared/SharedWorkerThread.cpp:
+
 2021-12-11  Mark Lam  
 
 Automatically forbid JS execution when we throw a TerminationException.


Modified: trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp (286913 => 286914)

--- trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp	2021-12-11 16:59:05 UTC (rev 286913)
+++ trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp	2021-12-11 18:17:29 UTC (rev 286914)
@@ -34,6 +34,8 @@
 #include "DateTimeFieldsState.h"
 #include "DateTimeFormat.h"
 #include "DateTimeSymbolicFieldElement.h"
+#include "Document.h"
+#include "Event.h"
 #include "HTMLNames.h"
 #include "PlatformLocale.h"
 #include "ShadowPseudoIds.h"


Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (286913 => 286914)

--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp	2021-12-11 16:59:05 UTC (rev 286913)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp	2021-12-11 18:17:29 UTC (rev 286914)
@@ -29,6 +29,7 @@
 #include "DisplayList.h"
 #include "DisplayListDrawingContext.h"
 #include "DisplayListItems.h"
+#include "Filter.h"
 #include "GraphicsContext.h"
 #include "ImageBuffer.h"
 #include "Logging.h"


Modified: trunk/Source/WebCore/workers/WorkerDebuggerProxy.h (286913 => 286914)

--- trunk/Source/WebCore/workers/WorkerDebuggerProxy.h	2021-12-11 16:59:05 UTC (rev 286913)
+++ trunk/Source/WebCore/workers/WorkerDebuggerProxy.h	2021-12-11 18:17:29 UTC (rev 286914)
@@ -30,6 +30,8 @@
 
 #pragma once
 
+#include 
+
 namespace WebCore {
 
 class WorkerDebuggerProxy {


Modified:

[webkit-changes] [286817] trunk/Tools

2021-12-09 Thread lmoura

Title: [286817] trunk/Tools








Revision 286817
Author lmo...@igalia.com
Date 2021-12-09 16:30:40 -0800 (Thu, 09 Dec 2021)


Log Message
[webkitpy] Make check-webkit-style check WebDriverTests/TestExpectations.json
https://bugs.webkit.org/show_bug.cgi?id=213453

Reviewed by Adrian Perez de Castro.

While the WebDriver tests are imported and mostly ignored by
check-webkit-style, the script must check TestExpectations.json
to avoid commiting invalid json data and breaking the bots.

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherSkipTest._assert_should_skip_without_warning): Pass
a valid error handler so the JSONChecker can be instantiated.
(CheckerDispatcherSkipTest.test_should_skip_without_warning__false):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checker.py
trunk/Tools/Scripts/webkitpy/style/checker_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (286816 => 286817)

--- trunk/Tools/ChangeLog	2021-12-10 00:25:12 UTC (rev 286816)
+++ trunk/Tools/ChangeLog	2021-12-10 00:30:40 UTC (rev 286817)
@@ -1,3 +1,20 @@
+2021-12-09  Lauro Moura  
+
+[webkitpy] Make check-webkit-style check WebDriverTests/TestExpectations.json
+https://bugs.webkit.org/show_bug.cgi?id=213453
+
+Reviewed by Adrian Perez de Castro.
+
+While the WebDriver tests are imported and mostly ignored by
+check-webkit-style, the script must check TestExpectations.json
+to avoid commiting invalid json data and breaking the bots.
+
+* Scripts/webkitpy/style/checker.py:
+* Scripts/webkitpy/style/checker_unittest.py:
+(CheckerDispatcherSkipTest._assert_should_skip_without_warning): Pass
+a valid error handler so the JSONChecker can be instantiated.
+(CheckerDispatcherSkipTest.test_should_skip_without_warning__false):
+
 2021-12-09  Alex Christensen  
 
 Prepare for transition to C++20


Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (286816 => 286817)

--- trunk/Tools/Scripts/webkitpy/style/checker.py	2021-12-10 00:25:12 UTC (rev 286816)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py	2021-12-10 00:30:40 UTC (rev 286817)
@@ -368,6 +368,7 @@
 
 _NEVER_SKIPPED_FILES = _NEVER_SKIPPED_JS_FILES + [
 'TestExpectations',
+'TestExpectations.json',
 '.py'
 ]
 


Modified: trunk/Tools/Scripts/webkitpy/style/checker_unittest.py (286816 => 286817)

--- trunk/Tools/Scripts/webkitpy/style/checker_unittest.py	2021-12-10 00:25:12 UTC (rev 286816)
+++ trunk/Tools/Scripts/webkitpy/style/checker_unittest.py	2021-12-10 00:30:40 UTC (rev 286817)
@@ -319,7 +319,7 @@
 expected):
 # Check the file type before asserting the return value.
 checker = self._dispatcher.dispatch(file_path=path,
-handle_style_error=None,
+handle_style_error=DefaultStyleErrorHandler('', None, None, []),
 min_confidence=3,
 commit_queue=False)
 message = 'while checking: %s' % path
@@ -348,6 +348,8 @@
 paths = ['foo.txt',
  os.path.join('LayoutTests', 'ChangeLog'),
  os.path.join('LayoutTests', 'foo.py'),
+ os.path.join('WebDriverTests', 'ChangeLog'),
+ os.path.join('WebDriverTests', 'TestExpectations.json'),
 ]
 
 for path in paths:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286798] trunk

2021-12-09 Thread lmoura

Title: [286798] trunk








Revision 286798
Author lmo...@igalia.com
Date 2021-12-09 12:35:32 -0800 (Thu, 09 Dec 2021)


Log Message
Adds Lauro Moura's GitHub username to constributors.json

Unreviewed.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (286797 => 286798)

--- trunk/ChangeLog	2021-12-09 20:35:12 UTC (rev 286797)
+++ trunk/ChangeLog	2021-12-09 20:35:32 UTC (rev 286798)
@@ -1,3 +1,11 @@
+2021-12-09  Lauro Moura  
+
+Adds Lauro Moura's GitHub username to constributors.json
+
+Unreviewed.
+
+* metadata/contributors.json:
+
 2021-11-30  Tyler Wilcock  
 
 Move tyle...@apple.com to first entry in "emails" key


Modified: trunk/metadata/contributors.json (286797 => 286798)

--- trunk/metadata/contributors.json	2021-12-09 20:35:12 UTC (rev 286797)
+++ trunk/metadata/contributors.json	2021-12-09 20:35:32 UTC (rev 286798)
@@ -4246,6 +4246,7 @@
  "lmo...@igalia.com",
  "lauro.n...@openbossa.org"
   ],
+  "github" : "lauromoura",
   "name" : "Lauro Moura",
   "nicks" : [
  "lmoura"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286797] trunk/Tools

2021-12-09 Thread lmoura

Title: [286797] trunk/Tools








Revision 286797
Author lmo...@igalia.com
Date 2021-12-09 12:35:12 -0800 (Thu, 09 Dec 2021)


Log Message
[WebXR][WPE] Build fails without openxr installed
https://bugs.webkit.org/show_bug.cgi?id=220250

Reviewed by Adrian Perez de Castro.

Based on original patch by Yury Semikhatsky. Rebased and installed
only for WPE, as GTK's module set does not declare openxr.

* wpe/dependencies/apt: Install libxcb-glx0-dev

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/dependencies/apt




Diff

Modified: trunk/Tools/ChangeLog (286796 => 286797)

--- trunk/Tools/ChangeLog	2021-12-09 20:25:11 UTC (rev 286796)
+++ trunk/Tools/ChangeLog	2021-12-09 20:35:12 UTC (rev 286797)
@@ -1,3 +1,15 @@
+2021-12-09  Lauro Moura  
+
+[WebXR][WPE] Build fails without openxr installed
+https://bugs.webkit.org/show_bug.cgi?id=220250
+
+Reviewed by Adrian Perez de Castro.
+
+Based on original patch by Yury Semikhatsky. Rebased and installed
+only for WPE, as GTK's module set does not declare openxr.
+
+* wpe/dependencies/apt: Install libxcb-glx0-dev
+
 2021-12-09  Ryan Haddad  
 
 Bring up another iOS GPU Processes tester


Modified: trunk/Tools/wpe/dependencies/apt (286796 => 286797)

--- trunk/Tools/wpe/dependencies/apt	2021-12-09 20:25:11 UTC (rev 286796)
+++ trunk/Tools/wpe/dependencies/apt	2021-12-09 20:35:12 UTC (rev 286797)
@@ -32,6 +32,7 @@
 libtheora-dev
 libvorbis-dev
 libvpx-dev
+libxcb-glx0-dev
 libxcb-xkb-dev
 libxkbcommon-dev
 libxrandr-dev






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286653] trunk/Source/WebCore

2021-12-08 Thread lmoura

Title: [286653] trunk/Source/WebCore








Revision 286653
Author lmo...@igalia.com
Date 2021-12-08 07:31:39 -0800 (Wed, 08 Dec 2021)


Log Message
REGRESSION(r286603) [GTK][WPE] WebGL broken after the ANGLE update.
https://bugs.webkit.org/show_bug.cgi?id=233965

Reviewed by Adrian Perez de Castro.

Covered by existing tests.

* platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
(WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):
Remove usage of SH_UNFOLD_SHORT_CIRCUIT after last ANGLE update as
suggested by Kimmo.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (286652 => 286653)

--- trunk/Source/WebCore/ChangeLog	2021-12-08 13:51:18 UTC (rev 286652)
+++ trunk/Source/WebCore/ChangeLog	2021-12-08 15:31:39 UTC (rev 286653)
@@ -1,3 +1,17 @@
+2021-12-08  Lauro Moura  
+
+REGRESSION(r286603) [GTK][WPE] WebGL broken after the ANGLE update.
+https://bugs.webkit.org/show_bug.cgi?id=233965
+
+Reviewed by Adrian Perez de Castro.
+
+Covered by existing tests.
+
+* platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
+(WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):
+Remove usage of SH_UNFOLD_SHORT_CIRCUIT after last ANGLE update as
+suggested by Kimmo.
+
 2021-12-08  Antoine Quint  
 
 'border-radius shorthand is getting expanded in WebKit


Modified: trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp (286652 => 286653)

--- trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp	2021-12-08 13:51:18 UTC (rev 286652)
+++ trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp	2021-12-08 15:31:39 UTC (rev 286653)
@@ -190,8 +190,9 @@
 
 String translatedShaderSource;
 String shaderInfoLog;
-GCGLuint64 extraCompileOptions = SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_UNFOLD_SHORT_CIRCUIT | SH_INIT_OUTPUT_VARIABLES | SH_ENFORCE_PACKING_RESTRICTIONS | SH_LIMIT_EXPRESSION_COMPLEXITY | SH_LIMIT_CALL_STACK_DEPTH | SH_INITIALIZE_UNINITIALIZED_LOCALS;
 
+GCGLuint64 extraCompileOptions = SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_INIT_OUTPUT_VARIABLES | SH_ENFORCE_PACKING_RESTRICTIONS | SH_LIMIT_EXPRESSION_COMPLEXITY | SH_LIMIT_CALL_STACK_DEPTH | SH_INITIALIZE_UNINITIALIZED_LOCALS;
+
 if (m_requiresBuiltInFunctionEmulation)
 extraCompileOptions |= SH_EMULATE_ABS_INT_FUNCTION;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286636] trunk/Source/ThirdParty/ANGLE

2021-12-07 Thread lmoura

Title: [286636] trunk/Source/ThirdParty/ANGLE








Revision 286636
Author lmo...@igalia.com
Date 2021-12-07 18:09:34 -0800 (Tue, 07 Dec 2021)


Log Message
Avoid noisy Wcomment warnings after ANGLE update in r286603
https://bugs.webkit.org/show_bug.cgi?id=233964

Unreviewed warning removal.


* src/compiler/translator/tree_util/IntermTraverse.h:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (286635 => 286636)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-08 01:43:22 UTC (rev 286635)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-08 02:09:34 UTC (rev 286636)
@@ -1,3 +1,12 @@
+2021-12-07  Lauro Moura  
+
+Avoid noisy Wcomment warnings after ANGLE update in r286603
+https://bugs.webkit.org/show_bug.cgi?id=233964
+
+Unreviewed warning removal.
+
+* src/compiler/translator/tree_util/IntermTraverse.h:
+
 2021-12-07  Kyle Piddington  
 
 Roll ANGLE to include upstreamed Metal backend


Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h (286635 => 286636)

--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h	2021-12-08 01:43:22 UTC (rev 286635)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h	2021-12-08 02:09:34 UTC (rev 286636)
@@ -239,10 +239,10 @@
 //
 //Node 1Node 6
 // EOpIndexDirectEOpIndexDirect
-///  \  /   \
+///  \  /   \.
 //   Node 2Node 3   Node 7Node 3
 //   EOpIndexIndirect N --> replaced with -->   EOpIndexIndirect N
-// /\/\
+// /\/\.
 //  Node 4Node 5  Node 8  Node 5
 //  symbol   _expression_replacement   _expression_
 //^ ^






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286605] trunk/Tools

2021-12-07 Thread lmoura

Title: [286605] trunk/Tools








Revision 286605
Author lmo...@igalia.com
Date 2021-12-07 12:11:30 -0800 (Tue, 07 Dec 2021)


Log Message
[reporelaypy] Autoinstall missing lupa fakeredis dependency
https://bugs.webkit.org/show_bug.cgi?id=233934

Reviewed by Jonathan Bedard.

Using the same version as resultsdbpy. Avoids ImportErrors running the
webkitpy suite when they're not installed.

* Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Add lupa and
bump version.
* Scripts/libraries/reporelaypy/setup.py: Bump version.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
trunk/Tools/Scripts/libraries/reporelaypy/setup.py




Diff

Modified: trunk/Tools/ChangeLog (286604 => 286605)

--- trunk/Tools/ChangeLog	2021-12-07 20:11:07 UTC (rev 286604)
+++ trunk/Tools/ChangeLog	2021-12-07 20:11:30 UTC (rev 286605)
@@ -1,3 +1,17 @@
+2021-12-07  Lauro Moura  
+
+[reporelaypy] Autoinstall missing lupa fakeredis dependency
+https://bugs.webkit.org/show_bug.cgi?id=233934
+
+Reviewed by Jonathan Bedard.
+
+Using the same version as resultsdbpy. Avoids ImportErrors running the
+webkitpy suite when they're not installed.
+
+* Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Add lupa and
+bump version.
+* Scripts/libraries/reporelaypy/setup.py: Bump version.
+
 2021-12-07  Kyle Piddington  
 
 Roll ANGLE to include upstreamed Metal backend


Modified: trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py (286604 => 286605)

--- trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py	2021-12-07 20:11:07 UTC (rev 286604)
+++ trunk/Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py	2021-12-07 20:11:30 UTC (rev 286605)
@@ -44,7 +44,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(0, 1, 1)
+version = Version(0, 1, 2)
 
 import webkitflaskpy
 
@@ -54,6 +54,7 @@
 
 AutoInstall.register(Package('fakeredis', Version(1, 5, 2)))
 AutoInstall.register(Package('hiredis', Version(1, 1, 0)))
+AutoInstall.register(Package('lupa', Version(1, 9)))
 AutoInstall.register(Package('redis', Version(3, 5, 3)))
 AutoInstall.register(Package('sortedcontainers', Version(2, 4, 0)))
 


Modified: trunk/Tools/Scripts/libraries/reporelaypy/setup.py (286604 => 286605)

--- trunk/Tools/Scripts/libraries/reporelaypy/setup.py	2021-12-07 20:11:07 UTC (rev 286604)
+++ trunk/Tools/Scripts/libraries/reporelaypy/setup.py	2021-12-07 20:11:30 UTC (rev 286605)
@@ -30,7 +30,7 @@
 
 setup(
 name='reporelaypy',
-version='0.1.1',
+version='0.1.2',
 description='Library for visualizing, processing and storing test results.',
 long_description=readme(),
 classifiers=[






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286586] trunk/LayoutTests

2021-12-06 Thread lmoura

Title: [286586] trunk/LayoutTests








Revision 286586
Author lmo...@igalia.com
Date 2021-12-06 20:12:27 -0800 (Mon, 06 Dec 2021)


Log Message
[GLIB] Small gardening

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286585 => 286586)

--- trunk/LayoutTests/ChangeLog	2021-12-07 03:40:42 UTC (rev 286585)
+++ trunk/LayoutTests/ChangeLog	2021-12-07 04:12:27 UTC (rev 286586)
@@ -1,3 +1,12 @@
+2021-12-06  Lauro Moura  
+
+[GLIB] Small gardening
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-12-06  Arcady Goldmints-Orlov  
 
 [GTK][WPE] Mathml asserts with invisible operators


Modified: trunk/LayoutTests/platform/glib/TestExpectations (286585 => 286586)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-12-07 03:40:42 UTC (rev 286585)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-12-07 04:12:27 UTC (rev 286586)
@@ -792,6 +792,8 @@
 
 webkit.org/b/233731 fast/mediastream/getDisplayMedia-size.html [ Failure ]
 
+webkit.org/b/233836 http/tests/media/media-blocked-by-willsendrequest.html [ Timeout ]
+
 #
 # End of GStreamer-related bugs
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (286585 => 286586)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-12-07 03:40:42 UTC (rev 286585)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-12-07 04:12:27 UTC (rev 286586)
@@ -269,6 +269,9 @@
 webkit.org/b/220614 imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath.svg [ Failure Pass ]
 webkit.org/b/222895 imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size.svg [ Failure Pass ]
 
+# UIScriptController
+webkit.org/b/205159 fast/scrolling/overflow-scroll-past-max.html [ Crash ]
+
 # WebGL
 webkit.org/b/213203 webgl/1.0.3/conformance/rendering/multisample-corruption.html [ Failure Timeout ]
 
@@ -916,7 +919,6 @@
 
 webkit.org/b/212202 fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Timeout ]
 webkit.org/b/212202 fast/scrolling/iframe-scrollable-after-back.html [ Timeout ]
-webkit.org/b/212202 fast/scrolling/overflow-scroll-past-max.html [ Timeout ]
 webkit.org/b/212202 fast/scrolling/programmatic-scroll-to-zero-zero.html [ Timeout ]
 webkit.org/b/212202 fast/scrolling/rtl-point-in-iframe.html [ Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286585] trunk/Source/WebKit

2021-12-06 Thread lmoura

Title: [286585] trunk/Source/WebKit








Revision 286585
Author lmo...@igalia.com
Date 2021-12-06 19:40:42 -0800 (Mon, 06 Dec 2021)


Log Message
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
https://bugs.webkit.org/show_bug.cgi?id=233881

Reviewed by Don Olmstead.

Build fix. Covered by existing tests

The previous approach of this patch created the links to the header
derived sources into the target webkit2/ folder, which in turn was a
link to /Source/WebKit/UIProcess/API/gtk. So it ended up
actually creating the links inside the Source directory.

This commit instead links a different webkit2/ folder from the
generated webkit folder for the WebKitGTK/WPE derived sources headers.

* PlatformGTK.cmake:
* PlatformWPE.cmake:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake




Diff

Modified: trunk/Source/WebKit/ChangeLog (286584 => 286585)

--- trunk/Source/WebKit/ChangeLog	2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/ChangeLog	2021-12-07 03:40:42 UTC (rev 286585)
@@ -1,3 +1,23 @@
+2021-12-06  Lauro Moura  
+
+REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
+https://bugs.webkit.org/show_bug.cgi?id=233881
+
+Reviewed by Don Olmstead.
+
+Build fix. Covered by existing tests
+
+The previous approach of this patch created the links to the header
+derived sources into the target webkit2/ folder, which in turn was a
+link to /Source/WebKit/UIProcess/API/gtk. So it ended up
+actually creating the links inside the Source directory.
+
+This commit instead links a different webkit2/ folder from the
+generated webkit folder for the WebKitGTK/WPE derived sources headers.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+
 2021-12-06  Brady Eidson  
 
 webpushd/webpushtool debugging additions


Modified: trunk/Source/WebKit/PlatformGTK.cmake (286584 => 286585)

--- trunk/Source/WebKit/PlatformGTK.cmake	2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/PlatformGTK.cmake	2021-12-07 03:40:42 UTC (rev 286585)
@@ -875,21 +875,11 @@
 COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
 )
 add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+OUTPUT ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
 )
 add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
-)
-add_custom_command(
-OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h
-COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-)
-add_custom_command(
 OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
 DEPENDS ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION}
 COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION} ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
@@ -906,9 +896,7 @@
 )
 add_custom_target(WebKit-fake-api-headers
 DEPENDS ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
-${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit2
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkit2
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkitdom


Modified: trunk/Source/WebKit/PlatformWPE.cmake (286584 => 286585)

--- trunk/Source/WebKit/PlatformWPE.cmake	2021-12-07 01:57:44 UTC (rev 286584)
+++ trunk/Source/WebKit/PlatformWPE.cmake	2021-12-07 03:40:42 UTC (rev 286585)
@@ -55,6 +55,12 @@
 )
 
 add_custom_command(
+OUTPUT ${DERIVED_SOURCES_WPE_API_DIR}/webkit2
+DEPENDS ${DERIVED_SOURCES_WPE_API_DIR}/webkit
+COMMAND ln -n -s -f ${DERIVED_SOURCES_WPE_API_DIR}/webkit ${DERIVED_SOURCES_WPE_API_DIR}/webkit2
+)
+

[webkit-changes] [286549] trunk/Source/WebKit

2021-12-06 Thread lmoura

Title: [286549] trunk/Source/WebKit








Revision 286549
Author lmo...@igalia.com
Date 2021-12-06 10:40:13 -0800 (Mon, 06 Dec 2021)


Log Message
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
https://bugs.webkit.org/show_bug.cgi?id=233881

Reviewed by Žan Doberšek.

Build fix. Covered by exiting tests.

* PlatformGTK.cmake: Add symbolic links for the public generated like
we do for the regular headers. It happened to work before because they
were created already in a webkit2 folder.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake




Diff

Modified: trunk/Source/WebKit/ChangeLog (286548 => 286549)

--- trunk/Source/WebKit/ChangeLog	2021-12-06 18:35:05 UTC (rev 286548)
+++ trunk/Source/WebKit/ChangeLog	2021-12-06 18:40:13 UTC (rev 286549)
@@ -1,3 +1,16 @@
+2021-12-06  Lauro Moura  
+
+REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
+https://bugs.webkit.org/show_bug.cgi?id=233881
+
+Reviewed by Žan Doberšek.
+
+Build fix. Covered by exiting tests.
+
+* PlatformGTK.cmake: Add symbolic links for the public generated like
+we do for the regular headers. It happened to work before because they
+were created already in a webkit2 folder.
+
 2021-12-06  Alex Christensen  
 
 WKWebpagePreferences._activeContentRuleListActionPatterns should be an NSDictionary of identifier to allowed patterns


Modified: trunk/Source/WebKit/PlatformGTK.cmake (286548 => 286549)

--- trunk/Source/WebKit/PlatformGTK.cmake	2021-12-06 18:35:05 UTC (rev 286548)
+++ trunk/Source/WebKit/PlatformGTK.cmake	2021-12-06 18:40:13 UTC (rev 286549)
@@ -875,6 +875,21 @@
 COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
 )
 add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+)
+add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitWebProcessEnumTypes.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
+)
+add_custom_command(
+OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+DEPENDS ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h
+COMMAND ln -n -s -f ${WebKit2Gtk_DERIVED_SOURCES_DIR}/webkit/WebKitVersion.h ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+)
+add_custom_command(
 OUTPUT ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
 DEPENDS ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION}
 COMMAND ln -n -s -f ${WEBKIT_DIR}/UIProcess/API/gtk${GTK_API_VERSION} ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
@@ -891,6 +906,9 @@
 )
 add_custom_target(WebKit-fake-api-headers
 DEPENDS ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitEnumTypes.h
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitVersion.h
+${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2/WebKitWebProcessEnumTypes.h
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-${WEBKITGTK_API_VERSION}/webkit2
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkit2
 ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/webkit2gtk-webextension/webkitdom






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286525] trunk/LayoutTests

2021-12-03 Thread lmoura

Title: [286525] trunk/LayoutTests








Revision 286525
Author lmo...@igalia.com
Date 2021-12-03 19:30:03 -0800 (Fri, 03 Dec 2021)


Log Message
[GLIB] Gardening some consistent timeouts

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286524 => 286525)

--- trunk/LayoutTests/ChangeLog	2021-12-04 03:08:54 UTC (rev 286524)
+++ trunk/LayoutTests/ChangeLog	2021-12-04 03:30:03 UTC (rev 286525)
@@ -1,3 +1,12 @@
+2021-12-03  Lauro Moura  
+
+[GLIB] Gardening some consistent timeouts
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-12-03  John Wilander  
 
 PCM: Unlinkable tokens for triggering event to prevent fraud


Modified: trunk/LayoutTests/platform/glib/TestExpectations (286524 => 286525)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-12-04 03:08:54 UTC (rev 286524)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-12-04 03:30:03 UTC (rev 286525)
@@ -334,7 +334,7 @@
 webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ]
 webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ]
 webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ]
-webkit.org/b/98382 accessibility/visible-elements.html [ Failure ]
+webkit.org/b/98382 accessibility/visible-elements.html [ Timeout ]
 
 webkit.org/b/209102 accessibility/accessibility-node-memory-management.html [ Failure ]
 
@@ -1336,7 +1336,8 @@
 
 webkit.org/b/208125 webrtc/peerconnection-new-candidate-page-cache.html [ Pass Crash ]
 
-webkit.org/b/216538 webrtc/captureCanvas-webrtc-software-h264-baseline.html [ Slow Failure ]
+# Was Slow Failure before libwebrtc bumped to M96 in r285577
+webkit.org/b/216538 webrtc/captureCanvas-webrtc-software-h264-baseline.html [ Timeout ]
 
 webkit.org/b/216763 webrtc/captureCanvas-webrtc-software-h264-high.html [ Crash Failure ]
 


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (286524 => 286525)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-12-04 03:08:54 UTC (rev 286524)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-12-04 03:30:03 UTC (rev 286525)
@@ -257,6 +257,7 @@
 
 # Scrolling coordinator
 webkit.org/b/215508 [ Release ] scrollingcoordinator/overflow-proxy-reattach.html [ Pass Timeout ]
+webkit.org/b/215508 [ Release ] scrollingcoordinator/fixed-node-reattach.html [ Pass Timeout ]
 
 #Simple Line Layout
 webkit.org/b/219976 fast/text/simple-line-wordspacing.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286503] trunk/LayoutTests

2021-12-03 Thread lmoura

Title: [286503] trunk/LayoutTests








Revision 286503
Author lmo...@igalia.com
Date 2021-12-03 11:06:39 -0800 (Fri, 03 Dec 2021)


Log Message
[GLIB] WPT css-transform transform-interpolation-rotate-slerp.html is flaky img failing after updated in r286002

Unreviewed test gardening.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286502 => 286503)

--- trunk/LayoutTests/ChangeLog	2021-12-03 18:30:11 UTC (rev 286502)
+++ trunk/LayoutTests/ChangeLog	2021-12-03 19:06:39 UTC (rev 286503)
@@ -1,3 +1,11 @@
+2021-12-03  Lauro Moura  
+
+[GLIB] WPT css-transform transform-interpolation-rotate-slerp.html is flaky img failing after updated in r286002
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
 2021-12-03  Eric Carlson  
 
 DisplayCaptureSource doesn't initialize base class correctly


Modified: trunk/LayoutTests/platform/glib/TestExpectations (286502 => 286503)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-12-03 18:30:11 UTC (rev 286502)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-12-03 19:06:39 UTC (rev 286503)
@@ -607,6 +607,8 @@
 
 webkit.org/b/233478 imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-child-will-change-transform.html [ ImageOnlyFailure ]
 
+webkit.org/b/233827 imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-rotate-slerp.html [ ImageOnlyFailure Pass ]
+
 #
 # End of CSS-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286375] trunk/LayoutTests

2021-12-01 Thread lmoura

Title: [286375] trunk/LayoutTests








Revision 286375
Author lmo...@igalia.com
Date 2021-12-01 11:28:46 -0800 (Wed, 01 Dec 2021)


Log Message
[GLIB] Skip model tag test

Unreviewed test gardening.

 is not enabled/supported in GTK/WPE.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286374 => 286375)

--- trunk/LayoutTests/ChangeLog	2021-12-01 19:23:32 UTC (rev 286374)
+++ trunk/LayoutTests/ChangeLog	2021-12-01 19:28:46 UTC (rev 286375)
@@ -1,3 +1,13 @@
+2021-12-01  Lauro Moura  
+
+[GLIB] Skip model tag test
+
+Unreviewed test gardening.
+
+ is not enabled/supported in GTK/WPE.
+
+* platform/glib/TestExpectations:
+
 2021-12-01  Philippe Normand  
 
 [GStreamer] requestVideoFrameCallback support


Modified: trunk/LayoutTests/platform/glib/TestExpectations (286374 => 286375)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-12-01 19:23:32 UTC (rev 286374)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-12-01 19:28:46 UTC (rev 286375)
@@ -1870,6 +1870,9 @@
 editing/text-iterator/backwards-text-iterator-attachment.html [ Skip ]
 fast/css/has-attachment.html [ Skip ]
 
+#  is not supported by GTK/WPE
+http/tests/model/ [ Skip ]
+
 #
 # End of UNSUPPORTED tests.
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286371] trunk/Source/WTF

2021-12-01 Thread lmoura

Title: [286371] trunk/Source/WTF








Revision 286371
Author lmo...@igalia.com
Date 2021-12-01 11:06:18 -0800 (Wed, 01 Dec 2021)


Log Message
Unreviewed. Fix -Wformat warning after in ThreadingPosix logging

* wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::establishHandle):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (286370 => 286371)

--- trunk/Source/WTF/ChangeLog	2021-12-01 19:01:35 UTC (rev 286370)
+++ trunk/Source/WTF/ChangeLog	2021-12-01 19:06:18 UTC (rev 286371)
@@ -1,3 +1,10 @@
+2021-12-01  Lauro Moura  
+
+Unreviewed. Fix -Wformat warning after in ThreadingPosix logging
+
+* wtf/posix/ThreadingPOSIX.cpp:
+(WTF::Thread::establishHandle):
+
 2021-12-01  J Pascoe  
 
 Fix NEAR_FIELD macro to support iOS devices again


Modified: trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp (286370 => 286371)

--- trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp	2021-12-01 19:01:35 UTC (rev 286370)
+++ trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp	2021-12-01 19:06:18 UTC (rev 286371)
@@ -306,7 +306,7 @@
 struct sched_param param = { 0 };
 error = pthread_setschedparam(threadHandle, policy | SCHED_RESET_ON_FORK, );
 if (error)
-LOG_ERROR("Failed to set sched policy %d for thread %d: %s", policy, threadHandle, safeStrerror(error).data());
+LOG_ERROR("Failed to set sched policy %d for thread %ld: %s", policy, threadHandle, safeStrerror(error).data());
 }
 #elif !HAVE(QOS_CLASSES)
 UNUSED_PARAM(qos);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286354] trunk/Source/WebKit

2021-12-01 Thread lmoura

Title: [286354] trunk/Source/WebKit








Revision 286354
Author lmo...@igalia.com
Date 2021-12-01 00:21:48 -0800 (Wed, 01 Dec 2021)


Log Message
[GTK][GTK4][WebDriver] Flaky crashes exiting many prompty-related webdriver tests
https://bugs.webkit.org/show_bug.cgi?id=233505

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

When building for GTK4, upon dialog closure the dialog widgets might
be removed with `webkitWebViewDialogSetChild(dialog, NULL)` while
the button is still registered as the default widget of the toplevel.

This commit makes sure we don't have a default widget while the
dialog is unmapped, to mirror the map() behavior.

* UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:
(webkitScriptDialogImplUnmap): Added to unset the default widget.
(webkit_script_dialog_impl_class_init): Register unmap callback.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (286353 => 286354)

--- trunk/Source/WebKit/ChangeLog	2021-12-01 07:43:30 UTC (rev 286353)
+++ trunk/Source/WebKit/ChangeLog	2021-12-01 08:21:48 UTC (rev 286354)
@@ -1,3 +1,23 @@
+2021-12-01  Lauro Moura  
+
+[GTK][GTK4][WebDriver] Flaky crashes exiting many prompty-related webdriver tests
+https://bugs.webkit.org/show_bug.cgi?id=233505
+
+Reviewed by Carlos Garcia Campos.
+
+Covered by existing tests.
+
+When building for GTK4, upon dialog closure the dialog widgets might
+be removed with `webkitWebViewDialogSetChild(dialog, NULL)` while
+the button is still registered as the default widget of the toplevel.
+
+This commit makes sure we don't have a default widget while the
+dialog is unmapped, to mirror the map() behavior.
+
+* UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:
+(webkitScriptDialogImplUnmap): Added to unset the default widget.
+(webkit_script_dialog_impl_class_init): Register unmap callback.
+
 2021-11-30  Antoine Quint  
 
 replace-webkit-additions-includes should assume unknown or empty deployment targets are supported


Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp (286353 => 286354)

--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp	2021-12-01 07:43:30 UTC (rev 286353)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp	2021-12-01 08:21:48 UTC (rev 286354)
@@ -74,6 +74,20 @@
 }
 #endif
 
+#if USE(GTK4)
+static void webkitScriptDialogImplUnmap(GtkWidget* widget)
+{
+if (!gtk_widget_get_mapped(widget))
+return;
+
+auto* toplevel = gtk_widget_get_toplevel(GTK_WIDGET(widget));
+if (WebCore::widgetIsOnscreenToplevelWindow(toplevel))
+gtk_window_set_default(GTK_WINDOW(toplevel), nullptr);
+
+GTK_WIDGET_CLASS(webkit_script_dialog_impl_parent_class)->unmap(widget);
+}
+#endif
+
 static void webkitScriptDialogImplMap(GtkWidget* widget)
 {
 WebKitScriptDialogImplPrivate* priv = WEBKIT_SCRIPT_DIALOG_IMPL(widget)->priv;
@@ -235,6 +249,9 @@
 widgetClass->key_press_event = webkitScriptDialogImplKeyPressEvent;
 #endif
 widgetClass->map = webkitScriptDialogImplMap;
+#if USE(GTK4)
+widgetClass->unmap = webkitScriptDialogImplUnmap;
+#endif
 #if !USE(GTK4)
 gtk_widget_class_set_accessible_role(widgetClass, ATK_ROLE_ALERT);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286281] trunk/LayoutTests

2021-11-29 Thread lmoura

Title: [286281] trunk/LayoutTests








Revision 286281
Author lmo...@igalia.com
Date 2021-11-29 19:25:00 -0800 (Mon, 29 Nov 2021)


Log Message
[GLIB] Gardening SVG filter failures after r286203

Unreviewed test gardening.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (286280 => 286281)

--- trunk/LayoutTests/ChangeLog	2021-11-30 02:33:06 UTC (rev 286280)
+++ trunk/LayoutTests/ChangeLog	2021-11-30 03:25:00 UTC (rev 286281)
@@ -1,3 +1,11 @@
+2021-11-29  Lauro Moura  
+
+[GLIB] Gardening SVG filter failures after r286203
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
 2021-11-29  Simon Fraser  
 
 Revert changes related to using a scroll animator for momentum scrolling


Modified: trunk/LayoutTests/platform/glib/TestExpectations (286280 => 286281)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-30 02:33:06 UTC (rev 286280)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-30 03:25:00 UTC (rev 286281)
@@ -135,7 +135,6 @@
 
 imported/mozilla/svg/blend-hard-light.svg [ Pass ]
 imported/mozilla/svg/dynamic-textPath-02.svg [ Pass ]
-imported/mozilla/svg/image/image-filter-01.svg [ Pass ]
 
 inspector/page/setScreenSizeOverride.html [ Pass ]
 
@@ -258,7 +257,6 @@
 webaudio/Panner/panner-loop.html [ Timeout Pass ]
 
 # CSS backgrounds. Passing after WPT re-import in r277073.
-imported/w3c/web-platform-tests/css/css-backgrounds/background-size-percentage-root.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-backgrounds/bg-color-with-gradient.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow-overlapping-001.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-backgrounds/css3-border-image-repeat-repeat.html [ Pass ]
@@ -389,6 +387,38 @@
 # Cairo-related bugs
 #
 
+webkit.org/b/233611 fast/images/exif-orientation-svg-feimage.html [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filter-bounds-02.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filter-scaled-02.html [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filters-and-group-opacity-01.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filters/feBlend-1.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filters/feConvolveMatrix-1.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/filters/feGaussianBlur-2.svg [ ImageOnlyFailure ]
+# This one below was [ Pass ] before
+webkit.org/b/233611 imported/mozilla/svg/image/image-filter-01.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/mozilla/svg/text/filter-applied.svg [ ImageOnlyFailure ]
+# This one needs a [Pass] after fixed, due to root expectation being ImageOnlyFailure. Was passing after r277073.
+webkit.org/b/233611 imported/w3c/web-platform-tests/css/css-backgrounds/background-size-percentage-root.html [ ImageOnlyFailure ]
+webkit.org/b/233611 imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-matrix.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feComposite-background-rect-control-operators.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feCompositeOpaque.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feDisplacementMap-color-interpolation-filters.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feFlood-color-interpolation.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feFlood-with-alpha-color.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feImage-image-primitive-subregion.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feMorphology-radius-cases.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feMorphology-zero-radius-one-axis.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/fePointLight-coordinates.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feSpotLight-coordinates.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feTurbulence-parallel-jobs.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feTurbulence-stitchTiles.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/feTurbulence_bad_seeds.html [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/hidpi/fePointLight-coordinates.svg [ ImageOnlyFailure ]
+webkit.org/b/233611 svg/filters/hidpi/feSpotLight-coordinates.svg [ ImageOnlyFailure ]
+

[webkit-changes] [286261] trunk/Tools

2021-11-29 Thread lmoura

Title: [286261] trunk/Tools








Revision 286261
Author lmo...@igalia.com
Date 2021-11-29 13:34:35 -0800 (Mon, 29 Nov 2021)


Log Message
[webkitcorepy] Environment: Sort values before comparing in unittest
https://bugs.webkit.org/show_bug.cgi?id=233582

Reviewed by Jonathan Bedard.

While Python3.6+'s dicts happen to keep insertion order, `os.listdir`
does not guarantee the order of the listed items[1]. This may cause
the Environment unittest to fail when comparing to the fixed expected
data, as it has been happending in some GTK/WPE bots.

[1] https://docs.python.org/3/library/os.html#os.listdir

* Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py:
(TestEnvironment.test_list):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (286260 => 286261)

--- trunk/Tools/ChangeLog	2021-11-29 21:24:56 UTC (rev 286260)
+++ trunk/Tools/ChangeLog	2021-11-29 21:34:35 UTC (rev 286261)
@@ -1,3 +1,20 @@
+2021-11-29  Lauro Moura  
+
+[webkitcorepy] Environment: Sort values before comparing in unittest
+https://bugs.webkit.org/show_bug.cgi?id=233582
+
+Reviewed by Jonathan Bedard.
+
+While Python3.6+'s dicts happen to keep insertion order, `os.listdir`
+does not guarantee the order of the listed items[1]. This may cause
+the Environment unittest to fail when comparing to the fixed expected
+data, as it has been happending in some GTK/WPE bots.
+
+[1] https://docs.python.org/3/library/os.html#os.listdir
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py:
+(TestEnvironment.test_list):
+
 2021-11-29  Wenson Hsieh  
 
 WKContentView should allow -captureTextFromCamera: with a caret selection unless the sender is the callout bar


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py (286260 => 286261)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py	2021-11-29 21:24:56 UTC (rev 286260)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py	2021-11-29 21:34:35 UTC (rev 286261)
@@ -59,16 +59,16 @@
 
 Environment.instance(self.path).load()
 self.assertEqual(
-list(Environment.instance(self.path).keys()),
-['KEY_A', 'KEY_B'] + list(os.environ.keys()),
+sorted(list(Environment.instance(self.path).keys())),
+sorted(['KEY_A', 'KEY_B'] + list(os.environ.keys())),
 )
 self.assertEqual(
-list(Environment.instance(self.path).values()),
-['value_a', 'value_b'] + list(os.environ.values()),
+sorted(list(Environment.instance(self.path).values())),
+sorted(['value_a', 'value_b'] + list(os.environ.values())),
 )
 self.assertEqual(
-list(Environment.instance(self.path).items()),
-[('KEY_A', 'value_a'), ('KEY_B', 'value_b')] + list(os.environ.items()),
+sorted(list(Environment.instance(self.path).items())),
+sorted([('KEY_A', 'value_a'), ('KEY_B', 'value_b')] + list(os.environ.items())),
 )
 finally:
 Environment._instance = None






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286217] trunk/Tools

2021-11-29 Thread lmoura

Title: [286217] trunk/Tools








Revision 286217
Author lmo...@igalia.com
Date 2021-11-29 09:14:46 -0800 (Mon, 29 Nov 2021)


Log Message
[webkitflaskpy] Make sure flask is registered before importing webkitflaskpy
https://bugs.webkit.org/show_bug.cgi?id=233561

Reviewed by Jonathan Bedard.

bug29 moved AuthedBlueprint to webkitflaskpy, but flask needs to
be registered before being imported to make sure AutoInstall takes
care of it. This avoids `ModuleNotFound: flask` errors running the
tests from a clean tree.

* Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py




Diff

Modified: trunk/Tools/ChangeLog (286216 => 286217)

--- trunk/Tools/ChangeLog	2021-11-29 16:54:12 UTC (rev 286216)
+++ trunk/Tools/ChangeLog	2021-11-29 17:14:46 UTC (rev 286217)
@@ -1,3 +1,17 @@
+2021-11-29  Lauro Moura  
+
+[webkitflaskpy] Make sure flask is registered before importing webkitflaskpy
+https://bugs.webkit.org/show_bug.cgi?id=233561
+
+Reviewed by Jonathan Bedard.
+
+bug29 moved AuthedBlueprint to webkitflaskpy, but flask needs to
+be registered before being imported to make sure AutoInstall takes
+care of it. This avoids `ModuleNotFound: flask` errors running the
+tests from a clean tree.
+
+* Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py:
+
 2021-11-29  Angelos Oikonomopoulos  
 
 Consider Source/cmake relevant for JSC


Modified: trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py (286216 => 286217)

--- trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py	2021-11-29 16:54:12 UTC (rev 286216)
+++ trunk/Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py	2021-11-29 17:14:46 UTC (rev 286217)
@@ -45,8 +45,6 @@
 
 version = Version(0, 2, 0)
 
-from webkitflaskpy.authed_blueprint import AuthedBlueprint
-
 AutoInstall.register(Package('click', Version(7, 1, 2)))
 AutoInstall.register(Package('flask', Version(1, 1, 2)))
 AutoInstall.register(Package('itsdangerous', Version(1, 1, 0)))
@@ -54,4 +52,6 @@
 AutoInstall.register(Package('markupsafe', Version(1, 1, 1)))
 AutoInstall.register(Package('werkzeug', Version(1, 0, 1)))
 
+from webkitflaskpy.authed_blueprint import AuthedBlueprint  # noqa: E402
+
 name = 'webkitflaskpy'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286185] trunk/Tools

2021-11-26 Thread lmoura

Title: [286185] trunk/Tools








Revision 286185
Author lmo...@igalia.com
Date 2021-11-26 14:19:14 -0800 (Fri, 26 Nov 2021)


Log Message
[GTK] Gardening API test WebKit.OnDeviceChangedCrash as flaky timeout

Unreviewed test gardening.

Flakiness seems to have been introduced between 243131@main and
243249@main.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (286184 => 286185)

--- trunk/Tools/ChangeLog	2021-11-26 22:10:00 UTC (rev 286184)
+++ trunk/Tools/ChangeLog	2021-11-26 22:19:14 UTC (rev 286185)
@@ -1,3 +1,14 @@
+2021-11-26  Lauro Moura  
+
+[GTK] Gardening API test WebKit.OnDeviceChangedCrash as flaky timeout
+
+Unreviewed test gardening.
+
+Flakiness seems to have been introduced between 243131@main and
+243249@main.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2021-11-26  Carlos Garcia Campos  
 
 [GTK][a11y] MenuListPopup elements should implement selection interface too when building with ATSPI


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (286184 => 286185)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-11-26 22:10:00 UTC (rev 286184)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-11-26 22:19:14 UTC (rev 286185)
@@ -190,7 +190,7 @@
 "expected": {"gtk": {"status": ["TIMEOUT", "PASS"], "bug": "webkit.org/b/205336"}}
 },
 "WebKit.OnDeviceChangeCrash": {
-"expected": {"gtk": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/214805"}}
+"expected": {"gtk": {"status": ["TIMEOUT", "PASS"], "bug": "webkit.org/b/214805"}}
 }
 }
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286170] trunk/Tools

2021-11-25 Thread lmoura

Title: [286170] trunk/Tools








Revision 286170
Author lmo...@igalia.com
Date 2021-11-25 20:15:29 -0800 (Thu, 25 Nov 2021)


Log Message
[GTK] Gardening API test authentication-success flaky timeout

Unreviewed test gardening.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (286169 => 286170)

--- trunk/Tools/ChangeLog	2021-11-25 21:14:17 UTC (rev 286169)
+++ trunk/Tools/ChangeLog	2021-11-26 04:15:29 UTC (rev 286170)
@@ -1,3 +1,11 @@
+2021-11-25  Lauro Moura  
+
+[GTK] Gardening API test authentication-success flaky timeout
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2021-11-25  Kimmo Kinnunen  
 
 GraphicsContextGL implementations should have separate class definitions


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (286169 => 286170)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-11-25 21:14:17 UTC (rev 286169)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-11-26 04:15:29 UTC (rev 286170)
@@ -8,7 +8,10 @@
 "expected": {"all@Debug": {"status": ["CRASH"], "bug": "webkit.org/b/221119"}}
 },
 "/webkit/Authentication/authentication-success": {
-"expected": {"all@Debug": {"status": ["CRASH"], "bug": "webkit.org/b/221119"}}
+"expected": {
+"all@Debug": {"status": ["CRASH"], "bug": "webkit.org/b/221119"},
+"gtk@Release": {"status": ["PASS", "TIMEOUT"], "bug": "webkit.org/b/233509"}
+}
 }
 }
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286141] trunk/Tools

2021-11-23 Thread lmoura

Title: [286141] trunk/Tools








Revision 286141
Author lmo...@igalia.com
Date 2021-11-23 19:47:06 -0800 (Tue, 23 Nov 2021)


Log Message
[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
https://bugs.webkit.org/show_bug.cgi?id=233452

Reviewed by Michael Catanzaro.

GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
being used as the max value, while GdkRGBA expects the value to be
between 0.0 and 1.0, per the official docs [1][2].

[1] https://docs.gtk.org/gdk3/struct.RGBA.html
[2] https://docs.gtk.org/gdk4/struct.RGBA.html

* MiniBrowser/gtk/BrowserWindow.c:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (286140 => 286141)

--- trunk/Tools/ChangeLog	2021-11-24 01:34:33 UTC (rev 286140)
+++ trunk/Tools/ChangeLog	2021-11-24 03:47:06 UTC (rev 286141)
@@ -1,3 +1,19 @@
+2021-11-23  Lauro Moura  
+
+[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
+https://bugs.webkit.org/show_bug.cgi?id=233452
+
+Reviewed by Michael Catanzaro.
+
+GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
+being used as the max value, while GdkRGBA expects the value to be
+between 0.0 and 1.0, per the official docs [1][2].
+
+[1] https://docs.gtk.org/gdk3/struct.RGBA.html
+[2] https://docs.gtk.org/gdk4/struct.RGBA.html
+
+* MiniBrowser/gtk/BrowserWindow.c:
+
 2021-11-23  Carlos Garcia Campos  
 
 [GTK] Change hardware-acceleration-policy setting default value to always


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (286140 => 286141)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2021-11-24 01:34:33 UTC (rev 286140)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2021-11-24 03:47:06 UTC (rev 286141)
@@ -1332,8 +1332,8 @@
 
 static void browser_window_init(BrowserWindow *window)
 {
-window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 255;
-window->backgroundColor.alpha = 1;
+window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 1.0;
+window->backgroundColor.alpha = 1.0;
 
 gtk_window_set_title(GTK_WINDOW(window), defaultWindowTitle);
 gtk_window_set_default_size(GTK_WINDOW(window), 1024, 768);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [286088] trunk/WebDriverTests

2021-11-19 Thread lmoura

Title: [286088] trunk/WebDriverTests








Revision 286088
Author lmo...@igalia.com
Date 2021-11-19 19:05:27 -0800 (Fri, 19 Nov 2021)


Log Message
[GLIB][WebDriver] Gardening COOP-related timeouts

Unreviewed test gardening.

* TestExpectations.json:

Modified Paths

trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json




Diff

Modified: trunk/WebDriverTests/ChangeLog (286087 => 286088)

--- trunk/WebDriverTests/ChangeLog	2021-11-20 02:33:42 UTC (rev 286087)
+++ trunk/WebDriverTests/ChangeLog	2021-11-20 03:05:27 UTC (rev 286088)
@@ -1,3 +1,11 @@
+2021-11-19  Lauro Moura  
+
+[GLIB][WebDriver] Gardening COOP-related timeouts
+
+Unreviewed test gardening.
+
+* TestExpectations.json:
+
 2021-10-08  Carlos Garcia Campos  
 
 [WebDriver] Update w3c and selenium tests


Modified: trunk/WebDriverTests/TestExpectations.json (286087 => 286088)

--- trunk/WebDriverTests/TestExpectations.json	2021-11-20 02:33:42 UTC (rev 286087)
+++ trunk/WebDriverTests/TestExpectations.json	2021-11-20 03:05:27 UTC (rev 286088)
@@ -321,6 +321,9 @@
 
 "imported/w3c/webdriver/tests/back/back.py": {
 "subtests": {
+"test_cross_origin[capabilities0]": {
+"expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/233391"}}
+},
 "test_data_urls": {
 "expected": {"wpe": {"status": ["FAIL"], "bug": "webkit.org/b/212950"}}
 },
@@ -387,6 +390,9 @@
 
 "imported/w3c/webdriver/tests/forward/forward.py": {
 "subtests": {
+"test_cross_origin[capabilities0]": {
+"expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/233391"}}
+},
 "test_data_urls": {
 "expected": {"wpe": {"status": ["FAIL"], "bug": "webkit.org/b/212950"}}
 },
@@ -814,6 +820,9 @@
 },
 "imported/w3c/webdriver/tests/element_click/navigate.py": {
 "subtests": {
+"test_link_cross_origin[capabilities0]": {
+"expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/233391"}}
+},
 "test_link_closes_window": {
 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/211548"}}
 },
@@ -1012,6 +1021,9 @@
 
 "imported/w3c/webdriver/tests/navigate_to/navigate.py": {
 "subtests": {
+"test_cross_origin[capabilities0]": {
+"expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/233391"}}
+},
 "test_no_top_browsing_context": {
 "expected": {"wpe": {"status": ["FAIL"], "bug": "webkit.org/b/212950"}}
 },
@@ -1303,6 +1315,9 @@
 },
 "test_no_browsing_context": {
 "expected": {"wpe": {"status": ["FAIL"], "bug": "webkit.org/b/212950"}}
+},
+"test_navigation_with_coop_headers[capabilities0]": {
+"expected": {"all": {"status": ["TIMEOUT"], "bug": "webkit.org/b/233391"}}
 }
 }
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285362] trunk/LayoutTests

2021-11-05 Thread lmoura

Title: [285362] trunk/LayoutTests








Revision 285362
Author lmo...@igalia.com
Date 2021-11-05 20:52:36 -0700 (Fri, 05 Nov 2021)


Log Message
[GLIB] Gardening some offscreencanvas failures after recent WPT update

Unreviewed test gardening.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285361 => 285362)

--- trunk/LayoutTests/ChangeLog	2021-11-06 03:02:57 UTC (rev 285361)
+++ trunk/LayoutTests/ChangeLog	2021-11-06 03:52:36 UTC (rev 285362)
@@ -1,5 +1,13 @@
 2021-11-05  Lauro Moura  
 
+[GLIB] Gardening some offscreencanvas failures after recent WPT update
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
+2021-11-05  Lauro Moura  
+
 [GLIB] Gardening more timeouts
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285361 => 285362)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-06 03:02:57 UTC (rev 285361)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-06 03:52:36 UTC (rev 285362)
@@ -916,6 +916,26 @@
 # Failing since r277543.
 webkit.org/b/225870 imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html [ Failure ]
 
+
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompointinit.worker.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompointinit.html [ Missing Failure ]
+webkit.org/b/232780 imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompointinit.worker.html [ Missing Failure ]
+
 #
 # End of OffscreenCanvas-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285355] trunk/LayoutTests

2021-11-05 Thread lmoura

Title: [285355] trunk/LayoutTests








Revision 285355
Author lmo...@igalia.com
Date 2021-11-05 15:20:49 -0700 (Fri, 05 Nov 2021)


Log Message
[GLIB] Gardening more timeouts

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285354 => 285355)

--- trunk/LayoutTests/ChangeLog	2021-11-05 22:00:52 UTC (rev 285354)
+++ trunk/LayoutTests/ChangeLog	2021-11-05 22:20:49 UTC (rev 285355)
@@ -1,3 +1,12 @@
+2021-11-05  Lauro Moura  
+
+[GLIB] Gardening more timeouts
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-11-05  Chris Dumez  
 
 Resync web-platform-tests/html from upstream


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285354 => 285355)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-05 22:00:52 UTC (rev 285354)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-05 22:20:49 UTC (rev 285355)
@@ -763,6 +763,9 @@
 webkit.org/b/231811 webaudio/audiocontext-state-interrupted.html [ Timeout ]
 webkit.org/b/231811 webaudio/suspend-context-while-interrupted.html [ Timeout ]
 
+# Also Timing out on the bots
+webkit.org/b/232629 http/tests/media/media-blocked-by-willsendrequest.html [ Crash Timeout ]
+
 #
 # End of GStreamer-related bugs
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (285354 => 285355)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-11-05 22:00:52 UTC (rev 285354)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-11-05 22:20:49 UTC (rev 285355)
@@ -177,6 +177,9 @@
 webkit.org/b/225479 accessibility/aria-modal.html [ Timeout ]
 webkit.org/b/225479 accessibility/dialog-showModal.html [ Timeout ]
 
+# Animations
+webkit.org/b/232745 fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Timeout ]
+
 # Complex Text Path: Tests passing with --complex-text
 webkit.org/b/215355 fonts/ligature.html [ ImageOnlyFailure ]
 webkit.org/b/215421 fast/encoding/denormalised-voiced-japanese-chars.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285354] trunk/Tools

2021-11-05 Thread lmoura

Title: [285354] trunk/Tools








Revision 285354
Author lmo...@igalia.com
Date 2021-11-05 15:00:52 -0700 (Fri, 05 Nov 2021)


Log Message
[Flatpak SDK] Print SDK version after update
https://bugs.webkit.org/show_bug.cgi?id=232725

Reviewed by Adrian Perez de Castro.

Print the actual installed version after the update step, even if
nothing was updated. This should help tracking the SDK versions across
builds on the bots.

* flatpak/flatpakutils.py:
(WebkitFlatpak.main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Tools/ChangeLog (285353 => 285354)

--- trunk/Tools/ChangeLog	2021-11-05 20:32:47 UTC (rev 285353)
+++ trunk/Tools/ChangeLog	2021-11-05 22:00:52 UTC (rev 285354)
@@ -1,3 +1,17 @@
+2021-11-05  Lauro Moura  
+
+[Flatpak SDK] Print SDK version after update
+https://bugs.webkit.org/show_bug.cgi?id=232725
+
+Reviewed by Adrian Perez de Castro.
+
+Print the actual installed version after the update step, even if
+nothing was updated. This should help tracking the SDK versions across
+builds on the bots.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.main):
+
 2021-11-05  Ryan Haddad  
 
 Bring up queues for Monterey


Modified: trunk/Tools/flatpak/flatpakutils.py (285353 => 285354)

--- trunk/Tools/flatpak/flatpakutils.py	2021-11-05 20:32:47 UTC (rev 285353)
+++ trunk/Tools/flatpak/flatpakutils.py	2021-11-05 22:00:52 UTC (rev 285354)
@@ -1034,6 +1034,8 @@
 package.install()
 regenerate_toolchains = True
 
+print("SDK version: {}".format(self.sdk_repo.version("org.webkit.Sdk")))
+
 else:
 regenerate_toolchains = self.regenerate_toolchains
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285309] trunk/LayoutTests

2021-11-04 Thread lmoura

Title: [285309] trunk/LayoutTests








Revision 285309
Author lmo...@igalia.com
Date 2021-11-04 14:23:10 -0700 (Thu, 04 Nov 2021)


Log Message
[GLIB] Gardening some timeouts

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285308 => 285309)

--- trunk/LayoutTests/ChangeLog	2021-11-04 21:19:07 UTC (rev 285308)
+++ trunk/LayoutTests/ChangeLog	2021-11-04 21:23:10 UTC (rev 285309)
@@ -1,3 +1,13 @@
+2021-11-04  Lauro Moura  
+
+[GLIB] Gardening some timeouts
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-11-04  Arcady Goldmints-Orlov  
 
 Update global test expectations to skip more rvfc tests (and enable them only on Mac/iOS)


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285308 => 285309)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-11-04 21:19:07 UTC (rev 285308)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-11-04 21:23:10 UTC (rev 285309)
@@ -1192,6 +1192,8 @@
 
 webkit.org/b/229219 http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Pass Timeout ]
 
+webkit.org/b/232726 webaudio/AudioBuffer/huge-buffer.html [ Pass Slow ]
+
 #
 # End of WebAudio-related bugs
 #
@@ -1745,6 +1747,7 @@
 webkit.org/b/166536 fast/canvas/webgl/shader-mix-with-bool.html [ Skip ]
 webkit.org/b/166536 fast/canvas/webgl/shader-vec-array-deref-no-crash.html [ Skip ]
 webkit.org/b/166536 fast/canvas/webgl/shader-with-reserved-keyword.html [ Skip ]
+webkit.org/b/166536 webgl/pending/conformance/glsl/misc/shader-with-reserved-words-2.html [ Skip ]
 
 # LFC (LayoutFormatingContext is disabled by default).
 fast/layoutformattingcontext/ [ Skip ]
@@ -2552,6 +2555,7 @@
 webkit.org/b/232386 jquery/traversing.html [ Timeout ]
 # Uncomment after timeout is solved Bug(GTK) jquery/traversing.html [ Slow Pass ]
 webkit.org/b/232386 jquery/manipulation.html [ Timeout ]
+# Uncomment after timeout is solved webkit.org/b/212960 jquery/manipulation.html [ Slow Pass ]
 webkit.org/b/232386 jquery/event.html [ Timeout ]
 webkit.org/b/232386 jquery/dimensions.html [ Timeout ]
 webkit.org/b/232386 jquery/data.html [ Timeout ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (285308 => 285309)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2021-11-04 21:19:07 UTC (rev 285308)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2021-11-04 21:23:10 UTC (rev 285309)
@@ -1282,7 +1282,6 @@
 Bug(GTK) js/dom/string-replacement-outofmemory.html [ Pass Slow ]
 Bug(GTK) [ Debug ] js/dom/toString-and-valueOf-override.html [ Pass Slow ]
 Bug(GTK) jquery/event.html [ Pass Slow ]
-Bug(GTK) jquery/manipulation.html [ Pass Slow ]
 Bug(GTK) jquery/offset.html [ Pass Slow ]
 Bug(GTK) jquery/traversing.html [ Pass Slow ]
 Bug(GTK) tables/mozilla/other/slashlogo.html [ Pass Slow ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (285308 => 285309)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-11-04 21:19:07 UTC (rev 285308)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-11-04 21:23:10 UTC (rev 285309)
@@ -888,8 +888,6 @@
 
 webkit.org/b/133151 js/cached-window-properties.html [ Slow ]
 
-webkit.org/b/212960 jquery/manipulation.html [ Slow ]
-
 imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html [ Slow ]
 
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285265] trunk/Source/WebKit

2021-11-04 Thread lmoura

Title: [285265] trunk/Source/WebKit








Revision 285265
Author lmo...@igalia.com
Date 2021-11-04 09:38:58 -0700 (Thu, 04 Nov 2021)


Log Message
REGRESSION(r285077) [GLIB] 'MemoryPressureMonitor' has not been declared
https://bugs.webkit.org/show_bug.cgi?id=232706

Unreviewed non-linux build fix.

MemoryPressureMonitor is only available on Linux, so its usage should
be guarded, like WebProcessPool.cpp does when starting it.


* UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitialize): Add OS(LINUX) guard.
(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (285264 => 285265)

--- trunk/Source/WebKit/ChangeLog	2021-11-04 16:28:50 UTC (rev 285264)
+++ trunk/Source/WebKit/ChangeLog	2021-11-04 16:38:58 UTC (rev 285265)
@@ -1,3 +1,17 @@
+2021-11-04  Lauro Moura  
+
+REGRESSION(r285077) [GLIB] 'MemoryPressureMonitor' has not been declared
+https://bugs.webkit.org/show_bug.cgi?id=232706
+
+Unreviewed non-linux build fix.
+
+MemoryPressureMonitor is only available on Linux, so its usage should
+be guarded, like WebProcessPool.cpp does when starting it.
+
+* UIProcess/glib/WebProcessPoolGLib.cpp:
+(WebKit::WebProcessPool::platformInitialize): Add OS(LINUX) guard.
+(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.
+
 2021-11-04  Brent Fulgham  
 
 [iOS] Update IOKit message filters for later iOS releases


Modified: trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp (285264 => 285265)

--- trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp	2021-11-04 16:28:50 UTC (rev 285264)
+++ trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp	2021-11-04 16:38:58 UTC (rev 285265)
@@ -61,8 +61,10 @@
 if (const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT"))
 m_alwaysUsesComplexTextCodePath = !strcmp(forceComplexText, "1");
 
+#if OS(LINUX)
 if (!MemoryPressureMonitor::disabled())
 installMemoryPressureHandler();
+#endif
 }
 
 void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy& process, WebProcessCreationParameters& parameters)
@@ -92,8 +94,10 @@
 
 parameters.memoryCacheDisabled = m_memoryCacheDisabled || LegacyGlobalSettings::singleton().cacheModel() == CacheModel::DocumentViewer;
 
+#if OS(LINUX)
 if (MemoryPressureMonitor::disabled())
 parameters.shouldSuppressMemoryPressureHandler = true;
+#endif
 
 #if USE(GSTREAMER)
 parameters.gstreamerOptions = WebCore::extractGStreamerOptionsFromCommandLine();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285077] trunk/Source/WebKit

2021-10-30 Thread lmoura

Title: [285077] trunk/Source/WebKit








Revision 285077
Author lmo...@igalia.com
Date 2021-10-29 23:28:57 -0700 (Fri, 29 Oct 2021)


Log Message
[GLIB][SOUP] Unify memoryPressureMonitorDisabled implementation
https://bugs.webkit.org/show_bug.cgi?id=232519

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

Follow up the fix of r285062, to avoid having two copies of
the same function around.

* UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::memoryPressureMonitorDisabled): Deleted.
* UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::MemoryPressureMonitor::disabled):
* UIProcess/linux/MemoryPressureMonitor.h:
* UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::memoryPressureMonitorDisabledSoup): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp
trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h
trunk/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (285076 => 285077)

--- trunk/Source/WebKit/ChangeLog	2021-10-30 05:25:59 UTC (rev 285076)
+++ trunk/Source/WebKit/ChangeLog	2021-10-30 06:28:57 UTC (rev 285077)
@@ -1,3 +1,26 @@
+2021-10-29  Lauro Moura  
+
+[GLIB][SOUP] Unify memoryPressureMonitorDisabled implementation
+https://bugs.webkit.org/show_bug.cgi?id=232519
+
+Reviewed by Carlos Garcia Campos.
+
+Covered by existing tests.
+
+Follow up the fix of r285062, to avoid having two copies of
+the same function around.
+
+* UIProcess/glib/WebProcessPoolGLib.cpp:
+(WebKit::WebProcessPool::platformInitialize):
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+(WebKit::memoryPressureMonitorDisabled): Deleted.
+* UIProcess/linux/MemoryPressureMonitor.cpp:
+(WebKit::MemoryPressureMonitor::disabled):
+* UIProcess/linux/MemoryPressureMonitor.h:
+* UIProcess/soup/WebProcessPoolSoup.cpp:
+(WebKit::WebProcessPool::platformInitializeNetworkProcess):
+(WebKit::memoryPressureMonitorDisabledSoup): Deleted.
+
 2021-10-29  Tim Horton  
 
 Add release logging of display list size to CGDisplayListImageBufferBackend


Modified: trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp (285076 => 285077)

--- trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp	2021-10-30 05:25:59 UTC (rev 285076)
+++ trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp	2021-10-30 06:28:57 UTC (rev 285077)
@@ -29,6 +29,7 @@
 #include "WebProcessPool.h"
 
 #include "LegacyGlobalSettings.h"
+#include "MemoryPressureMonitor.h"
 #include "WebMemoryPressureHandler.h"
 #include "WebProcessCreationParameters.h"
 #include 
@@ -52,12 +53,6 @@
 
 namespace WebKit {
 
-static bool memoryPressureMonitorDisabled()
-{
-static const char* disableMemoryPressureMonitor = getenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR");
-return disableMemoryPressureMonitor && !strcmp(disableMemoryPressureMonitor, "1");
-}
-
 void WebProcessPool::platformInitialize()
 {
 #if PLATFORM(GTK)
@@ -66,7 +61,7 @@
 if (const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT"))
 m_alwaysUsesComplexTextCodePath = !strcmp(forceComplexText, "1");
 
-if (!memoryPressureMonitorDisabled())
+if (!MemoryPressureMonitor::disabled())
 installMemoryPressureHandler();
 }
 
@@ -97,7 +92,7 @@
 
 parameters.memoryCacheDisabled = m_memoryCacheDisabled || LegacyGlobalSettings::singleton().cacheModel() == CacheModel::DocumentViewer;
 
-if (memoryPressureMonitorDisabled())
+if (MemoryPressureMonitor::disabled())
 parameters.shouldSuppressMemoryPressureHandler = true;
 
 #if USE(GSTREAMER)


Modified: trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp (285076 => 285077)

--- trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp	2021-10-30 05:25:59 UTC (rev 285076)
+++ trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp	2021-10-30 06:28:57 UTC (rev 285077)
@@ -29,6 +29,7 @@
 #if OS(LINUX)
 
 #include "WebProcessPool.h"
+#include 
 #include 
 #include 
 #include 
@@ -389,6 +390,18 @@
 })->detach();
 }
 
+bool MemoryPressureMonitor::s_disabled = false;
+
+bool MemoryPressureMonitor::disabled()
+{
+static std::once_flag flag;
+std::call_once(flag, []() {
+auto envvar = getenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR");
+s_disabled = envvar && !strcmp(envvar, "1");
+});
+return s_disabled;
+}
+
 void CGroupMemoryController::setMemoryControllerPath(CString memoryControllerPath)
 {
 if (memoryControllerPath == m_cgroupMemoryControllerPath)


Modified: trunk/Source/WebKit/UIProcess/linux/MemoryPressureMonitor.h (285076 => 285077)

---

[webkit-changes] [285067] trunk/LayoutTests

2021-10-29 Thread lmoura

Title: [285067] trunk/LayoutTests








Revision 285067
Author lmo...@igalia.com
Date 2021-10-29 18:29:16 -0700 (Fri, 29 Oct 2021)


Log Message
[GLIB] Gardening timeouts affected by xhtml mimetype misdetection

Unreviewed test gardening.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285066 => 285067)

--- trunk/LayoutTests/ChangeLog	2021-10-30 00:48:53 UTC (rev 285066)
+++ trunk/LayoutTests/ChangeLog	2021-10-30 01:29:16 UTC (rev 285067)
@@ -1,3 +1,11 @@
+2021-10-29  Lauro Moura  
+
+[GLIB] Gardening timeouts affected by xhtml mimetype misdetection
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
 2021-10-29  Arcady Goldmints-Orlov  
 
 [GTK] Layout Tests for experimental  element are failing since added


Modified: trunk/LayoutTests/platform/glib/TestExpectations (285066 => 285067)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-10-30 00:48:53 UTC (rev 285066)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-10-30 01:29:16 UTC (rev 285067)
@@ -1822,9 +1822,6 @@
 # NEEDS TRIAGING. If unsure, put it in this section.
 #
 
-Bug(GTK) jquery/offset.html [ Slow Pass ]
-Bug(GTK) jquery/traversing.html [ Slow Pass ]
-
 webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ]
 
 webkit.org/b/133151 js/cached-window-properties.html [ Timeout Pass ]
@@ -2529,7 +2526,26 @@
 webkit.org/b/232386 tables/mozilla/bugs/bug222846.html [ Failure ]
 webkit.org/b/232386 tables/mozilla_expected_failures/bugs/bug104898.html [ Failure ]
 webkit.org/b/232386 fast/dom/gc-11.html [ Timeout ]
+# Glib timeout since 243264@main (Mimetype woes)
+# html with xmlns xhtml. Times out evaluating document.body.innertext
+webkit.org/b/232386 svg/custom/svg-element-destructor-iteration-crash.html [ Timeout ]
+# Timing out with exception raised accessing iframe data.
+webkit.org/b/232386 jquery/offset.html [ Timeout ]
+# Uncomment after timeout is solved. Bug(GTK) jquery/offset.html [ Slow Pass ]
+webkit.org/b/232386 jquery/traversing.html [ Timeout ]
+# Uncomment after timeout is solved Bug(GTK) jquery/traversing.html [ Slow Pass ]
+webkit.org/b/232386 jquery/manipulation.html [ Timeout ]
+webkit.org/b/232386 jquery/event.html [ Timeout ]
+webkit.org/b/232386 jquery/dimensions.html [ Timeout ]
+webkit.org/b/232386 jquery/data.html [ Timeout ]
+webkit.org/b/232386 jquery/deferred.html [ Timeout ]
+webkit.org/b/232386 jquery/attributes.html [ Timeout ]
+webkit.org/b/232386 jquery/core.html [ Timeout ]
+webkit.org/b/232386 jquery/css.html [ Timeout ]
+# html with xmlns xhtml. Times out with some syntaxerrors in Js strings with 
+webkit.org/b/232386 svg/as-object/embedded-svg-size-changes.html [ Timeout ]
 
+
 # End: Common failures between GTK and WPE.
 
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284978] trunk/Tools/buildstream

2021-10-28 Thread lmoura

Title: [284978] trunk/Tools/buildstream








Revision 284978
Author lmo...@igalia.com
Date 2021-10-28 08:18:17 -0700 (Thu, 28 Oct 2021)


Log Message
[FlatpakSDK] Import ccache 4.4.2 over fdo-sdk 4.4.0
https://bugs.webkit.org/show_bug.cgi?id=232224

Reviewed by Philippe Normand.

ccache 4.4.2 already up in the unreleased version of freedesktop-sdk.
The latest, 21.08.4, is using 4.4.1.

To avoid changing too much gears at once, just patch the newest
version on top of our current sdk.

* elements/freedesktop-sdk.bst:
* patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch: Added.

Modified Paths

trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/elements/freedesktop-sdk.bst


Added Paths

trunk/Tools/buildstream/patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch




Diff

Modified: trunk/Tools/buildstream/ChangeLog (284977 => 284978)

--- trunk/Tools/buildstream/ChangeLog	2021-10-28 15:12:06 UTC (rev 284977)
+++ trunk/Tools/buildstream/ChangeLog	2021-10-28 15:18:17 UTC (rev 284978)
@@ -1,3 +1,19 @@
+2021-10-28  Lauro Moura  
+
+[FlatpakSDK] Import ccache 4.4.2 over fdo-sdk 4.4.0
+https://bugs.webkit.org/show_bug.cgi?id=232224
+
+Reviewed by Philippe Normand.
+
+ccache 4.4.2 already up in the unreleased version of freedesktop-sdk.
+The latest, 21.08.4, is using 4.4.1.
+
+To avoid changing too much gears at once, just patch the newest
+version on top of our current sdk.
+
+* elements/freedesktop-sdk.bst:
+* patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch: Added.
+
 2021-10-06  Philippe Normand  
 
 [Flatpak SDK] Add apitrace


Modified: trunk/Tools/buildstream/elements/freedesktop-sdk.bst (284977 => 284978)

--- trunk/Tools/buildstream/elements/freedesktop-sdk.bst	2021-10-28 15:12:06 UTC (rev 284977)
+++ trunk/Tools/buildstream/elements/freedesktop-sdk.bst	2021-10-28 15:18:17 UTC (rev 284978)
@@ -4,6 +4,8 @@
   url: gitlab_com:freedesktop-sdk/freedesktop-sdk.git
   track: 'release/21.08'
   ref: freedesktop-sdk-21.08.2-22-gdc1e3345272fc70397b441832940b956fca5df14
+- kind: patch
+  path: patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch
 config:
   options:
 target_arch: '%{arch}'


Added: trunk/Tools/buildstream/patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch (0 => 284978)

--- trunk/Tools/buildstream/patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch	(rev 0)
+++ trunk/Tools/buildstream/patches/fdo-sdk-0001-Bump-ccache-to-4.4.2.patch	2021-10-28 15:18:17 UTC (rev 284978)
@@ -0,0 +1,22 @@
+From ac4633b31800146a9811b64de1fcc82209183f2e Mon Sep 17 00:00:00 2001
+From: Lauro Moura 
+Date: Wed, 27 Oct 2021 22:45:08 -0300
+Subject: [PATCH] Bump ccache to 4.4.2
+
+---
+ elements/components/ccache.bst | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elements/components/ccache.bst b/elements/components/ccache.bst
+index 8c8e17a18..9f34f8c6d 100644
+--- a/elements/components/ccache.bst
 b/elements/components/ccache.bst
+@@ -18,4 +18,4 @@ sources:
+ - kind: git_tag
+   url: github:ccache/ccache.git
+   track: master
+-  ref: v4.4-0-g6ac58b50ec7ad402395acba9b1a5fdcbeabf347d
++  ref: v4.4.2-0-g89def7d170f930a4480a132679f6a9e03d972787
+-- 
+2.27.0
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284771] trunk/Source/WebCore

2021-10-24 Thread lmoura

Title: [284771] trunk/Source/WebCore








Revision 284771
Author lmo...@igalia.com
Date 2021-10-24 19:48:49 -0700 (Sun, 24 Oct 2021)


Log Message
[GLIB] REGRESSION(r284670): Tentative LTS build fix

Unreviewed build fix.

* platform/glib/LowPowerModeNotifierGLib.cpp:
(WebCore::LowPowerModeNotifier::LowPowerModeNotifier):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (284770 => 284771)

--- trunk/Source/WebCore/ChangeLog	2021-10-25 00:04:12 UTC (rev 284770)
+++ trunk/Source/WebCore/ChangeLog	2021-10-25 02:48:49 UTC (rev 284771)
@@ -1,3 +1,12 @@
+2021-10-24  Lauro Moura  
+
+[GLIB] REGRESSION(r284670): Tentative LTS build fix
+
+Unreviewed build fix.
+
+* platform/glib/LowPowerModeNotifierGLib.cpp:
+(WebCore::LowPowerModeNotifier::LowPowerModeNotifier):
+
 2021-10-24  Jean-Yves Avenard  
 
 Fix typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()


Modified: trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp (284770 => 284771)

--- trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp	2021-10-25 00:04:12 UTC (rev 284770)
+++ trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp	2021-10-25 02:48:49 UTC (rev 284771)
@@ -28,8 +28,8 @@
 
 
 LowPowerModeNotifier::LowPowerModeNotifier(LowPowerModeChangeCallback&& callback)
+#if GLIB_CHECK_VERSION(2, 69, 1)
 : m_callback(WTFMove(callback))
-#if GLIB_CHECK_VERSION(2, 69, 1)
 , m_powerProfileMonitor(adoptGRef(g_power_profile_monitor_dup_default()))
 #endif
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284311] trunk/Source/WebKit

2021-10-16 Thread lmoura

Title: [284311] trunk/Source/WebKit








Revision 284311
Author lmo...@igalia.com
Date 2021-10-16 02:07:26 -0700 (Sat, 16 Oct 2021)


Log Message
[GTK4] Update signal name to monitor window resize
https://bugs.webkit.org/show_bug.cgi?id=231854

Reviewed by Carlos Garcia Campos.

Using size-changed (previous signal name) makes the MiniBrowser crash
running the WebDriver tests.

The signal name was changed in
https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
as part of GTK 3.99.5.

Covered by existing tests.

* UIProcess/API/glib/WebKitUIClient.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (284310 => 284311)

--- trunk/Source/WebKit/ChangeLog	2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/ChangeLog	2021-10-16 09:07:26 UTC (rev 284311)
@@ -1,3 +1,21 @@
+2021-10-16  Lauro Moura  
+
+[GTK4] Update signal name to monitor window resize
+https://bugs.webkit.org/show_bug.cgi?id=231854
+
+Reviewed by Carlos Garcia Campos.
+
+Using size-changed (previous signal name) makes the MiniBrowser crash
+running the WebDriver tests.
+
+The signal name was changed in
+https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
+as part of GTK 3.99.5.
+
+Covered by existing tests.
+
+* UIProcess/API/glib/WebKitUIClient.cpp:
+
 2021-10-15  Alex Christensen  
 
 Start using adattributiond on iOS


Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (284310 => 284311)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2021-10-16 09:07:26 UTC (rev 284311)
@@ -208,7 +208,7 @@
 
 #if USE(GTK4)
 auto* surface = gtk_native_get_surface(GTK_NATIVE(window));
-auto signalID = g_signal_connect(surface, "size-changed", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
+auto signalID = g_signal_connect(surface, "layout", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
 if (width == targetGeometry->width && height == targetGeometry->height)
 RunLoop::current().stop();
 }), );






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [284227] trunk/Tools

2021-10-14 Thread lmoura

Title: [284227] trunk/Tools








Revision 284227
Author lmo...@igalia.com
Date 2021-10-14 19:20:48 -0700 (Thu, 14 Oct 2021)


Log Message
[webkitpy] Occasional exception thrown in change_result_to_failure when repeating flaky layout tests
https://bugs.webkit.org/show_bug.cgi?id=229788

Reviewed by Jonathan Bedard.

When a iterated/repeated flaky test moves from an unexpected Failure to
successive unexpected Pass, the currently stored result is still the
Failure (likely due to r235467). This may cause change_result_to_failure
to raise KeyError trying to forcibly remove() the Failure result from
the test_by_expectations set twice.

This commit relaxes the behavior to just ask to discard the value from
the set.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_update_summary_with_result): Added test case.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.change_result_to_failure): Use set.discard to avoid
KeyErrors.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py




Diff

Modified: trunk/Tools/ChangeLog (284226 => 284227)

--- trunk/Tools/ChangeLog	2021-10-15 02:02:14 UTC (rev 284226)
+++ trunk/Tools/ChangeLog	2021-10-15 02:20:48 UTC (rev 284227)
@@ -1,3 +1,25 @@
+2021-10-14  Lauro Moura  
+
+[webkitpy] Occasional exception thrown in change_result_to_failure when repeating flaky layout tests
+https://bugs.webkit.org/show_bug.cgi?id=229788
+
+Reviewed by Jonathan Bedard.
+
+When a iterated/repeated flaky test moves from an unexpected Failure to
+successive unexpected Pass, the currently stored result is still the
+Failure (likely due to r235467). This may cause change_result_to_failure
+to raise KeyError trying to forcibly remove() the Failure result from
+the test_by_expectations set twice.
+
+This commit relaxes the behavior to just ask to discard the value from
+the set.
+
+* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
+(LayoutTestRunnerTests.test_update_summary_with_result): Added test case.
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(TestRunResults.change_result_to_failure): Use set.discard to avoid
+KeyErrors.
+
 2021-10-14  Chris Dumez  
 
 Service workers running on the main thread should use the main VM


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py (284226 => 284227)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py	2021-10-15 02:02:14 UTC (rev 284226)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py	2021-10-15 02:20:48 UTC (rev 284227)
@@ -126,7 +126,8 @@
 runner._options.world_leaks = False
 test = 'failures/expected/reftest.html'
 leak_test = 'failures/expected/leak.html'
-expectations = TestExpectations(runner._port, tests=[test, leak_test])
+timeout_test = 'failures/expected/timeout.html'
+expectations = TestExpectations(runner._port, tests=[test, leak_test, timeout_test])
 expectations.parse_all_expectations()
 runner._expectations = expectations
 
@@ -148,6 +149,24 @@
 self.assertEqual(1, runner._current_run_results.expected)
 self.assertEqual(0, runner._current_run_results.unexpected)
 
+runner._current_run_results = TestRunResults(expectations, 3)
+result = TestResult(timeout_test, failures=[])
+runner.update_summary_with_result(result)
+self.assertEqual(0, runner._current_run_results.expected)
+self.assertEqual(1, runner._current_run_results.unexpected)
+result = TestResult(timeout_test, failures=[test_failures.FailureTextMismatch()])
+runner.update_summary_with_result(result)
+self.assertEqual(0, runner._current_run_results.expected)
+self.assertEqual(2, runner._current_run_results.unexpected)
+result = TestResult(timeout_test, failures=[])
+runner.update_summary_with_result(result)
+self.assertEqual(0, runner._current_run_results.expected)
+self.assertEqual(3, runner._current_run_results.unexpected)
+result = TestResult(timeout_test, failures=[])
+runner.update_summary_with_result(result)
+self.assertEqual(0, runner._current_run_results.expected)
+self.assertEqual(4, runner._current_run_results.unexpected)
+
 def test_servers_started(self):
 
 def start_http_server():


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (284226 => 284227)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2021-10-15 02:02:14 UTC (rev 284226)
+++

[webkit-changes] [283497] trunk/LayoutTests

2021-10-04 Thread lmoura

Title: [283497] trunk/LayoutTests








Revision 283497
Author lmo...@igalia.com
Date 2021-10-04 08:00:03 -0700 (Mon, 04 Oct 2021)


Log Message
Make preload referrer-img.py compatible with Python 3.9
https://bugs.webkit.org/show_bug.cgi?id=231099

Reviewed by Jonathan Bedard.

Python 3.9 removed[1] the deprecated `base64.decodestring`. We should use
`base64.decodebytes` instead (available since 3.1).

[1] https://bugs.python.org/issue39351

* http/wpt/preload/resources/referrer-img.py: Replace deprecated method.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/preload/resources/referrer-img.py




Diff

Modified: trunk/LayoutTests/ChangeLog (283496 => 283497)

--- trunk/LayoutTests/ChangeLog	2021-10-04 14:50:57 UTC (rev 283496)
+++ trunk/LayoutTests/ChangeLog	2021-10-04 15:00:03 UTC (rev 283497)
@@ -1,3 +1,17 @@
+2021-10-04  Lauro Moura  
+
+Make preload referrer-img.py compatible with Python 3.9
+https://bugs.webkit.org/show_bug.cgi?id=231099
+
+Reviewed by Jonathan Bedard.
+
+Python 3.9 removed[1] the deprecated `base64.decodestring`. We should use
+`base64.decodebytes` instead (available since 3.1).
+
+[1] https://bugs.python.org/issue39351
+
+* http/wpt/preload/resources/referrer-img.py: Replace deprecated method.
+
 2021-10-04  Alan Bujtas  
 
 'overflow-wrap: anywhere' should be considered when calculating min-content intrinsic sizes.


Modified: trunk/LayoutTests/http/wpt/preload/resources/referrer-img.py (283496 => 283497)

--- trunk/LayoutTests/http/wpt/preload/resources/referrer-img.py	2021-10-04 14:50:57 UTC (rev 283496)
+++ trunk/LayoutTests/http/wpt/preload/resources/referrer-img.py	2021-10-04 15:00:03 UTC (rev 283497)
@@ -1,7 +1,7 @@
-from base64 import decodestring
+from base64 import decodebytes
 import time
 
-png_response = decodestring(b'iVBORw0KGgoNSUhEUgEBCAA6fptVCklEQVR4nGNiBgADNjd8qABJRU5ErkJggg==')
+png_response = decodebytes(b'iVBORw0KGgoNSUhEUgEBCAA6fptVCklEQVR4nGNiBgADNjd8qABJRU5ErkJggg==')
 
 def main(request, response):
 referrer = request.headers.get(b"Referer", b"")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283496] trunk/Source/WebCore

2021-10-04 Thread lmoura

Title: [283496] trunk/Source/WebCore








Revision 283496
Author lmo...@igalia.com
Date 2021-10-04 07:50:57 -0700 (Mon, 04 Oct 2021)


Log Message
Fix LTS build after 242443@main

Unreviewed build fix.

* rendering/RenderBlockFlow.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (283495 => 283496)

--- trunk/Source/WebCore/ChangeLog	2021-10-04 14:26:18 UTC (rev 283495)
+++ trunk/Source/WebCore/ChangeLog	2021-10-04 14:50:57 UTC (rev 283496)
@@ -1,3 +1,11 @@
+2021-10-04  Lauro Moura  
+
+Fix LTS build after 242443@main
+
+Unreviewed build fix.
+
+* rendering/RenderBlockFlow.cpp:
+
 2021-10-04  Alan Bujtas  
 
 'overflow-wrap: anywhere' should be considered when calculating min-content intrinsic sizes.


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (283495 => 283496)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2021-10-04 14:26:18 UTC (rev 283495)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2021-10-04 14:50:57 UTC (rev 283496)
@@ -35,6 +35,7 @@
 #include "HitTestLocation.h"
 #include "InlineIteratorBox.h"
 #include "InlineIteratorLine.h"
+#include "InlineIteratorTextBox.h"
 #include "InlineWalker.h"
 #include "LayoutIntegrationLineLayout.h"
 #include "LayoutRepainter.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283487] trunk/Source/WebKit

2021-10-03 Thread lmoura

Title: [283487] trunk/Source/WebKit








Revision 283487
Author lmo...@igalia.com
Date 2021-10-03 22:37:08 -0700 (Sun, 03 Oct 2021)


Log Message
[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
https://bugs.webkit.org/show_bug.cgi?id=231153

Reviewed by Alexey Proskuryakov.

Revert back to the previous NOP behavior of bindAccessibilityTree()
for GTK4, leaving the assert for the debug mode with an informative
message in the log.

Covered by existing tests.

* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (283486 => 283487)

--- trunk/Source/WebKit/ChangeLog	2021-10-04 04:34:43 UTC (rev 283486)
+++ trunk/Source/WebKit/ChangeLog	2021-10-04 05:37:08 UTC (rev 283487)
@@ -1,3 +1,19 @@
+2021-10-03  Lauro Moura  
+
+[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
+https://bugs.webkit.org/show_bug.cgi?id=231153
+
+Reviewed by Alexey Proskuryakov.
+
+Revert back to the previous NOP behavior of bindAccessibilityTree()
+for GTK4, leaving the assert for the debug mode with an informative
+message in the log.
+
+Covered by existing tests.
+
+* UIProcess/gtk/WebPageProxyGtk.cpp:
+(WebKit::WebPageProxy::bindAccessibilityTree):
+
 2021-10-03  Don Olmstead  
 
 Non-unified build fixes, early October 2021 edition


Modified: trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp (283486 => 283487)

--- trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp	2021-10-04 04:34:43 UTC (rev 283486)
+++ trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp	2021-10-04 05:37:08 UTC (rev 283487)
@@ -53,7 +53,7 @@
 {
 #if USE(GTK4)
 // FIXME: We need a way to override accessible interface of WebView and send the atspi reference to the web process.
-RELEASE_ASSERT_NOT_REACHED();
+ASSERT_NOT_IMPLEMENTED_YET();
 #else
 auto* accessible = gtk_widget_get_accessible(viewWidget());
 atk_socket_embed(ATK_SOCKET(accessible), const_cast(plugID.utf8().data()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283479] trunk/Source/JavaScriptCore

2021-10-03 Thread lmoura

Title: [283479] trunk/Source/_javascript_Core








Revision 283479
Author lmo...@igalia.com
Date 2021-10-03 14:03:52 -0700 (Sun, 03 Oct 2021)


Log Message
Remove control reaches end of non-void function warning

Unreviewed. Warning introduced in r283139.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::isConstantOwnedByUnlinkedCodeBlock const):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (283478 => 283479)

--- trunk/Source/_javascript_Core/ChangeLog	2021-10-03 21:02:20 UTC (rev 283478)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-03 21:03:52 UTC (rev 283479)
@@ -1,3 +1,12 @@
+2021-10-03  Lauro Moura  
+
+Remove control reaches end of non-void function warning
+
+Unreviewed. Warning introduced in r283139.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::isConstantOwnedByUnlinkedCodeBlock const):
+
 2021-10-02  Yusuke Suzuki  
 
 [JSC] DateTimeFormat.resolvedOptions shouldn't return an object with other date/time properties if dateStyle or timeStyle are set


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (283478 => 283479)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2021-10-03 21:02:20 UTC (rev 283478)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2021-10-03 21:03:52 UTC (rev 283479)
@@ -938,6 +938,8 @@
 }
 case SourceCodeRepresentation::LinkTimeConstant:
 return false;
+default:
+RELEASE_ASSERT_NOT_REACHED();
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283432] trunk/Source/WebCore

2021-10-01 Thread lmoura

Title: [283432] trunk/Source/WebCore








Revision 283432
Author lmo...@igalia.com
Date 2021-10-01 20:21:43 -0700 (Fri, 01 Oct 2021)


Log Message
[GLIB] Fix build on Ubuntu 20.04 after 242376@main

Unreviewed build fix.

* dom/Position.cpp: Add missing header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (283431 => 283432)

--- trunk/Source/WebCore/ChangeLog	2021-10-02 02:48:04 UTC (rev 283431)
+++ trunk/Source/WebCore/ChangeLog	2021-10-02 03:21:43 UTC (rev 283432)
@@ -1,3 +1,11 @@
+2021-10-01  Lauro Moura  
+
+[GLIB] Fix build on Ubuntu 20.04 after 242376@main
+
+Unreviewed build fix.
+
+* dom/Position.cpp: Add missing header.
+
 2021-10-01  Chris Dumez  
 
 Drop support for macOS < 10.15


Modified: trunk/Source/WebCore/dom/Position.cpp (283431 => 283432)

--- trunk/Source/WebCore/dom/Position.cpp	2021-10-02 02:48:04 UTC (rev 283431)
+++ trunk/Source/WebCore/dom/Position.cpp	2021-10-02 03:21:43 UTC (rev 283432)
@@ -43,6 +43,7 @@
 #include "NodeTraversal.h"
 #include "PositionIterator.h"
 #include "RenderBlock.h"
+#include "RenderBlockFlow.h"
 #include "RenderFlexibleBox.h"
 #include "RenderGrid.h"
 #include "RenderInline.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283407] trunk/LayoutTests

2021-10-01 Thread lmoura

Title: [283407] trunk/LayoutTests








Revision 283407
Author lmo...@igalia.com
Date 2021-10-01 14:51:26 -0700 (Fri, 01 Oct 2021)


Log Message
[GLIB] A few more rebaselines

Unreviewed test gardening.

svg/zoom/page manually tested and working on GTK.

* platform/gtk/TestExpectations:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
* platform/wpe/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/wpe/svg/hixie/intrinsic/003-expected.txt:
* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
trunk/LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
trunk/LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
trunk/LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
trunk/LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
trunk/LayoutTests/platform/wpe/svg/custom/svg-fonts-without-missing-glyph-expected.txt
trunk/LayoutTests/platform/wpe/svg/hixie/intrinsic/003-expected.txt
trunk/LayoutTests/platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
trunk/LayoutTests/platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
trunk/LayoutTests/platform/wpe/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (283406 => 283407)

--- trunk/LayoutTests/ChangeLog	2021-10-01 21:47:22 UTC (rev 283406)
+++ trunk/LayoutTests/ChangeLog	2021-10-01 21:51:26 UTC (rev 283407)
@@ -1,3 +1,25 @@
+2021-10-01  Lauro Moura  
+
+[GLIB] A few more rebaselines
+
+Unreviewed test gardening.
+
+svg/zoom/page manually tested and working on GTK.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
+* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
+* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
+* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
+* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
+* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
+* platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
+* platform/wpe/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
+* platform/wpe/svg/hixie/intrinsic/003-expected.txt:
+* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
+* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
+* platform/wpe/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
+
 2021-10-01  Ayumi Kojima  
 
 [BigSur wk2 Debug] webgl/1.0.3/conformance/glsl/constructors/glsl-construct-bvec2.html is a flaky timeout.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (283406 => 283407)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2021-10-01 21:47:22 UTC (rev 283406)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2021-10-01 21:51:26 UTC (rev 283407)
@@ -1686,10 +1686,6 @@
 
 webkit.org/b/94952 platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html [ Failure ]
 
-webkit.org/b/158928 svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml [ Failure ]
-webkit.org/b/158928 svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml [ Failure ]
-webkit.org/b/158928

[webkit-changes] [283358] trunk/LayoutTests

2021-09-30 Thread lmoura

Title: [283358] trunk/LayoutTests








Revision 283358
Author lmo...@igalia.com
Date 2021-09-30 21:18:17 -0700 (Thu, 30 Sep 2021)


Log Message
[GLIB] Gardening some mediastream consistent failures

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (283357 => 283358)

--- trunk/LayoutTests/ChangeLog	2021-10-01 04:14:53 UTC (rev 283357)
+++ trunk/LayoutTests/ChangeLog	2021-10-01 04:18:17 UTC (rev 283358)
@@ -1,3 +1,12 @@
+2021-09-30  Lauro Moura  
+
+[GLIB] Gardening some mediastream consistent failures
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-09-30  Sihui Liu  
 
 Make File System Access API available in Worker


Modified: trunk/LayoutTests/platform/glib/TestExpectations (283357 => 283358)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-10-01 04:14:53 UTC (rev 283357)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-10-01 04:18:17 UTC (rev 283358)
@@ -656,6 +656,11 @@
 webkit.org/b/230415 fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ]
 webkit.org/b/187603 fast/mediastream/media-stream-track-source-failure.html [ Timeout Failure Pass ]
+webkit.org/b/231057 fast/mediastream/media-stream-video-track-interrupted.html [ Failure ]
+# Not exactly GStreamer (missing helper method to take viewport screenshot)
+webkit.org/b/231059 fast/mediastream/video-rotation-gpu-process-crash.html [ Failure ]
+webkit.org/b/231059 fast/mediastream/video-rotation.html [ Failure ]
+webkit.org/b/231061 fast/mediastream/captureStream/canvas3d.html [ Timeout ]
 
 webkit.org/b/223508 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure Pass ]
 


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (283357 => 283358)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-10-01 04:14:53 UTC (rev 283357)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-10-01 04:18:17 UTC (rev 283358)
@@ -232,6 +232,9 @@
 webkit.org/b/212145 http/tests/navigation/no-referrer-reset.html [ Timeout ]
 webkit.org/b/212145 http/tests/navigation/no-referrer-target-blank.html [ Timeout ]
 
+# Mediastream
+webkit.org/b/213202 fast/mediastream/getUserMedia-grant-persistency3.html [ Failure ]
+
 # Media Queries
 webkit.org/b/226521 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/source-media-outside-doc.html [ Pass Failure ]
 webkit.org/b/226521 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/source-media-outside-doc.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283118] trunk/LayoutTests

2021-09-27 Thread lmoura

Title: [283118] trunk/LayoutTests








Revision 283118
Author lmo...@igalia.com
Date 2021-09-27 09:12:27 -0700 (Mon, 27 Sep 2021)


Log Message
Garden passing flexbox abspos tests since updated in 242101@main

Unreviewed test gardening.

These tests are passing in all platforms according to
results.webkit.org.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (283117 => 283118)

--- trunk/LayoutTests/ChangeLog	2021-09-27 16:09:30 UTC (rev 283117)
+++ trunk/LayoutTests/ChangeLog	2021-09-27 16:12:27 UTC (rev 283118)
@@ -1,3 +1,14 @@
+2021-09-27  Lauro Moura  
+
+Garden passing flexbox abspos tests since updated in 242101@main
+
+Unreviewed test gardening.
+
+These tests are passing in all platforms according to
+results.webkit.org.
+
+* TestExpectations:
+
 2021-09-27  Eric Hutchison  
 
 [ Catalina BigSur wk1 Debug ] media/track/audio-track.html is a flaky crash.


Modified: trunk/LayoutTests/TestExpectations (283117 => 283118)

--- trunk/LayoutTests/TestExpectations	2021-09-27 16:09:30 UTC (rev 283117)
+++ trunk/LayoutTests/TestExpectations	2021-09-27 16:12:27 UTC (rev 283118)
@@ -4220,44 +4220,8 @@
 webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/scrollbars.html [ ImageOnlyFailure ]
 
 # Static position alignment in Flexbox.
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-002.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-003.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-004.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-005.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-006.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-007.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-008.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-rtl-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-rtl-002.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-vertWM-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-content-vertWM-002.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-002.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-003.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-004.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-005.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-006.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-007.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-008.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-rtl-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-rtl-002.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-rtl-003.html [ ImageOnlyFailure ]
-webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-rtl-004.html [ ImageOnlyFailure ]
 webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-safe-001.html [ ImageOnlyFailure ]
-webkit.org/b/221472

[webkit-changes] [283094] trunk/LayoutTests

2021-09-26 Thread lmoura

Title: [283094] trunk/LayoutTests








Revision 283094
Author lmo...@igalia.com
Date 2021-09-26 20:01:05 -0700 (Sun, 26 Sep 2021)


Log Message
[WPE] Rebaseline a number of text-only failures

Unreviewed test gardening.

Most are 1-pixel differences after some recent LFC-related commits.

* platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt:
* platform/glib/fast/encoding/charset-replacement-expected.txt:
* platform/wpe/TestExpectations:
* platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
* platform/wpe/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
* platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
* platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/wpe/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
* platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
* platform/wpe/css2.1/t0905-c414-flt-02-c-expected.txt:
* platform/wpe/css2.1/t0905-c414-flt-03-c-expected.txt:
* platform/wpe/css2.1/t0905-c414-flt-04-c-expected.txt:
* platform/wpe/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-flthw-00-c-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
* platform/wpe/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
* platform/wpe/css2.1/t0905-c5526-flthw-00-c-g-expected.txt:
* platform/wpe/css2.1/t090501-c414-flt-01-b-expected.txt:
* platform/wpe/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
* platform/wpe/css2.1/t1202-counter-04-b-expected.txt:
* platform/wpe/css2.1/t1202-counter-09-b-expected.txt:
* platform/wpe/css2.1/t1202-counters-04-b-expected.txt:
* platform/wpe/css2.1/t1202-counters-09-b-expected.txt:
* platform/wpe/fast/attachment/attachment-select-on-click-expected.txt:
* platform/wpe/fast/attachment/attachment-select-on-click-inside-user-select-all-expected.txt:
* platform/wpe/fast/borders/rtl-border-05-expected.txt:
* platform/wpe/fast/css/font-face-implicit-local-font-expected.txt:
* platform/wpe/fast/css/font-face-locally-installed-expected.txt:
* platform/wpe/fast/css/font-face-opentype-expected.txt:
* platform/wpe/fast/css/font-face-unicode-range-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt
trunk/LayoutTests/platform/glib/fast/encoding/charset-replacement-expected.txt
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5519-brdr-r-00-a-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-brdr-l-00-a-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-02-c-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-03-c-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-04-c-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltblck-01-d-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-flthw-00-c-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5525-fltwrap-00-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t0905-c5526-flthw-00-c-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t090501-c414-flt-01-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1202-counter-04-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1202-counter-09-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1202-counters-04-b-expected.txt
trunk/LayoutTests/platform/wpe/css2.1/t1202-counters-09-b-expected.txt
trunk/LayoutTests/platform/wpe/fast/attachment/attachment-select-on-click-expected.txt
trunk/LayoutTests/platform/wpe/fast/attachment/attachment-select-on-click-inside-user-select-all-expected.txt
trunk/LayoutTests/platform/wpe/fast/borders/rtl-border-05-expected.txt
trunk/LayoutTests/platform/wpe/fast/css/font-face-implicit-local-font-expected.txt

[webkit-changes] [283092] trunk/LayoutTests

2021-09-26 Thread lmoura

Title: [283092] trunk/LayoutTests








Revision 283092
Author lmo...@igalia.com
Date 2021-09-26 18:28:28 -0700 (Sun, 26 Sep 2021)


Log Message
[GLIB] Update baselines after 242013@main

Unreviewed test gardening.

These tests were updated to use the application bundle ID, which is
not used by the GLIB ports.

* platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt: Added.
* platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/glib/http/tests/contentextensions/
trunk/LayoutTests/platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt
trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (283091 => 283092)

--- trunk/LayoutTests/ChangeLog	2021-09-26 21:38:01 UTC (rev 283091)
+++ trunk/LayoutTests/ChangeLog	2021-09-27 01:28:28 UTC (rev 283092)
@@ -1,3 +1,27 @@
+2021-09-26  Lauro Moura  
+
+[GLIB] Update baselines after 242013@main
+
+Unreviewed test gardening.
+
+These tests were updated to use the application bundle ID, which is
+not used by the GLIB ports.
+
+* platform/glib/http/tests/contentextensions/block-private-click-measurement-expected.txt: Added.
+* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Added.
+* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Added.
+* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Added.
+*

[webkit-changes] [283085] trunk/Tools

2021-09-25 Thread lmoura

Title: [283085] trunk/Tools








Revision 283085
Author lmo...@igalia.com
Date 2021-09-25 21:31:22 -0700 (Sat, 25 Sep 2021)


Log Message
[GLIB] Use less parallel webviews in the uri-scheme API test for WPE and debug builds
https://bugs.webkit.org/show_bug.cgi?id=230783

Reviewed by Michael Catanzaro.

The WPE bots are timing out due to the reasons already mentioned in
bug230556 and bug229116, and GTK-Debug is flaky timing out.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextURIScheme):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp




Diff

Modified: trunk/Tools/ChangeLog (283084 => 283085)

--- trunk/Tools/ChangeLog	2021-09-25 22:00:38 UTC (rev 283084)
+++ trunk/Tools/ChangeLog	2021-09-26 04:31:22 UTC (rev 283085)
@@ -1,3 +1,16 @@
+2021-09-25  Lauro Moura  
+
+[GLIB] Use less parallel webviews in the uri-scheme API test for WPE and debug builds
+https://bugs.webkit.org/show_bug.cgi?id=230783
+
+Reviewed by Michael Catanzaro.
+
+The WPE bots are timing out due to the reasons already mentioned in
+bug230556 and bug229116, and GTK-Debug is flaky timing out.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
+(testWebContextURIScheme):
+
 2021-09-24  Jonathan Bedard  
 
 [run-webkit-tests] Use Python 3 (Revert)


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp (283084 => 283085)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp	2021-09-25 22:00:38 UTC (rev 283084)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp	2021-09-26 04:31:22 UTC (rev 283085)
@@ -299,7 +299,7 @@
 
 // Torture test time: make sure it still works if we issue a bunch of different requests all at
 // once. Each request should finish and return exactly the same data.
-int numIterations = 50;
+int numIterations = 25;
 GRefPtr views[numIterations];
 test->m_uriSchemeRequestCallbackUsesTestWebView = false;
 for (int i = 0; i < numIterations; i++) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283069] trunk/Source

2021-09-24 Thread lmoura

Title: [283069] trunk/Source








Revision 283069
Author lmo...@igalia.com
Date 2021-09-24 16:57:03 -0700 (Fri, 24 Sep 2021)


Log Message
Non-unified partial build fixes late September edition
https://bugs.webkit.org/show_bug.cgi?id=230763

Unreviewed non-unified build fixes.

Source/WebCore:

Covered by existing tests.


* Modules/cache/WorkerCacheStorageConnection.h: Add missing header.
* Modules/filesystemaccess/FileSystemHandle.cpp: Ditto.
* css/CSSFontPaletteValuesOverrideColorValue.h: Ditto.
* css/CSSFontPaletteValuesRule.cpp: Ditto.
* css/CSSFontPaletteValuesRule.h: Ditto.
* css/parser/CSSParserImpl.cpp: Ditto.
* css/typedom/CSSStyleValueFactory.cpp: Ditto.
* css/typedom/CSSStyleValueFactory.h: Ditto.
* loader/CrossOriginEmbedderPolicy.cpp: Ditto.
* loader/PingLoader.h: Ditto.
* platform/Scrollbar.cpp: Ditto.
* rendering/TextBoxPainter.cpp: Ditto.
* workers/SharedWorker.cpp: Ditto.
* workers/SharedWorkerGlobalScope.cpp: Ditto.
* workers/WorkerScriptLoaderClient.h: Ditto.

Source/WebKit:


* NetworkProcess/NetworkProcess.cpp: Add missing header.
* NetworkProcess/storage/FileSystemStorageHandleRegistry.cpp: Ditto.
* NetworkProcess/storage/FileSystemStorageManager.cpp: Ditto.
* NetworkProcess/storage/OriginStorageManager.h: Ditto.
* WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp: Add missing header.
(WebKit::RTCDataChannelRemoteManager::detectError): WebCore namespace.
(WebKit::RTCDataChannelRemoteManager::RemoteSourceConnection::didDetectError): Ditto.
* WebProcess/WebCoreSupport/WebStorageConnection.cpp: Add missing
header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp
trunk/Source/WebCore/css/CSSFontPaletteValuesOverrideColorValue.h
trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp
trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h
trunk/Source/WebCore/css/parser/CSSParserImpl.cpp
trunk/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
trunk/Source/WebCore/css/typedom/CSSStyleValueFactory.h
trunk/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
trunk/Source/WebCore/loader/PingLoader.h
trunk/Source/WebCore/platform/Scrollbar.cpp
trunk/Source/WebCore/rendering/TextBoxPainter.cpp
trunk/Source/WebCore/workers/SharedWorker.cpp
trunk/Source/WebCore/workers/SharedWorkerGlobalScope.cpp
trunk/Source/WebCore/workers/WorkerScriptLoaderClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandleRegistry.cpp
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageManager.cpp
trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.h
trunk/Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebStorageConnection.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (283068 => 283069)

--- trunk/Source/WebCore/ChangeLog	2021-09-24 23:49:29 UTC (rev 283068)
+++ trunk/Source/WebCore/ChangeLog	2021-09-24 23:57:03 UTC (rev 283069)
@@ -1,3 +1,28 @@
+2021-09-24  Lauro Moura  
+
+Non-unified partial build fixes late September edition
+https://bugs.webkit.org/show_bug.cgi?id=230763
+
+Unreviewed non-unified build fixes.
+
+Covered by existing tests.
+
+* Modules/cache/WorkerCacheStorageConnection.h: Add missing header.
+* Modules/filesystemaccess/FileSystemHandle.cpp: Ditto.
+* css/CSSFontPaletteValuesOverrideColorValue.h: Ditto.
+* css/CSSFontPaletteValuesRule.cpp: Ditto.
+* css/CSSFontPaletteValuesRule.h: Ditto.
+* css/parser/CSSParserImpl.cpp: Ditto.
+* css/typedom/CSSStyleValueFactory.cpp: Ditto.
+* css/typedom/CSSStyleValueFactory.h: Ditto.
+* loader/CrossOriginEmbedderPolicy.cpp: Ditto.
+* loader/PingLoader.h: Ditto.
+* platform/Scrollbar.cpp: Ditto.
+* rendering/TextBoxPainter.cpp: Ditto.
+* workers/SharedWorker.cpp: Ditto.
+* workers/SharedWorkerGlobalScope.cpp: Ditto.
+* workers/WorkerScriptLoaderClient.h: Ditto.
+
 2021-09-24  Simon Fraser  
 
 Have ScrollingEffectsController drive all the ScrollAnimations


Modified: trunk/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h (283068 => 283069)

--- trunk/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h	2021-09-24 23:49:29 UTC (rev 283068)
+++ trunk/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h	2021-09-24 23:57:03 UTC (rev 283069)
@@ -28,6 +28,8 @@
 
 #include "CacheStorageConnection.h"
 
+#include "ResourceRequest.h"
+
 namespace WebCore {
 
 class WorkerGlobalScope;


Modified: trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp (283068 => 283069)

--- trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp	2021-09-24 23:49:29 UTC (rev 283068)
+++ trunk/Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp

[webkit-changes] [282654] trunk/Tools

2021-09-17 Thread lmoura

Title: [282654] trunk/Tools








Revision 282654
Author lmo...@igalia.com
Date 2021-09-17 04:02:51 -0700 (Fri, 17 Sep 2021)


Log Message
REGRESSION(r275267) [GLIB] API test /webkit/WebKitWebsiteData/configuration is failing
https://bugs.webkit.org/show_bug.cgi?id=224175

Reviewed by Carlos Garcia Campos.

Some WebsiteData tests rely on checking whether some specific files
are created in the background. Currently, this is done through
waitUntilFileChanged(), which first g_file_query() whether the file
exists before entering a main loop which uses GFileMonitor. While this
worked most of the time, some tests were flaky due to likely the file
being created between the query call and the monitoring starting,
especially after revisions like r275267.

This commit replaces the waitUntilFileChanged calls with an explicit
check loop, like was done for the applicationCache file in the
configuration test.

Also, for the ITP test, there's no need to check for the file to be
deleted, as the ResourceLoadStatistics just clears the database and
recreates the schema, reusing the existing file.

Covered by existing tests.

* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration):
(testWebsiteDataITP):
(testWebsiteDataDOMCache):
* TestWebKitAPI/glib/TestExpectations.json:
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::assertFileIsCreated):
(WebViewTest::assertJavaScriptBecomesTrue):
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.h




Diff

Modified: trunk/Tools/ChangeLog (282653 => 282654)

--- trunk/Tools/ChangeLog	2021-09-17 10:33:33 UTC (rev 282653)
+++ trunk/Tools/ChangeLog	2021-09-17 11:02:51 UTC (rev 282654)
@@ -1,3 +1,38 @@
+2021-09-17  Lauro Moura  
+
+REGRESSION(r275267) [GLIB] API test /webkit/WebKitWebsiteData/configuration is failing
+https://bugs.webkit.org/show_bug.cgi?id=224175
+
+Reviewed by Carlos Garcia Campos.
+
+Some WebsiteData tests rely on checking whether some specific files
+are created in the background. Currently, this is done through
+waitUntilFileChanged(), which first g_file_query() whether the file
+exists before entering a main loop which uses GFileMonitor. While this
+worked most of the time, some tests were flaky due to likely the file
+being created between the query call and the monitoring starting,
+especially after revisions like r275267.
+
+This commit replaces the waitUntilFileChanged calls with an explicit
+check loop, like was done for the applicationCache file in the
+configuration test.
+
+Also, for the ITP test, there's no need to check for the file to be
+deleted, as the ResourceLoadStatistics just clears the database and
+recreates the schema, reusing the existing file.
+
+Covered by existing tests.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+(testWebsiteDataConfiguration):
+(testWebsiteDataITP):
+(testWebsiteDataDOMCache):
+* TestWebKitAPI/glib/TestExpectations.json:
+* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
+(WebViewTest::assertFileIsCreated):
+(WebViewTest::assertJavaScriptBecomesTrue):
+* TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
+
 2021-09-17  Carlos Garcia Campos  
 
 [GTK][a11y] Add a build option to enable ATSPI


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (282653 => 282654)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2021-09-17 10:33:33 UTC (rev 282653)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2021-09-17 11:02:51 UTC (rev 282654)
@@ -174,7 +174,7 @@
 test->waitUntilLoadFinished();
 test->runJavaScriptAndWaitUntilFinished("window.indexedDB.open('TestDatabase');", nullptr);
 GUniquePtr indexedDBDirectory(g_build_filename(Test::dataDirectory(), "indexeddb", nullptr));
-test->waitUntilFileChanged(indexedDBDirectory.get(), G_FILE_MONITOR_EVENT_CREATED);
+test->assertFileIsCreated(indexedDBDirectory.get());
 g_assert_cmpstr(indexedDBDirectory.get(), ==, webkit_website_data_manager_get_indexeddb_directory(test->m_manager));
 g_assert_true(g_file_test(indexedDBDirectory.get(), G_FILE_TEST_IS_DIR));
 
@@ -183,10 +183,7 @@
 GUniquePtr applicationCacheDirectory(g_build_filename(Test::dataDirectory(), "appcache", nullptr));
 g_assert_cmpstr(applicationCacheDirectory.get(), ==, webkit_website_data_manager_get_offline_application_cache_directory(test->m_manager));
 GUniquePtr applicationCacheDatabase(g_build_filename(applicationCacheDirectory.get(), "ApplicationCache.db", nullptr));
-unsigned triesCount = 4;
-

[webkit-changes] [282140] trunk/Tools

2021-09-08 Thread lmoura

Title: [282140] trunk/Tools








Revision 282140
Author lmo...@igalia.com
Date 2021-09-08 05:56:13 -0700 (Wed, 08 Sep 2021)


Log Message
[GTK] Fix test path in last commit

Unreviewed test gardening.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (282139 => 282140)

--- trunk/Tools/ChangeLog	2021-09-08 12:52:04 UTC (rev 282139)
+++ trunk/Tools/ChangeLog	2021-09-08 12:56:13 UTC (rev 282140)
@@ -1,5 +1,13 @@
 2021-09-08  Lauro Moura  
 
+[GTK] Fix test path in last commit
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
+2021-09-08  Lauro Moura  
+
 [GTK] Garden default-menu API test failure
 
 Unreviewed test gardening.


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (282139 => 282140)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-08 12:52:04 UTC (rev 282139)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-08 12:56:13 UTC (rev 282140)
@@ -302,7 +302,7 @@
 "gtk": {"status": ["FAIL"], "bug": "webkit.org/b/227020"}
 }
 },
-"/webkit/WebKitWebPage/default-menu": {
+"/webkit/WebKitWebView/default-menu": {
 "expected": {
 "gtk": {"status": ["FAIL"], "bug": "webkit.org/b/230043"}
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282139] trunk/Tools

2021-09-08 Thread lmoura

Title: [282139] trunk/Tools








Revision 282139
Author lmo...@igalia.com
Date 2021-09-08 05:52:04 -0700 (Wed, 08 Sep 2021)


Log Message
[GTK] Garden default-menu API test failure

Unreviewed test gardening.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (282138 => 282139)

--- trunk/Tools/ChangeLog	2021-09-08 11:48:25 UTC (rev 282138)
+++ trunk/Tools/ChangeLog	2021-09-08 12:52:04 UTC (rev 282139)
@@ -1,3 +1,11 @@
+2021-09-08  Lauro Moura  
+
+[GTK] Garden default-menu API test failure
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2021-09-07  Fujii Hironori  
 
 [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (282138 => 282139)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-08 11:48:25 UTC (rev 282138)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-08 12:52:04 UTC (rev 282139)
@@ -301,6 +301,11 @@
 "expected": {
 "gtk": {"status": ["FAIL"], "bug": "webkit.org/b/227020"}
 }
+},
+"/webkit/WebKitWebPage/default-menu": {
+"expected": {
+"gtk": {"status": ["FAIL"], "bug": "webkit.org/b/230043"}
+}
 }
 }
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281993] trunk/Source/WebCore

2021-09-03 Thread lmoura

Title: [281993] trunk/Source/WebCore








Revision 281993
Author lmo...@igalia.com
Date 2021-09-03 08:11:48 -0700 (Fri, 03 Sep 2021)


Log Message
[GStreamer] Update mock display resolution after Mac mock was updated
https://bugs.webkit.org/show_bug.cgi?id=229868

Reviewed by Philippe Normand.

r281880 added this test and swapped the resolutions of Mac's mock
SCREEN-1 and SCREEN-2. As r281305 did, this commit matches the
GStreamer mock with the mac one.

Fixes fast/mediastream/get-display-media-capabilities.html

* platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockDisplayCaptureSourceGStreamer::capabilities):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281992 => 281993)

--- trunk/Source/WebCore/ChangeLog	2021-09-03 15:02:22 UTC (rev 281992)
+++ trunk/Source/WebCore/ChangeLog	2021-09-03 15:11:48 UTC (rev 281993)
@@ -1,3 +1,19 @@
+2021-09-03  Lauro Moura  
+
+[GStreamer] Update mock display resolution after Mac mock was updated
+https://bugs.webkit.org/show_bug.cgi?id=229868
+
+Reviewed by Philippe Normand.
+
+r281880 added this test and swapped the resolutions of Mac's mock
+SCREEN-1 and SCREEN-2. As r281305 did, this commit matches the
+GStreamer mock with the mac one.
+
+Fixes fast/mediastream/get-display-media-capabilities.html
+
+* platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
+(WebCore::MockDisplayCaptureSourceGStreamer::capabilities):
+
 2021-09-03  Simon Fraser  
 
 Scrollbars on pointer-events: none element still intercepts events


Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp (281992 => 281993)

--- trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp	2021-09-03 15:02:22 UTC (rev 281992)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp	2021-09-03 15:11:48 UTC (rev 281993)
@@ -99,8 +99,9 @@
 RealtimeMediaSourceCapabilities capabilities(settings().supportedConstraints());
 
 // FIXME: what should these be?
-capabilities.setWidth(CapabilityValueOrRange(1, 3840));
-capabilities.setHeight(CapabilityValueOrRange(1, 2160));
+// Currently mimicking the values for SCREEN-1 in MockRealtimeMediaSourceCenter.cpp::defaultDevices()
+capabilities.setWidth(CapabilityValueOrRange(1, 1920));
+capabilities.setHeight(CapabilityValueOrRange(1, 1080));
 capabilities.setFrameRate(CapabilityValueOrRange(.01, 30.0));
 
 m_capabilities = WTFMove(capabilities);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281977] trunk/Tools

2021-09-02 Thread lmoura

Title: [281977] trunk/Tools








Revision 281977
Author lmo...@igalia.com
Date 2021-09-02 20:36:18 -0700 (Thu, 02 Sep 2021)


Log Message
[GLIB] Install lcms2 in helper dependencies script
https://bugs.webkit.org/show_bug.cgi?id=229173

Reviewed by Carlos Alberto Lopez Perez.

lcms2 support is enabled by default since r274273.

* glib/dependencies/apt:
* glib/dependencies/dnf:
* glib/dependencies/pacman:
* gtk/dependencies/brew:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/glib/dependencies/apt
trunk/Tools/glib/dependencies/dnf
trunk/Tools/glib/dependencies/pacman
trunk/Tools/gtk/dependencies/brew




Diff

Modified: trunk/Tools/ChangeLog (281976 => 281977)

--- trunk/Tools/ChangeLog	2021-09-03 03:28:05 UTC (rev 281976)
+++ trunk/Tools/ChangeLog	2021-09-03 03:36:18 UTC (rev 281977)
@@ -1,5 +1,19 @@
 2021-09-02  Lauro Moura  
 
+[GLIB] Install lcms2 in helper dependencies script
+https://bugs.webkit.org/show_bug.cgi?id=229173
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+lcms2 support is enabled by default since r274273.
+
+* glib/dependencies/apt:
+* glib/dependencies/dnf:
+* glib/dependencies/pacman:
+* gtk/dependencies/brew:
+
+2021-09-02  Lauro Moura  
+
 [WPE] form-submission-steps API test is also flaky timing out like GTK
 
 Unreviewed test gardening.


Modified: trunk/Tools/glib/dependencies/apt (281976 => 281977)

--- trunk/Tools/glib/dependencies/apt	2021-09-03 03:28:05 UTC (rev 281976)
+++ trunk/Tools/glib/dependencies/apt	2021-09-03 03:36:18 UTC (rev 281977)
@@ -34,6 +34,7 @@
 libgstreamer-plugins-base1.0-dev
 libjpeg-dev
 libkate-dev
+liblcms2-dev
 libopenjp2-7-dev
 libpng-dev
 libseccomp-dev


Modified: trunk/Tools/glib/dependencies/dnf (281976 => 281977)

--- trunk/Tools/glib/dependencies/dnf	2021-09-03 03:28:05 UTC (rev 281976)
+++ trunk/Tools/glib/dependencies/dnf	2021-09-03 03:36:18 UTC (rev 281977)
@@ -14,6 +14,7 @@
 gstreamer1-plugins-base-devel
 gtk-doc
 intltool
+lcms2-devel
 libevent-devel
 libjpeg-turbo-devel
 libkate-devel


Modified: trunk/Tools/glib/dependencies/pacman (281976 => 281977)

--- trunk/Tools/glib/dependencies/pacman	2021-09-03 03:28:05 UTC (rev 281976)
+++ trunk/Tools/glib/dependencies/pacman	2021-09-03 03:36:18 UTC (rev 281977)
@@ -20,6 +20,7 @@
 gzip
 intltool
 itstool
+lcms2
 libevent
 libjpeg-turbo
 libkate


Modified: trunk/Tools/gtk/dependencies/brew (281976 => 281977)

--- trunk/Tools/gtk/dependencies/brew	2021-09-03 03:28:05 UTC (rev 281976)
+++ trunk/Tools/gtk/dependencies/brew	2021-09-03 03:36:18 UTC (rev 281977)
@@ -15,6 +15,7 @@
 libtasn1
 libtiff
 libtool
+little-cms2
 ninja
 pango
 pkg-config






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281974] trunk/Tools

2021-09-02 Thread lmoura

Title: [281974] trunk/Tools








Revision 281974
Author lmo...@igalia.com
Date 2021-09-02 19:53:23 -0700 (Thu, 02 Sep 2021)


Log Message
[WPE] form-submission-steps API test is also flaky timing out like GTK

Unreviewed test gardening.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (281973 => 281974)

--- trunk/Tools/ChangeLog	2021-09-03 02:21:53 UTC (rev 281973)
+++ trunk/Tools/ChangeLog	2021-09-03 02:53:23 UTC (rev 281974)
@@ -1,3 +1,11 @@
+2021-09-02  Lauro Moura  
+
+[WPE] form-submission-steps API test is also flaky timing out like GTK
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2021-09-02  Jonathan Bedard  
 
 [webkit-patch] apply-watchlist command fails on python 3 (Follow-up fix)


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (281973 => 281974)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-03 02:21:53 UTC (rev 281973)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-03 02:53:23 UTC (rev 281974)
@@ -83,7 +83,7 @@
 }
 },
 "/webkit/WebKitWebExtension/form-submission-steps": {
-"expected": {"gtk": {"status": ["TIMEOUT", "PASS"], "bug": "webkit.org/b/205333"}}
+"expected": {"all": {"status": ["TIMEOUT", "PASS"], "bug": "webkit.org/b/205333"}}
 },
 "/webkit/WebKitWebExtension/form-controls-associated-signal": {
 "expected": {"gtk": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/205380"}}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281966] trunk/Tools

2021-09-02 Thread lmoura

Title: [281966] trunk/Tools








Revision 281966
Author lmo...@igalia.com
Date 2021-09-02 16:39:39 -0700 (Thu, 02 Sep 2021)


Log Message
[GLIB] run-gtk-tests does not require GI outside the sandbox
https://bugs.webkit.org/show_bug.cgi?id=229836

Reviewed by Jonathan Bedard.

Some worker bots were failing without python3-gi installed, but it's
not required as the flatpak env provides it.

* Scripts/run-gtk-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (281965 => 281966)

--- trunk/Tools/ChangeLog	2021-09-02 23:25:16 UTC (rev 281965)
+++ trunk/Tools/ChangeLog	2021-09-02 23:39:39 UTC (rev 281966)
@@ -1,3 +1,15 @@
+2021-09-02  Lauro Moura  
+
+[GLIB] run-gtk-tests does not require GI outside the sandbox
+https://bugs.webkit.org/show_bug.cgi?id=229836
+
+Reviewed by Jonathan Bedard.
+
+Some worker bots were failing without python3-gi installed, but it's
+not required as the flatpak env provides it.
+
+* Scripts/run-gtk-tests:
+
 2021-09-02  Alex Christensen  
 
 Gracefully recover from WebAuthnProcess crashes


Modified: trunk/Tools/Scripts/run-gtk-tests (281965 => 281966)

--- trunk/Tools/Scripts/run-gtk-tests	2021-09-02 23:25:16 UTC (rev 281965)
+++ trunk/Tools/Scripts/run-gtk-tests	2021-09-02 23:39:39 UTC (rev 281966)
@@ -21,7 +21,6 @@
 import os
 import sys
 import optparse
-from gi.repository import Gio, GLib
 
 top_level_directory = os.path.normpath(os.path.join(os.path.dirname(__file__), "..", ".."))
 sys.path.insert(0, os.path.join(top_level_directory, "Tools", "flatpak"))
@@ -32,6 +31,14 @@
 import flatpakutils
 from api_test_runner import TestRunner, add_options
 
+
+try:
+from gi.repository import Gio, GLib
+except ImportError:
+# We don't require gi to be installed outside the sandbox
+if flatpakutils.is_sandboxed() or jhbuildutils.enter_jhbuild_environment_if_available("gtk"):
+raise
+
 class GtkTestRunner(TestRunner):
 TestRunner.TEST_TARGETS = [ "WebKit2Gtk", "TestWebKit", "TestJSC", "TestWTF", "TestWebCore", "TestJavaScriptCore" ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281925] trunk/Tools

2021-09-02 Thread lmoura

Title: [281925] trunk/Tools








Revision 281925
Author lmo...@igalia.com
Date 2021-09-02 08:42:27 -0700 (Thu, 02 Sep 2021)


Log Message
[webkitcorepy] Evaluate default Editor to false when not found
https://bugs.webkit.org/show_bug.cgi?id=229791

Reviewed by Jonathan Bedard.

This makes the default editor to not be listed as valid in platforms
without the open command. This was causing the tests to fail for
GTK/WPE (on Linux).

In a future commit a proper solution might be adding proper support
for $EDITOR.

* Scripts/libraries/webkitcorepy/webkitcorepy/editor.py:
(Editor.__bool__):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/editor.py




Diff

Modified: trunk/Tools/ChangeLog (281924 => 281925)

--- trunk/Tools/ChangeLog	2021-09-02 15:32:46 UTC (rev 281924)
+++ trunk/Tools/ChangeLog	2021-09-02 15:42:27 UTC (rev 281925)
@@ -1,3 +1,20 @@
+2021-09-02  Lauro Moura  
+
+[webkitcorepy] Evaluate default Editor to false when not found
+https://bugs.webkit.org/show_bug.cgi?id=229791
+
+Reviewed by Jonathan Bedard.
+
+This makes the default editor to not be listed as valid in platforms
+without the open command. This was causing the tests to fail for
+GTK/WPE (on Linux).
+
+In a future commit a proper solution might be adding proper support
+for $EDITOR.
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/editor.py:
+(Editor.__bool__):
+
 2021-09-02  Jonathan Bedard  
 
 [buildbot] Only serve content through nginx


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/editor.py (281924 => 281925)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/editor.py	2021-09-02 15:32:46 UTC (rev 281924)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/editor.py	2021-09-02 15:42:27 UTC (rev 281925)
@@ -130,4 +130,4 @@
 return self.name
 
 def __bool__(self):
-return os.path.isfile(self.path)
+return bool(self.path) and os.path.isfile(self.path)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281922] trunk/Tools

2021-09-02 Thread lmoura

Title: [281922] trunk/Tools








Revision 281922
Author lmo...@igalia.com
Date 2021-09-02 07:58:05 -0700 (Thu, 02 Sep 2021)


Log Message
[GLIB] Garden itp API test failure after r281886

Unreviewed test gardening.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (281921 => 281922)

--- trunk/Tools/ChangeLog	2021-09-02 14:50:01 UTC (rev 281921)
+++ trunk/Tools/ChangeLog	2021-09-02 14:58:05 UTC (rev 281922)
@@ -1,3 +1,11 @@
+2021-09-02  Lauro Moura  
+
+[GLIB] Garden itp API test failure after r281886
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2021-09-02  Carlos Alberto Lopez Perez  
 
 [GTK][WPE] Port API test runner to python3


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (281921 => 281922)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-02 14:50:01 UTC (rev 281921)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2021-09-02 14:58:05 UTC (rev 281922)
@@ -115,7 +115,8 @@
 },
 "/webkit/WebKitWebsiteData/itp": {
 "expected": {
-"all": {"status": ["PASS", "TIMEOUT"], "bug": "webkit.org/b/224175"}
+"all_before_bug_229807": {"status": ["PASS", "TIMEOUT"], "bug": "webkit.org/b/224175"},
+"all": {"status": ["FAIL"], "bug": "webkit.org/b/229807"}
 }
 },
 "/webkit/WebKitWebsiteData/configuration": {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281837] trunk/Source

2021-08-31 Thread lmoura

Title: [281837] trunk/Source








Revision 281837
Author lmo...@igalia.com
Date 2021-08-31 19:25:28 -0700 (Tue, 31 Aug 2021)


Log Message
Non-unified build partial fixes, late late August 2021
https://bugs.webkit.org/show_bug.cgi?id=229741

Unreviewed non-unified build fixes.

Source/_javascript_Core:


* bytecode/PutByStatus.cpp: Add missing header.
* bytecode/PutByVariant.h: Ditto.
* runtime/TemporalCalendar.cpp: Ditto.
* runtime/TemporalCalendarPrototype.cpp: Ditto.

Source/WebCore:

Still missing a strange WebCoreTestSupport.a-related link error.


* Modules/mediastream/RTCIceTransportBackend.h: Add missing header.
* Modules/mediastream/RTCPeerConnection.cpp: Ditto.
* Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp:
Ditto.
* html/FormController.cpp:
(WebCore::formSignature): Namespace HTMLNames.
* html/FormController.h: Add missing header.
* html/track/LoadableTextTrack.cpp: Add missing header.
* loader/PrivateClickMeasurement.cpp: Ditto.
* page/PageConfiguration.cpp: Ditto.

Source/WebKit:


* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
Add missing header.
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:
Add missing header.
(WebKit::PCM::Database::attributePrivateClickMeasurement): Namespace
some names.
(WebKit::PCM::Database::removeUnattributed): Ditto.
(WebKit::PCM::Database::clearPrivateClickMeasurement): Ditto.
(WebKit::PCM::Database::clearSentAttribution): Ditto.
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
Add missing header.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp
trunk/Source/_javascript_Core/bytecode/PutByVariant.h
trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp
trunk/Source/_javascript_Core/runtime/TemporalCalendarPrototype.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp
trunk/Source/WebCore/html/FormController.cpp
trunk/Source/WebCore/html/FormController.h
trunk/Source/WebCore/html/track/LoadableTextTrack.cpp
trunk/Source/WebCore/loader/PrivateClickMeasurement.cpp
trunk/Source/WebCore/page/PageConfiguration.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281836 => 281837)

--- trunk/Source/_javascript_Core/ChangeLog	2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-09-01 02:25:28 UTC (rev 281837)
@@ -1,3 +1,15 @@
+2021-08-31  Lauro Moura  
+
+Non-unified build partial fixes, late late August 2021
+https://bugs.webkit.org/show_bug.cgi?id=229741
+
+Unreviewed non-unified build fixes.
+
+* bytecode/PutByStatus.cpp: Add missing header.
+* bytecode/PutByVariant.h: Ditto.
+* runtime/TemporalCalendar.cpp: Ditto.
+* runtime/TemporalCalendarPrototype.cpp: Ditto.
+
 2021-08-31  Yusuke Suzuki  
 
 [JSC] Enable Object.hasOwn


Modified: trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp (281836 => 281837)

--- trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp	2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp	2021-09-01 02:25:28 UTC (rev 281837)
@@ -27,6 +27,7 @@
 #include "PutByStatus.h"
 
 #include "BytecodeStructs.h"
+#include "CacheableIdentifierInlines.h"
 #include "CodeBlock.h"
 #include "ComplexGetStatus.h"
 #include "GetterSetterAccessCase.h"


Modified: trunk/Source/_javascript_Core/bytecode/PutByVariant.h (281836 => 281837)

--- trunk/Source/_javascript_Core/bytecode/PutByVariant.h	2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/bytecode/PutByVariant.h	2021-09-01 02:25:28 UTC (rev 281837)
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include "CacheableIdentifier.h"
 #include "ObjectPropertyConditionSet.h"
 #include "PropertyOffset.h"
 #include "StructureSet.h"


Modified: trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp (281836 => 281837)

--- trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp	2021-09-01 01:08:07 UTC (rev 281836)
+++ trunk/Source/_javascript_Core/runtime/TemporalCalendar.cpp	2021-09-01 02:25:28 UTC (rev 281837)
@@ -26,6 +26,9 @@
 #include "config.h"
 #include "TemporalCalendar.h"
 
+#include "JSObjectInlines.h"
+#include "StructureInlines.h"
+
 namespace JSC {
 
 const ClassInfo TemporalCalendar::s_info = { "Object", ::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(TemporalCalendar) };


Modified: trunk/Source/_javascript_Core/runtime/TemporalCalendarPrototype.cpp (281836 => 281837)

---

1 2 3 4 5 >

1 - 100 of 493 matches

Mail list logo