[webkit-changes] [295750] trunk/Source/WebCore
Title: [295750] trunk/Source/WebCore
Revision 295750
Author n...@apple.com
Date 2022-06-22 15:07:32 -0700 (Wed, 22 Jun 2022)
Log Message
Rename attributeContainsJavascriptURL to attributeContainsJavaScriptURL
https://bugs.webkit.org/show_bug.cgi?id=241872
Reviewed by Wenson Hsieh.
with a capital S
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeContainsJavaScriptURL const):
(WebCore::Element::stripScriptingAttributes const):
(WebCore::Element::attributeContainsJavascriptURL const): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeContentsWithSideEffects):
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStartTag):
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeContainsJavaScriptURL const):
(WebCore::SVGAnimationElement::attributeContainsJavascriptURL const): Deleted.
* Source/WebCore/svg/SVGAnimationElement.h:
Canonical link: https://commits.webkit.org/251755@main
Modified Paths
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/svg/SVGAnimationElement.cpp
trunk/Source/WebCore/svg/SVGAnimationElement.h
Diff
Modified: trunk/Source/WebCore/dom/Element.cpp (295749 => 295750)
--- trunk/Source/WebCore/dom/Element.cpp 2022-06-22 21:41:28 UTC (rev 295749)
+++ trunk/Source/WebCore/dom/Element.cpp 2022-06-22 22:07:32 UTC (rev 295750)
@@ -2315,7 +2315,7 @@
return attribute.name().namespaceURI().isNull() && attribute.name().localName().startsWith("on"_s);
}
-bool Element::attributeContainsJavascriptURL(const Attribute& attribute) const
+bool Element::attributeContainsJavaScriptURL(const Attribute& attribute) const
{
return isURLAttribute(attribute) && WTF::protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(attribute.value()));
}
@@ -2324,7 +2324,7 @@
{
attributeVector.removeAllMatching([this](auto& attribute) -> bool {
return this->isEventHandlerAttribute(attribute)
-|| this->attributeContainsJavascriptURL(attribute)
+|| this->attributeContainsJavaScriptURL(attribute)
|| this->isHTMLContentAttribute(attribute);
});
}
Modified: trunk/Source/WebCore/dom/Element.h (295749 => 295750)
--- trunk/Source/WebCore/dom/Element.h 2022-06-22 21:41:28 UTC (rev 295749)
+++ trunk/Source/WebCore/dom/Element.h 2022-06-22 22:07:32 UTC (rev 295750)
@@ -294,7 +294,7 @@
void parserSetAttributes(const Vector&);
bool isEventHandlerAttribute(const Attribute&) const;
-virtual bool attributeContainsJavascriptURL(const Attribute&) const;
+virtual bool attributeContainsJavaScriptURL(const Attribute&) const;
// Remove attributes that might introduce scripting from the vector leaving the element unchanged.
void stripScriptingAttributes(Vector&) const;
Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (295749 => 295750)
--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2022-06-22 21:41:28 UTC (rev 295749)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2022-06-22 22:07:32 UTC (rev 295750)
@@ -238,7 +238,7 @@
}
if (element->hasAttributes()) {
for (auto& attribute : element->attributesIterator()) {
-if (element->isEventHandlerAttribute(attribute) || element->attributeContainsJavascriptURL(attribute))
+if (element->isEventHandlerAttribute(attribute) || element->attributeContainsJavaScriptURL(attribute))
attributesToRemove.append({ element.copyRef(), attribute.name() });
}
}
Modified: trunk/Source/WebCore/editing/markup.cpp (295749 => 295750)
--- trunk/Source/WebCore/editing/markup.cpp 2022-06-22 21:41:28 UTC (rev 295749)
+++ trunk/Source/WebCore/editing/markup.cpp 2022-06-22 22:07:32 UTC (rev 295750)
@@ -556,7 +556,7 @@
// We'll handle the style attribute separately, below.
if (attribute.name() == styleAttr && shouldOverrideStyleAttr)
continue;
-if (element.isEventHandlerAttribute(attribute) || element.attributeContainsJavascriptURL(attribute))
+if (element.isEventHandlerAttribute(attribute) || element.attributeContainsJavaScriptURL(attribute))
continue;
#if ENABLE(DATA_DETECTION)
if (replacementType == SpanReplacementType::DataDetector && DataDetection::isDataDetectorAttribute(attribute.name()))
Modified: trunk/Source/WebCore/svg/SVGAnimationElement.cpp (295749 => 295750)
--- trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2022-06-22 21:41:28 UTC (rev 295749)
+++ trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2022-06-22 22:07:32 UTC (rev 295750)
@@ -148,7 +148,7 @@
return supportedAttributes.get().contains(attrName);
}
-bool
[webkit-changes] [295747] trunk
Title: [295747] trunk
Revision 295747
Author n...@apple.com
Date 2022-06-22 13:11:59 -0700 (Wed, 22 Jun 2022)
Log Message
Make SVGAnimateElement respect _javascript_MarkupEnabled
https://bugs.webkit.org/show_bug.cgi?id=241820
Reviewed by Said Abou-Hallawa.
from/to/values attributes should be stripped in presence of _javascript_ URLs with the pref on.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeContainsJavascriptURL const):
(WebCore::Element::stripScriptingAttributes const):
(WebCore::Element::isJavaScriptURLAttribute const): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeContentsWithSideEffects):
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStartTag):
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeContainsJavascriptURL const):
* Source/WebCore/svg/SVGAnimationElement.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(TEST):
Canonical link: https://commits.webkit.org/251752@main
Modified Paths
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/svg/SVGAnimationElement.cpp
trunk/Source/WebCore/svg/SVGAnimationElement.h
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm
Diff
Modified: trunk/Source/WebCore/dom/Element.cpp (295746 => 295747)
--- trunk/Source/WebCore/dom/Element.cpp 2022-06-22 19:59:07 UTC (rev 295746)
+++ trunk/Source/WebCore/dom/Element.cpp 2022-06-22 20:11:59 UTC (rev 295747)
@@ -2315,7 +2315,7 @@
return attribute.name().namespaceURI().isNull() && attribute.name().localName().startsWith("on"_s);
}
-bool Element::isJavaScriptURLAttribute(const Attribute& attribute) const
+bool Element::attributeContainsJavascriptURL(const Attribute& attribute) const
{
return isURLAttribute(attribute) && WTF::protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(attribute.value()));
}
@@ -2324,7 +2324,7 @@
{
attributeVector.removeAllMatching([this](auto& attribute) -> bool {
return this->isEventHandlerAttribute(attribute)
-|| this->isJavaScriptURLAttribute(attribute)
+|| this->attributeContainsJavascriptURL(attribute)
|| this->isHTMLContentAttribute(attribute);
});
}
Modified: trunk/Source/WebCore/dom/Element.h (295746 => 295747)
--- trunk/Source/WebCore/dom/Element.h 2022-06-22 19:59:07 UTC (rev 295746)
+++ trunk/Source/WebCore/dom/Element.h 2022-06-22 20:11:59 UTC (rev 295747)
@@ -294,7 +294,7 @@
void parserSetAttributes(const Vector&);
bool isEventHandlerAttribute(const Attribute&) const;
-bool isJavaScriptURLAttribute(const Attribute&) const;
+virtual bool attributeContainsJavascriptURL(const Attribute&) const;
// Remove attributes that might introduce scripting from the vector leaving the element unchanged.
void stripScriptingAttributes(Vector&) const;
Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (295746 => 295747)
--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2022-06-22 19:59:07 UTC (rev 295746)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2022-06-22 20:11:59 UTC (rev 295747)
@@ -238,7 +238,7 @@
}
if (element->hasAttributes()) {
for (auto& attribute : element->attributesIterator()) {
-if (element->isEventHandlerAttribute(attribute) || element->isJavaScriptURLAttribute(attribute))
+if (element->isEventHandlerAttribute(attribute) || element->attributeContainsJavascriptURL(attribute))
attributesToRemove.append({ element.copyRef(), attribute.name() });
}
}
Modified: trunk/Source/WebCore/editing/markup.cpp (295746 => 295747)
--- trunk/Source/WebCore/editing/markup.cpp 2022-06-22 19:59:07 UTC (rev 295746)
+++ trunk/Source/WebCore/editing/markup.cpp 2022-06-22 20:11:59 UTC (rev 295747)
@@ -556,7 +556,7 @@
// We'll handle the style attribute separately, below.
if (attribute.name() == styleAttr && shouldOverrideStyleAttr)
continue;
-if (element.isEventHandlerAttribute(attribute) || element.isJavaScriptURLAttribute(attribute))
+if (element.isEventHandlerAttribute(attribute) || element.attributeContainsJavascriptURL(attribute))
continue;
#if ENABLE(DATA_DETECTION)
if (replacementType == SpanReplacementType::DataDetector && DataDetection::isDataDetectorAttribute(attribute.name()))
Modified: trunk/Source/WebCore/svg/SVGAnimationElement.cpp (295746 => 295747)
--- trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2022-06-22 19:59:07 UTC (rev 295746)
+++ trunk/Source/WebCore/svg/SVGAnimationElement.cpp 2022-06-22 20:11:59 UTC (rev 295747)
@@ -31,6 +31,7 @@
#include
[webkit-changes] [295541] trunk/Source/WebCore
Title: [295541] trunk/Source/WebCore
Revision 295541
Author n...@apple.com
Date 2022-06-14 15:15:59 -0700 (Tue, 14 Jun 2022)
Log Message
Remove redundant text-align-last BuilderCustom functions
https://bugs.webkit.org/show_bug.cgi?id=241607
Reviewed by Simon Fraser.
They might have been copy pasted from text-align, which needs them for the hasExplicitlySetTextAlign flag, which text-align-last does not have.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialTextAlignLast): Deleted.
(WebCore::Style::BuilderCustom::applyValueTextAlignLast): Deleted.
Canonical link: https://commits.webkit.org/251546@main
Modified Paths
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/style/StyleBuilderCustom.h
Diff
Modified: trunk/Source/WebCore/css/CSSProperties.json (295540 => 295541)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-06-14 22:14:47 UTC (rev 295540)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-06-14 22:15:59 UTC (rev 295541)
@@ -4609,7 +4609,6 @@
],
"codegen-properties": {
"converter": "TextAlignLast",
-"custom": "Initial|Value",
"settings-flag": "cssTextAlignLastEnabled"
},
"specification": {
Modified: trunk/Source/WebCore/style/StyleBuilderCustom.h (295540 => 295541)
--- trunk/Source/WebCore/style/StyleBuilderCustom.h 2022-06-14 22:14:47 UTC (rev 295540)
+++ trunk/Source/WebCore/style/StyleBuilderCustom.h 2022-06-14 22:15:59 UTC (rev 295541)
@@ -139,8 +139,6 @@
// Custom handling of initial + value only.
static void applyInitialTextAlign(BuilderState&);
static void applyValueTextAlign(BuilderState&, CSSValue&);
-static void applyInitialTextAlignLast(BuilderState&);
-static void applyValueTextAlignLast(BuilderState&, CSSValue&);
// Custom handling of value setting only.
static void applyValueBaselineShift(BuilderState&, CSSValue&);
@@ -206,16 +204,6 @@
builderState.style().setHasExplicitlySetTextAlign(true);
}
-inline void BuilderCustom::applyInitialTextAlignLast(BuilderState& builderState)
-{
-builderState.style().setTextAlignLast(RenderStyle::initialTextAlignLast());
-}
-
-inline void BuilderCustom::applyValueTextAlignLast(BuilderState& builderState, CSSValue& value)
-{
-builderState.style().setTextAlignLast(BuilderConverter::convertTextAlignLast(builderState, value));
-}
-
inline void BuilderCustom::resetEffectiveZoom(BuilderState& builderState)
{
// Reset the zoom in effect. This allows the setZoom method to accurately compute a new zoom in effect.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295535] trunk/Source/WTF/Scripts/Preferences/ WebPreferencesExperimental.yaml
Title: [295535] trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Revision 295535 Author n...@apple.com Date 2022-06-14 14:00:35 -0700 (Tue, 14 Jun 2022) Log Message Enable CSSTextAlignLast setting by default https://bugs.webkit.org/show_bug.cgi?id=241241 Reviewed by Alan Bujtas. All the WPT are on parity with Chrome & Firefox, so this should be ready to ship. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Canonical link: https://commits.webkit.org/251540@main Modified Paths trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (295534 => 295535) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-06-14 20:52:45 UTC (rev 295534) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-06-14 21:00:35 UTC (rev 295535) @@ -411,11 +411,11 @@ humanReadableDescription: "Enable the property text-align-last, defined in CSS Text 3" defaultValue: WebKitLegacy: - default: false + default: true WebKit: - default: false + default: true WebCore: - default: false + default: true CSSTextJustifyEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295265] trunk
Title: [295265] trunk Revision 295265 Author n...@apple.com Date 2022-06-04 07:01:53 -0700 (Sat, 04 Jun 2022) Log Message [IFC] Support text-align-last: justify https://bugs.webkit.org/show_bug.cgi?id=241301 Reviewed by Alan Bujtas. `text-align: justify` already worked for the legacy line layout, but not in IFC. Add support for it and a corresponding WPT. Also removed `text-justify: none` handling from legacy line layout, since IFC doesn't handle it, and legacy line layout also doesn't handle it correctly either. Thankfully `text-justify` is disabled by default. * LayoutTests/TestExpectations: * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Removed. * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Removed. Removed tests that were wrong, compared with other browsers to verify. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html: Added. WPT is from Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/css3-text/css3-text-align-last/text-align-last.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63 Upstream WPT PR: https://github.com/web-platform-tests/wpt/pull/34308 * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::applyRunExpansion): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::close): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::textAlignmentForLine const): Canonical link: https://commits.webkit.org/251311@main Modified Paths trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/resources/resource-files.json trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp trunk/Source/WebCore/rendering/LegacyLineLayout.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html Removed Paths trunk/LayoutTests/fast/css3-text/css3-text-align-last/ Diff Modified: trunk/LayoutTests/TestExpectations (295264 => 295265) --- trunk/LayoutTests/TestExpectations 2022-06-04 13:23:27 UTC (rev 295264) +++ trunk/LayoutTests/TestExpectations 2022-06-04 14:01:53 UTC (rev 295265) @@ -2906,8 +2906,6 @@ imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.https.html [ Skip ] imported/w3c/web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https.html [ Skip ] -# text-align-last -webkit.org/b/76173 fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html [ ImageOnlyFailure ] # text-justify webkit.org/b/99945 fast/css3-text/css3-text-justify/text-justify-none.html [ ImageOnlyFailure ] webkit.org/b/99945 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-001.html [ ImageOnlyFailure ] @@ -2920,6 +2918,7 @@ webkit.org/b/99945 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001.html [ ImageOnlyFailure ] webkit.org/b/99945 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001.html [ ImageOnlyFailure ] webkit.org/b/99945 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001.html [ ImageOnlyFailure ] +webkit.org/b/99945 imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001.html [ ImageOnlyFailure ] # Link prefetch is disabled by default (needs ENABLE_LINK_PREFETCH) webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/resources/resource-files.json (295264 => 295265) --- trunk/LayoutTests/imported/w3c/resources/resource-files.json 2022-06-04 13:23:27 UTC (rev 295264) +++ trunk/LayoutTests/imported/w3c/resources/resource-files.json 2022-06-04 14:01:53 UTC (rev 295265) @@ -1165,6 +1165,7 @@ "web-platform-tests/css/css-text/text-align/text-align-end-020.html", "web-platform-tests/css/css-text/text-align/text-align-end-021.html", "web-platform-tests/css/css-text/text-align/text-align-inline-end-crash.html", +"web-platform-tests/css/css-text/text-align/text-align-last-ref.html", "web-platform-tests/css/css-text/text-align/text-align-last-001.html", "web-platform-tests/css/css-text/text-align/text-align-last-002.html",
[webkit-changes] [295120] trunk
Title: [295120] trunk Revision 295120 Author n...@apple.com Date 2022-06-01 22:05:28 -0700 (Wed, 01 Jun 2022) Log Message text-align: match-parent on root handles direction incorrectly https://bugs.webkit.org/show_bug.cgi?id=241164 Reviewed by Myles C. Maxfield. The spec says the initial containing block's direction should be used when the element has no parent. Regarding the computed value, Chrome & Firefox computes to `start` for this case. This may change in https://github.com/w3c/csswg-drafts/issues/6542 to `left`/`right`. Test: imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html * LayoutTests/TestExpectations: * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTextAlign): Canonical link: https://commits.webkit.org/251211@main Modified Paths trunk/LayoutTests/TestExpectations trunk/Source/WebCore/style/StyleBuilderConverter.h Diff Modified: trunk/LayoutTests/TestExpectations (295119 => 295120) --- trunk/LayoutTests/TestExpectations 2022-06-02 04:05:22 UTC (rev 295119) +++ trunk/LayoutTests/TestExpectations 2022-06-02 05:05:28 UTC (rev 295120) @@ -2645,7 +2645,6 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-wins-001.html [ ImageOnlyFailure ] -webkit.org/b/241164 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-join-003.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-tatweel-002.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-tatweel-003.html [ ImageOnlyFailure ] Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (295119 => 295120) --- trunk/Source/WebCore/style/StyleBuilderConverter.h 2022-06-02 04:05:22 UTC (rev 295119) +++ trunk/Source/WebCore/style/StyleBuilderConverter.h 2022-06-02 05:05:28 UTC (rev 295120) @@ -614,6 +614,10 @@ if (primitiveValue.valueID() != CSSValueWebkitMatchParent && primitiveValue.valueID() != CSSValueMatchParent) return primitiveValue; +auto* element = builderState.element(); +if (element && element == builderState.document().documentElement()) +return TextAlignMode::Start; + auto& parentStyle = builderState.parentStyle(); if (parentStyle.textAlign() == TextAlignMode::Start) return parentStyle.isLeftToRightDirection() ? TextAlignMode::Left : TextAlignMode::Right; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295049] trunk
Title: [295049] trunk Revision 295049 Author n...@apple.com Date 2022-05-31 06:24:31 -0700 (Tue, 31 May 2022) Log Message Unprefix -webkit-text-justify and add inter-character value https://bugs.webkit.org/show_bug.cgi?id=229084 Reviewed by Antti Koivisto. This is still disabled by default behind the cssTextJustifyEnabled setting. We don't keep support for the -webkit- prefix, since only Firefox ships text-justify (without the prefix) and it was never enabled in WebKit for macOS/iOS. distribute and inter-character are aliases, with distribute being the legacy one. The spec specifies it as parse-time, but we implement it compute-time (like Chrome). https://github.com/w3c/csswg-drafts/issues/7322 is filed about potentially removing 'distribute' from the spec. * LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Removed. * LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Removed. * LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Removed. * LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Removed. Removed parsing tests redundant with WPT. * LayoutTests/fast/css3-text/css3-text-justify/text-justify-none.html: * LayoutTests/fast/text/text-combine-crash.html: * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-003.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-004.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-005.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-006.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001-expected.html: Added. *
[webkit-changes] [295021] trunk
Title: [295021] trunk Revision 295021 Author n...@apple.com Date 2022-05-30 01:29:03 -0700 (Mon, 30 May 2022) Log Message Unprefix -webkit-text-align-last and add match-parent value support https://bugs.webkit.org/show_bug.cgi?id=229083 Reviewed by Antti Koivisto. We do not keep support for the prefixed version since no other browser supports it, and WebKit never exposed it on macOS/iOS. Also, unprefix WPTs where prefixes were added automatically by the test importer. Note that serialization of the match-parent value isn't as specified in the spec, but the behavior matches other browsers. Original patch by Brent Fulgham. * LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt: Removed. * LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt: Removed. * LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html: Removed. * LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html: Removed. These tests are redundant with the parsing ones on WPT. * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: * LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-003.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-004.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-005.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-006.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-007.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-008.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-009.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-012.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-013.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-014.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-empty-inline.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-wins-001.html: * LayoutTests/imported/w3c/web-platform-tests/svg/styling/required-properties-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/StyleProperties.cpp: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::isPropertyRuntimeDisabled const): * Source/WebCore/css/parser/CSSParserFastPaths.cpp:
[webkit-changes] [295019] trunk/LayoutTests/fast/dom/HTMLMeterElement/ meter-element-markup-expected.txt
Title: [295019] trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt Revision 295019 Author n...@apple.com Date 2022-05-29 12:56:25 -0700 (Sun, 29 May 2022) Log Message [Gardening] Rebaseline fast/dom/HTMLMeterElement/meter-element-markup.html after 9a73643 https://bugs.webkit.org/show_bug.cgi?id=240930 Unreviewed test gardening. Just reflects the new unprefixed style. * LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Canonical link: https://commits.webkit.org/251114@main Modified Paths trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt Diff Modified: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt (295018 => 295019) --- trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt 2022-05-29 17:10:00 UTC (rev 295018) +++ trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt 2022-05-29 19:56:25 UTC (rev 295019) @@ -6,7 +6,7 @@ | value="70" | |
[webkit-changes] [294876] trunk/LayoutTests/platform/win/fast/css3-text/ css3-text-decoration/getComputedStyle/
Title: [294876] trunk/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/ Revision 294876 Author n...@apple.com Date 2022-05-26 05:13:28 -0700 (Thu, 26 May 2022) Log Message [Windows] Remove obsolete css3-text-decoration test results https://bugs.webkit.org/show_bug.cgi?id=240951 Unreviewed test gardening. * LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed. * LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed. Canonical link: https://commits.webkit.org/251006@main Removed Paths trunk/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294746] trunk/Source/WebCore
Title: [294746] trunk/Source/WebCore
Revision 294746
Author n...@apple.com
Date 2022-05-24 08:01:15 -0700 (Tue, 24 May 2022)
Log Message
Remove unused RenderTheme video-related methods
https://bugs.webkit.org/show_bug.cgi?id=240862
Reviewed by Antoine Quint.
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsCurrentTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsRemainingTime const): Deleted.
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsClosedCaptioning const): Deleted.
(WebCore::RenderTheme::hasOwnDisabledStateHandlingFor const): Deleted.
(WebCore::RenderTheme::usesMediaControlStatusDisplay): Deleted.
(WebCore::RenderTheme::usesMediaControlVolumeSlider const): Deleted.
(WebCore::RenderTheme::usesVerticalVolumeSlider const): Deleted.
(WebCore::RenderTheme::mediaControlsFadeInDuration): Deleted.
(WebCore::RenderTheme::mediaControlsFadeOutDuration): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::supportsClosedCaptioning const final): Deleted.
Canonical link: https://commits.webkit.org/250914@main
Modified Paths
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTheme.h
trunk/Source/WebCore/rendering/RenderThemeMac.h
Diff
Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (294745 => 294746)
--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2022-05-24 14:31:01 UTC (rev 294745)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2022-05-24 15:01:15 UTC (rev 294746)
@@ -77,7 +77,7 @@
const RenderStyle& sliderStyle = input.renderer()->style();
#if ENABLE(VIDEO)
-if (sliderStyle.effectiveAppearance() == MediaVolumeSliderPart && input.renderer()->theme().usesVerticalVolumeSlider())
+if (sliderStyle.effectiveAppearance() == MediaVolumeSliderPart)
return true;
#endif
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (294745 => 294746)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-24 14:31:01 UTC (rev 294745)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-24 15:01:15 UTC (rev 294746)
@@ -698,43 +698,6 @@
}
}
-#if ENABLE(VIDEO)
-
-String RenderTheme::formatMediaControlsTime(float time) const
-{
-if (!std::isfinite(time))
-time = 0;
-// FIXME: Seems like it would be better to use std::lround here.
-int seconds = static_cast(std::abs(time));
-int hours = seconds / (60 * 60);
-int minutes = (seconds / 60) % 60;
-seconds %= 60;
-if (hours)
-return makeString((time < 0 ? "-" : ""), hours, ':', pad('0', 2, minutes), ':', pad('0', 2, seconds));
-return makeString((time < 0 ? "-" : ""), pad('0', 2, minutes), ':', pad('0', 2, seconds));
-}
-
-String RenderTheme::formatMediaControlsCurrentTime(float currentTime, float /*duration*/) const
-{
-return formatMediaControlsTime(currentTime);
-}
-
-String RenderTheme::formatMediaControlsRemainingTime(float currentTime, float duration) const
-{
-return formatMediaControlsTime(currentTime - duration);
-}
-
-LayoutPoint RenderTheme::volumeSliderOffsetFromMuteButton(const RenderBox& muteButtonBox, const LayoutSize& size) const
-{
-LayoutUnit y = -size.height();
-FloatPoint absPoint = muteButtonBox.localToAbsolute(FloatPoint(muteButtonBox.offsetLeft(), y), { IsFixed, UseTransforms });
-if (absPoint.y() < 0)
-y = muteButtonBox.height();
-return LayoutPoint(0_lu, y);
-}
-
-#endif
-
Color RenderTheme::activeSelectionBackgroundColor(OptionSet options) const
{
auto& cache = colorCache(options);
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (294745 => 294746)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2022-05-24 14:31:01 UTC (rev 294745)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2022-05-24 15:01:15 UTC (rev 294746)
@@ -206,23 +206,6 @@
virtual Seconds animationDurationForProgressBar(const RenderProgress&) const;
virtual IntRect progressBarRectForBounds(const RenderObject&, const IntRect&) const;
-#if ENABLE(VIDEO)
-// Media controls
-virtual bool supportsClosedCaptioning() const { return false; }
-virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const { return false; }
-virtual bool usesMediaControlStatusDisplay() { return false; }
-virtual bool usesMediaControlVolumeSlider() const { return true; }
-virtual bool usesVerticalVolumeSlider() const { return true; }
-virtual double mediaControlsFadeInDuration() { return 0.1; }
-virtual Seconds mediaControlsFadeOutDuration() { return 300_ms; }
-virtual String formatMediaControlsTime(float time) const;
-virtual String
[webkit-changes] [294728] trunk/Source/WebCore
Title: [294728] trunk/Source/WebCore
Revision 294728
Author n...@apple.com
Date 2022-05-23 22:09:52 -0700 (Mon, 23 May 2022)
Log Message
Remove RenderSliderThumb
https://bugs.webkit.org/show_bug.cgi?id=240794
Reviewed by Antti Koivisto.
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::resolveCustomStyle):
(WebCore::RenderSliderThumb::RenderSliderThumb): Deleted.
(WebCore::RenderSliderThumb::updateAppearance): Deleted.
(WebCore::RenderSliderThumb::isSliderThumb const): Deleted.
(WebCore::SliderThumbElement::createElementRenderer): Deleted.
* Source/WebCore/html/shadow/SliderThumbElement.h:
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isSlider const):
(WebCore::RenderObject::isSliderThumb const): Deleted.
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Deleted.
* Source/WebCore/rendering/RenderSlider.h:
Canonical link: https://commits.webkit.org/250906@main
Modified Paths
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
trunk/Source/WebCore/html/shadow/SliderThumbElement.h
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderSlider.cpp
trunk/Source/WebCore/rendering/RenderSlider.h
Diff
Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (294727 => 294728)
--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2022-05-24 04:09:57 UTC (rev 294727)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2022-05-24 05:09:52 UTC (rev 294728)
@@ -63,7 +63,6 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(SliderThumbElement);
WTF_MAKE_ISO_ALLOCATED_IMPL(SliderContainerElement);
-WTF_MAKE_ISO_ALLOCATED_IMPL(RenderSliderThumb);
inline static Decimal sliderPosition(HTMLInputElement& element)
{
@@ -87,36 +86,6 @@
//
-RenderSliderThumb::RenderSliderThumb(SliderThumbElement& element, RenderStyle&& style)
-: RenderBlockFlow(element, WTFMove(style))
-{
-}
-
-void RenderSliderThumb::updateAppearance(const RenderStyle* parentStyle)
-{
-if (parentStyle->effectiveAppearance() == SliderVerticalPart)
-mutableStyle().setEffectiveAppearance(SliderThumbVerticalPart);
-else if (parentStyle->effectiveAppearance() == SliderHorizontalPart)
-mutableStyle().setEffectiveAppearance(SliderThumbHorizontalPart);
-else if (parentStyle->effectiveAppearance() == MediaSliderPart)
-mutableStyle().setEffectiveAppearance(MediaSliderThumbPart);
-else if (parentStyle->effectiveAppearance() == MediaVolumeSliderPart)
-mutableStyle().setEffectiveAppearance(MediaVolumeSliderThumbPart);
-else if (parentStyle->effectiveAppearance() == MediaFullScreenVolumeSliderPart)
-mutableStyle().setEffectiveAppearance(MediaFullScreenVolumeSliderThumbPart);
-if (style().hasEffectiveAppearance()) {
-ASSERT(element());
-theme().adjustSliderThumbSize(mutableStyle(), element());
-}
-}
-
-bool RenderSliderThumb::isSliderThumb() const
-{
-return true;
-}
-
-//
-
// FIXME: Find a way to cascade appearance and adjust heights, and get rid of this class.
// http://webkit.org/b/62535
class RenderSliderContainer final : public RenderFlexibleBox {
@@ -223,11 +192,6 @@
renderer()->setNeedsLayout();
}
-RenderPtr SliderThumbElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
-{
-return createRenderer(*this, WTFMove(style));
-}
-
bool SliderThumbElement::isDisabledFormControl() const
{
auto input = hostInput();
@@ -586,10 +550,8 @@
return downcast(shadowHost());
}
-std::optional SliderThumbElement::resolveCustomStyle(const Style::ResolutionContext&, const RenderStyle* hostStyle)
+std::optional SliderThumbElement::resolveCustomStyle(const Style::ResolutionContext& resolutionContext, const RenderStyle* hostStyle)
{
-// This doesn't actually compute style. This is just a hack to pick shadow pseudo id when host style is known.
-
if (!hostStyle)
return std::nullopt;
@@ -601,9 +563,31 @@
break;
default:
m_shadowPseudoId = ShadowPseudoIds::webkitSliderThumb();
+break;
}
-return std::nullopt;
+auto elementStyle = resolveStyle(resolutionContext);
+switch (hostStyle->effectiveAppearance()) {
+case MediaSliderPart:
+elementStyle.renderStyle->setEffectiveAppearance(MediaSliderThumbPart);
+break;
+case MediaVolumeSliderPart:
+elementStyle.renderStyle->setEffectiveAppearance(MediaVolumeSliderThumbPart);
+break;
+case MediaFullScreenVolumeSliderPart:
+elementStyle.renderStyle->setEffectiveAppearance(MediaFullScreenVolumeSliderThumbPart);
+break;
+case SliderVerticalPart:
+elementStyle.renderStyle->setEffectiveAppearance(SliderThumbVerticalPart);
+
[webkit-changes] [294677] trunk
Title: [294677] trunk Revision 294677 Author n...@apple.com Date 2022-05-23 13:17:49 -0700 (Mon, 23 May 2022) Log Message [css-ui] Unexpose remaining media-* appearance values https://bugs.webkit.org/show_bug.cgi?id=240484 Reviewed by Aditya Keerthi. These are made UA sheet-only (since they're used in the mediaControls*.css sheets): - media-fullscreen-volume-slider - media-slider - media-volume-slider These are made internal (only used from C++ code): - media-fullscreen-volume-slider-thumb - media-sliderthumb - media-volume-sliderthumb Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::resolveCustomStyle): (WebCore::SliderContainerElement::resolveCustomStyle): * Source/WebCore/platform/ThemeTypes.h: * Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json: * Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js: Canonical link: https://commits.webkit.org/250886@main Modified Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp trunk/Source/WebCore/platform/ThemeTypes.h trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js Diff Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294676 => 294677) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-23 19:56:01 UTC (rev 294676) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-23 20:17:49 UTC (rev 294677) @@ -47,8 +47,8 @@ PASS -webkit-appearance: media-current-time-display (invalid) PASS -webkit-appearance: media-enter-fullscreen-button (invalid) PASS -webkit-appearance: media-exit-fullscreen-button (invalid) -FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider" -FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb" +PASS -webkit-appearance: media-fullscreen-volume-slider (invalid) +PASS -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) PASS -webkit-appearance: media-mute-button (invalid) PASS -webkit-appearance: media-overlay-play-button (invalid) PASS -webkit-appearance: media-play-button (invalid) @@ -56,14 +56,14 @@ PASS -webkit-appearance: media-rewind-button (invalid) PASS -webkit-appearance: media-seek-back-button (invalid) PASS -webkit-appearance: media-seek-forward-button (invalid) -FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider" -FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb" +PASS -webkit-appearance: media-slider (invalid) +PASS -webkit-appearance: media-sliderthumb (invalid) PASS -webkit-appearance: media-time-remaining-display (invalid) PASS -webkit-appearance: media-toggle-closed-captions-button (invalid) -FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider" +PASS -webkit-appearance: media-volume-slider (invalid) PASS -webkit-appearance: media-volume-slider-container (invalid) PASS -webkit-appearance: media-volume-slider-mute-button (invalid) -FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb" +PASS -webkit-appearance: media-volume-sliderthumb (invalid) PASS -webkit-appearance: menuarrow (invalid) PASS -webkit-appearance: menubar (invalid) PASS -webkit-appearance: menucheckbox (invalid) @@ -210,8 +210,8 @@ PASS
[webkit-changes] [294647] trunk
Title: [294647] trunk Revision 294647 Author n...@apple.com Date 2022-05-23 09:32:54 -0700 (Mon, 23 May 2022) Log Message [css-ui] Restrict default-button CSS appearance value to useSystemAppearance https://bugs.webkit.org/show_bug.cgi?id=240391 Reviewed by Aditya Keerthi. This appearance value renders a button in its highlighted state to designate a button that is activated by default on macOS. The most important reason to keep it around is for internal macOS apps, so we restrict it to webviews with useSystemAppearance. * LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html: * LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json: * Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js: Canonical link: https://commits.webkit.org/250871@main Modified Paths trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js Diff Modified: trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt (294646 => 294647) --- trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt 2022-05-23 16:09:19 UTC (rev 294646) +++ trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt 2022-05-23 16:32:54 UTC (rev 294647) @@ -1,3 +1,2 @@ CONSOLE MESSAGE: The test PASS if it does not CRASH. -CONSOLE MESSAGE: NotFoundError: The object can not be found here. Modified: trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html (294646 => 294647) --- trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-05-23 16:09:19 UTC (rev 294646) +++ trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-05-23 16:32:54 UTC (rev 294647) @@ -1,5 +1,5 @@- * { -webkit-appearance:default-button; }+ * { -webkit-appearance: button; } tr { height: 10px; } td { width: 100px; height: 100px; } Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294646 => 294647) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-23 16:09:19 UTC (rev 294646) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-23 16:32:54 UTC (rev 294647) @@ -32,7 +32,7 @@ PASS -webkit-appearance: checkmenuitem (invalid) PASS -webkit-appearance: color-well (invalid) FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator" -FAIL -webkit-appearance: default-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "default-button" +PASS -webkit-appearance: default-button (invalid) FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator" PASS -webkit-appearance: dualbutton (invalid) PASS -webkit-appearance: groupbox (invalid) @@ -195,7 +195,7 @@ PASS appearance: checkmenuitem (invalid) PASS appearance: color-well (invalid) FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator" -FAIL appearance: default-button (invalid) assert_equals: style.appearance expected "" but got "default-button" +PASS appearance: default-button (invalid) FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator" PASS appearance: dualbutton (invalid) PASS appearance: groupbox (invalid) Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294646 => 294647) ---
[webkit-changes] [294641] trunk
Title: [294641] trunk
Revision 294641
Author n...@apple.com
Date 2022-05-23 08:02:52 -0700 (Mon, 23 May 2022)
Log Message
[css-ui] Remove support for appearance: media-controls-{dark/light}-bar-background
https://bugs.webkit.org/show_bug.cgi?id=240756
Reviewed by Antoine Quint.
Reverts r180965 (adapted with new code), this was originally added for old media controls, but was never used.
Marked relevant WPT as passing.
* LayoutTests/compositing/media-controls-bar-appearance-big-expected.txt: Removed.
* LayoutTests/compositing/media-controls-bar-appearance-big.html: Removed.
* LayoutTests/compositing/media-controls-bar-appearance-expected.txt: Removed.
* LayoutTests/compositing/media-controls-bar-appearance.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* LayoutTests/platform/ios/compositing/media-controls-bar-appearance-expected.txt: Removed.
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/platform/ThemeTypes.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/ThemeTypes.h:
* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/graphics/GraphicsLayer.h:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):
(WebCore::layerTypeForCustomBackdropAppearance): Deleted.
(WebCore::isCustomBackdropLayerType): Deleted.
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/graphics/ca/PlatformCALayer.h:
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::updateCustomAppearance):
* Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp:
(printLayer):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateCustomAppearance): Deleted.
* Source/WebCore/rendering/RenderLayerBacking.h:
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::updateCustomAppearance):
(WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
(WebKit::RemoteLayerTreePropertyApplier::updateMask):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[WKBackdropView hitTest:withEvent:]): Deleted.
(-[WKBackdropView description]): Deleted.
Canonical link: https://commits.webkit.org/250865@main
Modified Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/platform/ThemeTypes.cpp
trunk/Source/WebCore/platform/ThemeTypes.h
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
Removed Paths
[webkit-changes] [294640] trunk/Source/WebCore/rendering
Title: [294640] trunk/Source/WebCore/rendering
Revision 294640
Author n...@apple.com
Date 2022-05-23 07:58:55 -0700 (Mon, 23 May 2022)
Log Message
Remove RenderTheme::adjustSearchFieldDecorationStyle()
https://bugs.webkit.org/show_bug.cgi?id=240798
Reviewed by Antti Koivisto.
Let appearance: auto; handle this instead, to centralize this in one place.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
Canonical link: https://commits.webkit.org/250864@main
Modified Paths
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTheme.h
Diff
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (294639 => 294640)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-23 14:34:34 UTC (rev 294639)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2022-05-23 14:58:55 UTC (rev 294640)
@@ -306,9 +306,11 @@
case SearchFieldCancelButtonPart:
return adjustSearchFieldCancelButtonStyle(style, element);
case SearchFieldDecorationPart:
+return adjustSearchFieldDecorationPartStyle(style, element);
case SearchFieldResultsDecorationPart:
+return adjustSearchFieldResultsDecorationPartStyle(style, element);
case SearchFieldResultsButtonPart:
-return adjustSearchFieldDecorationStyle(style, element);
+return adjustSearchFieldResultsButtonStyle(style, element);
case ProgressBarPart:
return adjustProgressBarStyle(style, element);
case MeterPart:
@@ -426,15 +428,20 @@
if (pseudo == ShadowPseudoIds::webkitSearchCancelButton())
return SearchFieldCancelButtonPart;
-if (pseudo == ShadowPseudoIds::webkitSearchDecoration())
-return SearchFieldDecorationPart;
+if (is(element)) {
+if (!downcast(element.get()).canAdjustStyleForAppearance())
+return NoControlPart;
-if (pseudo == ShadowPseudoIds::webkitSearchResultsDecoration())
-return SearchFieldResultsDecorationPart;
+if (pseudo == ShadowPseudoIds::webkitSearchDecoration())
+return SearchFieldDecorationPart;
-if (pseudo == ShadowPseudoIds::webkitSearchResultsButton())
-return SearchFieldResultsButtonPart;
+if (pseudo == ShadowPseudoIds::webkitSearchResultsDecoration())
+return SearchFieldResultsDecorationPart;
+if (pseudo == ShadowPseudoIds::webkitSearchResultsButton())
+return SearchFieldResultsButtonPart;
+}
+
if (pseudo == ShadowPseudoIds::webkitSliderThumb() || pseudo == ShadowPseudoIds::webkitMediaSliderThumb())
return SliderThumbHorizontalPart;
@@ -445,25 +452,6 @@
return NoControlPart;
}
-void RenderTheme::adjustSearchFieldDecorationStyle(RenderStyle& style, const Element* element) const
-{
-if (is(element) && !downcast(*element).canAdjustStyleForAppearance()) {
-style.setEffectiveAppearance(NoControlPart);
-return;
-}
-
-switch (style.effectiveAppearance()) {
-case SearchFieldDecorationPart:
-return adjustSearchFieldDecorationPartStyle(style, element);
-case SearchFieldResultsDecorationPart:
-return adjustSearchFieldResultsDecorationPartStyle(style, element);
-case SearchFieldResultsButtonPart:
-return adjustSearchFieldResultsButtonStyle(style, element);
-default:
-break;
-}
-}
-
bool RenderTheme::paint(const RenderBox& box, ControlStates& controlStates, const PaintInfo& paintInfo, const LayoutRect& rect)
{
// If painting is disabled, but we aren't updating control tints, then just bail.
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (294639 => 294640)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2022-05-23 14:34:34 UTC (rev 294639)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2022-05-23 14:58:55 UTC (rev 294640)
@@ -449,8 +449,6 @@
ControlPart autoAppearanceForElement(const Element*) const;
ControlPart adjustAppearanceForElement(RenderStyle&, const Element*, ControlPart) const;
-void adjustSearchFieldDecorationStyle(RenderStyle&, const Element*) const;
-
mutable HashMap, WTF::UnsignedWithZeroKeyHashTraits> m_colorCacheMap;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294629] trunk
Title: [294629] trunk Revision 294629 Author n...@apple.com Date 2022-05-23 02:06:26 -0700 (Mon, 23 May 2022) Log Message [css-ui] Remove media-play-button and media-volume-slider-mute appearance values https://bugs.webkit.org/show_bug.cgi?id=240760 Reviewed by Antti Koivisto. These are unimplemented/no-op on all platforms. * LayoutTests/fast/css-generated-content/empty-first-letter-with-columns-crash.html: * LayoutTests/fast/multicol/readjust-first-child-on-attach.html: Stop using these appearance values in crashtests. * LayoutTests/imported/blink/fast/css-generated-content/empty-first-letter-with-columns-crash.html: Removed. Remove duplicate test. * LayoutTests/imported/blink/media/video-webkit-appearance-expected.html: Removed. * LayoutTests/imported/blink/media/video-webkit-appearance.html: Removed. Remove no longer relevant crashtest. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Marked subtests as passing. * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/mediaControls.css: Clean up stylesheet and stop using unsupported appearance values. (:is(audio, video)::-webkit-media-controls-panel): (video:-webkit-full-page-media): (:is(audio, video)::-webkit-media-controls-mute-button,): (:is(audio, video)::-webkit-media-controls-overlay-play-button): (:is(audio, video)::-webkit-media-controls-timeline-container): (:is(audio, video)::-webkit-media-controls-current-time-display,): (:is(audio, video)::-webkit-media-controls-timeline): (:is(audio, video)::-webkit-media-controls-volume-slider): (:is(audio, video)::-webkit-media-controls-seek-back-button,): (:is(audio, video)::-webkit-media-controls-rewind-button,): (:is(audio, video)::-webkit-media-controls-closed-captions-container,): (:is(audio, video)::-webkit-media-controls-volume-slider-mute-button): (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): Deleted. (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): Deleted. (audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button): Deleted. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): Deleted. (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): Deleted. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): Deleted. (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): Deleted. (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): Deleted. (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): Deleted. (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): Deleted. (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): Deleted. (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): Deleted. (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): Deleted. (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): Deleted. (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): Deleted. (audio::-webkit-media-controls-closed-captions-container, video::-webkit-media-controls-closed-captions-container): Deleted. (audio::-webkit-media-controls-closed-captions-track-list, video::-webkit-media-controls-closed-captions-track-list): Deleted. (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button): Deleted. (audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-controls-fullscreen-volume-slider): Deleted. (audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media-controls-fullscreen-volume-min-button): Deleted. (audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media-controls-fullscreen-volume-max-button): Deleted. * Source/WebCore/platform/ThemeTypes.cpp: (WebCore::operator<<): * Source/WebCore/platform/ThemeTypes.h: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustMediaControlStyle const): Deleted. * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaPlayButton): Deleted. (WebCore::RenderTheme::paintMediaMuteButton): Deleted. *
[webkit-changes] [294533] trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
Title: [294533] trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp Revision 294533 Author n...@apple.com Date 2022-05-19 23:39:43 -0700 (Thu, 19 May 2022) Log Message Add `revert-layer` to `isUniversalKeyword` https://bugs.webkit.org/show_bug.cgi?id=234674 Reviewed by Antti Koivisto. * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::isUniversalKeyword): Canonical link: https://commits.webkit.org/250788@main Modified Paths trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp Diff Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (294532 => 294533) --- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-20 06:19:49 UTC (rev 294532) +++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-20 06:39:43 UTC (rev 294533) @@ -1081,7 +1081,8 @@ return equalLettersIgnoringASCIICase(string, "initial"_s) || equalLettersIgnoringASCIICase(string, "inherit"_s) || equalLettersIgnoringASCIICase(string, "unset"_s) -|| equalLettersIgnoringASCIICase(string, "revert"_s); +|| equalLettersIgnoringASCIICase(string, "revert"_s) +|| equalLettersIgnoringASCIICase(string, "revert-layer"_s); } static RefPtr parseKeywordValue(CSSPropertyID propertyId, StringView string, const CSSParserContext& context) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294318] trunk/LayoutTests
Title: [294318] trunk/LayoutTests Revision 294318 Author n...@apple.com Date 2022-05-17 04:05:11 -0700 (Tue, 17 May 2022) Log Message [iOS] Rebaseline 2 tests in imported/w3c/web-platform-tests/html/semantics/forms/ https://bugs.webkit.org/show_bug.cgi?id=240512 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added. * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added. Canonical link: https://commits.webkit.org/250638@main Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (294317 => 294318) --- trunk/LayoutTests/ChangeLog 2022-05-17 09:47:30 UTC (rev 294317) +++ trunk/LayoutTests/ChangeLog 2022-05-17 11:05:11 UTC (rev 294318) @@ -1,3 +1,13 @@ +2022-05-17 Tim Nguyen + +[iOS] Rebaseline 2 tests in imported/w3c/web-platform-tests/html/semantics/forms/ +https://bugs.webkit.org/show_bug.cgi?id=240512 + +Unreviewed test gardening. + +* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added. +* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added. + 2022-05-17 Ziran Sun tidy up some test expectations files after resync html/semantics/forms tests Added: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt (0 => 294318) --- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt 2022-05-17 11:05:11 UTC (rev 294318) @@ -0,0 +1,21 @@ + + +Harness Error (TIMEOUT), message = null + +TIMEOUT Test timed out +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN +NOTRUN + Added: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt (0 => 294318) --- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt 2022-05-17 11:05:11 UTC (rev 294318) @@ -0,0 +1,4 @@ + + +FAIL whitespace should not be eaten after parent style recalculation assert_equals: expected "a b" but got "" + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294267] trunk
Title: [294267] trunk Revision 294267 Author n...@apple.com Date 2022-05-16 15:25:02 -0700 (Mon, 16 May 2022) Log Message [css-ui] Unexpose attachment and borderless-attachment appearance values https://bugs.webkit.org/show_bug.cgi?id=240447 Reviewed by Tim Horton. Hide them behind the attachmentElementEnabled setting. Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html LayoutTests: * imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Source/WebCore: * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): Canonical link: https://commits.webkit.org/250615@main Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294266 => 294267) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267) @@ -1,5 +1,18 @@ 2022-05-16 Tim Nguyen +[css-ui] Unexpose attachment and borderless-attachment appearance values +https://bugs.webkit.org/show_bug.cgi?id=240447 + +Reviewed by Tim Horton. + +Hide them behind the attachmentElementEnabled setting. + +Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html + +* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: + +2022-05-16 Tim Nguyen + [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal https://bugs.webkit.org/show_bug.cgi?id=240448 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294266 => 294267) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:25:02 UTC (rev 294267) @@ -17,9 +17,9 @@ PASS -webkit-appearance: textarea PASS -webkit-appearance: textfield PASS -webkit-appearance: bogus-button (invalid) -FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment" +PASS -webkit-appearance: attachment (invalid) PASS -webkit-appearance: button-bevel (invalid) -FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment" +PASS -webkit-appearance: borderless-attachment (invalid) PASS -webkit-appearance: button-arrow-down (invalid) PASS -webkit-appearance: button-arrow-next (invalid) PASS -webkit-appearance: button-arrow-previous (invalid) @@ -180,9 +180,9 @@ PASS appearance: textarea PASS appearance: textfield PASS appearance: bogus-button (invalid) -FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment" +PASS appearance: attachment (invalid) PASS appearance: button-bevel (invalid) -FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment" +PASS appearance: borderless-attachment (invalid) PASS appearance: button-arrow-down (invalid) PASS appearance: button-arrow-next (invalid) PASS appearance: button-arrow-previous (invalid) Modified: trunk/Source/WebCore/ChangeLog (294266 => 294267) --- trunk/Source/WebCore/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267) @@ -1,5 +1,19 @@ 2022-05-16 Tim Nguyen +[css-ui] Unexpose attachment and borderless-attachment appearance values +https://bugs.webkit.org/show_bug.cgi?id=240447 + +Reviewed by Tim Horton. + +Hide them behind the attachmentElementEnabled setting. + +Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html + +* css/parser/CSSParserFastPaths.cpp: +(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): + +2022-05-16 Tim Nguyen + [css-ui] Update documentation for appearance CSS property https://bugs.webkit.org/show_bug.cgi?id=240481 Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (294266 => 294267) --- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:18:15 UTC (rev 294266) +++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:25:02 UTC (rev 294267) @@ -750,8 +750,13 @@ return valueID == CSSValueNone || valueID == CSSValueNonScalingStroke; case CSSPropertyVisibility: // visible | hidden | collapse return valueID == CSSValueVisible || valueID == CSSValueHidden || valueID == CSSValueCollapse; -case
[webkit-changes] [294266] trunk/Source
Title: [294266] trunk/Source
Revision 294266
Author n...@apple.com
Date 2022-05-16 15:18:15 -0700 (Mon, 16 May 2022)
Log Message
[css-ui] Update documentation for appearance CSS property
https://bugs.webkit.org/show_bug.cgi?id=240481
Reviewed by Devin Rousso.
Account for r294226, r294187 and r294170.
Source/WebCore:
* css/CSSProperties.json:
Source/WebInspectorUI:
* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250614@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json
trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (294265 => 294266)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
@@ -1,3 +1,14 @@
+2022-05-16 Tim Nguyen
+
+[css-ui] Update documentation for appearance CSS property
+https://bugs.webkit.org/show_bug.cgi?id=240481
+
+Reviewed by Devin Rousso.
+
+Account for r294226, r294187 and r294170.
+
+* css/CSSProperties.json:
+
2022-05-16 Brent Fulgham
Remove abandoned UseScreenCaptureKit preference
Modified: trunk/Source/WebCore/css/CSSProperties.json (294265 => 294266)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-05-16 22:18:15 UTC (rev 294266)
@@ -5164,9 +5164,7 @@
"square-button",
"button",
"default-button",
-"inner-spin-button",
"listbox",
-"listitem",
"media-controls-dark-bar-background",
"media-controls-light-bar-background",
"media-fullscreen-volume-slider",
@@ -5181,18 +5179,9 @@
"menulist-button",
"meter",
"progress-bar",
-"progress-bar-value",
"slider-horizontal",
"slider-vertical",
-"sliderthumb-horizontal",
-"sliderthumb-vertical",
-"caret",
"searchfield",
-"searchfield-decoration",
-"searchfield-results-decoration",
-"searchfield-results-button",
-"searchfield-cancel-button",
-"snapshotted-plugin-overlay",
"textfield",
"relevancy-level-indicator",
"continuous-capacity-level-indicator",
@@ -5200,10 +5189,6 @@
"rating-level-indicator",
"-apple-pay-button",
"textarea",
-"attachment",
-"caps-lock-indicator",
-"color-well",
-"list-button",
"auto",
"none"
],
Modified: trunk/Source/WebInspectorUI/ChangeLog (294265 => 294266)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
@@ -1,3 +1,15 @@
+2022-05-16 Tim Nguyen
+
+[css-ui] Update documentation for appearance CSS property
+https://bugs.webkit.org/show_bug.cgi?id=240481
+
+Reviewed by Devin Rousso.
+
+Account for r294226, r294187 and r294170.
+
+* UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
+* UserInterface/External/CSSDocumentation/CSSDocumentation.js:
+
2022-05-13 Anjali Kumar
Web Inspector: [Meta] Implement Timelines Film Strip
Modified: trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json (294265 => 294266)
--- trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json 2022-05-16 21:53:34 UTC (rev 294265)
+++ trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json 2022-05-16 22:18:15 UTC (rev 294266)
@@ -4,6 +4,6 @@
},
"-webkit-appearance": {
"description": "Changes the appearance of buttons and other controls to resemble native controls.",
-"syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical |
[webkit-changes] [294254] trunk/metadata/contributors.json
Title: [294254] trunk/metadata/contributors.json
Revision 294254
Author n...@apple.com
Date 2022-05-16 14:01:40 -0700 (Mon, 16 May 2022)
Log Message
Add myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240475
Reviewed by Myles C. Maxfield.
* metadata/contributors.json:
Canonical link: https://commits.webkit.org/250607@main
Modified Paths
trunk/metadata/contributors.json
Diff
Modified: trunk/metadata/contributors.json (294253 => 294254)
--- trunk/metadata/contributors.json 2022-05-16 20:45:49 UTC (rev 294253)
+++ trunk/metadata/contributors.json 2022-05-16 21:01:40 UTC (rev 294254)
@@ -4144,6 +4144,17 @@
},
{
"emails" : [
+ "th...@apple.com",
+ "tuankie...@gmail.com"
+ ],
+ "github" : "tuankiet65",
+ "name" : "Kiet Ho",
+ "nicks" : [
+ "tuankiet65"
+ ]
+ },
+ {
+ "emails" : [
"kihong.k...@samsung.com"
],
"expertise" : "Device APIs(Battery Status, Vibration...), The EFLWebKit Port",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294226] trunk
Title: [294226] trunk Revision 294226 Author n...@apple.com Date 2022-05-16 03:27:00 -0700 (Mon, 16 May 2022) Log Message [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal https://bugs.webkit.org/show_bug.cgi?id=240448 Reviewed by Antti Koivisto. Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it. LayoutTests: * fast/forms/range/thumbslider-crash-expected.txt: Removed. * fast/forms/range/thumbslider-crash.html: Removed. * fast/forms/range/thumbslider-no-parent-slider.html: Removed. * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed. * platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. * imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Source/WebCore: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSValueKeywords.in: * platform/ThemeTypes.h: Canonical link: https://commits.webkit.org/250584@main Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/platform/ThemeTypes.h Removed Paths trunk/LayoutTests/fast/forms/range/thumbslider-crash-expected.txt trunk/LayoutTests/fast/forms/range/thumbslider-crash.html trunk/LayoutTests/fast/forms/range/thumbslider-no-parent-slider.html trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt trunk/LayoutTests/platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (294225 => 294226) --- trunk/LayoutTests/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225) +++ trunk/LayoutTests/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226) @@ -1,3 +1,25 @@ +2022-05-16 Tim Nguyen + +[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal +https://bugs.webkit.org/show_bug.cgi?id=240448 + +Reviewed by Antti Koivisto. + +iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it. + +* fast/forms/range/thumbslider-crash-expected.txt: Removed. +* fast/forms/range/thumbslider-crash.html: Removed. +* fast/forms/range/thumbslider-no-parent-slider.html: Removed. +* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. +* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: +* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed. +* platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed. +* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. +* platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed. + 2022-05-16 Martin Robinson Do not allow unitless values for CSS unprefixed perspective property Deleted:
[webkit-changes] [294187] trunk
Title: [294187] trunk
Revision 294187
Author n...@apple.com
Date 2022-05-13 22:29:41 -0700 (Fri, 13 May 2022)
Log Message
[css-ui] Unexpose appearance property values already handled by appearance: auto
https://bugs.webkit.org/show_bug.cgi?id=240384
Reviewed by Aditya Keerthi.
These are only used internally, and are handled by appearance: auto in the UA sheets:
- caps-lock-indicator
- color-well
- list-button
- searchfield-decoration
- searchfield-results-decoration
- searchfield-results-button
- searchfield-cancel-button
LayoutTests/imported/w3c:
* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
* platform/ThemeTypes.cpp:
(WebCore::operator<<):
* platform/ThemeTypes.h:
LayoutTests:
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* fast/css/appearance-caps-lock-indicator-expected.txt: Removed.
* fast/css/appearance-caps-lock-indicator.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
trunk/Source/WebCore/platform/ThemeTypes.cpp
trunk/Source/WebCore/platform/ThemeTypes.h
Removed Paths
trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt
trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html
Diff
Modified: trunk/LayoutTests/ChangeLog (294186 => 294187)
--- trunk/LayoutTests/ChangeLog 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/ChangeLog 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,3 +1,24 @@
+2022-05-13 Tim Nguyen
+
+[css-ui] Unexpose appearance property values already handled by appearance: auto
+https://bugs.webkit.org/show_bug.cgi?id=240384
+
+Reviewed by Aditya Keerthi.
+
+These are only used internally, and are handled by appearance: auto in the UA sheets:
+- caps-lock-indicator
+- color-well
+- list-button
+- searchfield-decoration
+- searchfield-results-decoration
+- searchfield-results-button
+- searchfield-cancel-button
+
+* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+* fast/css/appearance-caps-lock-indicator-expected.txt: Removed.
+* fast/css/appearance-caps-lock-indicator.html: Removed.
+
2022-05-13 Tyler Wilcock
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
Deleted: trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt (294186 => 294187)
--- trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,3 +0,0 @@
-Test that the CSS parser accepts caps-lock-indicator as a -webkit-appearance value.
-
-PASS
Deleted: trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html (294186 => 294187)
--- trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,12 +0,0 @@
-
-Test that the CSS parser accepts caps-lock-indicator as a -webkit-appearance value.
-
-FAIL: Test did not run
-
-
-if (window.testRunner)
-testRunner.dumpAsText();
-
-var appearance = document.getElementById("target").style.webkitAppearance;
-document.getElementById("result").innerText = appearance === "caps-lock-indicator" ? "PASS" : "FAIL: parsed as " + appearance;
-
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294186 => 294187)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,5 +1,23 @@
2022-05-13 Tim Nguyen
+[css-ui] Unexpose appearance property values already handled by appearance: auto
+
[webkit-changes] [294170] trunk
Title: [294170] trunk
Revision 294170
Author n...@apple.com
Date 2022-05-13 12:38:21 -0700 (Fri, 13 May 2022)
Log Message
[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
https://bugs.webkit.org/show_bug.cgi?id=240390
Reviewed by Aditya Keerthi.
LayoutTests/imported/w3c:
They're basically unimplemented.
* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.cpp:
(WebCore::operator<<):
* platform/ThemeTypes.h:
LayoutTests:
They're basically unimplemented.
Remove WPE expectations which were very out-of-date.
* fast/css/appearance-with-pseudo-elements-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode.html:
* fast/css/appearance-with-pseudo-elements.html:
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-expected.html
trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html
trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode.html
trunk/LayoutTests/fast/css/appearance-with-pseudo-elements.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/platform/ThemeTypes.cpp
trunk/Source/WebCore/platform/ThemeTypes.h
Removed Paths
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-ui/
Diff
Modified: trunk/LayoutTests/ChangeLog (294169 => 294170)
--- trunk/LayoutTests/ChangeLog 2022-05-13 19:16:19 UTC (rev 294169)
+++ trunk/LayoutTests/ChangeLog 2022-05-13 19:38:21 UTC (rev 294170)
@@ -1,3 +1,22 @@
+2022-05-13 Tim Nguyen
+
+[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
+https://bugs.webkit.org/show_bug.cgi?id=240390
+
+Reviewed by Aditya Keerthi.
+
+They're basically unimplemented.
+
+Remove WPE expectations which were very out-of-date.
+
+* fast/css/appearance-with-pseudo-elements-expected.html:
+* fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html:
+* fast/css/appearance-with-pseudo-elements-in-quirks-mode.html:
+* fast/css/appearance-with-pseudo-elements.html:
+* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+* platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
+
2022-05-13 Anjali Kumar
Web Inspector: [Meta] Implement Timelines Film Strip
Modified: trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-expected.html (294169 => 294170)
--- trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-expected.html 2022-05-13 19:16:19 UTC (rev 294169)
+++ trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-expected.html 2022-05-13 19:38:21 UTC (rev 294170)
@@ -12,7 +12,6 @@
}
#center::after {
content: "cappuccino";
--webkit-appearance: list-item;
}
Modified: trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html (294169 => 294170)
--- trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html 2022-05-13 19:16:19 UTC (rev 294169)
+++ trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html 2022-05-13 19:38:21 UTC (rev 294170)
@@ -11,7 +11,6 @@
}
#center:after {
content: "cappuccino";
--webkit-appearance: list-item;
}
Modified: trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode.html (294169 => 294170)
--- trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode.html 2022-05-13 19:16:19 UTC (rev 294169)
+++ trunk/LayoutTests/fast/css/appearance-with-pseudo-elements-in-quirks-mode.html 2022-05-13 19:38:21 UTC (rev 294170)
@@ -11,7 +11,6 @@
}
#center:after {
content: "cappuccino";
--webkit-appearance: list-item;
}
Modified:
[webkit-changes] [294098] trunk
Title: [294098] trunk
Revision 294098
Author n...@apple.com
Date 2022-05-12 05:40:27 -0700 (Thu, 12 May 2022)
Log Message
[:has() pseudo-class] Support invalidation for :target pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=240329
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Extend current test to cover more cases, and mark it as passing.
* web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt:
* web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html
* dom/Document.cpp:
(WebCore::Document::setCSSTarget):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294097 => 294098)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-12 08:44:29 UTC (rev 294097)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-12 12:40:27 UTC (rev 294098)
@@ -1,5 +1,17 @@
2022-05-12 Tim Nguyen
+[:has() pseudo-class] Support invalidation for :target pseudo-class
+https://bugs.webkit.org/show_bug.cgi?id=240329
+
+Reviewed by Antti Koivisto.
+
+Extend current test to cover more cases, and mark it as passing.
+
+* web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt:
+* web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html:
+
+2022-05-12 Tim Nguyen
+
Re-import css/selectors WPT from revision 4653e9128742e2c2609e76f04f4084cdc10ffead
https://bugs.webkit.org/show_bug.cgi?id=240332
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt (294097 => 294098)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt 2022-05-12 08:44:29 UTC (rev 294097)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt 2022-05-12 12:40:27 UTC (rev 294098)
@@ -1,5 +1,7 @@
-parent color must be yellow green when containing :target
-link to #fragment link to #
+link to #fragment link to #fragment2 link to #fragment3 link to #
+1: Must be green when containing :target
+2: Must be green when containing :target
+3: Must be green when containing :target
-FAIL CSS Selectors Invalidation: target pseudo in :has() argument assert_equals: parent should be yellowgreen on fragment click expected "rgb(154, 205, 50)" but got "rgb(0, 128, 0)"
+PASS CSS Selectors Invalidation: :target pseudo-class in :has() argument
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html (294097 => 294098)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html 2022-05-12 08:44:29 UTC (rev 294097)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html 2022-05-12 12:40:27 UTC (rev 294098)
@@ -1,36 +1,93 @@
-CSS Selectors Invalidation: target pseudo in :has() argument
+CSS Selectors Invalidation: :target pseudo-class in :has() argument