[webkit-changes] [252624] trunk/Source/WebCore
Title: [252624] trunk/Source/WebCore
Revision 252624
Author commit-qu...@webkit.org
Date 2019-11-19 04:41:25 -0800 (Tue, 19 Nov 2019)
Log Message
REGRESSION(r249428): [GStreamer] VP9 video rendered green
https://bugs.webkit.org/show_bug.cgi?id=201422
Patch by Thibault Saunier on 2019-11-19
Reviewed by Philippe Normand.
Avoid forcing a video conversion in software we end up and make
it happen in GL with a sensibly simpler pipeline, this is possible as
`glcolorconvert` properly setups the converted GL buffers.
Without that patch we are getting "random" not negotiated issues with
MediaStream sources related to the `GLMemory` caps feature during
renegotiation between the software `videoconvert` and our sink.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252623 => 252624)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 06:30:46 UTC (rev 252623)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 12:41:25 UTC (rev 252624)
@@ -1,3 +1,21 @@
+2019-11-19 Thibault Saunier
+
+REGRESSION(r249428): [GStreamer] VP9 video rendered green
+https://bugs.webkit.org/show_bug.cgi?id=201422
+
+Reviewed by Philippe Normand.
+
+Avoid forcing a video conversion in software we end up and make
+it happen in GL with a sensibly simpler pipeline, this is possible as
+`glcolorconvert` properly setups the converted GL buffers.
+
+Without that patch we are getting "random" not negotiated issues with
+MediaStream sources related to the `GLMemory` caps feature during
+renegotiation between the software `videoconvert` and our sink.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL):
+
2019-11-18 John Wilander
Check if ITP is on before applying third-party cookie blocking
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (252623 => 252624)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-11-19 06:30:46 UTC (rev 252623)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-11-19 12:41:25 UTC (rev 252624)
@@ -1200,12 +1200,6 @@
gst_bin_add_many(GST_BIN(videoSink), upload, colorconvert, appsink, nullptr);
-GRefPtr caps = adoptGRef(gst_caps_from_string("video/x-raw, format = (string) " GST_GL_CAPS_FORMAT));
-gst_caps_set_features(caps.get(), 0, gst_caps_features_new(GST_CAPS_FEATURE_MEMORY_GL_MEMORY, nullptr));
-g_object_set(appsink, "caps", caps.get(), nullptr);
-
-result &= gst_element_link_many(upload, colorconvert, appsink, nullptr);
-
// Workaround until we can depend on GStreamer 1.16.2.
// https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/commit/8d32de090554cf29fe359f83aa46000ba658a693
// Forcing a color conversion to RGBA here allows glupload to internally use
@@ -1218,22 +1212,22 @@
// and set the WEBKIT_GST_NO_RGBA_CONVERSION environment variable until
// GStreamer 1.16.2 is released.
// See also https://bugs.webkit.org/show_bug.cgi?id=201422
-if (webkitGstCheckVersion(1, 16, 2) || getenv("WEBKIT_GST_NO_RGBA_CONVERSION")) {
-GRefPtr pad = adoptGRef(gst_element_get_static_pad(upload, "sink"));
-gst_element_add_pad(videoSink, gst_ghost_pad_new("sink", pad.get()));
-} else {
-GstElement* capsFilter = gst_element_factory_make("capsfilter", nullptr);
-GRefPtr caps = adoptGRef(gst_caps_from_string("video/x-raw, format=RGBA"));
-g_object_set(capsFilter, "caps", caps.get(), nullptr);
+GRefPtr caps;
+if (webkitGstCheckVersion(1, 16, 2) || getenv("WEBKIT_GST_NO_RGBA_CONVERSION"))
+caps = adoptGRef(gst_caps_from_string("video/x-raw, format = (string) " GST_GL_CAPS_FORMAT));
+else {
+GST_INFO_OBJECT(pipeline(), "Forcing RGBA as GStreamer is not new enough.");
+caps = adoptGRef(gst_caps_from_string("video/x-raw, format = (string) RGBA"));
+}
-GstElement* videoconvert = gst_element_factory_make("videoconvert", nullptr);
-gst_bin_add_many(GST_BIN_CAST(videoSink), capsFilter, videoconvert, nullptr);
-result &= gst_element_link_many(capsFilter, videoconvert, upload, nullptr);
+gst_caps_set_features(caps.get(), 0, gst_caps_features_new(GST_CAPS_FEATURE_MEMORY_GL_MEMORY, nullptr));
+g_object_set(appsink, "caps", caps.get(), nullptr);
-GRefPtr pad = adoptGRef(gst_element_get_static_pad(capsFilter, "sink"));
-gst_element_add_pad(videoSink, gst_ghost_pad_new("sink", pad.get()));
-}
+result &= gst_element_link_many(upload, colorconvert, appsink, nullptr);
+GRef
[webkit-changes] [252625] trunk/Tools
Title: [252625] trunk/Tools
Revision 252625
Author commit-qu...@webkit.org
Date 2019-11-19 04:45:53 -0800 (Tue, 19 Nov 2019)
Log Message
Setup EWS queues for JSConly 32bits ARMv7 and MIPSel
https://bugs.webkit.org/show_bug.cgi?id=203946
Patch by Paulo Matos on 2019-11-19
Reviewed by Aakash Jain.
Naming of queues follow old EWS: jsc-mips for MIPSel
and jsc-armv7 for ARMv7.
* BuildSlaveSupport/ews-build/config.json:
* BuildSlaveSupport/ews-build/steps.py:
(RunJavaScriptCoreTests.start):
(PrintConfiguration.run):
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestRunJavaScriptCoreTests.test_remote_success):
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/config.json
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/config.json (252624 => 252625)
--- trunk/Tools/BuildSlaveSupport/ews-build/config.json 2019-11-19 12:41:25 UTC (rev 252624)
+++ trunk/Tools/BuildSlaveSupport/ews-build/config.json 2019-11-19 12:45:53 UTC (rev 252625)
@@ -6,6 +6,14 @@
"max_builds": 3
},
{
+ "name": "igalia-jsc32-armv7-ews",
+ "platform": "jsc-only"
+},
+{
+ "name": "igalia-jsc32-mipsel-ews",
+ "platform": "jsc-only"
+},
+{
"name": "igalia1-gtk-wk2-ews",
"platform": "gtk"
},
@@ -417,6 +425,28 @@
"workernames": ["ews127", "ews128"]
},
{
+ "name": "JSC-MIPSEL-32bits-EWS",
+ "shortname": "jsc-mips",
+ "icon": "buildAndTest",
+ "factory": "JSCTestsFactory",
+ "platform": "jsc-only",
+ "configuration": "release",
+ "architectures": ["mipsel"],
+ "workernames": ["igalia-jsc32-mipsel-ews"],
+ "remotes": "../../EWS-test-devices.json"
+},
+{
+ "name": "JSC-ARMv7-32bits-EWS",
+ "shortname": "jsc-armv7",
+ "icon": "buildAndTest",
+ "factory": "JSCTestsFactory",
+ "platform": "jsc-only",
+ "configuration": "release",
+ "architectures": ["armv7"],
+ "workernames": ["igalia-jsc32-armv7-ews"],
+ "remotes": "../../EWS-test-devices.json"
+},
+{
"name": "Bindings-Tests-EWS",
"shortname": "bindings",
"icon": "testOnly",
@@ -471,7 +501,7 @@
"name": "try",
"port": ,
"builderNames": ["Apply-WatchList-EWS", "Bindings-Tests-EWS", "GTK-Webkit2-EWS", "iOS-13-Build-EWS", "iOS-13-Simulator-Build-EWS",
- "JSC-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "macOS-High-Sierra-Release-Build-EWS",
+ "JSC-ARMv7-32bits-EWS", "JSC-MIPSEL-32bits-EWS", "JSC-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "macOS-High-Sierra-Release-Build-EWS",
"Services-EWS", "Style-EWS", "WebKitPerl-Tests-EWS", "WebKitPy-Tests-EWS", "WPE-EWS", "WinCairo-EWS"]
},
{
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (252624 => 252625)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-19 12:41:25 UTC (rev 252624)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-19 12:45:53 UTC (rev 252625)
@@ -963,6 +963,9 @@
if remotesfile:
self.command.append('--remote-config-file={0}'.format(remotesfile))
+platform = self.getProperty('platform')
+if platform == 'jsc-only' and remotesfile:
+self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited'])
appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
return shell.Test.start(self)
@@ -1887,10 +1890,11 @@
def run(self):
command_list = list(self.command_list_generic)
platform = self.getProperty('platform', '*')
-platform = platform.split('-')[0]
+if platform != 'jsc-only':
+platform = platform.split('-')[0]
if platform in ('mac', 'ios', '*'):
command_list.extend(self.command_list_apple)
-elif platform in ('gtk', 'wpe'):
+elif platform in ('gtk', 'wpe', 'jsc-only'):
command_list.extend(self.command_list_linux)
elif platform in ('win', 'wincairo'):
command_list.extend(self.command_list_win)
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (252624 => 252625)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-19 12:41:25 UTC (rev 252624)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-19 12:45:53 UTC (rev 252625)
@@ -1038,7 +1038,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
-command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--jsc-only'],
+
[webkit-changes] [252626] trunk/Source/WebCore
Title: [252626] trunk/Source/WebCore
Revision 252626
Author cdu...@apple.com
Date 2019-11-19 06:23:46 -0800 (Tue, 19 Nov 2019)
Log Message
http/tests/navigation/page-cache-mediastream.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=204321
Reviewed by Eric Carlson.
Make sure the MediaStreamTrack stays alive if there is a pending ended event to dispatch.
No new tests, covered by existing test.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::hasPendingActivity const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252625 => 252626)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 12:45:53 UTC (rev 252625)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 14:23:46 UTC (rev 252626)
@@ -1,3 +1,17 @@
+2019-11-19 Chris Dumez
+
+http/tests/navigation/page-cache-mediastream.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=204321
+
+Reviewed by Eric Carlson.
+
+Make sure the MediaStreamTrack stays alive if there is a pending ended event to dispatch.
+
+No new tests, covered by existing test.
+
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::hasPendingActivity const):
+
2019-11-19 Thibault Saunier
REGRESSION(r249428): [GStreamer] VP9 video rendered green
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (252625 => 252626)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2019-11-19 12:45:53 UTC (rev 252625)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2019-11-19 14:23:46 UTC (rev 252626)
@@ -573,7 +573,7 @@
bool MediaStreamTrack::hasPendingActivity() const
{
-return !m_ended;
+return !m_ended || ActiveDOMObject::hasPendingActivity();
}
AudioSourceProvider* MediaStreamTrack::audioSourceProvider()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252627] trunk
Title: [252627] trunk
Revision 252627
Author wenson_hs...@apple.com
Date 2019-11-19 07:26:13 -0800 (Tue, 19 Nov 2019)
Log Message
[Clipboard API] Add support for Clipboard.readText()
https://bugs.webkit.org/show_bug.cgi?id=204310
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline a couple of imported web platform tests.
* web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt:
* web-platform-tests/clipboard-apis/async-write-text-read-text-manual.https-expected.txt:
Source/WebCore:
Implements readText; see below for more detail.
Tests: editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html
editing/async-clipboard/clipboard-read-text-from-platform.html
editing/async-clipboard/clipboard-read-text-same-origin.html
editing/async-clipboard/clipboard-read-text.html
* Modules/async-clipboard/Clipboard.cpp:
(WebCore::Clipboard::readText):
Implement the method. This works similarly to Clipboard::read, but immediately reads text data for the first
clipboard item with data for "text/plain", instead of exposing a list of clipboard items.
* dom/DataTransfer.cpp:
(WebCore::DataTransfer::commitToPasteboard):
If the custom pasteboard data object is empty, then don't bother trying to write it to the platform pasteboard.
This avoids hitting an assertion in WebDragClient::beginDrag that checks to make sure there's no data on the
pasteboard right before beginning a drag in the UI process which was getting hit because we'd otherwise end up
writing just the pasteboard data origin; it also has an added bonus of avoiding an unnecessary sync IPC message.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::write):
Write the custom data type ("com.apple.WebKit.custom-pasteboard-data") when writing PasteboardCustomData to the
pasteboard on macOS, even when the custom pasteboard data only contains an origin. This allows DOM paste
requests to automatically accept when exchanging text data between the same origin via the async clipboard API.
LayoutTests:
Add several new layout tests.
* editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes-expected.txt: Added.
* editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html: Added.
Add a test to verify that if the clipboard changes content in the middle of a call to clipboard.readText, we
will reject the readText() promise and avoid exposing any text to the page.
* editing/async-clipboard/clipboard-read-text-expected.txt: Added.
* editing/async-clipboard/clipboard-read-text-from-platform-expected.txt: Added.
* editing/async-clipboard/clipboard-read-text-from-platform.html: Added.
Add a test to verify that we display DOM paste UI when reading text that was written to the pasteboard directly
via platform API.
* editing/async-clipboard/clipboard-read-text-same-origin-expected.txt: Added.
* editing/async-clipboard/clipboard-read-text-same-origin.html: Added.
Add a test to verify that we allow the page to access same origin text data on the pasteboard using readText,
during a user gesture.
* editing/async-clipboard/clipboard-read-text.html: Added.
Add a basic test to verify that readText works when the page writes text to the clipboard using DataTransfer and
document.execCommand.
* platform/gtk/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:
* platform/wpe/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-basics.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-text-read-text-manual.https-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/async-clipboard/Clipboard.cpp
trunk/Source/WebCore/dom/DataTransfer.cpp
trunk/Source/WebCore/platform/mac/PlatformPasteboardMac.mm
Added Paths
trunk/LayoutTests/editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes-expected.txt
trunk/LayoutTests/editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text-expected.txt
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text-from-platform-expected.txt
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text-from-platform.html
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text-same-origin-expected.txt
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text-same-origin.html
trunk/LayoutTests/editing/async-clipboard/clipboard-read-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252626 => 252627)
--- trunk/LayoutTests/ChangeL
[webkit-changes] [252628] trunk/Source/WebCore
Title: [252628] trunk/Source/WebCore Revision 252628 Author an...@apple.com Date 2019-11-19 07:34:28 -0800 (Tue, 19 Nov 2019) Log Message Move ElementRuleCollector to Style namespace https://bugs.webkit.org/show_bug.cgi?id=204329 Reviewed by Sam Weinig. Also move PageRuleCollector. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/CallTracerTypes.h: * css/DOMCSSRegisterCustomProperty.cpp: (WebCore::DOMCSSRegisterCustomProperty::registerProperty): * dom/Document.cpp: (WebCore::Document::styleForElementIgnoringPendingStylesheets): * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): * html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::toStyleVariant): (WebCore::CanvasRenderingContext2DBase::strokeStyle const): (WebCore::CanvasRenderingContext2DBase::setStrokeStyle): (WebCore::CanvasRenderingContext2DBase::fillStyle const): (WebCore::CanvasRenderingContext2DBase::setFillStyle): Rename CanvasRenderingContext2DBase::Style to StyleVariant to avoid name conflicts. (WebCore::toStyle): Deleted. * html/canvas/CanvasRenderingContext2DBase.h: * inspector/InspectorCanvas.cpp: (WebCore::InspectorCanvas::buildAction): * page/FrameView.cpp: (WebCore::FrameView::styleHidesScrollbarWithOrientation const): (WebCore::FrameView::updateScrollCorner): * rendering/RenderElement.cpp: (WebCore::RenderElement::getCachedPseudoStyle const): (WebCore::RenderElement::getUncachedPseudoStyle const): (WebCore::RenderElement::selectionPseudoStyle const): * rendering/RenderElement.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): * rendering/RenderObject.h: * rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle const): * rendering/updating/RenderTreeUpdater.cpp: (WebCore::pseudoStyleCacheIsInvalid): * style/ElementRuleCollector.cpp: Renamed from Source/WebCore/css/ElementRuleCollector.cpp. (WebCore::Style::MatchRequest::MatchRequest): (WebCore::Style::ElementRuleCollector::ElementRuleCollector): (WebCore::Style::ElementRuleCollector::addMatchedRule): (WebCore::Style::ElementRuleCollector::collectMatchingRules): (WebCore::Style::ElementRuleCollector::transferMatchedRules): (WebCore::Style::ElementRuleCollector::matchAuthorShadowPseudoElementRules): (WebCore::Style::ElementRuleCollector::matchHostPseudoClassRules): (WebCore::Style::ElementRuleCollector::matchSlottedPseudoElementRules): (WebCore::Style::ElementRuleCollector::matchPartPseudoElementRulesForScope): (WebCore::Style::ElementRuleCollector::collectSlottedPseudoElementRulesForSlot): (WebCore::Style::ElementRuleCollector::matchUARules): (WebCore::Style::ElementRuleCollector::ruleMatches): (WebCore::Style::ElementRuleCollector::collectMatchingRulesForList): (WebCore::Style::ElementRuleCollector::matchAllRules): (WebCore::Style::ElementRuleCollector::hasAnyMatchingRules): (WebCore::Style::ElementRuleCollector::addMatchedProperties): * style/ElementRuleCollector.h: Renamed from Source/WebCore/css/ElementRuleCollector.h. (WebCore::Style::PseudoElementRequest::PseudoElementRequest): (WebCore::Style::ElementRuleCollector::setPseudoElementRequest): (WebCore::Style::ElementRuleCollector::styleRelations const): (WebCore::Style::ElementRuleCollector::transferMatchedRules): * style/PageRuleCollector.cpp: Renamed from Source/WebCore/css/PageRuleCollector.cpp. (WebCore::Style::PageRuleCollector::matchPageRules): * style/PageRuleCollector.h: Renamed from Source/WebCore/css/PageRuleCollector.h. (WebCore::Style::PageRuleCollector::PageRuleCollector): * style/StyleResolver.cpp: (WebCore::Style::Resolver::pseudoStyleForElement): (WebCore::Style::Resolver::pseudoStyleRulesForElement): * style/StyleResolver.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/CallTracerTypes.h trunk/Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h trunk/Source/WebCore/inspector/InspectorCanvas.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebCore/rendering/RenderElement.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderScrollbar.cpp trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp trunk/Source/WebCore/style/StyleResolver.cpp trunk/Source/WebCore/style/StyleResolver.h Added Paths trunk/Source/WebCore/style/ElementRuleCollector.cpp trunk/Source/WebCore/style/ElementRuleCollector.h trunk/Source/WebCore/style/PageRuleCollector.cpp trunk/Source/WebCore/style/PageRuleCollector.h Removed Paths trunk/Source/WebCore/css/ElementRuleCollector.cpp trunk/Source/WebCore/css/ElementRuleCollector.h trunk
[webkit-changes] [252629] trunk/Source/WebCore
Title: [252629] trunk/Source/WebCore Revision 252629 Author an...@apple.com Date 2019-11-19 08:10:40 -0800 (Tue, 19 Nov 2019) Log Message Move RuleData to a file of its own https://bugs.webkit.org/show_bug.cgi?id=204351 Reviewed by Anders Carlsson. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * style/RuleData.cpp: Added. (WebCore::Style::computeMatchBasedOnRuleHash): (WebCore::Style::selectorCanMatchPseudoElement): (WebCore::Style::isCommonAttributeSelectorAttribute): (WebCore::Style::computeContainsUncommonAttributeSelector): (WebCore::Style::determinePropertyWhitelistType): (WebCore::Style::RuleData::RuleData): * style/RuleData.h: Added. (WebCore::Style::RuleData::position const): (WebCore::Style::RuleData::rule const): (WebCore::Style::RuleData::selector const): (WebCore::Style::RuleData::selectorIndex const): (WebCore::Style::RuleData::selectorListIndex const): (WebCore::Style::RuleData::canMatchPseudoElement const): (WebCore::Style::RuleData::matchBasedOnRuleHash const): (WebCore::Style::RuleData::containsUncommonAttributeSelector const): (WebCore::Style::RuleData::linkMatchType const): (WebCore::Style::RuleData::propertyWhitelistType const): (WebCore::Style::RuleData::descendantSelectorIdentifierHashes const): (WebCore::Style::RuleData::disableSelectorFiltering): * style/RuleSet.cpp: (WebCore::Style::computeMatchBasedOnRuleHash): Deleted. (WebCore::Style::selectorCanMatchPseudoElement): Deleted. (WebCore::Style::isCommonAttributeSelectorAttribute): Deleted. (WebCore::Style::computeContainsUncommonAttributeSelector): Deleted. (WebCore::Style::determinePropertyWhitelistType): Deleted. (WebCore::Style::RuleData::RuleData): Deleted. * style/RuleSet.h: (WebCore::Style::RuleData::position const): Deleted. (WebCore::Style::RuleData::rule const): Deleted. (WebCore::Style::RuleData::selector const): Deleted. (WebCore::Style::RuleData::selectorIndex const): Deleted. (WebCore::Style::RuleData::selectorListIndex const): Deleted. (WebCore::Style::RuleData::canMatchPseudoElement const): Deleted. (WebCore::Style::RuleData::matchBasedOnRuleHash const): Deleted. (WebCore::Style::RuleData::containsUncommonAttributeSelector const): Deleted. (WebCore::Style::RuleData::linkMatchType const): Deleted. (WebCore::Style::RuleData::propertyWhitelistType const): Deleted. (WebCore::Style::RuleData::descendantSelectorIdentifierHashes const): Deleted. (WebCore::Style::RuleData::disableSelectorFiltering): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/style/RuleSet.cpp trunk/Source/WebCore/style/RuleSet.h Added Paths trunk/Source/WebCore/style/RuleData.cpp trunk/Source/WebCore/style/RuleData.h Diff Modified: trunk/Source/WebCore/ChangeLog (252628 => 252629) --- trunk/Source/WebCore/ChangeLog 2019-11-19 15:34:28 UTC (rev 252628) +++ trunk/Source/WebCore/ChangeLog 2019-11-19 16:10:40 UTC (rev 252629) @@ -1,5 +1,55 @@ 2019-11-19 Antti Koivisto +Move RuleData to a file of its own +https://bugs.webkit.org/show_bug.cgi?id=204351 + +Reviewed by Anders Carlsson. + +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* style/RuleData.cpp: Added. +(WebCore::Style::computeMatchBasedOnRuleHash): +(WebCore::Style::selectorCanMatchPseudoElement): +(WebCore::Style::isCommonAttributeSelectorAttribute): +(WebCore::Style::computeContainsUncommonAttributeSelector): +(WebCore::Style::determinePropertyWhitelistType): +(WebCore::Style::RuleData::RuleData): +* style/RuleData.h: Added. +(WebCore::Style::RuleData::position const): +(WebCore::Style::RuleData::rule const): +(WebCore::Style::RuleData::selector const): +(WebCore::Style::RuleData::selectorIndex const): +(WebCore::Style::RuleData::selectorListIndex const): +(WebCore::Style::RuleData::canMatchPseudoElement const): +(WebCore::Style::RuleData::matchBasedOnRuleHash const): +(WebCore::Style::RuleData::containsUncommonAttributeSelector const): +(WebCore::Style::RuleData::linkMatchType const): +(WebCore::Style::RuleData::propertyWhitelistType const): +(WebCore::Style::RuleData::descendantSelectorIdentifierHashes const): +(WebCore::Style::RuleData::disableSelectorFiltering): +* style/RuleSet.cpp: +(WebCore::Style::computeMatchBasedOnRuleHash): Deleted. +(WebCore::Style::selectorCanMatchPseudoElement): Deleted. +(WebCore::Style::isCommonAttributeSelectorAttribute): Deleted. +(WebCore::Style::computeContainsUncommonAttributeSelector): Deleted. +(WebCore::Style::determinePropertyWhitelistType): Deleted. +(WebCore::Style::RuleData::RuleData): Deleted. +* style/RuleSet.h: +(WebCore::Style::RuleData::position const): Deleted. +(WebCore::Style::RuleData::rule const): Deleted. +
[webkit-changes] [252630] trunk/LayoutTests
Title: [252630] trunk/LayoutTests
Revision 252630
Author katherine_che...@apple.com
Date 2019-11-19 08:28:19 -0800 (Tue, 19 Nov 2019)
Log Message
[ Jazz ] http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=203813
Reviewed by Alexey Proskuryakov.
Added console logging to narrow down cause of flaky test which does not
reproduce locally. Changed test expectations to timeout so the bots
actually run the test and the issue can be determined.
* http/tests/resourceLoadStatistics/cookie-deletion-expected.txt:
* http/tests/resourceLoadStatistics/cookie-deletion.html:
* platform/wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html
trunk/LayoutTests/platform/wk2/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (252629 => 252630)
--- trunk/LayoutTests/ChangeLog 2019-11-19 16:10:40 UTC (rev 252629)
+++ trunk/LayoutTests/ChangeLog 2019-11-19 16:28:19 UTC (rev 252630)
@@ -1,3 +1,19 @@
+2019-11-19 Kate Cheney
+
+[ Jazz ] http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=203813
+
+
+Reviewed by Alexey Proskuryakov.
+
+Added console logging to narrow down cause of flaky test which does not
+reproduce locally. Changed test expectations to timeout so the bots
+actually run the test and the issue can be determined.
+
+* http/tests/resourceLoadStatistics/cookie-deletion-expected.txt:
+* http/tests/resourceLoadStatistics/cookie-deletion.html:
+* platform/wk2/TestExpectations:
+
2019-11-19 Wenson Hsieh
[Clipboard API] Add support for Clipboard.readText()
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt (252629 => 252630)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt 2019-11-19 16:10:40 UTC (rev 252629)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt 2019-11-19 16:28:19 UTC (rev 252630)
@@ -1,3 +1,21 @@
+CONSOLE MESSAGE: line 116: Test is beginning. document.location.hash is empty.
+CONSOLE MESSAGE: line 122: About to call runTest() for the first time.
+CONSOLE MESSAGE: line 61: step1. About to set a cookie
+CONSOLE MESSAGE: line 126: About to call runTest() after cookie was set. document hash is #step2
+CONSOLE MESSAGE: line 66: step2. About to open an iFrame to test for third party cookie access (should be successful)
+CONSOLE MESSAGE: line 72: step3. About to classify localhost as prevalent
+CONSOLE MESSAGE: line 76: step3. In the callback for testRunner.setStatisticsPrevalentResource
+CONSOLE MESSAGE: line 83: step4. About to open an iFrame to test for third party cookie access (should not be successful)
+CONSOLE MESSAGE: line 89: step5. About to open an iFrame to try to set a cookie as a third party (should fail)
+CONSOLE MESSAGE: line 95: step6. About to open an iFrame and fireDataModificationHandlerAndContinue
+CONSOLE MESSAGE: line 39: In fireDataModificationHandlerAndContinue
+CONSOLE MESSAGE: line 44: Calling statisticsProcessStatisticsAndDataRecords
+CONSOLE MESSAGE: line 41: In callback function for installStatisticsDidScanDataRecordsCallback
+CONSOLE MESSAGE: line 101: step7. About to open an iFrame and setAsNonPrevalentAndContinue
+CONSOLE MESSAGE: line 49: In setAsNonPrevalentAndContinue
+CONSOLE MESSAGE: line 51: In callback function for setStatisticsPrevalentResource
+CONSOLE MESSAGE: line 107: step8. About to open an iFrame and confirm third party has no cookie access
+CONSOLE MESSAGE: line 24: in finishTest
Test for partitioned and unpartitioned cookie deletion.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html (252629 => 252630)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html 2019-11-19 16:10:40 UTC (rev 252629)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html 2019-11-19 16:28:19 UTC (rev 252630)
@@ -21,6 +21,7 @@
const subPathToGetCookies = "/get-cookies.php?name1=" + firstPartyCookieName + "&name2=" + thirdPartyCookieName;
function finishTest() {
+console.log("in finishTest")
setEnableFeature(false, finishJSTest);
}
@@ -35,14 +36,19 @@
function fireDataModificationHandlerAndContinue() {
+console.log("In fireDataModificationHandlerAndContinue")
testRunner.installStatisticsDidScanDataRecordsCallback(function() {
+console.log("In callback function for installStatisticsDidScanDataRecordsCallback")
setTimeout(runTest, 500);
});
+console.log("Calling statisticsProcessStatisticsAndDataRecords")
testRunn
[webkit-changes] [252631] trunk/Source/WebCore
Title: [252631] trunk/Source/WebCore
Revision 252631
Author cdu...@apple.com
Date 2019-11-19 08:30:49 -0800 (Tue, 19 Nov 2019)
Log Message
Unreviewed iOS build fix.
* style/StyleAdjuster.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleAdjuster.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252630 => 252631)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 16:28:19 UTC (rev 252630)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 16:30:49 UTC (rev 252631)
@@ -1,3 +1,9 @@
+2019-11-19 Chris Dumez
+
+Unreviewed iOS build fix.
+
+* style/StyleAdjuster.cpp:
+
2019-11-19 Antti Koivisto
Move RuleData to a file of its own
Modified: trunk/Source/WebCore/style/StyleAdjuster.cpp (252630 => 252631)
--- trunk/Source/WebCore/style/StyleAdjuster.cpp 2019-11-19 16:28:19 UTC (rev 252630)
+++ trunk/Source/WebCore/style/StyleAdjuster.cpp 2019-11-19 16:30:49 UTC (rev 252631)
@@ -50,6 +50,7 @@
#include "SVGNames.h"
#include "SVGURIReference.h"
#include "Settings.h"
+#include "Text.h"
namespace WebCore {
namespace Style {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252632] trunk
Title: [252632] trunk
Revision 252632
Author eric.carl...@apple.com
Date 2019-11-19 08:50:55 -0800 (Tue, 19 Nov 2019)
Log Message
OverConstrainedError is missing 'name' property
https://bugs.webkit.org/show_bug.cgi?id=204069
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
* web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https-expected.txt:
* web-platform-tests/mediacapture-streams/GUM-invalid-facing-mode.https-expected.txt:
* web-platform-tests/mediacapture-streams/MediaStreamTrack-applyConstraints.https-expected.txt:
Source/WebCore:
No new tests, existing test and results updated.
* Modules/mediastream/OverconstrainedError.h:
(WebCore::OverconstrainedError::name const):
* Modules/mediastream/OverconstrainedError.idl:
LayoutTests:
* fast/mediastream/MediaDevices-getUserMedia.html:
* fast/mediastream/overconstrainederror-constraint.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt
trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html
trunk/LayoutTests/fast/mediastream/overconstrainederror-constraint.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/GUM-invalid-facing-mode.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-applyConstraints.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/OverconstrainedError.h
trunk/Source/WebCore/Modules/mediastream/OverconstrainedError.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (252631 => 252632)
--- trunk/LayoutTests/ChangeLog 2019-11-19 16:30:49 UTC (rev 252631)
+++ trunk/LayoutTests/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
@@ -1,3 +1,13 @@
+2019-11-19 Eric Carlson
+
+OverConstrainedError is missing 'name' property
+https://bugs.webkit.org/show_bug.cgi?id=204069
+
+Reviewed by Youenn Fablet.
+
+* fast/mediastream/MediaDevices-getUserMedia.html:
+* fast/mediastream/overconstrainederror-constraint.html:
+
2019-11-19 Kate Cheney
[ Jazz ] http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
Modified: trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt (252631 => 252632)
--- trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt 2019-11-19 16:30:49 UTC (rev 252631)
+++ trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt 2019-11-19 16:50:55 UTC (rev 252632)
@@ -48,7 +48,7 @@
PASS navigator.mediaDevices.getUserMedia({audio:false, video:videoConstraints}).then(invalidGotStream).catch(errorWithConstraints2) did not throw exception.
PASS Error callback called.
-PASS errorArg.name is "Error"
+PASS errorArg.name is "OverconstrainedError"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html (252631 => 252632)
--- trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html 2019-11-19 16:30:49 UTC (rev 252631)
+++ trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia.html 2019-11-19 16:50:55 UTC (rev 252632)
@@ -35,7 +35,7 @@
function errorWithConstraints2(e) {
testPassed("Error callback called.");
errorArg = e;
-shouldBeEqualToString("errorArg.name", "Error");
+shouldBeEqualToString("errorArg.name", "OverconstrainedError");
finishJSTest();
}
Modified: trunk/LayoutTests/fast/mediastream/overconstrainederror-constraint.html (252631 => 252632)
--- trunk/LayoutTests/fast/mediastream/overconstrainederror-constraint.html 2019-11-19 16:30:49 UTC (rev 252631)
+++ trunk/LayoutTests/fast/mediastream/overconstrainederror-constraint.html 2019-11-19 16:50:55 UTC (rev 252632)
@@ -20,6 +20,7 @@
(e) => {
assert_true(e instanceof OverconstrainedError);
assert_equals(e.constraint, "", "constraint should be the empty string");
+assert_equals(e.name, "OverconstrainedError", "OverconstrainedError name is correct");
}
);
}, "Before grant");
@@ -31,6 +32,7 @@
(e) => {
assert_true(e instanceof OverconstrainedError);
assert_equals(e.constraint, "deviceId", "constraint should be deviceId");
+assert_equals(e.name, "OverconstrainedError", "OverconstrainedError name is correct");
}
);
}, "After grant");
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (252631 => 252632)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:30:49 UTC (rev 252631)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
@@ -1,3 +1,14 @@
+2019-11-19 Eric Carlson
+
+OverConstrainedError is missing 'name' prop
[webkit-changes] [252633] trunk
Title: [252633] trunk Revision 252633 Author sihui_...@apple.com Date 2019-11-19 08:51:33 -0800 (Tue, 19 Nov 2019) Log Message Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html https://bugs.webkit.org/show_bug.cgi?id=204313 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt: Source/WebCore: Add some logging to help debug the flaky timeout of bufferedAmount-unchanged-by-sync-xhr.any.worker.html on commit-queue bot. * Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail): (WebCore::WebSocketChannel::didFailSocketStream): * platform/network/cf/SocketStreamHandleImplCFNet.cpp: (WebCore::SocketStreamHandleImpl::scheduleStreams): (WebCore::SocketStreamHandleImpl::readStreamCallback): * testing/InternalSettings.cpp: (WebCore::InternalSettings::Backup::restoreTo):Remove a duplicate setting. Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): LayoutTests: * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp trunk/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp trunk/Source/WebCore/testing/InternalSettings.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Diff Modified: trunk/LayoutTests/ChangeLog (252632 => 252633) --- trunk/LayoutTests/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632) +++ trunk/LayoutTests/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633) @@ -1,3 +1,13 @@ +2019-11-19 Sihui Liu + +Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html +https://bugs.webkit.org/show_bug.cgi?id=204313 + +Reviewed by Alex Christensen. + +* platform/ios-wk2/TestExpectations: +* platform/mac-wk2/TestExpectations: + 2019-11-19 Eric Carlson OverConstrainedError is missing 'name' property Modified: trunk/LayoutTests/imported/w3c/ChangeLog (252632 => 252633) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633) @@ -1,3 +1,12 @@ +2019-11-19 Sihui Liu + +Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html +https://bugs.webkit.org/show_bug.cgi?id=204313 + +Reviewed by Alex Christensen. + +* web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt: + 2019-11-19 Eric Carlson OverConstrainedError is missing 'name' property Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt (252632 => 252633) --- trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt 2019-11-19 16:50:55 UTC (rev 252632) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt 2019-11-19 16:51:33 UTC (rev 252633) @@ -1,3 +1,3 @@ -FAIL bufferedAmount should not be updated during a sync XHR assert_unreached: open should succeed Reached unreachable code +FAIL bufferedAmount should not be updated during a sync XHR assert_equals: expected 5 but got 0 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (252632 => 252633) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-19 16:50:55 UTC (rev 252632) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-19 16:51:33 UTC (rev 252633) @@ -1314,8 +1314,6 @@ webkit.org/b/197662 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html [ Pass Failure ] -webkit.org/b/198774 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Failure ] - webkit.org/b/176030 http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ] webkit.org/b/199013 [ Debug ] imported/w3c/web-platform-tests/websockets/Create-Secure-verify-url-set-non-default-port.any.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (252632 => 252633) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-11-19 16:50:55 UTC (rev 252632) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-11-19 16:51:33 UTC (rev 252633) @@ -913,8 +913,6 @@ webkit.org/b/198663 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Pass Timeout ] -webkit.org/b/198774 imported/w3c/
[webkit-changes] [252634] trunk
Title: [252634] trunk
Revision 252634
Author bb...@apple.com
Date 2019-11-19 09:11:49 -0800 (Tue, 19 Nov 2019)
Log Message
[Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector attaches to a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=204300
Reviewed by Devin Rousso.
Source/WebKit:
Add a new UI delegate method to notify clients when local Web Inspector is about to be loaded.
This can be triggered by -[_WKInspector show] in the Cocoa API, or via the WebCore-controlled
Inspect context menu item.
The client can then configure Web Inspector using delegates or by setting _WKInspector properties.
Covered by new API test WebKit.DidNotifyWhenInspectorAttached.
* UIProcess/API/APIUIClient.h:
(API::UIClient::didAttachInspector):
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didAttachInspector):
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::openLocalInspectorFrontend):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(-[InspectorDelegate _webView:didAttachInspector:]):
(TEST): Add new test to ensure the delegate is called as expected.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIUIClient.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (252633 => 252634)
--- trunk/Source/WebKit/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633)
+++ trunk/Source/WebKit/ChangeLog 2019-11-19 17:11:49 UTC (rev 252634)
@@ -1,3 +1,29 @@
+2019-11-19 Brian Burg
+
+[Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector attaches to a WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=204300
+
+
+Reviewed by Devin Rousso.
+
+Add a new UI delegate method to notify clients when local Web Inspector is about to be loaded.
+This can be triggered by -[_WKInspector show] in the Cocoa API, or via the WebCore-controlled
+Inspect context menu item.
+
+The client can then configure Web Inspector using delegates or by setting _WKInspector properties.
+
+Covered by new API test WebKit.DidNotifyWhenInspectorAttached.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::didAttachInspector):
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::didAttachInspector):
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::openLocalInspectorFrontend):
+
2019-11-18 John Wilander
Check if ITP is on before applying third-party cookie blocking
Modified: trunk/Source/WebKit/UIProcess/API/APIUIClient.h (252633 => 252634)
--- trunk/Source/WebKit/UIProcess/API/APIUIClient.h 2019-11-19 16:51:33 UTC (rev 252633)
+++ trunk/Source/WebKit/UIProcess/API/APIUIClient.h 2019-11-19 17:11:49 UTC (rev 252634)
@@ -199,6 +199,8 @@
#if ENABLE(WEB_AUTHN)
virtual void runWebAuthenticationPanel(WebKit::WebPageProxy&, WebAuthenticationPanel&, WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, CompletionHandler&& completionHandler) { completionHandler(WebKit::WebAuthenticationPanelResult::Unavailable); }
#endif
+
+virtual void didAttachInspector(WebKit::WebPageProxy&, WebKit::WebInspectorProxy&) { }
};
} // namespace API
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (252633 => 252634)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2019-11-19 16:51:33 UTC (rev 252633)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2019-11-19 17:11:49 UTC (rev 252634)
@@ -203,7 +203,7 @@
*/
- (void)_webView:(WKWebView *)webView shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:(WKFrameInfo *)requestingFrame decisionHandler:(void (^)(BOOL))decisionHandler WK_API_AVAILABLE(ios(13.0));
-#else // TARGET_OS_IPHONE
+#else // !TARGET_OS_IPHONE
- (void)_prepareForImmediateActionAnimationForWebView:(WKWebView *)webView WK_API_AVAILABLE(macos(10.13.4));
- (void)_cancelImmediateActionAnimationForWebView:(WKWebView *)webView WK_API_AVAILABLE(macos(10.13.4));
- (void)_completeImmediateActionAnimationForWebView:(WKWebView *)webView WK_API_AVAILABLE(macos(10.13.4));
@@ -232,6 +232,11 @@
- (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element userInfo:(id )userInfo WK_API_DEPRECATED_WITH_REPLACEMENT("_webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:", macos(10.12, 10.14.4));
- (void)_webView:(WKWebView *)webView
[webkit-changes] [252635] trunk/Source/WebKit
Title: [252635] trunk/Source/WebKit Revision 252635 Author megan_gard...@apple.com Date 2019-11-19 10:10:34 -0800 (Tue, 19 Nov 2019) Log Message Unreviwed build fix for older bots. * Platform/spi/ios/UIKitSPI.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h Diff Modified: trunk/Source/WebKit/ChangeLog (252634 => 252635) --- trunk/Source/WebKit/ChangeLog 2019-11-19 17:11:49 UTC (rev 252634) +++ trunk/Source/WebKit/ChangeLog 2019-11-19 18:10:34 UTC (rev 252635) @@ -1,3 +1,11 @@ +2019-11-19 Megan Gardner + + + +Unreviwed build fix for older bots. + +* Platform/spi/ios/UIKitSPI.h: + 2019-11-19 Brian Burg [Cocoa] Add WKUIDelegate SPI to inform clients when a _WKInspector attaches to a WKWebView Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (252634 => 252635) --- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-11-19 17:11:49 UTC (rev 252634) +++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2019-11-19 18:10:34 UTC (rev 252635) @@ -449,11 +449,9 @@ @interface UITextInteractionAssistant () - (void)activateSelection; - (void)deactivateSelection; -- (void)didEndScrollingOrZooming; - (void)didEndScrollingOverflow; - (void)selectionChanged; - (void)setGestureRecognizers; -- (void)willStartScrollingOrZooming; - (void)willStartScrollingOverflow; @end @@ -,6 +1109,11 @@ #define UIWKDocumentRequestMarkedTextRects (1 << 5) +@interface UITextInteractionAssistant (Staging_55645619) +- (void)didEndScrollingOrZooming; +- (void)willStartScrollingOrZooming; +@end + #if HAVE(LINK_PREVIEW) && USE(UICONTEXTMENU) @interface UIContextMenuConfiguration (IPI) @property (nonatomic, copy) UIContextMenuContentPreviewProvider previewProvider; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252636] trunk/Source/WebKit
Title: [252636] trunk/Source/WebKit
Revision 252636
Author cdu...@apple.com
Date 2019-11-19 10:23:18 -0800 (Tue, 19 Nov 2019)
Log Message
Make sendWithAsyncReply() safe to call from any thread
https://bugs.webkit.org/show_bug.cgi?id=204355
Reviewed by Alex Christensen.
Make sendWithAsyncReply() safe to call from any thread, similarly to the regular send().
Also start using it in WebProcess::processTaskStateDidChange() now that it is safe.
* Platform/IPC/Connection.cpp:
(IPC::asyncReplyHandlerMapLock):
(IPC::asyncReplyHandlerMap):
(IPC::nextAsyncReplyHandlerID):
(IPC::addAsyncReplyHandler):
(IPC::clearAsyncReplyHandlers):
(IPC::CompletionHandler const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::operator* const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::operator bool const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::updateStrongReference): Deleted.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::processTaskStateDidChange):
(WebKit::WebProcess::parentProcessDidHandleProcessWasResumed): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp
trunk/Source/WebKit/Platform/IPC/Connection.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (252635 => 252636)
--- trunk/Source/WebKit/ChangeLog 2019-11-19 18:10:34 UTC (rev 252635)
+++ trunk/Source/WebKit/ChangeLog 2019-11-19 18:23:18 UTC (rev 252636)
@@ -1,3 +1,38 @@
+2019-11-19 Chris Dumez
+
+Make sendWithAsyncReply() safe to call from any thread
+https://bugs.webkit.org/show_bug.cgi?id=204355
+
+Reviewed by Alex Christensen.
+
+Make sendWithAsyncReply() safe to call from any thread, similarly to the regular send().
+Also start using it in WebProcess::processTaskStateDidChange() now that it is safe.
+
+* Platform/IPC/Connection.cpp:
+(IPC::asyncReplyHandlerMapLock):
+(IPC::asyncReplyHandlerMap):
+(IPC::nextAsyncReplyHandlerID):
+(IPC::addAsyncReplyHandler):
+(IPC::clearAsyncReplyHandlers):
+(IPC::CompletionHandler const): Deleted.
+(WebKit::WebProcessProxy::WeakOrStrongPtr::operator* const): Deleted.
+(WebKit::WebProcessProxy::WeakOrStrongPtr::operator bool const): Deleted.
+(WebKit::WebProcessProxy::WeakOrStrongPtr::updateStrongReference): Deleted.
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::processTaskStateDidChange):
+(WebKit::WebProcess::parentProcessDidHandleProcessWasResumed): Deleted.
+
2019-11-19 Megan Gardner
Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (252635 => 252636)
--- trunk/Source/WebKit/Platform/IPC/Connection.cpp 2019-11-19 18:10:34 UTC (rev 252635)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp 2019-11-19 18:23:18 UTC (rev 252636)
@@ -30,6 +30,7 @@
#include "MessageFlags.h"
#include
#include
+#include
#include
#include
#include
@@ -243,9 +244,15 @@
return map;
}
-static HashMap>>& asyncReplyHandlerMap()
+static Lock& asyncReplyHandlerMapLock()
{
-ASSERT(RunLoop::isMain());
+static Lock lock;
+return lock;
+}
+
+static HashMap>>& asyncReplyHandlerMap(const LockHolder&)
+{
+ASSERT(asyncReplyHandlerMapLock().isHeld());
static NeverDestroyed>>> map;
return map.get();
}
@@ -1118,15 +1125,14 @@
uint64_t nextAsyncReplyHandlerID()
{
-ASSERT(RunLoop::isMain());
-static uint64_t identifier { 0 };
+static std::atomic identifier { 0 };
return ++identifier;
}
void addAsyncReplyHandler(Connection& connection, uint64_t identifier, CompletionHandler&& completionHandler)
{
-RELEASE_ASSERT(RunLoop::isMain());
-auto result = asyncReplyHandlerMap().ensure(reinterpret_cast(&connection), [] {
+LockHolder locker(asyncReplyHandlerMapLock());
+auto result = asyncReplyHandlerMap(locker).ensure(reinterpret_cast(&connection), [] {
return HashMap>();
}).iterator->value.add(identifier, WTFMove(completionHandler));
ASSERT_UNUSED(result, result.isNewEntry);
@@ -1134,8 +1140,12 @@
void clearAsyncReplyHandlers(const Connection& connection)
{
-RELEASE_ASSERT(RunLoop::isMain());
-auto map = asyncReplyHandlerMap().take(reinterpret_cast(&connection));
+HashMap> map;
+{
+LockHolder locker(asyncReplyHandlerMapLock());
+map = asyncReplyHandlerMap(locker).take(reinterpret_cast(&connection));
+}
+
for (auto& handler : map.values()) {
if (handler)
handler(nul
[webkit-changes] [252637] trunk/Source
Title: [252637] trunk/Source
Revision 252637
Author bb...@apple.com
Date 2019-11-19 10:41:31 -0800 (Tue, 19 Nov 2019)
Log Message
[Cocoa] Add _WKInspector SPI to set diagnostic logging delegate for a local Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=204323
Reviewed by Devin Rousso.
Source/WebInspectorUI:
* UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setDiagnosticLoggingAvailable):
Add a stub FrontendAPI method to be filled in later.
Source/WebKit:
Testing this end-to-end isn't quite possible yet because WebInspectorUI does not
yet send any dummy diagnostic events that we can use for testing purposes.
* WebKit.xcodeproj/project.pbxproj:
* UIProcess/API/Cocoa/_WKInspectorInternal.h: Fix include.
* UIProcess/API/Cocoa/_WKInspectorPrivate.h: Added.
* UIProcess/API/Cocoa/_WKInspector.mm: Fix include.
(-[_WKInspector _setDiagnosticLoggingDelegate:]):
Allow clients to set the diagnosticLoggingDelegate directly on _WKInspector.
The implementation forwards this setter to the Inspector's WKWebView and notifies
the frontend that diagnostic logging availability did change.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setDiagnosticLoggingAvailable):
Plumbing.
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::setDiagnosticLoggingAvailable):
* WebProcess/WebPage/WebInspectorUI.h:
* WebProcess/WebPage/WebInspectorUI.messages.in:
More plumbing.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h
trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit/UIProcess/WebInspectorProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.h
trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in
Added Paths
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (252636 => 252637)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-11-19 18:23:18 UTC (rev 252636)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-19 18:41:31 UTC (rev 252637)
@@ -1,3 +1,14 @@
+2019-11-19 Brian Burg
+
+[Cocoa] Add _WKInspector SPI to set diagnostic logging delegate for a local Web Inspector
+https://bugs.webkit.org/show_bug.cgi?id=204323
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Protocol/InspectorFrontendAPI.js:
+(InspectorFrontendAPI.setDiagnosticLoggingAvailable):
+Add a stub FrontendAPI method to be filled in later.
+
2019-11-18 Devin Rousso
Web Inspector: Elements: copying multiple DOM nodes should copy more than just the last selected node
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js (252636 => 252637)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2019-11-19 18:23:18 UTC (rev 252636)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2019-11-19 18:41:31 UTC (rev 252637)
@@ -75,6 +75,11 @@
WI.updateVisibilityState(visible);
},
+setDiagnosticLoggingAvailable: function(available)
+{
+// FIXME: update diagnostic availability and start/stop diagnostic recorders.
+},
+
showConsole: function()
{
WI.showConsoleTab();
Modified: trunk/Source/WebKit/ChangeLog (252636 => 252637)
--- trunk/Source/WebKit/ChangeLog 2019-11-19 18:23:18 UTC (rev 252636)
+++ trunk/Source/WebKit/ChangeLog 2019-11-19 18:41:31 UTC (rev 252637)
@@ -1,3 +1,34 @@
+2019-11-19 Brian Burg
+
+[Cocoa] Add _WKInspector SPI to set diagnostic logging delegate for a local Web Inspector
+https://bugs.webkit.org/show_bug.cgi?id=204323
+
+Reviewed by Devin Rousso.
+
+Testing this end-to-end isn't quite possible yet because WebInspectorUI does not
+yet send any dummy diagnostic events that we can use for testing purposes.
+
+* WebKit.xcodeproj/project.pbxproj:
+
+* UIProcess/API/Cocoa/_WKInspectorInternal.h: Fix include.
+* UIProcess/API/Cocoa/_WKInspectorPrivate.h: Added.
+* UIProcess/API/Cocoa/_WKInspector.mm: Fix include.
+(-[_WKInspector _setDiagnosticLoggingDelegate:]):
+Allow clients to set the diagnosticLoggingDelegate directly on _WKInspector.
+The implementation forwards this setter to the Inspector's WKWebView and notifies
+the frontend that diagnostic logging availability did change.
+
+* UIProcess/WebInspectorProxy.h:
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::setDiagnosticLoggingAvailable):
+Plumbing.
+
+* WebProcess/WebPage/WebInspectorUI.cpp:
+
[webkit-changes] [252638] trunk/Source/WebCore
Title: [252638] trunk/Source/WebCore
Revision 252638
Author za...@apple.com
Date 2019-11-19 10:58:04 -0800 (Tue, 19 Nov 2019)
Log Message
[LFC][IFC] Assign inlineCapacity to various inline run vectors.
https://bugs.webkit.org/show_bug.cgi?id=204354
Reviewed by Antti Koivisto.
Inline capacity values are mainly based off of the equivalent simple line layout vectors.
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
* layout/inlineformatting/InlineFormattingState.h:
* layout/inlineformatting/InlineLine.h:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRendererStyle): Apparently 'newStyle' is moved out at this point.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h
trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLine.h
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/InlineLineLayout.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252637 => 252638)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 18:41:31 UTC (rev 252637)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 18:58:04 UTC (rev 252638)
@@ -1,3 +1,20 @@
+2019-11-19 Zalan Bujtas
+
+[LFC][IFC] Assign inlineCapacity to various inline run vectors.
+https://bugs.webkit.org/show_bug.cgi?id=204354
+
+
+Reviewed by Antti Koivisto.
+
+Inline capacity values are mainly based off of the equivalent simple line layout vectors.
+
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
+* layout/inlineformatting/InlineFormattingState.h:
+* layout/inlineformatting/InlineLine.h:
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::updateRendererStyle): Apparently 'newStyle' is moved out at this point.
+
2019-11-19 Sihui Liu
Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h (252637 => 252638)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h 2019-11-19 18:41:31 UTC (rev 252637)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h 2019-11-19 18:58:04 UTC (rev 252638)
@@ -38,9 +38,9 @@
namespace Layout {
// Temp
-using InlineItems = Vector>;
-using InlineRuns = Vector>;
-using LineBoxes = Vector>;
+using InlineItems = Vector, 30>;
+using InlineRuns = Vector, 10>;
+using LineBoxes = Vector, 5>;
// InlineFormattingState holds the state for a particular inline formatting context tree.
class InlineFormattingState : public FormattingState {
WTF_MAKE_ISO_ALLOCATED(InlineFormattingState);
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (252637 => 252638)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-11-19 18:41:31 UTC (rev 252637)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-11-19 18:58:04 UTC (rev 252638)
@@ -86,7 +86,7 @@
}
Line::Run::Run(const Box& layoutBox, InlineItem::Type type, const Display::Rect& logicalRect)
-: m_layoutBox(layoutBox)
+: m_layoutBox(&layoutBox)
, m_type(type)
, m_logicalRect(logicalRect)
{
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.h (252637 => 252638)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.h 2019-11-19 18:41:31 UTC (rev 252637)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.h 2019-11-19 18:58:04 UTC (rev 252638)
@@ -68,6 +68,9 @@
void moveLogicalRight(LayoutUnit);
struct Run {
+Run(Run&&) = default;
+Run& operator=(Run&& other) = default;
+
bool isText() const { return m_type == InlineItem::Type::Text; }
bool isBox() const { return m_type == InlineItem::Type::Box; }
bool isForcedLineBreak() const { return m_type == InlineItem::Type::ForcedLineBreak; }
@@ -74,7 +77,7 @@
bool isContainerStart() const { return m_type == InlineItem::Type::ContainerStart; }
bool isContainerEnd() const { return m_type == InlineItem::Type::ContainerEnd; }
-const Box& layoutBox() const { return m_layoutBox; }
+const Box& layoutBox() const { return *m_layoutBox; }
const Display::Rect& logicalRect() const { return m_logicalRect; }
Optional textContext() const { return m_textContext; }
bool isCollapsedToVisuallyEmpty() const { return m_isCollapsedToVisuallyEmpty; }
@@ -98,14 +101,14 @@
void setComputedHorizontalExpansion(LayoutUnit logicalExpansion);
void adjustExpansionBehavior(ExpansionBehavior);
-cons
[webkit-changes] [252639] trunk/Source/WebCore
Title: [252639] trunk/Source/WebCore Revision 252639 Author an...@apple.com Date 2019-11-19 11:04:38 -0800 (Tue, 19 Nov 2019) Log Message Rename CSSDefaultStyleSheets to UserAgentStyle https://bugs.webkit.org/show_bug.cgi?id=204357 Reviewed by Zalan Bujtas. Also move it to Style namespace and directory, along with InspectorCSSOMWrappers. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * page/ProcessWarming.cpp: (WebCore::ProcessWarming::prewarmGlobally): * style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::matchUARules): * style/InspectorCSSOMWrappers.cpp: Renamed from Source/WebCore/css/InspectorCSSOMWrappers.cpp. (WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers): (WebCore::Style::InspectorCSSOMWrappers::collectScopeWrappers): * style/InspectorCSSOMWrappers.h: Renamed from Source/WebCore/css/InspectorCSSOMWrappers.h. * style/PageRuleCollector.cpp: (WebCore::Style::PageRuleCollector::matchAllPageRules): * style/RuleData.h: * style/RuleSet.h: * style/StyleResolver.cpp: (WebCore::Style::Resolver::Resolver): (WebCore::Style::Resolver::styleForElement): * style/StyleScopeRuleSets.cpp: (WebCore::Style::ScopeRuleSets::updateUserAgentMediaQueryStyleIfNeeded const): (WebCore::Style::ScopeRuleSets::collectFeatures const): * style/StyleScopeRuleSets.h: (WebCore::Style::ScopeRuleSets::features const): (WebCore::Style::ScopeRuleSets::mutableFeatures): * style/StyleSharingResolver.h: * style/UserAgentStyle.cpp: Renamed from Source/WebCore/css/CSSDefaultStyleSheets.cpp. (WebCore::Style::UserAgentStyle::initDefaultStyle): (WebCore::Style::UserAgentStyle::addToDefaultStyle): (WebCore::Style::UserAgentStyle::loadFullDefaultStyle): (WebCore::Style::UserAgentStyle::loadSimpleDefaultStyle): (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): * style/UserAgentStyle.h: Renamed from Source/WebCore/css/CSSDefaultStyleSheets.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/ProcessWarming.cpp trunk/Source/WebCore/style/ElementRuleCollector.cpp trunk/Source/WebCore/style/PageRuleCollector.cpp trunk/Source/WebCore/style/RuleData.h trunk/Source/WebCore/style/RuleSet.h trunk/Source/WebCore/style/StyleResolver.cpp trunk/Source/WebCore/style/StyleScopeRuleSets.cpp trunk/Source/WebCore/style/StyleScopeRuleSets.h trunk/Source/WebCore/style/StyleSharingResolver.h Added Paths trunk/Source/WebCore/style/InspectorCSSOMWrappers.cpp trunk/Source/WebCore/style/InspectorCSSOMWrappers.h trunk/Source/WebCore/style/UserAgentStyle.cpp trunk/Source/WebCore/style/UserAgentStyle.h Removed Paths trunk/Source/WebCore/css/CSSDefaultStyleSheets.cpp trunk/Source/WebCore/css/CSSDefaultStyleSheets.h trunk/Source/WebCore/css/InspectorCSSOMWrappers.cpp trunk/Source/WebCore/css/InspectorCSSOMWrappers.h Diff Modified: trunk/Source/WebCore/ChangeLog (252638 => 252639) --- trunk/Source/WebCore/ChangeLog 2019-11-19 18:58:04 UTC (rev 252638) +++ trunk/Source/WebCore/ChangeLog 2019-11-19 19:04:38 UTC (rev 252639) @@ -1,3 +1,44 @@ +2019-11-19 Antti Koivisto + +Rename CSSDefaultStyleSheets to UserAgentStyle +https://bugs.webkit.org/show_bug.cgi?id=204357 + +Reviewed by Zalan Bujtas. + +Also move it to Style namespace and directory, along with InspectorCSSOMWrappers. + +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* page/ProcessWarming.cpp: +(WebCore::ProcessWarming::prewarmGlobally): +* style/ElementRuleCollector.cpp: +(WebCore::Style::ElementRuleCollector::matchUARules): +* style/InspectorCSSOMWrappers.cpp: Renamed from Source/WebCore/css/InspectorCSSOMWrappers.cpp. +(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers): +(WebCore::Style::InspectorCSSOMWrappers::collectScopeWrappers): +* style/InspectorCSSOMWrappers.h: Renamed from Source/WebCore/css/InspectorCSSOMWrappers.h. +* style/PageRuleCollector.cpp: +(WebCore::Style::PageRuleCollector::matchAllPageRules): +* style/RuleData.h: +* style/RuleSet.h: +* style/StyleResolver.cpp: +(WebCore::Style::Resolver::Resolver): +(WebCore::Style::Resolver::styleForElement): +* style/StyleScopeRuleSets.cpp: +(WebCore::Style::ScopeRuleSets::updateUserAgentMediaQueryStyleIfNeeded const): +(WebCore::Style::ScopeRuleSets::collectFeatures const): +* style/StyleScopeRuleSets.h: +(WebCore::Style::ScopeRuleSets::features const): +(WebCore::Style::ScopeRuleSets::mutableFeatures): +* style/StyleSharingResolver.h: +* style/UserAgentStyle.cpp: Renamed from Source/WebCore/css/CSSDefaultStyleSheets.cpp. +(WebCore::Style::UserAgentStyle::initDefaultStyle): +(WebCore::Style::UserAgentStyle::addToDefaultStyle): +(WebCore::Style::UserAgentStyle::loadFullDefaultStyle): +(W
[webkit-changes] [252640] trunk/Source/WebCore
Title: [252640] trunk/Source/WebCore
Revision 252640
Author za...@apple.com
Date 2019-11-19 12:00:28 -0800 (Tue, 19 Nov 2019)
Log Message
[LFC][IFC] Display::Run:TextContext should use StringView
https://bugs.webkit.org/show_bug.cgi?id=204356
Reviewed by Antti Koivisto.
We could just use StringView instead of String here (though this is all temporary until We figure out the relationship
between the layout and the display trees e.g. how to reference content from the display tree).
* layout/displaytree/DisplayRun.h:
(WebCore::Display::Run::TextContext::TextContext):
(WebCore::Display::Run::TextContext::content const):
(WebCore::Display::Run::TextContext::expand):
* layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::expand):
(WebCore::Layout::Line::appendTextContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/displaytree/DisplayRun.h
trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252639 => 252640)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 19:04:38 UTC (rev 252639)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 20:00:28 UTC (rev 252640)
@@ -1,3 +1,22 @@
+2019-11-19 Zalan Bujtas
+
+[LFC][IFC] Display::Run:TextContext should use StringView
+https://bugs.webkit.org/show_bug.cgi?id=204356
+
+
+Reviewed by Antti Koivisto.
+
+We could just use StringView instead of String here (though this is all temporary until We figure out the relationship
+between the layout and the display trees e.g. how to reference content from the display tree).
+
+* layout/displaytree/DisplayRun.h:
+(WebCore::Display::Run::TextContext::TextContext):
+(WebCore::Display::Run::TextContext::content const):
+(WebCore::Display::Run::TextContext::expand):
+* layout/inlineformatting/InlineLine.cpp:
+(WebCore::Layout::Line::Run::expand):
+(WebCore::Layout::Line::appendTextContent):
+
2019-11-19 Antti Koivisto
Rename CSSDefaultStyleSheets to UserAgentStyle
Modified: trunk/Source/WebCore/layout/displaytree/DisplayRun.h (252639 => 252640)
--- trunk/Source/WebCore/layout/displaytree/DisplayRun.h 2019-11-19 19:04:38 UTC (rev 252639)
+++ trunk/Source/WebCore/layout/displaytree/DisplayRun.h 2019-11-19 20:00:28 UTC (rev 252640)
@@ -44,12 +44,12 @@
WTF_MAKE_STRUCT_FAST_ALLOCATED;
public:
struct ExpansionContext;
-TextContext(unsigned position, unsigned length, String content, Optional = { });
+TextContext(unsigned position, unsigned length, StringView content, Optional = { });
unsigned start() const { return m_start; }
unsigned end() const { return start() + length(); }
unsigned length() const { return m_length; }
-String content() const { return m_content; }
+StringView content() const { return m_content; }
struct ExpansionContext {
ExpansionBehavior behavior;
@@ -58,7 +58,7 @@
void setExpansion(ExpansionContext expansionContext) { m_expansionContext = expansionContext; }
Optional expansion() const { return m_expansionContext; }
-void expand(const TextContext& other);
+void expand(StringView, unsigned expandedLength);
private:
unsigned m_start { 0 };
@@ -65,7 +65,7 @@
unsigned m_length { 0 };
Optional m_expansionContext;
// FIXME: This is temporary. We should have some mapping setup to identify associated text content instead.
-String m_content;
+StringView m_content;
};
Run(const RenderStyle&, const Rect& logicalRect, Optional = WTF::nullopt);
@@ -114,7 +114,7 @@
{
}
-inline Run::TextContext::TextContext(unsigned start, unsigned length, String content, Optional expansionContext)
+inline Run::TextContext::TextContext(unsigned start, unsigned length, StringView content, Optional expansionContext)
: m_start(start)
, m_length(length)
, m_expansionContext(expansionContext)
@@ -122,10 +122,10 @@
{
}
-inline void Run::TextContext::expand(const TextContext& other)
+inline void Run::TextContext::expand(StringView text, unsigned expandedLength)
{
-m_content.append(other.content());
-m_length += other.length();
+m_length = expandedLength;
+m_content = text;
}
}
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (252639 => 252640)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-11-19 19:04:38 UTC (rev 252639)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2019-11-19 20:00:28 UTC (rev 252640)
@@ -130,7 +130,8 @@
ASSERT(!isCollapsedToVisuallyEmpty());
m_logicalRect.expandHorizontally(nextRun.logicalRect().width());
-m_textContext->expand(*nextRun.textContext());
+auto expandedLength = m_textContext->length() + nextRun.textContext()->length();
+m_textContext->expand(StringView(l
[webkit-changes] [252641] trunk
Title: [252641] trunk Revision 252641 Author wilan...@apple.com Date 2019-11-19 12:35:21 -0800 (Tue, 19 Nov 2019) Log Message Resource Load Statistics: Count third-party script loads under top frame https://bugs.webkit.org/show_bug.cgi?id=204262 Reviewed by Alex Christensen. Source/WebCore: Third-party scripts running in the first-party context are a significant privacy and security risk. This change captures the number of such script loads which will allow ITP to take action. Tests: http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database.html http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker.html http/tests/resourceLoadStatistics/count-third-party-script-loads-database.html http/tests/resourceLoadStatistics/count-third-party-script-loads.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Now sends the ResourceLoadObserver::FetchDestinationIsScriptLike parameter to ResourceLoadObserver::logSubresourceLoading(). * loader/ResourceLoadObserver.h: (WebCore::ResourceLoadObserver::logSubresourceLoading): Now takes a FetchDestinationIsScriptLike parameter. * loader/ResourceLoadStatistics.cpp: (WebCore::ResourceLoadStatistics::encode const): (WebCore::ResourceLoadStatistics::decode): (WebCore::ResourceLoadStatistics::toString const): Output of the new topFrameLoadedThirdPartyScripts category. Removed the lastSeen output since it may differ between test runs. (WebCore::ResourceLoadStatistics::merge): Handling of the new topFrameLoadedThirdPartyScripts category. * loader/ResourceLoadStatistics.h: Added the new topFrameLoadedThirdPartyScripts category. * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequestInternal): Now sends the ResourceLoadObserver::FetchDestinationIsScriptLike parameter to ResourceLoadObserver::logSubresourceLoading(). Source/WebKit: Third-party scripts running in the first-party context are a significant privacy and security risk. This change captures the number of such script loads which will allow ITP to take action. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore): (WebKit::ResourceLoadStatisticsDatabaseStore::createUniqueIndices): (WebKit::ResourceLoadStatisticsDatabaseStore::createSchema): (WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements): (WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationships): (WebKit::ResourceLoadStatisticsDatabaseStore::getSubStatisticStatement): Addition of the new category TopFrameLoadedThirdPartyScripts. (WebKit::ResourceLoadStatisticsDatabaseStore::resourceToString): Removed the lastSeen output since it may differ between test runs. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h: * NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: Bumped statisticsModelVersion to 17. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): Encoding and decoding of the new category topFrameLoadedThirdPartyScripts. * WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: (WebKit::WebResourceLoadObserver::logSubresourceLoading): Now takes an additional enum parameter FetchDestinationIsScriptLike which is used to detect third-party script-like loads (script, worker, or service worker) from third-parties. If one is detected, it is stored in the new topFrameLoadedThirdPartyScripts category. * WebProcess/WebCoreSupport/WebResourceLoadObserver.h: LayoutTests: * http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database-expected.txt: Added. * http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database.html: Added. * http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-expected.txt: Added. * http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker.html: Added. * http/tests/resourceLoadStatistics/count-third-party-script-loads-database-expected.txt: Added. * http/tests/resourceLoadStatistics/count-third-party-script-loads-database.html: Added. * http/tests/resourceLoadStatistics/count-third-party-script-loads-expected.txt: Added. * http/tests/resourceLoadStatistics/count-third-party-script-loads.html: Added. * http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-database-expected.txt: Added. * http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-database.html: Added. * http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-expected.txt: Added. * http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script.html: Added. * http/tests/resourceLoadStatistics/log-cross-site-load-with-link-decoration-database-expected.txt: Removed the lastSeen output since it may differ be
[webkit-changes] [252643] trunk/Source/WebKit
Title: [252643] trunk/Source/WebKit Revision 252643 Author pvol...@apple.com Date 2019-11-19 13:00:21 -0800 (Tue, 19 Nov 2019) Log Message [iOS] Fix sysctl-read sandbox violation https://bugs.webkit.org/show_bug.cgi?id=204358 Reviewed by Brent Fulgham. The WebContent sandbox should allow sysctl-read of "kern.hostname", "kern.osrelease", and "kern.version". * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (252642 => 252643) --- trunk/Source/WebKit/ChangeLog 2019-11-19 20:53:34 UTC (rev 252642) +++ trunk/Source/WebKit/ChangeLog 2019-11-19 21:00:21 UTC (rev 252643) @@ -1,3 +1,15 @@ +2019-11-19 Per Arne Vollan + +[iOS] Fix sysctl-read sandbox violation +https://bugs.webkit.org/show_bug.cgi?id=204358 + + +Reviewed by Brent Fulgham. + +The WebContent sandbox should allow sysctl-read of "kern.hostname", "kern.osrelease", and "kern.version". + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2019-11-19 John Wilander Resource Load Statistics: Count third-party script loads under top frame Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (252642 => 252643) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-11-19 20:53:34 UTC (rev 252642) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-11-19 21:00:21 UTC (rev 252643) @@ -849,10 +849,13 @@ "hw.physicalcpu" "hw.physicalcpu_max" "kern.bootargs" +"kern.hostname" "kern.memorystatus_level" "kern.osproductversion" +"kern.osrelease" "kern.osvariant_status" "kern.secure_kernel" +"kern.version" "vm.footprint_suspend")) (allow iokit-get-properties ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252644] trunk/Tools
Title: [252644] trunk/Tools
Revision 252644
Author aakash_j...@apple.com
Date 2019-11-19 13:21:41 -0800 (Tue, 19 Nov 2019)
Log Message
Disable reporting EWS test failures from clean-tree to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=204369
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTestsWithoutPatch):
(RunAPITestsWithoutPatch.evaluateCommand):
(RunWebKitTestsWithoutPatch.start): Deleted.
(RunAPITestsWithoutPatch.start): Deleted.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
* BuildSlaveSupport/ews-build/loadConfig.py:
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py (252643 => 252644)
--- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-19 21:00:21 UTC (rev 252643)
+++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-19 21:21:41 UTC (rev 252644)
@@ -46,9 +46,6 @@
passwords = {}
else:
passwords = json.load(open(os.path.join(master_prefix_path, 'passwords.json')))
-results_server_api_key = passwords.get('results-server-api-key')
-if results_server_api_key:
-os.environ['RESULTS_SERVER_API_KEY'] = results_server_api_key
checkWorkersAndBuildersForConsistency(config, config['workers'], config['builders'])
checkValidSchedulers(config, config['schedulers'])
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (252643 => 252644)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-19 21:00:21 UTC (rev 252643)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-19 21:21:41 UTC (rev 252644)
@@ -31,7 +31,6 @@
from layout_test_failures import LayoutTestFailures
import json
-import os
import re
import requests
@@ -40,8 +39,6 @@
EWS_URL = 'https://ews-build.webkit.org/'
WithProperties = properties.WithProperties
Interpolate = properties.Interpolate
-RESULTS_WEBKIT_URL = 'https://results.webkit.org'
-RESULTS_SERVER_API_KEY = 'RESULTS_SERVER_API_KEY'
class ConfigureBuild(buildstep.BuildStep):
@@ -1342,16 +1339,6 @@
class RunWebKitTestsWithoutPatch(RunWebKitTests):
name = 'run-layout-tests-without-patch'
-def start(self):
-self.workerEnvironment[RESULTS_SERVER_API_KEY] = os.getenv(RESULTS_SERVER_API_KEY)
-self.setCommand(self.command +
-['--buildbot-master', EWS_URL.replace('https://', '').strip('/'),
-'--builder-name', self.getProperty('buildername'),
-'--build-number', self.getProperty('buildnumber'),
-'--buildbot-worker', self.getProperty('workername'),
-'--report', RESULTS_WEBKIT_URL])
-return super(RunWebKitTestsWithoutPatch, self).start()
-
def evaluateCommand(self, cmd):
rc = shell.Test.evaluateCommand(self, cmd)
self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(identifier='clean-tree'), ExtractTestResults(identifier='clean-tree'), AnalyzeLayoutTestsResults()])
@@ -1670,17 +1657,7 @@
def evaluateCommand(self, cmd):
return TestWithFailureCount.evaluateCommand(self, cmd)
-def start(self):
-self.workerEnvironment[RESULTS_SERVER_API_KEY] = os.getenv(RESULTS_SERVER_API_KEY)
-self.setCommand(self.command +
-['--buildbot-master', EWS_URL.replace('https://', '').strip('/'),
-'--builder-name', self.getProperty('buildername'),
-'--build-number', self.getProperty('buildnumber'),
-'--buildbot-worker', self.getProperty('workername'),
-'--report', RESULTS_WEBKIT_URL])
-return super(RunAPITestsWithoutPatch, self).start()
-
class AnalyzeAPITestsResults(buildstep.BuildStep):
name = 'analyze-api-tests-results'
description = ['analyze-api-test-results']
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (252643 => 252644)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-19 21:00:21 UTC (rev 252643)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-19 21:21:41 UTC (rev 252644)
@@ -1504,7 +1504,6 @@
self.setProperty('buildername', 'iOS-13-Simulator-WK2-Tests-EWS')
self.setProperty('buildnumber', '123')
self.setProperty('workername', 'ews126')
-os.environ['RESULTS_SERVER_API_KEY'] = 'sample-key'
def test_success(self):
self.configureStep()
@@ -1513,7 +1512,6 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logfiles={'json': self.jsonFileName},
-env={'RESULTS_SERVER_API_KEY': 'sample-key'},
logEnviron=False,
command=['python',
'Tools/Scripts/run-webkit-tests',
@@ -1524,11 +1522,6 @@
[webkit-changes] [252645] trunk/LayoutTests
Title: [252645] trunk/LayoutTests Revision 252645 Author wenson_hs...@apple.com Date 2019-11-19 13:36:54 -0800 (Tue, 19 Nov 2019) Log Message fast/events/touch/ios/long-press-on-link.html times out after r251693 https://bugs.webkit.org/show_bug.cgi?id=204365 Reviewed by Megan Gardner. The change in trac.webkit.org/r251693 inadvertently fixed a failing layout test, fast/events/touch/ios/ long-press-on-image.html. In doing so, it caused the subsequent layout test, long-press-on-link.html, to begin failing, since both tests depend on the previous test not presenting a context menu when long pressing; if the previous test presents a context menu, the next test will proceed while the context menu is still dismissing, which prevents the touches from making it to the web view. To fix this, simply mark both tests as `runSingly` in test options; this forces context menu UI to be torn down after running these two tests, so that these tests won't have side effects when they successfully show a context menu. * fast/events/touch/ios/long-press-on-image.html: * fast/events/touch/ios/long-press-on-link.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html Diff Modified: trunk/LayoutTests/ChangeLog (252644 => 252645) --- trunk/LayoutTests/ChangeLog 2019-11-19 21:21:41 UTC (rev 252644) +++ trunk/LayoutTests/ChangeLog 2019-11-19 21:36:54 UTC (rev 252645) @@ -1,3 +1,24 @@ +2019-11-19 Wenson Hsieh + +fast/events/touch/ios/long-press-on-link.html times out after r251693 +https://bugs.webkit.org/show_bug.cgi?id=204365 + + +Reviewed by Megan Gardner. + +The change in trac.webkit.org/r251693 inadvertently fixed a failing layout test, fast/events/touch/ios/ +long-press-on-image.html. In doing so, it caused the subsequent layout test, long-press-on-link.html, to begin +failing, since both tests depend on the previous test not presenting a context menu when long pressing; if the +previous test presents a context menu, the next test will proceed while the context menu is still dismissing, +which prevents the touches from making it to the web view. + +To fix this, simply mark both tests as `runSingly` in test options; this forces context menu UI to be torn down +after running these two tests, so that these tests won't have side effects when they successfully show a context +menu. + +* fast/events/touch/ios/long-press-on-image.html: +* fast/events/touch/ios/long-press-on-link.html: + 2019-11-19 John Wilander Resource Load Statistics: Count third-party script loads under top frame Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html (252644 => 252645) --- trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html 2019-11-19 21:21:41 UTC (rev 252644) +++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html 2019-11-19 21:36:54 UTC (rev 252645) @@ -1,4 +1,4 @@ - + Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html (252644 => 252645) --- trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html 2019-11-19 21:21:41 UTC (rev 252644) +++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html 2019-11-19 21:36:54 UTC (rev 252645) @@ -1,4 +1,4 @@ - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252646] trunk/Source/WebCore
Title: [252646] trunk/Source/WebCore Revision 252646 Author rn...@webkit.org Date 2019-11-19 13:57:52 -0800 (Tue, 19 Nov 2019) Log Message Rename AbstractEventLoop to EventLoop and move to its own cpp file https://bugs.webkit.org/show_bug.cgi?id=204335 Reviewed by Antti Koivisto. This patch renames AbstractEventLoop to EventLoop and move to its own cpp file since r252607 consolidated the event loop implementations in WindowEventLoop and WorkerEventLoop. * Modules/cache/DOMCache.cpp: * Modules/cache/DOMCacheStorage.cpp: * Modules/encryptedmedia/MediaKeySession.cpp: * Modules/encryptedmedia/MediaKeys.cpp: * Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * animation/WebAnimation.cpp: * bindings/js/JSDOMPromiseDeferred.h: * css/FontFaceSet.cpp: * dom/ActiveDOMObject.cpp: * dom/Document.h: * dom/ScriptExecutionContext.h: * dom/WindowEventLoop.cpp: (WebCore::AbstractEventLoop::queueTask): Deleted. (WebCore::AbstractEventLoop::resumeGroup): Deleted. (WebCore::AbstractEventLoop::stopGroup): Deleted. (WebCore::AbstractEventLoop::scheduleToRunIfNeeded): Deleted. (WebCore::AbstractEventLoop::run): Deleted. (WebCore::AbstractEventLoop::clearAllTasks): Deleted. (WebCore::EventLoopFunctionDispatchTask::EventLoopFunctionDispatchTask): Deleted. (WebCore::EventLoopTaskGroup::queueTask): Deleted. * dom/WindowEventLoop.h: * fileapi/FileReader.cpp: * testing/Internals.cpp: * workers/WorkerEventLoop.h: * workers/service/ServiceWorkerContainer.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/cache/DOMCache.cpp trunk/Source/WebCore/Modules/cache/DOMCacheStorage.cpp trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/animation/WebAnimation.cpp trunk/Source/WebCore/bindings/js/JSDOMPromiseDeferred.h trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/dom/ActiveDOMObject.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/ScriptExecutionContext.h trunk/Source/WebCore/dom/WindowEventLoop.cpp trunk/Source/WebCore/dom/WindowEventLoop.h trunk/Source/WebCore/fileapi/FileReader.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/workers/WorkerEventLoop.h trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp Added Paths trunk/Source/WebCore/dom/EventLoop.cpp trunk/Source/WebCore/dom/EventLoop.h Removed Paths trunk/Source/WebCore/dom/AbstractEventLoop.h Diff Modified: trunk/Source/WebCore/ChangeLog (252645 => 252646) --- trunk/Source/WebCore/ChangeLog 2019-11-19 21:36:54 UTC (rev 252645) +++ trunk/Source/WebCore/ChangeLog 2019-11-19 21:57:52 UTC (rev 252646) @@ -1,3 +1,41 @@ +2019-11-18 Ryosuke Niwa + +Rename AbstractEventLoop to EventLoop and move to its own cpp file +https://bugs.webkit.org/show_bug.cgi?id=204335 + +Reviewed by Antti Koivisto. + +This patch renames AbstractEventLoop to EventLoop and move to its own cpp file since +r252607 consolidated the event loop implementations in WindowEventLoop and WorkerEventLoop. + +* Modules/cache/DOMCache.cpp: +* Modules/cache/DOMCacheStorage.cpp: +* Modules/encryptedmedia/MediaKeySession.cpp: +* Modules/encryptedmedia/MediaKeys.cpp: +* Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp: +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* animation/WebAnimation.cpp: +* bindings/js/JSDOMPromiseDeferred.h: +* css/FontFaceSet.cpp: +* dom/ActiveDOMObject.cpp: +* dom/Document.h: +* dom/ScriptExecutionContext.h: +* dom/WindowEventLoop.cpp: +(WebCore::AbstractEventLoop::queueTask): Deleted. +(WebCore::AbstractEventLoop::resumeGroup): Deleted. +(WebCore::AbstractEventLoop::stopGroup): Deleted. +(WebCore::AbstractEventLoop::scheduleToRunIfNeeded): Deleted. +(WebCore::AbstractEventLoop::run): Deleted. +(WebCore::AbstractEventLoop::clearAllTasks): Deleted. +(WebCore::EventLoopFunctionDispatchTask::EventLoopFunctionDispatchTask): Deleted. +(WebCore::EventLoopTaskGroup::queueTask): Deleted. +* dom/WindowEventLoop.h: +* fileapi/FileReader.cpp: +* testing/Internals.cpp: +* workers/WorkerEventLoop.h: +* workers/service/ServiceWorkerContainer.cpp: + 2019-11-19 Yusuke Suzuki [IndexedDB] IndexedDB's threading assertion should respect Web thread Modified: trunk/Source/WebCore/Modules/cache/DOMCache.cpp (252645 => 252646) --- trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2019-11-19 21:36:54 UTC (rev 252645) +++ trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2019-11-19 21:57:52 UTC (rev 252646) @@ -26,8 +26,8 @@ #
[webkit-changes] [252647] trunk/Source/WebCore
Title: [252647] trunk/Source/WebCore
Revision 252647
Author dba...@webkit.org
Date 2019-11-19 14:05:12 -0800 (Tue, 19 Nov 2019)
Log Message
ASSERTION FAILURE: useDownstream ? (result > vp) : (result < vp) in WebCore::nextSentenceBoundaryInDirection()
https://bugs.webkit.org/show_bug.cgi?id=204370
Reviewed by Wenson Hsieh.
Only positions whose anchor nodes are in a document and in the same tree scope can be
compared using the operator< overload. Otherwise, the result is non-deterministic by
spec. (13 November 2019):
6. If node1 or node2 is null, or node1's root is not node2's root, then return the result of
adding DOCUMENT_POSITION_DISCONNECTED, DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC, and either
DOCUMENT_POSITION_PRECEDING or DOCUMENT_POSITION_FOLLOWING, with the constraint that this is
to be consistent, together.
NOTE: Whether to return DOCUMENT_POSITION_PRECEDING or DOCUMENT_POSITION_FOLLOWING is typically
implemented via pointer comparison. In _javascript_ implementations a cached Math.random()
value can be used.
* dom/Node.cpp:
(WebCore::areNodesConnectedInSameTreeScope): Added; extracted from compareDocumentPosition().
(WebCore::Node::compareDocumentPosition): Write in terms of areNodesConnectedInSameTreeScope().
* dom/Node.h:
* editing/VisiblePosition.cpp:
(WebCore::areVisiblePositionsInSameTreeScope): Added. Write in terms of areNodesConnectedInSameTreeScope().
* editing/VisiblePosition.h:
* editing/VisibleUnits.cpp:
(WebCore::nextSentenceBoundaryInDirection): Update assert. We can only compare positions
if areVisiblePositionsInSameTreeScope() returns true.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/editing/VisiblePosition.cpp
trunk/Source/WebCore/editing/VisiblePosition.h
trunk/Source/WebCore/editing/VisibleUnits.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252646 => 252647)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 21:57:52 UTC (rev 252646)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 22:05:12 UTC (rev 252647)
@@ -1,3 +1,35 @@
+2019-11-19 Daniel Bates
+
+ASSERTION FAILURE: useDownstream ? (result > vp) : (result < vp) in WebCore::nextSentenceBoundaryInDirection()
+https://bugs.webkit.org/show_bug.cgi?id=204370
+
+
+Reviewed by Wenson Hsieh.
+
+Only positions whose anchor nodes are in a document and in the same tree scope can be
+compared using the operator< overload. Otherwise, the result is non-deterministic by
+spec. (13 November 2019):
+
+6. If node1 or node2 is null, or node1's root is not node2's root, then return the result of
+adding DOCUMENT_POSITION_DISCONNECTED, DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC, and either
+DOCUMENT_POSITION_PRECEDING or DOCUMENT_POSITION_FOLLOWING, with the constraint that this is
+to be consistent, together.
+
+NOTE: Whether to return DOCUMENT_POSITION_PRECEDING or DOCUMENT_POSITION_FOLLOWING is typically
+implemented via pointer comparison. In _javascript_ implementations a cached Math.random()
+value can be used.
+
+* dom/Node.cpp:
+(WebCore::areNodesConnectedInSameTreeScope): Added; extracted from compareDocumentPosition().
+(WebCore::Node::compareDocumentPosition): Write in terms of areNodesConnectedInSameTreeScope().
+* dom/Node.h:
+* editing/VisiblePosition.cpp:
+(WebCore::areVisiblePositionsInSameTreeScope): Added. Write in terms of areNodesConnectedInSameTreeScope().
+* editing/VisiblePosition.h:
+* editing/VisibleUnits.cpp:
+(WebCore::nextSentenceBoundaryInDirection): Update assert. We can only compare positions
+if areVisiblePositionsInSameTreeScope() returns true.
+
2019-11-18 Ryosuke Niwa
Rename AbstractEventLoop to EventLoop and move to its own cpp file
Modified: trunk/Source/WebCore/dom/Node.cpp (252646 => 252647)
--- trunk/Source/WebCore/dom/Node.cpp 2019-11-19 21:57:52 UTC (rev 252646)
+++ trunk/Source/WebCore/dom/Node.cpp 2019-11-19 22:05:12 UTC (rev 252647)
@@ -1610,6 +1610,14 @@
return Node::DOCUMENT_POSITION_DISCONNECTED | Node::DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC | direction;
}
+bool areNodesConnectedInSameTreeScope(const Node* a, const Node* b)
+{
+if (!a || !b)
+return false;
+// Note that we avoid comparing Attr nodes here, since they return false from isConnected() all the time (which seems like a bug).
+return a->isConnected() == b->isConnected() && &a->treeScope() == &b->treeScope();
+}
+
unsigned short Node::compareDocumentPosition(Node& otherNode)
{
if (&otherNode == this)
@@ -1654,9 +1662,8 @@
}
// If one node is in the document and the other is not, we must be disconnected.
-// If the nodes have different owning documents, they
[webkit-changes] [252648] trunk/Tools
Title: [252648] trunk/Tools
Revision 252648
Author jbed...@apple.com
Date 2019-11-19 14:06:43 -0800 (Tue, 19 Nov 2019)
Log Message
results.webkit.org: Have build.webkit.org report JSC tests
https://bugs.webkit.org/show_bug.cgi?id=204364
Reviewed by Aakash Jain.
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunJavaScriptCoreTests):
(RunWebKitTests):
(RunAPITests):
(RunPythonTests):
(RunLLINTCLoopTests):
(Run32bitJSCTests):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (252647 => 252648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-11-19 22:05:12 UTC (rev 252647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-11-19 22:06:43 UTC (rev 252648)
@@ -28,6 +28,7 @@
import os
import re
+import socket
import json
import cStringIO
import urllib
@@ -35,8 +36,9 @@
APPLE_WEBKIT_AWS_PROXY = "http://proxy01.webkit.org:3128"
S3URL = "https://s3-us-west-2.amazonaws.com/"
WithProperties = properties.WithProperties
-RESULTS_WEBKIT = 'https://results.webkit.org'
+RESULTS_WEBKIT_URL = 'https://results.webkit.org'
RESULTS_SERVER_API_KEY = 'RESULTS_SERVER_API_KEY'
+BUILD_WEBKIT_URL = socket.gethostname().strip()
class TestWithFailureCount(shell.Test):
@@ -341,7 +343,17 @@
description = ["jscore-tests running"]
descriptionDone = ["jscore-tests"]
jsonFileName = "jsc_results.json"
-command = ["perl", "./Tools/Scripts/run-_javascript_core-tests", "--no-build", "--no-fail-fast", "--json-output={0}".format(jsonFileName), WithProperties("--%(configuration)s")]
+command = [
+"perl", "./Tools/Scripts/run-_javascript_core-tests",
+"--no-build", "--no-fail-fast",
+"--json-output={0}".format(jsonFileName),
+WithProperties("--%(configuration)s"),
+"--builder-name", WithProperties("%(buildername)s"),
+"--build-number", WithProperties("%(buildnumber)s"),
+"--buildbot-worker", WithProperties("%(slavename)s"),
+"--buildbot-master", BUILD_WEBKIT_URL,
+"--report", RESULTS_WEBKIT_URL,
+]
failedTestsFormatString = "%d JSC test%s failed"
logfiles = {"json": jsonFileName}
@@ -420,8 +432,8 @@
"--build-number", WithProperties("%(buildnumber)s"),
"--buildbot-worker", WithProperties("%(slavename)s"),
"--master-name", "webkit.org",
- "--buildbot-master", "build.webkit.org",
- "--report", RESULTS_WEBKIT,
+ "--buildbot-master", BUILD_WEBKIT_URL,
+ "--report", RESULTS_WEBKIT_URL,
"--test-results-server", "webkit-test-results.webkit.org",
"--exit-after-n-crashes-or-timeouts", "50",
"--exit-after-n-failures", "500",
@@ -550,11 +562,11 @@
"--json-output={0}".format(jsonFileName),
WithProperties("--%(configuration)s"),
"--verbose",
-"--buildbot-master", "build.webkit.org",
+"--buildbot-master", BUILD_WEBKIT_URL,
"--builder-name", WithProperties("%(buildername)s"),
"--build-number", WithProperties("%(buildnumber)s"),
"--buildbot-worker", WithProperties("%(slavename)s"),
-"--report", RESULTS_WEBKIT,
+"--report", RESULTS_WEBKIT_URL,
]
failedTestsFormatString = "%d api test%s failed or timed out"
@@ -585,11 +597,11 @@
"./Tools/Scripts/test-webkitpy",
"--verbose",
WithProperties("--%(configuration)s"),
-"--buildbot-master", "build.webkit.org",
+"--buildbot-master", BUILD_WEBKIT_URL,
"--builder-name", WithProperties("%(buildername)s"),
"--build-number", WithProperties("%(buildnumber)s"),
"--buildbot-worker", WithProperties("%(slavename)s"),
-"--report", RESULTS_WEBKIT,
+"--report", RESULTS_WEBKIT_URL,
]
failedTestsFormatString = "%d python test%s failed"
@@ -647,7 +659,18 @@
description = ["cloop-tests running"]
descriptionDone = ["cloop-tests"]
jsonFileName = "jsc_cloop.json"
-command = ["perl", "./Tools/Scripts/run-_javascript_core-tests", "--cloop", "--no-build", "--no-jsc-stress", "--no-fail-fast", "--json-output={0}".format(jsonFileName), WithProperties("--%(configuration)s")]
+command = [
+"perl", "./Tools/Scripts/run-_javascript_core-tests",
+"--cloop", "--no-build",
+"--no-jsc-stress", "--no-fail-fast",
+"--json-output={0}".format(jsonFileName),
+WithProperties("--%(configuration)s"),
+"--builder-name", WithProperties("%(buildername)s"),
+"--build-number", WithProperties("%(buildnumber)s"),
+"--buildbot-worker", WithProperties("%(slavename)s"),
+"--buildbot-master", BUILD_WEBKIT_URL,
+"--report", RESULTS_WEBKIT_URL,
+]
failedTestsFormatString = "%d regression%s found."
logf
[webkit-changes] [252649] tags/Safari-609.1.9.7/
Title: [252649] tags/Safari-609.1.9.7/ Revision 252649 Author alanc...@apple.com Date 2019-11-19 14:15:45 -0800 (Tue, 19 Nov 2019) Log Message New tag. Added Paths tags/Safari-609.1.9.7/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252650] tags/Safari-609.1.9.7/Source
Title: [252650] tags/Safari-609.1.9.7/Source Revision 252650 Author alanc...@apple.com Date 2019-11-19 14:17:58 -0800 (Tue, 19 Nov 2019) Log Message Versioning. Modified Paths tags/Safari-609.1.9.7/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/WebCore/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/WebKit/Configurations/Version.xcconfig tags/Safari-609.1.9.7/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-609.1.9.7/Source/_javascript_Core/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/WebCore/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/WebCore/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/WebCore/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/WebCore/PAL/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/WebInspectorUI/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -1,7 +1,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/WebKit/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/WebKit/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/WebKit/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-609.1.9.7/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (252649 => 252650) --- tags/Safari-609.1.9.7/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2019-11-19 22:15:45 UTC (rev 252649) +++ tags/Safari-609.1.9.7/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2019-11-19 22:17:58 UTC (rev 252650) @@ -24,7 +24,7 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 9; -MICRO_VERSION = 6; +MICRO_VERSION = 7; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252651] trunk/Source/WebCore
Title: [252651] trunk/Source/WebCore
Revision 252651
Author ysuz...@apple.com
Date 2019-11-19 14:31:11 -0800 (Tue, 19 Nov 2019)
Log Message
Unreviewed, follow-up after r252642
https://bugs.webkit.org/show_bug.cgi?id=204346
* Modules/indexeddb/IDBActiveDOMObject.h:
* Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::~TransactionOperation):
(WebCore::IDBClient::TransactionOperation::perform):
(WebCore::IDBClient::TransactionOperation::transitionToCompleteOnThisThread):
(WebCore::IDBClient::TransactionOperation::transitionToComplete):
(WebCore::IDBClient::TransactionOperation::doComplete):
* platform/Supplementable.h:
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::removeSupplement):
(WebCore::Supplementable::requireSupplement):
* platform/Timer.cpp:
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::start):
(WebCore::TimerBase::stop):
(WebCore::TimerBase::setNextFireTime):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h
trunk/Source/WebCore/Modules/indexeddb/client/TransactionOperation.h
trunk/Source/WebCore/platform/Supplementable.h
trunk/Source/WebCore/platform/Timer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252650 => 252651)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 22:17:58 UTC (rev 252650)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 22:31:11 UTC (rev 252651)
@@ -1,3 +1,25 @@
+2019-11-19 Yusuke Suzuki
+
+Unreviewed, follow-up after r252642
+https://bugs.webkit.org/show_bug.cgi?id=204346
+
+* Modules/indexeddb/IDBActiveDOMObject.h:
+* Modules/indexeddb/client/TransactionOperation.h:
+(WebCore::IDBClient::TransactionOperation::~TransactionOperation):
+(WebCore::IDBClient::TransactionOperation::perform):
+(WebCore::IDBClient::TransactionOperation::transitionToCompleteOnThisThread):
+(WebCore::IDBClient::TransactionOperation::transitionToComplete):
+(WebCore::IDBClient::TransactionOperation::doComplete):
+* platform/Supplementable.h:
+(WebCore::Supplementable::provideSupplement):
+(WebCore::Supplementable::removeSupplement):
+(WebCore::Supplementable::requireSupplement):
+* platform/Timer.cpp:
+(WebCore::TimerBase::~TimerBase):
+(WebCore::TimerBase::start):
+(WebCore::TimerBase::stop):
+(WebCore::TimerBase::setNextFireTime):
+
2019-11-19 Daniel Bates
ASSERTION FAILURE: useDownstream ? (result > vp) : (result < vp) in WebCore::nextSentenceBoundaryInDirection()
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h (252650 => 252651)
--- trunk/Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h 2019-11-19 22:17:58 UTC (rev 252650)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h 2019-11-19 22:31:11 UTC (rev 252651)
@@ -38,7 +38,7 @@
Thread& originThread() const { return m_originThread.get(); }
void contextDestroyed() final {
-ASSERT(canCurrentThreadAccessThreadLocalData(m_originThread.get()));
+ASSERT(canCurrentThreadAccessThreadLocalData(originThread()));
Locker lock(m_scriptExecutionContextLock);
ActiveDOMObject::contextDestroyed();
Modified: trunk/Source/WebCore/Modules/indexeddb/client/TransactionOperation.h (252650 => 252651)
--- trunk/Source/WebCore/Modules/indexeddb/client/TransactionOperation.h 2019-11-19 22:17:58 UTC (rev 252650)
+++ trunk/Source/WebCore/Modules/indexeddb/client/TransactionOperation.h 2019-11-19 22:31:11 UTC (rev 252651)
@@ -51,12 +51,12 @@
public:
virtual ~TransactionOperation()
{
-ASSERT(canCurrentThreadAccessThreadLocalData(m_originThread.get()));
+ASSERT(canCurrentThreadAccessThreadLocalData(originThread()));
}
void perform()
{
-ASSERT(canCurrentThreadAccessThreadLocalData(m_originThread.get()));
+ASSERT(canCurrentThreadAccessThreadLocalData(originThread()));
ASSERT(m_performFunction);
m_performFunction();
m_performFunction = { };
@@ -64,7 +64,7 @@
void transitionToCompleteOnThisThread(const IDBResultData& data)
{
-ASSERT(canCurrentThreadAccessThreadLocalData(m_originThread.get()));
+ASSERT(canCurrentThreadAccessThreadLocalData(originThread()));
m_transaction->operationCompletedOnServer(data, *this);
}
@@ -72,7 +72,7 @@
{
ASSERT(isMainThread());
-if (canCurrentThreadAccessThreadLocalData(m_originThread.get()))
+if (canCurrentThreadAccessThreadLocalData(originThread()))
transitionToCompleteOnThisThread(data);
else {
m_transaction->performCallbackOnOriginThread(*this, &TransactionOperation::transitionToCompleteOnThisThread, data);
@@ -83,7 +83,7 @@
void doComplete(const IDBResultData& data)
{
-ASSERT(canCurrentThreadAccessThreadLocalData(m_originThread.get()));
+
[webkit-changes] [252652] trunk/Source/WebInspectorUI
Title: [252652] trunk/Source/WebInspectorUI Revision 252652 Author drou...@apple.com Date 2019-11-19 14:55:04 -0800 (Tue, 19 Nov 2019) Log Message Web Inspector: Local Overrides: the placeholder for the MIME type, status code, and status text is the same as the placeholder URL https://bugs.webkit.org/show_bug.cgi?id=204330 Reviewed by Joseph Pecoraro. * UserInterface/Views/LocalResourceOverridePopover.js: (WI.LocalResourceOverridePopover.prototype.get serializedData): (WI.LocalResourceOverridePopover.prototype.show): (WI.LocalResourceOverridePopover.prototype._createEditor): * UserInterface/Views/LocalResourceOverridePopover.css: (.popover .local-resource-override-popover-content .data-grid tr.header-content-type > :matches(.name-column, .value-column)): Added. Replace the hardcoded `placeholder` with an optional `options` object that can include a `placeholder` value, allowing each caller to customize what is shown. Disallow selecting the "Content-Type" header since it's automatically populated, even if there is no set value for the MIME type or URL (e.g. inferred from placeholders). Drive-by: if a `CodeMirror` has no value, attempt to use it's placeholder instead. Drive-by: replace generic `dataGrid` with more specific `this._headersDataGrid`, which is more clear given how many `WI.DataGrid` are created by this class. * UserInterface/Views/DataGridNode.js: (WI.DataGridNode.prototype.get selectable): (WI.PlaceholderDataGridNode): * UserInterface/Views/DataGrid.js: (WI.DataGrid.createSortableDataGrid): * UserInterface/Views/DOMStorageContentView.js: (WI.DOMStorageContentView.prototype.itemAdded): (WI.DOMStorageContentView.prototype._populate): * UserInterface/Views/EditableDataGridNode.js: (WI.EditableDataGridNode): Deleted. * UserInterface/Views/HeapSnapshotClassDataGridNode.js: (WI.HeapSnapshotClassDataGridNode): * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js: (WI.HeapSnapshotInstanceDataGridNode): * UserInterface/Views/HeapSnapshotInstanceFetchMoreDataGridNode.js: (WI.HeapSnapshotInstanceFetchMoreDataGridNode): * UserInterface/Views/ProfileDataGridNode.js: (WI.ProfileDataGridNode): * UserInterface/Views/RecordingStateDetailsSidebarPanel.js: (WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D): (WI.RecordingStateDetailsSidebarPanel): * UserInterface/Views/ResourceDetailsSidebarPanel.js: (WI.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid.addDataGridNode): * UserInterface/Views/TimelineDataGridNode.js: (WI.TimelineDataGridNode): Rework constructor of `WI.DataGridNode` to accept an `options`-style object as its second parameter, instead of separate parameters for each configurable property. Now that this is able to be done via a single parameter, add support for marking a `WI.DataGridNode` as not being selectable. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/EditableDataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotClassDataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceFetchMoreDataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.css trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js trunk/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252651 => 252652) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-19 22:31:11 UTC (rev 252651) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-19 22:55:04 UTC (rev 252652) @@ -1,3 +1,54 @@ +2019-11-19 Devin Rousso + +Web Inspector: Local Overrides: the placeholder for the MIME type, status code, and status text is the same as the placeholder URL +https://bugs.webkit.org/show_bug.cgi?id=204330 + +Reviewed by Joseph Pecoraro. + +* UserInterface/Views/LocalResourceOverridePopover.js: +(WI.LocalResourceOverridePopover.prototype.get serializedData): +(WI.LocalResourceOverridePopover.prototype.show): +(WI.LocalResourceOverridePopover.prototype._createEditor): +* UserInterface/Views/LocalResourceOverridePopover.css: +(.popover .local-resource-override-popover-content .data-grid tr.header-content-type > :matches(.name-column, .value-column)): Added. +Replace the hardcoded `placeholder` with an optional `options` object that can include a +`placeholder` v
[webkit-changes] [252653] trunk/Source/WebCore
Title: [252653] trunk/Source/WebCore
Revision 252653
Author beid...@apple.com
Date 2019-11-19 16:12:06 -0800 (Tue, 19 Nov 2019)
Log Message
Fix null deref when a DocumentLoader's policy decision is delivered.
and https://bugs.webkit.org/show_bug.cgi?id=204378
Reviewed by Ryosuke Niwa.
Definitely a required null check, as all async entries into DocumentLoader should (and most do!)
No new tests, as no steps to reproduce are known.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy): Null check m_frame.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (252652 => 252653)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 22:55:04 UTC (rev 252652)
+++ trunk/Source/WebCore/ChangeLog 2019-11-20 00:12:06 UTC (rev 252653)
@@ -1,3 +1,17 @@
+2019-11-19 Brady Eidson
+
+Fix null deref when a DocumentLoader's policy decision is delivered.
+ and https://bugs.webkit.org/show_bug.cgi?id=204378
+
+Reviewed by Ryosuke Niwa.
+
+Definitely a required null check, as all async entries into DocumentLoader should (and most do!)
+
+No new tests, as no steps to reproduce are known.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::continueAfterContentPolicy): Null check m_frame.
+
2019-11-19 Yusuke Suzuki
Unreviewed, follow-up after r252642
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (252652 => 252653)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2019-11-19 22:55:04 UTC (rev 252652)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2019-11-20 00:12:06 UTC (rev 252653)
@@ -910,6 +910,11 @@
if (isStopping())
return;
+if (!m_frame) {
+RELEASE_LOG_IF_ALLOWED("continueAfterContentPolicy: Policy action %i received by DocumentLoader with null frame", (int)policy);
+return;
+}
+
switch (policy) {
case PolicyAction::Use: {
if (!frameLoader()->client().canShowMIMEType(m_response.mimeType()) || disallowWebArchive()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252654] trunk/LayoutTests
Title: [252654] trunk/LayoutTests Revision 252654 Author jiewen_...@apple.com Date 2019-11-19 16:16:37 -0800 (Tue, 19 Nov 2019) Log Message Unreviewed, test gardening * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (252653 => 252654) --- trunk/LayoutTests/ChangeLog 2019-11-20 00:12:06 UTC (rev 252653) +++ trunk/LayoutTests/ChangeLog 2019-11-20 00:16:37 UTC (rev 252654) @@ -1,3 +1,9 @@ +2019-11-19 Jiewen Tan + +Unreviewed, test gardening + +* platform/ios-wk2/TestExpectations: + 2019-11-19 Wenson Hsieh fast/events/touch/ios/long-press-on-link.html times out after r251693 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (252653 => 252654) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-20 00:12:06 UTC (rev 252653) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-20 00:16:37 UTC (rev 252654) @@ -1038,14 +1038,6 @@ fast/visual-viewport/ios/bottom-bar-with-keyboard.html [ Skip ] fast/visual-viewport/ios/fixed-element-on-bottom-with-keyboard.html [ Skip ] fast/visual-viewport/ios/zoomed-focus-in-fixed.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html [ Skip ] -http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html [ Skip ] http/tests/navigation/ping-attribute [ Skip ] webkit.org/b/153380 webarchive/loading/object.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252656] branches/safari-608-branch/Source/WebCore
Title: [252656] branches/safari-608-branch/Source/WebCore
Revision 252656
Author alanc...@apple.com
Date 2019-11-19 16:33:09 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r251678. rdar://problem/57283567
Drop code for X-Temp-Tablet HTTP header experiment
https://bugs.webkit.org/show_bug.cgi?id=203524
Reviewed by Ryosuke Niwa.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp
branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.h
Diff
Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (252655 => 252656)
--- branches/safari-608-branch/Source/WebCore/ChangeLog 2019-11-20 00:32:19 UTC (rev 252655)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog 2019-11-20 00:33:09 UTC (rev 252656)
@@ -1,3 +1,33 @@
+2019-11-19 Alan Coon
+
+Cherry-pick r251678. rdar://problem/57283567
+
+Drop code for X-Temp-Tablet HTTP header experiment
+https://bugs.webkit.org/show_bug.cgi?id=203524
+
+
+Reviewed by Ryosuke Niwa.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::CachedResourceLoader):
+(WebCore::CachedResourceLoader::requestResource):
+* loader/cache/CachedResourceLoader.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-28 Chris Dumez
+
+Drop code for X-Temp-Tablet HTTP header experiment
+https://bugs.webkit.org/show_bug.cgi?id=203524
+
+
+Reviewed by Ryosuke Niwa.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::CachedResourceLoader):
+(WebCore::CachedResourceLoader::requestResource):
+* loader/cache/CachedResourceLoader.h:
+
2019-11-18 Alan Coon
Apply patch. rdar://problem/57257755
Modified: branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp (252655 => 252656)
--- branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2019-11-20 00:32:19 UTC (rev 252655)
+++ branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2019-11-20 00:33:09 UTC (rev 252656)
@@ -152,16 +152,6 @@
return nullptr;
}
-#if PLATFORM(IOS) && !PLATFORM(IOSMAC)
-static bool isXTempTabletHeaderExperimentOver()
-{
-DateComponents date;
-date.setMillisecondsSinceEpochForMonth(WallTime::now().secondsSinceEpoch().milliseconds());
-// End of experiment is 02-01-2020.
-return date.fullYear() > 2020 || (date.fullYear() == 2020 && date.month() >= 1);
-}
-#endif
-
CachedResourceLoader::CachedResourceLoader(DocumentLoader* documentLoader)
: m_document(nullptr)
, m_documentLoader(documentLoader)
@@ -171,9 +161,6 @@
, m_autoLoadImages(true)
, m_imagesEnabled(true)
, m_allowStaleResources(false)
-#if PLATFORM(IOS) && !PLATFORM(IOSMAC)
-, m_isXTempTabletHeaderExperimentOver(isXTempTabletHeaderExperimentOver())
-#endif
{
}
@@ -803,36 +790,6 @@
return FetchOptions::Destination::EmptyString;
}
-#if PLATFORM(IOS) && !PLATFORM(IOSMAC)
-static bool isGoogleSearch(const URL& url)
-{
-if (!url.protocolIs("https"))
-return false;
-
-RegistrableDomain registrableDomain(url);
-if (!registrableDomain.string().startsWith("google."))
-return false;
-
-auto host = url.host();
-return host.startsWithIgnoringASCIICase("google.") || host.startsWithIgnoringASCIICase("www.google.") || host.startsWithIgnoringASCIICase("images.google.");
-}
-
-bool CachedResourceLoader::shouldSendXTempTabletHeader(CachedResource::Type type, Frame& frame, const URL& url) const
-{
-if (m_isXTempTabletHeaderExperimentOver || !IOSApplication::isMobileSafari())
-return false;
-
-if (!isGoogleSearch(url))
-return false;
-
-if (type == CachedResource::Type::MainResource && frame.isMainFrame())
-return true;
-
-auto* topDocument = frame.mainFrame().document();
-return topDocument && isGoogleSearch(topDocument->url());
-}
-#endif
-
ResourceErrorOr> CachedResourceLoader::requestResource(CachedResource::Type type, CachedResourceRequest&& request, ForPreload forPreload, DeferOption defer)
{
request.setDestinationIfNotSet(destinationForType(type));
@@ -916,12 +873,6 @@
}
}
-// FIXME: This is temporary for .
-#if PLATFORM(IOS) && !PLATFORM(IOSMAC)
-if (deviceHasIPadCapability() && frame() && shouldSendXTempTabletHeader(type, *frame(), request.resourceRequest().url()))
-request.resourceRequ
[webkit-changes] [252655] trunk/Source/WebKit
Title: [252655] trunk/Source/WebKit Revision 252655 Author cdu...@apple.com Date 2019-11-19 16:32:19 -0800 (Tue, 19 Nov 2019) Log Message Protect MessageReceivers when possible while they are processing incoming IPC messages https://bugs.webkit.org/show_bug.cgi?id=204377 Reviewed by Brady Eidson. Protect MessageReceiver while they are processing incoming IPC messages for extra safety. It is a common mistake to call client delegates as a result of an IPC, and failing to protect |this| while doing so. Client code can destroy |this| and we end up crashing. For MessageReceivers that are not RefCounted, they can use the "NotRefCounted" attribute in their messages.in file to opt out. * NetworkProcess/Cookies/WebCookieManager.messages.in: * NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: * NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in: * NetworkProcess/NetworkContentRuleListManager.messages.in: * NetworkProcess/NetworkSocketChannel.messages.in: * NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in: * NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in: * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: * NetworkProcess/webrtc/NetworkMDNSRegister.messages.in: * NetworkProcess/webrtc/NetworkRTCMonitor.messages.in: * NetworkProcess/webrtc/NetworkRTCSocket.messages.in: * PluginProcess/PluginControllerProxy.messages.in: * PluginProcess/PluginProcess.messages.in: * Scripts/webkit/messages.py: * Shared/API/Cocoa/RemoteObjectRegistry.messages.in: * Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in: * Shared/Authentication/AuthenticationManager.messages.in: * Shared/AuxiliaryProcess.messages.in: * Shared/Plugins/NPObjectMessageReceiver.messages.in: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: * UIProcess/DrawingAreaProxy.messages.in: * UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in: * UIProcess/ViewGestureController.messages.in: * UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in: * UIProcess/WebFullScreenManagerProxy.messages.in: * UIProcess/WebPasteboardProxy.messages.in: * UIProcess/ios/SmartMagnificationController.messages.in: * WebProcess/ApplePay/WebPaymentCoordinator.messages.in: * WebProcess/Automation/WebAutomationSessionProxy.messages.in: * WebProcess/Geolocation/WebGeolocationManager.messages.in: * WebProcess/Network/webrtc/WebMDNSRegister.messages.in: * WebProcess/Network/webrtc/WebRTCMonitor.messages.in: * WebProcess/Network/webrtc/WebRTCResolver.messages.in: * WebProcess/Network/webrtc/WebRTCSocket.messages.in: * WebProcess/Notifications/WebNotificationManager.messages.in: * WebProcess/Storage/WebSWContextManagerConnection.messages.in: * WebProcess/WebPage/DrawingArea.messages.in: * WebProcess/WebPage/ViewGestureGeometryCollector.messages.in: * WebProcess/WebProcess.messages.in: * WebProcess/cocoa/UserMediaCaptureManager.messages.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in trunk/Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.messages.in trunk/Source/WebKit/NetworkProcess/NetworkContentRuleListManager.messages.in trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.messages.in trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocket.messages.in trunk/Source/WebKit/PluginProcess/PluginControllerProxy.messages.in trunk/Source/WebKit/PluginProcess/PluginProcess.messages.in trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.messages.in trunk/Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in trunk/Source/WebKit/Shared/AuxiliaryProcess.messages.in trunk/Source/WebKit/Shared/Plugins/NPObjectMessageReceiver.messages.in trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in trunk/Source/WebKit/UIProcess/DrawingAreaProxy.messages.in trunk/Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in trunk/Source/WebKit/UIProcess/ViewGestureController.messages.in trunk/Source/WebKit/
[webkit-changes] [252657] branches/safari-608-branch/Source/WebKit
Title: [252657] branches/safari-608-branch/Source/WebKit
Revision 252657
Author alanc...@apple.com
Date 2019-11-19 16:33:13 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r252619. rdar://problem/57330791
IPC::Decoder should use nullptr as invalid value
Reviewed by Brent Fulgham.
Covered by existing tests.
* Platform/IPC/Decoder.cpp:
(IPC::alignedBufferIsLargeEnoughToContain): Add bufferStart
parameter to add beginning bounds check now that m_bufferPos
uses nullptr for an invalid value.
(IPC::Decoder::alignBufferPosition): Update to pass m_buffer to
IPC::alignedBufferIsLargeEnoughToContain().
(IPC::Decoder::bufferIsLargeEnoughToContain const): Ditto.
* Platform/IPC/Decoder.h:
(IPC::Decoder::isInvalid const): Add beginning bounds check now
that m_bufferPos uses nullptr for an invalid value.
(IPC::Decoder::markInvalid): Make nullptr the invalid value for
m_bufferPos.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/Platform/IPC/Decoder.cpp
branches/safari-608-branch/Source/WebKit/Platform/IPC/Decoder.h
Diff
Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (252656 => 252657)
--- branches/safari-608-branch/Source/WebKit/ChangeLog 2019-11-20 00:33:09 UTC (rev 252656)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog 2019-11-20 00:33:13 UTC (rev 252657)
@@ -1,3 +1,53 @@
+2019-11-19 Alan Coon
+
+Cherry-pick r252619. rdar://problem/57330791
+
+IPC::Decoder should use nullptr as invalid value
+
+
+
+Reviewed by Brent Fulgham.
+
+Covered by existing tests.
+
+* Platform/IPC/Decoder.cpp:
+(IPC::alignedBufferIsLargeEnoughToContain): Add bufferStart
+parameter to add beginning bounds check now that m_bufferPos
+uses nullptr for an invalid value.
+(IPC::Decoder::alignBufferPosition): Update to pass m_buffer to
+IPC::alignedBufferIsLargeEnoughToContain().
+(IPC::Decoder::bufferIsLargeEnoughToContain const): Ditto.
+* Platform/IPC/Decoder.h:
+(IPC::Decoder::isInvalid const): Add beginning bounds check now
+that m_bufferPos uses nullptr for an invalid value.
+(IPC::Decoder::markInvalid): Make nullptr the invalid value for
+m_bufferPos.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-11-18 David Kilzer
+
+IPC::Decoder should use nullptr as invalid value
+
+
+
+Reviewed by Brent Fulgham.
+
+Covered by existing tests.
+
+* Platform/IPC/Decoder.cpp:
+(IPC::alignedBufferIsLargeEnoughToContain): Add bufferStart
+parameter to add beginning bounds check now that m_bufferPos
+uses nullptr for an invalid value.
+(IPC::Decoder::alignBufferPosition): Update to pass m_buffer to
+IPC::alignedBufferIsLargeEnoughToContain().
+(IPC::Decoder::bufferIsLargeEnoughToContain const): Ditto.
+* Platform/IPC/Decoder.h:
+(IPC::Decoder::isInvalid const): Add beginning bounds check now
+that m_bufferPos uses nullptr for an invalid value.
+(IPC::Decoder::markInvalid): Make nullptr the invalid value for
+m_bufferPos.
+
2019-11-18 Alan Coon
Apply patch. rdar://problem/57283569
Modified: branches/safari-608-branch/Source/WebKit/Platform/IPC/Decoder.cpp (252656 => 252657)
--- branches/safari-608-branch/Source/WebKit/Platform/IPC/Decoder.cpp 2019-11-20 00:33:09 UTC (rev 252656)
+++ branches/safari-608-branch/Source/WebKit/Platform/IPC/Decoder.cpp 2019-11-20 00:33:13 UTC (rev 252657)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -135,15 +135,19 @@
return reinterpret_cast((reinterpret_cast(ptr) + alignmentMask) & ~alignmentMask);
}
-static inline bool alignedBufferIsLargeEnoughToContain(const uint8_t* alignedPosition, const uint8_t* bufferEnd, size_t size)
+static inline bool alignedBufferIsLargeEnoughToContain(const uint8_t* alignedPosition, const uint8_t* bufferStart, const uint8_t* bufferEnd, size_t size)
{
-return bufferEnd >= alignedPosition && static_cast(bufferEnd - alignedPosition) >= size;
+// When size == 0 for the last argument and it's a variable length byte arrray,
+// bufferStart == alignedPosition == bufferEnd, so checking (bufferEnd >= alignedPosition)
+// is not an off-by-one error since (static_cast(bufferEnd - alignedPosition) >= size)
+// will catch issues when size != 0.
+return bufferEnd >= alignedPosition &
[webkit-changes] [252658] trunk/Source
Title: [252658] trunk/Source
Revision 252658
Author ross.kirsl...@sony.com
Date 2019-11-19 16:48:32 -0800 (Tue, 19 Nov 2019)
Log Message
Unreviewed non-unified build fixes.
Source/WebCore:
* Modules/async-clipboard/ClipboardItem.cpp:
* Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
* Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
* Modules/async-clipboard/ClipboardItemDataSource.h:
* Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp:
* animation/WebAnimation.cpp:
* html/canvas/WebGLRenderingContextBase.cpp:
* xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit:
* WebProcess/WebPage/FindController.cpp:
* WebProcess/WebPage/FindController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemDataSource.h
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp
trunk/Source/WebCore/animation/WebAnimation.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp
trunk/Source/WebKit/WebProcess/WebPage/FindController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (252657 => 252658)
--- trunk/Source/WebCore/ChangeLog 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/ChangeLog 2019-11-20 00:48:32 UTC (rev 252658)
@@ -1,3 +1,16 @@
+2019-11-19 Ross Kirsling
+
+Unreviewed non-unified build fixes.
+
+* Modules/async-clipboard/ClipboardItem.cpp:
+* Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
+* Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
+* Modules/async-clipboard/ClipboardItemDataSource.h:
+* Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp:
+* animation/WebAnimation.cpp:
+* html/canvas/WebGLRenderingContextBase.cpp:
+* xml/parser/XMLDocumentParserLibxml2.cpp:
+
2019-11-19 Brady Eidson
Fix null deref when a DocumentLoader's policy decision is delivered.
Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp (252657 => 252658)
--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp 2019-11-20 00:48:32 UTC (rev 252658)
@@ -31,6 +31,7 @@
#include "ClipboardItemBindingsDataSource.h"
#include "ClipboardItemPasteboardDataSource.h"
#include "Navigator.h"
+#include "PasteboardCustomData.h"
#include "PasteboardItemInfo.h"
#include "SharedBuffer.h"
Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp (252657 => 252658)
--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp 2019-11-20 00:48:32 UTC (rev 252658)
@@ -35,6 +35,7 @@
#include "JSBlob.h"
#include "JSDOMPromise.h"
#include "JSDOMPromiseDeferred.h"
+#include "PasteboardCustomData.h"
#include "SharedBuffer.h"
#include
Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h (252657 => 252658)
--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h 2019-11-20 00:48:32 UTC (rev 252658)
@@ -33,9 +33,12 @@
namespace WebCore {
+class Blob;
class DOMPromise;
class FileReaderLoader;
class PasteboardCustomData;
+class ScriptExecutionContext;
+class SharedBuffer;
class ClipboardItemBindingsDataSource : public ClipboardItemDataSource {
WTF_MAKE_FAST_ALLOCATED;
Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemDataSource.h (252657 => 252658)
--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemDataSource.h 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemDataSource.h 2019-11-20 00:48:32 UTC (rev 252658)
@@ -35,6 +35,7 @@
class Clipboard;
class ClipboardItem;
class DeferredPromise;
+class PasteboardCustomData;
class ClipboardItemDataSource {
public:
Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp (252657 => 252658)
--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp 2019-11-20 00:33:13 UTC (rev 252657)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp 2019-11-20 00:48:32 UTC (rev 252658)
@@ -29,6 +29,7 @@
#include "Clipboard.h"
#include "ClipboardItem.h"
#include "JSDOMPromiseDeferred.h"
[webkit-changes] [252659] trunk/LayoutTests
Title: [252659] trunk/LayoutTests
Revision 252659
Author simon.fra...@apple.com
Date 2019-11-19 16:50:07 -0800 (Tue, 19 Nov 2019)
Log Message
REGRESSION (r252598): system-preview/badge.html and transforms/2d/zoom-menulist.html are failing
https://bugs.webkit.org/show_bug.cgi?id=204383
Unreviewed test gardening: adjust these tests for the different color component
rounding introduced in r252598.
* platform/ios/transforms/2d/zoom-menulist-expected.txt:
* system-preview/badge-expected.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/transforms/2d/zoom-menulist-expected.txt
trunk/LayoutTests/system-preview/badge-expected.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252658 => 252659)
--- trunk/LayoutTests/ChangeLog 2019-11-20 00:48:32 UTC (rev 252658)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 00:50:07 UTC (rev 252659)
@@ -55,6 +55,17 @@
* http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt:
Removed the lastSeen output since it may differ between test runs.
+2019-11-19 Simon Fraser
+
+REGRESSION (r252598): system-preview/badge.html and transforms/2d/zoom-menulist.html are failing
+https://bugs.webkit.org/show_bug.cgi?id=204383
+
+Unreviewed test gardening: adjust these tests for the different color component
+rounding introduced in r252598.
+
+* platform/ios/transforms/2d/zoom-menulist-expected.txt:
+* system-preview/badge-expected.html:
+
2019-11-19 Sihui Liu
Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
Modified: trunk/LayoutTests/platform/ios/transforms/2d/zoom-menulist-expected.txt (252658 => 252659)
--- trunk/LayoutTests/platform/ios/transforms/2d/zoom-menulist-expected.txt 2019-11-20 00:48:32 UTC (rev 252658)
+++ trunk/LayoutTests/platform/ios/transforms/2d/zoom-menulist-expected.txt 2019-11-20 00:50:07 UTC (rev 252659)
@@ -7,7 +7,7 @@
RenderText {#text} at (0,1) size 273x36
text run at (0,1) width 273: "Zooming Menu List"
RenderBlock (anonymous) at (0,59) size 784x73
-RenderMenuList {SELECT} at (6,6) size 147x60 [bgcolor=#FF02] [border: (3px solid #4C4C4C)]
+RenderMenuList {SELECT} at (6,6) size 147x60 [bgcolor=#FF03] [border: (3px solid #4C4C4C)]
RenderBlock (anonymous) at (19,10) size 109x40
RenderText at (0,0) size 63x39
text run at (0,0) width 63: "One"
Modified: trunk/LayoutTests/system-preview/badge-expected.html (252658 => 252659)
--- trunk/LayoutTests/system-preview/badge-expected.html 2019-11-20 00:48:32 UTC (rev 252658)
+++ trunk/LayoutTests/system-preview/badge-expected.html 2019-11-20 00:50:07 UTC (rev 252659)
@@ -42,7 +42,7 @@
-
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252660] trunk/Source/WebCore
Title: [252660] trunk/Source/WebCore Revision 252660 Author you...@apple.com Date 2019-11-19 16:50:51 -0800 (Tue, 19 Nov 2019) Log Message Introduce a mock implementation of CoreAudioSharedUnit https://bugs.webkit.org/show_bug.cgi?id=204290 Reviewed by Eric Carlson. Introduce BaseAudioSharedUnit as a base class to CoreAudioSharedUnit. Make CoreAudioCaptureSource use either CoreAudioSharedUnit singleton or an override. Implement a MockAudioSharedUnit and use the override to implement mock audio capture sources. Remove some code from CoreAudioCaptureSource related to reference data, which is not used currently. Covered by existing tests. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/mediastream/mac/BaseAudioSharedUnit.cpp: Added. (WebCore::BaseAudioSharedUnit::addClient): (WebCore::BaseAudioSharedUnit::removeClient): (WebCore::BaseAudioSharedUnit::forEachClient const): (WebCore::BaseAudioSharedUnit::clearClients): (WebCore::BaseAudioSharedUnit::startProducingData): (WebCore::BaseAudioSharedUnit::resume): (WebCore::BaseAudioSharedUnit::prepareForNewCapture): (WebCore::BaseAudioSharedUnit::captureFailed): (WebCore::BaseAudioSharedUnit::stopProducingData): (WebCore::BaseAudioSharedUnit::suspend): (WebCore::BaseAudioSharedUnit::audioSamplesAvailable): * platform/mediastream/mac/BaseAudioSharedUnit.h: Added. (WebCore::BaseAudioSharedUnit::delaySamples): (WebCore::BaseAudioSharedUnit::isSuspended const): (WebCore::BaseAudioSharedUnit::volume const): (WebCore::BaseAudioSharedUnit::sampleRate const): (WebCore::BaseAudioSharedUnit::enableEchoCancellation const): (WebCore::BaseAudioSharedUnit::setVolume): (WebCore::BaseAudioSharedUnit::setSampleRate): (WebCore::BaseAudioSharedUnit::setEnableEchoCancellation): (WebCore::BaseAudioSharedUnit::sampleRateCapacities const): (WebCore::BaseAudioSharedUnit::hasClients const): (WebCore::BaseAudioSharedUnit::setSuspended): * platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioSharedUnit::unit): (WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit): (WebCore::CoreAudioSharedUnit::setupAudioUnit): (WebCore::CoreAudioSharedUnit::configureMicrophoneProc): (WebCore::CoreAudioSharedUnit::configureSpeakerProc): (WebCore::CoreAudioSharedUnit::provideSpeakerData): (WebCore::CoreAudioSharedUnit::processMicrophoneSamples): (WebCore::initializeCoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::create): (WebCore::CoreAudioCaptureSource::createForTesting): (WebCore::CoreAudioCaptureSource::unit): (WebCore::CoreAudioCaptureSourceFactory::devicesChanged): (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::initializeToStartProducingData): (WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::startProducingData): (WebCore::CoreAudioCaptureSource::stopProducingData): (WebCore::CoreAudioCaptureSource::capabilities): (WebCore::CoreAudioCaptureSource::settingsDidChange): (WebCore::CoreAudioCaptureSource::scheduleReconfiguration): (WebCore::CoreAudioCaptureSource::beginInterruption): (WebCore::CoreAudioCaptureSource::endInterruption): (WebCore::CoreAudioCaptureSource::interrupted const): (WebCore::CoreAudioCaptureSource::delaySamples): * platform/mediastream/mac/CoreAudioCaptureSource.h: * platform/mediastream/mac/MockAudioSharedUnit.h: Added. * platform/mediastream/mac/MockAudioSharedUnit.mm: Added. (WebCore::MockRealtimeAudioSource::create): (WebCore::MockAudioSharedUnit::singleton): (WebCore::MockAudioSharedUnit::MockAudioSharedUnit): (WebCore::MockAudioSharedUnit::hasAudioUnit const): (WebCore::MockAudioSharedUnit::setCaptureDevice): (WebCore::MockAudioSharedUnit::reconfigureAudioUnit): (WebCore::MockAudioSharedUnit::cleanupAudioUnit): (WebCore::MockAudioSharedUnit::startInternal): (WebCore::MockAudioSharedUnit::stopInternal): (WebCore::MockAudioSharedUnit::isProducingData const): (WebCore::MockAudioSharedUnit::tick): (WebCore::MockAudioSharedUnit::delaySamples): (WebCore::MockAudioSharedUnit::reconfigure): (WebCore::MockAudioSharedUnit::emitSampleBuffers): (WebCore::MockAudioSharedUnit::render): * platform/mediastream/mac/MockRealtimeAudioSourceMac.h: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h Added Paths trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm Removed Paths trunk/Source/WebCore/platform/mediastream/mac/MockRealtimeAudioSourceMac.h trunk/Source/WebCore/platform/mediastream/mac/MockRealtimeAudioSourceMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (252659 => 2526
[webkit-changes] [252661] trunk/Source/JavaScriptCore
Title: [252661] trunk/Source/_javascript_Core
Revision 252661
Author ysuz...@apple.com
Date 2019-11-19 16:56:39 -0800 (Tue, 19 Nov 2019)
Log Message
[JSC] Work-around Leaks' false-positive report about memory leaking
https://bugs.webkit.org/show_bug.cgi?id=204384
Reviewed by Mark Lam.
According to the radar, Leaks start reporting false-positive memory leaks about ExecutableAllocator and FixedVMPoolExecutableAllocator,
while they are per-process singleton and reachable through g_jscConfig. I'm guessing this is because Leaks start skipping scan for
readonly memory region. (g_jscConfig is now mprotected to readonly).
To work-around this, we anchor these heap allocated things to global variables to help Leaks scan. Once it is fixed, we should remove it.
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::initializeUnderlyingAllocator):
(JSC::ExecutableAllocator::initialize):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (252660 => 252661)
--- trunk/Source/_javascript_Core/ChangeLog 2019-11-20 00:50:51 UTC (rev 252660)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-11-20 00:56:39 UTC (rev 252661)
@@ -1,3 +1,21 @@
+2019-11-19 Yusuke Suzuki
+
+[JSC] Work-around Leaks' false-positive report about memory leaking
+https://bugs.webkit.org/show_bug.cgi?id=204384
+
+
+Reviewed by Mark Lam.
+
+According to the radar, Leaks start reporting false-positive memory leaks about ExecutableAllocator and FixedVMPoolExecutableAllocator,
+while they are per-process singleton and reachable through g_jscConfig. I'm guessing this is because Leaks start skipping scan for
+readonly memory region. (g_jscConfig is now mprotected to readonly).
+
+To work-around this, we anchor these heap allocated things to global variables to help Leaks scan. Once it is fixed, we should remove it.
+
+* jit/ExecutableAllocator.cpp:
+(JSC::ExecutableAllocator::initializeUnderlyingAllocator):
+(JSC::ExecutableAllocator::initialize):
+
2019-11-18 Mark Lam
Always enable Optional parse(const char* string) for OS(DARWIN).
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (252660 => 252661)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2019-11-20 00:50:51 UTC (rev 252660)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2019-11-20 00:56:39 UTC (rev 252661)
@@ -414,10 +414,14 @@
m_reservation.deallocate();
}
+// Keep this pointer in a mutable global variable to help Leaks find it.
+// But we do not use this pointer.
+static FixedVMPoolExecutableAllocator* globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = nullptr;
void ExecutableAllocator::initializeUnderlyingAllocator()
{
RELEASE_ASSERT(!g_jscConfig.fixedVMPoolExecutableAllocator);
g_jscConfig.fixedVMPoolExecutableAllocator = new FixedVMPoolExecutableAllocator();
+globalFixedVMPoolExecutableAllocatorToWorkAroundLeaks = g_jscConfig.fixedVMPoolExecutableAllocator;
CodeProfiling::notifyAllocator(g_jscConfig.fixedVMPoolExecutableAllocator);
}
@@ -642,9 +646,13 @@
namespace JSC {
+// Keep this pointer in a mutable global variable to help Leaks find it.
+// But we do not use this pointer.
+static ExecutableAllocator* globalExecutableAllocatorToWorkAroundLeaks = nullptr;
void ExecutableAllocator::initialize()
{
g_jscConfig.executableAllocator = new ExecutableAllocator;
+globalExecutableAllocatorToWorkAroundLeaks = g_jscConfig.executableAllocator;
}
ExecutableAllocator& ExecutableAllocator::singleton()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252664] branches/safari-608-branch/Tools
Title: [252664] branches/safari-608-branch/Tools
Revision 252664
Author alanc...@apple.com
Date 2019-11-19 17:24:47 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r252087. rdar://problem/56900657
REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=203844
Rubber-stamped by Aakash Jain.
Remove infinite loop for Windows.
* Scripts/webkitpy/port/win.py:
(WinPort._path_to_default_image_diff):
(WinPort._path_to_image_diff): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/port/win.py
Diff
Modified: branches/safari-608-branch/Tools/ChangeLog (252663 => 252664)
--- branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:45 UTC (rev 252663)
+++ branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:47 UTC (rev 252664)
@@ -1,5 +1,35 @@
2019-11-19 Alan Coon
+Cherry-pick r252087. rdar://problem/56900657
+
+REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=203844
+
+Rubber-stamped by Aakash Jain.
+
+Remove infinite loop for Windows.
+
+* Scripts/webkitpy/port/win.py:
+(WinPort._path_to_default_image_diff):
+(WinPort._path_to_image_diff): Deleted.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-11-05 Jonathan Bedard
+
+REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=203844
+
+Rubber-stamped by Aakash Jain.
+
+Remove infinite loop for Windows.
+
+* Scripts/webkitpy/port/win.py:
+(WinPort._path_to_default_image_diff):
+(WinPort._path_to_image_diff): Deleted.
+
+2019-11-19 Alan Coon
+
Cherry-pick r252058. rdar://problem/56889868
webkitpy: Build ImageDiff if it is missing (Follow-fix)
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/port/win.py (252663 => 252664)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/port/win.py 2019-11-20 01:24:45 UTC (rev 252663)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/port/win.py 2019-11-20 01:24:47 UTC (rev 252664)
@@ -192,10 +192,7 @@
def _path_to_lighttpd_php(self):
return "/usr/bin/php-cgi"
-def _path_to_image_diff(self):
-if self.is_cygwin():
-return super(WinPort, self)._path_to_image_diff()
-
+def _path_to_default_image_diff(self):
return self._build_path('ImageDiff.exe')
API_TEST_BINARY_NAMES = ['TestWTF.exe', 'TestWebCore.exe', 'TestWebKitLegacy.exe']
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252665] branches/safari-608-branch/Tools
Title: [252665] branches/safari-608-branch/Tools
Revision 252665
Author alanc...@apple.com
Date 2019-11-19 17:24:50 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r250966. rdar://problem/56047710
results.webkit.org: Start reporting results
https://bugs.webkit.org/show_bug.cgi?id=202639
Reviewed by Dewei Zhu.
* BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
(loadBuilderConfig): Load API key for results.webkit.org.
* BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
(create_mock_slave_passwords_dict): Add mock for API key.
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunWebKitTests): Start reporting to results.webkit.org.
(RunWebKitTests.__init__): Do not print the environment to hide the API key.
(RunWebKitTests.start): Add the API key to the environment.
(RunAPITests): Start reporting to results.webkit.org.
(RunAPITests.__init__): Do not print the environment to hide the API key.
(RunAPITests.start): Add the API key to the environment.
(RunPythonTests): Start reporting to results.webkit.org.
(RunPythonTests.__init__): Do not print the environment to hide the API key.
(RunPythonTests.start): Add the API key to the environment.
* Scripts/webkitpy/results/upload.py:
(Upload):
(Upload.upload): Add API_KEY, if it exists, to the request.
(Upload.upload_archive): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py
branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py
branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py
Diff
Modified: branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py (252664 => 252665)
--- branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py 2019-11-20 01:24:47 UTC (rev 252664)
+++ branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py 2019-11-20 01:24:50 UTC (rev 252665)
@@ -49,8 +49,11 @@
passwords = make_passwords_json.create_mock_slave_passwords_dict()
else:
passwords = json.load(open('passwords.json'))
+results_server_api_key = passwords.get('results-server-api-key')
+if results_server_api_key:
+os.environ['RESULTS_SERVER_API_KEY'] = results_server_api_key
+
config = json.load(open('config.json'))
-
c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']], max_builds=1) for slave in config['slaves']]
c['schedulers'] = []
Modified: branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py (252664 => 252665)
--- branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py 2019-11-20 01:24:47 UTC (rev 252664)
+++ branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py 2019-11-20 01:24:50 UTC (rev 252665)
@@ -31,7 +31,9 @@
def create_mock_slave_passwords_dict():
with open('config.json', 'r') as config_json:
config_dict = json.load(config_json)
-return dict([(slave['name'], '1234') for slave in config_dict['slaves']])
+result = dict([(slave['name'], '1234') for slave in config_dict['slaves']])
+result['results-server-api-key'] = 'api-key'
+return result
if __name__ == '__main__':
with open('passwords.json', 'w') as passwords_file:
Modified: branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (252664 => 252665)
--- branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-11-20 01:24:47 UTC (rev 252664)
+++ branches/safari-608-branch/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2019-11-20 01:24:50 UTC (rev 252665)
@@ -35,6 +35,8 @@
APPLE_WEBKIT_AWS_PROXY = "http://proxy01.webkit.org:3128"
S3URL = "https://s3-us-west-2.amazonaws.com/"
WithProperties = properties.WithProperties
+RESULTS_WEBKIT = 'https://results.webkit.org'
+RESULTS_SERVER_API_KEY = 'RESULTS_SERVER_API_KEY'
class TestWithFailureCount(shell.Test):
@@ -393,13 +395,22 @@
"--clobber-old-results",
"--builder-name", WithProperties("%(buildername)s"),
"--build-number", WithProperties("%(buildnumber)s"),
+ "--buildbot-worker", WithProperties("%(slavename)s"),
"--master-name", "webkit.org",
+ "--buildbot-master", "build.webkit.org",
+ "--report", RESULTS_WEBKIT,
"--test-results-server", "webkit-test-results.webkit.org",
"--exit-afte
[webkit-changes] [252662] branches/safari-608-branch/Tools
Title: [252662] branches/safari-608-branch/Tools
Revision 252662
Author alanc...@apple.com
Date 2019-11-19 17:24:40 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r249652. rdar://problem/55190632
run-webkit-tests: Report results archive to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=201321
Reviewed by Aakash Jain.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): After all tests are finish, upload the results archive for each
configuration.
* Scripts/webkitpy/results/upload.py:
(Upload):
(Upload.__init__): Automatically define timestamp.
(Upload.upload_archive): Upload an archive associated with the test run.
* Scripts/webkitpy/results/upload_unittest.py:
(UploadTest.test_buildbot):
(UploadTest):
(UploadTest.test_archive_upload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py
Diff
Modified: branches/safari-608-branch/Tools/ChangeLog (252661 => 252662)
--- branches/safari-608-branch/Tools/ChangeLog 2019-11-20 00:56:39 UTC (rev 252661)
+++ branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:40 UTC (rev 252662)
@@ -1,3 +1,46 @@
+2019-11-19 Alan Coon
+
+Cherry-pick r249652. rdar://problem/55190632
+
+run-webkit-tests: Report results archive to results.webkit.org
+https://bugs.webkit.org/show_bug.cgi?id=201321
+
+Reviewed by Aakash Jain.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run): After all tests are finish, upload the results archive for each
+configuration.
+* Scripts/webkitpy/results/upload.py:
+(Upload):
+(Upload.__init__): Automatically define timestamp.
+(Upload.upload_archive): Upload an archive associated with the test run.
+* Scripts/webkitpy/results/upload_unittest.py:
+(UploadTest.test_buildbot):
+(UploadTest):
+(UploadTest.test_archive_upload):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-09 Jonathan Bedard
+
+run-webkit-tests: Report results archive to results.webkit.org
+https://bugs.webkit.org/show_bug.cgi?id=201321
+
+Reviewed by Aakash Jain.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.run): After all tests are finish, upload the results archive for each
+configuration.
+* Scripts/webkitpy/results/upload.py:
+(Upload):
+(Upload.__init__): Automatically define timestamp.
+(Upload.upload_archive): Upload an archive associated with the test run.
+* Scripts/webkitpy/results/upload_unittest.py:
+(UploadTest.test_buildbot):
+(UploadTest):
+(UploadTest.test_archive_upload):
+
2019-11-18 Alan Coon
Apply patch. rdar://problem/57283569
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (252661 => 252662)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2019-11-20 00:56:39 UTC (rev 252661)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2019-11-20 01:24:40 UTC (rev 252662)
@@ -37,6 +37,7 @@
import json
import logging
import random
+import shutil
import sys
import time
from collections import defaultdict, OrderedDict
@@ -244,6 +245,7 @@
max_child_processes_for_run = 1
child_processes_option_value = self._options.child_processes
+uploads = []
for device_type in device_type_list:
self._runner._test_is_slow = lambda test_file: self._test_is_slow(test_file, device_type=device_type)
@@ -281,6 +283,7 @@
configuration=configuration,
details=Upload.create_details(options=self._options),
commits=self._port.commits_for_upload(),
+timestamp=start_time,
run_stats=Upload.create_run_stats(
start_time=start_time_for_device,
end_time=time.time(),
@@ -288,10 +291,12 @@
),
results=self._results_to_upload_json_trie(self._expectations[device_type], temp_initial_results),
)
-for url in self._options.report_urls:
-self._printer.write_update('Uploading to {} ...'.format(url))
-if not upload.upload(url, log_line_func=self._printer.writeln):
+for hostname in self._options.report_urls:
+
[webkit-changes] [252663] branches/safari-608-branch/Tools
Title: [252663] branches/safari-608-branch/Tools
Revision 252663
Author alanc...@apple.com
Date 2019-11-19 17:24:45 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r252058. rdar://problem/56889868
webkitpy: Build ImageDiff if it is missing (Follow-fix)
https://bugs.webkit.org/show_bug.cgi?id=183422
Unreviewed infrastructure fix.
* Scripts/webkitpy/port/base.py:
(Port._path_to_image_diff): Use the host build directory.
* Scripts/webkitpy/port/config.py:
(Config.build_directory): Allow the caller to ignore the port argument, which will return the default
build directory for the host running the script.
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.make_port):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py
branches/safari-608-branch/Tools/Scripts/webkitpy/port/config.py
branches/safari-608-branch/Tools/Scripts/webkitpy/port/port_testcase.py
Diff
Modified: branches/safari-608-branch/Tools/ChangeLog (252662 => 252663)
--- branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:40 UTC (rev 252662)
+++ branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:45 UTC (rev 252663)
@@ -1,5 +1,39 @@
2019-11-19 Alan Coon
+Cherry-pick r252058. rdar://problem/56889868
+
+webkitpy: Build ImageDiff if it is missing (Follow-fix)
+https://bugs.webkit.org/show_bug.cgi?id=183422
+
+Unreviewed infrastructure fix.
+
+* Scripts/webkitpy/port/base.py:
+(Port._path_to_image_diff): Use the host build directory.
+* Scripts/webkitpy/port/config.py:
+(Config.build_directory): Allow the caller to ignore the port argument, which will return the default
+build directory for the host running the script.
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.make_port):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-11-05 Jonathan Bedard
+
+webkitpy: Build ImageDiff if it is missing (Follow-fix)
+https://bugs.webkit.org/show_bug.cgi?id=183422
+
+Unreviewed infrastructure fix.
+
+* Scripts/webkitpy/port/base.py:
+(Port._path_to_image_diff): Use the host build directory.
+* Scripts/webkitpy/port/config.py:
+(Config.build_directory): Allow the caller to ignore the port argument, which will return the default
+build directory for the host running the script.
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.make_port):
+
+2019-11-19 Alan Coon
+
Cherry-pick r249652. rdar://problem/55190632
run-webkit-tests: Report results archive to results.webkit.org
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py (252662 => 252663)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py 2019-11-20 01:24:40 UTC (rev 252662)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py 2019-11-20 01:24:45 UTC (rev 252663)
@@ -1385,7 +1385,12 @@
"""Returns the full path to the image_diff binary, or None if it is not available.
This is likely used only by diff_image()"""
-return self._build_path('ImageDiff')
+default_image_diff = self._path_to_default_image_diff()
+if self._filesystem.exists(default_image_diff):
+return default_image_diff
+built_image_diff = self._filesystem.join(self._config.build_directory(self.get_option('configuration'), for_host=True), 'ImageDiff')
+_log.debug('ImageDiff not found at {}, using {} instead'.format(default_image_diff, built_image_diff))
+return built_image_diff
API_TEST_BINARY_NAMES = ['TestWTF', 'TestWebKitAPI']
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/port/config.py (252662 => 252663)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/port/config.py 2019-11-20 01:24:40 UTC (rev 252662)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/port/config.py 2019-11-20 01:24:45 UTC (rev 252663)
@@ -79,7 +79,7 @@
self._build_directories = {}
self._port_implementation = port_implementation
-def build_directory(self, configuration):
+def build_directory(self, configuration, for_host=False):
"""Returns the path to the build directory for the configuration."""
if configuration:
flags = ["--configuration", self.flag_for_configuration(configuration)]
@@ -87,7 +87,7 @@
configuration = ""
flags = []
-if self._port_implementation:
+if self._port_implementation and not for_host:
flags.append('--' + self._port_implementation)
if not self._build_directories.get(configuration):
Modified: branches/safari-608-branch/Tools
[webkit-changes] [252666] branches/safari-608-branch/Tools
Title: [252666] branches/safari-608-branch/Tools
Revision 252666
Author alanc...@apple.com
Date 2019-11-19 17:24:53 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r250997. rdar://problem/56177210
results.webkit.org: Sort out certificates on Catalina
https://bugs.webkit.org/show_bug.cgi?id=202837
Unreviewed infrastructure repair.
This is a temporary strategy until we sort out our certificates on the newly
deployed Catalina bots.
* Scripts/webkitpy/results/upload.py:
(Upload.upload):
(Upload.upload_archive):
* Scripts/webkitpy/results/upload_unittest.py:
(UploadTest.test_upload):
(UploadTest.test_archive_upload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py
branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py
Diff
Modified: branches/safari-608-branch/Tools/ChangeLog (252665 => 252666)
--- branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:50 UTC (rev 252665)
+++ branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:24:53 UTC (rev 252666)
@@ -1,5 +1,44 @@
2019-11-19 Alan Coon
+Cherry-pick r250997. rdar://problem/56177210
+
+results.webkit.org: Sort out certificates on Catalina
+https://bugs.webkit.org/show_bug.cgi?id=202837
+
+Unreviewed infrastructure repair.
+
+This is a temporary strategy until we sort out our certificates on the newly
+deployed Catalina bots.
+
+* Scripts/webkitpy/results/upload.py:
+(Upload.upload):
+(Upload.upload_archive):
+* Scripts/webkitpy/results/upload_unittest.py:
+(UploadTest.test_upload):
+(UploadTest.test_archive_upload):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-10 Jonathan Bedard
+
+results.webkit.org: Sort out certificates on Catalina
+https://bugs.webkit.org/show_bug.cgi?id=202837
+
+Unreviewed infrastructure repair.
+
+This is a temporary strategy until we sort out our certificates on the newly
+deployed Catalina bots.
+
+* Scripts/webkitpy/results/upload.py:
+(Upload.upload):
+(Upload.upload_archive):
+* Scripts/webkitpy/results/upload_unittest.py:
+(UploadTest.test_upload):
+(UploadTest.test_archive_upload):
+
+2019-11-19 Alan Coon
+
Cherry-pick r250966. rdar://problem/56047710
results.webkit.org: Start reporting results
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py (252665 => 252666)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py 2019-11-20 01:24:50 UTC (rev 252665)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload.py 2019-11-20 01:24:53 UTC (rev 252666)
@@ -178,6 +178,7 @@
'{}{}'.format(hostname, self.UPLOAD_ENDPOINT),
headers={'Content-type': 'application/json'},
data=""
+verify=False,
)
except requests.exceptions.ConnectionError:
log_line_func(' ' * 4 + 'Failed to upload to {}, results server not online'.format(hostname))
@@ -215,6 +216,7 @@
'{}{}'.format(hostname, self.ARCHIVE_UPLOAD_ENDPOINT),
data=""
files=dict(file=archive),
+verify=False,
)
except requests.exceptions.ConnectionError:
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py (252665 => 252666)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py 2019-11-20 01:24:50 UTC (rev 252665)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/results/upload_unittest.py 2019-11-20 01:24:53 UTC (rev 252666)
@@ -126,15 +126,15 @@
)],
)
-with mock.patch('requests.post', new=lambda url, headers={}, data="" self.MockResponse()):
+with mock.patch('requests.post', new=lambda url, headers={}, data="" verify=True: self.MockResponse()):
self.assertTrue(upload.upload('https://results.webkit.org', log_line_func=lambda _: None))
-with mock.patch('requests.post', new=lambda url, headers={}, data="" self.raise_requests_ConnectionError()):
+with mock.patch('requests.post', new=lambda url, headers={}, data="" verify=True: self.raise_requests_ConnectionError()):
lines = []
self.assertFalse(upload.upload('https://results.webkit.org', log_line_func=lambda line: lines.append(line)))
self.assertEqual([' ' * 4 + 'Failed to upload to https://results.webkit.org, results server not online'], lines)
-mock_404 = mock.patch('requests.post', new=lambda url, headers={}, data="" self.MockRespon
[webkit-changes] [252667] trunk
Title: [252667] trunk
Revision 252667
Author commit-qu...@webkit.org
Date 2019-11-19 17:27:35 -0800 (Tue, 19 Nov 2019)
Log Message
Nullptr crash in Node::setTextContent via Document::setTitle if title element is removed before setTextContent call.
https://bugs.webkit.org/show_bug.cgi?id=204332
Patch by Sunny He on 2019-11-19
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/Document/title-property-set-with-dom-event.html
* dom/Document.cpp:
(WebCore::Document::setTitle):
LayoutTests:
* fast/dom/Document/title-property-set-with-dom-event-expected.txt: Added.
* fast/dom/Document/title-property-set-with-dom-event.html: Added.
* fast/dom/Document/title-property-set-with-dom-event-svg-expected.html: Added.
* fast/dom/Document/title-property-set-with-dom-event-svg.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Added Paths
trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-expected.txt
trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg-expected.txt
trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg.html
trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252666 => 252667)
--- trunk/LayoutTests/ChangeLog 2019-11-20 01:24:53 UTC (rev 252666)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 01:27:35 UTC (rev 252667)
@@ -1,3 +1,14 @@
+2019-11-19 Sunny He
+
+Nullptr crash in Node::setTextContent via Document::setTitle if title element is removed before setTextContent call.
+https://bugs.webkit.org/show_bug.cgi?id=204332
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/Document/title-property-set-with-dom-event-expected.txt: Added.
+* fast/dom/Document/title-property-set-with-dom-event.html: Added.
+* fast/dom/Document/title-property-set-with-dom-event-svg-expected.html: Added.
+* fast/dom/Document/title-property-set-with-dom-event-svg.html: Added.
2019-11-19 Jiewen Tan
Unreviewed, test gardening
Added: trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-expected.txt (0 => 252667)
--- trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-expected.txt 2019-11-20 01:27:35 UTC (rev 252667)
@@ -0,0 +1 @@
+Test that setting title while there is a registred DOMNodeInserted event handler which indirectly deletes title doesn't crash.
Added: trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg-expected.txt (0 => 252667)
--- trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg-expected.txt 2019-11-20 01:27:35 UTC (rev 252667)
@@ -0,0 +1 @@
+Test that setting title of a SVG document while there is a registred DOMNodeInserted event handler which indirectly deletes title doesn't crash.
Added: trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg.html (0 => 252667)
--- trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event-svg.html 2019-11-20 01:27:35 UTC (rev 252667)
@@ -0,0 +1,23 @@
+
+
+
+function test() {
+if (window.testRunner) {
+window.testRunner.dumpAsText();
+}
+var SVG_NAMESPACE = "http://www.w3.org/2000/svg";
+var svgDocument = document.implementation.createDocument(SVG_NAMESPACE, "svg", null);
+
+svgDocument.addEventListener("DOMNodeInserted", () => {
+var a = svgDocument.querySelector("title").remove();
+});
+svgDocument.title = "abc"
+}
+test()
+
+
+
+Test that setting title of a SVG document while there is a registred DOMNodeInserted event handler which indirectly deletes title doesn't crash.
+
+
+
\ No newline at end of file
Added: trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event.html (0 => 252667)
--- trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Document/title-property-set-with-dom-event.html 2019-11-20 01:27:35 UTC (rev 252667)
@@ -0,0 +1,21 @@
+
+
+
+function test() {
+if (window.testRunner) {
+window.testRunner.dumpAsText();
+}
+
+window.top.addEventListener("DOMNodeInserted", () => {
+document.head.innerHTML = 123;
+}, {once : true});
+document.title = "abc";
+}
+test()
+
+
+
+Test that setting title while there is a registred DOMNodeInserted event handler which indirectly deletes title doesn't crash.
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (252666 => 252667)
--- trunk/Source/WebCore/ChangeLog 201
[webkit-changes] [252668] trunk/LayoutTests
Title: [252668] trunk/LayoutTests
Revision 252668
Author jiewen_...@apple.com
Date 2019-11-19 17:35:20 -0800 (Tue, 19 Nov 2019)
Log Message
Improve WebAuthn NFC tests after r252297
https://bugs.webkit.org/show_bug.cgi?id=204251
Reviewed by Alexey Proskuryakov.
This patch fixes a test failure after r252297 and adds new test contents for r252297.
* http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt:
* http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
* http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
* http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252667 => 252668)
--- trunk/LayoutTests/ChangeLog 2019-11-20 01:27:35 UTC (rev 252667)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 01:35:20 UTC (rev 252668)
@@ -1,3 +1,17 @@
+2019-11-19 Jiewen Tan
+
+Improve WebAuthn NFC tests after r252297
+https://bugs.webkit.org/show_bug.cgi?id=204251
+
+Reviewed by Alexey Proskuryakov.
+
+This patch fixes a test failure after r252297 and adds new test contents for r252297.
+
+* http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html:
+* http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-success-nfc.https.html:
+
2019-11-19 Sunny He
Nullptr crash in Node::setTextContent via Document::setTitle if title element is removed before setTextContent call.
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt (252667 => 252668)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt 2019-11-20 01:27:35 UTC (rev 252667)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https-expected.txt 2019-11-20 01:35:20 UTC (rev 252668)
@@ -5,4 +5,5 @@
PASS PublicKeyCredential's [[create]] with no connections in a mock nfc authenticator.
PASS PublicKeyCredential's [[create]] with null version in a mock nfc authenticator.
PASS PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.
+PASS PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.2
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html (252667 => 252668)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html 2019-11-20 01:27:35 UTC (rev 252667)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-nfc.https.html 2019-11-20 01:35:20 UTC (rev 252668)
@@ -137,4 +137,26 @@
return promiseRejects(t, "NotAllowedError", navigator.credentials.create(options), "Operation timed out.");
}, "PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.");
+promise_test(function(t) {
+const options = {
+publicKey: {
+rp: {
+name: "example.com"
+},
+user: {
+name: "John Appleseed",
+id: asciiToUint8Array("123456"),
+displayName: "John",
+},
+challenge: asciiToUint8Array("123456"),
+pubKeyCredParams: [{ type: "public-key", alg: -7 }],
+timeout: 10
+}
+};
+
+if (window.internals)
+internals.setMockWebAuthenticationConfiguration({ nfc: { error: "malicious-payload", payloadBase64:[testDummyMessagePayloadBase64, testDummyMessagePayloadBase64] } });
+return promiseRejects(t, "NotAllowedError", navigator.credentials.create(options), "Operation timed out.");
+}, "PublicKeyCredential's [[create]] with wrong version in a mock nfc authenticator.2");
+
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt (252667 => 252668)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt 2019-11-20 01:27:35 UTC (rev 252667)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-nfc.https-expected.txt 2019-11-20 01:35:20 UTC (rev 252668)
@@ -5,4 +5,5 @@
PASS PublicKeyCredential's [[create]] with U2F in a mock nfc authenticator.
PASS PublicKeyCredential's [[create]] with multiple physical tags in a m
[webkit-changes] [252669] branches/safari-608-branch/Tools
Title: [252669] branches/safari-608-branch/Tools
Revision 252669
Author alanc...@apple.com
Date 2019-11-19 17:37:25 -0800 (Tue, 19 Nov 2019)
Log Message
Cherry-pick r252031. rdar://problem/56889868
webkitpy: Build ImageDiff if it is missing
https://bugs.webkit.org/show_bug.cgi?id=183422
Reviewed by Alexey Proskuryakov.
ImageDiff is built with a different SDK than the rest of the WebKit
stack, and this frequently causes infrastructure failures where ImageDiff
is missing on testers. To address this, we should automatically build
ImageDiff if it is missing.
* Scripts/webkitpy/port/base.py:
(Port.check_build): Unconditionally build ImageDiff if it is missing.
(Port.check_image_diff): Use _build_path since _path_to_image_diff will
attempt to use a back-up location.
(Port._path_to_image_diff): If the provided path to ImageDiff does not
exist, use the path of the one we built.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py
Diff
Modified: branches/safari-608-branch/Tools/ChangeLog (252668 => 252669)
--- branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:35:20 UTC (rev 252668)
+++ branches/safari-608-branch/Tools/ChangeLog 2019-11-20 01:37:25 UTC (rev 252669)
@@ -1,5 +1,47 @@
2019-11-19 Alan Coon
+Cherry-pick r252031. rdar://problem/56889868
+
+webkitpy: Build ImageDiff if it is missing
+https://bugs.webkit.org/show_bug.cgi?id=183422
+
+Reviewed by Alexey Proskuryakov.
+
+ImageDiff is built with a different SDK than the rest of the WebKit
+stack, and this frequently causes infrastructure failures where ImageDiff
+is missing on testers. To address this, we should automatically build
+ImageDiff if it is missing.
+
+* Scripts/webkitpy/port/base.py:
+(Port.check_build): Unconditionally build ImageDiff if it is missing.
+(Port.check_image_diff): Use _build_path since _path_to_image_diff will
+attempt to use a back-up location.
+(Port._path_to_image_diff): If the provided path to ImageDiff does not
+exist, use the path of the one we built.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-11-04 Jonathan Bedard
+
+webkitpy: Build ImageDiff if it is missing
+https://bugs.webkit.org/show_bug.cgi?id=183422
+
+Reviewed by Alexey Proskuryakov.
+
+ImageDiff is built with a different SDK than the rest of the WebKit
+stack, and this frequently causes infrastructure failures where ImageDiff
+is missing on testers. To address this, we should automatically build
+ImageDiff if it is missing.
+
+* Scripts/webkitpy/port/base.py:
+(Port.check_build): Unconditionally build ImageDiff if it is missing.
+(Port.check_image_diff): Use _build_path since _path_to_image_diff will
+attempt to use a back-up location.
+(Port._path_to_image_diff): If the provided path to ImageDiff does not
+exist, use the path of the one we built.
+
+2019-11-19 Alan Coon
+
Cherry-pick r250997. rdar://problem/56177210
results.webkit.org: Sort out certificates on Catalina
Modified: branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py (252668 => 252669)
--- branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py 2019-11-20 01:35:20 UTC (rev 252668)
+++ branches/safari-608-branch/Tools/Scripts/webkitpy/port/base.py 2019-11-20 01:37:25 UTC (rev 252669)
@@ -243,10 +243,7 @@
if self.get_option('install') and not self._check_port_build():
return False
if not self.check_image_diff():
-if self.get_option('build'):
-return self._build_image_diff()
-else:
-return False
+return self._build_image_diff()
return True
def check_api_test_build(self, canonicalized_binaries=None):
@@ -295,7 +292,7 @@
def check_image_diff(self, override_step=None, logging=True):
"""This routine is used to check whether image_diff binary exists."""
-image_diff_path = self._path_to_image_diff()
+image_diff_path = self._build_path('ImageDiff')
if not self._filesystem.exists(image_diff_path):
if logging:
_log.error("ImageDiff was not found at %s" % image_diff_path)
@@ -1381,6 +1378,7 @@
This is likely only used by start/stop_helper()."""
return None
+@memoized
def _path_to_image_diff(self):
"""Returns the full path to the image_diff binary, or None if it is not available.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [252670] trunk
Title: [252670] trunk Revision 252670 Author sihui_...@apple.com Date 2019-11-19 17:53:06 -0800 (Tue, 19 Nov 2019) Log Message IndexedDB: update m_objectStoresByName after renaming object store https://bugs.webkit.org/show_bug.cgi?id=204373 Reviewed by Brady Eidson. Source/WebCore: Tests: storage/indexeddb/put-after-objectstore-rename-private.html storage/indexeddb/put-after-objectstore-rename.html * Modules/indexeddb/server/MemoryIDBBackingStore.cpp: (WebCore::IDBServer::MemoryIDBBackingStore::renameObjectStore): LayoutTests: * storage/indexeddb/put-after-objectstore-rename-expected.txt: Added. * storage/indexeddb/put-after-objectstore-rename-private-expected.txt: Added. * storage/indexeddb/put-after-objectstore-rename-private.html: Added. * storage/indexeddb/put-after-objectstore-rename.html: Added. * storage/indexeddb/resources/put-after-objectstore-rename.js: Added. (prepareDatabase): (openSuccess): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp Added Paths trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-expected.txt trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private-expected.txt trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private.html trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename.html trunk/LayoutTests/storage/indexeddb/resources/put-after-objectstore-rename.js Diff Modified: trunk/LayoutTests/ChangeLog (252669 => 252670) --- trunk/LayoutTests/ChangeLog 2019-11-20 01:37:25 UTC (rev 252669) +++ trunk/LayoutTests/ChangeLog 2019-11-20 01:53:06 UTC (rev 252670) @@ -1,3 +1,18 @@ +2019-11-19 Sihui Liu + +IndexedDB: update m_objectStoresByName after renaming object store +https://bugs.webkit.org/show_bug.cgi?id=204373 + +Reviewed by Brady Eidson. + +* storage/indexeddb/put-after-objectstore-rename-expected.txt: Added. +* storage/indexeddb/put-after-objectstore-rename-private-expected.txt: Added. +* storage/indexeddb/put-after-objectstore-rename-private.html: Added. +* storage/indexeddb/put-after-objectstore-rename.html: Added. +* storage/indexeddb/resources/put-after-objectstore-rename.js: Added. +(prepareDatabase): +(openSuccess): + 2019-11-19 Jiewen Tan Improve WebAuthn NFC tests after r252297 Added: trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-expected.txt (0 => 252670) --- trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-expected.txt (rev 0) +++ trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-expected.txt 2019-11-20 01:53:06 UTC (rev 252670) @@ -0,0 +1,18 @@ +This tests verifies put operation can be performed on renamed object store + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB; + +indexedDB.deleteDatabase(dbname) +indexedDB.open(dbname) +Open database upgradeneeded: database old version - 0, new version - 1 +Current objectStore name: ObjectStore +Current objectStore name: RenamedObjectStore +Open database success +Put success in renamed object store +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private-expected.txt (0 => 252670) --- trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private-expected.txt (rev 0) +++ trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private-expected.txt 2019-11-20 01:53:06 UTC (rev 252670) @@ -0,0 +1,18 @@ +This tests verifies put operation can be performed on renamed object store + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB; + +indexedDB.deleteDatabase(dbname) +indexedDB.open(dbname) +Open database upgradeneeded: database old version - 0, new version - 1 +Current objectStore name: ObjectStore +Current objectStore name: RenamedObjectStore +Open database success +Put success in renamed object store +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private.html (0 => 252670) --- trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private.html (rev 0) +++ trunk/LayoutTests/storage/indexeddb/put-after-objectstore-rename-private.html 2019-11-20 01:53:06 UTC (rev 252670) @@ -0,0 +1,10 @@ + + + +
[webkit-changes] [252672] trunk
Title: [252672] trunk
Revision 252672
Author sihui_...@apple.com
Date 2019-11-19 18:08:55 -0800 (Tue, 19 Nov 2019)
Log Message
IndexedDB: overflow of KeyGenerator in MemoryIDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=204366
Reviewed by Brady Eidson.
Source/WebCore:
Do not set KeyGenerator if it is key is bigger than 2^53.
Test: storage/indexeddb/key-generator-private.html
* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::maybeUpdateKeyGeneratorNumber):
LayoutTests:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-generator-private-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(request.onerror):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/key-generator-expected.txt
trunk/LayoutTests/storage/indexeddb/key-generator-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/key-generator.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (252671 => 252672)
--- trunk/LayoutTests/ChangeLog 2019-11-20 02:08:26 UTC (rev 252671)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 02:08:55 UTC (rev 252672)
@@ -1,5 +1,17 @@
2019-11-19 Sihui Liu
+IndexedDB: overflow of KeyGenerator in MemoryIDBBackingStore
+https://bugs.webkit.org/show_bug.cgi?id=204366
+
+Reviewed by Brady Eidson.
+
+* storage/indexeddb/key-generator-expected.txt:
+* storage/indexeddb/key-generator-private-expected.txt:
+* storage/indexeddb/resources/key-generator.js:
+(request.onerror):
+
+2019-11-19 Sihui Liu
+
IndexedDB: update m_objectStoresByName after renaming object store
https://bugs.webkit.org/show_bug.cgi?id=204373
Modified: trunk/LayoutTests/storage/indexeddb/key-generator-expected.txt (252671 => 252672)
--- trunk/LayoutTests/storage/indexeddb/key-generator-expected.txt 2019-11-20 02:08:26 UTC (rev 252671)
+++ trunk/LayoutTests/storage/indexeddb/key-generator-expected.txt 2019-11-20 02:08:55 UTC (rev 252672)
@@ -161,6 +161,28 @@
PASS Got "d" for key: 2
db.close()
+Verify that keys above 2^64 result in errors.
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+trans1 = db.transaction(['store'], 'readwrite')
+store_t1 = trans1.objectStore('store')
+store_t1.put('a')
+request = store.get(1)
+store_t1.put('b', Math.pow(2, 64))
+request = store.get(18446744073709552000)
+store_t1.put('c')
+store_t1.put('d', 2)
+request = store.get(2)
+PASS Got "a" for key: 1
+PASS Got "b" for key: 18446744073709552000
+Error event fired auto-incrementing past 2^64 (as expected)
+PASS event.target.error.name is 'ConstraintError'
+event.preventDefault()
+PASS Got "d" for key: 2
+db.close()
+
Ensure key generator state is maintained across connections:
indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
Modified: trunk/LayoutTests/storage/indexeddb/key-generator-private-expected.txt (252671 => 252672)
--- trunk/LayoutTests/storage/indexeddb/key-generator-private-expected.txt 2019-11-20 02:08:26 UTC (rev 252671)
+++ trunk/LayoutTests/storage/indexeddb/key-generator-private-expected.txt 2019-11-20 02:08:55 UTC (rev 252672)
@@ -161,6 +161,28 @@
PASS Got "d" for key: 2
db.close()
+Verify that keys above 2^64 result in errors.
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+trans1 = db.transaction(['store'], 'readwrite')
+store_t1 = trans1.objectStore('store')
+store_t1.put('a')
+request = store.get(1)
+store_t1.put('b', Math.pow(2, 64))
+request = store.get(18446744073709552000)
+store_t1.put('c')
+store_t1.put('d', 2)
+request = store.get(2)
+PASS Got "a" for key: 1
+PASS Got "b" for key: 18446744073709552000
+Error event fired auto-incrementing past 2^64 (as expected)
+PASS event.target.error.name is 'ConstraintError'
+event.preventDefault()
+PASS Got "d" for key: 2
+db.close()
+
Ensure key generator state is maintained across connections:
indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
Modified: trunk/LayoutTests/storage/indexeddb/resources/key-generator.js (252671 => 252672)
--- trunk/LayoutTests/storage/indexeddb/resources/key-generator.js 2019-11-20 02:08:26 UTC (rev 252671)
+++ trunk/LayoutTests/storage/indexeddb/resources/key-generator.js 2019-11-20 02:08:55 UTC (rev 252672)
@@ -221,6 +221,33 @@
}
);
+defineTest(
+'Verify that keys above 2^64 result in errors.',
+function (db, trans) {
+db.createObjectStore('store', { autoIncrement: true });
+},
+
+function (db, callback) {
+evalAndLog("trans1 =
[webkit-changes] [252671] trunk/Source/JavaScriptCore
Title: [252671] trunk/Source/_javascript_Core
Revision 252671
Author hironori.fu...@sony.com
Date 2019-11-19 18:08:26 -0800 (Tue, 19 Nov 2019)
Log Message
[JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of using WTF::threadSpecificKeyCreate directly
https://bugs.webkit.org/show_bug.cgi?id=204350
Reviewed by Yusuke Suzuki.
WTF provides two thread specific storages, ThreadSpecific and
threadSpecificKeyCreate. Only DisallowVMReentry and DeferGC were
using the latter. They should use WTF::ThreadSpecific because it
is a useful type-safe wrapper class.
* heap/DeferGC.cpp:
* heap/DeferGC.h:
(JSC::DisallowGC::initialize):
(JSC::DisallowGC::scopeReentryCount):
(JSC::DisallowGC::setScopeReentryCount):
* runtime/DisallowVMReentry.cpp:
* runtime/DisallowVMReentry.h:
(JSC::DisallowVMReentry::initialize):
(JSC::DisallowVMReentry::scopeReentryCount):
(JSC::DisallowVMReentry::setScopeReentryCount):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/DeferGC.cpp
trunk/Source/_javascript_Core/heap/DeferGC.h
trunk/Source/_javascript_Core/runtime/DisallowVMReentry.cpp
trunk/Source/_javascript_Core/runtime/DisallowVMReentry.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (252670 => 252671)
--- trunk/Source/_javascript_Core/ChangeLog 2019-11-20 01:53:06 UTC (rev 252670)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-11-20 02:08:26 UTC (rev 252671)
@@ -1,3 +1,26 @@
+2019-11-19 Fujii Hironori
+
+[JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of using WTF::threadSpecificKeyCreate directly
+https://bugs.webkit.org/show_bug.cgi?id=204350
+
+Reviewed by Yusuke Suzuki.
+
+WTF provides two thread specific storages, ThreadSpecific and
+threadSpecificKeyCreate. Only DisallowVMReentry and DeferGC were
+using the latter. They should use WTF::ThreadSpecific because it
+is a useful type-safe wrapper class.
+
+* heap/DeferGC.cpp:
+* heap/DeferGC.h:
+(JSC::DisallowGC::initialize):
+(JSC::DisallowGC::scopeReentryCount):
+(JSC::DisallowGC::setScopeReentryCount):
+* runtime/DisallowVMReentry.cpp:
+* runtime/DisallowVMReentry.h:
+(JSC::DisallowVMReentry::initialize):
+(JSC::DisallowVMReentry::scopeReentryCount):
+(JSC::DisallowVMReentry::setScopeReentryCount):
+
2019-11-19 Yusuke Suzuki
[JSC] Work-around Leaks' false-positive report about memory leaking
Modified: trunk/Source/_javascript_Core/heap/DeferGC.cpp (252670 => 252671)
--- trunk/Source/_javascript_Core/heap/DeferGC.cpp 2019-11-20 01:53:06 UTC (rev 252670)
+++ trunk/Source/_javascript_Core/heap/DeferGC.cpp 2019-11-20 02:08:26 UTC (rev 252671)
@@ -31,7 +31,7 @@
namespace JSC {
#ifndef NDEBUG
-WTF::ThreadSpecificKey DisallowGC::s_scopeReentryCount = 0;
+LazyNeverDestroyed> DisallowGC::s_scopeReentryCount;
#endif
} // namespace JSC
Modified: trunk/Source/_javascript_Core/heap/DeferGC.h (252670 => 252671)
--- trunk/Source/_javascript_Core/heap/DeferGC.h 2019-11-20 01:53:06 UTC (rev 252670)
+++ trunk/Source/_javascript_Core/heap/DeferGC.h 2019-11-20 02:08:26 UTC (rev 252671)
@@ -27,6 +27,7 @@
#include "DisallowScope.h"
#include "Heap.h"
+#include
#include
namespace JSC {
@@ -89,20 +90,20 @@
static void initialize()
{
-WTF::threadSpecificKeyCreate(&s_scopeReentryCount, 0);
+s_scopeReentryCount.construct();
}
private:
-static uintptr_t scopeReentryCount()
+static unsigned scopeReentryCount()
{
-return reinterpret_cast(WTF::threadSpecificGet(s_scopeReentryCount));
+return *s_scopeReentryCount.get();
}
-static void setScopeReentryCount(uintptr_t value)
+static void setScopeReentryCount(unsigned value)
{
-WTF::threadSpecificSet(s_scopeReentryCount, reinterpret_cast(value));
+*s_scopeReentryCount.get() = value;
}
-JS_EXPORT_PRIVATE static WTF::ThreadSpecificKey s_scopeReentryCount;
+JS_EXPORT_PRIVATE static LazyNeverDestroyed> s_scopeReentryCount;
#endif // NDEBUG
Modified: trunk/Source/_javascript_Core/runtime/DisallowVMReentry.cpp (252670 => 252671)
--- trunk/Source/_javascript_Core/runtime/DisallowVMReentry.cpp 2019-11-20 01:53:06 UTC (rev 252670)
+++ trunk/Source/_javascript_Core/runtime/DisallowVMReentry.cpp 2019-11-20 02:08:26 UTC (rev 252671)
@@ -31,7 +31,7 @@
namespace JSC {
#ifndef NDEBUG
-WTF::ThreadSpecificKey DisallowVMReentry::s_scopeReentryCount = 0;
+LazyNeverDestroyed> DisallowVMReentry::s_scopeReentryCount;
#endif
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/DisallowVMReentry.h (252670 => 252671)
--- trunk/Source/_javascript_Core/runtime/DisallowVMReentry.h 2019-11-20 01:53:06 UTC (rev 252670)
+++ trunk/Source/_javascript_Core/runtime/DisallowVMReentry.h 2019-11-20 02:08:26 UTC (rev 252671)
@@ -26,6 +26,7 @@
#pragma o
[webkit-changes] [252673] trunk/Source/WebCore
Title: [252673] trunk/Source/WebCore Revision 252673 Author sihui_...@apple.com Date 2019-11-19 18:13:24 -0800 (Tue, 19 Nov 2019) Log Message IndexedDB: pass along error of IDBBackingStore operations https://bugs.webkit.org/show_bug.cgi?id=204381 Reviewed by Brady Eidson. Covered by existing tests. * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::performClearObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (252672 => 252673) --- trunk/Source/WebCore/ChangeLog 2019-11-20 02:08:55 UTC (rev 252672) +++ trunk/Source/WebCore/ChangeLog 2019-11-20 02:13:24 UTC (rev 252673) @@ -1,5 +1,20 @@ 2019-11-19 Sihui Liu +IndexedDB: pass along error of IDBBackingStore operations +https://bugs.webkit.org/show_bug.cgi?id=204381 + +Reviewed by Brady Eidson. + +Covered by existing tests. + +* Modules/indexeddb/server/UniqueIDBDatabase.cpp: +(WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore): +(WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore): +(WebCore::IDBServer::UniqueIDBDatabase::performClearObjectStore): +(WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex): + +2019-11-19 Sihui Liu + IndexedDB: overflow of KeyGenerator in MemoryIDBBackingStore https://bugs.webkit.org/show_bug.cgi?id=204366 Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (252672 => 252673) --- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-11-20 02:08:55 UTC (rev 252672) +++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-11-20 02:13:24 UTC (rev 252673) @@ -892,9 +892,8 @@ } ASSERT(m_backingStore); -m_backingStore->createObjectStore(transactionIdentifier, info); +IDBError error = m_backingStore->createObjectStore(transactionIdentifier, info); -IDBError error; postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformCreateObjectStore, callbackIdentifier, error, info)); } @@ -945,9 +944,8 @@ LOG(IndexedDB, "(db) UniqueIDBDatabase::performDeleteObjectStore"); ASSERT(m_backingStore); -m_backingStore->deleteObjectStore(transactionIdentifier, objectStoreIdentifier); +IDBError error = m_backingStore->deleteObjectStore(transactionIdentifier, objectStoreIdentifier); -IDBError error; postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformDeleteObjectStore, callbackIdentifier, error, objectStoreIdentifier)); } @@ -1048,9 +1046,8 @@ LOG(IndexedDB, "(db) UniqueIDBDatabase::performClearObjectStore"); ASSERT(m_backingStore); -m_backingStore->clearObjectStore(transactionIdentifier, objectStoreIdentifier); +IDBError error = m_backingStore->clearObjectStore(transactionIdentifier, objectStoreIdentifier); -IDBError error; postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformClearObjectStore, callbackIdentifier, error)); } @@ -1168,9 +1165,8 @@ LOG(IndexedDB, "(db) UniqueIDBDatabase::performDeleteIndex"); ASSERT(m_backingStore); -m_backingStore->deleteIndex(transactionIdentifier, objectStoreIdentifier, indexIdentifier); +IDBError error = m_backingStore->deleteIndex(transactionIdentifier, objectStoreIdentifier, indexIdentifier); -IDBError error; postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformDeleteIndex, callbackIdentifier, error, objectStoreIdentifier, indexIdentifier)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252674] trunk/Source/JavaScriptCore
Title: [252674] trunk/Source/_javascript_Core Revision 252674 Author ysuz...@apple.com Date 2019-11-19 18:28:52 -0800 (Tue, 19 Nov 2019) Log Message [JSC] MetadataTable::sizeInBytes should not touch m_rawBuffer in UnlinkedMetadataTable unless MetadataTable is linked to that UnlinkedMetadataTable https://bugs.webkit.org/show_bug.cgi?id=204390 Reviewed by Mark Lam. We have a race issue here. When calling MetadataTable::sizeInBytes, we call UnlinkedMetadataTable::sizeInBytes since we change the result based on whether this MetadataTable is linked to this UnlinkedMetadataTable or not. The problem is that we are calling `UnlinkedMetadataTable::totalSize` unconditionally in UnlinkedMetadataTable::sizeInBytes, and this is touching m_rawBuffer unconditionally. This is not correct since it is possible that this m_rawBuffer is realloced while we are calling MetadataTable::sizeInBytes in GC thread. 1. The GC thread is calling MetadataTable::sizeInBytes for MetadataTable "A". 2. The main thread is destroying MetadataTable "B". 3. MetadataTable "B" is linked to UnlinkedMetadataTable "C". 4. MetadataTable "A" is pointing to UnlinkedMetadataTable "C". 5. "A" is touching UnlinkedMetadataTable::m_rawBuffer in "C", called from MetadataTable::sizeInBytes. 6. (2) destroys MetadataTable "B", and realloc UnlinkedMetadataTable::m_rawBuffer in "C". 7. (5) can touch already freed buffer. This patch fixes UnlinkedMetadataTable::sizeInBytes: not touching m_rawBuffer unless it is owned by the caller's MetadataTable. We need to call UnlinkedMetadataTable::sizeInBytes anyway since we need to adjust the result based on whether the caller MetadataTable is linked to this UnlinkedMetadataTable. * bytecode/UnlinkedMetadataTableInlines.h: (JSC::UnlinkedMetadataTable::sizeInBytes): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTableInlines.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (252673 => 252674) --- trunk/Source/_javascript_Core/ChangeLog 2019-11-20 02:13:24 UTC (rev 252673) +++ trunk/Source/_javascript_Core/ChangeLog 2019-11-20 02:28:52 UTC (rev 252674) @@ -1,3 +1,29 @@ +2019-11-19 Yusuke Suzuki + +[JSC] MetadataTable::sizeInBytes should not touch m_rawBuffer in UnlinkedMetadataTable unless MetadataTable is linked to that UnlinkedMetadataTable +https://bugs.webkit.org/show_bug.cgi?id=204390 + +Reviewed by Mark Lam. + +We have a race issue here. When calling MetadataTable::sizeInBytes, we call UnlinkedMetadataTable::sizeInBytes since we change the result based on +whether this MetadataTable is linked to this UnlinkedMetadataTable or not. The problem is that we are calling `UnlinkedMetadataTable::totalSize` +unconditionally in UnlinkedMetadataTable::sizeInBytes, and this is touching m_rawBuffer unconditionally. This is not correct since it is possible +that this m_rawBuffer is realloced while we are calling MetadataTable::sizeInBytes in GC thread. + +1. The GC thread is calling MetadataTable::sizeInBytes for MetadataTable "A". +2. The main thread is destroying MetadataTable "B". +3. MetadataTable "B" is linked to UnlinkedMetadataTable "C". +4. MetadataTable "A" is pointing to UnlinkedMetadataTable "C". +5. "A" is touching UnlinkedMetadataTable::m_rawBuffer in "C", called from MetadataTable::sizeInBytes. +6. (2) destroys MetadataTable "B", and realloc UnlinkedMetadataTable::m_rawBuffer in "C". +7. (5) can touch already freed buffer. + +This patch fixes UnlinkedMetadataTable::sizeInBytes: not touching m_rawBuffer unless it is owned by the caller's MetadataTable. We need to call +UnlinkedMetadataTable::sizeInBytes anyway since we need to adjust the result based on whether the caller MetadataTable is linked to this UnlinkedMetadataTable. + +* bytecode/UnlinkedMetadataTableInlines.h: +(JSC::UnlinkedMetadataTable::sizeInBytes): + 2019-11-19 Fujii Hironori [JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of using WTF::threadSpecificKeyCreate directly Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTableInlines.h (252673 => 252674) --- trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTableInlines.h 2019-11-20 02:13:24 UTC (rev 252673) +++ trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTableInlines.h 2019-11-20 02:28:52 UTC (rev 252674) @@ -88,7 +88,10 @@ // In this case, we return the size of the table minus the offset table, // which was already accounted for in the UnlinkedCodeBlock. -size_t result = totalSize(); + +// Be careful not to touch m_rawBuffer if this metadataTable is not owning it. +// It is possible that, m_rawBuffer is realloced in the other thread while we are accessing here. +size_t result = metadataTable.totalSize(); if (me
[webkit-changes] [252675] trunk
Title: [252675] trunk
Revision 252675
Author commit-qu...@webkit.org
Date 2019-11-19 18:37:16 -0800 (Tue, 19 Nov 2019)
Log Message
Assertion failure in HTMLMediaElement::enterFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=204376
Patch by Peng Liu on 2019-11-19
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-set-presentation-mode-to-inline.html
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::setFullscreenMode):
LayoutTests:
* media/video-set-presentation-mode-to-inline-expected.txt: Added.
* media/video-set-presentation-mode-to-inline.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLVideoElement.cpp
Added Paths
trunk/LayoutTests/media/video-set-presentation-mode-to-inline-expected.txt
trunk/LayoutTests/media/video-set-presentation-mode-to-inline.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252674 => 252675)
--- trunk/LayoutTests/ChangeLog 2019-11-20 02:28:52 UTC (rev 252674)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 02:37:16 UTC (rev 252675)
@@ -1,3 +1,13 @@
+2019-11-19 Peng Liu
+
+Assertion failure in HTMLMediaElement::enterFullscreen()
+https://bugs.webkit.org/show_bug.cgi?id=204376
+
+Reviewed by Eric Carlson.
+
+* media/video-set-presentation-mode-to-inline-expected.txt: Added.
+* media/video-set-presentation-mode-to-inline.html: Added.
+
2019-11-19 Sihui Liu
IndexedDB: overflow of KeyGenerator in MemoryIDBBackingStore
Added: trunk/LayoutTests/media/video-set-presentation-mode-to-inline-expected.txt (0 => 252675)
--- trunk/LayoutTests/media/video-set-presentation-mode-to-inline-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-set-presentation-mode-to-inline-expected.txt 2019-11-20 02:37:16 UTC (rev 252675)
@@ -0,0 +1,10 @@
+This tests that setting the presentation mode of a video element to inline when it is in inline will not crash.
+
+RUN(internals.settings.setAllowsPictureInPictureMediaPlayback(true))
+RUN(video.src = "" "content/test"))
+EVENT(canplaythrough)
+RUN(video.play())
+RUN(video.webkitSetPresentationMode("inline"))
+RUN(video.webkitSetPresentationMode("inline"))
+END OF TEST
+
Added: trunk/LayoutTests/media/video-set-presentation-mode-to-inline.html (0 => 252675)
--- trunk/LayoutTests/media/video-set-presentation-mode-to-inline.html (rev 0)
+++ trunk/LayoutTests/media/video-set-presentation-mode-to-inline.html 2019-11-20 02:37:16 UTC (rev 252675)
@@ -0,0 +1,30 @@
+
+
+
+
+var eventCount = 0;
+
+function go()
+{
+findMediaElement();
+run('internals.settings.setAllowsPictureInPictureMediaPlayback(true)');
+run('video.src = "" "content/test")');
+waitForEventOnce('canplaythrough', canPlayThrough);
+}
+
+function canPlayThrough()
+{
+runWithKeyDown('video.play()');
+runWithKeyDown('video.webkitSetPresentationMode("inline")');
+runWithKeyDown('video.webkitSetPresentationMode("inline")');
+endTest();
+}
+
+
+
+This tests that setting the presentation mode of a video element to inline when it is in inline will not crash.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (252674 => 252675)
--- trunk/Source/WebCore/ChangeLog 2019-11-20 02:28:52 UTC (rev 252674)
+++ trunk/Source/WebCore/ChangeLog 2019-11-20 02:37:16 UTC (rev 252675)
@@ -1,3 +1,15 @@
+2019-11-19 Peng Liu
+
+Assertion failure in HTMLMediaElement::enterFullscreen()
+https://bugs.webkit.org/show_bug.cgi?id=204376
+
+Reviewed by Eric Carlson.
+
+Test: media/video-set-presentation-mode-to-inline.html
+
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::setFullscreenMode):
+
2019-11-19 Sihui Liu
IndexedDB: pass along error of IDBBackingStore operations
Modified: trunk/Source/WebCore/html/HTMLVideoElement.cpp (252674 => 252675)
--- trunk/Source/WebCore/html/HTMLVideoElement.cpp 2019-11-20 02:28:52 UTC (rev 252674)
+++ trunk/Source/WebCore/html/HTMLVideoElement.cpp 2019-11-20 02:37:16 UTC (rev 252675)
@@ -474,8 +474,10 @@
}
#endif
-if (mode == VideoFullscreenModeNone && isFullscreen()) {
-exitFullscreen();
+if (mode == VideoFullscreenModeNone) {
+if (isFullscreen())
+exitFullscreen();
+
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252676] trunk/LayoutTests
Title: [252676] trunk/LayoutTests
Revision 252676
Author commit-qu...@webkit.org
Date 2019-11-19 18:43:37 -0800 (Tue, 19 Nov 2019)
Log Message
Typos in layout test names
https://bugs.webkit.org/show_bug.cgi?id=204387
Patch by Peng Liu on 2019-11-19
Reviewed by Eric Carlson.
* media/video-fullscreen-only-controls-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-controls-expected.txt.
* media/video-fullscreen-only-controls.html: Renamed from LayoutTests/media/video-fullscreeen-only-controls.html.
* media/video-fullscreen-only-playback-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-playback-expected.txt.
* media/video-fullscreen-only-playback.html: Renamed from LayoutTests/media/video-fullscreeen-only-playback.html.
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
Added Paths
trunk/LayoutTests/media/video-fullscreen-only-controls-expected.txt
trunk/LayoutTests/media/video-fullscreen-only-controls.html
trunk/LayoutTests/media/video-fullscreen-only-playback-expected.txt
trunk/LayoutTests/media/video-fullscreen-only-playback.html
Removed Paths
trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt
trunk/LayoutTests/media/video-fullscreeen-only-controls.html
trunk/LayoutTests/media/video-fullscreeen-only-playback-expected.txt
trunk/LayoutTests/media/video-fullscreeen-only-playback.html
Diff
Modified: trunk/LayoutTests/ChangeLog (252675 => 252676)
--- trunk/LayoutTests/ChangeLog 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,5 +1,21 @@
2019-11-19 Peng Liu
+Typos in layout test names
+https://bugs.webkit.org/show_bug.cgi?id=204387
+
+Reviewed by Eric Carlson.
+
+* media/video-fullscreen-only-controls-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-controls-expected.txt.
+* media/video-fullscreen-only-controls.html: Renamed from LayoutTests/media/video-fullscreeen-only-controls.html.
+* media/video-fullscreen-only-playback-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-playback-expected.txt.
+* media/video-fullscreen-only-playback.html: Renamed from LayoutTests/media/video-fullscreeen-only-playback.html.
+* platform/gtk/TestExpectations:
+* platform/ios/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/win/TestExpectations:
+
+2019-11-19 Peng Liu
+
Assertion failure in HTMLMediaElement::enterFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=204376
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,13 +0,0 @@
-This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.
-
-
-RUN(internals.settings.setAllowsInlineMediaPlayback(false))
-EXPECTED (video.hasAttribute('controls') == 'false') OK
-EXPECTED (video.controls == 'false') OK
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-END OF TEST
-
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-controls.html (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-controls.html 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-controls.html 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,33 +0,0 @@
-
-
-This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.
-
-
-
-var shadowRoot;
-var panel;
-
-run("internals.settings.setAllowsInlineMediaPlayback(false)");
-
-var video = document.getElementById('video');
-video.src = "" "content/test");
-
-testExpected("video.hasAttribute('controls')", false);
-testExpected("video.controls", false);
-
-if (window.internals) {
-testExpected("shadowRoot = internals.shadowRoot(video)", null, "!=");
-testExpected("panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel')", null, "!=");
-testExpected("internals.shadowPseudoId(pa
[webkit-changes] [252677] trunk/Source/WebKit
Title: [252677] trunk/Source/WebKit
Revision 252677
Author cdu...@apple.com
Date 2019-11-19 19:08:07 -0800 (Tue, 19 Nov 2019)
Log Message
Unreviewed mac catalyst build fix after r252655.
* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in
Diff
Modified: trunk/Source/WebKit/ChangeLog (252676 => 252677)
--- trunk/Source/WebKit/ChangeLog 2019-11-20 02:43:37 UTC (rev 252676)
+++ trunk/Source/WebKit/ChangeLog 2019-11-20 03:08:07 UTC (rev 252677)
@@ -1,3 +1,9 @@
+2019-11-19 Chris Dumez
+
+Unreviewed mac catalyst build fix after r252655.
+
+* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in:
+
2019-11-19 Ross Kirsling
Unreviewed non-unified build fixes.
Modified: trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in (252676 => 252677)
--- trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in 2019-11-20 02:43:37 UTC (rev 252676)
+++ trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in 2019-11-20 03:08:07 UTC (rev 252677)
@@ -22,7 +22,7 @@
#if ENABLE(PLATFORM_DRIVEN_TEXT_CHECKING)
-messages -> TextCheckingControllerProxy {
+messages -> TextCheckingControllerProxy NotRefCounted {
ReplaceRelativeToSelection(struct WebKit::AttributedString annotatedString, int64_t selectionOffset, uint64_t length, uint64_t relativeReplacementLocation, uint64_t relativeReplacementLength)
RemoveAnnotationRelativeToSelection(String annotationName, int64_t selectionOffset, uint64_t length)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252678] trunk/Source/WebKit
Title: [252678] trunk/Source/WebKit
Revision 252678
Author cdu...@apple.com
Date 2019-11-19 19:14:29 -0800 (Tue, 19 Nov 2019)
Log Message
Unreviewed, fix webkitpy failures after r252655.
* Scripts/webkit/LegacyMessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):
* Scripts/webkit/MessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
* Scripts/webkit/MessageReceiverSuperclass-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/LegacyMessageReceiver-expected.cpp
trunk/Source/WebKit/Scripts/webkit/MessageReceiver-expected.cpp
trunk/Source/WebKit/Scripts/webkit/MessageReceiverSuperclass-expected.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (252677 => 252678)
--- trunk/Source/WebKit/ChangeLog 2019-11-20 03:08:07 UTC (rev 252677)
+++ trunk/Source/WebKit/ChangeLog 2019-11-20 03:14:29 UTC (rev 252678)
@@ -1,5 +1,19 @@
2019-11-19 Chris Dumez
+Unreviewed, fix webkitpy failures after r252655.
+
+* Scripts/webkit/LegacyMessageReceiver-expected.cpp:
+(WebKit::WebPage::didReceiveWebPageMessage):
+(WebKit::WebPage::didReceiveSyncWebPageMessage):
+* Scripts/webkit/MessageReceiver-expected.cpp:
+(WebKit::WebPage::didReceiveMessage):
+(WebKit::WebPage::didReceiveSyncMessage):
+* Scripts/webkit/MessageReceiverSuperclass-expected.cpp:
+(WebKit::WebPage::didReceiveMessage):
+(WebKit::WebPage::didReceiveSyncMessage):
+
+2019-11-19 Chris Dumez
+
Unreviewed mac catalyst build fix after r252655.
* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.messages.in:
Modified: trunk/Source/WebKit/Scripts/webkit/LegacyMessageReceiver-expected.cpp (252677 => 252678)
--- trunk/Source/WebKit/Scripts/webkit/LegacyMessageReceiver-expected.cpp 2019-11-20 03:08:07 UTC (rev 252677)
+++ trunk/Source/WebKit/Scripts/webkit/LegacyMessageReceiver-expected.cpp 2019-11-20 03:14:29 UTC (rev 252678)
@@ -78,6 +78,7 @@
void WebPage::didReceiveWebPageMessage(IPC::Connection& connection, IPC::Decoder& decoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::LoadURL::name()) {
IPC::handleMessage(decoder, this, &WebPage::loadURL);
return;
@@ -163,6 +164,7 @@
void WebPage::didReceiveSyncWebPageMessage(IPC::Connection& connection, IPC::Decoder& decoder, std::unique_ptr& replyEncoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::CreatePlugin::name()) {
IPC::handleMessage(decoder, *replyEncoder, this, &WebPage::createPlugin);
return;
Modified: trunk/Source/WebKit/Scripts/webkit/MessageReceiver-expected.cpp (252677 => 252678)
--- trunk/Source/WebKit/Scripts/webkit/MessageReceiver-expected.cpp 2019-11-20 03:08:07 UTC (rev 252677)
+++ trunk/Source/WebKit/Scripts/webkit/MessageReceiver-expected.cpp 2019-11-20 03:14:29 UTC (rev 252678)
@@ -78,6 +78,7 @@
void WebPage::didReceiveMessage(IPC::Connection& connection, IPC::Decoder& decoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::LoadURL::name()) {
IPC::handleMessage(decoder, this, &WebPage::loadURL);
return;
@@ -163,6 +164,7 @@
void WebPage::didReceiveSyncMessage(IPC::Connection& connection, IPC::Decoder& decoder, std::unique_ptr& replyEncoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::CreatePlugin::name()) {
IPC::handleMessage(decoder, *replyEncoder, this, &WebPage::createPlugin);
return;
Modified: trunk/Source/WebKit/Scripts/webkit/MessageReceiverSuperclass-expected.cpp (252677 => 252678)
--- trunk/Source/WebKit/Scripts/webkit/MessageReceiverSuperclass-expected.cpp 2019-11-20 03:08:07 UTC (rev 252677)
+++ trunk/Source/WebKit/Scripts/webkit/MessageReceiverSuperclass-expected.cpp 2019-11-20 03:14:29 UTC (rev 252678)
@@ -142,6 +142,7 @@
void WebPage::didReceiveMessage(IPC::Connection& connection, IPC::Decoder& decoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::LoadURL::name()) {
IPC::handleMessage(decoder, this, &WebPage::loadURL);
return;
@@ -169,6 +170,7 @@
void WebPage::didReceiveSyncMessage(IPC::Connection& connection, IPC::Decoder& decoder, std::unique_ptr& replyEncoder)
{
+auto protectedThis = makeRef(*this);
if (decoder.messageName() == Messages::WebPage::TestSyncMessage::name()) {
IPC::handleMessageSynchronous(connection, decoder, replyEncoder, this, &WebPage::testSyncMessage);
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/li
[webkit-changes] [252679] trunk
Title: [252679] trunk
Revision 252679
Author sbar...@apple.com
Date 2019-11-19 19:22:37 -0800 (Tue, 19 Nov 2019)
Log Message
Remove runNullishAwareOperatorsEnabled
Rubber-stamped by Keith Miller.
JSTests:
* stress/nullish-coalescing.js:
* stress/optional-chaining.js:
* stress/tail-call-recognize.js:
Tools:
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/nullish-coalescing.js
trunk/JSTests/stress/optional-chaining.js
trunk/JSTests/stress/tail-call-recognize.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/JSTests/ChangeLog (252678 => 252679)
--- trunk/JSTests/ChangeLog 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/JSTests/ChangeLog 2019-11-20 03:22:37 UTC (rev 252679)
@@ -1,3 +1,13 @@
+2019-11-19 Saam Barati
+
+Remove runNullishAwareOperatorsEnabled
+
+Rubber-stamped by Keith Miller.
+
+* stress/nullish-coalescing.js:
+* stress/optional-chaining.js:
+* stress/tail-call-recognize.js:
+
2019-11-18 Keith Miller
Enable Nullish operators by default
Modified: trunk/JSTests/stress/nullish-coalescing.js (252678 => 252679)
--- trunk/JSTests/stress/nullish-coalescing.js 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/JSTests/stress/nullish-coalescing.js 2019-11-20 03:22:37 UTC (rev 252679)
@@ -1,5 +1,3 @@
-//@ runNullishAwareOperatorsEnabled
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/optional-chaining.js (252678 => 252679)
--- trunk/JSTests/stress/optional-chaining.js 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/JSTests/stress/optional-chaining.js 2019-11-20 03:22:37 UTC (rev 252679)
@@ -1,5 +1,3 @@
-//@ runNullishAwareOperatorsEnabled
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error(`expected ${expected} but got ${actual}`);
Modified: trunk/JSTests/stress/tail-call-recognize.js (252678 => 252679)
--- trunk/JSTests/stress/tail-call-recognize.js 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/JSTests/stress/tail-call-recognize.js 2019-11-20 03:22:37 UTC (rev 252679)
@@ -1,5 +1,3 @@
-//@ runNullishAwareOperatorsEnabled
-
function callerMustBeRun() {
if (!Object.is(callerMustBeRun.caller, runTests))
throw new Error("Wrong caller, expected run but got ", callerMustBeRun.caller);
Modified: trunk/Tools/ChangeLog (252678 => 252679)
--- trunk/Tools/ChangeLog 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/Tools/ChangeLog 2019-11-20 03:22:37 UTC (rev 252679)
@@ -1,3 +1,11 @@
+2019-11-19 Saam Barati
+
+Remove runNullishAwareOperatorsEnabled
+
+Rubber-stamped by Keith Miller.
+
+* Scripts/run-jsc-stress-tests:
+
2019-11-19 Jonathan Bedard
results.webkit.org: Have build.webkit.org report JSC tests
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (252678 => 252679)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2019-11-20 03:14:29 UTC (rev 252678)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2019-11-20 03:22:37 UTC (rev 252679)
@@ -704,10 +704,6 @@
run("big-int-enabled", "--useBigInt=true" , *(FTL_OPTIONS + optionalTestSpecificOptions))
end
-def runNullishAwareOperatorsEnabled(*optionalTestSpecificOptions)
-run("nullish-aware-operators-enabled", "--useNullishAwareOperators=true" , *(FTL_OPTIONS + optionalTestSpecificOptions))
-end
-
def runFTLNoCJIT(*optionalTestSpecificOptions)
run("misc-ftl-no-cjit", *(FTL_OPTIONS + NO_CJIT_OPTIONS + optionalTestSpecificOptions))
end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252680] trunk
Title: [252680] trunk Revision 252680 Author rmoris...@apple.com Date 2019-11-19 19:41:57 -0800 (Tue, 19 Nov 2019) Log Message [ESNext][BigInt] Add support for op_inc https://bugs.webkit.org/show_bug.cgi?id=193240 Reviewed by Yusuke Suzuki. JSTests: Some parts of these tests are inspired by tests in a WIP patch by Caio Lima. Thanks to him for allowing their reuse. * stress/inc-osr-exit-from-big-int.js: Added. (let.assert.sameValue): (postInc): (preInc): (postDec): (preDec): * stress/inc-osr-exit-to-big-int.js: Added. (let.assert.sameValue): (postInc): (preInc): (postDec): (preDec): (o.valueOf): Source/_javascript_Core: This patch adds support for both ++ and -- on BigInts. It required the following secondary changes: - teaching FixupPhase how to replace it by ArithAdd/ArithSub/ValueAdd/ValueSub when the type is Int32/Double/BigInt - pulling ObservedResults out of UnaryArithProfile/BinaryArithProfile, so that it can be used by ArithAdd regardless of whether it comes from an Inc or from an Add - adding the constant 1n to the VM object so that it can be used by FixupPhase since it cannot allocate a new JSValue. - adding an UnaryArithProfile to op_inc and op_dec, and teaching the llint to update them. - adding ToNumeric (identity on bigints, same as toNumber on everything else) to all tiers * bytecode/ArithProfile.cpp: (JSC::ArithProfile::shouldEmitSetDouble const): (JSC::ArithProfile::emitSetDouble const): (JSC::ArithProfile::shouldEmitSetNonNumeric const): (JSC::ArithProfile::shouldEmitSetBigInt const): (JSC::ArithProfile::emitSetNonNumeric const): (JSC::ArithProfile::emitSetBigInt const): * bytecode/ArithProfile.h: (JSC::ObservedResults::ObservedResults): (JSC::ObservedResults::didObserveNonInt32): (JSC::ObservedResults::didObserveDouble): (JSC::ObservedResults::didObserveNonNegZeroDouble): (JSC::ObservedResults::didObserveNegZeroDouble): (JSC::ObservedResults::didObserveNonNumeric): (JSC::ObservedResults::didObserveBigInt): (JSC::ObservedResults::didObserveInt32Overflow): (JSC::ObservedResults::didObserveInt52Overflow): (JSC::ArithProfile::observedResults const): (JSC::ArithProfile::didObserveNonInt32 const): (JSC::ArithProfile::didObserveDouble const): (JSC::ArithProfile::didObserveNonNegZeroDouble const): (JSC::ArithProfile::didObserveNegZeroDouble const): (JSC::ArithProfile::didObserveNonNumeric const): (JSC::ArithProfile::didObserveBigInt const): (JSC::ArithProfile::didObserveInt32Overflow const): (JSC::ArithProfile::didObserveInt52Overflow const): (JSC::ArithProfile::setObservedNonNegZeroDouble): (JSC::ArithProfile::setObservedNegZeroDouble): (JSC::ArithProfile::setObservedNonNumeric): (JSC::ArithProfile::setObservedBigInt): (JSC::ArithProfile::setObservedInt32Overflow): (JSC::ArithProfile::setObservedInt52Overflow): (JSC::ArithProfile::observeResult): * bytecode/BytecodeList.rb: * bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeIndex): (JSC::computeDefsForBytecodeIndex): * bytecode/CodeBlock.cpp: (JSC::CodeBlock::unaryArithProfileForPC): * bytecode/ExitKind.h: * bytecode/SpeculatedType.h: (JSC::isInt32SpeculationForArithmetic): (JSC::isInt32OrBooleanSpeculationForArithmetic): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitUnaryOp): (JSC::BytecodeGenerator::emitToNumeric): * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp: (JSC::emitPostIncOrDec): * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGBackwardsPropagationPhase.cpp: (JSC::DFG::BackwardsPropagationPhase::propagate): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::makeSafe): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGCapabilities.cpp: (JSC::DFG::capabilityLevel): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixupToNumeric): * dfg/DFGMayExit.cpp: * dfg/DFGNode.h: (JSC::DFG::Node::hasHeapPrediction): * dfg/DFGNodeType.h: * dfg/DFGOperations.cpp: * dfg/DFGOperations.h: * dfg/DFGPredictionPropagationPhase.cpp: * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileIncOrDec): (JSC::DFG::SpeculativeJIT::compileToPrimitive): (JSC::DFG::SpeculativeJIT::compileToNumeric): * dfg/DFGSpeculativeJIT.h: * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileNode): (JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec): * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): * jit/JIT.h: * jit/JITMathIC.h: (JSC::JITMathIC::generateInline): * jit/JITMulGenerator.cpp: (JSC::JITMulGenerator::generateFastPath): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_
[webkit-changes] [252681] trunk
Title: [252681] trunk Revision 252681 Author you...@apple.com Date 2019-11-19 20:10:24 -0800 (Tue, 19 Nov 2019) Log Message getUserMedia echoCancellation constraint has no affect https://bugs.webkit.org/show_bug.cgi?id=179411 Reviewed by Eric Carlson. LayoutTests/imported/w3c: * web-platform-tests/mediacapture-streams/MediaDevices-getSupportedConstraints.https-expected.txt: Source/WebCore: Update implementation to properly report echoCancellation is supported and can take true or false. Update CoreAudioCaptureSource to initialize its state in constructor from the audio unit. This allows getUserMedia constraints to kick in after construction and update the source parameters. Audio unit parameters will then be set when the source will be asked to produce data. To enable testing, the mock audio is now adding a high frequency hum when echo cancellation is off. Covered by updated test. * Modules/mediastream/MediaStreamTrack.cpp: (WebCore::capabilityStringVector): (WebCore::capabilityBooleanVector): * platform/mediastream/RealtimeMediaSourceCenter.cpp: (WebCore::RealtimeMediaSourceCenter::RealtimeMediaSourceCenter): * platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp: * platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::initializeToStartProducingData): * platform/mediastream/mac/MockAudioSharedUnit.mm: (WebCore::MockAudioSharedUnit::reconfigure): * platform/mock/MockRealtimeAudioSource.cpp: (WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource): LayoutTests: * fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt: * fast/mediastream/MediaDevices-getSupportedConstraints.html: * fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt: * fast/mediastream/apply-constraints-audio-expected.txt: * fast/mediastream/apply-constraints-audio.html: * fast/mediastream/getUserMedia-webaudio-expected.txt: * fast/mediastream/getUserMedia-webaudio.html: * webrtc/routines.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt trunk/LayoutTests/fast/mediastream/apply-constraints-audio-expected.txt trunk/LayoutTests/fast/mediastream/apply-constraints-audio.html trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio-expected.txt trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getSupportedConstraints.https-expected.txt trunk/LayoutTests/webrtc/routines.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp trunk/Source/WebCore/platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.cpp trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm trunk/Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp Diff Modified: trunk/LayoutTests/ChangeLog (252680 => 252681) --- trunk/LayoutTests/ChangeLog 2019-11-20 03:41:57 UTC (rev 252680) +++ trunk/LayoutTests/ChangeLog 2019-11-20 04:10:24 UTC (rev 252681) @@ -1,3 +1,19 @@ +2019-11-19 Youenn Fablet + +getUserMedia echoCancellation constraint has no affect +https://bugs.webkit.org/show_bug.cgi?id=179411 + +Reviewed by Eric Carlson. + +* fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt: +* fast/mediastream/MediaDevices-getSupportedConstraints.html: +* fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt: +* fast/mediastream/apply-constraints-audio-expected.txt: +* fast/mediastream/apply-constraints-audio.html: +* fast/mediastream/getUserMedia-webaudio-expected.txt: +* fast/mediastream/getUserMedia-webaudio.html: +* webrtc/routines.js: + 2019-11-19 Peng Liu Typos in layout test names Modified: trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt (252680 => 252681) --- trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt 2019-11-20 03:41:57 UTC (rev 252680) +++ trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt 2019-11-20 04:10:24 UTC (rev 252681) @@ -10,7 +10,7 @@ PASS supportedConstraints.aspectRatio is true PASS supportedConstraints.deviceId is true -PASS supportedConstraints.echoCancellation is false +PASS supportedConstraints.echoCancellation is true PASS supportedConstraints.facingMode is true PASS supportedConstraints.frameRate is true PASS supportedConstraints.groupId is false Modified: trunk/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html (252680 =>
[webkit-changes] [252682] trunk
Title: [252682] trunk
Revision 252682
Author drou...@apple.com
Date 2019-11-19 20:31:20 -0800 (Tue, 19 Nov 2019)
Log Message
Web Inspector: DOM.highlightSelector should work for "div, div::before"
https://bugs.webkit.org/show_bug.cgi?id=204306
Reviewed by Brian Burg.
.:
* ManualTests/inspector/overlay-selectors.html: Added.
Source/WebCore:
In r252436, the implementation of `DOM.highlightSelector` was changed from just calling
`document.querySelectorAll` to actually attempting to mimic what the CSS selector matching
engine does. Basically, this meant adding logic to walk the entire DOM tree and for each
node test each `CSSSelector` of the given `selector` string to see if it matched.
At the time, I had incorrectly assumed that once a selector was found that matched the
current node, it wouldn't need to be checked against ever again. This would be a fine
assumption if we didn't care about `:before`/`:after`, but since `DOM.highlightSelector`
also wants to match those, it is necessary to test every `CSSSelector` in case a later one
in the given `selector` string matches a pseudo-element (e.g. `div, div:before`).
The fix is simply to change `break` to `continue` and to ensure that every item in the
generated `NodeList` is unique (otherwise the overlay for a node may be drawn twice).
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightSelector):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
Added Paths
trunk/ManualTests/inspector/overlay-selectors.html
Diff
Modified: trunk/ChangeLog (252681 => 252682)
--- trunk/ChangeLog 2019-11-20 04:10:24 UTC (rev 252681)
+++ trunk/ChangeLog 2019-11-20 04:31:20 UTC (rev 252682)
@@ -1,3 +1,12 @@
+2019-11-19 Devin Rousso
+
+Web Inspector: DOM.highlightSelector should work for "div, div::before"
+https://bugs.webkit.org/show_bug.cgi?id=204306
+
+Reviewed by Brian Burg.
+
+* ManualTests/inspector/overlay-selectors.html: Added.
+
2019-11-12 Carlos Alberto Lopez Perez
[GTK][WPE] Support Pointer Events
Added: trunk/ManualTests/inspector/overlay-selectors.html (0 => 252682)
--- trunk/ManualTests/inspector/overlay-selectors.html (rev 0)
+++ trunk/ManualTests/inspector/overlay-selectors.html 2019-11-20 04:31:20 UTC (rev 252682)
@@ -0,0 +1,44 @@
+
+p {
+position: fixed;
+right: 20px;
+bottom: 20px;
+margin: 0;
+}
+
+.expected {
+position: absolute;
+width: 300px;
+height: 100px;
+background-image: linear-gradient(to right, rgba(111, 168, 220, 0.66) 33.3%, transparent 33.3%, transparent 66.6%, rgba(111, 168, 220, 0.66) 66.6%);
+}
+.actual, .actual::before {
+display: inline-block;
+width: 100px;
+height: 100px;
+}
+.actual {
+position: relative;
+}
+.actual::before {
+position: absolute;
+left: 200px;
+content: "";
+}
+
+
+
+
+
+
+
+Inspect this page and hover the `.actual, .actual::before` CSS selector in the Styles panel of the details sidebar in the Elements tab. Click Show Expected to compare with the expected result.
+
+let showingExpected = false;
+document.querySelector("button").addEventListener("click", (event) => {
+showingExpected = !showingExpected;
+for (let node of document.querySelectorAll(".expected"))
+node.hidden = !showingExpected;
+});
+
+
Modified: trunk/Source/WebCore/ChangeLog (252681 => 252682)
--- trunk/Source/WebCore/ChangeLog 2019-11-20 04:10:24 UTC (rev 252681)
+++ trunk/Source/WebCore/ChangeLog 2019-11-20 04:31:20 UTC (rev 252682)
@@ -1,3 +1,27 @@
+2019-11-19 Devin Rousso
+
+Web Inspector: DOM.highlightSelector should work for "div, div::before"
+https://bugs.webkit.org/show_bug.cgi?id=204306
+
+Reviewed by Brian Burg.
+
+In r252436, the implementation of `DOM.highlightSelector` was changed from just calling
+`document.querySelectorAll` to actually attempting to mimic what the CSS selector matching
+engine does. Basically, this meant adding logic to walk the entire DOM tree and for each
+node test each `CSSSelector` of the given `selector` string to see if it matched.
+
+At the time, I had incorrectly assumed that once a selector was found that matched the
+current node, it wouldn't need to be checked against ever again. This would be a fine
+assumption if we didn't care about `:before`/`:after`, but since `DOM.highlightSelector`
+also wants to match those, it is necessary to test every `CSSSelector` in case a later one
+in the given `selector` string matches a pseudo-element (e.g. `div, div:before`).
+
+The fix is simply to change `break` to `continue` and to ensure that every item in the
+generated `NodeList` is unique (otherwise the overlay for a node may be drawn twice).
+
+* inspector/agents/InspectorDOMAgent.cpp:
[webkit-changes] [252683] trunk
Title: [252683] trunk
Revision 252683
Author ross.kirsl...@sony.com
Date 2019-11-19 21:12:14 -0800 (Tue, 19 Nov 2019)
Log Message
Implement String.prototype.replaceAll
https://bugs.webkit.org/show_bug.cgi?id=202471
Reviewed by Yusuke Suzuki.
JSTests:
* stress/string-replaceall.js: Added.
Source/_javascript_Core:
Implement the stage 3 proposal here:
https://github.com/tc39/proposal-string-replaceall
String.prototype.replaceAll is the same as String.prototype.replace, except:
1. When the first argument is a string, all instances of the search string are replaced.
2. When the first argument is a non-global regular _expression_, a TypeError is thrown.
* builtins/BuiltinNames.h:
* builtins/StringPrototype.js:
(replaceAll): Added.
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
(JSC::jsSpliceSubstringsWithSeparators): Add early out for single-replacement case.
(JSC::replaceUsingStringSearch): Add global replacement logic, following replaceUsingRegExpSearch.
(JSC::replace):
(JSC::stringProtoFuncReplaceUsingStringSearch):
(JSC::stringProtoFuncReplaceAllUsingStringSearch): Added.
Source/WTF:
* wtf/text/StringCommon.h:
(WTF::findCommon):
Fix logic: "start > length" early out should come before "empty search string" early out.
LayoutTests:
* js/Object-getOwnPropertyNames-expected.txt:
* js/script-tests/Object-getOwnPropertyNames.js:
Grrr, why is this a layout test...
Modified Paths
trunk/JSTests/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt
trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/BuiltinNames.h
trunk/Source/_javascript_Core/builtins/StringPrototype.js
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringCommon.h
Added Paths
trunk/JSTests/stress/string-replaceall.js
Diff
Modified: trunk/JSTests/ChangeLog (252682 => 252683)
--- trunk/JSTests/ChangeLog 2019-11-20 04:31:20 UTC (rev 252682)
+++ trunk/JSTests/ChangeLog 2019-11-20 05:12:14 UTC (rev 252683)
@@ -1,3 +1,12 @@
+2019-11-19 Ross Kirsling
+
+Implement String.prototype.replaceAll
+https://bugs.webkit.org/show_bug.cgi?id=202471
+
+Reviewed by Yusuke Suzuki.
+
+* stress/string-replaceall.js: Added.
+
2019-11-19 Robin Morisset
[ESNext][BigInt] Add support for op_inc
Added: trunk/JSTests/stress/string-replaceall.js (0 => 252683)
--- trunk/JSTests/stress/string-replaceall.js (rev 0)
+++ trunk/JSTests/stress/string-replaceall.js 2019-11-20 05:12:14 UTC (rev 252683)
@@ -0,0 +1,36 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`expected ${expected} but got ${actual}`);
+}
+
+function shouldThrowTypeError(func) {
+let error;
+try {
+func();
+} catch (e) {
+error = e;
+}
+
+if (!(error instanceof TypeError))
+throw new Error('Expected TypeError!');
+}
+
+shouldThrowTypeError(() => { String.prototype.replaceAll.call(undefined, 'def', 'xyz'); });
+shouldThrowTypeError(() => { String.prototype.replaceAll.call(null, 'def', 'xyz'); });
+
+shouldThrowTypeError(() => { 'abcdefabcdefabc'.replaceAll(/def/, 'xyz'); });
+shouldThrowTypeError(() => { 'abcdefabcdefabc'.replaceAll(new RegExp('def'), 'xyz'); });
+shouldThrowTypeError(() => { 'abcdefabcdefabc'.replaceAll({ [Symbol.match]() {}, toString: () => 'def' }, 'xyz'); });
+
+shouldBe('abcdefabcdefabc'.replaceAll('def', 'xyz'), 'abcxyzabcxyzabc');
+shouldBe('abcdefabcdefabc'.replaceAll(/def/g, 'xyz'), 'abcxyzabcxyzabc');
+shouldBe('abcdefabcdefabc'.replaceAll(new RegExp('def', 'g'), 'xyz'), 'abcxyzabcxyzabc');
+shouldBe('abcdefabcdefabc'.replaceAll({ [Symbol.match]() {}, toString: () => 'def', flags: 'g' }, 'xyz'), 'abcxyzabcxyzabc');
+
+const search = /def/g;
+search[Symbol.replace] = undefined;
+shouldBe('abcdefabcdefabc'.replaceAll(search, 'xyz'), 'abcdefabcdefabc');
+search[Symbol.replace] = () => 'q';
+shouldBe('abcdefabcdefabc'.replaceAll(search, 'xyz'), 'q');
+search[Symbol.replace] = RegExp.prototype[Symbol.replace].bind(search);
+shouldBe('abcdefabcdefabc'.replaceAll(search, 'xyz'), 'abcxyzabcxyzabc');
Modified: trunk/LayoutTests/ChangeLog (252682 => 252683)
--- trunk/LayoutTests/ChangeLog 2019-11-20 04:31:20 UTC (rev 252682)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 05:12:14 UTC (rev 252683)
@@ -1,3 +1,14 @@
+2019-11-19 Ross Kirsling
+
+Implement String.prototype.replaceAll
+https://bugs.webkit.org/show_bug.cgi?id=202471
+
+Reviewed by Yusuke Suzuki.
+
+* js/Object-getOwnPropertyNames-expected.txt:
+* js/script-tests/Object-getOwnPropertyNames.js:
+Grrr, why is this a layout test...
+
2019-11-19 Youenn Fablet
getUserMedia echoCancellation constraint has no affect
Modified: trunk/LayoutTests/js/Object-getOwnPropertyN
[webkit-changes] [252685] trunk/LayoutTests
Title: [252685] trunk/LayoutTests Revision 252685 Author simon.fra...@apple.com Date 2019-11-19 23:23:17 -0800 (Tue, 19 Nov 2019) Log Message Remove macOS Sierra results in LayoutTests/platform https://bugs.webkit.org/show_bug.cgi?id=204388 Reviewed by Eric Carlson. * platform/mac-sierra-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt: Removed. * platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Removed. * platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Removed. * platform/mac-sierra-wk1/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed. * platform/mac-sierra-wk2/fast/dom/HTMLLinkElement/preconnect-support-expected.txt: Removed. * platform/mac-sierra-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Removed. * platform/mac-sierra/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: Removed. * platform/mac-sierra/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt: Removed. * platform/mac-sierra/css1/basic/inheritance-expected.png: Removed. * platform/mac-sierra/css1/basic/inheritance-expected.txt: Removed. * platform/mac-sierra/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Removed. * platform/mac-sierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Removed. * platform/mac-sierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-18-expected.png: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-18-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-19b-expected.png: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-19b-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-23-expected.png: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-23-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-69-expected.png: Removed. * platform/mac-sierra/css3/selectors3/html/css3-modsel-69-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-18-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-18-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-19b-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-23-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-23-expected.txt: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-69-expected.png: Removed. * platform/mac-sierra/css3/selectors3/xml/css3-modsel-69-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-1-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-2-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-3-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-4-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-5-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-6-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-7-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-8-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-9-expected.txt: Removed. * platform/mac-sierra/editing/deleting/delete-emoji-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/anchor-element-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/attrib-string-colors-with-color-filter-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/attrib-string-range-with-color-filter-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/attribute-string-for-copy-with-color-filter-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Removed. * platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Removed. * platform/mac
