Hi,
Please review the following fix in JDK9 at your convenience :
Bug : https://bugs.openjdk.java.net/browse/JDK-8160736
Webrev : http://cr.openjdk.java.net/~jdv/8160736/webrev.00/
Root Cause : KSS tool has detected usage of class.forName where it can be
avoided.
Solution : Use
Hi Phil,
Thanks for your review.
I have run all jtreg tests under imageio and there are no side effects.
Thanks,
Jay
From: Philip Race
Sent: Monday, August 01, 2016 7:22 PM
To: Jayathirth D V
Cc: Jim Graham; Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev
Hi,
Please review the following fix in JDK9 at your convenience:
Bug : https://bugs.openjdk.java.net/browse/JDK-8160943
Webrev : http://cr.openjdk.java.net/~jdv/8160943/webrev.00/
Root cause : While fixing JDK-8152672 we considered that there can be no data
in Jpeg image which can
~jdv/8153943/webrev.04/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Thursday, June 30, 2016 4:22 AM
To: Phil Race
Cc: Jayathirth D V; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In
PixelInterLeavedSampleModel and BandedSampleModel we
Hi Prasanta,
Changes are looking fine.
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Monday, July 25, 2016 3:28 PM
To: Philip Race; 2d-dev
Subject: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes
disabling jar caches
Hi All,
Please review a fix for jdk9 where
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8161902
Webrev : http://cr.openjdk.java.net/~jdv/8161902/webrev.00/
Root cause : Invalid class name used while constructing the object.
Solution : Use proper class-name for constructor(In
Hi Jim,
I just ran the test case attached in
https://bugs.openjdk.java.net/browse/JDK-4958271 .
It is actually generating an image and using it to do reader.readAll().
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Thursday, July 21, 2016 2:22 PM
To: Jayathirth D V; Philip Race
Hi Prasanta,
You have many lines of commented code in test case, which is not needed.
Also there are cases of null pointer dereferencing at line 68 & 70 in test
case. Please add checks for the same.
And you can add bug evaluation in JBS for the same.
Thanks,
Jay
From: Philip Race
http://cr.openjdk.java.net/~jdv/8160943/webrev.00/ and
open up the test case(after verifying whether it is the only test case which
uses this particular image) with new image that I have created.
Thanks,
Jay
-Original Message-
From: Philip Race
Sent: Wednesday, July 13, 2016 10:06 AM
T
Hi Prasanta,
Changes are working fine.
Thanks,
Jay
-Original Message-
From: Prasanta Sadhukhan
Sent: Thursday, July 14, 2016 10:34 AM
To: Philip Race
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-5080830: SheetCollate is not handled
properly by the cross platform print dlg
Hi Prasanta,
Please find updated webrev for reference :
http://cr.openjdk.java.net/~jdv/7059970/webrev.04/
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Wednesday, July 13, 2016 5:16 PM
To: Jayathirth D V
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case
To: Jayathirth D V
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7059970 : Test case:
javax/imageio/plugins/png/ITXtTest.java is not closing a file
Hi Jay,
Why do we need to catch and throw RuntimeExcpn?
try {
} catch (RuntimeException e) {
throw e;
}
Can't we just do
try
rom
ProblemList.txt as part of fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8160943
Please find webrev for review for JDK9:
http://cr.openjdk.java.net/~jdv/8160943/webrev.00/
Thanks,
Jay
From: Phil Race
Sent: Saturday, July 09, 2016 12:37 AM
To: Jayathirth D V
Cc: Jim Graham
Hi Prasanta,
Since CUPS is not used in Windows, your change will not make difference if I
run the test in Windows.
Please add @requires tag in jtreg test case and there are some lines which are
80 character plus.
Also please add null check when you create PrinterService in test case.
Hi,
Please review the following fix in JDK9 :
Bug : https://bugs.openjdk.java.net/browse/JDK-7059970
Webrev : http://cr.openjdk.java.net/~jdv/7059970/webrev.00/
Root cause : Test case ITXtTest.java is not deleting the file it is
creating(test.png). Also it is not closing
Hi Prasanta,
Changes are working fine.
Thanks,
Jay
From: Phil Race
Sent: Friday, July 01, 2016 11:55 PM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6789262: getPageFormat doesn't apply
PrintRequestAttributeSet specified
+1 ... although I am a
Hi Prasanta,
Changes are fine.
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Thursday, June 30, 2016 3:19 PM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing to file does not
throw a PrinterException if the file
Hi Prasanta,
Forgot to mention.
Please add evaluation in Bug and change fix version to 9 as we know it will
cause problems while pushing the changes to repo.
Thanks,
Jay
From: Jayathirth D V
Sent: Thursday, June 30, 2016 3:09 PM
To: Prasanta Sadhukhan; Philip Race
Cc: 2d-dev
ror()) {
abortDoc();
throw new PrinterException("Error while writing to file");
}
Thanks,
Jay
From: Prasanta Sadhukhan
Sent: Thursday, June 30, 2016 10:35 AM
To: Philip Race; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6218397:Printing
-Original Message-
From: Jim Graham
Sent: Saturday, June 04, 2016 4:52 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel
subclasses are missing hashCode() or equals() or both methods
That looks good to me. Has
Hi Brian,
Thanks for your inputs.
I have updated the new bug https://bugs.openjdk.java.net/browse/JDK-8160327
with same comment.
Thanks,
Jay
From: Brian Burkhalter
Sent: Tuesday, June 28, 2016 12:41 AM
To: Philip Race
Cc: Jayathirth D V; 2d-dev@openjdk.java.net
Subject: Re
ollow EXIF/APP1 data and I understand they may use
multiple APP2s because the marker segment has a size limit of 64K
(the size is a two byte quantity). So we can ignore this.
-phil.
On 6/23/16, 5:10 AM, Jayathirth D V wrote:
Hi Phil,
We have two images with which we can reproduce the issue:
1
also have a
>> meaningless override of super.equals/hashCode().
>>
>> And all of these classes suffer from casting to the specific type
>> before verifying its class as I mentioned in the ICM.equals() review...
>>
>> ...jim
>>
>> On 4/25
Hi Prasanta,
Changes are working fine.
Please convert multiple single line comments to multi-line comments both in
code change in test case. In test case there are some places where lines are
ending with more than 80 characters.
No need for review. Please change it before check-in.
Hi Phil,
Gentle reminder for review.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, June 15, 2016 10:01 AM
To: Jayathirth D V; Phil Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while
getting second image
Hi Phil,
Gentle remainder for review.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, June 15, 2016 10:01 AM
To: Jayathirth D V; Phil Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while
getting second image
Hi Prasanta,
Changes are fine.
Thanks,
Jay
From: prasanta sadhukhan
Sent: Friday, June 17, 2016 3:37 PM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on
Lexmark E352dn PS3 with "1200 IQ" setting
Hi Prasanta,
One more thing I missed, there are many unneeded imports in test case. Please
remove them also.
Thanks,
Jay
From: Jayathirth D V
Sent: Friday, June 17, 2016 2:45 PM
To: Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350
Hi Prasanta,
I tried to run the test but it looks like you are not creating object for
proper class in test case :
88 pj.setPrintable(new PrintableDemo(), pf);
I think it should be test class name :
88 pj.setPrintable(new PrintTestLexmarkIQ(), pf);
After we
Hi Jim,
Thanks for the review. I have updated the webrev for reference:
http://cr.openjdk.java.net/~jdv/6386906/webrev.02/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, June 15, 2016 4:15 AM
To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race
Subject: Re
Hi Jim,
Thanks for your review. I have updated the changes mentioned by you.
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/6386906/webrev.01/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Tuesday, June 14, 2016 12:34 AM
To: Jayathirth D V; 2d-dev
ted webrev for review:
http://cr.openjdk.java.net/~jdv/8152672/webrev.01/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Saturday, June 11, 2016 3:07 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Excep
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-6386906
Webrev : http://cr.openjdk.java.net/~jdv/6386906/webrev.00/
Issue : We are dividing an integer with another integer and trying to perform
ceil() on resultant value which will be
ion can contain data which will be similar
to EOI,SOI or other markers(FF XX).
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Friday, June 10, 2016 5:28 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exce
,
Jay
-Original Message-
From: Jim Graham
Sent: Thursday, June 02, 2016 2:08 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-8152672 : Exception getting thumbnail size
for JPEG with embedded thumbnail
I'm a little disturbed that we are just
/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Friday, June 03, 2016 2:25 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing
hashCode() or equals() or both methods
I just noticed a hashCode
Sent: Wednesday, June 01, 2016 10:06 PM
To: Jayathirth D V
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing
hashCode() or equals() or both methods
Please post the updated webrev.
-phil.
On 6/1/16, 12:02 AM, Jayathirth D V wrote
Fixed typo.
From: Jayathirth D V
Sent: Thursday, June 02, 2016 5:08 PM
To: Philip Race
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: RE: Review Request for JDK-8152672 : Exception while getting second
image properties for JPEG with embedded thumbnail
Hi Phil,
We have two kind
getting inside APP1 and APP2 markers also.
Thanks,
Jay
From: Phil Race
Sent: Thursday, June 02, 2016 4:05 AM
To: Jayathirth D V
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-8152672 : Exception while getting second
image properties for JPEG with embedded thumb
Updated bug title in JBS as it was misleading.
From: Jayathirth D V
Sent: Wednesday, June 01, 2016 12:48 PM
To: Philip Race; Jim Graham
Cc: 2d-dev@openjdk.java.net
Subject: Review Request for JDK-8152672 : Exception getting thumbnail size for
JPEG with embedded thumbnail
Hi,
Please
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8152672
Webrev : http://cr.openjdk.java.net/~jdv/8152672/webrev.00/
Issue : When we are trying to get properties related to second image in JPEG
file we are getting IIOException
Hi Prasanta,
Changes are fine.
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Monday, May 30, 2016 11:20 PM
To: prasanta sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not
compilable:
Hi Jim,
Thanks for your valuable inputs. I have made recommended changes.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/7107905/webrev.08/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Friday, May 27, 2016 11:52 PM
To: Jayathirth D V; Philip Race
Cc
iday, May 27, 2016 2:18 PM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing
hashCode() or equals() or both methods
Hi Jay,
.equals() should not be comparing any fields that are computed from other
fi
Hi,
Gentle reminder.
Please review updated fix:
http://cr.openjdk.java.net/~jdv/7107905/webrev.07/
Thanks,
Jay
-Original Message-
From: Jayathirth D V
Sent: Thursday, May 19, 2016 6:43 PM
To: Philip Race; Jim Graham
Cc: 2d-dev@openjdk.java.net
Subject: Review Request for JDK-7107905
Hi Prasanta,
Verified the changes and even in case of -ve width/height now we are using
hardware margins and not java defined 1 inch margin. +1.
Thanks,
Jay
-Original Message-
From: prasanta sadhukhan
Sent: Thursday, May 19, 2016 3:30 PM
To: Phil Race; 2d-dev@openjdk.java.net
Subject:
Hi,
Previously for this bug we were making changes related only to IndexColorModel.
Since we are expanding to include hashCode() or equals() method from
PackedColorModel and ComponentColorModel, I have created single webrev for
review under the same bug id.
Now the "getclass()==" check is
Hi Prasanta,
Changes are working fine. +1.
Thanks,
Jay
-Original Message-
From: Phil Race
Sent: Thursday, May 19, 2016 3:53 AM
To: prasanta sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6509729:
javax.print.ServiceUI.printDialog Border/Margin Evaluation
Thanks Phil and Jim for your review.
-Original Message-
From: Philip Race
Sent: Friday, May 06, 2016 4:17 AM
To: Jayathirth D V
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel
colour when converting images
e Java like the other methods here.
>>
>> PixelInterleavedSampleModel and BandedSampleModel also have a
>> meaningless override of super.equals/hashCode().
>>
>> And all of these classes suffer from casting to the specific type
>> before verifying its cl
Hi Jim,
I am trying to modify/add equals()/hashCode() methods in
java.awt.image.ComponentSampleModel() and its subclasses.
In BandedSampleModel and PixelInterleavedSampleModel I see that we have just
hashCode() functions and not equals() and these hashCode() function are
returning just
Hi,
Gentle reminder. Please review.
Thanks,
Jay
-Original Message-
From: Jayathirth D V
Sent: Monday, May 02, 2016 4:05 PM
To: Jim Graham; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel
colour when converting
Hi Prahalad,
Changes are working fine.+1.
In test case please make jtreg comments as multiline comments and move them
below copyright and above import statements for readability before pushing.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Tuesday, May 03, 2016 1:42 AM
To:
of white color in JDK-7116979. I think
we can check-in present changes and work on new bug. Please let me know your
inputs.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Monday, May 02, 2016 3:46 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK
toring RGB colors
in color-map as it can vary if user provides custom color-map. This looks like
completely different issue of not extracting proper value for white color.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Saturday, April 30, 2016 4:43 AM
To: Jayathirth D V; Philip R
ely and
> then rewrite the whole tail end of the loop body from 291 to the end
> of the loop as:
>
> if (i == 0) {
> if (r > delta) return false;
> } else {
> if (r < 255-delta) return false;
> }
> // 2 more similar tests for j/g and k/b
>
> Then &quo
-Original Message-
From: Jim Graham
Sent: Saturday, April 23, 2016 7:30 AM
To: Phil Race; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In
java.awt.image package some of the classes are missing hashCode() or equals()
method
relevant changes in its subclasses and sent review
in its thread.
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Thursday, April 14, 2016 2:57 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method
anks,
Jay
From: Phil Race
Sent: Wednesday, April 20, 2016 10:48 PM
To: Jayathirth D V
Cc: Jim Graham; Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In
java.awt.image package some of the classes are missing hashCode() or equals()
me
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8153943
This is subtask of https://bugs.openjdk.java.net/browse/JDK-6588409
Webrev : http://cr.openjdk.java.net/~jdv/8153943/webrev.00/
Issue : Some of the java.awt.image classes are
Message-
From: Jim Graham
Sent: Saturday, February 20, 2016 3:02 AM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel
colour when converting images to TYPE_BYTE_INDEXED
Hi Jayathirth
Looks good.
-Original Message-
From: prasanta sadhukhan
Sent: Tuesday, April 19, 2016 12:57 PM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6197099 : PrinterJob.getUserName()
throws a security exception when user.name permission
Hi Prasanta,
In test case there is an indentation problem for multiline comments in jtreg.
Also what I have observed is that in case of jtreg summary if we include "."
after running jtreg in the report it will not show complete summary it will
show only until the "."
In your case it will show
Looks fine.
From: prasanta sadhukhan
Sent: Friday, April 15, 2016 11:18 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and
the printer job name is not passed to the implementing
Thanks Jay.
Please
Hi Prasanta,
Changes are fine.
Please add your analysis in JBS. Some lines in test case has more than 80
characters, please update them before pushing.
I have updated the OS and CPU as generic for new bug
https://bugs.openjdk.java.net/browse/JDK-8154218 since we know it is common
problem among
Hi Prasanta,
Changes are working fine.
Jtreg comment in test case is not properly indented and add '*' for each
multiline as per coding guidelines before pushing the change.
Also summary of test case should mention about what is test doing, instead of
the problem statement.
Thanks,
Jay
Hi Prasanta,
Change is working fine, +1.
Additional comments : Please add your analysis in JBS and also remove/update
the present Javadoc comment in test case and add Override annotation for
subclasses present in test case.
Thanks,
Jay
From: prasanta sadhukhan
Sent: Thursday,
inal Message-
From: Phil Race
Sent: Wednesday, April 13, 2016 1:49 AM
To: Jim Graham
Cc: Jayathirth D V; Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel
doesnt exist and it relies on ColorModel.equals() which is not st
To: Jayathirth D V; Philip Race; Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel
doesnt exist and it relies on ColorModel.equals() which is not strict
Hi Jay,
There was one thing I pointed out in the first review that got
Sure Sergey after technical review is done I will raise CCC for the same.
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Friday, April 08, 2016 12:42 AM
To: Jim Graham; Jayathirth D V; Philip Race; Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev
Graham
Sent: Friday, April 08, 2016 12:28 AM
To: Jayathirth D V; Philip Race; Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel
doesnt exist and it relies on ColorModel.equals() which is not strict
Hi Jayathirth
tructed ICM instances are equals() == true, tested with one of each of the
constructors...
- I have made changes to test case for verifying all constructors with
same ICM. Also added verification for hashCode value.
...jim
On 4/6/2016 4:47 AM, Jayathirth D V wrote:
Hi Sergey,
It will be pushed after removing the redundant code.
Please find the webrev:
http://cr.openjdk.java.net/~jdv/8044289/webrev.07/
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, April 05, 2016 8:05 PM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject
ril 05, 2016 2:59 AM
To: Jayathirth D V
Cc: Prasanta Sadhukhan; 2d-dev
Subject: Re: Review Request for JDK-8153363: Redundant check for number of
components in PackedColorModel.equals() method
This looks fine although I am unable to work out how a JCK test
detected the duplication
-phil.
On
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8153363
Webrev : http://cr.openjdk.java.net/~jdv/8153363/webrev.00/
Issue : We have redundant check for equality of number of components in
PackedColorModel.
Solution : Number of
Hi Prasanta,
Changes are fine and test case looks good. Please make proper indentation for
jtreg comments before checkin.
Thanks,
Jay
-Original Message-
From: Phil Race
Sent: Friday, April 01, 2016 10:47 PM
To: prasanta sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9]: RFR
sadhukhan
Sent: Wednesday, March 30, 2016 12:34 PM
To: Phil Race; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [9] RFR JDK-8042713,,[macosx] Print dialog does not update
attribute set with page range
Hi Phil,
Yes, the combination of this fix plus 8061258 works with both the testcase I
. As we discussed it looks like only PageRanges is not working.
You can update the bug regarding the same with Fix version as 9.
Thanks,
Jay
From: prasanta sadhukhan
Sent: Wednesday, March 30, 2016 12:18 PM
To: Phil Race; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [9] RFR: JDK
om: Sergey Bylokhov
Sent: Tuesday, March 29, 2016 6:11 PM
To: Philip Race; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() and write() NPE is not handled properly for stream
I am not sure what is the reason of this
, March 29, 2016 10:38 PM
To: Jayathirth D V
Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() and write() NPE is not handled properly for stream
This is OK but you ought to remember that read() and write() only HAPPEN
/webrev.05/
Thanks,
Jay
From: prasanta sadhukhan
Sent: Tuesday, March 29, 2016 2:21 PM
To: Jayathirth D V
Cc: Philip Race; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() and write() NPE is not handled properly for stream
+1
h 24, 2016 5:10 AM
To: Jayathirth D V
Cc: Sergey Bylokhov; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() and write() NPE is not handled properly for stream
I don't think this is ready and we need to discuss whether to rework it.
In general I
Thanks for the review Sergey.
Can I get +1 for this please?
-Jay
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, March 22, 2016 9:52 PM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read
for review:
http://cr.openjdk.java.net/~jdv/8044289/webrev.03/
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Tuesday, March 22, 2016 7:39 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read
Hi Sergey,
For the second approach I have created webrev for review.
Please review updated webrev :
http://cr.openjdk.java.net/~jdv/8044289/webrev.02/
Thanks,
Jay
-Original Message-
From: Jayathirth D V
Sent: Friday, March 18, 2016 2:23 PM
To: Sergey Bylokhov
Cc: 2d-dev
will indicate that
we are not able to create required stream.
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, March 17, 2016 7:27 PM
To: Phil Race
Cc: Jayathirth D V; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: Review Request for JDK-8044289 : In ImageIO.read() and write() NPE
is not handled properly for stream
The test writes out into "test.src".
I believe that you should treat that as a "read-only" location.
gey Bylokhov
Sent: Friday, March 18, 2016 12:24 AM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net; Philip Race
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In
ImageIO.read() and write() NPE is not handled properly for stream
On 17.03.16 21:14, Jayathirth D V wrote:
>
Change is fine. Looks like this is the only place in ImageTypeSpecifier where
we are not using short-circuit logical "or".
-Original Message-
From: prasanta sadhukhan
Sent: Tuesday, March 15, 2016 5:36 PM
To: Sergey Bylokhov; Jayathirth D V; 2d-dev@openjdk.java.net
Subject: [9
Looks good to go.
Thanks,
Jay
From: prasanta sadhukhan
Sent: Wednesday, March 16, 2016 2:17 PM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from
PrintJob.getGraphics() running
closed/java/awt/PrintJob/HighResTest
HI Prasanta,
Changes are fine. Both the print dialogs are coming and there is no NPE.
In test case please change copyright year to 2016 and also it is better to have
jtreg comments before import statements for readability.
Thanks,
Jay
From: Phil Race
Sent: Wednesday, March 16,
Changes are fine.
-Original Message-
From: Yuri Nesterenko
Sent: Friday, March 11, 2016 5:26 PM
To: prasanta sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8151621, , [TEST_BUG]
java/awt/print/PrinterJob/MultiMonPrintDlgTest.java doesn't work with jtreg
, 2016 2:38 AM
To: prasanta sadhukhan; Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses
background's alpha channel
Yes, that is the only issue I see now as well...
...jim
On 3/9/16 10:39 PM, prasanta
Jim thanks for the review.
Prasanta I have updated the webrev to address indentation issues. Please review:
http://cr.openjdk.java.net/~jdv/8139183/webrev.06/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Thursday, March 10, 2016 5:28 AM
To: Jayathirth D V
Cc: 2d-dev
Hi Jim,
I have made changes mentioned by you.
Please find updated webrev:
http://cr.openjdk.java.net/~jdv/8139183/webrev.05/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Wednesday, March 09, 2016 3:23 AM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D
) Removed setColor() with transparent color for AlphaComposite.Clear as it is
not needed.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/8139183/webrev.04/
Thanks,
Jay
-Original Message-
From: Jim Graham
Sent: Tuesday, March 08, 2016 6:00 AM
To: Jayathirth D V
Cc: 2d
Fix looks fine. Please add relevant noreg label in bug before resolving it,
since there is no test case.
Thanks,
Jay
-Original Message-
From: Phil Race
Sent: Saturday, March 05, 2016 1:00 AM
To: prasanta sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9]: RFR
To: Jayathirth D V; Sergey Bylokhov
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses
background's alpha channel
Hi Jay,
The new code looks good except for one minor indentation problem on the
argument list of the method after you added
To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses
background's alpha channel
The logic here has mixed up the opacities and what needs to be done about them.
If the source image is opaque
Hi Prasanta,
Fix looks fine to me. We are taking care of both having the dialog within
proper monitor and also making sure that it stays within the window bounds and
also consistent with native print dialog.
Thanks,
Jay
-Original Message-
From: Philip Race
Sent: Wednesday, March 02,
301 - 400 of 432 matches
Mail list logo
