[jira] [Commented] (KUDU-3402) Make tracing.html work on newer browsers

2023-06-23 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736544#comment-17736544 ] Todd Lipcon commented on KUDU-3402: --- I think it's been deprecated and replaced by Perfetto (standalone

Re: Welcoming Yuqi Du as Kudu committer and PMC member

2023-06-06 Thread Todd Lipcon
Congrats, Yuqi! -Todd On Tue, Jun 6, 2023 at 11:01 AM Alexey Serbin wrote: > Congratulations, Yuqi! > > Thank you for your contribution to the project! > I look forward to seeing more of that coming from you as a committer and > PMC member :) > > > Kind regards, > > Alexey > > On Tue, Jun 6,

Re: [ANNOUNCE] Welcoming Abhishek Chennaka as Kudu committer and PMC member

2023-02-22 Thread Todd Lipcon
Congrats on the recognition of you work, Abhishek! Todd On Wed, Feb 22, 2023, 6:15 PM 邓科 wrote: > Congrats Abhishek!!! > > Yingchun Lai 于2023年2月23日周四 08:05写道: > > > Congrats! > > > > Mahesh Reddy 于2023年2月23日 周四03:07写道: > > > > > Congrats Abhishek!!! Great work and well deserved! > > > > > >

Re: [ANNOUNCE] Welcoming Abhishek Chennaka as Kudu committer and PMC member

2023-02-22 Thread Todd Lipcon
Congrats on the recognition of you work, Abhishek! Todd On Wed, Feb 22, 2023, 6:15 PM 邓科 wrote: > Congrats Abhishek!!! > > Yingchun Lai 于2023年2月23日周四 08:05写道: > > > Congrats! > > > > Mahesh Reddy 于2023年2月23日 周四03:07写道: > > > > > Congrats Abhishek!!! Great work and well deserved! > > > > > >

[jira] [Commented] (KUDU-3383) About strong consistency read from leader

2022-07-27 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572022#comment-17572022 ] Todd Lipcon commented on KUDU-3383: --- You might want to look at Yugabyte's implementation of leader

[jira] [Commented] (KUDU-3371) Use RocksDB to store LBM metadata

2022-05-25 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542192#comment-17542192 ] Todd Lipcon commented on KUDU-3371: --- Oh actually looks like I did put it on public github. Some info

[jira] [Commented] (KUDU-3371) Use RocksDB to store LBM metadata

2022-05-25 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542191#comment-17542191 ] Todd Lipcon commented on KUDU-3371: --- I think this is a reasonable idea. A long time ago I also tried

[kudu-CR] [ntp] improve two arithmetic operator

2021-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/17852 ) Change subject: [ntp] improve two arithmetic operator .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17852/3/src/kudu

Re: Kudu-python addition

2021-06-21 Thread Todd Lipcon
Sent an invite. -Todd On Mon, Jun 21, 2021 at 4:06 PM Bankim Bhavsar wrote: > Hello Kudu devs, > > Could anybody add me to the kudu-python project on Pypi.org? Need this for > uploading kudu-python artifacts for 1.15.0 > > https://pypi.org/project/kudu-python/#history >

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-3108: fix invalid memory accesses in merge iterator

2020-11-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 ) Change subject: KUDU-3108: fix invalid memory accesses in merge iterator .. Patch Set 6: I seem to recall that adar had a simpler two

[jira] [Resolved] (KUDU-2844) Avoid copying strings from dictionary or plain-encoded blocks

2020-08-26 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved KUDU-2844. --- Fix Version/s: 1.13.0 Resolution: Fixed > Avoid copying strings from dictionary or pl

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. KUDU-2844 (3/3): avoid copying plain

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. Patch Set 2: I think this needs some more fixup to have better test

[kudu-CR] WIP: support keys not at the front of a schema

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15748 ) Change subject: WIP: support keys not at the front of a schema .. WIP: support keys not at the front of a schema Change-Id

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Add .clang-format file This clang-format file seems to capture our existing style

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 2: Verified+1 Not waiting for Jenkins since there's no code change here

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41def9a77bd98bf09353fe9a7789756a1bff30c1 Gerrit-Change-Number: 16260 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit

[kudu-CR] Add .clang-format file

2020-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16260 ) Change subject: Add .clang-format file .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16260/1/docs/contributing.adoc

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-25 Thread Todd Lipcon (Code Review)
atchset Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Ge

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. KUDU-2844 (1/3): make BlockHandle ref-counted

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
nge-Number: 15800 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-13 Thread Todd Lipcon (Code Review)
aster Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerr

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15800/3

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-13 Thread Todd Lipcon (Code Review)
aster Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerr

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15800/2

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
nge-Number: 15800 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-13 Thread Todd Lipcon (Code Review)
-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15800/2

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15800/2

[kudu-CR] WIP KUDU-1587 part 1: load meter for ThreadPool

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 ) Change subject: WIP KUDU-1587 part 1: load meter for ThreadPool .. Patch Set 1: just did a quick skim over the patch, would be good

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
aster Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerr

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
nge-Number: 15800 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Volodymyr Verovkin

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 ) Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena .. Patch Set 3: (4 comments) http

[kudu-CR] KUDU-2844 (1/3): make BlockHandle ref-counted

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 ) Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15800/1

[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct

2020-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 3: (6 comments) http

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 12 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey

[kudu-CR] Remove last vestiges of gscoped ptr

2020-07-30 Thread Todd Lipcon (Code Review)
-Change-Number: 16261 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Lieber-Dembo Gerrit-Reviewer: Grant Henke

[kudu-CR] Add .clang-format file

2020-07-30 Thread Todd Lipcon (Code Review)
: I41def9a77bd98bf09353fe9a7789756a1bff30c1 Gerrit-Change-Number: 16260 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-30 Thread Todd Lipcon (Code Review)
/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 11 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer

[jira] [Commented] (KUDU-3178) An option to terminate connections which have been open for very long time

2020-07-30 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168086#comment-17168086 ] Todd Lipcon commented on KUDU-3178: --- Could we instead just keep track of the expiration time

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16249 ) Change subject: rpc: Change InboundCall arena to 4kB by default .. rpc: Change InboundCall arena to 4kB by default This changes

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
rit-MessageType: newpatchset Gerrit-Change-Id: Id20a3cbb5c2da1b6bfc519d852b90687297d4739 Gerrit-Change-Number: 16249 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] master-test: reuse protobuf for response

2020-07-29 Thread Todd Lipcon (Code Review)
:8080/16255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I865bf87cade25c784660f897849793fbe6d027df Gerrit-Change-Number: 16255 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16249 ) Change subject: rpc: Change InboundCall arena to 4kB by default .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16249

[kudu-CR] rpc: Change InboundCall arena to 4kB by default

2020-07-28 Thread Todd Lipcon (Code Review)
-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id20a3cbb5c2da1b6bfc519d852b90687297d4739 Gerrit-Change-Number: 16249 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-28 Thread Todd Lipcon (Code Review)
/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 9 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer

[kudu-CR] table locations-itest: reuse protobufs in the benchmark client

2020-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16236 ) Change subject: table_locations-itest: reuse protobufs in the benchmark client .. table_locations-itest: reuse protobufs

[kudu-CR] table locations-itest: reuse protobufs in the benchmark client

2020-07-24 Thread Todd Lipcon (Code Review)
-Number: 16236 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. tls_socket: avoid cork/uncork dance for small writevs

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
: Ic6abf790a38878b41862655e643782a7624b763f Gerrit-Change-Number: 16209 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 ) Change subject: tls_socket: avoid cork/uncork dance for small writevs .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c

[jira] [Commented] (KUDU-3162) Failed to compile kudu using openssl 1.1.1

2020-07-20 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161572#comment-17161572 ] Todd Lipcon commented on KUDU-3162: --- I think you want to set the OPENSSL_FOO_LIBRARY variables to point

[jira] [Resolved] (KUDU-3162) Failed to compile kudu using openssl 1.1.1

2020-07-20 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved KUDU-3162. --- Fix Version/s: n/a Resolution: Not A Problem > Failed to compile kudu using openssl 1.

[kudu-CR] tls socket: avoid cork/uncork dance for small writevs

2020-07-16 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16184 ) Change subject: loadgen: use multiple KuduClient instances .. loadgen: use multiple KuduClient instances KuduClient

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16169/5/src

[kudu-CR] tablet: acquire/release locks in batches

2020-07-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. tablet: acquire/release locks in batches Prior to this patch, each

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tablet: acquire/release locks in batches .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16169 To unsubscribe, visit

[kudu-CR] tablet: acquire/release locks in batches

2020-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 5: Verified+1 Failure looks unrelated. This should be ready

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16169 ) Change subject: tablet: acquire/release locks in batches .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/16169/2/src

[kudu-CR] tablet: acquire/release locks in batches

2020-07-14 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16189 ) Change subject: client: allocate InFlightOp from a Batcher Arena .. client: allocate InFlightOp from a Batcher Arena

[kudu-CR] tablet: acquire/release locks in batches

2020-07-13 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
nge-Number: 16189 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16189 ) Change subject: client: allocate InFlightOp from a Batcher Arena .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16189

[kudu-CR] client: allocate InFlightOp from a Batcher Arena

2020-07-13 Thread Todd Lipcon (Code Review)
iew, visit http://gerrit.cloudera.org:8080/16189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I446a8d21253b7a274872bff6d3e76705ac95d0d5 Gerrit-Change-Number: 16189 Gerrit-PatchSet: 1 Gerrit-O

[kudu-CR] WIP: tablet: acquire/release locks in batches

2020-07-13 Thread Todd Lipcon (Code Review)
Gerrit-Change-Number: 16169 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] loadgen: use multiple KuduClient instances

2020-07-13 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/16184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I722a0761e97894857e2ca3c0286b4467d7f27d47 Gerrit-Change-Number: 16184 Gerrit-PatchSet: 1 Gerrit-Owner: Todd

[kudu-CR] WIP: lock manager batch release

2020-07-10 Thread Todd Lipcon (Code Review)
Gerrit-MessageType: newchange Gerrit-Change-Id: I3cb724e953ecdf188a35181c2f91b721b3416524 Gerrit-Change-Number: 16169 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. Patch Set 4: Verified+1 Test failure looks unrelated -- To view, visit http

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-636. Use Arena for EncodedKeys .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16162 To unsubscribe, visit http

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. KUDU-636. Use Arena for EncodedKeys This updates EncodedKeyBuilder

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib46d0e2c31e03a7f319ceb0bf742e08ff74d7683 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16162 ) Change subject: KUDU-636. Use Arena for EncodedKeys .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16162/2/src/kudu

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-10 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib46d0e2c31e03a7f319ceb0bf742e08ff74d7683 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-09 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib46d0e2c31e03a7f319ceb0bf742e08ff74d7683 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer

[kudu-CR] KUDU-636. Use Arena for EncodedKeys

2020-07-09 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/16162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib46d0e2c31e03a7f319ceb0bf742e08ff74d7683 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 ) Change subject: KUDU-636. Use protobuf arenas for CommitMsgs .. Patch Set 3: also worth noting I rebased this away from

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 ) Change subject: KUDU-636. Use protobuf arenas for CommitMsgs .. Patch Set 3: (2 comments) think I fixed the issues but we'll see what

[kudu-CR] KUDU-636. Use protobuf arenas for CommitMsgs

2020-07-09 Thread Todd Lipcon (Code Review)
: I78698d4cb4944bddd8dabd6cbbf1e3a064056199 Gerrit-Change-Number: 16147 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Enable arenas for RPC request and response This changes the RPC

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Enable arenas for RPC request and response .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16136 To unsubscribe, visit

[kudu-CR] Enable arenas for RPC request and response

2020-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 5: Verified+1 The failure here is a pre-existing LSAN issue

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Upgrade C++ to protobuf 3.12 This has various performance improvements

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-07 Thread Todd Lipcon (Code Review)
/16147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78698d4cb4944bddd8dabd6cbbf1e3a064056199 Gerrit-Change-Number: 16147 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
-Change-Id: Ifd5e6bbdd2c517b1af2ff833701983315111bba4 Gerrit-Change-Number: 16135 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Optimize GetTableLocations for better arena use

2020-07-07 Thread Todd Lipcon (Code Review)
: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Enable arenas for RPC request and response

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 ) Change subject: Enable arenas for RPC request and response .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/16136/4

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/16135/4/src/kudu/cfile

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
: Ifd5e6bbdd2c517b1af2ff833701983315111bba4 Gerrit-Change-Number: 16135 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Use protobuf arenas for CommitMsgs

2020-07-06 Thread Todd Lipcon (Code Review)
: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] Enable arenas for RPC request and response

2020-07-06 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16135 ) Change subject: Upgrade C++ to protobuf 3.12 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16135/3/thirdparty

[kudu-CR] Upgrade C++ to protobuf 3.12

2020-07-02 Thread Todd Lipcon (Code Review)
: Ifd5e6bbdd2c517b1af2ff833701983315111bba4 Gerrit-Change-Number: 16135 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] WIP: Enable arenas for RPC request and response

2020-07-02 Thread Todd Lipcon (Code Review)
ter Gerrit-MessageType: newpatchset Gerrit-Change-Id: I810931900fc2b5f1dec1265abadfb33fb41d29bf Gerrit-Change-Number: 16136 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

  1   2   3   4   5   6   7   8   9   10   >