Re: [blink-dev] Intent to Ship: :user-valid and :user-invalid CSS pseudo-classes

Thanks for adding that test Joey! https://staging.wpt.fyi/results/css/selectors/valid-invalid-form-fieldset.html?label=pr_head&max-count=1&pr=41801 shows that it also passes on Firefox. Not sure why Safari didn't run, but that's not your fault and not something to block on. LGTM1, and thanks for

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

Hi Koji, It looks like the tests for this are here: https://wpt.fyi/results/css/css-text/word-break/auto-phrase?label=experimental&label=master&aligned Since the implementation uses a heuristic and the spec doesn't define the precise rules, can you say something about the approach taken in the te

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

Thanks for investigating and fixing the failures, Koji! On the UA defined rules, if other vendors are happy with the examples used, then that's what matters in practice. If you do get pushback on specific examples I hope there are others that can be used that are a common ground. I think everythi

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

LGTM1 If there is feedback on the TAG review or Mozilla issue while this feature is on its way to stable, can you loop back to this thread? On Thu, Sep 7, 2023 at 4:01 PM Philip Jägenstedt wrote: > Thanks for investigating and fixing the failures, Koji! > > On the UA defined rules,

Re: [blink-dev] Intent to Ship: Fire toggle events using microtasks

It sounds like the idea is to prove this web compatible by shipping it, before updating the spec. On the level of interest, there was no reaction on https://github.com/whatwg/html/issues/9046 after you asked. Is there other communication that makes you relatively sure the interest is there? On Fri

Re: [blink-dev] Intent to Ship: MediaStreamTrack Stats

LGTM1, this is a minor addition to an existing API, was discussed in the WG at TPAC, and has a positive standards position from Mozilla. On Mon, Oct 9, 2023 at 4:16 PM Henrik Boström wrote: > *Contant emails:* > h...@chromium.org, h...@chromium.org > > *Explainer:* > This is a small addition to

Re: [blink-dev] Intent to Ship: CSS Exponential Functions

LGTM1, when Gecko and WebKit have already shipped there isn't much to discuss :) On Tue, Oct 17, 2023 at 10:00 AM Daniil Sakhapov wrote: > Contact emailssakha...@chromium.org, seo...@chromium.org > > Specification > https://www.w3.org/TR/css-values-4/#exponent-funcs > > Summary > > Add css expon

Re: [blink-dev] Intent to Prototype and Ship: URL.canParse

LGTM3 https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=canparse shows this is indeed passing on Firefox and Safari. On Mon, Oct 16, 2023 at 7:34 PM Alex Russell wrote: > LGTM2 > > On Mon, Oct 16, 2023 at 7:24 AM Mike Taylor > wrote: > >> LGTM1 >> On 10/13/23 6:08 PM, Jerem

Re: [blink-dev] Re: Intent to Ship: Close requests for CloseWatcher, , and popover=""

eventDefault()ed cancel event. See >> https://github.com/WICG/close-watcher/blob/main/README.md#abuse-analysis >> for more details. >> >> >> Also helpful; thank you! >> >> >> Note that the API generally guides you away from this possibility by >> making

Re: [blink-dev] Intent to Ship: Fire toggle events using microtasks

is a risk for web compatibility, although I was convinced that this > should just improve the consistency of the event timing. > If there is significant breakage, I will disable this change via finch and > revert the spec changes. > > On Fri, Oct 6, 2023 at 4:12 AM Philip Jägenst

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

LGTM3 with sentimental feelings. Back in 2010 (https://dev.opera.com/blog/re-introducing-video/) I was cheering for Theora and shipped support in Presto. We now have other open and RF video codecs which have been deployed on a much larger scale, and I'd like to think that Theora and the Xiph folks

Re: [blink-dev] Intent to ship: The Login Status API and its use in FedCM

Hi Christian, Do you have a reviewer for https://github.com/web-platform-tests/wpt/pull/40709 so you can get it merged? Just like spec changes, tests are ideally merged and showing results on wpt.fyi before we ship, so that any issues are apparent and can be addressed. Best regards, Philip On We

Re: [blink-dev] Intent to Ship: CSS and Syntax for registered Custom Properties

LGTM3 On Tue, Oct 24, 2023 at 5:28 PM Chris Harrelson wrote: > LGTM2 > > On Tue, Oct 24, 2023 at 8:27 AM Mike Taylor > wrote: > >> Understood - thanks! >> >> LGTM1 >> On 10/24/23 9:16 AM, Rune Lillesveen wrote: >> >> On Tue, Oct 24, 2023 at 1:58 AM Mike Taylor >> wrote: >> >>> Hey Rune, >>> On

Re: [blink-dev] Re: Intent to Ship: WebGPU maxBindGroupsPlusVertexBuffers limit

Hi François, Corentin, I greped for "maxBindGroupsPlusVertexBuffers" in a checkout of https://github.com/gpuweb/cts but couldn't find any tests. Should there be shared tests there? Best regards, Philip On Wed, Oct 25, 2023 at 4:25 PM Mike Taylor wrote: > LGTM2 > On 10/25/23 4:32 AM, 'François

Re: [blink-dev] Re: Intent to Ship: WebGPU maxBindGroupsPlusVertexBuffers limit

ative/Device.cpp;l=1808;drc=b6a33c6fb6097fb097b7e60ad63cb552724cf60e > In the meantime, we have web platform tests to check its existence: > https://chromium-review.googlesource.com/c/chromium/src/+/4952541/3/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt > > > On Fri,

Re: [blink-dev] Intent to Ship: CSS masking

LGTM1 Thanks for writing that up, Philip! I believe that should be helpful for release notes and MDN docs down the line. On Thu, Oct 26, 2023 at 7:20 PM 'Philip Rogers' via blink-dev < blink-dev@chromium.org> wrote: > > > On Wednesday, October 25, 2023 at 7:24:34 AM UTC-7 Mike Taylor wrote: > >

Re: [EXTERNAL] Re: [blink-dev] Intent to Implement and Ship: Feature detection for supported clipboard formats

LGTM2 This looks like a small addition that we should ship. It's tested and passing here: https://wpt.fyi/results/clipboard-apis/clipboard-item.https.html?label=experimental&label=master&aligned On Wed, Nov 1, 2023 at 4:43 PM Rick Byers wrote: > LGTM1 > > On Wed, Oct 25, 2023 at 4:33 PM 'Anupam

Re: [blink-dev] Re: PSA: Web contents will honor the Android OS bold text setting

Hi Mark, There is certainly precedent for supporting OS-level settings like this, and doing it is important for the users who use the settings and expect consistent experience. As Dominik notes, most such modes are detectable, and for some the page can react to the preference using prefers-* media

Re: [blink-dev] Intent to Ship: SpeechSynthesis and SpeechSynthesisVoice interface objects

a bugfix > > On Wed, Jun 30, 2021 at 4:41 AM Daniel Bratell > wrote: > >> LGTM2 >> On 2021-06-30 01:40, TAMURA, Kent wrote: >> >> LGTM1. >> They should have interface objects, and the Gecko status is a good signal. >> >> On Wed, Jun 30, 2021 at

Re: [blink-dev] Intent to Prototype: @page margin boxes

It's great to see a bug with so many stars (now 100!) being addressed. Thanks for filing the TAG review at https://github.com/w3ctag/design-reviews/issues/918 too! On Fri, Nov 3, 2023 at 2:19 PM Morten Stenshorne wrote: > Contact emailsmsten...@chromium.org > > Explainerhttps://github.com/msten

Re: [blink-dev] Re: Intent to Ship: Document picture-in-picture: require user gesture for resize APIs

LGTM2 On Wed, Nov 29, 2023 at 4:12 PM Yoav Weiss wrote: > LGTM1 > > On Wednesday, November 29, 2023 at 4:04:49 PM UTC+1 Tommy Steimel wrote: > >> Okay the security reviewer has now re-reviewed it given the updated >> information. Thanks! >> >> On Mon, Nov 27, 2023 at 11:55 PM Rick Byers wrote:

Re: [blink-dev] Intent to Ship: Storage Buckets API

Hi Evan, A few questions inline. On Tue, Nov 14, 2023 at 9:38 PM Evan Stade wrote: > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? > > No > Which platform will this not be supported on? > Is this feature fully te

Re: [blink-dev] Intent to Ship: Document rules, response header, eagerness

LGTM3 On Wed, Nov 29, 2023 at 5:55 PM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2023-11-23 10:11, Yoav Weiss wrote: > > LGTM1 > > These all seem like useful improvements! :) > > > On Wed, Nov 22, 2023 at 8:14 PM Jeremy Roman wrote: > >> >> >> On Wed, Nov 22, 2023 at 11:10 AM Yoav Weiss >>

Re: [blink-dev] Intent to Ship: Storage Buckets API

t; > Hi Philip, > > thanks for pointing out those two oversights. I have fixed the checkboxes > on the chromestatus entry. It is in fact tested by WPT and supported on all > Blink platforms. > > On Wed, Nov 29, 2023 at 8:43 AM Philip Jägenstedt > wrote: > >> Hi Evan,

Re: [blink-dev] Intent to Ship: Storage Buckets API

rage/buckets/detached-iframe.https.html: > wpt_internal/storage/buckets/idlharness-worker.https.any.js: > wpt_internal/storage/buckets/opaque-origin.https.window.js: > wpt_internal/storage/buckets/resources/opaque-origin-sandbox.html: > wpt_internal/storage/buckets/storage_bucket_object.ten

Re: [blink-dev] Intent to Ship: Extension of WebDriver command for clicking on FedCM dialogs

LGTM3 On Tue, Dec 5, 2023 at 7:58 PM Rick Byers wrote: > LGTM2 > > On Tue, Dec 5, 2023 at 12:31 PM Mike Taylor > wrote: > >> LGTM1 >> On 12/5/23 3:44 AM, 'Zachary Tan' via blink-dev wrote: >> >> My mistake - it is indeed without the "k", thanks for double checking. >> >> On Tue, Dec 5, 2023 at

Re: [blink-dev] Intent to Ship: Storage Buckets API

estdriver actions such as setting > permission state can enable a wide range of tests. In those cases the > calculus of cost vs reward is much more favorable. So I would assume that > changes to testdriver should meet a high bar of broad utility, similar to > how we treat core libra

Re: [blink-dev] Intent to Ship: CSSKeyframesRule.length

LGTM1 with or without a feature flag. I'm comfortable to LGTM this even without a flag because the length property was exposed in Gecko and WebKit

Re: [blink-dev] Intent to Ship: Navigational prefetch: follow redirects

LGTM3 On Wed, Dec 13, 2023 at 3:11 AM Mike Taylor wrote: > LGTM2 > On 12/12/23 5:34 PM, Rick Byers wrote: > > Personally I'd consider this prefetch behavior change to be more of a UA > impl detail than a "web exposed API". I'm really glad you're covering this > in a spec and WPT in the hopes of

Re: [blink-dev] Intent to deprecate and remove import assertion 'assert' syntax

On Wed, Dec 13, 2023 at 6:10 PM Shu-yu Guo wrote: > On Wed, Dec 13, 2023 at 9:03 AM Philip Jägenstedt > wrote: > >> LGTM2 for Mike's plan of deprecating for 3 milestones, doing outreach, >> and then revisiting this thread. >> >> If we still know of seriou

Re: [blink-dev] Intent to Ship: Storage Buckets API

On Fri, Dec 15, 2023 at 9:03 PM Evan Stade wrote: > Thanks all! > > On Wed, Dec 13, 2023 at 5:10 AM Philip Jägenstedt > wrote: > >> Hi Evan, >> >> Thanks for looking into this, and for answering some of my questions >> off-list. To summarize, eviction is

Re: [blink-dev] Intent to Ship: field-sizing CSS property

Hi Kent, I see that https://github.com/whatwg/html/pull/9903 is still open, do you expect to be able to land it soon? Given the positive review on https://github.com/WebKit/standards-positions/issues/231, perhaps requesting review from someone on the WebKit team would be fruitful? Best regards, P

Re: [blink-dev] Re: Intent to Ship: Use specific fetch destination for JSON/CSS modules

LGTM2, thanks for fixing this! On Wed, Jan 10, 2024 at 5:03 PM Yoav Weiss wrote: > LGTM1 > > > > On Wed, Jan 10, 2024 at 4:58 PM Nicolò Ribaudo > wrote: > >> Yes I made a mistake in the description. The destination for CSS modules >> is indeed "style", and not "css". Thanks for catching it! >>

Re: [blink-dev] Re: Intent to Ship: Import attributes 'with' syntax

LGTM2 On Wed, Jan 10, 2024 at 5:16 PM Yoav Weiss wrote: > LGTM1 > > On Wed, Jan 10, 2024 at 5:08 PM Nicolò Ribaudo > wrote: > >> > Like other JS language changes, I'm guessing we expect developers to >> use UA sniffing to know where it's safe to ship this syntax? >> >> Yes -- given that this is

Re: [blink-dev] Re: Intent to Ship: Close requests for CloseWatcher, , and popover=""

> wrote: > >> LGTM3 >> >> I agree that introspection can be additive on top of what we want to ship >> here. >> >> On Wed, Oct 18, 2023 at 5:48 PM Philip Jägenstedt >> wrote: >> >>> The spec change has now landed, LGTM2. >>> >

Re: [blink-dev] Re: Intent to implement and ship: Allow elements with CSS display:contents to be focusable

On Wed, Jan 10, 2024 at 5:50 PM David Baron wrote: > > > On Wed, Jan 10, 2024 at 11:14 AM Yoav Weiss > wrote: > >> >> >> On Tuesday, January 9, 2024 at 5:39:19 PM UTC+1 David Baron wrote: >> >> Contact emailsdba...@chromium.org >> >> ExplainerNone >> >> Specificationhttps://github.com/w3c/csswg-

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

ies back in > Chrome 15, whereas a *deprecation/removal* has a different set of fields, > if I understand correctly. > > >> >> What's a reasonable sample size of HTTP Archive sites to audit? Should >> this be a complement/precursor to the proposed Deprecation Tri

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

On Thu, Jan 25, 2024 at 2:00 AM Wesley Luyten wrote: > Wesley from Mux here. I saw the issue come by. > > We'd be happy those API's could get deprecated and unified into the new > one. > > Our Media Chrome (library, not browser) implementation handles this > gracefully, some code here > > https:/

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

ld I >>>>>> create a >>>>>> new feature (titled "Deprecation of HTMLVideoElement-specific Prefixed >>>>>> Fullscreen API")? I think the current ChromeStatus entry also covers this >>>>>> API >>>>>> <https

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

t; are using https://f.vimeocdn.com/p/4.27.1/js/vendor.module.js, one link > is also playing an overlay video intro. > > On Thu, Jan 25, 2024 at 12:25 AM Philip Jägenstedt > wrote: > >> I'm also happy to support a plan to deprecate and remove. The use counter >> that

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

minimize the work for web authors as they switch away from > the API. > > On Fri, Jan 26, 2024 at 6:26 AM Philip Jägenstedt > wrote: > >> https://sites.google.com/a/chromium.org/dev/blink/launching-features >> doesn't give any guidance on the timeline, so let's

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Apologies in advance for excessive paperwork, but can you also put https://chromestatus.com/feature/5111638103687168 through the process, requesting enterprise signoff in particular? Enterprise folks could depend on this and might need to take some extra action, and a "Feature deprecation" entry is

Re: [blink-dev] Intent to Ship: Element Reflection

Hi Alice, For testing of these in WPT, do you have some details on what's missing? It's already possible to get the accessible name and role for an element: https://web-platform-tests.org/writing-tests/testdriver.html#accessibility I suspect that won't help, but there's an experimental/tentative

Re: [blink-dev] Intent to Ship: CJK punctuation kerning: the CSS `text-spacing-trim` property

Hi Koji, Thanks for linking the tests, judging just by the test names it looks like many combinations of languages and fonts are tested. Some of the tests are failing though, is that expected? Also, I see that some of the tests don't actually use text-spacing-trim, are those just testing default

Re: [blink-dev] Intent to Ship: CJK punctuation kerning: the CSS `text-spacing-trim` property

As a data point, I see that the flag in STP is called "CSS text-spacing property", which suggests all 3 properties behind a single flag. It might not ship together, but it's a good guess. On Thu, Feb 1, 2024 at 12:02 PM Philip Jägenstedt wrote: > Hi Koji, > > Than

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

a field on the chrome status entry? It doesn't show up for me. Or >> is this about emailing the list mentioned here >> <https://www.chromium.org/developers/enterprise-changes/#1-give-enterprises-visibility> >> ? >> >> Thanks, >> Thomas >> >>

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

I see the Gecko issue has now been resolved as positive, which is great. Are any of these units already supported in Firefox or Safari, or would we be the first to ship all of them? (I took a look at one test and have a guess, but just as well to ask.) On Sat, 7 Jan 2023 at 01:48 Mike Taylor wro

Re: [blink-dev] Intent to Ship: CSS Root Font Units: 'rex', 'rch', 'ric', 'rlh'

but nothing else I guess. None of > them are in Firefox. > > On Tue, Jan 10, 2023 at 11:11 AM Philip Jägenstedt > wrote: > >> I see the Gecko issue has now been resolved as positive, which is great. >> >> Are any of these units already supported in Firefox or Safari,

Re: [blink-dev] Intent to Ship: CSS Nesting

I think that we should ship this. It's a high profile and in-demand new feature , so I have a few questions and comments first. Taking a look at the open spec issues ( https://github.com/w3c/csswg-drafts/labels/css-nesting-1) some

Re: [blink-dev] Re: Intent to Ship: Add containerName and containerQuery, update conditionText

LGTM1 Thanks Daniil for that httparchive analysis. The second one looking for use of the @container rule should include all cases that could matter. 56 unique matches is a very small number when it comes to httparchive compat analysis. I double checked just one of them (botaniska.se, a nice park i

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

Is https://github.com/whatwg/html/pull/8199 blocked mainly on implementer interest? Do other browsers exactly match the behavior before this spec change, or is it more complicated than that? What I'm getting at is whether we have confidence that we'll have eventual interop on the new behavior. On

Re: [blink-dev] Intent to Ship: Streaming declarative shadow DOM

LGTM3, that this is already enabled in WebKit makes it a pretty simple case. On Wed, Jan 25, 2023 at 8:34 AM Yoav Weiss wrote: > LGTM2 > > On Tue, Jan 24, 2023 at 9:27 PM Rick Byers wrote: > >> Thanks Mason. LGTM1 >> >> On Tue, Jan 24, 2023 at 2:59 PM Mason Freed wrote: >> >>> >>> >>> On Tue,

Re: [blink-dev] Intent to Ship: CSS Nesting

ongoing > discussions around this topic on the CSSWG, for example today there's a > special meeting only for CSS Nesting topics: > https://lists.w3.org/Archives/Public/www-style/2023Jan/0011.html > > What's their impact on the current implementation? > > Thanks, >

Re: [blink-dev] Intent to Ship: CSS Nesting

t; back here to allow for a new attempt at building more consensus. As always, >> some breaking changes may be possible after that point too, but it'll >> depend on the realities of web compat. >> >> API owners also agreed that we'd look for 4 LGTMs in this case ins

Re: [blink-dev] Intent to Ship: CSS Nesting

it or > they will simply not use the feature. > I've therefore created an issue > <https://github.com/w3c/csswg-drafts/issues/8399> to discuss this. > > Sebastian > > On Friday, January 27, 2023 at 9:46:38 AM UTC+1 Philip Jägenstedt wrote: > >> Hi Oriol

Re: [blink-dev] Intent to Deprecate and Remove: WebRTC's RTCStats of type "track" and "stream".

LGTM1 for the plan to remove in 112 with reverse OT until 115. We discussed in today's meeting whether we should also have an enterprise policy, but landed on not requesting it. The reason is that it's quite possible that this change only breaks Twilio and nothing else, at all. That's because of t

Re: [blink-dev] Intent to Ship: CSS font-variant-position property

I will recuse myself from this one since I have an interest in the success of Interop 2022 (and 2023), but I think shipping this makes sense. Chrome is the last browser to not support it at all, and we've seen with other features that the time it becomes available in all browsers can be an inflecti

Re: [blink-dev] Intent to Ship: Fetch: Headers.getSetCookie()

LGTM1 On Fri, Feb 10, 2023 at 7:05 PM Andreu Botella wrote: > Contact emails abote...@igalia.com, ri...@chromium.org > > Explainer None > > Specification https://fetch.spec.whatwg.org/#dom-headers-getsetcookie > > Design docs > https://github.com/whatwg/fetch/issues/973#issuecomment-902578584 >

Re: [blink-dev] Re: Intent to Ship: WebGLContextEvent on Web Workers

Hi Josh, Thanks for taking a look at this and noticing it's kind of fragile and broken :) The idlharness.js setup has evolved step by step from IDL manually copied from specs and inlined into specs, to today's setup of the interfaces/*.idl being updated by automated PRs, but *not* reviewed/merged

Re: [blink-dev] Intent to Ship: URL Standard-compatible IPv4 embedded IPv6 host parser

LGTM3 First of all, thank you for working on this! I think adding a use counter is probably too much overhead for this change, but I took a look [1] in httparchive for the strings 'http://[::' and 'https://[::' and got 123 and 2 matches respectively. Among the top ranked sites are https://www.che

Re: [blink-dev] Intent to Ship: URL Standard-compatible IPv4 embedded IPv6 host parser

[::1.2]"; is worth testing I'll leave to your judgment. On Wed, Feb 15, 2023 at 6:09 PM Philip Jägenstedt wrote: > LGTM3 > > First of all, thank you for working on this! > > I think adding a use counter is probably too much overhead for this > change, but I took a look [1

Re: [blink-dev] Intent to Ship: Resoure Hint "Least Restrictive" CSP

LGTM3 On Wed, Feb 22, 2023 at 8:07 AM Noam Rosenthal wrote: > Anyone for a LGTM3? :) > > On Wed, Feb 15, 2023 at 6:24 PM Mike Taylor > wrote: > >> LGTM2 >> >> On Wed, Feb 15, 2023 at 9:58 AM Yoav Weiss >> wrote: >> >>> LGTM1 >>> >>> Thanks for cleaning this up and landing on a solution that's

Re: [blink-dev] Intent to Deprecate and Remove: Legacy callback-based RTCPeerConnection.getStats() API

I think the overall timeline looks great, the final removal is almost a year from now, after the 2023 holiday season. However, I'd like to bikeshed "Throw an exception if the trial is not used in Stable in M119 (Release: October 31, 2023)". This is when the breakage will be apparent to most users/

Re: [blink-dev] Intent to Deprecate and Remove: Legacy callback-based RTCPeerConnection.getStats() API

LGTM2, even better! On Fri, Feb 24, 2023 at 5:04 PM Yoav Weiss wrote: > SGTM! > > On Fri, Feb 24, 2023 at 4:40 PM Henrik Boström wrote: > >> Yes, I think throwing in M117, stable on Aug 30 would be even better. >> >> On Friday, February 24, 2023 at 4:32:21 PM

Re: [blink-dev] Intent to Ship: CSS "overflow" media features

I think this feature falls under Implementations of already-defined consensus-based standards in our process, and Signals from other implementations in an intent-to-ship

Re: [blink-dev] Intent to Ship: CSS headline balancing

Hi Koji, Looks like the tests are in https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&aligned&view=subtest&q=balance. There's one failing test there, do you know why that is? And overall, are you happy with the test coverage here, does it cover most important corner

Re: [blink-dev] Re: Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

Hi Eli, Jumping in here to answer your question since it was easy enough to test. `new URL('https://example!.com').host` in Chrome currently returns "example% 21.com", but in Safari it's "example!.com". With the proposed change, Chrome will match Sarari. I've also confirmed that your isValidHost(

Re: [blink-dev] Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

To simplify and keep this moving, I've filed https://github.com/mozilla/standards-positions/issues/759 as an umbrella issue for anything URL in Interop 2023. My view is that we can't improve our risk assessment of this by much with metrics, because we can't distinguish between harmless and serious

Re: [blink-dev] Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

On Mon, Mar 13, 2023 at 11:05 AM Yoav Weiss wrote: > > > On Mon, Mar 13, 2023 at 10:46 AM Philip Jägenstedt > wrote: > >> To simplify and keep this moving, I've filed >> https://github.com/mozilla/standards-positions/issues/759 as an umbrella >> issue for

Re: [blink-dev] Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

gt; CL is created by an external developer, would you suggest creating a > feature flag for it as well? > > Jiacheng Guo > > On Mon, Mar 13, 2023 at 7:31 PM Yoav Weiss wrote: > >> >> >> On Mon, Mar 13, 2023 at 11:21 AM Philip Jägenstedt >> wrote: >> &g

Re: [blink-dev] Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

;ve updated my isValidHost() util to support this change. Could someone >> please have another look and let me know if my implementation now aligns >> well with the spec? >> >> >> >> On Monday, March 13, 2023 at 6:26:18 PM UTC-7 dom...@chromium.org wrote: >>

Re: [blink-dev] Intent to Ship: Forbidden and escaped host characters compliant with the URL standard

LGTM1 to ship this change with a feature flag which we can use as a kill switch. Adding use counters so that we can get examples of breakage *if* it happens would be great too, if it's not too much overhead. On Tue, Mar 14, 2023 at 11:04 AM Philip Jägenstedt wrote: > Hi Eli, > >

Re: [blink-dev] Intent to Ship: Speculation rules: Content Security Policy extension

LGTM3, thanks for making this change visible. On Mon, Mar 13, 2023 at 11:42 PM TAMURA, Kent wrote: > LGTM2. > I agree with Yoav. > > > On Mon, Mar 13, 2023 at 6:59 PM Yoav Weiss wrote: > >> LGTM1. This seems like a reasonable, compatible addition which doesn't >> modify the interop risk calculu

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Mon, Mar 13, 2023 at 9:02 AM Koji Ishii wrote: > Looks like the tests are in >> https://wpt.fyi/results/css/css-text/white-space?label=master&label=experimental&aligned&view=subtest&q=balance. >> There's one failing test there, do you know why that is? > > > Thanks for pointing this out. The

Re: [blink-dev] Intent to Ship: CSS headline balancing

On Wed, Mar 15, 2023 at 5:35 PM Koji Ishii wrote: > On Thu, Mar 16, 2023 at 12:51 AM Philip Jägenstedt > wrote: > >> On Mon, Mar 13, 2023 at 9:02 AM Koji Ishii wrote: >> >> >>> Looks like the tests are in >>>> https://wpt.fyi/results/css/css-

Re: [blink-dev] Intent to Ship: CSS headline balancing

with the test coverage here, does it cover >>> most important corner cases? >> >> >> I'm keeping eyes on incoming issues and feedback. It's a pleasant >> surprise that more web devs than expected are excited with this feature, >> and gave us great fe

Re: [blink-dev] Intent to Ship: The Popover API

Hi Mason, This will be great, looking forward to seeing it ship! Two questions inline and bonus API-owner-hat-off question: Do you have a use counter for this feature which you'll use to track adoption? Do you have a ballpark guess about what the usage will be like a year from now? (There's an

Re: [blink-dev] Intent to Prototype: CSS font-palette property animation

Hi Munira, Do you think this will require any changes to DevTools for debuggability? There's a checklist at https://goo.gle/devtools-checklist, where the key question is "how would a web developer making use of your new WPF test and debug their code?" Best regards, Philip On Mon, Mar 20, 2023 at

Re: [blink-dev] Re: Intent to Ship: The Popover API

Hi Noam, Do you know if these sanitizers generally work as allowlists or blocklists? In other words, will the new popover attribute be allowed through current versions of those sanitizers? Best regards, Philip On Mon, Mar 20, 2023 at 9:19 AM Noam Rosenthal wrote: > Voicing some concern about t

Re: [blink-dev] Re: Intent to Ship: The Popover API

LGTM3 On Wed, Mar 22, 2023 at 4:52 PM Mike Taylor wrote: > LGTM2 > On 3/21/23 3:01 AM, Noam Rosenthal wrote: > > > > On Mon, Mar 20, 2023 at 8:13 PM Mason Freed wrote: > >> On Mon, Mar 20, 2023 at 1:19 AM Noam Rosenthal >> wrote: >> >>> Voicing some concern about this API that I've raised befo

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

Hi Roger, I took a look for the tests, and am wondering if the tests added here are for Level 4? https://github.com/web-platform-tests/wpt/pull/37950 At least some of them are already passing in Chrome Dev (with experimental features enabled), but not Chrome stable, so some of these tests seem re

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

I took a look at https://github.com/whatwg/html/pull/7908 and it looks like there's agreement to merge it, but it's waiting on this intent to be approved. Normally we block in the other direction, but that's fine, as long as the spec change is merged. Looks like there's broad support for this chan

Re: [blink-dev] Intent to Ship: CSS :lang pseudo class level 4

xtended-filtering.html >> and >> https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/selectors/lang-extended-filtering-with-string-arguments.html >> >> About the standards-positions issue, I filed it on >> https://github.com/mozilla/standards-positions/issues/735

Re: [blink-dev] Intent to Ship: Deprecate module size limit for WebAssembly.Module()

Hey Andreas, Do you know what the limits of other browsers are? If testing a 1 GB module is too slow to be reliable (sometimes timing out) then perhaps there's a large-ish module you can test with that still exceeds the current limits? Note that you could also add a manual test in WPT for the rea

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

ps://github.com/w3ctag/design-reviews/issues/832 I’ll update the >>>> ChromeStatus entry to refer to it. >>>> >>>> On Tuesday, April 4, 2023 at 5:21:16 AM UTC-7 mt...@google.com wrote: >>>>> >>>> Thanks to the UseCounter + UKM + M112 hit

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

On Wed, Apr 19, 2023 at 10:28 PM Rick Byers wrote: > On Wed, Apr 19, 2023 at 3:41 PM Philip Jägenstedt > wrote: > >> I wonder if we can get enough confidence with less work than >> investigating 40 randomly chosen sites from UseCounter hits. >> >> This is a p

Re: [blink-dev] Intent to Implement and Ship: Use RegExp v flag instead of u for HTML pattern attribute

1412729#c46 | ✅ | >> | https://www.thebay.com | >> https://crbug.com/1412729#c45 | ✅ | >> >> This is not quite a "random" sample, as I instead started with the most >> common s

Re: [blink-dev] Re: Intent-to-Ship: MediaRecorder keyframe configurability

Thanks for filing https://github.com/web-platform-tests/wpt/issues/39642, I've asked there for more details on what it would take to test this. The spec change added two dictionary members to https://w3c.github.io/mediacapture-record/#mediarecorderoptions-section which means that it would at least

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

On Wed, Apr 26, 2023 at 12:42 PM Yoav Weiss wrote: > > > On Fri, Apr 21, 2023 at 6:48 PM 'Markus Handell' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact emails: >> >> hande...@google.com >> >> Explainer: >> >>- >> >>https://github.com/w3c/mediacapture-record/pull/216 >>

Re: [blink-dev] Intent to Implement and Ship: Update of "xml" prefix handling in lookupNamespaceURI() and createNSResolver()

LGTM3, thanks for measuring with use counter and aligning with Gecko and WebKit on this. On Wed, Apr 26, 2023 at 9:11 PM Mike Taylor wrote: > LGTM2 > On 4/26/23 11:28 AM, Mike West wrote: > > LGTM1. > > Testing looks good, and skipping the TAG review for features specified and > shipped in other

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

On Thu, Apr 27, 2023 at 9:24 AM Markus Handell wrote: > >> Thanks for filing >> https://github.com/web-platform-tests/wpt/issues/39642, I've asked >> there for more details on what it would take to test this. >> >> > I added some more detail there. > > >> The spec change added two dictionary memb

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

cided that a separate spec issue be filed on that topic, > https://github.com/w3c/mediacapture-record/issues/219. > > > On Thu, Apr 27, 2023 at 12:38 PM Philip Jägenstedt > wrote: > >> On Thu, Apr 27, 2023 at 9:24 AM Markus Handell >> wrote: >> >>> >&

Re: [blink-dev] PSA: Adding WebDriver commands for interacting with FedCM dialogs

Hi Christian, Thanks for sending this PSA, and thank you for careful attention to testability of FedCM. It's extra work, but if history is any guide it will make FedCM more interoperable, and web developers will rejoice! WebDriver changes don't need to go through the Blink launch process, but a f

Re: [blink-dev] Intent to Ship: Boolean Context Style Container Queries

LGTM2 On Wed, May 3, 2023 at 11:35 PM Manuel Rego Casasnovas wrote: > LGTM1 > > On 03/05/2023 14:22, Rune Lillesveen wrote: > > > > Contact emails > > > > futh...@chromium.org > > > > > > Explainer > > > > None > > > > > > Specification > > >

Re: [blink-dev] Intent to Ship: Keyboard-focusable scroll containers

LGTM2 On Wed, May 10, 2023 at 5:50 PM Mike Taylor wrote: > LGTM1 > On 5/9/23 6:15 PM, Di Zhang wrote: > > Yes, this change is flagged behind the feature KeyboardFocusableScrollers > (disabled by passing > `--disable-blink-features=KeyboardFocusableScrollers`). > > We have looped in aleventhal@ f

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

It looks like this was spec'd in https://github.com/whatwg/url/pull/735, with participation from Chromium and WebKit folks. https://bugzilla.mozilla.org/show_bug.cgi?id=1831587 was filed for Gecko, but there's no clear position. Would you mind filing an issue at https://github.com/mozilla/standards

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

On Fri, May 12, 2023 at 11:57 AM Debadree Chatterjee wrote: > Hey! > > > to ensure Mozilla is aware this happening? > > I am filing an issue for this > Thanks! Can you link it here when filed? > > What can you say about usage in the wild here? > > In regards to this I believe no more data was

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

my testing. The rest of sites do occasionally > (sometimes with the second argument being 0, sometimes a different > number, sometimes a string), but none seemed to break in my testing. > > Andreu > On 5/12/23 10:38, Philip Jägenstedt wrote: > > It looks like this was spec&#x

Re: [blink-dev] Intent to Ship: CSS Motion Path

On Sat, May 13, 2023 at 1:09 AM Mike Taylor wrote: > Hi Daniil, > On 5/11/23 8:38 AM, Daniil Sakhapov wrote: > > Contact emails sakha...@chromium.org > > Explainer As part of the Interop 2023 we ship the rest of the CSS Motion > Path. Currently only path() works. And after a spec has been reworke

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

; Debadree > On Monday, May 15, 2023 at 10:06:05 PM UTC+5:30 PhistucK wrote: > >> It would be something like this - >> >> https://groups.google.com/a/chromium.org/g/blink-dev/c/rDaQdKpWAx8/m/qjTlRNShAgAJ >> >> ☆*PhistucK* >> >> >> On Mon, May 15,

  1   2   3   >