[jira] [Commented] (XERCESC-2077) Add CMake build system

2017-06-29 Thread Roger Leigh (JIRA)
[ https://issues.apache.org/jira/browse/XERCESC-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069093#comment-16069093 ] Roger Leigh commented on XERCESC-2077: -- Hi Franz, You're most welcome, and I'm glad that the work

[jira] [Comment Edited] (XERCESC-2077) Add CMake build system

2017-06-29 Thread Franz Beaune (JIRA)
[ https://issues.apache.org/jira/browse/XERCESC-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068815#comment-16068815 ] Franz Beaune edited comment on XERCESC-2077 at 6/29/17 10:03 PM: - Hey

Re: Upporting status

2017-06-29 Thread Roger Leigh
On 29/06/17 20:47, Cantor, Scott wrote: On 6/29/17, 3:25 PM, "Roger Leigh" wrote: It's "scripts/sanityTest.pl", a Perl script which runs all the tests, concatenates their output, and then diffs it with the expected output. It fails if the output differs or the tests fail

Re: Upporting status

2017-06-29 Thread Cantor, Scott
Ack, never mind, PEBKAC, they're running now. -- Scott On 6/29/17, 3:49 PM, "Cantor, Scott" wrote: On 6/29/17, 3:46 PM, "Roger Leigh" wrote: > Actually, just run "make check" which builds the tests and runs them foryou. Not for me unfortunately.

Re: Upporting status

2017-06-29 Thread Cantor, Scott
On 6/29/17, 3:46 PM, "Roger Leigh" wrote: > Actually, just run "make check" which builds the tests and runs them foryou. Not for me unfortunately. export

Re: Upporting status

2017-06-29 Thread Cantor, Scott
On 6/29/17, 3:25 PM, "Roger Leigh" wrote: > It's "scripts/sanityTest.pl", a Perl script which runs all the tests, > concatenates their output, and then diffs it with the expected output. > It fails if the output differs or the tests fail prematurely. Well, I've run that

Re: Upporting status

2017-06-29 Thread Roger Leigh
On 29/06/17 20:25, Roger Leigh wrote: On 29/06/17 20:17, Cantor, Scott wrote: On 6/29/17, 3:02 PM, "Roger Leigh" wrote: The recent trunk changes broke a few of the unit tests. I don't understand how, other than the ones that are for some reason depending on the

Re: Upporting status

2017-06-29 Thread Cantor, Scott
On 6/29/17, 3:31 PM, "Roger Leigh" wrote: > This is because the unit test is comparing the tool help output line by > line and it's simply due to an extra line being added to the help > output. It's not a fault of the change, it's just that the test data > needs

Re: Upporting status

2017-06-29 Thread Roger Leigh
On 29/06/17 20:17, Cantor, Scott wrote: On 6/29/17, 3:02 PM, "Roger Leigh" wrote: The recent trunk changes broke a few of the unit tests. I don't understand how, other than the ones that are for some reason depending on the output of the parameter options for the

Re: Upporting status

2017-06-29 Thread Roger Leigh
On 29/06/17 20:17, Cantor, Scott wrote: On 6/29/17, 3:02 PM, "Roger Leigh" wrote: The recent trunk changes broke a few of the unit tests. I don't understand how, other than the ones that are for some reason depending on the output of the parameter options for the

[jira] [Commented] (XERCESC-2077) Add CMake build system

2017-06-29 Thread Franz Beaune (JIRA)
[ https://issues.apache.org/jira/browse/XERCESC-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068815#comment-16068815 ] Franz Beaune commented on XERCESC-2077: --- Hey Roger, I just created an account here to say a

Re: Upporting status

2017-06-29 Thread Cantor, Scott
On 6/29/17, 3:02 PM, "Roger Leigh" wrote: > The recent trunk changes broke a few of the unit tests. I don't understand how, other than the ones that are for some reason depending on the output of the parameter options for the DOMCount sample. That seems like an odd test,

Re: Upporting status

2017-06-29 Thread Roger Leigh
On 22/06/17 19:23, Cantor, Scott wrote: I've ported essentially all code-related changes and a decent amount of the web site changes from the 3.1 branch back up to trunk. At least one of the original security fixes to the branch apparently caused a regression, which I wasn't surprised by. I

[jira] [Updated] (XERCESC-2088) Bad casting from DOMTextImpl to DOMElementImpl

2017-06-29 Thread Scott Cantor (JIRA)
[ https://issues.apache.org/jira/browse/XERCESC-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Cantor updated XERCESC-2088: -- Attachment: casting.patch Updated proposed patch with more error checking and removed virtual

[jira] [Updated] (XERCESC-2088) Bad casting from DOMTextImpl to DOMElementImpl

2017-06-29 Thread Scott Cantor (JIRA)
[ https://issues.apache.org/jira/browse/XERCESC-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Cantor updated XERCESC-2088: -- Attachment: (was: casting.patch) > Bad casting from DOMTextImpl to DOMElementImpl >