[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

mgorny added a comment. In https://reviews.llvm.org/D23745#572517, @beanz wrote: > Is there a bug you're trying to fix here? It seems to me that the existing > behavior works correctly. I'm also pretty sure from the comment in > https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in

Re: r284265 - [Sema] Refactor context checking for availability diagnostics

Hi Erik, This change does not work with one of the headers from the AVFoundation framework in tvOS 10.0. We can try to get a fix into the tvOS SDK, but it will probably be a while before we could release an SDK with that change. In the meantime, this is kind of disruptive. Can you find a way

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

ahatanak updated this revision to Diff 74944. ahatanak added a comment. Address review comments. Simplify and add comments. https://reviews.llvm.org/D25547 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:31 +CallArgList , CallArgList *RtlArgs, +llvm::Optional DevirtualizedClassTy) { assert(CE == nullptr || isa(CE) || Shouldn't MD just be the devirtualized method? That should avoid

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

rjmccall added a comment. In https://reviews.llvm.org/D25448#572245, @vsk wrote: > Patch update: Pass along the type info of the derived class to the ubsan > runtime when we devirtualize a method call. This squashes the FP. I tested > this with 'check-ubsan' in addition to adding a lit test. >

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

beanz added a comment. Looking more closely at this, there is a problem that I see. The clang runtime directory only supports building compiler-rt, and is going to be replaced by the llvm runtimes directory in the (hopefully near) future. Maybe a better way to go is to define

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

vsk updated this revision to Diff 74943. vsk added a comment. - Remove some default arguments left over from an older revision of this patch. - Simplify the test. https://reviews.llvm.org/D25448 Files: lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

beanz added a comment. Is there a bug you're trying to fix here? It seems to me that the existing behavior works correctly. I'm also pretty sure from the comment in https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in the list. https://reviews.llvm.org/D23745

[PATCH] D25673: [libclang] Add missing cursor kinds to python bindings.

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks for working on this! Fwiw, I double-checked the API coverage with: $ git grep -E "CXCursor_[a-zA-Z_0-9]+ *= *[0-9]+" | grep -Eo "[0-9]+" | sort -u | uniq | wc -l

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. > The tests should be runnable with lit. I generally just do an in-tree build > and run make check-libcxx. @EricWF , what's the recommended way of running > the tests from an out-of-tree build? Things seem broken at the moment with clang from tip of tree. I did a clean

r284443 - [CMake] Add a few default passthrough variables for bootstrap builds

Author: cbieneman Date: Mon Oct 17 19:50:20 2016 New Revision: 284443 URL: http://llvm.org/viewvc/llvm-project?rev=284443=rev Log: [CMake] Add a few default passthrough variables for bootstrap builds This just passes through a few missing CMake variables for multi-stage builds. Modified:

Re: r284272 - Implement no_sanitize_address for global vars

Did you code-review this? (sorry if I missed it) On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Fri Oct 14 14:55:09 2016 > New Revision: 284272 > > URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev > Log: >

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL284442: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25711?vs=74935=74937#toc Repository: rL LLVM

r284442 - [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

Author: vedantk Date: Mon Oct 17 19:23:27 2016 New Revision: 284442 URL: http://llvm.org/viewvc/llvm-project?rev=284442=rev Log: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC) Differential Revision: https://reviews.llvm.org/D25711 Modified:

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#566507, @rSerge wrote: > I have extended this feature to check for OS support too (currently Linux > only). I can't commit it so far because I don't know how to implement a test. > XFAIL cannot check for both CPU and OS: it can only

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. The great thing about unique_ptr is, if it compiles, we're probably good. :) https://reviews.llvm.org/D25711 ___ cfe-commits mailing list

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

vsk created this revision. vsk added a reviewer: jlebar. vsk added a subscriber: cfe-commits. https://reviews.llvm.org/D25711 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added a comment. Thank you for continuing your efforts on this, I have just a few minor nits remaining. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35 + diag(MatchedDecl->getLocStart(), + "rand() function has limited randomness; " + msg); +}

[PATCH] D25363: Store a SourceRange for multi-token builtin types

aaron.ballman added inline comments. Comment at: include/clang/AST/TypeLoc.h:513 struct BuiltinLocInfo { - SourceLocation BuiltinLoc; + SourceRange BuiltinRange; }; Since this doubles the size of the type loc for builtin types, do you happen to have any

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. Sorry for the delay, I had thought I pointed to some potentially helpful documentation. :/ BTW, did the test get removed from the latest change? I don't see it being added anymore. https://reviews.llvm.org/D24799 ___

Re: [libcxx] r249738 - Split out of .

> @Bruno, > > Can you try "-fdiagnostics-show-note-include-stack” so we know the other path > that leads to string.h? Attached the complete error log (this snippet won't help without full context anyway) -- Bruno Cardoso Lopes http://www.brunocardoso.cc output.log Description: Binary data

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

manmanren added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10129 +!Var->isThisDeclarationADemotedDefinition()) { + assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules + && "Demoting decls is only in the contest of

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. This is better than what I asked for :] Manman https://reviews.llvm.org/D25284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r249738 - Split out of .

> On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Hi, > > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: >> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes >> wrote: >>>

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho removed rL LLVM as the repository for this revision. falho updated this revision to Diff 74908. falho added a comment. Herald added subscribers: modocache, mgorny, beanz. updated diff according to first reviews https://reviews.llvm.org/D22346 Files:

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

vsk retitled this revision from "[ubsan] Disable -fsanitize=vptr checks for devirtualized calls" to "[ubsan] Use the object pointer's type info for devirtualized calls". vsk updated the summary for this revision. vsk added a subscriber: rsmith. vsk updated this revision to Diff 74916. vsk added

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

This revision was automatically updated to reflect the committed changes. Closed by commit rL284430: [Driver] Use stem rather than filename for executable name (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25700?vs=74905=74917#toc Repository: rL LLVM

r284430 - [Driver] Use stem rather than filename for executable name

Author: phosek Date: Mon Oct 17 17:02:53 2016 New Revision: 284430 URL: http://llvm.org/viewvc/llvm-project?rev=284430=rev Log: [Driver] Use stem rather than filename for executable name When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

bruno accepted this revision. bruno added a comment. Ok, thanks! LGTM Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25703: [AST] Add CanonicalDeclPtr.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. CanonicalDeclPtr is just like a T*, except it calls T::getCanonicalDecl() on construction. This is useful as the key in a "set of canonical Decls" -- it's much less error-prone than calling

[PATCH] D25704: [CUDA] When we emit an error that might have been deferred, also print a callstack.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. Previously, when you did something not allowed in a host+device function and then caused it to be codegen'ed, we would print out an error telling you that you did something bad, but we wouldn't

[PATCH] D25702: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, rnk. This fixes two related bugs: 1. Previously, if you had a non-wrong side call at some source code location L, we wouldn't emit errors for wrong-side calls that appeared at L. 2. We'd only

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

davide added a comment. And yes, if you can add a test case that will be great (there's no bot that caught this upstream) but one of our internal bots did. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

bruno added a reviewer: bruno. bruno added a comment. Can you add a testcase for that? Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Was going to commit the same. Thanks. LGTM. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

[PATCH] D25663: [analyzer] Update alpha and potential checker documentation, esp. alpha.valist

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you for the cleanup! Anna. https://reviews.llvm.org/D25663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

phosek created this revision. phosek added a reviewer: davide. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker becase on Windows, the

Re: [libcxx] r249738 - Split out of .

Hi, On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes > wrote: >> >> Hi Richard, >> >> I have a patch on top of your suggested patch from a year ago, that >> break the cyclic dependency

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

rjmccall added a comment. In https://reviews.llvm.org/D25556#572054, @ahatanak wrote: > In https://reviews.llvm.org/D25556#569809, @rjmccall wrote: > > > Richard should probably weigh in about whether we should be recording > > potential captures at *all* capturing scopes. But at the very

[PATCH] D25621: DebugInfo: use DIAlignment type.

vleschuk updated this revision to Diff 74899. vleschuk added a comment. - Use uint32_t directly for alignment instead of creating typedef ofr it - Get rid of DebugInfo dependency in AST https://reviews.llvm.org/D25621 Files: include/clang/AST/ASTContext.h include/clang/AST/DeclBase.h

[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC

mgorny created this revision. mgorny added reviewers: bkramer, bruno, rafael. mgorny added a subscriber: cfe-commits. Replace the string matching for /etc/debian_version with split integer/string matching algorithm. When the file contains 'major.minor' version number, parse the major version as

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

rjmccall added a comment. Thanks! A couple minor tweaks, then LGTM. Comment at: lib/CodeGen/CGExpr.cpp:1652 +Src = RValue::get(EmitObjCExtendObjectLifetime(Dst.getType(), + Src.getScalarVal())); // fall into

[PATCH] D25448: [ubsan] Disable -fsanitize=vptr checks for devirtualized calls

rjmccall added a comment. In https://reviews.llvm.org/D25448#571941, @vsk wrote: > Thanks for your feedback so far, and sorry for the delayed response. > > In https://reviews.llvm.org/D25448#570014, @rjmccall wrote: > > > Wait, can you talk me through the bug here? > > > Derived inherits from

r284423 - Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target.

Author: adrian Date: Mon Oct 17 15:37:56 2016 New Revision: 284423 URL: http://llvm.org/viewvc/llvm-project?rev=284423=rev Log: Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target. This fixes the green dragon builders after r284416. Modified:

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

ahatanak added a comment. In https://reviews.llvm.org/D25556#569809, @rjmccall wrote: > Richard should probably weigh in about whether we should be recording > potential captures at *all* capturing scopes. But at the very least, I think > you have a bug here where the variable is declared

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

timshen added a comment. In https://reviews.llvm.org/D25595#571171, @mclow.lists wrote: > I like the fix. :-) > > However, I think that the test, rather than going in a bug specific file > (pr21597.pass.cpp), should be added to the existing tests - where it should > have been in the first

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

timshen updated this revision to Diff 74894. timshen marked an inline comment as done. timshen added a comment. Updated file location and documentation. https://reviews.llvm.org/D25595 Files: libcxx/include/regex libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp Index:

Re: r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

Thanks for noticing! I improved the test in r284420 by separating the check for debug info kind and dwarf version. -- adrian > On Oct 17, 2016, at 1:11 PM, Robinson, Paul wrote: > > > >> -Original Message- >> From: cfe-commits

r284420 - Improve the CHECK lines in debug-options.c by separating out the check

Author: adrian Date: Mon Oct 17 15:14:23 2016 New Revision: 284420 URL: http://llvm.org/viewvc/llvm-project?rev=284420=rev Log: Improve the CHECK lines in debug-options.c by separating out the check for debug info kind and dwarf version. Modified: cfe/trunk/test/Driver/debug-options.c

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

Glad we all agree. I opened https://llvm.org/bugs/show_bug.cgi?id=30720 to keep track of this. On Mon, Oct 17, 2016 at 9:08 AM, Rui Ueyama wrote: > Agreed. We should define them as aliases to existing options without > -plugin-opt. > > On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva

r284419 - [Coverage] Update test after r284418.

Author: davide Date: Mon Oct 17 15:06:32 2016 New Revision: 284419 URL: http://llvm.org/viewvc/llvm-project?rev=284419=rev Log: [Coverage] Update test after r284418. We now strip coverage metadata if debug info are not present. Modified: cfe/trunk/test/CodeGen/code-coverage.c Modified:

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov added a comment. friendly ping https://reviews.llvm.org/D25258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Adrian Prantl via cfe-commits > Sent: Monday, October 17, 2016 12:36 PM > To: cfe-commits@lists.llvm.org > Subject: r284416 - Driver/Darwin: Set the DWARF version based on the > deployment

r284417 - Update testcase for r284416.

Author: adrian Date: Mon Oct 17 14:46:26 2016 New Revision: 284417 URL: http://llvm.org/viewvc/llvm-project?rev=284417=rev Log: Update testcase for r284416. Modified: cfe/trunk/test/CodeGen/dwarf-version.c Modified: cfe/trunk/test/CodeGen/dwarf-version.c URL:

r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

Author: adrian Date: Mon Oct 17 14:36:18 2016 New Revision: 284416 URL: http://llvm.org/viewvc/llvm-project?rev=284416=rev Log: Driver/Darwin: Set the DWARF version based on the deployment target. System utilities such as atos only support DWARF 4 on OS X 10.11+ and iOS 9+. We thus want to

Re: [PATCH] D25448: [ubsan] Disable -fsanitize=vptr checks for devirtualized calls

On 17 Oct 2016 12:06 pm, "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: vsk added a comment. Thanks for your feedback so far, and sorry for the delayed response. In https://reviews.llvm.org/D25448#570014, @rjmccall wrote: > Wait, can you talk me through the bug here?

[PATCH] D25431: [libcxx] Convert Solaris support library to C++ to fix -std=c++11 build

mgorny planned changes to this revision. mgorny added a comment. Damn it, it seems that SunOS isn't actually exposing some functions. I need to work on this further, and figure out WTF. https://reviews.llvm.org/D25431 ___ cfe-commits mailing list

[PATCH] D25448: [ubsan] Disable -fsanitize=vptr checks for devirtualized calls

vsk added a comment. Thanks for your feedback so far, and sorry for the delayed response. In https://reviews.llvm.org/D25448#570014, @rjmccall wrote: > Wait, can you talk me through the bug here? Derived inherits from Base1 and Base2. We upcast an instance of Derived to Base2, then call a

[PATCH] D25606: alpha.core.UnreachableCode - don't warn about unreachable code inside macro

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rL LLVM https://reviews.llvm.org/D25606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka marked an inline comment as done. vitalybuka added a comment. Slowdown from this function is below: 0.05% and it's mostly just traversing AST. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

mgorny planned changes to this revision. mgorny added a comment. I'm going to delay this one a bit. I've already fixed all other distro checks to use VFS. Now I'd like to update them to use proper numeric parsing. https://reviews.llvm.org/D24954

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

mgorny added a comment. A gentle ping. https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

mgorny added a comment. In https://reviews.llvm.org/D25686#571857, @hfinkel wrote: > It seems like we should teach Triple how to parse this triples correctly > (i.e. to recognize that the vendor is ARM), and then canonicalize the > environment to GNUEABIHF (or whatever)? I've attempted that

[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

ABataev added inline comments. Comment at: include/clang/AST/Type.h:2934 ExtInfo(bool noReturn, bool hasRegParm, unsigned regParm, CallingConv cc, -bool producesResult) { +bool producesResult, bool noCallerSavedRegs) { assert((!hasRegParm ||

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

rsmith added a comment. I really don't like the command-line interface you're proposing here. It seems like it will be extremely confusing what something like `-fmodules -fexclusive-builtin-modules` means, for instance (usually, later `-f` flags override earlier ones, so does this *turn off*

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

hfinkel added a comment. It seems like we should teach Triple how to parse this triples correctly (i.e. to recognize that the vendor is ARM), and then canonicalize the environment to GNUEABIHF (or whatever)? https://reviews.llvm.org/D25686 ___

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

bruno added a comment. > The long answer is that there is a history of problems regarding the > intrinsic files: > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html > http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html > Mainly compatibility issues because MSVC

Re: r284392 - Reapply r284383. The test failures were due to a missing dir in test/

On 17 October 2016 at 10:34, Tim Northover wrote: > I think this might be something to do with git not actually recording > empty directories. Could you have another look? Never mind, I've confirmed and committed a fix in r284401. Tim.

[PATCH] D25641: [Driver] Use VFS to perform all distribution checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL284403: [Driver] Use VFS to perform all distribution checks (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25641?vs=74767=74874#toc Repository: rL LLVM

r284403 - [Driver] Use VFS to perform all distribution checks

Author: mgorny Date: Mon Oct 17 13:07:15 2016 New Revision: 284403 URL: http://llvm.org/viewvc/llvm-project?rev=284403=rev Log: [Driver] Use VFS to perform all distribution checks Use the VFS provided by D.getVFS() for all distribution checks, including those performing read of the release file.

Re: r284392 - Reapply r284383. The test failures were due to a missing dir in test/

On 17 October 2016 at 11:13, Krzysztof Parzyszek wrote: > That is crazy! You are right---git does not store empty directories. "SVN > co" worked fine for me, but "git clone" didn't. D: Oops, a bit of overlap. Thanks for fixing it more thoroughly than me! Tim.

Re: r284392 - Reapply r284383. The test failures were due to a missing dir in test/

That is crazy! You are right---git does not store empty directories. "SVN co" worked fine for me, but "git clone" didn't. D: Fixed in r284402. -Krzysztof On 10/17/2016 12:34 PM, Tim Northover wrote: Hi Krzysztof, This still seems to be failing on Darwin:

r284402 - Add a dummy file in each subdirectory in test/Driver/Inputs/hexagon_tree

Author: kparzysz Date: Mon Oct 17 13:04:05 2016 New Revision: 284402 URL: http://llvm.org/viewvc/llvm-project?rev=284402=rev Log: Add a dummy file in each subdirectory in test/Driver/Inputs/hexagon_tree Git does not store empty subdirectories (while SVN does). Git clone of the clang repository

r284401 - Hexagon: add dummy files to test dir so git keeps them.

Author: tnorthover Date: Mon Oct 17 13:00:27 2016 New Revision: 284401 URL: http://llvm.org/viewvc/llvm-project?rev=284401=rev Log: Hexagon: add dummy files to test dir so git keeps them. Should fix hexagon-elf-toolchain.c tests on Git. Added:

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

mgorny created this revision. mgorny added reviewers: bob.wilson, rengolin, rafael, ddunbar. mgorny added subscribers: cfe-commits, zlei. Herald added a subscriber: aemerson. Support the arm-hardfloat-*-*eabi triples used by Gentoo to signify hardfloat variants of ARM *EABI. Add tests for correct

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

On 14 October 2016 at 14:21, Eric Fiselier via cfe-commits wrote: > Could you give me more information about the compiler your using? Do you mostly build libcxx outside of a Clang source tree? I suspect the problem is that if Clang is built at the same time then

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Ok, great! LGTM https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25641: [Driver] Use VFS to perform all distribution checks

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks! LGTM! https://reviews.llvm.org/D25641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284400 - Fix a typo.

Author: adrian Date: Mon Oct 17 12:41:51 2016 New Revision: 284400 URL: http://llvm.org/viewvc/llvm-project?rev=284400=rev Log: Fix a typo. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Fwd: r198063 - Warn on mismatched parentheses in memcmp and friends.

[Re-send to correct addresses.] On Thu, Dec 26, 2013 at 3:38 PM, Nico Weber wrote: > Author: nico > Date: Thu Dec 26 17:38:39 2013 > New Revision: 198063 > > URL: http://llvm.org/viewvc/llvm-project?rev=198063=rev > Log: > Warn on mismatched parentheses in memcmp and

[PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284399: [clang-tidy] Clean up code after applying replacements. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D24572?vs=74160=74868#toc Repository: rL LLVM

Re: r284392 - Reapply r284383. The test failures were due to a missing dir in test/

Hi Krzysztof, This still seems to be failing on Darwin: /Users/tim/llvm/llvm/tools/clang/test/Driver/hexagon-toolchain-elf.c:9:14: error: expected string not found in input // CHECK000: "-cc1" {{.*}} "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include"

[clang-tools-extra] r284399 - [clang-tidy] Clean up code after applying replacements.

Author: alexfh Date: Mon Oct 17 12:25:02 2016 New Revision: 284399 URL: http://llvm.org/viewvc/llvm-project?rev=284399=rev Log: [clang-tidy] Clean up code after applying replacements. Summary: Remove empty namespaces and initializer list commas / colons in affected ranges. Initial patch: proper

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

jhen added a comment. Adding arron.ballman as a reviewer as alexfh seems to be on leave for a few weeks. https://reviews.llvm.org/D25450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bruno added a comment. Nice! Thanks https://reviews.llvm.org/D25597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21508: Make friend function template definition available if class is instantiated.

Ping. Thanks, --Serge 2016-10-13 11:51 GMT+07:00 Serge Pavlov : > sepavloff updated the summary for this revision. > > https://reviews.llvm.org/D21508 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

ABataev added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov added a comment. friendly ping https://reviews.llvm.org/D25258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

GorNishanov added a comment. @rsmith, I am wondering what were your thoughts on where to generate try { body } catch (...) { p.set_exception(std::exception()); } Would it be in SemaCoroutine.cpp? Essentially, add something like this: ` bool makeBody() { if (!OnException)

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

On 17 October 2016 at 09:11, Nico Weber via cfe-commits wrote: > Looks like things are still unexpectedly passing at r284389 on macOS (but we > currently only build and test libc++ on macOS, so maybe it's broken > elsewhere too). Green dragon is showing similar

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

[PATCH] D25621: DebugInfo: use DIAlignment type.

vleschuk marked an inline comment as done. vleschuk added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; vleschuk wrote: > aprantl wrote: > >

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

mgorny added a reviewer: beanz. mgorny added a comment. A gentle ping here. https://reviews.llvm.org/D23745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

ABataev added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

Looks like things are still unexpectedly passing at r284389 on macOS (but we currently only build and test libc++ on macOS, so maybe it's broken elsewhere too). https://codereview.chromium.org/2429533002/

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

kparzysz added a comment. I committed https://reviews.llvm.org/rL284383 and the Hexagon bot is passing now. (The patch was reverted, but then it was recommitted.) https://reviews.llvm.org/D25597 ___ cfe-commits mailing list

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

Agreed. We should define them as aliases to existing options without -plugin-opt. On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Nice to see this land! > > One nit: > Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a >

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

On 17 October 2016 at 08:36, Haojian Wu wrote: > Sorry for the trouble and delay (I missed this email previously). No worries. I thought that might be what had happened, the weekend deluge can hide anything. > Should be fixed in r284391. Thanks. Tim.

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

ABataev added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

  1   2   >