[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 398314. janosimas added a comment. Herald added a subscriber: carlosgalvezp. I added a comment in the docs noting this is a breaking change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/

[PATCH] D116856: [docs] Fix documentation of -fstrict-float-cast-overflow after D115804.

craig.topper created this revision. craig.topper added reviewers: spatel, nikic. craig.topper requested review of this revision. Herald added a project: clang. Previously this was documented as having the behavior of the "target's native float-to-int conversion". After D115804

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda updated this revision to Diff 398310. kda added a comment. add 3 parameter constructor for MemorySanitizerOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116634/new/ https://reviews.llvm.org/D116634 Files:

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/MemorySanitizer.h:28 bool Recover; + bool EagerChecks; }; vitalybuka wrote: > maybe we should use CheckParamRetVal something here? > How about EagerChecksRequested?

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 398308. owenpan added a comment. - Rebased to `main`. - Removed unused code. - Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

kda updated this revision to Diff 398303. kda marked 2 inline comments as done. kda added a comment. Reworked for comments and to be llvm only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116634/new/ https://reviews.llvm.org/D116634 Files:

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd97025ad3a70: [clang-format][NFC] Fix a bug in

[clang] d97025a - [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

Author: owenca Date: 2022-01-07T21:12:18-08:00 New Revision: d97025ad3a70c322843232036e2a11598b9fb9a6 URL: https://github.com/llvm/llvm-project/commit/d97025ad3a70c322843232036e2a11598b9fb9a6 DIFF: https://github.com/llvm/llvm-project/commit/d97025ad3a70c322843232036e2a11598b9fb9a6.diff LOG:

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added a comment. Block pointers are actually data pointers and should stay in the generic address space. I... don't honestly know why they get lowered as function pointers; they probably shouldn't be. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/

[clang] 5be1319 - [NFC] Test commit.

Author: Jun Zhang Date: 2022-01-08T10:36:09+08:00 New Revision: 5be131922cb78b4d1ff9bbfe4f524261c12f9cf8 URL: https://github.com/llvm/llvm-project/commit/5be131922cb78b4d1ff9bbfe4f524261c12f9cf8 DIFF: https://github.com/llvm/llvm-project/commit/5be131922cb78b4d1ff9bbfe4f524261c12f9cf8.diff

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

LegalizeAdulthood updated this revision to Diff 398281. LegalizeAdulthood edited the summary of this revision. LegalizeAdulthood added a comment. Add more test cases and improve the Lexing state machine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116425/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. In D114639#3228704 , @rnk wrote: > In D114639#3199458 , @RKSimon wrote: > >> @rnk I'm not certain but I think the only buildbot still using VS2017 is >> windows-gcebot2 ? > > Yes, it

[PATCH] D116827: Don't pass uninitialized QueryKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG244dd2913a43: Dont pass uninitialized QueryKind (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/

[clang-tools-extra] 244dd29 - Don't pass uninitialized QueryKind

Author: Vitaly Buka Date: 2022-01-07T17:14:08-08:00 New Revision: 244dd2913a43a200f5a6544d424cdc37b771028b URL: https://github.com/llvm/llvm-project/commit/244dd2913a43a200f5a6544d424cdc37b771028b DIFF: https://github.com/llvm/llvm-project/commit/244dd2913a43a200f5a6544d424cdc37b771028b.diff

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeeff8a37c35: [llvm] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:1 include(GNUInstallDirs) N.B. this already had it from an earlier revision of mine, so didn't need to add it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka updated this revision to Diff 398271. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D116844: [Driver][Fuchsia] -r: imply -nostdlib like GCC

MaskRay created this revision. MaskRay added a reviewer: phosek. Herald added a subscriber: abrachet. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D116843 . Repository: rG LLVM

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added a comment. OK, at long last, I this is the attempt that's gonna make it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___ cfe-commits

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

MaskRay created this revision. MaskRay added reviewers: thesamesam, phosek. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See `gcc -dumpspecs` that -r essentially implies -nostdlib and suppresses default -l* and crt*.o. The

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; kda wrote: > kda wrote: > > MaskRay wrote: > > > MaskRay wrote: >

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 398266. kda added a comment. refined rendering of help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

rnk added a comment. In D114639#3199458 , @RKSimon wrote: > @rnk I'm not certain but I think the only buildbot still using VS2017 is > windows-gcebot2 ? Yes, it probably uses VS2017, and probably also the sanitizer-windows bot as well:

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; kda wrote: > MaskRay wrote: > > MaskRay wrote: > > > `--help`

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 398263. kda added a comment. adjust help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda marked 2 inline comments as done. kda added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "Detect uninitialized parameters and return values.">>, +Group; MaskRay wrote: > MaskRay

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

rnk added a comment. However, do we need to make changes to `llvm::UpgradeDataLayoutString`? Otherwise, I believe old bitcode for MSVC targets will no longer be able to be loaded for LTO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

rnk added a comment. In D115942#3227047 , @pengfei wrote: > In D115942#3226146 , @rnk wrote: > >> Yeah, let's try to reach some resolution on that. > > The things are different. We don't support f80 type on

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; vitalybuka wrote: > kda wrote: > > It seems like the first line of 'findImplementors' is 'if (IDs.empty() || > > !Index)`. > > I wonder if

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

rnk added a comment. I think it's worth taking the time to hook up /ZH. Sorry we missed the patch last March. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116835/new/ https://reviews.llvm.org/D116835

[PATCH] D116828: Initialize HighlightingsBuilder::Resolver

This revision was automatically updated to reflect the committed changes. Closed by commit rG669eb6004670: Initialize HighlightingsBuilder::Resolver (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116828/new/

[clang-tools-extra] 669eb60 - Initialize HighlightingsBuilder::Resolver

Author: Vitaly Buka Date: 2022-01-07T15:21:22-08:00 New Revision: 669eb60046706c096d4d7804359670f3ca18ed7a URL: https://github.com/llvm/llvm-project/commit/669eb60046706c096d4d7804359670f3ca18ed7a DIFF: https://github.com/llvm/llvm-project/commit/669eb60046706c096d4d7804359670f3ca18ed7a.diff

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

sammccall added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1955 + bool IsPrivateHeader; + SmallString<128> FrameworkName, IncludeSpelling; + if (BestPrefixIsFramework && sammccall wrote: > nit: I don't think these strings need to be so big,

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1955 + bool IsPrivateHeader; + SmallString<128> FrameworkName, IncludeSpelling; + if (BestPrefixIsFramework &&

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall added a comment. Anything left to do here? I think it would be nice to get this into 14 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 ___

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

rsmith added a comment. This is CWG issue 2351. Please add a corresponding test to `tests/CXX/drs/dr23xx.cpp`. Comment at: clang/lib/Sema/SemaInit.cpp:1311-1319 + } else if (DeclType->isVoidType()) { +// [expr.type.conv]p2: Otherwise, if the type is cv void and the +

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:311 llvm::StringRef MainFilePath) { if (IDs.empty() || !Index) return {}; here Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228594 , @vitalybuka wrote: > In D116827#3228524 , @kda wrote: > >> This seems to introduce a new branch, should there be a new unit test in: >> XRefsTests.cpp? > > It's

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3173 + AssociatedOffloadKind); +AL.clear(); +// Offload the host object to the host linker. Doing `clear()` in a function intended to append looks suspicious.

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

jyu2 updated this revision to Diff 398249. jyu2 added a comment. Fix format problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/ https://reviews.llvm.org/D116764 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228524 , @kda wrote: > This seems to introduce a new branch, should there be a new unit test in: > XRefsTests.cpp? It's not functional change, test should not be able to see a difference after this patch.

[PATCH] D116713: [clangd] Support configuration of inlay hints.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:51 bool VisitCXXConstructExpr(CXXConstructExpr *E) { +if (!Cfg.InlayHints.DeducedTypes) + return true; hokein wrote: > this should be

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan added a comment. In D116272#3228427 , @tstellar wrote: > We may have time to fit it in to the release, but no guarantees. Can you > file an issue for this? That would be great. I filed an issue:

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d2977ff236: [-fms-extensions] Make some exception specification warnings/errors compatible… (authored by akhuang). Repository: rG LLVM Github

[clang] 28d2977 - [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

Author: Amy Huang Date: 2022-01-07T14:42:16-08:00 New Revision: 28d2977ff236dffa2a955714aee86e798ca9acd9 URL: https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9 DIFF: https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9.diff

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently when -fgpu-rdc is specified, HIP toolchain always does host linking even if --cuda-device-only is specified. This patch fixes that. Only device linking is performed when

[PATCH] D116827: Don't pass uninitialized QueryKind

kda requested changes to this revision. kda added a comment. This revision now requires changes to proceed. I think I forgot to 'Request Changes'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added a comment. This seems to introduce a new branch, should there be a new unit test in: XRefsTests.cpp? Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; It seems like the first line of 'findImplementors' is

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a604fdbcd5f: [Clang][CFG] check children statements of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[clang] 3a604fd - [Clang][CFG] check children statements of asm goto

Author: Nick Desaulniers Date: 2022-01-07T14:11:08-08:00 New Revision: 3a604fdbcd5fd9ca41f6659692bb4ad2151c3cf4 URL: https://github.com/llvm/llvm-project/commit/3a604fdbcd5fd9ca41f6659692bb4ad2151c3cf4 DIFF:

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:636-638 +unsigned AS = PointeeType->isFunctionTy() + ? getDataLayout().getProgramAddressSpace() + : Context.getTargetAddressSpace(ETy);

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 398231. owenpan added a comment. - Use `verifyFormat` instead of `EXPECT_EQ`. - Make this option have less impact on the unwrapped line parser by checking `Style.RemoveBracesLLVM`. - Remove some unused code. CHANGES SINCE LAST ACTION

[PATCH] D116713: [clangd] Support configuration of inlay hints.

sammccall updated this revision to Diff 398228. sammccall marked 2 inline comments as done. sammccall added a comment. Simplify & fix category checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116713/new/ https://reviews.llvm.org/D116713

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

tstellar added a comment. We may have time to fit it in to the release, but no guarantees. Can you file an issue for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

jyu2 accepted this revision. jyu2 added a comment. Looks good to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059 ___ cfe-commits mailing list

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan added a comment. Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272

[PATCH] D116585: Fix wrong JS import linebreak

futuarmo abandoned this revision. futuarmo added a comment. Issue was fixed by other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116585/new/ https://reviews.llvm.org/D116585 ___ cfe-commits

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1da5f3c2d65: [lld] Deprecate using llvm-config to detect llvm installation (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

rsmith added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3784-3790 + if (auto *TD = dyn_cast(D)) { +// CXXDeductionGuideDecls reference the class template parameters so we need +// to make sure not to call this twice on the same template

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 398219. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files:

[PATCH] D116512: [clang-tidy] Limit non-Strict mode to public functions

mehdi_amini abandoned this revision. mehdi_amini added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:43 + a human reader, and there's basically no place for a bug to hide. On the other + hand for non-public functions, all

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

aprantl added a comment. How does this relate to the code in `llvm/utils/lldbDataFormatters.py` and should it be added there instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116113/new/ https://reviews.llvm.org/D116113

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood added a reviewer: JonasToth. LegalizeAdulthood added a comment. I'm adding the original author of this check as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116386/new/ https://reviews.llvm.org/D116386 ___

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood added a comment. In D116386#3227236 , @aaron.ballman wrote: > We're in strong agreement that guideline checkers with untenable false > positive rates are a > very bad thing. I think this particular check is of insufficient quality to

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 ___

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-redundant-void-arg.cpp:561 +#define return_t(T) T +return_t(void) func(void); +// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: redundant void argument list in function

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

arlosi added a comment. I submitted a change last year to hook up the /ZH option, but it was never completed. https://reviews.llvm.org/D98438 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116835/new/ https://reviews.llvm.org/D116835

[PATCH] D116521: [CMake] Factor out config prefix finding logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44e336577510: [CMake] Factor out config prefix finding logic (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 44e3365 - [CMake] Factor out config prefix finding logic

Author: John Ericson Date: 2022-01-07T20:16:18Z New Revision: 44e3365775101fec3fd355eda339282258d74415 URL: https://github.com/llvm/llvm-project/commit/44e3365775101fec3fd355eda339282258d74415 DIFF: https://github.com/llvm/llvm-project/commit/44e3365775101fec3fd355eda339282258d74415.diff LOG:

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans added a comment. After sending this, I realized we should probably have a test to make sure it gets all the way into the .o and .pdb files correctly... And, maybe we should hook up the /ZH flag? (https://docs.microsoft.com/en-us/cpp/build/reference/zh?view=msvc-170=true still says MD5 is

[PATCH] D116835: Use sha256 for source file debug info checksums with MSVC compat >= 1930

hans created this revision. hans added reviewers: thakis, rnk, arlosi. Herald added subscribers: dexonsmith, hiraditya. hans requested review of this revision. Herald added projects: clang, LLVM. >From the VS2022 release notes, it sounds like newer MSVC versions are using >SHA256 for these

[PATCH] D116521: [CMake] Factor out config prefix finding logic

beanz accepted this revision. beanz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 ___ cfe-commits mailing list

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. All the lsan tests, when run in lsan+asan mode, Deadlock in `StopTheWord` when creating the tracer thread... F21505206: image.png -> `check-lsan` gets stuck, due to all the deadlocking tests :( Could it be caused by asan

[PATCH] D116521: [CMake] Factor out config prefix finding logic

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seems like a cleanup to me, and consistent with D116524 . Soft-accept, but only if D116524 is accepted first.

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2872-2874 + if (FormatTok->is(tok::l_square)) +if (!tryToParseLambda()) + break; Fewer ifs and lines. Repository: rG LLVM Github Monorepo

[PATCH] D116834: [clang][dataflow] Change `transfer` function to update lattice element in place.

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2. ymandel requested review of this revision. Herald added a project: clang. Currently, the transfer function returns a new lattice element, which forces an unnecessary copy on processing each CFG statement. Repository:

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D115060#3227120 , @owenpan wrote: > Maybe option 4 for now So I can get it through. > and the refactoring

[PATCH] D116833: [clang][Sema] Disable -Wc++20-designator in system macros

carlosgalvezp added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7161 +!DiagnosedNestedDesignator && !DiagnosedMixedDesignator && +!getSourceManager().isInSystemMacro(FirstDesignator)) { Diag(FirstDesignator, getLangOpts().CPlusPlus20

[PATCH] D116833: [clang][Sema] Disable -Wc++20-designator in system macros

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7161 +!DiagnosedNestedDesignator && !DiagnosedMixedDesignator && +!getSourceManager().isInSystemMacro(FirstDesignator)) { Diag(FirstDesignator, getLangOpts().CPlusPlus20

[PATCH] D116833: [clang][Sema] Disable -Wc++20-designator in system macros

carlosgalvezp created this revision. carlosgalvezp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To be consistent with GCC. Fixes #52944. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116833 Files:

[PATCH] D116828: Initialize HighlightingsBuilder::Resolver

vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detected by msan with: -Xclang

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Even if findImplementors does not

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 398195. serge-sans-paille added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei added inline comments. Comment at: llvm/include/llvm/Analysis/ScalarFuncs.def:19 +TLI_DEFINE_SCALAR_MASS_FUNC("acosf", "__xl_acosf") +TLI_DEFINE_SCALAR_MASS_FUNC("__acosf_finite", "__xl_acosf") +TLI_DEFINE_SCALAR_MASS_FUNC("acos", "__xl_acos")

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan updated this revision to Diff 398192. egorzhdan added a comment. Remove accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116822/new/ https://reviews.llvm.org/D116822 Files: clang/include/clang/Basic/DarwinSDKInfo.h

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) t4c1 wrote: > tra wrote: > > We need to figure out how

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

pcc added a comment. I'm not aware of any of those places causing an actual problem though? The AST isn't a stable interface, and __builtin_dump_struct is for debugging purposes only. I would expect debug info consumers to be able to handle __va_list in the global namespace as this is the

[PATCH] D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

logan-5 created this revision. logan-5 added reviewers: njames93, aaron.ballman. logan-5 added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. This behavior was fixed for regular

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3204 if (StackProtectorLevel) { -CmdArgs.push_back("-stack-protector-buffer-size"); -// FIXME: Verify the argument is a valid integer. -

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

egorzhdan created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes the mapping between iOS & tvOS/watchOS versions more

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

davrec added a comment. > There are already two way more sophisticated (forgive me my bias) > implementations in Clang that are for checking if two statements or decls are > the same. > > 1. ODRHash, used in modules to discover ODR violations > 2. ASTStructuralEquivalenceContext, used in

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 398182. MuAlphaOmegaEpsilon added a comment. Rebased to more recent main branch, updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files:

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398179. saiislam marked an inline comment as done. saiislam added a comment. Added diagnostic remarks for when ISA trait is not selected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 398178. dgoldman added a comment. Don't suggest umbrella headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D116814: Accept string literal decay in conditional operator

estan updated this revision to Diff 398177. estan added a comment. Add entry in clang-tools-extra/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814 Files:

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @aganea Thanks for your help. I already did everything you wrote (I am however using the coreutils provided by Git). `check-asan` works on my new computer. I still don't know why it didn't work on my older one... I will try to get the lsan tests working (and

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan commandeered this revision. estan added a reviewer: fiesh. estan added a comment. I think we can close this one now that https://reviews.llvm.org/D116378 has landed though, since this revision was originally only about warnings in system macros case which is now solved (?) I'll

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

martong added a comment. In D114622#3200678 , @NoQ wrote: > These checks are almost 2000 lines of code each and it looks like all they do > is figure out if two statements are the same and we have a very flexible > reusable solution for this sort of

[PATCH] D116814: Accept string literal decay in conditional operator

estan created this revision. Herald added subscribers: carlosgalvezp, kbarton, nemanjai. estan edited the summary of this revision. estan edited the summary of this revision. estan edited the summary of this revision. estan edited the summary of this revision. estan updated this revision to Diff

  1   2   >