r284271 - [linux] When pre-reserving stack pages to work around broken address space

Author: rsmith Date: Fri Oct 14 14:51:36 2016 New Revision: 284271 URL: http://llvm.org/viewvc/llvm-project?rev=284271=rev Log: [linux] When pre-reserving stack pages to work around broken address space layout for PIE binaries, ask the OS how much stack space is already in use to avoid stack

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

jbangert removed rL LLVM as the repository for this revision. jbangert updated this revision to Diff 74737. Herald added subscribers: mgorny, beanz. https://reviews.llvm.org/D24997 Files: clang-tidy/utils/ASTUtils.cpp clang-tidy/utils/ASTUtils.h clang-tidy/utils/CMakeLists.txt

Re: [PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

I figured out make clang-tidy. Compiles now (the typedef was the wrong way around, and i never noticed because make with the default target continued to work). Updated the diff. On Fri, Oct 14, 2016 at 12:49 PM Julian Bangert wrote: > Apologies for the breakage. I

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bruno added a comment. Krzysztof, do you have a backtrace that you can paste here or point me to the buidbot stderr log? There's no point in looking for relative paths inside the VFS, it would be nice if we fix the root cause here. https://reviews.llvm.org/D25597

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

rjmccall added a comment. Sorry, no, just the one that takes an llvm::Value* instead of an Expr*. https://reviews.llvm.org/D25547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

kparzysz added a comment. Right on entry to the asserting function: (gdb) where #0 0x752b9870 in (anonymous namespace)::RedirectingFileSystem::lookupPath(llvm::sys::path::const_iterator, llvm::sys::path::const_iterator, (anonymous namespace)::Entry*) () from

r284277 - __builtin_fpclassify missing one int parameter

Author: davidsh Date: Fri Oct 14 15:43:37 2016 New Revision: 284277 URL: http://llvm.org/viewvc/llvm-project?rev=284277=rev Log: __builtin_fpclassify missing one int parameter Patch by Tania Albarghouthi. Differential Revision: https://reviews.llvm.org/D25480 Modified:

[PATCH] D25480: __builtin_fpclassify missing one int parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL284277: __builtin_fpclassify missing one int parameter (authored by davidsh). Changed prior to commit: https://reviews.llvm.org/D25480?vs=74377=74740#toc Repository: rL LLVM

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

UBSAN may not be replacing the function, but it is doing something weird at the codegen level. I looked into this a while ago but never sorted it out. Either way I'll clarify the comments and add the missing reset() calls. Unfortunately the tests still fail in the same way. On Fri, Oct 14, 2016

[libcxx] r284282 - Clarify XFAIL comments

Author: ericwf Date: Fri Oct 14 16:30:35 2016 New Revision: 284282 URL: http://llvm.org/viewvc/llvm-project?rev=284282=rev Log: Clarify XFAIL comments Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp

[PATCH] D23657: Remove some false positives when taking the address of packed members

joerg added a comment. It seems like on-stack arrays still don't work? #include struct test { uint32_t x; } __attribute__((__packed__)); int main(void) { struct test __attribute__((__aligned__(4))) a[4]; uint32_t *p32; p32 = [0].x; }

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284284 - Reinstate r284008 reverted in r284081, with two fixes:

Author: rsmith Date: Fri Oct 14 16:41:24 2016 New Revision: 284284 URL: http://llvm.org/viewvc/llvm-project?rev=284284=rev Log: Reinstate r284008 reverted in r284081, with two fixes: 1) Merge and demote variable definitions when we find a redefinition in MergeVarDecls, not only when we find one

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

inglorion updated this revision to Diff 74734. inglorion added a comment. - Removed unused header. https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index: test/CodeGenCXX/debug-info-ms-vbase.cpp

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bruno added a comment. One possible reason: remove_dots is called upon a path with a leading "..", which then gets appended in front of another path to form the absolute path. I'm taking a look right now to try to figure out if there's any code path that might lead to this.

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

kparzysz added a comment. dbgs showed that the path components were `.. target hexagon include`. The paths are constructed in lib/Driver/ToolChains.cpp, many are based on "getHexagonTargetDir". https://reviews.llvm.org/D25597 ___ cfe-commits

[PATCH] D19854: Define Contiki OS toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL284278: Define Contiki OS toolchain (authored by dlkreitz). Changed prior to commit: https://reviews.llvm.org/D19854?vs=70076=74741#toc Repository: rL LLVM https://reviews.llvm.org/D19854 Files:

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

kparzysz added a comment. The `..:target:hexagon:include:` is debug code printing all the path components, separated by :. https://reviews.llvm.org/D25597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

Hi Nico, Could you give me more information about the compiler your using? /Eric On Fri, Oct 14, 2016 at 1:21 PM, Nico Weber wrote: > This is breaking tests for me: > > Unexpected Passing Tests (4): > libc++ ::

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

inglorion updated this revision to Diff 74733. inglorion added a comment. @rnk's comments (thanks!) - Converted SeenTypes to a DenseSet. - Switched to getCodeGenOpts().EmitCodeView to check if we should emit the extra records. - Switched to using SeenTypes.count(...) != 0 to check if we've seen

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

Hi Haojian, On 14 October 2016 at 06:01, Haojian Wu via cfe-commits wrote: > + std::string GuardName(FileName); > + if (IsHeader) { > +std::replace(GuardName.begin(), GuardName.end(), '/', '_'); > +std::replace(GuardName.begin(), GuardName.end(), '.', '_');

r284272 - Implement no_sanitize_address for global vars

Author: dougk Date: Fri Oct 14 14:55:09 2016 New Revision: 284272 URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev Log: Implement no_sanitize_address for global vars Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r284278 - Define Contiki OS toolchain

Author: dlkreitz Date: Fri Oct 14 15:44:33 2016 New Revision: 284278 URL: http://llvm.org/viewvc/llvm-project?rev=284278=rev Log: Define Contiki OS toolchain Patch by Michael LeMay Differential revision: http://reviews.llvm.org/D19854 Modified: cfe/trunk/lib/Driver/Driver.cpp

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

erik.pilkington updated this revision to Diff 74738. erik.pilkington added a comment. This new patch renames `DelayedDiagnostic::DeprecationData` to `DelayedDiagnostic::AvailabilityData`, because now that it can hold information about deprecated, unavailable, and partial diagnostics. Thanks,

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

rsmith added a comment. I reverted this in r284081, and relanded with fixes described here as r284284. Comment at: lib/Sema/SemaDecl.cpp:9712 + + // Demote the newly parsed definition to a fake declaration. + if (!VDecl->isThisDeclarationADemotedDefinition())

r284285 - Add more swift calling convention tests

Author: arnolds Date: Fri Oct 14 16:55:56 2016 New Revision: 284285 URL: http://llvm.org/viewvc/llvm-project?rev=284285=rev Log: Add more swift calling convention tests Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c cfe/trunk/test/CodeGen/arm-swiftcall.c Modified:

Re: [libcxx] r249738 - Split out of .

On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Richard, > > I have a patch on top of your suggested patch from a year ago, that > break the cyclic dependency we're seeing, with this (and a few changes > to the SDK) we can bootstrap clang with

[libcxx] r284216 - Remove dead CMake target

Author: ericwf Date: Fri Oct 14 04:06:38 2016 New Revision: 284216 URL: http://llvm.org/viewvc/llvm-project?rev=284216=rev Log: Remove dead CMake target Modified: libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake libcxx/trunk/lib/CMakeLists.txt Modified:

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

ioeric updated this revision to Diff 74631. ioeric added a comment. - Separate assertions to get more information. https://reviews.llvm.org/D25597 Files: lib/Basic/VirtualFileSystem.cpp Index: lib/Basic/VirtualFileSystem.cpp

[PATCH] D25565: Deduplicate sets of replacements by file names.

ioeric updated this revision to Diff 74634. ioeric added a comment. - Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565 - Forgot to update names in tests... https://reviews.llvm.org/D25565 Files: include/clang/Tooling/Core/Replacement.h

[PATCH] D25598: [clang-move] Matching static class member more correctly.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D25598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284222 - Try to fix windows bot file path style failure caused by r284219.

Author: ioeric Date: Fri Oct 14 05:10:26 2016 New Revision: 284222 URL: http://llvm.org/viewvc/llvm-project?rev=284222=rev Log: Try to fix windows bot file path style failure caused by r284219. Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp Modified:

[PATCH] D25606: alpha.core.UnreachableCode - don't warn about unreachable code inside macro

danielmarjamaki created this revision. danielmarjamaki added reviewers: NoQ, dcoughlin. danielmarjamaki added subscribers: cfe-commits, xazax.hun, zaks.anna, a.sidorin. danielmarjamaki set the repository for this revision to rL LLVM. This patch fixes false positives for such code: #define

r284213 - [x86][ms-inline-asm] use of "jmp short" in asm is not supported

Author: mzuckerm Date: Fri Oct 14 03:13:27 2016 New Revision: 284213 URL: http://llvm.org/viewvc/llvm-project?rev=284213=rev Log: [x86][ms-inline-asm] use of "jmp short" in asm is not supported Test linked to: https://reviews.llvm.org/D24957 Committing in the name of Ziv Izhar: After check-all

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. timshen added a subscriber: cfe-commits. Fixes PR21597. https://reviews.llvm.org/D25595 Files: libcxx/include/regex libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp Index:

[PATCH] D25576: Add 64-bit MS _Interlocked functions as builtins again

mstorsjo added a comment. > (should they be also on AArch64? I had problems with testing it for AArch64, > so I left it) Technically, I think they should be on AArch64 as well. But clang/LLVM probably doesn't support AArch64/Windows yet (I guess?), so testing it probably is impossible.

[PATCH] D24958: Test linked to D24957

This revision was automatically updated to reflect the committed changes. Closed by commit rL284213: [x86][ms-inline-asm] use of "jmp short" in asm is not supported (authored by mzuckerm). Changed prior to commit: https://reviews.llvm.org/D24958?vs=72624=74626#toc Repository: rL LLVM

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bkramer added a comment. I think the assertion is correct, there's something fishy with the inputs. The paths coming in should be absolute, and there should never be a .. at the start in a absolute path. This only fails on a single buildbot and doesn't reproduce anywhere else. @bruno any

[libcxxabi] r284217 - Mark test as unsupported without threads

Author: ericwf Date: Fri Oct 14 04:12:53 2016 New Revision: 284217 URL: http://llvm.org/viewvc/llvm-project?rev=284217=rev Log: Mark test as unsupported without threads Modified: libcxxabi/trunk/test/libcxxabi/test/config.py libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp

[PATCH] D25565: Deduplicate sets of replacements by file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284219: Deduplicate sets of replacements by file names. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25565?vs=74634=74636#toc Repository: rL LLVM

r284219 - Deduplicate sets of replacements by file names.

Author: ioeric Date: Fri Oct 14 04:32:06 2016 New Revision: 284219 URL: http://llvm.org/viewvc/llvm-project?rev=284219=rev Log: Deduplicate sets of replacements by file names. Summary: If there are multiple pairs with the same file path after removing dots, we only keep one

[PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 updated this revision to Diff 74638. rogfer01 added a comment. Updated patch, now we check if the innermost base of a MemberExpr is a DeclRefExpr and check for its declaration in case it provides stronger alignment guarantees. https://reviews.llvm.org/D23657 Files:

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

hokein created this revision. hokein added a reviewer: klimek. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25600 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Index:

[PATCH] D25565: Deduplicate sets of replacements by file names.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. I'd not rename the function. Otherwise looks good. https://reviews.llvm.org/D25565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

EricWF added a comment. I just spoke with Jonathan Wakely about this change, and he believes that it should be ABI safe. https://reviews.llvm.org/D25593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25596: alpha.core.Conversion - Fix false positive for 'U32 += S16; ' expression, that is not unsafe

danielmarjamaki created this revision. danielmarjamaki added a reviewer: NoQ. danielmarjamaki added subscribers: cfe-commits, xazax.hun, dcoughlin. danielmarjamaki set the repository for this revision to rL LLVM. This patch fix false positives for loss of sign in addition and subtraction

[libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

Author: ericwf Date: Fri Oct 14 03:47:09 2016 New Revision: 284214 URL: http://llvm.org/viewvc/llvm-project?rev=284214=rev Log: XFAIL aligned allocation tests for older Clang versions Modified: libcxx/trunk/test/libcxx/test/config.py

[PATCH] D25565: Deduplicate sets of replacements by file names.

ioeric updated this revision to Diff 74632. ioeric added a comment. - Change name to groupReplacementsByFile https://reviews.llvm.org/D25565 Files: include/clang/Tooling/Core/Replacement.h include/clang/Tooling/Refactoring.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp

[PATCH] D25598: [clang-move] Matching static class member more correctly.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25598 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/test.cpp test/clang-move/Inputs/test.h test/clang-move/move-class.cpp Index:

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev created this revision. v.g.vassilev added reviewers: chandlerc, rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25604 Files: lib/Driver/ToolChains.cpp Index:

[clang-tools-extra] r284221 - [clang-move] Matching static class member more correctly.

Author: hokein Date: Fri Oct 14 05:07:58 2016 New Revision: 284221 URL: http://llvm.org/viewvc/llvm-project?rev=284221=rev Log: [clang-move] Matching static class member more correctly. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25598 Modified:

[PATCH] D25598: [clang-move] Matching static class member more correctly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284221: [clang-move] Matching static class member more correctly. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25598?vs=74633=74650#toc Repository: rL LLVM

[libcxx] r284209 - Add void_t and invoke feature test macros

Author: ericwf Date: Fri Oct 14 02:19:52 2016 New Revision: 284209 URL: http://llvm.org/viewvc/llvm-project?rev=284209=rev Log: Add void_t and invoke feature test macros Added: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke_feature_test_macro.pass.cpp

[PATCH] D25586: [clang-move] Use cl::list and cl::CommaSeparated for the list of names.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rL LLVM https://reviews.llvm.org/D25586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Since `remove_dots` does not delete leading "../" anymore, assertion test need to be updated. https://reviews.llvm.org/D25597 Files: lib/Basic/VirtualFileSystem.cpp Index:

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath closed this revision. rmaprath added a comment. Committed as r284128. https://reviews.llvm.org/D24864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. This change breaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25625/steps/build%2032-bit%20symbolizer%20for%20compiler_rt_build/logs/stdio https://reviews.llvm.org/D24864 ___ cfe-commits mailing

[PATCH] D25572: [Coverage] Support for C++17 if initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL284293: [Coverage] Support for C++17 if initializers (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25572?vs=74559=74753#toc Repository: rL LLVM

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL284292: [Coverage] Support for C++17 switch initializers (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25539?vs=74552=74752#toc Repository: rL LLVM

r284292 - [Coverage] Support for C++17 switch initializers

Author: vedantk Date: Fri Oct 14 18:38:13 2016 New Revision: 284292 URL: http://llvm.org/viewvc/llvm-project?rev=284292=rev Log: [Coverage] Support for C++17 switch initializers Differential Revision: https://reviews.llvm.org/D25539 Added: cfe/trunk/test/CoverageMapping/switch.cpp -

r284293 - [Coverage] Support for C++17 if initializers

Author: vedantk Date: Fri Oct 14 18:38:16 2016 New Revision: 284293 URL: http://llvm.org/viewvc/llvm-project?rev=284293=rev Log: [Coverage] Support for C++17 if initializers Differential Revision: https://reviews.llvm.org/D25572 Added: cfe/trunk/test/CoverageMapping/if.cpp - copied,

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath added a comment. In https://reviews.llvm.org/D24864#570924, @vitalybuka wrote: > So there is: > > - Looking for __cxa_thread_atexit_impl in c > - Looking for __cxa_thread_atexit_impl in c - not found > > and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF I think, the problem

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. Maybe? - if (UNIX AND NOT (APPLE OR CYGWIN)) + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN)) list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp) endif() https://reviews.llvm.org/D24864 ___

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

Oh, I have another idea: could it be that you're also turning some optimization on when UBSan is enabled? Note that the operator new/operator delete pair is elidable in each of these tests, and Clang will remove the calls when compiling with optimizations enabled. That's it. The UBSAN tests build

[libcxx] r284289 - Prevent new/delete replacement tests from being optimized away.

Author: ericwf Date: Fri Oct 14 17:47:08 2016 New Revision: 284289 URL: http://llvm.org/viewvc/llvm-project?rev=284289=rev Log: Prevent new/delete replacement tests from being optimized away. Modified:

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

Thanks Richard. I've fixed the tests in r284289. On Fri, Oct 14, 2016 at 4:40 PM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Oh, I have another idea: could it be that you're also

[PATCH] D25586: [clang-move] Use cl::list and cl::CommaSeparated for the list of names.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284291: [clang-move] Use cl::list for the list of names (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D25586?vs=74599=74749#toc Repository: rL LLVM

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

vitalybuka added a comment. So there is: - Looking for __cxa_thread_atexit_impl in c - Looking for __cxa_thread_atexit_impl in c - not found and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF https://reviews.llvm.org/D24864 ___ cfe-commits

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath added a comment. In https://reviews.llvm.org/D24864#570935, @vitalybuka wrote: > Maybe? > > - if (UNIX AND NOT (APPLE OR CYGWIN)) > + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN)) > list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp) > endif() > Yes! I was

[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

sebpop accepted this revision. sebpop added a reviewer: sebpop. sebpop added a comment. This revision is now accepted and ready to land. This got approved in the past review. Let's commit it now that the clang bug was fixed. Thanks Aditya for keeping track of this.

[libcxxabi] r284294 - Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF

Author: vitalybuka Date: Fri Oct 14 18:51:41 2016 New Revision: 284294 URL: http://llvm.org/viewvc/llvm-project?rev=284294=rev Log: Don't compile cxa_thread_atexit.cpp with -DLIBCXX_ENABLE_THREADS=OFF Reviewers: rmaprath Subscribers: beanz, mgorny Differential Revision:

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bruno added a comment. Looks that somehow the current directory doesn't exit anymore OR it's non empty but only contains spaces or something like that. Besides the snippet below, RedirectingFileSystem::lookupPath(llvm::Twine const&) also calls `makeAbsolute` before `remove_dots`. Can you try

Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: > Author: emaste > Date: Fri Oct 14 12:59:53 2016 > New Revision: 284256 > > URL: http://llvm.org/viewvc/llvm-project?rev=284256=rev > Log: > Link static PIE programs against rcrt0.o on OpenBSD > > Patch by Stefan Kempf. >

r284300 - Disable a silly GCC diagnostic for combining a scanf length specifier with the

Author: rsmith Date: Fri Oct 14 20:59:52 2016 New Revision: 284300 URL: http://llvm.org/viewvc/llvm-project?rev=284300=rev Log: Disable a silly GCC diagnostic for combining a scanf length specifier with the '*' specifier. Apparently the GNU folks want to discourage self-documenting code.

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1650 +} + switch (Lifetime) { I think you can fold this a bit more. :) You have exactly the same switch statement below, and several of the cases are identical; for the others, you

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar created this revision. jlebar added reviewers: rsmith, tra. jlebar added a subscriber: cfe-commits. Herald added a subscriber: aemerson. In CUDA compilation, we call isInlineDefinitionExternallyVisible (via getGVALinkageForFunction) on functions while parsing their definitions. At the

[PATCH] D25568: [libcxx] [cmake] Use -print-libgcc-file-name option to find compiler runtime

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This doesn't seem right seeing as `print-libgcc_file-name` prints the `libgcc.a` path, and we were previously linking `libgcc_s`. https://reviews.llvm.org/D25568

r284228 - Removed duplicate header include

Author: ioeric Date: Fri Oct 14 06:48:10 2016 New Revision: 284228 URL: http://llvm.org/viewvc/llvm-project?rev=284228=rev Log: Removed duplicate header include Reviewers: ioeric Subscribers: klimek Patch by Krasimir Georgiev! Differential Revision: https://reviews.llvm.org/D25599 Modified:

[PATCH] D25610: [clang-move] Add header guard for the new header.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg Comment at: clang-move/ClangMove.cpp:264 +HeaderGuard += "#define " + GuardName + "\n"; +clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0, +

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005 +/// \endcode +AST_MATCHER(VarDecl, isStaticDataMember) { + return Node.isStaticDataMember(); How does this differ from

[clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

Author: hokein Date: Fri Oct 14 08:01:36 2016 New Revision: 284233 URL: http://llvm.org/viewvc/llvm-project?rev=284233=rev Log: [clang-move] Add header guard for the new header. Summary: The header guard generated by clang-move isn't always a perfect style, just avoid getting the header included

[PATCH] D25468: [libcxx] Do not declare the thread api when __external_threading is present

This revision was automatically updated to reflect the committed changes. Closed by commit rL284232: [libcxx] Do not declare the thread api when __external_threading is present (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D25468?vs=74234=74668#toc Repository: rL

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === ---

[clang-tools-extra] r284235 - [clang-tidy] Add additional diagnostic to misc-use-after-move

Author: mboehme Date: Fri Oct 14 08:23:39 2016 New Revision: 284235 URL: http://llvm.org/viewvc/llvm-project?rev=284235=rev Log: [clang-tidy] Add additional diagnostic to misc-use-after-move Summary: This adds a diagnostic to the misc-use-after-move check that is output when the use happens on a

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

This revision was automatically updated to reflect the committed changes. Closed by commit rL284235: [clang-tidy] Add additional diagnostic to misc-use-after-move (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D25612?vs=74671=74673#toc Repository: rL LLVM

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74675. hokein added a comment. woohoo, delete more code! https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++

[clang-tools-extra] r284236 - [clang-move] Don't overuse Replacements::add.

Author: hokein Date: Fri Oct 14 08:43:49 2016 New Revision: 284236 URL: http://llvm.org/viewvc/llvm-project?rev=284236=rev Log: [clang-move] Don't overuse Replacements::add. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25613 Modified:

[PATCH] D25608: [libclang] Make tests for python bindings pass on Windows.

ikudrin created this revision. ikudrin added reviewers: hansonw, compnerd, indygreg, eliben. ikudrin added a subscriber: cfe-commits. Please note that this patch fixes only Windows-related issues. https://reviews.llvm.org/D25470 is required to pass all the tests.

[PATCH] D25568: [libcxx] [cmake] Use -print-libgcc-file-name option to find compiler runtime

mgorny added a comment. In https://reviews.llvm.org/D25568#570222, @EricWF wrote: > This doesn't seem right seeing as `print-libgcc_file-name` prints the > `libgcc.a` path, and we were previously linking `libgcc_s`. Do you have any other solution in mind? There is no switch to print the

[PATCH] D25431: [libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues

mgorny added a comment. In https://reviews.llvm.org/D25431#570227, @EricWF wrote: > Why not just compile the sources files as C++ by changing their extensions? > This change seems all kinds of wrong because we're throwing away *all* of our > flags, including things like `-m32` or `-target `.

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

mboehme updated this revision to Diff 74671. mboehme added a comment. - Responses to reviewer comments https://reviews.llvm.org/D25612 Files: clang-tidy/misc/UseAfterMoveCheck.cpp test/clang-tidy/misc-use-after-move.cpp Index: test/clang-tidy/misc-use-after-move.cpp

[PATCH] D25610: [clang-move] Add header guard for the new header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284233: [clang-move] Add header guard for the new header. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25610?vs=74663=74669#toc Repository: rL LLVM

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:472 std::string FilePath = RemoveReplacement.getFilePath().str(); addOrMergeReplacement(RemoveReplacement, [FilePath]); For deletions, you can simply use `add`, which now simply

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74677. hokein added a comment. Delete one more function. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++

r284229 - Fix for PR30632: Name mangling issue.

Author: abataev Date: Fri Oct 14 07:43:59 2016 New Revision: 284229 URL: http://llvm.org/viewvc/llvm-project?rev=284229=rev Log: Fix for PR30632: Name mangling issue. There was a bug in the implementation of captured statements. If it has a lambda expression in it and the same lambda expression

[PATCH] D25431: [libcxx] Convert Solaris support library to C++ to fix -std=c++11 build

mgorny retitled this revision from "[libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues" to "[libcxx] Convert Solaris support library to C++ to fix -std=c++11 build ". mgorny updated the summary for this revision. mgorny updated this revision to Diff 74666. mgorny

[libcxx] r284230 - Disable Modules when building the libc++ sources.

Author: ericwf Date: Fri Oct 14 07:56:52 2016 New Revision: 284230 URL: http://llvm.org/viewvc/llvm-project?rev=284230=rev Log: Disable Modules when building the libc++ sources. Libc++ will not build with modules enabled. In order to support an in-tree libc++ when LLVM_ENABLE_MODULES is ON we

[PATCH] D25610: [clang-move] Add header guard for the new header.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:264 +HeaderGuard += "#define " + GuardName + "\n"; +clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0, + HeaderGuard); ioeric

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

emaste added inline comments. Comment at: lib/abi/CHANGELOG.TXT:22 + Although this change removes symbols, it should still be non-ABI breaking + since all of the definitions removed are inline functions. + Should we also include in this comment the further

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1044-1070 +static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) { + SmallVector Queue; + + while (true) { +for (const auto : Record->bases()) { + const RecordType *Ty =

  1   2   >