Re: [chromium-dev] code coverage on 3 platforms

2010-01-02 Thread Bradley Nelson
WOOT! On Thu, Dec 31, 2009 at 9:07 PM, John Grabowski j...@chromium.org wrote: I had an OKR to get code coverage working on 3 platforms for Chromium unit test bundles in Q409. If you're in PST, I made it! Dashboard (overview): http://build.chromium.org/buildbot/perf/dashboard/coverage.html

Re: [chromium-dev] Tryconsole

2009-12-28 Thread Bradley Nelson
I've finally tracked down why it was failing to detect some try jobs. I've corrected it. Let me know if anyone sees evidence to the contrary. -BradN On Tue, Dec 8, 2009 at 1:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
to base scare you enough that we should look at this again? -BradN On Mon, Dec 7, 2009 at 2:22 PM, Antoine Labour pi...@chromium.org wrote: On Mon, Dec 7, 2009 at 1:43 PM, Bradley Nelson bradnel...@google.comwrote: Hello All, Last week I re-landed a change to split off parts of chrome.gyp

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
You mean as 'base' currently is, or duplicating the file lists? -BradN On Tue, Dec 8, 2009 at 11:19 AM, Mark Mentovai m...@chromium.org wrote: I think that the stripped-down NaCl-specific 64-bit targets are the right thing to have happened to base, at least for now. Mark Brad Nelson

[chromium-dev] Tryconsole

2009-12-08 Thread Bradley Nelson
Hi All, I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username / builder / change name). The two summary graphs show load for the day, load

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Even if those files are largely a duplicate of those in base? -BradN On Tue, Dec 8, 2009 at 11:22 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: You mean as 'base' currently is, or duplicating the file lists? I mean I have no problem with base_nacl_win64 existing

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Greg, will this work for you? -BradN On Tue, Dec 8, 2009 at 11:28 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: Even if those files are largely a duplicate of those in base? If it gets to that point, we can maintain the sources list, or the shared sources list

Re: [chromium-dev] NaCl related build error

2009-12-01 Thread Bradley Nelson
Hi Antony, My fixes arrived at 33433. Did you sync that before trying the above? I hadn't validated command line builds (I'm checking that myself now). Oh by the way, I assume you're using /Out because of devenv.exe 's weird console piping behavior. Something we learned with the bots is that if

Re: [chromium-dev] NaCl related build error

2009-12-01 Thread Bradley Nelson
Hmmn, ok builds for me at the command line. I'll drop by in a bit. -BradN On Tue, Dec 1, 2009 at 11:00 AM, Bradley Nelson bradnel...@google.comwrote: Hi Antony, My fixes arrived at 33433. Did you sync that before trying the above? I hadn't validated command line builds (I'm checking

[chromium-dev] Re: How do I generate an msvs_guid for the GYP file?

2009-11-30 Thread Bradley Nelson
Actually, I just did some checking with laforge. He's told me something a little different. Apparently, he would prefer that we do explicitly pin the guids with msvs_guid. They still have some scripts which disable targets by guid. When he's firefighting on the release branch it is useful for him

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
, Darin Fisher da...@chromium.org wrote: Sounds like a good change, but did you consider putting these gypi files in the subdirectories? chrome/renderer/renderer.gypi, etc. seems like it would be nice. -Darin On Wed, Nov 18, 2009 at 7:02 PM, Bradley Nelson bradnel...@google.comwrote

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
, Bradley Nelson bradnel...@google.comwrote: Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi

Re: [chromium-dev] Splitting apart chrome.gyp

2009-11-19 Thread Bradley Nelson
I've talked it over with laforge. I'm gonna revert this for now, until m4 is out of the way. We'll try it again in ~2 weeks. Maybe I'll get those includes done the right way in gyp in the meantime. -BradN On Thu, Nov 19, 2009 at 10:02 AM, Bradley Nelson bradnel...@google.comwrote: It's been

Re: [chromium-dev] huge binary drop of native client code

2009-11-18 Thread Bradley Nelson
Arrgh. Sorry about that. There was some confusion as to which third_party directory those were suppose to go into (we really need to change gcl to base everything from the top of the world). Backing things out shortly. It didn't break nacl's trybots or waterfall because they're less pared down,

Re: [chromium-dev] huge binary drop of native client code

2009-11-18 Thread Bradley Nelson
: On Wed, Nov 18, 2009 at 4:43 PM, Bradley Nelson bradnel...@google.com wrote: Backing things out shortly. No rush; if you need the code, it's ok. (It'd be nice if you used deps_os though.) It didn't break nacl's trybots or waterfall because they're less pared down, and probably got

[chromium-dev] Splitting apart chrome.gyp

2009-11-18 Thread Bradley Nelson
Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi (renderer) chrome_tests.gypi (almost all tests) You

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-16 Thread Bradley Nelson
:51 PM, Bradley Nelson bradnel...@google.com wrote: Ok that fix is in. You'd need to set GYP_MSVS_VERSION=2008e Let me know how that goes for you. -BradN On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Updated http://sites.google.com

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Bradley Nelson
We do now have a mechanism to share a pool of tryslaves between multiple project types. For instance: gyp, nacl, o3d all share a common pool. This is on the 'experimental' tryserver.nacl master. Unlike the layout/valgrid/chromeos trybots on the main tryserver, this mechanism shares the same slaves

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-12 Thread Bradley Nelson
Ok that fix is in. You'd need to set GYP_MSVS_VERSION=2008e Let me know how that goes for you. -BradN On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel mar...@chromium.orgwrote: Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference

Re: [chromium-dev] Is it possible to configure/build chromium (linux) completely out of the source tree?

2009-11-11 Thread Bradley Nelson
You have two options. Both _may_ be working on linux, there is an outstanding issue to fix a problem (at least on windows) in the second: 1. You could muck with gyp_chromium locally and change it so -S some_suffix is passed in. All generated stuff gets a suffix inserted. 2. You can set

Re: [chromium-dev] Re: [gyp-developer] Coping with configurations differences in sources

2009-11-11 Thread Bradley Nelson
mmentovai, gregoryd and I met today. We've decided Option #1 is actually bad. I'm investigating Option #3 which is likely to be cleaner and seems to meet everyones needs. I'll be updating this review to that approach shortly. -BradN On Wed, Nov 11, 2009 at 5:48 PM, Marc-Antoine Ruel

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-10 Thread Bradley Nelson
This sounds great. I didn't know express chokes on folders. I'll investigate tomorrow and look into offering an option/autodetecting for gyp to emit a flat sln. -BradN On Tue, Nov 10, 2009 at 8:19 PM, Dan Kegel d...@kegel.com wrote: On Mon, Nov 9, 2009 at 6:21 PM, Dominic Jodoin

[chromium-dev] Coping with configurations differences in sources

2009-11-09 Thread Bradley Nelson
Hi Mark, So the nacl guys have a use case where they would be tempted to have per-configuration sources, if it were supported. Since this is particularly hairy for xcode, I wanted to see if you could offer some guidance as to how they should tackle this. Currently they are porting base + app to

[chromium-dev] Re: Coping with configurations differences in sources

2009-11-09 Thread Bradley Nelson
Greg can this work for you? On Nov 9, 2009 6:49 PM, Mark Mentovai m...@chromium.org wrote: (m...@chromium.org, please - that's the address that I can post to mailing lists from.) There was a chromium-dev thread on this on Friday.

[chromium-dev] Re: Circular relationship in NaCl .gyp files - this is bad!

2009-11-05 Thread Bradley Nelson
Some further info on this topic: There are circular dependencies in nacl, but the reason this does not afflict the buildbots is that xcode will handle this correctly IF you CMD-Q out of xcode before regenerating the project file. We should nonetheless fix the circularity and then have gyp

[chromium-dev] Re: Inheritance in gyp configurations

2009-11-03 Thread Bradley Nelson
. Wong (王重傑) ajw...@chromium.orgwrote: On Mon, Nov 2, 2009 at 3:37 PM, Bradley Nelson bradnel...@google.comwrote: S,o as it happens, I just had someone on nacl make the first use of multiple inheritance this morning. He hasn't checked it in yet, but the use case is: 'Common': { # bunch

[chromium-dev] Re: Inheritance in gyp configurations

2009-11-01 Thread Bradley Nelson
idea. It's supported largely as a side effect of normal gyp expansion. If you feel strongly, we could take it out. I'm on the fence as to whether its dangerous in the unusual context in which it applies to gyp. Let me know. :-) -BradN -Albert On Thu, Oct 29, 2009 at 5:42 PM, Bradley Nelson

[chromium-dev] Re: Inheritance in gyp configurations

2009-11-01 Thread Bradley Nelson
Brad, we can still inherit from non-abstract configurations, right? This might be useful... yes, we can, and it would Mark Bradley Nelson wrote: configurations can now inherit from one or more other configurations, and configurations which are not fully expressed should be marked

[chromium-dev] Inheritance in gyp configurations

2009-10-29 Thread Bradley Nelson
Hi All, I've just rolled out an enhancement to gyp to support inheritance in configurations. This shouldn't have any noticeable effect other than reducing the repetition needed for things like Purify/notcmalloc. I've tested it as best I can, but please let me know if you experience anything

[chromium-dev] Re: Inheritance in gyp configurations

2009-10-29 Thread Bradley Nelson
': ['Common'], # Debug specific }, 'Release': { 'inherit_from': ['Common'], # Release specific }, }, -BradN On Thu, Oct 29, 2009 at 5:37 PM, Nick Carter n...@chromium.org wrote: What does the syntax look like? - nick On Thu, Oct 29, 2009 at 3:22 PM, Bradley Nelson bradnel

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Bradley Nelson
So we have set of tests for gyp which are green for all the generators other than make. I believe mmoss has been whittling away on them, and I think its down to just 2 failures. go/gypbot After that its just a matter of the will to switch over the buildbots and fix any unforeseen issues. -BradN

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Bradley Nelson
Looks like the failures are part of the same test case. It's the case where the same source file is built as part of two different targets using different defines. The make generator appears to build it only one way and use it in both targets. -BradN 2009/10/28 Bradley Nelson bradnel

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Bradley Nelson
to the casual developers like while we get our ducks in line. -Albert 2009/10/28 Bradley Nelson bradnel...@google.com Looks like the failures are part of the same test case. It's the case where the same source file is built as part of two different targets using different defines. The make

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Bradley Nelson
Michael, The variables handling in gyp definitely needs to be settled, but to get people going with this, I've sent you a change that should resolve this particular case (though it is moderately redundant). -BradN On Wed, Oct 21, 2009 at 12:58 PM, Michael Moss mm...@chromium.org wrote: To

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Bradley Nelson
That's http://codereview.chromium.org/295044 for reference. On Wed, Oct 21, 2009 at 1:06 PM, Bradley Nelson bradnel...@google.comwrote: Michael, The variables handling in gyp definitely needs to be settled, but to get people going with this, I've sent you a change that should resolve

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Bradley Nelson
Nacl/O3d*trybots seem ok on a restart.-BradN On Mon, Oct 12, 2009 at 8:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Mon, Oct 12, 2009 at 7:58 AM, Thomas Van Lenten thoma...@chromium.orgwrote: On Mon, Oct 12, 2009 at 10:45 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On

[chromium-dev] Re: Extracting Webkit Test Shell and its dependencies

2009-10-02 Thread Bradley Nelson
Also you should get webkit/tools/tests_shell.sln -BradN On Thu, Oct 1, 2009 at 10:45 AM, Peter Kasting pkast...@google.com wrote: On Wed, Sep 30, 2009 at 4:06 AM, plafayette pierre.lafaye...@gmail.comwrote: Is there a good, and less painful, way to extract test_shell into its own project?

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Bradley Nelson
The idea is that nacl will be baked in, and eventually be active by default.They've pared things down a good bit already. How far out of the ballpark is this on size? -BradN On Tue, Sep 29, 2009 at 12:45 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: you need to edit your .gclient and

[chromium-dev] Re: FYI, project cruft

2009-09-28 Thread Bradley Nelson
direct_dependent_setting is not transitive by design. This was intended to discourage targets from inheriting an ever growing list of header from their dependencies. In the case were a module does not fully encapsulate its dependencies, there aretwo syntaxes that are currently supported that can

[chromium-dev] Re: FYI, project cruft

2009-09-28 Thread Bradley Nelson
One further point of clarification: gyp depends != msvs dependencies For example if in gyp you have: progA -- libB -- libC In msvs you will get: progA -- libB progA -- libC (unless as mark mentioned hard_dependency is used) -BradN So in terms of missed parallelism the current behavior should

[chromium-dev] Re: FYI, project cruft

2009-09-28 Thread Bradley Nelson
Ignore everything below the -BradN in my last message. (mmentovai beat me to the punch on replying :-) ) -BradN On Mon, Sep 28, 2009 at 3:23 PM, Bradley Nelson bradnel...@google.comwrote: One further point of clarification: gyp depends != msvs dependencies For example if in gyp you have

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

2009-09-23 Thread Bradley Nelson
I'll look into it. Sorrry, we added support for setting the default run target, but it has to create a per user config file. -BradN On Wed, Sep 23, 2009 at 1:55 PM, Jeremy Orlow jor...@google.com wrote: On Wed, Sep 23, 2009 at 1:43 PM, John Abd-El-Malek j...@chromium.orgwrote: I've seen this

[chromium-dev] .grd files

2009-09-18 Thread Bradley Nelson
Hi All, If you don't modify .grd files, strings or resources, you can stop reading. So it's come to my attention that due to prior flakiness in the build it's become common practice for people to make whitespace changes in .grd files when anything changes in their dependencies. Some time last

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-09-14 Thread Bradley Nelson
If no one objects, I've been thinking of changing this to be:1. If you have only VS2005, use that 2. If you have only VS2008, use that 3. If you have both or neither use 2005 This would continue to be overridden by GYP_MSVS_VERSION or GYP_DEFINES=-Dmsvs_version Sound ok? -BradN On Mon, Sep 14,

[chromium-dev] Re: How to extract .sln and .vcproj files from chrome.gyp

2009-09-04 Thread Bradley Nelson
Any kind of output at all to the console?So for instance you don't see src/chrome/chrome.sln? -BradN On Thu, Sep 3, 2009 at 5:45 AM, 子朝 王 wzcpri...@gmail.com wrote: Hello! How to extract .sln and .vcproj files from chrome.gyp? I have added depot_tools, python bin, svn to my PATH, but when

[chromium-dev] Re: detect problems with resources right away

2009-09-03 Thread Bradley Nelson
Hi Pawel, I'm in the process of landing a change which will add grit_info.py, which will let you list all of the inputs and outputs from a .grd file. Initially I'll be using the inputs to fix some of the dependencies. Does this cover your concerns? http://codereview.chromium.org/197007/show

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Bradley Nelson
That one is know (we have a gyp issue filed from a while back).The problem is that visual studio doesn't detect command line changes (well actually it does as long as you do them in the IDE and don't leave the sln). We believe we can 'fix' this limitation by having gyp emit a file containing

[chromium-dev] Re: Clobbering

2009-08-11 Thread Bradley Nelson
We currently have a hack of sorts in mind (well an issue filed on gyp) that would cover a larger class of settings changes (the worst handled by vstudio directly). The idea is to have gyp generate a text file full of settings garp which would be an additional dependency of each project. There are

[chromium-dev] Re: Clobbering

2009-08-11 Thread Bradley Nelson
Ok I think I've found it.It looks like a bug in the rule - makefile emitter which is only used for webcore. (Most gyp rules turn into custom build rules, but we added a makefile emitter option for this one because the native rules were too slow). It appears that the custom build step for the

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-10 Thread Bradley Nelson
Solutions or Projects to always save line endings in LF generated via gyp. -- Mohamed Mansour On Fri, Aug 7, 2009 at 1:48 AM, Bradley Nelson bradnel...@google.comwrote: Yeah we should certainly handle this better.This was a known thing, but I've called it out in this gyp issue: http

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Bradley Nelson
Yes Mohamed, please do. Which files had the dos line endings?We should really add a presubmit check... -BradN On Thu, Aug 6, 2009 at 9:22 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Ah thank you Dan! It worked! I guess I should commit the line ending then? -- Mohamed Mansour On

[chromium-dev] Re: my patch fails compile on try servers because png file isn't updated?

2009-07-31 Thread Bradley Nelson
I believe the tryserver doesn't take binaries.-BradN On Fri, Jul 31, 2009 at 5:40 PM, Tim Steele t...@chromium.org wrote: My patch http://codereview.chromium.org/159728 keeps failing to compilehttp://build.chromium.org/buildbot/try-server/builders/win/builds/12301/steps/compile/logs/stdio

[chromium-dev] Re: Mini Installer Build issues

2009-07-23 Thread Bradley Nelson
This kind of error tends to occur if gyp regenerates the project while you are in visual studio.Very often if you close and reopen the solution the problem will go away. Unfortunately hitting yes to project/sln reload does not seem to be equivalent in all cases to a full close and reopen. -BradN

[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp

2009-07-17 Thread Bradley Nelson
Sorry about the confusion, yes Thomas is correct, gyp_dogfood did recently get renamed to gyp_chromium.(Stale client...) Interesting that GYP_MSVS_VERSION=2005 was actually required (as that should be the default currently). The docs definitely need another pass. :-) -BradN On Fri, Jul 17, 2009

[chromium-dev] Re: How to Generate Visual Studio .SLN file from gyp

2009-07-16 Thread Bradley Nelson
I'm puzzled why src/tools/gyp/gyp_chromium is getting used, as src/tools/gyp/gyp_dogfood is what I would expect.What shows up at the bottom of src/DEPS? (in the run hook) -BradN On Thu, Jul 16, 2009 at 10:53 AM, Thomas Van Lenten thoma...@chromium.orgwrote: sync again, it sounds like your src

[chromium-dev] Re: vs2008 and gyp

2009-07-15 Thread Bradley Nelson
. -BradN On Wed, Jul 15, 2009 at 10:34 PM, Thiago Farina thiago.far...@gmail.comwrote: Is safe to try this option? Nothing will be broken? Where I can set this variable? On Jun 4, 3:40 pm, Bradley Nelson bradnel...@google.com wrote: Hi All, If you don't have Visual Studio 2008 installed you

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-07-13 Thread Bradley Nelson
test_support_unit - Debug Win32 test_support_ui - Debug Win32 codesighs (third_party\codesighs\codesighs) - Debug Win32 automated_ui_tests - Debug Win32 memory_test - Debug Win32 activex_test_control - Debug Win32 On Thu, Jun 18, 2009 at 4:08 PM, Bradley

[chromium-dev] Re: help with gyp?

2009-07-09 Thread Bradley Nelson
Sounds like you're looking for an 'actions' or 'rules'.Look at src/webkit/webkit.gyp or src/chrome/chrome.gyp On Thu, Jul 9, 2009 at 11:12 AM, Mike Mammarella m...@chromium.org wrote: Hi all, I'm trying to add a file which needs to be processed autoconf-style at compile time. It's a script

[chromium-dev] Re: Updating Rietveld by replying to codereview emails

2009-07-07 Thread Bradley Nelson
Excellent! On Jul 6, 2009 9:43 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: This is the best news I've heard in the last week. Thank you, Thank you, Thank you. -- Elliot On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malekj...@chromium.org wrote: Just a heads up that y...

[chromium-dev] Re: Some projects are always out of date

2009-07-05 Thread Bradley Nelson
In the case of cygwin and lastchange I think know what's going on, and unfortunately these currently expect to always get built. The cygwin case is so that setup_mount gets run before anything else and it unfortunately wants to run every time. It's used to poke the registry to prepare the

[chromium-dev] Re: cygwin dependence missing?

2009-07-01 Thread Bradley Nelson
If you're hitting overflows, it might be from the native client landing, which ended up dragging in more than intended, its been backed out, but it was an extra 300MB. gyp should be setting CYGWIN=nontsec for actions and rules (unless you use the msvs_use_cygwin_shell:0). -BradN 2009/7/1 David

[chromium-dev] Re: Should GYP files be UTF8 Encoded?

2009-06-29 Thread Bradley Nelson
was just creating a new GYP file and wanted to know what encoding to save the file as...that's all :-) On Jun 26, 10:52 pm, Bradley Nelson bradnel...@google.com wrote: The intention was ascii AFAIK. Unless someone has a use case? -BradN On Fri, Jun 26, 2009 at 3:05 PM, Daniel Cowx

[chromium-dev] Re: How do I *undefine* a define in GYP?

2009-06-27 Thread Bradley Nelson
You can undefine items with: 'defines!: [ 'WIN32_LEAN_AND_MEAN', ], -BradN On Sat, Jun 27, 2009 at 1:47 PM, Daniel Cowx daniel.c...@gmail.com wrote: Okay, I've figured out that I can do: snip 'msvs_settings': { 'VCCLCompilerTool': { 'UndefinePreprocessorDefinitions':

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-06-27 Thread Bradley Nelson
memory_test - Debug Win32 activex_test_control - Debug Win32 On Thu, Jun 18, 2009 at 4:08 PM, Bradley Nelson bradnel...@google.com wrote: Andrew, can you give an example of something that built that shouldn't have for test_shell? Maybe we have some overspecified dependencies

[chromium-dev] Re: Should GYP files be UTF8 Encoded?

2009-06-26 Thread Bradley Nelson
The intention was ascii AFAIK. Unless someone has a use case? -BradN On Fri, Jun 26, 2009 at 3:05 PM, Daniel Cowx daniel.c...@gmail.com wrote: Not that I'm aware of. Just wanted to confirm that intention is ASCII for now unless need arises. On Jun 26, 2:18 pm, Dan Kegel

[chromium-dev] Re: How do you do an if-else statement in GYP?

2009-06-24 Thread Bradley Nelson
Hi Daniel: Currently you'd have to have another whole conditional inside: 'conditions': [ ['my_variable==Blort', { # path A }, { 'conditions: ['my_variable==Blat', { # path B }, { # path C (default) }], }], -BradN On Wed, Jun 24, 2009 at 2:49 PM, Daniel

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-06-19 Thread Bradley Nelson
activex_test_control - Debug Win32 On Thu, Jun 18, 2009 at 4:08 PM, Bradley Nelson bradnel...@google.com wrote: Andrew, can you give an example of something that built that shouldn't have for test_shell? Maybe we have some overspecified dependencies as well. -BradN On Thu, Jun

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-06-19 Thread Bradley Nelson
-7D059D26064E} Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = test_shell, ..\webkit\tools\test_shell\test_shell.vcproj, {FA39524D-3067-4141-888D-28A86C66F2B9} - nick On Fri, Jun 19, 2009 at 1:53 PM, Bradley Nelson bradnel...@google.comwrote: Ok so I've tracked down the issue

[chromium-dev] Re: changing chrome_exe to chrome, converting chrome.exe to gyp

2009-06-18 Thread Bradley Nelson
Andrew, can you give an example of something that built that shouldn't have for test_shell? Maybe we have some overspecified dependencies as well. -BradN On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus scher...@chromium.orgwrote: I'll see if I can repro this again before filing a bug, but

[chromium-dev] Re: How do you generate the VS project files from GYP without gclient?

2009-06-16 Thread Bradley Nelson
In the same directory with your .gclient file run:src/tools/gyp/gyp src/build/all.gyp -BradN On Tue, Jun 16, 2009 at 9:17 PM, Daniel Cowx daniel.c...@gmail.com wrote: I know that you typically generate the project files via gclient runhooks --force, but I'm curious to know how to generate

[chromium-dev] Re: Any way to compile webkit faster

2009-06-11 Thread Bradley Nelson
By last gyp Sverrir, do you mean the modules in chrome.sln switching over, or the ones in webkit?There was one generated set of targets in webkit.gyp, that we ended up adding a makefile emission option for. It was just too slow with rules (all the overhead of crossing over into cygwin per file).

[chromium-dev] Re: Any way to compile webkit faster

2009-06-10 Thread Bradley Nelson
What does your NUMBER_OF_PROCESSORS environment variable have set?What happens if you set it explicitly to 4? -BradN On Wed, Jun 10, 2009 at 7:43 PM, Mohamed Mansour m0.interact...@gmail.comwrote: +dev -- Forwarded message -- From: Mohamed Mansour m0.interact...@gmail.com

[chromium-dev] Re: Build errors with VS2008SP1

2009-06-07 Thread Bradley Nelson
With VS2008 it is very likely things are messed up right now. I run VS2008 on one of my boxes and a few days ago when I last tried it was hitting several issues: tcmalloc stuff, _TR1 thing related to boost/tuple. Unfortunately results have been unstable with vs2008 lately. Once gyp is fully

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-06-04 Thread Bradley Nelson
Ok I'll change it to opt in.-BradN On Thu, Jun 4, 2009 at 10:51 AM, Mike Belshe mbel...@google.com wrote: Can we change this so that you have to opt-in to vs2008? I have vs2008 on my system, but I never really wanted to use it for chrome. It's just that gyp automatically switched me to it.

[chromium-dev] vs2008 and gyp

2009-06-04 Thread Bradley Nelson
Hi All, If you don't have Visual Studio 2008 installed you can stop reading. As many of you have no doubt noticed, gyp emits something approximating vs2008 sln/vcproj files for the portion of the build it has swallowed. Currently it decides to emit vs2008 format if vs2008 is installed. The

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-05-27 Thread Bradley Nelson
So sverrir's suggestion is right idea. Currently gyp is detecting and emitting 2005/2008 based on what you have installed. Once chrome.sln is eaten this should allow people to use either, but currently if you have 2008 installed it changes lower level stuff but the checked in sln is still at 2005.

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009-05-27 Thread Bradley Nelson
files? What program is doing this and how do I invoke it? I was only able to find details of the GYP syntax on the wiki, but nothing on how these files are actually converted into vcproj files. Thanks, Daniel On May 27, 1:54 pm, Bradley Nelson bradnel...@google.com wrote: So sverrir's

[chromium-dev] Re: VS2008 dependencies..... something is wrong....

2009-05-21 Thread Bradley Nelson
Yes we generate most of the slns and vcprojs from the .gyp files, chrome.sln being the key exception.One issue might be vs2008. I assume at some point the automatic conversion from vs2005 ran. You might need to revert chrome.sln and the other vcprojs and re-run the conversion. Any day now we'll be

[chromium-dev] Re: VS2008 dependencies..... something is wrong....

2009-05-20 Thread Bradley Nelson
Do you see dependencies in any of the slns (like src/base/base.sln for instance?) -BradN On Wed, May 20, 2009 at 9:30 AM, nakro yoav.zilberb...@gmail.com wrote: VS 2008 pro SP 1, on Vista (hebrew) 32SP1 my other projects works just fine, i always thought that the dependencies don't show

[chromium-dev] Re: cygwin setup_mount does not run automatically

2009-05-20 Thread Bradley Nelson
...@google.comwrote: Hi, Brad -- nope, VS 2005, sp1... - Miranda On Wed, May 20, 2009 at 1:25 PM, Bradley Nelson bradnel...@google.comwrote: Hi Miranda, Are you using vs2008 by any chance? -BradN On Wed, May 20, 2009 at 1:07 PM, Miranda Callahan miran...@google.comwrote: Hi Brad

[chromium-dev] Re: cygwin setup_mount does not run automatically

2009-05-16 Thread Bradley Nelson
Hi Ben, I've just checked in a change that should cause that to get run at the right time. Please let me know if you see this issue again. -BradN On Fri, May 15, 2009 at 2:22 AM, Ben Harper rogo...@gmail.com wrote: Hi, I don't know whether cygwin/setup_mount is supposed to run

[chromium-dev] Re: Help: WebKit builder out of diskspace

2009-05-12 Thread Bradley Nelson
It's my change. Fixing but I've opened the tree, as the only side effect is output goes somewhere else temporarily (hence the disk overflow).Sorry -BradN On Tue, May 12, 2009 at 3:11 PM, Jeremy Moskovich jer...@chromium.orgwrote: Can anyone resolve this so we can reopen the tree? Thanks,

[chromium-dev] VS2008 via gyp

2009-05-11 Thread Bradley Nelson
Hi All, I've just dropped in a change to gyp that will generate visual studio 2008 style projects (really just messes with the version numbers), if vs2008 is detected locally. This behavior is disabled on the buildbots at the moment. If this gets in your way you can control it with the

Re: [client-tools-dev] Re: [chromium-dev] webkit now building with gyp on Windows

2009-05-08 Thread Bradley Nelson
Congrats steven! Excellent work! -bradn On May 8, 2009 8:51 AM, Darin Fisher da...@chromium.org wrote: FYI, here's the patch I applied to enable /MP: Index: common.gypi === --- common.gypi (revision 15636) +++ common.gypi (working

[chromium-dev] Re: adding libraries to gyp

2009-04-28 Thread Bradley Nelson
Hi Evan, I'll take a look. Once we switched completely the msvs_guid's can go away (it will generate stable but random ones). -BradN On Tue, Apr 28, 2009 at 12:31 PM, Evan Martin e...@chromium.org wrote: In http://codereview.chromium.org/99132 , I split one library into two. This worked fine

[chromium-dev] Re: webkit gyp conversion planned for tomorrow (Tuesday) evening

2009-04-28 Thread Bradley Nelson
Hi All, Due to some last minute integration issues this will get pushed to 8pmPDT. Wish me luck! -BradN On Mon, Apr 27, 2009 at 4:51 PM, Steven Knight s...@chromium.org wrote: Brad Nelson is planning to close the tree some time tomorrow night (Tuesday 28 April) to land the conversion of

[chromium-dev] Re: Tree is closed - v8 bustage.

2009-04-28 Thread Bradley Nelson
dglaz...@chromium.org wrote: Testing the fix ... :DG On Tue, Apr 28, 2009 at 8:36 PM, Bradley Nelson bradnel...@google.com wrote: Looking into a fix, this may be a missing dependency from v8_snapshot on js2c. It would non-deterministically pass with incredibuild. -BradN On Tue

[chromium-dev] Re: gyp build on Linux

2009-04-01 Thread Bradley Nelson
Congrats! Excellent work. -bradn On Apr 1, 2009 5:17 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Great work! thanks so much for making gyp for linux! On Wed, Apr 1, 2009 at 7:32 PM, Steven Knight s...@chromium.org wrote: Linux builds have bee...

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Bradley Nelson
Very mysterious. These are gyp related: ..\base\base.vcproj ..\base\base_gfx.vcproj ..\base\base_unittests.vcproj ..\third_party\bzip2\bzip2.vcproj ..\net\crash_cache.vcproj ..\base\debug_message.vcproj But these are not: ..\googleurl\build\googleurl.vcproj ..\v8\tools\visual_studio\v8.vcproj

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Bradley Nelson
We are not using 2.6? Not at the moment. Thanks, at a loss to explain it. Let me know if this happens again. Has anyone else seen this sort of thing? -BradN On Thu, Mar 19, 2009 at 1:42 PM, Bradley Nelson bradnel...@google.com wrote: Very mysterious. These are gyp related

[chromium-dev] Re: When i open the chrome.sln,vs report a lot vcproj file missing?

2009-03-17 Thread Bradley Nelson
11, 2009 at 9:09 PM, Bradley Nelson bradnel...@google.com wrote: Hi All, I've just rolled out a switchover of several components on Windows to gyp (generate your project), the new cross platform build tool to which chromium is migrating. gyp is now the official build tool for mac

[chromium-dev] Re: When i open the chrome.sln,vs report a lot vcproj file missing?

2009-03-17 Thread Bradley Nelson
, Bradley Nelson bradnel...@google.comwrote: Did this ever get resolved?I'd be eager to hear about any trouble with gyp. -BradN On Mon, Mar 16, 2009 at 5:44 PM, Jim Roskind j...@chromium.org wrote: Just a wild guess... please ignore if this is not applicable: Any chance you pulled

[chromium-dev] Re: When i open the chrome.sln,vs report a lot vcproj file missing?

2009-03-17 Thread Bradley Nelson
On Tue, Mar 17, 2009 at 9:28 PM, Mark Mentovai m...@chromium.org wrote: Marc-Antoine Ruel wrote: They are not svn:ignored. OK, anything that's GYP-generated does need to be in svn:ignore. Not understanding why? One of the thing I'm afraid of is that even if a generated .vcproj is

[chromium-dev] gyp for windows base is live!

2009-03-11 Thread Bradley Nelson
Hi All, I've just rolled out a switchover of several components on Windows to gyp (generate your project), the new cross platform build tool to which chromium is migrating. gyp is now the official build tool for mac. Consider this a trial period for windows. IF THE ARE PROBLEMS, PLEASE LET ME