[chromium-dev] can't download chrome installer when behind a squid proxy

2010-01-20 Thread Paweł Hajdan , Jr .
I have a local squid proxy and on Windows machines using it the Chrome installer never finishes (I can download the first, small .exe which then initializes and tries to download the main installer). When not using squid it works fine. When using other proxies like tinyproxy, it also works fine.

Re: [chromium-dev] can't download chrome installer when behind a squid proxy

2010-01-20 Thread Paweł Hajdan , Jr .
On Wed, Jan 20, 2010 at 22:38, Eric Roman ero...@chromium.org wrote: Omaha doesn't support manual authentication for proxies, so if your squid proxy is requiring a username/password that could be the problem. Yes, I know about this problem (it's documented in the help message linked when the

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-13 Thread Paweł Hajdan , Jr .
Michał, Chris: could you comment on security aspects and give some recommendations? Ben, could you comment on the user interaction / usability aspect? We have few choices here, I'm not sure which one is preferred. On Mon, Jan 11, 2010 at 23:23, Benjamin Smedberg bsmedb...@gmail.com wrote: For

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-13 Thread Paweł Hajdan , Jr .
On Wed, Jan 13, 2010 at 23:01, Chris Evans cev...@chromium.org wrote: On Wed, Jan 13, 2010 at 8:36 AM, Evan Martin ev...@google.com wrote: Since the proposed vulnerability is that I have cd'ed into a specially crafted malicious directory then type out google-chrome some-particular-url, at

[chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-11 Thread Paweł Hajdan , Jr .
Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. If it's ok to do so, I'd also like to include some message

[chromium-dev] opening local files with chrome from command line, relative paths

2010-01-08 Thread Paweł Hajdan , Jr .
We have http://crbug.com/4436, and the problem is that if you launch chrome index.html (with index.html in the current directory) it will try to navigate to http://index.html/ instead. This behavior is useful for cases like chrome www.google.com, and generally I don't see a good solution to this

Re: [chromium-dev] Best way to test HTTP basic auth cross-platform?

2009-12-19 Thread Paweł Hajdan , Jr .
On Sat, Dec 19, 2009 at 02:25, Drew Wilson atwil...@chromium.org wrote: Is there another way to do it? Perhaps ui_test should register its own NotificationObserver with the AutomationProvider framework? Or is that a bogus approach? I'd really suggest starting with a browser_test instead. It's

[chromium-dev] DirectoryWatcher and listening for user script changes

2009-12-18 Thread Paweł Hajdan , Jr .
I was thinking about many DirectoryWatcher problems, especially on Linux, and now noticed http://crbug.com/20832. User scripts are the only user of DirectoryWatcher. DirectoryWatcher has many quirks - on Windows it behaves in a weird way on XP so we can't test it reliably (and hits the disk on UI

Re: [chromium-dev] Best Practices when disabling tests?

2009-12-16 Thread Paweł Hajdan , Jr .
On Mon, Dec 14, 2009 at 21:23, Andrew Scherkus scher...@chromium.org wrote: I wrote up this section under our Tree Sheriff page: http://dev.chromium.org/developers/tree-sheriffs#TOC-Disabling-tests Thanks! I expanded the section to also mention the FLAKY_ prefix (which is very helpful in

Re: [chromium-dev] Best way to test HTTP basic auth cross-platform?

2009-12-16 Thread Paweł Hajdan , Jr .
On Thu, Dec 17, 2009 at 03:22, Drew Wilson atwil...@chromium.org wrote: The closest thing I found to what I want is the LoginPromptTest ui_tests, but these seem only to work on Windows because the automation framework doesn't yet support NotificationType::AUTH_NEEDED on anything but windows:

Re: [chromium-dev] UI Jank Task Force Status Update

2009-12-08 Thread Paweł Hajdan Jr .
On Tue, Dec 8, 2009 at 00:19, Mark Mentovai m...@chromium.org wrote: Is this thought to be http://crbug.com/29240, or are there other problems with the signal handler? The change to fix that is out at http://codereview.chromium.org/460094. I'm not sure. The failures are not deterministic.

Re: [chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Paweł Hajdan Jr .
Thanks so much! It's nice to learn some things about webkit. Some ideas for the next round of talks: - how sandboxing works on Linux and Mac - ChromeFrame internals (how it interacts with IE, ExternalTab magic etc) - performance tests - Valgrind and ThreadSanitizer - plugins in the multi-process

[chromium-dev] [GTTF] running the views and chromeos trybots for more kinds of CLs

2009-12-07 Thread Paweł Hajdan Jr .
I hit at least few cases when I broke the views and/or chromeos buildbot with a CL which doesn't touch the views code directly (which would trigger submitting it to the views trybot). Today another change in a gypi file triggered a compile failure on views bots, while all other trybots have been

Re: [chromium-dev] UI Jank Task Force Status Update

2009-12-07 Thread Paweł Hajdan Jr .
On Mon, Dec 7, 2009 at 22:34, Glenn Wilson gwil...@chromium.org wrote: Evan Triaging Linux Jank bugs. Probably not many that are actionable right now, though. That's not exactly Jank issue, but on a lot of our bots we're getting leftover processes on Linux. It seems they don't respond

Re: [chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33846

2009-12-04 Thread Paweł Hajdan Jr .
Just FYI, I checked in a patch to disable the test isolation for net_unittests. The thing is, it exposed further problems with the tests. I will investigate that offline. Sorry for a day of increased flakiness. I hope it will pay off in the future with less debugging mysteries with Singletons

[chromium-dev] Two warnings when installing an extension

2009-12-02 Thread Paweł Hajdan Jr .
Just compiled Chromium Linux from trunk and downloaded the sample buildbot extension. I got two warnings while doing this: - when downloading, that the file might be dangerous and hurt my computer - do I want to continue - and second, whether I want to install the extension It may be a better

Re: [chromium-dev] Two warnings when installing an extension

2009-12-02 Thread Paweł Hajdan Jr .
On Wed, Dec 2, 2009 at 19:24, Aaron Boodman a...@google.com wrote: The first prompt is not shown when you install from the gallery, so for 99% of cases users won't see it. Ah, sounds great. By the way, I'm really happy how extensions in Chrome work in general. Instant installation etc. And

Re: [chromium-dev] Xcode, whitespace and you

2009-11-30 Thread Paweł Hajdan Jr .
Could you document that on some Mac wiki page on code.google.com/p/chromium? This way if anyone decides to use Xcode editor at any time will see this handy tip. On Mon, Nov 30, 2009 at 21:31, Dave MacLachlan dmacl...@chromium.orgwrote: If you don't ever use Xcode as an editor, don't ever want

[chromium-dev] Waiting for things in ResourceDispatcherHost

2009-11-30 Thread Paweł Hajdan Jr .
Currently we don't start the request in ResourceDispatcherHost until the user script is ready (or not needed). UserScriptListener handles that. We also wait for SafeBrowsing, Plugins, etc. We're going to wait for PrivacyBlacklists. I was thinking about refactoring RDH so that it would be easy to

Re: [chromium-dev] Flaky SessionHistoryTest.LocationReplace, fun with investigating it

2009-11-25 Thread Paweł Hajdan Jr .
On Wed, Nov 25, 2009 at 20:57, Tim Steele timste...@google.com wrote: It seems like the test should wait for the title to update, and not the navigation to finish. I'm pretty sure it's not a waiting problem. I followed what the test does manually, and I could still reproduce the issue. I also

Re: [chromium-dev] Flaky SessionHistoryTest.LocationReplace, fun with investigating it

2009-11-25 Thread Paweł Hajdan Jr .
On Wed, Nov 25, 2009 at 22:33, Tim Steele timste...@google.com wrote: There are only a couple places where WebCore tells the client that the title changed (looks like 3, search FrameLoader for dispatchDidReceiveTitle). There are conditionals wrapping each such call and also, in some cases,

[chromium-dev] Flaky SessionHistoryTest.LocationReplace, fun with investigating it

2009-11-24 Thread Paweł Hajdan Jr .
A little background: SessionHistoryTest.LocationReplace rarely fails on the buildbot (isn't even on the flakiness dashboard), but seems to be #1 flaky test on the trybot, where it fails almost every time (or so it seems to me). It also reproduces very consistently on my Windows VM, so we have a

Re: [chromium-dev] Flaky SessionHistoryTest.LocationReplace, fun with investigating it

2009-11-24 Thread Paweł Hajdan Jr .
On Wed, Nov 25, 2009 at 00:07, Evan Stade est...@google.com wrote: sounds like http://crbug.com/22560 Thanks for finding it. /me votes for removing the Mstone-X label from it, bumping priority to Pri-2, adding a FlakyTest label and details about SessionHistoryTest.LocationReplace, and finally

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-23 Thread Paweł Hajdan Jr .
On Fri, Nov 20, 2009 at 23:34, Darin Fisher da...@chromium.org wrote: We could define a function that must be called before you can use code in base/. You could add a call to this everywhere that we currently create the AtExitManager. Or, maybe we could combine those somehow. Thanks for

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Paweł Hajdan Jr .
On Mon, Nov 23, 2009 at 02:22, Marc-Antoine Ruel mar...@google.com wrote: It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an

Re: [chromium-dev] workflow for cross-platform development

2009-11-22 Thread Paweł Hajdan Jr .
On Sat, Nov 21, 2009 at 19:52, Chris Bentzel cbent...@google.com wrote: Have there been any thoughts about adding gcl patch and unpatch commands which will grab the file diffs as well as duplicate the CL metadata in src/.svn/gcl_info? It's not trivial to correctly apply a patch in svn (file

Re: [chromium-dev] class has virtual method but non-virtual destructor

2009-11-20 Thread Paweł Hajdan Jr .
On Fri, Nov 20, 2009 at 21:05, Evan Martin e...@chromium.org wrote: Your analysis is correct. However, a virtual destructor is not needed in the case where you never delete through the Base*. It turns out for our codebase that is very common (due to lots of observer-like patterns), so we

[chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-20 Thread Paweł Hajdan Jr .
Do you have some idea how to get rid of the Singletons in base/time_win.cc? They don't play very well with base::SystemMonitor, MessageLoop, and test code. Here's the scenario we're hitting right now (in browser_tests): 1. HighResolutionTimerManager is created to enable high resolution timer

Re: [chromium-dev] FYI ... you might find some issues missing in issue_tracker

2009-11-19 Thread Paweł Hajdan Jr .
Not sure if that's related, but bugdroid started to behave strangely. I see new comments for commits from before a week. On Wed, Nov 18, 2009 at 20:27, Dirk Pranke dpra...@chromium.org wrote: Hi all, Just a heads' up ... we've discovered a bug in Issue Tracker that has caused a few of our

[chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Paweł Hajdan Jr .
It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support for git-cl because there is already a watchlists.py file, but then there are some questions: - should the watchlists.py file (from depot_tools) be copied to

Re: [chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Paweł Hajdan Jr .
On Tue, Nov 17, 2009 at 20:43, Peter Kasting pkast...@google.com wrote: On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin ev...@google.com wrote: Since we're talking about style, I'll note that this pattern is no good (and I've seen it explicitly called out somewhere before). The problem is

[chromium-dev] [GTTF] running tests that fail most often early in the queue

2009-11-12 Thread Paweł Hajdan Jr .
I was just looking at the buildbot cycle stats at http://build.chromium.org/buildbot/waterfall/stats and realized that on many bots the most frequently failing tests are browser_tests and ui_tests. Then I checked how early they are run by each bot (the earlier we know about the failure, the

[chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-12 Thread Paweł Hajdan Jr .
On Thu, Nov 12, 2009 at 20:26, John Abd-El-Malek j...@chromium.org wrote: My question still stands: if this list is needed in order to process the first network request, why add extra complexity to RDH to make more things asynchronous, when either way any IO is basically blocked on the

Re: [chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-12 Thread Paweł Hajdan jr
On Thu, Nov 12, 2009 at 21:28, Peter Kasting pkast...@google.com wrote: On Thu, Nov 12, 2009 at 12:13 PM, John Abd-El-Malek j...@chromium.orgwrote: per our chat on irc, I think if a new privacy blacklist is added while running, it should be loaded on the file thread, and when it's available

[chromium-dev] Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-11 Thread Paweł Hajdan Jr .
Initially I got an advice to use PauseRequest and ResourceHandler to wait with servicing requests until all privacy blacklists are loaded. However, there are problems with that. When you look at ResourceDispatcher code, we need a Blacklist::Match* even before creating URLRequest. I thought about

[chromium-dev] Re: Waiting for privacy blacklists to load in ResourceDispatcherHost

2009-11-11 Thread Paweł Hajdan Jr .
On Thu, Nov 12, 2009 at 01:00, John Abd-El-Malek j...@chromium.org wrote: On Wed, Nov 11, 2009 at 1:22 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: To do that, I'd need to listen for BlacklistManager notifications in RDH (on IO thread). Does it seem OK to make RDH

Re: [chromium-dev] Beginning with development

2009-11-10 Thread Paweł Hajdan jr
Note however that you can build specific projects. When working on base or net for example, you can build just base_unittests and net_unittests. When working on webkity things, you can sometimes compile just the test_shell, and not chrome. -- Chromium Developers mailing list:

[chromium-dev] Re: Assertion failures on Mac OS are super slow

2009-11-09 Thread Paweł Hajdan Jr .
On Mon, Nov 9, 2009 at 5:03 PM, Dave MacLachlan dmacl...@google.com wrote: I haven't looked into it, but I'm assuming the reason it's so slow is because of the bad DSYM parsing in Leopard. It should be much faster in Snow Leopard, but that probably doesn't help you. That's probably

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-04 Thread Paweł Hajdan Jr .
On Wed, Nov 4, 2009 at 08:56, Aaron Boodman a...@chromium.org wrote: Why don't you pass an Extension instance? It's in a test. Mocking an Extension is not trivial as well. :( Or maybe... I didn't read all of the extensions unit tests, maybe it's not that hard. It seems like you are

[chromium-dev] Re: Singleton, LazyInstance, and testability

2009-11-04 Thread Paweł Hajdan Jr .
So, the problem with Extensions has been solved (thanks to Aaron), but there's stil the original issue that may bite at any time (please see the first message for context): Is there a big difference between a Singleton and LazyInstance? I was thinking about making NPAPI::PluginList a Singleton

[chromium-dev] Re: Working on privacy blacklists, collision warning

2009-11-04 Thread Paweł Hajdan Jr .
On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: - make ExtensionsService a BlacklistPathProvider and write a test which loads an extension and verifies that BlacklistManager notices that (I'm working on it now) This is done. To clarify: you can't yet load

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-03 Thread Paweł Hajdan Jr .
On Tue, Nov 3, 2009 at 06:50, John Abd-El-Malek j...@chromium.org wrote: *The solution* 1+2: Use ChromeThread::PostTask and friends (i.e. PostDelayedTask, DeleteSoon, ReleaseSoon) which are safe and efficient: no locks are grabbed if the target thread is known to outlive the current thread.

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Paweł Hajdan Jr .
On Tue, Nov 3, 2009 at 16:58, Evan Martin e...@chromium.org wrote: I'm not sure which news you're referring to. :) To the one that the files are supposed to by svn-copied by git, that there is a command to check for that, and that you offered to help in case of problems. :)

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

2009-11-03 Thread Paweł Hajdan Jr .
On Tue, Nov 3, 2009 at 19:08, Drew Wilson atwil...@chromium.org wrote: I've also been known to use the built-in GNU emacs from a terminal shell (especially when working remotely/SSH-ing). I see no reason why you can't have the same experience that you do with your Linux box, although you'd

[chromium-dev] Which editor do you recommend on Mac OS X?

2009-11-03 Thread Paweł Hajdan Jr .
Recently I started working more and more on Mac OS X, and I'm trying to find an editor that would work the best for me. On Linux I used GNU Emacs with many customizations. Some of the most handy ones for working on Chromium were Google Style script and launching the compilation from the editor. I

[chromium-dev] Singleton, LazyInstance, and testability

2009-11-03 Thread Paweł Hajdan Jr .
I encountered another problem related to Singletons in unit tests. PluginService is a Singleton, and it listens to extensions notifications. In one of my tests when I was using the extensions notifications the PluginService crashed because I passed NULL as the Extension* - because the listener I

[chromium-dev] Re: FYI: Linux interactive_ui_tests a bit hosed

2009-11-02 Thread Paweł Hajdan Jr .
I think that the right fix is to switch interactive_ui_tests to browser_tests launcher (jcampan did some great work to make the launcher more flexible, it may be quite simple to do the switch now - if there are no UI tests in interactive_ui_tests). I also suggest bumping the priority of

[chromium-dev] Re: How much RAM needed to get past linking? (Linux)

2009-11-02 Thread Paweł Hajdan Jr .
If you have less than 1 GB of RAM, I wouldn't even try to link the biggest binaries. 2 GB of RAM should be sufficient, although with 4 and more it's better. And you will notice the change after switching to gold. On Mon, Nov 2, 2009 at 18:58, Adam Langley a...@chromium.org wrote: On Fri, Oct

[chromium-dev] compile fails on Ubuntu 9.04

2009-11-02 Thread Paweł Hajdan Jr .
I'm getting this compile error when compiling on Ubuntu 9.04 (scons): Compiling /home/ph/chromium/src/sconsbuild/Debug/obj/libxslt/libxslt/libxslt/xsltutils.o Generating version information Creating library /home/ph/chromium/src/sconsbuild/Debug/lib/libxslt.a Indexing

[chromium-dev] Re: refactoring and git

2009-11-02 Thread Paweł Hajdan Jr .
That's a good news. Can that info be put somewhere in the UsingGit wiki page? On Mon, Nov 2, 2009 at 23:56, Evan Martin e...@chromium.org wrote: On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson atwil...@chromium.org wrote: I'm doing some refactoring in the chromium worker code, and I got the

[chromium-dev] Re: Working on privacy blacklists, collision warning

2009-10-29 Thread Paweł Hajdan Jr .
26, 2009 at 09:05, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Please don't make non-trivial changes to chrome/browser/privacy_blacklists if possible. I have a big change which I'll be soon (today) submitting for review. It will be needed to integrate privacy blacklists with extensions

[chromium-dev] Re: [Green Tree] Task Force Status Update 10/26

2009-10-28 Thread Paweł Hajdan Jr .
On Wed, Oct 28, 2009 at 16:35, Scott Violet s...@chromium.org wrote: I suspect this happens when the theme resources aren't correctly built. Perhaps we should have this check early on in ui tests so that we don't run any tests if this check fails. Yeah, I was even thinking about a build

[chromium-dev] Working on privacy blacklists, collision warning

2009-10-26 Thread Paweł Hajdan Jr .
Please don't make non-trivial changes to chrome/browser/privacy_blacklists if possible. I have a big change which I'll be soon (today) submitting for review. It will be needed to integrate privacy blacklists with extensions. --~--~-~--~~~---~--~~ Chromium

[chromium-dev] compile error on Snow Leopard

2009-10-24 Thread Paweł Hajdan Jr .
I get this when compiling unit_tests on Mac OS X 10.6 Snow Leopard: /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689:0 /Users/ph/chromium/src/chrome/browser/cocoa/ bookmark_bar_controller_unittest.mm:689: warning: 'stringWithCString:' is deprecated (declared at

[chromium-dev] How to use PauseRequest

2009-10-23 Thread Paweł Hajdan Jr .
I'm going to use PauseRequest for privacy blacklists. It seems that I should create a new ResourceHandler, and resource handlers seem to wrap another resource handlers. Then I'd have to add code to use the new ResourceHandler in ResourceDispatcherHost. I'd need to write a ResourceHandler which

[chromium-dev] Re: weird Visual Studio link error, will clobber fix it?

2009-10-19 Thread Paweł Hajdan Jr .
That fixed it, thanks! On Fri, Oct 16, 2009 at 22:00, Marc-Antoine Ruel mar...@chromium.orgwrote: ... more hotfixes for you to install http://dev.chromium.org/developers/how-tos/build-instructions-windows On Fri, Oct 16, 2009 at 3:57 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote

[chromium-dev] weird Visual Studio link error, will clobber fix it?

2009-10-16 Thread Paweł Hajdan Jr .
I'm consistently getting this error when linking (fails 57 times when compiling the entire chrome.sln): 2shell32.lib(shguid.obj) : fatal error LNK1103: debugging information corrupt; recompile module I'm using Visual Studio 2005, fresh checkout. Should I just try clobber?

[chromium-dev] bugtracker cleanup

2009-10-15 Thread Paweł Hajdan Jr .
Today I reviewed some old bugs which didn't get any attention and tried to correctly mark/assign/close them. Feel free to reassign a bug if I assigned it to you - I was generally looking for people familiar with the area so that they can decide what to do next (please not that the status of such

[chromium-dev] Re: Please confirm the bug (some bitmaps aren/t displayed)

2009-10-12 Thread Paweł Hajdan Jr .
On Mon, Oct 12, 2009 at 20:53, Jeremy Orlow jor...@chromium.org wrote: I think the bigger issue is how/when Area-Misc bugs get triaged. Do they ever? If not, we should probably change that. I sometimes review old bugs and close those which no longer reproduce, and ask for more details in

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

2009-10-09 Thread Paweł Hajdan Jr .
On Fri, Oct 9, 2009 at 11:01, Jickae Davis jick...@gmail.com wrote: Well, I agree with PhistucK. I think a progress bar may help though it's not so accurate. By the way, if I want to add such a bar with chromium, how should I start? Is there a method that tells the size of the resources to

[chromium-dev] detecting tabs using a lot of CPU?

2009-10-07 Thread Paweł Hajdan Jr .
Just a while before one of my tabs (GMail) started using a lot of CPU time (67% while I was compiling in the background). The browser and the system were responsive at all times, but processing power was wasted. We have a warning dialog for hanged renderers offering to kill them. What do you think

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Paweł Hajdan Jr .
On Wed, Oct 7, 2009 at 21:25, Jeremy Orlow jor...@chromium.org wrote: I could't imagine many users understanding a feature like this much less finding it particularly useful. That's right, an average user would be only confused. Just exposing this info (cpu-hungriness) to extensions seems

[chromium-dev] Re: SVN Stable Tree Path for 3.0.195.25

2009-10-07 Thread Paweł Hajdan Jr .
(adding people more familiar with the release process...) On Wed, Oct 7, 2009 at 20:16, Amit Kishnani akish...@adobe.com wrote: Hey Elliot, thanks for quick turnaround. the trunk (svn) : http://src.chromium.org/svn/trunk/src/chrome/VERSION is MAJOR=4 MINOR=0 BUILD=222 PATCH=1 but I

[chromium-dev] Re: How to deal with flaky unit tests

2009-10-06 Thread Paweł Hajdan Jr .
On Wed, Oct 7, 2009 at 02:02, Nicolas Sylvain nsylv...@chromium.org wrote: Once we start tagging the flaky tests, we will monitor the flakiness dashboard and make sure that a test that is no longer flaky has its FLAKY_ tag removed. It may be a good idea to expand the number of tests listed

[chromium-dev] Re: flaky resource failures

2009-09-25 Thread Paweł Hajdan Jr .
On Fri, Sep 25, 2009 at 05:26, Thomas Van Lenten thoma...@chromium.orgwrote: On Thu, Sep 24, 2009 at 6:24 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten thoma...@chromium.orgwrote: Brad landed support for depending on all the python

[chromium-dev] Re: buildbot failure in Chromium on Modules XP (dbg), revision 27248

2009-09-25 Thread Paweł Hajdan Jr .
Confirmed. It is flaky. I'm going to disable it when I have a while. Feel free to disable it earlier. On Fri, Sep 25, 2009 at 14:19, Eric Roman ero...@chromium.org wrote: Looks like FTPCacheURLCredentials is flaky; none of these changes touched that code... On Fri, Sep 25, 2009 at 2:14 PM,

[chromium-dev] flaky resource failures

2009-09-24 Thread Paweł Hajdan Jr .
We still have problems with resources, examples: [FATAL:tab_renderer.cc(132)] Check failed: waiting_animation_frames-width() % waiting_animation_frames-height() == 0. [FATAL:image_operations.cc(373)] Check failed: rgb.width() == alpha.width(). [FATAL:resource_bundle_win.cc(155)] Check failed:

[chromium-dev] Re: flaky resource failures

2009-09-24 Thread Paweł Hajdan Jr .
I don't think we depend on all the grit .py files. I think these changes are rare enough that we can just clobber as needed. On Thu, Sep 24, 2009 at 12:03 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: We still have problems with resources, examples: [FATAL:tab_renderer.cc(132

[chromium-dev] Re: flaky resource failures

2009-09-24 Thread Paweł Hajdan Jr .
On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten thoma...@chromium.orgwrote: Brad landed support for depending on all the python files that go into grit, so that part would have worked. The not always rebuilding for .h files is the problem. Does it mean we're missing some deps in the gyp

[chromium-dev] debugging the browser started by UI tests

2009-09-22 Thread Paweł Hajdan Jr .
What's the best way to attach the debugger to a browser started by a UI test? How about doing that only in case of a crash? I'm looking for solution both for Windows and Linux, so if you have good techniques, it'd be really nice. I can even document them on the wiki, but currently I'm using LOG

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Paweł Hajdan Jr .
On Tue, Sep 22, 2009 at 17:40, Nicolas Sylvain nsylv...@chromium.orgwrote: 3 PM : two failing ui tests are disabled by the webkit sheriff I was looking at the UI tests and it wasn't immediately obvious that a webkit update might break them. Can we run all the UI tests on the webkit canary bot?

[chromium-dev] Dashboard to show which UI/unit/etc (non-webkit) tests are slowest

2009-09-17 Thread Paweł Hajdan Jr .
The slowness dashboard is ready at http://build.chromium.org/buildbot/slowness-report/ There are some problems with it (like garbage in test names), and it could possibly display more data (like median and stddev), but it's generally usable. --~--~-~--~~~---~--~~

[chromium-dev] Re: Chrome Library for tweaking Windows Network Settings

2009-09-16 Thread Paweł Hajdan Jr .
You can mock the HostResolver to make it fail to resolve anything (possibly except localhost). For examples, see HostResolver's unit tests and possibly other places where it is used. You can also make it fail to resolve specific hosts, which should also be handy. On Tue, Sep 15, 2009 at 13:54, TJ

[chromium-dev] Re: [linux] parasite is awesome

2009-09-16 Thread Paweł Hajdan Jr .
Looks like a good candidate for LinuxDebugging wiki page. On Wed, Sep 16, 2009 at 17:04, Evan Martin e...@chromium.org wrote: http://chipx86.github.com/gtkparasite/ We had looked into using parasite back in the early days, but I forgot about it due to 32/64-bit stuff. But now that we've

[chromium-dev] Re: [linux] parasite is awesome

2009-09-16 Thread Paweł Hajdan Jr .
On Wed, Sep 16, 2009 at 17:22, Ian Fette i...@chromium.org wrote: Out of curiosity, could this be integrated in our testing framework to have less-flaky UI tests (at least for some subset of the functionality currently tested with UI tests)? I don't have idea how to use it for that purpose.

[chromium-dev] Avoiding DevToolsSanityTest bustages

2009-09-11 Thread Paweł Hajdan Jr .
DevToolsSanityTest flips frequently between enabled and disabled. It seems to be mostly caused by changes in WebKit. I see two nice ways to prevent that: - run the tests upstream on webkit.org bots (probably hard) - run the tests on our webkit canary bot (should be doable) What do you think?

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Paweł Hajdan Jr .
For me it was obvious, but if people are surprised by this, then improving the documentation is probably a good idea. Just curious... the change has been submitted to trybots before landing, hasn't it? On Thu, Sep 10, 2009 at 10:03, Dan Kegel d...@kegel.com wrote: An external contributor was

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Paweł Hajdan Jr .
On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote: In this case, the code may have been submitted by a committer without using the trybots (tsk, tsk). We don't currently mention the trybots on dev.chromium.org. Is it time to? Submitting without trybots and breaking the

[chromium-dev] Re: How to use automation to do form submission?

2009-09-10 Thread Paweł Hajdan Jr .
I think you can execute javascript with automation (see chrome/test/automation/tab_proxy.h). It is possible to submit forms using javascript. If you want to add a new automation request, see chrome/test/automation_messages{,_internal}.h and add a new message there. Then add a new call to TabProxy

[chromium-dev] Re: Announcing view-net-internal:

2009-09-10 Thread Paweł Hajdan Jr .
I like it! Like every feature which allows one to take a look under the hood. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Wanted: anonymous FTP servers running rare software

2009-09-10 Thread Paweł Hajdan Jr .
On Thu, Sep 10, 2009 at 15:54, Chris Evans cev...@chromium.org wrote: Sounds like a moderate amount of work. IMHO, it would be acceptable from a security standpoint to: 1) Fix any bugs turned up by fuzzing. Even then, I'd need some way to verify the validity of the fixes. Mozilla has some

[chromium-dev] Just got a backtrace from flaky RenderViewTest

2009-09-09 Thread Paweł Hajdan Jr .
So, RenderViewTest crashes very often. Now, thanks to maruel, we have a stack trace: [--] 16 tests from RenderViewTest [ RUN ] RenderViewTest.OnLoadAlternateHTMLText Backtrace: GetStackFrames [0x00FF6085+306229] _sbrk [0x00A7E5EE+70254] _sbrk

[chromium-dev] Re: Are we going to support active FTP?

2009-09-09 Thread Paweł Hajdan Jr .
The bug is about a firewall forbidding the connection. Why the trick won't work? If I can't connect to the PASV port, I'd try PORT, even on successful PASV response. On Wed, Sep 9, 2009 at 12:52, Michal Zalewski lcam...@gmail.com wrote: I can't think of any. It would be nice to have active

[chromium-dev] Re: how to run chromium with 'automation' enabled?

2009-09-04 Thread Paweł Hajdan Jr .
by the chrome.dll suggests that this is the case. Simon On Thu, Sep 3, 2009 at 11:07 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Then probably you should just use AutomationProxy (directly, without UI test framework). Adapting tests would be harder - just build a small driver

[chromium-dev] Re: how to induce flakiness, episode 1326: misusing IN_PROC_BROWSER_TEST

2009-09-03 Thread Paweł Hajdan Jr .
these tests in their own executable; they should all be in-proc browser tests. - nick On Wed, Sep 2, 2009 at 9:44 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: So, here are the choices I currently see: - let each binary only use one kind of tests (probably both UI) - split each

[chromium-dev] Re: how to run chromium with 'automation' enabled?

2009-09-03 Thread Paweł Hajdan Jr .
You need AutomationProxy for that. See the line server_.reset(CreateAutomationProxy(command_execution_timeout_ms_)); Please keep the discussion on the list. And I'll repeat my question: what is your goal? I might guess that you are trying to re-use the browser between test runs. It may be a bad

[chromium-dev] Re: how to run chromium with 'automation' enabled?

2009-09-03 Thread Paweł Hajdan Jr .
Then probably you should just use AutomationProxy (directly, without UI test framework). Adapting tests would be harder - just build a small driver program to launch the browser in a similar way UI test does, and uses the AutomationProxy to send it NavigateToURL message. You may also want to take

[chromium-dev] detect problems with resources right away

2009-09-03 Thread Paweł Hajdan Jr .
The flakiness with resources has hugely decreased since I landed my infamous hook, but it's still there. I'm not sure what really happens, so I'm thinking about a special build step (before UI tests etc), which would verify that all the expected resources are present in the bundle and then fail.

[chromium-dev] Re: detect problems with resources right away

2009-09-03 Thread Paweł Hajdan Jr .
. Initially I'll be using the inputs to fix some of the dependencies. Does this cover your concerns? http://codereview.chromium.org/197007/show -BradN On Thu, Sep 3, 2009 at 5:30 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: The flakiness with resources has hugely decreased since I

[chromium-dev] Re: how to induce flakiness, episode 1326: misusing IN_PROC_BROWSER_TEST

2009-09-02 Thread Paweł Hajdan Jr .
would be better. On Mon, Aug 31, 2009 at 11:44, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: I don't quite know how to solve the problem. When IN_PROC_BROWSER_TEST is used, a launcher that will isolate the test cases should be used (like running them in forked processes or reloading a dll

[chromium-dev] please use FlakyTest label and file flakiness bugs

2009-09-01 Thread Paweł Hajdan Jr .
If you disable a flaky test, please file a bug if needed, and assign a FlakyTest label (I'm automatically CC-ed). This way I can easily search for it. Sometimes a flakiness pattern is more clearly visible then, and it helps. Thanks! --~--~-~--~~~---~--~~ Chromium

[chromium-dev] RWX sections in the binary

2009-09-01 Thread Paweł Hajdan Jr .
Chromium gives this notice when compiling on Gentoo: QA Notice: The following files contain writable and executable sections Files with such sections will not work properly (or at all!) on some architectures/operating systems. A bug should be filed at http://bugs.gentoo.org/ to make sure the

[chromium-dev] Creating a SkBitmap filled with one color

2009-08-26 Thread Paweł Hajdan Jr .
How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? I'd need that for Linux extension shelf, and the Windows code for that seems not easily portable to Linux. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-26 Thread Paweł Hajdan Jr .
Seconded. Tags would make my work on packaging for Gentoo much easier. On Wed, Aug 26, 2009 at 15:51, Aaron Boodman a...@chromium.org wrote: Checking up on this. I don't see the tags in src.chromium.org yet. Can we get this going for the next dev release? - a On Tue, Aug 11, 2009 at 1:30

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Paweł Hajdan Jr .
Thanks for all the answers, especially the first one from erg. I'm going to use Skia, because another method (SetBackground in RWHV) requires that. On Wed, Aug 26, 2009 at 16:33, Tony Chang t...@chromium.org wrote: There's an example of how to do this with skia in src/app/resource_bundle.cc

[chromium-dev] forbidding IN_PROC_BROWSER_TESTS in unit_tests

2009-08-25 Thread Paweł Hajdan Jr .
I'm in the middle of debugging a problem which is caused by singletons. It's a very bad category of problems, because the results are initially very mysterious, until you discover that it's a singleton which carries state from one test to another. Browser tests carry a lot of state. The entire

[chromium-dev] Re: forbidding IN_PROC_BROWSER_TESTS in unit_tests

2009-08-25 Thread Paweł Hajdan Jr .
On Tue, Aug 25, 2009 at 16:08, Evan Stade est...@chromium.org wrote: uh, for which binaries are in proc browser tests allowed? I know there is one in interactive_ui_tests and it was causing problems (which caused me to go and use the code to not use statics). BrowserFocusUITests was the one.

[chromium-dev] Re: forbidding IN_PROC_BROWSER_TESTS in unit_tests

2009-08-25 Thread Paweł Hajdan Jr .
I think it should only be allowed in tests that use a launcher which will properly isolate test cases. Currently interactive_ui_tests use in-proc tests. To make transition easier, I'm going to allow in-proc in them, but try to get rid of it finally (or make the launcher safer). On Tue, Aug 25,

[chromium-dev] Re: PSA: do not include X_messages.h in other headers

2009-08-20 Thread Paweł Hajdan Jr .
Cool! Thanks so much. I'm going to write a presubmit check for that. On Thu, Aug 20, 2009 at 11:12, John Abd-El-Malek j...@chromium.org wrote: Including files like render_messages.h and automation_messages.h from other header files is unnecessary and slows down the build (adds about ~100K

[chromium-dev] Re: Overloading operator for TimeDelta

2009-08-20 Thread Paweł Hajdan Jr .
On Thu, Aug 20, 2009 at 16:02, Peter Kasting pkast...@chromium.org wrote: On Thu, Aug 20, 2009 at 3:33 PM, Andrew Scherkus scher...@chromium.orgwrote: Any opposition to globally declaring an operator ostream overload for TimeDelta in base/time.h? This will pull the stream headers into all

  1   2   >