[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Andrew Scherkus
Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Trying to figure out a workaround. If all else fails I can always give in and add depot_tools to my PATH :) On Wed, Oct 14, 2009 at 11:08 PM, Aaron Boodman a...@chromium.org wrote:

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Ojan Vafai
Replying off-list as requested... Firstly, this is awesome! On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips ch...@chromium.org wrote: git-cl upload Runs presubmit tests on upload, continues even if tests fail. This latter part is different than the gcl version. Is that intentional? I

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Chase Phillips
Hi Andrew, On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus scher...@chromium.orgwrote: Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Thanks for pointing this out. The hooks should fail gracefully in those cases, so I'll make

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Andrew Scherkus
On Thu, Oct 15, 2009 at 11:03 AM, Chase Phillips ch...@chromium.org wrote: Hi Andrew, On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus scher...@chromium.orgwrote: Hrmm... it looks your script assumes depot_tools is in your PATH -- if it can't find it the script crashes. Thanks for

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Chase Phillips
On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Replying off-list as requested... Right! ;) Firstly, this is awesome! Thanks. On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips ch...@chromium.orgwrote: git-cl upload Runs presubmit tests on upload, continues

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Evan Martin
On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips ch...@chromium.org wrote: To bypass the presubmit tests in upload or dcommit, use the --bypass-hooks flag. git-cl dcommit's -f now implies --bypass-hooks along with skipping the commit confirm prompt. Ditto above. The gcl flag is

[chromium-dev] Re: [announce] git-cl now has presubmit support.. read on to find out how to enable it!

2009-10-15 Thread Ojan Vafai
On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips ch...@chromium.org wrote: On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Replying off-list as requested... Right! ;) Doh. However, my tests of gcl upload show they already have the same behavior here: gcl uploads