On Wed, May 13, 2009 at 12:53 PM, Brett Wilson wrote:
> On Wed, May 13, 2009 at 12:39 PM, Darin Fisher wrote:
> > That is what I meant by pain
> > It only applies to "third party" code that conforms to the google style
> > guide, which says that all include paths must be relative to the root
On Wed, May 13, 2009 at 12:39 PM, Darin Fisher wrote:
> That is what I meant by pain
> It only applies to "third party" code that conforms to the google style
> guide, which says that all include paths must be relative to the root. Come
> to think of it, I think this could cause problems for
Yes... that's what I'd imagine us doing... just because we suck in
projects A, B, C doesn't mean they need to conform to our "include
starts at the root" convention - as far as they're concerned the root
is src/ in their repo.
-Ben
On Wed, May 13, 2009 at 12:39 PM, Darin Fisher wrote:
> That is
That is what I meant by pain
It only applies to "third party" code that conforms to the google style
guide, which says that all include paths must be relative to the root. Come
to think of it, I think this could cause problems for such projects, since
I'm sure the V8 developers don't think of
Really? I don't think we include anything in third_party using
third_party in the include path - or is this not what you mean by
"pain"?
-Ben
On Wed, May 13, 2009 at 12:32 PM, Darin Fisher wrote:
> I think that's a good point, and it would make for a much easier to
> understand and enforce poli
I think that's a good point, and it would make for a much easier to
understand and enforce policy. It means some potential pain if we ever wish
to fork a top-level directory off into a separate opensource project.
-Darin
On Wed, May 13, 2009 at 10:56 AM, Ben Goodger (Google) wrote:
> I do think
I do think this distinction is fairly arbitrary in the world of open
source projects. It is not hard to imagine a time when some of these
dependencies may have more non-Google contributors than Googlers. It
is also possible that licensing may change over time.
In addition, it makes it harder to d
Nice work Stephen!!-Darin
On Wed, May 13, 2009 at 9:03 AM, Stephen White wrote:
> Ok, the Skia move is done.
> I've had some reports that you need to clean/rebuild skia.lib, but that a
> full clobber is not necessary.
>
> Thanks to maruel, thomasvl, and nsylvain for helping out with mop-up.
>
> L
Ok, the Skia move is done.
I've had some reports that you need to clean/rebuild skia.lib, but that a
full clobber is not necessary.
Thanks to maruel, thomasvl, and nsylvain for helping out with mop-up.
Let me know if you have any further problems.
Stephen
On Tue, May 12, 2009 at 5:22 PM, Stephe
On Tue, May 12, 2009 at 3:05 PM, Stephen White wrote:
> On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain wrote:
>
>>
>>
>> On Tue, May 12, 2009 at 2:22 PM, Stephen White
>> wrote:
>>
>>> I'm in the process of updating chromium to use tip-of-tree skia, and in
>>> the same CL, moving skia to a thir
On Tue, May 12, 2009 at 3:06 PM, Brett Wilson wrote:
>
> On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain
> wrote:
> > On Tue, May 12, 2009 at 2:22 PM, Stephen White >
> > wrote:
> >>
> >> I'm in the process of updating chromium to use tip-of-tree skia, and in
> >> the same CL, moving skia to a
On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain wrote:
> On Tue, May 12, 2009 at 2:22 PM, Stephen White
> wrote:
>>
>> I'm in the process of updating chromium to use tip-of-tree skia, and in
>> the same CL, moving skia to a third_party directory,
>> retrieved via DEPS. What this means for you:
On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain wrote:
>
>
> On Tue, May 12, 2009 at 2:22 PM, Stephen White
> wrote:
>
>> I'm in the process of updating chromium to use tip-of-tree skia, and in
>> the same CL, moving skia to a third_party directory, retrieved via DEPS.
>> What this means for yo
On Tue, May 12, 2009 at 2:22 PM, Stephen White wrote:
> I'm in the process of updating chromium to use tip-of-tree skia, and in the
> same CL, moving skia to a third_party directory, retrieved via DEPS. What
> this means for you:
>
Hi,
Why do you want to move it to third party?
The other proje
On Tue, May 12, 2009 at 2:22 PM, Stephen White wrote:
> Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM EST
> (7AM PST).
> Stephen
Woo! Woo!
Very glad to see Skia unforking!
(Linux folks: this unblocks me writing complex-text support)
AGL
--~--~-~--~~--
15 matches
Mail list logo
