On Mon, Jan 11, 2010 at 9:04 PM, Chris Evans cev...@chromium.org wrote:
Hi,
I found this interesting: http://a.qoid.us/google.html
Because it's clearly very non-JavaScript focused (just a CSS rotation) and
yet the browsers exhibit very different performance characteristics.
All on my
On Tue, Jan 12, 2010 at 11:33 AM, Evan Martin e...@chromium.org wrote:
On Tue, Jan 12, 2010 at 10:17 AM, Brett Wilson bre...@chromium.org wrote:
I imagine the problems on Linux are the same as they were on Windows,
where the underlying graphics layer wants to place glyphs aligned on
pixel
On Mon, Jan 11, 2010 at 12:59 AM, hap 497 hap...@gmail.com wrote:
Thank you.
But when I load www.cnn.com, I see something strange:
First the throbber is spinning, and then the cnn fave icon is shown
and then the throbber is spinning again, and then fave icon is shown.
And then the fave icon
On Mon, Dec 7, 2009 at 1:43 PM, Bradley Nelson bradnel...@google.com wrote:
Hello All,
Last week I re-landed a change to split off parts of chrome.gyp into .gypi's
in the same directory.
I had done something similar a couple weeks back, but took it out because
concern was raised about merge
On Wed, Dec 9, 2009 at 4:24 PM, John Abd-El-Malek j...@chromium.org wrote:
btw I searched the code, almost all the instances are in code from different
repositories, like v8, gtest, gmock. I counted only 17 instances in
Chrome's code.
Most of the Chrome NOLINTs look like the're around
On Tue, Nov 3, 2009 at 6:01 AM, Mike Pinkerton pinker...@chromium.org wrote:
Can you put this information, as well as some examples for proper
usage, on dev.chromium.org. I doubt this stuff is very well documented
from the perspective of someone trying to use it, and this looks like
a great
2009/10/23 Hironori Bono (坊野 博典) hb...@google.com:
Hi Brett,
Thank you so much for noticing this. I'm integrating the
ThumbnailGenertor class into my prototype now. :)
By the way, I'm a little wondering if there is a function that changes
the width and the height of a thumbnail image
Hi Hironori,
Thanks for researching this topic. On generating thumbnails, I wrote
chrome/browser/tab_contents/thumbnail_generator which tries to get the
most up-to-date thumbnail images for all tabs (except ones that
haven't ever been shown) with minimal performance overhead. The code
hasn't
On Thu, Oct 22, 2009 at 1:39 PM, Evan Stade est...@chromium.org wrote:
Hi all,
At its last meeting the jank task force discussed improving
responsiveness of the spellchecker but we didn't come to a solid
conclusion so I thought I'd bring it up here to see if anyone else has
opinions. The
On Mon, Oct 19, 2009 at 7:27 AM, Evan Martin e...@chromium.org wrote:
On Sun, Oct 18, 2009 at 11:58 PM, Adam Barth aba...@chromium.org wrote:
It looks like Brent Fulgham is strongly considering moving his Windows
WebKit port to Skia:
On Mon, Oct 19, 2009 at 1:19 AM, David palm...@gmail.com wrote:
Someone knows where is a good guide for make an npapi plugin? and how
to call function to execute process...
Your best bet is probably starting with the layout test plugin:
I finished moving the last bit of string stuff in preparation for
separating ICU from base. All ICU and related utilities have moved to
src/base/i18n. The rest of base should not depend on base/i18n because
it will be a separate library, but base/i18n can depend on the rest of
base.
The core
On Wed, Oct 7, 2009 at 12:52 PM, Tony Chang t...@chromium.org wrote:
Actually, the original distinction was stuff that could be shared
across computers and stuff that couldn't be shared (i.e., local
state). I think originally this was for the difference between stuff
that a mounted home
On Wed, Oct 7, 2009 at 1:26 PM, Tony Chang t...@chromium.org wrote:
The quasi-defunct profile system that uses the enable-udd-profiles
still has a separate Local State file and safe browsing databases
because it used different user data directory (udd).
This change seems orthogonal to the
On Wed, Sep 30, 2009 at 12:18 AM, Andrew Scherkus scher...@chromium.org wrote:
I'm doing some video UI refactoring to use GraphicsContext but noticed
drawPath() is unimplemented (causes linker error).
What's a good practice to implementing something no one has ever used
before? Do we strive
On Tue, Sep 29, 2009 at 4:15 PM, Jeremy Orlow jor...@chromium.org wrote:
I'm guessing different people/companies will have different needs for a
kiosk mode.
Maybe all of these should be separate flags rather than one kiosk flag?
We could then offer recommendations in a Chromium for kiosks
On Tue, Sep 29, 2009 at 4:37 PM, Jeremy Orlow jor...@chromium.org wrote:
On Tue, Sep 29, 2009 at 4:20 PM, Brett Wilson bre...@chromium.org wrote:
On Tue, Sep 29, 2009 at 4:15 PM, Jeremy Orlow jor...@chromium.org wrote:
I'm guessing different people/companies will have different needs
On Thu, Sep 24, 2009 at 10:32 PM, Adam Barth aba...@chromium.org wrote:
On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher da...@chromium.org wrote:
Maybe I'm in the minority, but it doesn't sound that unreasonable to support
command line options for disabling the status bubble and starting in
On Thu, Sep 17, 2009 at 3:31 PM, Adam Langley a...@chromium.org wrote:
On Thu, Sep 17, 2009 at 3:03 PM, Peter Kasting pkast...@google.com wrote:
It's disappointing to me that this change was made without any bug in the
bug database linked, and without any input from a member of the UI team,
On Tue, Sep 15, 2009 at 7:31 PM, Mohamed Mansour
m0.interact...@gmail.com wrote:
Hi all,
I am having trouble trying to figure out how I could replace the contents of
a specific WebFrame while I am in RenderView with a custom DOMUI page that I
have created.
Here is a scenario:
User visits
On Thu, Sep 3, 2009 at 9:26 AM, Evan Martine...@chromium.org wrote:
Ok, I'll mark that I own this here and unassign it if I can't figure it out:
http://code.google.com/p/chromium/issues/detail?id=20991
On Thu, Sep 3, 2009 at 2:41 AM, Dean McNameede...@chromium.org wrote:
Ug, I can't
On Mon, Aug 31, 2009 at 8:56 AM, Mark Mentovaim...@chromium.org wrote:
I spent a chunk of last week looking at the new tab page performance
on startup on the Mac. I found that the renderer was waiting on data
from the browser process for what seemed like far too long. The key
to this
On Mon, Aug 31, 2009 at 9:17 AM, Brett Wilsonbre...@chromium.org wrote:
On Mon, Aug 31, 2009 at 8:56 AM, Mark Mentovaim...@chromium.org wrote:
I spent a chunk of last week looking at the new tab page performance
on startup on the Mac. I found that the renderer was waiting on data
from the
On Mon, Aug 31, 2009 at 10:13 AM, Marc-Antoine Ruelmar...@chromium.org wrote:
If you are not a committer, you can skip this message.
If you want to run layout tests as a try job, you can use the layout
try slaves. They are not in the default pool so you need to reference
them manually.
On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote:
I've heard people proclaim the principle of being able to copy a profile
across systems as being a deciding factor for certain changes (e.g. the
history epoch change). However, it doesn't seem to be universally held or
+finnur who did this for the about box.
Brett
On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote:
Argh. Forgot attachment.
On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote:
I'm playing with different ideas for the extension install dialog, and
I just checked in r24417 which changes the 0 for times on Mac
Linux (used to mean 1970) to match Windows (1601). This means that the
profiles can be copied between systems without getting the dates all
wrong, and should also fix some bugs related to cookie expiration (
On Mon, Aug 24, 2009 at 6:18 AM, Anand Mistryakmis...@gmail.com wrote:
I'm looking at the about:memory page and am wondering how useful is the
private VM field? Would it be just as good to have a total VM instead? The
reason I ask is because private VM doesn't map easily to Linux where
On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote:
Thanks. But the picture in the document shows there is only 1
ResourceDispatcherHost and there are 2 Renderer Processes:
http://dev.chromium.org/developers/design-documents/multi-process-architecture
And the
On Wed, Aug 19, 2009 at 1:23 PM, Darin Fisherda...@chromium.org wrote:
On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin e...@chromium.org wrote:
Rad that you're doing this!
I think that we shouldn't have any linux-specific directories except
for one or two cases where it's *really*
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while and hope it eventually converges to something better.
The changes in
On Wed, Aug 19, 2009 at 9:49 PM, Brett Wilsonbre...@chromium.org wrote:
On Wed, Aug 19, 2009 at 6:00 PM, Dean McNameede...@chromium.org wrote:
I kinda feel like this is one of those things you can try hard to
premeditate, but in the end you'll just have to deal with it being
ugly for a while
On Mon, Aug 17, 2009 at 11:19 PM, estelectronix...@gmail.com wrote:
Thanks for the explaination, Nick Carter.
I understand now, Chrome is a Google product while Chromium is a open-
source project.
Any thing else differs between Google Chrome and Chromium? I found
dictionaries missing from
On Mon, Aug 17, 2009 at 2:59 PM, Evan Stadeest...@chromium.org wrote:
I believe Brett meant to say chrome/renderer/render_{view,widget}.{h,cc}
They're both correct, depending on whether you want the browser or the renderer.
Brett
--~--~-~--~~~---~--~~
Chromium
On Wed, Aug 12, 2009 at 11:15 AM, Robert Sesekrse...@gmail.com wrote:
Two things about the Mac history menu that I'd like people to weigh in on:
1. The Show All History command should have a keyboard shortcut. We can't
use the logical Cmd+H because it's bound by the system. Stuart suggested
On Wed, Aug 12, 2009 at 12:18 PM, Avi Drissmana...@chromium.org wrote:
Brett—
Are we talking about the history page, or history items? The history page
gets its own tab, sure. But when someone picks an item from the history
menu, where does it go? I think current foreground tab is right,
On Mon, Aug 10, 2009 at 3:28 PM, Daniel Cowxdaniel.c...@gmail.com wrote:
Just wondering if there's any code kicking around somewhere in the
codebase for reading/writing INI files?
No, we don't deal with ini files at all to my knowledge. We use JSON
for that type of thing. What do you need it
On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhalkuch...@chromium.org wrote:
I thought to:user and -cc:user would work in this case? Have you tried
using that in Has the words on Filter edit screen?
One problem with this is that it doesn't fix the case where people
respond to the review mail via
On Sat, Aug 1, 2009 at 4:34 PM, Dan Kegeld...@kegel.com wrote:
I suppose you could try running the hunspell test suite itself
under valgrind. Their README tells how to do it, but
when I tried, I couldn't get it to work. (Wonder if that
means they haven't run it, either?)
Hi Dan,
Purify
I added myself to some watchlists and I get a bunch of email about a
lot of reviews
But this has confused my Gmail filters, which automatic ally label and
archive code reviews not addressed directly to me, and all of my CCd
code reviews show up in my inbox.
Anybody know how to reliably detect
On Sat, Jul 25, 2009 at 4:27 PM, n179911n179...@gmail.com wrote:
Hi,
For
http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code,
it said
For web content, this specialization is WebContents in
chrome/browser/web_contents.cc. There are also a few other types for
On Wed, Jul 22, 2009 at 2:58 PM, Adam Langleya...@chromium.org wrote:
On Wed, Jul 22, 2009 at 9:50 PM, Darin Fisherda...@google.com wrote:
Personally, I much prefer the #include png.h approach. Is it a problem to
wait for the GYP change that makes this possible?
Well, I could make it
On Tue, Jul 21, 2009 at 8:42 AM, Nicolas Sylvainnsylv...@chromium.org wrote:
On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. phajdan...@chromium.org
wrote:
Can we have a trybot with that configuration, which would just compile the
code? I think it would really save people's time. I never
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote:
WebCore::String has the interesting property of differentiating between an
empty string and a null string. In string16, however, there is no such thing
as null.
The LocalStorage implementation I'm working on proxies data
On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote:
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote:
On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote:
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote
On Tue, Jul 7, 2009 at 6:20 PM, Andrew Scherkusscher...@google.com wrote:
According to the watchlist file, brettw is watching base from /src
kylep sent me a code review that only modifies touches files in
/src/media/base, however brettw got added to the cc list.
Is this intended behavior for
On Fri, Jul 3, 2009 at 12:00 AM, Dmitry.Skibadmitry.sk...@gmail.com wrote:
Recently I was playing with hunspell and got very displeased with its
code (which claims to be cpp, but in fact 'classified' c). I even
started to think about rewriting it in, you know, correct cpp. Then
I realized
Our team has had somewhat of an ad-hoc approach to organizing code
that's different across platforms. In many cases our approach has been
quite good. In others, less so, and there have also been questions
about what the preferred method for writing a certain component in a
cross-platform way.
On Fri, Jun 19, 2009 at 1:15 PM, Sverrir Á. Bergsver...@chromium.org wrote:
I'm hoping to be able to add Icelandic spelling check to Chrome Before I
invest a lot of time I have some quick questions/observations:
I found an myspell/aspell dictionary for Open Office
here:
There are a surprising number of comic characters on here. I bet you
know Meryl Silverburgh!
Generally this type of thing is on the dev site like here:
http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
Brett
--~--~-~--~~~---~--~~
I was informed that I may have broken mac tab contents painting in
18363. I have to leave now, so if this is causing you problems you can
back me out.
If somebody wants to fix it instead, I'll make you chocolate chip cookies :)
Brett
--~--~-~--~~~---~--~~
On Sat, Jun 6, 2009 at 11:13 PM, meryl silverburgh.me...@gmail.com wrote:
Hi,
I add debug print status in BrowserRenderProcessHost::OnPageContents
() to print out the value of 'contents'
void BrowserRenderProcessHost::OnPageContents(const GURL url,
On Wed, Jun 3, 2009 at 1:00 PM, Aaron Boodman a...@chromium.org wrote:
[I actually created this awhile ago, but never sent it 'round]
It is really common for extensions to want to offer additional
contextual options for content elements. For example Download this
movie, edit this image,
On Tue, Jun 2, 2009 at 4:57 PM, Meryl Silverburgh
silverburgh.me...@gmail.com wrote:
I am reading this document
http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code;
about chromium source code:
It said:
renderer: Code for the subprocess in each tab. This embeds
When I landed the WebKIt integration this morning a bunch of the bots
needed clobbering due to linker errors. The errors were missing V8
handles while linking generate_profile.
I haven't seen any of the commonly-compiled projects fail because of
this, so it's possible you don't have to clobber
On Wed, May 27, 2009 at 11:56 AM, Amanda Walker ama...@chromium.org wrote:
On Tue, May 26, 2009 at 11:31 PM, Brett Wilson bre...@chromium.org wrote:
Don't bother doing an assertion when the next line will crash anyway:
DCHECK(foo);
foo-DoSomething();
will normally crash pretty obviously
On Wed, May 13, 2009 at 12:39 PM, Darin Fisher da...@chromium.org wrote:
That is what I meant by pain
It only applies to third party code that conforms to the google style
guide, which says that all include paths must be relative to the root. Come
to think of it, I think this could cause
On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote:
Perhaps what we need is a companion to FilePath. For example:
FilePath: much as it is now, lightweight, alternative to string
manipulation.
FileReference: heavierweight, can talk to the file system and have
carnal
On Wed, May 13, 2009 at 4:34 PM, Amanda Walker ama...@chromium.org wrote:
On Wed, May 13, 2009 at 7:07 PM, Brett Wilson bre...@chromium.org wrote:
On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org wrote:
Perhaps what we need is a companion to FilePath. For example
On Wed, May 13, 2009 at 6:12 PM, Greg Spencer gspen...@google.com wrote:
On Wed, May 13, 2009 at 4:07 PM, Brett Wilson bre...@chromium.org wrote:
On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org
wrote:
Perhaps what we need is a companion to FilePath. For example
On Wed, May 13, 2009 at 7:24 PM, Brett Wilson bre...@chromium.org wrote:
On Wed, May 13, 2009 at 6:12 PM, Greg Spencer gspen...@google.com wrote:
On Wed, May 13, 2009 at 4:07 PM, Brett Wilson bre...@chromium.org wrote:
On Wed, May 13, 2009 at 3:51 PM, Amanda Walker ama...@chromium.org
wrote
On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org
wrote:
I'm in the process of updating chromium to use tip-of-tree skia, and in
the same CL, moving skia to a third_party directory,
retrieved
2009/5/6 Andrew Scherkus scher...@chromium.org:
On Tue, May 5, 2009 at 9:49 PM, Albert J. Wong (王重傑) ajw...@chromium.org
wrote:
On Tue, May 5, 2009 at 9:38 PM, Amanda Walker ama...@chromium.org wrote:
Ah, I see. Hmm, going in that direction (from a GraphicsContext back
up to the
On Wed, May 6, 2009 at 8:40 AM, Andrew Scherkus scher...@chromium.org wrote:
WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in
a GraphicsContext:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup
On Sat, May 2, 2009 at 6:09 AM, Evan Martin e...@chromium.org wrote:
The suggestions on that code review are good: we ought to measure how
many fonts normal users see, and then pick the cache tuning parameter
accordingly.
Adam Barth is a good person to ask about how to do this, since he
2009/5/1 Mohamed Mansour m0.interact...@gmail.com:
Why wouldn't we just use std::string ? Many places in the code uses
std::string. DictionaryValue needs to be converted as well as many others.
So what do we finally decide, go what Pink stated and use char* or use
std::string.
I believe the
On Mon, Apr 27, 2009 at 8:05 AM, Mike Pinkerton pinker...@chromium.org wrote:
On Sun, Apr 26, 2009 at 5:50 PM, Amanda Walker ama...@chromium.org wrote:
Application startup is one of the areas where we count every
millisecond, and try to touch the disk as little as possible. I don't
think
I just moved the remaining methods from WebContents to TabContents. I
kept the methods and data members the same, just merged the classes,
so it should be easy to find what you're looking for (or to resolve
conflicts if you have local changes to web_contents.cc). Hopefully
this will make the
On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman a...@chromium.org wrote:
Is it possible to enforce these rules with code rather than capital letters?
I don't think I've made this particular error, but it's something I
could see myself doing. From their names, chrome/common seems like a
On Mon, Apr 13, 2009 at 11:01 AM, Tim Steele t...@chromium.org wrote:
I don't know of a reason we need more than 1 history thread, but I can't say
for sure.
HistoryService is responsible today for starting/stopping/destroying the
history thread, so if we have multiple services then we need
On Fri, Apr 10, 2009 at 12:42 PM, Evan Stade est...@chromium.org wrote:
a) wrap the clipboard calls in gtk_threads_{enter,leave}(). This makes
the calls thread safe, but it does so by locking a process-wide mutex,
which will block our UI thread's main loop.
I personally think this is OK.
On Wed, Apr 8, 2009 at 7:48 PM, Nick Baum nickb...@chromium.org wrote:
Hi all,
I fleshed out a few more APIs. I've put them in separate documents since the
API pattern doc was getting a bit long. Below are some notes, feedback
appreciated.
In particular, I'd love feedback from Scott on
On Mon, Mar 30, 2009 at 10:12 AM, Jian Li jia...@chromium.org wrote:
I got another failure for checkdeps:
ERROR in
C:/b/slave/chromium-rel-builder/build/src\chrome\test\worker\test_webworker.cc
Illegal include: webkit/tools/test_shell/test_webworker_helper.h
Because of -webkit from
On Fri, Mar 27, 2009 at 1:50 PM, Book'em Dano daniel.c...@gmail.com wrote:
At the top of sandbox\src\interception.h, it refers the reader to:
http://wiki/Main/ChromeSandboxInterceptionDesign. Does anyone know
where this document can be found?
The sandbox info on
On Thu, Mar 26, 2009 at 9:41 AM, Aaron Boodman a...@chromium.org wrote:
I'm starting to dig into implementing the tab and window API as a
first example of all the other browser-automation type APIs we
eventually want to implement for extensions.
One of my early assumptions was that the APIs
On Thu, Mar 26, 2009 at 10:09 AM, Aaron Boodman a...@chromium.org wrote:
On Thu, Mar 26, 2009 at 9:52 AM, Brett Wilson bre...@chromium.org wrote:
What would IDs refer to in history?
I've only barely looked into the history data model, but I was hoping
it would be a persistent ID for each
On Thu, Mar 26, 2009 at 11:37 AM, Aaron Boodman a...@chromium.org wrote:
On Thu, Mar 26, 2009 at 11:22 AM, Brett Wilson bre...@chromium.org wrote:
Those are exposed, but I wonder which cases an extension needs to
refer to them. They are internal IDs generated by sqlite. If you clear
your
On Wed, Mar 25, 2009 at 10:16 AM, Alex Russell slightly...@google.com wrote:
MSFT did a new set of fonts to take specific advantage of ClearType:
http://www.microsoft.com/typography/ClearTypeFonts.mspx
The Core Fonts are still available and installed by default on all
windows versions that
As Peter said, the ScrollBar object is not responsible for drawing
scroll bars on pages, which is what the bug is about.
Brett
On Wed, Mar 25, 2009 at 1:15 PM, Mohamed Mansour
m0.interact...@gmail.com wrote:
There is no context menu for the ScrollBar.
-m0
On Wed, Mar 25, 2009 at 3:55
I would do the thin Objective C mode, partially since all Chrome
developers know C++. I could debug that code or make changes to it if
I was doing something that affected it, but I would have a much harder
time with Objective-C.
Brett
On Thu, Mar 19, 2009 at 4:00 PM, Scott Hess
On Mon, Mar 16, 2009 at 4:25 PM, Marshall Greenblatt
magreenbl...@gmail.com wrote:
My needs in this case are related to the Chromium Embedded Framework (CEF).
The code currently works as follows:
1. Retrieve our custom WebViewDelegate instance pointer via the WebFrame
pointer passed to
On Sun, Mar 15, 2009 at 7:37 AM, Dean McNamee de...@chromium.org wrote:
I had a discussion about Views with Scott. I think I am on the side
of the fence that porting views it not a good idea. One of the things
that came up is remote X, would it be possible to ever have good
remote X
On Sun, Mar 15, 2009 at 10:09 AM, Adam Langley a...@chromium.org wrote:
On Sun, Mar 15, 2009 at 8:55 AM, Dean McNamee de...@chromium.org wrote:
UI elements like buttons are different, my understanding is that (at
least in theory) it should be possible for all of those images of the
different
On Tue, Mar 10, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
I actually don't know. It seems like just simple state gathering but it
might be more.
The big concern is that it fits our model but no one else's. Everyone else
is OK with the UI asking the renderer questions directly, and
On Wed, Mar 11, 2009 at 10:01 AM, Avi Drissman a...@google.com wrote:
Most platforms (meaning not Chrome) have the ability, when the user pulls
down a menu, to adjust the states of the menu items within. For them, when
the user selects the Edit menu, they're OK calling into WebCore and asking
On Wed, Mar 11, 2009 at 10:11 AM, Amanda Walker ama...@chromium.org wrote:
On Wed, Mar 11, 2009 at 2:07 PM, Brett Wilson bre...@chromium.org wrote:
Do you mean when you click on the menu, blocking the browser until the
renderer responds with whether the menus can be enabled? I would
On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote:
On the Mac, code like this:
namespace {
class MyTest : public testing::Test {
};
} // namespace
TEST_F(MyTest, ATest) {
}
generates errors like this:
warning: ‘MyTest_ATest_Test’ has a field
On Tue, Mar 3, 2009 at 4:49 PM, William Chan (陈智昌)
willc...@chromium.org wrote:
My old team never really used FRIEND_TEST. We found it ugly that our
production code depended on test code. We typically used friended
Peer classes defined in the unittest file, but not in the anonymous
On Thu, Feb 26, 2009 at 7:59 PM, eager_learner
vijay.sankar.ra...@gmail.com wrote:
Hello
I am trying to integrate test a third party library available in
source into the Visual Studio 2008 Pro environment. The problem seems
to be that the third_party/libxml/win32/include/xmlversion.h file
On Tue, Feb 17, 2009 at 3:43 PM, Marc-Andre Decoste m...@google.com wrote:
Salut,
I'm looking for a way to know, at the BrowserView (or even at
the RenderWidgetHostViewWin) level, if there is one, and only one scroll bar
visible. I thought I could ask Windows with ::GetScrollBarInfo, but
On Thu, Feb 5, 2009 at 9:29 PM, Ian Fette i...@chromium.org wrote:
Once again, my laptop is refusing to stand by and Windows is throwing up
warning dialogs about Insufficient system resources exist to complete the
API. Currently Chrome is sucking down a healthy 1043 gdi handles according
to
2009/2/4 Paweł Hajdan Jr. phajdan...@chromium.org:
I recently tried to port chrome/browser/safe_browsing/protocol_manager.cc to
Linux, but there's one problem. ProtocolManager uses hash_map of
URLFetcher*-s, and GCC needs a hash function for it.
I see many ways we can deal with that, and I
On Wed, Feb 4, 2009 at 2:58 PM, Adam Langley a...@chromium.org wrote:
If you've ever tried running strace on our binaries, you've probably
noticed the Ubuntu version messes up a lot because it cannot decode
the 32-bit structures correctly. For example:
[pid 21205] ... recvmsg resumed
On Tue, Feb 3, 2009 at 9:05 PM, t...@chromium.org wrote:
What evan means is that after downloading the tar ball, you need to run
gclient sync to get all the platform specific dependencies.
We recently started generating the source tar ball on a regular basis and
it doesn't include all the
There are a lot of patches lately with a lot of reviewers on them,
especially related to porting since a lot of people might need to be
in the loop for some changes.
The problem is that there's no clear responsibility given in these
reviews. If I'm the sole reviewer on a change, I know I have to
On Fri, Jan 16, 2009 at 9:32 AM, Sverrir Á. Berg sver...@google.com wrote:
I'm running these tests:
http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking-decorations.html
http://trac.webkit.org/export/39759/trunk/LayoutTests/fast/text/stroking.html
It seems that our font
I'm currently doing a 2-day merge rotation.As part of this, various
layout tests are regressing or getting added that I'm inserting into
the tests_fixable list.
But, like every other layout test fixer, after my merges are done,
I'll finally go back to my old work and not think about it any more.
On Thu, Jan 15, 2009 at 1:20 PM, Pam Greene p...@chromium.org wrote:
When fixing layout tests only means re-baselining, that's easy. But
sometimes they break (or new ones fail) for deeper reasons, and the person
doing the merge may not be the right one to make the fix (or may not be able
to
On Thu, Jan 15, 2009 at 1:19 PM, Amanda Walker ama...@chromium.org wrote:
That's true. In the example I gave (Mac driver loading), each module
has a property list that lists its dependencies (and version
requirements, etc.). That's not quite as simple to do inside a single
application, of
On Wed, Jan 14, 2009 at 6:22 PM, Evan Martin e...@chromium.org wrote:
Our CommandLine class is very confusing -- it is not a class for
working with command lines, but in fact a stealth singleton that wraps
the command line used to start the process.
Further, since it came from Windows, it
1 - 100 of 126 matches
Mail list logo
