[GitHub] [airflow] stale[bot] closed pull request #6290: [AIRFLOW-5618] Remove copy of pygments style

2019-12-02 Thread GitBox
stale[bot] closed pull request #6290: [AIRFLOW-5618] Remove copy of pygments style URL: https://github.com/apache/airflow/pull/6290 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352497006 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[jira] [Created] (AIRFLOW-6145) Rename local_to_gcs service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6145: --- Summary: Rename local_to_gcs service Key: AIRFLOW-6145 URL: https://issues.apache.org/jira/browse/AIRFLOW-6145 Project: Apache Airflow Issue

[GitHub] [airflow] codecov-io edited a comment on issue #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements URL: https://github.com/apache/airflow/pull/6686#issuecomment-559765152 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6686?src=pr=h1) Report > :exclamation:

[GitHub] [airflow] codecov-io edited a comment on issue #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements URL: https://github.com/apache/airflow/pull/6686#issuecomment-559765152 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6686?src=pr=h1) Report > :exclamation:

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352494761 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[GitHub] [airflow] codecov-io commented on issue #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler

2019-12-02 Thread GitBox
codecov-io commented on issue #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler URL: https://github.com/apache/airflow/pull/6710#issuecomment-560314022 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6710?src=pr=h1) Report > Merging

[GitHub] [airflow] feluelle commented on a change in pull request #6705: [AIRFLOW-6142] Fix different local/Travis pylint results

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6705: [AIRFLOW-6142] Fix different local/Travis pylint results URL: https://github.com/apache/airflow/pull/6705#discussion_r352505508 ## File path: scripts/ci/_utils.sh ## @@ -81,7 +81,7 @@ function print_info() { declare

[jira] [Created] (AIRFLOW-6151) Rename adls_to_gcs service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6151: --- Summary: Rename adls_to_gcs service Key: AIRFLOW-6151 URL: https://issues.apache.org/jira/browse/AIRFLOW-6151 Project: Apache Airflow Issue

[GitHub] [airflow] ToxaZ opened a new pull request #6711: Add Wrike as official user of airflow

2019-12-02 Thread GitBox
ToxaZ opened a new pull request #6711: Add Wrike as official user of airflow URL: https://github.com/apache/airflow/pull/6711 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-6147) Rename gcs_to_s3 service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6147: --- Summary: Rename gcs_to_s3 service Key: AIRFLOW-6147 URL: https://issues.apache.org/jira/browse/AIRFLOW-6147 Project: Apache Airflow Issue

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352495420 ## File path: airflow/__init__.py ## @@ -44,23 +44,8 @@ settings.initialize()

[jira] [Commented] (AIRFLOW-5618) Remove copy of pygments style

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985933#comment-16985933 ] ASF GitHub Bot commented on AIRFLOW-5618: - stale[bot] commented on pull request #6290:

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352498412 ## File path: airflow/executors/base_executor.py ## @@ -16,67 +14,86 @@ # KIND, either

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352498858 ## File path: airflow/executors/celery_executor.py ## @@ -57,17 +61,17 @@

[jira] [Created] (AIRFLOW-6148) Rename gcs_to_gcs service

2019-12-02 Thread Jira
Michał Słowikowski created AIRFLOW-6148: --- Summary: Rename gcs_to_gcs service Key: AIRFLOW-6148 URL: https://issues.apache.org/jira/browse/AIRFLOW-6148 Project: Apache Airflow Issue

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352484749 ## File path: airflow/contrib/hooks/emr_hook.py ## @@

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352485257 ## File path: airflow/contrib/operators/emr_add_steps_operator.py

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352486516 ## File path:

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352485757 ## File path: airflow/contrib/hooks/emr_hook.py ## @@

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352484275 ## File path: airflow/contrib/hooks/emr_hook.py ## @@

[GitHub] [airflow] ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6655: [AIRFLOW-6056] Allow EmrAddStepsOperator to accept job_flow_name as alternative to job_flow_id URL: https://github.com/apache/airflow/pull/6655#discussion_r352484939 ## File path: airflow/contrib/operators/emr_add_steps_operator.py

[jira] [Commented] (AIRFLOW-4355) Externally triggered DAG is marked as 'success' even if a task has been 'removed'!

2019-12-02 Thread Pramod Bisht (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985924#comment-16985924 ] Pramod Bisht commented on AIRFLOW-4355: --- [~ash]  [~toopt4] I am also facing the same issue,  is

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352499486 ## File path: airflow/executors/celery_executor.py ## @@ -264,30 +284,45 @@ def

[GitHub] [airflow] codecov-io commented on issue #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke

2019-12-02 Thread GitBox
codecov-io commented on issue #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke URL: https://github.com/apache/airflow/pull/6704#issuecomment-560332188 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6704?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke URL: https://github.com/apache/airflow/pull/6704#issuecomment-560332188 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6704?src=pr=h1) Report > Merging

[GitHub] [airflow] shaikshakeel commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator

2019-12-02 Thread GitBox
shaikshakeel commented on issue #6469: [AIRFLOW-5816] S3 to snowflake operator URL: https://github.com/apache/airflow/pull/6469#issuecomment-560348447 @feluelle can you confirm this? This is an automated message from the

[GitHub] [airflow] ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638#discussion_r352547908 ## File path: tests/models/test_dag.py ## @@ -968,3 +968,14 @@ def

[GitHub] [airflow] zhongjiajie commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3 [DO NOT MERGE]

2019-12-02 Thread GitBox
zhongjiajie commented on issue #5659: [AIRFLOW-5033] Switched to snakebite-py3 [DO NOT MERGE] URL: https://github.com/apache/airflow/pull/5659#issuecomment-560357775 That great, Thanks @Tagar This is an automated message

[GitHub] [airflow] robinedwards commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats

2019-12-02 Thread GitBox
robinedwards commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats URL: https://github.com/apache/airflow/pull/6684#discussion_r352555482 ## File path: airflow/www/views.py ## @@ -334,11 +334,20 @@ def task_stats(self,

[GitHub] [airflow] ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats URL: https://github.com/apache/airflow/pull/6684#discussion_r352555841 ## File path: airflow/www/views.py ## @@ -347,47 +356,48 @@ def task_stats(self, session=None):

[GitHub] [airflow] potiuk commented on issue #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler

2019-12-02 Thread GitBox
potiuk commented on issue #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler URL: https://github.com/apache/airflow/pull/6710#issuecomment-560372076 Thanks @seii-saintway ! This is an automated message from

[jira] [Commented] (AIRFLOW-6144) Improve the log message of airflow scheduler

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986014#comment-16986014 ] ASF subversion and git services commented on AIRFLOW-6144: -- Commit

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352567425 ## File path: airflow/plugins_manager.py ## @@ -187,26 +192,29 @@ def make_module(name,

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352567794 ## File path: airflow/plugins_manager.py ## @@ -16,17 +15,18 @@ # KIND, either express

[GitHub] [airflow] ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638#discussion_r352574872 ## File path: tests/models/test_dag.py ## @@ -968,3 +968,14 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352582321 ## File path: airflow/jobs/base_job.py ## @@ -171,17 +171,14 @@ def

[GitHub] [airflow] ashb edited a comment on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables

2019-12-02 Thread GitBox
ashb edited a comment on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables URL: https://github.com/apache/airflow/pull/6706#issuecomment-560383931 @potiuk Am I right in thinking that `# pylint:disable-x` is always wrong and we need the space after `:`? If so I'll add a

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352553141 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links - Airflow users mailing list: ``_ -- `Issues on

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352561195 ## File path: airflow/executors/dask_executor.py ## @@ -55,23 +58,28 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352566346 ## File path: airflow/models/dagbag.py ## @@ -406,8 +404,10 @@ def collect_dags(

[GitHub] [airflow] ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638#discussion_r352579797 ## File path: tests/models/test_dag.py ## @@ -968,3 +968,14 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r35258 ## File path: tests/jobs/test_local_task_job.py ## @@ -43,6 +43,9 @@

[GitHub] [airflow] ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352582982 ## File path: airflow/jobs/local_task_job.py ## @@ -112,13 +111,6 @@ def

[jira] [Updated] (AIRFLOW-6134) Scheduler hanging every 45 minutes, workers hanging on every job

2019-12-02 Thread Brent Driskill (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brent Driskill updated AIRFLOW-6134: Component/s: worker > Scheduler hanging every 45 minutes, workers hanging on every job >

[jira] [Updated] (AIRFLOW-6134) Scheduler hanging every 45 minutes, workers hanging on every job

2019-12-02 Thread Brent Driskill (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brent Driskill updated AIRFLOW-6134: Summary: Scheduler hanging every 45 minutes, workers hanging on every job (was:

[jira] [Commented] (AIRFLOW-3407) BaseOperator and LoggingMixin do not call super().__init__

2019-12-02 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986140#comment-16986140 ] Ash Berlin-Taylor commented on AIRFLOW-3407: It's probably okay/right for BaseOperator not

[GitHub] [airflow] codecov-io edited a comment on issue #6692: [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6692: [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible URL: https://github.com/apache/airflow/pull/6692#issuecomment-559966254 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6692?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6692: [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6692: [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible URL: https://github.com/apache/airflow/pull/6692#issuecomment-559966254 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6692?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352654863 ## File path: CONTRIBUTING.rst ## @@ -267,348 +264,34 @@ Limitations: They are optimized for repeatability of tests,

[GitHub] [airflow] potiuk commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352654863 ## File path: CONTRIBUTING.rst ## @@ -267,348 +264,34 @@ Limitations: They are optimized for repeatability of tests,

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352629189 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352628244 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352657847 ## File path: airflow/contrib/operators/neo4j_operator.py ## @@ -0,0 +1,115 @@ +# -*- coding: utf-8 -*- +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352655261 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352655006 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352628599 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352659460 ## File path: tests/contrib/hooks/test_neo4j_hook.py ## @@ -0,0 +1,91 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352629659 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook

2019-12-02 Thread GitBox
feluelle commented on a change in pull request #6604: [AIRFLOW-5920] Neo4j operator and hook URL: https://github.com/apache/airflow/pull/6604#discussion_r352653613 ## File path: airflow/contrib/hooks/neo4j_hook.py ## @@ -0,0 +1,101 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] Khrol commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
Khrol commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638#discussion_r352555018 ## File path: tests/models/test_dag.py ## @@ -968,3 +968,14 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats URL: https://github.com/apache/airflow/pull/6684#discussion_r352555071 ## File path: airflow/www/views.py ## @@ -334,11 +334,20 @@ def task_stats(self, session=None):

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352565100 ## File path: airflow/logging_config.py ## @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*-

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352565842 ## File path: airflow/models/dag.py ## @@ -1254,9 +1253,11 @@ def run( """

[GitHub] [airflow] ashb commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
ashb commented on issue #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#issuecomment-560375970 (Will likely conflict with #6596) This is an

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352552498 ## File path: CONTRIBUTING.rst ## @@ -742,8 +495,56 @@ Resources & links Review comment: Can't comment on the line here,

[GitHub] [airflow] ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats URL: https://github.com/apache/airflow/pull/6684#discussion_r352554650 ## File path: airflow/www/templates/airflow/dags.html ## @@ -403,7 +405,7 @@ DAGs

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352563506 ## File path: airflow/executors/local_executor.py ## @@ -43,40 +42,44 @@ This option

[GitHub] [airflow] kaxil merged pull request #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke

2019-12-02 Thread GitBox
kaxil merged pull request #6704: [AIRFLOW-6141] Remove ReadyToRescheduleDep if sensor mode == poke URL: https://github.com/apache/airflow/pull/6704 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352563810 ## File path: airflow/executors/local_executor.py ## @@ -43,40 +42,44 @@ This option

[GitHub] [airflow] codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128] URL: https://github.com/apache/airflow/pull/6597#issuecomment-560382310 #

[GitHub] [airflow] codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128] URL: https://github.com/apache/airflow/pull/6597#issuecomment-560382310 #

[GitHub] [airflow] codecov-io commented on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128]

2019-12-02 Thread GitBox
codecov-io commented on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128] URL: https://github.com/apache/airflow/pull/6597#issuecomment-560382310 #

[GitHub] [airflow] codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128]

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6597: [AIRFLOW-6005] Common classes should always be imported from airflow, Depends on [AIRFLOW-6004] [AIRFLOW-6140] [AIRFLOW-6128] URL: https://github.com/apache/airflow/pull/6597#issuecomment-560382310 #

[GitHub] [airflow] ashb merged pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
ashb merged pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate URL: https://github.com/apache/airflow/pull/6553#discussion_r352585323 ## File path: tests/jobs/test_local_task_job.py ## @@ -43,6 +43,9 @@

[jira] [Commented] (AIRFLOW-6134) Scheduler hanging every 45 minutes

2019-12-02 Thread Brent Driskill (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986044#comment-16986044 ] Brent Driskill commented on AIRFLOW-6134: - Digging into it a little more, I see the following:

[GitHub] [airflow] kaxil merged pull request #6711: Add Wrike as official user of airflow

2019-12-02 Thread GitBox
kaxil merged pull request #6711: Add Wrike as official user of airflow URL: https://github.com/apache/airflow/pull/6711 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] ashb commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#discussion_r352546049 ## File path: airflow/jobs/__init__.py ## @@ -23,4 +23,4 @@ from

[GitHub] [airflow] ashb commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class URL: https://github.com/apache/airflow/pull/6697#discussion_r352545774 ## File path: airflow/jobs/scheduler_job.py ## @@ -54,8 +54,9 @@ from

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352550769 ## File path: CONTRIBUTING.rst ## @@ -267,348 +264,34 @@ Limitations: They are optimized for repeatability of tests,

[GitHub] [airflow] ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6684: [AIRFLOW-6095] Filter dags returned by task_stats URL: https://github.com/apache/airflow/pull/6684#discussion_r352556361 ## File path: tests/www/test_views.py ## @@ -1405,6 +1405,20 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352563040 ## File path: airflow/executors/kubernetes_executor.py ## @@ -601,18 +629,19 @@ def

[GitHub] [airflow] Khrol commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag

2019-12-02 Thread GitBox
Khrol commented on a change in pull request #6638: [AIRFLOW-6043] Update dag reference to all tasks in sub_dag URL: https://github.com/apache/airflow/pull/6638#discussion_r352577332 ## File path: tests/models/test_dag.py ## @@ -968,3 +968,14 @@ def

[jira] [Commented] (AIRFLOW-6043) `Dag.sub_dag` method keeps references to origin dag

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986033#comment-16986033 ] ASF subversion and git services commented on AIRFLOW-6043: -- Commit

[jira] [Commented] (AIRFLOW-6043) `Dag.sub_dag` method keeps references to origin dag

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986032#comment-16986032 ] ASF GitHub Bot commented on AIRFLOW-6043: - ashb commented on pull request #6638: [AIRFLOW-6043]

[jira] [Resolved] (AIRFLOW-6043) `Dag.sub_dag` method keeps references to origin dag

2019-12-02 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-6043. Fix Version/s: 1.10.7 Resolution: Fixed > `Dag.sub_dag` method keeps

[GitHub] [airflow] codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-559224555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6596?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-559224555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6596?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on a change in pull request #6585: More GSOD improvements

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#discussion_r352550619 ## File path: CONTRIBUTING.rst ## @@ -267,348 +264,34 @@ Limitations: They are optimized for repeatability of tests,

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352562023 ## File path: airflow/executors/kubernetes_executor.py ## @@ -241,17 +253,23 @@ def

[jira] [Commented] (AIRFLOW-6141) The sensor cannot be executed by invalid deps

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986011#comment-16986011 ] ASF GitHub Bot commented on AIRFLOW-6141: - kaxil commented on pull request #6704:

[jira] [Resolved] (AIRFLOW-6141) The sensor cannot be executed by invalid deps

2019-12-02 Thread Kaxil Naik (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-6141. - Fix Version/s: 1.10.7 Resolution: Fixed > The sensor cannot be executed by invalid deps

[jira] [Resolved] (AIRFLOW-6144) Improve the log message of airflow scheduler

2019-12-02 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-6144. --- Resolution: Fixed > Improve the log message of airflow scheduler >

[jira] [Commented] (AIRFLOW-6144) Improve the log message of airflow scheduler

2019-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986013#comment-16986013 ] ASF GitHub Bot commented on AIRFLOW-6144: - potiuk commented on pull request #6710:

[jira] [Commented] (AIRFLOW-6141) The sensor cannot be executed by invalid deps

2019-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986012#comment-16986012 ] ASF subversion and git services commented on AIRFLOW-6141: -- Commit

[GitHub] [airflow] potiuk merged pull request #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler

2019-12-02 Thread GitBox
potiuk merged pull request #6710: [AIRFLOW-6144] Improve the log message of airflow scheduler URL: https://github.com/apache/airflow/pull/6710 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-12-02 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352568182 ## File path: airflow/settings.py ## @@ -68,13 +67,13 @@ LOG_FORMAT = conf.get('core',

[GitHub] [airflow] ashb commented on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables

2019-12-02 Thread GitBox
ashb commented on issue #6706: [AIRFLOW-6143] Remove master-failing pylint:disables URL: https://github.com/apache/airflow/pull/6706#issuecomment-560383931 @potiuk Am I right in thinking that `# pylint:disable-x` is always wrong and we need the space after `:`? If so I'll add a pre-commit

[GitHub] [airflow] potiuk commented on issue #6585: More GSOD improvements

2019-12-02 Thread GitBox
potiuk commented on issue #6585: More GSOD improvements URL: https://github.com/apache/airflow/pull/6585#issuecomment-560392090 > I wonder if the images should live under docs/images/ instead of just images/? I think those documents are not part of the user docs - they are developer's

<    1   2   3   >