[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153195877 --- Diff: aria/parser/reading/reader.py --- @@ -28,16 +28,9 @@ def __init__(self, context, location, loader): def load(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153196429 --- Diff: aria/utils/threading.py --- @@ -161,11 +242,7 @@ def close(self): self._workers = None def drain(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153148567 --- Diff: aria/parser/reading/yaml.py --- @@ -82,7 +84,11 @@ def read(self): # see issue here: # https

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153150480 --- Diff: aria/utils/threading.py --- @@ -93,7 +92,104 @@ def sum(arg1, arg2): print executor.returns

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153151961 --- Diff: aria/parser/loading/loader.py --- @@ -32,3 +32,6 @@ def close(self): def load(self): raise

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-27 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r153152535 --- Diff: aria/parser/loading/uri.py --- @@ -44,6 +45,7 @@ def __init__(self, context, location, origin_location=None

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151468906 --- Diff: extensions/aria_extension_tosca/simple_v1_0/assignments.py --- @@ -144,6 +144,17 @@ def _get_type(self, context

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151405515 --- Diff: aria/parser/reading/yaml.py --- @@ -82,7 +84,11 @@ def read(self): # see issue here: # https

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151187582 --- Diff: aria/parser/loading/loader.py --- @@ -32,3 +32,6 @@ def close(self): def load(self): raise

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151419226 --- Diff: aria/utils/threading.py --- @@ -161,11 +242,7 @@ def close(self): self._workers = None def drain(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151401197 --- Diff: aria/parser/presentation/presentation.py --- @@ -199,6 +199,9 @@ class Presentation(PresentationBase): """

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151400932 --- Diff: aria/parser/presentation/presentation.py --- @@ -199,6 +199,9 @@ class Presentation(PresentationBase): """

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151402533 --- Diff: aria/parser/reading/reader.py --- @@ -28,16 +28,9 @@ def __init__(self, context, location, loader): def load(self

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151080284 --- Diff: aria/__init__.py --- @@ -47,22 +46,19 @@ def install_aria_extensions(strict=True): """ -

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151404126 --- Diff: aria/parser/reading/yaml.py --- @@ -16,18 +16,30 @@ from .reader import Reader from .locator import Locator from

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151394538 --- Diff: aria/parser/loading/uri.py --- @@ -44,6 +45,7 @@ def __init__(self, context, location, origin_location=None

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151185189 --- Diff: aria/parser/consumption/presentation.py --- @@ -13,15 +13,16 @@ # See the License for the specific language governing permissions

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151185309 --- Diff: aria/parser/consumption/presentation.py --- @@ -31,47 +32,33 @@ class Read(Consumer): instances. It supports

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151398089 --- Diff: aria/parser/presentation/field_validators.py --- @@ -14,12 +14,29 @@ # limitations under the License. +from

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151087783 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151402149 --- Diff: aria/parser/consumption/presentation.py --- @@ -86,52 +73,193 @@ def dump(self): self.context.presentation.presenter

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151396216 --- Diff: aria/parser/loading/uri.py --- @@ -85,6 +91,11 @@ def close(self): def load(self): return self._loader.load

[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

2017-11-20 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151408981 --- Diff: aria/utils/threading.py --- @@ -93,7 +92,104 @@ def sum(arg1, arg2): print executor.returns

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152312803 --- Diff: aria/orchestrator/execution_preparer.py --- @@ -31,70 +31,79 @@ DEFAULT_TASK_RETRY_INTERVAL = 30 -class

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152311655 --- Diff: aria/orchestrator/execution_preparer.py --- @@ -31,70 +31,79 @@ DEFAULT_TASK_RETRY_INTERVAL = 30 -class

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152310821 --- Diff: aria/orchestrator/execution_preparer.py --- @@ -31,70 +31,79 @@ DEFAULT_TASK_RETRY_INTERVAL = 30 -class

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152312142 --- Diff: aria/orchestrator/execution_preparer.py --- @@ -31,70 +31,79 @@ DEFAULT_TASK_RETRY_INTERVAL = 30 -class

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152283978 --- Diff: tests/orchestrator/execution/test_execution_compiler.py --- @@ -296,171 +230,161 @@ def _setup_mock_workflow_in_service(request

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152273125 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152273731 --- Diff: tests/orchestrator/execution/test_execution_compiler.py --- @@ -78,24 +76,23 @@ def test_missing_workflow_implementation(service

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152273070 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152233353 --- Diff: tests/orchestrator/execution/__init__.py --- @@ -0,0 +1,14 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152280899 --- Diff: tests/orchestrator/execution/test_execution_compiler.py --- @@ -296,171 +230,161 @@ def _setup_mock_workflow_in_service(request

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152233908 --- Diff: tests/orchestrator/execution_plugin/test_local.py --- @@ -500,8 +500,9 @@ def mock_workflow(ctx, graph

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152281650 --- Diff: tests/orchestrator/execution/test_execution_compiler.py --- @@ -296,171 +230,161 @@ def _setup_mock_workflow_in_service(request

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152226255 --- Diff: aria/cli/commands/executions.py --- @@ -141,17 +143,21 @@ def start(workflow_name, WORKFLOW_NAME is the unique name

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152257452 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152252973 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152261088 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152252420 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152257018 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152252053 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-ariatosca pull request #208: ARIA-408 remove execution creation fr...

2017-11-21 Thread aviyoop
Github user aviyoop commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152252772 --- Diff: aria/orchestrator/execution_compiler.py --- @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one