[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-05-01 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r418675292 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -356,8 +302,9 @@ public final Locale getLocale() { /** * @return

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-30 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r417928946 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-30 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r417928218 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableStringComparisonTest.java ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apa

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-30 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r417928414 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -730,6 +743,11 @@ public static boolean le(String b0, String b1) {

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416159495 ## File path: core/src/main/java/org/apache/calcite/runtime/Utilities.java ## @@ -212,6 +213,27 @@ public static int compareNullsLast(Comparable v0, Com

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416157474 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@ -919,9 +919,12 @@ protected RexLiteral makeLiteral( // from the type

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416157060 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -638,6 +639,13 @@ public static boolean eq(Object b0, Object b1) {

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416156622 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416155985 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r416155657 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r415721356 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina

[GitHub] [calcite] rubenada commented on a change in pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

2020-04-27 Thread GitBox
rubenada commented on a change in pull request #1937: URL: https://github.com/apache/calcite/pull/1937#discussion_r415721356 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java ## @@ -279,4 +281,18 @@ public final String getCollationName() { public fina