Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
abhishekagarwal87 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514464482 ## extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleStorageTest.java: ## @@ -50,6 +51,8 @@ public class

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514514772 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -159,11 +167,23 @@ public void delete(final String

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514515215 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -142,14 +147,17 @@ public GoogleStorageObjectMetadata

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514514415 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java: ## @@ -70,12 +70,12 @@ public void

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514516223 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java: ## @@ -88,15 +88,6 @@ private void

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514513657 ## extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleUtilsTest.java: ## @@ -78,5 +79,25 @@ public void test429()

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-06 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1514697656 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -920,7 +928,6 @@ TaskStatus

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
abhishekrb19 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514091733 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -142,14 +147,17 @@ public GoogleStorageObjectMetadata

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
abhishekrb19 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514560682 ## extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleStorageTest.java: ## @@ -62,31 +65,39 @@ public void setUp() }

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-06 Thread via GitHub
kfaraz commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1513743509 ## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ## @@ -113,6 +123,22 @@ public Map getRecordsProcessed()

Re: [PR] [Backport] Handle uninitialized cache in Node role watchers (#15726) (druid)

2024-03-06 Thread via GitHub
cryptoe merged PR #16052: URL: https://github.com/apache/druid/pull/16052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch 29.0.1 updated: Handle uninitialized cache in Node role watchers (#15726) (#16052)

2024-03-06 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 5c7512c54db Handle uninitialized cache in Node

Re: [PR] Make servedSegments nullable to maintain compatibility (druid)

2024-03-06 Thread via GitHub
cryptoe commented on PR #16034: URL: https://github.com/apache/druid/pull/16034#issuecomment-1980702618 Removed the 29.0.1 since the base PR was not merged in 29.0.0. Thanks @adarshsanjeev for the catch. -- This is an automated message from the Apache Git Service. To respond to the

[PR] [Backport] Handle uninitialized cache in Node role watchers (#15726) (druid)

2024-03-06 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16052: URL: https://github.com/apache/druid/pull/16052 Backport #15726 to 29.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(druid) branch master updated: Handle uninitialized cache in Node role watchers (#15726)

2024-03-06 Thread amatya
This is an automated email from the ASF dual-hosted git repository. amatya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new c2841425f44 Handle uninitialized cache in Node

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-06 Thread via GitHub
AmatyaAvadhanula merged PR #15726: URL: https://github.com/apache/druid/pull/15726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] recover segments from historical to deep storage (druid)

2024-03-06 Thread via GitHub
freemanlutsk commented on issue #7184: URL: https://github.com/apache/druid/issues/7184#issuecomment-1980612335 @peak-c Hi Did you find a solution? I've faced with a similar issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
abhishekagarwal87 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514307972 ## extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleDataSegmentKillerTest.java: ## @@ -54,8 +51,7 @@ public class

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-03-06 Thread via GitHub
LakshSingla commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1514353936 ## processing/src/main/java/org/apache/druid/frame/segment/FrameCursorUtils.java: ## @@ -79,60 +79,71 @@ public static Filter buildFilter(@Nullable Filter filter,

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
abhishekagarwal87 commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514312905 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java: ## @@ -70,12 +70,12 @@ public void

Re: [PR] Remove exception on failure response from GCS delete API (druid)

2024-03-06 Thread via GitHub
gargvishesh commented on code in PR #16047: URL: https://github.com/apache/druid/pull/16047#discussion_r1514507754 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -159,11 +167,23 @@ public void delete(final String

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-06 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1514715332 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -920,7 +928,6 @@ TaskStatus

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-06 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1514715332 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -920,7 +928,6 @@ TaskStatus

[PR] [Backport] Web console: make double detection better (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16060: URL: https://github.com/apache/druid/pull/16060 Backport of #15998 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Revert explain attributes change (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16061: URL: https://github.com/apache/druid/pull/16061 Backport of #16004 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Web console: support for the export execution state (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16058: URL: https://github.com/apache/druid/pull/16058 Backport of #15969 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Web console: fix crash when parsing data in data loader that can not be parsed (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16059: URL: https://github.com/apache/druid/pull/16059 Backport of #15983 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Rows.objectToNumber: Accept decimals with output type LONG. (#15999) (druid)

2024-03-06 Thread via GitHub
gianm opened a new pull request, #16062: URL: https://github.com/apache/druid/pull/16062 Backport of #15999 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-06 Thread via GitHub
gianm commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1514853293 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +136,69 @@ public void testGeneralUseSimulation()

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-06 Thread via GitHub
gianm commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1514853293 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +136,69 @@ public void testGeneralUseSimulation()

[PR] [Backport] fix bug with expression virtual column indexes on missing columns for expressions that turn null values into not null values (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16055: URL: https://github.com/apache/druid/pull/16055 Backport of #15959 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Backport] Bump org.postgresql:postgresql from 42.6.0 to 42.7.2 (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16056: URL: https://github.com/apache/druid/pull/16056 Backport of #15931 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MSQ: Validate that strings and string arrays are not mixed. (druid)

2024-03-06 Thread via GitHub
LakshSingla commented on code in PR #15920: URL: https://github.com/apache/druid/pull/15920#discussion_r1514821209 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskSqlEngine.java: ## @@ -307,6 +337,124 @@ private static void

Re: [PR] Pull up literals in InputAccessor (druid)

2024-03-06 Thread via GitHub
soumyava commented on code in PR #16033: URL: https://github.com/apache/druid/pull/16033#discussion_r1514757469 ## extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchSqlAggregatorTest.java: ## @@ -1318,6 +1320,20 @@

[PR] Rewrite exotic LAST_VALUE/FIRST_VALUE to self-reference. (druid)

2024-03-06 Thread via GitHub
kgyrtkirk opened a new pull request, #16063: URL: https://github.com/apache/druid/pull/16063 * rewrite `LAST_VALUE(x) OVER (ORDER BY y)` to `LAG(x,0) OVER (ORDER BY y)` * not directly to `x` because some queries get unplannable that way * restrict `NTILE` from framing - as its not

Re: [PR] Pull up literals in InputAccessor (druid)

2024-03-06 Thread via GitHub
kgyrtkirk commented on code in PR #16033: URL: https://github.com/apache/druid/pull/16033#discussion_r1514844345 ## extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchSqlAggregatorTest.java: ## @@ -1318,6 +1320,20 @@

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-06 Thread via GitHub
gianm commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1514853293 ## server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java: ## @@ -116,6 +136,69 @@ public void testGeneralUseSimulation()

[PR] Fix race in BaseNodeRoleWatcher tests (druid)

2024-03-06 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16064: URL: https://github.com/apache/druid/pull/16064 Follow up PR to #15726 Addresses the comments: - https://github.com/apache/druid/pull/15726#discussion_r1514832437 - https://github.com/apache/druid/pull/15726#discussion_r1514853293

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515079633 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

[PR] [Backport] Web console: make flattenSpec location adaptive (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16054: URL: https://github.com/apache/druid/pull/16054 Backport of #15946 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515076050 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515077043 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

[PR] [Backport] fix NestedCommonFormatColumnHandler to use nullable comparator when castToType is set (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16053: URL: https://github.com/apache/druid/pull/16053 Backport of #15921 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-03-06 Thread via GitHub
gianm commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1514832437 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -215,34 +232,79 @@ public void cacheInitialized() // No need to wait on

Re: [PR] Rewrite exotic LAST_VALUE/FIRST_VALUE to self-reference. (druid)

2024-03-06 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16063: URL: https://github.com/apache/druid/pull/16063#discussion_r1514892748 ## sql/src/main/java/org/apache/druid/sql/calcite/rule/RewriteFirstValueLastValueRule.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

Re: [PR] Calcite tests remove expected exception (druid)

2024-03-06 Thread via GitHub
kgyrtkirk commented on PR #16046: URL: https://github.com/apache/druid/pull/16046#issuecomment-1981459426 failure of jdk11 static checks seem unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515079012 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515077676 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515078482 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

[PR] Fix bug with mmless ingestion and compaction tasks on azure (druid)

2024-03-06 Thread via GitHub
georgew5656 opened a new pull request, #16065: URL: https://github.com/apache/druid/pull/16065 Fixes a reporting bug with running k8s compaction tasks on azure. ### Description There is logic in AbstractTask.cleanup that lets peons that are running standalone (currently only a

[PR] [Backport] Reduce the size of distribution docker image (druid)

2024-03-06 Thread via GitHub
cryptoe opened a new pull request, #16057: URL: https://github.com/apache/druid/pull/16057 Backport of #15968 to 29.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Task Labeling for Improved Monitoring and Analysis (druid)

2024-03-06 Thread via GitHub
arunramani commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1514902100 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java: ## @@ -134,6 +134,23 @@ default int getPriority() */ String getType(); +

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-06 Thread via GitHub
317brian commented on PR #16031: URL: https://github.com/apache/druid/pull/16031#issuecomment-1981490490 @adarshsanjeev The relevant changes will also need to go into the 29.0.1 branch so that it gets included in those docs and goes out with that release -- This is an automated message

Re: [PR] fixup!: #15981 Missing completion reports on index_parallel tasks (druid)

2024-03-06 Thread via GitHub
georgew5656 merged PR #16042: URL: https://github.com/apache/druid/pull/16042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (c2841425f44 -> ae022cc0c93)

2024-03-06 Thread georgew5656
This is an automated email from the ASF dual-hosted git repository. georgew5656 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from c2841425f44 Handle uninitialized cache in Node role watchers (#15726) add ae022cc0c93 fixup!: #15981 Missing

Re: [PR] Fix race in BaseNodeRoleWatcher tests (druid)

2024-03-06 Thread via GitHub
gianm commented on code in PR #16064: URL: https://github.com/apache/druid/pull/16064#discussion_r1515003440 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -352,6 +345,24 @@ public void resetNodes(Map fullNodes) } } + static void

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515092725 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
vtlim merged PR #16001: URL: https://github.com/apache/druid/pull/16001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: restore information about truncated responses to sql api (#16001)

2024-03-06 Thread victoria
This is an automated email from the ASF dual-hosted git repository. victoria pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new ebf3bdd909f restore information about

Re: [PR] docs: restore information about truncated responses to sql api (#16001) (druid)

2024-03-06 Thread via GitHub
317brian merged PR #16066: URL: https://github.com/apache/druid/pull/16066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch 29.0.1 updated: docs: restore information about truncated responses to sql api (#16001) (#16066)

2024-03-06 Thread brile
This is an automated email from the ASF dual-hosted git repository. brile pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 1c36a3231ec docs: restore information about

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
317brian commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515095043 ## docs/api-reference/sql-api.md: ## @@ -54,24 +54,24 @@ The request body takes the following properties: * `resultFormat`: String that indicates the format to

Re: [PR] Fix bug with mmless ingestion and compaction tasks on azure (druid)

2024-03-06 Thread via GitHub
adithyachakilam commented on code in PR #16065: URL: https://github.com/apache/druid/pull/16065#discussion_r1515240184 ## extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java: ## @@ -116,7 +116,7 @@ public void uploadBlockBlob(final

[PR] restore information about truncated responses to sql api (#16001) (druid)

2024-03-06 Thread via GitHub
techdocsmith opened a new pull request, #16066: URL: https://github.com/apache/druid/pull/16066 #16001 ### Description Restores information about trailing newline for complete API responses This PR has: - [ x] been self-reviewed. - [ ] using the [concurrency

Re: [PR] Bump postcss from 8.4.26 to 8.4.31 in /website (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15079: URL: https://github.com/apache/druid/pull/15079#issuecomment-1982083358 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Remediate ingestion failures when number of segments in time period is larger than 32767 (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15090: URL: https://github.com/apache/druid/pull/15090#issuecomment-1982083409 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump postcss from 8.4.21 to 8.4.31 in /web-console (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15080: URL: https://github.com/apache/druid/pull/15080#issuecomment-1982083382 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] remove unsafe use of maven dependency caching, and cache deps explicitly (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15106: URL: https://github.com/apache/druid/pull/15106#issuecomment-1982083444 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Use JsonNode for comparing Json strings to fix the flaky test (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15105: URL: https://github.com/apache/druid/pull/15105#issuecomment-1982083423 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Flaky Test in org.apache.druid.java.util.emitter.core.EmitterTest.testBasicAuthenticationAndNewlineSeparating (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15137: URL: https://github.com/apache/druid/pull/15137#issuecomment-1982083476 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump @babel/traverse from 7.22.11 to 7.23.2 in /web-console (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15170: URL: https://github.com/apache/druid/pull/15170#issuecomment-1982083497 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Bump @babel/traverse from 7.22.8 to 7.23.2 in /website (druid)

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #15171: URL: https://github.com/apache/druid/pull/15171#issuecomment-1982083524 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
317brian commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515085847 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`: String

Re: [PR] Fix bug with mmless ingestion and compaction tasks on azure (druid)

2024-03-06 Thread via GitHub
adithyachakilam commented on code in PR #16065: URL: https://github.com/apache/druid/pull/16065#discussion_r1515241732 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java: ## @@ -201,7 +201,11 @@ public void cleanUp(TaskToolbox toolbox,

Re: [PR] restore information about truncated responses to sql api (druid)

2024-03-06 Thread via GitHub
techdocsmith commented on code in PR #16001: URL: https://github.com/apache/druid/pull/16001#discussion_r1515092071 ## docs/api-reference/sql-api.md: ## @@ -53,11 +53,25 @@ The request body takes the following properties: * `query`: SQL query string. * `resultFormat`:

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-03-06 Thread via GitHub
kfaraz merged PR #15947: URL: https://github.com/apache/druid/pull/15947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Add stats segmentsRead and segmentsPublished to compaction task reports (#15947)

2024-03-06 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 564c44ed85c Add stats segmentsRead and

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-03-06 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1515490040 ## sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/BaseExpressionDimFilterOperatorConversion.java: ## @@ -40,13 +40,17 @@

Re: [PR] Fix race in BaseNodeRoleWatcher tests (druid)

2024-03-06 Thread via GitHub
AmatyaAvadhanula commented on code in PR #16064: URL: https://github.com/apache/druid/pull/16064#discussion_r1515419017 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -76,28 +76,24 @@ public BaseNodeRoleWatcher( NodeRole nodeRole )

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-03-06 Thread via GitHub
kfaraz commented on code in PR #15991: URL: https://github.com/apache/druid/pull/15991#discussion_r1515467043 ## server/src/main/java/org/apache/druid/server/metrics/WorkerTaskCountStatsMonitor.java: ## @@ -64,6 +78,10 @@ public boolean doMonitor(ServiceEmitter emitter)

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-03-06 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1515462510 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1719,9 +1731,129 @@ private void

Re: [PR] Kill segments by version (druid)

2024-03-06 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1515508935 ## server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java: ## @@ -1068,6 +1068,7 @@ public void testMultiIntervalUsedList()

Re: [PR] Update docs to document breaking change in explain attributes (druid)

2024-03-06 Thread via GitHub
adarshsanjeev commented on PR #16031: URL: https://github.com/apache/druid/pull/16031#issuecomment-1982318343 @317brian, the change should only be present in the 29.0, and was reverted in 29.0.1, so the documentation would not need to be updated, right? -- This is an automated message

Re: [PR] Update Memcache SSLContext Protocol to TLSv1.2 (druid)

2024-03-06 Thread via GitHub
xvrl merged PR #16035: URL: https://github.com/apache/druid/pull/16035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Update protocol for MemcachedCache (#16035)

2024-03-06 Thread xvrl
This is an automated email from the ASF dual-hosted git repository. xvrl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new bf39c71d2a5 Update protocol for MemcachedCache

Re: [PR] Fix bug with mmless ingestion and compaction tasks on azure (druid)

2024-03-06 Thread via GitHub
kfaraz commented on code in PR #16065: URL: https://github.com/apache/druid/pull/16065#discussion_r1515608613 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -1108,13 +1108,12 @@ private static InputFormat

Re: [PR] Array overlap to allow numeric operand (druid)

2024-03-06 Thread via GitHub
sreemanamala commented on code in PR #15964: URL: https://github.com/apache/druid/pull/15964#discussion_r1515425821 ## sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ArrayOverlapOperatorConversion.java: ## @@ -59,11 +59,13 @@ public class

Re: [PR] Kill segments by version (druid)

2024-03-06 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1515514934 ## server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java: ## @@ -124,6 +127,7 @@ default Collection

Re: [I] SQL query with an empty string as group by fails: "Cannot add expression of different type to set" (druid)

2024-03-06 Thread via GitHub
juhoautio-rovio commented on issue #13775: URL: https://github.com/apache/druid/issues/13775#issuecomment-1980309240 I don't have latest version of Druid at hand to test, but I suspect that this bug remains. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Add column flattening via UI creating wrong spec for Kafka ingestions (druid)

2024-03-06 Thread via GitHub
fectrain commented on issue #16012: URL: https://github.com/apache/druid/issues/16012#issuecomment-1980306072 guess this PR has make it adaptive already, it has been marked as milestone 29.0.1 #15946 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] add google as external storage for msq export (druid)

2024-03-06 Thread via GitHub
adarshsanjeev commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-1980347387 Thanks for the PR! I'll take a look at it shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL