[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344433322 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344426269 ## File path:

[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344426863 ## File path:

[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344427395 ## File path:

[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

suneet-amp commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344427249 ## File path:

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces

lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-552059277 This pull request **fixes 1 alert** when merging 546d957d52cfc3b2ba3c36c633e50679d72720a1 into

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344424620 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] suneet-amp commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

suneet-amp commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-552056083 > Sorry, that didn't end up being so short... I .. hope this didn't make it more

[GitHub] [incubator-druid] fjy merged pull request #8843: Add more datasketches doubles sketch SQL functions

fjy merged pull request #8843: Add more datasketches doubles sketch SQL functions URL: https://github.com/apache/incubator-druid/pull/8843 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated (0e8c3f7 -> 75ea0d5)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 0e8c3f7 SQL: EARLIEST, LATEST aggregators. (#8815) add 75ea0d5 Add more datasketches doubles sketch SQL

[GitHub] [incubator-druid] clintropolis commented on issue #8803: Use RFC4180Parser as CSVParser

clintropolis commented on issue #8803: Use RFC4180Parser as CSVParser URL: https://github.com/apache/incubator-druid/pull/8803#issuecomment-552054643 I think this PR needs to have master branch merged in for it to pass CI

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344423212 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422389 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvInputFormatTest.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422376 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422402 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422407 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422393 ## File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java ## @@ -306,6

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422386 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422380 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422375 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422382 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422405 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422397 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422347 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422367 ## File path: core/src/test/java/org/apache/druid/data/input/impl/SplitIteratingReaderTest.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422359 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422338 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422322 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422315 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JSONParseSpec.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422336 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422356 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422320 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422363 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SplitIteratingReader.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422328 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422355 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422371 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopInputSource.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422343 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvReaderTest.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422310 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422306 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422287 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422293 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/TaskToolbox.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422286 ## File path: core/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422296 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422291 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344422300 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8843: Add more datasketches doubles sketch SQL functions

clintropolis commented on a change in pull request #8843: Add more datasketches doubles sketch SQL functions URL: https://github.com/apache/incubator-druid/pull/8843#discussion_r344421305 ## File path:

[GitHub] [incubator-druid] capistrant commented on issue #8826: druid-basic-security - allow LDAP groupMapping updates

capistrant commented on issue #8826: druid-basic-security - allow LDAP groupMapping updates URL: https://github.com/apache/incubator-druid/issues/8826#issuecomment-552048233 This functionality already exists. I made an assumption off of the groupMapping section of the docs. However, the

[GitHub] [incubator-druid] capistrant closed issue #8826: druid-basic-security - allow LDAP groupMapping updates

capistrant closed issue #8826: druid-basic-security - allow LDAP groupMapping updates URL: https://github.com/apache/incubator-druid/issues/8826 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8838: Web console: replace (and remove) old consoles

clintropolis commented on a change in pull request #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#discussion_r344415538 ## File path: licenses.yaml ## @@ -5036,21 +4918,15 @@ module: web-console

[incubator-druid] branch master updated (6eacaf4 -> 0e8c3f7)

This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 6eacaf4 Use more efficient tasks API (#8844) add 0e8c3f7 SQL: EARLIEST, LATEST aggregators. (#8815)

[GitHub] [incubator-druid] clintropolis closed issue #8536: Add last and first aggregators to sql

clintropolis closed issue #8536: Add last and first aggregators to sql URL: https://github.com/apache/incubator-druid/issues/8536 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] clintropolis merged pull request #8815: SQL: EARLIEST, LATEST aggregators.

clintropolis merged pull request #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344397365 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344392441 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344391518 ## File path: docs/tutorials/tutorial-batch.md ## @@ -134,8 +134,7 @@ which has been

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344393304 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344397213 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344392227 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344391981 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API

jihoonson commented on a change in pull request #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#discussion_r344392697 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] vogievetsky commented on issue #1082: Realtime cleanup may not work if there are exceptions during cleanup

vogievetsky commented on issue #1082: Realtime cleanup may not work if there are exceptions during cleanup URL: https://github.com/apache/incubator-druid/issues/1082#issuecomment-552022246 Closing as the realtime node was removed

[GitHub] [incubator-druid] vogievetsky closed issue #1082: Realtime cleanup may not work if there are exceptions during cleanup

vogievetsky closed issue #1082: Realtime cleanup may not work if there are exceptions during cleanup URL: https://github.com/apache/incubator-druid/issues/1082 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] capistrant opened a new pull request #8847: Fix groupMapping endpoint URIs in druid-basic-security doc

capistrant opened a new pull request #8847: Fix groupMapping endpoint URIs in druid-basic-security doc URL: https://github.com/apache/incubator-druid/pull/8847 ### Description Documentation update only. I was testing out the

[GitHub] [incubator-druid] vogievetsky commented on issue #8810: Make submit task API similar to supervisor API

vogievetsky commented on issue #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#issuecomment-552011594 I am a strong  on the design (I am biased since I filed the original issue). This will allow us to take a nasty hack out

[GitHub] [incubator-druid] gianm commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators.

gianm commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#discussion_r344387726 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/aggregation/Aggregations.java ## @@ -48,10

[GitHub] [incubator-druid] vogievetsky commented on issue #8833: SQL query fails in semi join when using NOT IN with subquery

vogievetsky commented on issue #8833: SQL query fails in semi join when using NOT IN with subquery URL: https://github.com/apache/incubator-druid/issues/8833#issuecomment-552000743 This is a known issues the `x IN (...)` is actually a special case, this will be addressed by

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8838: Web console: replace (and remove) old consoles

lgtm-com[bot] commented on issue #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-552000562 This pull request **fixes 28 alerts** when merging 8ff3c9ccf371a81520c75fdca23c567ca79c2b4f into

[GitHub] [incubator-druid] surekhasaharan commented on issue #8810: Make submit task API similar to supervisor API

surekhasaharan commented on issue #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#issuecomment-551999456 > Please fix LGTM alert. Yeah, i looked at that, it thinks `dataSchema` can be null

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators.

clintropolis commented on a change in pull request #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#discussion_r344375327 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/aggregation/Aggregations.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344364825 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344353621 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344352968 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8698: add explodeSpec

vogievetsky commented on a change in pull request #8698: add explodeSpec URL: https://github.com/apache/incubator-druid/pull/8698#discussion_r344350401 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaSamplerSpecTest.java

[GitHub] [incubator-druid] vogievetsky commented on issue #8838: Web console: replace (and remove) old consoles

vogievetsky commented on issue #8838: Web console: replace (and remove) old consoles URL: https://github.com/apache/incubator-druid/pull/8838#issuecomment-551962265 Thanks @clintropolis fixed and pushed. This is an automated

[GitHub] [incubator-druid] palanieppan-m commented on issue #8728: Initial join support

palanieppan-m commented on issue #8728: Initial join support URL: https://github.com/apache/incubator-druid/issues/8728#issuecomment-551957897 @kstrempel we looked into join support through presto couple years ago. Its possible but presto connector interface did not have API to

[GitHub] [incubator-druid] sascha-coenen commented on issue #8841: add readiness endpoints to processes having initialization delays

sascha-coenen commented on issue #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#issuecomment-551945335 BTW: readiness endpoints alone will not suffice to integrate Druid well with Kubernetes. Reason

[GitHub] [incubator-druid] himanshug opened a new issue #8846: VersionedIntervalTimeline performance corner case with high number of overlapping segments

himanshug opened a new issue #8846: VersionedIntervalTimeline performance corner case with high number of overlapping segments URL: https://github.com/apache/incubator-druid/issues/8846 Recently all of our historical node restarted on a cluster which was serving about 5 segments of

[GitHub] [incubator-druid] pjain1 commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

pjain1 commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344310873 ## File path: docs/operations/api-reference.md ## @@ -752,7 +752,11 @@

[GitHub] [incubator-druid] sascha-coenen commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

sascha-coenen commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344305509 ## File path: docs/operations/api-reference.md ## @@ -752,7 +752,11

[GitHub] [incubator-druid] suneet-amp commented on issue #8815: SQL: EARLIEST, LATEST aggregators.

suneet-amp commented on issue #8815: SQL: EARLIEST, LATEST aggregators. URL: https://github.com/apache/incubator-druid/pull/8815#issuecomment-551935233 Taking a look now - should have a review out in an hour. Doubt I'll find anything else. Feel free to merge and I'll comment retroactively

[GitHub] [incubator-druid] fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344276502 ## File path: docs/operations/api-reference.md ## @@ -752,7 +752,11 @@ Returns

[GitHub] [incubator-druid] fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344274367 ## File path: docs/operations/api-reference.md ## @@ -752,7 +752,11 @@ Returns

[GitHub] [incubator-druid] fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344274733 ## File path:

[GitHub] [incubator-druid] fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays

fjy commented on a change in pull request #8841: add readiness endpoints to processes having initialization delays URL: https://github.com/apache/incubator-druid/pull/8841#discussion_r344274695 ## File path:

[GitHub] [incubator-druid] smokemonster99 commented on issue #4194: Kafka lag emitter - Kafka Indexing Service

smokemonster99 commented on issue #4194: Kafka lag emitter - Kafka Indexing Service URL: https://github.com/apache/incubator-druid/pull/4194#issuecomment-551900265 Actually @wankunde my config file has "ingest/kafka/lag" : { "dimensions" : ["dataSource"], "type" : "gauge" },

[GitHub] [incubator-druid] stale[bot] commented on issue #3362: Race on segment loading

stale[bot] commented on issue #3362: Race on segment loading URL: https://github.com/apache/incubator-druid/issues/3362#issuecomment-551895621 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the

[GitHub] [incubator-druid] stale[bot] closed issue #3362: Race on segment loading

stale[bot] closed issue #3362: Race on segment loading URL: https://github.com/apache/incubator-druid/issues/3362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] smokemonster99 commented on issue #4194: Kafka lag emitter - Kafka Indexing Service

smokemonster99 commented on issue #4194: Kafka lag emitter - Kafka Indexing Service URL: https://github.com/apache/incubator-druid/pull/4194#issuecomment-551895380 Thanks guys, I rebuilt my cluster from scratch (terraform deployment) and today the 3 lag metrics started posting to datadog!

[GitHub] [incubator-druid] fjy merged pull request #8844: Web console: Use more efficient tasks API

fjy merged pull request #8844: Web console: Use more efficient tasks API URL: https://github.com/apache/incubator-druid/pull/8844 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated (c204d68 -> 6eacaf4)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from c204d68 Fixes, adjustments to numeric null handling and string first/last aggregators. (#8834) add

[GitHub] [incubator-druid] gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344236027 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344240980 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344243873 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

gianm commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344245773 ## File path:

[GitHub] [incubator-druid] licl2014 removed a comment on issue #8445: In DirectDruidClient, Future cancellation listener shouldn't run in HTTP library thread

licl2014 removed a comment on issue #8445: In DirectDruidClient, Future cancellation listener shouldn't run in HTTP library thread URL: https://github.com/apache/incubator-druid/issues/8445#issuecomment-532655119 I also have a problem about `cancel query`, the scenario is as follows:

[GitHub] [incubator-druid-website-src] michalmisiewicz opened a new pull request #79: Add Datumo to list of companies providing druid commercial services

michalmisiewicz opened a new pull request #79: Add Datumo to list of companies providing druid commercial services URL: https://github.com/apache/incubator-druid-website-src/pull/79 This is an automated message from the

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-551458539 I repeated the benchmarks after being modified to have the latest changes to make sure

[GitHub] [incubator-druid] leventov commented on issue #7084: Make IntelliJ inspection "Collection.EMPTY_* field accesses replaceable with Collections.empty*()" a error

leventov commented on issue #7084: Make IntelliJ inspection "Collection.EMPTY_* field accesses replaceable with Collections.empty*()" a error URL: https://github.com/apache/incubator-druid/issues/7084#issuecomment-551454168 Adding terms to make this issue more searchable: EMPTY_LIST,

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344079277 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows)

clintropolis commented on a change in pull request #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#discussion_r344078217 ## File path:

  1   2   >