[GitHub] [druid] clintropolis commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up l

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049146027 ## processing/src/test/java/org/apache/druid/query/scan/NestedDataScanQueryTest.java: ## @@ -463,13 +462,13 @@ public void testExpectedTypes() throws Exception

[GitHub] [druid] clintropolis commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up l

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049145951 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralDictionaryEncodedColumn.java: ## @@ -509,6 +527,124 @@ public boolean isNull()

[GitHub] [druid] clintropolis commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up l

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049145239 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralDictionaryEncodedColumn.java: ## @@ -156,7 +156,11 @@ public String lookupName(int id

[GitHub] [druid] cheddar merged pull request #13514: Support Framing for Window Aggregations

2022-12-14 Thread GitBox
cheddar merged PR #13514: URL: https://github.com/apache/druid/pull/13514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

[GitHub] [druid] clintropolis commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up l

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049142763 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralDictionaryEncodedColumn.java: ## @@ -146,7 +146,7 @@ public String lookupName(int id)

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13514: Support Framing for Window Aggregations

2022-12-14 Thread GitBox
imply-cheddar commented on code in PR #13514: URL: https://github.com/apache/druid/pull/13514#discussion_r1049142764 ## processing/src/main/java/org/apache/druid/query/rowsandcols/semantic/DefaultFramedOnHeapAggregatable.java: ## @@ -0,0 +1,581 @@ +/* + * Licensed to the Apache

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13514: Support Framing for Window Aggregations

2022-12-14 Thread GitBox
imply-cheddar commented on code in PR #13514: URL: https://github.com/apache/druid/pull/13514#discussion_r1049142442 ## processing/src/main/java/org/apache/druid/query/operator/window/WindowFrame.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13514: Support Framing for Window Aggregations

2022-12-14 Thread GitBox
imply-cheddar commented on code in PR #13514: URL: https://github.com/apache/druid/pull/13514#discussion_r1049141901 ## processing/src/main/java/org/apache/druid/query/operator/window/WindowFrame.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] clintropolis commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up l

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049140515 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralColumnIndexSupplier.java: ## @@ -574,22 +579,34 @@ public BitmapColumnIndex forValue(

[GitHub] [druid] clintropolis commented on a diff in pull request #13514: Support Framing for Window Aggregations

2022-12-14 Thread GitBox
clintropolis commented on code in PR #13514: URL: https://github.com/apache/druid/pull/13514#discussion_r1042923453 ## processing/src/main/java/org/apache/druid/query/operator/window/WindowFrame.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] imply-cheddar commented on a diff in pull request #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up

2022-12-14 Thread GitBox
imply-cheddar commented on code in PR #13561: URL: https://github.com/apache/druid/pull/13561#discussion_r1049122636 ## processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralColumnIndexSupplier.java: ## @@ -574,22 +579,34 @@ public BitmapColumnIndex forValue

[GitHub] [druid] vogievetsky commented on pull request #13563: Druid quickstart: Update task memory computation

2022-12-14 Thread GitBox
vogievetsky commented on PR #13563: URL: https://github.com/apache/druid/pull/13563#issuecomment-1352406830 Ok so you might have read my comment above and wondered, wait what indexer configs are you using? It is a fair question. I copy a custom set of indexer configs into the micro-qu

[GitHub] [druid] vogievetsky commented on pull request #13563: Druid quickstart: Update task memory computation

2022-12-14 Thread GitBox
vogievetsky commented on PR #13563: URL: https://github.com/apache/druid/pull/13563#issuecomment-1352295279 I think the same sort of adjustment needs to happen to the indexer: I just ran built this build, and ran `./bin/start-druid -m 16g -s broker,router,historical,coordinator-overlo

[GitHub] [druid] somu-imply commented on a diff in pull request #13479: docs: documentation for unnest datasource

2022-12-14 Thread GitBox
somu-imply commented on code in PR #13479: URL: https://github.com/apache/druid/pull/13479#discussion_r1049003425 ## docs/tutorials/tutorial-unnest-datasource.md: ## @@ -0,0 +1,564 @@ +--- +id: tutorial-unnest-datasource +sidebar_label: "Using the unnest datasource" +title: "Tut

[GitHub] [druid] somu-imply commented on a diff in pull request #13479: docs: documentation for unnest datasource

2022-12-14 Thread GitBox
somu-imply commented on code in PR #13479: URL: https://github.com/apache/druid/pull/13479#discussion_r1049003425 ## docs/tutorials/tutorial-unnest-datasource.md: ## @@ -0,0 +1,564 @@ +--- +id: tutorial-unnest-datasource +sidebar_label: "Using the unnest datasource" +title: "Tut

[GitHub] [druid] somu-imply commented on a diff in pull request #13479: docs: documentation for unnest datasource

2022-12-14 Thread GitBox
somu-imply commented on code in PR #13479: URL: https://github.com/apache/druid/pull/13479#discussion_r1049005956 ## docs/querying/datasource.md: ## @@ -370,3 +370,57 @@ always be correct. - Join algorithms other than broadcast hash-joins. - Join condition on a column compared

[GitHub] [druid] vogievetsky merged pull request #13478: Link to java docs

2022-12-14 Thread GitBox
vogievetsky merged PR #13478: URL: https://github.com/apache/druid/pull/13478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.

[GitHub] [druid] rohangarg merged pull request #13553: Use template file for adding table functions grammar

2022-12-14 Thread GitBox
rohangarg merged PR #13553: URL: https://github.com/apache/druid/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.ap

[GitHub] [druid] writer-jill opened a new pull request, #13565: Tutorial: Query view

2022-12-14 Thread GitBox
writer-jill opened a new pull request, #13565: URL: https://github.com/apache/druid/pull/13565 New tutorial for using the Druid Query view. This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] writer-jill commented on pull request #13417: SQL IDE tutorial

2022-12-14 Thread GitBox
writer-jill commented on PR #13417: URL: https://github.com/apache/druid/pull/13417#issuecomment-1351651290 Closing - will open new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [druid] writer-jill closed pull request #13417: SQL IDE tutorial

2022-12-14 Thread GitBox
writer-jill closed pull request #13417: SQL IDE tutorial URL: https://github.com/apache/druid/pull/13417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] imply-cheddar opened a new pull request, #13564: Unify the handling of HTTP between SQL and Native

2022-12-14 Thread GitBox
imply-cheddar opened a new pull request, #13564: URL: https://github.com/apache/druid/pull/13564 The SqlResource and QueryResource have been using independent logic for things like error handling and response context stuff. This became abundantly clear and painful during a change

[GitHub] [druid] kfaraz merged pull request #13562: [Backport] Zero-copy local deep storage. (#13394)

2022-12-14 Thread GitBox
kfaraz merged PR #13562: URL: https://github.com/apache/druid/pull/13562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] rohangarg commented on pull request #13553: Use template file for adding table functions grammar

2022-12-14 Thread GitBox
rohangarg commented on PR #13553: URL: https://github.com/apache/druid/pull/13553#issuecomment-1350953682 > The one draw-back to the copy-and-edit approach is that each Calcite upgrade requires a manual step to match up our version against the new Calcite version, and to understand the diff

[GitHub] [druid] 599166320 commented on a diff in pull request #13168: ScanQuery supports multi column orderBy queries

2022-12-14 Thread GitBox
599166320 commented on code in PR #13168: URL: https://github.com/apache/druid/pull/13168#discussion_r1048216373 ## processing/src/main/java/org/apache/druid/query/scan/ScanQueryOrderBySequence.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [druid] kfaraz commented on a diff in pull request #13558: Fix shutdown in httpRemote task runner

2022-12-13 Thread GitBox
kfaraz commented on code in PR #13558: URL: https://github.com/apache/druid/pull/13558#discussion_r1048084584 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunnerTest.java: ## @@ -1606,6 +1607,63 @@ WorkerNodeService.DISCOVERY_SERVICE_KE

[GitHub] [druid] vogievetsky opened a new pull request, #13562: [Backport] Zero-copy local deep storage. (#13394)

2022-12-13 Thread GitBox
vogievetsky opened a new pull request, #13562: URL: https://github.com/apache/druid/pull/13562 Backport of #13394 to fix the copy delay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [druid] adarshsanjeev closed pull request #12580: Add validation for invalid partitioned by granularities

2022-12-13 Thread GitBox
adarshsanjeev closed pull request #12580: Add validation for invalid partitioned by granularities URL: https://github.com/apache/druid/pull/12580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] clintropolis opened a new pull request, #13561: fix cool nested column bug caused by not properly validating that global id is present in global dictionary before lookup up local id

2022-12-13 Thread GitBox
clintropolis opened a new pull request, #13561: URL: https://github.com/apache/druid/pull/13561 ### Description This PR fixes a bug with nested column "value set" indexes caused by not properly validating that the globalId looked up for value is present in the global dictionary prior to

[GitHub] [druid] dependabot[bot] opened a new pull request, #13560: Bump oauth2-oidc-sdk from 6.5 to 10.4

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #13560: URL: https://github.com/apache/druid/pull/13560 Bumps [oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 6.5 to 10.4. Changelog Sourced from https://bitbucket.org/connect2id/oauth

[GitHub] [druid] dependabot[bot] commented on pull request #13526: Bump oauth2-oidc-sdk from 6.5 to 10.3

2022-12-13 Thread GitBox
dependabot[bot] commented on PR #13526: URL: https://github.com/apache/druid/pull/13526#issuecomment-1350055767 Superseded by #13560. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [druid] dependabot[bot] closed pull request #13526: Bump oauth2-oidc-sdk from 6.5 to 10.3

2022-12-13 Thread GitBox
dependabot[bot] closed pull request #13526: Bump oauth2-oidc-sdk from 6.5 to 10.3 URL: https://github.com/apache/druid/pull/13526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [druid] paul-rogers commented on pull request #13360: Enhanced MSQ table functions

2022-12-13 Thread GitBox
paul-rogers commented on PR #13360: URL: https://github.com/apache/druid/pull/13360#issuecomment-1350032595 In the next PR, `extern()` will work as @gianm suggested: ```sql INSERT INTO ... SELECT ... FROM TABLE(extern( inputSource => '', inputFormat => '')) (a V

[GitHub] [druid] kfaraz opened a new pull request, #13559: Track input processedBytes with MSQ ingestion

2022-12-13 Thread GitBox
kfaraz opened a new pull request, #13559: URL: https://github.com/apache/druid/pull/13559 Follow up to #13520 ### Description Bytes processed are currently tracked for intermediate stages in MSQ ingestion. This PR adds the capability to track the bytes processed by an MSQ control

[GitHub] [druid] capistrant commented on pull request #12599: Add a configurable bufferPeriod between when a segment is marked unused and deleted by KillUnusedSegments duty

2022-12-13 Thread GitBox
capistrant commented on PR #12599: URL: https://github.com/apache/druid/pull/12599#issuecomment-1349566343 > @capistrant - are you still working on this PR? Asking since this is a really useful feature. And after this, we can enable the auto-killing of unused segments. @abhishekagarw

[GitHub] [druid] kfaraz commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
kfaraz commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047627317 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformatio

[GitHub] [druid] vogievetsky closed pull request #13556: Zk should be default

2022-12-13 Thread GitBox
vogievetsky closed pull request #13556: Zk should be default URL: https://github.com/apache/druid/pull/13556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [druid] cryptoe commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047529750 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformati

[GitHub] [druid] paul-rogers commented on a diff in pull request #13535: MSQ s3 deep storage tests

2022-12-13 Thread GitBox
paul-rogers commented on code in PR #13535: URL: https://github.com/apache/druid/pull/13535#discussion_r1047483660 ## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/ITS3ToS3ParallelIndexTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Soft

[GitHub] [druid] adarshsanjeev commented on pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
adarshsanjeev commented on PR #13463: URL: https://github.com/apache/druid/pull/13463#issuecomment-1349219166 Changes LGTM, thanks for taking up this PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] jasonk000 commented on pull request #13545: perf: core/TextReader for faster json ingestion

2022-12-13 Thread GitBox
jasonk000 commented on PR #13545: URL: https://github.com/apache/druid/pull/13545#issuecomment-1349206720 @samarthjain @maytasm could you please review or help me tag the correct reviewer for this? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [druid] kfaraz commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
kfaraz commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047444199 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformatio

[GitHub] [druid] cryptoe commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047417646 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/WorkerChatHandlerTest.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [druid] cryptoe commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047417646 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/WorkerChatHandlerTest.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [druid] cryptoe commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047416530 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/WorkerChatHandlerTest.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [druid] cryptoe commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047415353 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformati

[GitHub] [druid] kfaraz commented on a diff in pull request #13463: Multiple fixes for the MSQ stats merging piece which

2022-12-13 Thread GitBox
kfaraz commented on code in PR #13463: URL: https://github.com/apache/druid/pull/13463#discussion_r1047359656 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -615,7 +615,9 @@ public void updatePartialKeyStatisticsInformatio

[GitHub] [druid] 599166320 commented on a diff in pull request #13168: ScanQuery supports multi column orderBy queries

2022-12-13 Thread GitBox
599166320 commented on code in PR #13168: URL: https://github.com/apache/druid/pull/13168#discussion_r1047383221 ## processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java: ## @@ -252,6 +266,127 @@ public void cleanup(Iterator iterFromMake) ); } + p

[GitHub] [druid] 599166320 commented on a diff in pull request #13168: ScanQuery supports multi column orderBy queries

2022-12-13 Thread GitBox
599166320 commented on code in PR #13168: URL: https://github.com/apache/druid/pull/13168#discussion_r1047363771 ## processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java: ## @@ -252,6 +266,127 @@ public void cleanup(Iterator iterFromMake) ); } + p

[GitHub] [druid] 599166320 commented on a diff in pull request #13168: ScanQuery supports multi column orderBy queries

2022-12-13 Thread GitBox
599166320 commented on code in PR #13168: URL: https://github.com/apache/druid/pull/13168#discussion_r1047312824 ## processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java: ## @@ -66,7 +72,12 @@ public Sequence process( @Nullable final QueryMetrics query

[GitHub] [druid] cryptoe commented on a diff in pull request #13429: 25.0 release notes: batch 3

2022-12-13 Thread GitBox
cryptoe commented on code in PR #13429: URL: https://github.com/apache/druid/pull/13429#discussion_r1047162325 ## docs/next-release-notes.md: ## @@ -0,0 +1,618 @@ +--- +title: "WIP release notes for 25.0" +--- + + + +## Highlights + +### Multi-stage query + +The multi-stage que

[GitHub] [druid] kfaraz merged pull request #13520: Add InputStats to track bytes processed by a task

2022-12-13 Thread GitBox
kfaraz merged PR #13520: URL: https://github.com/apache/druid/pull/13520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] kfaraz commented on pull request #13557: Upgrade io.kubernetes.client-java to 17.0.0

2022-12-13 Thread GitBox
kfaraz commented on PR #13557: URL: https://github.com/apache/druid/pull/13557#issuecomment-1348507109 The v17 client uses `snakeyaml:1.33` which seems to have the same vulnerability. Just suppressing the CVE for now. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [druid] applike-ss commented on issue #7404: "useDefaultValueForNull" needs documentation

2022-12-13 Thread GitBox
applike-ss commented on issue #7404: URL: https://github.com/apache/druid/issues/7404#issuecomment-1348396229 i still didn't find the docs for this. Can the issue be re-opened? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [druid] AmatyaAvadhanula opened a new pull request, #13558: Fix shutdown in httpRemote task runner

2022-12-13 Thread GitBox
AmatyaAvadhanula opened a new pull request, #13558: URL: https://github.com/apache/druid/pull/13558 ### Description HttpRemoteTaskRunner#shutdown doesn't execute the shutdown hooks and this led to discrepancies such as `task/run/time` not being

[GitHub] [druid] cryptoe commented on issue #13528: issue in building from source code

2022-12-13 Thread GitBox
cryptoe commented on issue #13528: URL: https://github.com/apache/druid/issues/13528#issuecomment-1348312867 ```json "volta": { "node": "16.17.0", "npm": "8.15.0" } ``` I recommend you to install volta https://volta.sh/ -- This is an automated messag

[GitHub] [druid] kfaraz opened a new pull request, #13557: Upgrade kube client to 17.0.0

2022-12-13 Thread GitBox
kfaraz opened a new pull request, #13557: URL: https://github.com/apache/druid/pull/13557 The older versions of `io.kubernetes:client-java` depends on vulnerable versions of snakeyaml: [CVE-2022-1471](https://nvd.nist.gov/vuln/detail/CVE-2022-1471) Failing Travis cron: https://a

[GitHub] [druid] kfaraz commented on a diff in pull request #13520: Add InputStats to track bytes processed by a task

2022-12-12 Thread GitBox
kfaraz commented on code in PR #13520: URL: https://github.com/apache/druid/pull/13520#discussion_r1045388899 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/external/ExternalInputSliceReader.java: ## @@ -134,6 +136,7 @@ private static Iterator inp

[GitHub] [druid] kfaraz merged pull request #13555: [Backport] Druid quickstart: Add zk in services

2022-12-12 Thread GitBox
kfaraz merged PR #13555: URL: https://github.com/apache/druid/pull/13555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] findingrish commented on a diff in pull request #13556: Zk should be default

2022-12-12 Thread GitBox
findingrish commented on code in PR #13556: URL: https://github.com/apache/druid/pull/13556#discussion_r1046662762 ## examples/bin/start-druid-main.py: ## @@ -57,7 +57,8 @@ ROUTER, COORDINATOR, HISTORICAL, -MIDDLE_MANAGER +MIDDLE_MANAGER, +ZK Review C

[GitHub] [druid] kfaraz commented on pull request #13556: Zk should be default

2022-12-12 Thread GitBox
kfaraz commented on PR #13556: URL: https://github.com/apache/druid/pull/13556#issuecomment-1347672401 Don't these lines already handle this? (`zk = True`) https://github.com/apache/druid/blob/7682b0b6b185e4879ba202b0b777fa655e3d4f59/examples/bin/start-druid-main.py#L238-L241 -- This i

[GitHub] [druid] paul-rogers commented on a diff in pull request #13168: ScanQuery supports multi column orderBy queries

2022-12-12 Thread GitBox
paul-rogers commented on code in PR #13168: URL: https://github.com/apache/druid/pull/13168#discussion_r1046251965 ## processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java: ## @@ -445,6 +432,63 @@ public Ordering getResultOrdering() ); } + public List ge

[GitHub] [druid] cheddar commented on pull request #13501: Analysis refactor

2022-12-12 Thread GitBox
cheddar commented on PR #13501: URL: https://github.com/apache/druid/pull/13501#issuecomment-1347623942 @somu-imply when I went to merge, I realized that none of your commit messages really made for a good commit message on the whole PR. Going forward, try to make your initial commit messa

[GitHub] [druid] cheddar merged pull request #13501: Analysis refactor

2022-12-12 Thread GitBox
cheddar merged PR #13501: URL: https://github.com/apache/druid/pull/13501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

[GitHub] [druid] cheddar merged pull request #13394: Zero-copy local deep storage.

2022-12-12 Thread GitBox
cheddar merged PR #13394: URL: https://github.com/apache/druid/pull/13394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

[GitHub] [druid-website] vogievetsky merged pull request #200: Autobuild

2022-12-12 Thread GitBox
vogievetsky merged PR #200: URL: https://github.com/apache/druid-website/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dr

[GitHub] [druid-website-src] vogievetsky merged pull request #356: Events - change to only show future events

2022-12-12 Thread GitBox
vogievetsky merged PR #356: URL: https://github.com/apache/druid-website-src/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [druid-website-src] vogievetsky merged pull request #355: Update events.yml

2022-12-12 Thread GitBox
vogievetsky merged PR #355: URL: https://github.com/apache/druid-website-src/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [druid] vogievetsky commented on pull request #13555: [Backport] Druid quickstart: Add zk in services

2022-12-12 Thread GitBox
vogievetsky commented on PR #13555: URL: https://github.com/apache/druid/pull/13555#issuecomment-1347494924 I think we also need to add https://github.com/apache/druid/pull/13556 to this backport -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [druid] vogievetsky opened a new pull request, #13556: Zk should be default

2022-12-12 Thread GitBox
vogievetsky opened a new pull request, #13556: URL: https://github.com/apache/druid/pull/13556 Fixing a bug introduced in https://github.com/apache/druid/pull/13550 where the change makes it that there is no ZK by default. -- This is an automated message from the Apache Git Service. T

[GitHub] [druid] ektravel commented on a diff in pull request #13465: docs: notebook only for SQL tutorial

2022-12-12 Thread GitBox
ektravel commented on code in PR #13465: URL: https://github.com/apache/druid/pull/13465#discussion_r1046465411 ## examples/quickstart/jupyter-notebooks/sql-tutorial.ipynb: ## @@ -0,0 +1,715 @@ +{ + "cells": [ + { + "cell_type": "markdown", + "id": "ad4e60b6", + "metadata

[GitHub] [druid] ektravel commented on a diff in pull request #13465: docs: notebook only for SQL tutorial

2022-12-12 Thread GitBox
ektravel commented on code in PR #13465: URL: https://github.com/apache/druid/pull/13465#discussion_r1046464161 ## examples/quickstart/jupyter-notebooks/sql-tutorial.ipynb: ## @@ -0,0 +1,715 @@ +{ + "cells": [ + { + "cell_type": "markdown", + "id": "ad4e60b6", + "metadata

[GitHub] [druid] TSFenwick commented on a diff in pull request #13513: Draft: prototype emitting unparseable events from taskreports

2022-12-12 Thread GitBox
TSFenwick commented on code in PR #13513: URL: https://github.com/apache/druid/pull/13513#discussion_r1046353798 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)

[GitHub] [druid] TSFenwick commented on a diff in pull request #13513: Draft: prototype emitting unparseable events from taskreports

2022-12-12 Thread GitBox
TSFenwick commented on code in PR #13513: URL: https://github.com/apache/druid/pull/13513#discussion_r1046353798 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)

[GitHub] [druid] rohangarg commented on pull request #13498: Retry query automatically for failed historicals

2022-12-12 Thread GitBox
rohangarg commented on PR #13498: URL: https://github.com/apache/druid/pull/13498#issuecomment-1347239817 @churromorales : @imply-cheddar and I were also discussing this today and we think that if you really want to implement server side retry of queries in druid, you'd need to buffer up th

[GitHub] [druid] jon-wei commented on a diff in pull request #13513: Draft: prototype emitting unparseable events from taskreports

2022-12-12 Thread GitBox
jon-wei commented on code in PR #13513: URL: https://github.com/apache/druid/pull/13513#discussion_r1046311713 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)

[GitHub] [druid] jon-wei commented on a diff in pull request #13513: Draft: prototype emitting unparseable events from taskreports

2022-12-12 Thread GitBox
jon-wei commented on code in PR #13513: URL: https://github.com/apache/druid/pull/13513#discussion_r1046307201 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ## @@ -546,6 +553,41 @@ public TaskStatus runTask(final TaskToolbox toolbox)

[GitHub] [druid] findingrish opened a new pull request, #13555: [Backport] Druid quickstart: Add zk in services

2022-12-12 Thread GitBox
findingrish opened a new pull request, #13555: URL: https://github.com/apache/druid/pull/13555 Backports #13550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [druid] paul-rogers commented on pull request #13553: Use template file for adding table functions grammar

2022-12-12 Thread GitBox
paul-rogers commented on PR #13553: URL: https://github.com/apache/druid/pull/13553#issuecomment-1347050635 The one draw-back to the copy-and-edit approach is that each Calcite upgrade requires a manual step to match up our version against the new Calcite version, and to understand the diff

[GitHub] [druid] paul-rogers commented on a diff in pull request #13553: Use template file for adding table functions grammar

2022-12-12 Thread GitBox
paul-rogers commented on code in PR #13553: URL: https://github.com/apache/druid/pull/13553#discussion_r1046230205 ## sql/src/main/codegen/includes/from.ftl: ## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license a

[GitHub] [druid] somu-imply opened a new pull request, #13554: Native query runners for unnest

2022-12-12 Thread GitBox
somu-imply opened a new pull request, #13554: URL: https://github.com/apache/druid/pull/13554 Adds the tests and changes for native tests for unnest in Scan, TopN, GroupBy etc. This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.

[GitHub] [druid] vogievetsky merged pull request #13550: Druid automated quickstart: zookeeper in service list

2022-12-12 Thread GitBox
vogievetsky merged PR #13550: URL: https://github.com/apache/druid/pull/13550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.

[GitHub] [druid] vogievetsky closed issue #13543: Add zk to the possible service list in the new bin/start-druid script

2022-12-12 Thread GitBox
vogievetsky closed issue #13543: Add zk to the possible service list in the new bin/start-druid script URL: https://github.com/apache/druid/issues/13543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] vtlim commented on a diff in pull request #13479: docs: documentation for unnest datasource

2022-12-12 Thread GitBox
vtlim commented on code in PR #13479: URL: https://github.com/apache/druid/pull/13479#discussion_r1044936703 ## docs/tutorials/tutorial-unnest-datasource.md: ## @@ -0,0 +1,564 @@ +--- +id: tutorial-unnest-datasource +sidebar_label: "Using the unnest datasource" +title: "Tutorial

[GitHub] [druid] dampcake commented on pull request #13538: FEAT : apiversion change to kubeversion

2022-12-12 Thread GitBox
dampcake commented on PR #13538: URL: https://github.com/apache/druid/pull/13538#issuecomment-1346857756 This might be a question for the larger Druid team but have we considered dropping support for Kubernetes versions prior to 1.19? All of the major cloud providers are well past 1.19 as a

[GitHub] [druid] kfaraz merged pull request #13552: [Backport] Druid automated quickstart

2022-12-12 Thread GitBox
kfaraz merged PR #13552: URL: https://github.com/apache/druid/pull/13552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid-website-src] petermarshallio opened a new pull request, #356: Events - change to only show future events

2022-12-12 Thread GitBox
petermarshallio opened a new pull request, #356: URL: https://github.com/apache/druid-website-src/pull/356 Amends the iterator so that an event is only included if it's today or afterwards (bit of a hack without the time) - so only upcoming events are shown. Kicks out "nothing scheduled yet

[GitHub] [druid] rohangarg closed pull request #13553: Use template file for adding table functions grammar

2022-12-12 Thread GitBox
rohangarg closed pull request #13553: Use template file for adding table functions grammar URL: https://github.com/apache/druid/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [druid] rohangarg commented on pull request #13553: Use template file for adding table functions grammar

2022-12-12 Thread GitBox
rohangarg commented on PR #13553: URL: https://github.com/apache/druid/pull/13553#issuecomment-1346487733 closing this since better to have discussion on #13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid-website-src] petermarshallio opened a new pull request, #355: Update events.yml

2022-12-12 Thread GitBox
petermarshallio opened a new pull request, #355: URL: https://github.com/apache/druid-website-src/pull/355 Adding upcoming events for December -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] rohangarg commented on pull request #13553: Use template file for adding table functions grammar

2022-12-12 Thread GitBox
rohangarg commented on PR #13553: URL: https://github.com/apache/druid/pull/13553#issuecomment-1346167353 @paul-rogers @imply-cheddar : This proposes an alternate way to extend the `FROM` grammar in Calcite. The new changes merged recently for extended table functions use a script `edit-par

[GitHub] [druid-website-src] petermarshallio commented on pull request #354: Update README.md

2022-12-12 Thread GitBox
petermarshallio commented on PR #354: URL: https://github.com/apache/druid-website-src/pull/354#issuecomment-1346143755 Not sure that this actually fixed the issue. Needs more checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid-website-src] petermarshallio closed pull request #354: Update README.md

2022-12-12 Thread GitBox
petermarshallio closed pull request #354: Update README.md URL: https://github.com/apache/druid-website-src/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [druid-website-src] petermarshallio opened a new pull request, #354: Update README.md

2022-12-12 Thread GitBox
petermarshallio opened a new pull request, #354: URL: https://github.com/apache/druid-website-src/pull/354 Add CXX flags to work around build issue. This may need confirming in other environments. See https://github.com/nodejs/node/issues/38367 -- This is an automated message

[GitHub] [druid] kfaraz merged pull request #13541: Removing unused exec service.

2022-12-12 Thread GitBox
kfaraz merged PR #13541: URL: https://github.com/apache/druid/pull/13541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apach

[GitHub] [druid] kfaraz commented on a diff in pull request #13550: Druid automated quickstart: zk in service list

2022-12-12 Thread GitBox
kfaraz commented on code in PR #13550: URL: https://github.com/apache/druid/pull/13550#discussion_r1045553887 ## examples/bin/start-druid-main.py: ## @@ -50,6 +50,7 @@ MIDDLE_MANAGER = "middleManager" TASKS = "tasks" INDEXER = "indexer" +ZK = "zk" Review Comment: I think

[GitHub] [druid] kfaraz commented on a diff in pull request #13550: Druid automated quickstart: zk in service list

2022-12-12 Thread GitBox
kfaraz commented on code in PR #13550: URL: https://github.com/apache/druid/pull/13550#discussion_r1045553887 ## examples/bin/start-druid-main.py: ## @@ -50,6 +50,7 @@ MIDDLE_MANAGER = "middleManager" TASKS = "tasks" INDEXER = "indexer" +ZK = "zk" Review Comment: I think

[GitHub] [druid] kfaraz commented on a diff in pull request #13550: Druid automated quickstart: zk in service list

2022-12-12 Thread GitBox
kfaraz commented on code in PR #13550: URL: https://github.com/apache/druid/pull/13550#discussion_r1045552943 ## examples/bin/start-druid-main.py: ## @@ -146,25 +150,22 @@ def configure_parser(): 'in the given conf directory. e.g. 500m, 4g, 6g\n')

[GitHub] [druid] kfaraz commented on a diff in pull request #13550: Druid automated quickstart: zk in service list

2022-12-12 Thread GitBox
kfaraz commented on code in PR #13550: URL: https://github.com/apache/druid/pull/13550#discussion_r1045552345 ## examples/bin/start-druid-main.py: ## @@ -133,10 +137,10 @@ def configure_parser(): from the given root directory. Calculates memory requirements for

[GitHub] [druid] findingrish opened a new pull request, #13552: [Backport] Druid automated quickstart

2022-12-12 Thread GitBox
findingrish opened a new pull request, #13552: URL: https://github.com/apache/druid/pull/13552 Backports #13365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

<    4   5   6   7   8   9   10   11   12   13   >