[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073679864 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6301,26 +6307,27 @@ public Map

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1082702226 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6301,26 +6307,27 @@ public Map

[GitHub] [fineract] galovics merged pull request #2904: FINERACT-1724: Added JMS connection pooling to the external event producer

galovics merged PR #2904: URL: https://github.com/apache/fineract/pull/2904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2903: [FINERACT-1678] Inline Loan COB for Batch API

galovics merged PR #2903: URL: https://github.com/apache/fineract/pull/2903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

galovics merged PR #2897: URL: https://github.com/apache/fineract/pull/2897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2904: FINERACT-1724: Added JMS connection pooling to the external event producer

galovics opened a new pull request, #2904: URL: https://github.com/apache/fineract/pull/2904 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] taskain7 opened a new pull request, #2903: [FINERACT-1678] Inline Loan COB for Batch API

taskain7 opened a new pull request, #2903: URL: https://github.com/apache/fineract/pull/2903 ## Description Loan COB API filter executes the Inline COB for soft locked loans for Batch API. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2902: FINERACT-1840: Fee income is not realised if the loan got fully repaid

josehernandezfintecheandomx opened a new pull request, #2902: URL: https://github.com/apache/fineract/pull/2902 ## Description A Loan with a NSF fee is added (specific due date fee) and the loan got fully repaid on the same day the Fee income is not realised, the Accrual transaction

[GitHub] [fineract] galovics commented on a diff in pull request #2901: FINERACT-1707 - Export refactor

galovics commented on code in PR #2901: URL: https://github.com/apache/fineract/pull/2901#discussion_r1081362685 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/DatatableExportTargetParameter.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed

[GitHub] [fineract] galovics merged pull request #2901: FINERACT-1707 - Export refactor

galovics merged PR #2901: URL: https://github.com/apache/fineract/pull/2901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081328719 ## fineract-provider/src/main/resources/db/changelog/tenant/parts/0086_add_cob_business_date_to_loan_account_locks.xml: ## @@ -0,0 +1,32 @@ + +

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

adamsaghy commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081304157 ## fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java: ## @@ -57,10 +60,14 @@ public class LoanAccountLock { @Column(name =

[GitHub] [fineract] taskain7 commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081300032 ## fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java: ## @@ -57,10 +60,14 @@ public class LoanAccountLock { @Column(name =

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

adamsaghy commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081295733 ## fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java: ## @@ -57,10 +60,14 @@ public class LoanAccountLock { @Column(name =

[GitHub] [fineract] taskain7 commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081292221 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/StayedLockedLoansTasklet.java: ## @@ -33,16 +39,25 @@ @RequiredArgsConstructor public class

[GitHub] [fineract] taskain7 commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081287370 ## fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java: ## @@ -57,10 +60,14 @@ public class LoanAccountLock { @Column(name =

[GitHub] [fineract] galovics commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

galovics commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1081272455 ## fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java: ## @@ -57,10 +60,14 @@ public class LoanAccountLock { @Column(name =

[GitHub] [fineract] galovics merged pull request #2886: FINERACT-1724 - Replayed bulk transaction fix

galovics merged PR #2886: URL: https://github.com/apache/fineract/pull/2886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

adamsaghy merged PR #2852: URL: https://github.com/apache/fineract/pull/2852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2900: FINERACT-1724: Removed accidental closing of JMS connection upon startup

galovics merged PR #2900: URL: https://github.com/apache/fineract/pull/2900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 opened a new pull request, #2901: FINERACT-1707 - Export refactor

b0c1 opened a new pull request, #2901: URL: https://github.com/apache/fineract/pull/2901 FINERACT-1707 - Export refactor [x] Refactor Datatable export [x] Fix CSV exceptions ## Description Describe the changes made and why they were made. Ignore if these details

[GitHub] [fineract] b0c1 closed pull request #2899: FINERACT-1707 - Export refactor

b0c1 closed pull request #2899: FINERACT-1707 - Export refactor URL: https://github.com/apache/fineract/pull/2899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract] galovics opened a new pull request, #2900: FINERACT-1724: Removed accidental closing of JMS connection upon startup

galovics opened a new pull request, #2900: URL: https://github.com/apache/fineract/pull/2900 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] b0c1 opened a new pull request, #2899: FINERACT-1707 - Export refactor

b0c1 opened a new pull request, #2899: URL: https://github.com/apache/fineract/pull/2899 FINERACT-1707 - Export refactor [x] Refactor Datatable export [x] Fix CSV generation exception ## Description Describe the changes made and why they were made. Ignore if these

[GitHub] [fineract] galovics merged pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics merged PR #2891: URL: https://github.com/apache/fineract/pull/2891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1080999034 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/config/ExternalEventJMSConfiguration.java: ## @@ -60,4 +61,13 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1080989821 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/config/ExternalEventJMSConfiguration.java: ## @@ -60,4 +61,13 @@ public

[GitHub] [fineract] galovics merged pull request #2898: FINERACT-1844-Loan-Chargeback-Transaction-event-data-fix

galovics merged PR #2898: URL: https://github.com/apache/fineract/pull/2898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073680744 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6341,41 +6349,19 @@ public Map

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073679864 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6301,26 +6307,27 @@ public Map

[GitHub] [fineract] taskain7 commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1073662589 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/StayedLockedLoansTasklet.java: ## @@ -35,14 +40,24 @@ public class StayedLockedLoansTasklet

[GitHub] [fineract] galovics merged pull request #2777: [FINERACT-1678] Loan COB Catch Up

galovics merged PR #2777: URL: https://github.com/apache/fineract/pull/2777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2878: FINERACT-1853: General accounting summary table reports

galovics merged PR #2878: URL: https://github.com/apache/fineract/pull/2878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

josehernandezfintecheandomx commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1073648909 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -430,7

[GitHub] [fineract] galovics merged pull request #2895: FINERACT-1707 - S3 upgrade

galovics merged PR #2895: URL: https://github.com/apache/fineract/pull/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2898: FINERACT-1844-Loan-Chargeback-Transaction-event-data-fix

ruchiD opened a new pull request, #2898: URL: https://github.com/apache/fineract/pull/2898 ## Description Fix for LoanChargebackTransactionBusinessEvent to have correct transaction payload data. Describe the changes made and why they were made. Ignore if these details are

[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

josehernandezfintecheandomx commented on PR #2882: URL: https://github.com/apache/fineract/pull/2882#issuecomment-1387202314 > Kindly review my questions! Comments attended -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

josehernandezfintecheandomx commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073641960 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -4158,20 +4157,12 @@ public LocalDate

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

josehernandezfintecheandomx commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073641584 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6301,26 +6302,18 @@ public Map

[GitHub] [fineract] galovics commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

galovics commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1073566287 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/StayedLockedLoansTasklet.java: ## @@ -35,14 +40,24 @@ public class StayedLockedLoansTasklet

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

adamsaghy commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1073541622 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/StayedLockedLoansTasklet.java: ## @@ -35,14 +40,24 @@ public class StayedLockedLoansTasklet

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

adamsaghy commented on code in PR #2897: URL: https://github.com/apache/fineract/pull/2897#discussion_r1073538291 ## fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountStayedLockedDataV1.avsc: ## @@ -0,0 +1,31 @@ +{ +"name": "LoanAccountStayedLockedDataV1", +

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073533927 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -4158,20 +4157,12 @@ public LocalDate

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073533927 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -4158,20 +4157,12 @@ public LocalDate

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1073524648 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -430,7 +430,8 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

josehernandezfintecheandomx commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073519202 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -4158,20 +4157,12 @@ public LocalDate

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073518496 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6301,26 +6302,18 @@ public Map

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

adamsaghy commented on code in PR #2882: URL: https://github.com/apache/fineract/pull/2882#discussion_r1073511151 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -4158,20 +4157,12 @@ public LocalDate

[GitHub] [fineract] taskain7 opened a new pull request, #2897: [FINERACT-1859] Avro schema for LoanAccountsStayedLockedBusinessEvent

taskain7 opened a new pull request, #2897: URL: https://github.com/apache/fineract/pull/2897 ## Description Avro schema for `LoanAccountsStayedLockedBusinessEvent` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] b0c1 commented on a diff in pull request #2886: FINERACT-1724 - Replayed bulk transaction fix

b0c1 commented on code in PR #2886: URL: https://github.com/apache/fineract/pull/2886#discussion_r1073450401 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/ApplyChargeToOverdueLoansBusinessStep.java: ## @@ -28,6 +29,7 @@ @Component @RequiredArgsConstructor

[GitHub] [fineract] b0c1 commented on a diff in pull request #2886: FINERACT-1724 - Replayed bulk transaction fix

b0c1 commented on code in PR #2886: URL: https://github.com/apache/fineract/pull/2886#discussion_r1073447319 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/business/aspect/BulkEventAspect.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics merged pull request #2896: [FINERACT-1863] Swagger schema fix for configuration APIs

galovics merged PR #2896: URL: https://github.com/apache/fineract/pull/2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073338862 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/producer/jms/JMSMultiExternalEventProducer.java: ## @@ -0,0 +1,151 @@ +/** + *

[GitHub] [fineract] taskain7 commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

taskain7 commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1073290311 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/AsyncLoanCOBExecutorServiceImpl.java: ## @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] taskain7 opened a new pull request, #2896: [FINERACT-1863] Swagger schema fix for configuration APIs

taskain7 opened a new pull request, #2896: URL: https://github.com/apache/fineract/pull/2896 ## Description - swagger schema fix for `PutGlobalConfigurationsRequest` - swagger schema fix for `PutExternalEventConfigurationsRequest` -- This is an automated message from the

[GitHub] [fineract] ruchiD commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

ruchiD commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073275255 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] ruchiD commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

ruchiD commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073275255 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073255186 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073253912 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java: ## @@ -19,19 +19,25 @@ package

[GitHub] [fineract] ruchiD commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

ruchiD commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073184573 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] ruchiD commented on a diff in pull request #2886: FINERACT-1724 - Replayed bulk transaction fix

ruchiD commented on code in PR #2886: URL: https://github.com/apache/fineract/pull/2886#discussion_r1073156103 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/ApplyChargeToOverdueLoansBusinessStep.java: ## @@ -28,6 +29,7 @@ @Component

[GitHub] [fineract] ruchiD commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

ruchiD commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1073148174 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/producer/jms/JMSMultiExternalEventProducer.java: ## @@ -0,0 +1,151 @@ +/** + *

[GitHub] [fineract] josehernandezfintecheandomx closed pull request #2888: FINERACT-1840: Fee income is not realised if the loan got fully repaid

josehernandezfintecheandomx closed pull request #2888: FINERACT-1840: Fee income is not realised if the loan got fully repaid URL: https://github.com/apache/fineract/pull/2888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [fineract] b0c1 opened a new pull request, #2895: FINERACT-1707 - S3 upgrade

b0c1 opened a new pull request, #2895: URL: https://github.com/apache/fineract/pull/2895 FINERACT-1707 - S3 upgrade [x] Upgrade S3 dependencies and libraries ## Description Describe the changes made and why they were made. Ignore if these details are present on the

[GitHub] [fineract] b0c1 closed pull request #2894: FINERACT-1707 - S3 upgrade

b0c1 closed pull request #2894: FINERACT-1707 - S3 upgrade URL: https://github.com/apache/fineract/pull/2894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [fineract] galovics commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

galovics commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1072602144 ## fineract-provider/src/main/java/org/apache/fineract/cob/data/ProjectIdAndLastClosedBusinessDate.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] galovics merged pull request #2893: FINERACT-1724: Fix loan status change bug at the event of transaction replay

galovics merged PR #2893: URL: https://github.com/apache/fineract/pull/2893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2892: FINERACT-1724: Add Charge-off transaction into r_enum_value table

galovics merged PR #2892: URL: https://github.com/apache/fineract/pull/2892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 opened a new pull request, #2894: FINERACT-1707 - S3 upgrade

b0c1 opened a new pull request, #2894: URL: https://github.com/apache/fineract/pull/2894 FINERACT-1707 - S3 upgrade [x] Upgrade S3 dependencies and libraries without code modifications ## Description Describe the changes made and why they were made. Ignore if these

[GitHub] [fineract] galovics commented on a diff in pull request #2886: FINERACT-1724 - Replayed bulk transaction fix

galovics commented on code in PR #2886: URL: https://github.com/apache/fineract/pull/2886#discussion_r1072434667 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/business/annotation/BulkEventSupport.java: ## @@ -0,0 +1,36 @@ +/** + * Licensed to the

[GitHub] [fineract] adamsaghy opened a new pull request, #2893: FINERACT-1724: Fix loan status change bug at the event of transaction replay

adamsaghy opened a new pull request, #2893: URL: https://github.com/apache/fineract/pull/2893 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072383085 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java: ## @@ -19,19 +19,25 @@ package

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072370757 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java: ## @@ -19,19 +19,25 @@ package

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072367835 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/messaging/jms/ActiveMQMessageFactory.java: ## @@ -16,21 +16,20 @@ * specific language

[GitHub] [fineract] galovics commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072366927 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanAccountsStayedLockedBusinessEvent.java: ## @@ -39,4 +39,9 @@ public String getType() {

[GitHub] [fineract] adamsaghy opened a new pull request, #2892: FINERACT-1724: Add Charge-off transaction into r_enum_value table

adamsaghy opened a new pull request, #2892: URL: https://github.com/apache/fineract/pull/2892 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072301485 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java: ## @@ -19,19 +19,25 @@ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072301485 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/repository/ExternalEventRepository.java: ## @@ -19,19 +19,25 @@ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072297910 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/producer/jms/JMSMultiExternalEventProducer.java: ## @@ -0,0 +1,151 @@ +/** + *

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072285436 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072285436 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/jobs/SendAsynchronousEventsTasklet.java: ## @@ -69,20 +79,66 @@ private boolean

[GitHub] [fineract] galovics merged pull request #2889: FINERACT-1806: Trigger event when charge-off happens

galovics merged PR #2889: URL: https://github.com/apache/fineract/pull/2889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072171238 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/messaging/jms/ActiveMQMessageFactory.java: ## @@ -16,21 +16,20 @@ * specific language

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

adamsaghy commented on code in PR #2891: URL: https://github.com/apache/fineract/pull/2891#discussion_r1072168430 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanAccountsStayedLockedBusinessEvent.java: ## @@ -39,4 +39,9 @@ public String getType() {

[GitHub] [fineract] galovics merged pull request #2880: FINERACT-1694-External-event-producer-batch-size-configuration

galovics merged PR #2880: URL: https://github.com/apache/fineract/pull/2880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2883: chore(deps): update all non-major dependencies

galovics merged PR #2883: URL: https://github.com/apache/fineract/pull/2883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072099383 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanTransactionDataMapper.java: ## @@ -22,9

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072099130 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/UnpaidChargeData.java: ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics merged pull request #2890: FINERACT-1724: Fix id type of LoanAccountDataV1

galovics merged PR #2890: URL: https://github.com/apache/fineract/pull/2890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072094462 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanAccountDataMapper.java: ## @@ -36,5 +36,6

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072091915 ## fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc: ## @@ -0,0 +1,31 @@ +{ +"name": "UnpaidChargeDataV1", +"namespace":

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072091551 ## fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc: ## @@ -0,0 +1,31 @@ +{ +"name": "UnpaidChargeDataV1", +"namespace":

[GitHub] [fineract] galovics opened a new pull request, #2891: FINERACT-1724: Implemented support for multiple parallel JMS producers for external events

galovics opened a new pull request, #2891: URL: https://github.com/apache/fineract/pull/2891 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

galovics commented on code in PR #2889: URL: https://github.com/apache/fineract/pull/2889#discussion_r1072063934 ## fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc: ## @@ -0,0 +1,31 @@ +{ +"name": "UnpaidChargeDataV1", +"namespace":

[GitHub] [fineract] galovics merged pull request #2879: [FINERACT-1852] Swagger schema inconsistency for Business Step Config

galovics merged PR #2879: URL: https://github.com/apache/fineract/pull/2879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #2890: FINERACT-1724: Fix id type of LoanAccountDataV1

adamsaghy opened a new pull request, #2890: URL: https://github.com/apache/fineract/pull/2890 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy opened a new pull request, #2889: FINERACT-1806: Trigger event when charge-off happens

adamsaghy opened a new pull request, #2889: URL: https://github.com/apache/fineract/pull/2889 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2887: [FINERACT-1859] Missing configuration for business event

galovics merged PR #2887: URL: https://github.com/apache/fineract/pull/2887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

adamsaghy merged PR #2881: URL: https://github.com/apache/fineract/pull/2881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2888: FINERACT-1840: Fee income is not realised if the loan got fully repaid

josehernandezfintecheandomx opened a new pull request, #2888: URL: https://github.com/apache/fineract/pull/2888 ## Description Fee income is not realised if the loan got fully repaid due there is only one debit gl entry with the transaction amount consolidated

  1   2   3   4   5   6   7   8   9   10   >