[GitHub] [fineract] galovics merged pull request #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition

galovics merged PR #2790: URL: https://github.com/apache/fineract/pull/2790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2791: chore(deps): bump actions/setup-java from 19eeec562b37d29a1ad055b7de9c280bd0906d8d to c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c

galovics merged PR #2791: URL: https://github.com/apache/fineract/pull/2791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040923233 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -545,90 +543,77 @@ public ClientData

[GitHub] [fineract] adamsaghy opened a new pull request, #2792: FINERACT-1828: Fix datatable audit time handling

adamsaghy opened a new pull request, #2792: URL: https://github.com/apache/fineract/pull/2792 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040895441 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040894809 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040894541 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040893967 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040891345 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040889924 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +61,7 @@ public interface

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040888121 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepositoryWrapper.java: ## @@ -86,8 +87,21 @@ public Client

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040886870 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +750,18 @@ public boolean isStaff() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040886420 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040885753 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -224,12 +227,11 @@ public class Client extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040851100 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850456 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850214 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040849840 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040847505 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040847320 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040846935 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040845861 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040842842 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/AbstractWorkbookPopulator.java: ## @@ -130,7 +130,7 @@ protected void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition

adamsaghy commented on code in PR #2790: URL: https://github.com/apache/fineract/pull/2790#discussion_r1040833610 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanSummaryData.java: ## @@ -120,4 +139,70 @@ public LoanSummaryData(final

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2791: chore(deps): bump actions/setup-java from 19eeec562b37d29a1ad055b7de9c280bd0906d8d to c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c

dependabot[bot] opened a new pull request, #2791: URL: https://github.com/apache/fineract/pull/2791 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 19eeec562b37d29a1ad055b7de9c280bd0906d8d to c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c. Commits

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040266949 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265923 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265769 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -555,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265519 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -24,92 +24,96 @@ import java.util.List;

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265338 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040264438 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039990728 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -479,10 +476,10 @@ public Map update(final

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039989747 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -229,7 +232,7 @@ public static Client

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039890596 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -293,7 +297,7 @@ public static ClientData

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039890825 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -379,7 +383,7 @@ public static ClientData

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039887260 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java: ## @@ -95,7

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039886014 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039881056 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039880418 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -436,4 +352,251 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039811298 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -24,92 +24,96 @@ import java.util.List; import java.util.Set;

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039804761 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -555,6 +523,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039802744 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,16 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039800321 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -479,10 +476,10 @@ public Map update(final JsonCommand command) {

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039796013 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -229,7 +232,7 @@ public static Client createNew(final AppUser

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793683 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -379,7 +383,7 @@ public static ClientData clientIdentifier(final

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793234 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -293,7 +297,7 @@ public static ClientData template(final Long

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039791113 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java: ## @@ -95,7 +97,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039704997 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -34,82 +36,83 @@ import

[GitHub] [fineract] ruchiD opened a new pull request, #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition

ruchiD opened a new pull request, #2790: URL: https://github.com/apache/fineract/pull/2790 ## Description 1.Added computation of amount summation for various Loan Transactions based on transaction type and reverse status, for summary in Loan get by loanId api. 2.Added Loan Transaction

[GitHub] [fineract] forking-renovate[bot] commented on pull request #2787: chore(deps): update all non-major dependencies

forking-renovate[bot] commented on PR #2787: URL: https://github.com/apache/fineract/pull/2787#issuecomment-1337464480 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039662977 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +757,18 @@ public boolean isStaff() {

[GitHub] [fineract] adamsaghy merged pull request #2789: FINERACT-1825: Fix end of month handling

adamsaghy merged PR #2789: URL: https://github.com/apache/fineract/pull/2789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039618936 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. #

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039617750 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039608506 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +60,7 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039606278 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039605644 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface

[GitHub] [fineract] galovics merged pull request #2785: FINERACT-1760: Fix reversal external id handling

galovics merged PR #2785: URL: https://github.com/apache/fineract/pull/2785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039581083 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java:

[GitHub] [fineract] galovics commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

galovics commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1039567356 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@ public void

[GitHub] [fineract] totemcaf commented on a diff in pull request #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

totemcaf commented on code in PR #2712: URL: https://github.com/apache/fineract/pull/2712#discussion_r1039549134 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java: ## @@ -102,10 +102,10 @@

[GitHub] [fineract] totemcaf commented on a diff in pull request #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

totemcaf commented on code in PR #2712: URL: https://github.com/apache/fineract/pull/2712#discussion_r1039548957 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java: ## @@ -102,10 +102,10 @@

[GitHub] [fineract] adamsaghy opened a new pull request, #2789: FINERACT-1825: Fix end of month handling

adamsaghy opened a new pull request, #2789: URL: https://github.com/apache/fineract/pull/2789 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039521823 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] dependabot[bot] closed pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0

dependabot[bot] closed pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0 URL: https://github.com/apache/fineract/pull/2784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] dependabot[bot] commented on pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0

dependabot[bot] commented on PR #2784: URL: https://github.com/apache/fineract/pull/2784#issuecomment-1337222001 Looks like actions/setup-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract] galovics merged pull request #2786: chore(deps): update actions/setup-java digest to 19eeec5

galovics merged PR #2786: URL: https://github.com/apache/fineract/pull/2786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039302792 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039292804 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,15 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039288976 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +60,7 @@ public interface

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287520 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287147 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039285495 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +757,18 @@ public boolean isStaff() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039284331 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -34,82 +36,83 @@ import

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039270839 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -436,4 +352,251 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039265325 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java: ## @@ -489,4 +491,11 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2788: Fix to set obligation met date for installment with chargeback transa…

josehernandezfintecheandomx opened a new pull request, #2788: URL: https://github.com/apache/fineract/pull/2788 …ction ## Description In case if a loan is fully paid and there was a chargeback transaction the last installment is not marked as paid/completed. Ignore if

[GitHub] [fineract] renovate-bot opened a new pull request, #2787: chore(deps): update all non-major dependencies

renovate-bot opened a new pull request, #2787: URL: https://github.com/apache/fineract/pull/2787 [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age |

[GitHub] [fineract] renovate-bot opened a new pull request, #2786: chore(deps): update actions/setup-java digest to 19eeec5

renovate-bot opened a new pull request, #2786: URL: https://github.com/apache/fineract/pull/2786 [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] github-actions[bot] commented on pull request #2719: Add documentation for Cucumber Test Framework

github-actions[bot] commented on PR #2719: URL: https://github.com/apache/fineract/pull/2719#issuecomment-1335979449 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy opened a new pull request, #2785: FINERACT-1760: Fix reversal external id handling

adamsaghy opened a new pull request, #2785: URL: https://github.com/apache/fineract/pull/2785 ## Description We dont need auto generation for reversal external id... if it is not provided, it remains null (empty). From the internal reverse-replay logic it got lifted to set the

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037944537 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -96,6 +97,19 @@ public CommandProcessingResult

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037949603 ## fineract-provider/src/test/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImplTest.java: ## @@ -45,17 +52,24 @@ class

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037948686 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java: ## @@ -178,4 +185,14 @@ List

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037947036 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanCOBCatchUpServiceImpl.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037946516 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanCOBCatchUpServiceImpl.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037944537 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -96,6 +97,19 @@ public CommandProcessingResult

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037943155 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -120,6 +132,19 @@ public void execute(List loanIds,

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037939515 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -120,6 +132,19 @@ public void execute(List loanIds,

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037918426 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -120,6 +132,19 @@ public void execute(List loanIds,

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037909217 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResourceSwagger.java: ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software

<    1   2   3   4   5   6   7   8   9   10   >