vidakovic merged pull request #1973:
URL: https://github.com/apache/fineract/pull/1973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
ptuomola opened a new pull request #1975:
URL: https://github.com/apache/fineract/pull/1975
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic merged pull request #1973:
URL: https://github.com/apache/fineract/pull/1973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
BLasan commented on pull request #1933:
URL: https://github.com/apache/fineract/pull/1933#issuecomment-974642152
@avikganguly01 @fynmanoj Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rrpawar96 opened a new pull request #1976:
URL: https://github.com/apache/fineract/pull/1976
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
rrpawar96 closed pull request #1976:
URL: https://github.com/apache/fineract/pull/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
github-actions[bot] commented on pull request #1852:
URL: https://github.com/apache/fineract/pull/1852#issuecomment-977305449
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the A
ptuomola opened a new pull request #1977:
URL: https://github.com/apache/fineract/pull/1977
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
ptuomola closed pull request #1977:
URL: https://github.com/apache/fineract/pull/1977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola opened a new pull request #1978:
URL: https://github.com/apache/fineract/pull/1978
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
ptuomola commented on pull request #1978:
URL: https://github.com/apache/fineract/pull/1978#issuecomment-977618840
@rrpawar96 could you check if this PR fixes your CORS error issue? If yes, I
can merge it in given the build passes.
--
This is an automated message from the Apache Git Ser
rrpawar96 commented on pull request #1978:
URL: https://github.com/apache/fineract/pull/1978#issuecomment-977697287
@ptuomola, Yes tested, it's working all good. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rrpawar96 opened a new pull request #1979:
URL: https://github.com/apache/fineract/pull/1979
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
ptuomola merged pull request #1978:
URL: https://github.com/apache/fineract/pull/1978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola commented on pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#issuecomment-977764933
@vidakovic This upgrades the Spring Boot to 2.6.0 - an upgrade that was
unblocked by the config file rework. If you can approve and merge this, as next
step I'll then rework t
vidakovic commented on a change in pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#discussion_r756009170
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java
##
@@ -59,3
vidakovic commented on pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#issuecomment-977826524
Overall looks good to me. Just one caveat: at the moment there is no
compatible Spring Cloud release for Spring Boot 2.6.0. Just in case someone is
using that combination in
vidakovic edited a comment on pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#issuecomment-977826524
Overall looks good to me. Just one caveat: at the moment there is no
compatible Spring Cloud release for Spring Boot 2.6.0. Just in case someone is
using that combinat
ptuomola commented on pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#issuecomment-977842201
> Overall looks good to me. Just one caveat: at the moment there is no
compatible Spring Cloud release for Spring Boot 2.6.0. Just in case someone is
using that combination in
ptuomola commented on a change in pull request #1975:
URL: https://github.com/apache/fineract/pull/1975#discussion_r756027492
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java
##
@@ -59,33
ptuomola opened a new pull request #1980:
URL: https://github.com/apache/fineract/pull/1980
## Description
Fix as proposed by Victor Jo in the JIRA ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [
ptuomola opened a new pull request #1981:
URL: https://github.com/apache/fineract/pull/1981
## Description
As we now have all the integration and docker tests running in a Github
Action, we can disable the same activities from Travis. We need to use Travis
for SonarQube as there is
francisguchie commented on pull request #1978:
URL: https://github.com/apache/fineract/pull/1978#issuecomment-977903376
@rrpawar96 and @ptuomola thank you for this good work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ptuomola closed pull request #1975:
URL: https://github.com/apache/fineract/pull/1975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
vidakovic merged pull request #1975:
URL: https://github.com/apache/fineract/pull/1975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
avikganguly01 merged pull request #1933:
URL: https://github.com/apache/fineract/pull/1933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
ptuomola closed pull request #1980:
URL: https://github.com/apache/fineract/pull/1980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
rrpawar96 opened a new pull request #1982:
URL: https://github.com/apache/fineract/pull/1982
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
rrpawar96 closed pull request #1982:
URL: https://github.com/apache/fineract/pull/1982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
IOhacker commented on pull request #1891:
URL: https://github.com/apache/fineract/pull/1891#issuecomment-979280078
I will close this PR, because I have tested the latest update of Spring
2.6.0 and there are less issues. I will submit another PR
--
This is an automated message from the Ap
IOhacker closed pull request #1891:
URL: https://github.com/apache/fineract/pull/1891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
IOhacker opened a new pull request #1983:
URL: https://github.com/apache/fineract/pull/1983
## Description
Java has been upgraded from v11 LTS to v17 LTS
https://paste.apache.org/nd32y
## Checklist
Please make sure these boxes are checked before submitting your pu
francisguchie commented on pull request #1979:
URL: https://github.com/apache/fineract/pull/1979#issuecomment-979337940
Thanks @rrpawar96
@awasum @ptuomola please note that i have already tested the functionality
of this and works for me like
--
This is an automated message from
francisguchie commented on pull request #1976:
URL: https://github.com/apache/fineract/pull/1976#issuecomment-979338917
@rrpawar96, @awasum @ptuomola I have tested this and already have it in
live production
--
This is an automated message from the Apache Git Service.
To respond to the
francisguchie commented on pull request #1982:
URL: https://github.com/apache/fineract/pull/1982#issuecomment-979340712
@rrpawar96 @awasum @ptuomola - this functionality has already been tested
by using a branch from @rrpawar96 's repo. It is ok with me.
--
This is an automated mess
rrpawar96 opened a new pull request #1984:
URL: https://github.com/apache/fineract/pull/1984
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
francisguchie commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-979448970
@rrpawar96 @ptuomola @awasum this i have tested and works for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #1725:
URL: https://github.com/apache/fineract/pull/1725#issuecomment-979525505
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the A
vidakovic merged pull request #1983:
URL: https://github.com/apache/fineract/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
francisguchie commented on pull request #1976:
URL: https://github.com/apache/fineract/pull/1976#issuecomment-979882565
@rrpawar96 i think the title should read FINERACT-1053:CustomAccountNumber
(custom)
--
This is an automated message from the Apache Git Service.
To respond to the mes
rrpawar96 opened a new pull request #1985:
URL: https://github.com/apache/fineract/pull/1985
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
bharathcgowda commented on pull request #1985:
URL: https://github.com/apache/fineract/pull/1985#issuecomment-980031678
@rrpawar96 thank you for sending this fix, could you please check and fix
the travis issue?
@ptuomola @vidakovic @thesmallstar It would be really helpful if any
ptuomola merged pull request #1981:
URL: https://github.com/apache/fineract/pull/1981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola merged pull request #1976:
URL: https://github.com/apache/fineract/pull/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
vidakovic commented on pull request #1985:
URL: https://github.com/apache/fineract/pull/1985#issuecomment-980153939
btw: I have a fix for the Travis issue... will submit later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
rrpawar96 commented on pull request #1985:
URL: https://github.com/apache/fineract/pull/1985#issuecomment-980177932
Yes, it seems the Travis build is been fixed by this PR #1981, let me also
try again by rebasing.
--
This is an automated message from the Apache Git Service.
To respond to
ptuomola closed pull request #1725:
URL: https://github.com/apache/fineract/pull/1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola commented on pull request #1725:
URL: https://github.com/apache/fineract/pull/1725#issuecomment-980499067
Let's see if the build passes now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ptuomola commented on pull request #1725:
URL: https://github.com/apache/fineract/pull/1725#issuecomment-980503370
This change makes half of the integration tests to fail... that needs to be
investigated / fixed before merging
--
This is an automated message from the Apache Git Service.
ptuomola commented on pull request #1883:
URL: https://github.com/apache/fineract/pull/1883#issuecomment-980516413
Hi @IOhacker - will you have time to finish this one off? I can give it a go
if you're busy - would be great to get this implemented...
--
This is an automated message from
vidakovic opened a new pull request #1986:
URL: https://github.com/apache/fineract/pull/1986
## Description
- proper Docker image build with reasonable startup parameters (the ones
that were in place until now were not really great)
- using the latest JDK 17 LTS release everywhere
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757832128
##
File path: .travis.yml
##
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq inst
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833279
##
File path: .travis.yml
##
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq ins
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833593
##
File path: fineract-provider/build.gradle
##
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
-enabled = false
+jib {
+f
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833811
##
File path: fineract-provider/build.gradle
##
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
c
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757834318
##
File path: fineract-provider/build.gradle
##
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
-enabled = false
+jib {
+fr
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-980826177
... not sure if my comment made it to GH... so here again:
We can do that (environment variables to configure basic auth vs. oauth)...
could we just do this in another
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757835136
##
File path: .travis.yml
##
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq ins
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757836960
##
File path: fineract-provider/build.gradle
##
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
-enabled = false
+jib {
+f
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757837024
##
File path: fineract-provider/build.gradle
##
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
c
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757838707
##
File path: fineract-provider/build.gradle
##
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
c
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757840732
##
File path: fineract-provider/build.gradle
##
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
co
ptuomola opened a new pull request #1987:
URL: https://github.com/apache/fineract/pull/1987
## Description
The licenses of 3rd party packages we were including in the distribution
packages were rather out-of-date.
Instead of "hardcoding" the licenses - which would require a l
Ankit-muellner commented on pull request #1987:
URL: https://github.com/apache/fineract/pull/1987#issuecomment-981067967
that's a good strategy. thanks @ptuomola
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ptuomola opened a new pull request #1988:
URL: https://github.com/apache/fineract/pull/1988
## Description
Findbugs logs so much output that it is impossible to find the test results
in the mix. This disables the progress reporting from Findbugs.
## Checklist
Pleas
vidakovic commented on pull request #1988:
URL: https://github.com/apache/fineract/pull/1988#issuecomment-981119421
@ptuomola thank you... that one was really annoying and polluting the build
logs...
--
This is an automated message from the Apache Git Service.
To respond to the message,
vidakovic merged pull request #1988:
URL: https://github.com/apache/fineract/pull/1988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-981351366
@ptuomola ... well... step by step sometimes doesn't work. Docker Compose on
Github Actions is just not working, so I replaced the integration test setup as
well (which was a
fynmanoj commented on a change in pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#discussion_r758322188
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientIdentifier.java
##
@@ -58,20 +62,29 @@
private Int
fynmanoj commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-981599347
@rrpawar96 , @francisguchie as per the Screenshots attached to JIRA ticket
the new field appears to be a dropdown. where does the dropdown values are
fetched from? Also if the
sheminanto opened a new pull request #1989:
URL: https://github.com/apache/fineract/pull/1989
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract
ptuomola opened a new pull request #1990:
URL: https://github.com/apache/fineract/pull/1990
## Description
Building on (and including) the excellent work of @IOhacker, this completes
the removal of Drizzle from all parts of the code. This also stops including
any JDBC driver in the
ptuomola merged pull request #1989:
URL: https://github.com/apache/fineract/pull/1989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
francisguchie commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-981928025
@fynmanoj
This list is going to be hard coded i presume the number of counties in the
world does not change that much and can be easily found here
https://www.worldo
fynmanoj commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-982244722
@francisguchie isn't it a good idea to fetch the predefined data set from
the platform itself?, especially when it is a mandatory field? That would help
others to upgrade eff
awasum commented on a change in pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#discussion_r759049043
##
File path: README.md
##
@@ -21,17 +21,17 @@ If you are interested in contributing to this project, but
perhaps don't quite k
Requirements
==
ptuomola commented on a change in pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#discussion_r759059231
##
File path: README.md
##
@@ -21,17 +21,17 @@ If you are interested in contributing to this project, but
perhaps don't quite k
Requirements
awasum commented on pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#issuecomment-982433917
I wonder if something like ./gradlew bootRun will still work? And will it be
using the default MariaDB client now?
How does this affect tomcat Deployments and reporting for cl
awasum commented on pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#issuecomment-982437584
I will have to create time to test this today or tomorrow night... But don't
let this stop you. @vidakovic, @IOhacker, @avikganguly01, @fynmanoj @rrpawar96
@francisguchie. This
ptuomola commented on pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#issuecomment-982480788
> I wonder if something like ./gradlew bootRun will still work?
> And will it be using the default MariaDB client now?
Yes, bootRun will work as I've added the Mari
vidakovic commented on pull request #1990:
URL: https://github.com/apache/fineract/pull/1990#issuecomment-982532243
note: working on an easier approach for boot run... no need for mariadb
parts after...
On Tue, 30 Nov 2021, 11:06 Petri Tuomola, ***@***.***> wrote:
> I wonder
prakash24 opened a new pull request #1991:
URL: https://github.com/apache/fineract/pull/1991
## Description
The change aims to fix monthly schedule problem when the first repayment
date is on end of February and subsequent repayment dates lies on 30th of every
month.
prakash24 closed pull request #1991:
URL: https://github.com/apache/fineract/pull/1991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
fynmanoj opened a new pull request #1992:
URL: https://github.com/apache/fineract/pull/1992
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
fynmanoj commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-984676969
@ptuomola , Kindly review this. As you have added these lines, please let me
know if you suspect any other impact for this change.
--
This is an automated message from the
fynmanoj closed pull request #1992:
URL: https://github.com/apache/fineract/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
fynmanoj edited a comment on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-984676969
@ptuomola , Kindly review this. please let me know if you suspect any other
impact for this change.
--
This is an automated message from the Apache Git Service.
To
BLasan commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-984859582
@ptuomola Could you please review this? With the `exclude` part, email
sending was not getting executed (class not found error was throwing)
--
This is an automated message fr
ptuomola commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985161158
@BLasan the build seems to be still failing due to duplicate classes...
The reason why the exclusion is exactly to resolve this duplication of
classes: otherwise we hav
ptuomola edited a comment on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985161158
@BLasan the build seems to be still failing due to duplicate classes...
The reason why the exclusion is exactly to resolve this duplication of
classes: otherwise
fynmanoj commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985257058
Hi @ptuomola , I have added the stack trace in this ticket
https://issues.apache.org/jira/browse/FINERACT-1448
--
This is an automated message from the Apache Git Servic
ptuomola opened a new pull request #1993:
URL: https://github.com/apache/fineract/pull/1993
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
ptuomola commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985528490
I created a PR that hopefully fixes this - see #1993. Let's see if that
works...
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ptuomola commented on pull request #1993:
URL: https://github.com/apache/fineract/pull/1993#issuecomment-985532823
Hopefully this fixes the dependency issue that was stopping email sending
from working.
Now what would be really great is: some integration tests that confirm that
bot
fynmanoj commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985594991
@ptuomola , Thank you very much. This should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
fynmanoj closed pull request #1992:
URL: https://github.com/apache/fineract/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
fynmanoj commented on pull request #1992:
URL: https://github.com/apache/fineract/pull/1992#issuecomment-985653156
Fixed by : https://github.com/apache/fineract/pull/1993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ptuomola merged pull request #1993:
URL: https://github.com/apache/fineract/pull/1993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola opened a new pull request #1994:
URL: https://github.com/apache/fineract/pull/1994
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
rrpawar96 commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-986007523
@fynmanoj , please re-review this PR, now we are fetching the countries list
from the database so it can be modified directly from the database.
The documentTypeValue param
1 - 100 of 15550 matches
Mail list logo
