[GitHub] [incubator-mxnet] gyshi commented on issue #15753: Numpy add numpy linalg norm and numpy min

2019-08-05 Thread GitBox
gyshi commented on issue #15753: Numpy add numpy linalg norm and numpy min URL: https://github.com/apache/incubator-mxnet/pull/15753#issuecomment-518511756 done This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] TaoLv commented on issue #15613: [Discussion] 1.5.1 Patch Release

2019-08-05 Thread GitBox
TaoLv commented on issue #15613: [Discussion] 1.5.1 Patch Release URL: https://github.com/apache/incubator-mxnet/issues/15613#issuecomment-518511236 > @TaoLv Lets include #15692 in the 1.5.1 release to fix #15737 Thanks for reporting. Added it to

[GitHub] [incubator-mxnet] gyshi removed a comment on issue #15753: Numpy add numpy linalg norm and numpy min

2019-08-05 Thread GitBox
gyshi removed a comment on issue #15753: Numpy add numpy linalg norm and numpy min URL: https://github.com/apache/incubator-mxnet/pull/15753#issuecomment-518479488 > @gyshi Please separate this into 2 PRs: one for linalg.norm, the other for np.min. OK, because i use min in my op

[GitHub] [incubator-mxnet] TaoLv commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format"

2019-08-05 Thread GitBox
TaoLv commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format" URL: https://github.com/apache/incubator-mxnet/issues/15737#issuecomment-518509859 Thanks for the prompt response @samskalicky . I will update the wiki page accordingly.

[GitHub] [incubator-mxnet] pengzhao-intel edited a comment on issue #15589: [Discussion] 1.6.0 Roadmap

2019-08-05 Thread GitBox
pengzhao-intel edited a comment on issue #15589: [Discussion] 1.6.0 Roadmap URL: https://github.com/apache/incubator-mxnet/issues/15589#issuecomment-513055092 CPU related proposal for 1.6 (keep updating in the following several days). 1. **WIP**, MKL-DNN upgrade to 1.0 - the

[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #15613: [Discussion] 1.5.1 Patch Release

2019-08-05 Thread GitBox
samskalicky edited a comment on issue #15613: [Discussion] 1.5.1 Patch Release URL: https://github.com/apache/incubator-mxnet/issues/15613#issuecomment-518430120 @TaoLv Lets include https://github.com/apache/incubator-mxnet/pull/15692 in the 1.5.1 release to fix

[GitHub] [incubator-mxnet] samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format"

2019-08-05 Thread GitBox
samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format" URL: https://github.com/apache/incubator-mxnet/issues/15737#issuecomment-518501223 @TaoLv I tried building with the v1.5.x branch and confirmed that it failed. I cherry picked your PR in and rebuilt, and

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
sandeep-krishnamurthy commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518495671 > +1 > > It's a nice proposal which can save lots of maintaining efforts for a different

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
pengzhao-intel commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518492849 +1 It's a nice proposal which can save lots of maintaining efforts for a different organization with a

[GitHub] [incubator-mxnet] gyshi commented on issue #15753: Numpy add numpy linalg norm and numpy min

2019-08-05 Thread GitBox
gyshi commented on issue #15753: Numpy add numpy linalg norm and numpy min URL: https://github.com/apache/incubator-mxnet/pull/15753#issuecomment-518479488 > @gyshi Please separate this into 2 PRs: one for linalg.norm, the other for np.min. OK, because i use min in my op

[GitHub] [incubator-mxnet] hgt312 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
hgt312 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310863702 ## File path: src/operator/tensor/indexing_op.h ## @@ -341,6 +341,53 @@ struct

[GitHub] [incubator-mxnet] hubutui commented on issue #15294: mkldnn is not properly installed

2019-08-05 Thread GitBox
hubutui commented on issue #15294: mkldnn is not properly installed URL: https://github.com/apache/incubator-mxnet/issues/15294#issuecomment-518475606 @pengzhao-intel I'm not sure, I don't use the Makefile to build, I use cmake.

[GitHub] [incubator-mxnet] DickJC123 commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params

2019-08-05 Thread GitBox
DickJC123 commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params URL: https://github.com/apache/incubator-mxnet/pull/15688#discussion_r310862530 ## File path: src/operator/tensor/matrix_op.cc ## @@ -763,7 +763,7 @@ parameter

[incubator-mxnet] branch ib/jl-mxnet-root-env updated (f1a36fb -> 36076c4)

2019-08-05 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a change to branch ib/jl-mxnet-root-env in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from f1a36fb Revert "runtime_functions: test backward compatibility" add 858e171 1.5.0 news

[GitHub] [incubator-mxnet] larroy commented on issue #15762: [WIP] Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes.

2019-08-05 Thread GitBox
larroy commented on issue #15762: [WIP] Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes. URL: https://github.com/apache/incubator-mxnet/pull/15762#issuecomment-518465478 @zhreshold @anirudh2290

[GitHub] [incubator-mxnet] xinyu-intel commented on a change in pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
xinyu-intel commented on a change in pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754#discussion_r310854086 ## File path: python/mxnet/contrib/quantization.py ## @@ -780,3 +820,170 @@ def calib_graph(qsym,

[GitHub] [incubator-mxnet] larroy commented on issue #15762: [WIP] Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes.

2019-08-05 Thread GitBox
larroy commented on issue #15762: [WIP] Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes. URL: https://github.com/apache/incubator-mxnet/pull/15762#issuecomment-518463348 @mxnet-label-bot add [pr-work-in-progress]

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 85373f9 Bump the publish

[incubator-mxnet] branch revert-15489-acc_api updated (01ffe9b -> 153872c)

2019-08-05 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 01ffe9b CI add 153872c retrigger CI No new revisions were added by this update.

[GitHub] [incubator-mxnet] larroy opened a new pull request #15762: Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes.

2019-08-05 Thread GitBox
larroy opened a new pull request #15762: Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes. URL: https://github.com/apache/incubator-mxnet/pull/15762 ## Description ## This PR improves initialization of the Library which uses unsafe passing

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
zixuanweeei commented on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518461277 Feel free to directly mention me here if there is any question . BTW, we are working on integrating the LBR-GRU of MKL-DNN

[GitHub] [incubator-mxnet] samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format"

2019-08-05 Thread GitBox
samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format" URL: https://github.com/apache/incubator-mxnet/issues/15737#issuecomment-518461295 Sure, will try and report back > On Aug 5, 2019, at 6:23 PM, Tao Lv wrote: > > Thanks @TaoLv, it does work

[GitHub] [incubator-mxnet] eloi-loomai commented on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
eloi-loomai commented on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518459506 Not sure This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] eloi-loomai edited a comment on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
eloi-loomai edited a comment on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518459506 Not sure, LSTM seems to work. This is an automated message

[GitHub] [incubator-mxnet] TaoLv commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format"

2019-08-05 Thread GitBox
TaoLv commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format" URL: https://github.com/apache/incubator-mxnet/issues/15737#issuecomment-518458801 > Thanks @TaoLv, it does work with `mxnet-mkl --pre` > > Can you share the PR that has the fix? Is it a fix that can go into

[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #15760: build sample library in CI

2019-08-05 Thread GitBox
mseth10 commented on a change in pull request #15760: build sample library in CI URL: https://github.com/apache/incubator-mxnet/pull/15760#discussion_r310849601 ## File path: tests/python/unittest/test_library_loading.py ## @@ -33,6 +33,7 @@ def test_library_loading():

[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #15761: [OpPerf] Handle positional arguments

2019-08-05 Thread GitBox
ChaiBapchya opened a new pull request #15761: [OpPerf] Handle positional arguments URL: https://github.com/apache/incubator-mxnet/pull/15761 ## Description ## Fixes https://github.com/apache/incubator-mxnet/issues/15735 Currently, OpPerf utility only takes keyworded arguments

[GitHub] [incubator-mxnet] mseth10 opened a new pull request #15760: build sample library in CI

2019-08-05 Thread GitBox
mseth10 opened a new pull request #15760: build sample library in CI URL: https://github.com/apache/incubator-mxnet/pull/15760 ## Description ## This PR aims to modify the unit test in https://github.com/apache/incubator-mxnet/pull/15489, which needs a built library to load. This PR

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
zixuanweeei commented on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518454755 Is there any problem with the order? The native LSTM implementation of MXNet shares the same order of gates with that of MKL-DNN,

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15759: [Optimizer] Gradient is mutated in the Adam optimizer

2019-08-05 Thread GitBox
mxnet-label-bot commented on issue #15759: [Optimizer] Gradient is mutated in the Adam optimizer URL: https://github.com/apache/incubator-mxnet/issues/15759#issuecomment-518447282 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels

[GitHub] [incubator-mxnet] sxjscience opened a new issue #15759: [Optimizer] Gradient is mutated in the Adam optimizer

2019-08-05 Thread GitBox
sxjscience opened a new issue #15759: [Optimizer] Gradient is mutated in the Adam optimizer URL: https://github.com/apache/incubator-mxnet/issues/15759 In the implementation of Adam: grad, mean and var are all mutated (See

[incubator-mxnet] branch revert-15489-acc_api updated (95b02a9 -> 01ffe9b)

2019-08-05 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 95b02a9 Retrigger CI add 01ffe9b CI No new revisions were added by this update.

[GitHub] [incubator-mxnet] wkcn edited a comment on issue #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
wkcn edited a comment on issue #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755#issuecomment-518446105 Maybe we can only disable the related test temporarily. This is

[GitHub] [incubator-mxnet] wkcn commented on issue #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
wkcn commented on issue #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755#issuecomment-518446105 Maybe we can only disable the related test. This is an automated

[GitHub] [incubator-mxnet] roywei commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
roywei commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518441849 +1 cycled reference between github disucssion and dev list dicussion is confusing.

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15715: Improve diagnose.py to display environment variables

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15715: Improve diagnose.py to display environment variables URL: https://github.com/apache/incubator-mxnet/pull/15715#discussion_r310833617 ## File path: tools/diagnose.py ## @@ -171,6 +161,31 @@ def check_network(args):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15715: Improve diagnose.py to display environment variables

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15715: Improve diagnose.py to display environment variables URL: https://github.com/apache/incubator-mxnet/pull/15715#discussion_r310833617 ## File path: tools/diagnose.py ## @@ -171,6 +161,31 @@ def check_network(args):

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
marcoabreu commented on issue #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755#issuecomment-518439661 Yes JackieWu schrieb am Di., 6. Aug. 2019, 01:27: > Does it avoid the risk to build the dynamic library in CI rather

[incubator-mxnet] branch revert-15489-acc_api updated (1e97b86 -> 95b02a9)

2019-08-05 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 1e97b86 Revert "Dynamic Library Loading Support (#15489)" add 95b02a9 Retrigger CI No

[GitHub] [incubator-mxnet] wkcn commented on issue #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
wkcn commented on issue #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755#issuecomment-518437645 Does it avoid the risk to build the dynamic library in CI rather than download?

[GitHub] [incubator-mxnet] larroy closed pull request #13472: [WIP][Don't merge] Comment out dmlc::SetEnv in pthread_atfork #13438

2019-08-05 Thread GitBox
larroy closed pull request #13472: [WIP][Don't merge] Comment out dmlc::SetEnv in pthread_atfork #13438 URL: https://github.com/apache/incubator-mxnet/pull/13472 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] larroy commented on issue #14836: Refactor AGInfo and Imperative

2019-08-05 Thread GitBox
larroy commented on issue #14836: Refactor AGInfo and Imperative URL: https://github.com/apache/incubator-mxnet/pull/14836#issuecomment-518436181 @mxnet-label-bot remove [pr-awaiting-response] This is an automated message

[GitHub] [incubator-mxnet] larroy commented on issue #14836: Refactor AGInfo and Imperative

2019-08-05 Thread GitBox
larroy commented on issue #14836: Refactor AGInfo and Imperative URL: https://github.com/apache/incubator-mxnet/pull/14836#issuecomment-518435973 @mxnet-label-bot add [pr-awaiting-review] This is an automated message from the

[GitHub] [incubator-mxnet] larroy commented on issue #14836: Refactor AGInfo and Imperative

2019-08-05 Thread GitBox
larroy commented on issue #14836: Refactor AGInfo and Imperative URL: https://github.com/apache/incubator-mxnet/pull/14836#issuecomment-518436045 @mxnet-label-bot remove [pr-work-in-progress] This is an automated message from

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518434385 @marcoabreu I think we're in agreement here. We will be distributing some pre-built libraries in an S3 bucket as examples. We will provide

[GitHub] [incubator-mxnet] access2rohit commented on issue #15758: UNIX_CPU build failing

2019-08-05 Thread GitBox
access2rohit commented on issue #15758: UNIX_CPU build failing URL: https://github.com/apache/incubator-mxnet/issues/15758#issuecomment-518431417 @mxnet-label-bot add [CI] This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15758: UNIX_CPU build failing

2019-08-05 Thread GitBox
mxnet-label-bot commented on issue #15758: UNIX_CPU build failing URL: https://github.com/apache/incubator-mxnet/issues/15758#issuecomment-518431355 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet

[GitHub] [incubator-mxnet] access2rohit opened a new issue #15758: UNIX_CPU build failing

2019-08-05 Thread GitBox
access2rohit opened a new issue #15758: UNIX_CPU build failing URL: https://github.com/apache/incubator-mxnet/issues/15758 http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/activity failing consistently Train MNIST is failing

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518431226 No pulling of any prebuilt binaries due to the same reasons, please. I understand you trying to make it more convenient, but I think that

[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky edited a comment on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518404947 @marcoabreu we added an example directory at: example/lib_api. Currently the test.py includes a test that uses the locally built

[GitHub] [incubator-mxnet] samskalicky commented on issue #15613: [Discussion] 1.5.1 Patch Release

2019-08-05 Thread GitBox
samskalicky commented on issue #15613: [Discussion] 1.5.1 Patch Release URL: https://github.com/apache/incubator-mxnet/issues/15613#issuecomment-518430120 @TaoLv Can #15737 be fixed in 1.5.1? This is an automated message

[GitHub] [incubator-mxnet] vdantu commented on issue #15734: How to get computation cost and communication cost in distributed training?

2019-08-05 Thread GitBox
vdantu commented on issue #15734: How to get computation cost and communication cost in distributed training? URL: https://github.com/apache/incubator-mxnet/issues/15734#issuecomment-518424537 @mxnet-label-bot add [question, training] @apeforest @yuxihu : Would you be able to help

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r31081 ## File path: src/operator/numpy/indexing_op.cc ## @@ -0,0 +1,158 @@ +/* + *

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310810460 ## File path: python/mxnet/numpy/multiarray.py ## @@ -1879,6 +1879,85 @@ def

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310810220 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -590,6 +590,88 @@ def

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310809625 ## File path: src/operator/tensor/indexing_op.h ## @@ -341,6 +341,53 @@

[GitHub] [incubator-mxnet] wkcn commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND`

2019-08-05 Thread GitBox
wkcn commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND` URL: https://github.com/apache/incubator-mxnet/pull/15751#issuecomment-518416439 @sxjscience The previous test is also wrong. In the previous test, I passed the memory address of a NDArray into

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310808895 ## File path: src/operator/tensor/indexing_op.h ## @@ -341,6 +341,53 @@

[GitHub] [incubator-mxnet] IvyBazan commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
IvyBazan commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518415560 Issues related to missing content: Missing nin content-https://github.com/apache/incubator-mxnet/issues/15729#issuecomment-518131446 Missing nnvm

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310804504 ## File path: include/mxnet/tuple.h ## @@ -366,7 +366,6 @@ class Tuple { } }; - Review

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310804533 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*!

[GitHub] [incubator-mxnet] IvyBazan commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
IvyBazan commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518410177 @marcoabreu I removed those links because I couldn't find any replacement for the content that was hosted on dmlc.ml. It seems better to temporarily have

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518404947 @marcoabreu we added an example directory at: example/lib_api. Currently the test.py includes a test that uses the locally built library

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
marcoabreu commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518404430 We can't use the CI system for performance measurements since it does not provide a consistent environment for

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e128999 Bump the publish

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518399555 > We'll move the test pulling from the S3 bucket to the examples directory so that it doesnt run in the CI. Could you elaborate?

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310787012 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*!

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310786940 ## File path: src/c_api/c_api_symbolic.cc ## @@ -658,6 +658,85 @@ int MXSymbolInferShapeEx(SymbolHandle

[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky edited a comment on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518393421 Thanks @marcoabreu for the catch. As we discussed offline, the problem is not with the feature in this PR but with how

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518393421 Thanks @marcoabreu for the catch. As we discussed offline, the problem is not with the feature in this PR but with how

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310784456 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310784456 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310783434 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782505 ## File path: src/c_api/c_api_symbolic.cc ## @@ -585,6 +586,96 @@ int MXSymbolInferShape(SymbolHandle sym,

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782296 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*! \brief

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782321 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*! \brief

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781490 ## File path: python/mxnet/ndarray/ndarray.py ## @@ -131,14 +133,24 @@ def _new_alloc_handle(shape, ctx,

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781096 ## File path: include/mxnet/tuple.h ## @@ -366,7 +366,6 @@ class Tuple { } }; - Review comment:

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310780707 ## File path: include/mxnet/c_api.h ## @@ -55,7 +55,9 @@ extern "C" { #endif /*! \brief manually

[GitHub] [incubator-mxnet] sandeep-krishnamurthy opened a new issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
sandeep-krishnamurthy opened a new issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757 **Problem Statement** 1. Performance tests are not integrated with CI. We do not run any performance tests during PR

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
mxnet-label-bot commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518388377 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754#discussion_r310776345 ## File path: python/mxnet/contrib/quantization.py ## @@ -780,3 +820,170 @@ def calib_graph(qsym,

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754#discussion_r310777249 ## File path: python/mxnet/contrib/quantization.py ## @@ -780,3 +820,170 @@ def calib_graph(qsym,

[GitHub] [incubator-mxnet] haojin2 commented on issue #15753: Numpy add numpy linalg norm and numpy min

2019-08-05 Thread GitBox
haojin2 commented on issue #15753: Numpy add numpy linalg norm and numpy min URL: https://github.com/apache/incubator-mxnet/pull/15753#issuecomment-518384022 @gyshi Please separate this into 2 PRs: one for linalg.norm, the other for np.min.

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
aaronmarkham commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518380481 @marcoabreu Sorry about rushing that through without addressing your questions. We needed to be rid of the malware links ASAP. @IvyBazan Can you

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310766155 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310763807 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310763807 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #15756: Fix flaky test test_global_metric

2019-08-05 Thread GitBox
ptrendx opened a new pull request #15756: Fix flaky test test_global_metric URL: https://github.com/apache/incubator-mxnet/pull/15756 ## Description ## Fixes #15592 The reason for assertion failure was that sometimes the random inputs would produce `nan` as a result, which would

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310762141 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e130fcc Bump the publish

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761132 ## File path: include/mxnet/tuple.h ## @@ -272,6 +272,14 @@ class Tuple { is.get(); if (ch == '(' || ch

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310757672 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[incubator-mxnet] branch v1.5.x updated: DMLC link removal (#15708)

2019-08-05 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch v1.5.x in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.5.x by this push: new 0a3413f DMLC link removal

[GitHub] [incubator-mxnet] aaronmarkham merged pull request #15708: DMLC link removal

2019-08-05 Thread GitBox
aaronmarkham merged pull request #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310757672 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[GitHub] [incubator-mxnet] marcoabreu opened a new pull request #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
marcoabreu opened a new pull request #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755 Reverts apache/incubator-mxnet#15489 Reason is the fact that this change poses a security risk:

[incubator-mxnet] branch revert-15489-acc_api created (now 1e97b86)

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a change to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 1e97b86 Revert "Dynamic Library Loading Support (#15489)" This branch includes the

  1   2   >