Re: [PR] xtensa/esp32s3: Add XTWDT support [nuttx]

2023-11-13 Thread via GitHub
pkarashchenko commented on PR #11179: URL: https://github.com/apache/nuttx/pull/11179#issuecomment-1809683675 Please resolve merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] the bug of sscanf exception output in arm64 platform [nuttx]

2023-11-13 Thread via GitHub
pkarashchenko commented on code in PR #11182: URL: https://github.com/apache/nuttx/pull/11182#discussion_r1392114769 ## libs/libc/stdio/lib_libvscanf.c: ## @@ -315,6 +315,37 @@ int lib_vscanf(FAR struct lib_instream_s *stream, FAR int *lastc, fmt++;

Re: [PR] virtio: add virtio framework in NuttX [nuttx]

2023-11-13 Thread via GitHub
CV-Bowen commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1809607877 @masayuki2009 OK, I will try QEMU-8.1.2 later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] mm: free delay list when exceeding specified count [nuttx]

2023-11-13 Thread via GitHub
XuNeo opened a new pull request, #11183: URL: https://github.com/apache/nuttx/pull/11183 ## Summary This configuration allows delaying the freeing of memory until the count of delayed memory nodes surpasses a specified limit. When used in conjunction with KASAN (Kernel Address Saniti

Re: [PR] virtio: add virtio framework in NuttX [nuttx]

2023-11-13 Thread via GitHub
masayuki2009 commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1809594823 @CV-Bowen I noticed that rv-virt with the new VirtIO framework does not work with QEMU-8.1.2. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] matter: add compile support for NuttX [nuttx-apps]

2023-11-13 Thread via GitHub
zhhyu7 closed pull request #2186: matter: add compile support for NuttX URL: https://github.com/apache/nuttx-apps/pull/2186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
anchao commented on PR #11177: URL: https://github.com/apache/nuttx/pull/11177#issuecomment-1809525088 Ready to review now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1391963607 ## binfmt/binfmt_execmodule.c: ## @@ -400,17 +398,6 @@ int exec_module(FAR struct binary_s *binp, } #endif - /* Perform file actions */ - - if (actions != NULL

[PR] the bug of sscanf exception output in arm64 platform [nuttx]

2023-11-13 Thread via GitHub
Boatingup opened a new pull request, #11182: URL: https://github.com/apache/nuttx/pull/11182 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: d92a7011fdc6e25818085f260c14313fc17f67f7

2023-11-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 099d69dd Publishing web: 36ddd7c6

(nuttx) branch master updated: xtensa/esp32s3: Add RWDT support

2023-11-13 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new d92a7011fd xtensa/esp32s3: Add RWDT support d92a

Re: [PR] xtensa/esp32s3: Add RWDT support [nuttx]

2023-11-13 Thread via GitHub
acassis merged PR #11180: URL: https://github.com/apache/nuttx/pull/11180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: stm32/stm32_adc.c: protect irq_attach with refcounter

2023-11-13 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0e40cc2853 stm32/stm32_adc.c: protect irq_attach

Re: [PR] stm32/stm32_adc.c: protect irq_attach with refcounter [nuttx]

2023-11-13 Thread via GitHub
acassis merged PR #11181: URL: https://github.com/apache/nuttx/pull/11181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1391471383 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret = pthread

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1391460655 ## sched/tls/tls_initinfo.c: ## @@ -22,9 +22,13 @@ * Included Files / +#include + #in

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1391459966 ## sched/task/task_setcanceltype.c: ## @@ -52,77 +52,3 @@ * / Review Comment: Oops, y

Re: [PR] drivers/foc: return scaling factor for phase currents and BEMF via ioctl [nuttx]

2023-11-13 Thread via GitHub
raiden00pl commented on code in PR #11176: URL: https://github.com/apache/nuttx/pull/11176#discussion_r1391452690 ## boards/arm/stm32/common/src/stm32_ihm07m1.c: ## @@ -307,6 +307,17 @@ static int board_foc_info_get(struct foc_dev_s *dev, info->hw_cfg.pwm_dt_ns = PWM_DEADTIME

Re: [PR] drivers/foc: return scaling factor for phase currents and BEMF via ioctl [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11176: URL: https://github.com/apache/nuttx/pull/11176#discussion_r1391404410 ## boards/arm/stm32f7/steval-eth001v1/src/stm32_foc.c: ## @@ -256,10 +259,8 @@ static struct stm32_foc_board_ops_s g_stm32_foc_board_ops = static struct stm3

(nuttx-apps) branch master updated: examples/foc: set direction when updating new setpoint

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new b52f7dae0 examples/foc: set direction whe

Re: [PR] examples/foc: set direction when updating new setpoint [nuttx-apps]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #2193: URL: https://github.com/apache/nuttx-apps/pull/2193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] examples/foc: start from the beginning if control loop is started [nuttx-apps]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #2190: URL: https://github.com/apache/nuttx-apps/pull/2190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: examples/foc: start from the beginning if control loop is started

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 1095aec16 examples/foc: start from the be

(nuttx-apps) 04/04: examples/foc: fix warning for sensored configurations

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit f9a4ace59a191807f77f519a37e1e39d47728147 Author: raiden00pl AuthorDate: Tue Nov 7 17:57:28 2023 +0100 exampl

Re: [PR] examples/foc: various fixes foc_cfg.h [nuttx-apps]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #2191: URL: https://github.com/apache/nuttx-apps/pull/2191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) 02/04: examples/foc: add #error messages

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 8a04e2b282d8fb76dd280c42dd5ced5e38e32469 Author: raiden00pl AuthorDate: Tue Nov 7 17:57:07 2023 +0100 exampl

(nuttx-apps) 01/04: examples/foc: allow sensored velocity mode

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 3c541c496bf3249b9b02dde1d26df996ee0f1632 Author: raiden00pl AuthorDate: Tue Nov 7 17:53:25 2023 +0100 exampl

(nuttx-apps) branch master updated (ac64c7d14 -> f9a4ace59)

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from ac64c7d14 add short command-line arguments and record execution time new 3c541c496 examples/foc: allow sen

(nuttx-apps) 03/04: examples/foc: raise error if both sensorless and sensored modes enabled

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 87dcf877e70662141922d41e35a1eb4abe7f4338 Author: raiden00pl AuthorDate: Wed Nov 8 15:04:54 2023 +0100 exampl

(nuttx) branch master updated: stm32/foc: add support for board-specific ioctl

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 225d5bba6e stm32/foc: add support for board-sp

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1391341383 ## include/nuttx/tls.h: ## @@ -206,6 +206,12 @@ struct tls_info_s struct pthread_cleanup_s tl_stack[CONFIG_PTHREAD_CLEANUP_STACKSIZE]; #endif + uint8_t t

Re: [PR] stm32/foc: add support for board-specific ioctl [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #11175: URL: https://github.com/apache/nuttx/pull/11175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] stm32/stm32_adc.c: protect irq_attach with refcounter [nuttx]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #11181: URL: https://github.com/apache/nuttx/pull/11181 ## Summary stm32/stm32_adc.c: protect irq_attach with refcounter irq_attach should only be called once for ADCs that share a common interrupt handler. We can move irq_attach to just before

[PR] xtensa/esp32s3: Add RWDT support [nuttx]

2023-11-13 Thread via GitHub
eren-terzioglu opened a new pull request, #11180: URL: https://github.com/apache/nuttx/pull/11180 ## Summary xtensa/esp32s3: Add rwdt support ## Impact Only esp32s3 ## Testing `esp32s3-devkit:watchdog` config used with `RTC Watchdog Timer` option enabled un

(nuttx) branch master updated: uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b3f20d4bd6 uart_tcsendbreak: Remove cancel poi

Re: [PR] uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #11178: URL: https://github.com/apache/nuttx/pull/11178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] xtensa/esp32s3: Add XTWDT support [nuttx]

2023-11-13 Thread via GitHub
eren-terzioglu opened a new pull request, #11179: URL: https://github.com/apache/nuttx/pull/11179 ## Summary * xtensa/esp32s3: Add XTWDT support * xtensa/esp32s3: Add rtc defconfig ## Impact Only esp32s3 ## Testing Modified version of `watchdog` example u

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-13 Thread via GitHub
xiaoxiang781216 commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1808313047 It doesn't work as epxect, because nuttx/Makefile invoke apps/Makefile, but not include apps/Makefile. nuttx's Makefile can't see EXTRA_LIBS you add in examples/libtest/Ma

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-13 Thread via GitHub
casaroli commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1808294354 > Which Make.defs do you modify? Hello, I did not modify any `Make.defs`. I expect that libtest would work with the default [Make.defs](https://github.com/apache/nu

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-13 Thread via GitHub
xiaoxiang781216 commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1808284015 Which Make.defs do you modify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(nuttx) branch master updated: drivers/segger/Kconfig: cosmetics

2023-11-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7996266f6e drivers/segger/Kconfig: cosmetics 7

Re: [PR] drivers/segger/Kconfig: cosmetics [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 merged PR #11174: URL: https://github.com/apache/nuttx/pull/11174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1391172544 ## sched/tls/tls_initinfo.c: ## @@ -66,5 +70,17 @@ int tls_init_info(FAR struct tcb_s *tcb) /* Attach per-task info in group to TLS */ info->tl_task = t

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1391116716 ## binfmt/binfmt_execmodule.c: ## @@ -400,17 +398,6 @@ int exec_module(FAR struct binary_s *binp, } #endif - /* Perform file actions */ - - if (actions != NULL

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1391101304 ## binfmt/binfmt_execmodule.c: ## @@ -400,17 +398,6 @@ int exec_module(FAR struct binary_s *binp, } #endif - /* Perform file actions */ - - if (actions != NULL

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1391101304 ## binfmt/binfmt_execmodule.c: ## @@ -400,17 +398,6 @@ int exec_module(FAR struct binary_s *binp, } #endif - /* Perform file actions */ - - if (actions != NULL

[PR] uart_tcsendbreak: Remove cancel point, as tcsendbreak is not one [nuttx]

2023-11-13 Thread via GitHub
pussuw opened a new pull request, #11178: URL: https://github.com/apache/nuttx/pull/11178 ## Summary tcsendbreak is not a cancellation point -> remove cancel point logic from it. Reference: https://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html ## Imp

[PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-13 Thread via GitHub
anchao opened a new pull request, #11177: URL: https://github.com/apache/nuttx/pull/11177 ## Summary sched/taskfiles: skip unnecessary file open/close operations to improve performance The task files should consult the "spawn action" and "O_CLOEXEC flags" to determine furthe

[PR] examples/foc: set direction when updating new setpoint [nuttx-apps]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #2193: URL: https://github.com/apache/nuttx-apps/pull/2193 ## Summary examples/foc: set direction when updating new setpoint ## Impact refactor ## Testing locally on various hw -- This is an automated message from the Apache

[PR] examples/foc: fixes for sensored operation mode [nuttx-apps]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #2192: URL: https://github.com/apache/nuttx-apps/pull/2192 ## Summary - examples/foc: get velocity from observer if sensored mode - examples/foc: fix active brake for sensored mode - examples/foc: fix compilation for open-loop without angle obser

[PR] examples/foc: various fixes foc_cfg.h [nuttx-apps]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #2191: URL: https://github.com/apache/nuttx-apps/pull/2191 ## Summary - examples/foc: allow sensored velocity mode - examples/foc: add #error messages - examples/foc: raise error if both sensorless and sensored modes enabled - examples/foc: fi

[PR] examples/foc: start from the beginning if control loop is started [nuttx-apps]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #2190: URL: https://github.com/apache/nuttx-apps/pull/2190 ## Summary - examples/foc: start from the beginning if control loop is started After the start request to FOC device, we should return to the beginning of the loop and wait for the first

[PR] drivers/foc: return scaling factor for phase currents and BEMF via ioctl [nuttx]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #11176: URL: https://github.com/apache/nuttx/pull/11176 ## Summary - drivers/foc: get hardware information via lower-half interface - drivers/foc: return scaling factor for phase currents and BEMF via ioctl These values are board-specific p

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on PR #11165: URL: https://github.com/apache/nuttx/pull/11165#issuecomment-1807967384 > @pussuw what are the pros and cons of moving the cancellation points to user space/libc ? @acassis My primary concern and motivation for doing these changes is to improve security

[PR] stm32/foc: add support for board-specific ioctl [nuttx]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #11175: URL: https://github.com/apache/nuttx/pull/11175 ## Summary stm32/foc: add support for board-specific ioctl ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] drivers/segger/Kconfig: cosmetics [nuttx]

2023-11-13 Thread via GitHub
raiden00pl opened a new pull request, #11174: URL: https://github.com/apache/nuttx/pull/11174 ## Summary drivers/segger/Kconfig: cosmetics ## Impact ## Testing ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390941495 ## libs/libc/sched/CMakeLists.txt: ## @@ -26,11 +26,11 @@ set(SRCS clock_timespec_add.c clock_timespec_subtract.c clock_getcpuclockid.c -clock_getres.

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390939391 ## include/nuttx/tls.h: ## @@ -205,6 +205,12 @@ struct tls_info_s struct pthread_cleanup_s stack[CONFIG_PTHREAD_CLEANUP_STACKSIZE]; Review Comment: Ok -- This

Re: [PR] arch/arm: Let's old arm's arm_doirq return register context like armv7-a [nuttx]

2023-11-13 Thread via GitHub
raiden00pl merged PR #11170: URL: https://github.com/apache/nuttx/pull/11170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

(nuttx) branch master updated: arch/arm: Let's old arm's arm_doirq return register context like armv7-a

2023-11-13 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 459f8235e4 arch/arm: Let's old arm's arm_doirq

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390938982 ## include/nuttx/tls.h: ## @@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex); #elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__) Review Comment:

(nuttx) branch master updated: rp2040: pwm: Fix errors at CONFIG_PWM_NCHANNELS=1

2023-11-13 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c076cb1bef rp2040: pwm: Fix errors at CONFIG_PW

Re: [PR] rp2040: pwm: Fix errors at CONFIG_PWM_NCHANNELS=1 [nuttx]

2023-11-13 Thread via GitHub
raiden00pl merged PR #11172: URL: https://github.com/apache/nuttx/pull/11172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

(nuttx) branch master updated: Documentation: flipperzero: Fix typo

2023-11-13 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4e89313913 Documentation: flipperzero: Fix typo

Re: [PR] Documentation: flipperzero: Fix typo [nuttx]

2023-11-13 Thread via GitHub
raiden00pl merged PR #11173: URL: https://github.com/apache/nuttx/pull/11173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390933827 ## sched/tls/tls_initinfo.c: ## @@ -66,5 +70,17 @@ int tls_init_info(FAR struct tcb_s *tcb) /* Attach per-task info in group to TLS */ info->tl_task = tcb->group

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390933549 ## include/nuttx/tls.h: ## @@ -205,6 +205,12 @@ struct tls_info_s struct pthread_cleanup_s stack[CONFIG_PTHREAD_CLEANUP_STACKSIZE]; #endif + uint8_t tl_cpstate;

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390933131 ## libs/libc/sched/task_cancelpt.c: ## @@ -0,0 +1,289 @@ +/ + * libs/libc/sched/task_cancelpt

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-13 Thread via GitHub
pussuw commented on PR #11165: URL: https://github.com/apache/nuttx/pull/11165#issuecomment-1807897534 > > @pkarashchenko @patacongo You might be interested in this. Also, do you mind if I remove the nested cancellation point logic now as well ? > > That is something I had planned to

[PR] Documentation: flipperzero: Fix typo [nuttx]

2023-11-13 Thread via GitHub
takumiando opened a new pull request, #11173: URL: https://github.com/apache/nuttx/pull/11173 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e