[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #9138: URL: https://github.com/apache/nuttx/pull/9138#issuecomment-1550784058 @mu578 but all possible combination(4) are valid and useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[nuttx] 01/02: libc/string: prevent libc in the kernel/userspace optionally

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 58e97e521c9ef38851dccab84c6313c04aaa95d8 Author: Tiago Medicci Serrano AuthorDate: Fri Apr 28 13:55:23 2023 -0300

[nuttx] 02/02: arch/xtensa/esp32_esp32s3: prevent arch's libc in the userspace

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 496a77653a57845c660d0e3758d92f7c4cfd6adf Author: Tiago Medicci Serrano AuthorDate: Wed May 3 15:30:20 2023 -0300

[nuttx] branch master updated (6be363ff35 -> 496a77653a)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6be363ff35 drivers/serial: fix race condition in multi-thread write new 58e97e521c libc/string: prevent libc

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9138: URL: https://github.com/apache/nuttx/pull/9138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] btashton commented on a diff in pull request #9287: usbhost: Make unplugging hubs more reliable.

2023-05-16 Thread via GitHub
btashton commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195974689 ## drivers/usbhost/usbhost_hub.c: ## @@ -1491,7 +1521,7 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) { Review Comment: Is this correct for

[GitHub] [nuttx] lupyuen commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
lupyuen commented on code in PR #9304: URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195973988 ## boards/arm64/a64/pinephone/Kconfig: ## @@ -17,4 +17,10 @@ config PINEPHONE_LCD ---help--- Select to enable support for LCD Display. +config

[nuttx] branch master updated (23ad4700a9 -> 6be363ff35)

2023-05-16 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 23ad4700a9 drivers/serial/pty.c: Fix coverity issue add 6be363ff35 drivers/serial: fix race condition in

[GitHub] [nuttx] jerpelea merged pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
jerpelea merged PR #9292: URL: https://github.com/apache/nuttx/pull/9292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9304: URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195969655 ## boards/arm64/a64/pinephone/Kconfig: ## @@ -17,4 +17,10 @@ config PINEPHONE_LCD ---help--- Select to enable support for LCD Display.

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1755: nshlib: Add support for disabling echoback

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #1755: URL: https://github.com/apache/nuttx-apps/pull/1755#issuecomment-1550774421 @takumiando could you fetch the latest master, rebase your change and push again? CI break is fixed. -- This is an automated message from the Apache Git Service. To respond

[nuttx-apps] branch master updated: examples/foc: improve the readability of the motor structures

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 111e02dbd examples/foc: improve the

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1757: examples/foc: improve the readability of the motor structures

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #1757: URL: https://github.com/apache/nuttx-apps/pull/1757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated: drivers/serial/pty.c: Fix coverity issue

2023-05-16 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 23ad4700a9 drivers/serial/pty.c: Fix coverity

[GitHub] [nuttx] jerpelea merged pull request #9305: drivers/serial/pty.c: Fix coverity issue

2023-05-16 Thread via GitHub
jerpelea merged PR #9305: URL: https://github.com/apache/nuttx/pull/9305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx-apps] btashton merged pull request #1758: nshlib: fix memory leak found out by -fanalyzer

2023-05-16 Thread via GitHub
btashton merged PR #1758: URL: https://github.com/apache/nuttx-apps/pull/1758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx-apps] btashton merged pull request #1759: add fdsan unit test

2023-05-16 Thread via GitHub
btashton merged PR #1759: URL: https://github.com/apache/nuttx-apps/pull/1759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx-apps] branch master updated: nshlib: fix memory leak found out by -fanalyzer

2023-05-16 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 28973a37b nshlib: fix memory leak found

[nuttx-apps] branch master updated: add fdsan unit test

2023-05-16 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new aea9b50dc add fdsan unit test aea9b50dc

[GitHub] [nuttx] lywind opened a new pull request, #9307: Fix windows compile errors because of double quotes in config

2023-05-16 Thread via GitHub
lywind opened a new pull request, #9307: URL: https://github.com/apache/nuttx/pull/9307 The "CONFIG_APPS_DIR" generated in .config has double quotes and is not recognized as a path by most make systems. This commits removes these double quotes to make the compile successfully. ##

[GitHub] [nuttx] btashton commented on pull request #9204: fdt: Add initial FDT support and procfs for userspace export

2023-05-16 Thread via GitHub
btashton commented on PR #9204: URL: https://github.com/apache/nuttx/pull/9204#issuecomment-1550762515 So I do not forget. The boot spec that qemu uses matches Linux understanding for arm64, so the address to the dtb should be in the `x0` register for arm64

[GitHub] [nuttx] btashton opened a new issue, #9306: docs: Sphinx warnings to be fixed up

2023-05-16 Thread via GitHub
btashton opened a new issue, #9306: URL: https://github.com/apache/nuttx/issues/9306 Creating an issue so I dont forget to circle back to these. Ignore the `Duplicate C declaration` warnings as they are a known deficiency in Sphinx that has not been resolved upstream. - [ ]

[GitHub] [nuttx] btashton commented on pull request #9297: virtio: add virtio framework in NuttX

2023-05-16 Thread via GitHub
btashton commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1550743722 I am very interested in this PR, but do not let my review hold this up since I likely wont have time to give it a detailed review for a few days. -- This is an automated message from

[GitHub] [nuttx-apps] btashton opened a new pull request, #1760: CI: set-output command is deprecated

2023-05-16 Thread via GitHub
btashton opened a new pull request, #1760: URL: https://github.com/apache/nuttx-apps/pull/1760 ## Summary CI currently runs with the warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see:

[GitHub] [nuttx-apps] hujun260 opened a new pull request, #1759: add fdsan unit test

2023-05-16 Thread via GitHub
hujun260 opened a new pull request, #1759: URL: https://github.com/apache/nuttx-apps/pull/1759 ## Summary Add fdsan unit test. Due to the current Nuttx not supporting death test, we removed death test from the original test cases of Android ## Impact none ## Testing

[GitHub] [nuttx] zhang-2019 commented on pull request #9057: dma support 16550 uart

2023-05-16 Thread via GitHub
zhang-2019 commented on PR #9057: URL: https://github.com/apache/nuttx/pull/9057#issuecomment-1550601969 I have rebased to the last commit, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nuttx] lupyuen commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
lupyuen commented on code in PR #9304: URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195863100 ## boards/arm64/a64/pinephone/Kconfig: ## @@ -17,4 +17,10 @@ config PINEPHONE_LCD ---help--- Select to enable support for LCD Display. +config

[GitHub] [nuttx] lupyuen commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
lupyuen commented on code in PR #9304: URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195862416 ## Documentation/platforms/arm/a64/boards/pinephone/index.rst: ## @@ -155,6 +155,13 @@ Supports all the features in ``lcd``, plus LVGL Graphics Library and Touch Panel

[nuttx] branch master updated (81bdb97536 -> e1096bd35c)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 81bdb97536 libc/misc: add fdsan api doc add e1096bd35c libc/regex: add regex implementation No new revisions

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9284: nuttx/libs/libc: add regex implementation

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9284: URL: https://github.com/apache/nuttx/pull/9284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (242127556c -> 81bdb97536)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 242127556c Documentation: Add "High Performance, Zero Latency Interrupts" add 90387a5b41 libc/misc: add fdsan

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9260: libc/misc: add Fdsan module

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9260: URL: https://github.com/apache/nuttx/pull/9260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9303: Nucleo watchdog

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9303: URL: https://github.com/apache/nuttx/pull/9303#discussion_r1195859242 ## boards/arm/stm32h7/nucleo-h743zi2/src/stm32_bringup.c: ## @@ -96,6 +96,21 @@ int stm32_bringup(void) } #endif +#ifdef CONFIG_STM32_IWDG + /*

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9304: URL: https://github.com/apache/nuttx/pull/9304#discussion_r1195857955 ## boards/arm64/a64/pinephone/Kconfig: ## @@ -17,4 +17,10 @@ config PINEPHONE_LCD ---help--- Select to enable support for LCD Display.

[GitHub] [nuttx] liqinhuixm commented on a diff in pull request #9295: net: Add the check that socket domain is equal to bound address type, when do bind.

2023-05-16 Thread via GitHub
liqinhuixm commented on code in PR #9295: URL: https://github.com/apache/nuttx/pull/9295#discussion_r1195855844 ## net/tcp/tcp_conn.c: ## @@ -1193,6 +1193,15 @@ FAR struct tcp_conn_s *tcp_alloc_accept(FAR struct net_driver_s *dev, int tcp_bind(FAR struct tcp_conn_s *conn,

[GitHub] [nuttx] zhang-2019 closed pull request #9057: dma support 16550 uart

2023-05-16 Thread via GitHub
zhang-2019 closed pull request #9057: dma support 16550 uart URL: https://github.com/apache/nuttx/pull/9057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [nuttx] anchao commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
anchao commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1550574117 > Sorry I do not have time this week. I have verify this PR on sim/usbdev, everything works as expected. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nuttx] no1wudi opened a new pull request, #9305: drivers/serial/pty.c: Fix coverity issue

2023-05-16 Thread via GitHub
no1wudi opened a new pull request, #9305: URL: https://github.com/apache/nuttx/pull/9305 ## Summary Coverity report that `ntotal` may be a negative value. ## Impact Minor ## Testing sim and CI -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] lupyuen commented on pull request #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
lupyuen commented on PR #9304: URL: https://github.com/apache/nuttx/pull/9304#issuecomment-1550549856 Fixed the UART3 configuration. Sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[nuttx-website] branch asf-site updated: Publishing web: b5385572da9781727954ec9d98f5329c0d33acf2 docs: 242127556c27f336f394ab073ecc70ef010fbabd

2023-05-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new cc240d2f Publishing web:

[GitHub] [nuttx] lupyuen opened a new pull request, #9304: arm64/pinephone: Add driver for PinePhone LTE Modem (Quectel EG25-G)

2023-05-16 Thread via GitHub
lupyuen opened a new pull request, #9304: URL: https://github.com/apache/nuttx/pull/9304 ## Summary This PR adds the PinePhone Driver for Quectel EG25-G LTE Modem. When the driver is started, the LTE Modem accepts AT Commands over UART3 and `/dev/ttyS1`. PinePhone's LTE Modem

[GitHub] [nuttx] slorquet opened a new pull request, #9303: Nucleo watchdog

2023-05-16 Thread via GitHub
slorquet opened a new pull request, #9303: URL: https://github.com/apache/nuttx/pull/9303 ## Summary Add a config to test the stm32h7 watchdog ## Impact None ## Testing Builds and run -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] hartmannathan commented on pull request #9302: Documentation: Add "High Performance, Zero Latency Interrupts"

2023-05-16 Thread via GitHub
hartmannathan commented on PR #9302: URL: https://github.com/apache/nuttx/pull/9302#issuecomment-1550201552 > Thanks for doing this! My pleasure! I plan to continue doing this, one article at a time, with the other documents that are currently parked in the CWIKI that haven't

[GitHub] [nuttx] ldube commented on a diff in pull request #9287: usbhost: Make unplugging hubs more reliable.

2023-05-16 Thread via GitHub
ldube commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195572019 ## drivers/usbhost/usbhost_hub.c: ## @@ -1491,7 +1521,7 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) { Review Comment: @xiaoxiang781216 I

[nuttx] branch master updated (f61dc72892 -> 242127556c)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f61dc72892 net/tcp:Add NewReno congestion control. add 242127556c Documentation: Add "High Performance, Zero

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9302: Documentation: Add "High Performance, Zero Latency Interrupts"

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9302: URL: https://github.com/apache/nuttx/pull/9302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] mu578 commented on issue #9298: Signal must be masked when it is delivered to a signal handler

2023-05-16 Thread via GitHub
mu578 commented on issue #9298: URL: https://github.com/apache/nuttx/issues/9298#issuecomment-1550138175 You write faster that I can read (I have a slow morning today). Yes about priority handling, not particularly just for signal API, it is always nice to have. Anyway, in a general

[GitHub] [nuttx] hartmannathan opened a new pull request, #9302: Documentation: Add "High Performance, Zero Latency Interrupts"

2023-05-16 Thread via GitHub
hartmannathan opened a new pull request, #9302: URL: https://github.com/apache/nuttx/pull/9302 ## Summary Add the document "High Performance, Zero Latency Interrupts"; until now, this was found only in the

[GitHub] [nuttx] tmedicci opened a new issue, #9301: Interdependencies errors on CI

2023-05-16 Thread via GitHub
tmedicci opened a new issue, #9301: URL: https://github.com/apache/nuttx/issues/9301 The job https://github.com/apache/nuttx/actions/runs/4993159615/jobs/8941973789?pr=9138#step:7:448 shows an error while refreshing the `arty_a7:netnsh` defconfig. This very same error happens while

[GitHub] [nuttx] patacongo commented on pull request #9299: Signal must be masked when it is delivered to a signal handler

2023-05-16 Thread via GitHub
patacongo commented on PR #9299: URL: https://github.com/apache/nuttx/pull/9299#issuecomment-1550062895 I believe that this is a correct and complete change as submitted. However, there are other unrelated issues that could make this unreliable. See #9300 -- This is an automated

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9287: usbhost: Make unplugging hubs more reliable.

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195459866 ## drivers/usbhost/usbhost_hub.c: ## @@ -1491,7 +1521,7 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) { Review Comment: If so, can

[GitHub] [nuttx] patacongo opened a new pull request, #9299: Signal must be masked when it is delivered to a signal handler

2023-05-16 Thread via GitHub
patacongo opened a new pull request, #9299: URL: https://github.com/apache/nuttx/pull/9299 ## Summary Signal must be masked when it is delivered to a signal handler per: > https://pubs.opengroup.org/onlinepubs/007904875/functions/sigaction.html: > > When a signal is

[GitHub] [nuttx] CV-Bowen opened a new pull request, #9297: virtio: add virtio framework in NuttX

2023-05-16 Thread via GitHub
CV-Bowen opened a new pull request, #9297: URL: https://github.com/apache/nuttx/pull/9297 ## Summary 1. virtio devics/drivers match and probe/remote mechanism; 2. virtio mmio transport layer based on OpenAmp; 3. virtio-serial driver based on new virtio framework; 4. virtio-rng

[GitHub] [nuttx] ldube commented on a diff in pull request #9287: usbhost: Make unplugging hubs more reliable.

2023-05-16 Thread via GitHub
ldube commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195388713 ## drivers/usbhost/usbhost_hub.c: ## @@ -1491,7 +1521,7 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) { Review Comment: I think we should

[nuttx] branch master updated: net/tcp:Add NewReno congestion control.

2023-05-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f61dc72892 net/tcp:Add NewReno congestion

[GitHub] [nuttx] acassis merged pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
acassis merged PR #9262: URL: https://github.com/apache/nuttx/pull/9262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] davids5 commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
davids5 commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1549906080 > > Does that use CDCACM? > > @davids5 emm ... I don't have real hardware for CDCACM yet, could you please help to verify this PR? Sorry I do not have time this week. --

[nuttx] branch master updated (26361ee1d2 -> 7a8cf7ff70)

2023-05-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 26361ee1d2 tools/nuttx-gdbinit/armv7-a: add fpu support add 7a8cf7ff70 Indent the include statement by two

[GitHub] [nuttx] acassis merged pull request #9267: Indent the include statement by two spaces

2023-05-16 Thread via GitHub
acassis merged PR #9267: URL: https://github.com/apache/nuttx/pull/9267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] acassis commented on a diff in pull request #9287: usbhost: Make unplugging hubs more reliable.

2023-05-16 Thread via GitHub
acassis commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195350305 ## drivers/usbhost/usbhost_hub.c: ## @@ -1513,10 +1543,20 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) work_cancel(LPWORK, >work); - /*

[GitHub] [nuttx] acassis commented on a diff in pull request #9295: net: Add the check that socket domain is equal to bound address type, when do bind.

2023-05-16 Thread via GitHub
acassis commented on code in PR #9295: URL: https://github.com/apache/nuttx/pull/9295#discussion_r1195343334 ## net/tcp/tcp_conn.c: ## @@ -1193,6 +1193,15 @@ FAR struct tcp_conn_s *tcp_alloc_accept(FAR struct net_driver_s *dev, int tcp_bind(FAR struct tcp_conn_s *conn, FAR

[GitHub] [nuttx] mu578 commented on pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-16 Thread via GitHub
mu578 commented on PR #9138: URL: https://github.com/apache/nuttx/pull/9138#issuecomment-1549817140 Maybe you should enforce an explicit LIBC_ARCH_BUILD_SHARED instead of defaulting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nuttx] tmedicci commented on a diff in pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-16 Thread via GitHub
tmedicci commented on code in PR #9138: URL: https://github.com/apache/nuttx/pull/9138#discussion_r1195243859 ## libs/libc/libc.h: ## @@ -53,6 +55,12 @@ #define LIB_BUFLEN_UNKNOWN INT_MAX +#if defined(CONFIG_BUILD_FLAT) || \ +((!defined(CONFIG_LIBC_PREVENT_STRING_USER)

[GitHub] [nuttx] anchao commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
anchao commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1549758216 > Does that use CDCACM? @davids5 emm ... I don't have real hardware for CDCACM yet, could you please help to verify this PR? -- This is an automated message from the Apache Git

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9103: arch/riscv: Fixed FPU register error

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9103: URL: https://github.com/apache/nuttx/pull/9103#discussion_r1195185751 ## arch/risc-v/src/common/riscv_macros.S: ## @@ -227,8 +222,15 @@ REGLOAD t0, REG_INT_CTX(\out) li t1, MSTATUS_FS and t2, t0, t1

[nuttx] branch master updated (eb47312518 -> 26361ee1d2)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from eb47312518 netdev_upper: Protect quota by spin lock to allow netpkt_xxx be called in interrupt context add

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9234: tools/nuttx-gdbinit/armv7-a: add fpu support

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9234: URL: https://github.com/apache/nuttx/pull/9234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9057: dma support 16550 uart

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #9057: URL: https://github.com/apache/nuttx/pull/9057#issuecomment-1549696373 > I have resolved all the confilcts, please review please fetch the last main and rebase your change to remove the merge commit from PR. -- This is an automated message

[nuttx] branch master updated (36591af615 -> eb47312518)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 36591af615 net/rpmsg: initialize semaphore count before wait add eb47312518 netdev_upper: Protect quota by

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9293: netdev_upper: Protect quota by spin lock to allow netpkt_xxx be called in interrupt context

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9293: URL: https://github.com/apache/nuttx/pull/9293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] davids5 commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
davids5 commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1549682285 > Yes, I verify this change on our real product(Cortex-M55/Cortex-A7(SMP 2 Core)) Does that use CDCACM? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9284: nuttx/libs/libc: add regex implementation

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #9284: URL: https://github.com/apache/nuttx/pull/9284#issuecomment-1549620628 Another fix the issue from https://github.com/apache/nuttx/pull/9294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nuttx-apps] anchao opened a new pull request, #1758: nshlib: fix memory leak found out by -fanalyzer

2023-05-16 Thread via GitHub
anchao opened a new pull request, #1758: URL: https://github.com/apache/nuttx-apps/pull/1758 ## Summary nshlib: fix memory leak found out by -fanalyzer ```bash nsh_ddcmd.c: In function ‘cmd_dd’: nsh_ddcmd.c:492:1: warning: leak of ‘dd.buffer’ [CWE-401]

[GitHub] [nuttx] anchao commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
anchao commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1549472094 > @anchao Did you test this on real HW? Did you test the CDCACM driver, and ensure the lead/lag on connect/disconnect was handled? I.E Data sent in connected state, then disconnected etc

[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1757: examples/foc: improve the readability of the motor structures

2023-05-16 Thread via GitHub
raiden00pl opened a new pull request, #1757: URL: https://github.com/apache/nuttx-apps/pull/1757 ## Summary examples/foc: improve the readability of the motor structures ## Impact Purely cosmetic change ## Testing CI -- This is an automated message from the

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9296: arch: Save sigdeliver into xcp in the case of signal self delevery

2023-05-16 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9296: URL: https://github.com/apache/nuttx/pull/9296 ## Summary to avoid the infinite recusive dispatch: ``` *0 myhandler (signo=27, info=0xf3e38b9c, context=0x0) at

[GitHub] [nuttx] davids5 commented on pull request #9292: drivers/serial: fix race condition in multi-thread write

2023-05-16 Thread via GitHub
davids5 commented on PR #9292: URL: https://github.com/apache/nuttx/pull/9292#issuecomment-1549348546 @anchao Did you test this on real HW? Did you test the CDCACM driver, and ensure the lead/lag on connect/disconnect was handled? I.E Data sent in connected state, then disconnected etc

[nuttx] branch master updated: net/rpmsg: initialize semaphore count before wait

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 36591af615 net/rpmsg: initialize semaphore

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9290: net/rpmsg: initialize semaphore count before wait

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9290: URL: https://github.com/apache/nuttx/pull/9290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] liqinhuixm commented on pull request #9294: net/udp: Populate the udp connection structure with the address family.

2023-05-16 Thread via GitHub
liqinhuixm commented on PR #9294: URL: https://github.com/apache/nuttx/pull/9294#issuecomment-1549293559 The connection domain cannot be modified after the socket is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9294: net/udp: Populate the udp connection structure with the address family.

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9294: URL: https://github.com/apache/nuttx/pull/9294#discussion_r1194857172 ## net/udp/udp_conn.c: ## @@ -807,6 +807,7 @@ int udp_bind(FAR struct udp_conn_s *conn, FAR const struct sockaddr *addr) uint16_t portno; int ret; +

[nuttx] branch master updated (6417ca79ad -> 50cf3d8577)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6417ca79ad CI: set-output command is deprecated add 150e5a1a0f sim/posix/backtrace: process host backtrace

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9291: sim/posix/backtrace: process host backtrace with critical section

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9291: URL: https://github.com/apache/nuttx/pull/9291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] liqinhuixm opened a new pull request, #9295: net: Add the check that socket domain is equal to bound address type, when do bind.

2023-05-16 Thread via GitHub
liqinhuixm opened a new pull request, #9295: URL: https://github.com/apache/nuttx/pull/9295 When do socket bind, if the connection domain is not equal to the bound address type, this will cause the stack-buffer-overflow. ## Summary When bind the sockaddr, Check conn->domain

[GitHub] [nuttx] extinguish commented on pull request #9284: nuttx/libs/libc: add regex implementation

2023-05-16 Thread via GitHub
extinguish commented on PR #9284: URL: https://github.com/apache/nuttx/pull/9284#issuecomment-1549230594 the issues that posted in https://github.com/apache/nuttx/pull/9282 is fixed in this new pull request. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] extinguish commented on pull request #9282: nuttx/libs/libc: add regex implementation

2023-05-16 Thread via GitHub
extinguish commented on PR #9282: URL: https://github.com/apache/nuttx/pull/9282#issuecomment-1549219224 > I see that you already closed this. However, you need to know this: This is BSD-licenses, third party code and must be handled in a different way from a real, original, Apache

[GitHub] [nuttx] liqinhuixm commented on pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
liqinhuixm commented on PR #9262: URL: https://github.com/apache/nuttx/pull/9262#issuecomment-1549192789 > Hi @liqinhuixm please include the summary information in the log message. Please consider transforming this Testing selection in a small user guide at Documentation/ to explain people

[GitHub] [nuttx] liqinhuixm commented on a diff in pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
liqinhuixm commented on code in PR #9262: URL: https://github.com/apache/nuttx/pull/9262#discussion_r1194771645 ## net/tcp/tcp.h: ## @@ -71,7 +71,7 @@ # define TCP_WBPKTLEN(wrb) ((wrb)->wb_iob->io_pktlen) # define TCP_WBSENT(wrb)((wrb)->wb_sent) #

[GitHub] [nuttx] liqinhuixm commented on a diff in pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
liqinhuixm commented on code in PR #9262: URL: https://github.com/apache/nuttx/pull/9262#discussion_r1194764628 ## net/tcp/tcp_send_buffered.c: ## @@ -584,6 +584,10 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, } else if

[nuttx] branch master updated (9a654b658e -> 6417ca79ad)

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9a654b658e docs: Generate pdf version of docs for #9095 add 6417ca79ad CI: set-output command is deprecated

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9289: CI: set-output command is deprecated

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9289: URL: https://github.com/apache/nuttx/pull/9289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] liqinhuixm commented on a diff in pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
liqinhuixm commented on code in PR #9262: URL: https://github.com/apache/nuttx/pull/9262#discussion_r1194763584 ## net/tcp/tcp_cc.c: ## @@ -0,0 +1,293 @@ +/ + * net/tcp/tcp_cc.c + * Handling TCP

[GitHub] [nuttx] liqinhuixm commented on a diff in pull request #9262: Add NewReno congestion control.

2023-05-16 Thread via GitHub
liqinhuixm commented on code in PR #9262: URL: https://github.com/apache/nuttx/pull/9262#discussion_r1194763177 ## net/tcp/tcp_send_buffered.c: ## @@ -614,11 +619,12 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev, /* Do fast

[GitHub] [nuttx] zhang-2019 commented on a diff in pull request #9057: dma support 16550 uart

2023-05-16 Thread via GitHub
zhang-2019 commented on code in PR #9057: URL: https://github.com/apache/nuttx/pull/9057#discussion_r1194741598 ## drivers/serial/uart_16550.c: ## @@ -1157,25 +1317,198 @@ static bool u16550_rxflowcontrol(struct uart_dev_s *dev, *

[GitHub] [nuttx] zhang-2019 commented on pull request #9057: dma support 16550 uart

2023-05-16 Thread via GitHub
zhang-2019 commented on PR #9057: URL: https://github.com/apache/nuttx/pull/9057#issuecomment-1549136539 I have resolved all the confilcts, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nuttx] g2gps opened a new pull request, #9294: net/udp: Populate the udp connection structure with the address family.

2023-05-16 Thread via GitHub
g2gps opened a new pull request, #9294: URL: https://github.com/apache/nuttx/pull/9294 ## Summary The udp connection structure contains the field, "domain", which defines which address family it belongs to. Prior to this change, this field was not populated correctly, and was read

[GitHub] [nuttx] wengzhe opened a new pull request, #9293: netdev_upper: Protect quota by spin lock to allow netpkt_xxx be called in interrupt context

2023-05-16 Thread via GitHub
wengzhe opened a new pull request, #9293: URL: https://github.com/apache/nuttx/pull/9293 ## Summary Before `atomic` is ready on every platform, we need a way to protect `quota`, previously it's protected by `net_lock`, but this makes `netpkt_xxx` interfaces unable to be called under

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9252: Add ATSAMA5D2/D4 Secure Fuse Controller (SFC) driver

2023-05-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1194716367 ## include/nuttx/efuse/sama5_sfc_fuses.h: ## @@ -0,0 +1,247 @@ +/ + *

[nuttx] branch master updated: docs: Generate pdf version of docs for #9095

2023-05-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9a654b658e docs: Generate pdf version of docs

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9288: docs: Generate pdf version of docs for #9095

2023-05-16 Thread via GitHub
xiaoxiang781216 merged PR #9288: URL: https://github.com/apache/nuttx/pull/9288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >