snleee commented on a change in pull request #4615: Update Getting Started
documentation.
URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r325477904
##
File path: docs/getting_started.rst
##
@@ -114,7 +114,29 @@ Suppose we have a transcript in CSV
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch new_segment_creation
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 2930748 Adding CreateSegmentCommandV2 command
add 4e4b7be Address comments
No new
jamesyfshao commented on a change in pull request #4608: Unit tests and bug
fixes for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r325444901
##
File path:
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER
BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1)
Report
> Merging
jamesyfshao commented on a change in pull request #4608: Unit tests and bug
fixes for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r325443739
##
File path:
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325439739
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325440855
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325440772
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325437581
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325439471
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325441081
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325440450
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325438318
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
Jackie-Jiang commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325440281
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
codecov-io edited a comment on issue #4615: Update Getting Started
documentation.
URL: https://github.com/apache/incubator-pinot/pull/4615#issuecomment-531921434
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4615?src=pr=h1)
Report
> Merging
snleee commented on a change in pull request #4615: Update Getting Started
documentation.
URL: https://github.com/apache/incubator-pinot/pull/4615#discussion_r325418567
##
File path: docs/getting_started.rst
##
@@ -114,7 +114,25 @@ Suppose we have a transcript in CSV
codecov-io edited a comment on issue #4553: Refactor ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-524232323
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr=h1)
Report
> Merging
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r323414056
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##
@@ -21,14 +21,8
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r323415168
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/ColumnIndexContainer.java
##
@@ -44,5
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325409640
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
##
@@
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325361949
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/presence/RealtimePresenceVectorReaderWriterTest.java
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325409528
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/presence/RealtimePresenceVectorReaderWriter.java
##
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325413616
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/presence/RealtimePresenceVectorReaderWriterTest.java
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325387059
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/PresenceVectorReaderImpl.java
##
@@ -0,0
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325360431
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/BitmapDocIdSet.java
##
@@ -33,7 +36,8 @@
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r323414056
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##
@@ -21,14 +21,8
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325413513
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/PresenceVectorReader.java
##
@@ -0,0 +1,35
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325361903
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/presence/RealtimePresenceVectorReaderWriterTest.java
snleee commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325413576
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplPresenceVectorTest.java
##
jackjlli commented on a change in pull request #4608: Unit tests and bug fixes
for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r325409807
##
File path:
This is an automated email from the ASF dual-hosted git repository.
jenniferdai pushed a change to branch proxy
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
was ddb8c5f Adding a constructor to create the HttpClient with a proxy
The revisions that were on this
jenniferdai closed pull request #4582: Allow creation of HttpClient with a proxy
URL: https://github.com/apache/incubator-pinot/pull/4582
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-io edited a comment on issue #4583: Support default value for Byte
column
URL: https://github.com/apache/incubator-pinot/pull/4583#issuecomment-529687169
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4583?src=pr=h1)
Report
> Merging
Jackie-Jiang commented on a change in pull request #4583: Support default value
for Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325378744
##
File path:
mcvsubbu commented on issue #4553: Refactor ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-532395787
Please hold off merging until we are out of code yellow, thanks
This is an
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325378284
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325376173
##
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325371893
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325371496
##
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
jackjlli commented on a change in pull request #4583: Support default value for
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325371131
##
File path:
jackjlli commented on a change in pull request #4583: Support default value for
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325371081
##
File path:
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch byte-default-value
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 96af561 Add tests for Tdigest and HLL byte columns
add 99e963d Address PR comments
No new
chenboat edited a comment on issue #4618: Make Kafka offset out of range as an
transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618#issuecomment-532385271
> Your first point is wrong. The validation manager will put in newer
offsets that are valid before
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325367348
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325367412
##
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
chenboat commented on issue #4618: Make Kafka offset out of range as an
transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618#issuecomment-532385271
> Your first point is wrong. The validation manager will put in newer
offsets that are valid before restarting. No
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325359295
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325360390
##
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
mcvsubbu commented on issue #4618: Make Kafka offset out of range as an
transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618#issuecomment-532377804
Your first point is wrong. The validation manager will put in newer offsets
that are valid before restarting. No
Jackie-Jiang commented on a change in pull request #4583: Support default value
for Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325355324
##
File path:
Jackie-Jiang commented on a change in pull request #4583: Support default value
for Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325355088
##
File path:
npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325348903
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325333416
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r32546
##
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r32577
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 8d593f3 [TE] Bug fix to initialize the configDAO (#4616)
add c7b647a [TE][Composite-Alert]
akshayrai merged pull request #4609: [TE][Composite-Alert] Entity Anomaly Merger
URL: https://github.com/apache/incubator-pinot/pull/4609
This is an automated message from the Apache Git Service.
To respond to the message,
chenboat commented on issue #4618: Make Kafka offset out of range as an
transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618#issuecomment-532348196
By "a segment created before kafka rolled over data", do you mean the case
where the consumer asks for data with
npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325291420
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java
kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command
URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532276771
Yes. Which custom config are useful? Can we put them as part of tableConfig.
I am trying to see if we can move towards 3 main
mcvsubbu commented on issue #4617: Adding CreateSegmentCommandV2 command
URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532272767
In that case, let us add a print to the existing one to direct the user to
this new command, and mention that it is deprecated. Over
kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command
URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532259749
Existing command is too complicated and needs segment generation config. I
would like to simplify this. Touching existing will break
chenboat opened a new pull request #4618: Make Kafka offset out of range as an
transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618
During LLC migration in Uber, we often found LLC consumer often stopped
consumption because it is assigned a bad Kafka broker (and
63 matches
Mail list logo
