[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues URL: https://github.com/apache/incubator-pinot/pull/4113#discussion_r275861143 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues URL: https://github.com/apache/incubator-pinot/pull/4113#discussion_r275861363 ## File path:

[GitHub] [incubator-pinot] ly923976094 closed pull request #4006: Controller web use json string create and update schemas

2019-04-16 Thread GitBox
ly923976094 closed pull request #4006: Controller web use json string create and update schemas URL: https://github.com/apache/incubator-pinot/pull/4006 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275872214 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
jackjlli commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r275914812 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275929047 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275880161 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275916600 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
jackjlli commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r275922422 ## File path:

[incubator-pinot] branch master updated: [TE] Mark some classes as deprecated (#4120)

2019-04-16 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 443d49e [TE] Mark some classes

[GitHub] [incubator-pinot] akshayrai merged pull request #4120: [TE] Mark some classes as deprecated

2019-04-16 Thread GitBox
akshayrai merged pull request #4120: [TE] Mark some classes as deprecated URL: https://github.com/apache/incubator-pinot/pull/4120 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] fx19880617 closed pull request #113: Adding broker cache layer

2019-04-16 Thread GitBox
fx19880617 closed pull request #113: Adding broker cache layer URL: https://github.com/apache/incubator-pinot/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-pinot] fx19880617 closed pull request #101: Bug fixing during large realtime segment creation

2019-04-16 Thread GitBox
fx19880617 closed pull request #101: Bug fixing during large realtime segment creation URL: https://github.com/apache/incubator-pinot/pull/101 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r275922913 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275929047 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
tangdian commented on a change in pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#discussion_r275877669 ## File path:

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4120: [TE] Mark some classes as deprecated

2019-04-16 Thread GitBox
akshayrai opened a new pull request #4120: [TE] Mark some classes as deprecated URL: https://github.com/apache/incubator-pinot/pull/4120 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4067: [TE] Holt Winters detector

2019-04-16 Thread GitBox
xiaohui-sun merged pull request #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-pinot] branch master updated: [TE] Holt Winters detector (#4067)

2019-04-16 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6cd8657 [TE] Holt Winters detector

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4118: [TE] frontend - harleyjj/home - get all anomalies by subscription group

2019-04-16 Thread GitBox
akshayrai commented on a change in pull request #4118: [TE] frontend - harleyjj/home - get all anomalies by subscription group URL: https://github.com/apache/incubator-pinot/pull/4118#discussion_r275955329 ## File path: thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye

2019-04-16 Thread GitBox
xiaohui-sun commented on issue #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye URL: https://github.com/apache/incubator-pinot/pull/4125#issuecomment-483864824 Did you forget to include some files? I can only see the static final changes.

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276034823 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276036031 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276034471 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276036408 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

2019-04-16 Thread GitBox
jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r275972992 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java ##

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #4118: [TE] frontend - harleyjj/home - get all anomalies by subscription group

2019-04-16 Thread GitBox
harleyjj commented on a change in pull request #4118: [TE] frontend - harleyjj/home - get all anomalies by subscription group URL: https://github.com/apache/incubator-pinot/pull/4118#discussion_r275979013 ## File path: thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs

[incubator-pinot] branch race_condition deleted (was 61c497d)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch race_condition in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 61c497d In ClusterChangeMediator, add stop flag check inside for loop and wait block The

[incubator-pinot] branch master updated: In ClusterChangeMediator, add stop flag check inside for loop and wait block (#4121)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 88081bd In ClusterChangeMediator, add

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block

2019-04-16 Thread GitBox
Jackie-Jiang merged pull request #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block URL: https://github.com/apache/incubator-pinot/pull/4121 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] codecov-io commented on issue #4106: Remove redundant default broker configurations

2019-04-16 Thread GitBox
codecov-io commented on issue #4106: Remove redundant default broker configurations URL: https://github.com/apache/incubator-pinot/pull/4106#issuecomment-483854385 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4106?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye

2019-04-16 Thread GitBox
jihaozh opened a new pull request #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye URL: https://github.com/apache/incubator-pinot/pull/4125 - If there is a dot in a dimension value, it won't be able to show up correctly in the RCA page. This also

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block

2019-04-16 Thread GitBox
Jackie-Jiang opened a new pull request #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block URL: https://github.com/apache/incubator-pinot/pull/4121 1. Add stop flag check inside for loop to not wait until all change types getting processed 2. Add stop

[incubator-pinot] 01/01: In ClusterChangeMediator, add stop flag check inside for loop and wait block

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch race_condition in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 61c497d2766223fc21b84c58becd6ce86a7c1dff Author: Jackie (Xiaotian) Jiang AuthorDate: Tue Apr 16

[incubator-pinot] branch race_condition created (now 61c497d)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch race_condition in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 61c497d In ClusterChangeMediator, add stop flag check inside for loop and wait block This branch

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4122: [TE] adjustment on Yaml configurations

2019-04-16 Thread GitBox
xiaohui-sun opened a new pull request #4122: [TE] adjustment on Yaml configurations URL: https://github.com/apache/incubator-pinot/pull/4122 1. Set default Yaml configuration to algorithm based. 2. Set default bucketPeriod if it is not provided. (Haven't populated to algorithm.) 3.

[GitHub] [incubator-pinot] jihaozh merged pull request #4123: [TE] frontend - harleyjj/preview - fix preview error notification toast

2019-04-16 Thread GitBox
jihaozh merged pull request #4123: [TE] frontend - harleyjj/preview - fix preview error notification toast URL: https://github.com/apache/incubator-pinot/pull/4123 This is an automated message from the Apache Git Service.

[GitHub] [incubator-pinot] akshayrai closed pull request #4022: [TE] Clean up residue files from test & deprecated files

2019-04-16 Thread GitBox
akshayrai closed pull request #4022: [TE] Clean up residue files from test & deprecated files URL: https://github.com/apache/incubator-pinot/pull/4022 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/preview - fix preview error notification toast (#4123)

2019-04-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 45521f8 [TE] frontend -

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4124: [TE] Remove migration endpoints, partial reference and legacy alert

2019-04-16 Thread GitBox
akshayrai opened a new pull request #4124: [TE] Remove migration endpoints, partial reference and legacy alert URL: https://github.com/apache/incubator-pinot/pull/4124 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] akshayrai merged pull request #4124: [TE] Remove migration endpoints, partial reference and legacy alert

2019-04-16 Thread GitBox
akshayrai merged pull request #4124: [TE] Remove migration endpoints, partial reference and legacy alert URL: https://github.com/apache/incubator-pinot/pull/4124 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] Remove migrator, partial reference and legacy alert (#4124)

2019-04-16 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new dab44a6 [TE] Remove migrator,

[incubator-pinot] branch master updated: [TE] Fix the dimension values that contain dot in it (#4125)

2019-04-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 24c7a8e [TE] Fix the dimension values

[GitHub] [incubator-pinot] jihaozh merged pull request #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye

2019-04-16 Thread GitBox
jihaozh merged pull request #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye URL: https://github.com/apache/incubator-pinot/pull/4125 This is an automated message from the Apache Git

[incubator-pinot] branch master updated: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues (#4113)

2019-04-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 71de311 [TE] Fix MySQL and H2

[GitHub] [incubator-pinot] codecov-io commented on issue #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block

2019-04-16 Thread GitBox
codecov-io commented on issue #4121: In ClusterChangeMediator, add stop flag check inside for loop and wait block URL: https://github.com/apache/incubator-pinot/pull/4121#issuecomment-483842206 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4121?src=pr=h1) Report >

[incubator-pinot] branch broker_config updated (454e550 -> 13890c3)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_config in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 454e550 Remove redundant default broker configurations new 443d49e [TE] Mark some classes as

[GitHub] [incubator-pinot] akshayrai closed pull request #3952: [TE] Remove legacy alerts from search

2019-04-16 Thread GitBox
akshayrai closed pull request #3952: [TE] Remove legacy alerts from search URL: https://github.com/apache/incubator-pinot/pull/3952 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4123: [TE] frontend - harleyjj/preview - fix preview error notification toast

2019-04-16 Thread GitBox
harleyjj opened a new pull request #4123: [TE] frontend - harleyjj/preview - fix preview error notification toast URL: https://github.com/apache/incubator-pinot/pull/4123 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye

2019-04-16 Thread GitBox
xiaohui-sun commented on issue #4125: [TE] Fix the dimension values that contain dot to show up correctly in ThirdEye URL: https://github.com/apache/incubator-pinot/pull/4125#issuecomment-483865707 Oh I missed that. Approved.

[GitHub] [incubator-pinot] tangdian opened a new pull request #4126: [TE] add time format for MySQL: yyyy-mm-dd hh:mm:ss.S

2019-04-16 Thread GitBox
tangdian opened a new pull request #4126: [TE] add time format for MySQL: -mm-dd hh:mm:ss.S URL: https://github.com/apache/incubator-pinot/pull/4126 MySQL returns -MM-dd HH:mm:ss.S for datetime. My code was to eliminate everything after the '.' so a usual -MM-dd HH:mm:ss

[incubator-pinot] branch create-lead-controller-resource updated (e0838b5 -> 4647f8e)

2019-04-16 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard e0838b5 Create leadControllerResource in Helix cluster new 9c3b7a8 [TE]

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4122: [TE] adjustment on Yaml configurations

2019-04-16 Thread GitBox
xiaohui-sun merged pull request #4122: [TE] adjustment on Yaml configurations URL: https://github.com/apache/incubator-pinot/pull/4122 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated: [TE] adjustment on Yaml configurations (#4122)

2019-04-16 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new c674e72 [TE] adjustment on Yaml

[incubator-pinot] branch master updated: [TE] add time format for MySQL: yyyy-mm-dd hh:mm:ss.S (#4126)

2019-04-16 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 945a167 [TE] add time format for

[incubator-pinot] 01/01: Declare byte array size when initializing ByteArrayOutputStream

2019-04-16 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch improve-to-bytes-method in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit f15c5476f6066f110d8867e626e3f2f2c120d2c8 Author: jackjlli AuthorDate: Tue Apr 16 17:56:15 2019

[incubator-pinot] branch improve-to-bytes-method created (now f15c547)

2019-04-16 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch improve-to-bytes-method in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at f15c547 Declare byte array size when initializing ByteArrayOutputStream This branch

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#issuecomment-481923640 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4102?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#issuecomment-483536481 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4119?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4100: Refactor HelixBrokerStarter to separate constructor and start()

2019-04-16 Thread GitBox
jackjlli commented on a change in pull request #4100: Refactor HelixBrokerStarter to separate constructor and start() URL: https://github.com/apache/incubator-pinot/pull/4100#discussion_r276086705 ## File path:

[incubator-pinot] branch broker_starter updated (1b537cb -> ab01d7f)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_starter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1b537cb Refactor HelixBrokerStarter to separate constructor and start() new e6f0341

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276045003 ## File path:

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276044989 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4117: Admin tool for listing segments with invalid intervals for offline tables

2019-04-16 Thread GitBox
sunithabeeram commented on a change in pull request #4117: Admin tool for listing segments with invalid intervals for offline tables URL: https://github.com/apache/incubator-pinot/pull/4117#discussion_r276066325 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4117: Admin tool for listing segments with invalid intervals for offline tables

2019-04-16 Thread GitBox
sunithabeeram commented on a change in pull request #4117: Admin tool for listing segments with invalid intervals for offline tables URL: https://github.com/apache/incubator-pinot/pull/4117#discussion_r276066809 ## File path:

[incubator-pinot] branch master updated: Remove redundant default broker configurations (#4106)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 79b3368 Remove redundant default

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4106: Remove redundant default broker configurations

2019-04-16 Thread GitBox
Jackie-Jiang merged pull request #4106: Remove redundant default broker configurations URL: https://github.com/apache/incubator-pinot/pull/4106 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch broker_config deleted (was 13890c3)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_config in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 13890c3 Remove redundant default broker configurations The revisions that were on this branch are

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276044541 ## File path:

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276044534 ## File path:

[incubator-pinot] branch broker_starter updated (1878126 -> 0096bb3)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_starter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1878126 Refactor HelixBrokerStarter to separate constructor and start() new 0096bb3

[incubator-pinot] branch broker_starter updated (0096bb3 -> fff9cf9)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_starter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0096bb3 Refactor HelixBrokerStarter to separate constructor and start() new fff9cf9

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start()

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start() URL: https://github.com/apache/incubator-pinot/pull/4100#issuecomment-481500729 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start()

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #4100: Refactor HelixBrokerStarter to separate constructor and start() URL: https://github.com/apache/incubator-pinot/pull/4100#issuecomment-481500729 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4100?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jihaozh merged pull request #4126: [TE] add time format for MySQL: yyyy-mm-dd hh:mm:ss.S

2019-04-16 Thread GitBox
jihaozh merged pull request #4126: [TE] add time format for MySQL: -mm-dd hh:mm:ss.S URL: https://github.com/apache/incubator-pinot/pull/4126 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream

2019-04-16 Thread GitBox
sunithabeeram commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream URL: https://github.com/apache/incubator-pinot/pull/4127#issuecomment-483921293 Can you provide more context here? How much of a slow down are you seeing? How much is this change

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
sunithabeeram commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276065806 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
sunithabeeram commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276065750 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster

2019-04-16 Thread GitBox
codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#issuecomment-479147030 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4047?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4127: Declare byte array size when initializing ByteArrayOutputStream

2019-04-16 Thread GitBox
jackjlli opened a new pull request #4127: Declare byte array size when initializing ByteArrayOutputStream URL: https://github.com/apache/incubator-pinot/pull/4127 We've seen some use cases with high latency on `dataTable.toBytes()` method. This PR declares byte array size when

[incubator-pinot] branch broker_starter updated (ab01d7f -> 1878126)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_starter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ab01d7f Refactor HelixBrokerStarter to separate constructor and start() new 1878126

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276050671 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276047836 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276051147 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276048950 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4102: Cleanup singletons for 3 classes in ControllerStarter URL: https://github.com/apache/incubator-pinot/pull/4102#discussion_r276049917 ## File path:

[incubator-pinot] branch clean-up-singleton updated (3a297d3 -> 9f96eb5)

2019-04-16 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch clean-up-singleton in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3a297d3 Remove singleton for PinotLLCRealtimeSegmentManager and SegmentCompletionManager

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
Jackie-Jiang commented on a change in pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#discussion_r276046629 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream

2019-04-16 Thread GitBox
codecov-io commented on issue #4127: Declare byte array size when initializing ByteArrayOutputStream URL: https://github.com/apache/incubator-pinot/pull/4127#issuecomment-483903567 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4127?src=pr=h1) Report > Merging

[incubator-pinot] branch broker_starter updated (423c5dc -> 3cdf754)

2019-04-16 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch broker_starter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 423c5dc Refactor HelixBrokerStarter to separate constructor and start() new 3cdf754

[GitHub] [incubator-pinot] snleee opened a new pull request #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
snleee opened a new pull request #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119 When a server is down, current partition aware routing will always pick the next server. This pr improves the current approach by

[GitHub] [incubator-pinot] codecov-io commented on issue #4119: Improve partition aware routing when a server is down.

2019-04-16 Thread GitBox
codecov-io commented on issue #4119: Improve partition aware routing when a server is down. URL: https://github.com/apache/incubator-pinot/pull/4119#issuecomment-483536481 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4119?src=pr=h1) Report > Merging