[GitHub] [incubator-tvm] ANSHUMAN87 edited a comment on pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

ANSHUMAN87 edited a comment on pull request #5510: URL: https://github.com/apache/incubator-tvm/pull/5510#issuecomment-623859989 > Minor nits, A better commit message would be to refer to handling batch matmul in fully connected op rather than what it stands. > > Isn't there a need

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

ANSHUMAN87 commented on a change in pull request #5510: URL: https://github.com/apache/incubator-tvm/pull/5510#discussion_r419869014 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1329,16 +1329,20 @@ def convert_fully_connected(self, op): input_tensor_shape

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

ANSHUMAN87 commented on pull request #5510: URL: https://github.com/apache/incubator-tvm/pull/5510#issuecomment-623859989 > Minor nits, A better commit message would be to refer to handling batch matmul in fully connected op rather than what it stands. > > Isn't there a need for

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5486: [TFLITE]Select op support for tflite frontend

siju-samuel commented on a change in pull request #5486: URL: https://github.com/apache/incubator-tvm/pull/5486#discussion_r419859922 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -109,16 +109,17 @@ def __init__(self, model, subgraph, exp_tab): 'PAD':

[GitHub] [incubator-tvm] siju-samuel commented on pull request #5488: [TFLITE] SELECT

siju-samuel commented on pull request #5488: URL: https://github.com/apache/incubator-tvm/pull/5488#issuecomment-623853156 @dhruvaray Thanks for the PR. This part is covered in PR #5486 This is an automated message from

[GitHub] [incubator-tvm] tqchen commented on pull request #5506: [WEB][RUNTIME] TVM WebAssembly JS Runtime

tqchen commented on pull request #5506: URL: https://github.com/apache/incubator-tvm/pull/5506#issuecomment-623799974 @kazum Updated to include package.json This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5459: [Relay][Op]Support symbolic TopK, Ones, Zeros and Full

kevinthesun commented on a change in pull request #5459: URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r419829632 ## File path: include/tvm/relay/attrs/algorithm.h ## @@ -50,14 +50,14 @@ struct ArgsortAttrs : public tvm::AttrsNode { }; struct TopKAttrs

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r419826528 ## File path: python/tvm/relay/op/_transform.py ## @@ -101,6 +101,28 @@ def _arange_shape_func(start, stop, step): def

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r419826341 ## File path: python/tvm/relay/op/_transform.py ## @@ -101,6 +101,28 @@ def _arange_shape_func(start, stop, step): def

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r419826426 ## File path: python/tvm/relay/op/_transform.py ## @@ -101,6 +101,28 @@ def _arange_shape_func(start, stop, step): def

[GitHub] [incubator-tvm] wpan11nv commented on a change in pull request #5498: [Optimization] Warp level reduction support for CUDA

wpan11nv commented on a change in pull request #5498: URL: https://github.com/apache/incubator-tvm/pull/5498#discussion_r419821795 ## File path: src/tir/transforms/lower_warp_memory.cc ## @@ -265,10 +265,11 @@ class WarpAccessRewriter : protected StmtExprMutator {

[GitHub] [incubator-tvm] anijain2305 commented on issue #5455: [CI] [TEST] test_conv2d_int8_intrinsics

anijain2305 commented on issue #5455: URL: https://github.com/apache/incubator-tvm/issues/5455#issuecomment-623763751 Dug little bit deeper, but still not able to root cause. I think the const int bounds are good.

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419742381 ## File path: .gitignore ## @@ -2,9 +2,10 @@ __pycache__/ *.py[cod] *$py.class - +*.S Review comment: ah ok. I guess this means we can't

[GitHub] [incubator-tvm] tqchen commented on pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#issuecomment-623717030 @tmoreau89 @areusch Thanks, please https://tvm.apache.org/docs/contribute/code_review.html?highlight=approve#approve-and-request-changes-explicitly

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419739620 ## File path: .gitignore ## @@ -2,9 +2,10 @@ __pycache__/ *.py[cod] *$py.class - +*.S Review comment: try to ignore assembly files

[GitHub] [incubator-tvm] areusch commented on pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#issuecomment-623713671 I think this looks good to me now! This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419732922 ## File path: .gitignore ## @@ -2,9 +2,10 @@ __pycache__/ *.py[cod] *$py.class - +*.S Review comment: why this change?

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5486: [TFLITE]Select op support for tflite frontend

u99127 commented on a change in pull request #5486: URL: https://github.com/apache/incubator-tvm/pull/5486#discussion_r419721738 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -109,16 +109,17 @@ def __init__(self, model, subgraph, exp_tab): 'PAD':

[incubator-tvm] branch master updated: [RUST][RUNTIME] Fix workspace (#5503)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 7e88030 [RUST][RUNTIME] Fix workspace

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

u99127 commented on a change in pull request #5510: URL: https://github.com/apache/incubator-tvm/pull/5510#discussion_r419715441 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -419,6 +419,31 @@ def test_forward_cast(): _test_cast(np.arange(6.0,

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419718629 ## File path: src/runtime/rpc/rpc_pipe_impl.cc ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419717711 ## File path: python/tvm/_ffi/base.py ## @@ -48,8 +48,11 @@ def _load_lib(): """Load libary by searching possible path.""" lib_path =

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419704899 ## File path: python/tvm/_ffi/base.py ## @@ -48,8 +48,11 @@ def _load_lib(): """Load libary by searching possible path.""" lib_path =

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419702687 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419702240 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419701703 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419699242 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419699242 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[incubator-tvm] branch v0.6 updated: Fix Canonical Simplifier for v0.6 (#5509)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch v0.6 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/v0.6 by this push: new 60c5e48 Fix Canonical Simplifier for v0.6

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419691019 ## File path: src/runtime/rpc/rpc_endpoint.cc ## @@ -0,0 +1,1059 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419688468 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on pull request #5500: Show max flops in autotvm logs.

areusch commented on pull request #5500: URL: https://github.com/apache/incubator-tvm/pull/5500#issuecomment-623670799 ok, let's close this then, because it's more user preference and it's already in a callback. This is an

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419687967 ## File path: src/runtime/rpc/minrpc/posix_popen_server.cc ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419687452 ## File path: src/runtime/rpc/rpc_pipe_impl.cc ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419685840 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419685914 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419685397 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419685186 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419684714 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419684443 ## File path: python/tvm/rpc/minrpc.py ## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419681322 ## File path: python/tvm/rpc/server.py ## @@ -56,7 +57,7 @@ def _server_env(load_library, work_path=None): temp = util.tempdir() #

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419681078 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419676108 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419676108 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419676682 ## File path: src/runtime/rpc/minrpc/posix_popen_server.cc ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419676108 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419676108 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419673923 ## File path: src/runtime/rpc/rpc_pipe_impl.cc ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419671449 ## File path: jvm/core/src/main/java/org/apache/tvm/contrib/GraphRuntime.java ## @@ -38,53 +38,14 @@ * @return Runtime graph module that can be

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419660040 ## File path: src/runtime/rpc/rpc_endpoint.cc ## @@ -0,0 +1,1059 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5459: [Relay][Op]Support symbolic TopK, Ones, Zeros and Full

junrushao1994 commented on a change in pull request #5459: URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r419659665 ## File path: include/tvm/relay/attrs/algorithm.h ## @@ -50,14 +50,14 @@ struct ArgsortAttrs : public tvm::AttrsNode { }; struct

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419657264 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419655184 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419654945 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419654748 ## File path: src/runtime/rpc/minrpc/minrpc_server.h ## @@ -0,0 +1,598 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5510: [FRONTEND][TFLite] Fully connected op conversion made in sync with TFLite

ANSHUMAN87 opened a new pull request #5510: URL: https://github.com/apache/incubator-tvm/pull/5510 @FrozenGene : Please help review! Thank you! This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419626688 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419626178 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

tqchen commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419623838 ## File path: python/tvm/_ffi/base.py ## @@ -48,8 +48,11 @@ def _load_lib(): """Load libary by searching possible path.""" lib_path =

[GitHub] [incubator-tvm] kazum commented on pull request #5506: [WEB][RUNTIME] TVM WebAssembly JS Runtime

kazum commented on pull request #5506: URL: https://github.com/apache/incubator-tvm/pull/5506#issuecomment-623614061 `npm run bundle` fails. Did you forget to add web/package.json? This is an automated message from the

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419619940 ## File path: python/tvm/rpc/minrpc.py ## @@ -0,0 +1,79 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419619522 ## File path: python/tvm/rpc/client.py ## @@ -397,15 +421,41 @@ def connect(url, port, key="", session_timeout=0): the connection when

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419619088 ## File path: python/tvm/rpc/client.py ## @@ -378,7 +402,7 @@ def request_and_run(self, key, max_retry, str(last_err))) -def

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419618169 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419617098 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419616440 ## File path: python/tvm/rpc/client.py ## @@ -183,28 +198,37 @@ class LocalSession(RPCSession): need to be ran both locally and remotely.

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419613421 ## File path: python/tvm/error.py ## @@ -57,6 +57,11 @@ def __init__(self, msg): register_error("KeyError", KeyError) +@register_error +class

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419613026 ## File path: python/tvm/contrib/cc.py ## @@ -90,7 +90,8 @@ def get_target_triple(): def cross_compiler(compile_func,

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419611904 ## File path: python/tvm/_ffi/base.py ## @@ -48,8 +48,11 @@ def _load_lib(): """Load libary by searching possible path.""" lib_path =

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419610442 ## File path: python/tvm/_ffi/_ctypes/packed_func.py ## @@ -141,6 +141,17 @@ def _make_tvm_args(args, temp_args): elif isinstance(arg,

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

comaniac commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r419595355 ## File path: docs/dev/convert_layout.rst ## @@ -116,6 +117,7 @@ These steps happen for each operator in sequence, where ConvertLayout pass keeps

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5484: [REFACTOR][RPC][PROCOTOL-CHANGE] Modularize the RPC infra

areusch commented on a change in pull request #5484: URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419606101 ## File path: jvm/core/src/main/java/org/apache/tvm/contrib/GraphRuntime.java ## @@ -38,53 +38,14 @@ * @return Runtime graph module that can be

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5231: [POC] Pattern Language, Matcher, Rewriter, and Function Paritioner

zhiics commented on a change in pull request #5231: URL: https://github.com/apache/incubator-tvm/pull/5231#discussion_r419596978 ## File path: include/tvm/relay/dataflow_matcher.h ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] kevinthesun opened a new pull request #5509: [BUGFIX][BACKPORT-0.6][ARITH] Fix FloorMod Simplifier

kevinthesun opened a new pull request #5509: URL: https://github.com/apache/incubator-tvm/pull/5509 @tqchen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5479: [Relay-TFLite] FP32 and Quantized Object Detection Model

anijain2305 commented on a change in pull request #5479: URL: https://github.com/apache/incubator-tvm/pull/5479#discussion_r419587225 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -320,6 +321,45 @@ def dequantize(self, expr, tensor):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5493: [REFACTOR][BOYC] Non recursive partitioning

comaniac commented on a change in pull request #5493: URL: https://github.com/apache/incubator-tvm/pull/5493#discussion_r419586113 ## File path: src/relay/transforms/partition_graph.cc ## @@ -124,37 +112,40 @@ class AnnotationChecker : public ExprVisitor { * the

[GitHub] [incubator-tvm] kevinthesun commented on pull request #5467: [Relay]Improve Shape Func handling for Tuple inputs

kevinthesun commented on pull request #5467: URL: https://github.com/apache/incubator-tvm/pull/5467#issuecomment-623583616 @jroesch PTAL This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5231: [POC] Pattern Language, Matcher, Rewriter, and Function Paritioner

mbrookhart commented on a change in pull request #5231: URL: https://github.com/apache/incubator-tvm/pull/5231#discussion_r419582381 ## File path: include/tvm/relay/dataflow_functor.h ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5357: [Relay] enable blocking format in x86 conv2d and fold scale axis

icemelon9 commented on a change in pull request #5357: URL: https://github.com/apache/incubator-tvm/pull/5357#discussion_r419567958 ## File path: python/tvm/relay/op/strategy/x86.py ## @@ -18,13 +18,17 @@ # pylint:

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r419566833 ## File path: src/relay/transforms/pattern_util.h ## @@ -270,7 +270,7 @@ inline Constant MakeConstantScalar(DataType dtype, T value) { */

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5429: [RELAY][TF] Support symbolic newshape for Reshape

icemelon9 commented on a change in pull request #5429: URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r419566554 ## File path: tests/python/relay/test_any.py ## @@ -138,23 +138,35 @@ def test_any_concat(): result = ex.evaluate()(x_np, y_np)

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5479: [Relay-TFLite] FP32 and Quantized Object Detection Model

mbaret commented on a change in pull request #5479: URL: https://github.com/apache/incubator-tvm/pull/5479#discussion_r419538743 ## File path: python/tvm/relay/frontend/tflite_flexbuffer.py ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] nhynes commented on a change in pull request #5503: [RUST][RUNTIME] Fix workspace

nhynes commented on a change in pull request #5503: URL: https://github.com/apache/incubator-tvm/pull/5503#discussion_r419536942 ## File path: rust/runtime/src/workspace.rs ## @@ -92,9 +92,8 @@ impl WorkspacePool { break; } } -if

[GitHub] [incubator-tvm] tqchen commented on pull request #5505: [BUGFIX][BACKPORT-0.6][ARITH] Fix FloorMod Simplifier

tqchen commented on pull request #5505: URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623533282 @kevinthesun can you also send a PR to the 0.6 branch? Thank you! This is an automated message from the

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5505: [ARITH][Canonical Simplifier]Fix FloorMod

tqchen edited a comment on pull request #5505: URL: https://github.com/apache/incubator-tvm/pull/5505#issuecomment-623531864 Thanks @kevinthesun I checked and it is indeed the correct fix. Thanks @junrushao1994 @Hzfengsy

[incubator-tvm] branch master updated (0abf581 -> 6bbab4c)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 0abf581 bump tophub rocm version (#5504) add 6bbab4c Fix Canonical Simplifier (#5505) No new

[incubator-tvm-site] branch asf-site updated: Build at Mon May 4 07:34:27 PDT 2020

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 8501961 Build at Mon May 4

[incubator-tvm-site] branch master updated: add edgecortix inc to community (#6)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm-site.git The following commit(s) were added to refs/heads/master by this push: new c333db8 add edgecortix inc to

[GitHub] [incubator-tvm] dhruvaray opened a new pull request #5508: [TFLITE]GATHER_ND

dhruvaray opened a new pull request #5508: URL: https://github.com/apache/incubator-tvm/pull/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5507: [CRT]fix to reduce RAM size during loading model

siju-samuel opened a new pull request #5507: URL: https://github.com/apache/incubator-tvm/pull/5507 This fix will help to reduce RAM size during setup storage. I was facing issue with arduino which has only 256kb ram. For my model Setupstorage was consuming 80kb of ram and with this fix

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5492: [RUNTIME] Hexagon driver for offloading kernels to simulator

kparzysz-quic commented on a change in pull request #5492: URL: https://github.com/apache/incubator-tvm/pull/5492#discussion_r419427426 ## File path: src/runtime/hexagon/sim/driver/CMakeLists.txt ## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] lhutton1 commented on pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

lhutton1 commented on pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#issuecomment-623353852 @anijain2305 could you take another look when you have time? This is an automated message from the

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5493: [REFACTOR][BOYC] Non recursive partitioning

manupa-arm commented on a change in pull request #5493: URL: https://github.com/apache/incubator-tvm/pull/5493#discussion_r419281724 ## File path: src/relay/transforms/partition_graph.cc ## @@ -124,37 +112,40 @@ class AnnotationChecker : public ExprVisitor { * the