[GitHub] [airflow] turbaszek commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396937848 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [airflow] turbaszek merged pull request #7848: Add Colgate-Palmolive to users list

2020-03-24 Thread GitBox
turbaszek merged pull request #7848: Add Colgate-Palmolive to users list URL: https://github.com/apache/airflow/pull/7848 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7848: Add Colgate-Palmolive to users list

2020-03-24 Thread GitBox
boring-cyborg[bot] commented on issue #7848: Add Colgate-Palmolive to users list URL: https://github.com/apache/airflow/pull/7848#issuecomment-603066720 Awesome work, congrats on your first merged pull request! This is an

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r396942564 ## File path: .travis.yml ## @@ -41,24 +41,24 @@ jobs: stage: pre-test script: ./scripts/ci/ci

[GitHub] [airflow] potiuk commented on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603070770 BTW. I am going to re-write some parts of it. I came to the conclusion that generating requirements is too big of a hassle for pre-commits (espe

[GitHub] [airflow] potiuk commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396944135 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [airflow] potiuk commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396946424 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [airflow] potiuk commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396946424 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396947436 ## File path: airflow/providers/google/cloud/hooks/gcs.py ## @@ -185,6

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396947732 ## File path: airflow/providers/google/marketing_platform/example_dags/example_a

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396948615 ## File path: airflow/providers/google/marketing_platform/example_dags/example_a

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396949091 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ###

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396956097 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ###

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396959180 ## File path: tests/providers/google/marketing_platform/hooks/test_analytics.py

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396957217 ## File path: airflow/providers/google/marketing_platform/operators/analytics.py

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396953661 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ###

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396956399 ## File path: airflow/providers/google/marketing_platform/operators/analytics.py

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396950456 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ###

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396961535 ## File path: tests/providers/google/marketing_platform/operators/test_analytics

[GitHub] [airflow] xinbinhuang commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
xinbinhuang commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396835351 ## File path: Dockerfile ## @@ -0,0 +1,322 @@ +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [airflow] xinbinhuang commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
xinbinhuang commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r396970218 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [airflow] xinbinhuang commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
xinbinhuang commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603096290 Nice! Like the name standardization. I am also thinking if we should standardize the `connection_prefix` (used in AWS SSM & GCP Secrets Manager

[GitHub] [airflow] turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396981568 ## File path: tests/providers/google/marketing_platform/operators/test_analytics_system.py

[GitHub] [airflow] turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396982580 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ## @

[GitHub] [airflow] turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396982305 ## File path: airflow/providers/google/marketing_platform/operators/analytics.py #

[GitHub] [airflow] turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r396984067 ## File path: airflow/providers/google/marketing_platform/hooks/analytics.py ## @

[jira] [Commented] (AIRFLOW-7070) SimpleHttpOperator does not consider extra attributes from Airflow connection

2020-03-24 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065447#comment-17065447 ] Juraj Šanko commented on AIRFLOW-7070: -- [~dori] Unfortunately I don't have the ski

[GitHub] [airflow] potiuk commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r397002662 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

2020-03-24 Thread GitBox
michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA URL: https://github.com/apache/airflow/pull/7743#discussion_r397008333 ## File path: tests/providers/google/marketing_platform/operators/test_analytics

[jira] [Created] (AIRFLOW-7106) Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread Davide Malagoli (Jira)
Davide Malagoli created AIRFLOW-7106: Summary: Cloud data fusion integration - Allow to pass args to start pipeline Key: AIRFLOW-7106 URL: https://issues.apache.org/jira/browse/AIRFLOW-7106 Projec

[GitHub] [airflow] NBardelot commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-03-24 Thread GitBox
NBardelot commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP URL: https://github.com/apache/airflow/pull/7682#discussion_r397014266 ## File path: airflow/providers/microsoft/winrm/hooks/winrm.py ## @@ -199,7 +199,7 @@ de

[GitHub] [airflow] NBardelot commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-03-24 Thread GitBox
NBardelot commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP URL: https://github.com/apache/airflow/pull/7682#discussion_r397014266 ## File path: airflow/providers/microsoft/winrm/hooks/winrm.py ## @@ -199,7 +199,7 @@ de

[jira] [Commented] (AIRFLOW-7106) Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065459#comment-17065459 ] ASF GitHub Bot commented on AIRFLOW-7106: - malagoli commented on pull request #

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread GitBox
boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849#issuecomment-603132041 Congratulations on your first Pull Request and welcome to the Apache Airflow community! I

[GitHub] [airflow] malagoli opened a new pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread GitBox
malagoli opened a new pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to

[GitHub] [airflow] potiuk commented on issue #7792: [AIRFLOW-7102] Add try_number to airflow context

2020-03-24 Thread GitBox
potiuk commented on issue #7792: [AIRFLOW-7102] Add try_number to airflow context URL: https://github.com/apache/airflow/pull/7792#issuecomment-603144162 One more small thing. Can you also please add this to https://airflow.readthedocs.io/en/latest/macros-ref.html @cong-zhu ?

[GitHub] [airflow] potiuk commented on issue #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun

2020-03-24 Thread GitBox
potiuk commented on issue #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun URL: https://github.com/apache/airflow/pull/7709#issuecomment-603145445 Thanks @zhongjiajie ! This is an automated message from

[GitHub] [airflow] potiuk merged pull request #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun

2020-03-24 Thread GitBox
potiuk merged pull request #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun URL: https://github.com/apache/airflow/pull/7709 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (AIRFLOW-7053) Fix make success/failed error in graph view when dag not run

2020-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065482#comment-17065482 ] ASF subversion and git services commented on AIRFLOW-7053: -- Co

[jira] [Commented] (AIRFLOW-6562) mushroom cloud error when clicking 'mark failed/success' from graph view of dag that has never been run yet

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065480#comment-17065480 ] ASF GitHub Bot commented on AIRFLOW-6562: - potiuk commented on pull request #77

[jira] [Resolved] (AIRFLOW-6562) mushroom cloud error when clicking 'mark failed/success' from graph view of dag that has never been run yet

2020-03-24 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-6562. --- Fix Version/s: 2.0.0 Resolution: Fixed > mushroom cloud error when clicking 'mark fa

[jira] [Updated] (AIRFLOW-6562) mushroom cloud error when clicking 'mark failed/success' from graph view of dag that has never been run yet

2020-03-24 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6562: -- Fix Version/s: (was: 2.0.0) 1.10.10 > mushroom cloud error when clicki

[GitHub] [airflow] potiuk commented on a change in pull request #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#discussion_r397038865 ## File path: airflow/api/common/experimental/mark_tasks.py ## @@ -312,8 +374,6 @@ def set_dag_run_

[GitHub] [airflow] potiuk commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-03-24 Thread GitBox
potiuk commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-603150459 It looks good to me, I just would like to have second opinion (@mik-laj @kaxil @ashb ) --

[GitHub] [airflow] potiuk commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread GitBox
potiuk commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849#issuecomment-603153153 @turbaszek ? :) This is an automate

[GitHub] [airflow] zhongjiajie commented on issue #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun

2020-03-24 Thread GitBox
zhongjiajie commented on issue #7709: [AIRFLOW-6562] Fix success/failed error in graph without dagrun URL: https://github.com/apache/airflow/pull/7709#issuecomment-603170462 Thanks to merge. This is an automated message from

[GitHub] [airflow] turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849#discussion_r397064575 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ###

[GitHub] [airflow] turbaszek commented on a change in pull request #7832: [WIP] Add production image support

2020-03-24 Thread GitBox
turbaszek commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r397065441 ## File path: Dockerfile ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-603187906 Hello All, Except for the last changes pointed out by @feluelle I have resolved all problems. I am bit busy and not sure if I resolv

[GitHub] [airflow] mik-laj commented on issue #7809: Run Dataflow for ML Engine summary in venv

2020-03-24 Thread GitBox
mik-laj commented on issue #7809: Run Dataflow for ML Engine summary in venv URL: https://github.com/apache/airflow/pull/7809#issuecomment-603192586 @potiuk Can I have your review again? Travis is happy. This is an automated m

[GitHub] [airflow] abdulbasitds removed a comment on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds removed a comment on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-603187906 Hello All, Except for the last changes pointed out by @feluelle I have resolved all problems. I am bit busy and not sure if

[GitHub] [airflow] ad-m commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-03-24 Thread GitBox
ad-m commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP URL: https://github.com/apache/airflow/pull/7682#discussion_r397102749 ## File path: airflow/providers/microsoft/winrm/hooks/winrm.py ## @@ -199,7 +199,7 @@ def get

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r397106655 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -0,0 +1,214 @@ +# -*- coding: utf-

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r397106655 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -0,0 +1,214 @@ +# -*- coding: utf-

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7850: [AIRFLOW-4688]: Fix Pylint checkes for modules under scripts

2020-03-24 Thread GitBox
boring-cyborg[bot] commented on issue #7850: [AIRFLOW-4688]: Fix Pylint checkes for modules under scripts URL: https://github.com/apache/airflow/pull/7850#issuecomment-603220658 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues o

[jira] [Commented] (AIRFLOW-4688) Make scripts Pylint compatible

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065749#comment-17065749 ] ASF GitHub Bot commented on AIRFLOW-4688: - gdevanla commented on pull request #

[GitHub] [airflow] potiuk commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP URL: https://github.com/apache/airflow/pull/7682#discussion_r397128015 ## File path: airflow/providers/microsoft/winrm/hooks/winrm.py ## @@ -199,7 +199,7 @@ def g

[GitHub] [airflow] gdevanla opened a new pull request #7850: [AIRFLOW-4688]: Fix Pylint checkes for modules under scripts

2020-03-24 Thread GitBox
gdevanla opened a new pull request #7850: [AIRFLOW-4688]: Fix Pylint checkes for modules under scripts URL: https://github.com/apache/airflow/pull/7850 Fix pylint checks. To achieve this, perform minor re-arrangement of code snippets to allow for cleaner code. All checks under `scripts` fo

[GitHub] [airflow] potiuk commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7682: [AIRFLOW-7031] Airflow WinRM endpoint is hardcoded to HTTP URL: https://github.com/apache/airflow/pull/7682#discussion_r397128607 ## File path: airflow/providers/microsoft/winrm/hooks/winrm.py ## @@ -199,7 +199,7 @@ def g

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r397129801 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -0,0 +1,214 @@ +# -*- coding: utf-

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r397129801 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -0,0 +1,214 @@ +# -*- coding: utf-

[GitHub] [airflow] kaxil opened a new pull request #7851: Bump Boto3 to >=1.12

2020-03-24 Thread GitBox
kaxil opened a new pull request #7851: Bump Boto3 to >=1.12 URL: https://github.com/apache/airflow/pull/7851 Bump Boto3 to >=1.12 Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for ch

[GitHub] [airflow] abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#discussion_r397142449 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -0,0 +1,214 @@ +# -*- coding: utf-

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-603233128 @grjones I have almost resolved all change request,conflicts etc on this. Dont know if it can be merged now or not? @kaxil

[GitHub] [airflow] RosterIn commented on issue #7843: Colorblind friendly UI

2020-03-24 Thread GitBox
RosterIn commented on issue #7843: Colorblind friendly UI URL: https://github.com/apache/airflow/issues/7843#issuecomment-603253834 There was an attempt on this some time ago https://github.com/apache/airflow/pull/2654 This

[GitHub] [airflow] feluelle commented on a change in pull request #7851: Bump Boto3 to >=1.12

2020-03-24 Thread GitBox
feluelle commented on a change in pull request #7851: Bump Boto3 to >=1.12 URL: https://github.com/apache/airflow/pull/7851#discussion_r397229678 ## File path: setup.py ## @@ -182,7 +182,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version

[GitHub] [airflow] chetratep opened a new issue #7852: airflow 1.10.9 can't stop backfilling and timezone issue

2020-03-24 Thread GitBox
chetratep opened a new issue #7852: airflow 1.10.9 can't stop backfilling and timezone issue URL: https://github.com/apache/airflow/issues/7852 ▽ ``` from builtins import range from datetime import timedelta import pendulum import airflow from airflow.models import DAG

[GitHub] [airflow] kaxil commented on a change in pull request #7851: Bump Boto3 to >=1.12

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7851: Bump Boto3 to >=1.12 URL: https://github.com/apache/airflow/pull/7851#discussion_r397253470 ## File path: setup.py ## @@ -182,7 +182,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version

[GitHub] [airflow] turbaszek opened a new pull request #7853: Change signature of GSheetsHook methods

2020-03-24 Thread GitBox
turbaszek opened a new pull request #7853: Change signature of GSheetsHook methods URL: https://github.com/apache/airflow/pull/7853 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x

[GitHub] [airflow] j-y-matsubara opened a new pull request #7854: Add not solved items to pylint_todo.txt

2020-03-24 Thread GitBox
j-y-matsubara opened a new pull request #7854: Add not solved items to pylint_todo.txt URL: https://github.com/apache/airflow/pull/7854 This files do not pass pylint --- Issue link: Document only change, no JIRA issue Make sure to mark the boxes below before creating PR: [x

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7854: Add not solved items to pylint_todo.txt

2020-03-24 Thread GitBox
boring-cyborg[bot] commented on issue #7854: Add not solved items to pylint_todo.txt URL: https://github.com/apache/airflow/pull/7854#issuecomment-603327636 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about an

[GitHub] [airflow] mik-laj commented on a change in pull request #7853: Change signature of GSheetsHook methods

2020-03-24 Thread GitBox
mik-laj commented on a change in pull request #7853: Change signature of GSheetsHook methods URL: https://github.com/apache/airflow/pull/7853#discussion_r397298644 ## File path: airflow/providers/google/suite/hooks/sheets.py ## @@ -48,13 +46,11 @@ class GSheetsHook(CloudBa

[GitHub] [airflow] mik-laj merged pull request #7809: Run Dataflow for ML Engine summary in venv

2020-03-24 Thread GitBox
mik-laj merged pull request #7809: Run Dataflow for ML Engine summary in venv URL: https://github.com/apache/airflow/pull/7809 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] mik-laj opened a new pull request #7855: Improve example DAGs for Cloud Memorystore

2020-03-24 Thread GitBox
mik-laj opened a new pull request #7855: Improve example DAGs for Cloud Memorystore URL: https://github.com/apache/airflow/pull/7855 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [

[GitHub] [airflow] mik-laj opened a new pull request #7856: Fix CloudMemorystoreCreateInstanceAndImportOperator operator

2020-03-24 Thread GitBox
mik-laj opened a new pull request #7856: Fix CloudMemorystoreCreateInstanceAndImportOperator operator URL: https://github.com/apache/airflow/pull/7856 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below bef

[jira] [Commented] (AIRFLOW-6811) Workflows randomply fail because of ERROR - Unknown error in KubernetesJobWatcher

2020-03-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066003#comment-17066003 ] Max commented on AIRFLOW-6811: -- Dupe of [AIRFLOW-6040|https://issues.apache.org/jira/brows

[GitHub] [airflow] potiuk commented on issue #7854: Add not solved items to pylint_todo.txt

2020-03-24 Thread GitBox
potiuk commented on issue #7854: Add not solved items to pylint_todo.txt URL: https://github.com/apache/airflow/pull/7854#issuecomment-603393364 The general approach is that we should fix them rather than add to pylint_todo.txt -> pylint_todo.txt was only supposed to shrink, not grow. can

[GitHub] [airflow] potiuk commented on issue #7850: [AIRFLOW-4688]: Fix Pylint checks on modules under `scripts` folder

2020-03-24 Thread GitBox
potiuk commented on issue #7850: [AIRFLOW-4688]: Fix Pylint checks on modules under `scripts` folder URL: https://github.com/apache/airflow/pull/7850#issuecomment-603394754 I think there are two more files failing static checks. Can you please fix them @gdevanla ?

[GitHub] [airflow] eladkal opened a new pull request #7857: bumping simple-salesforce to 1.0.0

2020-03-24 Thread GitBox
eladkal opened a new pull request #7857: bumping simple-salesforce to 1.0.0 URL: https://github.com/apache/airflow/pull/7857 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x]

[GitHub] [airflow] codecov-io commented on issue #7856: Fix CloudMemorystoreCreateInstanceAndImportOperator operator

2020-03-24 Thread GitBox
codecov-io commented on issue #7856: Fix CloudMemorystoreCreateInstanceAndImportOperator operator URL: https://github.com/apache/airflow/pull/7856#issuecomment-603423909 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7856?src=pr&el=h1) Report > Merging [#7856](https://codecov.io

[GitHub] [airflow] TomAugspurger commented on issue #7786: Restore DaskExecutor tests

2020-03-24 Thread GitBox
TomAugspurger commented on issue #7786: Restore DaskExecutor tests URL: https://github.com/apache/airflow/pull/7786#issuecomment-603426189 Add a call to `start` in https://github.com/apache/airflow/pull/7786#issuecomment-602568451 doesn't seem to help. I think airflow was doing it internal

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603436714 > Nice! Like the name standardization. I am also thinking if we should standardize the `connection_prefix` (used in AWS SSM & GCP Secrets Manager) an

[GitHub] [airflow] potiuk commented on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603441221 @kaxil @ashb @turbaszek @mik-laj @dimberman -> We have much nicer version now. Requirement generation is now checked only as travis build (sepa

[GitHub] [airflow] kaxil commented on a change in pull request #6578: [AIRFLOW-5907] Add S3 to MySql Operator

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #6578: [AIRFLOW-5907] Add S3 to MySql Operator URL: https://github.com/apache/airflow/pull/6578#discussion_r397401713 ## File path: airflow/providers/mysql/operators/s3_to_mysql.py ## @@ -0,0 +1,84 @@ +# Licensed to the Apache So

[GitHub] [airflow] mik-laj commented on issue #7844: [AIRFLOW-5822] Updated CSRF_ENABLED to WTF_CSRF_ENABLED in default we…

2020-03-24 Thread GitBox
mik-laj commented on issue #7844: [AIRFLOW-5822] Updated CSRF_ENABLED to WTF_CSRF_ENABLED in default we… URL: https://github.com/apache/airflow/pull/7844#issuecomment-603475744 Why do you want to disable CSRF? That doesn't sound safe. ---

[GitHub] [airflow] ChethanUK commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor

2020-03-24 Thread GitBox
ChethanUK commented on issue #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor URL: https://github.com/apache/airflow/pull/7163#issuecomment-603488334 Thank You @roitvt :) This is an automated message from the Apach

[jira] [Created] (AIRFLOW-7107) GCS to Bigquery must provide a schema for externally created table

2020-03-24 Thread Chuan Qiu (Jira)
Chuan Qiu created AIRFLOW-7107: -- Summary: GCS to Bigquery must provide a schema for externally created table Key: AIRFLOW-7107 URL: https://issues.apache.org/jira/browse/AIRFLOW-7107 Project: Apache Airf

[GitHub] [airflow] codecov-io commented on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
codecov-io commented on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603512068 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7841?src=pr&el=h1) Report > Merging [#7841](https://codecov.io/gh/apache/airflow/p

[GitHub] [airflow] codecov-io edited a comment on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603512068 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7841?src=pr&el=h1) Report > Merging [#7841](https://codecov.io/gh/apache/a

[GitHub] [airflow] codecov-io edited a comment on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603512068 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7841?src=pr&el=h1) Report > Merging [#7841](https://codecov.io/gh/apache/a

[GitHub] [airflow] codecov-io edited a comment on issue #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#issuecomment-603512068 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7841?src=pr&el=h1) Report > Merging [#7841](https://codecov.io/gh/apache/a

[GitHub] [airflow] codecov-io commented on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

2020-03-24 Thread GitBox
codecov-io commented on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr&el=h1) Report > Merging [#7401](https:/

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr&el=h1) Report > Merging [#7401](

[GitHub] [airflow] codecov-io commented on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

2020-03-24 Thread GitBox
codecov-io commented on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr&el=h1) Report > Merging [#7405](https:

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr&el=h1) Report > Merging [#7423](https://code

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr&el=h1) Report > Merging [#7423](https://code

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr&el=h1) Report > Merging [#7423](https://code

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr&el=h1) Report > Merging [#7423](https://code

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr&el=h1) Report > Merging [#7423](https://code

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr&el=h1) Report > Merging [#7401](

  1   2   >