[GitHub] [calcite] xy2953396112 commented on a change in pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

xy2953396112 commented on a change in pull request #2241: URL: https://github.com/apache/calcite/pull/2241#discussion_r516736309 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java ## @@ -1931,6 +1931,18 @@ public static MutableRel

[GitHub] [calcite] chunweilei commented on pull request #2239: Following [CALCITE-4332] correct the code style and add some description

chunweilei commented on pull request #2239: URL: https://github.com/apache/calcite/pull/2239#issuecomment-720270874 > isn't style mandatory in compiling phase , checking style plugin? No, some convention is not mandatory.

[GitHub] [calcite] vlsi commented on a change in pull request #2229: Update release instructions

vlsi commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r516059392 ## File path: site/_docs/howto.md ## @@ -684,8 +688,13 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] danny0405 closed pull request #2218: [CALCITE-4233] Adding Elasticsearch Dismax API QueryBuilder

danny0405 closed pull request #2218: URL: https://github.com/apache/calcite/pull/2218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] jcamachor commented on a change in pull request #2094: [CALCITE-3409] Add an interface in RelOptMaterializations…

jcamachor commented on a change in pull request #2094: URL: https://github.com/apache/calcite/pull/2094#discussion_r516184828 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java ## @@ -50,6 +50,12 @@ */ public abstract class

[GitHub] [calcite] vlsi commented on pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

vlsi commented on pull request #2236: URL: https://github.com/apache/calcite/pull/2236#issuecomment-720787197 @qizhou92 , this looks nice. Have you seen `RexFuzzer`, `RexProgramFuzzyTest`, `org.apache.calcite.rex.RexSimplify#verify` ? I wonder if `z3` verifications could be

[GitHub] [calcite] chunweilei commented on pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

chunweilei commented on pull request #2237: URL: https://github.com/apache/calcite/pull/2237#issuecomment-720301754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516743019 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs unknownAs) {

[GitHub] [calcite] vlsi commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

vlsi commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r516285366 ## File path: core/src/test/java/org/apache/calcite/test/SmtLibTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] chunweilei edited a comment on pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

chunweilei edited a comment on pull request #2237: URL: https://github.com/apache/calcite/pull/2237#issuecomment-720328998 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] chunweilei merged pull request #2239: Following [CALCITE-4332] correct the code style and add some description

chunweilei merged pull request #2239: URL: https://github.com/apache/calcite/pull/2239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] julianhyde commented on pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

julianhyde commented on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-720700806 Regarding the commit message: > `a in (1, 2) and a = 1` should be simplified to `a=1` Use upper-case for SQL, and spaces around `=`.

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

yanlin-Lynn commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r516402810 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java ## @@ -407,6 +409,35 @@ protected

[GitHub] [calcite] rubenada commented on pull request #2229: Update release instructions

rubenada commented on pull request #2229: URL: https://github.com/apache/calcite/pull/2229#issuecomment-720524457 @julianhyde @danny0405 gentle reminder. Please take a look at the PR when you have some time. This is an

[GitHub] [calcite] chunweilei merged pull request #2231: [CALCITE-4350] The reverse operation of collation direction is overly relaxed

chunweilei merged pull request #2231: URL: https://github.com/apache/calcite/pull/2231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] qizhou92 commented on a change in pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

qizhou92 commented on a change in pull request #2236: URL: https://github.com/apache/calcite/pull/2236#discussion_r516309298 ## File path: core/src/test/java/org/apache/calcite/test/SmtLibTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] qizhou92 commented on pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

qizhou92 commented on pull request #2236: URL: https://github.com/apache/calcite/pull/2236#issuecomment-720752477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] eolivelli commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

eolivelli commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516232865 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,

[GitHub] [calcite] vlsi commented on pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

vlsi commented on pull request #2237: URL: https://github.com/apache/calcite/pull/2237#issuecomment-720322176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] xy2953396112 opened a new pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

xy2953396112 opened a new pull request #2241: URL: https://github.com/apache/calcite/pull/2241 …nct aggregate on target GROUP BY column (xzh) https://issues.apache.org/jira/browse/CALCITE-4374 This is an automated message

[GitHub] [calcite] rubenada commented on a change in pull request #2229: Update release instructions

rubenada commented on a change in pull request #2229: URL: https://github.com/apache/calcite/pull/2229#discussion_r516067535 ## File path: site/_docs/howto.md ## @@ -684,8 +688,13 @@ Note: release artifacts (dist.apache.org and repository.apache.org) are managed Before you

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

yanlin-Lynn commented on a change in pull request #2241: URL: https://github.com/apache/calcite/pull/2241#discussion_r516694228 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java ## @@ -1931,6 +1931,18 @@ public static MutableRel

[GitHub] [calcite] asfgit closed pull request #2225: [CALCITE-4345] NPE in AggregateCaseToFilterRule when converts SUM(CASE WHEN c THEN 1 END) (Jiatao Tao)

asfgit closed pull request #2225: URL: https://github.com/apache/calcite/pull/2225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2094: [CALCITE-3409] Add an interface in RelOptMaterializations…

xy2953396112 commented on a change in pull request #2094: URL: https://github.com/apache/calcite/pull/2094#discussion_r516391375 ## File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java ## @@ -197,6 +198,10 @@ public boolean isRuleExcluded(RelOptRule

[GitHub] [calcite] zabetak commented on a change in pull request #2223: Proposal : 4344 test container sample

zabetak commented on a change in pull request #2223: URL: https://github.com/apache/calcite/pull/2223#discussion_r515817104 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -239,6 +239,12 @@ public static final

[GitHub] [calcite] chunweilei commented on a change in pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

chunweilei commented on a change in pull request #2237: URL: https://github.com/apache/calcite/pull/2237#discussion_r515812551 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -311,31 +312,39 @@ default boolean onProduce(RelNode

[GitHub] [calcite] julianhyde opened a new pull request #2240: Work-in-progress; do not review; do not merge

julianhyde opened a new pull request #2240: URL: https://github.com/apache/calcite/pull/2240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] vlsi commented on a change in pull request #2223: Proposal : 4344 test container sample

vlsi commented on a change in pull request #2223: URL: https://github.com/apache/calcite/pull/2223#discussion_r515826195 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -239,6 +239,12 @@ public static final CalciteSystemProperty

[GitHub] [calcite] zinking commented on pull request #2239: Following [CALCITE-4332] correct the code style and add some description

zinking commented on pull request #2239: URL: https://github.com/apache/calcite/pull/2239#issuecomment-720242103 isn't style mandatory in compiling phase , checking style plugin? This is an automated message from the Apache

[GitHub] [calcite] danny0405 commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

danny0405 commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516407768 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516228159 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,

[GitHub] [calcite] vlsi commented on a change in pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

vlsi commented on a change in pull request #2237: URL: https://github.com/apache/calcite/pull/2237#discussion_r515870606 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -335,6 +336,14 @@ default boolean onProduce(RelNode node) {

[GitHub] [calcite] danny0405 commented on pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

danny0405 commented on pull request #2237: URL: https://github.com/apache/calcite/pull/2237#issuecomment-720289937 Remember to update the commit message before commit. This is an automated message from the Apache Git

[GitHub] [calcite] danny0405 commented on a change in pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

danny0405 commented on a change in pull request #2163: URL: https://github.com/apache/calcite/pull/2163#discussion_r515829778 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java ## @@ -407,6 +409,35 @@ protected

[GitHub] [calcite] vlsi commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

vlsi commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516246682 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs unknownAs) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

liyafan82 commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516407877 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,

[GitHub] [calcite] danny0405 closed pull request #2214: [CALCITE-4106] Consider "listCoerced" in TypeCoercionImpl#inOperationCoercion (Jiatao Tao)

danny0405 closed pull request #2214: URL: https://github.com/apache/calcite/pull/2214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] danny0405 commented on pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

danny0405 commented on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-720289249 > We should merge two sargs if they apply to the same argument Totally agree, and actually this patch makes more sargs merged.

[GitHub] [calcite] jcamachor commented on a change in pull request #2094: [CALCITE-3409] Add an interface in RelOptMaterializations…

jcamachor commented on a change in pull request #2094: URL: https://github.com/apache/calcite/pull/2094#discussion_r516873161 ## File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java ## @@ -197,6 +198,10 @@ public boolean isRuleExcluded(RelOptRule

[calcite] branch master updated: [CALCITE-4273] Support get expression lineage for Calc

This is an automated email from the ASF dual-hosted git repository. yanlin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 2e9edae [CALCITE-4273] Support get expression

[GitHub] [calcite] yanlin-Lynn merged pull request #2163: [CALCITE-4273] Support get expression lineage for Calc

yanlin-Lynn merged pull request #2163: URL: https://github.com/apache/calcite/pull/2163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] danny0405 commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

danny0405 commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r517056551 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs

[GitHub] [calcite] liyafan82 opened a new pull request #2242: [CALCITE-4363] Need a utility to check if a SQL operator is standard

liyafan82 opened a new pull request #2242: URL: https://github.com/apache/calcite/pull/2242 Please see https://issues.apache.org/jira/browse/CALCITE-4363 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517082361 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -311,31 +311,31 @@ default boolean onProduce(RelNode

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083852 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -768,22 +772,22 @@ private boolean

[GitHub] [calcite] chunweilei commented on pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

chunweilei commented on pull request #2243: URL: https://github.com/apache/calcite/pull/2243#issuecomment-721499337 @liyafan82 thank you for your review. All comments are addressed. This is an automated message from the

[GitHub] [calcite] liyafan82 commented on a change in pull request #2242: [CALCITE-4363] Need a utility to check if a SQL operator is standard

liyafan82 commented on a change in pull request #2242: URL: https://github.com/apache/calcite/pull/2242#discussion_r517087047 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java ## @@ -482,6 +500,7 @@ * Its precedence is less than the

[GitHub] [calcite] chunweilei opened a new pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

chunweilei opened a new pull request #2243: URL: https://github.com/apache/calcite/pull/2243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] liyafan82 commented on pull request #2242: [CALCITE-4363] Need a utility to check if a SQL operator is standard

liyafan82 commented on pull request #2242: URL: https://github.com/apache/calcite/pull/2242#issuecomment-721482425 This PR does two things: 1. We provide a utility to get the related sql libraries, given a sql operator. This should be helpful for the users (see the discussion in the

[GitHub] [calcite] chunweilei commented on pull request #2237: [CALCITE-4368] TopDownOptTest fails if applying non-substitution rule first

chunweilei commented on pull request #2237: URL: https://github.com/apache/calcite/pull/2237#issuecomment-721482956 Opened another PR to fix comments: https://github.com/apache/calcite/pull/2243. This is an automated

[GitHub] [calcite] chunweilei commented on a change in pull request #2242: [CALCITE-4363] Need a utility to check if a SQL operator is standard

chunweilei commented on a change in pull request #2242: URL: https://github.com/apache/calcite/pull/2242#discussion_r517072732 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java ## @@ -482,6 +500,7 @@ * Its precedence is less than the

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517080225 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -69,8 +69,8 @@ private GeneratorTask applying = null;

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517081499 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -170,27 +170,27 @@ private void clearProcessed(RelSet

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083461 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -601,7 +604,7 @@ private boolean checkLowerBound(RelNode

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083286 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -590,7 +593,7 @@ private RelNode convert(RelNode rel,

[GitHub] [calcite] chunweilei commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

chunweilei commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517085070 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -311,31 +311,31 @@ default boolean onProduce(RelNode

[GitHub] [calcite] chunweilei commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

chunweilei commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517085147 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -69,8 +69,8 @@ private GeneratorTask applying =

[GitHub] [calcite] chunweilei commented on a change in pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

chunweilei commented on a change in pull request #2241: URL: https://github.com/apache/calcite/pull/2241#discussion_r517086483 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java ## @@ -1931,6 +1931,22 @@ public static MutableRel

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2241: [CALCITE-4374] Support materialized view recognition when query disti…

xy2953396112 commented on a change in pull request #2241: URL: https://github.com/apache/calcite/pull/2241#discussion_r517118764 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java ## @@ -1931,6 +1931,22 @@ public static MutableRel