[GitHub] [druid] a2l007 commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
a2l007 commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556218910 ## File path: processing/src/main/java/org/apache/druid/query/ResourceLimitExceededException.java ## @@ -19,18 +19,33 @@ package

[GitHub] [druid] kaijianding opened a new pull request #10745: can reset kafka Supervisor to offset by specified time

2021-01-12 Thread GitBox
kaijianding opened a new pull request #10745: URL: https://github.com/apache/druid/pull/10745 ### Description Currently, druid can only reset to earliest/latest offset, sometimes, users want to read from a specified time like the start of today A new optional param

[GitHub] [druid] jihoonson commented on pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jihoonson commented on pull request #10746: URL: https://github.com/apache/druid/pull/10746#issuecomment-758500465 Will update docs as a follow-up. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] jihoonson commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r1 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class

[GitHub] [druid] jihoonson opened a new pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jihoonson opened a new pull request #10746: URL: https://github.com/apache/druid/pull/10746 ### Description Druid querying system returns an HTTP status code on query failures. Currently, most of query failures return an internal error (500) which could be misleading in some cases.

[GitHub] [druid] jihoonson commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r555600385 ## File path: core/src/main/java/org/apache/druid/java/util/metrics/ClockDriftSafeMonitorScheduler.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the

[GitHub] [druid] nishantmonu51 commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
nishantmonu51 commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r555825958 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java ## @@ -1044,17 +1048,21 @@ public IndexIOConfig(

[GitHub] [druid] fabes99 commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments

2021-01-12 Thread GitBox
fabes99 commented on issue #8663: URL: https://github.com/apache/druid/issues/8663#issuecomment-758589129 Facing the same issue also with version 0.18.1. This is an automated message from the Apache Git Service. To respond

[GitHub] [druid] licl2014 opened a new issue #10747: Hyperunique is giving different results on multiple execution of same query

2021-01-12 Thread GitBox
licl2014 opened a new issue #10747: URL: https://github.com/apache/druid/issues/10747 Hyperunique is giving different results on multiple execution of same query ### Affected Version 0.12.3 ### Description What my query as follows: ``` {

[GitHub] [druid] nishantmonu51 commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
nishantmonu51 commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r555809503 ## File path: extensions-core/hdfs-storage/src/main/java/org/apache/druid/inputsource/hdfs/HdfsInputSource.java ## @@ -214,10 +215,23 @@ public

[GitHub] [druid] nishantmonu51 commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
nishantmonu51 commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r555808142 ## File path: core/src/main/java/org/apache/druid/data/input/AbstractInputSource.java ## @@ -31,13 +31,16 @@ */ public abstract class

[GitHub] [druid] nishantmonu51 commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
nishantmonu51 commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-758695886 @jihoonson thanks for the review, I hv updated the PR, yes, it will be nice to get this in 0.21.0 release.

[GitHub] [druid] nishantmonu51 commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
nishantmonu51 commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r555815427 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java ## @@ -153,6 +154,9 @@ @JsonIgnore

[GitHub] [druid] jihoonson commented on a change in pull request #10743: fix limited queries with subtotals

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10743: URL: https://github.com/apache/druid/pull/10743#discussion_r556259073 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -43,6 +43,7 @@ private

[GitHub] [druid] jihoonson commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556271084 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -463,36 +481,36 @@ Response ok(Object object) throws IOException

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-12 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r556267351 ## File path: docs/misc/math-expr.md ## @@ -119,6 +119,13 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] jihoonson commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556270879 ## File path: processing/src/main/java/org/apache/druid/query/ResourceLimitExceededException.java ## @@ -19,18 +19,33 @@ package

[GitHub] [druid] jihoonson commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r556275449 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java ## @@ -1044,17 +1048,21 @@ public IndexIOConfig(

[GitHub] [druid] jihoonson commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r556280161 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java ## @@ -232,6 +237,10 @@ public boolean

[GitHub] [druid] jon-wei commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jon-wei commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556245770 ## File path: processing/src/main/java/org/apache/druid/query/QueryUnsupportedException.java ## @@ -24,21 +24,20 @@ import

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-12 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r555931298 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/UniformGranularitySpec.java ## @@ -57,18 +60,17 @@ public

[GitHub] [druid] maytasm commented on pull request #10740: Fix byte calculation for maxBytesInMemory to take into account of Sink/Hydrant Object overhead

2021-01-12 Thread GitBox
maytasm commented on pull request #10740: URL: https://github.com/apache/druid/pull/10740#issuecomment-758863964 > ``` > [ERROR] Failures: > [ERROR]

[GitHub] [druid] suneet-s commented on pull request #10740: Fix byte calculation for maxBytesInMemory to take into account of Sink/Hydrant Object overhead

2021-01-12 Thread GitBox
suneet-s commented on pull request #10740: URL: https://github.com/apache/druid/pull/10740#issuecomment-758803244 ``` [ERROR] Failures: [ERROR]

[GitHub] [druid] loquisgon commented on a change in pull request #10742: Granularity interval materialization

2021-01-12 Thread GitBox
loquisgon commented on a change in pull request #10742: URL: https://github.com/apache/druid/pull/10742#discussion_r555991064 ## File path: server/src/main/java/org/apache/druid/segment/indexing/granularity/GranularitySpec.java ## @@ -45,7 +46,7 @@ * * @return set of

[GitHub] [druid] suneet-s commented on a change in pull request #10743: fix limited queries with subtotals

2021-01-12 Thread GitBox
suneet-s commented on a change in pull request #10743: URL: https://github.com/apache/druid/pull/10743#discussion_r556004791 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java ## @@ -16281,6 +16281,71 @@ public void testTimeStampAddConversion()

[GitHub] [druid] a2l007 commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
a2l007 commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556043383 ## File path: processing/src/main/java/org/apache/druid/query/BadQueryException.java ## @@ -20,12 +20,16 @@ package org.apache.druid.query; /** - *

[GitHub] [druid-website-src] druid-matt opened a new pull request #200: remove 1 meetup, add 2

2021-01-12 Thread GitBox
druid-matt opened a new pull request #200: URL: https://github.com/apache/druid-website-src/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [druid] gianm commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
gianm commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r556053575 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class

[GitHub] [druid] suneet-s commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
suneet-s commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r556068500 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class

[GitHub] [druid] jihoonson merged pull request #10736: Fix potential deadlock in batch ingestion

2021-01-12 Thread GitBox
jihoonson merged pull request #10736: URL: https://github.com/apache/druid/pull/10736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] gianm commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
gianm commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r556054132 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class

[GitHub] [druid] jihoonson commented on pull request #10736: Fix potential deadlock in batch ingestion

2021-01-12 Thread GitBox
jihoonson commented on pull request #10736: URL: https://github.com/apache/druid/pull/10736#issuecomment-758968538 @loquisgon @maytasm thanks for the review! This is an automated message from the Apache Git Service. To

[druid] branch master updated (3984457 -> ca32652)

2021-01-12 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3984457 Add missing unit tests for segment loading in historicals (#10737) add ca32652 Fix potential

[GitHub] [druid] suneet-s merged pull request #10741: Web console: fix bad results if there is not native bigint

2021-01-12 Thread GitBox
suneet-s merged pull request #10741: URL: https://github.com/apache/druid/pull/10741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] suneet-s commented on pull request #10741: Web console: fix bad results if there is not native bigint

2021-01-12 Thread GitBox
suneet-s commented on pull request #10741: URL: https://github.com/apache/druid/pull/10741#issuecomment-759124141 nice test! This is an automated message from the Apache Git Service. To respond to the message, please log on

[druid] branch master updated (aecc9e5 -> 2fc2938)

2021-01-12 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from aecc9e5 Remove legacy code from LogUsedSegments duty (#10287) add 2fc2938 Web console: fix bad results if

[GitHub] [druid] jihoonson commented on a change in pull request #10746: Tidy up HTTP status codes for query errors

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10746: URL: https://github.com/apache/druid/pull/10746#discussion_r556202316 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -463,36 +481,36 @@ Response ok(Object object) throws IOException

[GitHub] [druid] techdocsmith commented on a change in pull request #10748: reword for clarity

2021-01-12 Thread GitBox
techdocsmith commented on a change in pull request #10748: URL: https://github.com/apache/druid/pull/10748#discussion_r556188376 ## File path: docs/ingestion/native-batch.md ## @@ -192,7 +192,7 @@ that range if there's some stray data with unexpected timestamps.

[GitHub] [druid] jihoonson merged pull request #10287: Remove legacy code from LogUsedSegments duty

2021-01-12 Thread GitBox
jihoonson merged pull request #10287: URL: https://github.com/apache/druid/pull/10287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] techdocsmith opened a new pull request #10748: reword for clarity

2021-01-12 Thread GitBox
techdocsmith opened a new pull request #10748: URL: https://github.com/apache/druid/pull/10748 Fixes awkward wording around the behavior of `appendToExsiting`. ### Description Removes ambiguity around the "current

[druid] branch master updated (ca32652 -> aecc9e5)

2021-01-12 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from ca32652 Fix potential deadlock in batch ingestion (#10736) add aecc9e5 Remove legacy code from

[GitHub] [druid] jihoonson commented on pull request #10614: re-use expression vector evaluation results for the same offset in expression vector selectors

2021-01-12 Thread GitBox
jihoonson commented on pull request #10614: URL: https://github.com/apache/druid/pull/10614#issuecomment-759125756 LGTM. Thanks @clintropolis. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] gianm commented on a change in pull request #10748: reword for clarity

2021-01-12 Thread GitBox
gianm commented on a change in pull request #10748: URL: https://github.com/apache/druid/pull/10748#discussion_r556167558 ## File path: docs/ingestion/native-batch.md ## @@ -192,7 +192,7 @@ that range if there's some stray data with unexpected timestamps.

[GitHub] [druid] jihoonson commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r556211566 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class

[GitHub] [druid] jihoonson commented on a change in pull request #10732: Add a config for monitorScheduler type

2021-01-12 Thread GitBox
jihoonson commented on a change in pull request #10732: URL: https://github.com/apache/druid/pull/10732#discussion_r556211781 ## File path: server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java ## @@ -28,9 +29,17 @@ */ public class