[incubator-pinot] branch switch-ui-to-sql updated (26586a1 -> 3db7c2b)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 26586a1 move sql parser to calcite parser again discard 91958f9 move sql back to pql parser

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] harleyjj opened a new pull request #5012: [TE] frontend - harleyjj/alert-details - fix anomaly chart mapping to…

2020-01-23 Thread GitBox
harleyjj opened a new pull request #5012: [TE] frontend - harleyjj/alert-details - fix anomaly chart mapping to… URL: https://github.com/apache/incubator-pinot/pull/5012 … be robust against imprecision 1) Anomaly endTime sometimes does not align to granularity, so we change the

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5013: For RANGE predicate queries touching offline segments, use sorted inverted index.

2020-01-23 Thread GitBox
siddharthteotia opened a new pull request #5013: For RANGE predicate queries touching offline segments, use sorted inverted index. URL: https://github.com/apache/incubator-pinot/pull/5013 Motivation: Currently, we don't leverage inverted index (sorted or bitmap) for RANGE

[incubator-pinot] branch switch-ui-to-sql updated (3db7c2b -> be1a84f)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3db7c2b Make sql as default query format. add 27ab5ad Make sql as default query format.

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats.

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#issuecomment-574887413 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577528692 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=h1) Report > Merging

[incubator-pinot] branch update_docker_images created (now 435b34e)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 435b34e update docker image location This branch includes the following new commits:

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5007: update docker image location

2020-01-23 Thread GitBox
fx19880617 opened a new pull request #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007 Update all pinot related docker images to `apachepinot` repo. This is an automated message from

[incubator-pinot] branch update_docker_images updated (435b34e -> 49d0a2b)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 435b34e update docker image location add 49d0a2b update docker image location This

[GitHub] [incubator-pinot] codecov-io commented on issue #5007: update docker image location

2020-01-23 Thread GitBox
codecov-io commented on issue #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007#issuecomment-577614102 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5007: update docker image location

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007#issuecomment-577614102 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=h1) Report > Merging

[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (cadbd0d -> 38ee798)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard cadbd0d Make calcite parser support order by expression add

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5006: Add FieldConfig.

2020-01-23 Thread GitBox
kishoreg commented on a change in pull request #5006: Add FieldConfig. URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r369983270 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@ -82,7 +88,8 @@ public

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5006: Add FieldConfig.

2020-01-23 Thread GitBox
siddharthteotia opened a new pull request #5006: Add FieldConfig. URL: https://github.com/apache/incubator-pinot/pull/5006 TableConfig can take a list of FieldConfig to encapsulate storage, indexing and any other information for a field.

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-23 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r369991242 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5006: Add FieldConfig.

2020-01-23 Thread GitBox
siddharthteotia commented on a change in pull request #5006: Add FieldConfig. URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r369984530 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@ -82,7 +88,8 @@

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats.

2020-01-23 Thread GitBox
codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#issuecomment-574887413 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on issue #5006: Add FieldConfig

2020-01-23 Thread GitBox
codecov-io commented on issue #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#issuecomment-577589208 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=h1) Report > Merging

[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (3558d26 -> cadbd0d)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3558d26 Make calcite parser support order by expression add

[incubator-pinot] 01/01: update docker image location

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 435b34e9c099e219bebe4d1a145d0de50eda0b82 Author: Xiang Fu AuthorDate: Thu Jan 23 01:30:11 2020

[GitHub] [incubator-pinot] haibow opened a new pull request #5010: Exclude slf4j from hadoop-common

2020-01-23 Thread GitBox
haibow opened a new pull request #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010 `slf4j-log4j12` is included in `hadoop-common`, causing logger resolution issues in several places. We are at the mercy of JVM to pick a logger when there are

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370348191 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java ## @@ -0,0 +1,72 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370276146 ## File path:

[GitHub] [incubator-pinot] elonazoulay opened a new issue #5008: Add TestContainer

2020-01-23 Thread GitBox
elonazoulay opened a new issue #5008: Add TestContainer URL: https://github.com/apache/incubator-pinot/issues/5008 Add TestContainer to help with testing. This can also be used by external projects that interact with pinot.

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…

2020-01-23 Thread GitBox
xiaohui-sun commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r370329916 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5000: [TE] frontend - harleyjj/alert-details - show bounds for minute and d…

2020-01-23 Thread GitBox
xiaohui-sun merged pull request #5000: [TE] frontend - harleyjj/alert-details - show bounds for minute and d… URL: https://github.com/apache/incubator-pinot/pull/5000 This is an automated message from the Apache Git

[incubator-pinot] branch master updated (c3117d0 -> 0819c1e)

2020-01-23 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c3117d0 Handle sun.nio.ch.DirectBuffer cleaner behavior for jdk 8+ (#5002) add 0819c1e [TE] frontend

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370275890 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370276395 ## File path:

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…

2020-01-23 Thread GitBox
vincentchenjl opened a new pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009 …t cron This is an automated message from the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370279960 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java ## @@ -0,0 +1,72 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370279280 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java ## @@ -0,0 +1,72 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370277724 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java ## @@ -0,0 +1,72 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370324802 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@ -177,7 +188,7 @@ public

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig

2020-01-23 Thread GitBox
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370324742 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java ## @@ -157,7 +168,7 @@ public

[GitHub] [incubator-pinot] codecov-io commented on issue #5010: Exclude slf4j from hadoop-common

2020-01-23 Thread GitBox
codecov-io commented on issue #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010#issuecomment-577910671 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…

2020-01-23 Thread GitBox
xiaohui-sun commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa… URL: https://github.com/apache/incubator-pinot/pull/5011#discussion_r370397132 ## File path:

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…

2020-01-23 Thread GitBox
vincentchenjl commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r370381169 ## File path:

[GitHub] [incubator-pinot] fx19880617 merged pull request #5001: Supress runtime logging warnings for java 11

2020-01-23 Thread GitBox
fx19880617 merged pull request #5001: Supress runtime logging warnings for java 11 URL: https://github.com/apache/incubator-pinot/pull/5001 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated (1f876c6 -> 4d61045)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1f876c6 update docker image location (#5007) add 4d61045 Supress runtime logging warnings for java

[incubator-pinot] branch master updated (0819c1e -> 1f876c6)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0819c1e [TE] frontend - harleyjj/alert-details - show bounds for minute and day granularity in Alert

[GitHub] [incubator-pinot] fx19880617 merged pull request #5007: update docker image location

2020-01-23 Thread GitBox
fx19880617 merged pull request #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] harleyjj opened a new pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…

2020-01-23 Thread GitBox
harleyjj opened a new pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa… URL: https://github.com/apache/incubator-pinot/pull/5011 …ram for yaml/list 1) Makes dataset an optional param for returning a filtered list of detection yaml

[GitHub] [incubator-pinot] fx19880617 merged pull request #5010: Exclude slf4j from hadoop-common

2020-01-23 Thread GitBox
fx19880617 merged pull request #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pinot] branch master updated (4d61045 -> 94c7675)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4d61045 Supress runtime logging warnings for java 11 (#5001) add 94c7675 Exclude slf4j from pom

[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (38ee798 -> ff02093)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 38ee798 Make calcite parser support order by expression add

[incubator-pinot] branch switch-ui-to-sql updated (b2b5779 -> 26586a1)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b2b5779 move sql back to pql parser discard edea63b Address comments discard 05da777 Adding

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
Jackie-Jiang commented on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577932630 We don't support such queries yet, so what is the current behavior with this pr checked in? Will the engine throw

[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
fx19880617 commented on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577933473 > We don't support such queries yet, so what is the current behavior with this pr checked in? Will the engine throw

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418027 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418027 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
siddharthteotia commented on a change in pull request #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370417690 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression

2020-01-23 Thread GitBox
fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418278 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java

[GitHub] [incubator-pinot] siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.

2020-01-23 Thread GitBox
siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577935875 This is supported on all paths right? (1) PQL -> PqlCompiler ->

[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (ff02093 -> fa4001c)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ff02093 Set SqlConformanceEnum.LENIENT to CalciteParser add

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.

2020-01-23 Thread GitBox
fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370421179 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.

2020-01-23 Thread GitBox
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577938204 > This is supported on all paths right? > > (1) PQL -> PqlCompiler ->

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.

2020-01-23 Thread GitBox
fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370421179 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
npawar commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370427425 ## File path:

[GitHub] [incubator-pinot] npawar commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
npawar commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577944366 This LGTM. I see you've also included the change to use LIMIT in group by queries.

[GitHub] [incubator-pinot] siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945733 > > This is supported on all paths right? > > (1) PQL -> PqlCompiler ->

[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945931 > This LGTM. > I see you've also included the change to use LIMIT in group by

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
siddharthteotia edited a comment on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945733 > > This is supported on all paths right? > > (1) PQL ->

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
siddharthteotia commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370429986 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577946390 > > > This is supported on all paths right? > > > (1) PQL -> PqlCompiler ->

[incubator-pinot] branch master updated (94c7675 -> 995ad83)

2020-01-23 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 94c7675 Exclude slf4j from pom (#5010) add 995ad83 Calcite SQL compiler syntax support for order by

[GitHub] [incubator-pinot] fx19880617 merged pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance

2020-01-23 Thread GitBox
fx19880617 merged pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005 This is an automated message from

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…

2020-01-23 Thread GitBox
harleyjj commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa… URL: https://github.com/apache/incubator-pinot/pull/5011#discussion_r370435266 ## File path: