[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773917
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 24/May/22 08:25
Start Date: 24/May/22 08:25
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135564137
> @slfan1989 sounds good. I assume the patch in the new PR will be similar -
if so, feel free to mention me and I will try and review in good time.
Hi, @dannycjones , thank you , new pr(HDFS-16590. Fix Junit Test Deprecated
assertThat #4349)
Issue Time Tracking
---
Worklog Id: (was: 773917)
Time Spent: 4.5h (was: 4h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773909=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773909
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 24/May/22 08:13
Start Date: 24/May/22 08:13
Worklog Time Spent: 10m
Work Description: dannycjones commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135552621
@slfan1989 sounds good. I assume the patch in the new PR will be similar -
if so, feel free to mention me and I will try and review in good time.
Issue Time Tracking
---
Worklog Id: (was: 773909)
Time Spent: 4h 20m (was: 4h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773810
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:37
Start Date: 23/May/22 23:37
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241796
Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep
improving it, I think this should really be changed to HDFS-JIRA.
Issue Time Tracking
---
Worklog Id: (was: 773810)
Time Spent: 4h 10m (was: 4h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773809
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:37
Start Date: 23/May/22 23:37
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241795
Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep
improving it, I think this should really be changed to HDFS-JIRA.
Issue Time Tracking
---
Worklog Id: (was: 773809)
Time Spent: 4h (was: 3h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773808=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773808
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:35
Start Date: 23/May/22 23:35
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879939590
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
Issue Time Tracking
---
Worklog Id: (was: 773808)
Time Spent: 3h 50m (was: 3h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773807=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773807
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:34
Start Date: 23/May/22 23:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135240105
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 60 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 44s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 24s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 15m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 21m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 57s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 24m 28s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 34s | | the patch passed |
| +1 :green_heart: | compile | 22m 14s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 14s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 4 new + 2458 unchanged - 451
fixed = 2462 total (was 2909) |
| +1 :green_heart: | compile | 20m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 47s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 4 new + 2256
unchanged - 451 fixed = 2260 total (was 2707) |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 4m 20s | | root: The patch generated
0 new + 688 unchanged - 2 fixed = 688 total (was 690) |
| +1 :green_heart: | mvnsite | 15m 56s | | the patch passed |
| +1 :green_heart: | javadoc | 13m 45s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 23m 17s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 12s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 4s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 18m 29s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit |
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773647
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 18:35
Start Date: 23/May/22 18:35
Worklog Time Spent: 10m
Work Description: steveloughran commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135009677
> Sorry for disturbing you during the holiday.
you didn't, i was offline. just that you seemed to worrying too much that i
hadn't commented
Issue Time Tracking
---
Worklog Id: (was: 773647)
Time Spent: 3.5h (was: 3h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773486
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:38
Start Date: 23/May/22 13:38
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879468528
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773486)
Time Spent: 3h 10m (was: 3h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773487=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773487
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:39
Start Date: 23/May/22 13:39
Worklog Time Spent: 10m
Work Description: slfan1989 closed pull request #4334: HADOOP-18248. Fix
Junit Test Deprecated assertThat.
URL: https://github.com/apache/hadoop/pull/4334
Issue Time Tracking
---
Worklog Id: (was: 773487)
Time Spent: 3h 20m (was: 3h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773484
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:38
Start Date: 23/May/22 13:38
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879467790
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thank you for your suggestion, I will continue to improve the code.
Issue Time Tracking
---
Worklog Id: (was: 773484)
Time Spent: 3h (was: 2h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773483=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773483
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:36
Start Date: 23/May/22 13:36
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134690674
> > Hi, @steveloughran please help me to review the code, thank you very
much!
> > lwe have these things called "holidays" and "weekends". do not take the
fact that i didn't review the change personally.
>
> it's mostly an HDFS source change. you need an hdfs jira for that bit of
the patch.
>
> for hadoop common, why not move it to assertj the way we are doing for new
code
Thanks for your suggestion, I will re-submit a HDFS JIRA and make some
adjustments to the code. Sorry for disturbing you
during the holiday.
Issue Time Tracking
---
Worklog Id: (was: 773483)
Time Spent: 2h 50m (was: 2h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773477=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773477
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:25
Start Date: 23/May/22 13:25
Worklog Time Spent: 10m
Work Description: steveloughran commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134678711
> Hi, @steveloughran please help me to review the code, thank you very much!
lwe have these things called "holidays" and "weekends". do not take the fact
that i didn't review the change personally.
it's mostly an HDFS source change. you need an hdfs jira for that bit of the
patch.
for hadoop common, why not move it to assertj the way we are doing for new
code
Issue Time Tracking
---
Worklog Id: (was: 773477)
Time Spent: 2h 40m (was: 2.5h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773459=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773459
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:39
Start Date: 23/May/22 12:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879390284
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here and when/if we can remove.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
Issue Time Tracking
---
Worklog Id: (was: 773459)
Time Spent: 2.5h (was: 2h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773458=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773458
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:39
Start Date: 23/May/22 12:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879406416
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why they
are here and when we should remove them.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I'm not sure if there's any side effects here, we are changing the test.
Can we stick with equals?
```suggestion
assertThat(s, CoreMatchers.equalTo(component.getName() + "-" + i));
```
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why its
here and when we should remove it.
Issue Time Tracking
---
Worklog Id: (was: 773458)
Time Spent: 2h 20m (was: 2h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773445
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:02
Start Date: 23/May/22 12:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
I will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773445)
Time Spent: 2h (was: 1h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773446
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:02
Start Date: 23/May/22 12:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Thank you, I will fix it.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
OK, I will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773446)
Time Spent: 2h 10m (was: 2h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773371
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 09:09
Start Date: 23/May/22 09:09
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879203139
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Hi, @dannycjones ,Thank you very much for your help reviewing the code, I
will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773371)
Time Spent: 1h 50m (was: 1h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773350=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773350
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 08:39
Start Date: 23/May/22 08:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
Issue Time Tracking
---
Worklog Id: (was: 773350)
Time Spent: 1h 40m (was: 1.5h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773347=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773347
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 08:37
Start Date: 23/May/22 08:37
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
Please move these below the `org.hamcrest` import.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
Issue Time Tracking
---
Worklog Id: (was: 773347)
Time Spent: 1.5h (was: 1h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773305=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773305
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 07:02
Start Date: 23/May/22 07:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134261746
Hi, @steveloughran please help me to review the code, thank you very much!
Issue Time Tracking
---
Worklog Id: (was: 773305)
Time Spent: 1h 20m (was: 1h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773258
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 00:37
Start Date: 23/May/22 00:37
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134036795
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 64 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 29m 8s | | trunk passed |
| +1 :green_heart: | compile | 30m 24s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 24m 48s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 45s | | trunk passed |
| +1 :green_heart: | mvnsite | 11m 29s | | trunk passed |
| +1 :green_heart: | javadoc | 9m 51s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 10m 0s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 17m 42s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 56s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 25m 26s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 2s | | the patch passed |
| +1 :green_heart: | compile | 29m 19s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 29m 19s | |
root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 2460 unchanged - 450
fixed = 2460 total (was 2910) |
| +1 :green_heart: | compile | 24m 41s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 24m 41s | |
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 2256 unchanged -
450 fixed = 2256 total (was 2706) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 37s | | root: The patch generated
0 new + 687 unchanged - 2 fixed = 687 total (was 689) |
| +1 :green_heart: | mvnsite | 11m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 9m 43s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 10m 13s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 19m 24s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 3s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 22s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 399m 37s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 3m 53s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | unit | 5m 27s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 24m 16s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 48m 4s | | hadoop-distcp in the patch
passed. |
| +1 :green_heart: | unit | 21m 50s | | hadoop-yarn-services-core in
the patch passed. |
| +1 :green_heart: | unit | 3m 19s | | hadoop-aws in the patch passed.
|
| +1 :green_heart: | unit | 2m 50s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 38s | | The patch does
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773257
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 00:27
Start Date: 23/May/22 00:27
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134033538
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 63 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 59s | | trunk passed |
| +1 :green_heart: | compile | 29m 13s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 25m 43s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 49s | | trunk passed |
| +1 :green_heart: | mvnsite | 11m 11s | | trunk passed |
| +1 :green_heart: | javadoc | 9m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 10m 7s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 17m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 10s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 25m 39s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 11s | | the patch passed |
| +1 :green_heart: | compile | 29m 7s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 29m 7s | |
root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 2460 unchanged - 449
fixed = 2460 total (was 2909) |
| +1 :green_heart: | compile | 25m 32s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 25m 32s | |
root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 2258 unchanged -
449 fixed = 2258 total (was 2707) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 36s | | root: The patch generated
0 new + 684 unchanged - 2 fixed = 684 total (was 686) |
| +1 :green_heart: | mvnsite | 10m 58s | | the patch passed |
| +1 :green_heart: | javadoc | 9m 45s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 10m 6s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 19m 45s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 19s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 4s | | hadoop-auth in the patch
passed. |
| -1 :x: | unit | 394m 34s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | unit | 4m 19s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | unit | 5m 49s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 24m 31s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 48m 34s | | hadoop-distcp in the patch
passed. |
| +1 :green_heart: | unit | 21m 38s | | hadoop-yarn-services-core in
the patch passed. |
| +1 :green_heart: | unit | 3m 42s | | hadoop-aws in the patch
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773190=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773190
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 22/May/22 10:43
Start Date: 22/May/22 10:43
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1133867455
Hi, @steveloughran, this pr is to solve the Deprecated problem of the
assertThat method. I read the javac compilation problem and think that other
problems should be submitted to other prs for resolution. I will continue to
follow up on other javac compilation problems to solve.
Issue Time Tracking
---
Worklog Id: (was: 773190)
Time Spent: 50m (was: 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773035
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 20/May/22 22:18
Start Date: 20/May/22 22:18
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1133428989
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 63 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 35s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 57s | | trunk passed |
| +1 :green_heart: | compile | 29m 58s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 26m 26s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 5m 6s | | trunk passed |
| +1 :green_heart: | mvnsite | 13m 43s | | trunk passed |
| +1 :green_heart: | javadoc | 11m 34s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 10m 50s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 19m 11s | | trunk passed |
| +1 :green_heart: | shadedclient | 28m 34s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 37s | | the patch passed |
| +1 :green_heart: | compile | 28m 21s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 28m 21s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/3/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 55 new + 1758 unchanged - 57
fixed = 1813 total (was 1815) |
| +1 :green_heart: | compile | 23m 11s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 23m 11s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/3/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 54 new + 1633
unchanged - 56 fixed = 1687 total (was 1689) |
| +1 :green_heart: | blanks | 0m 1s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 56s | | root: The patch generated
0 new + 684 unchanged - 2 fixed = 684 total (was 686) |
| +1 :green_heart: | mvnsite | 13m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 10m 13s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 11m 15s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 20m 31s | | the patch passed |
| +1 :green_heart: | shadedclient | 28m 50s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 22s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 375m 50s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 3m 50s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | unit | 5m 24s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 23m 53s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 46m 1s | | hadoop-distcp in the patch
passed. |
| +1 :green_heart: | unit | 21m 14s |
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=772892=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772892
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 20/May/22 15:50
Start Date: 20/May/22 15:50
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1133060843
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 13 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 51s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 0s | | trunk passed |
| +1 :green_heart: | compile | 25m 2s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 21m 37s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 31s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 1s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 36s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 2m 59s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 5m 17s | | trunk passed |
| +1 :green_heart: | shadedclient | 26m 50s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 48s | | the patch passed |
| +1 :green_heart: | compile | 24m 50s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 24m 50s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/2/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 10 new + 1801 unchanged - 11
fixed = 1811 total (was 1812) |
| +1 :green_heart: | compile | 22m 4s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 22m 4s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/2/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 11 new + 1675
unchanged - 12 fixed = 1686 total (was 1687) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 22s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 28s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 2m 59s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 5m 25s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 58s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 3m 50s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 397m 33s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 56s | | The patch does not
generate ASF License warnings. |
| | | 635m 9s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4334 |
| Optional Tests | dupname asflicense compile javac javadoc
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=772789=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772789
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 20/May/22 11:25
Start Date: 20/May/22 11:25
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1132788194
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 56s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 51s | | trunk passed |
| +1 :green_heart: | compile | 23m 7s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 31s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 20s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 32s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 9s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 3m 34s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 5m 38s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 18s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 52s | | the patch passed |
| +1 :green_heart: | compile | 22m 22s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 22s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/1/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 2 new + 1809 unchanged - 3
fixed = 1811 total (was 1812) |
| +1 :green_heart: | compile | 20m 35s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 35s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/1/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 2 new + 1684
unchanged - 3 fixed = 1686 total (was 1687) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 8s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 38s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 59s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 3m 29s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 5m 47s | | the patch passed |
| +1 :green_heart: | shadedclient | 24m 25s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 3m 58s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 255m 4s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 57s | | The patch does not
generate ASF License warnings. |
| | | 482m 5s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4334 |
| Optional Tests | dupname asflicense compile javac javadoc
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=772659=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772659
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 20/May/22 03:21
Start Date: 20/May/22 03:21
Worklog Time Spent: 10m
Work Description: slfan1989 opened a new pull request, #4334:
URL: https://github.com/apache/hadoop/pull/4334
JIRA: HADOOP-18248 Fix Junit Test Deprecated assertThat
javac will give a warning for compilation, as follows:
TestIncrementalBrVariations.java:141:4:[deprecation]
assertThat(T,Matcher) in Assert has been deprecated
org.junit.Assert.assertThat Deprecated. use
org.hamcrest.MatcherAssert.assertThat()
Issue Time Tracking
---
Worklog Id: (was: 772659)
Remaining Estimate: 0h
Time Spent: 10m
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Fix For: 3.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
