Re: [PATCH 1/2] ofono: fix ip/ipv6/dual protocol support

2014-12-16 Thread Patrik Flykt
On Tue, 2014-12-16 at 11:34 +0200, pasi.sjoh...@jolla.com wrote: From: Jarko Poutiainen jarko.poutiai...@oss.tieto.com -Reset ipv4/6_method to CONNMAN_IPCONFIG_METHOD_UNKNOWN when protocol is set ip/ipv6/dual on ofono. -IPv6 configuration method is either CONNMAN_IPCONFIG_METHOD_FIXED

Re: [PATCH 2/2] network: index needs to be set also for ip6config

2014-12-16 Thread Patrik Flykt
Hi, On Tue, 2014-12-16 at 11:34 +0200, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com Fixes the issue that network index was not set for ipv6-connections. Which issue do you see if this is not set? Is this a pre-requisite for patch 1/1? If so, send

[PATCH] ipconfig: Remove unused ipconfig-origin

2014-12-16 Thread Patrik Flykt
ipconfig-origin can be safely removed as nothing sets it. --- src/ipconfig.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 3d0c387..5c34e98 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -45,8 +45,6 @@ struct connman_ipconfig {

Re: [PATCH 2/2] network: index needs to be set also for ip6config

2014-12-16 Thread Patrik Flykt
On Tue, 2014-12-16 at 11:04 +, Pasi Sjöholm wrote: SLAAC/DHCPv6 will not work with dual/ipv4v6-pdp when this is not done. From this I try to decipher that something does not work if IPv4 is present. What is this something? Did it stop working after patch 1/2 got applied? Cheers,

Re: tinc vpn plugin

2014-12-16 Thread Patrik Flykt
Hi, On Sat, 2014-12-06 at 18:25 +0100, Anton Voyl wrote: Tinc triggers scripts upon events, e.g. tinc-up after tinc comes up, tinc-down before tinc comes down, etc. This feature could advantageously be used to keep the tinc vpn plugin to a bare minimum, e.g. tinc-up could call

Re: WIFI Tehtering works over eth0 but not ppp0 ?

2014-12-16 Thread Patrik Flykt
Hi, On Wed, 2014-12-10 at 20:00 +0200, Frederik Lotter wrote: (3) Next I disconnect WIRED eth0 service. * The log starts here * (4) I run a program which talks to connmand over DBUS, and connect to a cellular service, which creates ppp0. (5) I ping

Re: [PATCH] service: Send changed type signal

2014-12-11 Thread Patrik Flykt
On Thu, 2014-12-11 at 17:54 +0800, Chengyi Zhao wrote: From: Chengyi Zhao chengyi1.z...@archermind.com --- There is no commit message. NACK. Patrik ___ connman mailing list connman@connman.net

Re: NTP server setup

2014-12-05 Thread Patrik Flykt
Hi, On Fri, 2014-12-05 at 10:27 +0100, Boszormenyi Zoltan wrote: I am using a custom distro derived from Angström (based on Yocto Daisy) and I have a problem with the NTP setup in connman. I can configure the fallback timeservers just fine in /var/lib/connman/settings.

Re: Error reconnecting to a hidden AP.

2014-12-05 Thread Patrik Flykt
On Fri, 2014-12-05 at 14:49 +0200, Tomasz Bursztyka wrote: I think ConnMan's README advises to enable it but it's a mistake. ConnMan's fallback autoscan is better since it handles properly the hidden SSIDs. Could we have a patch to that documentation and not enable it by default if we are?

Re: Retrieve the saved Wi-Fi profiles which are not in range

2014-12-04 Thread Patrik Flykt
On Thu, 2014-12-04 at 18:58 +, Lorn Potter wrote: Jolla's connman code does exactly this. ...and as we've discussed before, it needs a bit more love and care before any of it gets close to upstream. Cheers, Patrik ___ connman mailing

Re: Retrieve the saved Wi-Fi profiles which are not in range

2014-12-03 Thread Patrik Flykt
On Wed, 2014-12-03 at 14:45 +0530, Siddhartha Sikder wrote: Is there any way to retrieve the saved Wi-Fi profiles which are not in range and are not found via scanning? There is no way to retrieve saved services that are not in range or otherwise unavailable. See the

Re: [PATCH 0/5] Minor fixes

2014-12-02 Thread Patrik Flykt
On Mon, 2014-12-01 at 16:17 +0200, Patrik Flykt wrote: Hi, Here are a couple of fixes for the issues discovered. Patches 01 and 02 clean up whitespace and pointer usage, while patch03 adds a unique value for CONNMAN_IPCONFIG_TYPE_ALL. Previously it shared a value of zero

Re: [PATCH 4/5] gdhcp: Properly specify length of uint64_t

2014-12-02 Thread Patrik Flykt
On Tue, 2014-12-02 at 17:06 -0800, Justin Maggard wrote: Hmm, this looks fishy to me. Wouldn't this read() call change the pointer, rather than the uint64_t value? Yes... Patrik ___ connman mailing list connman@connman.net

[PATCH 1/5] service: Whitespace fixes

2014-12-01 Thread Patrik Flykt
--- src/service.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 87a2f2c..9644c8e 100644 --- a/src/service.c +++ b/src/service.c @@ -5732,9 +5732,9 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,

[PATCH 3/5] ipconfig: Define unique value for CONNMAN_IPCONFIG_TYPE_ALL

2014-12-01 Thread Patrik Flykt
Make a distinction between all and unknown ipconfig type values. As a result Update the code to handle CONNMAN_IPCONFIG_TYPE_ALL in switch statements. As the unknown and all ipconfig values are now semantically different, modify __connman_service_is_connected_state() to return the combined state

[PATCH 5/5] util: Properly specify length of uint64_t

2014-12-01 Thread Patrik Flykt
--- src/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util.c b/src/util.c index 2d3a7f7..da32cc5 100644 --- a/src/util.c +++ b/src/util.c @@ -45,7 +45,7 @@ int __connman_util_get_random(uint64_t *val) if (!val) return -EINVAL; - if

[PATCH 4/5] gdhcp: Properly specify length of uint64_t

2014-12-01 Thread Patrik Flykt
--- gdhcp/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdhcp/common.c b/gdhcp/common.c index 4a7270b..ae0ecb1 100644 --- a/gdhcp/common.c +++ b/gdhcp/common.c @@ -76,7 +76,7 @@ int dhcp_get_random(uint64_t *val) } } - if

Re: [PATCH 2/2] [connman] inotify: refcount struct connman_inotify

2014-11-24 Thread Patrik Flykt
On Fri, 2014-11-21 at 13:07 +0200, Hannu Mallat wrote: When processing inotify events, callbacks may unregister which can result in freeing the related connman_inotify struct. However that struct is referenced in the loop which processes the events read in. Implement reference counting to

Re: [PATCH v2 0/7] Use /dev/urandom

2014-11-24 Thread Patrik Flykt
On Wed, 2014-11-19 at 12:46 +0200, Patrik Flykt wrote: Hi, Updated the patch set according to comments. If /dev/urandom is not found, fall back to glibc functions. Therefore /dev/urandom is no longer needed at compile time, and the README need not be updated with new requirements

Re: disabling technologies on startup

2014-11-23 Thread Patrik Flykt
Hi, On Fri, 2014-11-21 at 09:30 -0500, Ernast Sevo wrote: Hello, I am attempting to figure out if it is possible to disable wifi/bluetooth/cellular through connman on startup so when system boots those technologies will not be powered until they are explicitly turned on by user.

Re: How to Identify the chosen association type of Wifi AP

2014-11-19 Thread Patrik Flykt
Hi, On Wed, 2014-11-19 at 09:13 +0100, frederic.wo...@continental-corporation.com wrote: Hi All I would like to know if connman agent provides the information to identify the association type of Wifi AP chosen by the user in particular with WPS. AFAIU when starting association to

[PATCH v2 1/7] util: Use proper source for random numbers

2014-11-19 Thread Patrik Flykt
Use /dev/urandom as the proper source for random numbers. Verify the existence of /dev/urandom at compile time and program startup. --- Makefile.am | 2 +- src/connman.h | 4 +++ src/main.c| 2 ++ src/util.c| 88 +++ 4 files

[PATCH v2 6/7] gdhcp: Use dhcp_get_random() where necessary

2014-11-19 Thread Patrik Flykt
Instead of always using the libc rand() function, use the function from the gdhcp common code. With this change the seed value can be omitted from IPv4 link-local code. --- gdhcp/client.c | 23 ++- gdhcp/ipv4ll.c | 23 --- gdhcp/ipv4ll.h | 2 +- 3 files

[PATCH v2 4/7] config: Use the newly provided function for getting random values

2014-11-19 Thread Patrik Flykt
--- src/config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/config.c b/src/config.c index e7d1671..a4c117e 100644 --- a/src/config.c +++ b/src/config.c @@ -1435,12 +1435,14 @@ static void generate_random_string(char *str, int length) { uint8_t val;

[PATCH v2 2/7] dnsproxy: Use the newly provided function for getting random values

2014-11-19 Thread Patrik Flykt
--- src/dnsproxy.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index bdd7fd5..7562067 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -218,7 +218,11 @@ static GHashTable *partial_tcp_req_table; static guint16 get_id(void) { -

[PATCH v2 3/7] dhcpv6: Use the newly provided function for getting random values

2014-11-19 Thread Patrik Flykt
--- src/dhcpv6.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 5f8029f..c311045 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -107,7 +107,10 @@ static void clear_timer(struct connman_dhcpv6 *dhcp) static inline float

[PATCH v2 7/7] dhcp: Clean up resources initialized by dhcp_get_random()

2014-11-19 Thread Patrik Flykt
--- src/dhcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/dhcp.c b/src/dhcp.c index 505d9f0..841b0c7 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -672,4 +672,6 @@ void __connman_dhcp_cleanup(void) g_hash_table_destroy(ipconfig_table); ipconfig_table = NULL; + +

Re: Connect to a wifi with password without connmanctl

2014-11-19 Thread Patrik Flykt
Have a look at the test scripts in test directory (connman repo), these are in python and sort of easy to read so it should help you to do the same in node-js. In order to solve this, you Stavros need to write the node-js app so that it registers itself with the Agent API to ConnMan and pops

[PATCH v2 5/7] gdhcp: Add a function to fetch random values

2014-11-19 Thread Patrik Flykt
Provide a function for fetching random values, either by reading /dev/urandom or using libc. The caller is responsible for seeding the libc random function prior to use, should a fallback to libc function take place. --- gdhcp/common.c | 41 - gdhcp/gdhcp.h

[PATCH v2 0/7] Use /dev/urandom

2014-11-19 Thread Patrik Flykt
version of the same code for random number usage for the dhcp part. As more code might move under or created in util, I kept the explicit initialization function. Cheers, Patrik Patrik Flykt (7): util: Use proper source for random numbers dnsproxy: Use the newly provided function

Re: Is this a bug? wlan0: deauthenticated (Reason: 6)

2014-11-18 Thread Patrik Flykt
Hi, On Mon, 2014-11-17 at 17:48 -0800, Terry Simons wrote: If the driver is trying to send data frames before it's fully authenticated, you'll see this happen. Basically what happened is my device lost its wifi connection and then never tried reconnecting again. The Reason: 6

Quick, dirty and non-functional shell script

2014-11-18 Thread Patrik Flykt
Hi, Ok, I found my very quick, dirty and non-functional example shell script printing out an ordered list of saved ConnMan services. It most likely won't work properly or at all, so someone should definitely fix it with better shell syntax and usability if considered for any real world

Re: [PATCH 1/5] util: Use proper source for random numbers

2014-11-18 Thread Patrik Flykt
Hi, On Tue, 2014-11-18 at 17:05 +0900, Marcel Holtmann wrote: why not just open /dev/urandom and only if it is not present fallback to C library rand() etc. I mean realistically the device node will be present. That's a fail-safe way of doing this without interrupting anybody

[PATCH 1/5] util: Use proper source for random numbers

2014-11-17 Thread Patrik Flykt
Use /dev/urandom as the proper source for random numbers. Verify the existence of /dev/urandom at compile time and program startup. --- Makefile.am | 2 +- configure.ac | 2 ++ src/connman.h | 4 +++ src/main.c| 4 +++ src/util.c| 79

[PATCH 0/5] Use /dev/urandom

2014-11-17 Thread Patrik Flykt
Hi, This patch set reads /dev/urandom for random numbers replacing the previously used functions. With this /dev/urandom is now needed on the system where ConnMan is running. Cheers, Patrik Patrik Flykt (5): util: Use proper source for random numbers README: Document

[PATCH 5/5] config: Use the newly provided function for getting random values

2014-11-17 Thread Patrik Flykt
--- src/config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/config.c b/src/config.c index e7d1671..a4c117e 100644 --- a/src/config.c +++ b/src/config.c @@ -1435,12 +1435,14 @@ static void generate_random_string(char *str, int length) { uint8_t val;

[PATCH 3/5] dnsproxy: Use the newly provided function for getting random values

2014-11-17 Thread Patrik Flykt
--- src/dnsproxy.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index bdd7fd5..7562067 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -218,7 +218,11 @@ static GHashTable *partial_tcp_req_table; static guint16 get_id(void) { -

[PATCH 2/5] README: Document that /dev/urandom is needed

2014-11-17 Thread Patrik Flykt
--- README | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README b/README index b1367dd..926733d 100644 --- a/README +++ b/README @@ -40,7 +40,8 @@ by using the -I command line option. Compilation and installation -In order to compile

[PATCH 4/5] dhcpv6: Use the newly provided function for getting random values

2014-11-17 Thread Patrik Flykt
--- src/dhcpv6.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 5f8029f..c311045 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -107,7 +107,10 @@ static void clear_timer(struct connman_dhcpv6 *dhcp) static inline float

Re: [PATCH] Fix crash.

2014-11-12 Thread Patrik Flykt
On Wed, 2014-11-12 at 11:18 +0100, Erik Larsson wrote: When browser is requested and users tries to disconnect reply will be NULL. This fix check the reply message before acting on it. Applied, thanks! Modified the commit message a bit so that the root cause of the NULL reply got spelled out

Re: [PATCH] wifi: do not start autoscan while connected

2014-11-11 Thread Patrik Flykt
On Mon, 2014-11-10 at 07:44 -0800, Jason Abele wrote: Did this patch get forgotten? I had expected it to show up ahead of my other recent patch Yes, I missed this one. It's applied now. Thanks! Patrik ___ connman mailing list

Re: [PATCH] technology: Set P2P state according to saved and configured values

2014-11-11 Thread Patrik Flykt
On Fri, 2014-10-24 at 14:34 +0300, Patrik Flykt wrote: As the P2P technology does not have any devices or rfkill switches associated with it, unconditionally enable or disable the technology when it is created. When creating the P2P technology, also take the WiFi powered state into account

Re: [PATCH] Fix crash.

2014-11-11 Thread Patrik Flykt
Hi, On Tue, 2014-11-11 at 12:43 +0100, Erik Larsson wrote: When browser is requested and users tries to disconnect reply will be NULL. This fix check the reply message before acting on it. --- src/agent-connman.c | 4 1 file changed, 4 insertions(+) diff --git

Re: Cellular on ConnMan

2014-11-10 Thread Patrik Flykt
Hi, On Thu, 2014-11-06 at 17:54 -0800, nanxi wrote: But why I am seeing ofonod here? Did I miss something? BTW, my connman is 1.11 and Your ConnMan version is way too old, not going to look at any problems coming from such an ancient version. Please upgrade! Cheers, Patrik

Re: [PATCH 1/2] Fix preferred bluetooth role matching.

2014-11-10 Thread Patrik Flykt
On Mon, 2014-11-03 at 23:24 -0600, David Lechner wrote: This fixes an error in the proxy_get_role fuction in commit 6f6927236fc35429eecb1b1459ea5e20ab667db8. The comment was correct as to what we want to accomplish here, however the programming logic did not match what the comment says. Now

Re: [PATCH 2/2] Fix crash when role is NULL.

2014-11-10 Thread Patrik Flykt
On Mon, 2014-11-03 at 23:24 -0600, David Lechner wrote: This fixes a crash that was introduced in commit 6f6927236fc35429eecb1b1459ea5e20ab667db8. It is possible for the role to be NULL, which caused a crash in strcmp. Applied, thanks! There was a missing semicolon, I fixed that in order to

Re: [PATCH] ofono: Fix memory leak

2014-11-10 Thread Patrik Flykt
On Fri, 2014-11-07 at 23:05 +0300, Slava Monich wrote: Free connman_ipaddress prior to allocating the new one. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wifi: scan all channels when connected

2014-11-10 Thread Patrik Flykt
On Fri, 2014-11-07 at 15:14 -0800, Jason Abele wrote: From: Jason Abele ja...@aether.com If the wifi interface is connected and a scan is requested via dbus, only the channels from connectable services will be scanned. This leaves few options to fill out a UI with a fresh list of available

Re: [PATCH] Support connecting to bluetooth GN and PANU roles

2014-11-03 Thread Patrik Flykt
On Wed, 2014-10-29 at 11:52 -0500, David Lechner wrote: Bluetooth PAN specifies three different roles for different types of network connections, PANU, NAP and GN. ConnMan currently supports NAP but ignores the other roles. This patch adds support for the GN and PANU roles so that we can

Re: [PATCH] add netdev support in connman-dbus.conf

2014-10-30 Thread Patrik Flykt
for their networking programs. It would be excellent if this could be incorporated into the upstream connman project. Patrik Flykt advised that I should post the patch inline here, so here it goes: --- connman-dbus.conf 2011-04-18 02:03:56.0 -0700 +++ connman-dbus.conf.diff 2014-10-23 21:37

Re: connman Digest, Vol 69, Issue 24 Unreachable favorite network

2014-10-29 Thread Patrik Flykt
Hi, On Tue, 2014-10-28 at 09:18 -0500, Janakiram Sistla wrote: Can you please let me know if we have an plans to do this or port the below patch from sailfish https://github.com/mer-packages/connman/commit/20ade1463f02fea5d45d77bc75db67ae4008c09e No, we don't have any plans on

Re: [PATCH] Support connecting to bluetooth GN and PANU roles

2014-10-29 Thread Patrik Flykt
Hi, Unfortunately your patch has all its lines ending in ^M and has hard line wrappings in places. Also a few nitpicks below. Could you simply send out the patch with 'git send-email ' ? On Fri, 2014-10-24 at 11:46 -0500, David Lechner wrote: Bluetooth PAN specifies three different

Re: Preconfiguring wired Ethernet interfaces

2014-10-28 Thread Patrik Flykt
On Mon, 2014-10-27 at 09:44 -0500, Ryan Kuester wrote: 1. Discovering the MAC addresses of the two interfaces by external means, that is, not via a connman interface. The 'Ethernet' dict for a service contains the interface MAC address. So once (if) you're on the device, no other tools

Re: connman Digest, Vol 69, Issue 24

2014-10-28 Thread Patrik Flykt
Hi, On Mon, 2014-10-27 at 14:44 -0500, Janakiram Sistla wrote: And what exactly are the problems you are referring to? Do they still happen with ConnMan 1.26 or later? Patrik, I am looking to see if connMan can display favorite and remembered networks even if they are not

Re: Preconfiguring wired Ethernet interfaces

2014-10-28 Thread Patrik Flykt
Hi, On Mon, 2014-10-27 at 14:33 -0500, Ryan Kuester wrote: On Mon, Oct 27, 2014 at 05:07:34PM +0200, Jukka Rissanen wrote: On ma, 2014-10-27 at 09:44 -0500, Ryan Kuester wrote: Hi all, There's a thread[1] from early 2013 which concluded that the way to statically

Re: Unreachable favorite network

2014-10-27 Thread Patrik Flykt
Hi, On Fri, 2014-10-24 at 11:13 -0500, Janakiram Sistla wrote: Hi Patrick/Marcel, I had seen some old mailing threads about adding unreachable favorite network in connman. But i hadn't seen any recent mails about the same. i also see other open sdk like jolla have their work around

Re: disabling p2p

2014-10-24 Thread Patrik Flykt
Hi, On Thu, 2014-10-23 at 11:50 -0400, Ernast Sevo wrote: Hello! I am attempting to disable P2P in connman and have this currently in connman's settings file: . . . [P2P] Enable=false Tethering=false This snippet is correct and should disable/power off P2P. I just verified

[PATCH] technology: Set P2P state according to saved and configured values

2014-10-24 Thread Patrik Flykt
As the P2P technology does not have any devices or rfkill switches associated with it, unconditionally enable or disable the technology when it is created. When creating the P2P technology, also take the WiFi powered state into account. --- src/technology.c | 32 +++-

Re: [PATCH] Add support for PANU and GN roles to Bluetooth.

2014-10-24 Thread Patrik Flykt
Hi, On Thu, 2014-10-23 at 11:28 -0500, David Lechner wrote: On 10/23/2014 05:27 AM, Patrik Flykt wrote: A commit message shedding some light on what this patch tries to do is quite necessary. PANU support is already there, so is this patch about connecting to a GN instead

Re: Fwd: [PATCH 2/2] connman-wait-online.service.in: systemd service that waits for network

2014-10-23 Thread Patrik Flykt
On Thu, 2014-10-23 at 10:23 +0200, Noé RUBINSTEIN wrote: Would that fit as a connmanctl wait command? I'd prefer to have a small standalone binary for this so that connnmanctl (and the wait for connection binary) can be installed independently of each other. Cheers, Patrik

Re: Bridging

2014-10-23 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 18:54 +0200, Anton Voyl wrote: Hello, Is it possible to bridge an interface that is managed by connman (e.g. wlan0) and an interface that is not managed by connman? Does connman provide something like: brctl addbr bridge brctl addif bridge wlan0 brctl

Re: [PATCH] Add support for PANU and GN roles to Bluetooth.

2014-10-23 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 19:30 -0500, David Lechner wrote: --- A commit message shedding some light on what this patch tries to do is quite necessary. PANU support is already there, so is this patch about connecting to a GN instead of a NAP? If this is about tethering, there is not

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

2014-10-23 Thread Patrik Flykt
On Tue, 2014-10-21 at 12:31 -0500, David Lechner wrote: Bluetooth, however, never sent this signal, This is caused because there are two plugins for Bluetooth, one for Bluez 4 and the other one for Bluez 5. Both register a connman_technology_driver. So far so good. The problem is caused by

Re: [PATCH] proxy: remove timeout on proxy cleanup

2014-10-23 Thread Patrik Flykt
On Wed, 2014-10-22 at 12:33 +0300, Hannu Mallat wrote: Make sure the timeout source is cleaned when proxy_lookup struct is deallocated. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

2014-10-22 Thread Patrik Flykt
Hi, On Tue, 2014-10-21 at 12:27 -0500, David Lechner wrote: --- src/connman.h| 1 + src/rfkill.c | 2 ++ src/technology.c | 15 +++ 3 files changed, 18 insertions(+) diff --git a/src/connman.h b/src/connman.h index da01215..bab013b 100644 ---

Re: [PATCH] agent: Check for pointer validity before cancelling agent request

2014-10-22 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 11:09 +0300, Hannu Mallat wrote: In the case where agent disappears from D-Bus while there are pending requests, request-driver may become null. As it's useless to send a Cancel to a nonexistent agent, not to mention accessing null pointer causes a crash,

Re: [PATCH v2] config: Handle IN_MOVED_TO inotify event

2014-10-22 Thread Patrik Flykt
On Tue, 2014-10-21 at 15:59 +0300, Tomasz Bursztyka wrote: If the user moves a .config to /var/lib/connman which happens to be on the same fs, this will raise IN_MOVED_FROM/IN_MOVE_TO inotify events and not IN_DELETE/IN_CREATE. Applied, thanks! Patrik

Re: [PATCH] ipconfig: Fix memory leak

2014-10-21 Thread Patrik Flykt
On Thu, 2014-10-16 at 18:14 +0800, Chengyi Zhao wrote: From: Chengyi Zhao chengyi1.z...@archermind.com Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: Configuration

2014-10-10 Thread Patrik Flykt
Hi, On Fri, 2014-10-10 at 08:52 +, Thiemo van Engelen wrote: So what would be the preferred way? If the problem was that the failure got saved to disk, patch 2/2 in the Don't save or load service failure patch set should do the trick. In addition patch 1/2 removes service failure

Re: [PATCH] gsupplicant: Fix a typo in WPS method configuration

2014-10-10 Thread Patrik Flykt
On Fri, 2014-10-10 at 11:56 +0300, Tomasz Bursztyka wrote: It's push_button, not puth_button... Applied, thansk! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 0/2] Don't save or load service failure

2014-10-10 Thread Patrik Flykt
On Thu, 2014-10-09 at 16:25 +0300, Patrik Flykt wrote: Hi, Applied these two patches. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wifi: Enforce peer disconnection properly

2014-10-10 Thread Patrik Flykt
On Thu, 2014-10-09 at 16:15 +0300, Tomasz Bursztyka wrote: The dedicated wifi interface is not properly reseted. So even if the disconnection went fine, it might still stay on a connecting state in the wifi plugin only. Applied, thanks! Patrik

Re: [PATCH v2 0/2] Peer Service DBus API fixes

2014-10-09 Thread Patrik Flykt
On Thu, 2014-10-09 at 14:25 +0300, Tomasz Bursztyka wrote: DBus content was not matching its signature. Jussi Kukkonen (1): peer: Use correct helper function to append WiFiDisplayIEs Tomasz Bursztyka (1): peer: Append Peer Service content according to the signature What changed in

Re: [PATCH v2 0/2] Peer Service DBus API fixes

2014-10-09 Thread Patrik Flykt
On Thu, 2014-10-09 at 14:25 +0300, Tomasz Bursztyka wrote: DBus content was not matching its signature. Jussi Kukkonen (1): peer: Use correct helper function to append WiFiDisplayIEs Tomasz Bursztyka (1): peer: Append Peer Service content according to the signature Applied both

[PATCH 1/2] service: Don't save or load reason for failure

2014-10-09 Thread Patrik Flykt
Loading the 'Failure' attribute and attempting to set the service state to failure has been applied only to non-favorite services. As non-favorite services need to be connected via D-Bus, there is no change in autoconnect functionality. Also enforcing IPv4 and IPv6 state is wrong, as the

[PATCH 0/2] Don't save or load service failure

2014-10-09 Thread Patrik Flykt
the service error was read from file. This extra check can therefore be removed. These two should fix the bug found by Thiemo van Engelen. Cheers, Patrik Patrik Flykt (2): service: Don't save or load reason for failure service: When connecting, ignore previous invalid key errors src

[PATCH 2/2] service: When connecting, ignore previous invalid key errors

2014-10-09 Thread Patrik Flykt
An invalid key error is indicated from the respective plugin by calling __connman_service_indicate_error() from network.c. That function removes the passphrase used and is detected a few lines earlier before this change. --- src/service.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: Functionality to ignore invalid-key failures

2014-10-08 Thread Patrik Flykt
On Wed, 2014-10-08 at 09:40 +, Thiemo van Engelen wrote: Please comment on the functionality and the patch and what I should do to get this integrated into connman. Should I post it on the mailing list or also send it directly to Patrik (or someone else)? Thanks for pinging. I forgot to

[PATCH] service: Remove a check that cannot happen

2014-10-08 Thread Patrik Flykt
Before calling service_connect(), __connman_service_connet() has cleared any errors the service has had. With that in mind it makes no sense to compare against something that can not happen. --- src/service.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/service.c

Re: [PATCH 0/4] Integrate partially ConnMan with hostnamed

2014-10-07 Thread Patrik Flykt
On Tue, 2014-10-07 at 15:28 +0300, Tomasz Bursztyka wrote: This is meant to get the proper device type. However, future work could integrate better. To set the dynamic hostname for instance... Tomasz Bursztyka (4): machine: Integrate ConnMan with systemd-hostnamed wifi: Revert

Re: [PATCH] manager: Fix an issue when verifying Peer Service parameters

2014-10-07 Thread Patrik Flykt
On Tue, 2014-10-07 at 10:59 +0300, Tomasz Bursztyka wrote: Content of the pointer should be checked, not the pointers themselves. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: [PATCH 0/5 v2] Peer API improvements

2014-10-02 Thread Patrik Flykt
On Wed, 2014-10-01 at 16:25 +0300, Tomasz Bursztyka wrote: v2: rebased against latest trunk, and set PrimaryDeviceType to Computer/PC as a default setting Here are 2 functionalities meant to improve Peer API experience: - patch 1 to 3: this helps to configure a primary and secondary device

Re: [PATCH 0/5] Peer API improvements

2014-10-01 Thread Patrik Flykt
On Thu, 2014-09-18 at 16:17 +0300, Tomasz Bursztyka wrote: Here are 2 functionalities meant to improve Peer API experience: - patch 1 to 3: this helps to configure a primary and secondary device types. Thus you can tell what device (PC-Laptop, Display-Television etc...) you are. - patch 4 and

Re: [PATCH] service: Do not reply via D-Bus when clearing service error

2014-09-30 Thread Patrik Flykt
On Thu, 2014-09-25 at 15:20 +0300, Patrik Flykt wrote: When clearing a service in error state, set both ipconfigs to idle causing the service states in both ipconfig and service to be reset. Save the D-Bus id before setting the service to idle and restore it afterwards so that a possible D-Bus

Re: [PATCH] vpn: Indicating error no longer needs state to be set to failure

2014-09-30 Thread Patrik Flykt
On Fri, 2014-09-26 at 12:10 +0300, Patrik Flykt wrote: Indicating an error will set the states correctly and nowadays properly decides what the state will be. Therefore the extra call setting state to failed is removed. Applied. Patrik

Re: [PATCH] vpn-provider: Properly set VPN connection state on failure

2014-09-30 Thread Patrik Flykt
On Fri, 2014-09-26 at 12:09 +0300, Patrik Flykt wrote: Since the net.connman.vpn.Agent RequestInput D-Bus method call is used to fetch fresh credentials from the user, set the VPN connection state to idle after VPN authetication or login error. Other VPN errors will keep the VPN connection

Re: [PATCH 0/3] Some memory issue fixes

2014-09-30 Thread Patrik Flykt
On Mon, 2014-09-29 at 09:19 +0300, Hannu Mallat wrote: Some fixes to memory issues I've encountered in testing, please review. These have all come up when testing connecting to and disconnecting from different networks while restarting wpa_supplicant and/or reloading wlan kernel module in

Re: [PATCH] ofono: Bring device attached to modem down and up if IMSI has really changed

2014-09-30 Thread Patrik Flykt
Hi, On Mon, 2014-09-29 at 11:20 +0300, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com Bringing the device down when the IMSI is really changed will force the service have correct identifier and not to use the old one (eg. when SIM- card is changed).

Re: [PATCH 04/14] client: Support basic WiFi Display IEs (un)registration

2014-09-30 Thread Patrik Flykt
Hi, On Mon, 2014-09-29 at 15:19 +0300, Tomasz Bursztyka wrote: @@ -2280,13 +2304,27 @@ static int cmd_peer_service(char *args[], int num, { unsigned char bjr_query[1024] = {}; unsigned char bjr_response[1024] = {}; + unsigned char wfd_ies[1024] = {};

Re: [PATCH v2 00/14] Support for WiFi Display as a Peer Service

2014-09-30 Thread Patrik Flykt
On Mon, 2014-09-29 at 15:19 +0300, Tomasz Bursztyka wrote: Now that wpa_supplicant supports setting the WFD through DBus API, I am resending this patch-set, rebased against latest ConnMan's master branch. Tomasz Bursztyka (14): gsupplicant: Add a callback enabled setter for the WFD IEs

Re: [PATCH 0/4] Handle PeerServiceRegister master parameter

2014-09-30 Thread Patrik Flykt
On Tue, 2014-09-30 at 13:41 +0300, Tomasz Bursztyka wrote: When set, the go intent will be set to a high value ensuring that it advertizes it's will to be the GO when negocating about it. All patches applied, thanks! Patrik ___ connman

Re: [PATCH v2] gdhcp: Workaround for buggy AP that handle broadcast flag incorrectly

2014-09-30 Thread Patrik Flykt
On Wed, 2014-09-24 at 11:18 +0300, Jukka Rissanen wrote: Some routers/AP handle the DHCP broadcast flag incorrectly. This means that some AP discard the DHCP packet if broadcast flag is present and some discard it if broadcast flag is missing. The workaround is to first send DISCOVER packet

[PATCH] service: Do not reply via D-Bus when clearing service error

2014-09-25 Thread Patrik Flykt
When clearing a service in error state, set both ipconfigs to idle causing the service states in both ipconfig and service to be reset. Save the D-Bus id before setting the service to idle and restore it afterwards so that a possible D-Bus client won't be informed of a connection error which

[PATCH] openconnect: Remove authentication tokens also on connect error

2014-09-25 Thread Patrik Flykt
The openconnect program will exit with a value of 1 not only when there was a network error, but also when erroneous authentication information is given. Therefore indicate authentication error also in this case causing the authentication information to be cleaned up. ---

Re: [PATCH] service: Fix compiler old_state warning

2014-09-24 Thread Patrik Flykt
Hi, On Mon, 2014-09-15 at 16:19 +0200, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com CC src/src_connmand-service.o src/service.c: In function ‘__connman_service_ipconfig_indicate_state’: src/service.c:5771:13: warning: ‘old_state’ may be used

Re: [PATCH] Fix fallback nameservers harder

2014-09-24 Thread Patrik Flykt
Hi, On Wed, 2014-09-17 at 15:28 +0300, Jukka Rissanen wrote: From: Andreas Hartmetz ahartm...@gmail.com - Make sure to insert them with the enabled flag set. No need to touch the flag afterwards. When they are not supposed to be used, they are removed entirely anyway. Once

Re: [PATCH] connection: Set default gateway for a type if not active

2014-09-24 Thread Patrik Flykt
On Tue, 2014-09-23 at 11:56 +0530, Saurav Babu wrote: In Dual Network where both IPv4 and IPv6 networks are available, gateway address should be set for both network types. Currently in following scenario: - Gateway Address for IPv6 is already available - IPv4 gateway address is obtained

Re: Make connman ignore wildcard interfaces

2014-09-24 Thread Patrik Flykt
On Tue, 2014-09-23 at 19:19 -0300, Vinícius Costa Gomes wrote: Ideally I would have connman ignore both the docker0 interface and the individual veth* interfaces - but the connmand -I option doesn't seem to support wildcards. Any ideas? From the manpage connman.conf(5), seems that

Re: Issue doing Connect on a failed service

2014-09-24 Thread Patrik Flykt
Hi, On Wed, 2014-09-17 at 15:30 +0200, Richard Röjfors wrote: Hi, Currently there is an issue in connman when Connect is issued for a failed service. 1. In connect service the incoming DBusMessage is assigned to service-pending. 2. __connman_service_connect is called which

Re: [PATCH 0/4] Misc DHCPv4 patches

2014-09-22 Thread Patrik Flykt
On Wed, 2014-09-17 at 15:16 +0300, Jukka Rissanen wrote: Jukka Rissanen (4): gdhcp: Transaction id was not set when receiving L2 packet gdhcp: Transaction id is in network byte order gdhcp: Fix memory leak when clearing option hash Applied patches 1-3/4, thanks! Patrik

<    1   2   3   4   5   6   7   8   9   10   >