Re: [PATCH] wifi: do not start autoscan while connected

2014-11-11 Thread Patrik Flykt
On Mon, 2014-11-10 at 07:44 -0800, Jason Abele wrote: > Did this patch get forgotten? > > I had expected it to show up ahead of my other recent patch Yes, I missed this one. It's applied now. Thanks! Patrik ___ connman mailing list connman@con

Re: [PATCH] ofono: Fix memory leak

2014-11-10 Thread Patrik Flykt
On Fri, 2014-11-07 at 23:05 +0300, Slava Monich wrote: > Free connman_ipaddress prior to allocating the new one. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wifi: scan all channels when connected

2014-11-10 Thread Patrik Flykt
On Fri, 2014-11-07 at 15:14 -0800, Jason Abele wrote: > From: Jason Abele > > If the wifi interface is connected and a scan is requested via dbus, > only the channels from connectable services will be scanned. This > leaves few options to fill out a UI with a fresh list of available > services w

Re: [PATCH 2/2] Fix crash when role is NULL.

2014-11-10 Thread Patrik Flykt
On Mon, 2014-11-03 at 23:24 -0600, David Lechner wrote: > This fixes a crash that was introduced in commit > 6f6927236fc35429eecb1b1459ea5e20ab667db8. It is possible for the role > to be NULL, which caused a crash in strcmp. Applied, thanks! There was a missing semicolon, I fixed that in order to

Re: [PATCH 1/2] Fix preferred bluetooth role matching.

2014-11-10 Thread Patrik Flykt
On Mon, 2014-11-03 at 23:24 -0600, David Lechner wrote: > This fixes an error in the proxy_get_role fuction in commit > 6f6927236fc35429eecb1b1459ea5e20ab667db8. > > The comment was correct as to what we want to accomplish here, however the > programming logic did not match what the comment says.

Re: Cellular on ConnMan

2014-11-10 Thread Patrik Flykt
Hi, On Thu, 2014-11-06 at 17:54 -0800, nanxi wrote: > But why I am seeing ofonod here? Did I miss something? > BTW, my connman is 1.11 and Your ConnMan version is way too old, not going to look at any problems coming from such an ancient version. Please upgrade! Cheers, Patri

Re: [PATCH] Support connecting to bluetooth GN and PANU roles

2014-11-03 Thread Patrik Flykt
On Wed, 2014-10-29 at 11:52 -0500, David Lechner wrote: > Bluetooth PAN specifies three different roles for different types of > network connections, PANU, NAP and GN. ConnMan currently supports NAP > but ignores the other roles. This patch adds support for the GN and > PANU roles so that we can co

Re: [PATCH] add netdev support in connman-dbus.conf

2014-10-30 Thread Patrik Flykt
group for their networking > programs. It would be excellent if this could be incorporated into the > upstream connman project. Patrik Flykt advised that I should post the > patch inline here, so here it goes: > > > --- connman-dbus.conf 2011-04-18 02:03:56.0 -0700 > +++

Re: [PATCH] Support connecting to bluetooth GN and PANU roles

2014-10-29 Thread Patrik Flykt
Hi, Unfortunately your patch has all its lines ending in ^M and has hard line wrappings in places. Also a few nitpicks below. Could you simply send out the patch with 'git send-email ' ? On Fri, 2014-10-24 at 11:46 -0500, David Lechner wrote: > Bluetooth PAN specifies three different

Re: connman Digest, Vol 69, Issue 24 Unreachable favorite network

2014-10-29 Thread Patrik Flykt
Hi, On Tue, 2014-10-28 at 09:18 -0500, Janakiram Sistla wrote: > Can you please let me know if we have an plans to do this or port the > below patch from sailfish > > https://github.com/mer-packages/connman/commit/20ade1463f02fea5d45d77bc75db67ae4008c09e No, we don't have any plans on t

Re: Preconfiguring wired Ethernet interfaces

2014-10-28 Thread Patrik Flykt
Hi, On Mon, 2014-10-27 at 14:33 -0500, Ryan Kuester wrote: > On Mon, Oct 27, 2014 at 05:07:34PM +0200, Jukka Rissanen wrote: > > On ma, 2014-10-27 at 09:44 -0500, Ryan Kuester wrote: > > > Hi all, > > > > > > There's a thread[1] from early 2013 which concluded that the way to > > > stati

Re: connman Digest, Vol 69, Issue 24

2014-10-28 Thread Patrik Flykt
Hi, On Mon, 2014-10-27 at 14:44 -0500, Janakiram Sistla wrote: > > And what exactly are the problems you are referring to? Do they > > still happen with ConnMan 1.26 or later? > Patrik, I am looking to see if connMan can display favorite and > remembered networks even if they are not rea

Re: Preconfiguring wired Ethernet interfaces

2014-10-28 Thread Patrik Flykt
On Mon, 2014-10-27 at 09:44 -0500, Ryan Kuester wrote: >1. Discovering the MAC addresses of the two interfaces by external > means, that is, not via a connman interface. The 'Ethernet' dict for a service contains the interface MAC address. So once (if) you're on the device, no other tool

Re: Unreachable favorite network

2014-10-26 Thread Patrik Flykt
Hi, On Fri, 2014-10-24 at 11:13 -0500, Janakiram Sistla wrote: > Hi Patrick/Marcel, > > I had seen some old mailing threads about adding unreachable favorite > network in connman. But i hadn't seen any recent mails about the same. i > also see other open sdk like jolla have their work ar

Re: [PATCH] Add support for PANU and GN roles to Bluetooth.

2014-10-24 Thread Patrik Flykt
Hi, On Thu, 2014-10-23 at 11:28 -0500, David Lechner wrote: > On 10/23/2014 05:27 AM, Patrik Flykt wrote: > > A commit message shedding some light on what this patch tries to do is > > quite necessary. PANU support is already there, so is this patch about > > conne

[PATCH] technology: Set P2P state according to saved and configured values

2014-10-24 Thread Patrik Flykt
As the P2P technology does not have any devices or rfkill switches associated with it, unconditionally enable or disable the technology when it is created. When creating the P2P technology, also take the WiFi powered state into account. --- src/technology.c | 32 +++- 1

Re: disabling p2p

2014-10-23 Thread Patrik Flykt
Hi, On Thu, 2014-10-23 at 11:50 -0400, Ernast Sevo wrote: > Hello! > > I am attempting to disable P2P in connman and have this currently in > connman's settings file: > > . > . > . > [P2P] > Enable=false > Tethering=false This snippet is correct and should disable/power off P2P. I jus

Re: [PATCH] proxy: remove timeout on proxy cleanup

2014-10-23 Thread Patrik Flykt
On Wed, 2014-10-22 at 12:33 +0300, Hannu Mallat wrote: > Make sure the timeout source is cleaned when proxy_lookup struct is > deallocated. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/l

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

2014-10-23 Thread Patrik Flykt
On Tue, 2014-10-21 at 12:31 -0500, David Lechner wrote: > Bluetooth, however, never sent this signal, This is caused because there are two plugins for Bluetooth, one for Bluez 4 and the other one for Bluez 5. Both register a connman_technology_driver. So far so good. The problem is caused by tech

Re: [PATCH] Add support for PANU and GN roles to Bluetooth.

2014-10-23 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 19:30 -0500, David Lechner wrote: > --- A commit message shedding some light on what this patch tries to do is quite necessary. PANU support is already there, so is this patch about connecting to a GN instead of a NAP? If this is about tethering, there is not mu

Re: Bridging

2014-10-23 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 18:54 +0200, Anton Voyl wrote: > Hello, > > Is it possible to bridge an interface that is managed by connman (e.g. > wlan0) and an interface that is not managed by connman? > > Does connman provide something like: > brctl addbr bridge > brctl addif bridge wlan0

Re: Fwd: [PATCH 2/2] connman-wait-online.service.in: systemd service that waits for network

2014-10-23 Thread Patrik Flykt
On Thu, 2014-10-23 at 10:23 +0200, Noé RUBINSTEIN wrote: > Would that fit as a "connmanctl wait" command? I'd prefer to have a small standalone binary for this so that connnmanctl (and the wait for connection binary) can be installed independently of each other. Cheers, Patrik

Re: [PATCH 2/2] connman-wait-online.service.in: systemd service that waits for network

2014-10-22 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 11:21 +0200, Noé Rubinstein wrote: > Create a systemd service that uses test/wait-for-ready to wait for any > interface to be in the 'ready' or 'online' state. This service will be > pulled by network-online.target. > > This is similar to NetworkManager-wait-onl

Re: [PATCH v2] config: Handle IN_MOVED_TO inotify event

2014-10-22 Thread Patrik Flykt
On Tue, 2014-10-21 at 15:59 +0300, Tomasz Bursztyka wrote: > If the user moves a .config to /var/lib/connman which happens to be on > the same fs, this will raise IN_MOVED_FROM/IN_MOVE_TO inotify events > and not IN_DELETE/IN_CREATE. Applied, thanks! Patrik __

Re: [PATCH] agent: Check for pointer validity before cancelling agent request

2014-10-22 Thread Patrik Flykt
Hi, On Wed, 2014-10-22 at 11:09 +0300, Hannu Mallat wrote: > In the case where agent disappears from D-Bus while there are pending > requests, request->driver may become null. As it's useless to send a > Cancel to a nonexistent agent, not to mention accessing null pointer > causes a crash

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

2014-10-22 Thread Patrik Flykt
Hi, On Tue, 2014-10-21 at 12:31 -0500, David Lechner wrote: > I have written a UI for connman an ran into an bug when restarting > connman. When restarting, most technologies send the TechnologyRemoved > signal via DBus. Bluetooth, however, never sent this signal, so when > connman res

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

2014-10-22 Thread Patrik Flykt
Hi, On Tue, 2014-10-21 at 12:27 -0500, David Lechner wrote: > --- > src/connman.h| 1 + > src/rfkill.c | 2 ++ > src/technology.c | 15 +++ > 3 files changed, 18 insertions(+) > > diff --git a/src/connman.h b/src/connman.h > index da01215..bab013b 100644 > ---

Re: [PATCH] ipconfig: Fix memory leak

2014-10-21 Thread Patrik Flykt
On Thu, 2014-10-16 at 18:14 +0800, Chengyi Zhao wrote: > From: Chengyi Zhao Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wifi: Enforce peer disconnection properly

2014-10-10 Thread Patrik Flykt
On Thu, 2014-10-09 at 16:15 +0300, Tomasz Bursztyka wrote: > The dedicated wifi interface is not properly reseted. So even if the > disconnection went fine, it might still stay on a connecting state in > the wifi plugin only. Applied, thanks! Patrik __

Re: [PATCH 0/2] Don't save or load service failure

2014-10-10 Thread Patrik Flykt
On Thu, 2014-10-09 at 16:25 +0300, Patrik Flykt wrote: > Hi, Applied these two patches. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Fix a typo in WPS method configuration

2014-10-10 Thread Patrik Flykt
On Fri, 2014-10-10 at 11:56 +0300, Tomasz Bursztyka wrote: > It's push_button, not puth_button... Applied, thansk! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: Configuration

2014-10-10 Thread Patrik Flykt
On Fri, 2014-10-10 at 10:55 +, Thiemo van Engelen wrote: > The second "problem" is that I do not really like the idea of connman > relying on the autoscan and flush behaviour of wpa_supplicant for a > service to be removed after some time, and with it any failure > associated with it. > The ide

Re: Configuration

2014-10-10 Thread Patrik Flykt
Hi, On Fri, 2014-10-10 at 08:52 +, Thiemo van Engelen wrote: > So what would be the preferred way? If the problem was that the failure got saved to disk, patch 2/2 in the "Don't save or load service failure" patch set should do the trick. In addition patch 1/2 removes service failure

[PATCH 2/2] service: When connecting, ignore previous invalid key errors

2014-10-09 Thread Patrik Flykt
An invalid key error is indicated from the respective plugin by calling __connman_service_indicate_error() from network.c. That function removes the passphrase used and is detected a few lines earlier before this change. --- src/service.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH 0/2] Don't save or load service failure

2014-10-09 Thread Patrik Flykt
to the cases where the service error was read from file. This extra check can therefore be removed. These two should fix the bug found by Thiemo van Engelen. Cheers, Patrik Patrik Flykt (2): service: Don't save or load reason for failure service: When connecting, ignore previ

[PATCH 1/2] service: Don't save or load reason for failure

2014-10-09 Thread Patrik Flykt
Loading the 'Failure' attribute and attempting to set the service state to failure has been applied only to non-favorite services. As non-favorite services need to be connected via D-Bus, there is no change in autoconnect functionality. Also enforcing IPv4 and IPv6 state is wrong, as the respectiv

Re: [PATCH v2 0/2] Peer Service DBus API fixes

2014-10-09 Thread Patrik Flykt
On Thu, 2014-10-09 at 14:25 +0300, Tomasz Bursztyka wrote: > DBus content was not matching its signature. > > Jussi Kukkonen (1): > peer: Use correct helper function to append WiFiDisplayIEs > > Tomasz Bursztyka (1): > peer: Append Peer Service content according to the signature Applied both

Re: [PATCH v2 0/2] Peer Service DBus API fixes

2014-10-09 Thread Patrik Flykt
On Thu, 2014-10-09 at 14:25 +0300, Tomasz Bursztyka wrote: > DBus content was not matching its signature. > > Jussi Kukkonen (1): > peer: Use correct helper function to append WiFiDisplayIEs > > Tomasz Bursztyka (1): > peer: Append Peer Service content according to the signature What changed

[PATCH] service: Remove a check that cannot happen

2014-10-08 Thread Patrik Flykt
Before calling service_connect(), __connman_service_connet() has cleared any errors the service has had. With that in mind it makes no sense to compare against something that can not happen. --- src/service.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/service.c b/

Re: Functionality to ignore invalid-key failures

2014-10-08 Thread Patrik Flykt
On Wed, 2014-10-08 at 09:40 +, Thiemo van Engelen wrote: > > Please comment on the functionality and the patch and what I should do > to get this integrated into connman. Should I post it on the mailing > list or also send it directly to Patrik (or someone else)? Thanks for pinging. I forgot

Re: [PATCH] manager: Fix an issue when verifying Peer Service parameters

2014-10-07 Thread Patrik Flykt
On Tue, 2014-10-07 at 10:59 +0300, Tomasz Bursztyka wrote: > Content of the pointer should be checked, not the pointers themselves. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/

Re: [PATCH] gsupplicant: Configure device with WPS PBC method only

2014-10-07 Thread Patrik Flykt
On Mon, 2014-10-06 at 10:47 +0300, Tomasz Bursztyka wrote: > Thus incoming connection will not try to use WPS PIN method. This > enforces connman to support only WPS PBC on incoming connection. Applied, thanks! Patrik ___ connman mailing list c

Re: [PATCH 0/4] Integrate partially ConnMan with hostnamed

2014-10-07 Thread Patrik Flykt
On Tue, 2014-10-07 at 15:28 +0300, Tomasz Bursztyka wrote: > This is meant to get the proper device type. > > However, future work could integrate better. To set the dynamic hostname for > instance... > > Tomasz Bursztyka (4): > machine: Integrate ConnMan with systemd-hostnamed > wifi: Rever

Re: [PATCH 0/5 v2] Peer API improvements

2014-10-02 Thread Patrik Flykt
On Wed, 2014-10-01 at 16:25 +0300, Tomasz Bursztyka wrote: > v2: rebased against latest trunk, and set PrimaryDeviceType to Computer/PC > as a default setting > > Here are 2 functionalities meant to improve Peer API experience: > - patch 1 to 3: this helps to configure a primary and secondary devi

Re: [PATCH 0/5] Peer API improvements

2014-10-01 Thread Patrik Flykt
On Thu, 2014-09-18 at 16:17 +0300, Tomasz Bursztyka wrote: > Here are 2 functionalities meant to improve Peer API experience: > - patch 1 to 3: this helps to configure a primary and secondary device > types. Thus you can tell what device (PC-Laptop, Display-Television etc...) > you are. > - patch 4

Re: [PATCH v2] gdhcp: Workaround for buggy AP that handle broadcast flag incorrectly

2014-09-30 Thread Patrik Flykt
On Wed, 2014-09-24 at 11:18 +0300, Jukka Rissanen wrote: > Some routers/AP handle the DHCP broadcast flag incorrectly. > This means that some AP discard the DHCP packet if broadcast > flag is present and some discard it if broadcast flag is missing. > > The workaround is to first send DISCOVER pac

Re: [PATCH 0/4] Handle PeerServiceRegister master parameter

2014-09-30 Thread Patrik Flykt
On Tue, 2014-09-30 at 13:41 +0300, Tomasz Bursztyka wrote: > When set, the go intent will be set to a high value ensuring that > it advertizes it's will to be the GO when negocating about it. All patches applied, thanks! Patrik ___ connman mail

Re: [PATCH v2 00/14] Support for WiFi Display as a Peer Service

2014-09-30 Thread Patrik Flykt
On Mon, 2014-09-29 at 15:19 +0300, Tomasz Bursztyka wrote: > Now that wpa_supplicant supports setting the WFD through DBus API, > I am resending this patch-set, rebased against latest ConnMan's master branch. > > Tomasz Bursztyka (14): > gsupplicant: Add a callback enabled setter for the WFD IEs

Re: [PATCH 04/14] client: Support basic WiFi Display IEs (un)registration

2014-09-30 Thread Patrik Flykt
Hi, On Mon, 2014-09-29 at 15:19 +0300, Tomasz Bursztyka wrote: > @@ -2280,13 +2304,27 @@ static int cmd_peer_service(char *args[], int > num, > { > unsigned char bjr_query[1024] = {}; > unsigned char bjr_response[1024] = {}; > + unsigned char wfd_ies[1024] = {}; >

Re: [PATCH] ofono: Bring device attached to modem down and up if IMSI has really changed

2014-09-30 Thread Patrik Flykt
Hi, On Mon, 2014-09-29 at 11:20 +0300, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > Bringing the device down when the IMSI is really changed will force the > service have correct identifier and not to use the old one (eg. when SIM- > card is changed). > --- > plugins/ofono.c

Re: [PATCH 0/3] Some memory issue fixes

2014-09-30 Thread Patrik Flykt
On Mon, 2014-09-29 at 09:19 +0300, Hannu Mallat wrote: > Some fixes to memory issues I've encountered in testing, please review. > > These have all come up when testing connecting to and disconnecting > from different networks while restarting wpa_supplicant and/or > reloading wlan kernel module

Re: [PATCH] openconnect: Remove authentication tokens also on connect error

2014-09-30 Thread Patrik Flykt
On Thu, 2014-09-25 at 15:20 +0300, Patrik Flykt wrote: > The openconnect program will exit with a value of 1 not only when there was > a network error, but also when erroneous authentication information is > given. Therefore indicate authentication error also in this case caus

Re: [PATCH] vpn-provider: Properly set VPN connection state on failure

2014-09-30 Thread Patrik Flykt
On Fri, 2014-09-26 at 12:09 +0300, Patrik Flykt wrote: > Since the net.connman.vpn.Agent RequestInput D-Bus method call is used > to fetch fresh credentials from the user, set the VPN connection state > to idle after VPN authetication or login error. Other VPN errors will > keep the VP

Re: [PATCH] vpn: Indicating error no longer needs state to be set to failure

2014-09-30 Thread Patrik Flykt
On Fri, 2014-09-26 at 12:10 +0300, Patrik Flykt wrote: > Indicating an error will set the states correctly and nowadays properly > decides what the state will be. Therefore the extra call setting state > to failed is removed. Applied.

Re: [PATCH] service: Do not reply via D-Bus when clearing service error

2014-09-30 Thread Patrik Flykt
On Thu, 2014-09-25 at 15:20 +0300, Patrik Flykt wrote: > When clearing a service in error state, set both ipconfigs to idle causing > the service states in both ipconfig and service to be reset. Save the > D-Bus id before setting the service to idle and restore it afterwards so > that

[PATCH] vpn-provider: Properly set VPN connection state on failure

2014-09-26 Thread Patrik Flykt
Since the net.connman.vpn.Agent RequestInput D-Bus method call is used to fetch fresh credentials from the user, set the VPN connection state to idle after VPN authetication or login error. Other VPN errors will keep the VPN connection in failure state. Fix the code to allow the state to be set to

[PATCH] vpn: Indicating error no longer needs state to be set to failure

2014-09-26 Thread Patrik Flykt
Indicating an error will set the states correctly and nowadays properly decides what the state will be. Therefore the extra call setting state to failed is removed. --- vpn/plugins/vpn.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c index a1c5f18..b438d

[PATCH] service: Do not reply via D-Bus when clearing service error

2014-09-25 Thread Patrik Flykt
When clearing a service in error state, set both ipconfigs to idle causing the service states in both ipconfig and service to be reset. Save the D-Bus id before setting the service to idle and restore it afterwards so that a possible D-Bus client won't be informed of a connection error which actual

[PATCH] openconnect: Remove authentication tokens also on connect error

2014-09-25 Thread Patrik Flykt
The openconnect program will exit with a value of 1 not only when there was a network error, but also when erroneous authentication information is given. Therefore indicate authentication error also in this case causing the authentication information to be cleaned up. --- vpn/plugins/openconnect.c

Re: Issue doing Connect on a failed service

2014-09-24 Thread Patrik Flykt
Hi, On Wed, 2014-09-17 at 15:30 +0200, Richard Röjfors wrote: > Hi, > > Currently there is an issue in connman when Connect is issued for a failed > service. > > 1. > In connect service the incoming DBusMessage is assigned to service->pending. > > 2. > __connman_service_connect is call

Re: Make connman ignore wildcard interfaces

2014-09-24 Thread Patrik Flykt
On Tue, 2014-09-23 at 19:19 -0300, Vinícius Costa Gomes wrote: > > Ideally I would have connman ignore both the docker0 interface and > > the individual veth* interfaces - but the connmand "-I" option > > doesn't seem to support wildcards. > > > > Any ideas? > > From the manpage connman.conf(5), s

Re: [PATCH] connection: Set default gateway for a type if not active

2014-09-24 Thread Patrik Flykt
On Tue, 2014-09-23 at 11:56 +0530, Saurav Babu wrote: > In Dual Network where both IPv4 and IPv6 networks are available, > gateway address should be set for both network types. > Currently in following scenario: > - Gateway Address for IPv6 is already available > - IPv4 gateway address is obtained

Re: [PATCH] Fix fallback nameservers harder

2014-09-24 Thread Patrik Flykt
Hi, On Wed, 2014-09-17 at 15:28 +0300, Jukka Rissanen wrote: > From: Andreas Hartmetz > > - Make sure to insert them with the enabled flag set. No need to > touch the flag afterwards. When they are not supposed to be used, > they are removed entirely anyway. Once upon a time the fa

Re: [PATCH] service: Fix compiler old_state warning

2014-09-24 Thread Patrik Flykt
Hi, On Mon, 2014-09-15 at 16:19 +0200, Peter Meerwald wrote: > From: Peter Meerwald > > CC src/src_connmand-service.o > src/service.c: In function ‘__connman_service_ipconfig_indicate_state’: > src/service.c:5771:13: warning: ‘old_state’ may be used uninitialized in this > functi

Re: [PATCH] doc: Fix typo in session-overview.txt

2014-09-22 Thread Patrik Flykt
On Mon, 2014-09-22 at 11:40 +0200, Peter Meerwald wrote: > From: Peter Meerwald Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] doc: Fix typos in session-policy-format.txt

2014-09-22 Thread Patrik Flykt
On Mon, 2014-09-22 at 12:17 +0200, Peter Meerwald wrote: > From: Peter Meerwald Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 0/4] Misc DHCPv4 patches

2014-09-22 Thread Patrik Flykt
On Wed, 2014-09-17 at 15:16 +0300, Jukka Rissanen wrote: > Jukka Rissanen (4): > gdhcp: Transaction id was not set when receiving L2 packet > gdhcp: Transaction id is in network byte order > gdhcp: Fix memory leak when clearing option hash Applied patches 1-3/4, thanks! Patrik ___

Re: [PATCH 0/2] dnsproxy: Check whether cache cleanup needs to be scheduled

2014-09-18 Thread Patrik Flykt
On Wed, 2014-09-17 at 14:22 +0300, Hannu Mallat wrote: > One more reworking: unit test needs a few more stubs when compiling > without optimization. > > Hannu Mallat (2): > dnsproxy: Check whether cache cleanup needs to be scheduled I applied only patch 1/2 as it wasn't really clear from runnin

Re: [PATCH] manager: Do not recurse one more level for upnp basic type

2014-09-18 Thread Patrik Flykt
On Tue, 2014-09-16 at 08:48 -0400, Eduardo Abinader wrote: > Just recurse one more level for the byte array that > corresponds to bonjour data and not for the variant holding > upnp data. This patch prevents a segmentation fault > occuring by dereferencing null upnp data. Applied, thanks!

Re: [PATCH v2 0/3] Peer service registration fixes

2014-09-18 Thread Patrik Flykt
On Wed, 2014-09-17 at 08:27 -0400, Eduardo Abinader wrote: > This set aims to solve observed issues during peer service > register and unregister scenarios. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.conn

Re: [PATCH] timeserver: Cleanup comments and clarify debug message

2014-09-18 Thread Patrik Flykt
On Mon, 2014-09-15 at 17:03 +0200, Peter Meerwald wrote: > From: Peter Meerwald > > Signed-off-by: Peter Meerwald Applied, thanks! As we have a "flat" contributor structure in ConnMan, the Author field already records the developer information for each patch. Thus we haven't needed signed-off-

Re: Connman behavior with marginally stabe wifi

2014-09-18 Thread Patrik Flykt
Hi, On Thu, 2014-09-18 at 08:57 +, Thiemo van Engelen wrote: > We however have problems with the wifi connection, especially when it > is installed such that the wifi connection is marginally stable (and > there is no ethernet connection) > What we see is that when the connection is d

Re: Using connman to 'monitor' while tethering

2014-09-18 Thread Patrik Flykt
Hi, On Thu, 2014-09-18 at 12:24 +0200, Olliver Schinagl wrote: > Well our specific use-case is, that a device is in 'listening' mode as > an Accesspoint, a device connects to it (first use wizard like thing) > to setup the local network. The the app then via dbus tells connman to > stop t

Re: Using connman to 'monitor' while tethering

2014-09-18 Thread Patrik Flykt
Hi, On Thu, 2014-09-18 at 09:27 +0200, Olliver Schinagl wrote: > One thing I have not been able to figure out yet however, if connman is > able to do a wifi scan while it is also running as accesspoint. This depends basically on wpa_supplicant and/or the WiFi device driver. If both of

Re: timeservers get used up

2014-09-16 Thread Patrik Flykt
Hi, On Mon, 2014-09-15 at 17:41 +0200, Peter Meerwald wrote: > Hello Patrik, > > connman builds up available timeservers and keeps them in a list, each > timeservers is tried and used in turn > > if a timeserver fails (not resolvable, not in sync, kiss-of-death), > current timeserver

Re: [PATCH v2] dhcp: Without gateway, the IP is always considered changed when a lease is received

2014-09-15 Thread Patrik Flykt
On Mon, 2014-09-15 at 13:33 +0200, Peter Meerwald wrote: > From: Peter Meerwald > > Connman constantly updates the IP when a lease without gateway is received, > e.g. > connmand[7607]: eth0.42 {del} route 0.0.0.0 gw 0.0.0.0 scope 253 > connmand[7607]: eth0.42 {add} route 0.0.0.0 gw 0.0.0.0 scop

Re: [PATCH] dhcp: Without gateway, the IP is always considered changed when a lease is received

2014-09-15 Thread Patrik Flykt
On Mon, 2014-09-15 at 13:36 +0200, Peter Meerwald wrote: > even though if no gateway is given by DHCP, connman currently adds a > route destination 0.0.0.0 gw 0.0.0.0 -- is this intended? > > maybe this should be addressed by a separate patch... (it doesn't seem > to harm) If there is no gateway,

Re: [PATCH] dhcp: Without gateway, the IP is always considered changed when a lease is received

2014-09-15 Thread Patrik Flykt
On Mon, 2014-09-15 at 12:58 +0200, Peter Meerwald wrote: > > > - else if (!c_address || !c_gateway) > > > - ip_change = true; > > > > Should this also be 'g_strcmp0(...)'? So that if the gateway > changes, > > becomes set or unset, an update is made. > > I don't understand the

Re: [PATCH] service: Enable modified IP configuration only if connected

2014-09-15 Thread Patrik Flykt
On Fri, 2014-09-12 at 16:58 +0300, Patrik Flykt wrote: > After assigning the new ipconfig to the service in question, enable > the new ipconfig only if the service is currently in use, i.e. the > service is connecting or connected. Otherwise the new ipconfig will > be applied to some o

Re: [PATCH] ipconfig: Do not enable or disable IPv6 unconditionally

2014-09-15 Thread Patrik Flykt
On Fri, 2014-09-12 at 15:43 +0300, Patrik Flykt wrote: > When setting an ipconfig it is not known whether the service is in active > use or idling. Therefore enabling or disabling IPv6 cannot happen at this > point. Applied. Patrik __

Re: [PATCH] service: Allow setting a passphrase for provisioned WiFi EAP services

2014-09-15 Thread Patrik Flykt
On Fri, 2014-09-12 at 16:25 +0300, Patrik Flykt wrote: > Allow changing of WiFi EAP passphrases for a provisioned service as they > cannot always be preconfigured. The same applies to WiFi EAP identities, > but there modification was already allowed. Applied, Thomas Green mentioned for

Re: [PATCH 0/2] IPv6 ipconfig fixes

2014-09-15 Thread Patrik Flykt
On Fri, 2014-09-12 at 16:22 +0300, Jukka Rissanen wrote: > Hi, > > IPv6 can be disabled in the kernel side if we switch from one > service to another that use the same network interface (typically > these are wifi services). Patch 2 fixes the issue which was > reported yesterday by Arjuna S. So wh

Re: [PATCH 0/4] Bunch of fixes to stateful dhcpv6/ipv6 related issues

2014-09-15 Thread Patrik Flykt
On Fri, 2014-09-12 at 08:08 +0300, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > 1. last_request needs to be reset to the current time during renew/rebind > or otherwise the lease will be dropped after the initial expiration-value > has been passed. > > 2. dhcpv6 server can set lower va

Re: [PATCH] dhcp: Without gateway, the IP is always considered changed when a lease is received

2014-09-15 Thread Patrik Flykt
Hi, On Thu, 2014-09-11 at 16:14 +0200, Peter Meerwald wrote: > - if (address && c_address && g_strcmp0(address, c_address) != 0) > + if (g_strcmp0(address, c_address) != 0) > ip_change = true; > - else if (gateway && c_gateway && g_strcmp0(gateway, c_gate

Re: Connecting to ieee8021x access point

2014-09-14 Thread Patrik Flykt
On Fri, 2014-09-12 at 14:28 +, Thomas Green wrote: > Patrik, > > The login credentials are different for each person that attaches. > There has to be a configuration file to describe the eap and phase2 > scheme being used, but the first connection still prompts for the > username and passphras

Re: IPv6 being disabled in some scenarios

2014-09-12 Thread Patrik Flykt
Hi, On Thu, 2014-09-11 at 13:04 -0700, Arjuna S wrote: > From my look at the code and enabling debugging, this sequence appears to > be happening: Yes, this sequence is happening. After a day of debugging by Jukka and me, Jukka traced the missing ipconfig down to network.c. Similar to D

[PATCH] service: Enable modified IP configuration only if connected

2014-09-12 Thread Patrik Flykt
After assigning the new ipconfig to the service in question, enable the new ipconfig only if the service is currently in use, i.e. the service is connecting or connected. Otherwise the new ipconfig will be applied to some other service. --- src/service.c | 6 +- 1 file changed, 5 insertions(+)

Re: [PATCH] service: Allow setting a passphrase for provisioned WiFi EAP services

2014-09-12 Thread Patrik Flykt
On Fri, 2014-09-12 at 16:25 +0300, Patrik Flykt wrote: > Thanks to Peter Meerwald for reporting the issue. And that should read Thomas Green. Cheers, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mail

[PATCH] service: Allow setting a passphrase for provisioned WiFi EAP services

2014-09-12 Thread Patrik Flykt
Allow changing of WiFi EAP passphrases for a provisioned service as they cannot always be preconfigured. The same applies to WiFi EAP identities, but there modification was already allowed. Thanks to Peter Meerwald for reporting the issue. --- src/service.c | 6 +- 1 file changed, 5 insertion

[PATCH] ipconfig: Do not enable or disable IPv6 unconditionally

2014-09-12 Thread Patrik Flykt
When setting an ipconfig it is not known whether the service is in active use or idling. Therefore enabling or disabling IPv6 cannot happen at this point. --- src/ipconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index d81a791..ecd

Re: Connecting to ieee8021x access point

2014-09-12 Thread Patrik Flykt
On Thu, 2014-09-11 at 18:58 +, Thomas Green wrote: > All, > > I'm currently running connman 1.21. I'd upgrade if possible. Just looking at the release notes for newer releases I can discover quite a few fixes to DHCP for example. > I am trying to connect to a ieee8021x access point. It nev

Re: [PATCH 1/2] dhcpv6: Do not let rebind and renew go crazy due too low T1 and T2

2014-09-11 Thread Patrik Flykt
On Thu, 2014-09-11 at 10:15 +0300, Patrik Flykt wrote: > The second problem is that ConnMan needs to keep in mind also T2 and > address expiry values. By only checking against T1 it is possible to > construct a case where the server sets T1 to 5 seconds, T2 to 7 > seconds and address

Re: [PATCH 1/2] dhcpv6: Do not let rebind and renew go crazy due too low T1 and T2

2014-09-11 Thread Patrik Flykt
Hi, On Thu, 2014-09-11 at 01:03 +0300, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > Force minimum T1 and T2 to prevent renew and rebind go grazy if > the lease is not getting renew or rebound. > --- > src/dhcpv6.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a

Re: [PATCH] dhcpv6: Remove CONFIRM message sending when connecting a link

2014-09-10 Thread Patrik Flykt
On Wed, 2014-09-10 at 13:10 +0300, Jukka Rissanen wrote: > The CONFIRM message is not sent any more as it does not make much > sense because we do not save address expiration time so we cannot > really know how long the saved address is valid anyway. > > The reply to CONFIRM message does not send

Re: [PATCH v2] service: Reset the IPv6.Privacy to interface default when service is removed

2014-09-10 Thread Patrik Flykt
On Wed, 2014-09-10 at 13:42 +0300, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > As service is removed the IPv6.Privacy needs to be also reset to interface > default (ipdevice->ipv6_privacy). Applied, thanks! Patrik ___ connman mail

Re: agent, route questions with 1.25

2014-09-10 Thread Patrik Flykt
Hi, On Fri, 2014-09-05 at 10:50 -0400, Mike Purvis wrote: > Is there some way to make connman more persistent in trying to achieve a > connection? My perception is that it basically tries once, fails, and then > gives up for good. Unfortunately not. There exists a category of WiFi APs th

Re: [PATCH 0/2] Code cleanup in inet

2014-09-10 Thread Patrik Flykt
On Tue, 2014-09-09 at 23:06 -0400, Eduardo Abinader wrote: > Remove two unused functions in inet. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 0/3] Fix setting of passphrase

2014-09-10 Thread Patrik Flykt
On Tue, 2014-09-09 at 14:29 +0300, Patrik Flykt wrote: > Hi, > > Patch 03 fixes the issue with not being able to set a passphrase when > it is defined in a .config file. The fix is to simply set the immutable > flag after configuring the service. > > In order to co

[PATCH 3/3] config: Set service to immutable after completed configuration

2014-09-09 Thread Patrik Flykt
A service that has been provisioned via other means than NFC is marked immutable and no further modifications are allowed except those specified in __connman_service_load_modifiable(). Setting a service to immutable needs to happen after all necessary configuration is done as generic configuration

[PATCH 0/3] Fix setting of passphrase

2014-09-09 Thread Patrik Flykt
into one place and the literal service type names are replaced with the helper function from service.c. Cheers, Patrik Patrik Flykt (3): config: Refactor checks for configuration file type config: Refactor connecting after service provisioning config: Set service to immutable after

<    2   3   4   5   6   7   8   9   10   11   >