Please review the jpackage fix for bug [1] at [2].
- Fixed code which enumerates folders and files to include empty folders.
- Added EmptyFolderTest.
[1] https://bugs.openjdk.java.net/browse/JDK-8233166
[2] http://cr.openjdk.java.net/~almatvee/8233166/webrev.00/
Thanks,
Alexander
Please review the jpackage fix for bug [1] at [2].
- Updated background image with one which supports retina display.
[1] https://bugs.openjdk.java.net/browse/JDK-8235954
[2] http://cr.openjdk.java.net/~almatvee/8235954/webrev.00/
Thanks,
Alexander
Please review the jpackage fix for bug [1] at [2].
- Fixed by forcing signing even if runtime already signed.
- Original implementation was not taken in consideration that runtime
can be signed (JDK itself is signed from which jpackage is used or
runtime provided via --runtime-image).
-
Please review the jpackage fix for bug [1] at [2].
- Modified customization script for DMG to use location where DMG is
mounted to identify image that we need to customize, instead of using
name which might not be unique.
[1] https://bugs.openjdk.java.net/browse/JDK-8235955
[2]
description in the default overrides.wxi file.
JpIcon is just one of WiX variables to pass configuration data from
jpackage Java into WiX toolset.
- Alexey
On 1/6/2020 7:36 PM, Alexander Matveev wrote:
Hi Alexey,
Can you add description for JpIcon to overrides.wxi, otherwise looks
fine
Looks good.
Thanks,
Alexander
On 12/20/2019 8:56 AM, Andy Herrick wrote:
looks good.
/Andy
On 12/19/2019 8:52 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Comments added to the default WiX source file explaining how the
default file is expected to be overridden.
Looks good.
Thanks,
Alexander
On 12/20/2019 8:53 AM, Andy Herrick wrote:
fix looks fine.
/Andy
On 12/19/2019 8:02 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
The fix changes the default setting for Windows installers to allow
downgrades.
- Alexey
[1]
Hi Alexey,
Can you add description for JpIcon to overrides.wxi, otherwise looks fine.
Thanks,
Alexander
On 12/20/2019 12:16 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Add properties to msi installers to properly display installation
location and icon of the
Looks good.
On 12/16/2019 7:32 AM, Andy Herrick wrote:
Please review this jpackage fix to [1] at [2]
the change just adds quotes around the Argument element's value in WIX
xml's association definition.
[1] https://bugs.openjdk.java.net/browse/JDK-8235915
[2]
by Process or ProcessBuilder , and
although it would be better to identify and resolve the underlying
problem, the fix is needed now, so this change seems appropriate.
/Andy
On 12/13/2019 1:01 AM, Alexander Matveev wrote:
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading o
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading output from "hdiutil attach" was
not exiting immediately after process terminated with delays upto 20
seconds always and in some case upto 10 minutes and thus test was
timeout. Only possible workaround found is
webrev.01 is incorrect, since it uses JTREG_ prefix for variables name.
Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/
It is identical to webrev.01, except prefix of variable names changed to
JT_.
Thanks,
Alexander
On 12/10/19 3:54 PM, Alexander Matveev wrote
Please review fix [2] for jpackage bug [1].
- Changed background image for DMG to TIFF format, which can be used
to embed 2x image to support HiDPI displays.
Thanks,
Alexander
[1] https://bugs.openjdk.java.net/browse/JDK-8234284
[2] http://cr.openjdk.java.net/~almatvee/8234284/webrev.00/
enough here?
-- Jon
On 12/10/19 1:35 PM, Alexander Matveev wrote:
Please review simple script fix [2] for jpackage bug [1].
- Modified script to download jtreg bundle from URL provided by
environment variable JTREG_BUNDLE_URL.
Thanks,
Alexander
[1] https://bugs.openjdk.java.net/browse/JDK
Looks good.
Thanks,
Alexander
On 12/10/2019 12:00 PM, Andy Herrick wrote:
On 12/10/2019 12:56 PM, Andy Herrick wrote:
Please review the jpackage fix at [1] to issue [2].
This is a change to jpackage/internal/IOUtils.copyFile() to
essentially replace it's content with a call to Files.copy()
Please review simple script fix [2] for jpackage bug [1].
- Modified script to download jtreg bundle from URL provided by
environment variable JTREG_BUNDLE_URL.
Thanks,
Alexander
[1] https://bugs.openjdk.java.net/browse/JDK-8235252
[2]
Hi Andy,
Looks good.
Thanks,
Alexander
On 12/9/2019 5:26 PM, Andy Herrick wrote:
On 12/9/2019 6:53 PM, Phil Race wrote:
> [2] http://cr.openjdk.java.net/~herrick/8235601/webrev.01/
This does not bring up the expected webrev
My apologies - I uploaded the wrong webrev - It should be fixed
Looks good.
Thanks,
Alexander
On 12/9/2019 1:42 PM, Andy Herrick wrote:
Please review simple fix [2] for jpackage bug [1]
fixing error message for mutually exclusive options.
/Andy
[1] https://bugs.openjdk.java.net/browse/JDK-8234867
[2]
Looks good, but is there better way to exclude tests on Solaris? I do
not like idea adding @requires for all tests.
Thanks,
Alexander
On 12/6/2019 10:35 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 12/6/2019 1:33 PM, Andy Herrick wrote:
Please review this jpackager test fix for bug
Hi Alexey,
1) Remove this file:
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.rej
2) Agree with Phil, they probably should be pushed as two separate bugs.
3) Do you know how to run installer tests with new changes? It is not
clear from code.
Changes itself looks fine.
Looks good.
On 11/20/2019 6:36 AM, Andy Herrick wrote:
webrev revised in place at [2].
/Andy
On 11/19/2019 9:00 PM, Alexey Semenyuk wrote:
Andy,
I guess
http://cr.openjdk.java.net/~herrick/8234402/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html
can be
Looks good.
On 11/19/19 4:00 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This change restores JPackageToolProvider and gets rid of the
temporary factory class.
[1]
Looks good.
On 11/8/2019 1:31 PM, Andy Herrick wrote:
revised [3] as per below suggestions.
[3] http://cr.openjdk.java.net/~herrick/8233591/webrev.03
/Andy
On 11/8/2019 4:07 PM, Alexey Semenyuk wrote:
This is minor and not directly related to this change, but looks like
we have
Looks good.
On 11/8/2019 11:38 AM, Andy Herrick wrote:
Please review the revised jpackage fix for bug [1] at [3].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This webrev (webrev.03) addresses feedback from previous version
(webrev.02).
[1]
Hi Andy,
Agree with Alexey comments. Otherwise looks good.
Thanks,
Alexander
On 11/7/2019 2:44 PM, Andy Herrick wrote:
On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
I guess the link for the review is
https://cr.openjdk.java.net/~herrick/8233636/webrev.02
sry: yes webrev is
Hi Andy,
http://cr.openjdk.java.net/~herrick/8233594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html
106 \ Pass on --bind-seervices option to jlink (which will
link in \n\
Spelling: --bind-seervices -> --bind-services
Looks good.
On 11/5/2019 12:39 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes the --package-type option to just --type , and adds the
-t short form.
[1]
Hi Alexey,
On 11/1/2019 9:00 PM, Alexey Semenyuk wrote:
On 11/1/2019 9:45 PM, Alexander Matveev wrote:
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html
This file refers
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html
This file refers to JpAllowDowngrades and JpAllowUpgrades. Code sets
JpAllowUpgrades to yes always and never sets JpAllowDowngrades. Maybe I
Looks good.
On 10/31/2019 2:02 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This is a fixes a regression from the fix to JDK-8231882
Looks good.
On 10/31/2019 12:11 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- fixed issue with truncated log output of jtreg tests (added
in
a single test run.
So I'd suggest to remove PackageTest.isCurrentType() at all from
PackageTest class. It is not needed.
- Alexey
On 10/29/2019 1:19 AM, Alexander Matveev wrote:
Changes since last review:
http://cr.openjdk.java.net/~almatvee/8232186/webrev.03/
- Hello.java combined
Looks good.
On 10/30/2019 3:03 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8233143
[2]
Hi Alexey,
Looks good. Did you test it by trying to install into existing folder? I
remember having issues reading some variables in libwixhelper.cpp.
Thanks,
Alexander
On 10/30/2019 1:42 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the
Looks good.
On 10/30/2019 12:48 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8233218
[2]
:07 AM, Andy Herrick wrote:
looks ok to me
/ANdy
On 10/22/2019 5:29 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Removed --mac-app-store-category.
- Added
Looks good.
On 10/23/2019 7:00 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8223323
[2]
Looks good.
On 10/23/2019 6:59 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8230612
[2]
Hi Alexey,
Looks good.
Thanks,
Alexander
On 10/22/2019 2:14 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- fixes for [3], [4], [5] and [6] bugs.
-
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Removed --mac-app-store-category.
- Added Hello.java test app to support file association on OS X.
- Modified Hello.java to write output file to user
Looks good.
On 10/22/2019 12:34 PM, Andy Herrick wrote:
There really aren't any tests for overridable resources in packages,
the mechanism is only tested by testing the one resource that is
overriddable in app-image build, the app icon.
This the second resources overridable in windows
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html
Line 180: man -> main
Looks good.
On 10/18/2019 7:53 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fixes the case where using runtime-image prevented checking for
no main class being
Looks good.
On 10/17/19 7:03 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8231972
[2]
Looks good.
On 10/16/2019 4:56 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally regression in JPackageCommand class fixed.
- Alexey
[1]
Looks good.
On 10/15/2019 12:13 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally migrated some tests that used the old test helpers to use
the new test
Looks good.
On 10/15/2019 12:27 PM, Andy Herrick wrote:
A long overdue change. Looks good as far as I can see.
Thanks
/Andy
On 10/15/2019 2:48 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Not sure what problem was, but after moving hidden items at same Y
value as non-hidden icons issue was resolved. Also, had to adjust Y
value to
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Patch is based on JDK-8231856 fix.
- Fixed by using URI to escape URLs. URLEncoder.encode() encodes form
data and it will use "+" for space. pkg
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by adding read permissions to all jars during installation.
[1] https://bugs.openjdk.java.net/browse/JDK-8231858
[2]
Hi Andy,
Looks good.
Thanks,
Alexander
On 10/8/2019 3:29 PM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 10/8/2019 6:09 PM, Andy Herrick wrote:
Minor revision after some discussion:
[3]: http://cr.openjdk.java.net/~herrick/8231910/webrev.02
/Andy
On 10/8/2019 3:06 PM, Andy Herrick
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by using correct icon for pkg.
- Added icon for dark theme and it will be called
appName-background-darkAqua.png, for separate customization
Looks good.
On 10/4/2019 12:14 PM, Alexey Semenyuk wrote:
Yes, it is. Sorry, my bad, I didn't notice it. Looks good then!
- Alexey
On 10/4/2019 3:11 PM, Andy Herrick wrote:
isn't what this change in BasicTest in this webrev does ?
It passes on all platforms with Mach 5 builds.
/Andy
On
Looks good.
On 10/3/2019 5:17 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8231850
[2]
r
On 10/2/2019 2:34 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added two signing tests for macOS. One test checks signing app image
and second checks p
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Changed "Java" dir to "app" dir in jpackage app image on macOS.
[1] https://bugs.openjdk.java.net/browse/JDK-8231706
[2]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added two signing tests for macOS. One test checks signing app image
and second checks pkg and dmg.
- These test will not be run if machine is not
Looks good.
On 10/1/19 3:00 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8231721
[2]
Looks good.
On 9/29/2019 1:50 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- Improve jpackage test helpers.
- Implement
/2019 4:07 PM, Alexander Matveev wrote:
Looks good.
Do we really planning to call AppImageFile.get() with different
values? I think removing or fixing is still better to avoid any
potential bugs.
Thanks,
Alexander
On 9/29/2019 1:06 PM, Alexey Semenyuk wrote:
One thing that I just notice i
Looks good.
On 9/29/2019 4:45 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Baseline for review is [3].
[1] https://bugs.openjdk.java.net/browse/JDK-8230974
[2]
Looks good.
On 9/29/2019 3:08 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
The fix adds use of `ldd` command and packaging specific tools to
build list of packages
Looks good.
Do we really planning to call AppImageFile.get() with different values?
I think removing or fixing is still better to avoid any potential bugs.
Thanks,
Alexander
On 9/29/2019 1:06 PM, Alexey Semenyuk wrote:
One thing that I just notice is that you introduced caching in
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Removed --identifier option, since it only usage is to specify
identifier when generating pkg on macOS and as default value for
Looks good.
On 9/26/2019 5:15 AM, Kevin Rushforth wrote:
Looks good.
-- Kevin
On 9/26/2019 3:57 AM, Andy Herrick wrote:
Revised [3] to remove the change to CreateJmods.gmk since it is not
needed as the module will be resolved because it provides an
implementation of ToolProvider.
[3]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Main class from module will be used if main class is not specified in
CLI. Main class from CLI will be preferred over main class specified in
Hi Andy,
Looks good.
Do you think it would be better to write CLI arguments in some internal
format instead of just raw dump? It might be better in case if we plan
to change CLI between versions and at same time supporting generation of
installers for app image using different jpackage
Looks good.
On 9/24/2019 11:08 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 9/24/2019 1:24 PM, Andy Herrick wrote:
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings
with the CLIOptions id's, and adds unit
Looks good.
On 9/23/2019 4:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- remove --linux-deb-copyright option.
- add tests to verify that placing
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8231279/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java.frames.html
Maybe add new line between 41-42 and remove 43 to align import static
with other static imports.
Looks fine.
Thanks,
Alexander
On
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Version from main module (if exist) will be used as --app-version if
--app-version is not specified.
[1]
Looks good.
On 9/20/2019 4:57 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- directory layout of Linux app image adjusted to better comply with
Linux FSH.
that you do not see any
scrollbars in the normal case.
Will it be possible to provide your own image to be used by the
packager? Some people like
to do some branding here.
Michael
Am 18.09.19 um 23:14 schrieb Alexander Matveev:
Hi Michael,
I did screenshot with show hidden files enabled in Finder
Hi Alexey,
Looks good.
Thanks,
Alexander
On 9/18/2019 8:23 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- Move common deb and rpm packaging code in the
are shown.
Thanks,
Alexander
On 9/17/2019 11:52 PM, Michael Paus wrote:
Hi,
why are there scrollbars in the image on JBS? When you normally
open a DMG you do not get scrollbars.
Michael
Message: 6
Date: Tue, 17 Sep 2019 19:42:01 -0700
From: Alexander Matveev
To: core-libs-dev
Subject: RFR: JDK
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added link to "/Application" folder to DMG for drag and drop app to
this folder.
- Added background image with arrow pointing from App icon to
run the
tests in a mode when they verify packages are properly installed.
- Alexey
On 9/12/2019 9:34 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Renamed "
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Renamed "--output" to "--dest" and made it optional with default to ".".
[1] https://bugs.openjdk.java.net/browse/JDK-8230521
[2]
gn", "--verify",
file.toString());
---
- Alexey
On 9/11/2019 11:53 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Binaries in runtime and Frameworks will not be si
Looks good.
Thanks,
Alexander
On 9/12/2019 4:11 AM, Andy Herrick wrote:
Revised with webrev.03.
Changed SimplePackageTest instructions as suggested and added
LinuxDebBundler.java to file list (double checked file list used to
create webrev contains all changed files).
/ANdy
On 9/11/2019
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Binaries in runtime and Frameworks will not be signed directly using
user provided certificate.
- libapplauncher.dylib will be signed with user
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Error mentioned in bug report was due to missing Xcode when running
SetFile. Fixed by not running SetFile if Xcode is not available. This
tool used
Looks good.
On 9/11/2019 6:07 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
1.) adds the new option --linux-shortcut, and now only creates a
shortcut on linux
Hi Andy,
http://cr.openjdk.java.net/~herrick/8230519/webrev.02/test/jdk/tools/jpackage/share/ErrorTest.java.frames.html
Line 90: Add space before ARG2.
Looks good.
Thanks,
Alexander
On 9/9/2019 3:25 PM, Andy Herrick wrote:
Please review the updated jpackage fix for bug [1] at [3].
Hi Andy,
http://cr.openjdk.java.net/~herrick/8230522/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties.frames.html
Line 44 "mp." -> "map"
Looks good.
On 9/9/2019 10:14 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- reworked jpackage tests that produce platform specific packages to
get rid of code
Hi Andrey,
Writing to /Application on macOS or "Program Files" on Windows requires
admin privileges. It is very uncommon when application stores temp files
or setting files modifiable by user inside installation folder. For temp
files I will recommend to use system provided temp folder. For
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
1) This file is not used and was removed.
2) This file was removed due to JDK-8221333.
3) Removed unused services code.
[1]
Hi Alexey,
Looks good. Any plans to convert all tests to use new helper classes?
Thanks,
Alexander
On 8/30/2019 2:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
-
Looks good.
Thanks,
Alexander
On 8/29/2019 11:18 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8230152
[2]
Looks good.
Thanks,
Alexander
On 8/27/2019 4:25 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8224833
[2]
Looks good.
Thanks,
Alexander
On 8/27/2019 1:13 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix implementation of --linux-app-release CLI option for Debian
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by statically linking with runtime.
[1] https://bugs.openjdk.java.net/browse/JDK-8229788
[2]
Looks good.
Thanks,
Alexander
On 8/19/2019 2:16 PM, Kevin Rushforth wrote:
OK. Looks good.
-- Kevin
On 8/19/2019 2:09 PM, Andy Herrick wrote:
On 8/19/19 4:53 PM, Kevin Rushforth wrote:
The following will take the last in the list of extensions and use
that:
+ entryName =
Looks good.
Thanks,
Alexander
On 8/19/2019 9:56 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control
Looks good.
Thanks,
Alexander
On 8/16/2019 1:36 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229791
[2]
Looks good.
Is it possible to have test for this new option? If yes, then as part of
this fix or as separate issue should be fine.
Thanks,
Alexander
On 8/16/2019 11:28 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch
Looks good.
Thanks,
Alexander
On 8/16/2019 12:12 PM, Alexey Semenyuk wrote:
Makes sense. Looks good then.
- Alexey
On 8/16/2019 3:08 PM, Andy Herrick wrote:
On 8/16/2019 2:26 PM, Alexey Semenyuk wrote:
Andy,
I think we want this change in all Windows jtreg tests as they all
use this
Looks good.
Thanks,
Alexander
On 8/15/2019 1:50 PM, Andy Herrick wrote:
ok - revised [3] to restore the second trace statement (now
Log.verbose())
[3]: http://cr.openjdk.java.net/~herrick/8224594/webrev.02/
/Andy
On 8/15/2019 3:40 PM, Andy Herrick wrote:
The first of these doesn't convey
Looks good and probably lets restore removed log statements.
On 8/15/2019 12:09 PM, Alexey Semenyuk wrote:
Andy,
What is the reason to remove log statements in
301 - 400 of 501 matches
Mail list logo
