On Mon, 21 Mar 2022 10:45:27 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] -
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote:
> The ObjectInputStream.GetField method `get(String name, Object val)` should
> have been throwing
> a ClassNotFoundException if the class was not found. Instead the
> implementation was returning null.
> A design error does not allow the
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev wrote:
> See the [integration
> commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
> ) for JDK-8245095. It reintroduced
On Thu, 14 Oct 2021 14:44:34 GMT, Julia Boes wrote:
> sun.reflect.ReflectionFactory provides MethodHandles for the various
> serialization methods, it is a critical internal API in the jdk.unsupported
> module (see JEP 260 [1]) that may be used by 3rd party serialization
&g
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class wh
On Mon, 18 Oct 2021 11:38:22 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 24 commits:
>>
>> - Minor rewording of bind address output
>> - Merge bra
On Thu, 14 Oct 2021 15:04:23 GMT, Daniel Fuchs wrote:
> The update on the throws declaration in the test is a bit of a distraction.
Right, should have mentioned that the only relevant change _in the test_ is on
line 253, the rest is cleanup.
-
PR:
sun.reflect.ReflectionFactory provides MethodHandles for the various
serialization methods, it is a critical internal API in the jdk.unsupported
module (see JEP 260 [1]) that may be used by 3rd party serialization libraries.
One of these serialization methods is readObjectNoData [2]:
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 24 commits:
- Minor rewording of bind address output
- Mer
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
update output for all interfaces
-
Changes:
- all: htt
On Tue, 28 Sep 2021 10:30:21 GMT, Bernd Eckenfels
wrote:
> * For all interfaces use "-b 0.0.0.0" (IPv4) or "-b ::" (IPv6)
>
> Instead of:
>
> * For 0.0.0.0 (all interfaces) use -b 0.0.0.0 or -b ::0
>
> In the usage?
>
> (I think ?::? is canon?)
Good point, "::" is recommended, e.g. in
On Tue, 28 Sep 2021 10:08:29 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 20 commits:
- use ipv4/ipv6 specific loopback address and add a
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote:
> Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is
> common default for Apache httpd [1], Ngnix [2], the Python web server [3].
> This being said, I want to make sure we're taking the right decision here so
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with two additional
commits since the last revision:
- change default bind address from anylocal to loopback
- address PR com
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into simpleserver
>> - Merge
On Tue, 21 Sep 2021 16:18:54 GMT, Daniel Fuchs wrote:
>> The problem I was referring to was not about printing to the console. I
>> hadn't thought about that, I agree the default locale should be used there.
>> I was referring to `Last-modified` HTTP headers with a non-English date
>> value,
On Mon, 20 Sep 2021 16:16:10 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java
>> line 340:
>>
>>> 338: }
>>> 339: }
>>> 340: return false;
>>
>> This will start checking from the root of
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' into simpleserver
- Merg
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 12 commits:
- Merge branch 'master' into simpleserver
- check
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an i
On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> correct path handling
>
> src/jdk.httpserver/share/classes/modu
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
correct path handling
-
Changes:
- all: https://git.openjd
On Wed, 15 Sep 2021 03:14:04 GMT, Jaikiran Pai wrote:
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
> Thank you Florent, I wasn't aware of that.
related PR for reference:
itionally, a small API is introduced for programmatic creation and
> customization.
>
> Testing: tier1-3.
Julia Boes has updated the pull request incrementally with three additional
commits since the last revision:
- small spec rewording
- add module main class to symbolgen
On Tue, 14 Sep 2021 15:56:28 GMT, Jim Laskey wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Wed, 15 Sep 2021 07:49:38 GMT, Michael McMahon wrote:
>> Or maybe - which would be more accurate:
>>
>>
>> with the given {@code statusCode} and the body bytes' length (or {@code -1}
>> if the body is empty).
>
> I agree with your second suggestion. It's better not to refer to the
>
On Tue, 14 Sep 2021 16:45:08 GMT, Daniel Fuchs wrote:
>> Just a rewording, maybe.
>
> Hmm... Maye that should be "The response headers *are sent*". The non-obvious
> technical details is that the response headers are sent before the body - as
> soon as you call `sendResponseHeaders`. The link
On Tue, 14 Sep 2021 13:38:27 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line
>> 106:
>>
>>> 104: var h = headers.entrySet().stream()
>>> 105: .collect(Collectors.toUnmodifiableMap(
>>> 106:
On Tue, 14 Sep 2021 13:47:48 GMT, Andrey Turbanov
wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose
On Tue, 14 Sep 2021 15:42:06 GMT, Jaikiran Pai wrote:
>> src/java.base/windows/classes/sun/net/www/content-types.properties line 30:
>>
>>> 28: application/octet-stream: \
>>> 29: description=Generic Binary Stream;\
>>> 30:
This change implements a simple web server that can be run on the command-line
with `java -m jdk.httpserver`.
This is facilitated by adding an entry point for the `jdk.httpserver` module,
an implementation class whose main method is run when the above command is
executed. This is the first
On Wed, 28 Jul 2021 17:23:51 GMT, Emmanuel Bourg
wrote:
>> @ebourg for future PRs please do not force push after the PR is out for
>> review. Just push incremental commits normally. The Skara tooling will
>> squash them all into a single commit.
>
> @kevinrushforth I'll do that, thank you for
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg
wrote:
> This PR fixes the following spelling errors:
>
> choosen -> chosen
> commad -> command
> hiearchy -> hierarchy
> leagacy -> legacy
> minium -> minimum
> subsytem -> subsystem
> unamed -> unnamed
I'm happy to sponsor this
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote:
> In the methods in question, `RejectedExecutionException` is an expected
> exception that was previously unhandled (it is a `RuntimeException`, not a
> subclass of `ExecutionException`). This change adds
> `RejectedExecut
On Wed, 16 Jun 2021 10:28:11 GMT, Pavel Rappo wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix copyright year
>
> test/jdk/java/util/concurrent/forkjoin/AsyncShutdownNowInvokeAny
> In the methods in question, `RejectedExecutionException` is an expected
> exception that was previously unhandled (it is a `RuntimeException`, not a
> subclass of `ExecutionException`). This change adds
> `RejectedExecutionException` to the existing catch clause.
Julia Boes
In the methods in question, `RejectedExecutionException` is an expected
exception that was previously unhandled (it is a `RuntimeException`, not a
subclass of `ExecutionException`). This change adds
`RejectedExecutionException` to the existing catch clause.
-
Commit messages:
-
On Thu, 18 Feb 2021 07:12:34 GMT, Andrey Turbanov
wrote:
>> Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall -
>> have they been addressed?
>> https://github.com/openjdk/jdk/pull/1853#discussion_r572815422
>>
On Thu, 18 Feb 2021 07:12:34 GMT, Andrey Turbanov
wrote:
>> Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall -
>> have they been addressed?
>> https://github.com/openjdk/jdk/pull/1853#discussion_r572815422
>>
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes wrote:
> This change removes some instances of superfluous boxing in
> java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.
This pull request has now been integrated.
Changeset: e9d7c07b
Author: Julia Boes
URL:
This change removes some instances of superfluous boxing in
java.io.ObjectStreamClass.
Testing: tier 1-3 all clear.
-
Commit messages:
- remove superfluous boxing
Changes: https://git.openjdk.java.net/jdk/pull/2641/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2641=00
On Thu, 18 Feb 2021 07:12:34 GMT, Andrey Turbanov
wrote:
>> Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall -
>> have they been addressed?
>> https://github.com/openjdk/jdk/pull/1853#discussion_r572815422
>>
On Sun, 20 Dec 2020 17:05:21 GMT, Andrey Turbanov
wrote:
> 8080272 Refactor I/O stream copying to use
> InputStream.transferTo/readAllBytes and Files.copy
Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall - have
they been addressed?
On Sat, 13 Feb 2021 10:56:32 GMT, Andrey Turbanov
wrote:
>> This fours tests pass without problems, when I run them separately.
>>
>> ## sun/security/tools/jarsigner/TimestampCheck.java
>> ## sun/security/tools/keytool/DefaultOptions.java
>> ##
On Mon, 8 Feb 2021 14:40:16 GMT, Weijun Wang wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuario
>
On Mon, 21 Dec 2020 08:19:08 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
>
On Wed, 16 Dec 2020 15:17:57 GMT, Julia Boes wrote:
> Another change to align with upcoming changes in the JLS terminology ('type'
> versus 'class and interface').
>
> For background see:
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.
he type of a variable or an expression),
> the change in terminology is mostly not applicable. For easier reviewing,
> paragraphs will only be reflowed before the PR is integrated.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
ref
Another change to align with upcoming changes in the JLS terminology ('type'
versus 'class and interface').
For background see:
https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
Where a class models types (as in the type of a variable or an expression),
On Tue, 15 Dec 2020 19:28:15 GMT, Julia Boes wrote:
> This change is in line with upcoming changes in the JLS terminology ('type'
> versus 'class and interface').
>
> For background see:
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
ly be reflowed before the PR is
> integrated.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
reflow paragraphs
-
Changes:
- all: https://git.openjdk.java.net/jdk16/pull/27/files
- new: https://git.openjdk.java.net/jdk1
This change is in line with upcoming changes in the JLS terminology ('type'
versus 'class and interface').
For background see:
https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
For easier reviewing, paragraphs will only be reflowed before the PR is
On Mon, 7 Dec 2020 17:31:34 GMT, Julia Boes wrote:
> This change applies a stricter semantic distinction of 'type' versus 'class
> and interface'. This is based on the JLS changes described in the "Consistent
> Class and Interface Terminology" document:
> https://
s-terminology-jls.html.
>
> The following rules were applied:
> - 'class' and/or 'interface' are used when referring to the class/interface
> itself
> - 'type' is used when referring to the type of a variable or expression
Julia Boes has updated the pull request incrementally with
On Mon, 7 Dec 2020 18:22:33 GMT, Daniel Fuchs wrote:
>> This change applies a stricter semantic distinction of 'type' versus 'class
>> and interface'. This is based on the JLS changes described in the
>> "Consistent Class and Interface Terminology" document:
>>
This change applies a stricter semantic distinction of 'type' versus 'class and
interface'. This is based on the JLS changes described in the "Consistent Class
and Interface Terminology" document:
https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
The
On Wed, 2 Dec 2020 14:51:23 GMT, Julia Boes wrote:
> Now that the changes for record serialization are integrated into the Java
> Object Serialization Specification, this change updates the serialization
> javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
> java
On Thu, 3 Dec 2020 10:39:05 GMT, Julia Boes wrote:
> Records exit preview in JDK 16. This change removes preview related
> suppression warnings in some source files and removes the '--enable-preview'
> option for compilation and execution of some tests that use record classes.
Records exit preview in JDK 16. This change removes preview related suppression
warnings in some source files and removes the '--enable-preview' option for
compilation and execution of some tests that use record classes.
-
Commit messages:
- remove --enable-preview in tests
-
Now that the changes for record serialization are integrated into the Java
Object Serialization Specification, this change updates the serialization
javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
java.lang.Record. Additionally, the suppression of preview related warnings is
Hi Vipin,
I'm happy to sponsor this and any related changes.
Let me know if you need help with anything.
Best,
Julia
On 26/08/2020 17:55, Daniel Fuchs wrote:
Hi Vipin,
This looks good to me.
Make sure to generate the API docs locally and eyeball them to
double check that nothing is amiss.
Hi,
The two changes below still need to be reviewed. Any takers?
Cheers,
Julia
---
old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14
23:55:41.953638446 +0530
+++
Hi Vipin,
Thanks for providing this fix, I'm happy to sponsor your change. To
complete the review, we still need someone to green light the remaining
changes below. I'm looping in net-dev and security-dev to have a look.
Bug: https://bugs.openjdk.java.net/browse/JDK-8251542
Webrev:
All(aEntrySet));
+ assertTrue(bEntrySet.isEmpty());
+ assertEquals(aEntrySet.size(), 2);
+
+ aEntrySet.clear();
+ assertTrue(aEntrySet.isEmpty());
+ }
+
+ @Test
+ public void testEntrySetExceptionWhenAdd() {
+ Properties a = new Properties();
+ a.setProperty(&quo
Hi Anthony,
Since short-circuiting sounds similar to a Subscriber cancelling its
Subscription, I believe it might be worthwhile to consider the Flow API.
If the argument would be a `Flow.Processor`, then the
implementation would publish instances of T to it, subscribe to
receive instances of
Hi Tagir,
By the way, the proposed API allows no possibility to short-circuit
the pusher. So if mapMulti produces many elements and short-circuiting
terminal operation like anyMatch finds the match, it won't stop the
pusher from pushing. Have you considered to use
BiConsumer, T>, so Stream API
Hi,
Thanks for the feedback so far. We'll get back on the suggested
implementation and signature changes individually.
Regarding the naming, Paul's suggestion mapAccept seems favorable. This
being said, we'll pause the naming discussion for now and will resume it
once all other questions
Hi Yu,
Just to confirm, for
src/java.base/share/classes/java/util/Properties.java the copyright
should be updated as :
+ * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights
Because 1995 was the year when the file was added, while 2020 when
this change is made. Correct me
Hi Yu,
diff -r 216c6baa0564 -r 09736e9e4c38
src/java.base/share/classes/java/util/Properties.java
--- a/src/java.base/share/classes/java/util/Properties.java Sat Jun 20
15:11:19 2020 +0800
+++ b/src/java.base/share/classes/java/util/Properties.java Sat Jun 20
22:27:57 2020 +0800
@@ -1,5 +1,5
Hi Yu Li,
The copyright year of Properties.java needs to be updated to 2020.
Otherwise looks good to me!
Cheers,
Julia
Hi Yu Li,
I'm happy to sponsor your fix once it's reviewed. Could you just confirm
that you have signed the Oracle Contributor Agreement?
https://www.oracle.com/technetwork/community/oca-486395.html
Cheers,
Julia
On 30/05/2020 21:00, Rob Spoor wrote:
There's still a little regression there
Hi,
This test-only RFR proposes a tool for timeout testing for the JDK test
library. It runs a task in a separate thread and cancels the task if it
doesn't complete within a given timeout. Any exception thrown by the
task is propagated transparently.
TestNG doesn't currently provide this
Hi,
to make it more consistent w/ other tools, I'd move all ifconfig (incl. one on
macOS) to 'net' category, i.e. rename them to net.ifconfig, this will require
also moving all netstat.* on macOS and solaris to 'net' as well. I don't insist
on it, though.
Good point, I made those changes.
Hi,
In the case of test failure, the environment information of 'ifconfig
-a' is already gathered on macOS systems.
The following enhancement allows the same information to be gathered on
Linux, Solaris and Windows systems (in the latter case 'ipconfig /all').
Bug:
:
Hi Julia,
Looks good to me. But can you find out if there exists a test
where this statement is verified?
best regards,
-- daniel
On 26/11/2019 10:46, Julia Boes wrote:
Hi,
This is a minor fix, a word was missing in the javadoc of
Arrays.compare(compare(T[] a, T[] b).
Bug: https
Hi,
This is a minor fix, a word was missing in the javadoc of
Arrays.compare(compare(T[] a, T[] b).
Bug: https://bugs.openjdk.java.net/browse/JDK-8234799
Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234799/webrev.00/
Regards,
Julia
Seems to be a “your milage varies”. I am fine with whatever the
final decision is. However, I do believe the comment above reads
better and aligns the methods better.
FWIW, and as author of many of the lines being changed, I prefer that
comment on a separate from the actual modifiers. I think
Hi Roger, Lance,
Can you recheck the edit to java/lang/invoke/ClassSpecializer.java: 544
I would think the line should be broken at the "..."
* class TopClass { ... * private static final class Species_LLI
extends TopClass {
That's right, there was also a closing brace missing.
Hi,
This cleanup work addresses an outdated coding convention in java.base.
It removes the line break from a class declaration, for example:
public
TypeNameOnNextLine
becomes
public TypeNameOnSameLine
Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234335/webrev.00/
Bug:
Hi Stuart,
Thanks for the review. I made the changes you mentioned.
Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.01/
If you would like to sponsor for this change, that would be great!
Regards,
Julia
On 03/10/2019 18:44, Stuart Marks wrote:
On 10/2/19 2:36 AM, Julia
Hi,
This is a minor fix of the Collector class-level documentation, where
the wrong type declaration was used in a code sample.
While at it, I added a compilation test for all code samples of this
class-level javadoc.
Bug: https://bugs.openjdk.java.net/browse/JDK-8231161
Webrev:
Hi,
Thanks for the review, Lance and Brent!
Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.04/
Regards,
Julia
On 23/09/2019 19:58, Lance Andersen wrote:
Hi Julia,
I made a quick pass and the changes seem OK
On Sep 23, 2019, at 2:17 PM, Julia Boes <mailto:juli
Hi Brent,
I was able to generate a webrev without any missing sdiffs (using gawk
instead of awk with webrev.ksh) and made the requested changes below.
src/java.base/share/classes/java/util/ResourceBundle.java
I believe the tag spanning L2801-2 can be changed:
2801 * Special
available with Skara?
If the later, then it can/should be reported and fixed.
Roger
On 9/20/19 6:22 AM, Julia Boes wrote:
Hi,
Thanks for noticing the glitch in the sdiffs, Naoto and Brent. I see
that there is indeed an issue with the webrev script and I'm looking
into a workaround.
The following
Hi,
Thanks for noticing the glitch in the sdiffs, Naoto and Brent. I see
that there is indeed an issue with the webrev script and I'm looking
into a workaround.
The following classes are affected:
src/java.base/share/classes/java/lang/SecurityManager.java
Hi,
This change replaces the HTML code tag with the equivalent javadoc tag
in the java.base module as such:
foo becomes {@code foo}
Ignored are any code tags that enclose other HTML or javadoc tags or
that contain HTML entities, e.g. character codes.
Examples (after change):
Julia,
It looks fine., thank you for doing this
Best
Lance
On Sep 5, 2019, at 2:28 PM, Julia Boes wrote:
Hi,
Thanks for your comments, Lance and Pavel.
The copyright will be updated before pushing, as Daniel suggested.
To address the tag alignment, I adjusted the replacement from
Hi,
Thanks for your comments, Lance and Pavel.
The copyright will be updated before pushing, as Daniel suggested.
To address the tag alignment, I adjusted the replacement from
'@exception' -> '@throws' to '@exception' -> 'throws ', where the
added whitespace preserves the original
..this time with the right link!
On 05/09/2019 11:40, Julia Boes wrote:
Hi,
This change replaces all occurrences of the @exception tag in
java.base with the @throws tag. The tags are synonyms but @throws is
the newer preferred option [1].
Bug: https://bugs.openjdk.java.net/browse/JDK
Hi,
This change replaces all occurrences of the @exception tag in java.base
with the @throws tag. The tags are synonyms but @throws is the newer
preferred option [1].
Bug: https://bugs.openjdk.java.net/browse/JDK-8230648
Webrev:
Hi Ivan,
The change of the javadoc was made per Brian's request for consistency
with java.lang.Math, see the description of the bug:
https://bugs.openjdk.java.net/browse/JDK-8229485
Best,
Julia
On 22/08/2019 17:25, Ivan Gerasimov wrote:
Is there a reason to change the text at lines 72-75?
a corresponding
method in Math there is a link in javadoc `@see Math#xxx`.
I think, it makes sense to provide such links for all new methods for
consistency.
With kind regards,
Ivan
On 8/21/19 6:29 AM, Julia Boes wrote:
Hi all,
Thanks for the review. I incorporated the following changes
nd part must be in the synopsis too.
best regards,
-- daniel
On 8/14/19 9:01 AM, Julia Boes wrote:
>
> Hi,
>
> This fix adds decrementExact(), incrementExact(), and negateExact()
to java.lang.StrictMath. The methods were added to java.lang.Math
previously [1] and should have been a
Hi,
This fix adds decrementExact(), incrementExact(), and negateExact() to
java.lang.StrictMath. The methods were added to java.lang.Math
previously [1] and should have been added to java.lang.StrictMath for
consistency.
Bug: https://bugs.openjdk.java.net/browse/JDK-8229485
Webrev:
a
separate issue for that purpose.
Thanks,
Brian
On Aug 13, 2019, at 3:16 AM, Julia Boes <mailto:julia.b...@oracle.com>> wrote:
This is a minor fix of the javadoc in java.lang.Math. The methods
decrementExact(), incrementExact() and negateExact() declare they
throw a Arithmetic
t relevant to the change.
Thanks, Roger
On 8/13/19 9:33 AM, Julia Boes wrote:
Forwarding this thread to the right list!
Forwarded Message
Subject: Re: RFR: 8229337: java.lang.Math class doc should be
adjusted regarding -Exact methods
Date: Tue, 13 Aug 2019 13:51:02
1 - 100 of 101 matches
Mail list logo
